1 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
3 * format.c: Completely rewrite, to achieve better abstraction.
4 Rewrite all references to formats in other files.
6 * format.def: Rewrite and reorganize.
8 * settings.c: Move everything related to custom currency formats
9 into format.[ch], changing them in form, so as to group related
10 code and definitions better. Changed all references to use the
12 (static var decimal) Removed.
13 (static var grouping) Removed.
14 (static var cc) Removed.
15 (get_decimal) Removed.
16 (set_decimal) Removed.
17 (get_grouping) Removed.
18 (set_grouping) Removed.
22 * settings.h: (macro CC_CNT) Removed.
23 (macro CC_WIDTH) Removed.
24 (struct custom_currency) Removed.
26 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
28 * data-in.c (data_in): Use switch statement instead of table, to
29 avoid dependence on the order of the FMT_* enums.
31 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
33 * data-out.c: (num_to_string) Removed, because it was dead code.
35 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
37 * data-in.c (parse_trailer): Fix error message.
39 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
41 * format.c (fmt_is_binary): New function.
43 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
45 * procedure.c procedure.h: Encapsulated the static data into a single
48 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
50 * casefile.c (casereader_read_xfer): Always initialize the case,
51 even on an error condition.
53 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
55 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
56 entire function useless.
58 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
60 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
61 casereader method casereader_clone.
63 * procedure.c pransformations.h: Introduced new type casenum_t
65 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
67 * variable.c: (width_to_bytes) Rephrase code for clarify.
69 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
71 * format.c: (fmt_type_from_string) New function.
72 (fmt_to_string) Include decimals in output if the format has
73 decimals, even if the format type does not. This way, we can
74 accurately reproduce incorrect formats in user output.
75 (check_common_specifier) Make the check for a bad format type an
76 assertion, so we get bug reports if they show up. Fix message.
77 Check for decimal places with a format type that doesn't allow
79 (check_input_specifier) Remove check for FMT_X, which has been
81 (check_output_specifier) Ditto.
83 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
85 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
86 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
87 (enum fmt_parse_flags) Removed.
89 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
91 * casefile.c casefile.h: Converted to an abstract base class.
92 * casefile-private.h fastfile.c fastfile.h: New files.
93 * automake.mk procedure.c scratch-writer.c storage-stream.c
95 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
97 * procedure.c (internal_procedure): Create sink_case with only as
98 many values as the compacted dictionary.
100 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
102 Remove "debugging" code that caused plenty of false positives and
105 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
107 * case.c: Remove all references to `this' member.
109 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
111 Fix link error noted by Jason Stover.
113 * storage-stream.c: Include <assert.h>.
115 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
117 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
118 ALL) and additional underlying system file issues.
120 Thanks to John Darrington for review.
122 First problem: var_hash points to variables not owned by the
123 sys-file-reader, which the caller may free or modify. Use an
124 array of sfm_vars instead, as done earlier (e.g. CVS version
127 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
128 members and remove all code that references it. Add vars, var_cnt
129 members. Remove fix_specials member, which was unused.
130 (struct sfm_var) Remove name member, which was unused.
131 (sfm_close_reader) Free vars member instead of var_hash.
132 (compare_var_shortnames) Removed.
133 (hash_var_shortname) Removed.
134 (sfm_open_reader) Fill out vars array.
135 (compare_var_index) Removed.
136 (sfm_read_case) Use vars instead of var_hash.
138 Second problem: we're confused about when we actually have very
139 long strings, causing us to choose incorrectly between slow path
140 and fast path in sfm_read_case.
142 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
143 have very long strings, not when we have long variable names,
144 which is an unrelated feature.
146 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
148 * variable.h: Move var_set and variable parsing declarations to
149 new header, src/language/lexer/variable-parser.h. Modified lots
150 of files to include the new header.
152 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
154 * value-labels.c (value_to_string): When there's no value label,
155 format the variable according to its print format, instead of
156 always effectively using A or F format.
158 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
160 * casefile.c (casefile_get_random_reader): Nasty hack to get around
163 * format.c: Removed tortological assertion.
165 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
167 Reform string library.
169 * file-name.c (fn_interp_vars): Change interface to take a
170 substring as input. Updated all users.
172 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
174 * format.c (measure_is_valid): Really return false when m >=
177 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
179 Implement random access to casefiles, for use in GUI.
181 * casefile.c: (struct casereader) Add `random', `file_ofs',
182 `buffer_ofs' members.
183 (casefile_get_random_reader) New function.
184 (read_open_file) Break part into new function
185 seek_and_fill_buffer().
186 (fill_buffer) Update buffer_ofs, file_ofs.
187 (casereader_seek) New function.
189 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
191 * settings.c: Added call to i18n{done, init}.
193 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
195 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
198 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
200 * casefile.c: Convert many uses of `int' to `bool'.
202 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
204 * transformations.c (trns_chain_destroy): Destroy chain's trns
205 member, to fix memory leak.
207 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
209 * storage-stream.c (storage_source_decapsulate): Destroy case
210 source to fix memory leak.
212 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
214 * scratch-reader.c (scratch_reader_read_case): Copy into existing
215 case passed as argument instead of initializing the argument as a
216 case. Fixes memory leak that showed up in
217 tests/command/aggregate.sh with scratch files.
219 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
221 * procedure.c (proc_done): Destroy default_dict, to fix memory
224 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
226 Simplify procedure_with_splits().
228 * procedure.c (struct split_aux_data): Removed case_count member.
229 (procedure_with_splits) Don't initialize case_count.
230 (split_procedure_case_func) Check whether prev_case is null
231 instead of case_count.
232 (split_procedure_end_func) Ditto.
234 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
236 * case.c (case_move): Do nothing if dst and src are the same
238 (case_try_create) Merge two similar cases.
239 (case_copy) Unshare only if data must be actually copied.
241 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
243 * data-in.c data-out.c dictionary.c sys-file-reader.c
244 sys-file-writer.c variable.c variable.h: Reworked very long string
245 support for better encapsulation.
247 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
249 * value-labels.c (val_labs_can_set_width): New function.
250 (val_labs_set_width) Clear labels if increasing width to long
252 (val_labs_destroy) Remove unneeded test for null.
254 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
256 * value-labels.h: Remove unneeded dependency on variable.h.
258 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
260 Get rid of `char *c' member in union value, for cleanliness.
262 * value.h: (union value) Remove `c' member.
264 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
266 Make dictionary compacting functions a little more general.
268 * sys-file-writer.c (sfm_open_writer): Use
269 dict_compacting_would_change().
270 (does_dict_need_translation) Removed.
272 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
274 Make dictionary compacting functions a little more general.
276 * dictionary.c (dict_needs_compaction): Rename
277 dict_compacting_would_shrink(). Update all callers.
278 (dict_compacting_would_change) New function.
280 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
282 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
283 inverted return value (!).
285 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
287 Continue reforming procedure execution.
289 * procedure.c: Search and replace "vfm" by "proc". Notably:
290 (static var vfm_source) Rename proc_source. Update all
292 (static var vfm_sink) Rename proc_sink. Update all references.
294 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
296 Continue reforming procedure execution. In this phase, remove
297 PROCESS IF, which was deprecated anyway and can be easily
298 simulated with TEMPORARY followed by SELECT IF.
300 * procedure.c: (open_active_file) Don't call
301 add_process_if_trns().
302 (discard_variables) Get rid of redundant call to
303 proc_cancel_all_transformations().
304 (add_process_if_trns) Removed.
305 (process_if_trns_proc) Removed.
306 (process_if_trns_free) Removed.
308 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
310 Continue reforming procedure execution. In this phase, add
311 `const' to the case passed to procedure()'s callback.
313 Updated all users of procedure() as well.
315 * procedure.c: (struct write_case_data) Add "const" to ccase
316 parameter for case_func member.
317 (procedure) Add "const" to ccase parameter for proc_func
319 (multipass_case_func) Make ccase parameter const.
320 (internal_procedure) Add "const" to ccase parameter for case_func
322 (split_procedure_case_func) Make ccase parameter const.
323 (multipass_split_case_func) Make ccase parameter const.
325 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
327 Continue reforming procedure execution. In this phase, get rid of
328 the output code for SPLIT FILE groups in procedure.c, which really
329 shouldn't be doing any output. Move it into the individual
330 procedures instead. This also adds some flexibility.
332 Updated many users of procedure_with_splits() and
333 multipass_procedure_with_splits() to call
334 output_split_file_values() and to deal with increased use of
337 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
338 parameter to begin_func member.
339 (procedure_with_splits) Add "const struct ccase *" parameter to
340 begin_func parameter. Make ccase parameter const in proc_func
342 (split_procedure_case_func) Don't dump split file group. Pass
344 (dump_splits) Moved to language/dictionary/split-file.c as
345 output_split_file_values().
346 (struct multipass_split_aux_data) Add "const struct ccase *"
347 parameter to split_func member.
348 (multipass_procedure_with_splits) Add "const struct ccase *"
349 parameter to split_func parameter.
350 (multipass_split_case_func) Save new SPLIT FILE case before
352 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
354 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
356 Continue reforming procedure execution. Change
357 internal_procedure() so that it calls open_active_file() and
358 close_active_file(), which isolates most of the actual procedure
361 * procedure.c: (struct write_case_data) Rename `proc_func' member
362 to `case_func' and update all references.
363 (procedure) Rewrite as one-line wrapper around
364 internal_procedure().
365 (struct multipass_aux_data) New.
366 (multipass_callback) Renamed multipass_case_func(). Use struct
367 multipass_aux_data as auxiliary data.
368 (multipass_end_func) New function.
369 (multipass_procedure) Rewrite as wrapper for internal_procedure()
370 that uses multipass_case_func, multipass_end_func.
371 (internal_procedure) Add `end_func' argument. Move optimization
372 of trivial case in here. Move call to open_active_file() and
373 close_active_file() in here. Now assert that vfm_source is
375 (procedure_with_splits_callback) Rename
376 split_procedure_case_func().
377 (split_procedure_end_func) New function.
378 (multipass_split_callback) Rename multipass_split_case_func.
379 (multipass_split_end_func) New function.
380 (discard_variables) No need to test for nonnull vfm_source.
382 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
384 Continue reforming procedure execution. Get rid of unused member.
386 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
388 (write_case) Don't increment cases_analyzed.
390 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
392 Continue reforming procedure execution. In this phase, move
393 procedure.c and procedure.h from src to src/data. Update
394 makefiles and #includes accordingly.
396 * procedure.c: Moved here from src/.
398 * procedure.h: Moved here from src/.
400 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
402 Continue reforming procedure execution. In this phase, get rid of
403 many global variables, consolidating procedure execution in
404 procedure.c. Encapsulate transformations in new "struct
405 trns_chain". Also, change implementation of N OF CASES, FILTER,
406 and PROCESS IF from special cases to transformations.
408 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
411 * dictionary.c: (global variable default_dict) Move to
414 * variable.h: (TRNS_*) Move to transformations.h.
415 (struct transformation) Move to transformations.c.
417 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
419 * sys-file-reader.c: Fixed invalid read problems.
421 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
423 * storage-stream.c: Add missing function comments.
425 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
427 Continue reforming procedure execution. In this phase, add some
428 new, needed functionality to storage-stream.
430 * storage-stream.c: (storage_source_decapsulate) New function.
432 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
434 * variable.c (width_to_bytes): Declarations must precede
435 statements for C90 compliance.
437 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
439 * data-out.c, data-in.c, variable.c, variable.h: New functions
440 copy_mangle and copy_demangle for reading/writing cases; emulates the
441 way SPSS deals with strings > 255 bytes.
443 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
444 subtype 14 needed for strings longer than 255 bytes.
446 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
447 instead of literal values. Also fixed some constness issues.
449 * format.h: Constness
451 * sfm-private.h: Renamed the case_size identifier, since I discovered
452 that SPSS's respect for this variable is very nominal.
454 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
456 Change case limit type from int to size_t.
458 * dictionary.c: (struct dictionary) Change type of case_limit
460 (dict_get_case_limit) Change return type.
461 (dict_set_case_limit) Change parameter type.
463 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
465 * variable.h: (struct variable) Rename `reinit' member as `leave'
466 and invert sense. Fix up all references.
468 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
470 Continue reforming procedure execution. In this phase, break
471 procedure.c into multiple files.
473 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
475 * case-sink.c: New file.
477 * case-sink.h: New file.
479 * case-source.c: New file.
481 * case-source.h: New file.
483 * storage-stream.c: New file.
485 * storage-stream.h: New file.
487 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
489 * variable.h: (struct variable) Remove `init' member and all
490 references to it from other files. It was initialized in several
491 places, but nothing really ever used it for anything worthwhile.
492 Thanks to Jason Stover for pointing out how confusing this
495 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
497 Continue reforming error message support. In this phase, get rid
498 of message "titles" and put the message text in `struct error'.
499 Now `struct error' encapsulates a message more properly.
501 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
502 Format message ourselves.
504 * data-in.c: (vdls_error) Ditto.
506 * por-file-reader.c: (error) Ditto.
508 * sys-file-reader.c: (corrupt_msg) Ditto.
510 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
512 GNU standards require "file name" instead of "filename" in
513 documentation. It's nice for our code to follow the convention
516 * casefile.c: (struct casefile) Rename `filename' member to
517 `file_name'. Updated all references.
519 * file-name.c: [!unix] (struct file_identity) Rename
520 normalized_filename member to normalized_file_name. Updated all
523 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
525 We don't really support anything but Unix-like environments well,
526 so we might as well de-obfuscate by writing directory and path
527 separators explicitly.
529 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
531 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
532 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
534 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
537 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
539 GNU standards require "file name" instead of "filename" in
540 documentation. It's nice for our code to follow the convention
543 * filename.c: Rename to file-name.c.
545 * filename.h: Rename to file-name.h. Update all inclusions.
546 Update header guards.
548 * automake.mk: Update file names.
550 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
552 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
554 (fn_basename) Removed (dead code).
555 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
556 (fn_special_p) Renamed fn_is_special(), all references updated.
557 (fn_exists_p) Renamed fn_exists(), all references updated.
559 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
561 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
562 Also, now it only tilde-expands file names, not paths.
563 (fn_search_path) Tilde-expand one directory at a time.
565 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
567 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
568 get rid of non-Unixlike version of the code, which has probably
570 (fn_prepend_dir) Removed (dead code).
572 * filename.h: (macro DIR_SEPARATOR_STRING) New.
573 (macro PATH_SEPARATOR_STRING) New.
574 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
576 Continue reforming error message support. In this phase, we get
577 rid of VM() and the other msg() support for "verbosity", replacing
578 it by a new function verbose_msg().
580 * filename.c: (fn_search_path) Use verbose_msg() instead of
583 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
585 * sfm-private.h: Get rid of #defines after #error, which makes no
588 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
590 Get rid of our own int32 type in favor of the standard int32_t
593 * sfm-private.h: (int32 macro) Don't define this anymore. Do
596 * sys-file-reader.c: Use int32_t instead of int32 throughout.
598 * sys-file-writer.c: Use int32_t instead of int32 throughout.
600 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
602 Remove ill-considered file routines that are no longer used.
604 * filename.c: (fn_open_ext) Removed.
605 (fn_close_ext) Removed.
607 * filename.h: (struct file_ext) Removed.
609 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
611 * variable.c (var_is_valid_name): Move declarations before code
614 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
616 * filename.ch (fn_interp_vars): Fixed small buglet.
618 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
620 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
621 so as to modify the string inline. Thus makeing it easier to
622 destroy the results when no longer needed.
624 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
626 * category.c (cat_stored_values_destroy): Fixed memory leak.
628 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
630 Add some missing frees. Thanks to John Darrington for reporting
633 * any-writer.c (any_writer_close): Free writer.
635 * any-reader.c (any_reader_close): Free reader.
637 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
639 * por-file-reader.c: (error) Mark as NO_RETURN.
641 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
643 * settings.c: Changed default value of scompress to true.
645 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
647 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
649 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
652 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
653 here from pref.h.orig.
655 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
657 * sys-file-reader.c: Fixed bug reading compressed files.
659 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
661 * Numerous renames. See src/ChangeLog for details.
663 * Moved files from src directory