1 2007-10-08 Ben Pfaff <blp@gnu.org>
3 Fix bug #21280. Thanks to John Darrington for review.
5 * file-name.c (create_stream): New function.
7 * por-file-writer.c (pfm_open_writer): Use fh_open to open the
8 file handle before creating the file, to ensure that we don't
9 truncate a file that we're reading. Make code easier to read by
12 * sys-file-write.c (sfm_open_writer): Ditto.
14 2007-10-01 Ben Pfaff <blp@gnu.org>
16 Fix bug #21192. Thanks to John Darrington for review.
18 * casereader.c (casereader_read): Decrement case_cnt before
19 calling the casereader's "read" member function, so that we
20 interact properly with lazy_casereader.
22 * datasheet.c: Add regression test for above bug fix.
23 (clone_datasheet): New function.
24 (lazy_callback): New function.
25 (check_datasheet_casereader): New function.
26 (check_datasheet): Check datasheet contents are reported correctly
27 through an ordinary casereader and a lazy casereader.
28 (clone_model): Use clone_datasheet.
30 2007-09-24 Ben Pfaff <blp@gnu.org>
32 Patch #6210. Reviewed by John Darrington.
33 * settings.c: Drop "long view", which is not needed any longer.
34 (static var long_view): Removed.
35 (force_long_view): Removed.
36 (get_viewwidth): Removed.
37 (init_viewport): Removed long_view reference.
39 2007-09-19 John Darrington <john@darrington.wattle.id.au>
41 * settings.c settings.h: Changed viewport's length and width to be
42 owned by the user interface which uses the data library. This allows
43 better abstraction, and makes dynamically adjustable dimensions easier.
45 2007-09-18 Ben Pfaff <blp@gnu.org>
47 * procedure.c (proc_extract_active_file_data): New function.
49 * lazy-casereader.h: New file.
51 * lazy-casereader.c: New file.
53 * casereader.c (casereader_dynamic_cast): New function.
55 2007-09-14 Ben Pfaff <blp@gnu.org>
57 * dictionary.c (dict_clone): Copy case indexes from cloned
58 dictionary. Fixes bug #21061. Reviewed by John Darrington.
60 2007-09-13 John Darrington <john@darrington.wattle.id.au>
62 * value.c value.h (create_value): New function.
64 2007-09-12 Ben Pfaff <blp@gnu.org>
66 Make it clear that translator casereader and casewriter translate
67 functions are supposed to destroy their input case.
69 * casereader-translator.c (struct casereader_translator): Change
70 input case parameter of translate member function from const
71 struct ccase * to struct ccase *.
72 (casereader_create_translator): Ditto, for translate parameter.
74 * casewriter-translator.c (struct casewriter_translator): Ditto.
75 (casewriter_create_translator): Ditto.
77 2007-08-27 John Darrington <john@darrington.wattle.id.au>
79 * sys-file-reader.c (read_display_parameters): Force display width
80 to 8, if the sys file says 0 (like SPSS does).
82 2007-08-12 Ben Pfaff <blp@gnu.org>
84 * dictionary.c (dict_dump): New function.
86 2007-08-12 Ben Pfaff <blp@gnu.org>
88 Drop dict_compactor in favor of using the new struct case_map.
90 * dictionary.c (struct copy_map): Removed.
91 (struct dict_compactor): Removed.
92 (dict_make_compactor): Removed.
93 (dict_compactor_compact): Removed.
94 (dict_compactor_destroy): Removed.
96 * procedure.c (struct data_set): Change `compactor' member to be a
98 (proc_open): Use case_map_to_compact_dict instead of
100 (proc_casereader_read): Use case_map_execute instead of
101 dict_compactor_compact.
102 (proc_commit): Use case_map_destroy instead of
103 dict_compactor_destroy.
105 * scratch-writer.c (struct scratch_writer): Change `compactor'
106 member to be a struct case_map *.
107 (scratch_writer_open): Use case_map_to_compact_dict instead of
109 (scratch_writer_casewriter_write): Use case_map_execute instead of
110 dict_compactor_compact.
112 2007-08-12 Ben Pfaff <blp@gnu.org>
114 * automake.mk: Add case-map.c, case-map.h.
116 * case-map.c: New file.
118 * case-map.h: New file.
120 2007-08-12 Ben Pfaff <blp@gnu.org>
122 * dictionary.c (dict_compact_values): Don't delete scratch
123 variables as well as compacting case indexes. Update all callers.
124 (dict_get_compacted_value_cnt): Rename dict_count_values and
125 change interface. Update all callers.
126 (dict_get_compacted_value_cnt): Remove.
127 (dict_compacting_would_shrink): Remove.
128 (dict_compacting_would_change): Remove.
129 (dict_make_compactor): Add new parameter. Update all callers.
131 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
132 instead of dict_count_values, changing an O(N) operation into
135 2007-08-12 Ben Pfaff <blp@gnu.org>
137 * casereader.c (casereader_read): Don't require cases read by a
138 casereader to be exactly the expected size: as long as they're big
141 2007-08-12 Ben Pfaff <blp@gnu.org>
143 Make casewriters keep track of the number of `union value's in
144 each case. This is useful for two reasons: casewriter_write can
145 then check that the case being written is large enough, and later
146 recipients of the casewriter can determine the size of the case.
148 * casewriter-translator.c (casewriter_create_translator): Add
151 * casewriter.c (struct casewriter): Add value_cnt member.
152 (casewriter_write): Check that the case passed in is big enough.
153 (casewriter_get_value_cnt): New function.
154 (casewriter_create): Add value_cnt parameter.
156 2007-08-09 Ben Pfaff <blp@gnu.org>
158 Fix bug reported by Jason Stover.
159 * settings.c: Move get_termcap_viewport and in particular the
160 #include for <curses.h> to the end of the file. curses.h
161 redefines bool on some systems (e.g. OpenBSD), which causes
162 disagreement between uses of bool before its inclusion and
164 Tested by Jason Stover.
166 2007-07-29 Ben Pfaff <blp@gnu.org>
168 Provisional fix for bug #18692 and bug #20161. Reviewed by John
171 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
172 argument (never "rb" or "wb") because SUSv3 says that only those
173 modes are defined, and glibc in fact rejects other modes.
175 Open portable files with fn_open so that they can be read from
176 pipes. Fix missing fh_close call to go along with fh_open.
177 Report an error if the file close reports an error.
178 * por-file-reader.c (close_reader): New function.
179 (por_file_casereader_destroy): Use close_reader.
180 (pfm_open_reader): Open file with fn_open.
182 2007-07-28 Ben Pfaff <blp@gnu.org>
184 Make PSPP able to read all the portable files I could find on the
185 web. Thanks to John Darrington for review. Bug #17620.
186 * por-file-reader.c (struct pfm_reader): New member `line_length'.
187 (error): Print file offset in hexadecimal.
188 (warning): New function.
189 (advance): Treat lines less than 80 bytes long as padded to 80
191 (pfm_open_reader): Call read_documents if we find an "E" record.
192 (convert_format): Convert invalid formats to the default format
193 instead of aborting reading the file.
194 (read_variables): Rename duplicate variable names instead of
195 aborting reading the file.
196 (read_value_label): Allow string variables of different widths to
197 be assigned value labels in the same record. Replace duplicate
198 value labels instead of aborting.
199 (read_documents): New function.
201 * por-file-writer.c (pfm_open_writer): Call write_documents if the
202 dictionary has documents.
203 (write_documents): New function.
205 2007-07-25 Ben Pfaff <blp@gnu.org>
207 Fix bugs related to bug #17213.
209 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
210 since the former is what config.h has. Include the needed ncurses
212 (static var echo) Rename to `do_echo' because the original name is
213 the same as an ncurses identifier.
214 (get_termcap_viewport) Use error instead of msg.
216 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
217 (fn_close): Don't close stdin, stdout, stderr.
219 2007-07-26 John Darrington <john@darrington.wattle.id.au>
221 * procedure.c procedure.h: Added callbacks which get invoked whenever
222 a dataset's transformation chain changes.
224 2007-07-24 Ben Pfaff <blp@gnu.org>
227 * sys-file-writer.c (write_variable_display_parameters): Use new
228 var_default_display_width function to choose display width of
229 segments after the first one in a given variable.
230 * variable.c (var_create): Use var_default_display_width to pick
231 new variable's display width.
232 (var_default_display_width): New function.
233 Reviewed by John Darrington.
235 2007-07-24 Ben Pfaff <blp@gnu.org>
238 * por-file-writer.c (write_variables): Write weight variable.
239 Reviewed by John Darrington.
241 2007-07-23 Ben Pfaff <blp@gnu.org>
243 Improvements to system file reader and writer.
245 First, move all detailed knowledge of very long strings into
246 sys-file-private.[ch], so that this nasty stuff can be isolated.
248 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
249 (EFFECTIVE_VLS_CHUNK): New macro.
250 (min_int): New function.
251 (max_int): New function.
252 (sfm_width_to_bytes): Rewrite.
253 (sfm_width_to_octs): New function.
254 (sfm_segment_alloc_width): New function.
255 (sfm_segment_alloc_bytes): New function.
256 (sfm_segment_used_bytes): New function.
257 (sfm_segment_offset): New function.
258 (sfm_segment_effective_offset): New function.
259 (sfm_dictionary_to_sfm_vars): New function.
261 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
262 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
263 (struct sfm_var): New structure.
265 Next, improvements to the system file reader.
267 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
268 type casenumber. Added `version_major', `version_minor',
271 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
272 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
273 Change `case_cnt' to type casenumber. Removed `has_vls'.
274 (struct sfm_var): Removed.
275 (sfm_open_reader): Don't warn on wrong case size if the file was
276 written by SPSS 13, which tends to get it wrong. Use
277 sfm_dictionary_to_sfm_vars.
278 (read_header): Always output system file info.
279 (read_variable_record): Simplify code for reading missing values.
280 (read_machine_int32_info): Save version numbers from system file
281 into info struct passed as new argument.
282 (read_long_string_map): Restructured to use new sys-file-private
284 (read_value_labels): Use size_overflow_p.
285 (sys_file_casereader_read): Get rid of distinction between fast
286 and slow paths. Use information provided by sys-file-primate's
287 struct sfm_var to simplify code.
288 (skip_whole_strings): New function.
289 (read_int32): Renamed read_int. Changed return value to int.
291 (read_flt64): Renamed read_float. Changed return value to
292 double. Updated all callers.
293 (int32_to_native): Removed. Changed callers to use
295 (flt64_to_double): Removed. Changed callers to use float_convert.
297 Finally, get rid of int32, flt64 terminology and types in system
298 file writer. The former wasn't very useful since a POSIX "int"
299 can hold the whole range of int32 and we generally didn't have a
300 need for it to be exactly-32-bits, just at-least-32-bits. The
301 latter was inconvenient because we had to assume that it could be
302 different from double and thereby convert special values SYSMIS,
303 HIGHEST, LOWEST to and from it in multiple places. Instead, now
304 we just use "int" and "double" in most places, and do conversions,
305 if necessary, very close to where we do I/O. This change meant
306 that the writer code couldn't represent records in the file as C
307 structs any longer, but that's no great loss. The code actually
308 seems to be more readable without them.
310 Simplify the compression buffering code: only buffer as much as
311 necessary, which is no more than eight 8-byte units at any given
314 * sys-file-writer.c (typedef flt64): Removed.
315 (macro second_lowest_flt64): Removed.
316 (struct sysfile_header): Removed.
317 (struct sysfile_variable): Removed.
318 (struct sfm_writer): Removed `needs_translation', `has_vls',
319 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
320 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
321 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
322 compression buffering by `opcodes', `opcode_cnt', `data',
323 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
324 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
325 data writer functions instead of structures.
326 (calc_oct_idx): New function.
327 (write_header): Use simple data writer functions instead of
329 (write_format_spec): Renamed write_format. New argument.
330 (write_variable_continuation_records): New function.
331 (write_variable): Use simple data writer functions instead of
332 structures. Use write_variable_continuation_records. Write
333 entire very long string instead of requiring caller to understand
335 (write_value_labels): Use simple data writer functions instead of
337 (write_documents): Ditto.
338 (write_variable_display_parameters): Use sys-file-private
339 functions to simplify. Use simple data writer functions instead
341 (write_vls_length_table): Use simple data writer functions instead
343 (write_longvar_table): Ditto.
344 (write_rec_7_34): Break into new functions
345 write_integer_info_record, write_float_info_record. Use simple
346 data writer functions instead of structures.
347 (buf_write): Removed.
348 (append_string_max): Removed.
349 (ensure_buf_space): Removed.
350 (sys_file_casewriter_write): Get rid of the distinction between
351 fast and slow paths, which didn't seem to be too useful. Use new
352 functions write_case_uncompressed, write_case_compressed.
353 (put_instruction): Removed.
354 (put_element): Removed.
355 (write_compressed_data): Removed.
356 (close_writer): Use flush_compressed. Only write case count to
357 system file if it will fit in the field.
358 (write_case_compressed): New function.
359 (write_case_uncompressed): New function.
360 (flush_compressed): New function.
361 (put_cmp_opcode): New function.
362 (put_cmp_number): New function.
363 (write_int): New function.
364 (convert_double_to_output_format): New function.
365 (write_float): New function.
366 (write_value): New function.
367 (write_string): New function.
368 (write_bytes): New function.
369 (write_zeros): New function.
370 (write_spaces): New function.
372 Reviewed by John Darrington.
374 2007-07-22 Ben Pfaff <blp@gnu.org>
376 Don't try to write very long strings to portable files. The
377 format does not support it.
379 * por-file-writer.c (MAX_POR_WIDTH): New macro.
380 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
381 (write_format): Add arg to take width to resize format to.
382 (write_value): Limit width of value written to MAX_POR_WIDTH.
383 (write_variables): Limit width of variable and its output formats
385 Reviewed by John Darrington.
387 2007-07-22 Ben Pfaff <blp@gnu.org>
389 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
390 local variable instead of literal 5.
391 Reviewed by John Darrington.
393 2007-07-22 Ben Pfaff <blp@gnu.org>
395 Fix problems with uniqueness of short names in system files with
396 very long string variables. Now a variable may have multiple
399 * automake.mk (src_data_libdata_a_SOURCES): Add new files
400 short-names.c, short-names.h.
402 * dictionary.c (dict_clone): Clone all the short names.
403 (compare_strings): Move into short-names.c.
404 (hash_strings): Ditto.
405 (set_var_short_name_suffix): Ditto.
406 (dict_assign_short_names): Ditto, rename short_names_assign,
407 change to assign all short names.
409 * por-file-writer.c (write_variables): Use short_names_assign
410 instead of dict_assign_short_names.
412 * short-names.c: New file.
414 * short-names.h: New file.
416 * sys-file-private.c (sfm_width_to_segments): New function.
418 * sys-file-reader.c (read_long_var_name_map): Save and restore all
419 the short names, not just the first one.
421 * sys-file-writer.c (cont_var_name): Removed.
422 (sfm_open_writer): Use short_names_assign instead of
423 dict_assign_short_names. Use unique short names assigned by
424 short_names_assign instead of those generated by cont_var_name.
426 * variable.c (struct variable): Remove `short_name' member,
427 replace by `short_names' and `short_name_cnt'.
428 (var_create) Initialize new members.
429 (var_get_short_name_cnt): New function.
430 (var_get_short_name): Now takes an index argument. Changed most
432 (var_set_short_name): Ditto.
433 (var_clear_short_name): Renamed var_clear_short_names, changed to
434 clear all short names.
436 Reviewed by John Darrington.
438 2007-07-22 Ben Pfaff <blp@gnu.org>
440 * variable.c (var_set_width): Use new var_set_width function.
442 * missing-values.c (mv_n_values): Drop assertion, which was not
445 * format.c (fmt_default_for_width): New function.
446 (fmt_resize): New function.
448 Reviewed by John Darrington.
450 2007-07-18 John Darrington <john@darrington.wattle.id.au>
452 * datasheet.c (datasheet_delete_columns): Added assertion to check
453 we're not deleting outside the range of the sheet.
456 * dictionary.c dictionary.h variable.c: Added the ability for string
457 variables to be resized.
459 * vardict.h: Added some prototypes (moved from dictionary.h) as
460 these should only be called by variable.c
463 2007-07-14 John Darrington <john@darrington.wattle.id.au>
465 * sfm-reader.c: Respect case_cnt field in file header.
467 2007-07-01 John Darrington <john@darrington.wattle.id.au>
469 * transformation.c transformation.h (trns_chain_execute): Changed the
470 signature (Patch #6057)
472 2007-06-10 Ben Pfaff <blp@gnu.org>
474 * casereader-filter.c (casereader_filter_destroy): Make sure to
475 write all the remaining excluded cases to the casewriter, if any.
477 * caseinit.c (init_list_destroy): Rewrite.
478 (init_list_clear): Ditto.
480 * casegrouper.c (casegrouper_get_next_group): Always set *reader
481 to null when returning false.
483 2007-06-06 Ben Pfaff <blp@gnu.org>
485 Actually implement the new procedure code and adapt all of its
486 clients to match. Also adapt all of the other case sources and
487 sinks in the tree and their clients to use the
488 casereader/casewriter infrastructure.
490 * automake.mk: Add and remove files.
492 * any-reader.c: Change into a casereader.
493 * por-file-reader.c: Ditto.
494 * scratch-reader.c: Ditto.
495 * sys-file-reader.c: Ditto.
497 * any-writer.c: Change into a casewriter.
498 * por-file-writer.c: Ditto.
499 * scratch-writer.c: Ditto.
500 * sys-file-writer.c: Ditto.
502 * procedure.c: Change to use casereader, casewriter, caseinit, and
503 other new infrastructure.
505 * scratch-handle.c: Adapt to new infrastructure.
507 * case-sink.c: Removed, now dead code.
508 * case-sink.h: Ditto.
509 * case-source.c: Ditto.
510 * case-source.h: Ditto.
511 * casefile-factory.c: Ditto.
512 * casefile-private.h: Ditto.
515 * casefilter.c: Ditto.
516 * casefilter.h: Ditto.
519 * fastfile-factory.c: Ditto.
520 * fastfile-factory.h: Ditto.
521 * storage-stream.c: Ditto.
522 * storage-stream.h: Ditto.
524 2007-06-06 Ben Pfaff <blp@gnu.org>
528 * automake.mk: Add new files.
530 * datasheet.c: New file.
532 * datasheet.h: New file.
534 2007-06-06 Ben Pfaff <blp@gnu.org>
536 Until now, the procedure code has provided a case to the
537 case_source, which has filled in the data values that come from
538 the active file. "Left" data values that don't come from the
539 active file naturally stay the same from case to case, because the
540 procedure code keeps using that same case.
542 One of the compromises that comes with the new procedure code is
543 that the active file allocates and provides its own case, which
544 the procedure code then has to resize to provide room for any
545 other variables that should go in the case and then fill in the
546 values of "left" variables. Then, when we're done with that case,
547 we have to save the values of "left" variables to copy into the
548 next case read from the active file.
550 The caseinit code helps with this.
552 * automake.mk: Add new files.
554 * caseinit.c: New file.
556 * caseinit.h: New file.
558 2007-06-06 Ben Pfaff <blp@gnu.org>
560 * value.h (value_cnt_from_width): New function.
562 * variable.c (var_get_value_cnt): Use new function.
564 2007-06-06 Ben Pfaff <blp@gnu.org>
566 Add casegrouper, to allow cases read from a given casereader to be
567 broken into groups, each of which has its own casereader.
568 Generally cases are grouped based on having equal values for some
571 * automake.mk: Add new files.
573 * casegrouper.c: New file.
575 * casegrouper.h: New file.
577 2007-06-06 Ben Pfaff <blp@gnu.org>
579 Add interface to lexicographical ordering of cases.
581 * automake.mk: Add new files.
583 * case-ordering.c: New file.
585 * case-ordering.h: New file.
587 2007-06-06 Ben Pfaff <blp@gnu.org>
589 Add casereaders and casewriters, the basis of the new data processing
590 implementation. A casereader is a uniform interface to reading cases
591 from a data source; a casewriter is a uniform interface to writing
592 cases to a data sink.
594 * automake.mk: Add new files.
596 * casereader-filter.c: New file.
598 * casereader-provider.h: New file.
600 * casereader-translator.c: New file.
602 * casereader.c: New file.
604 * casereader.h: New file.
606 * casewriter-provider.h: New file.
608 * casewriter-translator.c: New file.
610 * casewriter.c: New file.
612 * casewriter.h: New file.
614 2007-06-06 Ben Pfaff <blp@gnu.org>
616 "casewindow" data structure that extends the deque (from libpspp)
617 of cases with the ability to dump cases to disk if we get too many
620 * automake.mk: Add new files.
622 * casewindow.c: New file.
624 * casewindow.h: New file.
626 2007-06-06 Ben Pfaff <blp@gnu.org>
628 sparse_cases data structure that augments a sparse_array of cases
629 with the ability to dump cases to disk if we get too many cases in
632 * automake.mk: Add new files.
634 * sparse-cases.c: New file.
636 * sparse-cases.h: New file.
638 2007-06-06 Ben Pfaff <blp@gnu.org>
640 Adds a low-level on-disk case array data structure.
642 * automake.mk: Add new files.
644 * case-tmpfile.c: New file.
646 * case-tmpfile.h: New file.
648 2007-06-06 Ben Pfaff <blp@gnu.org>
650 In a couple of places we calculate the maximum number of cases to
651 keep in memory based on the user-defined workspace. Enable
652 centralizing the calculation through a new function.
654 * settings.c (get_workspace_cases): New function.
656 2007-06-06 Ben Pfaff <blp@gnu.org>
658 The casenumber type is defined in transformations.h, but case.h is
659 a more sensible place. Move it.
661 * case.h (CASENUMBER_MAX): New macro.
662 (typedef casenumber): Move here, from transformations.h.
664 2007-06-03 Ben Pfaff <blp@gnu.org>
666 Slightly generalize case_to_values and case_from_values functions.
668 * case.c (case_to_values): Rename case_copy_out, change interface.
669 (case_from_values): Rename case_copy_in, change interface.
671 * fastfile.c (fastfilereader_get_next_case): Update caller.
672 (write_case_to_disk): Ditto.
674 2007-06-02 Ben Pfaff <blp@gnu.org>
676 Clean up after a forgotten part of patch #5829.
678 * casedeque.h: Remove unused file.
680 * automake.mk: Remove casedeque.h from sources.
682 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
684 * category.c: Removed redundant #include
686 2007-05-06 Ben Pfaff <blp@gnu.org>
688 Abstract the documents within a dictionary a little better.
689 Thanks to John Darrington for suggestion, initial version, and
692 * dictionary.c (struct dictionary): Change `documents' member from
693 char * to struct string.
694 (dict_clear): Destroy struct string.
695 (dict_get_documents): Convert struct string to char *.
696 (dict_set_documents): Set struct string. Pad to 80-character
698 (dict_clear_documents): New function.
699 (dict_add_document_line): New function.
700 (dict_get_document_line_cnt): New function.
701 (dict_get_document_line): New function.
703 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
705 * sys-file-reader.c (read_documents): Use new document functions.
707 2007-04-19 John Darrington <john@darrington.wattle.id.au>
709 * sys-file-reader.c: When reading a system file which has no
710 long name table, automatically create one where the long names
711 are the lower case versions of the short names.
713 2007-04-22 Ben Pfaff <blp@gnu.org>
715 * dictionary.c (dict_set_split_vars): dict_destroy expects that
716 dict_clear will free most data related to the dictionary.
717 dict_clear does a decent job, except that dict_set_split_vars on
718 some systems won't actually free the dict's "split" member.
719 Instead, it'll allocate a 1-byte region. Fix this.
721 * value.c (value_copy): New function.
722 (value_set_missing): Ditto.
724 2007-04-22 John Darrington <john@darrington.wattle.id.au>
726 * Deleted existing category.h and moved cat-routines.h into
727 category.h Encapsulated struct cat_vals better.
729 2007-04-19 John Darrington <john@darrington.wattle.id.au>
731 * sys-file-reader.c: When reading a system file which has no
732 long name table, automatically create one where the long names
733 are the lower case versions of the short names.
735 2007-04-16 John Darrington <john@darrington.wattle.id.au>
737 * sys-file-reader.c: Some versions of Other Software seem to
738 produce system files with string variables' measure set to
739 zero. We'll assume these are supposed to be nominal variables.
741 2007-03-30 Ben Pfaff <blp@gnu.org>
743 * procedure.c: Adapt to new deque data structure.
745 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
746 Ben Pfaff <blp@gnu.org>
748 * file-name.c: Mingw compatibility fixes.
749 (fn_search_path): Use ISSLASH instead of comparing against '/'
751 (fn_dir_name): Use dir_name from gnulib.
752 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
753 (fn_get_identity): Use GetFullPathName instead of canonicalize
754 from gnulib, because the latter does not fully support
755 Windows-style path names. Use this implementation based on the
756 detected presence of Windows instead of the absence of Unix, since
757 the new implementation is Windows-specific.
758 (fn_compare_file_identities): In Windows implementation, compare
759 names case-insensitively.
761 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
763 * make-file.c: Don't include mkstemp.h, because gnulib now causes
764 <stdlib.h> to have the same effect.
766 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
768 * por-file-reader.c: Add missing _() around messages.
770 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
772 * make-file.c: Include "mkstemp.h", without which linking on
775 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
777 Reduce platform dependence.
779 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
780 Everywhere we using this, we really should have just depended on
781 the shell to expand tildes.
782 (fn_search_path): Simplify, given that we don't do tilde expansion
784 (fn_normalize): Removed. Caller changed to use the canonicalize
786 (fn_get_cwd): Removed. Only user was fn_normalize.
787 (fn_is_absolute): Really only test for absolute names.
788 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
790 (fn_readlink): Removed, as it was only used fn_normalize.
791 (fn_exists): Assume the stat function is available; gnulib does.
792 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
794 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
796 * dictionary.c (dict_create_vector_assert): New function.
798 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
800 * file-name.c (fn_normalize): Correct name of function
801 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
802 for pointing this out.
804 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
806 We are using a single member in struct file_handle, the "name"
807 field, for more than one purpose. When it begins with '"', it's a
808 file name; otherwise, it's a token that can be used to identify
809 it. When that assertion fires, it's because we searched for the
810 name case-sensitively as a file name (so that there was no match),
811 and then we try to insert it case-insensitively as a token, which
812 fails because duplicates aren't allowed.
814 Solution: break the two purposes into two separate fields. This
815 fixes the problem and likely makes the code easier to read too.
817 Fixes bug #18922. Thanks to John Darrington for bug report and
820 * file-handle-def.c (struct file_handle): New `id' member.
821 (fh_from_name): Rename fh_from_id. Update all callers.
822 (create_handle): New `id' parameter. Update all callers.
823 (fh_create_file): Ditto.
824 (fh_get_id): New function.
826 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
828 * case.c (case_is_null): Change return type to bool.
830 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
834 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
835 reference counting to share data. This makes it easy for
836 valgrind, etc. to find accesses to cases that have been destroyed
837 but have been kept around by another user's ref-count. This often
838 happens when the data set is small enough to find in memory; if a
839 bigger data set that would overflow to disk were used, then data
840 corruption would occur.
842 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
846 * case.c (case_unshare): Make it check internally whether the
847 ref_cnt is greater than 1, so that the callers don't have to.
848 Update callers not to check.
850 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
852 Before, I was thinking that I might want to get rid of reference
853 counting at some point. Now, I'm pretty sure that it's here to
854 stay. Thus, because we have to store the value_cnt anyway for
855 reference-counted cases, we might as well expose it to users.
857 * case.c (case_get_value_cnt): New function.
858 (case_resize): Drop OLD_CNT argument. Update all callers. Only
859 resize case if its size actually changed.
861 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
862 instead of peeking inside struct case directly.
863 (casefile_append): Ditto.
865 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
867 Get rid of the inlines for the case functions, which made the
868 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
869 the inlines didn't speed up "make check" at all, which is not a
870 perfect benchmark but seems indicative.)
872 * case.c: Remove #ifdef DEBUGGING...#endif around many function
873 definitions. Remove some assertions on nonnull pointers that were
874 redundant with a pointer dereference soon after in the function.
876 (struct case_data): Move definition here from case.h.
880 (case_data_wr): Ditto.
882 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
884 * automake.mk: Add casedeque.h to sources.
886 * casedeque.h: New file.
888 * procedure.c: (struct dataset) Change lag_count, lag_head,
889 lag_queue member into single struct casedeque member. Update all
890 users to use the casedeque instead.
893 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
895 * procedure.c: Simplify lagged cases interface. Updated all
896 clients--well, the only client--to use the simplified interface.
897 (dataset_n_lag) Removed.
898 (dataset_set_n_lag) Removed.
899 (dataset_need_lag) New function.
901 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
903 * dictionary.c procedure.c: More changes to ensure that callbacks occur
904 whenever appropriate, but only when the dataset/dictionary is in a
907 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
909 * dictionary.c dictionary.h : Added callbacks for change of filter and
910 split variables. Refactored some code to ensure that callbacks get
911 invoked when appropriate.
913 * procedure.c (proc_cancel_temporary_transformations): Make sure that
914 replace_dict callback occurs when permanent_dict replaces the current
917 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
919 * dictionary.c dictionary.h : Added callback for when the weight
920 variable of a dictionary changes.
922 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
924 * dictionary.c dictionary.h : Added replace_source and replace_dict
925 callbacks, and functions to deal with them.
927 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
929 Simplify missing value handling.
931 * missing-values.h (enum mv_class): New type.
932 (enum mv_type): Moved definition into missing-values.c and renamed
933 each MV_* to MVT_*, to distinguish them from the exposed mv_class
934 enums. Updated all uses.
935 (struct missing_values): Changed type of `type' from `enum
936 mv_type' to `int' because the definition is no longer exposed.
938 * missing-values.c (mv_is_value_missing): Add new enum mv_class
939 parameter. Update all callers.
940 (mv_is_num_missing): Ditto.
941 (mv_is_str_missing): Ditto.
942 (mv_is_value_user_missing): Removed. Changed callers to use
944 (mv_is_num_user_missing): Removed. Changed callers to use
946 (mv_is_str_user_missing): Removed. Changed callers to use
948 (mv_is_value_system_missing): Removed. Changed callers to use
950 (mv_set_type): Removed. Changed callers to use mv_clear.
951 (mv_clear): New function.
953 * variable.c (var_is_value_missing): Add new enum mv_class
954 parameter. Update all callers.
955 (var_is_num_missing): Ditto.
956 (var_is_str_missing): Ditto.
957 (var_is_value_user_missing): Removed. Changed callers to use
958 var_is_value_missing.
959 (var_is_num_user_missing): Removed. Changed callers to use
961 (var_is_str_user_missing): Removed. Changed callers to use
963 (var_is_value_system_missing): Removed. Changed callers to use
964 var_is_value_missing.
966 * casefilter.c (struct casefilter): Use enum mv_class in place of
968 (casefilter_variable_missing): Adapt to new member.
969 (casefilter_create): Change signature to take enum mv_class,
972 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
974 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
976 * case-sink.c case-sink.h procedure.c procedure.h
977 storage-stream.c: Now uses the factory.
979 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
981 Make it possible to pull cases from the active file with a
982 function call, instead of requiring indirection through a callback
985 * case-source.h (struct case_source_class): Change ->read function
986 to return a single case, instead of calling a callback function
987 for each case. Change ->destroy function to return an error
990 * case-source.c (free_case_source): Pass along the value returned
991 by the case_source ->destroy function.
993 * procedure.c (struct write_case_data): Removed.
994 (struct dataset): Added some members to track procedure state.
995 (procedure): Optimize the trivial case at this level.
996 (internal_procedure): Re-implement in terms of proc_open,
997 proc_read, proc_close.
998 (proc_open) New function.
999 (proc_read) New function.
1000 (proc_close) New function.
1001 (write_case) Moved into proc_read.
1002 (close_active_file) Moved closing of data source into proc_close.
1004 * storage-source.c: Rewrote to conform with modified
1005 case_source_class interface.
1007 * transformations.c (trns_chain_execute): Added argument to allow
1008 starting execution from an arbitrary transformation. Updated
1011 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
1013 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
1015 * sys-file-reader.c (read_display_parameters): Don't assume that
1016 MEASURE_* and ALIGN_* have the same values found in system files.
1018 * sys-file-writer.c (write_variable_display_parameters): Ditto.
1020 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
1021 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
1022 the value of n_MEASURES, which was off by 1 (at least from my
1025 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1027 * dictionary.c dictionary.h vardict.h variable.c: Added optional
1028 callbacks which are invoked when the dictionary or its
1029 variables are changed.
1031 * missing-values.c missing-values.h value-labels.c: Tidied up
1032 consistency checks, and made some of them return false
1033 instead of assert-failing.
1035 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
1037 * calendar.c (calendar_days_in_month): New function.
1039 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
1041 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
1042 the value label's width.
1044 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
1046 * sfm-private.h: Move contents into sys-file-writer.c, which is
1047 the only remaining user. Removed Borland C++-specific directives.
1049 * sys-file-reader.c: Clean up and rewrite entire file. The
1050 rewritten version is simpler and better abstracted, and should be
1051 easier to maintain and extend. It avoids using structures to read
1052 file data, which is prone to padding variations among compilers.
1053 It should also handle non-IEEE 754 system files, although I
1054 haven't been able to find any. It has been tested against many
1055 .sav files obtained from the Web and found to produce the same
1056 results as the earlier version of the code, or in some cases
1057 improved results. It is more tolerant of format variations found
1060 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
1061 member, putting an enum integer_format in its place. New member
1062 `float_format'. Changed `compressed' member to type bool.
1064 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
1066 * dictionary.c (dict_delete_consecutive_vars): New function.
1068 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
1070 * file-name.c (fn_search_path): Remove prefix arg that was unused
1071 by any caller. Updated all callers.
1073 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
1075 * format.c (fmt_dollar_template): Use user's decimal point
1076 character. Add assertion.
1078 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
1080 * format.c (fmt_dollar_template): New function, based on
1081 dollar_format_template from var-type-dialog.c.
1083 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1085 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1088 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1090 Finish converting struct variable to an opaque type. In this
1091 phase, we add remaining setter and getter functions, convert the
1092 remaining PSPP code to use them, and do a bunch of cleanup. The
1093 resulting changes are pervasive but mostly trivial, and only the
1094 notable changes are logged.
1096 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1099 * case.c (case_data): Renamed case_data_idx.
1100 (case_num): Renamed case_num_idx.
1101 (case_str): Renamed case_str_idx.
1102 (case_data_rw): Renamed case_data_rw_idx.
1104 * case.h (case_data): New function with old name and an interface
1105 that takes a variable instead of an index, which is easier to
1106 use. Updated all callers to use the new interface, or to use the
1107 new *_idx function (see above).
1110 (case_data_rw): Ditto.
1112 * category.c (cat_stored_values_destroy): Changed interface to
1113 take a struct cat_vals * instead of a struct variable *.
1115 * dictionary.c (dict_clone): Use new vector_clone function.
1116 (dict_clear) Use new var_destroy function.
1117 (add_var) New function.
1118 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1119 (dict_create_var_assert) Rewrite in terms of add_var.
1120 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1121 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1122 (dict_lookup_var) Use new var_create, var_destroy functions.
1123 (dict_contains_var) Rewrite in terms of new vardict functionality.
1124 (set_var_dict_index) New function.
1125 (set_var_case_index) New function.
1126 (reindex_vars) New function.
1127 (dict_delete_var) Rewrite in terms of new vardict functionality.
1128 (dict_reorder_var) Ditto.
1129 (dict_reorder_vars) Ditto.
1130 (rename_var) New function.
1131 (dict_rename_var) Use rename_var.
1132 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1133 (dict_get_compacted_idx_to_fv) Rename
1134 dict_get_compacted_dict_index_to_case_index, update callers.
1135 (dict_create_vector) Use new vector_create function.
1136 (dict_clear_vectors) Use new vector_destroy function.
1137 (set_var_short_name_suffix) Move here from variable.c, renamed
1138 from var_set_short_name_suffix, make static, update caller.
1140 * sys-file-private.c: New file.
1141 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1142 width_to_bytes, update callers.
1144 * sys-file-private.h: New file. Later it will supplant
1145 sfm-private.h; for now it supplements it.
1146 (macro MIN_VERY_LONG_STRING) New macro.
1147 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1149 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1150 MAX_LONG_STRING was used before.
1152 * sys-file-writer.c: Ditto.
1154 * value-labels.c: Change the paradigm here to be that a null
1155 pointer is OK for a struct val_labs * in most cases; it just
1156 represents an empty set of value labels.
1157 (val_labs_copy) A copy of a null set is a null set.
1158 (val_labs_count) A null set has 0 labels.
1159 (val_labs_replace) Change return type to void. Rewrite for
1161 (val_labs_find) A null set does not contain the value.
1162 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1163 transposed argument order, updated all callers.
1165 * value.c: New file.
1166 (value_dup) Moved here from variable.c.
1167 (compare_values) Ditto.
1170 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1171 (macro MAX_LONG_STRING) Removed, because it was only interesting
1172 for system files, not for general code.
1173 (macro MAX_VERY_LONG_STRING) Ditto.
1174 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1175 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1177 * vardict.h: New file, for an interface between variables and
1180 * variable.c: A lot of functions were moved around, for better
1182 (struct variable) Move definition here, from variable.h.
1183 (var_type_adj) Removed--makes i18n hard.
1184 (var_type_noun) Ditto.
1185 (var_create) New function.
1186 (var_clone) New function.
1187 (var_destroy) New function.
1188 (var_set_name) Assert that variable is not in a dictionary.
1189 (compare_var_names) Rename compare_vars_by_name and fix a couple
1190 of callers who thought the args were strings.
1191 (hash_var_name) Rename hash_var_by_name.
1192 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1193 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1194 (var_is_very_long_string) Removed, because it was only interesting
1195 to system file code.
1196 (var_set_missing_values) Allow the argument to be the wrong width,
1197 as long as we can resize it. Simplify callers who were doing the
1198 resizing themselves.
1199 (var_get_value_labels) New function.
1200 (var_has_value_labels) New function.
1201 (var_set_value_labels) New function.
1202 (alloc_value_labels) New function.
1203 (var_add_value_label) New function.
1204 (var_replace_value_label) New function.
1205 (var_clear_value_labels) New function.
1206 (var_lookup_value_label) New function.
1207 (var_get_value_name) Moved here from variable.c, renamed from
1208 var_get_value_name, transposed argument order, updated all
1210 (var_to_string) Moved here, from variable-label.c.
1211 (var_set_leave) New function.
1212 (var_get_leave) New function.
1213 (var_must_leave) New function.
1214 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1215 set_var_short_name_suffix.
1216 (var_get_dict_index) New function.
1217 (var_get_case_index) New function.
1218 (var_get_obs_vals) New function.
1219 (var_set_obs_vals) New function.
1220 (var_has_obs_vals) New function.
1221 (var_get_vardict) New function.
1222 (var_set_vardict) New function.
1223 (var_has_vardict) New function.
1224 (var_clear_vardict) New function.
1225 (value_dup) Moved to value.c.
1226 (compare_values) Ditto.
1229 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1230 (enum ALPHA) Rename VAR_STRING, update all users.
1232 * vector.c: New file.
1233 (struct vector) Moved here, from variable.h.
1234 (check_widths) New function.
1235 (vector_create) New function.
1236 (vector_clone) New function.
1237 (vector_destroy) New function.
1238 (vector_get_name) New function.
1239 (vector_get_var) New function.
1240 (vector_get_var_cnt) New function.
1241 (compare_vector_ptrs_by_name) New function.
1243 * vector.h: New file.
1245 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1247 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1248 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1251 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1253 * value-labels.c (destroy_atoms): New function.
1254 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1256 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1258 Thanks to Jason Stover for pointing out this problem.
1260 * data-out.c (output_number): Use gsl_finite from GSL, which is
1261 portable, instead of isfinite, which is not.
1264 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1266 * variable.c variable.h (value_dup): New function.
1268 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1270 Start converting struct variable to an opaque type. In this
1271 phase, we add a bunch of setter and getter functions and convert
1272 most of the PSPP code to use them. The resulting changes are
1273 pervasive but mostly trivial, and only the notable changes are
1276 * format.c (fmt_equal): New function.
1278 * variable.c (var_type_is_valid): New function.
1279 (measure_is_valid) Moved here, from format.c.
1280 (alignment_is_valid) Moved here, from format.c.
1281 (var_get_name) New function.
1282 (var_set_name) New function.
1283 (width_to_type) New function.
1284 (var_get_type) New function.
1285 (var_get_width) New function.
1286 (var_set_width) New function.
1287 (var_is_numeric) New function.
1288 (var_is_alpha) New function.
1289 (var_is_short_string) New function.
1290 (var_is_long_string) New function.
1291 (var_is_very_long_string) New function.
1292 (var_get_missing_values) New function.
1293 (var_set_missing_values) New function.
1294 (var_clear_missing_values) New function.
1295 (var_has_missing_values) New function.
1296 (var_is_value_missing) New function.
1297 (var_is_num_missing) New function.
1298 (var_is_str_missing) New function.
1299 (var_is_value_user_missing) New function.
1300 (var_is_num_user_missing) New function.
1301 (var_is_str_user_missing) New function.
1302 (var_is_value_system_missing) New function.
1303 (var_get_print_format) New function.
1304 (var_set_print_format) New function.
1305 (var_get_write_format) New function.
1306 (var_set_write_format) New function.
1307 (var_set_both_formats) New function.
1308 (var_get_label) New function.
1309 (var_set_label) New function.
1310 (var_clear_label) New function.
1311 (var_has_label) New function.
1312 (var_get_measure) New function.
1313 (var_set_measure) New function.
1314 (var_get_display_width) New function.
1315 (var_set_display_width) New function.
1316 (var_get_alignment) New function.
1317 (var_set_alignment) New function.
1318 (var_get_value_cnt) New function.
1319 (var_get_leave) New function.
1320 (var_get_short_name) New function.
1322 * variable.h: (struct variable) Removed "type" and "nv" members;
1323 they are now computed from "width" where needed.
1325 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1327 * missing-values.c (mv_resize): Don't write beyond end of the
1328 allocated buffer when resizing a long string.
1330 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1332 Clean up identifier code: don't require identifier enumerations to
1333 be in a particular order; make better use of string library;
1334 expose less of the internals.
1336 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1337 change interface. Updated all callers.
1338 (lex_id_match) Change interface to use struct substring, update
1340 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1341 (global array keywords[]) Make static, change form. Update all
1342 users to use lex_id_name instead.
1343 (lex_is_keyword) New function.
1344 (lex_id_to_token) Change interface to use struct substring, update
1346 (lex_id_name) New function.
1348 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1349 lex_is_keyword instead.
1350 (T_LAST_KEYWORD) Removed.
1351 (T_N_KEYWORDS) Removed.
1353 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1355 * format.c: (fmt_date_template) Distinguish characters for which a
1356 space is output and any date delimiter is allowed on input, from
1357 those for which a space is output and only a space is allowed on
1358 input. The former is represented by X, the latter by a space.
1359 Also, drop distinction between h and H, changing the former to the
1362 * data-in.c: Completely rewrite internals to conform to SPSS input
1363 formats as closely as possible.
1364 (data_in) Changed external interface by replacing the structure
1365 that was used as a single argument by a set of arguments. Updated
1367 (data_in_finite_line) Removed. Converted all callers to use plain
1369 (data_in_get_integer_format) New function.
1370 (data_in_set_integer_format) New function.
1371 (data_in_get_float_format) New function.
1372 (data_in_set_float_format) New function.
1374 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1375 (struct data_in) Removed.
1377 * data-out.c: (output_date) Drop each component from the input as
1378 it is output, to allow us to drop the distinction between h (a
1379 count of hours) and H (the hour of day) template characters.
1380 Also, handle new X template character.
1381 (output_scientific) Follow more rational rule on when to drop
1382 fraction introduced between SPSS 13 and 15. Updated test case to
1385 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1387 Fix buffer overflow reported by John Darrington.
1389 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1390 realize that DIGITS is a count of nibbles, not of bytes.
1392 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1394 * calendar.c (calendar_offset_to_gregorian) Also return the
1395 year-of-day. Change callers to new interface.
1397 * data-out.c: Completely rewrite internals to conform to SPSS
1398 output formats as completely as possible.
1399 (data_out) Change interface to put input parameters before output
1400 parameters, for consistency with the style I now prefer. Update
1402 (data_out_get_integer_format) New public function.
1403 (data_out_set_integer_format) New public function.
1404 (data_out_get_float_format) New public function.
1405 (data_out_set_float_format) New public function.
1407 * data-out.h: New file. Move prototype for data_out here, from
1410 * format.c: (fmt_step_width) Use equality comparison instead of
1411 bitwise and, for clarity.
1412 (fmt_is_string) Ditto.
1413 (fmt_input_to_output) Fix categories that are translated to F
1416 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1418 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1419 casefile-private.h: Added casefilter to assist commands with missing
1422 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1424 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1426 * settings.c: (route_errors_to_terminal) New variable.
1427 (route_errors_to_listing) New variable.
1428 (get_error_routing_to_terminal) New function.
1429 (set_error_routing_to_terminal) New function.
1430 (get_error_routing_to_listing) New function.
1431 (set_error_routing_to_listing) New function.
1433 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1435 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1437 * format.c: Completely rewrite, to achieve better abstraction.
1438 Rewrite all references to formats in other files.
1440 * format.def: Rewrite and reorganize.
1442 * settings.c: Move everything related to custom currency formats
1443 into format.[ch], changing them in form, so as to group related
1444 code and definitions better. Changed all references to use the
1446 (static var decimal) Removed.
1447 (static var grouping) Removed.
1448 (static var cc) Removed.
1449 (get_decimal) Removed.
1450 (set_decimal) Removed.
1451 (get_grouping) Removed.
1452 (set_grouping) Removed.
1456 * settings.h: (macro CC_CNT) Removed.
1457 (macro CC_WIDTH) Removed.
1458 (struct custom_currency) Removed.
1460 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1462 * data-in.c (data_in): Use switch statement instead of table, to
1463 avoid dependence on the order of the FMT_* enums.
1465 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1467 * data-out.c: (num_to_string) Removed, because it was dead code.
1469 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1471 * data-in.c (parse_trailer): Fix error message.
1473 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1475 * format.c (fmt_is_binary): New function.
1477 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1479 * procedure.c procedure.h: Encapsulated the static data into a single
1482 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1484 * casefile.c (casereader_read_xfer): Always initialize the case,
1485 even on an error condition.
1487 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1489 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1490 entire function useless.
1492 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1494 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1495 casereader method casereader_clone.
1497 * procedure.c pransformations.h: Introduced new type casenum_t
1499 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1501 * variable.c: (width_to_bytes) Rephrase code for clarify.
1503 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1505 * format.c: (fmt_type_from_string) New function.
1506 (fmt_to_string) Include decimals in output if the format has
1507 decimals, even if the format type does not. This way, we can
1508 accurately reproduce incorrect formats in user output.
1509 (check_common_specifier) Make the check for a bad format type an
1510 assertion, so we get bug reports if they show up. Fix message.
1511 Check for decimal places with a format type that doesn't allow
1513 (check_input_specifier) Remove check for FMT_X, which has been
1515 (check_output_specifier) Ditto.
1517 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1519 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1520 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1521 (enum fmt_parse_flags) Removed.
1523 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1525 * casefile.c casefile.h: Converted to an abstract base class.
1526 * casefile-private.h fastfile.c fastfile.h: New files.
1527 * automake.mk procedure.c scratch-writer.c storage-stream.c
1529 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1531 * procedure.c (internal_procedure): Create sink_case with only as
1532 many values as the compacted dictionary.
1534 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1536 Remove "debugging" code that caused plenty of false positives and
1539 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1541 * case.c: Remove all references to `this' member.
1543 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1545 Fix link error noted by Jason Stover.
1547 * storage-stream.c: Include <assert.h>.
1549 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1551 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1552 ALL) and additional underlying system file issues.
1554 Thanks to John Darrington for review.
1556 First problem: var_hash points to variables not owned by the
1557 sys-file-reader, which the caller may free or modify. Use an
1558 array of sfm_vars instead, as done earlier (e.g. CVS version
1561 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1562 members and remove all code that references it. Add vars, var_cnt
1563 members. Remove fix_specials member, which was unused.
1564 (struct sfm_var) Remove name member, which was unused.
1565 (sfm_close_reader) Free vars member instead of var_hash.
1566 (compare_var_shortnames) Removed.
1567 (hash_var_shortname) Removed.
1568 (sfm_open_reader) Fill out vars array.
1569 (compare_var_index) Removed.
1570 (sfm_read_case) Use vars instead of var_hash.
1572 Second problem: we're confused about when we actually have very
1573 long strings, causing us to choose incorrectly between slow path
1574 and fast path in sfm_read_case.
1576 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1577 have very long strings, not when we have long variable names,
1578 which is an unrelated feature.
1580 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1582 * variable.h: Move var_set and variable parsing declarations to
1583 new header, src/language/lexer/variable-parser.h. Modified lots
1584 of files to include the new header.
1586 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1588 * value-labels.c (value_to_string): When there's no value label,
1589 format the variable according to its print format, instead of
1590 always effectively using A or F format.
1592 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1594 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1597 * format.c: Removed tortological assertion.
1599 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1601 Reform string library.
1603 * file-name.c (fn_interp_vars): Change interface to take a
1604 substring as input. Updated all users.
1606 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1608 * format.c (measure_is_valid): Really return false when m >=
1611 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1613 Implement random access to casefiles, for use in GUI.
1615 * casefile.c: (struct casereader) Add `random', `file_ofs',
1616 `buffer_ofs' members.
1617 (casefile_get_random_reader) New function.
1618 (read_open_file) Break part into new function
1619 seek_and_fill_buffer().
1620 (fill_buffer) Update buffer_ofs, file_ofs.
1621 (casereader_seek) New function.
1623 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1625 * settings.c: Added call to i18n{done, init}.
1627 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1629 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1632 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1634 * casefile.c: Convert many uses of `int' to `bool'.
1636 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1638 * transformations.c (trns_chain_destroy): Destroy chain's trns
1639 member, to fix memory leak.
1641 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1643 * storage-stream.c (storage_source_decapsulate): Destroy case
1644 source to fix memory leak.
1646 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1648 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1649 case passed as argument instead of initializing the argument as a
1650 case. Fixes memory leak that showed up in
1651 tests/command/aggregate.sh with scratch files.
1653 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1655 * procedure.c (proc_done): Destroy default_dict, to fix memory
1658 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1660 Simplify procedure_with_splits().
1662 * procedure.c (struct split_aux_data): Removed case_count member.
1663 (procedure_with_splits) Don't initialize case_count.
1664 (split_procedure_case_func) Check whether prev_case is null
1665 instead of case_count.
1666 (split_procedure_end_func) Ditto.
1668 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1670 * case.c (case_move): Do nothing if dst and src are the same
1672 (case_try_create) Merge two similar cases.
1673 (case_copy) Unshare only if data must be actually copied.
1675 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1677 * data-in.c data-out.c dictionary.c sys-file-reader.c
1678 sys-file-writer.c variable.c variable.h: Reworked very long string
1679 support for better encapsulation.
1681 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1683 * value-labels.c (val_labs_can_set_width): New function.
1684 (val_labs_set_width) Clear labels if increasing width to long
1686 (val_labs_destroy) Remove unneeded test for null.
1688 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1690 * value-labels.h: Remove unneeded dependency on variable.h.
1692 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1694 Get rid of `char *c' member in union value, for cleanliness.
1696 * value.h: (union value) Remove `c' member.
1698 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1700 Make dictionary compacting functions a little more general.
1702 * sys-file-writer.c (sfm_open_writer): Use
1703 dict_compacting_would_change().
1704 (does_dict_need_translation) Removed.
1706 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1708 Make dictionary compacting functions a little more general.
1710 * dictionary.c (dict_needs_compaction): Rename
1711 dict_compacting_would_shrink(). Update all callers.
1712 (dict_compacting_would_change) New function.
1714 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1716 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1717 inverted return value (!).
1719 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1721 Continue reforming procedure execution.
1723 * procedure.c: Search and replace "vfm" by "proc". Notably:
1724 (static var vfm_source) Rename proc_source. Update all
1726 (static var vfm_sink) Rename proc_sink. Update all references.
1728 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1730 Continue reforming procedure execution. In this phase, remove
1731 PROCESS IF, which was deprecated anyway and can be easily
1732 simulated with TEMPORARY followed by SELECT IF.
1734 * procedure.c: (open_active_file) Don't call
1735 add_process_if_trns().
1736 (discard_variables) Get rid of redundant call to
1737 proc_cancel_all_transformations().
1738 (add_process_if_trns) Removed.
1739 (process_if_trns_proc) Removed.
1740 (process_if_trns_free) Removed.
1742 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1744 Continue reforming procedure execution. In this phase, add
1745 `const' to the case passed to procedure()'s callback.
1747 Updated all users of procedure() as well.
1749 * procedure.c: (struct write_case_data) Add "const" to ccase
1750 parameter for case_func member.
1751 (procedure) Add "const" to ccase parameter for proc_func
1753 (multipass_case_func) Make ccase parameter const.
1754 (internal_procedure) Add "const" to ccase parameter for case_func
1756 (split_procedure_case_func) Make ccase parameter const.
1757 (multipass_split_case_func) Make ccase parameter const.
1759 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1761 Continue reforming procedure execution. In this phase, get rid of
1762 the output code for SPLIT FILE groups in procedure.c, which really
1763 shouldn't be doing any output. Move it into the individual
1764 procedures instead. This also adds some flexibility.
1766 Updated many users of procedure_with_splits() and
1767 multipass_procedure_with_splits() to call
1768 output_split_file_values() and to deal with increased use of
1771 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1772 parameter to begin_func member.
1773 (procedure_with_splits) Add "const struct ccase *" parameter to
1774 begin_func parameter. Make ccase parameter const in proc_func
1776 (split_procedure_case_func) Don't dump split file group. Pass
1778 (dump_splits) Moved to language/dictionary/split-file.c as
1779 output_split_file_values().
1780 (struct multipass_split_aux_data) Add "const struct ccase *"
1781 parameter to split_func member.
1782 (multipass_procedure_with_splits) Add "const struct ccase *"
1783 parameter to split_func parameter.
1784 (multipass_split_case_func) Save new SPLIT FILE case before
1786 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1788 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1790 Continue reforming procedure execution. Change
1791 internal_procedure() so that it calls open_active_file() and
1792 close_active_file(), which isolates most of the actual procedure
1795 * procedure.c: (struct write_case_data) Rename `proc_func' member
1796 to `case_func' and update all references.
1797 (procedure) Rewrite as one-line wrapper around
1798 internal_procedure().
1799 (struct multipass_aux_data) New.
1800 (multipass_callback) Renamed multipass_case_func(). Use struct
1801 multipass_aux_data as auxiliary data.
1802 (multipass_end_func) New function.
1803 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1804 that uses multipass_case_func, multipass_end_func.
1805 (internal_procedure) Add `end_func' argument. Move optimization
1806 of trivial case in here. Move call to open_active_file() and
1807 close_active_file() in here. Now assert that vfm_source is
1809 (procedure_with_splits_callback) Rename
1810 split_procedure_case_func().
1811 (split_procedure_end_func) New function.
1812 (multipass_split_callback) Rename multipass_split_case_func.
1813 (multipass_split_end_func) New function.
1814 (discard_variables) No need to test for nonnull vfm_source.
1816 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1818 Continue reforming procedure execution. Get rid of unused member.
1820 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1822 (write_case) Don't increment cases_analyzed.
1824 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1826 Continue reforming procedure execution. In this phase, move
1827 procedure.c and procedure.h from src to src/data. Update
1828 makefiles and #includes accordingly.
1830 * procedure.c: Moved here from src/.
1832 * procedure.h: Moved here from src/.
1834 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1836 Continue reforming procedure execution. In this phase, get rid of
1837 many global variables, consolidating procedure execution in
1838 procedure.c. Encapsulate transformations in new "struct
1839 trns_chain". Also, change implementation of N OF CASES, FILTER,
1840 and PROCESS IF from special cases to transformations.
1842 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1845 * dictionary.c: (global variable default_dict) Move to
1848 * variable.h: (TRNS_*) Move to transformations.h.
1849 (struct transformation) Move to transformations.c.
1851 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1853 * sys-file-reader.c: Fixed invalid read problems.
1855 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1857 * storage-stream.c: Add missing function comments.
1859 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1861 Continue reforming procedure execution. In this phase, add some
1862 new, needed functionality to storage-stream.
1864 * storage-stream.c: (storage_source_decapsulate) New function.
1866 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1868 * variable.c (width_to_bytes): Declarations must precede
1869 statements for C90 compliance.
1871 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1873 * data-out.c, data-in.c, variable.c, variable.h: New functions
1874 copy_mangle and copy_demangle for reading/writing cases; emulates the
1875 way SPSS deals with strings > 255 bytes.
1877 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1878 subtype 14 needed for strings longer than 255 bytes.
1880 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1881 instead of literal values. Also fixed some constness issues.
1883 * format.h: Constness
1885 * sfm-private.h: Renamed the case_size identifier, since I discovered
1886 that SPSS's respect for this variable is very nominal.
1888 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1890 Change case limit type from int to size_t.
1892 * dictionary.c: (struct dictionary) Change type of case_limit
1894 (dict_get_case_limit) Change return type.
1895 (dict_set_case_limit) Change parameter type.
1897 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1899 * variable.h: (struct variable) Rename `reinit' member as `leave'
1900 and invert sense. Fix up all references.
1902 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1904 Continue reforming procedure execution. In this phase, break
1905 procedure.c into multiple files.
1907 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1909 * case-sink.c: New file.
1911 * case-sink.h: New file.
1913 * case-source.c: New file.
1915 * case-source.h: New file.
1917 * storage-stream.c: New file.
1919 * storage-stream.h: New file.
1921 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1923 * variable.h: (struct variable) Remove `init' member and all
1924 references to it from other files. It was initialized in several
1925 places, but nothing really ever used it for anything worthwhile.
1926 Thanks to Jason Stover for pointing out how confusing this
1929 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1931 Continue reforming error message support. In this phase, get rid
1932 of message "titles" and put the message text in `struct error'.
1933 Now `struct error' encapsulates a message more properly.
1935 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1936 Format message ourselves.
1938 * data-in.c: (vdls_error) Ditto.
1940 * por-file-reader.c: (error) Ditto.
1942 * sys-file-reader.c: (corrupt_msg) Ditto.
1944 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1946 GNU standards require "file name" instead of "filename" in
1947 documentation. It's nice for our code to follow the convention
1950 * casefile.c: (struct casefile) Rename `filename' member to
1951 `file_name'. Updated all references.
1953 * file-name.c: [!unix] (struct file_identity) Rename
1954 normalized_filename member to normalized_file_name. Updated all
1957 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1959 We don't really support anything but Unix-like environments well,
1960 so we might as well de-obfuscate by writing directory and path
1961 separators explicitly.
1963 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1965 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1966 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1968 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1971 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1973 GNU standards require "file name" instead of "filename" in
1974 documentation. It's nice for our code to follow the convention
1977 * filename.c: Rename to file-name.c.
1979 * filename.h: Rename to file-name.h. Update all inclusions.
1980 Update header guards.
1982 * automake.mk: Update file names.
1984 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1986 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1988 (fn_basename) Removed (dead code).
1989 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1990 (fn_special_p) Renamed fn_is_special(), all references updated.
1991 (fn_exists_p) Renamed fn_exists(), all references updated.
1993 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1995 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1996 Also, now it only tilde-expands file names, not paths.
1997 (fn_search_path) Tilde-expand one directory at a time.
1999 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
2001 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
2002 get rid of non-Unixlike version of the code, which has probably
2004 (fn_prepend_dir) Removed (dead code).
2006 * filename.h: (macro DIR_SEPARATOR_STRING) New.
2007 (macro PATH_SEPARATOR_STRING) New.
2008 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
2010 Continue reforming error message support. In this phase, we get
2011 rid of VM() and the other msg() support for "verbosity", replacing
2012 it by a new function verbose_msg().
2014 * filename.c: (fn_search_path) Use verbose_msg() instead of
2017 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
2019 * sfm-private.h: Get rid of #defines after #error, which makes no
2022 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
2024 Get rid of our own int32 type in favor of the standard int32_t
2027 * sfm-private.h: (int32 macro) Don't define this anymore. Do
2030 * sys-file-reader.c: Use int32_t instead of int32 throughout.
2032 * sys-file-writer.c: Use int32_t instead of int32 throughout.
2034 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
2036 Remove ill-considered file routines that are no longer used.
2038 * filename.c: (fn_open_ext) Removed.
2039 (fn_close_ext) Removed.
2041 * filename.h: (struct file_ext) Removed.
2043 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
2045 * variable.c (var_is_valid_name): Move declarations before code
2048 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
2050 * filename.ch (fn_interp_vars): Fixed small buglet.
2052 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
2054 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
2055 so as to modify the string inline. Thus makeing it easier to
2056 destroy the results when no longer needed.
2058 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
2060 * category.c (cat_stored_values_destroy): Fixed memory leak.
2062 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
2064 Add some missing frees. Thanks to John Darrington for reporting
2067 * any-writer.c (any_writer_close): Free writer.
2069 * any-reader.c (any_reader_close): Free reader.
2071 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
2073 * por-file-reader.c: (error) Mark as NO_RETURN.
2075 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
2077 * settings.c: Changed default value of scompress to true.
2079 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
2081 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
2083 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2086 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2087 here from pref.h.orig.
2089 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2091 * sys-file-reader.c: Fixed bug reading compressed files.
2093 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2095 * Numerous renames. See src/ChangeLog for details.
2097 * Moved files from src directory