1 2007-08-12 Ben Pfaff <blp@gnu.org>
3 * dictionary.c (dict_dump): New function.
5 2007-08-12 Ben Pfaff <blp@gnu.org>
7 Drop dict_compactor in favor of using the new struct case_map.
9 * dictionary.c (struct copy_map): Removed.
10 (struct dict_compactor): Removed.
11 (dict_make_compactor): Removed.
12 (dict_compactor_compact): Removed.
13 (dict_compactor_destroy): Removed.
15 * procedure.c (struct data_set): Change `compactor' member to be a
17 (proc_open): Use case_map_to_compact_dict instead of
19 (proc_casereader_read): Use case_map_execute instead of
20 dict_compactor_compact.
21 (proc_commit): Use case_map_destroy instead of
22 dict_compactor_destroy.
24 * scratch-writer.c (struct scratch_writer): Change `compactor'
25 member to be a struct case_map *.
26 (scratch_writer_open): Use case_map_to_compact_dict instead of
28 (scratch_writer_casewriter_write): Use case_map_execute instead of
29 dict_compactor_compact.
31 2007-08-12 Ben Pfaff <blp@gnu.org>
33 * automake.mk: Add case-map.c, case-map.h.
35 * case-map.c: New file.
37 * case-map.h: New file.
39 2007-08-12 Ben Pfaff <blp@gnu.org>
41 * dictionary.c (dict_compact_values): Don't delete scratch
42 variables as well as compacting case indexes. Update all callers.
43 (dict_get_compacted_value_cnt): Rename dict_count_values and
44 change interface. Update all callers.
45 (dict_get_compacted_value_cnt): Remove.
46 (dict_compacting_would_shrink): Remove.
47 (dict_compacting_would_change): Remove.
48 (dict_make_compactor): Add new parameter. Update all callers.
50 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
51 instead of dict_count_values, changing an O(N) operation into
54 2007-08-12 Ben Pfaff <blp@gnu.org>
56 * casereader.c (casereader_read): Don't require cases read by a
57 casereader to be exactly the expected size: as long as they're big
60 2007-08-12 Ben Pfaff <blp@gnu.org>
62 Make casewriters keep track of the number of `union value's in
63 each case. This is useful for two reasons: casewriter_write can
64 then check that the case being written is large enough, and later
65 recipients of the casewriter can determine the size of the case.
67 * casewriter-translator.c (casewriter_create_translator): Add
70 * casewriter.c (struct casewriter): Add value_cnt member.
71 (casewriter_write): Check that the case passed in is big enough.
72 (casewriter_get_value_cnt): New function.
73 (casewriter_create): Add value_cnt parameter.
75 2007-08-09 Ben Pfaff <blp@gnu.org>
77 Fix bug reported by Jason Stover.
78 * settings.c: Move get_termcap_viewport and in particular the
79 #include for <curses.h> to the end of the file. curses.h
80 redefines bool on some systems (e.g. OpenBSD), which causes
81 disagreement between uses of bool before its inclusion and
83 Tested by Jason Stover.
85 2007-07-29 Ben Pfaff <blp@gnu.org>
87 Provisional fix for bug #18692 and bug #20161. Reviewed by John
90 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
91 argument (never "rb" or "wb") because SUSv3 says that only those
92 modes are defined, and glibc in fact rejects other modes.
94 Open portable files with fn_open so that they can be read from
95 pipes. Fix missing fh_close call to go along with fh_open.
96 Report an error if the file close reports an error.
97 * por-file-reader.c (close_reader): New function.
98 (por_file_casereader_destroy): Use close_reader.
99 (pfm_open_reader): Open file with fn_open.
101 2007-07-28 Ben Pfaff <blp@gnu.org>
103 Make PSPP able to read all the portable files I could find on the
104 web. Thanks to John Darrington for review. Bug #17620.
105 * por-file-reader.c (struct pfm_reader): New member `line_length'.
106 (error): Print file offset in hexadecimal.
107 (warning): New function.
108 (advance): Treat lines less than 80 bytes long as padded to 80
110 (pfm_open_reader): Call read_documents if we find an "E" record.
111 (convert_format): Convert invalid formats to the default format
112 instead of aborting reading the file.
113 (read_variables): Rename duplicate variable names instead of
114 aborting reading the file.
115 (read_value_label): Allow string variables of different widths to
116 be assigned value labels in the same record. Replace duplicate
117 value labels instead of aborting.
118 (read_documents): New function.
120 * por-file-writer.c (pfm_open_writer): Call write_documents if the
121 dictionary has documents.
122 (write_documents): New function.
124 2007-07-25 Ben Pfaff <blp@gnu.org>
126 Fix bugs related to bug #17213.
128 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
129 since the former is what config.h has. Include the needed ncurses
131 (static var echo) Rename to `do_echo' because the original name is
132 the same as an ncurses identifier.
133 (get_termcap_viewport) Use error instead of msg.
135 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
136 (fn_close): Don't close stdin, stdout, stderr.
138 2007-07-26 John Darrington <john@darrington.wattle.id.au>
140 * procedure.c procedure.h: Added callbacks which get invoked whenever
141 a dataset's transformation chain changes.
143 2007-07-24 Ben Pfaff <blp@gnu.org>
146 * sys-file-writer.c (write_variable_display_parameters): Use new
147 var_default_display_width function to choose display width of
148 segments after the first one in a given variable.
149 * variable.c (var_create): Use var_default_display_width to pick
150 new variable's display width.
151 (var_default_display_width): New function.
152 Reviewed by John Darrington.
154 2007-07-24 Ben Pfaff <blp@gnu.org>
157 * por-file-writer.c (write_variables): Write weight variable.
158 Reviewed by John Darrington.
160 2007-07-23 Ben Pfaff <blp@gnu.org>
162 Improvements to system file reader and writer.
164 First, move all detailed knowledge of very long strings into
165 sys-file-private.[ch], so that this nasty stuff can be isolated.
167 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
168 (EFFECTIVE_VLS_CHUNK): New macro.
169 (min_int): New function.
170 (max_int): New function.
171 (sfm_width_to_bytes): Rewrite.
172 (sfm_width_to_octs): New function.
173 (sfm_segment_alloc_width): New function.
174 (sfm_segment_alloc_bytes): New function.
175 (sfm_segment_used_bytes): New function.
176 (sfm_segment_offset): New function.
177 (sfm_segment_effective_offset): New function.
178 (sfm_dictionary_to_sfm_vars): New function.
180 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
181 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
182 (struct sfm_var): New structure.
184 Next, improvements to the system file reader.
186 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
187 type casenumber. Added `version_major', `version_minor',
190 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
191 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
192 Change `case_cnt' to type casenumber. Removed `has_vls'.
193 (struct sfm_var): Removed.
194 (sfm_open_reader): Don't warn on wrong case size if the file was
195 written by SPSS 13, which tends to get it wrong. Use
196 sfm_dictionary_to_sfm_vars.
197 (read_header): Always output system file info.
198 (read_variable_record): Simplify code for reading missing values.
199 (read_machine_int32_info): Save version numbers from system file
200 into info struct passed as new argument.
201 (read_long_string_map): Restructured to use new sys-file-private
203 (read_value_labels): Use size_overflow_p.
204 (sys_file_casereader_read): Get rid of distinction between fast
205 and slow paths. Use information provided by sys-file-primate's
206 struct sfm_var to simplify code.
207 (skip_whole_strings): New function.
208 (read_int32): Renamed read_int. Changed return value to int.
210 (read_flt64): Renamed read_float. Changed return value to
211 double. Updated all callers.
212 (int32_to_native): Removed. Changed callers to use
214 (flt64_to_double): Removed. Changed callers to use float_convert.
216 Finally, get rid of int32, flt64 terminology and types in system
217 file writer. The former wasn't very useful since a POSIX "int"
218 can hold the whole range of int32 and we generally didn't have a
219 need for it to be exactly-32-bits, just at-least-32-bits. The
220 latter was inconvenient because we had to assume that it could be
221 different from double and thereby convert special values SYSMIS,
222 HIGHEST, LOWEST to and from it in multiple places. Instead, now
223 we just use "int" and "double" in most places, and do conversions,
224 if necessary, very close to where we do I/O. This change meant
225 that the writer code couldn't represent records in the file as C
226 structs any longer, but that's no great loss. The code actually
227 seems to be more readable without them.
229 Simplify the compression buffering code: only buffer as much as
230 necessary, which is no more than eight 8-byte units at any given
233 * sys-file-writer.c (typedef flt64): Removed.
234 (macro second_lowest_flt64): Removed.
235 (struct sysfile_header): Removed.
236 (struct sysfile_variable): Removed.
237 (struct sfm_writer): Removed `needs_translation', `has_vls',
238 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
239 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
240 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
241 compression buffering by `opcodes', `opcode_cnt', `data',
242 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
243 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
244 data writer functions instead of structures.
245 (calc_oct_idx): New function.
246 (write_header): Use simple data writer functions instead of
248 (write_format_spec): Renamed write_format. New argument.
249 (write_variable_continuation_records): New function.
250 (write_variable): Use simple data writer functions instead of
251 structures. Use write_variable_continuation_records. Write
252 entire very long string instead of requiring caller to understand
254 (write_value_labels): Use simple data writer functions instead of
256 (write_documents): Ditto.
257 (write_variable_display_parameters): Use sys-file-private
258 functions to simplify. Use simple data writer functions instead
260 (write_vls_length_table): Use simple data writer functions instead
262 (write_longvar_table): Ditto.
263 (write_rec_7_34): Break into new functions
264 write_integer_info_record, write_float_info_record. Use simple
265 data writer functions instead of structures.
266 (buf_write): Removed.
267 (append_string_max): Removed.
268 (ensure_buf_space): Removed.
269 (sys_file_casewriter_write): Get rid of the distinction between
270 fast and slow paths, which didn't seem to be too useful. Use new
271 functions write_case_uncompressed, write_case_compressed.
272 (put_instruction): Removed.
273 (put_element): Removed.
274 (write_compressed_data): Removed.
275 (close_writer): Use flush_compressed. Only write case count to
276 system file if it will fit in the field.
277 (write_case_compressed): New function.
278 (write_case_uncompressed): New function.
279 (flush_compressed): New function.
280 (put_cmp_opcode): New function.
281 (put_cmp_number): New function.
282 (write_int): New function.
283 (convert_double_to_output_format): New function.
284 (write_float): New function.
285 (write_value): New function.
286 (write_string): New function.
287 (write_bytes): New function.
288 (write_zeros): New function.
289 (write_spaces): New function.
291 Reviewed by John Darrington.
293 2007-07-22 Ben Pfaff <blp@gnu.org>
295 Don't try to write very long strings to portable files. The
296 format does not support it.
298 * por-file-writer.c (MAX_POR_WIDTH): New macro.
299 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
300 (write_format): Add arg to take width to resize format to.
301 (write_value): Limit width of value written to MAX_POR_WIDTH.
302 (write_variables): Limit width of variable and its output formats
304 Reviewed by John Darrington.
306 2007-07-22 Ben Pfaff <blp@gnu.org>
308 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
309 local variable instead of literal 5.
310 Reviewed by John Darrington.
312 2007-07-22 Ben Pfaff <blp@gnu.org>
314 Fix problems with uniqueness of short names in system files with
315 very long string variables. Now a variable may have multiple
318 * automake.mk (src_data_libdata_a_SOURCES): Add new files
319 short-names.c, short-names.h.
321 * dictionary.c (dict_clone): Clone all the short names.
322 (compare_strings): Move into short-names.c.
323 (hash_strings): Ditto.
324 (set_var_short_name_suffix): Ditto.
325 (dict_assign_short_names): Ditto, rename short_names_assign,
326 change to assign all short names.
328 * por-file-writer.c (write_variables): Use short_names_assign
329 instead of dict_assign_short_names.
331 * short-names.c: New file.
333 * short-names.h: New file.
335 * sys-file-private.c (sfm_width_to_segments): New function.
337 * sys-file-reader.c (read_long_var_name_map): Save and restore all
338 the short names, not just the first one.
340 * sys-file-writer.c (cont_var_name): Removed.
341 (sfm_open_writer): Use short_names_assign instead of
342 dict_assign_short_names. Use unique short names assigned by
343 short_names_assign instead of those generated by cont_var_name.
345 * variable.c (struct variable): Remove `short_name' member,
346 replace by `short_names' and `short_name_cnt'.
347 (var_create) Initialize new members.
348 (var_get_short_name_cnt): New function.
349 (var_get_short_name): Now takes an index argument. Changed most
351 (var_set_short_name): Ditto.
352 (var_clear_short_name): Renamed var_clear_short_names, changed to
353 clear all short names.
355 Reviewed by John Darrington.
357 2007-07-22 Ben Pfaff <blp@gnu.org>
359 * variable.c (var_set_width): Use new var_set_width function.
361 * missing-values.c (mv_n_values): Drop assertion, which was not
364 * format.c (fmt_default_for_width): New function.
365 (fmt_resize): New function.
367 Reviewed by John Darrington.
369 2007-07-18 John Darrington <john@darrington.wattle.id.au>
371 * datasheet.c (datasheet_delete_columns): Added assertion to check
372 we're not deleting outside the range of the sheet.
375 * dictionary.c dictionary.h variable.c: Added the ability for string
376 variables to be resized.
378 * vardict.h: Added some prototypes (moved from dictionary.h) as
379 these should only be called by variable.c
382 2007-07-14 John Darrington <john@darrington.wattle.id.au>
384 * sfm-reader.c: Respect case_cnt field in file header.
386 2007-07-01 John Darrington <john@darrington.wattle.id.au>
388 * transformation.c transformation.h (trns_chain_execute): Changed the
389 signature (Patch #6057)
391 2007-06-10 Ben Pfaff <blp@gnu.org>
393 * casereader-filter.c (casereader_filter_destroy): Make sure to
394 write all the remaining excluded cases to the casewriter, if any.
396 * caseinit.c (init_list_destroy): Rewrite.
397 (init_list_clear): Ditto.
399 * casegrouper.c (casegrouper_get_next_group): Always set *reader
400 to null when returning false.
402 2007-06-06 Ben Pfaff <blp@gnu.org>
404 Actually implement the new procedure code and adapt all of its
405 clients to match. Also adapt all of the other case sources and
406 sinks in the tree and their clients to use the
407 casereader/casewriter infrastructure.
409 * automake.mk: Add and remove files.
411 * any-reader.c: Change into a casereader.
412 * por-file-reader.c: Ditto.
413 * scratch-reader.c: Ditto.
414 * sys-file-reader.c: Ditto.
416 * any-writer.c: Change into a casewriter.
417 * por-file-writer.c: Ditto.
418 * scratch-writer.c: Ditto.
419 * sys-file-writer.c: Ditto.
421 * procedure.c: Change to use casereader, casewriter, caseinit, and
422 other new infrastructure.
424 * scratch-handle.c: Adapt to new infrastructure.
426 * case-sink.c: Removed, now dead code.
427 * case-sink.h: Ditto.
428 * case-source.c: Ditto.
429 * case-source.h: Ditto.
430 * casefile-factory.c: Ditto.
431 * casefile-private.h: Ditto.
434 * casefilter.c: Ditto.
435 * casefilter.h: Ditto.
438 * fastfile-factory.c: Ditto.
439 * fastfile-factory.h: Ditto.
440 * storage-stream.c: Ditto.
441 * storage-stream.h: Ditto.
443 2007-06-06 Ben Pfaff <blp@gnu.org>
447 * automake.mk: Add new files.
449 * datasheet.c: New file.
451 * datasheet.h: New file.
453 2007-06-06 Ben Pfaff <blp@gnu.org>
455 Until now, the procedure code has provided a case to the
456 case_source, which has filled in the data values that come from
457 the active file. "Left" data values that don't come from the
458 active file naturally stay the same from case to case, because the
459 procedure code keeps using that same case.
461 One of the compromises that comes with the new procedure code is
462 that the active file allocates and provides its own case, which
463 the procedure code then has to resize to provide room for any
464 other variables that should go in the case and then fill in the
465 values of "left" variables. Then, when we're done with that case,
466 we have to save the values of "left" variables to copy into the
467 next case read from the active file.
469 The caseinit code helps with this.
471 * automake.mk: Add new files.
473 * caseinit.c: New file.
475 * caseinit.h: New file.
477 2007-06-06 Ben Pfaff <blp@gnu.org>
479 * value.h (value_cnt_from_width): New function.
481 * variable.c (var_get_value_cnt): Use new function.
483 2007-06-06 Ben Pfaff <blp@gnu.org>
485 Add casegrouper, to allow cases read from a given casereader to be
486 broken into groups, each of which has its own casereader.
487 Generally cases are grouped based on having equal values for some
490 * automake.mk: Add new files.
492 * casegrouper.c: New file.
494 * casegrouper.h: New file.
496 2007-06-06 Ben Pfaff <blp@gnu.org>
498 Add interface to lexicographical ordering of cases.
500 * automake.mk: Add new files.
502 * case-ordering.c: New file.
504 * case-ordering.h: New file.
506 2007-06-06 Ben Pfaff <blp@gnu.org>
508 Add casereaders and casewriters, the basis of the new data processing
509 implementation. A casereader is a uniform interface to reading cases
510 from a data source; a casewriter is a uniform interface to writing
511 cases to a data sink.
513 * automake.mk: Add new files.
515 * casereader-filter.c: New file.
517 * casereader-provider.h: New file.
519 * casereader-translator.c: New file.
521 * casereader.c: New file.
523 * casereader.h: New file.
525 * casewriter-provider.h: New file.
527 * casewriter-translator.c: New file.
529 * casewriter.c: New file.
531 * casewriter.h: New file.
533 2007-06-06 Ben Pfaff <blp@gnu.org>
535 "casewindow" data structure that extends the deque (from libpspp)
536 of cases with the ability to dump cases to disk if we get too many
539 * automake.mk: Add new files.
541 * casewindow.c: New file.
543 * casewindow.h: New file.
545 2007-06-06 Ben Pfaff <blp@gnu.org>
547 sparse_cases data structure that augments a sparse_array of cases
548 with the ability to dump cases to disk if we get too many cases in
551 * automake.mk: Add new files.
553 * sparse-cases.c: New file.
555 * sparse-cases.h: New file.
557 2007-06-06 Ben Pfaff <blp@gnu.org>
559 Adds a low-level on-disk case array data structure.
561 * automake.mk: Add new files.
563 * case-tmpfile.c: New file.
565 * case-tmpfile.h: New file.
567 2007-06-06 Ben Pfaff <blp@gnu.org>
569 In a couple of places we calculate the maximum number of cases to
570 keep in memory based on the user-defined workspace. Enable
571 centralizing the calculation through a new function.
573 * settings.c (get_workspace_cases): New function.
575 2007-06-06 Ben Pfaff <blp@gnu.org>
577 The casenumber type is defined in transformations.h, but case.h is
578 a more sensible place. Move it.
580 * case.h (CASENUMBER_MAX): New macro.
581 (typedef casenumber): Move here, from transformations.h.
583 2007-06-03 Ben Pfaff <blp@gnu.org>
585 Slightly generalize case_to_values and case_from_values functions.
587 * case.c (case_to_values): Rename case_copy_out, change interface.
588 (case_from_values): Rename case_copy_in, change interface.
590 * fastfile.c (fastfilereader_get_next_case): Update caller.
591 (write_case_to_disk): Ditto.
593 2007-06-02 Ben Pfaff <blp@gnu.org>
595 Clean up after a forgotten part of patch #5829.
597 * casedeque.h: Remove unused file.
599 * automake.mk: Remove casedeque.h from sources.
601 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
603 * category.c: Removed redundant #include
605 2007-05-06 Ben Pfaff <blp@gnu.org>
607 Abstract the documents within a dictionary a little better.
608 Thanks to John Darrington for suggestion, initial version, and
611 * dictionary.c (struct dictionary): Change `documents' member from
612 char * to struct string.
613 (dict_clear): Destroy struct string.
614 (dict_get_documents): Convert struct string to char *.
615 (dict_set_documents): Set struct string. Pad to 80-character
617 (dict_clear_documents): New function.
618 (dict_add_document_line): New function.
619 (dict_get_document_line_cnt): New function.
620 (dict_get_document_line): New function.
622 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
624 * sys-file-reader.c (read_documents): Use new document functions.
626 2007-04-19 John Darrington <john@darrington.wattle.id.au>
628 * sys-file-reader.c: When reading a system file which has no
629 long name table, automatically create one where the long names
630 are the lower case versions of the short names.
632 2007-04-22 Ben Pfaff <blp@gnu.org>
634 * dictionary.c (dict_set_split_vars): dict_destroy expects that
635 dict_clear will free most data related to the dictionary.
636 dict_clear does a decent job, except that dict_set_split_vars on
637 some systems won't actually free the dict's "split" member.
638 Instead, it'll allocate a 1-byte region. Fix this.
640 * value.c (value_copy): New function.
641 (value_set_missing): Ditto.
643 2007-04-22 John Darrington <john@darrington.wattle.id.au>
645 * Deleted existing category.h and moved cat-routines.h into
646 category.h Encapsulated struct cat_vals better.
648 2007-04-19 John Darrington <john@darrington.wattle.id.au>
650 * sys-file-reader.c: When reading a system file which has no
651 long name table, automatically create one where the long names
652 are the lower case versions of the short names.
654 2007-04-16 John Darrington <john@darrington.wattle.id.au>
656 * sys-file-reader.c: Some versions of Other Software seem to
657 produce system files with string variables' measure set to
658 zero. We'll assume these are supposed to be nominal variables.
660 2007-03-30 Ben Pfaff <blp@gnu.org>
662 * procedure.c: Adapt to new deque data structure.
664 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
665 Ben Pfaff <blp@gnu.org>
667 * file-name.c: Mingw compatibility fixes.
668 (fn_search_path): Use ISSLASH instead of comparing against '/'
670 (fn_dir_name): Use dir_name from gnulib.
671 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
672 (fn_get_identity): Use GetFullPathName instead of canonicalize
673 from gnulib, because the latter does not fully support
674 Windows-style path names. Use this implementation based on the
675 detected presence of Windows instead of the absence of Unix, since
676 the new implementation is Windows-specific.
677 (fn_compare_file_identities): In Windows implementation, compare
678 names case-insensitively.
680 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
682 * make-file.c: Don't include mkstemp.h, because gnulib now causes
683 <stdlib.h> to have the same effect.
685 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
687 * por-file-reader.c: Add missing _() around messages.
689 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
691 * make-file.c: Include "mkstemp.h", without which linking on
694 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
696 Reduce platform dependence.
698 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
699 Everywhere we using this, we really should have just depended on
700 the shell to expand tildes.
701 (fn_search_path): Simplify, given that we don't do tilde expansion
703 (fn_normalize): Removed. Caller changed to use the canonicalize
705 (fn_get_cwd): Removed. Only user was fn_normalize.
706 (fn_is_absolute): Really only test for absolute names.
707 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
709 (fn_readlink): Removed, as it was only used fn_normalize.
710 (fn_exists): Assume the stat function is available; gnulib does.
711 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
713 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
715 * dictionary.c (dict_create_vector_assert): New function.
717 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
719 * file-name.c (fn_normalize): Correct name of function
720 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
721 for pointing this out.
723 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
725 We are using a single member in struct file_handle, the "name"
726 field, for more than one purpose. When it begins with '"', it's a
727 file name; otherwise, it's a token that can be used to identify
728 it. When that assertion fires, it's because we searched for the
729 name case-sensitively as a file name (so that there was no match),
730 and then we try to insert it case-insensitively as a token, which
731 fails because duplicates aren't allowed.
733 Solution: break the two purposes into two separate fields. This
734 fixes the problem and likely makes the code easier to read too.
736 Fixes bug #18922. Thanks to John Darrington for bug report and
739 * file-handle-def.c (struct file_handle): New `id' member.
740 (fh_from_name): Rename fh_from_id. Update all callers.
741 (create_handle): New `id' parameter. Update all callers.
742 (fh_create_file): Ditto.
743 (fh_get_id): New function.
745 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
747 * case.c (case_is_null): Change return type to bool.
749 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
753 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
754 reference counting to share data. This makes it easy for
755 valgrind, etc. to find accesses to cases that have been destroyed
756 but have been kept around by another user's ref-count. This often
757 happens when the data set is small enough to find in memory; if a
758 bigger data set that would overflow to disk were used, then data
759 corruption would occur.
761 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
765 * case.c (case_unshare): Make it check internally whether the
766 ref_cnt is greater than 1, so that the callers don't have to.
767 Update callers not to check.
769 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
771 Before, I was thinking that I might want to get rid of reference
772 counting at some point. Now, I'm pretty sure that it's here to
773 stay. Thus, because we have to store the value_cnt anyway for
774 reference-counted cases, we might as well expose it to users.
776 * case.c (case_get_value_cnt): New function.
777 (case_resize): Drop OLD_CNT argument. Update all callers. Only
778 resize case if its size actually changed.
780 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
781 instead of peeking inside struct case directly.
782 (casefile_append): Ditto.
784 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
786 Get rid of the inlines for the case functions, which made the
787 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
788 the inlines didn't speed up "make check" at all, which is not a
789 perfect benchmark but seems indicative.)
791 * case.c: Remove #ifdef DEBUGGING...#endif around many function
792 definitions. Remove some assertions on nonnull pointers that were
793 redundant with a pointer dereference soon after in the function.
795 (struct case_data): Move definition here from case.h.
799 (case_data_wr): Ditto.
801 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
803 * automake.mk: Add casedeque.h to sources.
805 * casedeque.h: New file.
807 * procedure.c: (struct dataset) Change lag_count, lag_head,
808 lag_queue member into single struct casedeque member. Update all
809 users to use the casedeque instead.
812 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
814 * procedure.c: Simplify lagged cases interface. Updated all
815 clients--well, the only client--to use the simplified interface.
816 (dataset_n_lag) Removed.
817 (dataset_set_n_lag) Removed.
818 (dataset_need_lag) New function.
820 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
822 * dictionary.c procedure.c: More changes to ensure that callbacks occur
823 whenever appropriate, but only when the dataset/dictionary is in a
826 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
828 * dictionary.c dictionary.h : Added callbacks for change of filter and
829 split variables. Refactored some code to ensure that callbacks get
830 invoked when appropriate.
832 * procedure.c (proc_cancel_temporary_transformations): Make sure that
833 replace_dict callback occurs when permanent_dict replaces the current
836 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
838 * dictionary.c dictionary.h : Added callback for when the weight
839 variable of a dictionary changes.
841 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
843 * dictionary.c dictionary.h : Added replace_source and replace_dict
844 callbacks, and functions to deal with them.
846 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
848 Simplify missing value handling.
850 * missing-values.h (enum mv_class): New type.
851 (enum mv_type): Moved definition into missing-values.c and renamed
852 each MV_* to MVT_*, to distinguish them from the exposed mv_class
853 enums. Updated all uses.
854 (struct missing_values): Changed type of `type' from `enum
855 mv_type' to `int' because the definition is no longer exposed.
857 * missing-values.c (mv_is_value_missing): Add new enum mv_class
858 parameter. Update all callers.
859 (mv_is_num_missing): Ditto.
860 (mv_is_str_missing): Ditto.
861 (mv_is_value_user_missing): Removed. Changed callers to use
863 (mv_is_num_user_missing): Removed. Changed callers to use
865 (mv_is_str_user_missing): Removed. Changed callers to use
867 (mv_is_value_system_missing): Removed. Changed callers to use
869 (mv_set_type): Removed. Changed callers to use mv_clear.
870 (mv_clear): New function.
872 * variable.c (var_is_value_missing): Add new enum mv_class
873 parameter. Update all callers.
874 (var_is_num_missing): Ditto.
875 (var_is_str_missing): Ditto.
876 (var_is_value_user_missing): Removed. Changed callers to use
877 var_is_value_missing.
878 (var_is_num_user_missing): Removed. Changed callers to use
880 (var_is_str_user_missing): Removed. Changed callers to use
882 (var_is_value_system_missing): Removed. Changed callers to use
883 var_is_value_missing.
885 * casefilter.c (struct casefilter): Use enum mv_class in place of
887 (casefilter_variable_missing): Adapt to new member.
888 (casefilter_create): Change signature to take enum mv_class,
891 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
893 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
895 * case-sink.c case-sink.h procedure.c procedure.h
896 storage-stream.c: Now uses the factory.
898 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
900 Make it possible to pull cases from the active file with a
901 function call, instead of requiring indirection through a callback
904 * case-source.h (struct case_source_class): Change ->read function
905 to return a single case, instead of calling a callback function
906 for each case. Change ->destroy function to return an error
909 * case-source.c (free_case_source): Pass along the value returned
910 by the case_source ->destroy function.
912 * procedure.c (struct write_case_data): Removed.
913 (struct dataset): Added some members to track procedure state.
914 (procedure): Optimize the trivial case at this level.
915 (internal_procedure): Re-implement in terms of proc_open,
916 proc_read, proc_close.
917 (proc_open) New function.
918 (proc_read) New function.
919 (proc_close) New function.
920 (write_case) Moved into proc_read.
921 (close_active_file) Moved closing of data source into proc_close.
923 * storage-source.c: Rewrote to conform with modified
924 case_source_class interface.
926 * transformations.c (trns_chain_execute): Added argument to allow
927 starting execution from an arbitrary transformation. Updated
930 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
932 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
934 * sys-file-reader.c (read_display_parameters): Don't assume that
935 MEASURE_* and ALIGN_* have the same values found in system files.
937 * sys-file-writer.c (write_variable_display_parameters): Ditto.
939 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
940 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
941 the value of n_MEASURES, which was off by 1 (at least from my
944 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
946 * dictionary.c dictionary.h vardict.h variable.c: Added optional
947 callbacks which are invoked when the dictionary or its
948 variables are changed.
950 * missing-values.c missing-values.h value-labels.c: Tidied up
951 consistency checks, and made some of them return false
952 instead of assert-failing.
954 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
956 * calendar.c (calendar_days_in_month): New function.
958 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
960 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
961 the value label's width.
963 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
965 * sfm-private.h: Move contents into sys-file-writer.c, which is
966 the only remaining user. Removed Borland C++-specific directives.
968 * sys-file-reader.c: Clean up and rewrite entire file. The
969 rewritten version is simpler and better abstracted, and should be
970 easier to maintain and extend. It avoids using structures to read
971 file data, which is prone to padding variations among compilers.
972 It should also handle non-IEEE 754 system files, although I
973 haven't been able to find any. It has been tested against many
974 .sav files obtained from the Web and found to produce the same
975 results as the earlier version of the code, or in some cases
976 improved results. It is more tolerant of format variations found
979 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
980 member, putting an enum integer_format in its place. New member
981 `float_format'. Changed `compressed' member to type bool.
983 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
985 * dictionary.c (dict_delete_consecutive_vars): New function.
987 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
989 * file-name.c (fn_search_path): Remove prefix arg that was unused
990 by any caller. Updated all callers.
992 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
994 * format.c (fmt_dollar_template): Use user's decimal point
995 character. Add assertion.
997 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
999 * format.c (fmt_dollar_template): New function, based on
1000 dollar_format_template from var-type-dialog.c.
1002 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1004 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1007 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1009 Finish converting struct variable to an opaque type. In this
1010 phase, we add remaining setter and getter functions, convert the
1011 remaining PSPP code to use them, and do a bunch of cleanup. The
1012 resulting changes are pervasive but mostly trivial, and only the
1013 notable changes are logged.
1015 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1018 * case.c (case_data): Renamed case_data_idx.
1019 (case_num): Renamed case_num_idx.
1020 (case_str): Renamed case_str_idx.
1021 (case_data_rw): Renamed case_data_rw_idx.
1023 * case.h (case_data): New function with old name and an interface
1024 that takes a variable instead of an index, which is easier to
1025 use. Updated all callers to use the new interface, or to use the
1026 new *_idx function (see above).
1029 (case_data_rw): Ditto.
1031 * category.c (cat_stored_values_destroy): Changed interface to
1032 take a struct cat_vals * instead of a struct variable *.
1034 * dictionary.c (dict_clone): Use new vector_clone function.
1035 (dict_clear) Use new var_destroy function.
1036 (add_var) New function.
1037 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1038 (dict_create_var_assert) Rewrite in terms of add_var.
1039 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1040 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1041 (dict_lookup_var) Use new var_create, var_destroy functions.
1042 (dict_contains_var) Rewrite in terms of new vardict functionality.
1043 (set_var_dict_index) New function.
1044 (set_var_case_index) New function.
1045 (reindex_vars) New function.
1046 (dict_delete_var) Rewrite in terms of new vardict functionality.
1047 (dict_reorder_var) Ditto.
1048 (dict_reorder_vars) Ditto.
1049 (rename_var) New function.
1050 (dict_rename_var) Use rename_var.
1051 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1052 (dict_get_compacted_idx_to_fv) Rename
1053 dict_get_compacted_dict_index_to_case_index, update callers.
1054 (dict_create_vector) Use new vector_create function.
1055 (dict_clear_vectors) Use new vector_destroy function.
1056 (set_var_short_name_suffix) Move here from variable.c, renamed
1057 from var_set_short_name_suffix, make static, update caller.
1059 * sys-file-private.c: New file.
1060 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1061 width_to_bytes, update callers.
1063 * sys-file-private.h: New file. Later it will supplant
1064 sfm-private.h; for now it supplements it.
1065 (macro MIN_VERY_LONG_STRING) New macro.
1066 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1068 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1069 MAX_LONG_STRING was used before.
1071 * sys-file-writer.c: Ditto.
1073 * value-labels.c: Change the paradigm here to be that a null
1074 pointer is OK for a struct val_labs * in most cases; it just
1075 represents an empty set of value labels.
1076 (val_labs_copy) A copy of a null set is a null set.
1077 (val_labs_count) A null set has 0 labels.
1078 (val_labs_replace) Change return type to void. Rewrite for
1080 (val_labs_find) A null set does not contain the value.
1081 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1082 transposed argument order, updated all callers.
1084 * value.c: New file.
1085 (value_dup) Moved here from variable.c.
1086 (compare_values) Ditto.
1089 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1090 (macro MAX_LONG_STRING) Removed, because it was only interesting
1091 for system files, not for general code.
1092 (macro MAX_VERY_LONG_STRING) Ditto.
1093 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1094 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1096 * vardict.h: New file, for an interface between variables and
1099 * variable.c: A lot of functions were moved around, for better
1101 (struct variable) Move definition here, from variable.h.
1102 (var_type_adj) Removed--makes i18n hard.
1103 (var_type_noun) Ditto.
1104 (var_create) New function.
1105 (var_clone) New function.
1106 (var_destroy) New function.
1107 (var_set_name) Assert that variable is not in a dictionary.
1108 (compare_var_names) Rename compare_vars_by_name and fix a couple
1109 of callers who thought the args were strings.
1110 (hash_var_name) Rename hash_var_by_name.
1111 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1112 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1113 (var_is_very_long_string) Removed, because it was only interesting
1114 to system file code.
1115 (var_set_missing_values) Allow the argument to be the wrong width,
1116 as long as we can resize it. Simplify callers who were doing the
1117 resizing themselves.
1118 (var_get_value_labels) New function.
1119 (var_has_value_labels) New function.
1120 (var_set_value_labels) New function.
1121 (alloc_value_labels) New function.
1122 (var_add_value_label) New function.
1123 (var_replace_value_label) New function.
1124 (var_clear_value_labels) New function.
1125 (var_lookup_value_label) New function.
1126 (var_get_value_name) Moved here from variable.c, renamed from
1127 var_get_value_name, transposed argument order, updated all
1129 (var_to_string) Moved here, from variable-label.c.
1130 (var_set_leave) New function.
1131 (var_get_leave) New function.
1132 (var_must_leave) New function.
1133 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1134 set_var_short_name_suffix.
1135 (var_get_dict_index) New function.
1136 (var_get_case_index) New function.
1137 (var_get_obs_vals) New function.
1138 (var_set_obs_vals) New function.
1139 (var_has_obs_vals) New function.
1140 (var_get_vardict) New function.
1141 (var_set_vardict) New function.
1142 (var_has_vardict) New function.
1143 (var_clear_vardict) New function.
1144 (value_dup) Moved to value.c.
1145 (compare_values) Ditto.
1148 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1149 (enum ALPHA) Rename VAR_STRING, update all users.
1151 * vector.c: New file.
1152 (struct vector) Moved here, from variable.h.
1153 (check_widths) New function.
1154 (vector_create) New function.
1155 (vector_clone) New function.
1156 (vector_destroy) New function.
1157 (vector_get_name) New function.
1158 (vector_get_var) New function.
1159 (vector_get_var_cnt) New function.
1160 (compare_vector_ptrs_by_name) New function.
1162 * vector.h: New file.
1164 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1166 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1167 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1170 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1172 * value-labels.c (destroy_atoms): New function.
1173 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1175 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1177 Thanks to Jason Stover for pointing out this problem.
1179 * data-out.c (output_number): Use gsl_finite from GSL, which is
1180 portable, instead of isfinite, which is not.
1183 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1185 * variable.c variable.h (value_dup): New function.
1187 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1189 Start converting struct variable to an opaque type. In this
1190 phase, we add a bunch of setter and getter functions and convert
1191 most of the PSPP code to use them. The resulting changes are
1192 pervasive but mostly trivial, and only the notable changes are
1195 * format.c (fmt_equal): New function.
1197 * variable.c (var_type_is_valid): New function.
1198 (measure_is_valid) Moved here, from format.c.
1199 (alignment_is_valid) Moved here, from format.c.
1200 (var_get_name) New function.
1201 (var_set_name) New function.
1202 (width_to_type) New function.
1203 (var_get_type) New function.
1204 (var_get_width) New function.
1205 (var_set_width) New function.
1206 (var_is_numeric) New function.
1207 (var_is_alpha) New function.
1208 (var_is_short_string) New function.
1209 (var_is_long_string) New function.
1210 (var_is_very_long_string) New function.
1211 (var_get_missing_values) New function.
1212 (var_set_missing_values) New function.
1213 (var_clear_missing_values) New function.
1214 (var_has_missing_values) New function.
1215 (var_is_value_missing) New function.
1216 (var_is_num_missing) New function.
1217 (var_is_str_missing) New function.
1218 (var_is_value_user_missing) New function.
1219 (var_is_num_user_missing) New function.
1220 (var_is_str_user_missing) New function.
1221 (var_is_value_system_missing) New function.
1222 (var_get_print_format) New function.
1223 (var_set_print_format) New function.
1224 (var_get_write_format) New function.
1225 (var_set_write_format) New function.
1226 (var_set_both_formats) New function.
1227 (var_get_label) New function.
1228 (var_set_label) New function.
1229 (var_clear_label) New function.
1230 (var_has_label) New function.
1231 (var_get_measure) New function.
1232 (var_set_measure) New function.
1233 (var_get_display_width) New function.
1234 (var_set_display_width) New function.
1235 (var_get_alignment) New function.
1236 (var_set_alignment) New function.
1237 (var_get_value_cnt) New function.
1238 (var_get_leave) New function.
1239 (var_get_short_name) New function.
1241 * variable.h: (struct variable) Removed "type" and "nv" members;
1242 they are now computed from "width" where needed.
1244 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1246 * missing-values.c (mv_resize): Don't write beyond end of the
1247 allocated buffer when resizing a long string.
1249 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1251 Clean up identifier code: don't require identifier enumerations to
1252 be in a particular order; make better use of string library;
1253 expose less of the internals.
1255 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1256 change interface. Updated all callers.
1257 (lex_id_match) Change interface to use struct substring, update
1259 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1260 (global array keywords[]) Make static, change form. Update all
1261 users to use lex_id_name instead.
1262 (lex_is_keyword) New function.
1263 (lex_id_to_token) Change interface to use struct substring, update
1265 (lex_id_name) New function.
1267 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1268 lex_is_keyword instead.
1269 (T_LAST_KEYWORD) Removed.
1270 (T_N_KEYWORDS) Removed.
1272 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1274 * format.c: (fmt_date_template) Distinguish characters for which a
1275 space is output and any date delimiter is allowed on input, from
1276 those for which a space is output and only a space is allowed on
1277 input. The former is represented by X, the latter by a space.
1278 Also, drop distinction between h and H, changing the former to the
1281 * data-in.c: Completely rewrite internals to conform to SPSS input
1282 formats as closely as possible.
1283 (data_in) Changed external interface by replacing the structure
1284 that was used as a single argument by a set of arguments. Updated
1286 (data_in_finite_line) Removed. Converted all callers to use plain
1288 (data_in_get_integer_format) New function.
1289 (data_in_set_integer_format) New function.
1290 (data_in_get_float_format) New function.
1291 (data_in_set_float_format) New function.
1293 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1294 (struct data_in) Removed.
1296 * data-out.c: (output_date) Drop each component from the input as
1297 it is output, to allow us to drop the distinction between h (a
1298 count of hours) and H (the hour of day) template characters.
1299 Also, handle new X template character.
1300 (output_scientific) Follow more rational rule on when to drop
1301 fraction introduced between SPSS 13 and 15. Updated test case to
1304 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1306 Fix buffer overflow reported by John Darrington.
1308 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1309 realize that DIGITS is a count of nibbles, not of bytes.
1311 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1313 * calendar.c (calendar_offset_to_gregorian) Also return the
1314 year-of-day. Change callers to new interface.
1316 * data-out.c: Completely rewrite internals to conform to SPSS
1317 output formats as completely as possible.
1318 (data_out) Change interface to put input parameters before output
1319 parameters, for consistency with the style I now prefer. Update
1321 (data_out_get_integer_format) New public function.
1322 (data_out_set_integer_format) New public function.
1323 (data_out_get_float_format) New public function.
1324 (data_out_set_float_format) New public function.
1326 * data-out.h: New file. Move prototype for data_out here, from
1329 * format.c: (fmt_step_width) Use equality comparison instead of
1330 bitwise and, for clarity.
1331 (fmt_is_string) Ditto.
1332 (fmt_input_to_output) Fix categories that are translated to F
1335 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1337 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1338 casefile-private.h: Added casefilter to assist commands with missing
1341 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1343 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1345 * settings.c: (route_errors_to_terminal) New variable.
1346 (route_errors_to_listing) New variable.
1347 (get_error_routing_to_terminal) New function.
1348 (set_error_routing_to_terminal) New function.
1349 (get_error_routing_to_listing) New function.
1350 (set_error_routing_to_listing) New function.
1352 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1354 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1356 * format.c: Completely rewrite, to achieve better abstraction.
1357 Rewrite all references to formats in other files.
1359 * format.def: Rewrite and reorganize.
1361 * settings.c: Move everything related to custom currency formats
1362 into format.[ch], changing them in form, so as to group related
1363 code and definitions better. Changed all references to use the
1365 (static var decimal) Removed.
1366 (static var grouping) Removed.
1367 (static var cc) Removed.
1368 (get_decimal) Removed.
1369 (set_decimal) Removed.
1370 (get_grouping) Removed.
1371 (set_grouping) Removed.
1375 * settings.h: (macro CC_CNT) Removed.
1376 (macro CC_WIDTH) Removed.
1377 (struct custom_currency) Removed.
1379 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1381 * data-in.c (data_in): Use switch statement instead of table, to
1382 avoid dependence on the order of the FMT_* enums.
1384 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1386 * data-out.c: (num_to_string) Removed, because it was dead code.
1388 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1390 * data-in.c (parse_trailer): Fix error message.
1392 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1394 * format.c (fmt_is_binary): New function.
1396 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1398 * procedure.c procedure.h: Encapsulated the static data into a single
1401 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1403 * casefile.c (casereader_read_xfer): Always initialize the case,
1404 even on an error condition.
1406 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1408 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1409 entire function useless.
1411 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1413 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1414 casereader method casereader_clone.
1416 * procedure.c pransformations.h: Introduced new type casenum_t
1418 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1420 * variable.c: (width_to_bytes) Rephrase code for clarify.
1422 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1424 * format.c: (fmt_type_from_string) New function.
1425 (fmt_to_string) Include decimals in output if the format has
1426 decimals, even if the format type does not. This way, we can
1427 accurately reproduce incorrect formats in user output.
1428 (check_common_specifier) Make the check for a bad format type an
1429 assertion, so we get bug reports if they show up. Fix message.
1430 Check for decimal places with a format type that doesn't allow
1432 (check_input_specifier) Remove check for FMT_X, which has been
1434 (check_output_specifier) Ditto.
1436 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1438 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1439 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1440 (enum fmt_parse_flags) Removed.
1442 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1444 * casefile.c casefile.h: Converted to an abstract base class.
1445 * casefile-private.h fastfile.c fastfile.h: New files.
1446 * automake.mk procedure.c scratch-writer.c storage-stream.c
1448 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1450 * procedure.c (internal_procedure): Create sink_case with only as
1451 many values as the compacted dictionary.
1453 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1455 Remove "debugging" code that caused plenty of false positives and
1458 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1460 * case.c: Remove all references to `this' member.
1462 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1464 Fix link error noted by Jason Stover.
1466 * storage-stream.c: Include <assert.h>.
1468 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1470 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1471 ALL) and additional underlying system file issues.
1473 Thanks to John Darrington for review.
1475 First problem: var_hash points to variables not owned by the
1476 sys-file-reader, which the caller may free or modify. Use an
1477 array of sfm_vars instead, as done earlier (e.g. CVS version
1480 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1481 members and remove all code that references it. Add vars, var_cnt
1482 members. Remove fix_specials member, which was unused.
1483 (struct sfm_var) Remove name member, which was unused.
1484 (sfm_close_reader) Free vars member instead of var_hash.
1485 (compare_var_shortnames) Removed.
1486 (hash_var_shortname) Removed.
1487 (sfm_open_reader) Fill out vars array.
1488 (compare_var_index) Removed.
1489 (sfm_read_case) Use vars instead of var_hash.
1491 Second problem: we're confused about when we actually have very
1492 long strings, causing us to choose incorrectly between slow path
1493 and fast path in sfm_read_case.
1495 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1496 have very long strings, not when we have long variable names,
1497 which is an unrelated feature.
1499 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1501 * variable.h: Move var_set and variable parsing declarations to
1502 new header, src/language/lexer/variable-parser.h. Modified lots
1503 of files to include the new header.
1505 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1507 * value-labels.c (value_to_string): When there's no value label,
1508 format the variable according to its print format, instead of
1509 always effectively using A or F format.
1511 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1513 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1516 * format.c: Removed tortological assertion.
1518 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1520 Reform string library.
1522 * file-name.c (fn_interp_vars): Change interface to take a
1523 substring as input. Updated all users.
1525 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1527 * format.c (measure_is_valid): Really return false when m >=
1530 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1532 Implement random access to casefiles, for use in GUI.
1534 * casefile.c: (struct casereader) Add `random', `file_ofs',
1535 `buffer_ofs' members.
1536 (casefile_get_random_reader) New function.
1537 (read_open_file) Break part into new function
1538 seek_and_fill_buffer().
1539 (fill_buffer) Update buffer_ofs, file_ofs.
1540 (casereader_seek) New function.
1542 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1544 * settings.c: Added call to i18n{done, init}.
1546 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1548 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1551 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1553 * casefile.c: Convert many uses of `int' to `bool'.
1555 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1557 * transformations.c (trns_chain_destroy): Destroy chain's trns
1558 member, to fix memory leak.
1560 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1562 * storage-stream.c (storage_source_decapsulate): Destroy case
1563 source to fix memory leak.
1565 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1567 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1568 case passed as argument instead of initializing the argument as a
1569 case. Fixes memory leak that showed up in
1570 tests/command/aggregate.sh with scratch files.
1572 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1574 * procedure.c (proc_done): Destroy default_dict, to fix memory
1577 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1579 Simplify procedure_with_splits().
1581 * procedure.c (struct split_aux_data): Removed case_count member.
1582 (procedure_with_splits) Don't initialize case_count.
1583 (split_procedure_case_func) Check whether prev_case is null
1584 instead of case_count.
1585 (split_procedure_end_func) Ditto.
1587 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1589 * case.c (case_move): Do nothing if dst and src are the same
1591 (case_try_create) Merge two similar cases.
1592 (case_copy) Unshare only if data must be actually copied.
1594 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1596 * data-in.c data-out.c dictionary.c sys-file-reader.c
1597 sys-file-writer.c variable.c variable.h: Reworked very long string
1598 support for better encapsulation.
1600 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1602 * value-labels.c (val_labs_can_set_width): New function.
1603 (val_labs_set_width) Clear labels if increasing width to long
1605 (val_labs_destroy) Remove unneeded test for null.
1607 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1609 * value-labels.h: Remove unneeded dependency on variable.h.
1611 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1613 Get rid of `char *c' member in union value, for cleanliness.
1615 * value.h: (union value) Remove `c' member.
1617 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1619 Make dictionary compacting functions a little more general.
1621 * sys-file-writer.c (sfm_open_writer): Use
1622 dict_compacting_would_change().
1623 (does_dict_need_translation) Removed.
1625 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1627 Make dictionary compacting functions a little more general.
1629 * dictionary.c (dict_needs_compaction): Rename
1630 dict_compacting_would_shrink(). Update all callers.
1631 (dict_compacting_would_change) New function.
1633 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1635 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1636 inverted return value (!).
1638 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1640 Continue reforming procedure execution.
1642 * procedure.c: Search and replace "vfm" by "proc". Notably:
1643 (static var vfm_source) Rename proc_source. Update all
1645 (static var vfm_sink) Rename proc_sink. Update all references.
1647 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1649 Continue reforming procedure execution. In this phase, remove
1650 PROCESS IF, which was deprecated anyway and can be easily
1651 simulated with TEMPORARY followed by SELECT IF.
1653 * procedure.c: (open_active_file) Don't call
1654 add_process_if_trns().
1655 (discard_variables) Get rid of redundant call to
1656 proc_cancel_all_transformations().
1657 (add_process_if_trns) Removed.
1658 (process_if_trns_proc) Removed.
1659 (process_if_trns_free) Removed.
1661 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1663 Continue reforming procedure execution. In this phase, add
1664 `const' to the case passed to procedure()'s callback.
1666 Updated all users of procedure() as well.
1668 * procedure.c: (struct write_case_data) Add "const" to ccase
1669 parameter for case_func member.
1670 (procedure) Add "const" to ccase parameter for proc_func
1672 (multipass_case_func) Make ccase parameter const.
1673 (internal_procedure) Add "const" to ccase parameter for case_func
1675 (split_procedure_case_func) Make ccase parameter const.
1676 (multipass_split_case_func) Make ccase parameter const.
1678 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1680 Continue reforming procedure execution. In this phase, get rid of
1681 the output code for SPLIT FILE groups in procedure.c, which really
1682 shouldn't be doing any output. Move it into the individual
1683 procedures instead. This also adds some flexibility.
1685 Updated many users of procedure_with_splits() and
1686 multipass_procedure_with_splits() to call
1687 output_split_file_values() and to deal with increased use of
1690 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1691 parameter to begin_func member.
1692 (procedure_with_splits) Add "const struct ccase *" parameter to
1693 begin_func parameter. Make ccase parameter const in proc_func
1695 (split_procedure_case_func) Don't dump split file group. Pass
1697 (dump_splits) Moved to language/dictionary/split-file.c as
1698 output_split_file_values().
1699 (struct multipass_split_aux_data) Add "const struct ccase *"
1700 parameter to split_func member.
1701 (multipass_procedure_with_splits) Add "const struct ccase *"
1702 parameter to split_func parameter.
1703 (multipass_split_case_func) Save new SPLIT FILE case before
1705 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1707 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1709 Continue reforming procedure execution. Change
1710 internal_procedure() so that it calls open_active_file() and
1711 close_active_file(), which isolates most of the actual procedure
1714 * procedure.c: (struct write_case_data) Rename `proc_func' member
1715 to `case_func' and update all references.
1716 (procedure) Rewrite as one-line wrapper around
1717 internal_procedure().
1718 (struct multipass_aux_data) New.
1719 (multipass_callback) Renamed multipass_case_func(). Use struct
1720 multipass_aux_data as auxiliary data.
1721 (multipass_end_func) New function.
1722 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1723 that uses multipass_case_func, multipass_end_func.
1724 (internal_procedure) Add `end_func' argument. Move optimization
1725 of trivial case in here. Move call to open_active_file() and
1726 close_active_file() in here. Now assert that vfm_source is
1728 (procedure_with_splits_callback) Rename
1729 split_procedure_case_func().
1730 (split_procedure_end_func) New function.
1731 (multipass_split_callback) Rename multipass_split_case_func.
1732 (multipass_split_end_func) New function.
1733 (discard_variables) No need to test for nonnull vfm_source.
1735 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1737 Continue reforming procedure execution. Get rid of unused member.
1739 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1741 (write_case) Don't increment cases_analyzed.
1743 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1745 Continue reforming procedure execution. In this phase, move
1746 procedure.c and procedure.h from src to src/data. Update
1747 makefiles and #includes accordingly.
1749 * procedure.c: Moved here from src/.
1751 * procedure.h: Moved here from src/.
1753 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1755 Continue reforming procedure execution. In this phase, get rid of
1756 many global variables, consolidating procedure execution in
1757 procedure.c. Encapsulate transformations in new "struct
1758 trns_chain". Also, change implementation of N OF CASES, FILTER,
1759 and PROCESS IF from special cases to transformations.
1761 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1764 * dictionary.c: (global variable default_dict) Move to
1767 * variable.h: (TRNS_*) Move to transformations.h.
1768 (struct transformation) Move to transformations.c.
1770 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1772 * sys-file-reader.c: Fixed invalid read problems.
1774 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1776 * storage-stream.c: Add missing function comments.
1778 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1780 Continue reforming procedure execution. In this phase, add some
1781 new, needed functionality to storage-stream.
1783 * storage-stream.c: (storage_source_decapsulate) New function.
1785 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1787 * variable.c (width_to_bytes): Declarations must precede
1788 statements for C90 compliance.
1790 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1792 * data-out.c, data-in.c, variable.c, variable.h: New functions
1793 copy_mangle and copy_demangle for reading/writing cases; emulates the
1794 way SPSS deals with strings > 255 bytes.
1796 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1797 subtype 14 needed for strings longer than 255 bytes.
1799 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1800 instead of literal values. Also fixed some constness issues.
1802 * format.h: Constness
1804 * sfm-private.h: Renamed the case_size identifier, since I discovered
1805 that SPSS's respect for this variable is very nominal.
1807 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1809 Change case limit type from int to size_t.
1811 * dictionary.c: (struct dictionary) Change type of case_limit
1813 (dict_get_case_limit) Change return type.
1814 (dict_set_case_limit) Change parameter type.
1816 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1818 * variable.h: (struct variable) Rename `reinit' member as `leave'
1819 and invert sense. Fix up all references.
1821 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1823 Continue reforming procedure execution. In this phase, break
1824 procedure.c into multiple files.
1826 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1828 * case-sink.c: New file.
1830 * case-sink.h: New file.
1832 * case-source.c: New file.
1834 * case-source.h: New file.
1836 * storage-stream.c: New file.
1838 * storage-stream.h: New file.
1840 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1842 * variable.h: (struct variable) Remove `init' member and all
1843 references to it from other files. It was initialized in several
1844 places, but nothing really ever used it for anything worthwhile.
1845 Thanks to Jason Stover for pointing out how confusing this
1848 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1850 Continue reforming error message support. In this phase, get rid
1851 of message "titles" and put the message text in `struct error'.
1852 Now `struct error' encapsulates a message more properly.
1854 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1855 Format message ourselves.
1857 * data-in.c: (vdls_error) Ditto.
1859 * por-file-reader.c: (error) Ditto.
1861 * sys-file-reader.c: (corrupt_msg) Ditto.
1863 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1865 GNU standards require "file name" instead of "filename" in
1866 documentation. It's nice for our code to follow the convention
1869 * casefile.c: (struct casefile) Rename `filename' member to
1870 `file_name'. Updated all references.
1872 * file-name.c: [!unix] (struct file_identity) Rename
1873 normalized_filename member to normalized_file_name. Updated all
1876 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1878 We don't really support anything but Unix-like environments well,
1879 so we might as well de-obfuscate by writing directory and path
1880 separators explicitly.
1882 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1884 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1885 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1887 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1890 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1892 GNU standards require "file name" instead of "filename" in
1893 documentation. It's nice for our code to follow the convention
1896 * filename.c: Rename to file-name.c.
1898 * filename.h: Rename to file-name.h. Update all inclusions.
1899 Update header guards.
1901 * automake.mk: Update file names.
1903 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1905 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1907 (fn_basename) Removed (dead code).
1908 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1909 (fn_special_p) Renamed fn_is_special(), all references updated.
1910 (fn_exists_p) Renamed fn_exists(), all references updated.
1912 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1914 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1915 Also, now it only tilde-expands file names, not paths.
1916 (fn_search_path) Tilde-expand one directory at a time.
1918 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1920 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1921 get rid of non-Unixlike version of the code, which has probably
1923 (fn_prepend_dir) Removed (dead code).
1925 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1926 (macro PATH_SEPARATOR_STRING) New.
1927 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1929 Continue reforming error message support. In this phase, we get
1930 rid of VM() and the other msg() support for "verbosity", replacing
1931 it by a new function verbose_msg().
1933 * filename.c: (fn_search_path) Use verbose_msg() instead of
1936 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1938 * sfm-private.h: Get rid of #defines after #error, which makes no
1941 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1943 Get rid of our own int32 type in favor of the standard int32_t
1946 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1949 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1951 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1953 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1955 Remove ill-considered file routines that are no longer used.
1957 * filename.c: (fn_open_ext) Removed.
1958 (fn_close_ext) Removed.
1960 * filename.h: (struct file_ext) Removed.
1962 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1964 * variable.c (var_is_valid_name): Move declarations before code
1967 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1969 * filename.ch (fn_interp_vars): Fixed small buglet.
1971 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1973 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1974 so as to modify the string inline. Thus makeing it easier to
1975 destroy the results when no longer needed.
1977 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1979 * category.c (cat_stored_values_destroy): Fixed memory leak.
1981 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1983 Add some missing frees. Thanks to John Darrington for reporting
1986 * any-writer.c (any_writer_close): Free writer.
1988 * any-reader.c (any_reader_close): Free reader.
1990 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1992 * por-file-reader.c: (error) Mark as NO_RETURN.
1994 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1996 * settings.c: Changed default value of scompress to true.
1998 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
2000 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
2002 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2005 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2006 here from pref.h.orig.
2008 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2010 * sys-file-reader.c: Fixed bug reading compressed files.
2012 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2014 * Numerous renames. See src/ChangeLog for details.
2016 * Moved files from src directory