1 2007-06-06 Ben Pfaff <blp@gnu.org>
3 Actually implement the new procedure code and adapt all of its
4 clients to match. Also adapt all of the other case sources and
5 sinks in the tree and their clients to use the
6 casereader/casewriter infrastructure.
8 * automake.mk: Add and remove files.
10 * any-reader.c: Change into a casereader.
11 * por-file-reader.c: Ditto.
12 * scratch-reader.c: Ditto.
13 * sys-file-reader.c: Ditto.
15 * any-writer.c: Change into a casewriter.
16 * por-file-writer.c: Ditto.
17 * scratch-writer.c: Ditto.
18 * sys-file-writer.c: Ditto.
20 * procedure.c: Change to use casereader, casewriter, caseinit, and
21 other new infrastructure.
23 * scratch-handle.c: Adapt to new infrastructure.
25 * case-sink.c: Removed, now dead code.
27 * case-source.c: Ditto.
28 * case-source.h: Ditto.
29 * casefile-factory.c: Ditto.
30 * casefile-private.h: Ditto.
33 * casefilter.c: Ditto.
34 * casefilter.h: Ditto.
37 * fastfile-factory.c: Ditto.
38 * fastfile-factory.h: Ditto.
39 * storage-stream.c: Ditto.
40 * storage-stream.h: Ditto.
42 2007-06-06 Ben Pfaff <blp@gnu.org>
46 * automake.mk: Add new files.
48 * datasheet.c: New file.
50 * datasheet.h: New file.
52 2007-06-06 Ben Pfaff <blp@gnu.org>
54 Until now, the procedure code has provided a case to the
55 case_source, which has filled in the data values that come from
56 the active file. "Left" data values that don't come from the
57 active file naturally stay the same from case to case, because the
58 procedure code keeps using that same case.
60 One of the compromises that comes with the new procedure code is
61 that the active file allocates and provides its own case, which
62 the procedure code then has to resize to provide room for any
63 other variables that should go in the case and then fill in the
64 values of "left" variables. Then, when we're done with that case,
65 we have to save the values of "left" variables to copy into the
66 next case read from the active file.
68 The caseinit code helps with this.
70 * automake.mk: Add new files.
72 * caseinit.c: New file.
74 * caseinit.h: New file.
76 2007-06-06 Ben Pfaff <blp@gnu.org>
78 * value.h (value_cnt_from_width): New function.
80 * variable.c (var_get_value_cnt): Use new function.
82 2007-06-06 Ben Pfaff <blp@gnu.org>
84 Add casegrouper, to allow cases read from a given casereader to be
85 broken into groups, each of which has its own casereader.
86 Generally cases are grouped based on having equal values for some
89 * automake.mk: Add new files.
91 * casegrouper.c: New file.
93 * casegrouper.h: New file.
95 2007-06-06 Ben Pfaff <blp@gnu.org>
97 Add interface to lexicographical ordering of cases.
99 * automake.mk: Add new files.
101 * case-ordering.c: New file.
103 * case-ordering.h: New file.
105 2007-06-06 Ben Pfaff <blp@gnu.org>
107 Add casereaders and casewriters, the basis of the new data processing
108 implementation. A casereader is a uniform interface to reading cases
109 from a data source; a casewriter is a uniform interface to writing
110 cases to a data sink.
112 * automake.mk: Add new files.
114 * casereader-filter.c: New file.
116 * casereader-provider.h: New file.
118 * casereader-translator.c: New file.
120 * casereader.c: New file.
122 * casereader.h: New file.
124 * casewriter-provider.h: New file.
126 * casewriter-translator.c: New file.
128 * casewriter.c: New file.
130 * casewriter.h: New file.
132 2007-06-06 Ben Pfaff <blp@gnu.org>
134 "casewindow" data structure that extends the deque (from libpspp)
135 of cases with the ability to dump cases to disk if we get too many
138 * automake.mk: Add new files.
140 * casewindow.c: New file.
142 * casewindow.h: New file.
144 2007-06-06 Ben Pfaff <blp@gnu.org>
146 sparse_cases data structure that augments a sparse_array of cases
147 with the ability to dump cases to disk if we get too many cases in
150 * automake.mk: Add new files.
152 * sparse-cases.c: New file.
154 * sparse-cases.h: New file.
156 2007-06-06 Ben Pfaff <blp@gnu.org>
158 Adds a low-level on-disk case array data structure.
160 * automake.mk: Add new files.
162 * case-tmpfile.c: New file.
164 * case-tmpfile.h: New file.
166 2007-06-06 Ben Pfaff <blp@gnu.org>
168 In a couple of places we calculate the maximum number of cases to
169 keep in memory based on the user-defined workspace. Enable
170 centralizing the calculation through a new function.
172 * settings.c (get_workspace_cases): New function.
174 2007-06-06 Ben Pfaff <blp@gnu.org>
176 The casenumber type is defined in transformations.h, but case.h is
177 a more sensible place. Move it.
179 * case.h (CASENUMBER_MAX): New macro.
180 (typedef casenumber): Move here, from transformations.h.
182 2007-06-03 Ben Pfaff <blp@gnu.org>
184 Slightly generalize case_to_values and case_from_values functions.
186 * case.c (case_to_values): Rename case_copy_out, change interface.
187 (case_from_values): Rename case_copy_in, change interface.
189 * fastfile.c (fastfilereader_get_next_case): Update caller.
190 (write_case_to_disk): Ditto.
192 2007-06-02 Ben Pfaff <blp@gnu.org>
194 Clean up after a forgotten part of patch #5829.
196 * casedeque.h: Remove unused file.
198 * automake.mk: Remove casedeque.h from sources.
200 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
202 * category.c: Removed redundant #include
204 2007-05-06 Ben Pfaff <blp@gnu.org>
206 Abstract the documents within a dictionary a little better.
207 Thanks to John Darrington for suggestion, initial version, and
210 * dictionary.c (struct dictionary): Change `documents' member from
211 char * to struct string.
212 (dict_clear): Destroy struct string.
213 (dict_get_documents): Convert struct string to char *.
214 (dict_set_documents): Set struct string. Pad to 80-character
216 (dict_clear_documents): New function.
217 (dict_add_document_line): New function.
218 (dict_get_document_line_cnt): New function.
219 (dict_get_document_line): New function.
221 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
223 * sys-file-reader.c (read_documents): Use new document functions.
225 2007-04-19 John Darrington <john@darrington.wattle.id.au>
227 * sys-file-reader.c: When reading a system file which has no
228 long name table, automatically create one where the long names
229 are the lower case versions of the short names.
231 2007-04-22 Ben Pfaff <blp@gnu.org>
233 * dictionary.c (dict_set_split_vars): dict_destroy expects that
234 dict_clear will free most data related to the dictionary.
235 dict_clear does a decent job, except that dict_set_split_vars on
236 some systems won't actually free the dict's "split" member.
237 Instead, it'll allocate a 1-byte region. Fix this.
239 * value.c (value_copy): New function.
240 (value_set_missing): Ditto.
242 2007-04-22 John Darrington <john@darrington.wattle.id.au>
244 * Deleted existing category.h and moved cat-routines.h into
245 category.h Encapsulated struct cat_vals better.
247 2007-04-19 John Darrington <john@darrington.wattle.id.au>
249 * sys-file-reader.c: When reading a system file which has no
250 long name table, automatically create one where the long names
251 are the lower case versions of the short names.
253 2007-04-16 John Darrington <john@darrington.wattle.id.au>
255 * sys-file-reader.c: Some versions of Other Software seem to
256 produce system files with string variables' measure set to
257 zero. We'll assume these are supposed to be nominal variables.
259 2007-03-30 Ben Pfaff <blp@gnu.org>
261 * procedure.c: Adapt to new deque data structure.
263 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
264 Ben Pfaff <blp@gnu.org>
266 * file-name.c: Mingw compatibility fixes.
267 (fn_search_path): Use ISSLASH instead of comparing against '/'
269 (fn_dir_name): Use dir_name from gnulib.
270 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
271 (fn_get_identity): Use GetFullPathName instead of canonicalize
272 from gnulib, because the latter does not fully support
273 Windows-style path names. Use this implementation based on the
274 detected presence of Windows instead of the absence of Unix, since
275 the new implementation is Windows-specific.
276 (fn_compare_file_identities): In Windows implementation, compare
277 names case-insensitively.
279 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
281 * make-file.c: Don't include mkstemp.h, because gnulib now causes
282 <stdlib.h> to have the same effect.
284 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
286 * por-file-reader.c: Add missing _() around messages.
288 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
290 * make-file.c: Include "mkstemp.h", without which linking on
293 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
295 Reduce platform dependence.
297 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
298 Everywhere we using this, we really should have just depended on
299 the shell to expand tildes.
300 (fn_search_path): Simplify, given that we don't do tilde expansion
302 (fn_normalize): Removed. Caller changed to use the canonicalize
304 (fn_get_cwd): Removed. Only user was fn_normalize.
305 (fn_is_absolute): Really only test for absolute names.
306 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
308 (fn_readlink): Removed, as it was only used fn_normalize.
309 (fn_exists): Assume the stat function is available; gnulib does.
310 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
312 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
314 * dictionary.c (dict_create_vector_assert): New function.
316 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
318 * file-name.c (fn_normalize): Correct name of function
319 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
320 for pointing this out.
322 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
324 We are using a single member in struct file_handle, the "name"
325 field, for more than one purpose. When it begins with '"', it's a
326 file name; otherwise, it's a token that can be used to identify
327 it. When that assertion fires, it's because we searched for the
328 name case-sensitively as a file name (so that there was no match),
329 and then we try to insert it case-insensitively as a token, which
330 fails because duplicates aren't allowed.
332 Solution: break the two purposes into two separate fields. This
333 fixes the problem and likely makes the code easier to read too.
335 Fixes bug #18922. Thanks to John Darrington for bug report and
338 * file-handle-def.c (struct file_handle): New `id' member.
339 (fh_from_name): Rename fh_from_id. Update all callers.
340 (create_handle): New `id' parameter. Update all callers.
341 (fh_create_file): Ditto.
342 (fh_get_id): New function.
344 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
346 * case.c (case_is_null): Change return type to bool.
348 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
352 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
353 reference counting to share data. This makes it easy for
354 valgrind, etc. to find accesses to cases that have been destroyed
355 but have been kept around by another user's ref-count. This often
356 happens when the data set is small enough to find in memory; if a
357 bigger data set that would overflow to disk were used, then data
358 corruption would occur.
360 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
364 * case.c (case_unshare): Make it check internally whether the
365 ref_cnt is greater than 1, so that the callers don't have to.
366 Update callers not to check.
368 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
370 Before, I was thinking that I might want to get rid of reference
371 counting at some point. Now, I'm pretty sure that it's here to
372 stay. Thus, because we have to store the value_cnt anyway for
373 reference-counted cases, we might as well expose it to users.
375 * case.c (case_get_value_cnt): New function.
376 (case_resize): Drop OLD_CNT argument. Update all callers. Only
377 resize case if its size actually changed.
379 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
380 instead of peeking inside struct case directly.
381 (casefile_append): Ditto.
383 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
385 Get rid of the inlines for the case functions, which made the
386 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
387 the inlines didn't speed up "make check" at all, which is not a
388 perfect benchmark but seems indicative.)
390 * case.c: Remove #ifdef DEBUGGING...#endif around many function
391 definitions. Remove some assertions on nonnull pointers that were
392 redundant with a pointer dereference soon after in the function.
394 (struct case_data): Move definition here from case.h.
398 (case_data_wr): Ditto.
400 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
402 * automake.mk: Add casedeque.h to sources.
404 * casedeque.h: New file.
406 * procedure.c: (struct dataset) Change lag_count, lag_head,
407 lag_queue member into single struct casedeque member. Update all
408 users to use the casedeque instead.
411 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
413 * procedure.c: Simplify lagged cases interface. Updated all
414 clients--well, the only client--to use the simplified interface.
415 (dataset_n_lag) Removed.
416 (dataset_set_n_lag) Removed.
417 (dataset_need_lag) New function.
419 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
421 * dictionary.c procedure.c: More changes to ensure that callbacks occur
422 whenever appropriate, but only when the dataset/dictionary is in a
425 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
427 * dictionary.c dictionary.h : Added callbacks for change of filter and
428 split variables. Refactored some code to ensure that callbacks get
429 invoked when appropriate.
431 * procedure.c (proc_cancel_temporary_transformations): Make sure that
432 replace_dict callback occurs when permanent_dict replaces the current
435 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
437 * dictionary.c dictionary.h : Added callback for when the weight
438 variable of a dictionary changes.
440 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
442 * dictionary.c dictionary.h : Added replace_source and replace_dict
443 callbacks, and functions to deal with them.
445 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
447 Simplify missing value handling.
449 * missing-values.h (enum mv_class): New type.
450 (enum mv_type): Moved definition into missing-values.c and renamed
451 each MV_* to MVT_*, to distinguish them from the exposed mv_class
452 enums. Updated all uses.
453 (struct missing_values): Changed type of `type' from `enum
454 mv_type' to `int' because the definition is no longer exposed.
456 * missing-values.c (mv_is_value_missing): Add new enum mv_class
457 parameter. Update all callers.
458 (mv_is_num_missing): Ditto.
459 (mv_is_str_missing): Ditto.
460 (mv_is_value_user_missing): Removed. Changed callers to use
462 (mv_is_num_user_missing): Removed. Changed callers to use
464 (mv_is_str_user_missing): Removed. Changed callers to use
466 (mv_is_value_system_missing): Removed. Changed callers to use
468 (mv_set_type): Removed. Changed callers to use mv_clear.
469 (mv_clear): New function.
471 * variable.c (var_is_value_missing): Add new enum mv_class
472 parameter. Update all callers.
473 (var_is_num_missing): Ditto.
474 (var_is_str_missing): Ditto.
475 (var_is_value_user_missing): Removed. Changed callers to use
476 var_is_value_missing.
477 (var_is_num_user_missing): Removed. Changed callers to use
479 (var_is_str_user_missing): Removed. Changed callers to use
481 (var_is_value_system_missing): Removed. Changed callers to use
482 var_is_value_missing.
484 * casefilter.c (struct casefilter): Use enum mv_class in place of
486 (casefilter_variable_missing): Adapt to new member.
487 (casefilter_create): Change signature to take enum mv_class,
490 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
492 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
494 * case-sink.c case-sink.h procedure.c procedure.h
495 storage-stream.c: Now uses the factory.
497 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
499 Make it possible to pull cases from the active file with a
500 function call, instead of requiring indirection through a callback
503 * case-source.h (struct case_source_class): Change ->read function
504 to return a single case, instead of calling a callback function
505 for each case. Change ->destroy function to return an error
508 * case-source.c (free_case_source): Pass along the value returned
509 by the case_source ->destroy function.
511 * procedure.c (struct write_case_data): Removed.
512 (struct dataset): Added some members to track procedure state.
513 (procedure): Optimize the trivial case at this level.
514 (internal_procedure): Re-implement in terms of proc_open,
515 proc_read, proc_close.
516 (proc_open) New function.
517 (proc_read) New function.
518 (proc_close) New function.
519 (write_case) Moved into proc_read.
520 (close_active_file) Moved closing of data source into proc_close.
522 * storage-source.c: Rewrote to conform with modified
523 case_source_class interface.
525 * transformations.c (trns_chain_execute): Added argument to allow
526 starting execution from an arbitrary transformation. Updated
529 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
531 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
533 * sys-file-reader.c (read_display_parameters): Don't assume that
534 MEASURE_* and ALIGN_* have the same values found in system files.
536 * sys-file-writer.c (write_variable_display_parameters): Ditto.
538 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
539 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
540 the value of n_MEASURES, which was off by 1 (at least from my
543 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
545 * dictionary.c dictionary.h vardict.h variable.c: Added optional
546 callbacks which are invoked when the dictionary or its
547 variables are changed.
549 * missing-values.c missing-values.h value-labels.c: Tidied up
550 consistency checks, and made some of them return false
551 instead of assert-failing.
553 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
555 * calendar.c (calendar_days_in_month): New function.
557 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
559 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
560 the value label's width.
562 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
564 * sfm-private.h: Move contents into sys-file-writer.c, which is
565 the only remaining user. Removed Borland C++-specific directives.
567 * sys-file-reader.c: Clean up and rewrite entire file. The
568 rewritten version is simpler and better abstracted, and should be
569 easier to maintain and extend. It avoids using structures to read
570 file data, which is prone to padding variations among compilers.
571 It should also handle non-IEEE 754 system files, although I
572 haven't been able to find any. It has been tested against many
573 .sav files obtained from the Web and found to produce the same
574 results as the earlier version of the code, or in some cases
575 improved results. It is more tolerant of format variations found
578 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
579 member, putting an enum integer_format in its place. New member
580 `float_format'. Changed `compressed' member to type bool.
582 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
584 * dictionary.c (dict_delete_consecutive_vars): New function.
586 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
588 * file-name.c (fn_search_path): Remove prefix arg that was unused
589 by any caller. Updated all callers.
591 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
593 * format.c (fmt_dollar_template): Use user's decimal point
594 character. Add assertion.
596 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
598 * format.c (fmt_dollar_template): New function, based on
599 dollar_format_template from var-type-dialog.c.
601 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
603 * data-out.c (output_scientific): Fix bad assumption that "buf" is
606 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
608 Finish converting struct variable to an opaque type. In this
609 phase, we add remaining setter and getter functions, convert the
610 remaining PSPP code to use them, and do a bunch of cleanup. The
611 resulting changes are pervasive but mostly trivial, and only the
612 notable changes are logged.
614 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
617 * case.c (case_data): Renamed case_data_idx.
618 (case_num): Renamed case_num_idx.
619 (case_str): Renamed case_str_idx.
620 (case_data_rw): Renamed case_data_rw_idx.
622 * case.h (case_data): New function with old name and an interface
623 that takes a variable instead of an index, which is easier to
624 use. Updated all callers to use the new interface, or to use the
625 new *_idx function (see above).
628 (case_data_rw): Ditto.
630 * category.c (cat_stored_values_destroy): Changed interface to
631 take a struct cat_vals * instead of a struct variable *.
633 * dictionary.c (dict_clone): Use new vector_clone function.
634 (dict_clear) Use new var_destroy function.
635 (add_var) New function.
636 (dict_create_var) Rewrite in terms of dict_create_var_assert.
637 (dict_create_var_assert) Rewrite in terms of add_var.
638 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
639 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
640 (dict_lookup_var) Use new var_create, var_destroy functions.
641 (dict_contains_var) Rewrite in terms of new vardict functionality.
642 (set_var_dict_index) New function.
643 (set_var_case_index) New function.
644 (reindex_vars) New function.
645 (dict_delete_var) Rewrite in terms of new vardict functionality.
646 (dict_reorder_var) Ditto.
647 (dict_reorder_vars) Ditto.
648 (rename_var) New function.
649 (dict_rename_var) Use rename_var.
650 (dict_rename_vars) Use pool to simplify code. Use rename_var.
651 (dict_get_compacted_idx_to_fv) Rename
652 dict_get_compacted_dict_index_to_case_index, update callers.
653 (dict_create_vector) Use new vector_create function.
654 (dict_clear_vectors) Use new vector_destroy function.
655 (set_var_short_name_suffix) Move here from variable.c, renamed
656 from var_set_short_name_suffix, make static, update caller.
658 * sys-file-private.c: New file.
659 (sfm_width_to_bytes) Moved here from variable.c, renamed from
660 width_to_bytes, update callers.
662 * sys-file-private.h: New file. Later it will supplant
663 sfm-private.h; for now it supplements it.
664 (macro MIN_VERY_LONG_STRING) New macro.
665 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
667 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
668 MAX_LONG_STRING was used before.
670 * sys-file-writer.c: Ditto.
672 * value-labels.c: Change the paradigm here to be that a null
673 pointer is OK for a struct val_labs * in most cases; it just
674 represents an empty set of value labels.
675 (val_labs_copy) A copy of a null set is a null set.
676 (val_labs_count) A null set has 0 labels.
677 (val_labs_replace) Change return type to void. Rewrite for
679 (val_labs_find) A null set does not contain the value.
680 (value_to_string) Moved to variable.c, renamed var_get_value_name,
681 transposed argument order, updated all callers.
684 (value_dup) Moved here from variable.c.
685 (compare_values) Ditto.
688 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
689 (macro MAX_LONG_STRING) Removed, because it was only interesting
690 for system files, not for general code.
691 (macro MAX_VERY_LONG_STRING) Ditto.
692 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
693 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
695 * vardict.h: New file, for an interface between variables and
698 * variable.c: A lot of functions were moved around, for better
700 (struct variable) Move definition here, from variable.h.
701 (var_type_adj) Removed--makes i18n hard.
702 (var_type_noun) Ditto.
703 (var_create) New function.
704 (var_clone) New function.
705 (var_destroy) New function.
706 (var_set_name) Assert that variable is not in a dictionary.
707 (compare_var_names) Rename compare_vars_by_name and fix a couple
708 of callers who thought the args were strings.
709 (hash_var_name) Rename hash_var_by_name.
710 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
711 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
712 (var_is_very_long_string) Removed, because it was only interesting
714 (var_set_missing_values) Allow the argument to be the wrong width,
715 as long as we can resize it. Simplify callers who were doing the
717 (var_get_value_labels) New function.
718 (var_has_value_labels) New function.
719 (var_set_value_labels) New function.
720 (alloc_value_labels) New function.
721 (var_add_value_label) New function.
722 (var_replace_value_label) New function.
723 (var_clear_value_labels) New function.
724 (var_lookup_value_label) New function.
725 (var_get_value_name) Moved here from variable.c, renamed from
726 var_get_value_name, transposed argument order, updated all
728 (var_to_string) Moved here, from variable-label.c.
729 (var_set_leave) New function.
730 (var_get_leave) New function.
731 (var_must_leave) New function.
732 (var_set_short_name_suffix) Moved to dictionary.c, renamed
733 set_var_short_name_suffix.
734 (var_get_dict_index) New function.
735 (var_get_case_index) New function.
736 (var_get_obs_vals) New function.
737 (var_set_obs_vals) New function.
738 (var_has_obs_vals) New function.
739 (var_get_vardict) New function.
740 (var_set_vardict) New function.
741 (var_has_vardict) New function.
742 (var_clear_vardict) New function.
743 (value_dup) Moved to value.c.
744 (compare_values) Ditto.
747 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
748 (enum ALPHA) Rename VAR_STRING, update all users.
750 * vector.c: New file.
751 (struct vector) Moved here, from variable.h.
752 (check_widths) New function.
753 (vector_create) New function.
754 (vector_clone) New function.
755 (vector_destroy) New function.
756 (vector_get_name) New function.
757 (vector_get_var) New function.
758 (vector_get_var_cnt) New function.
759 (compare_vector_ptrs_by_name) New function.
761 * vector.h: New file.
763 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
765 * casefilter.c (casefilter_variable_missing): Avoided comparision of
766 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
769 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
771 * value-labels.c (destroy_atoms): New function.
772 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
774 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
776 Thanks to Jason Stover for pointing out this problem.
778 * data-out.c (output_number): Use gsl_finite from GSL, which is
779 portable, instead of isfinite, which is not.
782 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
784 * variable.c variable.h (value_dup): New function.
786 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
788 Start converting struct variable to an opaque type. In this
789 phase, we add a bunch of setter and getter functions and convert
790 most of the PSPP code to use them. The resulting changes are
791 pervasive but mostly trivial, and only the notable changes are
794 * format.c (fmt_equal): New function.
796 * variable.c (var_type_is_valid): New function.
797 (measure_is_valid) Moved here, from format.c.
798 (alignment_is_valid) Moved here, from format.c.
799 (var_get_name) New function.
800 (var_set_name) New function.
801 (width_to_type) New function.
802 (var_get_type) New function.
803 (var_get_width) New function.
804 (var_set_width) New function.
805 (var_is_numeric) New function.
806 (var_is_alpha) New function.
807 (var_is_short_string) New function.
808 (var_is_long_string) New function.
809 (var_is_very_long_string) New function.
810 (var_get_missing_values) New function.
811 (var_set_missing_values) New function.
812 (var_clear_missing_values) New function.
813 (var_has_missing_values) New function.
814 (var_is_value_missing) New function.
815 (var_is_num_missing) New function.
816 (var_is_str_missing) New function.
817 (var_is_value_user_missing) New function.
818 (var_is_num_user_missing) New function.
819 (var_is_str_user_missing) New function.
820 (var_is_value_system_missing) New function.
821 (var_get_print_format) New function.
822 (var_set_print_format) New function.
823 (var_get_write_format) New function.
824 (var_set_write_format) New function.
825 (var_set_both_formats) New function.
826 (var_get_label) New function.
827 (var_set_label) New function.
828 (var_clear_label) New function.
829 (var_has_label) New function.
830 (var_get_measure) New function.
831 (var_set_measure) New function.
832 (var_get_display_width) New function.
833 (var_set_display_width) New function.
834 (var_get_alignment) New function.
835 (var_set_alignment) New function.
836 (var_get_value_cnt) New function.
837 (var_get_leave) New function.
838 (var_get_short_name) New function.
840 * variable.h: (struct variable) Removed "type" and "nv" members;
841 they are now computed from "width" where needed.
843 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
845 * missing-values.c (mv_resize): Don't write beyond end of the
846 allocated buffer when resizing a long string.
848 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
850 Clean up identifier code: don't require identifier enumerations to
851 be in a particular order; make better use of string library;
852 expose less of the internals.
854 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
855 change interface. Updated all callers.
856 (lex_id_match) Change interface to use struct substring, update
858 (lex_id_match_len) Removed. Update callers to use lex_id_match.
859 (global array keywords[]) Make static, change form. Update all
860 users to use lex_id_name instead.
861 (lex_is_keyword) New function.
862 (lex_id_to_token) Change interface to use struct substring, update
864 (lex_id_name) New function.
866 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
867 lex_is_keyword instead.
868 (T_LAST_KEYWORD) Removed.
869 (T_N_KEYWORDS) Removed.
871 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
873 * format.c: (fmt_date_template) Distinguish characters for which a
874 space is output and any date delimiter is allowed on input, from
875 those for which a space is output and only a space is allowed on
876 input. The former is represented by X, the latter by a space.
877 Also, drop distinction between h and H, changing the former to the
880 * data-in.c: Completely rewrite internals to conform to SPSS input
881 formats as closely as possible.
882 (data_in) Changed external interface by replacing the structure
883 that was used as a single argument by a set of arguments. Updated
885 (data_in_finite_line) Removed. Converted all callers to use plain
887 (data_in_get_integer_format) New function.
888 (data_in_set_integer_format) New function.
889 (data_in_get_float_format) New function.
890 (data_in_set_float_format) New function.
892 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
893 (struct data_in) Removed.
895 * data-out.c: (output_date) Drop each component from the input as
896 it is output, to allow us to drop the distinction between h (a
897 count of hours) and H (the hour of day) template characters.
898 Also, handle new X template character.
899 (output_scientific) Follow more rational rule on when to drop
900 fraction introduced between SPSS 13 and 15. Updated test case to
903 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
905 Fix buffer overflow reported by John Darrington.
907 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
908 realize that DIGITS is a count of nibbles, not of bytes.
910 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
912 * calendar.c (calendar_offset_to_gregorian) Also return the
913 year-of-day. Change callers to new interface.
915 * data-out.c: Completely rewrite internals to conform to SPSS
916 output formats as completely as possible.
917 (data_out) Change interface to put input parameters before output
918 parameters, for consistency with the style I now prefer. Update
920 (data_out_get_integer_format) New public function.
921 (data_out_set_integer_format) New public function.
922 (data_out_get_float_format) New public function.
923 (data_out_set_float_format) New public function.
925 * data-out.h: New file. Move prototype for data_out here, from
928 * format.c: (fmt_step_width) Use equality comparison instead of
929 bitwise and, for clarity.
930 (fmt_is_string) Ditto.
931 (fmt_input_to_output) Fix categories that are translated to F
934 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
936 * casefilter.c casefilter.h (new files), casefile.c casefile.h
937 casefile-private.h: Added casefilter to assist commands with missing
940 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
942 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
944 * settings.c: (route_errors_to_terminal) New variable.
945 (route_errors_to_listing) New variable.
946 (get_error_routing_to_terminal) New function.
947 (set_error_routing_to_terminal) New function.
948 (get_error_routing_to_listing) New function.
949 (set_error_routing_to_listing) New function.
951 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
953 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
955 * format.c: Completely rewrite, to achieve better abstraction.
956 Rewrite all references to formats in other files.
958 * format.def: Rewrite and reorganize.
960 * settings.c: Move everything related to custom currency formats
961 into format.[ch], changing them in form, so as to group related
962 code and definitions better. Changed all references to use the
964 (static var decimal) Removed.
965 (static var grouping) Removed.
966 (static var cc) Removed.
967 (get_decimal) Removed.
968 (set_decimal) Removed.
969 (get_grouping) Removed.
970 (set_grouping) Removed.
974 * settings.h: (macro CC_CNT) Removed.
975 (macro CC_WIDTH) Removed.
976 (struct custom_currency) Removed.
978 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
980 * data-in.c (data_in): Use switch statement instead of table, to
981 avoid dependence on the order of the FMT_* enums.
983 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
985 * data-out.c: (num_to_string) Removed, because it was dead code.
987 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
989 * data-in.c (parse_trailer): Fix error message.
991 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
993 * format.c (fmt_is_binary): New function.
995 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
997 * procedure.c procedure.h: Encapsulated the static data into a single
1000 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1002 * casefile.c (casereader_read_xfer): Always initialize the case,
1003 even on an error condition.
1005 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1007 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1008 entire function useless.
1010 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1012 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1013 casereader method casereader_clone.
1015 * procedure.c pransformations.h: Introduced new type casenum_t
1017 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1019 * variable.c: (width_to_bytes) Rephrase code for clarify.
1021 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1023 * format.c: (fmt_type_from_string) New function.
1024 (fmt_to_string) Include decimals in output if the format has
1025 decimals, even if the format type does not. This way, we can
1026 accurately reproduce incorrect formats in user output.
1027 (check_common_specifier) Make the check for a bad format type an
1028 assertion, so we get bug reports if they show up. Fix message.
1029 Check for decimal places with a format type that doesn't allow
1031 (check_input_specifier) Remove check for FMT_X, which has been
1033 (check_output_specifier) Ditto.
1035 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1037 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1038 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1039 (enum fmt_parse_flags) Removed.
1041 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1043 * casefile.c casefile.h: Converted to an abstract base class.
1044 * casefile-private.h fastfile.c fastfile.h: New files.
1045 * automake.mk procedure.c scratch-writer.c storage-stream.c
1047 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1049 * procedure.c (internal_procedure): Create sink_case with only as
1050 many values as the compacted dictionary.
1052 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1054 Remove "debugging" code that caused plenty of false positives and
1057 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1059 * case.c: Remove all references to `this' member.
1061 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1063 Fix link error noted by Jason Stover.
1065 * storage-stream.c: Include <assert.h>.
1067 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1069 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1070 ALL) and additional underlying system file issues.
1072 Thanks to John Darrington for review.
1074 First problem: var_hash points to variables not owned by the
1075 sys-file-reader, which the caller may free or modify. Use an
1076 array of sfm_vars instead, as done earlier (e.g. CVS version
1079 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1080 members and remove all code that references it. Add vars, var_cnt
1081 members. Remove fix_specials member, which was unused.
1082 (struct sfm_var) Remove name member, which was unused.
1083 (sfm_close_reader) Free vars member instead of var_hash.
1084 (compare_var_shortnames) Removed.
1085 (hash_var_shortname) Removed.
1086 (sfm_open_reader) Fill out vars array.
1087 (compare_var_index) Removed.
1088 (sfm_read_case) Use vars instead of var_hash.
1090 Second problem: we're confused about when we actually have very
1091 long strings, causing us to choose incorrectly between slow path
1092 and fast path in sfm_read_case.
1094 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1095 have very long strings, not when we have long variable names,
1096 which is an unrelated feature.
1098 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1100 * variable.h: Move var_set and variable parsing declarations to
1101 new header, src/language/lexer/variable-parser.h. Modified lots
1102 of files to include the new header.
1104 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1106 * value-labels.c (value_to_string): When there's no value label,
1107 format the variable according to its print format, instead of
1108 always effectively using A or F format.
1110 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1112 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1115 * format.c: Removed tortological assertion.
1117 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1119 Reform string library.
1121 * file-name.c (fn_interp_vars): Change interface to take a
1122 substring as input. Updated all users.
1124 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1126 * format.c (measure_is_valid): Really return false when m >=
1129 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1131 Implement random access to casefiles, for use in GUI.
1133 * casefile.c: (struct casereader) Add `random', `file_ofs',
1134 `buffer_ofs' members.
1135 (casefile_get_random_reader) New function.
1136 (read_open_file) Break part into new function
1137 seek_and_fill_buffer().
1138 (fill_buffer) Update buffer_ofs, file_ofs.
1139 (casereader_seek) New function.
1141 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1143 * settings.c: Added call to i18n{done, init}.
1145 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1147 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1150 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1152 * casefile.c: Convert many uses of `int' to `bool'.
1154 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1156 * transformations.c (trns_chain_destroy): Destroy chain's trns
1157 member, to fix memory leak.
1159 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1161 * storage-stream.c (storage_source_decapsulate): Destroy case
1162 source to fix memory leak.
1164 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1166 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1167 case passed as argument instead of initializing the argument as a
1168 case. Fixes memory leak that showed up in
1169 tests/command/aggregate.sh with scratch files.
1171 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1173 * procedure.c (proc_done): Destroy default_dict, to fix memory
1176 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1178 Simplify procedure_with_splits().
1180 * procedure.c (struct split_aux_data): Removed case_count member.
1181 (procedure_with_splits) Don't initialize case_count.
1182 (split_procedure_case_func) Check whether prev_case is null
1183 instead of case_count.
1184 (split_procedure_end_func) Ditto.
1186 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1188 * case.c (case_move): Do nothing if dst and src are the same
1190 (case_try_create) Merge two similar cases.
1191 (case_copy) Unshare only if data must be actually copied.
1193 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1195 * data-in.c data-out.c dictionary.c sys-file-reader.c
1196 sys-file-writer.c variable.c variable.h: Reworked very long string
1197 support for better encapsulation.
1199 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1201 * value-labels.c (val_labs_can_set_width): New function.
1202 (val_labs_set_width) Clear labels if increasing width to long
1204 (val_labs_destroy) Remove unneeded test for null.
1206 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1208 * value-labels.h: Remove unneeded dependency on variable.h.
1210 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1212 Get rid of `char *c' member in union value, for cleanliness.
1214 * value.h: (union value) Remove `c' member.
1216 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1218 Make dictionary compacting functions a little more general.
1220 * sys-file-writer.c (sfm_open_writer): Use
1221 dict_compacting_would_change().
1222 (does_dict_need_translation) Removed.
1224 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1226 Make dictionary compacting functions a little more general.
1228 * dictionary.c (dict_needs_compaction): Rename
1229 dict_compacting_would_shrink(). Update all callers.
1230 (dict_compacting_would_change) New function.
1232 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1234 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1235 inverted return value (!).
1237 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1239 Continue reforming procedure execution.
1241 * procedure.c: Search and replace "vfm" by "proc". Notably:
1242 (static var vfm_source) Rename proc_source. Update all
1244 (static var vfm_sink) Rename proc_sink. Update all references.
1246 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1248 Continue reforming procedure execution. In this phase, remove
1249 PROCESS IF, which was deprecated anyway and can be easily
1250 simulated with TEMPORARY followed by SELECT IF.
1252 * procedure.c: (open_active_file) Don't call
1253 add_process_if_trns().
1254 (discard_variables) Get rid of redundant call to
1255 proc_cancel_all_transformations().
1256 (add_process_if_trns) Removed.
1257 (process_if_trns_proc) Removed.
1258 (process_if_trns_free) Removed.
1260 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1262 Continue reforming procedure execution. In this phase, add
1263 `const' to the case passed to procedure()'s callback.
1265 Updated all users of procedure() as well.
1267 * procedure.c: (struct write_case_data) Add "const" to ccase
1268 parameter for case_func member.
1269 (procedure) Add "const" to ccase parameter for proc_func
1271 (multipass_case_func) Make ccase parameter const.
1272 (internal_procedure) Add "const" to ccase parameter for case_func
1274 (split_procedure_case_func) Make ccase parameter const.
1275 (multipass_split_case_func) Make ccase parameter const.
1277 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1279 Continue reforming procedure execution. In this phase, get rid of
1280 the output code for SPLIT FILE groups in procedure.c, which really
1281 shouldn't be doing any output. Move it into the individual
1282 procedures instead. This also adds some flexibility.
1284 Updated many users of procedure_with_splits() and
1285 multipass_procedure_with_splits() to call
1286 output_split_file_values() and to deal with increased use of
1289 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1290 parameter to begin_func member.
1291 (procedure_with_splits) Add "const struct ccase *" parameter to
1292 begin_func parameter. Make ccase parameter const in proc_func
1294 (split_procedure_case_func) Don't dump split file group. Pass
1296 (dump_splits) Moved to language/dictionary/split-file.c as
1297 output_split_file_values().
1298 (struct multipass_split_aux_data) Add "const struct ccase *"
1299 parameter to split_func member.
1300 (multipass_procedure_with_splits) Add "const struct ccase *"
1301 parameter to split_func parameter.
1302 (multipass_split_case_func) Save new SPLIT FILE case before
1304 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1306 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1308 Continue reforming procedure execution. Change
1309 internal_procedure() so that it calls open_active_file() and
1310 close_active_file(), which isolates most of the actual procedure
1313 * procedure.c: (struct write_case_data) Rename `proc_func' member
1314 to `case_func' and update all references.
1315 (procedure) Rewrite as one-line wrapper around
1316 internal_procedure().
1317 (struct multipass_aux_data) New.
1318 (multipass_callback) Renamed multipass_case_func(). Use struct
1319 multipass_aux_data as auxiliary data.
1320 (multipass_end_func) New function.
1321 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1322 that uses multipass_case_func, multipass_end_func.
1323 (internal_procedure) Add `end_func' argument. Move optimization
1324 of trivial case in here. Move call to open_active_file() and
1325 close_active_file() in here. Now assert that vfm_source is
1327 (procedure_with_splits_callback) Rename
1328 split_procedure_case_func().
1329 (split_procedure_end_func) New function.
1330 (multipass_split_callback) Rename multipass_split_case_func.
1331 (multipass_split_end_func) New function.
1332 (discard_variables) No need to test for nonnull vfm_source.
1334 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1336 Continue reforming procedure execution. Get rid of unused member.
1338 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1340 (write_case) Don't increment cases_analyzed.
1342 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1344 Continue reforming procedure execution. In this phase, move
1345 procedure.c and procedure.h from src to src/data. Update
1346 makefiles and #includes accordingly.
1348 * procedure.c: Moved here from src/.
1350 * procedure.h: Moved here from src/.
1352 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1354 Continue reforming procedure execution. In this phase, get rid of
1355 many global variables, consolidating procedure execution in
1356 procedure.c. Encapsulate transformations in new "struct
1357 trns_chain". Also, change implementation of N OF CASES, FILTER,
1358 and PROCESS IF from special cases to transformations.
1360 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1363 * dictionary.c: (global variable default_dict) Move to
1366 * variable.h: (TRNS_*) Move to transformations.h.
1367 (struct transformation) Move to transformations.c.
1369 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1371 * sys-file-reader.c: Fixed invalid read problems.
1373 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1375 * storage-stream.c: Add missing function comments.
1377 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1379 Continue reforming procedure execution. In this phase, add some
1380 new, needed functionality to storage-stream.
1382 * storage-stream.c: (storage_source_decapsulate) New function.
1384 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1386 * variable.c (width_to_bytes): Declarations must precede
1387 statements for C90 compliance.
1389 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1391 * data-out.c, data-in.c, variable.c, variable.h: New functions
1392 copy_mangle and copy_demangle for reading/writing cases; emulates the
1393 way SPSS deals with strings > 255 bytes.
1395 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1396 subtype 14 needed for strings longer than 255 bytes.
1398 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1399 instead of literal values. Also fixed some constness issues.
1401 * format.h: Constness
1403 * sfm-private.h: Renamed the case_size identifier, since I discovered
1404 that SPSS's respect for this variable is very nominal.
1406 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1408 Change case limit type from int to size_t.
1410 * dictionary.c: (struct dictionary) Change type of case_limit
1412 (dict_get_case_limit) Change return type.
1413 (dict_set_case_limit) Change parameter type.
1415 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1417 * variable.h: (struct variable) Rename `reinit' member as `leave'
1418 and invert sense. Fix up all references.
1420 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1422 Continue reforming procedure execution. In this phase, break
1423 procedure.c into multiple files.
1425 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1427 * case-sink.c: New file.
1429 * case-sink.h: New file.
1431 * case-source.c: New file.
1433 * case-source.h: New file.
1435 * storage-stream.c: New file.
1437 * storage-stream.h: New file.
1439 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1441 * variable.h: (struct variable) Remove `init' member and all
1442 references to it from other files. It was initialized in several
1443 places, but nothing really ever used it for anything worthwhile.
1444 Thanks to Jason Stover for pointing out how confusing this
1447 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1449 Continue reforming error message support. In this phase, get rid
1450 of message "titles" and put the message text in `struct error'.
1451 Now `struct error' encapsulates a message more properly.
1453 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1454 Format message ourselves.
1456 * data-in.c: (vdls_error) Ditto.
1458 * por-file-reader.c: (error) Ditto.
1460 * sys-file-reader.c: (corrupt_msg) Ditto.
1462 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1464 GNU standards require "file name" instead of "filename" in
1465 documentation. It's nice for our code to follow the convention
1468 * casefile.c: (struct casefile) Rename `filename' member to
1469 `file_name'. Updated all references.
1471 * file-name.c: [!unix] (struct file_identity) Rename
1472 normalized_filename member to normalized_file_name. Updated all
1475 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1477 We don't really support anything but Unix-like environments well,
1478 so we might as well de-obfuscate by writing directory and path
1479 separators explicitly.
1481 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1483 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1484 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1486 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1489 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1491 GNU standards require "file name" instead of "filename" in
1492 documentation. It's nice for our code to follow the convention
1495 * filename.c: Rename to file-name.c.
1497 * filename.h: Rename to file-name.h. Update all inclusions.
1498 Update header guards.
1500 * automake.mk: Update file names.
1502 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1504 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1506 (fn_basename) Removed (dead code).
1507 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1508 (fn_special_p) Renamed fn_is_special(), all references updated.
1509 (fn_exists_p) Renamed fn_exists(), all references updated.
1511 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1513 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1514 Also, now it only tilde-expands file names, not paths.
1515 (fn_search_path) Tilde-expand one directory at a time.
1517 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1519 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1520 get rid of non-Unixlike version of the code, which has probably
1522 (fn_prepend_dir) Removed (dead code).
1524 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1525 (macro PATH_SEPARATOR_STRING) New.
1526 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1528 Continue reforming error message support. In this phase, we get
1529 rid of VM() and the other msg() support for "verbosity", replacing
1530 it by a new function verbose_msg().
1532 * filename.c: (fn_search_path) Use verbose_msg() instead of
1535 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1537 * sfm-private.h: Get rid of #defines after #error, which makes no
1540 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1542 Get rid of our own int32 type in favor of the standard int32_t
1545 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1548 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1550 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1552 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1554 Remove ill-considered file routines that are no longer used.
1556 * filename.c: (fn_open_ext) Removed.
1557 (fn_close_ext) Removed.
1559 * filename.h: (struct file_ext) Removed.
1561 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1563 * variable.c (var_is_valid_name): Move declarations before code
1566 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1568 * filename.ch (fn_interp_vars): Fixed small buglet.
1570 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1572 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1573 so as to modify the string inline. Thus makeing it easier to
1574 destroy the results when no longer needed.
1576 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1578 * category.c (cat_stored_values_destroy): Fixed memory leak.
1580 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1582 Add some missing frees. Thanks to John Darrington for reporting
1585 * any-writer.c (any_writer_close): Free writer.
1587 * any-reader.c (any_reader_close): Free reader.
1589 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1591 * por-file-reader.c: (error) Mark as NO_RETURN.
1593 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1595 * settings.c: Changed default value of scompress to true.
1597 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1599 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1601 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1604 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1605 here from pref.h.orig.
1607 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1609 * sys-file-reader.c: Fixed bug reading compressed files.
1611 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1613 * Numerous renames. See src/ChangeLog for details.
1615 * Moved files from src directory