1 2007-07-18 John Darrington <john@darrington.wattle.id.au>
3 * datasheet.c (datasheet_delete_columns): Added assertion to check
4 we're not deleting outside the range of the sheet.
7 * dictionary.c dictionary.h variable.c: Added the ability for string
8 variables to be resized.
10 * vardict.h: Added some prototypes (moved from dictionary.h) as
11 these should only be called by variable.c
14 2007-07-14 John Darrington <john@darrington.wattle.id.au>
16 * sfm-reader.c: Respect case_cnt field in file header.
18 2007-07-01 John Darrington <john@darrington.wattle.id.au>
20 * transformation.c transformation.h (trns_chain_execute): Changed the
21 signature (Patch #6057)
23 2007-06-10 Ben Pfaff <blp@gnu.org>
25 * casereader-filter.c (casereader_filter_destroy): Make sure to
26 write all the remaining excluded cases to the casewriter, if any.
28 * caseinit.c (init_list_destroy): Rewrite.
29 (init_list_clear): Ditto.
31 * casegrouper.c (casegrouper_get_next_group): Always set *reader
32 to null when returning false.
34 2007-06-06 Ben Pfaff <blp@gnu.org>
36 Actually implement the new procedure code and adapt all of its
37 clients to match. Also adapt all of the other case sources and
38 sinks in the tree and their clients to use the
39 casereader/casewriter infrastructure.
41 * automake.mk: Add and remove files.
43 * any-reader.c: Change into a casereader.
44 * por-file-reader.c: Ditto.
45 * scratch-reader.c: Ditto.
46 * sys-file-reader.c: Ditto.
48 * any-writer.c: Change into a casewriter.
49 * por-file-writer.c: Ditto.
50 * scratch-writer.c: Ditto.
51 * sys-file-writer.c: Ditto.
53 * procedure.c: Change to use casereader, casewriter, caseinit, and
54 other new infrastructure.
56 * scratch-handle.c: Adapt to new infrastructure.
58 * case-sink.c: Removed, now dead code.
60 * case-source.c: Ditto.
61 * case-source.h: Ditto.
62 * casefile-factory.c: Ditto.
63 * casefile-private.h: Ditto.
66 * casefilter.c: Ditto.
67 * casefilter.h: Ditto.
70 * fastfile-factory.c: Ditto.
71 * fastfile-factory.h: Ditto.
72 * storage-stream.c: Ditto.
73 * storage-stream.h: Ditto.
75 2007-06-06 Ben Pfaff <blp@gnu.org>
79 * automake.mk: Add new files.
81 * datasheet.c: New file.
83 * datasheet.h: New file.
85 2007-06-06 Ben Pfaff <blp@gnu.org>
87 Until now, the procedure code has provided a case to the
88 case_source, which has filled in the data values that come from
89 the active file. "Left" data values that don't come from the
90 active file naturally stay the same from case to case, because the
91 procedure code keeps using that same case.
93 One of the compromises that comes with the new procedure code is
94 that the active file allocates and provides its own case, which
95 the procedure code then has to resize to provide room for any
96 other variables that should go in the case and then fill in the
97 values of "left" variables. Then, when we're done with that case,
98 we have to save the values of "left" variables to copy into the
99 next case read from the active file.
101 The caseinit code helps with this.
103 * automake.mk: Add new files.
105 * caseinit.c: New file.
107 * caseinit.h: New file.
109 2007-06-06 Ben Pfaff <blp@gnu.org>
111 * value.h (value_cnt_from_width): New function.
113 * variable.c (var_get_value_cnt): Use new function.
115 2007-06-06 Ben Pfaff <blp@gnu.org>
117 Add casegrouper, to allow cases read from a given casereader to be
118 broken into groups, each of which has its own casereader.
119 Generally cases are grouped based on having equal values for some
122 * automake.mk: Add new files.
124 * casegrouper.c: New file.
126 * casegrouper.h: New file.
128 2007-06-06 Ben Pfaff <blp@gnu.org>
130 Add interface to lexicographical ordering of cases.
132 * automake.mk: Add new files.
134 * case-ordering.c: New file.
136 * case-ordering.h: New file.
138 2007-06-06 Ben Pfaff <blp@gnu.org>
140 Add casereaders and casewriters, the basis of the new data processing
141 implementation. A casereader is a uniform interface to reading cases
142 from a data source; a casewriter is a uniform interface to writing
143 cases to a data sink.
145 * automake.mk: Add new files.
147 * casereader-filter.c: New file.
149 * casereader-provider.h: New file.
151 * casereader-translator.c: New file.
153 * casereader.c: New file.
155 * casereader.h: New file.
157 * casewriter-provider.h: New file.
159 * casewriter-translator.c: New file.
161 * casewriter.c: New file.
163 * casewriter.h: New file.
165 2007-06-06 Ben Pfaff <blp@gnu.org>
167 "casewindow" data structure that extends the deque (from libpspp)
168 of cases with the ability to dump cases to disk if we get too many
171 * automake.mk: Add new files.
173 * casewindow.c: New file.
175 * casewindow.h: New file.
177 2007-06-06 Ben Pfaff <blp@gnu.org>
179 sparse_cases data structure that augments a sparse_array of cases
180 with the ability to dump cases to disk if we get too many cases in
183 * automake.mk: Add new files.
185 * sparse-cases.c: New file.
187 * sparse-cases.h: New file.
189 2007-06-06 Ben Pfaff <blp@gnu.org>
191 Adds a low-level on-disk case array data structure.
193 * automake.mk: Add new files.
195 * case-tmpfile.c: New file.
197 * case-tmpfile.h: New file.
199 2007-06-06 Ben Pfaff <blp@gnu.org>
201 In a couple of places we calculate the maximum number of cases to
202 keep in memory based on the user-defined workspace. Enable
203 centralizing the calculation through a new function.
205 * settings.c (get_workspace_cases): New function.
207 2007-06-06 Ben Pfaff <blp@gnu.org>
209 The casenumber type is defined in transformations.h, but case.h is
210 a more sensible place. Move it.
212 * case.h (CASENUMBER_MAX): New macro.
213 (typedef casenumber): Move here, from transformations.h.
215 2007-06-03 Ben Pfaff <blp@gnu.org>
217 Slightly generalize case_to_values and case_from_values functions.
219 * case.c (case_to_values): Rename case_copy_out, change interface.
220 (case_from_values): Rename case_copy_in, change interface.
222 * fastfile.c (fastfilereader_get_next_case): Update caller.
223 (write_case_to_disk): Ditto.
225 2007-06-02 Ben Pfaff <blp@gnu.org>
227 Clean up after a forgotten part of patch #5829.
229 * casedeque.h: Remove unused file.
231 * automake.mk: Remove casedeque.h from sources.
233 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
235 * category.c: Removed redundant #include
237 2007-05-06 Ben Pfaff <blp@gnu.org>
239 Abstract the documents within a dictionary a little better.
240 Thanks to John Darrington for suggestion, initial version, and
243 * dictionary.c (struct dictionary): Change `documents' member from
244 char * to struct string.
245 (dict_clear): Destroy struct string.
246 (dict_get_documents): Convert struct string to char *.
247 (dict_set_documents): Set struct string. Pad to 80-character
249 (dict_clear_documents): New function.
250 (dict_add_document_line): New function.
251 (dict_get_document_line_cnt): New function.
252 (dict_get_document_line): New function.
254 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
256 * sys-file-reader.c (read_documents): Use new document functions.
258 2007-04-19 John Darrington <john@darrington.wattle.id.au>
260 * sys-file-reader.c: When reading a system file which has no
261 long name table, automatically create one where the long names
262 are the lower case versions of the short names.
264 2007-04-22 Ben Pfaff <blp@gnu.org>
266 * dictionary.c (dict_set_split_vars): dict_destroy expects that
267 dict_clear will free most data related to the dictionary.
268 dict_clear does a decent job, except that dict_set_split_vars on
269 some systems won't actually free the dict's "split" member.
270 Instead, it'll allocate a 1-byte region. Fix this.
272 * value.c (value_copy): New function.
273 (value_set_missing): Ditto.
275 2007-04-22 John Darrington <john@darrington.wattle.id.au>
277 * Deleted existing category.h and moved cat-routines.h into
278 category.h Encapsulated struct cat_vals better.
280 2007-04-19 John Darrington <john@darrington.wattle.id.au>
282 * sys-file-reader.c: When reading a system file which has no
283 long name table, automatically create one where the long names
284 are the lower case versions of the short names.
286 2007-04-16 John Darrington <john@darrington.wattle.id.au>
288 * sys-file-reader.c: Some versions of Other Software seem to
289 produce system files with string variables' measure set to
290 zero. We'll assume these are supposed to be nominal variables.
292 2007-03-30 Ben Pfaff <blp@gnu.org>
294 * procedure.c: Adapt to new deque data structure.
296 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
297 Ben Pfaff <blp@gnu.org>
299 * file-name.c: Mingw compatibility fixes.
300 (fn_search_path): Use ISSLASH instead of comparing against '/'
302 (fn_dir_name): Use dir_name from gnulib.
303 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
304 (fn_get_identity): Use GetFullPathName instead of canonicalize
305 from gnulib, because the latter does not fully support
306 Windows-style path names. Use this implementation based on the
307 detected presence of Windows instead of the absence of Unix, since
308 the new implementation is Windows-specific.
309 (fn_compare_file_identities): In Windows implementation, compare
310 names case-insensitively.
312 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
314 * make-file.c: Don't include mkstemp.h, because gnulib now causes
315 <stdlib.h> to have the same effect.
317 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
319 * por-file-reader.c: Add missing _() around messages.
321 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
323 * make-file.c: Include "mkstemp.h", without which linking on
326 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
328 Reduce platform dependence.
330 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
331 Everywhere we using this, we really should have just depended on
332 the shell to expand tildes.
333 (fn_search_path): Simplify, given that we don't do tilde expansion
335 (fn_normalize): Removed. Caller changed to use the canonicalize
337 (fn_get_cwd): Removed. Only user was fn_normalize.
338 (fn_is_absolute): Really only test for absolute names.
339 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
341 (fn_readlink): Removed, as it was only used fn_normalize.
342 (fn_exists): Assume the stat function is available; gnulib does.
343 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
345 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
347 * dictionary.c (dict_create_vector_assert): New function.
349 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
351 * file-name.c (fn_normalize): Correct name of function
352 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
353 for pointing this out.
355 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
357 We are using a single member in struct file_handle, the "name"
358 field, for more than one purpose. When it begins with '"', it's a
359 file name; otherwise, it's a token that can be used to identify
360 it. When that assertion fires, it's because we searched for the
361 name case-sensitively as a file name (so that there was no match),
362 and then we try to insert it case-insensitively as a token, which
363 fails because duplicates aren't allowed.
365 Solution: break the two purposes into two separate fields. This
366 fixes the problem and likely makes the code easier to read too.
368 Fixes bug #18922. Thanks to John Darrington for bug report and
371 * file-handle-def.c (struct file_handle): New `id' member.
372 (fh_from_name): Rename fh_from_id. Update all callers.
373 (create_handle): New `id' parameter. Update all callers.
374 (fh_create_file): Ditto.
375 (fh_get_id): New function.
377 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
379 * case.c (case_is_null): Change return type to bool.
381 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
385 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
386 reference counting to share data. This makes it easy for
387 valgrind, etc. to find accesses to cases that have been destroyed
388 but have been kept around by another user's ref-count. This often
389 happens when the data set is small enough to find in memory; if a
390 bigger data set that would overflow to disk were used, then data
391 corruption would occur.
393 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
397 * case.c (case_unshare): Make it check internally whether the
398 ref_cnt is greater than 1, so that the callers don't have to.
399 Update callers not to check.
401 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
403 Before, I was thinking that I might want to get rid of reference
404 counting at some point. Now, I'm pretty sure that it's here to
405 stay. Thus, because we have to store the value_cnt anyway for
406 reference-counted cases, we might as well expose it to users.
408 * case.c (case_get_value_cnt): New function.
409 (case_resize): Drop OLD_CNT argument. Update all callers. Only
410 resize case if its size actually changed.
412 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
413 instead of peeking inside struct case directly.
414 (casefile_append): Ditto.
416 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
418 Get rid of the inlines for the case functions, which made the
419 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
420 the inlines didn't speed up "make check" at all, which is not a
421 perfect benchmark but seems indicative.)
423 * case.c: Remove #ifdef DEBUGGING...#endif around many function
424 definitions. Remove some assertions on nonnull pointers that were
425 redundant with a pointer dereference soon after in the function.
427 (struct case_data): Move definition here from case.h.
431 (case_data_wr): Ditto.
433 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
435 * automake.mk: Add casedeque.h to sources.
437 * casedeque.h: New file.
439 * procedure.c: (struct dataset) Change lag_count, lag_head,
440 lag_queue member into single struct casedeque member. Update all
441 users to use the casedeque instead.
444 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
446 * procedure.c: Simplify lagged cases interface. Updated all
447 clients--well, the only client--to use the simplified interface.
448 (dataset_n_lag) Removed.
449 (dataset_set_n_lag) Removed.
450 (dataset_need_lag) New function.
452 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
454 * dictionary.c procedure.c: More changes to ensure that callbacks occur
455 whenever appropriate, but only when the dataset/dictionary is in a
458 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
460 * dictionary.c dictionary.h : Added callbacks for change of filter and
461 split variables. Refactored some code to ensure that callbacks get
462 invoked when appropriate.
464 * procedure.c (proc_cancel_temporary_transformations): Make sure that
465 replace_dict callback occurs when permanent_dict replaces the current
468 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
470 * dictionary.c dictionary.h : Added callback for when the weight
471 variable of a dictionary changes.
473 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
475 * dictionary.c dictionary.h : Added replace_source and replace_dict
476 callbacks, and functions to deal with them.
478 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
480 Simplify missing value handling.
482 * missing-values.h (enum mv_class): New type.
483 (enum mv_type): Moved definition into missing-values.c and renamed
484 each MV_* to MVT_*, to distinguish them from the exposed mv_class
485 enums. Updated all uses.
486 (struct missing_values): Changed type of `type' from `enum
487 mv_type' to `int' because the definition is no longer exposed.
489 * missing-values.c (mv_is_value_missing): Add new enum mv_class
490 parameter. Update all callers.
491 (mv_is_num_missing): Ditto.
492 (mv_is_str_missing): Ditto.
493 (mv_is_value_user_missing): Removed. Changed callers to use
495 (mv_is_num_user_missing): Removed. Changed callers to use
497 (mv_is_str_user_missing): Removed. Changed callers to use
499 (mv_is_value_system_missing): Removed. Changed callers to use
501 (mv_set_type): Removed. Changed callers to use mv_clear.
502 (mv_clear): New function.
504 * variable.c (var_is_value_missing): Add new enum mv_class
505 parameter. Update all callers.
506 (var_is_num_missing): Ditto.
507 (var_is_str_missing): Ditto.
508 (var_is_value_user_missing): Removed. Changed callers to use
509 var_is_value_missing.
510 (var_is_num_user_missing): Removed. Changed callers to use
512 (var_is_str_user_missing): Removed. Changed callers to use
514 (var_is_value_system_missing): Removed. Changed callers to use
515 var_is_value_missing.
517 * casefilter.c (struct casefilter): Use enum mv_class in place of
519 (casefilter_variable_missing): Adapt to new member.
520 (casefilter_create): Change signature to take enum mv_class,
523 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
525 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
527 * case-sink.c case-sink.h procedure.c procedure.h
528 storage-stream.c: Now uses the factory.
530 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
532 Make it possible to pull cases from the active file with a
533 function call, instead of requiring indirection through a callback
536 * case-source.h (struct case_source_class): Change ->read function
537 to return a single case, instead of calling a callback function
538 for each case. Change ->destroy function to return an error
541 * case-source.c (free_case_source): Pass along the value returned
542 by the case_source ->destroy function.
544 * procedure.c (struct write_case_data): Removed.
545 (struct dataset): Added some members to track procedure state.
546 (procedure): Optimize the trivial case at this level.
547 (internal_procedure): Re-implement in terms of proc_open,
548 proc_read, proc_close.
549 (proc_open) New function.
550 (proc_read) New function.
551 (proc_close) New function.
552 (write_case) Moved into proc_read.
553 (close_active_file) Moved closing of data source into proc_close.
555 * storage-source.c: Rewrote to conform with modified
556 case_source_class interface.
558 * transformations.c (trns_chain_execute): Added argument to allow
559 starting execution from an arbitrary transformation. Updated
562 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
564 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
566 * sys-file-reader.c (read_display_parameters): Don't assume that
567 MEASURE_* and ALIGN_* have the same values found in system files.
569 * sys-file-writer.c (write_variable_display_parameters): Ditto.
571 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
572 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
573 the value of n_MEASURES, which was off by 1 (at least from my
576 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
578 * dictionary.c dictionary.h vardict.h variable.c: Added optional
579 callbacks which are invoked when the dictionary or its
580 variables are changed.
582 * missing-values.c missing-values.h value-labels.c: Tidied up
583 consistency checks, and made some of them return false
584 instead of assert-failing.
586 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
588 * calendar.c (calendar_days_in_month): New function.
590 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
592 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
593 the value label's width.
595 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
597 * sfm-private.h: Move contents into sys-file-writer.c, which is
598 the only remaining user. Removed Borland C++-specific directives.
600 * sys-file-reader.c: Clean up and rewrite entire file. The
601 rewritten version is simpler and better abstracted, and should be
602 easier to maintain and extend. It avoids using structures to read
603 file data, which is prone to padding variations among compilers.
604 It should also handle non-IEEE 754 system files, although I
605 haven't been able to find any. It has been tested against many
606 .sav files obtained from the Web and found to produce the same
607 results as the earlier version of the code, or in some cases
608 improved results. It is more tolerant of format variations found
611 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
612 member, putting an enum integer_format in its place. New member
613 `float_format'. Changed `compressed' member to type bool.
615 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
617 * dictionary.c (dict_delete_consecutive_vars): New function.
619 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
621 * file-name.c (fn_search_path): Remove prefix arg that was unused
622 by any caller. Updated all callers.
624 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
626 * format.c (fmt_dollar_template): Use user's decimal point
627 character. Add assertion.
629 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
631 * format.c (fmt_dollar_template): New function, based on
632 dollar_format_template from var-type-dialog.c.
634 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
636 * data-out.c (output_scientific): Fix bad assumption that "buf" is
639 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
641 Finish converting struct variable to an opaque type. In this
642 phase, we add remaining setter and getter functions, convert the
643 remaining PSPP code to use them, and do a bunch of cleanup. The
644 resulting changes are pervasive but mostly trivial, and only the
645 notable changes are logged.
647 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
650 * case.c (case_data): Renamed case_data_idx.
651 (case_num): Renamed case_num_idx.
652 (case_str): Renamed case_str_idx.
653 (case_data_rw): Renamed case_data_rw_idx.
655 * case.h (case_data): New function with old name and an interface
656 that takes a variable instead of an index, which is easier to
657 use. Updated all callers to use the new interface, or to use the
658 new *_idx function (see above).
661 (case_data_rw): Ditto.
663 * category.c (cat_stored_values_destroy): Changed interface to
664 take a struct cat_vals * instead of a struct variable *.
666 * dictionary.c (dict_clone): Use new vector_clone function.
667 (dict_clear) Use new var_destroy function.
668 (add_var) New function.
669 (dict_create_var) Rewrite in terms of dict_create_var_assert.
670 (dict_create_var_assert) Rewrite in terms of add_var.
671 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
672 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
673 (dict_lookup_var) Use new var_create, var_destroy functions.
674 (dict_contains_var) Rewrite in terms of new vardict functionality.
675 (set_var_dict_index) New function.
676 (set_var_case_index) New function.
677 (reindex_vars) New function.
678 (dict_delete_var) Rewrite in terms of new vardict functionality.
679 (dict_reorder_var) Ditto.
680 (dict_reorder_vars) Ditto.
681 (rename_var) New function.
682 (dict_rename_var) Use rename_var.
683 (dict_rename_vars) Use pool to simplify code. Use rename_var.
684 (dict_get_compacted_idx_to_fv) Rename
685 dict_get_compacted_dict_index_to_case_index, update callers.
686 (dict_create_vector) Use new vector_create function.
687 (dict_clear_vectors) Use new vector_destroy function.
688 (set_var_short_name_suffix) Move here from variable.c, renamed
689 from var_set_short_name_suffix, make static, update caller.
691 * sys-file-private.c: New file.
692 (sfm_width_to_bytes) Moved here from variable.c, renamed from
693 width_to_bytes, update callers.
695 * sys-file-private.h: New file. Later it will supplant
696 sfm-private.h; for now it supplements it.
697 (macro MIN_VERY_LONG_STRING) New macro.
698 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
700 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
701 MAX_LONG_STRING was used before.
703 * sys-file-writer.c: Ditto.
705 * value-labels.c: Change the paradigm here to be that a null
706 pointer is OK for a struct val_labs * in most cases; it just
707 represents an empty set of value labels.
708 (val_labs_copy) A copy of a null set is a null set.
709 (val_labs_count) A null set has 0 labels.
710 (val_labs_replace) Change return type to void. Rewrite for
712 (val_labs_find) A null set does not contain the value.
713 (value_to_string) Moved to variable.c, renamed var_get_value_name,
714 transposed argument order, updated all callers.
717 (value_dup) Moved here from variable.c.
718 (compare_values) Ditto.
721 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
722 (macro MAX_LONG_STRING) Removed, because it was only interesting
723 for system files, not for general code.
724 (macro MAX_VERY_LONG_STRING) Ditto.
725 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
726 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
728 * vardict.h: New file, for an interface between variables and
731 * variable.c: A lot of functions were moved around, for better
733 (struct variable) Move definition here, from variable.h.
734 (var_type_adj) Removed--makes i18n hard.
735 (var_type_noun) Ditto.
736 (var_create) New function.
737 (var_clone) New function.
738 (var_destroy) New function.
739 (var_set_name) Assert that variable is not in a dictionary.
740 (compare_var_names) Rename compare_vars_by_name and fix a couple
741 of callers who thought the args were strings.
742 (hash_var_name) Rename hash_var_by_name.
743 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
744 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
745 (var_is_very_long_string) Removed, because it was only interesting
747 (var_set_missing_values) Allow the argument to be the wrong width,
748 as long as we can resize it. Simplify callers who were doing the
750 (var_get_value_labels) New function.
751 (var_has_value_labels) New function.
752 (var_set_value_labels) New function.
753 (alloc_value_labels) New function.
754 (var_add_value_label) New function.
755 (var_replace_value_label) New function.
756 (var_clear_value_labels) New function.
757 (var_lookup_value_label) New function.
758 (var_get_value_name) Moved here from variable.c, renamed from
759 var_get_value_name, transposed argument order, updated all
761 (var_to_string) Moved here, from variable-label.c.
762 (var_set_leave) New function.
763 (var_get_leave) New function.
764 (var_must_leave) New function.
765 (var_set_short_name_suffix) Moved to dictionary.c, renamed
766 set_var_short_name_suffix.
767 (var_get_dict_index) New function.
768 (var_get_case_index) New function.
769 (var_get_obs_vals) New function.
770 (var_set_obs_vals) New function.
771 (var_has_obs_vals) New function.
772 (var_get_vardict) New function.
773 (var_set_vardict) New function.
774 (var_has_vardict) New function.
775 (var_clear_vardict) New function.
776 (value_dup) Moved to value.c.
777 (compare_values) Ditto.
780 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
781 (enum ALPHA) Rename VAR_STRING, update all users.
783 * vector.c: New file.
784 (struct vector) Moved here, from variable.h.
785 (check_widths) New function.
786 (vector_create) New function.
787 (vector_clone) New function.
788 (vector_destroy) New function.
789 (vector_get_name) New function.
790 (vector_get_var) New function.
791 (vector_get_var_cnt) New function.
792 (compare_vector_ptrs_by_name) New function.
794 * vector.h: New file.
796 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
798 * casefilter.c (casefilter_variable_missing): Avoided comparision of
799 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
802 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
804 * value-labels.c (destroy_atoms): New function.
805 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
807 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
809 Thanks to Jason Stover for pointing out this problem.
811 * data-out.c (output_number): Use gsl_finite from GSL, which is
812 portable, instead of isfinite, which is not.
815 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
817 * variable.c variable.h (value_dup): New function.
819 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
821 Start converting struct variable to an opaque type. In this
822 phase, we add a bunch of setter and getter functions and convert
823 most of the PSPP code to use them. The resulting changes are
824 pervasive but mostly trivial, and only the notable changes are
827 * format.c (fmt_equal): New function.
829 * variable.c (var_type_is_valid): New function.
830 (measure_is_valid) Moved here, from format.c.
831 (alignment_is_valid) Moved here, from format.c.
832 (var_get_name) New function.
833 (var_set_name) New function.
834 (width_to_type) New function.
835 (var_get_type) New function.
836 (var_get_width) New function.
837 (var_set_width) New function.
838 (var_is_numeric) New function.
839 (var_is_alpha) New function.
840 (var_is_short_string) New function.
841 (var_is_long_string) New function.
842 (var_is_very_long_string) New function.
843 (var_get_missing_values) New function.
844 (var_set_missing_values) New function.
845 (var_clear_missing_values) New function.
846 (var_has_missing_values) New function.
847 (var_is_value_missing) New function.
848 (var_is_num_missing) New function.
849 (var_is_str_missing) New function.
850 (var_is_value_user_missing) New function.
851 (var_is_num_user_missing) New function.
852 (var_is_str_user_missing) New function.
853 (var_is_value_system_missing) New function.
854 (var_get_print_format) New function.
855 (var_set_print_format) New function.
856 (var_get_write_format) New function.
857 (var_set_write_format) New function.
858 (var_set_both_formats) New function.
859 (var_get_label) New function.
860 (var_set_label) New function.
861 (var_clear_label) New function.
862 (var_has_label) New function.
863 (var_get_measure) New function.
864 (var_set_measure) New function.
865 (var_get_display_width) New function.
866 (var_set_display_width) New function.
867 (var_get_alignment) New function.
868 (var_set_alignment) New function.
869 (var_get_value_cnt) New function.
870 (var_get_leave) New function.
871 (var_get_short_name) New function.
873 * variable.h: (struct variable) Removed "type" and "nv" members;
874 they are now computed from "width" where needed.
876 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
878 * missing-values.c (mv_resize): Don't write beyond end of the
879 allocated buffer when resizing a long string.
881 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
883 Clean up identifier code: don't require identifier enumerations to
884 be in a particular order; make better use of string library;
885 expose less of the internals.
887 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
888 change interface. Updated all callers.
889 (lex_id_match) Change interface to use struct substring, update
891 (lex_id_match_len) Removed. Update callers to use lex_id_match.
892 (global array keywords[]) Make static, change form. Update all
893 users to use lex_id_name instead.
894 (lex_is_keyword) New function.
895 (lex_id_to_token) Change interface to use struct substring, update
897 (lex_id_name) New function.
899 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
900 lex_is_keyword instead.
901 (T_LAST_KEYWORD) Removed.
902 (T_N_KEYWORDS) Removed.
904 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
906 * format.c: (fmt_date_template) Distinguish characters for which a
907 space is output and any date delimiter is allowed on input, from
908 those for which a space is output and only a space is allowed on
909 input. The former is represented by X, the latter by a space.
910 Also, drop distinction between h and H, changing the former to the
913 * data-in.c: Completely rewrite internals to conform to SPSS input
914 formats as closely as possible.
915 (data_in) Changed external interface by replacing the structure
916 that was used as a single argument by a set of arguments. Updated
918 (data_in_finite_line) Removed. Converted all callers to use plain
920 (data_in_get_integer_format) New function.
921 (data_in_set_integer_format) New function.
922 (data_in_get_float_format) New function.
923 (data_in_set_float_format) New function.
925 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
926 (struct data_in) Removed.
928 * data-out.c: (output_date) Drop each component from the input as
929 it is output, to allow us to drop the distinction between h (a
930 count of hours) and H (the hour of day) template characters.
931 Also, handle new X template character.
932 (output_scientific) Follow more rational rule on when to drop
933 fraction introduced between SPSS 13 and 15. Updated test case to
936 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
938 Fix buffer overflow reported by John Darrington.
940 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
941 realize that DIGITS is a count of nibbles, not of bytes.
943 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
945 * calendar.c (calendar_offset_to_gregorian) Also return the
946 year-of-day. Change callers to new interface.
948 * data-out.c: Completely rewrite internals to conform to SPSS
949 output formats as completely as possible.
950 (data_out) Change interface to put input parameters before output
951 parameters, for consistency with the style I now prefer. Update
953 (data_out_get_integer_format) New public function.
954 (data_out_set_integer_format) New public function.
955 (data_out_get_float_format) New public function.
956 (data_out_set_float_format) New public function.
958 * data-out.h: New file. Move prototype for data_out here, from
961 * format.c: (fmt_step_width) Use equality comparison instead of
962 bitwise and, for clarity.
963 (fmt_is_string) Ditto.
964 (fmt_input_to_output) Fix categories that are translated to F
967 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
969 * casefilter.c casefilter.h (new files), casefile.c casefile.h
970 casefile-private.h: Added casefilter to assist commands with missing
973 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
975 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
977 * settings.c: (route_errors_to_terminal) New variable.
978 (route_errors_to_listing) New variable.
979 (get_error_routing_to_terminal) New function.
980 (set_error_routing_to_terminal) New function.
981 (get_error_routing_to_listing) New function.
982 (set_error_routing_to_listing) New function.
984 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
986 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
988 * format.c: Completely rewrite, to achieve better abstraction.
989 Rewrite all references to formats in other files.
991 * format.def: Rewrite and reorganize.
993 * settings.c: Move everything related to custom currency formats
994 into format.[ch], changing them in form, so as to group related
995 code and definitions better. Changed all references to use the
997 (static var decimal) Removed.
998 (static var grouping) Removed.
999 (static var cc) Removed.
1000 (get_decimal) Removed.
1001 (set_decimal) Removed.
1002 (get_grouping) Removed.
1003 (set_grouping) Removed.
1007 * settings.h: (macro CC_CNT) Removed.
1008 (macro CC_WIDTH) Removed.
1009 (struct custom_currency) Removed.
1011 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1013 * data-in.c (data_in): Use switch statement instead of table, to
1014 avoid dependence on the order of the FMT_* enums.
1016 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1018 * data-out.c: (num_to_string) Removed, because it was dead code.
1020 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1022 * data-in.c (parse_trailer): Fix error message.
1024 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1026 * format.c (fmt_is_binary): New function.
1028 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1030 * procedure.c procedure.h: Encapsulated the static data into a single
1033 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1035 * casefile.c (casereader_read_xfer): Always initialize the case,
1036 even on an error condition.
1038 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1040 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1041 entire function useless.
1043 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1045 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1046 casereader method casereader_clone.
1048 * procedure.c pransformations.h: Introduced new type casenum_t
1050 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1052 * variable.c: (width_to_bytes) Rephrase code for clarify.
1054 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1056 * format.c: (fmt_type_from_string) New function.
1057 (fmt_to_string) Include decimals in output if the format has
1058 decimals, even if the format type does not. This way, we can
1059 accurately reproduce incorrect formats in user output.
1060 (check_common_specifier) Make the check for a bad format type an
1061 assertion, so we get bug reports if they show up. Fix message.
1062 Check for decimal places with a format type that doesn't allow
1064 (check_input_specifier) Remove check for FMT_X, which has been
1066 (check_output_specifier) Ditto.
1068 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1070 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1071 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1072 (enum fmt_parse_flags) Removed.
1074 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1076 * casefile.c casefile.h: Converted to an abstract base class.
1077 * casefile-private.h fastfile.c fastfile.h: New files.
1078 * automake.mk procedure.c scratch-writer.c storage-stream.c
1080 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1082 * procedure.c (internal_procedure): Create sink_case with only as
1083 many values as the compacted dictionary.
1085 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1087 Remove "debugging" code that caused plenty of false positives and
1090 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1092 * case.c: Remove all references to `this' member.
1094 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1096 Fix link error noted by Jason Stover.
1098 * storage-stream.c: Include <assert.h>.
1100 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1102 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1103 ALL) and additional underlying system file issues.
1105 Thanks to John Darrington for review.
1107 First problem: var_hash points to variables not owned by the
1108 sys-file-reader, which the caller may free or modify. Use an
1109 array of sfm_vars instead, as done earlier (e.g. CVS version
1112 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1113 members and remove all code that references it. Add vars, var_cnt
1114 members. Remove fix_specials member, which was unused.
1115 (struct sfm_var) Remove name member, which was unused.
1116 (sfm_close_reader) Free vars member instead of var_hash.
1117 (compare_var_shortnames) Removed.
1118 (hash_var_shortname) Removed.
1119 (sfm_open_reader) Fill out vars array.
1120 (compare_var_index) Removed.
1121 (sfm_read_case) Use vars instead of var_hash.
1123 Second problem: we're confused about when we actually have very
1124 long strings, causing us to choose incorrectly between slow path
1125 and fast path in sfm_read_case.
1127 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1128 have very long strings, not when we have long variable names,
1129 which is an unrelated feature.
1131 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1133 * variable.h: Move var_set and variable parsing declarations to
1134 new header, src/language/lexer/variable-parser.h. Modified lots
1135 of files to include the new header.
1137 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1139 * value-labels.c (value_to_string): When there's no value label,
1140 format the variable according to its print format, instead of
1141 always effectively using A or F format.
1143 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1145 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1148 * format.c: Removed tortological assertion.
1150 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1152 Reform string library.
1154 * file-name.c (fn_interp_vars): Change interface to take a
1155 substring as input. Updated all users.
1157 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1159 * format.c (measure_is_valid): Really return false when m >=
1162 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1164 Implement random access to casefiles, for use in GUI.
1166 * casefile.c: (struct casereader) Add `random', `file_ofs',
1167 `buffer_ofs' members.
1168 (casefile_get_random_reader) New function.
1169 (read_open_file) Break part into new function
1170 seek_and_fill_buffer().
1171 (fill_buffer) Update buffer_ofs, file_ofs.
1172 (casereader_seek) New function.
1174 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1176 * settings.c: Added call to i18n{done, init}.
1178 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1180 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1183 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1185 * casefile.c: Convert many uses of `int' to `bool'.
1187 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1189 * transformations.c (trns_chain_destroy): Destroy chain's trns
1190 member, to fix memory leak.
1192 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1194 * storage-stream.c (storage_source_decapsulate): Destroy case
1195 source to fix memory leak.
1197 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1199 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1200 case passed as argument instead of initializing the argument as a
1201 case. Fixes memory leak that showed up in
1202 tests/command/aggregate.sh with scratch files.
1204 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1206 * procedure.c (proc_done): Destroy default_dict, to fix memory
1209 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1211 Simplify procedure_with_splits().
1213 * procedure.c (struct split_aux_data): Removed case_count member.
1214 (procedure_with_splits) Don't initialize case_count.
1215 (split_procedure_case_func) Check whether prev_case is null
1216 instead of case_count.
1217 (split_procedure_end_func) Ditto.
1219 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1221 * case.c (case_move): Do nothing if dst and src are the same
1223 (case_try_create) Merge two similar cases.
1224 (case_copy) Unshare only if data must be actually copied.
1226 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1228 * data-in.c data-out.c dictionary.c sys-file-reader.c
1229 sys-file-writer.c variable.c variable.h: Reworked very long string
1230 support for better encapsulation.
1232 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1234 * value-labels.c (val_labs_can_set_width): New function.
1235 (val_labs_set_width) Clear labels if increasing width to long
1237 (val_labs_destroy) Remove unneeded test for null.
1239 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1241 * value-labels.h: Remove unneeded dependency on variable.h.
1243 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1245 Get rid of `char *c' member in union value, for cleanliness.
1247 * value.h: (union value) Remove `c' member.
1249 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1251 Make dictionary compacting functions a little more general.
1253 * sys-file-writer.c (sfm_open_writer): Use
1254 dict_compacting_would_change().
1255 (does_dict_need_translation) Removed.
1257 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1259 Make dictionary compacting functions a little more general.
1261 * dictionary.c (dict_needs_compaction): Rename
1262 dict_compacting_would_shrink(). Update all callers.
1263 (dict_compacting_would_change) New function.
1265 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1267 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1268 inverted return value (!).
1270 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1272 Continue reforming procedure execution.
1274 * procedure.c: Search and replace "vfm" by "proc". Notably:
1275 (static var vfm_source) Rename proc_source. Update all
1277 (static var vfm_sink) Rename proc_sink. Update all references.
1279 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1281 Continue reforming procedure execution. In this phase, remove
1282 PROCESS IF, which was deprecated anyway and can be easily
1283 simulated with TEMPORARY followed by SELECT IF.
1285 * procedure.c: (open_active_file) Don't call
1286 add_process_if_trns().
1287 (discard_variables) Get rid of redundant call to
1288 proc_cancel_all_transformations().
1289 (add_process_if_trns) Removed.
1290 (process_if_trns_proc) Removed.
1291 (process_if_trns_free) Removed.
1293 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1295 Continue reforming procedure execution. In this phase, add
1296 `const' to the case passed to procedure()'s callback.
1298 Updated all users of procedure() as well.
1300 * procedure.c: (struct write_case_data) Add "const" to ccase
1301 parameter for case_func member.
1302 (procedure) Add "const" to ccase parameter for proc_func
1304 (multipass_case_func) Make ccase parameter const.
1305 (internal_procedure) Add "const" to ccase parameter for case_func
1307 (split_procedure_case_func) Make ccase parameter const.
1308 (multipass_split_case_func) Make ccase parameter const.
1310 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1312 Continue reforming procedure execution. In this phase, get rid of
1313 the output code for SPLIT FILE groups in procedure.c, which really
1314 shouldn't be doing any output. Move it into the individual
1315 procedures instead. This also adds some flexibility.
1317 Updated many users of procedure_with_splits() and
1318 multipass_procedure_with_splits() to call
1319 output_split_file_values() and to deal with increased use of
1322 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1323 parameter to begin_func member.
1324 (procedure_with_splits) Add "const struct ccase *" parameter to
1325 begin_func parameter. Make ccase parameter const in proc_func
1327 (split_procedure_case_func) Don't dump split file group. Pass
1329 (dump_splits) Moved to language/dictionary/split-file.c as
1330 output_split_file_values().
1331 (struct multipass_split_aux_data) Add "const struct ccase *"
1332 parameter to split_func member.
1333 (multipass_procedure_with_splits) Add "const struct ccase *"
1334 parameter to split_func parameter.
1335 (multipass_split_case_func) Save new SPLIT FILE case before
1337 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1339 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1341 Continue reforming procedure execution. Change
1342 internal_procedure() so that it calls open_active_file() and
1343 close_active_file(), which isolates most of the actual procedure
1346 * procedure.c: (struct write_case_data) Rename `proc_func' member
1347 to `case_func' and update all references.
1348 (procedure) Rewrite as one-line wrapper around
1349 internal_procedure().
1350 (struct multipass_aux_data) New.
1351 (multipass_callback) Renamed multipass_case_func(). Use struct
1352 multipass_aux_data as auxiliary data.
1353 (multipass_end_func) New function.
1354 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1355 that uses multipass_case_func, multipass_end_func.
1356 (internal_procedure) Add `end_func' argument. Move optimization
1357 of trivial case in here. Move call to open_active_file() and
1358 close_active_file() in here. Now assert that vfm_source is
1360 (procedure_with_splits_callback) Rename
1361 split_procedure_case_func().
1362 (split_procedure_end_func) New function.
1363 (multipass_split_callback) Rename multipass_split_case_func.
1364 (multipass_split_end_func) New function.
1365 (discard_variables) No need to test for nonnull vfm_source.
1367 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1369 Continue reforming procedure execution. Get rid of unused member.
1371 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1373 (write_case) Don't increment cases_analyzed.
1375 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1377 Continue reforming procedure execution. In this phase, move
1378 procedure.c and procedure.h from src to src/data. Update
1379 makefiles and #includes accordingly.
1381 * procedure.c: Moved here from src/.
1383 * procedure.h: Moved here from src/.
1385 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1387 Continue reforming procedure execution. In this phase, get rid of
1388 many global variables, consolidating procedure execution in
1389 procedure.c. Encapsulate transformations in new "struct
1390 trns_chain". Also, change implementation of N OF CASES, FILTER,
1391 and PROCESS IF from special cases to transformations.
1393 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1396 * dictionary.c: (global variable default_dict) Move to
1399 * variable.h: (TRNS_*) Move to transformations.h.
1400 (struct transformation) Move to transformations.c.
1402 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1404 * sys-file-reader.c: Fixed invalid read problems.
1406 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1408 * storage-stream.c: Add missing function comments.
1410 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1412 Continue reforming procedure execution. In this phase, add some
1413 new, needed functionality to storage-stream.
1415 * storage-stream.c: (storage_source_decapsulate) New function.
1417 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1419 * variable.c (width_to_bytes): Declarations must precede
1420 statements for C90 compliance.
1422 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1424 * data-out.c, data-in.c, variable.c, variable.h: New functions
1425 copy_mangle and copy_demangle for reading/writing cases; emulates the
1426 way SPSS deals with strings > 255 bytes.
1428 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1429 subtype 14 needed for strings longer than 255 bytes.
1431 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1432 instead of literal values. Also fixed some constness issues.
1434 * format.h: Constness
1436 * sfm-private.h: Renamed the case_size identifier, since I discovered
1437 that SPSS's respect for this variable is very nominal.
1439 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1441 Change case limit type from int to size_t.
1443 * dictionary.c: (struct dictionary) Change type of case_limit
1445 (dict_get_case_limit) Change return type.
1446 (dict_set_case_limit) Change parameter type.
1448 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1450 * variable.h: (struct variable) Rename `reinit' member as `leave'
1451 and invert sense. Fix up all references.
1453 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1455 Continue reforming procedure execution. In this phase, break
1456 procedure.c into multiple files.
1458 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1460 * case-sink.c: New file.
1462 * case-sink.h: New file.
1464 * case-source.c: New file.
1466 * case-source.h: New file.
1468 * storage-stream.c: New file.
1470 * storage-stream.h: New file.
1472 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1474 * variable.h: (struct variable) Remove `init' member and all
1475 references to it from other files. It was initialized in several
1476 places, but nothing really ever used it for anything worthwhile.
1477 Thanks to Jason Stover for pointing out how confusing this
1480 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1482 Continue reforming error message support. In this phase, get rid
1483 of message "titles" and put the message text in `struct error'.
1484 Now `struct error' encapsulates a message more properly.
1486 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1487 Format message ourselves.
1489 * data-in.c: (vdls_error) Ditto.
1491 * por-file-reader.c: (error) Ditto.
1493 * sys-file-reader.c: (corrupt_msg) Ditto.
1495 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1497 GNU standards require "file name" instead of "filename" in
1498 documentation. It's nice for our code to follow the convention
1501 * casefile.c: (struct casefile) Rename `filename' member to
1502 `file_name'. Updated all references.
1504 * file-name.c: [!unix] (struct file_identity) Rename
1505 normalized_filename member to normalized_file_name. Updated all
1508 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1510 We don't really support anything but Unix-like environments well,
1511 so we might as well de-obfuscate by writing directory and path
1512 separators explicitly.
1514 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1516 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1517 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1519 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1522 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1524 GNU standards require "file name" instead of "filename" in
1525 documentation. It's nice for our code to follow the convention
1528 * filename.c: Rename to file-name.c.
1530 * filename.h: Rename to file-name.h. Update all inclusions.
1531 Update header guards.
1533 * automake.mk: Update file names.
1535 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1537 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1539 (fn_basename) Removed (dead code).
1540 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1541 (fn_special_p) Renamed fn_is_special(), all references updated.
1542 (fn_exists_p) Renamed fn_exists(), all references updated.
1544 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1546 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1547 Also, now it only tilde-expands file names, not paths.
1548 (fn_search_path) Tilde-expand one directory at a time.
1550 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1552 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1553 get rid of non-Unixlike version of the code, which has probably
1555 (fn_prepend_dir) Removed (dead code).
1557 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1558 (macro PATH_SEPARATOR_STRING) New.
1559 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1561 Continue reforming error message support. In this phase, we get
1562 rid of VM() and the other msg() support for "verbosity", replacing
1563 it by a new function verbose_msg().
1565 * filename.c: (fn_search_path) Use verbose_msg() instead of
1568 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1570 * sfm-private.h: Get rid of #defines after #error, which makes no
1573 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1575 Get rid of our own int32 type in favor of the standard int32_t
1578 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1581 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1583 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1585 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1587 Remove ill-considered file routines that are no longer used.
1589 * filename.c: (fn_open_ext) Removed.
1590 (fn_close_ext) Removed.
1592 * filename.h: (struct file_ext) Removed.
1594 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1596 * variable.c (var_is_valid_name): Move declarations before code
1599 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1601 * filename.ch (fn_interp_vars): Fixed small buglet.
1603 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1605 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1606 so as to modify the string inline. Thus makeing it easier to
1607 destroy the results when no longer needed.
1609 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1611 * category.c (cat_stored_values_destroy): Fixed memory leak.
1613 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1615 Add some missing frees. Thanks to John Darrington for reporting
1618 * any-writer.c (any_writer_close): Free writer.
1620 * any-reader.c (any_reader_close): Free reader.
1622 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1624 * por-file-reader.c: (error) Mark as NO_RETURN.
1626 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1628 * settings.c: Changed default value of scompress to true.
1630 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1632 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1634 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1637 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1638 here from pref.h.orig.
1640 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1642 * sys-file-reader.c: Fixed bug reading compressed files.
1644 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1646 * Numerous renames. See src/ChangeLog for details.
1648 * Moved files from src directory