1 2007-07-22 Ben Pfaff <blp@gnu.org>
3 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
4 local variable instead of literal 5.
6 2007-07-22 Ben Pfaff <blp@gnu.org>
8 Fix problems with uniqueness of short names in system files with
9 very long string variables. Now a variable may have multiple
12 * automake.mk (src_data_libdata_a_SOURCES): Add new files
13 short-names.c, short-names.h.
15 * dictionary.c (dict_clone): Clone all the short names.
16 (compare_strings): Move into short-names.c.
17 (hash_strings): Ditto.
18 (set_var_short_name_suffix): Ditto.
19 (dict_assign_short_names): Ditto, rename short_names_assign,
20 change to assign all short names.
22 * por-file-writer.c (write_variables): Use short_names_assign
23 instead of dict_assign_short_names.
25 * short-names.c: New file.
27 * short-names.h: New file.
29 * sys-file-private.c (sfm_width_to_segments): New function.
31 * sys-file-reader.c (read_long_var_name_map): Save and restore all
32 the short names, not just the first one.
34 * sys-file-writer.c (cont_var_name): Removed.
35 (sfm_open_writer): Use short_names_assign instead of
36 dict_assign_short_names. Use unique short names assigned by
37 short_names_assign instead of those generated by cont_var_name.
39 * variable.c (struct variable): Remove `short_name' member,
40 replace by `short_names' and `short_name_cnt'.
41 (var_create) Initialize new members.
42 (var_get_short_name_cnt): New function.
43 (var_get_short_name): Now takes an index argument. Changed most
45 (var_set_short_name): Ditto.
46 (var_clear_short_name): Renamed var_clear_short_names, changed to
47 clear all short names.
49 2007-07-22 Ben Pfaff <blp@gnu.org>
51 * variable.c (var_set_width): Use new var_set_width function.
53 * missing-values.c (mv_n_values): Drop assertion, which was not
56 * format.c (fmt_default_for_width): New function.
57 (fmt_resize): New function.
59 2007-07-18 John Darrington <john@darrington.wattle.id.au>
61 * datasheet.c (datasheet_delete_columns): Added assertion to check
62 we're not deleting outside the range of the sheet.
65 * dictionary.c dictionary.h variable.c: Added the ability for string
66 variables to be resized.
68 * vardict.h: Added some prototypes (moved from dictionary.h) as
69 these should only be called by variable.c
72 2007-07-14 John Darrington <john@darrington.wattle.id.au>
74 * sfm-reader.c: Respect case_cnt field in file header.
76 2007-07-01 John Darrington <john@darrington.wattle.id.au>
78 * transformation.c transformation.h (trns_chain_execute): Changed the
79 signature (Patch #6057)
81 2007-06-10 Ben Pfaff <blp@gnu.org>
83 * casereader-filter.c (casereader_filter_destroy): Make sure to
84 write all the remaining excluded cases to the casewriter, if any.
86 * caseinit.c (init_list_destroy): Rewrite.
87 (init_list_clear): Ditto.
89 * casegrouper.c (casegrouper_get_next_group): Always set *reader
90 to null when returning false.
92 2007-06-06 Ben Pfaff <blp@gnu.org>
94 Actually implement the new procedure code and adapt all of its
95 clients to match. Also adapt all of the other case sources and
96 sinks in the tree and their clients to use the
97 casereader/casewriter infrastructure.
99 * automake.mk: Add and remove files.
101 * any-reader.c: Change into a casereader.
102 * por-file-reader.c: Ditto.
103 * scratch-reader.c: Ditto.
104 * sys-file-reader.c: Ditto.
106 * any-writer.c: Change into a casewriter.
107 * por-file-writer.c: Ditto.
108 * scratch-writer.c: Ditto.
109 * sys-file-writer.c: Ditto.
111 * procedure.c: Change to use casereader, casewriter, caseinit, and
112 other new infrastructure.
114 * scratch-handle.c: Adapt to new infrastructure.
116 * case-sink.c: Removed, now dead code.
117 * case-sink.h: Ditto.
118 * case-source.c: Ditto.
119 * case-source.h: Ditto.
120 * casefile-factory.c: Ditto.
121 * casefile-private.h: Ditto.
124 * casefilter.c: Ditto.
125 * casefilter.h: Ditto.
128 * fastfile-factory.c: Ditto.
129 * fastfile-factory.h: Ditto.
130 * storage-stream.c: Ditto.
131 * storage-stream.h: Ditto.
133 2007-06-06 Ben Pfaff <blp@gnu.org>
137 * automake.mk: Add new files.
139 * datasheet.c: New file.
141 * datasheet.h: New file.
143 2007-06-06 Ben Pfaff <blp@gnu.org>
145 Until now, the procedure code has provided a case to the
146 case_source, which has filled in the data values that come from
147 the active file. "Left" data values that don't come from the
148 active file naturally stay the same from case to case, because the
149 procedure code keeps using that same case.
151 One of the compromises that comes with the new procedure code is
152 that the active file allocates and provides its own case, which
153 the procedure code then has to resize to provide room for any
154 other variables that should go in the case and then fill in the
155 values of "left" variables. Then, when we're done with that case,
156 we have to save the values of "left" variables to copy into the
157 next case read from the active file.
159 The caseinit code helps with this.
161 * automake.mk: Add new files.
163 * caseinit.c: New file.
165 * caseinit.h: New file.
167 2007-06-06 Ben Pfaff <blp@gnu.org>
169 * value.h (value_cnt_from_width): New function.
171 * variable.c (var_get_value_cnt): Use new function.
173 2007-06-06 Ben Pfaff <blp@gnu.org>
175 Add casegrouper, to allow cases read from a given casereader to be
176 broken into groups, each of which has its own casereader.
177 Generally cases are grouped based on having equal values for some
180 * automake.mk: Add new files.
182 * casegrouper.c: New file.
184 * casegrouper.h: New file.
186 2007-06-06 Ben Pfaff <blp@gnu.org>
188 Add interface to lexicographical ordering of cases.
190 * automake.mk: Add new files.
192 * case-ordering.c: New file.
194 * case-ordering.h: New file.
196 2007-06-06 Ben Pfaff <blp@gnu.org>
198 Add casereaders and casewriters, the basis of the new data processing
199 implementation. A casereader is a uniform interface to reading cases
200 from a data source; a casewriter is a uniform interface to writing
201 cases to a data sink.
203 * automake.mk: Add new files.
205 * casereader-filter.c: New file.
207 * casereader-provider.h: New file.
209 * casereader-translator.c: New file.
211 * casereader.c: New file.
213 * casereader.h: New file.
215 * casewriter-provider.h: New file.
217 * casewriter-translator.c: New file.
219 * casewriter.c: New file.
221 * casewriter.h: New file.
223 2007-06-06 Ben Pfaff <blp@gnu.org>
225 "casewindow" data structure that extends the deque (from libpspp)
226 of cases with the ability to dump cases to disk if we get too many
229 * automake.mk: Add new files.
231 * casewindow.c: New file.
233 * casewindow.h: New file.
235 2007-06-06 Ben Pfaff <blp@gnu.org>
237 sparse_cases data structure that augments a sparse_array of cases
238 with the ability to dump cases to disk if we get too many cases in
241 * automake.mk: Add new files.
243 * sparse-cases.c: New file.
245 * sparse-cases.h: New file.
247 2007-06-06 Ben Pfaff <blp@gnu.org>
249 Adds a low-level on-disk case array data structure.
251 * automake.mk: Add new files.
253 * case-tmpfile.c: New file.
255 * case-tmpfile.h: New file.
257 2007-06-06 Ben Pfaff <blp@gnu.org>
259 In a couple of places we calculate the maximum number of cases to
260 keep in memory based on the user-defined workspace. Enable
261 centralizing the calculation through a new function.
263 * settings.c (get_workspace_cases): New function.
265 2007-06-06 Ben Pfaff <blp@gnu.org>
267 The casenumber type is defined in transformations.h, but case.h is
268 a more sensible place. Move it.
270 * case.h (CASENUMBER_MAX): New macro.
271 (typedef casenumber): Move here, from transformations.h.
273 2007-06-03 Ben Pfaff <blp@gnu.org>
275 Slightly generalize case_to_values and case_from_values functions.
277 * case.c (case_to_values): Rename case_copy_out, change interface.
278 (case_from_values): Rename case_copy_in, change interface.
280 * fastfile.c (fastfilereader_get_next_case): Update caller.
281 (write_case_to_disk): Ditto.
283 2007-06-02 Ben Pfaff <blp@gnu.org>
285 Clean up after a forgotten part of patch #5829.
287 * casedeque.h: Remove unused file.
289 * automake.mk: Remove casedeque.h from sources.
291 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
293 * category.c: Removed redundant #include
295 2007-05-06 Ben Pfaff <blp@gnu.org>
297 Abstract the documents within a dictionary a little better.
298 Thanks to John Darrington for suggestion, initial version, and
301 * dictionary.c (struct dictionary): Change `documents' member from
302 char * to struct string.
303 (dict_clear): Destroy struct string.
304 (dict_get_documents): Convert struct string to char *.
305 (dict_set_documents): Set struct string. Pad to 80-character
307 (dict_clear_documents): New function.
308 (dict_add_document_line): New function.
309 (dict_get_document_line_cnt): New function.
310 (dict_get_document_line): New function.
312 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
314 * sys-file-reader.c (read_documents): Use new document functions.
316 2007-04-19 John Darrington <john@darrington.wattle.id.au>
318 * sys-file-reader.c: When reading a system file which has no
319 long name table, automatically create one where the long names
320 are the lower case versions of the short names.
322 2007-04-22 Ben Pfaff <blp@gnu.org>
324 * dictionary.c (dict_set_split_vars): dict_destroy expects that
325 dict_clear will free most data related to the dictionary.
326 dict_clear does a decent job, except that dict_set_split_vars on
327 some systems won't actually free the dict's "split" member.
328 Instead, it'll allocate a 1-byte region. Fix this.
330 * value.c (value_copy): New function.
331 (value_set_missing): Ditto.
333 2007-04-22 John Darrington <john@darrington.wattle.id.au>
335 * Deleted existing category.h and moved cat-routines.h into
336 category.h Encapsulated struct cat_vals better.
338 2007-04-19 John Darrington <john@darrington.wattle.id.au>
340 * sys-file-reader.c: When reading a system file which has no
341 long name table, automatically create one where the long names
342 are the lower case versions of the short names.
344 2007-04-16 John Darrington <john@darrington.wattle.id.au>
346 * sys-file-reader.c: Some versions of Other Software seem to
347 produce system files with string variables' measure set to
348 zero. We'll assume these are supposed to be nominal variables.
350 2007-03-30 Ben Pfaff <blp@gnu.org>
352 * procedure.c: Adapt to new deque data structure.
354 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
355 Ben Pfaff <blp@gnu.org>
357 * file-name.c: Mingw compatibility fixes.
358 (fn_search_path): Use ISSLASH instead of comparing against '/'
360 (fn_dir_name): Use dir_name from gnulib.
361 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
362 (fn_get_identity): Use GetFullPathName instead of canonicalize
363 from gnulib, because the latter does not fully support
364 Windows-style path names. Use this implementation based on the
365 detected presence of Windows instead of the absence of Unix, since
366 the new implementation is Windows-specific.
367 (fn_compare_file_identities): In Windows implementation, compare
368 names case-insensitively.
370 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
372 * make-file.c: Don't include mkstemp.h, because gnulib now causes
373 <stdlib.h> to have the same effect.
375 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
377 * por-file-reader.c: Add missing _() around messages.
379 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
381 * make-file.c: Include "mkstemp.h", without which linking on
384 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
386 Reduce platform dependence.
388 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
389 Everywhere we using this, we really should have just depended on
390 the shell to expand tildes.
391 (fn_search_path): Simplify, given that we don't do tilde expansion
393 (fn_normalize): Removed. Caller changed to use the canonicalize
395 (fn_get_cwd): Removed. Only user was fn_normalize.
396 (fn_is_absolute): Really only test for absolute names.
397 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
399 (fn_readlink): Removed, as it was only used fn_normalize.
400 (fn_exists): Assume the stat function is available; gnulib does.
401 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
403 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
405 * dictionary.c (dict_create_vector_assert): New function.
407 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
409 * file-name.c (fn_normalize): Correct name of function
410 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
411 for pointing this out.
413 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
415 We are using a single member in struct file_handle, the "name"
416 field, for more than one purpose. When it begins with '"', it's a
417 file name; otherwise, it's a token that can be used to identify
418 it. When that assertion fires, it's because we searched for the
419 name case-sensitively as a file name (so that there was no match),
420 and then we try to insert it case-insensitively as a token, which
421 fails because duplicates aren't allowed.
423 Solution: break the two purposes into two separate fields. This
424 fixes the problem and likely makes the code easier to read too.
426 Fixes bug #18922. Thanks to John Darrington for bug report and
429 * file-handle-def.c (struct file_handle): New `id' member.
430 (fh_from_name): Rename fh_from_id. Update all callers.
431 (create_handle): New `id' parameter. Update all callers.
432 (fh_create_file): Ditto.
433 (fh_get_id): New function.
435 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
437 * case.c (case_is_null): Change return type to bool.
439 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
443 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
444 reference counting to share data. This makes it easy for
445 valgrind, etc. to find accesses to cases that have been destroyed
446 but have been kept around by another user's ref-count. This often
447 happens when the data set is small enough to find in memory; if a
448 bigger data set that would overflow to disk were used, then data
449 corruption would occur.
451 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
455 * case.c (case_unshare): Make it check internally whether the
456 ref_cnt is greater than 1, so that the callers don't have to.
457 Update callers not to check.
459 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
461 Before, I was thinking that I might want to get rid of reference
462 counting at some point. Now, I'm pretty sure that it's here to
463 stay. Thus, because we have to store the value_cnt anyway for
464 reference-counted cases, we might as well expose it to users.
466 * case.c (case_get_value_cnt): New function.
467 (case_resize): Drop OLD_CNT argument. Update all callers. Only
468 resize case if its size actually changed.
470 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
471 instead of peeking inside struct case directly.
472 (casefile_append): Ditto.
474 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
476 Get rid of the inlines for the case functions, which made the
477 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
478 the inlines didn't speed up "make check" at all, which is not a
479 perfect benchmark but seems indicative.)
481 * case.c: Remove #ifdef DEBUGGING...#endif around many function
482 definitions. Remove some assertions on nonnull pointers that were
483 redundant with a pointer dereference soon after in the function.
485 (struct case_data): Move definition here from case.h.
489 (case_data_wr): Ditto.
491 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
493 * automake.mk: Add casedeque.h to sources.
495 * casedeque.h: New file.
497 * procedure.c: (struct dataset) Change lag_count, lag_head,
498 lag_queue member into single struct casedeque member. Update all
499 users to use the casedeque instead.
502 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
504 * procedure.c: Simplify lagged cases interface. Updated all
505 clients--well, the only client--to use the simplified interface.
506 (dataset_n_lag) Removed.
507 (dataset_set_n_lag) Removed.
508 (dataset_need_lag) New function.
510 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
512 * dictionary.c procedure.c: More changes to ensure that callbacks occur
513 whenever appropriate, but only when the dataset/dictionary is in a
516 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
518 * dictionary.c dictionary.h : Added callbacks for change of filter and
519 split variables. Refactored some code to ensure that callbacks get
520 invoked when appropriate.
522 * procedure.c (proc_cancel_temporary_transformations): Make sure that
523 replace_dict callback occurs when permanent_dict replaces the current
526 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
528 * dictionary.c dictionary.h : Added callback for when the weight
529 variable of a dictionary changes.
531 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
533 * dictionary.c dictionary.h : Added replace_source and replace_dict
534 callbacks, and functions to deal with them.
536 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
538 Simplify missing value handling.
540 * missing-values.h (enum mv_class): New type.
541 (enum mv_type): Moved definition into missing-values.c and renamed
542 each MV_* to MVT_*, to distinguish them from the exposed mv_class
543 enums. Updated all uses.
544 (struct missing_values): Changed type of `type' from `enum
545 mv_type' to `int' because the definition is no longer exposed.
547 * missing-values.c (mv_is_value_missing): Add new enum mv_class
548 parameter. Update all callers.
549 (mv_is_num_missing): Ditto.
550 (mv_is_str_missing): Ditto.
551 (mv_is_value_user_missing): Removed. Changed callers to use
553 (mv_is_num_user_missing): Removed. Changed callers to use
555 (mv_is_str_user_missing): Removed. Changed callers to use
557 (mv_is_value_system_missing): Removed. Changed callers to use
559 (mv_set_type): Removed. Changed callers to use mv_clear.
560 (mv_clear): New function.
562 * variable.c (var_is_value_missing): Add new enum mv_class
563 parameter. Update all callers.
564 (var_is_num_missing): Ditto.
565 (var_is_str_missing): Ditto.
566 (var_is_value_user_missing): Removed. Changed callers to use
567 var_is_value_missing.
568 (var_is_num_user_missing): Removed. Changed callers to use
570 (var_is_str_user_missing): Removed. Changed callers to use
572 (var_is_value_system_missing): Removed. Changed callers to use
573 var_is_value_missing.
575 * casefilter.c (struct casefilter): Use enum mv_class in place of
577 (casefilter_variable_missing): Adapt to new member.
578 (casefilter_create): Change signature to take enum mv_class,
581 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
583 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
585 * case-sink.c case-sink.h procedure.c procedure.h
586 storage-stream.c: Now uses the factory.
588 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
590 Make it possible to pull cases from the active file with a
591 function call, instead of requiring indirection through a callback
594 * case-source.h (struct case_source_class): Change ->read function
595 to return a single case, instead of calling a callback function
596 for each case. Change ->destroy function to return an error
599 * case-source.c (free_case_source): Pass along the value returned
600 by the case_source ->destroy function.
602 * procedure.c (struct write_case_data): Removed.
603 (struct dataset): Added some members to track procedure state.
604 (procedure): Optimize the trivial case at this level.
605 (internal_procedure): Re-implement in terms of proc_open,
606 proc_read, proc_close.
607 (proc_open) New function.
608 (proc_read) New function.
609 (proc_close) New function.
610 (write_case) Moved into proc_read.
611 (close_active_file) Moved closing of data source into proc_close.
613 * storage-source.c: Rewrote to conform with modified
614 case_source_class interface.
616 * transformations.c (trns_chain_execute): Added argument to allow
617 starting execution from an arbitrary transformation. Updated
620 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
622 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
624 * sys-file-reader.c (read_display_parameters): Don't assume that
625 MEASURE_* and ALIGN_* have the same values found in system files.
627 * sys-file-writer.c (write_variable_display_parameters): Ditto.
629 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
630 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
631 the value of n_MEASURES, which was off by 1 (at least from my
634 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
636 * dictionary.c dictionary.h vardict.h variable.c: Added optional
637 callbacks which are invoked when the dictionary or its
638 variables are changed.
640 * missing-values.c missing-values.h value-labels.c: Tidied up
641 consistency checks, and made some of them return false
642 instead of assert-failing.
644 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
646 * calendar.c (calendar_days_in_month): New function.
648 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
650 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
651 the value label's width.
653 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
655 * sfm-private.h: Move contents into sys-file-writer.c, which is
656 the only remaining user. Removed Borland C++-specific directives.
658 * sys-file-reader.c: Clean up and rewrite entire file. The
659 rewritten version is simpler and better abstracted, and should be
660 easier to maintain and extend. It avoids using structures to read
661 file data, which is prone to padding variations among compilers.
662 It should also handle non-IEEE 754 system files, although I
663 haven't been able to find any. It has been tested against many
664 .sav files obtained from the Web and found to produce the same
665 results as the earlier version of the code, or in some cases
666 improved results. It is more tolerant of format variations found
669 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
670 member, putting an enum integer_format in its place. New member
671 `float_format'. Changed `compressed' member to type bool.
673 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
675 * dictionary.c (dict_delete_consecutive_vars): New function.
677 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
679 * file-name.c (fn_search_path): Remove prefix arg that was unused
680 by any caller. Updated all callers.
682 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
684 * format.c (fmt_dollar_template): Use user's decimal point
685 character. Add assertion.
687 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
689 * format.c (fmt_dollar_template): New function, based on
690 dollar_format_template from var-type-dialog.c.
692 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
694 * data-out.c (output_scientific): Fix bad assumption that "buf" is
697 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
699 Finish converting struct variable to an opaque type. In this
700 phase, we add remaining setter and getter functions, convert the
701 remaining PSPP code to use them, and do a bunch of cleanup. The
702 resulting changes are pervasive but mostly trivial, and only the
703 notable changes are logged.
705 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
708 * case.c (case_data): Renamed case_data_idx.
709 (case_num): Renamed case_num_idx.
710 (case_str): Renamed case_str_idx.
711 (case_data_rw): Renamed case_data_rw_idx.
713 * case.h (case_data): New function with old name and an interface
714 that takes a variable instead of an index, which is easier to
715 use. Updated all callers to use the new interface, or to use the
716 new *_idx function (see above).
719 (case_data_rw): Ditto.
721 * category.c (cat_stored_values_destroy): Changed interface to
722 take a struct cat_vals * instead of a struct variable *.
724 * dictionary.c (dict_clone): Use new vector_clone function.
725 (dict_clear) Use new var_destroy function.
726 (add_var) New function.
727 (dict_create_var) Rewrite in terms of dict_create_var_assert.
728 (dict_create_var_assert) Rewrite in terms of add_var.
729 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
730 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
731 (dict_lookup_var) Use new var_create, var_destroy functions.
732 (dict_contains_var) Rewrite in terms of new vardict functionality.
733 (set_var_dict_index) New function.
734 (set_var_case_index) New function.
735 (reindex_vars) New function.
736 (dict_delete_var) Rewrite in terms of new vardict functionality.
737 (dict_reorder_var) Ditto.
738 (dict_reorder_vars) Ditto.
739 (rename_var) New function.
740 (dict_rename_var) Use rename_var.
741 (dict_rename_vars) Use pool to simplify code. Use rename_var.
742 (dict_get_compacted_idx_to_fv) Rename
743 dict_get_compacted_dict_index_to_case_index, update callers.
744 (dict_create_vector) Use new vector_create function.
745 (dict_clear_vectors) Use new vector_destroy function.
746 (set_var_short_name_suffix) Move here from variable.c, renamed
747 from var_set_short_name_suffix, make static, update caller.
749 * sys-file-private.c: New file.
750 (sfm_width_to_bytes) Moved here from variable.c, renamed from
751 width_to_bytes, update callers.
753 * sys-file-private.h: New file. Later it will supplant
754 sfm-private.h; for now it supplements it.
755 (macro MIN_VERY_LONG_STRING) New macro.
756 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
758 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
759 MAX_LONG_STRING was used before.
761 * sys-file-writer.c: Ditto.
763 * value-labels.c: Change the paradigm here to be that a null
764 pointer is OK for a struct val_labs * in most cases; it just
765 represents an empty set of value labels.
766 (val_labs_copy) A copy of a null set is a null set.
767 (val_labs_count) A null set has 0 labels.
768 (val_labs_replace) Change return type to void. Rewrite for
770 (val_labs_find) A null set does not contain the value.
771 (value_to_string) Moved to variable.c, renamed var_get_value_name,
772 transposed argument order, updated all callers.
775 (value_dup) Moved here from variable.c.
776 (compare_values) Ditto.
779 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
780 (macro MAX_LONG_STRING) Removed, because it was only interesting
781 for system files, not for general code.
782 (macro MAX_VERY_LONG_STRING) Ditto.
783 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
784 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
786 * vardict.h: New file, for an interface between variables and
789 * variable.c: A lot of functions were moved around, for better
791 (struct variable) Move definition here, from variable.h.
792 (var_type_adj) Removed--makes i18n hard.
793 (var_type_noun) Ditto.
794 (var_create) New function.
795 (var_clone) New function.
796 (var_destroy) New function.
797 (var_set_name) Assert that variable is not in a dictionary.
798 (compare_var_names) Rename compare_vars_by_name and fix a couple
799 of callers who thought the args were strings.
800 (hash_var_name) Rename hash_var_by_name.
801 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
802 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
803 (var_is_very_long_string) Removed, because it was only interesting
805 (var_set_missing_values) Allow the argument to be the wrong width,
806 as long as we can resize it. Simplify callers who were doing the
808 (var_get_value_labels) New function.
809 (var_has_value_labels) New function.
810 (var_set_value_labels) New function.
811 (alloc_value_labels) New function.
812 (var_add_value_label) New function.
813 (var_replace_value_label) New function.
814 (var_clear_value_labels) New function.
815 (var_lookup_value_label) New function.
816 (var_get_value_name) Moved here from variable.c, renamed from
817 var_get_value_name, transposed argument order, updated all
819 (var_to_string) Moved here, from variable-label.c.
820 (var_set_leave) New function.
821 (var_get_leave) New function.
822 (var_must_leave) New function.
823 (var_set_short_name_suffix) Moved to dictionary.c, renamed
824 set_var_short_name_suffix.
825 (var_get_dict_index) New function.
826 (var_get_case_index) New function.
827 (var_get_obs_vals) New function.
828 (var_set_obs_vals) New function.
829 (var_has_obs_vals) New function.
830 (var_get_vardict) New function.
831 (var_set_vardict) New function.
832 (var_has_vardict) New function.
833 (var_clear_vardict) New function.
834 (value_dup) Moved to value.c.
835 (compare_values) Ditto.
838 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
839 (enum ALPHA) Rename VAR_STRING, update all users.
841 * vector.c: New file.
842 (struct vector) Moved here, from variable.h.
843 (check_widths) New function.
844 (vector_create) New function.
845 (vector_clone) New function.
846 (vector_destroy) New function.
847 (vector_get_name) New function.
848 (vector_get_var) New function.
849 (vector_get_var_cnt) New function.
850 (compare_vector_ptrs_by_name) New function.
852 * vector.h: New file.
854 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
856 * casefilter.c (casefilter_variable_missing): Avoided comparision of
857 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
860 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
862 * value-labels.c (destroy_atoms): New function.
863 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
865 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
867 Thanks to Jason Stover for pointing out this problem.
869 * data-out.c (output_number): Use gsl_finite from GSL, which is
870 portable, instead of isfinite, which is not.
873 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
875 * variable.c variable.h (value_dup): New function.
877 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
879 Start converting struct variable to an opaque type. In this
880 phase, we add a bunch of setter and getter functions and convert
881 most of the PSPP code to use them. The resulting changes are
882 pervasive but mostly trivial, and only the notable changes are
885 * format.c (fmt_equal): New function.
887 * variable.c (var_type_is_valid): New function.
888 (measure_is_valid) Moved here, from format.c.
889 (alignment_is_valid) Moved here, from format.c.
890 (var_get_name) New function.
891 (var_set_name) New function.
892 (width_to_type) New function.
893 (var_get_type) New function.
894 (var_get_width) New function.
895 (var_set_width) New function.
896 (var_is_numeric) New function.
897 (var_is_alpha) New function.
898 (var_is_short_string) New function.
899 (var_is_long_string) New function.
900 (var_is_very_long_string) New function.
901 (var_get_missing_values) New function.
902 (var_set_missing_values) New function.
903 (var_clear_missing_values) New function.
904 (var_has_missing_values) New function.
905 (var_is_value_missing) New function.
906 (var_is_num_missing) New function.
907 (var_is_str_missing) New function.
908 (var_is_value_user_missing) New function.
909 (var_is_num_user_missing) New function.
910 (var_is_str_user_missing) New function.
911 (var_is_value_system_missing) New function.
912 (var_get_print_format) New function.
913 (var_set_print_format) New function.
914 (var_get_write_format) New function.
915 (var_set_write_format) New function.
916 (var_set_both_formats) New function.
917 (var_get_label) New function.
918 (var_set_label) New function.
919 (var_clear_label) New function.
920 (var_has_label) New function.
921 (var_get_measure) New function.
922 (var_set_measure) New function.
923 (var_get_display_width) New function.
924 (var_set_display_width) New function.
925 (var_get_alignment) New function.
926 (var_set_alignment) New function.
927 (var_get_value_cnt) New function.
928 (var_get_leave) New function.
929 (var_get_short_name) New function.
931 * variable.h: (struct variable) Removed "type" and "nv" members;
932 they are now computed from "width" where needed.
934 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
936 * missing-values.c (mv_resize): Don't write beyond end of the
937 allocated buffer when resizing a long string.
939 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
941 Clean up identifier code: don't require identifier enumerations to
942 be in a particular order; make better use of string library;
943 expose less of the internals.
945 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
946 change interface. Updated all callers.
947 (lex_id_match) Change interface to use struct substring, update
949 (lex_id_match_len) Removed. Update callers to use lex_id_match.
950 (global array keywords[]) Make static, change form. Update all
951 users to use lex_id_name instead.
952 (lex_is_keyword) New function.
953 (lex_id_to_token) Change interface to use struct substring, update
955 (lex_id_name) New function.
957 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
958 lex_is_keyword instead.
959 (T_LAST_KEYWORD) Removed.
960 (T_N_KEYWORDS) Removed.
962 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
964 * format.c: (fmt_date_template) Distinguish characters for which a
965 space is output and any date delimiter is allowed on input, from
966 those for which a space is output and only a space is allowed on
967 input. The former is represented by X, the latter by a space.
968 Also, drop distinction between h and H, changing the former to the
971 * data-in.c: Completely rewrite internals to conform to SPSS input
972 formats as closely as possible.
973 (data_in) Changed external interface by replacing the structure
974 that was used as a single argument by a set of arguments. Updated
976 (data_in_finite_line) Removed. Converted all callers to use plain
978 (data_in_get_integer_format) New function.
979 (data_in_set_integer_format) New function.
980 (data_in_get_float_format) New function.
981 (data_in_set_float_format) New function.
983 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
984 (struct data_in) Removed.
986 * data-out.c: (output_date) Drop each component from the input as
987 it is output, to allow us to drop the distinction between h (a
988 count of hours) and H (the hour of day) template characters.
989 Also, handle new X template character.
990 (output_scientific) Follow more rational rule on when to drop
991 fraction introduced between SPSS 13 and 15. Updated test case to
994 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
996 Fix buffer overflow reported by John Darrington.
998 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
999 realize that DIGITS is a count of nibbles, not of bytes.
1001 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1003 * calendar.c (calendar_offset_to_gregorian) Also return the
1004 year-of-day. Change callers to new interface.
1006 * data-out.c: Completely rewrite internals to conform to SPSS
1007 output formats as completely as possible.
1008 (data_out) Change interface to put input parameters before output
1009 parameters, for consistency with the style I now prefer. Update
1011 (data_out_get_integer_format) New public function.
1012 (data_out_set_integer_format) New public function.
1013 (data_out_get_float_format) New public function.
1014 (data_out_set_float_format) New public function.
1016 * data-out.h: New file. Move prototype for data_out here, from
1019 * format.c: (fmt_step_width) Use equality comparison instead of
1020 bitwise and, for clarity.
1021 (fmt_is_string) Ditto.
1022 (fmt_input_to_output) Fix categories that are translated to F
1025 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1027 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1028 casefile-private.h: Added casefilter to assist commands with missing
1031 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1033 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1035 * settings.c: (route_errors_to_terminal) New variable.
1036 (route_errors_to_listing) New variable.
1037 (get_error_routing_to_terminal) New function.
1038 (set_error_routing_to_terminal) New function.
1039 (get_error_routing_to_listing) New function.
1040 (set_error_routing_to_listing) New function.
1042 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1044 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1046 * format.c: Completely rewrite, to achieve better abstraction.
1047 Rewrite all references to formats in other files.
1049 * format.def: Rewrite and reorganize.
1051 * settings.c: Move everything related to custom currency formats
1052 into format.[ch], changing them in form, so as to group related
1053 code and definitions better. Changed all references to use the
1055 (static var decimal) Removed.
1056 (static var grouping) Removed.
1057 (static var cc) Removed.
1058 (get_decimal) Removed.
1059 (set_decimal) Removed.
1060 (get_grouping) Removed.
1061 (set_grouping) Removed.
1065 * settings.h: (macro CC_CNT) Removed.
1066 (macro CC_WIDTH) Removed.
1067 (struct custom_currency) Removed.
1069 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1071 * data-in.c (data_in): Use switch statement instead of table, to
1072 avoid dependence on the order of the FMT_* enums.
1074 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1076 * data-out.c: (num_to_string) Removed, because it was dead code.
1078 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1080 * data-in.c (parse_trailer): Fix error message.
1082 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1084 * format.c (fmt_is_binary): New function.
1086 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1088 * procedure.c procedure.h: Encapsulated the static data into a single
1091 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1093 * casefile.c (casereader_read_xfer): Always initialize the case,
1094 even on an error condition.
1096 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1098 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1099 entire function useless.
1101 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1103 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1104 casereader method casereader_clone.
1106 * procedure.c pransformations.h: Introduced new type casenum_t
1108 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1110 * variable.c: (width_to_bytes) Rephrase code for clarify.
1112 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1114 * format.c: (fmt_type_from_string) New function.
1115 (fmt_to_string) Include decimals in output if the format has
1116 decimals, even if the format type does not. This way, we can
1117 accurately reproduce incorrect formats in user output.
1118 (check_common_specifier) Make the check for a bad format type an
1119 assertion, so we get bug reports if they show up. Fix message.
1120 Check for decimal places with a format type that doesn't allow
1122 (check_input_specifier) Remove check for FMT_X, which has been
1124 (check_output_specifier) Ditto.
1126 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1128 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1129 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1130 (enum fmt_parse_flags) Removed.
1132 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1134 * casefile.c casefile.h: Converted to an abstract base class.
1135 * casefile-private.h fastfile.c fastfile.h: New files.
1136 * automake.mk procedure.c scratch-writer.c storage-stream.c
1138 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1140 * procedure.c (internal_procedure): Create sink_case with only as
1141 many values as the compacted dictionary.
1143 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1145 Remove "debugging" code that caused plenty of false positives and
1148 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1150 * case.c: Remove all references to `this' member.
1152 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1154 Fix link error noted by Jason Stover.
1156 * storage-stream.c: Include <assert.h>.
1158 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1160 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1161 ALL) and additional underlying system file issues.
1163 Thanks to John Darrington for review.
1165 First problem: var_hash points to variables not owned by the
1166 sys-file-reader, which the caller may free or modify. Use an
1167 array of sfm_vars instead, as done earlier (e.g. CVS version
1170 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1171 members and remove all code that references it. Add vars, var_cnt
1172 members. Remove fix_specials member, which was unused.
1173 (struct sfm_var) Remove name member, which was unused.
1174 (sfm_close_reader) Free vars member instead of var_hash.
1175 (compare_var_shortnames) Removed.
1176 (hash_var_shortname) Removed.
1177 (sfm_open_reader) Fill out vars array.
1178 (compare_var_index) Removed.
1179 (sfm_read_case) Use vars instead of var_hash.
1181 Second problem: we're confused about when we actually have very
1182 long strings, causing us to choose incorrectly between slow path
1183 and fast path in sfm_read_case.
1185 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1186 have very long strings, not when we have long variable names,
1187 which is an unrelated feature.
1189 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1191 * variable.h: Move var_set and variable parsing declarations to
1192 new header, src/language/lexer/variable-parser.h. Modified lots
1193 of files to include the new header.
1195 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1197 * value-labels.c (value_to_string): When there's no value label,
1198 format the variable according to its print format, instead of
1199 always effectively using A or F format.
1201 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1203 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1206 * format.c: Removed tortological assertion.
1208 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1210 Reform string library.
1212 * file-name.c (fn_interp_vars): Change interface to take a
1213 substring as input. Updated all users.
1215 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1217 * format.c (measure_is_valid): Really return false when m >=
1220 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1222 Implement random access to casefiles, for use in GUI.
1224 * casefile.c: (struct casereader) Add `random', `file_ofs',
1225 `buffer_ofs' members.
1226 (casefile_get_random_reader) New function.
1227 (read_open_file) Break part into new function
1228 seek_and_fill_buffer().
1229 (fill_buffer) Update buffer_ofs, file_ofs.
1230 (casereader_seek) New function.
1232 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1234 * settings.c: Added call to i18n{done, init}.
1236 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1238 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1241 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1243 * casefile.c: Convert many uses of `int' to `bool'.
1245 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1247 * transformations.c (trns_chain_destroy): Destroy chain's trns
1248 member, to fix memory leak.
1250 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1252 * storage-stream.c (storage_source_decapsulate): Destroy case
1253 source to fix memory leak.
1255 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1257 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1258 case passed as argument instead of initializing the argument as a
1259 case. Fixes memory leak that showed up in
1260 tests/command/aggregate.sh with scratch files.
1262 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1264 * procedure.c (proc_done): Destroy default_dict, to fix memory
1267 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1269 Simplify procedure_with_splits().
1271 * procedure.c (struct split_aux_data): Removed case_count member.
1272 (procedure_with_splits) Don't initialize case_count.
1273 (split_procedure_case_func) Check whether prev_case is null
1274 instead of case_count.
1275 (split_procedure_end_func) Ditto.
1277 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1279 * case.c (case_move): Do nothing if dst and src are the same
1281 (case_try_create) Merge two similar cases.
1282 (case_copy) Unshare only if data must be actually copied.
1284 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1286 * data-in.c data-out.c dictionary.c sys-file-reader.c
1287 sys-file-writer.c variable.c variable.h: Reworked very long string
1288 support for better encapsulation.
1290 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1292 * value-labels.c (val_labs_can_set_width): New function.
1293 (val_labs_set_width) Clear labels if increasing width to long
1295 (val_labs_destroy) Remove unneeded test for null.
1297 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1299 * value-labels.h: Remove unneeded dependency on variable.h.
1301 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1303 Get rid of `char *c' member in union value, for cleanliness.
1305 * value.h: (union value) Remove `c' member.
1307 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1309 Make dictionary compacting functions a little more general.
1311 * sys-file-writer.c (sfm_open_writer): Use
1312 dict_compacting_would_change().
1313 (does_dict_need_translation) Removed.
1315 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1317 Make dictionary compacting functions a little more general.
1319 * dictionary.c (dict_needs_compaction): Rename
1320 dict_compacting_would_shrink(). Update all callers.
1321 (dict_compacting_would_change) New function.
1323 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1325 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1326 inverted return value (!).
1328 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1330 Continue reforming procedure execution.
1332 * procedure.c: Search and replace "vfm" by "proc". Notably:
1333 (static var vfm_source) Rename proc_source. Update all
1335 (static var vfm_sink) Rename proc_sink. Update all references.
1337 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1339 Continue reforming procedure execution. In this phase, remove
1340 PROCESS IF, which was deprecated anyway and can be easily
1341 simulated with TEMPORARY followed by SELECT IF.
1343 * procedure.c: (open_active_file) Don't call
1344 add_process_if_trns().
1345 (discard_variables) Get rid of redundant call to
1346 proc_cancel_all_transformations().
1347 (add_process_if_trns) Removed.
1348 (process_if_trns_proc) Removed.
1349 (process_if_trns_free) Removed.
1351 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1353 Continue reforming procedure execution. In this phase, add
1354 `const' to the case passed to procedure()'s callback.
1356 Updated all users of procedure() as well.
1358 * procedure.c: (struct write_case_data) Add "const" to ccase
1359 parameter for case_func member.
1360 (procedure) Add "const" to ccase parameter for proc_func
1362 (multipass_case_func) Make ccase parameter const.
1363 (internal_procedure) Add "const" to ccase parameter for case_func
1365 (split_procedure_case_func) Make ccase parameter const.
1366 (multipass_split_case_func) Make ccase parameter const.
1368 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1370 Continue reforming procedure execution. In this phase, get rid of
1371 the output code for SPLIT FILE groups in procedure.c, which really
1372 shouldn't be doing any output. Move it into the individual
1373 procedures instead. This also adds some flexibility.
1375 Updated many users of procedure_with_splits() and
1376 multipass_procedure_with_splits() to call
1377 output_split_file_values() and to deal with increased use of
1380 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1381 parameter to begin_func member.
1382 (procedure_with_splits) Add "const struct ccase *" parameter to
1383 begin_func parameter. Make ccase parameter const in proc_func
1385 (split_procedure_case_func) Don't dump split file group. Pass
1387 (dump_splits) Moved to language/dictionary/split-file.c as
1388 output_split_file_values().
1389 (struct multipass_split_aux_data) Add "const struct ccase *"
1390 parameter to split_func member.
1391 (multipass_procedure_with_splits) Add "const struct ccase *"
1392 parameter to split_func parameter.
1393 (multipass_split_case_func) Save new SPLIT FILE case before
1395 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1397 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1399 Continue reforming procedure execution. Change
1400 internal_procedure() so that it calls open_active_file() and
1401 close_active_file(), which isolates most of the actual procedure
1404 * procedure.c: (struct write_case_data) Rename `proc_func' member
1405 to `case_func' and update all references.
1406 (procedure) Rewrite as one-line wrapper around
1407 internal_procedure().
1408 (struct multipass_aux_data) New.
1409 (multipass_callback) Renamed multipass_case_func(). Use struct
1410 multipass_aux_data as auxiliary data.
1411 (multipass_end_func) New function.
1412 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1413 that uses multipass_case_func, multipass_end_func.
1414 (internal_procedure) Add `end_func' argument. Move optimization
1415 of trivial case in here. Move call to open_active_file() and
1416 close_active_file() in here. Now assert that vfm_source is
1418 (procedure_with_splits_callback) Rename
1419 split_procedure_case_func().
1420 (split_procedure_end_func) New function.
1421 (multipass_split_callback) Rename multipass_split_case_func.
1422 (multipass_split_end_func) New function.
1423 (discard_variables) No need to test for nonnull vfm_source.
1425 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1427 Continue reforming procedure execution. Get rid of unused member.
1429 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1431 (write_case) Don't increment cases_analyzed.
1433 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1435 Continue reforming procedure execution. In this phase, move
1436 procedure.c and procedure.h from src to src/data. Update
1437 makefiles and #includes accordingly.
1439 * procedure.c: Moved here from src/.
1441 * procedure.h: Moved here from src/.
1443 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1445 Continue reforming procedure execution. In this phase, get rid of
1446 many global variables, consolidating procedure execution in
1447 procedure.c. Encapsulate transformations in new "struct
1448 trns_chain". Also, change implementation of N OF CASES, FILTER,
1449 and PROCESS IF from special cases to transformations.
1451 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1454 * dictionary.c: (global variable default_dict) Move to
1457 * variable.h: (TRNS_*) Move to transformations.h.
1458 (struct transformation) Move to transformations.c.
1460 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1462 * sys-file-reader.c: Fixed invalid read problems.
1464 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1466 * storage-stream.c: Add missing function comments.
1468 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1470 Continue reforming procedure execution. In this phase, add some
1471 new, needed functionality to storage-stream.
1473 * storage-stream.c: (storage_source_decapsulate) New function.
1475 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1477 * variable.c (width_to_bytes): Declarations must precede
1478 statements for C90 compliance.
1480 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1482 * data-out.c, data-in.c, variable.c, variable.h: New functions
1483 copy_mangle and copy_demangle for reading/writing cases; emulates the
1484 way SPSS deals with strings > 255 bytes.
1486 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1487 subtype 14 needed for strings longer than 255 bytes.
1489 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1490 instead of literal values. Also fixed some constness issues.
1492 * format.h: Constness
1494 * sfm-private.h: Renamed the case_size identifier, since I discovered
1495 that SPSS's respect for this variable is very nominal.
1497 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1499 Change case limit type from int to size_t.
1501 * dictionary.c: (struct dictionary) Change type of case_limit
1503 (dict_get_case_limit) Change return type.
1504 (dict_set_case_limit) Change parameter type.
1506 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1508 * variable.h: (struct variable) Rename `reinit' member as `leave'
1509 and invert sense. Fix up all references.
1511 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1513 Continue reforming procedure execution. In this phase, break
1514 procedure.c into multiple files.
1516 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1518 * case-sink.c: New file.
1520 * case-sink.h: New file.
1522 * case-source.c: New file.
1524 * case-source.h: New file.
1526 * storage-stream.c: New file.
1528 * storage-stream.h: New file.
1530 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1532 * variable.h: (struct variable) Remove `init' member and all
1533 references to it from other files. It was initialized in several
1534 places, but nothing really ever used it for anything worthwhile.
1535 Thanks to Jason Stover for pointing out how confusing this
1538 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1540 Continue reforming error message support. In this phase, get rid
1541 of message "titles" and put the message text in `struct error'.
1542 Now `struct error' encapsulates a message more properly.
1544 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1545 Format message ourselves.
1547 * data-in.c: (vdls_error) Ditto.
1549 * por-file-reader.c: (error) Ditto.
1551 * sys-file-reader.c: (corrupt_msg) Ditto.
1553 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1555 GNU standards require "file name" instead of "filename" in
1556 documentation. It's nice for our code to follow the convention
1559 * casefile.c: (struct casefile) Rename `filename' member to
1560 `file_name'. Updated all references.
1562 * file-name.c: [!unix] (struct file_identity) Rename
1563 normalized_filename member to normalized_file_name. Updated all
1566 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1568 We don't really support anything but Unix-like environments well,
1569 so we might as well de-obfuscate by writing directory and path
1570 separators explicitly.
1572 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1574 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1575 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1577 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1580 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1582 GNU standards require "file name" instead of "filename" in
1583 documentation. It's nice for our code to follow the convention
1586 * filename.c: Rename to file-name.c.
1588 * filename.h: Rename to file-name.h. Update all inclusions.
1589 Update header guards.
1591 * automake.mk: Update file names.
1593 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1595 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1597 (fn_basename) Removed (dead code).
1598 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1599 (fn_special_p) Renamed fn_is_special(), all references updated.
1600 (fn_exists_p) Renamed fn_exists(), all references updated.
1602 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1604 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1605 Also, now it only tilde-expands file names, not paths.
1606 (fn_search_path) Tilde-expand one directory at a time.
1608 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1610 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1611 get rid of non-Unixlike version of the code, which has probably
1613 (fn_prepend_dir) Removed (dead code).
1615 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1616 (macro PATH_SEPARATOR_STRING) New.
1617 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1619 Continue reforming error message support. In this phase, we get
1620 rid of VM() and the other msg() support for "verbosity", replacing
1621 it by a new function verbose_msg().
1623 * filename.c: (fn_search_path) Use verbose_msg() instead of
1626 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1628 * sfm-private.h: Get rid of #defines after #error, which makes no
1631 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1633 Get rid of our own int32 type in favor of the standard int32_t
1636 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1639 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1641 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1643 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1645 Remove ill-considered file routines that are no longer used.
1647 * filename.c: (fn_open_ext) Removed.
1648 (fn_close_ext) Removed.
1650 * filename.h: (struct file_ext) Removed.
1652 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1654 * variable.c (var_is_valid_name): Move declarations before code
1657 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1659 * filename.ch (fn_interp_vars): Fixed small buglet.
1661 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1663 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1664 so as to modify the string inline. Thus makeing it easier to
1665 destroy the results when no longer needed.
1667 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1669 * category.c (cat_stored_values_destroy): Fixed memory leak.
1671 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1673 Add some missing frees. Thanks to John Darrington for reporting
1676 * any-writer.c (any_writer_close): Free writer.
1678 * any-reader.c (any_reader_close): Free reader.
1680 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1682 * por-file-reader.c: (error) Mark as NO_RETURN.
1684 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1686 * settings.c: Changed default value of scompress to true.
1688 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1690 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1692 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1695 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1696 here from pref.h.orig.
1698 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1700 * sys-file-reader.c: Fixed bug reading compressed files.
1702 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1704 * Numerous renames. See src/ChangeLog for details.
1706 * Moved files from src directory