1 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
3 * settings.c: Added call to i18n{done, init}.
5 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
7 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
10 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
12 * casefile.c: Convert many uses of `int' to `bool'.
14 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
16 * transformations.c (trns_chain_destroy): Destroy chain's trns
17 member, to fix memory leak.
19 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
21 * storage-stream.c (storage_source_decapsulate): Destroy case
22 source to fix memory leak.
24 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
26 * scratch-reader.c (scratch_reader_read_case): Copy into existing
27 case passed as argument instead of initializing the argument as a
28 case. Fixes memory leak that showed up in
29 tests/command/aggregate.sh with scratch files.
31 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
33 * procedure.c (proc_done): Destroy default_dict, to fix memory
36 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
38 Simplify procedure_with_splits().
40 * procedure.c (struct split_aux_data): Removed case_count member.
41 (procedure_with_splits) Don't initialize case_count.
42 (split_procedure_case_func) Check whether prev_case is null
43 instead of case_count.
44 (split_procedure_end_func) Ditto.
46 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
48 * case.c (case_move): Do nothing if dst and src are the same
50 (case_try_create) Merge two similar cases.
51 (case_copy) Unshare only if data must be actually copied.
53 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
55 * data-in.c data-out.c dictionary.c sys-file-reader.c
56 sys-file-writer.c variable.c variable.h: Reworked very long string
57 support for better encapsulation.
59 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
61 * value-labels.c (val_labs_can_set_width): New function.
62 (val_labs_set_width) Clear labels if increasing width to long
64 (val_labs_destroy) Remove unneeded test for null.
66 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
68 * value-labels.h: Remove unneeded dependency on variable.h.
70 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
72 Get rid of `char *c' member in union value, for cleanliness.
74 * value.h: (union value) Remove `c' member.
76 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
78 Make dictionary compacting functions a little more general.
80 * sys-file-writer.c (sfm_open_writer): Use
81 dict_compacting_would_change().
82 (does_dict_need_translation) Removed.
84 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
86 Make dictionary compacting functions a little more general.
88 * dictionary.c (dict_needs_compaction): Rename
89 dict_compacting_would_shrink(). Update all callers.
90 (dict_compacting_would_change) New function.
92 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
94 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
95 inverted return value (!).
97 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
99 Continue reforming procedure execution.
101 * procedure.c: Search and replace "vfm" by "proc". Notably:
102 (static var vfm_source) Rename proc_source. Update all
104 (static var vfm_sink) Rename proc_sink. Update all references.
106 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
108 Continue reforming procedure execution. In this phase, remove
109 PROCESS IF, which was deprecated anyway and can be easily
110 simulated with TEMPORARY followed by SELECT IF.
112 * procedure.c: (open_active_file) Don't call
113 add_process_if_trns().
114 (discard_variables) Get rid of redundant call to
115 proc_cancel_all_transformations().
116 (add_process_if_trns) Removed.
117 (process_if_trns_proc) Removed.
118 (process_if_trns_free) Removed.
120 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
122 Continue reforming procedure execution. In this phase, add
123 `const' to the case passed to procedure()'s callback.
125 Updated all users of procedure() as well.
127 * procedure.c: (struct write_case_data) Add "const" to ccase
128 parameter for case_func member.
129 (procedure) Add "const" to ccase parameter for proc_func
131 (multipass_case_func) Make ccase parameter const.
132 (internal_procedure) Add "const" to ccase parameter for case_func
134 (split_procedure_case_func) Make ccase parameter const.
135 (multipass_split_case_func) Make ccase parameter const.
137 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
139 Continue reforming procedure execution. In this phase, get rid of
140 the output code for SPLIT FILE groups in procedure.c, which really
141 shouldn't be doing any output. Move it into the individual
142 procedures instead. This also adds some flexibility.
144 Updated many users of procedure_with_splits() and
145 multipass_procedure_with_splits() to call
146 output_split_file_values() and to deal with increased use of
149 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
150 parameter to begin_func member.
151 (procedure_with_splits) Add "const struct ccase *" parameter to
152 begin_func parameter. Make ccase parameter const in proc_func
154 (split_procedure_case_func) Don't dump split file group. Pass
156 (dump_splits) Moved to language/dictionary/split-file.c as
157 output_split_file_values().
158 (struct multipass_split_aux_data) Add "const struct ccase *"
159 parameter to split_func member.
160 (multipass_procedure_with_splits) Add "const struct ccase *"
161 parameter to split_func parameter.
162 (multipass_split_case_func) Save new SPLIT FILE case before
164 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
166 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
168 Continue reforming procedure execution. Change
169 internal_procedure() so that it calls open_active_file() and
170 close_active_file(), which isolates most of the actual procedure
173 * procedure.c: (struct write_case_data) Rename `proc_func' member
174 to `case_func' and update all references.
175 (procedure) Rewrite as one-line wrapper around
176 internal_procedure().
177 (struct multipass_aux_data) New.
178 (multipass_callback) Renamed multipass_case_func(). Use struct
179 multipass_aux_data as auxiliary data.
180 (multipass_end_func) New function.
181 (multipass_procedure) Rewrite as wrapper for internal_procedure()
182 that uses multipass_case_func, multipass_end_func.
183 (internal_procedure) Add `end_func' argument. Move optimization
184 of trivial case in here. Move call to open_active_file() and
185 close_active_file() in here. Now assert that vfm_source is
187 (procedure_with_splits_callback) Rename
188 split_procedure_case_func().
189 (split_procedure_end_func) New function.
190 (multipass_split_callback) Rename multipass_split_case_func.
191 (multipass_split_end_func) New function.
192 (discard_variables) No need to test for nonnull vfm_source.
194 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
196 Continue reforming procedure execution. Get rid of unused member.
198 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
200 (write_case) Don't increment cases_analyzed.
202 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
204 Continue reforming procedure execution. In this phase, move
205 procedure.c and procedure.h from src to src/data. Update
206 makefiles and #includes accordingly.
208 * procedure.c: Moved here from src/.
210 * procedure.h: Moved here from src/.
212 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
214 Continue reforming procedure execution. In this phase, get rid of
215 many global variables, consolidating procedure execution in
216 procedure.c. Encapsulate transformations in new "struct
217 trns_chain". Also, change implementation of N OF CASES, FILTER,
218 and PROCESS IF from special cases to transformations.
220 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
223 * dictionary.c: (global variable default_dict) Move to
226 * variable.h: (TRNS_*) Move to transformations.h.
227 (struct transformation) Move to transformations.c.
229 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
231 * sys-file-reader.c: Fixed invalid read problems.
233 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
235 * storage-stream.c: Add missing function comments.
237 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
239 Continue reforming procedure execution. In this phase, add some
240 new, needed functionality to storage-stream.
242 * storage-stream.c: (storage_source_decapsulate) New function.
244 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
246 * variable.c (width_to_bytes): Declarations must precede
247 statements for C90 compliance.
249 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
251 * data-out.c, data-in.c, variable.c, variable.h: New functions
252 copy_mangle and copy_demangle for reading/writing cases; emulates the
253 way SPSS deals with strings > 255 bytes.
255 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
256 subtype 14 needed for strings longer than 255 bytes.
258 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
259 instead of literal values. Also fixed some constness issues.
261 * format.h: Constness
263 * sfm-private.h: Renamed the case_size identifier, since I discovered
264 that SPSS's respect for this variable is very nominal.
266 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
268 Change case limit type from int to size_t.
270 * dictionary.c: (struct dictionary) Change type of case_limit
272 (dict_get_case_limit) Change return type.
273 (dict_set_case_limit) Change parameter type.
275 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
277 * variable.h: (struct variable) Rename `reinit' member as `leave'
278 and invert sense. Fix up all references.
280 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
282 Continue reforming procedure execution. In this phase, break
283 procedure.c into multiple files.
285 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
287 * case-sink.c: New file.
289 * case-sink.h: New file.
291 * case-source.c: New file.
293 * case-source.h: New file.
295 * storage-stream.c: New file.
297 * storage-stream.h: New file.
299 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
301 * variable.h: (struct variable) Remove `init' member and all
302 references to it from other files. It was initialized in several
303 places, but nothing really ever used it for anything worthwhile.
304 Thanks to Jason Stover for pointing out how confusing this
307 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
309 Continue reforming error message support. In this phase, get rid
310 of message "titles" and put the message text in `struct error'.
311 Now `struct error' encapsulates a message more properly.
313 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
314 Format message ourselves.
316 * data-in.c: (vdls_error) Ditto.
318 * por-file-reader.c: (error) Ditto.
320 * sys-file-reader.c: (corrupt_msg) Ditto.
322 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
324 GNU standards require "file name" instead of "filename" in
325 documentation. It's nice for our code to follow the convention
328 * casefile.c: (struct casefile) Rename `filename' member to
329 `file_name'. Updated all references.
331 * file-name.c: [!unix] (struct file_identity) Rename
332 normalized_filename member to normalized_file_name. Updated all
335 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
337 We don't really support anything but Unix-like environments well,
338 so we might as well de-obfuscate by writing directory and path
339 separators explicitly.
341 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
343 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
344 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
346 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
349 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
351 GNU standards require "file name" instead of "filename" in
352 documentation. It's nice for our code to follow the convention
355 * filename.c: Rename to file-name.c.
357 * filename.h: Rename to file-name.h. Update all inclusions.
358 Update header guards.
360 * automake.mk: Update file names.
362 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
364 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
366 (fn_basename) Removed (dead code).
367 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
368 (fn_special_p) Renamed fn_is_special(), all references updated.
369 (fn_exists_p) Renamed fn_exists(), all references updated.
371 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
373 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
374 Also, now it only tilde-expands file names, not paths.
375 (fn_search_path) Tilde-expand one directory at a time.
377 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
379 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
380 get rid of non-Unixlike version of the code, which has probably
382 (fn_prepend_dir) Removed (dead code).
384 * filename.h: (macro DIR_SEPARATOR_STRING) New.
385 (macro PATH_SEPARATOR_STRING) New.
386 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
388 Continue reforming error message support. In this phase, we get
389 rid of VM() and the other msg() support for "verbosity", replacing
390 it by a new function verbose_msg().
392 * filename.c: (fn_search_path) Use verbose_msg() instead of
395 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
397 * sfm-private.h: Get rid of #defines after #error, which makes no
400 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
402 Get rid of our own int32 type in favor of the standard int32_t
405 * sfm-private.h: (int32 macro) Don't define this anymore. Do
408 * sys-file-reader.c: Use int32_t instead of int32 throughout.
410 * sys-file-writer.c: Use int32_t instead of int32 throughout.
412 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
414 Remove ill-considered file routines that are no longer used.
416 * filename.c: (fn_open_ext) Removed.
417 (fn_close_ext) Removed.
419 * filename.h: (struct file_ext) Removed.
421 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
423 * variable.c (var_is_valid_name): Move declarations before code
426 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
428 * filename.ch (fn_interp_vars): Fixed small buglet.
430 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
432 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
433 so as to modify the string inline. Thus makeing it easier to
434 destroy the results when no longer needed.
436 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
438 * category.c (cat_stored_values_destroy): Fixed memory leak.
440 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
442 Add some missing frees. Thanks to John Darrington for reporting
445 * any-writer.c (any_writer_close): Free writer.
447 * any-reader.c (any_reader_close): Free reader.
449 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
451 * por-file-reader.c: (error) Mark as NO_RETURN.
453 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
455 * settings.c: Changed default value of scompress to true.
457 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
459 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
461 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
464 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
465 here from pref.h.orig.
467 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
469 * sys-file-reader.c: Fixed bug reading compressed files.
471 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
473 * Numerous renames. See src/ChangeLog for details.
475 * Moved files from src directory