1 2007-04-16 John Darrington <john@darrington.wattle.id.au>
3 * sys-file-reader.c: Some versions of Other Software seem to
4 produce system files with string variables' measure set to
5 zero. We'll assume these are supposed to be nominal variables.
7 2007-03-30 Ben Pfaff <blp@gnu.org>
9 * procedure.c: Adapt to new deque data structure.
11 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
12 Ben Pfaff <blp@gnu.org>
14 * file-name.c: Mingw compatibility fixes.
15 (fn_search_path): Use ISSLASH instead of comparing against '/'
17 (fn_dir_name): Use dir_name from gnulib.
18 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
19 (fn_get_identity): Use GetFullPathName instead of canonicalize
20 from gnulib, because the latter does not fully support
21 Windows-style path names. Use this implementation based on the
22 detected presence of Windows instead of the absence of Unix, since
23 the new implementation is Windows-specific.
24 (fn_compare_file_identities): In Windows implementation, compare
25 names case-insensitively.
27 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
29 * make-file.c: Don't include mkstemp.h, because gnulib now causes
30 <stdlib.h> to have the same effect.
32 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
34 * por-file-reader.c: Add missing _() around messages.
36 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
38 * make-file.c: Include "mkstemp.h", without which linking on
41 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
43 Reduce platform dependence.
45 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
46 Everywhere we using this, we really should have just depended on
47 the shell to expand tildes.
48 (fn_search_path): Simplify, given that we don't do tilde expansion
50 (fn_normalize): Removed. Caller changed to use the canonicalize
52 (fn_get_cwd): Removed. Only user was fn_normalize.
53 (fn_is_absolute): Really only test for absolute names.
54 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
56 (fn_readlink): Removed, as it was only used fn_normalize.
57 (fn_exists): Assume the stat function is available; gnulib does.
58 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
60 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
62 * dictionary.c (dict_create_vector_assert): New function.
64 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
66 * file-name.c (fn_normalize): Correct name of function
67 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
68 for pointing this out.
70 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
72 We are using a single member in struct file_handle, the "name"
73 field, for more than one purpose. When it begins with '"', it's a
74 file name; otherwise, it's a token that can be used to identify
75 it. When that assertion fires, it's because we searched for the
76 name case-sensitively as a file name (so that there was no match),
77 and then we try to insert it case-insensitively as a token, which
78 fails because duplicates aren't allowed.
80 Solution: break the two purposes into two separate fields. This
81 fixes the problem and likely makes the code easier to read too.
83 Fixes bug #18922. Thanks to John Darrington for bug report and
86 * file-handle-def.c (struct file_handle): New `id' member.
87 (fh_from_name): Rename fh_from_id. Update all callers.
88 (create_handle): New `id' parameter. Update all callers.
89 (fh_create_file): Ditto.
90 (fh_get_id): New function.
92 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
94 * case.c (case_is_null): Change return type to bool.
96 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
100 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
101 reference counting to share data. This makes it easy for
102 valgrind, etc. to find accesses to cases that have been destroyed
103 but have been kept around by another user's ref-count. This often
104 happens when the data set is small enough to find in memory; if a
105 bigger data set that would overflow to disk were used, then data
106 corruption would occur.
108 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
112 * case.c (case_unshare): Make it check internally whether the
113 ref_cnt is greater than 1, so that the callers don't have to.
114 Update callers not to check.
116 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
118 Before, I was thinking that I might want to get rid of reference
119 counting at some point. Now, I'm pretty sure that it's here to
120 stay. Thus, because we have to store the value_cnt anyway for
121 reference-counted cases, we might as well expose it to users.
123 * case.c (case_get_value_cnt): New function.
124 (case_resize): Drop OLD_CNT argument. Update all callers. Only
125 resize case if its size actually changed.
127 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
128 instead of peeking inside struct case directly.
129 (casefile_append): Ditto.
131 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
133 Get rid of the inlines for the case functions, which made the
134 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
135 the inlines didn't speed up "make check" at all, which is not a
136 perfect benchmark but seems indicative.)
138 * case.c: Remove #ifdef DEBUGGING...#endif around many function
139 definitions. Remove some assertions on nonnull pointers that were
140 redundant with a pointer dereference soon after in the function.
142 (struct case_data): Move definition here from case.h.
146 (case_data_wr): Ditto.
148 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
150 * automake.mk: Add casedeque.h to sources.
152 * casedeque.h: New file.
154 * procedure.c: (struct dataset) Change lag_count, lag_head,
155 lag_queue member into single struct casedeque member. Update all
156 users to use the casedeque instead.
159 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
161 * procedure.c: Simplify lagged cases interface. Updated all
162 clients--well, the only client--to use the simplified interface.
163 (dataset_n_lag) Removed.
164 (dataset_set_n_lag) Removed.
165 (dataset_need_lag) New function.
167 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
169 * dictionary.c procedure.c: More changes to ensure that callbacks occur
170 whenever appropriate, but only when the dataset/dictionary is in a
173 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
175 * dictionary.c dictionary.h : Added callbacks for change of filter and
176 split variables. Refactored some code to ensure that callbacks get
177 invoked when appropriate.
179 * procedure.c (proc_cancel_temporary_transformations): Make sure that
180 replace_dict callback occurs when permanent_dict replaces the current
183 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
185 * dictionary.c dictionary.h : Added callback for when the weight
186 variable of a dictionary changes.
188 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
190 * dictionary.c dictionary.h : Added replace_source and replace_dict
191 callbacks, and functions to deal with them.
193 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
195 Simplify missing value handling.
197 * missing-values.h (enum mv_class): New type.
198 (enum mv_type): Moved definition into missing-values.c and renamed
199 each MV_* to MVT_*, to distinguish them from the exposed mv_class
200 enums. Updated all uses.
201 (struct missing_values): Changed type of `type' from `enum
202 mv_type' to `int' because the definition is no longer exposed.
204 * missing-values.c (mv_is_value_missing): Add new enum mv_class
205 parameter. Update all callers.
206 (mv_is_num_missing): Ditto.
207 (mv_is_str_missing): Ditto.
208 (mv_is_value_user_missing): Removed. Changed callers to use
210 (mv_is_num_user_missing): Removed. Changed callers to use
212 (mv_is_str_user_missing): Removed. Changed callers to use
214 (mv_is_value_system_missing): Removed. Changed callers to use
216 (mv_set_type): Removed. Changed callers to use mv_clear.
217 (mv_clear): New function.
219 * variable.c (var_is_value_missing): Add new enum mv_class
220 parameter. Update all callers.
221 (var_is_num_missing): Ditto.
222 (var_is_str_missing): Ditto.
223 (var_is_value_user_missing): Removed. Changed callers to use
224 var_is_value_missing.
225 (var_is_num_user_missing): Removed. Changed callers to use
227 (var_is_str_user_missing): Removed. Changed callers to use
229 (var_is_value_system_missing): Removed. Changed callers to use
230 var_is_value_missing.
232 * casefilter.c (struct casefilter): Use enum mv_class in place of
234 (casefilter_variable_missing): Adapt to new member.
235 (casefilter_create): Change signature to take enum mv_class,
238 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
240 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
242 * case-sink.c case-sink.h procedure.c procedure.h
243 storage-stream.c: Now uses the factory.
245 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
247 Make it possible to pull cases from the active file with a
248 function call, instead of requiring indirection through a callback
251 * case-source.h (struct case_source_class): Change ->read function
252 to return a single case, instead of calling a callback function
253 for each case. Change ->destroy function to return an error
256 * case-source.c (free_case_source): Pass along the value returned
257 by the case_source ->destroy function.
259 * procedure.c (struct write_case_data): Removed.
260 (struct dataset): Added some members to track procedure state.
261 (procedure): Optimize the trivial case at this level.
262 (internal_procedure): Re-implement in terms of proc_open,
263 proc_read, proc_close.
264 (proc_open) New function.
265 (proc_read) New function.
266 (proc_close) New function.
267 (write_case) Moved into proc_read.
268 (close_active_file) Moved closing of data source into proc_close.
270 * storage-source.c: Rewrote to conform with modified
271 case_source_class interface.
273 * transformations.c (trns_chain_execute): Added argument to allow
274 starting execution from an arbitrary transformation. Updated
277 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
279 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
281 * sys-file-reader.c (read_display_parameters): Don't assume that
282 MEASURE_* and ALIGN_* have the same values found in system files.
284 * sys-file-writer.c (write_variable_display_parameters): Ditto.
286 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
287 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
288 the value of n_MEASURES, which was off by 1 (at least from my
291 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
293 * dictionary.c dictionary.h vardict.h variable.c: Added optional
294 callbacks which are invoked when the dictionary or its
295 variables are changed.
297 * missing-values.c missing-values.h value-labels.c: Tidied up
298 consistency checks, and made some of them return false
299 instead of assert-failing.
301 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
303 * calendar.c (calendar_days_in_month): New function.
305 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
307 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
308 the value label's width.
310 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
312 * sfm-private.h: Move contents into sys-file-writer.c, which is
313 the only remaining user. Removed Borland C++-specific directives.
315 * sys-file-reader.c: Clean up and rewrite entire file. The
316 rewritten version is simpler and better abstracted, and should be
317 easier to maintain and extend. It avoids using structures to read
318 file data, which is prone to padding variations among compilers.
319 It should also handle non-IEEE 754 system files, although I
320 haven't been able to find any. It has been tested against many
321 .sav files obtained from the Web and found to produce the same
322 results as the earlier version of the code, or in some cases
323 improved results. It is more tolerant of format variations found
326 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
327 member, putting an enum integer_format in its place. New member
328 `float_format'. Changed `compressed' member to type bool.
330 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
332 * dictionary.c (dict_delete_consecutive_vars): New function.
334 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
336 * file-name.c (fn_search_path): Remove prefix arg that was unused
337 by any caller. Updated all callers.
339 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
341 * format.c (fmt_dollar_template): Use user's decimal point
342 character. Add assertion.
344 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
346 * format.c (fmt_dollar_template): New function, based on
347 dollar_format_template from var-type-dialog.c.
349 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
351 * data-out.c (output_scientific): Fix bad assumption that "buf" is
354 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
356 Finish converting struct variable to an opaque type. In this
357 phase, we add remaining setter and getter functions, convert the
358 remaining PSPP code to use them, and do a bunch of cleanup. The
359 resulting changes are pervasive but mostly trivial, and only the
360 notable changes are logged.
362 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
365 * case.c (case_data): Renamed case_data_idx.
366 (case_num): Renamed case_num_idx.
367 (case_str): Renamed case_str_idx.
368 (case_data_rw): Renamed case_data_rw_idx.
370 * case.h (case_data): New function with old name and an interface
371 that takes a variable instead of an index, which is easier to
372 use. Updated all callers to use the new interface, or to use the
373 new *_idx function (see above).
376 (case_data_rw): Ditto.
378 * category.c (cat_stored_values_destroy): Changed interface to
379 take a struct cat_vals * instead of a struct variable *.
381 * dictionary.c (dict_clone): Use new vector_clone function.
382 (dict_clear) Use new var_destroy function.
383 (add_var) New function.
384 (dict_create_var) Rewrite in terms of dict_create_var_assert.
385 (dict_create_var_assert) Rewrite in terms of add_var.
386 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
387 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
388 (dict_lookup_var) Use new var_create, var_destroy functions.
389 (dict_contains_var) Rewrite in terms of new vardict functionality.
390 (set_var_dict_index) New function.
391 (set_var_case_index) New function.
392 (reindex_vars) New function.
393 (dict_delete_var) Rewrite in terms of new vardict functionality.
394 (dict_reorder_var) Ditto.
395 (dict_reorder_vars) Ditto.
396 (rename_var) New function.
397 (dict_rename_var) Use rename_var.
398 (dict_rename_vars) Use pool to simplify code. Use rename_var.
399 (dict_get_compacted_idx_to_fv) Rename
400 dict_get_compacted_dict_index_to_case_index, update callers.
401 (dict_create_vector) Use new vector_create function.
402 (dict_clear_vectors) Use new vector_destroy function.
403 (set_var_short_name_suffix) Move here from variable.c, renamed
404 from var_set_short_name_suffix, make static, update caller.
406 * sys-file-private.c: New file.
407 (sfm_width_to_bytes) Moved here from variable.c, renamed from
408 width_to_bytes, update callers.
410 * sys-file-private.h: New file. Later it will supplant
411 sfm-private.h; for now it supplements it.
412 (macro MIN_VERY_LONG_STRING) New macro.
413 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
415 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
416 MAX_LONG_STRING was used before.
418 * sys-file-writer.c: Ditto.
420 * value-labels.c: Change the paradigm here to be that a null
421 pointer is OK for a struct val_labs * in most cases; it just
422 represents an empty set of value labels.
423 (val_labs_copy) A copy of a null set is a null set.
424 (val_labs_count) A null set has 0 labels.
425 (val_labs_replace) Change return type to void. Rewrite for
427 (val_labs_find) A null set does not contain the value.
428 (value_to_string) Moved to variable.c, renamed var_get_value_name,
429 transposed argument order, updated all callers.
432 (value_dup) Moved here from variable.c.
433 (compare_values) Ditto.
436 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
437 (macro MAX_LONG_STRING) Removed, because it was only interesting
438 for system files, not for general code.
439 (macro MAX_VERY_LONG_STRING) Ditto.
440 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
441 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
443 * vardict.h: New file, for an interface between variables and
446 * variable.c: A lot of functions were moved around, for better
448 (struct variable) Move definition here, from variable.h.
449 (var_type_adj) Removed--makes i18n hard.
450 (var_type_noun) Ditto.
451 (var_create) New function.
452 (var_clone) New function.
453 (var_destroy) New function.
454 (var_set_name) Assert that variable is not in a dictionary.
455 (compare_var_names) Rename compare_vars_by_name and fix a couple
456 of callers who thought the args were strings.
457 (hash_var_name) Rename hash_var_by_name.
458 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
459 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
460 (var_is_very_long_string) Removed, because it was only interesting
462 (var_set_missing_values) Allow the argument to be the wrong width,
463 as long as we can resize it. Simplify callers who were doing the
465 (var_get_value_labels) New function.
466 (var_has_value_labels) New function.
467 (var_set_value_labels) New function.
468 (alloc_value_labels) New function.
469 (var_add_value_label) New function.
470 (var_replace_value_label) New function.
471 (var_clear_value_labels) New function.
472 (var_lookup_value_label) New function.
473 (var_get_value_name) Moved here from variable.c, renamed from
474 var_get_value_name, transposed argument order, updated all
476 (var_to_string) Moved here, from variable-label.c.
477 (var_set_leave) New function.
478 (var_get_leave) New function.
479 (var_must_leave) New function.
480 (var_set_short_name_suffix) Moved to dictionary.c, renamed
481 set_var_short_name_suffix.
482 (var_get_dict_index) New function.
483 (var_get_case_index) New function.
484 (var_get_obs_vals) New function.
485 (var_set_obs_vals) New function.
486 (var_has_obs_vals) New function.
487 (var_get_vardict) New function.
488 (var_set_vardict) New function.
489 (var_has_vardict) New function.
490 (var_clear_vardict) New function.
491 (value_dup) Moved to value.c.
492 (compare_values) Ditto.
495 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
496 (enum ALPHA) Rename VAR_STRING, update all users.
498 * vector.c: New file.
499 (struct vector) Moved here, from variable.h.
500 (check_widths) New function.
501 (vector_create) New function.
502 (vector_clone) New function.
503 (vector_destroy) New function.
504 (vector_get_name) New function.
505 (vector_get_var) New function.
506 (vector_get_var_cnt) New function.
507 (compare_vector_ptrs_by_name) New function.
509 * vector.h: New file.
511 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
513 * casefilter.c (casefilter_variable_missing): Avoided comparision of
514 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
517 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
519 * value-labels.c (destroy_atoms): New function.
520 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
522 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
524 Thanks to Jason Stover for pointing out this problem.
526 * data-out.c (output_number): Use gsl_finite from GSL, which is
527 portable, instead of isfinite, which is not.
530 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
532 * variable.c variable.h (value_dup): New function.
534 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
536 Start converting struct variable to an opaque type. In this
537 phase, we add a bunch of setter and getter functions and convert
538 most of the PSPP code to use them. The resulting changes are
539 pervasive but mostly trivial, and only the notable changes are
542 * format.c (fmt_equal): New function.
544 * variable.c (var_type_is_valid): New function.
545 (measure_is_valid) Moved here, from format.c.
546 (alignment_is_valid) Moved here, from format.c.
547 (var_get_name) New function.
548 (var_set_name) New function.
549 (width_to_type) New function.
550 (var_get_type) New function.
551 (var_get_width) New function.
552 (var_set_width) New function.
553 (var_is_numeric) New function.
554 (var_is_alpha) New function.
555 (var_is_short_string) New function.
556 (var_is_long_string) New function.
557 (var_is_very_long_string) New function.
558 (var_get_missing_values) New function.
559 (var_set_missing_values) New function.
560 (var_clear_missing_values) New function.
561 (var_has_missing_values) New function.
562 (var_is_value_missing) New function.
563 (var_is_num_missing) New function.
564 (var_is_str_missing) New function.
565 (var_is_value_user_missing) New function.
566 (var_is_num_user_missing) New function.
567 (var_is_str_user_missing) New function.
568 (var_is_value_system_missing) New function.
569 (var_get_print_format) New function.
570 (var_set_print_format) New function.
571 (var_get_write_format) New function.
572 (var_set_write_format) New function.
573 (var_set_both_formats) New function.
574 (var_get_label) New function.
575 (var_set_label) New function.
576 (var_clear_label) New function.
577 (var_has_label) New function.
578 (var_get_measure) New function.
579 (var_set_measure) New function.
580 (var_get_display_width) New function.
581 (var_set_display_width) New function.
582 (var_get_alignment) New function.
583 (var_set_alignment) New function.
584 (var_get_value_cnt) New function.
585 (var_get_leave) New function.
586 (var_get_short_name) New function.
588 * variable.h: (struct variable) Removed "type" and "nv" members;
589 they are now computed from "width" where needed.
591 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
593 * missing-values.c (mv_resize): Don't write beyond end of the
594 allocated buffer when resizing a long string.
596 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
598 Clean up identifier code: don't require identifier enumerations to
599 be in a particular order; make better use of string library;
600 expose less of the internals.
602 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
603 change interface. Updated all callers.
604 (lex_id_match) Change interface to use struct substring, update
606 (lex_id_match_len) Removed. Update callers to use lex_id_match.
607 (global array keywords[]) Make static, change form. Update all
608 users to use lex_id_name instead.
609 (lex_is_keyword) New function.
610 (lex_id_to_token) Change interface to use struct substring, update
612 (lex_id_name) New function.
614 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
615 lex_is_keyword instead.
616 (T_LAST_KEYWORD) Removed.
617 (T_N_KEYWORDS) Removed.
619 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
621 * format.c: (fmt_date_template) Distinguish characters for which a
622 space is output and any date delimiter is allowed on input, from
623 those for which a space is output and only a space is allowed on
624 input. The former is represented by X, the latter by a space.
625 Also, drop distinction between h and H, changing the former to the
628 * data-in.c: Completely rewrite internals to conform to SPSS input
629 formats as closely as possible.
630 (data_in) Changed external interface by replacing the structure
631 that was used as a single argument by a set of arguments. Updated
633 (data_in_finite_line) Removed. Converted all callers to use plain
635 (data_in_get_integer_format) New function.
636 (data_in_set_integer_format) New function.
637 (data_in_get_float_format) New function.
638 (data_in_set_float_format) New function.
640 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
641 (struct data_in) Removed.
643 * data-out.c: (output_date) Drop each component from the input as
644 it is output, to allow us to drop the distinction between h (a
645 count of hours) and H (the hour of day) template characters.
646 Also, handle new X template character.
647 (output_scientific) Follow more rational rule on when to drop
648 fraction introduced between SPSS 13 and 15. Updated test case to
651 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
653 Fix buffer overflow reported by John Darrington.
655 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
656 realize that DIGITS is a count of nibbles, not of bytes.
658 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
660 * calendar.c (calendar_offset_to_gregorian) Also return the
661 year-of-day. Change callers to new interface.
663 * data-out.c: Completely rewrite internals to conform to SPSS
664 output formats as completely as possible.
665 (data_out) Change interface to put input parameters before output
666 parameters, for consistency with the style I now prefer. Update
668 (data_out_get_integer_format) New public function.
669 (data_out_set_integer_format) New public function.
670 (data_out_get_float_format) New public function.
671 (data_out_set_float_format) New public function.
673 * data-out.h: New file. Move prototype for data_out here, from
676 * format.c: (fmt_step_width) Use equality comparison instead of
677 bitwise and, for clarity.
678 (fmt_is_string) Ditto.
679 (fmt_input_to_output) Fix categories that are translated to F
682 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
684 * casefilter.c casefilter.h (new files), casefile.c casefile.h
685 casefile-private.h: Added casefilter to assist commands with missing
688 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
690 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
692 * settings.c: (route_errors_to_terminal) New variable.
693 (route_errors_to_listing) New variable.
694 (get_error_routing_to_terminal) New function.
695 (set_error_routing_to_terminal) New function.
696 (get_error_routing_to_listing) New function.
697 (set_error_routing_to_listing) New function.
699 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
701 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
703 * format.c: Completely rewrite, to achieve better abstraction.
704 Rewrite all references to formats in other files.
706 * format.def: Rewrite and reorganize.
708 * settings.c: Move everything related to custom currency formats
709 into format.[ch], changing them in form, so as to group related
710 code and definitions better. Changed all references to use the
712 (static var decimal) Removed.
713 (static var grouping) Removed.
714 (static var cc) Removed.
715 (get_decimal) Removed.
716 (set_decimal) Removed.
717 (get_grouping) Removed.
718 (set_grouping) Removed.
722 * settings.h: (macro CC_CNT) Removed.
723 (macro CC_WIDTH) Removed.
724 (struct custom_currency) Removed.
726 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
728 * data-in.c (data_in): Use switch statement instead of table, to
729 avoid dependence on the order of the FMT_* enums.
731 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
733 * data-out.c: (num_to_string) Removed, because it was dead code.
735 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
737 * data-in.c (parse_trailer): Fix error message.
739 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
741 * format.c (fmt_is_binary): New function.
743 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
745 * procedure.c procedure.h: Encapsulated the static data into a single
748 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
750 * casefile.c (casereader_read_xfer): Always initialize the case,
751 even on an error condition.
753 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
755 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
756 entire function useless.
758 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
760 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
761 casereader method casereader_clone.
763 * procedure.c pransformations.h: Introduced new type casenum_t
765 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
767 * variable.c: (width_to_bytes) Rephrase code for clarify.
769 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
771 * format.c: (fmt_type_from_string) New function.
772 (fmt_to_string) Include decimals in output if the format has
773 decimals, even if the format type does not. This way, we can
774 accurately reproduce incorrect formats in user output.
775 (check_common_specifier) Make the check for a bad format type an
776 assertion, so we get bug reports if they show up. Fix message.
777 Check for decimal places with a format type that doesn't allow
779 (check_input_specifier) Remove check for FMT_X, which has been
781 (check_output_specifier) Ditto.
783 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
785 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
786 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
787 (enum fmt_parse_flags) Removed.
789 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
791 * casefile.c casefile.h: Converted to an abstract base class.
792 * casefile-private.h fastfile.c fastfile.h: New files.
793 * automake.mk procedure.c scratch-writer.c storage-stream.c
795 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
797 * procedure.c (internal_procedure): Create sink_case with only as
798 many values as the compacted dictionary.
800 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
802 Remove "debugging" code that caused plenty of false positives and
805 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
807 * case.c: Remove all references to `this' member.
809 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
811 Fix link error noted by Jason Stover.
813 * storage-stream.c: Include <assert.h>.
815 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
817 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
818 ALL) and additional underlying system file issues.
820 Thanks to John Darrington for review.
822 First problem: var_hash points to variables not owned by the
823 sys-file-reader, which the caller may free or modify. Use an
824 array of sfm_vars instead, as done earlier (e.g. CVS version
827 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
828 members and remove all code that references it. Add vars, var_cnt
829 members. Remove fix_specials member, which was unused.
830 (struct sfm_var) Remove name member, which was unused.
831 (sfm_close_reader) Free vars member instead of var_hash.
832 (compare_var_shortnames) Removed.
833 (hash_var_shortname) Removed.
834 (sfm_open_reader) Fill out vars array.
835 (compare_var_index) Removed.
836 (sfm_read_case) Use vars instead of var_hash.
838 Second problem: we're confused about when we actually have very
839 long strings, causing us to choose incorrectly between slow path
840 and fast path in sfm_read_case.
842 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
843 have very long strings, not when we have long variable names,
844 which is an unrelated feature.
846 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
848 * variable.h: Move var_set and variable parsing declarations to
849 new header, src/language/lexer/variable-parser.h. Modified lots
850 of files to include the new header.
852 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
854 * value-labels.c (value_to_string): When there's no value label,
855 format the variable according to its print format, instead of
856 always effectively using A or F format.
858 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
860 * casefile.c (casefile_get_random_reader): Nasty hack to get around
863 * format.c: Removed tortological assertion.
865 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
867 Reform string library.
869 * file-name.c (fn_interp_vars): Change interface to take a
870 substring as input. Updated all users.
872 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
874 * format.c (measure_is_valid): Really return false when m >=
877 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
879 Implement random access to casefiles, for use in GUI.
881 * casefile.c: (struct casereader) Add `random', `file_ofs',
882 `buffer_ofs' members.
883 (casefile_get_random_reader) New function.
884 (read_open_file) Break part into new function
885 seek_and_fill_buffer().
886 (fill_buffer) Update buffer_ofs, file_ofs.
887 (casereader_seek) New function.
889 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
891 * settings.c: Added call to i18n{done, init}.
893 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
895 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
898 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
900 * casefile.c: Convert many uses of `int' to `bool'.
902 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
904 * transformations.c (trns_chain_destroy): Destroy chain's trns
905 member, to fix memory leak.
907 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
909 * storage-stream.c (storage_source_decapsulate): Destroy case
910 source to fix memory leak.
912 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
914 * scratch-reader.c (scratch_reader_read_case): Copy into existing
915 case passed as argument instead of initializing the argument as a
916 case. Fixes memory leak that showed up in
917 tests/command/aggregate.sh with scratch files.
919 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
921 * procedure.c (proc_done): Destroy default_dict, to fix memory
924 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
926 Simplify procedure_with_splits().
928 * procedure.c (struct split_aux_data): Removed case_count member.
929 (procedure_with_splits) Don't initialize case_count.
930 (split_procedure_case_func) Check whether prev_case is null
931 instead of case_count.
932 (split_procedure_end_func) Ditto.
934 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
936 * case.c (case_move): Do nothing if dst and src are the same
938 (case_try_create) Merge two similar cases.
939 (case_copy) Unshare only if data must be actually copied.
941 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
943 * data-in.c data-out.c dictionary.c sys-file-reader.c
944 sys-file-writer.c variable.c variable.h: Reworked very long string
945 support for better encapsulation.
947 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
949 * value-labels.c (val_labs_can_set_width): New function.
950 (val_labs_set_width) Clear labels if increasing width to long
952 (val_labs_destroy) Remove unneeded test for null.
954 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
956 * value-labels.h: Remove unneeded dependency on variable.h.
958 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
960 Get rid of `char *c' member in union value, for cleanliness.
962 * value.h: (union value) Remove `c' member.
964 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
966 Make dictionary compacting functions a little more general.
968 * sys-file-writer.c (sfm_open_writer): Use
969 dict_compacting_would_change().
970 (does_dict_need_translation) Removed.
972 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
974 Make dictionary compacting functions a little more general.
976 * dictionary.c (dict_needs_compaction): Rename
977 dict_compacting_would_shrink(). Update all callers.
978 (dict_compacting_would_change) New function.
980 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
982 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
983 inverted return value (!).
985 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
987 Continue reforming procedure execution.
989 * procedure.c: Search and replace "vfm" by "proc". Notably:
990 (static var vfm_source) Rename proc_source. Update all
992 (static var vfm_sink) Rename proc_sink. Update all references.
994 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
996 Continue reforming procedure execution. In this phase, remove
997 PROCESS IF, which was deprecated anyway and can be easily
998 simulated with TEMPORARY followed by SELECT IF.
1000 * procedure.c: (open_active_file) Don't call
1001 add_process_if_trns().
1002 (discard_variables) Get rid of redundant call to
1003 proc_cancel_all_transformations().
1004 (add_process_if_trns) Removed.
1005 (process_if_trns_proc) Removed.
1006 (process_if_trns_free) Removed.
1008 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1010 Continue reforming procedure execution. In this phase, add
1011 `const' to the case passed to procedure()'s callback.
1013 Updated all users of procedure() as well.
1015 * procedure.c: (struct write_case_data) Add "const" to ccase
1016 parameter for case_func member.
1017 (procedure) Add "const" to ccase parameter for proc_func
1019 (multipass_case_func) Make ccase parameter const.
1020 (internal_procedure) Add "const" to ccase parameter for case_func
1022 (split_procedure_case_func) Make ccase parameter const.
1023 (multipass_split_case_func) Make ccase parameter const.
1025 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1027 Continue reforming procedure execution. In this phase, get rid of
1028 the output code for SPLIT FILE groups in procedure.c, which really
1029 shouldn't be doing any output. Move it into the individual
1030 procedures instead. This also adds some flexibility.
1032 Updated many users of procedure_with_splits() and
1033 multipass_procedure_with_splits() to call
1034 output_split_file_values() and to deal with increased use of
1037 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1038 parameter to begin_func member.
1039 (procedure_with_splits) Add "const struct ccase *" parameter to
1040 begin_func parameter. Make ccase parameter const in proc_func
1042 (split_procedure_case_func) Don't dump split file group. Pass
1044 (dump_splits) Moved to language/dictionary/split-file.c as
1045 output_split_file_values().
1046 (struct multipass_split_aux_data) Add "const struct ccase *"
1047 parameter to split_func member.
1048 (multipass_procedure_with_splits) Add "const struct ccase *"
1049 parameter to split_func parameter.
1050 (multipass_split_case_func) Save new SPLIT FILE case before
1052 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1054 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1056 Continue reforming procedure execution. Change
1057 internal_procedure() so that it calls open_active_file() and
1058 close_active_file(), which isolates most of the actual procedure
1061 * procedure.c: (struct write_case_data) Rename `proc_func' member
1062 to `case_func' and update all references.
1063 (procedure) Rewrite as one-line wrapper around
1064 internal_procedure().
1065 (struct multipass_aux_data) New.
1066 (multipass_callback) Renamed multipass_case_func(). Use struct
1067 multipass_aux_data as auxiliary data.
1068 (multipass_end_func) New function.
1069 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1070 that uses multipass_case_func, multipass_end_func.
1071 (internal_procedure) Add `end_func' argument. Move optimization
1072 of trivial case in here. Move call to open_active_file() and
1073 close_active_file() in here. Now assert that vfm_source is
1075 (procedure_with_splits_callback) Rename
1076 split_procedure_case_func().
1077 (split_procedure_end_func) New function.
1078 (multipass_split_callback) Rename multipass_split_case_func.
1079 (multipass_split_end_func) New function.
1080 (discard_variables) No need to test for nonnull vfm_source.
1082 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1084 Continue reforming procedure execution. Get rid of unused member.
1086 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1088 (write_case) Don't increment cases_analyzed.
1090 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1092 Continue reforming procedure execution. In this phase, move
1093 procedure.c and procedure.h from src to src/data. Update
1094 makefiles and #includes accordingly.
1096 * procedure.c: Moved here from src/.
1098 * procedure.h: Moved here from src/.
1100 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1102 Continue reforming procedure execution. In this phase, get rid of
1103 many global variables, consolidating procedure execution in
1104 procedure.c. Encapsulate transformations in new "struct
1105 trns_chain". Also, change implementation of N OF CASES, FILTER,
1106 and PROCESS IF from special cases to transformations.
1108 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1111 * dictionary.c: (global variable default_dict) Move to
1114 * variable.h: (TRNS_*) Move to transformations.h.
1115 (struct transformation) Move to transformations.c.
1117 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1119 * sys-file-reader.c: Fixed invalid read problems.
1121 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1123 * storage-stream.c: Add missing function comments.
1125 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1127 Continue reforming procedure execution. In this phase, add some
1128 new, needed functionality to storage-stream.
1130 * storage-stream.c: (storage_source_decapsulate) New function.
1132 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1134 * variable.c (width_to_bytes): Declarations must precede
1135 statements for C90 compliance.
1137 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1139 * data-out.c, data-in.c, variable.c, variable.h: New functions
1140 copy_mangle and copy_demangle for reading/writing cases; emulates the
1141 way SPSS deals with strings > 255 bytes.
1143 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1144 subtype 14 needed for strings longer than 255 bytes.
1146 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1147 instead of literal values. Also fixed some constness issues.
1149 * format.h: Constness
1151 * sfm-private.h: Renamed the case_size identifier, since I discovered
1152 that SPSS's respect for this variable is very nominal.
1154 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1156 Change case limit type from int to size_t.
1158 * dictionary.c: (struct dictionary) Change type of case_limit
1160 (dict_get_case_limit) Change return type.
1161 (dict_set_case_limit) Change parameter type.
1163 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1165 * variable.h: (struct variable) Rename `reinit' member as `leave'
1166 and invert sense. Fix up all references.
1168 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1170 Continue reforming procedure execution. In this phase, break
1171 procedure.c into multiple files.
1173 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1175 * case-sink.c: New file.
1177 * case-sink.h: New file.
1179 * case-source.c: New file.
1181 * case-source.h: New file.
1183 * storage-stream.c: New file.
1185 * storage-stream.h: New file.
1187 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1189 * variable.h: (struct variable) Remove `init' member and all
1190 references to it from other files. It was initialized in several
1191 places, but nothing really ever used it for anything worthwhile.
1192 Thanks to Jason Stover for pointing out how confusing this
1195 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1197 Continue reforming error message support. In this phase, get rid
1198 of message "titles" and put the message text in `struct error'.
1199 Now `struct error' encapsulates a message more properly.
1201 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1202 Format message ourselves.
1204 * data-in.c: (vdls_error) Ditto.
1206 * por-file-reader.c: (error) Ditto.
1208 * sys-file-reader.c: (corrupt_msg) Ditto.
1210 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1212 GNU standards require "file name" instead of "filename" in
1213 documentation. It's nice for our code to follow the convention
1216 * casefile.c: (struct casefile) Rename `filename' member to
1217 `file_name'. Updated all references.
1219 * file-name.c: [!unix] (struct file_identity) Rename
1220 normalized_filename member to normalized_file_name. Updated all
1223 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1225 We don't really support anything but Unix-like environments well,
1226 so we might as well de-obfuscate by writing directory and path
1227 separators explicitly.
1229 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1231 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1232 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1234 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1237 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1239 GNU standards require "file name" instead of "filename" in
1240 documentation. It's nice for our code to follow the convention
1243 * filename.c: Rename to file-name.c.
1245 * filename.h: Rename to file-name.h. Update all inclusions.
1246 Update header guards.
1248 * automake.mk: Update file names.
1250 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1252 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1254 (fn_basename) Removed (dead code).
1255 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1256 (fn_special_p) Renamed fn_is_special(), all references updated.
1257 (fn_exists_p) Renamed fn_exists(), all references updated.
1259 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1261 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1262 Also, now it only tilde-expands file names, not paths.
1263 (fn_search_path) Tilde-expand one directory at a time.
1265 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1267 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1268 get rid of non-Unixlike version of the code, which has probably
1270 (fn_prepend_dir) Removed (dead code).
1272 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1273 (macro PATH_SEPARATOR_STRING) New.
1274 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1276 Continue reforming error message support. In this phase, we get
1277 rid of VM() and the other msg() support for "verbosity", replacing
1278 it by a new function verbose_msg().
1280 * filename.c: (fn_search_path) Use verbose_msg() instead of
1283 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1285 * sfm-private.h: Get rid of #defines after #error, which makes no
1288 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1290 Get rid of our own int32 type in favor of the standard int32_t
1293 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1296 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1298 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1300 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1302 Remove ill-considered file routines that are no longer used.
1304 * filename.c: (fn_open_ext) Removed.
1305 (fn_close_ext) Removed.
1307 * filename.h: (struct file_ext) Removed.
1309 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1311 * variable.c (var_is_valid_name): Move declarations before code
1314 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1316 * filename.ch (fn_interp_vars): Fixed small buglet.
1318 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1320 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1321 so as to modify the string inline. Thus makeing it easier to
1322 destroy the results when no longer needed.
1324 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1326 * category.c (cat_stored_values_destroy): Fixed memory leak.
1328 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1330 Add some missing frees. Thanks to John Darrington for reporting
1333 * any-writer.c (any_writer_close): Free writer.
1335 * any-reader.c (any_reader_close): Free reader.
1337 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1339 * por-file-reader.c: (error) Mark as NO_RETURN.
1341 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1343 * settings.c: Changed default value of scompress to true.
1345 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1347 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1349 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1352 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1353 here from pref.h.orig.
1355 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1357 * sys-file-reader.c: Fixed bug reading compressed files.
1359 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1361 * Numerous renames. See src/ChangeLog for details.
1363 * Moved files from src directory