1 2007-04-22 Ben Pfaff <blp@gnu.org>
3 * dictionary.c (dict_set_split_vars): dict_destroy expects that
4 dict_clear will free most data related to the dictionary.
5 dict_clear does a decent job, except that dict_set_split_vars on
6 some systems won't actually free the dict's "split" member.
7 Instead, it'll allocate a 1-byte region. Fix this.
9 * value.c (value_copy): New function.
10 (value_set_missing): Ditto.
12 2007-04-22 John Darrington <john@darrington.wattle.id.au>
14 * Deleted existing category.h and moved cat-routines.h into
15 category.h Encapsulated struct cat_vals better.
17 2007-04-19 John Darrington <john@darrington.wattle.id.au>
19 * sys-file-reader.c: When reading a system file which has no
20 long name table, automatically create one where the long names
21 are the lower case versions of the short names.
23 2007-04-16 John Darrington <john@darrington.wattle.id.au>
25 * sys-file-reader.c: Some versions of Other Software seem to
26 produce system files with string variables' measure set to
27 zero. We'll assume these are supposed to be nominal variables.
29 2007-03-30 Ben Pfaff <blp@gnu.org>
31 * procedure.c: Adapt to new deque data structure.
33 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
34 Ben Pfaff <blp@gnu.org>
36 * file-name.c: Mingw compatibility fixes.
37 (fn_search_path): Use ISSLASH instead of comparing against '/'
39 (fn_dir_name): Use dir_name from gnulib.
40 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
41 (fn_get_identity): Use GetFullPathName instead of canonicalize
42 from gnulib, because the latter does not fully support
43 Windows-style path names. Use this implementation based on the
44 detected presence of Windows instead of the absence of Unix, since
45 the new implementation is Windows-specific.
46 (fn_compare_file_identities): In Windows implementation, compare
47 names case-insensitively.
49 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
51 * make-file.c: Don't include mkstemp.h, because gnulib now causes
52 <stdlib.h> to have the same effect.
54 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
56 * por-file-reader.c: Add missing _() around messages.
58 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
60 * make-file.c: Include "mkstemp.h", without which linking on
63 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
65 Reduce platform dependence.
67 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
68 Everywhere we using this, we really should have just depended on
69 the shell to expand tildes.
70 (fn_search_path): Simplify, given that we don't do tilde expansion
72 (fn_normalize): Removed. Caller changed to use the canonicalize
74 (fn_get_cwd): Removed. Only user was fn_normalize.
75 (fn_is_absolute): Really only test for absolute names.
76 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
78 (fn_readlink): Removed, as it was only used fn_normalize.
79 (fn_exists): Assume the stat function is available; gnulib does.
80 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
82 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
84 * dictionary.c (dict_create_vector_assert): New function.
86 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
88 * file-name.c (fn_normalize): Correct name of function
89 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
90 for pointing this out.
92 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
94 We are using a single member in struct file_handle, the "name"
95 field, for more than one purpose. When it begins with '"', it's a
96 file name; otherwise, it's a token that can be used to identify
97 it. When that assertion fires, it's because we searched for the
98 name case-sensitively as a file name (so that there was no match),
99 and then we try to insert it case-insensitively as a token, which
100 fails because duplicates aren't allowed.
102 Solution: break the two purposes into two separate fields. This
103 fixes the problem and likely makes the code easier to read too.
105 Fixes bug #18922. Thanks to John Darrington for bug report and
108 * file-handle-def.c (struct file_handle): New `id' member.
109 (fh_from_name): Rename fh_from_id. Update all callers.
110 (create_handle): New `id' parameter. Update all callers.
111 (fh_create_file): Ditto.
112 (fh_get_id): New function.
114 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
116 * case.c (case_is_null): Change return type to bool.
118 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
122 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
123 reference counting to share data. This makes it easy for
124 valgrind, etc. to find accesses to cases that have been destroyed
125 but have been kept around by another user's ref-count. This often
126 happens when the data set is small enough to find in memory; if a
127 bigger data set that would overflow to disk were used, then data
128 corruption would occur.
130 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
134 * case.c (case_unshare): Make it check internally whether the
135 ref_cnt is greater than 1, so that the callers don't have to.
136 Update callers not to check.
138 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
140 Before, I was thinking that I might want to get rid of reference
141 counting at some point. Now, I'm pretty sure that it's here to
142 stay. Thus, because we have to store the value_cnt anyway for
143 reference-counted cases, we might as well expose it to users.
145 * case.c (case_get_value_cnt): New function.
146 (case_resize): Drop OLD_CNT argument. Update all callers. Only
147 resize case if its size actually changed.
149 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
150 instead of peeking inside struct case directly.
151 (casefile_append): Ditto.
153 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
155 Get rid of the inlines for the case functions, which made the
156 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
157 the inlines didn't speed up "make check" at all, which is not a
158 perfect benchmark but seems indicative.)
160 * case.c: Remove #ifdef DEBUGGING...#endif around many function
161 definitions. Remove some assertions on nonnull pointers that were
162 redundant with a pointer dereference soon after in the function.
164 (struct case_data): Move definition here from case.h.
168 (case_data_wr): Ditto.
170 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
172 * automake.mk: Add casedeque.h to sources.
174 * casedeque.h: New file.
176 * procedure.c: (struct dataset) Change lag_count, lag_head,
177 lag_queue member into single struct casedeque member. Update all
178 users to use the casedeque instead.
181 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
183 * procedure.c: Simplify lagged cases interface. Updated all
184 clients--well, the only client--to use the simplified interface.
185 (dataset_n_lag) Removed.
186 (dataset_set_n_lag) Removed.
187 (dataset_need_lag) New function.
189 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
191 * dictionary.c procedure.c: More changes to ensure that callbacks occur
192 whenever appropriate, but only when the dataset/dictionary is in a
195 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
197 * dictionary.c dictionary.h : Added callbacks for change of filter and
198 split variables. Refactored some code to ensure that callbacks get
199 invoked when appropriate.
201 * procedure.c (proc_cancel_temporary_transformations): Make sure that
202 replace_dict callback occurs when permanent_dict replaces the current
205 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
207 * dictionary.c dictionary.h : Added callback for when the weight
208 variable of a dictionary changes.
210 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
212 * dictionary.c dictionary.h : Added replace_source and replace_dict
213 callbacks, and functions to deal with them.
215 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
217 Simplify missing value handling.
219 * missing-values.h (enum mv_class): New type.
220 (enum mv_type): Moved definition into missing-values.c and renamed
221 each MV_* to MVT_*, to distinguish them from the exposed mv_class
222 enums. Updated all uses.
223 (struct missing_values): Changed type of `type' from `enum
224 mv_type' to `int' because the definition is no longer exposed.
226 * missing-values.c (mv_is_value_missing): Add new enum mv_class
227 parameter. Update all callers.
228 (mv_is_num_missing): Ditto.
229 (mv_is_str_missing): Ditto.
230 (mv_is_value_user_missing): Removed. Changed callers to use
232 (mv_is_num_user_missing): Removed. Changed callers to use
234 (mv_is_str_user_missing): Removed. Changed callers to use
236 (mv_is_value_system_missing): Removed. Changed callers to use
238 (mv_set_type): Removed. Changed callers to use mv_clear.
239 (mv_clear): New function.
241 * variable.c (var_is_value_missing): Add new enum mv_class
242 parameter. Update all callers.
243 (var_is_num_missing): Ditto.
244 (var_is_str_missing): Ditto.
245 (var_is_value_user_missing): Removed. Changed callers to use
246 var_is_value_missing.
247 (var_is_num_user_missing): Removed. Changed callers to use
249 (var_is_str_user_missing): Removed. Changed callers to use
251 (var_is_value_system_missing): Removed. Changed callers to use
252 var_is_value_missing.
254 * casefilter.c (struct casefilter): Use enum mv_class in place of
256 (casefilter_variable_missing): Adapt to new member.
257 (casefilter_create): Change signature to take enum mv_class,
260 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
262 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
264 * case-sink.c case-sink.h procedure.c procedure.h
265 storage-stream.c: Now uses the factory.
267 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
269 Make it possible to pull cases from the active file with a
270 function call, instead of requiring indirection through a callback
273 * case-source.h (struct case_source_class): Change ->read function
274 to return a single case, instead of calling a callback function
275 for each case. Change ->destroy function to return an error
278 * case-source.c (free_case_source): Pass along the value returned
279 by the case_source ->destroy function.
281 * procedure.c (struct write_case_data): Removed.
282 (struct dataset): Added some members to track procedure state.
283 (procedure): Optimize the trivial case at this level.
284 (internal_procedure): Re-implement in terms of proc_open,
285 proc_read, proc_close.
286 (proc_open) New function.
287 (proc_read) New function.
288 (proc_close) New function.
289 (write_case) Moved into proc_read.
290 (close_active_file) Moved closing of data source into proc_close.
292 * storage-source.c: Rewrote to conform with modified
293 case_source_class interface.
295 * transformations.c (trns_chain_execute): Added argument to allow
296 starting execution from an arbitrary transformation. Updated
299 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
301 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
303 * sys-file-reader.c (read_display_parameters): Don't assume that
304 MEASURE_* and ALIGN_* have the same values found in system files.
306 * sys-file-writer.c (write_variable_display_parameters): Ditto.
308 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
309 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
310 the value of n_MEASURES, which was off by 1 (at least from my
313 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
315 * dictionary.c dictionary.h vardict.h variable.c: Added optional
316 callbacks which are invoked when the dictionary or its
317 variables are changed.
319 * missing-values.c missing-values.h value-labels.c: Tidied up
320 consistency checks, and made some of them return false
321 instead of assert-failing.
323 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
325 * calendar.c (calendar_days_in_month): New function.
327 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
329 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
330 the value label's width.
332 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
334 * sfm-private.h: Move contents into sys-file-writer.c, which is
335 the only remaining user. Removed Borland C++-specific directives.
337 * sys-file-reader.c: Clean up and rewrite entire file. The
338 rewritten version is simpler and better abstracted, and should be
339 easier to maintain and extend. It avoids using structures to read
340 file data, which is prone to padding variations among compilers.
341 It should also handle non-IEEE 754 system files, although I
342 haven't been able to find any. It has been tested against many
343 .sav files obtained from the Web and found to produce the same
344 results as the earlier version of the code, or in some cases
345 improved results. It is more tolerant of format variations found
348 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
349 member, putting an enum integer_format in its place. New member
350 `float_format'. Changed `compressed' member to type bool.
352 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
354 * dictionary.c (dict_delete_consecutive_vars): New function.
356 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
358 * file-name.c (fn_search_path): Remove prefix arg that was unused
359 by any caller. Updated all callers.
361 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
363 * format.c (fmt_dollar_template): Use user's decimal point
364 character. Add assertion.
366 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
368 * format.c (fmt_dollar_template): New function, based on
369 dollar_format_template from var-type-dialog.c.
371 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
373 * data-out.c (output_scientific): Fix bad assumption that "buf" is
376 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
378 Finish converting struct variable to an opaque type. In this
379 phase, we add remaining setter and getter functions, convert the
380 remaining PSPP code to use them, and do a bunch of cleanup. The
381 resulting changes are pervasive but mostly trivial, and only the
382 notable changes are logged.
384 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
387 * case.c (case_data): Renamed case_data_idx.
388 (case_num): Renamed case_num_idx.
389 (case_str): Renamed case_str_idx.
390 (case_data_rw): Renamed case_data_rw_idx.
392 * case.h (case_data): New function with old name and an interface
393 that takes a variable instead of an index, which is easier to
394 use. Updated all callers to use the new interface, or to use the
395 new *_idx function (see above).
398 (case_data_rw): Ditto.
400 * category.c (cat_stored_values_destroy): Changed interface to
401 take a struct cat_vals * instead of a struct variable *.
403 * dictionary.c (dict_clone): Use new vector_clone function.
404 (dict_clear) Use new var_destroy function.
405 (add_var) New function.
406 (dict_create_var) Rewrite in terms of dict_create_var_assert.
407 (dict_create_var_assert) Rewrite in terms of add_var.
408 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
409 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
410 (dict_lookup_var) Use new var_create, var_destroy functions.
411 (dict_contains_var) Rewrite in terms of new vardict functionality.
412 (set_var_dict_index) New function.
413 (set_var_case_index) New function.
414 (reindex_vars) New function.
415 (dict_delete_var) Rewrite in terms of new vardict functionality.
416 (dict_reorder_var) Ditto.
417 (dict_reorder_vars) Ditto.
418 (rename_var) New function.
419 (dict_rename_var) Use rename_var.
420 (dict_rename_vars) Use pool to simplify code. Use rename_var.
421 (dict_get_compacted_idx_to_fv) Rename
422 dict_get_compacted_dict_index_to_case_index, update callers.
423 (dict_create_vector) Use new vector_create function.
424 (dict_clear_vectors) Use new vector_destroy function.
425 (set_var_short_name_suffix) Move here from variable.c, renamed
426 from var_set_short_name_suffix, make static, update caller.
428 * sys-file-private.c: New file.
429 (sfm_width_to_bytes) Moved here from variable.c, renamed from
430 width_to_bytes, update callers.
432 * sys-file-private.h: New file. Later it will supplant
433 sfm-private.h; for now it supplements it.
434 (macro MIN_VERY_LONG_STRING) New macro.
435 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
437 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
438 MAX_LONG_STRING was used before.
440 * sys-file-writer.c: Ditto.
442 * value-labels.c: Change the paradigm here to be that a null
443 pointer is OK for a struct val_labs * in most cases; it just
444 represents an empty set of value labels.
445 (val_labs_copy) A copy of a null set is a null set.
446 (val_labs_count) A null set has 0 labels.
447 (val_labs_replace) Change return type to void. Rewrite for
449 (val_labs_find) A null set does not contain the value.
450 (value_to_string) Moved to variable.c, renamed var_get_value_name,
451 transposed argument order, updated all callers.
454 (value_dup) Moved here from variable.c.
455 (compare_values) Ditto.
458 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
459 (macro MAX_LONG_STRING) Removed, because it was only interesting
460 for system files, not for general code.
461 (macro MAX_VERY_LONG_STRING) Ditto.
462 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
463 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
465 * vardict.h: New file, for an interface between variables and
468 * variable.c: A lot of functions were moved around, for better
470 (struct variable) Move definition here, from variable.h.
471 (var_type_adj) Removed--makes i18n hard.
472 (var_type_noun) Ditto.
473 (var_create) New function.
474 (var_clone) New function.
475 (var_destroy) New function.
476 (var_set_name) Assert that variable is not in a dictionary.
477 (compare_var_names) Rename compare_vars_by_name and fix a couple
478 of callers who thought the args were strings.
479 (hash_var_name) Rename hash_var_by_name.
480 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
481 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
482 (var_is_very_long_string) Removed, because it was only interesting
484 (var_set_missing_values) Allow the argument to be the wrong width,
485 as long as we can resize it. Simplify callers who were doing the
487 (var_get_value_labels) New function.
488 (var_has_value_labels) New function.
489 (var_set_value_labels) New function.
490 (alloc_value_labels) New function.
491 (var_add_value_label) New function.
492 (var_replace_value_label) New function.
493 (var_clear_value_labels) New function.
494 (var_lookup_value_label) New function.
495 (var_get_value_name) Moved here from variable.c, renamed from
496 var_get_value_name, transposed argument order, updated all
498 (var_to_string) Moved here, from variable-label.c.
499 (var_set_leave) New function.
500 (var_get_leave) New function.
501 (var_must_leave) New function.
502 (var_set_short_name_suffix) Moved to dictionary.c, renamed
503 set_var_short_name_suffix.
504 (var_get_dict_index) New function.
505 (var_get_case_index) New function.
506 (var_get_obs_vals) New function.
507 (var_set_obs_vals) New function.
508 (var_has_obs_vals) New function.
509 (var_get_vardict) New function.
510 (var_set_vardict) New function.
511 (var_has_vardict) New function.
512 (var_clear_vardict) New function.
513 (value_dup) Moved to value.c.
514 (compare_values) Ditto.
517 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
518 (enum ALPHA) Rename VAR_STRING, update all users.
520 * vector.c: New file.
521 (struct vector) Moved here, from variable.h.
522 (check_widths) New function.
523 (vector_create) New function.
524 (vector_clone) New function.
525 (vector_destroy) New function.
526 (vector_get_name) New function.
527 (vector_get_var) New function.
528 (vector_get_var_cnt) New function.
529 (compare_vector_ptrs_by_name) New function.
531 * vector.h: New file.
533 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
535 * casefilter.c (casefilter_variable_missing): Avoided comparision of
536 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
539 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
541 * value-labels.c (destroy_atoms): New function.
542 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
544 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
546 Thanks to Jason Stover for pointing out this problem.
548 * data-out.c (output_number): Use gsl_finite from GSL, which is
549 portable, instead of isfinite, which is not.
552 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
554 * variable.c variable.h (value_dup): New function.
556 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
558 Start converting struct variable to an opaque type. In this
559 phase, we add a bunch of setter and getter functions and convert
560 most of the PSPP code to use them. The resulting changes are
561 pervasive but mostly trivial, and only the notable changes are
564 * format.c (fmt_equal): New function.
566 * variable.c (var_type_is_valid): New function.
567 (measure_is_valid) Moved here, from format.c.
568 (alignment_is_valid) Moved here, from format.c.
569 (var_get_name) New function.
570 (var_set_name) New function.
571 (width_to_type) New function.
572 (var_get_type) New function.
573 (var_get_width) New function.
574 (var_set_width) New function.
575 (var_is_numeric) New function.
576 (var_is_alpha) New function.
577 (var_is_short_string) New function.
578 (var_is_long_string) New function.
579 (var_is_very_long_string) New function.
580 (var_get_missing_values) New function.
581 (var_set_missing_values) New function.
582 (var_clear_missing_values) New function.
583 (var_has_missing_values) New function.
584 (var_is_value_missing) New function.
585 (var_is_num_missing) New function.
586 (var_is_str_missing) New function.
587 (var_is_value_user_missing) New function.
588 (var_is_num_user_missing) New function.
589 (var_is_str_user_missing) New function.
590 (var_is_value_system_missing) New function.
591 (var_get_print_format) New function.
592 (var_set_print_format) New function.
593 (var_get_write_format) New function.
594 (var_set_write_format) New function.
595 (var_set_both_formats) New function.
596 (var_get_label) New function.
597 (var_set_label) New function.
598 (var_clear_label) New function.
599 (var_has_label) New function.
600 (var_get_measure) New function.
601 (var_set_measure) New function.
602 (var_get_display_width) New function.
603 (var_set_display_width) New function.
604 (var_get_alignment) New function.
605 (var_set_alignment) New function.
606 (var_get_value_cnt) New function.
607 (var_get_leave) New function.
608 (var_get_short_name) New function.
610 * variable.h: (struct variable) Removed "type" and "nv" members;
611 they are now computed from "width" where needed.
613 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
615 * missing-values.c (mv_resize): Don't write beyond end of the
616 allocated buffer when resizing a long string.
618 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
620 Clean up identifier code: don't require identifier enumerations to
621 be in a particular order; make better use of string library;
622 expose less of the internals.
624 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
625 change interface. Updated all callers.
626 (lex_id_match) Change interface to use struct substring, update
628 (lex_id_match_len) Removed. Update callers to use lex_id_match.
629 (global array keywords[]) Make static, change form. Update all
630 users to use lex_id_name instead.
631 (lex_is_keyword) New function.
632 (lex_id_to_token) Change interface to use struct substring, update
634 (lex_id_name) New function.
636 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
637 lex_is_keyword instead.
638 (T_LAST_KEYWORD) Removed.
639 (T_N_KEYWORDS) Removed.
641 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
643 * format.c: (fmt_date_template) Distinguish characters for which a
644 space is output and any date delimiter is allowed on input, from
645 those for which a space is output and only a space is allowed on
646 input. The former is represented by X, the latter by a space.
647 Also, drop distinction between h and H, changing the former to the
650 * data-in.c: Completely rewrite internals to conform to SPSS input
651 formats as closely as possible.
652 (data_in) Changed external interface by replacing the structure
653 that was used as a single argument by a set of arguments. Updated
655 (data_in_finite_line) Removed. Converted all callers to use plain
657 (data_in_get_integer_format) New function.
658 (data_in_set_integer_format) New function.
659 (data_in_get_float_format) New function.
660 (data_in_set_float_format) New function.
662 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
663 (struct data_in) Removed.
665 * data-out.c: (output_date) Drop each component from the input as
666 it is output, to allow us to drop the distinction between h (a
667 count of hours) and H (the hour of day) template characters.
668 Also, handle new X template character.
669 (output_scientific) Follow more rational rule on when to drop
670 fraction introduced between SPSS 13 and 15. Updated test case to
673 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
675 Fix buffer overflow reported by John Darrington.
677 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
678 realize that DIGITS is a count of nibbles, not of bytes.
680 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
682 * calendar.c (calendar_offset_to_gregorian) Also return the
683 year-of-day. Change callers to new interface.
685 * data-out.c: Completely rewrite internals to conform to SPSS
686 output formats as completely as possible.
687 (data_out) Change interface to put input parameters before output
688 parameters, for consistency with the style I now prefer. Update
690 (data_out_get_integer_format) New public function.
691 (data_out_set_integer_format) New public function.
692 (data_out_get_float_format) New public function.
693 (data_out_set_float_format) New public function.
695 * data-out.h: New file. Move prototype for data_out here, from
698 * format.c: (fmt_step_width) Use equality comparison instead of
699 bitwise and, for clarity.
700 (fmt_is_string) Ditto.
701 (fmt_input_to_output) Fix categories that are translated to F
704 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
706 * casefilter.c casefilter.h (new files), casefile.c casefile.h
707 casefile-private.h: Added casefilter to assist commands with missing
710 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
712 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
714 * settings.c: (route_errors_to_terminal) New variable.
715 (route_errors_to_listing) New variable.
716 (get_error_routing_to_terminal) New function.
717 (set_error_routing_to_terminal) New function.
718 (get_error_routing_to_listing) New function.
719 (set_error_routing_to_listing) New function.
721 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
723 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
725 * format.c: Completely rewrite, to achieve better abstraction.
726 Rewrite all references to formats in other files.
728 * format.def: Rewrite and reorganize.
730 * settings.c: Move everything related to custom currency formats
731 into format.[ch], changing them in form, so as to group related
732 code and definitions better. Changed all references to use the
734 (static var decimal) Removed.
735 (static var grouping) Removed.
736 (static var cc) Removed.
737 (get_decimal) Removed.
738 (set_decimal) Removed.
739 (get_grouping) Removed.
740 (set_grouping) Removed.
744 * settings.h: (macro CC_CNT) Removed.
745 (macro CC_WIDTH) Removed.
746 (struct custom_currency) Removed.
748 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
750 * data-in.c (data_in): Use switch statement instead of table, to
751 avoid dependence on the order of the FMT_* enums.
753 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
755 * data-out.c: (num_to_string) Removed, because it was dead code.
757 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
759 * data-in.c (parse_trailer): Fix error message.
761 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
763 * format.c (fmt_is_binary): New function.
765 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
767 * procedure.c procedure.h: Encapsulated the static data into a single
770 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
772 * casefile.c (casereader_read_xfer): Always initialize the case,
773 even on an error condition.
775 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
777 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
778 entire function useless.
780 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
782 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
783 casereader method casereader_clone.
785 * procedure.c pransformations.h: Introduced new type casenum_t
787 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
789 * variable.c: (width_to_bytes) Rephrase code for clarify.
791 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
793 * format.c: (fmt_type_from_string) New function.
794 (fmt_to_string) Include decimals in output if the format has
795 decimals, even if the format type does not. This way, we can
796 accurately reproduce incorrect formats in user output.
797 (check_common_specifier) Make the check for a bad format type an
798 assertion, so we get bug reports if they show up. Fix message.
799 Check for decimal places with a format type that doesn't allow
801 (check_input_specifier) Remove check for FMT_X, which has been
803 (check_output_specifier) Ditto.
805 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
807 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
808 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
809 (enum fmt_parse_flags) Removed.
811 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
813 * casefile.c casefile.h: Converted to an abstract base class.
814 * casefile-private.h fastfile.c fastfile.h: New files.
815 * automake.mk procedure.c scratch-writer.c storage-stream.c
817 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
819 * procedure.c (internal_procedure): Create sink_case with only as
820 many values as the compacted dictionary.
822 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
824 Remove "debugging" code that caused plenty of false positives and
827 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
829 * case.c: Remove all references to `this' member.
831 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
833 Fix link error noted by Jason Stover.
835 * storage-stream.c: Include <assert.h>.
837 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
839 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
840 ALL) and additional underlying system file issues.
842 Thanks to John Darrington for review.
844 First problem: var_hash points to variables not owned by the
845 sys-file-reader, which the caller may free or modify. Use an
846 array of sfm_vars instead, as done earlier (e.g. CVS version
849 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
850 members and remove all code that references it. Add vars, var_cnt
851 members. Remove fix_specials member, which was unused.
852 (struct sfm_var) Remove name member, which was unused.
853 (sfm_close_reader) Free vars member instead of var_hash.
854 (compare_var_shortnames) Removed.
855 (hash_var_shortname) Removed.
856 (sfm_open_reader) Fill out vars array.
857 (compare_var_index) Removed.
858 (sfm_read_case) Use vars instead of var_hash.
860 Second problem: we're confused about when we actually have very
861 long strings, causing us to choose incorrectly between slow path
862 and fast path in sfm_read_case.
864 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
865 have very long strings, not when we have long variable names,
866 which is an unrelated feature.
868 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
870 * variable.h: Move var_set and variable parsing declarations to
871 new header, src/language/lexer/variable-parser.h. Modified lots
872 of files to include the new header.
874 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
876 * value-labels.c (value_to_string): When there's no value label,
877 format the variable according to its print format, instead of
878 always effectively using A or F format.
880 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
882 * casefile.c (casefile_get_random_reader): Nasty hack to get around
885 * format.c: Removed tortological assertion.
887 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
889 Reform string library.
891 * file-name.c (fn_interp_vars): Change interface to take a
892 substring as input. Updated all users.
894 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
896 * format.c (measure_is_valid): Really return false when m >=
899 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
901 Implement random access to casefiles, for use in GUI.
903 * casefile.c: (struct casereader) Add `random', `file_ofs',
904 `buffer_ofs' members.
905 (casefile_get_random_reader) New function.
906 (read_open_file) Break part into new function
907 seek_and_fill_buffer().
908 (fill_buffer) Update buffer_ofs, file_ofs.
909 (casereader_seek) New function.
911 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
913 * settings.c: Added call to i18n{done, init}.
915 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
917 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
920 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
922 * casefile.c: Convert many uses of `int' to `bool'.
924 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
926 * transformations.c (trns_chain_destroy): Destroy chain's trns
927 member, to fix memory leak.
929 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
931 * storage-stream.c (storage_source_decapsulate): Destroy case
932 source to fix memory leak.
934 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
936 * scratch-reader.c (scratch_reader_read_case): Copy into existing
937 case passed as argument instead of initializing the argument as a
938 case. Fixes memory leak that showed up in
939 tests/command/aggregate.sh with scratch files.
941 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
943 * procedure.c (proc_done): Destroy default_dict, to fix memory
946 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
948 Simplify procedure_with_splits().
950 * procedure.c (struct split_aux_data): Removed case_count member.
951 (procedure_with_splits) Don't initialize case_count.
952 (split_procedure_case_func) Check whether prev_case is null
953 instead of case_count.
954 (split_procedure_end_func) Ditto.
956 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
958 * case.c (case_move): Do nothing if dst and src are the same
960 (case_try_create) Merge two similar cases.
961 (case_copy) Unshare only if data must be actually copied.
963 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
965 * data-in.c data-out.c dictionary.c sys-file-reader.c
966 sys-file-writer.c variable.c variable.h: Reworked very long string
967 support for better encapsulation.
969 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
971 * value-labels.c (val_labs_can_set_width): New function.
972 (val_labs_set_width) Clear labels if increasing width to long
974 (val_labs_destroy) Remove unneeded test for null.
976 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
978 * value-labels.h: Remove unneeded dependency on variable.h.
980 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
982 Get rid of `char *c' member in union value, for cleanliness.
984 * value.h: (union value) Remove `c' member.
986 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
988 Make dictionary compacting functions a little more general.
990 * sys-file-writer.c (sfm_open_writer): Use
991 dict_compacting_would_change().
992 (does_dict_need_translation) Removed.
994 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
996 Make dictionary compacting functions a little more general.
998 * dictionary.c (dict_needs_compaction): Rename
999 dict_compacting_would_shrink(). Update all callers.
1000 (dict_compacting_would_change) New function.
1002 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1004 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1005 inverted return value (!).
1007 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1009 Continue reforming procedure execution.
1011 * procedure.c: Search and replace "vfm" by "proc". Notably:
1012 (static var vfm_source) Rename proc_source. Update all
1014 (static var vfm_sink) Rename proc_sink. Update all references.
1016 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1018 Continue reforming procedure execution. In this phase, remove
1019 PROCESS IF, which was deprecated anyway and can be easily
1020 simulated with TEMPORARY followed by SELECT IF.
1022 * procedure.c: (open_active_file) Don't call
1023 add_process_if_trns().
1024 (discard_variables) Get rid of redundant call to
1025 proc_cancel_all_transformations().
1026 (add_process_if_trns) Removed.
1027 (process_if_trns_proc) Removed.
1028 (process_if_trns_free) Removed.
1030 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1032 Continue reforming procedure execution. In this phase, add
1033 `const' to the case passed to procedure()'s callback.
1035 Updated all users of procedure() as well.
1037 * procedure.c: (struct write_case_data) Add "const" to ccase
1038 parameter for case_func member.
1039 (procedure) Add "const" to ccase parameter for proc_func
1041 (multipass_case_func) Make ccase parameter const.
1042 (internal_procedure) Add "const" to ccase parameter for case_func
1044 (split_procedure_case_func) Make ccase parameter const.
1045 (multipass_split_case_func) Make ccase parameter const.
1047 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1049 Continue reforming procedure execution. In this phase, get rid of
1050 the output code for SPLIT FILE groups in procedure.c, which really
1051 shouldn't be doing any output. Move it into the individual
1052 procedures instead. This also adds some flexibility.
1054 Updated many users of procedure_with_splits() and
1055 multipass_procedure_with_splits() to call
1056 output_split_file_values() and to deal with increased use of
1059 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1060 parameter to begin_func member.
1061 (procedure_with_splits) Add "const struct ccase *" parameter to
1062 begin_func parameter. Make ccase parameter const in proc_func
1064 (split_procedure_case_func) Don't dump split file group. Pass
1066 (dump_splits) Moved to language/dictionary/split-file.c as
1067 output_split_file_values().
1068 (struct multipass_split_aux_data) Add "const struct ccase *"
1069 parameter to split_func member.
1070 (multipass_procedure_with_splits) Add "const struct ccase *"
1071 parameter to split_func parameter.
1072 (multipass_split_case_func) Save new SPLIT FILE case before
1074 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1076 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1078 Continue reforming procedure execution. Change
1079 internal_procedure() so that it calls open_active_file() and
1080 close_active_file(), which isolates most of the actual procedure
1083 * procedure.c: (struct write_case_data) Rename `proc_func' member
1084 to `case_func' and update all references.
1085 (procedure) Rewrite as one-line wrapper around
1086 internal_procedure().
1087 (struct multipass_aux_data) New.
1088 (multipass_callback) Renamed multipass_case_func(). Use struct
1089 multipass_aux_data as auxiliary data.
1090 (multipass_end_func) New function.
1091 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1092 that uses multipass_case_func, multipass_end_func.
1093 (internal_procedure) Add `end_func' argument. Move optimization
1094 of trivial case in here. Move call to open_active_file() and
1095 close_active_file() in here. Now assert that vfm_source is
1097 (procedure_with_splits_callback) Rename
1098 split_procedure_case_func().
1099 (split_procedure_end_func) New function.
1100 (multipass_split_callback) Rename multipass_split_case_func.
1101 (multipass_split_end_func) New function.
1102 (discard_variables) No need to test for nonnull vfm_source.
1104 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1106 Continue reforming procedure execution. Get rid of unused member.
1108 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1110 (write_case) Don't increment cases_analyzed.
1112 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1114 Continue reforming procedure execution. In this phase, move
1115 procedure.c and procedure.h from src to src/data. Update
1116 makefiles and #includes accordingly.
1118 * procedure.c: Moved here from src/.
1120 * procedure.h: Moved here from src/.
1122 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1124 Continue reforming procedure execution. In this phase, get rid of
1125 many global variables, consolidating procedure execution in
1126 procedure.c. Encapsulate transformations in new "struct
1127 trns_chain". Also, change implementation of N OF CASES, FILTER,
1128 and PROCESS IF from special cases to transformations.
1130 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1133 * dictionary.c: (global variable default_dict) Move to
1136 * variable.h: (TRNS_*) Move to transformations.h.
1137 (struct transformation) Move to transformations.c.
1139 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1141 * sys-file-reader.c: Fixed invalid read problems.
1143 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1145 * storage-stream.c: Add missing function comments.
1147 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1149 Continue reforming procedure execution. In this phase, add some
1150 new, needed functionality to storage-stream.
1152 * storage-stream.c: (storage_source_decapsulate) New function.
1154 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1156 * variable.c (width_to_bytes): Declarations must precede
1157 statements for C90 compliance.
1159 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1161 * data-out.c, data-in.c, variable.c, variable.h: New functions
1162 copy_mangle and copy_demangle for reading/writing cases; emulates the
1163 way SPSS deals with strings > 255 bytes.
1165 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1166 subtype 14 needed for strings longer than 255 bytes.
1168 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1169 instead of literal values. Also fixed some constness issues.
1171 * format.h: Constness
1173 * sfm-private.h: Renamed the case_size identifier, since I discovered
1174 that SPSS's respect for this variable is very nominal.
1176 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1178 Change case limit type from int to size_t.
1180 * dictionary.c: (struct dictionary) Change type of case_limit
1182 (dict_get_case_limit) Change return type.
1183 (dict_set_case_limit) Change parameter type.
1185 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1187 * variable.h: (struct variable) Rename `reinit' member as `leave'
1188 and invert sense. Fix up all references.
1190 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1192 Continue reforming procedure execution. In this phase, break
1193 procedure.c into multiple files.
1195 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1197 * case-sink.c: New file.
1199 * case-sink.h: New file.
1201 * case-source.c: New file.
1203 * case-source.h: New file.
1205 * storage-stream.c: New file.
1207 * storage-stream.h: New file.
1209 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1211 * variable.h: (struct variable) Remove `init' member and all
1212 references to it from other files. It was initialized in several
1213 places, but nothing really ever used it for anything worthwhile.
1214 Thanks to Jason Stover for pointing out how confusing this
1217 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1219 Continue reforming error message support. In this phase, get rid
1220 of message "titles" and put the message text in `struct error'.
1221 Now `struct error' encapsulates a message more properly.
1223 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1224 Format message ourselves.
1226 * data-in.c: (vdls_error) Ditto.
1228 * por-file-reader.c: (error) Ditto.
1230 * sys-file-reader.c: (corrupt_msg) Ditto.
1232 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1234 GNU standards require "file name" instead of "filename" in
1235 documentation. It's nice for our code to follow the convention
1238 * casefile.c: (struct casefile) Rename `filename' member to
1239 `file_name'. Updated all references.
1241 * file-name.c: [!unix] (struct file_identity) Rename
1242 normalized_filename member to normalized_file_name. Updated all
1245 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1247 We don't really support anything but Unix-like environments well,
1248 so we might as well de-obfuscate by writing directory and path
1249 separators explicitly.
1251 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1253 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1254 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1256 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1259 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1261 GNU standards require "file name" instead of "filename" in
1262 documentation. It's nice for our code to follow the convention
1265 * filename.c: Rename to file-name.c.
1267 * filename.h: Rename to file-name.h. Update all inclusions.
1268 Update header guards.
1270 * automake.mk: Update file names.
1272 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1274 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1276 (fn_basename) Removed (dead code).
1277 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1278 (fn_special_p) Renamed fn_is_special(), all references updated.
1279 (fn_exists_p) Renamed fn_exists(), all references updated.
1281 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1283 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1284 Also, now it only tilde-expands file names, not paths.
1285 (fn_search_path) Tilde-expand one directory at a time.
1287 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1289 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1290 get rid of non-Unixlike version of the code, which has probably
1292 (fn_prepend_dir) Removed (dead code).
1294 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1295 (macro PATH_SEPARATOR_STRING) New.
1296 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1298 Continue reforming error message support. In this phase, we get
1299 rid of VM() and the other msg() support for "verbosity", replacing
1300 it by a new function verbose_msg().
1302 * filename.c: (fn_search_path) Use verbose_msg() instead of
1305 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1307 * sfm-private.h: Get rid of #defines after #error, which makes no
1310 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1312 Get rid of our own int32 type in favor of the standard int32_t
1315 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1318 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1320 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1322 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1324 Remove ill-considered file routines that are no longer used.
1326 * filename.c: (fn_open_ext) Removed.
1327 (fn_close_ext) Removed.
1329 * filename.h: (struct file_ext) Removed.
1331 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1333 * variable.c (var_is_valid_name): Move declarations before code
1336 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1338 * filename.ch (fn_interp_vars): Fixed small buglet.
1340 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1342 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1343 so as to modify the string inline. Thus makeing it easier to
1344 destroy the results when no longer needed.
1346 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1348 * category.c (cat_stored_values_destroy): Fixed memory leak.
1350 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1352 Add some missing frees. Thanks to John Darrington for reporting
1355 * any-writer.c (any_writer_close): Free writer.
1357 * any-reader.c (any_reader_close): Free reader.
1359 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1361 * por-file-reader.c: (error) Mark as NO_RETURN.
1363 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1365 * settings.c: Changed default value of scompress to true.
1367 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1369 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1371 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1374 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1375 here from pref.h.orig.
1377 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1379 * sys-file-reader.c: Fixed bug reading compressed files.
1381 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1383 * Numerous renames. See src/ChangeLog for details.
1385 * Moved files from src directory