1 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
3 * casefile.c (casefile_get_random_reader): Nasty hack to get around
6 * format.c: Removed tortological assertion.
8 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
10 Reform string library.
12 * file-name.c (fn_interp_vars): Change interface to take a
13 substring as input. Updated all users.
15 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
17 * format.c (measure_is_valid): Really return false when m >=
20 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
22 Implement random access to casefiles, for use in GUI.
24 * casefile.c: (struct casereader) Add `random', `file_ofs',
26 (casefile_get_random_reader) New function.
27 (read_open_file) Break part into new function
28 seek_and_fill_buffer().
29 (fill_buffer) Update buffer_ofs, file_ofs.
30 (casereader_seek) New function.
32 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
34 * settings.c: Added call to i18n{done, init}.
36 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
38 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
41 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
43 * casefile.c: Convert many uses of `int' to `bool'.
45 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
47 * transformations.c (trns_chain_destroy): Destroy chain's trns
48 member, to fix memory leak.
50 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
52 * storage-stream.c (storage_source_decapsulate): Destroy case
53 source to fix memory leak.
55 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
57 * scratch-reader.c (scratch_reader_read_case): Copy into existing
58 case passed as argument instead of initializing the argument as a
59 case. Fixes memory leak that showed up in
60 tests/command/aggregate.sh with scratch files.
62 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
64 * procedure.c (proc_done): Destroy default_dict, to fix memory
67 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
69 Simplify procedure_with_splits().
71 * procedure.c (struct split_aux_data): Removed case_count member.
72 (procedure_with_splits) Don't initialize case_count.
73 (split_procedure_case_func) Check whether prev_case is null
74 instead of case_count.
75 (split_procedure_end_func) Ditto.
77 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
79 * case.c (case_move): Do nothing if dst and src are the same
81 (case_try_create) Merge two similar cases.
82 (case_copy) Unshare only if data must be actually copied.
84 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
86 * data-in.c data-out.c dictionary.c sys-file-reader.c
87 sys-file-writer.c variable.c variable.h: Reworked very long string
88 support for better encapsulation.
90 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
92 * value-labels.c (val_labs_can_set_width): New function.
93 (val_labs_set_width) Clear labels if increasing width to long
95 (val_labs_destroy) Remove unneeded test for null.
97 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
99 * value-labels.h: Remove unneeded dependency on variable.h.
101 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
103 Get rid of `char *c' member in union value, for cleanliness.
105 * value.h: (union value) Remove `c' member.
107 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
109 Make dictionary compacting functions a little more general.
111 * sys-file-writer.c (sfm_open_writer): Use
112 dict_compacting_would_change().
113 (does_dict_need_translation) Removed.
115 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
117 Make dictionary compacting functions a little more general.
119 * dictionary.c (dict_needs_compaction): Rename
120 dict_compacting_would_shrink(). Update all callers.
121 (dict_compacting_would_change) New function.
123 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
125 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
126 inverted return value (!).
128 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
130 Continue reforming procedure execution.
132 * procedure.c: Search and replace "vfm" by "proc". Notably:
133 (static var vfm_source) Rename proc_source. Update all
135 (static var vfm_sink) Rename proc_sink. Update all references.
137 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
139 Continue reforming procedure execution. In this phase, remove
140 PROCESS IF, which was deprecated anyway and can be easily
141 simulated with TEMPORARY followed by SELECT IF.
143 * procedure.c: (open_active_file) Don't call
144 add_process_if_trns().
145 (discard_variables) Get rid of redundant call to
146 proc_cancel_all_transformations().
147 (add_process_if_trns) Removed.
148 (process_if_trns_proc) Removed.
149 (process_if_trns_free) Removed.
151 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
153 Continue reforming procedure execution. In this phase, add
154 `const' to the case passed to procedure()'s callback.
156 Updated all users of procedure() as well.
158 * procedure.c: (struct write_case_data) Add "const" to ccase
159 parameter for case_func member.
160 (procedure) Add "const" to ccase parameter for proc_func
162 (multipass_case_func) Make ccase parameter const.
163 (internal_procedure) Add "const" to ccase parameter for case_func
165 (split_procedure_case_func) Make ccase parameter const.
166 (multipass_split_case_func) Make ccase parameter const.
168 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
170 Continue reforming procedure execution. In this phase, get rid of
171 the output code for SPLIT FILE groups in procedure.c, which really
172 shouldn't be doing any output. Move it into the individual
173 procedures instead. This also adds some flexibility.
175 Updated many users of procedure_with_splits() and
176 multipass_procedure_with_splits() to call
177 output_split_file_values() and to deal with increased use of
180 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
181 parameter to begin_func member.
182 (procedure_with_splits) Add "const struct ccase *" parameter to
183 begin_func parameter. Make ccase parameter const in proc_func
185 (split_procedure_case_func) Don't dump split file group. Pass
187 (dump_splits) Moved to language/dictionary/split-file.c as
188 output_split_file_values().
189 (struct multipass_split_aux_data) Add "const struct ccase *"
190 parameter to split_func member.
191 (multipass_procedure_with_splits) Add "const struct ccase *"
192 parameter to split_func parameter.
193 (multipass_split_case_func) Save new SPLIT FILE case before
195 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
197 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
199 Continue reforming procedure execution. Change
200 internal_procedure() so that it calls open_active_file() and
201 close_active_file(), which isolates most of the actual procedure
204 * procedure.c: (struct write_case_data) Rename `proc_func' member
205 to `case_func' and update all references.
206 (procedure) Rewrite as one-line wrapper around
207 internal_procedure().
208 (struct multipass_aux_data) New.
209 (multipass_callback) Renamed multipass_case_func(). Use struct
210 multipass_aux_data as auxiliary data.
211 (multipass_end_func) New function.
212 (multipass_procedure) Rewrite as wrapper for internal_procedure()
213 that uses multipass_case_func, multipass_end_func.
214 (internal_procedure) Add `end_func' argument. Move optimization
215 of trivial case in here. Move call to open_active_file() and
216 close_active_file() in here. Now assert that vfm_source is
218 (procedure_with_splits_callback) Rename
219 split_procedure_case_func().
220 (split_procedure_end_func) New function.
221 (multipass_split_callback) Rename multipass_split_case_func.
222 (multipass_split_end_func) New function.
223 (discard_variables) No need to test for nonnull vfm_source.
225 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
227 Continue reforming procedure execution. Get rid of unused member.
229 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
231 (write_case) Don't increment cases_analyzed.
233 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
235 Continue reforming procedure execution. In this phase, move
236 procedure.c and procedure.h from src to src/data. Update
237 makefiles and #includes accordingly.
239 * procedure.c: Moved here from src/.
241 * procedure.h: Moved here from src/.
243 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
245 Continue reforming procedure execution. In this phase, get rid of
246 many global variables, consolidating procedure execution in
247 procedure.c. Encapsulate transformations in new "struct
248 trns_chain". Also, change implementation of N OF CASES, FILTER,
249 and PROCESS IF from special cases to transformations.
251 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
254 * dictionary.c: (global variable default_dict) Move to
257 * variable.h: (TRNS_*) Move to transformations.h.
258 (struct transformation) Move to transformations.c.
260 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
262 * sys-file-reader.c: Fixed invalid read problems.
264 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
266 * storage-stream.c: Add missing function comments.
268 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
270 Continue reforming procedure execution. In this phase, add some
271 new, needed functionality to storage-stream.
273 * storage-stream.c: (storage_source_decapsulate) New function.
275 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
277 * variable.c (width_to_bytes): Declarations must precede
278 statements for C90 compliance.
280 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
282 * data-out.c, data-in.c, variable.c, variable.h: New functions
283 copy_mangle and copy_demangle for reading/writing cases; emulates the
284 way SPSS deals with strings > 255 bytes.
286 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
287 subtype 14 needed for strings longer than 255 bytes.
289 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
290 instead of literal values. Also fixed some constness issues.
292 * format.h: Constness
294 * sfm-private.h: Renamed the case_size identifier, since I discovered
295 that SPSS's respect for this variable is very nominal.
297 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
299 Change case limit type from int to size_t.
301 * dictionary.c: (struct dictionary) Change type of case_limit
303 (dict_get_case_limit) Change return type.
304 (dict_set_case_limit) Change parameter type.
306 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
308 * variable.h: (struct variable) Rename `reinit' member as `leave'
309 and invert sense. Fix up all references.
311 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
313 Continue reforming procedure execution. In this phase, break
314 procedure.c into multiple files.
316 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
318 * case-sink.c: New file.
320 * case-sink.h: New file.
322 * case-source.c: New file.
324 * case-source.h: New file.
326 * storage-stream.c: New file.
328 * storage-stream.h: New file.
330 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
332 * variable.h: (struct variable) Remove `init' member and all
333 references to it from other files. It was initialized in several
334 places, but nothing really ever used it for anything worthwhile.
335 Thanks to Jason Stover for pointing out how confusing this
338 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
340 Continue reforming error message support. In this phase, get rid
341 of message "titles" and put the message text in `struct error'.
342 Now `struct error' encapsulates a message more properly.
344 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
345 Format message ourselves.
347 * data-in.c: (vdls_error) Ditto.
349 * por-file-reader.c: (error) Ditto.
351 * sys-file-reader.c: (corrupt_msg) Ditto.
353 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
355 GNU standards require "file name" instead of "filename" in
356 documentation. It's nice for our code to follow the convention
359 * casefile.c: (struct casefile) Rename `filename' member to
360 `file_name'. Updated all references.
362 * file-name.c: [!unix] (struct file_identity) Rename
363 normalized_filename member to normalized_file_name. Updated all
366 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
368 We don't really support anything but Unix-like environments well,
369 so we might as well de-obfuscate by writing directory and path
370 separators explicitly.
372 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
374 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
375 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
377 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
380 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
382 GNU standards require "file name" instead of "filename" in
383 documentation. It's nice for our code to follow the convention
386 * filename.c: Rename to file-name.c.
388 * filename.h: Rename to file-name.h. Update all inclusions.
389 Update header guards.
391 * automake.mk: Update file names.
393 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
395 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
397 (fn_basename) Removed (dead code).
398 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
399 (fn_special_p) Renamed fn_is_special(), all references updated.
400 (fn_exists_p) Renamed fn_exists(), all references updated.
402 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
404 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
405 Also, now it only tilde-expands file names, not paths.
406 (fn_search_path) Tilde-expand one directory at a time.
408 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
410 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
411 get rid of non-Unixlike version of the code, which has probably
413 (fn_prepend_dir) Removed (dead code).
415 * filename.h: (macro DIR_SEPARATOR_STRING) New.
416 (macro PATH_SEPARATOR_STRING) New.
417 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
419 Continue reforming error message support. In this phase, we get
420 rid of VM() and the other msg() support for "verbosity", replacing
421 it by a new function verbose_msg().
423 * filename.c: (fn_search_path) Use verbose_msg() instead of
426 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
428 * sfm-private.h: Get rid of #defines after #error, which makes no
431 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
433 Get rid of our own int32 type in favor of the standard int32_t
436 * sfm-private.h: (int32 macro) Don't define this anymore. Do
439 * sys-file-reader.c: Use int32_t instead of int32 throughout.
441 * sys-file-writer.c: Use int32_t instead of int32 throughout.
443 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
445 Remove ill-considered file routines that are no longer used.
447 * filename.c: (fn_open_ext) Removed.
448 (fn_close_ext) Removed.
450 * filename.h: (struct file_ext) Removed.
452 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
454 * variable.c (var_is_valid_name): Move declarations before code
457 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
459 * filename.ch (fn_interp_vars): Fixed small buglet.
461 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
463 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
464 so as to modify the string inline. Thus makeing it easier to
465 destroy the results when no longer needed.
467 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
469 * category.c (cat_stored_values_destroy): Fixed memory leak.
471 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
473 Add some missing frees. Thanks to John Darrington for reporting
476 * any-writer.c (any_writer_close): Free writer.
478 * any-reader.c (any_reader_close): Free reader.
480 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
482 * por-file-reader.c: (error) Mark as NO_RETURN.
484 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
486 * settings.c: Changed default value of scompress to true.
488 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
490 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
492 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
495 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
496 here from pref.h.orig.
498 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
500 * sys-file-reader.c: Fixed bug reading compressed files.
502 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
504 * Numerous renames. See src/ChangeLog for details.
506 * Moved files from src directory