1 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
3 * procedure.c (internal_procedure): Create sink_case with only as
4 many values as the compacted dictionary.
6 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
8 Remove "debugging" code that caused plenty of false positives and
11 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
13 * case.c: Remove all references to `this' member.
15 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
17 Fix link error noted by Jason Stover.
19 * storage-stream.c: Include <assert.h>.
21 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
23 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
24 ALL) and additional underlying system file issues.
26 Thanks to John Darrington for review.
28 First problem: var_hash points to variables not owned by the
29 sys-file-reader, which the caller may free or modify. Use an
30 array of sfm_vars instead, as done earlier (e.g. CVS version
33 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
34 members and remove all code that references it. Add vars, var_cnt
35 members. Remove fix_specials member, which was unused.
36 (struct sfm_var) Remove name member, which was unused.
37 (sfm_close_reader) Free vars member instead of var_hash.
38 (compare_var_shortnames) Removed.
39 (hash_var_shortname) Removed.
40 (sfm_open_reader) Fill out vars array.
41 (compare_var_index) Removed.
42 (sfm_read_case) Use vars instead of var_hash.
44 Second problem: we're confused about when we actually have very
45 long strings, causing us to choose incorrectly between slow path
46 and fast path in sfm_read_case.
48 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
49 have very long strings, not when we have long variable names,
50 which is an unrelated feature.
52 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
54 * variable.h: Move var_set and variable parsing declarations to
55 new header, src/language/lexer/variable-parser.h. Modified lots
56 of files to include the new header.
58 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
60 * value-labels.c (value_to_string): When there's no value label,
61 format the variable according to its print format, instead of
62 always effectively using A or F format.
64 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
66 * casefile.c (casefile_get_random_reader): Nasty hack to get around
69 * format.c: Removed tortological assertion.
71 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
73 Reform string library.
75 * file-name.c (fn_interp_vars): Change interface to take a
76 substring as input. Updated all users.
78 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
80 * format.c (measure_is_valid): Really return false when m >=
83 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
85 Implement random access to casefiles, for use in GUI.
87 * casefile.c: (struct casereader) Add `random', `file_ofs',
89 (casefile_get_random_reader) New function.
90 (read_open_file) Break part into new function
91 seek_and_fill_buffer().
92 (fill_buffer) Update buffer_ofs, file_ofs.
93 (casereader_seek) New function.
95 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
97 * settings.c: Added call to i18n{done, init}.
99 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
101 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
104 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
106 * casefile.c: Convert many uses of `int' to `bool'.
108 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
110 * transformations.c (trns_chain_destroy): Destroy chain's trns
111 member, to fix memory leak.
113 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
115 * storage-stream.c (storage_source_decapsulate): Destroy case
116 source to fix memory leak.
118 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
120 * scratch-reader.c (scratch_reader_read_case): Copy into existing
121 case passed as argument instead of initializing the argument as a
122 case. Fixes memory leak that showed up in
123 tests/command/aggregate.sh with scratch files.
125 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
127 * procedure.c (proc_done): Destroy default_dict, to fix memory
130 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
132 Simplify procedure_with_splits().
134 * procedure.c (struct split_aux_data): Removed case_count member.
135 (procedure_with_splits) Don't initialize case_count.
136 (split_procedure_case_func) Check whether prev_case is null
137 instead of case_count.
138 (split_procedure_end_func) Ditto.
140 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
142 * case.c (case_move): Do nothing if dst and src are the same
144 (case_try_create) Merge two similar cases.
145 (case_copy) Unshare only if data must be actually copied.
147 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
149 * data-in.c data-out.c dictionary.c sys-file-reader.c
150 sys-file-writer.c variable.c variable.h: Reworked very long string
151 support for better encapsulation.
153 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
155 * value-labels.c (val_labs_can_set_width): New function.
156 (val_labs_set_width) Clear labels if increasing width to long
158 (val_labs_destroy) Remove unneeded test for null.
160 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
162 * value-labels.h: Remove unneeded dependency on variable.h.
164 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
166 Get rid of `char *c' member in union value, for cleanliness.
168 * value.h: (union value) Remove `c' member.
170 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
172 Make dictionary compacting functions a little more general.
174 * sys-file-writer.c (sfm_open_writer): Use
175 dict_compacting_would_change().
176 (does_dict_need_translation) Removed.
178 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
180 Make dictionary compacting functions a little more general.
182 * dictionary.c (dict_needs_compaction): Rename
183 dict_compacting_would_shrink(). Update all callers.
184 (dict_compacting_would_change) New function.
186 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
188 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
189 inverted return value (!).
191 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
193 Continue reforming procedure execution.
195 * procedure.c: Search and replace "vfm" by "proc". Notably:
196 (static var vfm_source) Rename proc_source. Update all
198 (static var vfm_sink) Rename proc_sink. Update all references.
200 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
202 Continue reforming procedure execution. In this phase, remove
203 PROCESS IF, which was deprecated anyway and can be easily
204 simulated with TEMPORARY followed by SELECT IF.
206 * procedure.c: (open_active_file) Don't call
207 add_process_if_trns().
208 (discard_variables) Get rid of redundant call to
209 proc_cancel_all_transformations().
210 (add_process_if_trns) Removed.
211 (process_if_trns_proc) Removed.
212 (process_if_trns_free) Removed.
214 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
216 Continue reforming procedure execution. In this phase, add
217 `const' to the case passed to procedure()'s callback.
219 Updated all users of procedure() as well.
221 * procedure.c: (struct write_case_data) Add "const" to ccase
222 parameter for case_func member.
223 (procedure) Add "const" to ccase parameter for proc_func
225 (multipass_case_func) Make ccase parameter const.
226 (internal_procedure) Add "const" to ccase parameter for case_func
228 (split_procedure_case_func) Make ccase parameter const.
229 (multipass_split_case_func) Make ccase parameter const.
231 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
233 Continue reforming procedure execution. In this phase, get rid of
234 the output code for SPLIT FILE groups in procedure.c, which really
235 shouldn't be doing any output. Move it into the individual
236 procedures instead. This also adds some flexibility.
238 Updated many users of procedure_with_splits() and
239 multipass_procedure_with_splits() to call
240 output_split_file_values() and to deal with increased use of
243 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
244 parameter to begin_func member.
245 (procedure_with_splits) Add "const struct ccase *" parameter to
246 begin_func parameter. Make ccase parameter const in proc_func
248 (split_procedure_case_func) Don't dump split file group. Pass
250 (dump_splits) Moved to language/dictionary/split-file.c as
251 output_split_file_values().
252 (struct multipass_split_aux_data) Add "const struct ccase *"
253 parameter to split_func member.
254 (multipass_procedure_with_splits) Add "const struct ccase *"
255 parameter to split_func parameter.
256 (multipass_split_case_func) Save new SPLIT FILE case before
258 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
260 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
262 Continue reforming procedure execution. Change
263 internal_procedure() so that it calls open_active_file() and
264 close_active_file(), which isolates most of the actual procedure
267 * procedure.c: (struct write_case_data) Rename `proc_func' member
268 to `case_func' and update all references.
269 (procedure) Rewrite as one-line wrapper around
270 internal_procedure().
271 (struct multipass_aux_data) New.
272 (multipass_callback) Renamed multipass_case_func(). Use struct
273 multipass_aux_data as auxiliary data.
274 (multipass_end_func) New function.
275 (multipass_procedure) Rewrite as wrapper for internal_procedure()
276 that uses multipass_case_func, multipass_end_func.
277 (internal_procedure) Add `end_func' argument. Move optimization
278 of trivial case in here. Move call to open_active_file() and
279 close_active_file() in here. Now assert that vfm_source is
281 (procedure_with_splits_callback) Rename
282 split_procedure_case_func().
283 (split_procedure_end_func) New function.
284 (multipass_split_callback) Rename multipass_split_case_func.
285 (multipass_split_end_func) New function.
286 (discard_variables) No need to test for nonnull vfm_source.
288 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
290 Continue reforming procedure execution. Get rid of unused member.
292 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
294 (write_case) Don't increment cases_analyzed.
296 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
298 Continue reforming procedure execution. In this phase, move
299 procedure.c and procedure.h from src to src/data. Update
300 makefiles and #includes accordingly.
302 * procedure.c: Moved here from src/.
304 * procedure.h: Moved here from src/.
306 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
308 Continue reforming procedure execution. In this phase, get rid of
309 many global variables, consolidating procedure execution in
310 procedure.c. Encapsulate transformations in new "struct
311 trns_chain". Also, change implementation of N OF CASES, FILTER,
312 and PROCESS IF from special cases to transformations.
314 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
317 * dictionary.c: (global variable default_dict) Move to
320 * variable.h: (TRNS_*) Move to transformations.h.
321 (struct transformation) Move to transformations.c.
323 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
325 * sys-file-reader.c: Fixed invalid read problems.
327 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
329 * storage-stream.c: Add missing function comments.
331 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
333 Continue reforming procedure execution. In this phase, add some
334 new, needed functionality to storage-stream.
336 * storage-stream.c: (storage_source_decapsulate) New function.
338 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
340 * variable.c (width_to_bytes): Declarations must precede
341 statements for C90 compliance.
343 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
345 * data-out.c, data-in.c, variable.c, variable.h: New functions
346 copy_mangle and copy_demangle for reading/writing cases; emulates the
347 way SPSS deals with strings > 255 bytes.
349 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
350 subtype 14 needed for strings longer than 255 bytes.
352 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
353 instead of literal values. Also fixed some constness issues.
355 * format.h: Constness
357 * sfm-private.h: Renamed the case_size identifier, since I discovered
358 that SPSS's respect for this variable is very nominal.
360 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
362 Change case limit type from int to size_t.
364 * dictionary.c: (struct dictionary) Change type of case_limit
366 (dict_get_case_limit) Change return type.
367 (dict_set_case_limit) Change parameter type.
369 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
371 * variable.h: (struct variable) Rename `reinit' member as `leave'
372 and invert sense. Fix up all references.
374 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
376 Continue reforming procedure execution. In this phase, break
377 procedure.c into multiple files.
379 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
381 * case-sink.c: New file.
383 * case-sink.h: New file.
385 * case-source.c: New file.
387 * case-source.h: New file.
389 * storage-stream.c: New file.
391 * storage-stream.h: New file.
393 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
395 * variable.h: (struct variable) Remove `init' member and all
396 references to it from other files. It was initialized in several
397 places, but nothing really ever used it for anything worthwhile.
398 Thanks to Jason Stover for pointing out how confusing this
401 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
403 Continue reforming error message support. In this phase, get rid
404 of message "titles" and put the message text in `struct error'.
405 Now `struct error' encapsulates a message more properly.
407 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
408 Format message ourselves.
410 * data-in.c: (vdls_error) Ditto.
412 * por-file-reader.c: (error) Ditto.
414 * sys-file-reader.c: (corrupt_msg) Ditto.
416 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
418 GNU standards require "file name" instead of "filename" in
419 documentation. It's nice for our code to follow the convention
422 * casefile.c: (struct casefile) Rename `filename' member to
423 `file_name'. Updated all references.
425 * file-name.c: [!unix] (struct file_identity) Rename
426 normalized_filename member to normalized_file_name. Updated all
429 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
431 We don't really support anything but Unix-like environments well,
432 so we might as well de-obfuscate by writing directory and path
433 separators explicitly.
435 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
437 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
438 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
440 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
443 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
445 GNU standards require "file name" instead of "filename" in
446 documentation. It's nice for our code to follow the convention
449 * filename.c: Rename to file-name.c.
451 * filename.h: Rename to file-name.h. Update all inclusions.
452 Update header guards.
454 * automake.mk: Update file names.
456 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
458 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
460 (fn_basename) Removed (dead code).
461 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
462 (fn_special_p) Renamed fn_is_special(), all references updated.
463 (fn_exists_p) Renamed fn_exists(), all references updated.
465 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
467 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
468 Also, now it only tilde-expands file names, not paths.
469 (fn_search_path) Tilde-expand one directory at a time.
471 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
473 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
474 get rid of non-Unixlike version of the code, which has probably
476 (fn_prepend_dir) Removed (dead code).
478 * filename.h: (macro DIR_SEPARATOR_STRING) New.
479 (macro PATH_SEPARATOR_STRING) New.
480 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
482 Continue reforming error message support. In this phase, we get
483 rid of VM() and the other msg() support for "verbosity", replacing
484 it by a new function verbose_msg().
486 * filename.c: (fn_search_path) Use verbose_msg() instead of
489 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
491 * sfm-private.h: Get rid of #defines after #error, which makes no
494 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
496 Get rid of our own int32 type in favor of the standard int32_t
499 * sfm-private.h: (int32 macro) Don't define this anymore. Do
502 * sys-file-reader.c: Use int32_t instead of int32 throughout.
504 * sys-file-writer.c: Use int32_t instead of int32 throughout.
506 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
508 Remove ill-considered file routines that are no longer used.
510 * filename.c: (fn_open_ext) Removed.
511 (fn_close_ext) Removed.
513 * filename.h: (struct file_ext) Removed.
515 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
517 * variable.c (var_is_valid_name): Move declarations before code
520 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
522 * filename.ch (fn_interp_vars): Fixed small buglet.
524 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
526 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
527 so as to modify the string inline. Thus makeing it easier to
528 destroy the results when no longer needed.
530 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
532 * category.c (cat_stored_values_destroy): Fixed memory leak.
534 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
536 Add some missing frees. Thanks to John Darrington for reporting
539 * any-writer.c (any_writer_close): Free writer.
541 * any-reader.c (any_reader_close): Free reader.
543 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
545 * por-file-reader.c: (error) Mark as NO_RETURN.
547 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
549 * settings.c: Changed default value of scompress to true.
551 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
553 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
555 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
558 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
559 here from pref.h.orig.
561 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
563 * sys-file-reader.c: Fixed bug reading compressed files.
565 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
567 * Numerous renames. See src/ChangeLog for details.
569 * Moved files from src directory