1 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
3 * output.c: (outp_read_devices) Fix message.
5 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
7 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
8 address is passed to dict_get_vars() from size_t to int to match
11 * modify-vars.c: (validate_var_modification) Ditto.
13 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
15 * dictionary.[ch] Changed cnt from size_t* to int* since that's
16 what it's called as, and on x86_64 machines they're different sizes.
18 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
20 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
22 * lexer.c: (lex_sbc_only_once) New function.
23 (lex_sbc_missing) New function.
25 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
27 * case.h: (case_str) Make it return `unsigned char'.
29 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
31 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
32 subcommands that we didn't support. Fix bug 13911. Fix bug
33 reported by Adam Pierson (COMPRESSED and other subcommands didn't
34 work on SAVE). Refactor all related code.
36 * command.def: Add XEXPORT command.
38 * dictionary.c: (dict_delete_scratch_vars) New function.
40 * get.c: (cmd_get) Fix parsing.
41 (struct save_trns) Removed.
42 (cmd_save_internal) Removed.
44 (do_write_case) Removed.
45 (save_write_case_func) Removed.
46 (save_trns_proc) Removed.
47 (save_trns_free) Removed.
48 (trim_dictionary) Removed.
49 (struct export_proc) Removed.
51 (export_write_case_func) Removed.
52 (export_proc_free) Removed.
53 (enum writer_type) New enum.
54 (enum command_type) New enum.
55 (struct any_writer) New struct.
56 (any_writer_destroy) New function.
57 (parse_write_command) New function.
58 (any_writer_write_case) New function.
59 (parse_output_proc) New function.
60 (output_proc) New function.
63 (struct output_trns) New struct.
64 (parse_output_trns) New function.
65 (output_trns_proc) New function.
66 (output_trns_free) New function.
68 (cmd_xexport) New function.
69 (parse_dict_trim) New function.
70 (struct mtf_proc) Change `by_cnt' member type to `int'.
73 * pfm-write.c: (struct pfm_writer) Add `digits' member.
74 (pfm_writer_default_options) New function.
75 (pfm_open_writer) Add `opts' argument and handle options.
76 (write_float) Write only as many digits as `digits' member says.
77 (format_trig_double) Limit base-10 precision to LDBL_DIG.
79 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
80 (struct pfm_write_options) New struct.
82 * sfm-write.c: (sfm_writer_default_options) New function.
83 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
84 `opts' argument. Implement options.
86 * sfm-write.h: (struct sfm_write_options) New struct.
88 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
89 char *' instead of `char *'.
91 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
93 * factor_stats.c: Needed <config.h> included earlier.
95 * percentiles.c: Needed to include <config.h>.
97 * val.h: Don't include "config.h".
99 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
101 Clean up treatment of missing values by moving all the code into
102 one place. All references to the missing value function were
103 updated, but only major changes are detailed below.
105 * Makefile.am: Add missing-values.c, missing-values.h to sources.
107 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
109 * dictionary.c: (dict_create_var) Initialize `miss' member with
111 (dict_clone_var) Copy `miss' member with mv_copy().
113 * get.c: (mtf_merge_dictionary) Use mv_copy().
115 * missing-values.c: New file.
117 * missing-values.h: New file.
119 * mis-val.c: Rewrite. New version implements updated semantics.
121 * pfm-read.c: (read_variables) Rewrite missing value handling.
123 * pfm-write.c: (write_variables) Rewrite missing value handling.
125 * sfm-read.c: (read_variables) Rewrite missing value handling.
127 * sfm-write.c: (write_variable) Rewrite missing value handling.
129 * sfmP.h: Include "magic.h" to get definition of
132 * sysfile-info.c: (describe_variable) Rewrite missing value
135 * val.h: Include "magic.h" to get definition of
138 * var.h: Include "missing-values.h". Drop MISSING_* enums.
139 (struct variable) Remove `miss_type', `missing'. Add `miss'.
141 * vars-atr.c: (is_num_user_missing) Removed--use
142 mv_is_num_user_missing().
143 (is_str_user_missing) Removed--use mv_is_str_user_missing().
144 (is_system_missing) Removed--use mv_is_value_system_missing().
145 (is_missing) Removed--use mv_is_value_missing().
146 (is_user_missing) Removed--use mv_is_value_user_missing().
148 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
150 Adopt use of gnulib for portability.
152 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
155 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
156 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
159 * In many source files, added an explicit inclusion of gettext.h
160 and definition of _ macro. These are no longer in pref.h because
161 it interfered with definitions in a few gnulib source files.
163 * In many source files, changed #include "bool.h" to #include
164 <stdbool.h>, which is provided by gnulib.
166 * alloc.c: Removed functions defined in gnulib:
171 (out_of_memory) Redefined as wrapper for xalloc_die().
173 * alloc.h: Replace prototypes by #include "xalloc.h".
175 * casefile.c: Use full_read() and full_write() from gnulib instead
176 of our home-grown versions.
178 (full_write) Removed.
180 * getline.c: Renamed getl.c.
182 * getline.h: Renamed getl.h, updated all references.
184 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
187 * glob.c: Just #include <time.h> instead of the crazy rigmarole
189 (init_glob) Call set_program_name() to initial gnulib progname
192 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
194 * permissions.c: Use "stat-macros.h" from gnulib.
196 * postscript.c: Just #include <time.h> instead of the crazy
197 rigmarole here before.
199 * q2c.c: (main) Make generated code #include "gettext.h".
201 * str.h: Get rid of most explicit declarations of standard
202 functions, in favor of including gnulib header files.
204 * expressions/evaluate.c: Ditto.
206 * expressions/operations.h.pl: Make generated code #include
207 <stdbool.h>, not "bool.h".
209 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
211 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
214 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
216 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
217 null pointer to printf for %.*s.
219 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
221 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
224 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
226 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
228 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
230 * postscript.c: (postopen) Cast `char' to `unsigned char' before
231 passing to isspace().
233 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
235 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
237 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
239 * histogram.c: Include <config.h>.
241 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
243 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
245 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
247 * format.c: (check_common_specifier) Fix msg() bug found by
249 (check_output_specifier) Ditto.
251 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
253 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
256 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
258 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
259 avoid "unused variable" warning.
261 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
263 * command.c: (find_word) Cast `char' to `unsigned char' before
264 passing to isspace().
266 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
268 * case.c: (case_compare) Implement as delegating to
269 case_compare_2dict().
271 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
273 * algorithm.c: Inclusion of <alloca.h> is unneeded.
275 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
277 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
278 -ansi changes the behavior of header files significantly. It
279 causes __STRICT_ANSI__ to be defined, and some headers interpret
280 that as cause to e.g. not use `long long' or __attribute__. The
281 former example is bad when off_t is supposed to be `long long',
282 and the latter prevents -Wformat from working.
284 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
286 Get rid of dependency on libgmp by writing our own routine for
287 floating-point base conversion.
289 * pfm-write.c: (write_float) Rewrote.
291 (pow30_nonnegative) New function.
292 (pow30) New function.
293 (trig_to_char) New function.
294 (format_trig_digits) New function.
295 (recurse_format_trig_int) New function.
296 (format_trig_int) New function.
297 (should_round_up) New function.
298 (try_round_up) New function.
299 (format_trig_double) New function.
301 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
303 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
306 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
308 * pfm-read.c: (read_version_data) Read and ignore author field.
310 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
312 * get.c: (mtf_processing) Don't assume that
313 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
314 returns a negative, zero, or positive result. Fixes MATCH FILES
315 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
317 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
319 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
320 preprocessor test for sys/types.h was accidentally inverted. This
323 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
325 * get.c: (cmd_match_files) Fix memory leak on `by' and on
328 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
331 * vfm.c: (close_active_file) Remove unnecessary test.
333 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
335 Fix NDEBUG compile errors.
337 * hash.h: Needed explicit #include <assert.h>.
339 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
342 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
344 Implement embedding for PostScript driver. Fixes bug 12970.
346 * ascii.c: Fix compiler warnings.
350 * chart.h: Add `file' member.
352 * output.h: (struct outp_class) initialise_chart, finalise_chart
353 should take outp_driver *, not outp_class *. Update all
356 * plot-chart.c: (chart_create) Fix segfault when there are no
357 output drivers at all.
358 (chart_submit) Call d->class->finalise_chart.
360 * postscript.c: (ps_open_page) Set cp_y to 0.
361 (ps_submit) New function.
362 (ps_chart_initialise) Implement.
363 (ps_chart_finalise) Implement.
364 (static var postscript_class) Add ps_submit.
365 (static var epsf_class) Add ps_submit.
368 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
370 Did some more work on bug 12859 and then realized that a *good*
371 solution would require some fundamental restructuring. For now,
372 I'm marking REPEATING DATA unimplemented, and then we can revisit
375 * command.def: Make REPEATING DATA unimplemented.
377 * data-list.c: (cmd_repeating_data) Assume inline file is 80
379 (realize_value) Revert previous changes; no longer needed.
382 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
383 file_loc, to avoid bad references later.
387 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
389 Make some code tolerant of reentry. Should not be needed if other
390 code is correct but it is good to be generally tolerant.
392 * error.c: (err_hcf) Set file_loc to null after free().
394 * output.c: (outp_done) Similar changes.
396 * str.c: (ds_destroy) Ditto.
398 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
400 Continue work on bug 12859, plus some code cleanup.
402 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
403 boolean variables. Don't try to compute starts_end, cont_end for
404 inline file. Calculate length only after parsing variable
405 specifications. Add proper transformation to list.
406 (realize_value) If the rpd_num_or_var has no value, return new
407 DEFAULT_MEMBER argument (for use with inline file).
408 (repeating_data_trns_proc) Pass default values.
410 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
411 open, and only if we actually started reading data.
413 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
417 * output.c: (outp_read_devices) Fix message.
419 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
421 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
422 of the sort algorithm from the parser for the SORT command.
424 * rank.q: Added the parser for the RANK command.
426 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
430 * sort.c: (sort_parse_criteria) Only set *saw_direction if
431 saw_direction is non-null. Thanks to John Darrington for
434 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
436 * get.c: (mtf_processing) Handle case of a lookup table as the
437 active file. Thanks to John Darrington for reporting this bug.
439 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
441 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
442 POSIX calloc function.
444 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
445 reflect new signature.
447 * sfm-read.c: Now much more robust in the face of badly formed
450 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
452 *sfm-read.c: Fixed some bugs regarding long string continuation
453 records, which the previous fix uncovered.
455 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
457 * sfm-read.c, sfmP.h: Allow reading of system files when the
458 case_size value in the header is -1. Also changed some Errors to
459 Warnings when reading system files.
461 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
463 * data-list.c: (data_list_trns_free) Don't free the argument
464 because cancel_transformations() will do that itself.
465 (data_list_source_destroy) Destroy the argument to
466 data_list_trns_free(), because it no longer does so itself.
468 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
470 * data-out.c: (format_and_round) Don't output leading `-' if value
473 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
477 * som.c: (output_encodings) If some cell in the table won't fit
478 with the horizontal or vertical headers, cancel those headers.
480 * som.h: (struct som_table_class) Add fits_width, fits_length,
483 * tab.c: (tabi_fits_width) New function.
484 (tabi_fits_length) New function.
485 (tabi_set_headers) New function.
486 (global var tab_table_class) Add the new functions as appropriate
489 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
491 Fix rest of bug 13054.
493 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
494 DATETIME, TIME system/portable file values.
496 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
498 * data-list.c: (parse_free) Use make_input_format().
500 * data-out.c: (num_to_string) Use make_output_format().
502 * dictionary.c: (dict_create_var) Ditto.
504 * format.c: (global var f8_2) New var.
505 (make_input_format) New function.
506 (make_output_format) New function.
508 * get.c: (cmd_match_files) Use make_output_format().
510 * list.q: (cmd_list) Ditto.
512 * matrix-data.c: Ditto.
514 * sfm-read.c: (parse_format_spec) Check output specifier
517 * tab.c: (tab_float) Use make_output_format().
519 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
521 Fix more of bug 13054.
523 * format.def: FMT_A should allow 255-character output. FMT_AHEX
524 should allow 510-character input and output.
526 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
527 (convert_E) Handle non-finite values.
529 (format_and_round) New function.
530 (convert_infinite) New function used by try_F() and convert_E().
532 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
534 Regularize string and buffer function names so that they make some
537 * str.c: (mm_reverse) Rename buf_reverse(). Update all
539 (mm_find_reverse) Rename buf_find_reverse(). Update all
541 (mm_case_compare) Rename buf_compare_case(). Update all
543 (st_compare_pad) Rename buf_compare_rpad(). Update all
545 (str_compare_rpad) New function.
546 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
548 (buf_copy_str_lpad) New function.
549 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
551 (st_pad_copy) Rename str_copy_rpad(). Update all references.
552 (st_trim_copy) Rename str_copy_trunc(). Update all references.
553 (st_uppercase) Renamed str_uppercase(). Update all references.
555 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
557 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
560 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
562 * data-in.c: (data_in) Add assertion to check input specifier.
564 * data-out.c: (data_out) Add assertion to check output specifier.
566 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
568 Start to fix bug 13054.
570 * format.c: (check_input_specifier) Improve error message.
571 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
572 valid decimal places.
573 (check_output_specifier) Ditto (but different criteria).
574 (convert_fmt_ItoO) Assert valid input and output specifiers.
575 Also, if input specifier has *any* decimal places, make the output
576 specifier 1 place wider.
578 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
580 * sysfile-info.c: Fixed bug [# 13024 ]
582 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
584 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
585 actually implement it.
587 * command.c: (FILE_TYPE_okay) Always return 1.
589 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
591 * file-type.c: Add prototypes to get rid of warnings.
593 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
595 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
596 more ISO/IEC 9899:1990 conformance issues.
598 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
600 Fix bug 12948. See also new test in
601 tests/bugs/match-file-scratch.sh.
603 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
604 that deletes scratch variables that someone else might be using,
605 and because we can't reassign our sources' value indexes.
606 Instead, simply don't copy scratch variables into the master
609 * dictionary.c: (dict_compact_values) Delete variables from the
610 dictionary passed in, not from default_dict (!).
612 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
614 Improve hash.c comments, error-checking.
616 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
617 (hsh_create) size == 0 should *not* return NULL! Set
619 (hsh_clear) Set hash_ordered.
620 (locate_matching_entry) Check hash_ordered.
621 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
622 (hsh_data) Set hash_ordered. Add const-ness to return value and
626 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
628 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
630 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
632 * copyleft.c: Updated copyright date.
634 * Makefile.am: Removed erroneous explicit "-lplot"
636 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
638 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
640 * command.c command.def: Added description string for unimplemented commands.
642 * oneway.q: Sorted the hash tables before shipping out the results. Closes
645 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
649 * data-list.c: (parse_fixed) Use lex_end_of_command().
651 (cmd_repeating_data) Set cont_end.num in right situations.
652 (parse_repeating_data) Remove redundant test.
654 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
656 Partial fix for bug 12859.
658 * data-list.c: (cmd_data_list) Add transformation properly in
659 vfm_source == NULL case.
661 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
663 * lexer.c: (lex_error) Improve error messages.
665 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
667 * get.c: (cmd_match_files) Check token type before trying to match
668 tokid. Fixes bug 12923.
670 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
672 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
675 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
677 * expressions/generate.pl: (get_token) Make use of /g
678 backward-compatible with Perl 5.6.1.
680 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
682 * var-display.c: (cmd_variable_alignment) Fix memory leak.
683 (cmd_variable_level) Ditto.
685 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
687 Hash table had buggy deletion function. The fix required changing
688 other functions to do probing in the required order.
690 * hash.c: (locate_matching_entry) Rewrite and change interface.
691 (hsh_rehash) Rewrite to use locate_matching_entry().
694 (hsh_delete) Ditto. Also, fix stupid bugs.
696 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
698 * dictionary.c: (dict_clone) Properly copy vectors.
700 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
702 New implementation of long variable names. Each variable has a
703 "normal" name, which may be up to 64 bytes long and which is used
704 for all normal operations. Variables may have a "short" name,
705 which is limited to 8 bytes and used only for system and portable
706 file input and output.
708 Make tokid case-preserving. Update most uses of tokid to treat it
711 Update many commands to deal with long variable names.
713 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
715 * command.c: (cmd_parse) Ditto.
716 (match_strings) Use toupper() before comparing characters.
717 (conflicting_3char_prefixes) Use mm_case_compare() instead of
719 (cmd_match_words) Ditto.
721 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
724 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
725 Use st_trim_copy() instead of strcpy().
727 * data-in.c: (parse_enum) Use mm_case_compare() instead of
730 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
732 (parse_free) Use st_trim_copy() instead of strcpy().
734 * descript.c: (struct dsc_var) Change z_name[] to fit long var
736 (try_name) Use strcasecmp() instead of strcmp().
737 (generate_z_varname) Use st_trim_copy() instead of strcpy().
738 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
741 * dictionary.c: (struct dictionary) Removed `long_name_tab'
743 (compare_long_names) Removed.
744 (hash_long_name) Removed.
745 (dict_create) Don't initialize `long_name_tab' member.
746 (dict_clone) Copy short names into new dictionary.
747 (dict_clear) Don't clear `long_name_tab' member.
748 (dict_get_varname_block) Removed.
749 (dict_add_longvar_entry) Removed.
751 (dict_destroy) Don't destroy `long_name_tab' member.
752 (dict_create_var_from_short) Removed.
753 (dict_create_var_x) Removed.
754 (dict_create_var) Get rid of longname handling.
756 (dict_clone_var) Get rid of longname parameter and longname
758 (dict_lookup_var) Get rid of longname handling.
759 (dict_reorder_var) New function.
760 (dict_rename_var) Clear short name.
761 (dict_rename_vars) Get rid of longname handling. Clear short
763 (dict_create_vector) Support long vector names.
764 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
765 (quasi_base27) Removed.
766 (make_short_name) Removed.
767 (compare_strings) New function.
768 (hash_string) New function.
769 (dict_assign_short_names) New function.
771 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
773 (get_handle_for_filename) Support long handle names.
775 * file-type.c: (struct col_spec) Make `name' fit long var names.
776 (cmd_file_type) Use strcasecmp() instead of strcmp().
778 * flip.c: (make_new_var) Rewrite.
779 (flip_sink_write) Use st_trim_copy() instead of strncpy().
781 * format.c: (parse_format_specifier_name) Use mm_case_compare()
784 * get.c: (cmd_save_internal) Rephrase.
785 (rename_variables) Drop test for identical variable name.
786 (struct mtf_proc) Change `first', `last' to fit long var name.
788 * hash.c: (hsh_hash_case_string) New function for case-insensitive
791 * lexer.c: (restore_token) Use st_trim_copy() instead of
793 (lex_get) Don't uppercase string when copying into tokid.
794 (lex_put_back_id) Use st_trim_copy() instead of
797 * list.q: (determine_layout) Consider length of variable names in
798 choosing vertical layout.
800 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
802 (string_to_content_type) Ditto.
804 * modify-vars.c: (compare_variables_given_ordering) Ditto.
805 (struct var_renaming) Change `new_name' to fit long var name.
806 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
809 * pfm-read.c: (read_variables) Disallow system variables in system
811 (write_variables) Call dict_assign_short_names() and use
812 short_name[] members.
814 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
817 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
818 map. Reorder variables into same order as long variable map.
819 (read_variables) Set short name.
821 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
822 (write_variable) Use st_bare_pad_copy().
823 (write_longvar_table) Rewrite.
825 * str.c: (mm_case_compare) New function.
827 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
830 * t-test.q: (tts_custom_groups) Remove redundant test.
831 (tts_custom_pairs) Ditto.
833 * var.h: (struct variable) Change `name' to fit long var names.
834 Remove `longname'. Add `short_name' member. Reorder some
836 (struct name_table_entry) Removed.
837 (struct vector) Change `name' to fit long vector names.
839 * vars-atr.c: (var_is_valid_name) Allow long var names.
840 (compare_var_names) Use strcasecmp() instead of strcmp().
841 (compare_var_ptr_names) Ditto.
842 (hash_var_name) Use hsh_hash_case_string().
843 (hash_var_ptr_name) Ditto.
844 (var_set_short_name) New function.
845 (var_clear_short_name) New function.
846 (var_set_short_name_suffix) New function.
848 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
849 Use strcasecmp() instead of strcmp().
850 (struct array_var_set) Removed `longname_tab'.
851 (array_var_set_lookup_var_idx) Drop longname_tab support.
852 (array_var_set_destroy) Don't destroy `longname_tab'.
853 (var_set_create_from_array) Don't create `longname_tab'.
855 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
858 * expressions/parse.c: (word_matches) Use mm_case_compare()
860 (compare_strings) New function.
861 (lookup_function) Use compare_strings() instead of strcmp().
863 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
865 * algorithm.c: (move_element) New function.
867 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
869 * aggregate.c: (parse_aggregate_functions) Always initialize
872 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
874 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
876 * dictionary.c: (dict_clone) Ditto.
877 (dict_clone_var_assert) New function.
879 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
881 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
883 * error.c: Added a string for the compiler version to the
884 request_bug_report_and_abort function.
886 * groff_font.c, font.c: Removed manpage(1) style references from
887 comments, because RMS frowns upon them.
889 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
891 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
893 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
895 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
898 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
900 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
901 which should be LONG_NAME_LEN
903 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
905 * command.def echo.c: Added the ECHO command.
907 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
909 Finish fixing MATCH FILES (bug 11677).
911 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
912 keep_variables(), rename_variables().
913 (drop_variables) New function.
914 (keep_variables) New function.
915 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
916 (cmd_match_files) Deal with in_var. Use drop_variables(),
917 keep_variables(). When IN is specified, require BY. Set master
918 variables after master dictionary is complete. Add IN variables
919 after master dictionary is complete.
920 (mtf_free_file) Free `in_name'.
921 (mtf_delete_file_in_place) Set in_var value to 0.
922 (mtf_read_nonactive_records) Rephrase.
923 (mtf_processing) Support IN. Rephrase. Fix bugs.
924 (mtf_merge_dictionary) Don't set master variables; we do that
926 (get_master) Don't insist that there's a master variable.
928 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
930 Kluge to make some variable renaming sort of work.
933 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
935 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
937 Add functions for comparing sets of variables between cases.
940 * case.c: (case_compare) New function.
941 (case_compare_2dict) New function.
943 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
945 (cmd_aggregate) Nullify break_case. Don't call
946 initialize_aggregate_info().
947 (agr_destroy) Destroy break_case.
948 (aggregate_single_case) Rewrite. Use case_compare().
949 (dump_aggregate_info) Copy from break_case into output.
950 (initialize_aggregate_info) Copy break_case from input.
952 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
954 * vfm.c: (equal_splits) Use case_compare().
956 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
958 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
960 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
962 Start work on fixing MATCH FILES.
964 * get.c: (enum operation) Remove OP_MATCH.
965 (trim_dictionary) Change return value to bool. Don't support
967 (struct mtf_file) Remove `first', `last' members.
968 (struct mtf_proc) Add `first', `last' members. Change mtf_case
969 from `struct ccase *' to `struct ccase'. Remove `by' member.
970 (cmd_match_files) Essentially rewrite.
971 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
972 (mtf_read_nonactive_records) mtf_ parameter is not unused.
973 (mtf_processing) Ditto. Also rephrase some code.
974 (mtf_merge_dictionary) Rewrite for easy comprehension.
976 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
978 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
981 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
983 Thu Apr 14 2005 John Darrington
985 * var-display.c: New file.
987 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
988 display_width, measure and alignment parameters to variables.
990 * aggregate.c command.def compute.c count.c data-list.c descript.c
991 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
992 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
993 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
994 vars-prs.c vector.c :
995 - Replaced literal constants representing maximum variable name
996 length with macro definitions.
997 - Added support for long variable names.
998 - Changed lexer such that it no longer makes tokens upper
999 case, but relies upon case insensitive behaviour of commands.
1001 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
1003 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
1004 fails, don't dereference the resulting null pointer (bug 12427).
1005 Also, fix double free error.
1007 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
1009 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
1010 (accumulate_aggregate_info) Set int1 to 1 for SUM.
1011 (dump_aggregate_info) Only make SUM non-missing if there was at
1014 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
1016 * aggregate.c: (dump_aggregate_info) Properly test whether the
1017 destination variable is numeric, when making the result
1018 system-missing for columnwise missing values.
1020 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
1022 * misc.h: Remove GCC specializations.
1024 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
1026 Make sort stable (bug 12313).
1028 * sort.c: Don't need to include some headers anymore.
1029 (static var min_buffers) New variable.
1030 (static var max_buffers) New variable.
1031 (static var allow_internal_sort) New variable.
1032 (cmd_sort_cases) Add test mode.
1033 (sort_execute) Rephrase.
1034 (do_internal_sort) Don't try internal sorting if
1035 allow_internal_sort is set.
1036 (struct external_sort) Renamed `initial_runs' to `runs' and
1037 updated all references.
1038 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
1039 (macro MIN_BUFFER_SIZE_BYTES) Removed.
1040 (macro MIN_BUFFER_SIZE_RECS) Removed.
1041 (compare_initial_runs) Removed.
1042 (struct record_run) Add member `idx'.
1043 (write_initial_runs) Pass increasing values to process_case() as
1045 (process_case) Add `idx' parameter and use it to initialize new
1047 (allocate_cases) Limit allocated buffers to max_buffers.
1048 (compare_record_run) Use new `idx' member for last resort
1049 comparison, for stability.
1050 (end_run) Call casefile_sleep() on irs->casefile, to prevent
1051 running out of file descriptors.
1052 (struct merge_state) Removed.
1053 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
1054 unless we have fewer runs left. Always merge consecutive runs,
1055 for stability. Return the final run.
1057 (choose_merge) New function.
1058 (merge_once) Rewritten.
1060 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
1062 * cmdline.c: (static var testing_mode) Move into
1063 parse_command_line().
1065 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
1067 * algorithm.c: (remove_range) New function.
1068 (remove_element) New function.
1070 * dictionary.c: (dict_delete_var) Use remove_element().
1072 * flip.c: (cmd_flip) Ditto.
1074 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
1076 * file-handle.q: (struct file_handle) `open_mode' should not be
1079 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
1081 First phase of making SORT CASES stable (bug 12313).
1083 * sort.c: (struct indexed_case) New structure.
1084 (do_internal_sort) Rewrite to make internal sorting stable.
1085 (compare_case_dblptrs) Removed.
1086 (compare_indexed_cases) New function.
1088 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
1092 * casefile.c: (casereader_read_xfer_assert) New function.
1094 * dictionary.c: (dict_compact_case) New function.
1096 * flip.c: (struct flip_pgm) New member idx_to_fv.
1097 (cmd_flip) Initialize idx_to_fv member.
1098 (destroy_flip_pgm) Free idx_to_fv member.
1099 (flip_sink_write) Use struct flip_pgm member instead of case_sink
1101 (flip_sink_write) Ditto.
1103 * vfm.c: (write_case) Use dict_compact_case() instead of
1105 (compact_case) Removed.
1106 (storage_source_create) Removed `dict' parameter. All references
1109 * vfm.h: (struct case_source) Removed `value_cnt' member. All
1111 (struct case_sink) Removed `dict', `idx_to_fv' members. All
1114 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
1116 More AGGREGATE fixes.
1118 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
1119 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
1121 (initialize_aggregate_info) Fix initialization for MIN, MAX for
1124 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
1126 Start work on testing and debugging AGGREGATE.
1128 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
1129 of a bit-map. Require proper subcommand ordering. Make OUTFILE
1130 subcommand mandatory.
1131 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
1132 functions' arguments are in the correct order and swap them if
1134 (accumulate_aggregate_info) Make SUM include weights. Add various
1136 (dump_aggregate_info) Add various string functions.
1137 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
1139 * sort.c: (sort_parse_criteria) Add parameter for returning
1140 whether any directions were specified. All callers updated.
1142 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
1144 * t-test.q: Fixed erroneous logic in compare_group_binary.
1146 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
1148 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
1149 keywords (bug 11628).
1151 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
1153 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
1154 called *before* close_active_file().
1156 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
1158 * file-handle.q: (struct file_handle) Change open_mode from
1159 character pointer to 3-char array, for safety. Updated all
1162 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
1164 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
1167 * pfm-read.c: (read_header) Improve error message for many cases
1168 in which the input is not actually a portable file.
1170 * file-handle.q: (fh_open) When we give an error message, actually
1173 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
1175 * format.c: (check_common_specifier) New function for checks
1176 common to check_input_specifier() and check_output_specifier().
1177 (check_input_specifier) Use check_common_specifier().
1178 (check_output_specifier) Use check_common_specifier().
1179 (check_string_specifier) Removed.
1180 (check_specifier_type) New function.
1181 (check_specifier_width) New function.
1182 (get_format_var_width) Fix bug.
1184 * formats.c: (internal_cmd_formats) Only accept numeric variables.
1186 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
1187 update all references. Make case-insensitive.
1189 * pfm-read.c: Essentially rewrite the whole file. Now much
1192 * print.c: (check_string_width) New function.
1193 (fixed_parse_compatible) Use check_string_width(),
1194 check_specifier_type().
1195 (dump_fmt_list) Ditto.
1197 * str.c: (st_trim_copy) New function.
1198 (st_uppercase) New function.
1200 * vars-atr.c: (var_is_valid_name) New function.
1202 * expressions/parse.c: (type_coercion_core) Use
1203 check_specifier_type().
1205 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
1207 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
1209 * expressions/parse.c: (no_match) Ditto.
1211 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
1213 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
1215 * expressions/helpers.c: (struct func_params) Removed.
1216 (generalized_idf) Removed.
1219 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
1221 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
1222 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1223 Implement SIG.F, which I had overlooked previously.
1225 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1227 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1228 available only in testing mode.
1230 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1232 * data-in.c: Use `bool' throughout, where relevant.
1234 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1236 DATA LIST with free-field formats should not have implied decimal
1237 places (bug 12035). Also clean up data-in.c a bit.
1239 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1241 * data-in.c: (apply_implied_decimals) New function.
1242 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1243 set. Also, get rid of gotos.
1244 (parse_Z) Use apply_implied_decimals() if the field doesn't
1245 contain a decimal point.
1246 (parse_N) Use apply_implied_decimals().
1252 (parse_enum) New function.
1253 (macro CHAR_IS_ROMAN) Removed.
1254 (macro ROMAN_VALUE) Removed.
1255 (parse_month) Use parse_enum().
1256 (parse_weekday) Use parse_enum().
1257 (parse_DATETIME) Use long for weekday.
1259 * data-list.c: (read_from_data_list_fixed) Use
1260 DI_IMPLIED_DECIMALS.
1262 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1264 When the lexer sees something like `-5' in the input, it has to
1265 decide whether it's a negative numeric constant token or a '-'
1266 token followed by a positive numeric constant token. It always
1267 decides on the former, and then the parser can call
1268 lex_negative_to_dash() if it wants the latter. However, this
1269 doesn't work for the case of `-0', because negative zero is
1270 (portably) indistinguishable from positive zero. So now we divide
1271 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1272 distinction clear. This requires a little bit of extra effort,
1273 because there were several references to T_NUM in the code base.
1275 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1276 positive and negative numeric constants.
1277 (lex_double_p) Renamed lex_is_number(). Changed return type to
1278 bool. Updated all relevant references to T_NUM to instead use
1280 (lex_double) Renamed lex_number(). All references updated.
1281 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1282 bool. All references updated.
1283 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1284 (lex_negative_to_dash) Ditto.
1287 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1289 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1291 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1293 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1295 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1296 values as system-missing.
1298 * expressions/parse.c: (parse_vector_element) Fix order of
1299 arguments in call to expr_allocate_binary().
1301 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1303 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1306 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1307 failure, as indicated by function comment.
1308 (parse_binary_operators) Always return NULL on type_coercion()
1309 failure. Should have been doing this anyway, but bug in
1310 type_coercion_core() filtered through.
1311 (parse_add) Fix typo in user message.
1312 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1314 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1316 * expressions/operations.def: Add VALUE function.
1318 * expressions/parse.c: (parse_function) Need an unary composite
1319 node for variables in A TO B, not a variable node. Use
1320 allocate_unary_variable().
1321 (parse_primary) Use allocate_unary_variable().
1322 (allocate_unary_variable) New function.
1324 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1326 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1327 but fixed the real problem that was preventing the build from a
1328 separate directory. I liked it my way better ;-)
1330 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1332 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1333 John Darrington <john@darrington.wattle.id.au> for reporting this
1336 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1338 * expressions/Makefile.am expressions/evaluate.h.pl
1339 expressions/evaluate.inc.pl expressions/operations.h.pl
1340 expressions/optimize.inc.pl expressions/parse.inc.p:
1342 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1345 Fixed everything so that it can be built from an arbitrary
1348 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1350 * Makefile.am : Fixed up CLEANFILES target.
1352 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1354 * str.h: Changed `struct len_string' to `struct fixed_string', a
1355 more accurate name. Updated all references.
1357 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1359 Redo calendar support. Should now be bug-for-bug compatible.
1361 * calendar.c: New file.
1363 * calendar.h: New file.
1365 * data-in.c: Use new calendar functions.
1366 (parse_sign) Change sense of return value.
1367 (calendar_error) New function.
1368 (ymd_to_ofs) New function.
1369 (ymd_to_date) New function.
1370 (parse_DATE) Use new function.
1371 (parse_ADATE) Ditto.
1372 (parse_EDATE) Ditto.
1373 (parse_SDATE) Ditto.
1374 (parse_JDATE) Ditto.
1379 (parse_DTIME) Ditto.
1380 (parse_DATETIME) Ditto.
1382 * data-out.c: (convert_date) Use new calendar functions.
1384 * error.c: (err_vmsg) Changed interface to be more sensible.
1385 Updated all callers.
1386 (dump_message) Don't double new-lines (why did we do this
1389 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1391 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1392 (macro FLT64_MAX) Moved here from pref.h.orig.
1394 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1396 * set.q: Support SET EPOCH.
1397 (static var set_epoch) New var.
1398 (aux_stc_custom_epoch) New function.
1399 (stc_custom_epoch) New function.
1400 (get_epoch) New function.
1401 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1403 * format.c: Make it possible just to check whether a specifier is
1404 valid without emitting an error message.
1405 (parse_format_specifier_name) Change interface, update all
1407 (check_input_specifier) Ditto.
1408 (check_output_specifier) Ditto.
1409 (parse_format_specifier) Ditto.
1411 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1413 * command.def: Add DEBUG POOL.
1415 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1417 (pool_clear) Properly account for size of pool gizmo.
1418 (pool_realloc) Ditto.
1419 (pool_clone) New function.
1421 * pool.h: Mark our allocation functions MALLOC_LIKE.
1423 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1425 * Makefile.am: Move many definitions into new top-level
1426 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1427 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1430 * case.c: (case_resize) New function.
1431 (case_swap) New function.
1433 * casefile.c: Include mkfile.h.
1435 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1437 * sfm-read.c: Fixed a buglet which caused a crash when trying
1438 to read a non-existent file.
1440 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1444 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1445 Important part: get rid of spurious copying of function->format to
1446 destvar->print and destvar->write.
1448 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1450 Fix bug 11916, which was confusing a variable's `index' member
1451 with the variable's position in a var_set. Although these are
1452 usually the same, they are not for array `var_set's.
1454 Took advantage of this bug as an opportunity to clean up and
1455 rewrite parse_var_set_vars().
1457 * vars-prs.c: (parse_vs_variable_idx) New function.
1458 (parse_vs_variable) Reimplement in terms of
1459 parse_vs_variable_idx().
1460 (parse_var_idx_class) New function.
1461 (add_variable) New function.
1462 (add_variables) New function.
1463 (parse_var_set_vars) Rewritten.
1464 (struct var_set) Change `lookup_var' member that returns a
1465 variable into `lookup_var_idx' member that returns an int.
1466 Updated the var set implementations in obvious corresponding ways.
1467 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1469 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1471 Use our global variable compare & hash functions and give them
1472 better names. Add similar functions for dealing with double
1473 pointers to variables.
1475 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1476 (hash_variable) Renamed hash_var_name().
1477 (compare_var_ptr_names) New function.
1478 (hash_var_ptr_name) New function.
1480 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1482 (compare_var_name) Removed.
1483 (hash_var_name) Removed.
1485 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1489 * dictionary.c: (compare_variable_dblptrs) Rename
1490 compare_var_ptrs() and fix it to properly dereference the double
1493 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1495 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1496 declare subcommands as mandatory. Closed bug #11843
1498 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1500 * getline.c command.[ch] command.def: Added (very rudimentary)
1501 support for line completion when in interactive mode. Partially
1502 addresses bug #11693
1504 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1506 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1507 problems revealed by valgrind.
1510 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1512 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1513 whether or not PAGER is set.
1515 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1517 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1518 "invalid free" errors. Hopefully fixes bug #11722
1520 * compute.c expr-prs.c: Check that lvalues are populated before
1521 attempting to destroy them. Closes bug #11676
1523 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1525 * aggregate.c: Initialised the complete agr_proc structure.
1529 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1531 * print.c: (print_trns_free) Close the dfm writer if there is one,
1532 fixing a memory leak.
1534 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1536 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1540 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1542 * linked-list.[ch] Added
1544 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1545 set.q: Yet more memory leaks
1547 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1549 * t-test.q examine.q : More memory leaks fixed.
1551 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1553 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1556 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1558 * ascii.c cartesian.c casefile.c chart.h devind.c
1559 examine.q frequencies.q
1560 html.c output.h piechart.c plot-chart.c plot-hist.c
1562 Integrated the chart rendering into the output stream
1563 (currently only works for html).
1565 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1566 dummy-chart.c for compiling without charts.
1568 * mkfile.[ch] Created.
1570 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1571 Added type element so we can tell if it's a chart or a table.
1573 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1574 API of charts to be more like that of tables.
1576 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1578 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1579 main.c. Removed the handler for SIGQUIT.
1581 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1583 * casefile.c: Added a signal handler to delete temp files on
1586 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1588 * command.def Added a lot more unimplemented commands.
1590 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1592 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1594 * sort.c: (compare_initial_runs) Needed additional level of
1596 (merge_once) Fix plenty of stupid mistakes.
1598 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1600 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1601 calling casefile_to_disk() or we will lose the last block in the
1602 file if the casefile started out as disk-based.
1603 (casefile_get_reader) Initialize reader->destructive to 0.
1604 (cmd_debug_casefile) Add new test pattern.
1605 (test_casefile) Define new test pattern to make sure
1606 casefile_sleep() works properly.
1608 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1610 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1611 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1612 attempt to seperate the creation and processing of charts from their
1615 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1618 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1620 * main.c Added a signal handler for SIGFPE
1622 * sort.c Somewhat more robust fix to the previous entry.
1624 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1626 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1627 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1628 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1631 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1633 * case.h Fixed bug # 11307
1635 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1637 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1640 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1642 * pfm-read.c: (read_variables) Remove direct manipulation of
1643 v->aux, which is no longer needed. Fixes bug 11483.
1645 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1647 * data-list.c Fixed a bug in parsing delimiters.
1649 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1652 * percentiles.c Properly handled calculation of Tukey hinges where
1653 the number of data is small.
1655 * oneway.q Used the generic value_to_string function for independent
1656 variable instead of trying to do it ourselves.
1658 * box-whisker.c Fixed a buglet which caused a crash if the number of
1662 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1664 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1666 * percentiles.c Fixed some bugs when calculating percentiles when
1667 there's a small number of cases.
1669 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1671 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1673 * examine.q factor_stats.[ch] Added calculation of percentiles
1675 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1677 * t-test.q Fixed bug #11227 Made t-test work when the independent
1680 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1682 * factor_stats.c Fixed calculation of trimmed mean under various
1685 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1687 * histogram.c chart.[ch] factor_stats.c frequencies.q
1689 Added code to calculate sensible histogram ranges and limits.
1691 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1693 * chart.h Updated to reflect many API changes.
1695 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1696 cartesian.c and into chart.c
1698 * factorstats.[ch] Added the histogram calculations
1700 * casefile.c Removed an unused variable.
1702 * frequencies.q examine.q histogram.c Reworked the API for
1705 * piechart.c Revised the API for piecharts.
1707 * var.h Moved the definitions of freq_tab and freq out of var.h
1708 and into frequencies.q where they belong.
1710 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1712 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1713 using AC_TYPE_OFF_T.
1715 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1717 * flip.c: (flip_file) If fseeko() is not available, use long int
1718 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1719 reporting the problem.
1721 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1723 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1724 conflict with stdio.
1726 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1728 * var-labs.c (var_to_string) Now returns null if the variable is null
1730 * value-labels.c (value_to_string) Made it return null if either the
1731 value or the variable is null.
1733 * hash.c (hsh_clear) Fixed a buglet.
1735 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1736 with the wrong model.
1738 * casefile.[ch] Added a function to return the casereader.case_idx
1741 * examine.q Implemented the extreme values results.
1743 John Darrington <john@darrington.wattle.id.au>
1745 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1746 output.[ch] getline.c
1748 Plugged some memory leaks
1750 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1752 Adopt GSL random number generators, paving the way for providing
1753 the complete suite of random number generators on expressions.
1755 * Makefile.am: Remove random.c, random.h.
1757 * random.c: Removed.
1759 * random.h: Removed.
1761 * algorithm.c: (algo_default_random) Use GSL functions.
1763 * casefile.c: (test_casefile) Use GSL RNG functions.
1765 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1768 * sample.c: (cmd_sample) Use GSL RNG functions.
1769 (sample_trns_proc) Ditto.
1771 * set.q: (static var set_seed) Removed.
1772 (static var seed_flag) Removed.
1773 (static var rng) New variable.
1774 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1775 (stc_custom_seed) Use new seed functions.
1776 (seed_is_set) Removed.
1777 (get_rng) New function that composes the entire external
1779 (set_rng) New function.
1780 (random_seed) New function.
1782 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1784 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1785 John Darrington <john@darrington.wattle.id.au> for reporting this
1788 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1790 * permissions.c command.def Added the PERMISSIONS command
1792 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1794 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1795 output file because that will precede #include <config.h>, which
1797 (main) Add needed headers to /* (header) */ code.
1799 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1801 Instead of making system or portable file readers responsible for
1802 dropping and reordering variables, make them read full cases and
1803 let the caller take care of any changes.
1805 * get.c: New "case map" structure to handle this. Use for GET,
1806 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1808 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1809 changed appropriately.
1811 * sfm-read.c: (sfm_read_case) Ditto.
1813 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1815 Decided that case_serialize() and case_unserialize() were too
1816 abstract. Also we need a couple more functions to avoid excessive
1817 copying for data in/out fast paths.
1819 * case.c: (case_serial_size) Removed.
1820 (case_serialize) Rename case_to_values() and make its argument
1821 explicitly an array of union values.
1822 (case_unserialize) Rename case_from_values() and make its argument
1823 explicitly an array of union values.
1824 (case_data_all) New function.
1825 (case_data_all_rw) New function.
1827 * casefile.c: (struct casefile) Change buffer from array of
1828 unsigned char to array of union value for better accuracy.
1829 Redefine buffer_used and buffer_size in terms of values, not
1830 bytes. Remove case_size because it is now redundant with
1831 value_cnt. Fix up all references to these members.
1833 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1835 * barchart.c: (struct subcat) Make `label' member const to silence
1836 GCC warning with -Wwrite-strings.
1838 * cartesian.c: (struct dataset) Ditto.
1840 * case.c: Don't re-define NDEBUG if already defined.
1841 Add lots of comments.
1843 * str.c: Fix includes.
1845 * crosstabs.q: Fix includes.
1847 * examine.q: Fix includes. Fix GCC warning about unused
1850 * frequencies.q: (stat macro) Removed and replaced where used by
1853 * list.q: Fix includes.
1855 * oneway.q: Fix includes.
1857 * piechart.c: Fix includes. Only define M_PI if not already
1860 * sfm-read.c: (bswap) New function.
1861 (bswap_int32) Write in terms of bswap.
1862 (bswap_flt64) Ditto.
1864 * str.c: (ds_data) Add external definition here, needed because
1865 str.h has only an `extern inline' version.
1867 * value-labels.c: Fix includes.
1869 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1871 Instead of providing a system or portable file writer with a raw
1872 case in the format needed for output, provide it with a regular
1873 case. The writer takes care of any needed translation.
1875 * aggregate.c: Adopt new scheme for AGGREGATE.
1876 (struct agr_proc) sfm_agr_case member removed.
1877 (write_case_to_sfm) Removed because the new interface is easier to
1880 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1882 * pfm-write.c: Implement new scheme.
1884 * sfm-write.c: Ditto.
1886 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1888 Instead of treating `struct file_handle' as a class to subclass
1889 into data files, system files, and portable files, instead use it
1890 as a helper that coordinates access. Now it is opaque, too.
1892 This means that most references to a struct file_handle are now
1893 changed into references to one of struct dfm_reader, struct
1894 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1895 pfm_reader, or struct pfm_writer, according to what's being read
1898 Most related changes are only worth summarizing briefly.
1900 * dictionary.c: (dict_clear) Destroy aux data in deleted
1902 (dict_clear_aux) New function.
1903 (dict_create_var) Initialize aux, aux_dtor.
1904 (dict_delete_var) Destroy aux data in deleted variable.
1906 * file-handle.h: (struct fh_ext_class) Removed.
1907 (struct file_handle) Removed.
1908 (fh_init_files) Removed.
1910 * file-handle.q: Changed references to a handle's `private' member
1911 to direct references.
1912 (struct private_file_handle) Renamed file_handle.
1913 Add next, open_cnt, type, open_mode, aux members.
1914 (struct file_handle_list) Removed.
1915 (extern var inline_file) Removed.
1916 (static var file_handles) Changed from file_handle_list * to
1918 (create_file_handle) Initialize new members.
1919 (fh_close_handle) Removed.
1920 (mode_name) New function.
1921 (fh_open) New function.
1922 (fh_close) New function.
1923 (fh_parse_file_handle) Renamed fh_parse().
1925 * glob.c: (init_glob) Remove fh_init_files() call.
1927 * aggregate.c: use sfm_writer.
1928 (create_sysfile) Removed because the new interface is simpler.
1930 * apply-dict.c: Use sfm_reader.
1932 * data-list.c: Use dfm_reader.
1934 * file-type.c: Use dfm_reader.
1936 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1938 * inpt-pgm.c: Use dfm_reader.
1940 * print.c: Use dfm_writer.
1942 * sysfile-info: Use sfm_reader.
1944 * dfm-read.c: Adopt new file handle infrastructure.
1946 * dfm-write.c: Ditto.
1948 * pfm-read.c: Ditto.
1950 * pfm-write.c: Ditto.
1952 * sfm-read.c: Ditto.
1954 * sfm-write.c: Ditto.
1956 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1958 Break dictionary functions into separate header file.
1960 * dictionary.h: New file.
1962 * var.h: Moved dict_*() functions to dictionary.h.
1964 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1966 Get rid of procedure-specific union in struct variable, using
1967 instead a void * pointer and a destructor function.
1969 Most related changes are only worth brief summaries.
1971 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1972 old p.crs member in struct variable.
1974 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1975 of old p.frq member in struct variable.
1977 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1978 it's no longer possible to grab this from var->p.frq.
1980 * piechart.c: (draw_piechart) Ditto.
1982 * group.c: (group_proc_get) New function.
1984 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1991 * main.c: (execute_command) Clear aux data in default_dict after
1992 each command. (It's debatable whether this should be done.)
1994 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1995 member in struct variable.
1997 * means.q: Get rid of integer mode, which is not included in
1998 recent SPSS and was the only code that wanted per-variable private
2001 * var.h: (struct crosstab_proc) Removed.
2002 (struct frequencies_proc) Removed.
2003 (struct list_proc) Removed.
2004 (struct get_proc) Removed.
2005 (struct means_proc) Removed.
2006 (struct matrix_data_proc) Removed.
2007 (struct match_files_proc) Removed.
2008 (lots of enums) Removed.
2009 (struct variable) Removed members `p', `get'. Add member
2012 * vars-atr.c: (var_attach_aux) New function.
2013 (var_detach_aux) New function.
2014 (var_clear_aux) New function.
2015 (var_dtor_free) New function.
2016 (discard_variables) Use NULL instead of inline_file.
2018 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2020 * value-labs.c Fixed the implmentation of value_to_string, so
2021 that it properly handles alpha values.
2023 * oneway.q Changed instances where labels were being probed manually,
2024 to use the canonical {var,value}_to_string functions
2026 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2028 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
2029 plots. Changed the API of the cartesian plot to be a much lower level
2032 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
2034 * examine.q Added some of the parametric calculations
2036 * factor_stats.[ch] Created
2038 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2040 * examine.q Changed the definition of factors to be a composite, and
2041 dealt with the consequences.
2043 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
2045 * examine.q Fixed problem where examine wasn't dealing properly with
2048 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
2050 * oneway.q Fixed problem where oneway wasn't dealing properly with
2053 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
2055 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
2056 command which had settings didn't get the appropriate code
2059 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
2060 to convert variables/values to strings.
2062 * examine.q Added framework for the EXAMINE command.
2064 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
2066 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
2067 subcommand types. Changed frequencies.q to use it rather then the
2068 custom parser. Dealt with the consequences. Added a test for NTILES
2069 subcommand of frequencies.
2071 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
2073 * oneway.q Fixed up the behaviour when given missing values
2075 * levene.c oneway.q Fixed a buglet with the levene statistic and
2076 incorporated the levene test into the oneway command.
2078 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
2079 global scope, since they're only relevant to T-TEST
2081 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
2083 * group.c group.h group_proc.h levene.c oneway.q t-test.q
2085 Made the t-test more consistent
2086 with the way it handles groups. That is, it now uses a hash instead
2087 of an array of 2. Also, made the levene.c file independent of the
2088 implementation of the t-test. So now levene should be fine for both
2091 * Added an oneway.q file for one way anova
2093 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
2095 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
2098 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
2102 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
2103 (data_list_trns_free) Free dls->delims.
2105 * t-test.q: (tts_custom_pairs) Free vars.
2106 (ssbox_one_sample_init) Fix tab_vline() argument.
2107 (ssbox_independent_samples_init) Ditto.
2108 (trbox_paired_init) Ditto.
2109 (trbox_one_sample_init) Ditto.
2111 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
2113 Generalize casefiles to the extent that we can use them for
2114 sorting and other kinds of data transformations. Change cases to
2115 be copy-on-write to improve memory efficiency in common cases.
2116 Every access to a member of a `struct ccase' was changed to be a
2117 call to a case_*() function, especially case_data(), case_num(),
2118 case_str(), or case_data_rw(). Many instances of a local variable
2119 named "case_num" were changed to "case_idx" as a consequence.
2120 Many `struct ccase *' were changed to actual `struct ccase'
2121 because of copying semantics of cases. In several places there
2122 was a choice between updating debug code to work with the new ADTs
2123 or just deleting it because it was useless; I chose to delete it.
2125 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
2131 * aggregate.c: (struct agr_proc) Change type of `sort' to
2132 sort_criteria *. Add `break_vars', `break_var_cnt' members.
2133 Rename `vars' to `agr_vars', all references updated. Change
2134 `agr_case' to type `struct ccase'.
2135 (cmd_aggregate) Deal with new members. Use case_create(),
2136 sort_active_file_in_place(), sort_active_file_to_casefile().
2137 (agr_destroy) Deal with new members.
2138 (aggregate_single_case) Ditto.
2139 (dump_aggregate_info) Ditto.
2140 (initialize_aggregate_info) Ditto.
2141 (agr_to_active_file) Ditto.
2142 (presorted_agr_to_sysfile) Ditto.
2143 (sort_agr_to_sysfile) Removed.
2145 * alloc.c: (out_of_memory) Make non-static.
2147 * alloc.h: Prototype out_of_memory().
2149 * casefile.c: Switched from a linked list in-memory representation
2150 to a two-level array-style representation. The linked list was
2151 appropriate when we could stick a header onto cases, but that's no
2152 longer the case. Also, the two-level array will allow for random
2153 in-memory access in case that's ever wanted. Also added the
2154 concept of a `destructive casereader', one that destroys cases in
2155 the underlying casefile as they are read out.
2156 (macro CASES_PER_BLOCK) New macro.
2157 (struct casefile) New members `value_cnt', `case_list_size',
2158 `case_acct_size', `being_destroyed', `cases'. Removed `head',
2160 (struct casereader) Removed `cur'. Added `destructive', `c'.
2161 (global var casefiles) Made static.
2162 (static var case_bytes) New var.
2163 (casefile_create) Takes a value count, not a case size in bytes,
2164 to conform to the case interface. All callers updated. Deal with
2165 new and removed members.
2166 (casefile_destroy) Deal with new and removed members.
2167 (casefile_sleep) New function.
2168 (casefile_get_case_size) Removed.
2169 (casefile_get_value_cnt) New function.
2170 (casefile_append) Rewritten to deal with new and removed members.
2171 (casefile_append_xfer) New function.
2172 (write_case_to_disk) Use case_serialize().
2173 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
2174 Couldn't figure out why.
2175 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
2176 deal with new and removed members.
2178 (merge_sort) Removed.
2179 (casefile_sort) Removed.
2180 (casefile_get_reader) Deal with new and removed members.
2181 (casefile_get_destructive_reader) New function.
2182 (reader_open_file) Make code more readable. Create case for
2184 (casereader_get_casefile) New function.
2185 (casereader_read) Deal with new and removed members. Now returns
2186 a copy of the case, so that the caller is responsible for
2187 destroying the returned case.
2188 (casereader_read_xfer) New function.
2189 (casereader_destroy) Destroy reader's case.
2190 (test_casefile) Second arg is now a value count, all callers
2191 updated. Now tests destructive readers too.
2192 (get_random_case) Deal with new case ADT.
2193 (write_random_case) Ditto.
2194 (read_and_verify_random_case) Ditto.
2196 * crosstabs.q: Remove debug code.
2198 * descript.q: (calc_descriptives) Deal with new case, casefile
2201 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
2203 * do-if.c: Remove unneeded header inclusion.
2205 * expr-prs.c: Remove debug code.
2207 * exprP.h: Remove debug code.
2209 * flip.c: (flip_file) Use fseeko() if available.
2211 * formats.c: Remove debug code.
2213 * get.c: Remove debug code.
2214 (struct mtf_file) Change `input' from `union value *' to `struct
2215 ccase', all references updated.
2217 * levene.c: (levene) Deal with new case, casefile ADTs.
2219 * list.q: Remove debug code.
2221 * loop.c: Remove debug code.
2223 * matrix-data.c: Remove debug code.
2225 * means.q: Remove debug code.
2227 * mis-val.c: Remove debug code.
2229 * pfm-read.c: Remove debug code.
2230 (pfm_read_code) Change second arg from `union value *' to `struct
2231 ccase *', all references updated.
2233 * recode.c: (string_to_long) Make first arg const.
2234 (convert_to_double) Ditto.
2236 * repeat.c: Remove debug code.
2238 * sample.c: Remove debug code.
2240 * sfm-read.c: Remove debug code.
2241 (sfm_read_case) Change second arg from `union value *' to `struct
2244 * sort.c: Redone in terms of casefiles.
2245 (enum sort_direction) Moved here from sort.h.
2246 (struct sort_criterion) New structure.
2247 (struct sort_criteria) New structure.
2248 (cmd_sort_cases) Rewritten.
2249 (prepare_to_sort_active_file) New function.
2250 (sort_active_file_in_place) New function.
2251 (sort_active_file_to_casefile) New function.
2252 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2253 changed, all callers updated.
2254 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2255 rewritten & interface changed, all callers updated.
2256 (sort_cases) Renamed sort_execute(), rewritten & interface
2257 changed, all callers updated.
2258 (struct internal_sort) Removed.
2259 (do_internal_sort) Rewritten, interface changed.
2260 (destroy_internal_sort) Removed.
2261 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2262 (struct initial_run) Removed; an initial run is now just a
2264 (compare_initial_runs) Rewritten.
2265 (struct external_sort) Changed almost completely.
2266 (do_external_sort) Rewritten, interface changed.
2267 (destroy_external_sort) Rewritten.
2268 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2269 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2270 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2271 (init_external_sort) Removed.
2272 (simulate_error) Removed.
2273 (rmdir_temp_dir) Removed.
2274 (get_temp_file_name) Removed.
2275 (open_temp_file) Removed.
2276 (close_temp_file) Removed.
2277 (remove_temp_file) Removed.
2278 (write_temp_file) Removed.
2279 (read_temp_file) Removed.
2280 (struct record_run) Change `record' from `struct case_lit *' to
2282 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2283 `file_idx', `output_file'. Add `run', casefile'. Change
2284 `last_output' from `struct case_list *' to `struct ccase'.
2285 (write_initial_runs) Change interface, rewrite.
2286 (sort_sink_write) Renamed process_case(), changed interfaced,
2288 (destroy_initial_run_state) Rewritten.
2289 (allocate_cases) Rewritten.
2290 (compare_record) Interface changed, rewritten.
2291 (start_run) Rewritten.
2292 (end_run) Rewritten.
2293 (output_record) Rewritten.
2294 (grab_case) Removed.
2295 (release_case) Removed.
2296 (struct merge_case) Change `cases' from double pointer to single
2298 (merge) Deal with new case and casefile ADTs.
2299 (struct run) Removed.
2300 (merge_once) Rewritten, interface changed.
2301 (fill_run_buffer) Removed.
2302 (sort_sink_make_source) Removed.
2303 (sort_sink_class) Removed.
2304 (struct sort_source_aux) Removed.
2305 (sort_source_read_helper) Removed.
2306 (sort_source_read) Removed.
2307 (read_sort_output) Removed.
2308 (read_internal_sort_output) Removed.
2309 (read_external_sort_output) Removed.
2310 (sort_source_destroy) Removed.
2311 (sort_source_class) Removed.
2313 * sort.h: (struct sort_cases_pgm) Removed.
2314 (enum sort_direction) Moved to sort.c.
2316 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2318 * tab.c: Remove debug code.
2320 * var-labs.c: Remove debug code.
2322 * var.h: (struct ccase) Removed.
2323 (struct case_list) Removed.
2325 * vars-atr.c: (discard_variables) Use free_case_source().
2327 * vars-prs.c: (parse_vs_variable) Make arg const.
2328 (parse_dict_variable) Ditto.
2329 (parse_variables) Make struct dictionary * arg const.
2330 (parse_var_set_vars) Make struct var_set * arg const.
2331 (struct var_set) Add const to some of the function pointers' args.
2332 (var_set_get_cnt) Make arg const.
2333 (var_set_get_var) Make first arg const.
2334 (var_set_lookup_var) Make first arg const.
2335 (dict_var_set_get_cnt) Make arg const.
2336 (dict_var_set_get_var) Make first arg const.
2337 (dict_var_set_lookup_var) Make first arg const.
2338 (var_set_create_from_dict) Make arg const. Add cast to aux
2340 (struct array_var_set) Add const to var member.
2341 (array_var_set_get_cnt) Make arg const.
2342 (array_var_set_get_var) Make first arg const.
2343 (array_var_set_lookup_var) Make first arg const.
2344 (var_set_create_from_array) Make first arg const. Insert cast.
2346 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2347 members from `struct ccase *' to `struct ccase'.
2348 (static var lag_queue) Change from double to single pointer.
2349 (procedure) Optimize trivial case.
2350 (internal_procedure) Deal with changed case, case_source ADTs.
2351 (create_trns_case) Changed interface, rewrote.
2352 (open_active_interface) Initialize modified lag queue.
2353 (write_case) Deal with changed case ADT.
2354 (lag_case) Deal with modified lag queue.
2355 (close_active_file) Destroy modified lag queue.
2356 Deal with changed case_source, case_sink ADTs.
2357 (destroy_storage_stream_info) Make null arg into no-op.
2358 (storage_sink_make_source) Set aux in created source.
2359 (storage_source_read) Deal with changed case, casefile ADTs.
2360 (storage_source_create) New function.
2361 (lagged_case) Rewrite.
2362 (free_case_source) New function.
2363 (free_case_sink) Rewrite.
2364 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2366 (procedure_with_splits) Deal with changed prev_case.
2367 (procedure_with_splits_callback) Ditto.
2368 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2370 (multipass_procedure_with_splits) Deal with changed prev_case.
2371 (multipass_split_callback) Ditto.
2374 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2376 The workspace idea didn't work out.
2378 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2380 * workspace.c: Removed.
2382 * workspace.h: Removed.
2384 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2386 Fully implement arbitrary delimiters on DATA LIST, extending the
2387 half implementation that was already there.
2389 * data-list.c: (struct data_list_pgm) Remove `delim', add
2390 `delims', `delim_cnt'.
2391 (cmd_data_list) Initialize new members. Parse delimiters and
2392 clean up code a bit.
2393 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2394 handling of leading commas.
2395 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2397 (read_from_data_list_free) Adapt to new DFM interfaces.
2398 (read_from_data_list_list) Ditto.
2399 (repeating_data_trns_proc) Ditto.
2401 * dfm.c: Split up reader and writer into separate code, because
2402 they do different things. Use struct string instead of explicit
2403 allocation code, for clarity.
2404 (enum dfm_reader_flags) New enum.
2405 (struct dfm_fhuser_ext) Removed.
2406 (struct dfm_reader_ext) New.
2407 (get_reader) New function, used by just about all the reader
2409 (dfm_close) Removed.
2410 (close_reader) New function.
2411 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2412 (dfm_open_for_writing) Ditto.
2413 (macro force_line_buffer_expansion) Removed.
2414 (count_tabs) Removed.
2415 (tabs_to_spaces) Removed.
2416 (read_record) Deal with new dfm_reader_ext. Use struct string
2417 functions. Don't convert tabs to spaces.
2418 (dfm_eof) New function.
2419 (dfm_get_record) Changed interface, rewrote.
2420 (dfm_expand_tabs) New function.
2421 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2422 dfm_reader_ext, rewritten.
2423 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2424 dfm_reader_ext, rewritten.
2425 (dfm_set_record) Removed in favor of dfm_forward_columns().
2426 (dfm_forward_columns) New function.
2427 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2428 dfm_reader_ext, rewritten.
2429 (static var dfm_r_class) Use close_reader for the destructor.
2430 (struct dfm_writer_ext) New.
2431 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2432 bounce buffer now instead of local allocation.
2433 (close_writer) New function.
2434 (static var dfm_writer_ext) Use close_writer for destructor.
2435 (cmd_begin_data) Adapt to new dfm_reader_ext.
2437 * file-handle.q: Add support for per-file tab width.
2438 (struct private_file_handle) Add tab_width member.
2439 (q2c specifications) Add tabwidth subcommand.
2440 (cmd_file_handle) Put parsed tab width into private_file_handle.
2441 (create_file_handle) Set default tab width.
2442 (handle_get_tab_width) New function.
2444 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2446 * inpt-pgm.c: (reread_trns_proc) Ditto.
2448 * matrix-data.c: (context) Ditto.
2449 (another_token) Ditto.
2453 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2455 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2457 (casereader_destroy) Don't close file descriptor -1.
2459 * recode.c: (cmd_recode) Fix memory leak.
2461 * set.q: (q2c specifications) Fix typo in user message.
2463 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2464 undefined behavior for overlapping arguments.
2466 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2468 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2469 don't call it when we're running under valgrind.
2470 (call_posix_fadvise) New function.
2471 (casefile_to_disk) Use call_posix_fadvise().
2472 (reader_open_file) Ditto.
2474 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2476 Update our string ADTs, struct string and struct len_string. Get
2477 rid of pool support, which was largely unused. Rename lots of
2478 functions to have more obvious or consistent names.
2480 * ascii.c: Get rid of ascii_pool. It was only used for string
2482 (ascii_open_global) Don't create ascii_pool.
2483 (ascii_close_driver) Don't destroy ascii_pool.
2484 (ascii_postopen_driver) Don't use pool.
2485 (ascii_close_driver) Destroy strings manually.
2487 * str.c: (ds_create) Remove pool argument, all references updated.
2489 (ds_replace) Remove pool support, make more efficient when we
2490 don't need to reallocate.
2491 (ds_destroy) Remove pool support.
2492 (ds_rpad) New function.
2493 (ds_size) Renamed ds_capacity(), all references updated.
2494 (ds_value) Renamed ds_c_str(), all references updated.
2495 (ds_concat) Renamed ds_puts(), all references updated.
2496 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2497 (ds_putchar) Renamed ds_putc(), all references updated.
2498 (ds_getline) Renamed ds_gets(), all references updated.
2499 (ls_create) Remove pool argument, all references updated.
2500 (ls_create_buffer) Ditto.
2501 (ls_destroy) Removed pool support.
2502 (ls_value) Renamed ls_c_str(), all references updated.
2504 * str.h: (ls_length) [__GNUC__] Add inline version.
2505 (ls_c_str) [__GNUC__] Add inline version.
2506 (ls_end) [__GNUC__] Add inline version.
2507 (struct string) Remove pool member. Rename `size' to `capacity',
2508 all references updated.
2510 * tab.c: (text_format) Instead of using pool argument to
2511 ls_create_buffer(), call pool_register() on allocated data.
2513 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2515 We're abusing the current ASCII driver by telling it to allocate a
2516 9999-line, 9999-character page in the tests. This causes some
2517 systems to curl up and die because it allocates 20 MB of
2518 contiguous RAM. This change alleviates at least part of the
2519 problem. It is mostly a stop-gap until the new output system is
2522 * ascii.c: (struct line) New structure.
2523 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2524 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2525 (ascii_preopen_driver) Initialize new members, not old ones.
2526 (ascii_close_driver) Destroy new members, not old ones.
2527 (ascii_open_page) Allocate new members, not old ones.
2528 (expand_line) Allocate room in line.
2529 (draw_line) Use new members.
2530 (ascii_line_horz) Ditto.
2531 (ascii_line_vert) Ditto.
2532 (ascii_line_intersection) Ditto.
2534 (output_lines) Ditto.
2535 (ascii_close_page) Ditto.
2537 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2539 * matrix.c: Dead code. Removed.
2541 * matrix.h: Dead code. Removed.
2543 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2545 Contrary to what I'd always understood, there is an efficient
2546 algorithm for deletion from a hash table populated via linear
2547 probing. This change implements it.
2549 * hash.c: (hsh_rehash) Probe in increasing order.
2551 (locate_matching_entry) Ditto.
2552 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2554 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2556 * moments.c (calc_moments): Adjust calculation of kurtosis to
2557 avoid subtracting huge numbers from huge numbers, on Michael
2560 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2562 Rework moments routines for improved numerical stability based on
2563 Michael Kiefte's advice. Any bugs or remaining numerical problems
2564 are still mine though.
2566 There is now a struct moments1 for use with one-pass moments. It
2567 uses a provisional means algorithm as an attempt to improve
2568 accuracy of higher moments. The older struct moments now only
2569 handles two-pass moments.
2571 * aggregate.c: Use moments1 instead moments.
2573 * descript.c: Revert previous change, which is no longer needed
2574 due to the moments revision.
2576 * moments.c: (calc_moments) New function for calculating variance,
2578 (moments_pass_one) Only accumulate weights bigger than zero.
2579 (moments_calculate) Allow calculating the mean on pass one, others
2580 require pass two. Implement in terms of calc_moments().
2581 (struct moments1) New structure.
2582 (init_moments1) New function.
2583 (moments1_clear) Ditto.
2584 (moments1_create) Ditto.
2585 (moments1_add) Ditto.
2586 (moments1_calculate) Ditto.
2587 (moments1_destroy) Ditto.
2588 (cmd_debug_moments) Deal with `struct moments' or `struct
2589 moments1' as requested by user.
2591 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2593 * Makefile.am (pspp_SOURCES): Remove debug.c.
2595 * debug.c: Removed. It was empty anyway.
2597 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2599 * descript.c (calc_descriptives): Fix assert failure when only
2600 MOMENT_MEAN is needed.
2602 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2606 fixed problem with parsing in match_statistic() causing
2607 "DESCRIPTIVE STAT=MEAN." to barf.
2609 "MEAN" is now default if "SORT" given without specification.
2611 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2612 generally less forgiving of syntax errors: better to have it do
2613 nothing and type it in again then to not know what it actually did
2616 z-score transformation now checks score for user-missing values
2617 and checks std_dev for SYSMIS.
2619 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2621 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2622 Changed dict_get_case_weight() to accept an additional int * flag
2623 to complain about system-missing, user-missing, zero, or negative
2624 weights and updated existing functions to pass int * to
2625 dict_get_case_weight().
2627 2004-04-05 jmd <jmd@gnu.org>
2629 * main.c: Fixed configuration problems with gsl
2631 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2633 2004-04-03 blp <blp@gnu.org>
2635 * lexer.c, ChangeLog:
2636 Fix infinite loop on comment at end of file, add test.
2638 2004-04-03 jmd <jmd@gnu.org>
2640 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2641 Fixed the calculation of percentiles and added --syntax and --algorithm options
2643 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2645 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2648 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2650 * frequencies.q: Fixed the calculation of percentiles
2652 * Makefile.am: Added the --ansi flag and dealt with the
2653 consequences. Added some entries to PSPP_sources so that
2654 make distcheck would pass
2656 * cmdline.c: Added the --syntax and --algorithm options
2658 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2660 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2662 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2663 use the new multipass_split_... mechanism.
2665 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2667 * frequencies.q: (calc_stats) Use moments data structure and
2668 calc_seskew(), calc_sekurt() functions.
2670 * set.q main.c settings.h Added support for --syntax and --algorithm
2673 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2675 * vfm.c: Had to get last call to multipass_split_output() inside
2676 open_active_file()/close_active_file() pairing, so introduce new
2678 (internal_procedure) Move procedure() code here, except for calls
2679 to open_active_file() and close_active_file().
2680 (procedure) Wrap open_active_file() and close_active_file() around
2681 internal_procedure().
2682 (multipass_procedure_with_splits) Wrap open_active_file() and
2683 close_active_file() around internal_procedure().
2685 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2687 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2689 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2691 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2693 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2695 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2697 * algorithm.c: By default turn off some of the more expensive
2699 (expensive_assert) New macro which expands to assert if
2700 EXTRA_CHECKS is defined, to nothing otherwise.
2701 (unique) Use expensive_assert().
2702 (binary_search) Ditto.
2708 * command.c: (conflicting_3char_prefixes) Words that are the same
2709 don't cause conflicts when they are abbreviated to the first three
2712 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2713 nonterm_node's n earlier.
2714 (generic_str_func) Ditto.
2716 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2718 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2719 test multipass support, take advantage of new moments
2720 calculation, and to not be such crappy code. Get rid of q2c
2721 processing for DESCRIPTIVES.
2723 * vfm.c: (struct multipass_split_aux_data) New structure.
2724 (multipass_procedure_with_splits) New function.
2725 (multipass_split_callback) New function.
2726 (multipass_split_output) New function.
2727 * descript.q: Removed.
2729 * descript.c: New file.
2731 * var.h: Removed descriptives enums.
2732 (struct descriptives_proc) Removed.
2733 (struct variable) Removed p.dsc.
2735 * Makefile.am: (q_sources_c) Remove descript.c.
2736 (q_sources_q) Removed descript.q.
2738 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2740 New manager for keeping track of used workspace.
2742 * workspace.c: New file.
2744 * workspace.h: New file.
2746 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2748 * sort.c: (do_internal_sort) Use workspace_malloc().
2749 (destroy_internal_sort) Use workspace_free().
2751 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2753 New `struct casefile' for managing sets of cases.
2755 * casefile.c: New file.
2757 * casefile.h: New file.
2759 * command.def: Add DEBUG CASEFILE command.
2761 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2763 * sort.c: (sort_cases) Move logic for sending storage file to disk
2764 into do_external_sort().
2765 (struct internal_sort) Use an array of ccase pointers instead of a
2767 (do_internal_sort) Rewrite to handle casefiles.
2768 (compare_case_list) Removed.
2769 (compare_cases) New function.
2770 (compare_case_dblptrs) New function.
2771 (read_internal_sort_output) Deal with new struct internal_sort.
2773 * vfm.c: (static var workspace_overflow) Removed.
2774 (struct storage_stream_info) Removed all the members. Added
2775 struct casefile * member.
2776 (storage_sink_open) Use casefile.
2777 (open_storage_file) Removed.
2778 (write_storage_file) Removed.
2779 (storage_to_disk) Removed.
2780 (destroy_storage_stream_info) Use casefile.
2781 (storage_sink_write) Use casefile.
2782 (storage_sink_make_source) Use casefile.
2783 (storage_source_count) Use casefile.
2784 (storage_source_read) Use casefile.
2785 (storage_source_on_disk) Removed.
2786 (storage_source_get_cases) Removed.
2787 (storage_source_set_cases) Removed.
2788 (storage_source_get_casefile) New function.
2790 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2792 New `struct moments' for calculating moments.
2798 * moments.c: New file.
2800 * moments.h: New file.
2802 * command.def: Add DEBUG MOMENTS command.
2804 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2807 * aggregate.c: Modify AGGREGATE to use the new moments
2808 calculation, even if not in such a great way.
2809 (struct agr_var) Add `moments' member.
2810 (parse_aggregate_functions) Set `moments' member to null.
2811 (agr_destroy) Destroy `moments' member.
2812 (accumulate_aggregate_info) Use `moments' for standard deviation.
2813 (dump_aggregate_info) Ditto.
2814 (initialize_aggregate_info) Create or clear `moments'.
2816 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2817 cube(), pow4() that were in stats.h. All references updated.
2819 * crosstabs.q: stats.h had chi-square significance functions. Use
2821 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2823 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2824 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2826 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2828 * dictionary.c: (dict_compact_values) Compacted values need to
2831 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2833 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2834 `/' at start. Check return value of parse_variables() for error
2837 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2839 Revamp expressions: make the code a little nicer, and fix bugs
2842 * expr-evl.c: (expr_evaluate) Make expression argument const.
2843 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2844 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2845 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2846 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2847 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2848 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2849 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2850 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2851 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2852 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2853 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2854 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2855 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2857 * expr-opt.c: (optimize_expression) Rewrite.
2862 (macro s0l) Removed.
2864 (macro s1l) Removed.
2866 (macro s2l) Removed.
2869 (eq_num_con) New function.
2870 (optimize_tree) New function.
2871 (macro rnc) Removed.
2872 (macro frnc) Removed.
2873 (str_search) Add const to string params.
2874 (str_rsearch) Ditto.
2875 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2876 str[], str_len[] locals to substitute for most of removed macros.
2877 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2878 Removed support for missing values because we're never called with
2879 missing values. Use set_number() or set_number_errno() instead of
2880 rnc or frnc. Removed any stuff that caused trouble in testing.
2881 We can re-add it later if it really slows anything. Fix some
2883 (evaluate_tree_with_missing) Not yet supported. To be added later
2885 (repl_num_con) Removed.
2886 (collapse_node) New function.
2887 (force_repl_num_con) Removed.
2888 (set_number) New function.
2889 (set_number_errno) New function.
2890 (repl_str_con) Removed.
2891 (set_string) New function.
2892 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2894 (dump_node) No special case for OP_AND, OP_OR.
2896 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2897 (expr_get_type) New function.
2898 (type_check) Rewrite.
2899 (type_coercion) New function.
2900 (struct operator) New structure.
2901 (match_operator New function.
2902 (parse_binary_operators) New function.
2903 (parse_inverting_unary_operator) New function.
2904 (parse_or) Rewritten.
2905 (parse_and) Rewritten.
2906 (parse_not) Rewritten.
2907 (parse_rel) Rewritten.
2908 (parse_add) Rewritten.
2909 (parse_mul) Rewritten.
2910 (parse_neg) Rewritten.
2911 (parse_exp) Rewritten.
2912 (parse_sysvar) Add $TRUE, $FALSE system variables.
2913 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2914 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2916 (struct function) Remove desc, change `func' prototype.
2917 (unary_func) Remove special cases.
2918 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2919 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2920 (VALUE_func) Use allocate_var_node().
2921 (nary_num_func) Allow MIN and MAX for strings.
2922 Use allocate_var_node(). Properly clean up.
2924 (generic_str_func) Use local table instead of removed `desc'
2925 member. Mostly rewrite.
2926 (get_num_args) Revise error message.
2927 (parse_function) Return EXPR_ERROR, not 0 on error.
2929 (macro varies) Removed.
2930 (ops[]) Use expr.def.
2931 (free_node) Do nothing if node is null.
2932 (allocate_num_con) New function.
2933 (allocate_str_con) New function.
2934 (allocate_var_node) New function.
2935 (allocate_binary_nonterminal) New function.
2936 (append_nonterminal_arg) Removed.
2937 (static var func_tab[]) Revised.
2938 (expr_debug_print_postfix) Make parameter const.
2939 Use printf() instead of debug_printf().
2941 * expr.def: New file.
2943 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2944 use named enum instead of unnamed, all references updated. Add
2945 EXPR_ANY, EXPR_NO_OPTIMIZE.
2947 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2948 instead of defining OP_* directly.
2949 (macro IS_TERMINAL) New macro.
2950 (macro IS_NONTERMINAL) New macro.
2951 (enum OP_NO_FLAGS) New.
2953 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2955 * error.c: (err_assert_fail) msg variable needs to be non-const.
2957 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2959 * debug.c: (cmd_debug_evaluate) Rewrite.
2961 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2963 Fix some CROSSTABS bit rot stupidity.
2965 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2966 (internal_cmd_crosstabs) Initializes cells[] correctly.
2967 (float_M_suffix) Rename format_cell_entry(), change prototype,
2969 (display_crosstabulation) Fix cell formatting.
2971 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2973 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2974 to call lex_discard_line() to do that.
2976 * command.c: (run_command) Call lex_discard_line() after
2979 * lexer.c: (lex_entire_end) Change behavior.
2980 (lex_rest_of_line) Change behavior. Return const char *.
2981 (lex_discard_line) Don't clear getl_buf, don't emit message.
2983 * main.c: (handle_error) Emit message here.
2985 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2986 instead of lex_entire_line().
2988 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2990 * title.c: (get_title) Call lex_discard_line() after
2992 (cmd_file_label) Ditto.
2993 (cmd_document) Deal with const char * return value.
2995 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2997 Removed REMARK command.
2999 * command.c: (extract_prefix) Removed.
3000 (output_line) Removed.
3001 (cmd_remark) Removed.
3003 * command.def: Remove REMARK.
3005 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
3007 Added abort() after lots of assert(0) invocations to avoid some
3008 compiler warnings. We really need a NOT_REACHED macro.
3010 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3012 * sort.c: Added missing call to temp_file_close. Changed error
3013 messages to warnings.
3015 * set.q: Improved setting of set_view{length,width} to be more tolerant
3018 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
3020 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
3021 used with incorrect syntax.
3023 * error.c, error.h et al: Overridden definition of assert for a
3026 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
3027 subcommand was given when it ought to have been.
3029 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
3031 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
3035 (tab_joint_text) Ditto.
3037 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
3039 * levene.c: Add #include.
3041 * set.q: (set_viewport) Add `int' argument to make its prototype
3042 correct for signal().
3044 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
3046 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
3049 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
3051 Changed DFM from open-at-first-access to explicit-open. Before,
3052 calling dfm_get_record() or dfm_put_record() would automatically
3053 open the file. Now, you have to call dfm_open_for_reading() or
3054 dfm_open_for_writing() explicitly. This makes it possible to
3055 check permissions, file existence, etc. earlier.
3057 Also made struct file_handle more opaque, and clean up in general.
3059 * data-list.c: (cmd_data_list) Open handle for reading.
3061 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
3063 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
3064 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
3065 (open_inline_file) Removed.
3066 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
3067 it. Deal with line_number in extension record instead of file
3069 (dfm_get_record) Rewrote.
3070 (dfm_put_record) Rewrote.
3071 (dfm_push) Assert file is open and one of ours. Deal with
3072 line_number in extension record instead of file handle.
3073 (dfm_pop) Assert file is open and one of ours. Deal with
3074 line_number in extension record instead of file handle.
3075 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
3078 * file-handle.h: (enum constants RH_RF_*) Removed.
3079 (enum constants FH_MD_*) Removed.
3080 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
3081 `recform', `lrecl', `mode' members. Public references to
3082 `recform' changed to use handle_get_mode(), references to `lrecl'
3083 changed to use handle_get_record_width(). Added `private' member.
3084 (enum file_handle_mode) New.
3086 * file-handle.q: (struct private_file_handle) New structure.
3087 (struct file_handle_list) New structure.
3088 (static var files) New.
3089 (static var file_handles) Removed.
3090 (init_file_handle) Removed.
3091 (create_file_handle) Removed.
3092 (get_handle_with_name) New function.
3093 (get_handle_for_filename) New function.
3094 (cmd_file_handle) Rewritten.
3095 (hash_file_handle) Removed.
3096 (cmp_file_handle) Removed.
3097 (fh_init_files) Rewritten.
3098 (fh_parse_file_handle) Rewritten. Allows identifiers as
3100 (fh_get_handle_by_name) Renamed handle_get_name(), all references
3102 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
3103 references updated. Rewritten.
3104 (fh_record_width) Renamed handle_get_record_width(), all
3105 references updated. Rewritten.
3106 (handle_get_mode) New function.
3108 * file-type.c: (cmd_file_type) Open handle for reading.
3110 * filename.c: [unix] (struct file_identity) New structure.
3111 [unix] (fn_get_identity) New function.
3112 [unix] (fn_free_identity) New function.
3113 [unix] (fn_compare_file_identities) New function.
3114 [!unix] (struct file_identity) New structure.
3115 [!unix] (fn_get_identity) New function.
3116 [!unix] (fn_free_identity) New function.
3117 [!unix] (fn_compare_file_identities) New function.
3119 * lexer.c: (static var put) Renamed put_token, all references
3121 (static var put_tokstr) New.
3122 (static var put_tokval) New.
3123 (lex_init) Initialize put_tokstr().
3124 (restore_token) New function.
3125 (save_token) New function.
3126 (lex_get) Use restore_token().
3127 (lex_put_back) Use save_token().
3128 (lex_put_back_id) New function.
3129 (lex_put_forward) Removed.
3130 (lex_preprocess_line) Set put_token instead of using
3132 (lex_negative_to_dash) Use save_token(), set put_token directly.
3133 (dump_token) Use stderr instead of stdout.
3135 * main.c: (main) Remove call to cmd_init().
3137 * matrix-data.c: (cmd_matrix_data) Open file for reading.
3139 * pfm-read.c: Use handle_get_filename() instead of trying to use
3140 h->fn directly, all over.
3142 * pfm-write.c: Ditto.
3144 * print.c: (internal_cmd_print) Open handle for writing.
3145 (dump_table) Use handle_get_filename().
3146 (print_trns_proc) Use handle_get_mode().
3147 (cmd_print_space) Use fh_parse_file_handle().
3148 Open handle for writing.
3149 [0] (debug_print) Removed.
3151 * sfm-read.c: Use handle_get_filename() instead of trying to use
3152 h->fn directly, all over.
3154 * sfm-write.c: Ditto.
3156 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
3160 * autorecode.c: (arc_free) Free arc->src_values.
3162 * error.c: (msg) Free buf.
3164 * val-labs.c: (do_value_labels) Always free vars.
3166 * vfm.c: (close_active_file) If sink has no make_source then call
3167 its destroy function.
3169 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
3171 Fixed cmd_parse() so that it always skips past a full command
3172 name. A few special commands for which this would be bad get
3173 special treatment. This lets us drop code for skipping past the
3174 end of a command name in most cmd_*() functions. It's not worth
3175 listing all the commands affected.
3177 * command.c: (struct command) Remove `cmd' member, replace by
3178 `name' member, all references updated. Remove `word', `next',
3179 `skip_entire_name' members.
3180 (macro DEFCMD) Deal with revised `struct command'.
3181 (macro UNIMPL) Ditto.
3182 (macro SPCCMD) New macro for commands whose last word shouldn't be
3184 (static array cmd_table[]) Make const, rename `commands', remove
3186 (macro COMMAND_CNT) New macro.
3187 (split_words) Removed.
3189 (FILE_TYPE_okay) Make parameter const.
3190 (cmd_parse) Improve error messages.
3191 (match_strings) New function.
3192 (next_word) New function.
3193 (enum command_match) New enum.
3194 (conflicting_3char_prefixes) New function.
3195 (conflicting_3char_prefix_command) New function.
3196 (cmd_match_words) New function.
3197 (count_matching_commands) New function.
3198 (get_command_name) New function.
3199 (free_words) New function.
3200 (unknown_command_error) New function.
3201 (figure_out_command) Renamed parse_command_name(), rewritten.
3203 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
3204 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
3205 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
3208 * command.h: (macro SPCCMD) New.
3210 * include.c: (cmd_include_at) Removed.
3211 (cmd_include) Allow identifier to be used as filename.
3213 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
3215 * t-test.q: (cmd_t_test) Command name is now parsed for us.
3218 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
3220 Start work on better test framework.
3222 * Makefile.am: (pspp_sources) Add debug.c.
3224 * debug.c: New file.
3226 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3227 cmd_debug_evaluate().
3229 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3231 * expr.h: (enum constant PXP_DUMP) Removed.
3233 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3235 * set.q: Implemented the SHOW command, and synced it to the existing
3238 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3239 changes as the window size is changed.
3241 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3242 environment variables if other methods are not available.
3244 glob.c: Removed a lot of global variables from glob.c and encapsulated
3247 random.c: Tidied up the way the random seed is set.
3249 str.c: Added a ds_vprintf function.
3251 error.c: Extended dump_message so that messages are always broken at
3254 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3256 * pfm-write.c: (bufwrite) Write out the correct element for string
3257 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3259 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3261 Get rid of static and global (!) vars in matrix-data.c.
3263 * matrix-data.c: (static var nr_data) Removed.
3264 (static var nr_factor_values) Removed.
3265 (static var max_cell_index) Removed.
3266 (static var split_values) Removed.
3267 (struct nr_aux_data) New structure.
3268 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3269 place of static vars, pass to create_case_source() and procedure()
3271 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3272 struct matrix_data_pgm *.
3273 (nr_read_splits) Ditto.
3274 (nr_read_factors) Ditto.
3275 (nr_output_data) Ditto.
3276 (static var wr_content) Removed.
3277 (global var wr_data) Removed.
3278 (global var wr_current) Removed.
3279 (struct wr_aux_data) New structure.
3280 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3281 place of static vars, pass to create_case_source() and procedure()
3283 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3284 instead of matrix_data_pgm *.
3285 (wr_read_splits) Ditto.
3286 (wr_output_data) Ditto.
3287 (wr_read_rowtype) Ditto.
3288 (wr_read_factors) Ditto.
3289 (wr_read_indeps) Ditto.
3291 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3293 Get rid of static vars in autorecode.c.
3295 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3296 `n_arc' to `spec_cnt'. All references updated.
3297 (static var v_src) Removed.
3298 (static var v_dest) Removed.
3299 (static var h_trns) Removed.
3300 (static var nv_src) Removed.
3301 (static var descend) Removed.
3302 (static var print) Removed.
3303 (enum direction) New enum.
3304 (struct autorecode_pgm) New structure.
3305 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3306 Move n_dest local var into struct autorecode_pgm for ease of
3307 clean-up. Use arc_free().
3308 (arc_free) New function.
3309 (recode) Modify to take struct autorecode_pgm * parameter instead
3310 of using statics. Let the caller clean up.
3311 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3312 instead of statics. Rearrange code a little.
3314 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3316 Get rid of static, global vars in recode.c. Remove debug code.
3318 * recode.c: (static var head) Removed.
3319 (global var v) Removed.
3320 (global var nv) Removed.
3321 (cmd_recode) New local variables head, v, nv. Initialize and free
3322 v. Don't call debug_print().
3323 [DEBUGGING] (dump_dest) Removed.
3324 [DEBUGGING] (debug_print) Removed.
3326 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3328 Get rid of static vars in expr-opt.c.
3330 * expr-opt.c: (static var e) Removed.
3331 (static var nop) Removed.
3332 (static var mop) Removed.
3333 (static var ndbl) Removed.
3334 (static var mdbl) Removed.
3335 (static var nstr) Removed.
3336 (static var mstr) Removed.
3337 (static var nvars) Removed.
3338 (static var mvars) Removed.
3339 (struct expr_dump_state) New structure.
3340 (dump_expression) Use new struct expr_dump_state instead of static
3341 vars and pass to functions we call.
3342 (dump_node) Use struct expr_dump_state * parameter.
3344 (emit_num_con) Ditto.
3345 (emit_str_con) Ditto.
3348 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3350 Get rid of static var in COUNT.
3352 * count.c: (static var head) Move into cmd_count().
3353 (cmd_count) [DEBUGGING] Don't call debug_print.
3354 [DEBUGGING] (debug_print) Removed.
3356 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3358 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3360 * val-labs.c: (static var v) Removed.
3361 (static var nv) Removed.
3362 [DEBUGGING] (debug_print) Removed.
3363 (verify_val_labs) Add struct variable **, int parameters.
3364 (get_label) Ditto. Improve error messages, streamline.
3365 (erase_labels) New function for erasing value labels, taking over
3366 part of verify_val_labs()'s function.
3369 (cmd_value_labels) No need to call init() or done() anymore.
3370 (cmd_add_value_labels) Ditto.
3371 (do_value_labels) Add vars, var_cnt local variables. Clean up
3372 after them internally. Call erase_labels() if we should. Don't
3375 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3377 Get rid of static vars in MATCH FILES.
3379 * get.c: (static var mtf_head) Removed.
3380 (static var mtf_tail) Removed.
3381 (static var mtf_by) Removed.
3382 (static var mtf_n_by) Removed.
3383 (static var mtf_master) Removed.
3384 (static var mtf_seq_num) Removed.
3385 (static var mtf_seq_nums) Removed.
3386 (static var mtf_sink) Removed.
3387 (static var mtf_case) Removed.
3388 (struct mtf_proc) New structure.
3389 (cmd_match_files) Use struct mtf_proc instead of static vars.
3390 (mtf_processing_finish) Ditto.
3392 (mtf_delete_file_in_place) Ditto.
3393 (mtf_read_nonactive_records) Ditto.
3394 (mtf_compare_BY_values) Ditto.
3395 (mtf_processing) Ditto.
3396 (mtf_merge_dictionary) Ditto.
3398 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3400 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3402 * dictionary.c: (dict_rename_var) Add assertion.
3403 (dict_contains_var) Check by index instead of name.
3405 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3407 Get rid of compaction_necessary, compaction_nval, compaction_case.
3408 Redo VFM interface. Replace disk_sink and memory_sink by
3409 storage_sink, disk_source and memory_source by storage_source.
3411 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3415 (struct write_case_data) Remove `begin_func', `end_func',
3416 `func_aux' members. Add `aux', `trns_case', `sink_case',
3417 `cases_written', `cases_analyzed' members.
3418 (global var compaction_necessary) Make static.
3419 (global var compaction_nval) Removed.
3420 (global var compaction_case) Removed.
3421 (static var case_count) Removed.
3422 (struct procedure_aux_data) Removed.
3423 (struct split_aux_data) Removed.
3424 (procedure) Remove begin_func, end_func parameters. Rewrite.
3425 (static var not_canceled) Removed.
3426 (process_active_file) Removed.
3427 (process_active_file_write_case) Removed.
3428 (process_active_file_output_case) Removed.
3429 (prepare_for_writing) Moved into open_active_file().
3430 (arrange_compaction) Ditto.
3432 (open_active_file) Rewrote.
3433 (write_case) New function.
3434 [DEBUGGING] (index_to_varname) Removed.
3435 (execute_transformations) New function.
3436 (exclude_this_case) Renamed filter_case(), changed interface.
3437 (clear_case) Added struct ccase * parameter to interface.
3438 (close_active_file) Added struct write_case_data * parameter,
3440 (disk_sink_create) Removed.
3441 (disk_sink_destroy) Removed.
3442 (disk_sink_make_source) Removed.
3443 (disk_sink_write) Removed.
3444 (disk_source_count) Removed.
3445 (disk_source_destroy) Removed.
3446 (disk_source_read) Removed.
3447 (global var disk_sink_class) Removed.
3448 (global var disk_source_class) Removed.
3449 (global var memory_sink_class) Removed.
3450 (global var memory_source_class) Removed.
3451 (memory_sink_create) Removed.
3452 (memory_sink_destroy) Removed.
3453 (memory_sink_make_source) Removed.
3454 (memory_sink_write) Removed.
3455 (memory_source_count) Removed.
3456 (memory_source_destroy) Removed.
3457 (memory_source_get_cases) Removed.
3458 (memory_source_read) Removed.
3459 (memory_source_set_cases) Removed.
3460 (struct disk_stream_info) Removed.
3461 (struct memory_sink_info) Removed.
3462 (struct memory_source_info) Removed.
3463 (write_active_file_to_disk) Removed.
3464 (destroy_storage_stream_info) New function.
3465 (global var null_sink_class) New var.
3466 (global var storage_sink_class) New var.
3467 (global var storage_source_class) New var.
3468 (open_storage_file) New function.
3469 (storage_sink_destroy) New function.
3470 (storage_sink_make_source) New function.
3471 (storage_sink_open) New function.
3472 (storage_sink_write) New function.
3473 (storage_source_count) New function.
3474 (storage_source_destroy) New function.
3475 (storage_source_get_cases) New function.
3476 (storage_source_on_disk) New function.
3477 (storage_source_read) New function.
3478 (storage_source_set_cases) New function.
3479 (storage_source_to_disk) New function.
3480 (storage_to_disk) New function.
3481 (struct storage_stream_info) New structure.
3482 (write_storage_file) New function.
3483 (procedure_write_case) Removed.
3484 (create_case_source) Add `struct dictionary *' parameter, all
3486 (create_case_sink) Ditto.
3487 (free_case_sink) New function.
3488 (struct split_aux_data) New structure.
3489 (procedure_with_splits) New function implementing what procedure()
3491 (SPLIT_FILE_proc_func) Removed.
3492 (procedure_with_splits_callback) New function.
3493 (equal_splits) New function.
3495 * aggregate.c: Pass around a struct instead of using statics.
3496 (static var outfile) Remove.
3497 (enum type) Give it tag `missing_treatment'.
3498 (static var missing) Remove.
3499 (static var sort) Remove.
3500 (static var agr_first) Remove.
3501 (static var agr_next) Remove.
3502 (static var case_count) Remove.
3503 (static var prev_case) Remove.
3504 (static var buf64_1xx) Remove.
3505 (static var buf_1xx) Remove.
3506 (struct agr_proc) New structure incorporating the above.
3507 (cmd_aggregate) Use new struct. Clean up error handling using
3508 agr_destroy(). Completely rewrite actual implementation of
3510 (create_sysfile) Add struct agr_proc * parameter, modify
3512 (parse_aggregate_functions) Ditto.
3513 (free_aggregate_functions) Ditto. Rename agr_destroy().
3514 (aggregate_single_case) Add struct agr_proc * parameter, modify
3516 (accumulate_aggregate_info) Ditto.
3517 (dump_aggregate_info) Ditto.
3518 (initialize_aggregate_info) Ditto.
3519 (agr_00x_trns_proc) Removed.
3520 (agr_00x_end_func) Removed.
3521 (agr_10x_trns_proc) Removed.
3522 (agr_10x_trns_free) Removed.
3523 (agr_10x_end_func) Removed.
3524 (agr_11x_read) Removed.
3525 (agr_11x_finish) Removed.
3526 [DEBUGGING] (debug_print) Removed.
3527 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3529 (agr_to_active_file) New function.
3530 (presorted_agr_to_sysfile) New function.
3531 (sort_agr_to_sysfile) New function.
3533 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3535 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3537 * descript.q: (cmd_descriptives) Ditto.
3539 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3540 to new procedure() interface.
3542 * command.c: (cmd_execute) Adapt to new procedure() interface.
3544 * dictionary.c: (dict_compact_values) Also delete scratch
3546 (dict_get_compacted_value_cnt) New function.
3547 (dict_get_compacted_idx_to_fv) New function.
3549 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3550 (cmd_flip) Adapt to new procedure() interface.
3551 (flip_sink_write) Use sink->idx_to_fv.
3553 * frequencies.q: (internal_cmd_frequencies) Use
3554 procedure_with_splits().
3556 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3557 (static var mtf_sink) New static var.
3558 (static var mtf_case) New static var.
3559 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3560 we actually implement the matching.
3561 (mtf_delete_file_in_place) Use mtf_case.
3562 (mtf_processing) Use mtf_case and mtf_sink.
3563 (cmd_export) Adapt to new procedure() interface.
3565 * levene.c: (levene) Use procedure_with_splits().
3567 * list.q: (cmd_list) Use procedure_with_splits().
3569 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3570 procedure() interface.
3571 (read_matrices_with_rowtype) Ditto.
3573 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3574 TEMPORARY. Adapt to new procedure() interface.
3576 * rename-vars.c: Warn about and cancel TEMPORARY.
3578 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3579 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3580 compaction_nval. Adapt to new procedure() interface. Use
3581 storage_source_to_disk().
3582 (do_internal_sort) Don't try to dump the cases to memory.
3583 (compare_case_lists) Pass null idx_to_fv.
3584 (struct initial_run_state) Add `idx_to_fv' member. Remove
3586 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3587 new procedure() interface. Reset irs->idx_to_fv after calling
3589 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3590 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3592 (destroy_initial_run_state) Don't dereference irs after freeing
3594 (allocate_cases) Don't calculate case_size locally.
3595 (compare_record) Add idx_to_fv parameter.
3596 (compare_record_run) Change parameter from struct sort_cases_pgm *
3597 to struct initial_run_state *. Pass irs->idx_to_fv to
3599 (compare_record_run) Third parameter now a struct
3600 initial_run_state *.
3601 (output_record) No need for out_case anymore. Pass irs, not
3602 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3604 (merge) Use case_size from struct sort_cases_pgm.
3605 (merge_once) Use case_size from struct sort_cases_pgm.
3606 Pass null pointer to compare_record() as idx_to_fv.
3607 (global var sort_sink_class) Make static.
3609 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3611 * temporary.c: Remove debugging crap.
3613 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3615 * t-test.q, levene.c: Fixed up the handling of MISSING values
3618 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3620 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3623 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3625 Change explicit variable name checks into use of
3626 dict_class_from_id().
3628 * dictionary.c: (dict_create_var) Change explicit variable name
3629 check into use of dict_class_from_id().
3631 * get.c: (trim_dictionary) Ditto.
3633 * sel-if.c: (cmd_filter) Ditto.
3635 * sysfile-info.c: (cmd_display) Ditto.
3637 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3639 * vfm.c: (arrange_compaction) Ditto.
3641 * weight.c: (cmd_weight) Ditto.
3643 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3645 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3646 transformation following the input program, if any, for some
3647 reason we special-cased f_trns. That's just wrong. It should
3648 always be set to n_trns.
3650 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3652 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3653 introduced in last check-in.
3655 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3657 * format.c: (global array translate_fmt[]) Removed.
3658 (translate_fmt) New function as replacement.
3659 (parse_format_specifier_name) Rewrite.
3661 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3664 * sfm-read.c: (parse_format_spec) Ditto.
3666 * postscript.c: (text) Fix handling of fonts with missing
3669 * sort.c: (struct external_sort) Add temp_name member.
3670 (destroy_external_sort) Free temp_dir, temp_name members.
3671 (init_external_sort) Allocate temp_name.
3672 (get_temp_file_name) Change prototype.
3673 (open_temp_file) Deal with change to get_temp_file_name().
3674 (close_temp_file) Ditto.
3675 (remove_temp_file) Ditto.
3676 (write_temp_file) Ditto.
3677 (read_temp_file) Ditto.
3678 (sort_sink_destroy) Removed.
3679 (sort_sink_class) Change destroy member to null.
3681 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3683 Eliminate temp_case.
3685 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3686 anymore. Use agr_11x_finish().
3687 (aggregate_single_case) Make first param const.
3688 (accumulate_aggregate_info) Ditto.
3689 (agr_00x_end_func) Use compaction_case, not temp_case.
3690 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3692 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3693 (cmd_data_list) Initialize case_size.
3694 (read_from_data_list_fixed) Add struct ccase * param, use instead
3696 (read_from_data_list_free) Ditto.
3697 (read_from_data_list_list) Ditto.
3698 (read_one_case) Rename data_list_trns_proc(), all references
3699 updated. Add argument in calling above functions. Use c
3700 argument instead of temp_case.
3701 (destroy_dls) Rename data_list_trns_free(), all references
3704 * expr-evl.c: (expr_evaluate) Make second parameter const.
3706 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3707 (cmd_end_file_type) Initialize `case_size'.
3708 (file_type_source_read) Add struct ccase * parameter. Use instead
3711 * flip.c: Rewritten.
3713 * get.c: (struct get_pgm) New structure to keep track of
3715 (cmd_get) Initialize case_size.
3717 (get_source) Deal with struct get_pgm.
3718 (get_source_read) Add struct ccase * parameter, use instead of
3720 (import_source_read) Ditto.
3722 * get.c: Use a null pointer instead of temp_case to represent the
3723 "current case" in a struct mtf_file's input member.
3724 (mtf_processing_finish) Pass null to mtf_processing(), not
3726 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3727 (mtf_compare_BY_values) Add extra arg, use instead of null input
3729 (mtf_processing) Use c parameter instead of temp_case. Pass
3730 compaction_case to process_active_file_output_case().
3732 * glob.c: (global variable temp_case) Removed.
3734 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3735 (cmd_input_program) Initialize case_size. Set
3736 vfm_source->value_cnt.
3737 (init_case) Add struct ccase * parameter, use instead of
3740 (input_program_source_read) Ditto.
3742 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3743 (dump_cell_content) Ditto.
3744 (nr_output_data) Ditto.
3745 (read_matrices_without_rowtype) Ditto.
3746 (matrix_data_read_with_rowtype) Ditto.
3747 (wr_read_splits) Ditto.
3748 (wr_output_data) Ditto.
3750 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3752 * sort.c: (sort_cases) Initialize scp->case_size.
3753 (struct external_sort) Remove `case_size' member.
3754 (write_initial_runs) Only call vfm_sink->class_destroy if
3756 (struct sort_source_aux) New structure.
3757 (sort_source_read_helper) New function.
3758 (sort_source_read) Use sort_source_read_helper().
3759 (read_sort_output) Change interface to be more reasonable.
3760 (read_internal_sort_output) Ditto.
3761 (read_external_sort_output) Ditto.
3763 * vars-prs.c: (dict_class_to_name) Pass return value through
3766 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3767 (procedure) Initialize trns_case.
3768 (procedure) Pass trns_case to vfm_source->class->read().
3770 (process_active_file) Start using struct procedure_aux_data.
3771 (process_active_file_write_case) Pass trns_case to
3772 transformations, lag_case(), clear_case().
3773 (process_active_file_output_case) Add struct ccase * parameter.
3774 (create_trns_case) New function.
3775 (make_temp_case) Removed.
3776 (vector_initialization) Removed.
3777 (close_active_file) Only call make_source if non-null, otherwise
3778 set vfm_source to null pointer. Don't free temp_case.
3779 (disk_source_read) Add struct ccase * parameter, use instead of
3781 (memory_source_read) Ditto.
3782 (lag_case) Add const struct ccase * member.
3783 (procedure_write_case) Use trns_case instead of temp_case.
3784 (clear_case) Add struct ccase * member, use instead of temp_case.
3785 (exclude_this_case) Ditto.
3786 (create_case_source) Add struct dictionary * parameter, use to
3787 initialize source->value_cnt.
3789 * vfm.h: (struct case_source) Add `value_cnt' member.
3790 (struct case_source_class) Add struct ccase * parameter to `read'
3791 member function pointer.
3792 (struct case_sink_class) Make struct ccase * parameter const in
3793 `write' member function pointer.
3795 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3797 Fix a lot of "possibly uninitialized variable" warnings. Some of
3798 them are even real bugs. A few of them make me wonder how the
3801 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3803 * ascii.c: (output_lines) Add default case to switch.
3805 * crosstabs.q: Remove static variable `expected' and all
3807 (display_crosstabulation) Always calculate expected value.
3809 (output_pivot_table) Initialize `cmp'.
3810 (display_crosstabulation) New variable `last_row', which is
3813 * data-in.c: (parse_numeric) Always initialize sign. How did this
3816 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3817 Always set info.ofs. (How did this work?!)
3819 * expr-opt.c: (optimize_tree) Always initialize `m'.
3820 (evaluate_tree) Always initialize `c'. (How did this work?)
3822 * frequencies.q: (frq_custom_variables) Always initialize min,
3824 (frq_custom_grouped) Always initialize `dl'.
3826 * groff-font.c: (groff_read_font) Always initialize char_set.
3828 * matrix-data.c: (nr_output_data) Initialize `split'.
3829 (wr_read_splits) Remove shadowing split_cnt declaration.
3830 (wr_output_data) Initialize `split'.
3832 * output.c: (tokener) Skip add character on syntax error.
3834 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3836 * postscript.c: (read_ps_encodings) Use line.string instead of
3838 (write_text) Add default case to switch.
3839 (text) Always initialize multiple variables. Fix bug with
3842 * print.c: (fixed_parse_fortran) Initialize head.
3843 (alloc_line) Add default case to switch.
3845 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3846 (recode_trns_proc) Move variable declaration inward. Add default
3849 * sfm-read.c: (read_header) Initialize skip_amt.
3851 * sysfile-info.c: (display_variables) Always initialize pc.
3853 * vars-prs.c: Initialized `included'.
3855 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3857 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3858 Just use signal() instead.
3860 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3862 Get rid of vfm_sink_info and vfm_source_info.
3864 * aggregate.c: (agr_00x_end_func) Don't increment
3865 sfm_sink_info.ncases.
3867 * sort.c: (do_internal_sort) Get case count from
3868 vfm_source->class->count().
3869 (struct external_sort) Add `case_size' member.
3870 (do_external_sort) Initialize case_size.
3871 (struct initial_run_state) Add `case_size' member.
3872 (write_initial_runs) Initialize case_size.
3873 (sort_sink_write) Use case_size.
3874 (read_external_sort_output) Use case_size. Get case_cnt from
3877 * vfm.c: (struct write_case_data) Add underscores to existing arg
3878 names, all references updated. Renamed `aux' as `func_aux', all
3879 references updated. Added new `aux' member.
3880 (global var vfm_source_info) Removed.
3881 (global var vfm_sink_info) Removed.
3882 (struct procedure_aux_data) New.
3883 (struct split_aux_data) New.
3884 (procedure) Use `aux' fields for procedure_aux_data,
3886 (process_active_file_write_case) Pass case_count + 1 to
3887 transformation procedures, exclude_this_case().
3888 (process_active_file_output_case) Don't increment
3889 vfm_sink_info.ncases.
3890 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3891 to send data to disk early.
3892 (make_temp_case) Don't use vfm_sink_info.case_size.
3893 (close_active_file) Don't initialize vfm_source_info.
3894 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3895 (disk_sink_create) Initialize and/or update disk_stream_info.
3896 (disk_sink_write) Ditto.
3897 (disk_sink_destroy) Ditto.
3898 (disk_sink_make_source) Ditto.
3899 (disk_source_read) Ditto.
3900 (disk_source_destroy) Ditto.
3901 (global var disk_source_class) Add disk_source_count().
3902 (disk_source_count) New function.
3903 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3904 (struct memory_source_info) Ditto.
3905 (memory_sink_create) Deal with case_cnt, case_size.
3906 (memory_sink_write) Ditto.
3907 (memory_sink_make_source) Ditto.
3908 (memory_source_read) Ditto.
3909 (memory_source_count) New function.
3910 (memory_source_class) Add memory_source_count().
3911 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3912 proc_aux->cases_written, and pass it to transformation procedures
3913 and exclude_this_case ().
3914 (exclude_this_case) Add case_num parameter. Pass it to
3916 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3919 * vfm.h: (struct case_source_class) Add `count' member.
3921 * vfmP.h: (struct stream_info) Removed.
3922 (global variable vfm_source_info) Removed.
3923 (global variable vfm_sink_info) Removed.
3925 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3927 * var.h: (typedef trns_proc_func) New typedef.
3928 (trns_free_func) New typedef.
3929 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3930 to type trns_free_func. This only changes the actual type of
3931 trns_proc_func, adding a `case_num' parameter. Updated all
3932 implementations to use the typedefs instead.
3934 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3935 (compute_num_vec) Ditto.
3936 (compute_str) Ditto.
3937 (compute_str_vec) Ditto.
3939 * do-if.c: (do_if_trns_proc) Ditto.
3941 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3944 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3945 pass to transformation functions.
3946 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3948 * loop.c: (loop_1_trns_proc) Ditto.
3949 (loop_2_trns_proc) Ditto.
3950 (loop_3_trns_proc) Ditto.
3952 * print.c: (print_space_trns_proc) Ditto.
3954 * sel-if.c: (select_if_proc) Ditto.
3956 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3958 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3959 destroying hash table.
3961 * glob.c: (read_active_file) Variable not referenced, removed.
3962 (cancel_input_pgm) Ditto.
3964 * levene.c: Add #include <stdlib.h> needed to call free().
3966 * aggregate.c: (parse_aggregate_functions) Make `function'
3969 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3971 Start working to eliminate VFM dependence on static variables.
3973 * command.c: (cmd_parse) Use case_source_is_class().
3975 * data-list.c: Rewrite to eliminate use of static variables.
3977 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3979 * file-handle.q: (fh_handle_name) Make parameter const.
3981 * file-type.c: Rewrite to eliminate use of static variables.
3983 * flip.c: Rewrite to eliminate use of static variables.
3985 * format.c: (get_format_var_width) New function.
3987 * get.c: Eliminate use of static variables.
3989 * inpt-pgm.c: Eliminate use of static variables.
3991 * matrix-data.c: Eliminate use of static variables.
3993 * set.q: (set_max_workspace) New variable.
3994 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3996 * var.h: (struct case_list) Move here from vfmP.h.
3998 * vars-atr.c: (discard_variables) Handle new vfm_source type.
4000 * vfm.c: (vfm_source) Change type from struct case_stream to
4002 (vfm_sink) Change type from struct case_stream to struct
4004 (static var paging) Rename workspace_overflow, all references
4006 (procedure) Use new class structures.
4007 (process_active_file) Ditto.
4008 (process_active_file_write_case) Ditto.
4009 (prepare_for_writing) Use set_max_workspace. Use new class
4011 (close_active_file) Use new class structures. Free old sink.
4012 (global var disk_source_file) Removed.
4013 (global var disk_sink_file) Removed.
4014 (disk_stream_init) Removed.
4015 (disk_stream_read) Removed.
4016 (disk_stream_write) Removed.
4017 (disk_stream_mode) Removed.
4018 (disk_stream_destroy_source) Removed.
4019 (disk_stream_destroy_sink) Removed.
4020 (global var vfm_disk_stream) Removed.
4021 (disk_sink_create) New function.
4022 (disk_sink_write) New function.
4023 (disk_sink_destroy) New function.
4024 (disk_sink_make_source) New function.
4025 (disk_sink_class) New static var.
4026 (disk_source_read) New function.
4027 (disk_source_destroy) New function.
4028 (global var vfm_source_class) New var.
4029 (global var memory_source_cases) Removed.
4030 (global var memory_sink_cases) Removed.
4031 (global var memory_sink_max_cases) Removed.
4032 (struct memory_sink_info) New struct.
4033 (memory_stream_init) Removed.
4034 (memory_stream_read) Removed.
4035 (memory_stream_write) Removed.
4036 (memory_stream_mode) Removed.
4037 (memory_stream_destroy_source) Removed.
4038 (memory_stream_destroy_sink) Removed.
4039 (global var vfm_memory_stream) Removed.
4040 (page_to_disk) Renamed write_active_file_to_disk().
4041 (memory_sink_create) New function.
4042 (memory_sink_write) New function.
4043 (memory_sink_destroy) New function.
4044 (memory_sink_make_source) New function.
4045 (memory_sink_class) New static var.
4046 (memory_source_read) New function.
4047 (memory_source_destroy) New function.
4048 (memory_source_get_cases) New function.
4049 (memory_source_set_cases) New function.
4050 (global var vfm_source_class) New var.
4051 (procedure_write_case) Use new class structures.
4052 (create_case_source) New function.
4053 (case_source_is_complex) New function.
4054 (case_source_is_class) New function.
4055 (create_case_sink) New function.
4057 * vfm.h: (global variable reinit_sysmis) Not used, removed.
4058 (global variable reinit_blanks) Not used, removed.
4059 (global variable init_zero) Not used, removed.
4060 (global variable init_blanks) Not used, removed.
4061 (struct case_source) New struct.
4062 (struct case_source_class) New struct.
4063 (struct case_sink) New struct.
4064 (struct case_sink_class) New struct.
4065 (struct case_stream) Removed.
4067 * vfmP.h: (struct case_list) Moved to var.h.
4069 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
4071 * algorithm.c: (count_equal) New function.
4072 (count_if) New function.
4073 (unique) Add assertions.
4074 (partition) Add assertions.
4075 (is_partitioned) New function.
4076 (copy_if) Add assertions.
4077 (remove_equal) Add assertions.
4078 (lexicographical_compare) Rename lexicographical_compare_3way.
4079 (sort) Add assertions. Rephrase some code.
4080 (is_sorted) New function.
4082 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
4086 * sort.c: Completely rewrite.
4088 * sort.h: Expose interface via struct sort_cases_pgm, not via
4091 * aggregate.c: (sort) New static var.
4092 (cmd_aggregate) Use sort.
4093 (create_sysfile) Ditto.
4094 (aggregate_single_case) Ditto.
4095 (dump_aggregate_info) Ditto.
4096 (agr_00x_end_func) Ditto.
4097 (debug_print) Ditto.
4099 * var.h: (enum SRT_ASCEND) Removed.
4100 (enum SRT_DESCEND) Removed.
4101 (struct sort_cases_proc) Removed.
4102 (struct variable) Remove p.srt member.
4104 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
4106 Get rid of the old, crappy heap structure and replace it by a new,
4107 shiny, C++ STL-like heap structure.
4109 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
4111 * algorithm.c: (push_heap) New function.
4122 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
4124 Increase warning level.
4126 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
4128 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
4130 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
4132 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
4134 * dictionary.c: (dict_create_var) Fix root cause of bug worked
4135 around by previous change log entry.
4137 * compute.c: (lvalue_finalize) Remove workaround from previous
4140 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4142 * compute.c: Fixed a bug where the Format was not getting set for
4143 computed variables (thus causing a crash when SAVEing).
4145 * Added a test to stop this bug ever coming back
4147 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
4149 Got rid of approx.h. In general, replaced all references to
4150 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
4153 * Makefile.am: (pspp_SOURCES) Removed approx.h.
4155 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
4156 test for mag < EPSILON.
4158 * misc.h: Add definition of EPSILON.
4160 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
4162 * vfm.c: (procedure) Add check to prevent recursive call.
4164 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
4166 * Moved the declarations relating to values to their own header file
4169 * Added levene.c and levene.h
4171 * vars-atr.c: Changed the signature of compare_values to
4172 take const * arguments.
4174 * t-test.q: Changed the structure of struct t_test_proc
4175 variables now contain their own group statistics information.
4176 Eventually, t_test_proc might get renamed, because it'd be
4177 applicable to other commands too.
4179 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
4181 * data-out.c: Clean up. Changed interface of convert_*() to take
4182 either a `double' or a `const char *' instead of a `const union
4183 value *'. Update all implementations of those interfaces.
4184 (data_out) Use switch statements instead of a table.
4185 (convert_AHEX) Rewrite.
4187 * format.h: Update comment.
4189 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
4191 * q2c.c: (dump_header) Add an Emacs header line to output files
4192 that makes generated .c files read-only by default, to make it
4193 difficult to accidentally change generated files.
4195 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
4197 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
4198 not bogus a->v.c <=> b->v.c pointer compare.
4199 (compare_freq_alpha_a) Ditto.
4200 (compare_freq_numeric_d) Ditto.
4201 (compare_freq_alpha_d) Ditto.
4203 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
4205 Changed data_out() to store string data directly into a `union
4206 value''s s member, not indirectly into c.
4208 * crosstabs.q: (output_pivot_table) Use format_short() instead of
4210 (table_value_missing) Ditto.
4211 (float_M_suffix) Ditto.
4212 (format_short) New function.
4214 * data-in.h: (data_in_finite_line) Remove inline definition.
4216 * data-list.c: (destroy_dls_var_spec) New function.
4217 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
4218 (data_list_source_destroy_source) Avoid cast.
4219 (struct repeating_data_trns) New field `id_value'. Update
4221 (cmd_repeating_data) Initialize id_value. Use new
4222 repeating_data_trns_free() for freeing REPEATING DATA
4224 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4225 (repeating_data_trns_free) New function.
4227 * data-out.c: (data_out) Change return type to `void' by replacing
4228 error returns by writing a message into the output buffer.
4229 (convert_A) Read from v->s instead of v->c.
4230 (convert_AHEX) Ditto.
4232 * expr-evl.c: Update comment.
4233 (expr_evaluate) Add assertion in OP_STRING case.
4235 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4237 * list.q: (list_cases) Update for new data_out() semantics.
4239 * print.c: (print_trns_proc) Ditto.
4241 * tab.c: (tab_value) Ditto.
4242 (tab_float) Avoid stupid cast.
4244 * var.h: Update comments.
4245 (macro MAX_STRING) New macro.
4246 (macro MAX_ELEMS_PER_VALUE) New macro.
4248 * vars-atr.c: (compare_values) New function.
4250 * vfm.c: (dump_splits) Update for new data_out() semantics.
4252 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4254 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4256 (struct crosstab) Rename v[] to vars[]. All references updated.
4257 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4258 same time, which caused the hash value to depend only on a single
4259 value, not all of the variables' values.
4261 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4263 Clean up struct dictionary's value_cnt usage.
4265 * dictionary.c: Add a function comment to each function.
4266 (struct dictionary) Rename value_cnt to next_value_idx, which more
4267 accurately reflects its meaning. All references updated.
4268 (dict_rename_vars) Add assertion.
4269 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4271 (dict_get_case_size) New function.
4273 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4275 * get.c: (mtf_read_nonactive_records) Ditto.
4277 * sort.c: (allocate_cases) Ditto.
4278 (write_initial_runs) Ditto.
4282 * vfm.c: (prepare_for_writing) Ditto.
4286 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4288 Make vfm.c slightly less grotesque.
4290 * vfm.c: (filter_var) Removed.
4291 (filter_index) Removed.
4292 (FILTERED macro) Removed.
4293 (exclude_this_case) New function.
4294 (process_active_file_write_case) Use exclude_this_case() instead
4295 of FILTERED and inline tests.
4296 (procedure_write_case) Ditto.
4297 (setup_filter) Removed.
4298 (open_active_file) Don't call setup_filter().
4299 (close_active_file) Call dict_get_filter() instead of checking
4302 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4304 * var.h: (struct variable) Update comments.
4306 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4308 New functions dict_create_var_assert(), dict_lookup_var_assert().
4309 Converted several dict_*_var()/assert pairs into a single
4310 dict_*_var_assert().
4312 * dictionary.c: (dict_create_var_assert) New function.
4313 (dict_lookup_var_assert) New function.
4315 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4317 Got rid of "struct long_vec", envector(), devector(), etc. Added
4318 two members `init', `reinit' to struct variable as a substitute.
4320 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4326 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4329 * autorecode.c: (cmd_autorecode) destvars don't need init.
4331 * compute.c: (lvalue_finalize) Set reinit.
4333 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4334 (dump_fmt_list) Ditto.
4337 * descript.q: (run_z_pass) Don't need init for z-scores.
4339 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4341 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4343 * glob.c: (init_glob) Remove vec_init() calls.
4345 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4347 * loop.c: (internal_cmd_loop) Don't need to call envector().
4349 * numeric.c: (cmd_numeric) Ditto.
4351 (cmd_leave) Ditto. Set `init', `reinit' members.
4353 * recode.c: (cmd_recode) Don't need to call envector().
4355 * repeat.c: (internal_cmd_do_repeat) Ditto.
4357 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4358 (force_create_variable) Removed prototype.
4359 (force_dup_variable) Ditto.
4361 * vector.c: (cmd_vector) Don't need to call envector().
4363 * vfm.c: (reinit_sysmis) Removed.
4364 (reinit_blanks) Removed.
4365 (init_zero) Removed.
4366 (init_blanks) Removed.
4367 (process_active_file_write_case) No need to deal with vectors.
4368 Call clear_temp_case().
4369 (vector_initialization) Rewrite to use `init', `reinit'.
4370 (close_active_file) No need to call vec_clear().
4371 (procedure_write_case) Call clear_temp_case().
4372 (clear_temp_case) New function.
4374 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4376 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4379 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4381 Add auxiliary argument to procedure() interface. Associated small
4382 clean-ups of vfm interface.
4384 * Updated every caller of procedure() and process_active_file() to
4385 reflect modified interface. Simple, ordinary changes not listed
4388 * Updated every function that implements struct case_stream's
4389 `read' function to take a write_case_func and a write_case_data.
4390 Also updated every caller of write_case() to instead call them
4391 through these arguments. In some cases this meant that the extra
4392 args had to be threaded through a couple of extra levels. This
4393 wasn't difficult or interesting so the details won't be given.
4395 * data-list.c: (struct repeating_data_trns) Add members
4396 `write_case', `wc_data' as kluge.
4397 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4399 (repeating_data_set_write_case) New function.
4401 * data-list.h: New file to declare repeating_data_trns_proc() and
4402 repeating_data_set_write_case().
4404 * inpt-pgm.c: (input_program_source_read) Call
4405 repeating_data_set_write_case() for all the REPEATING DATA
4406 transformations, so that they know where to send their cases.
4407 It's a big kluge. Also kluge in END CASE.
4408 (end_case_trns_proc) Never called anymore, but we still need it,
4411 * sort.c: (read_sort_output) Update to match struct case_stream
4414 * vfm.c: (struct write_case_data) New structure.
4415 (proc_func) Removed.
4416 (virt_proc_func) Removed.
4417 (begin_func) Removed.
4418 (virt_begin_func) Removed.
4420 (write_case) Removed.
4421 (procedure) Added an auxiliary parameter to each function pointer
4422 argument's prototype. Added an auxiliary data parameter.
4424 (process_active_file) Ditto.
4425 (process_active_file_write_case) Pass aux data along.
4426 (close_active_file) Ditto.
4427 (procedure_write_case) Ditto.
4428 (SPLIT_FILE_procfunc) Ditto.
4430 * vfm.h: (typedef write_case_data) New.
4431 (typedef write_case_func) New.
4432 (struct case_stream) Add parameters to `read' member prototype.
4434 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4436 * t-test.q: Added calculations for independent samples. (But no Levene
4439 * Makefile.am: Moved q_sources_c into own variable
4441 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4443 Miscellaneous cleanups.
4445 * Change unused to UNUSED in many source files to reflect modified
4446 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4447 __CYGWIN32__, __unix__, and unix not to assume that they're
4448 defined to a nonzero value. Change use of __attribute__ to use
4449 NO_RETURN or PRINTF_FORMAT instead.
4451 * alloc.h: Move definitions for local_alloc(), local_free() here
4452 from ../pref.h.orig and simplify.
4454 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4455 use a pool allocator unconditionally.
4456 (CHECK_STRING_SPACE) Removed.
4457 (ALLOC_STRING_SPACE) Removed.
4458 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4461 * expr-opt.c: (dump_expression) Allocate string pool.
4463 * expr-prs.c: (expr_free) Free string pool.
4465 * pool.c: (pool_destroy) This pool must be removed from its
4466 parent's list of gizmos, not from its own. Use free_all_gizmos().
4467 (pool_clear) New function.
4468 (free_all_gizmos) New function.
4469 (pool_alloc) Use space in empty block after this one if any.
4470 (pool_release) Only empty out blocks, don't actually free() them.
4472 * print.c: Get rid of PAGED_STACK special case by always
4473 dynamically allocating line buffers.
4474 (struct print_trns) Always include the `line' member.
4475 (internal_cmd_print) Always initialize the `line' member.
4476 (alloc_line) Always allocate memory for `line'.
4477 (print_trns_proc) Always initialize buf from `line' member.
4478 (print_trns_free) Always free `line' memory.
4480 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4483 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4485 * flip.c: Fixed crash from FLIP when a numeric variable is
4486 specified on NEWNAMES and a large value is used, and a couple of
4487 other minor bugs besides.
4488 (struct varname) Make name a 9-character fixed-size array
4489 instead of a 1-character variable size array.
4490 (make_new_var) Allow digits in variable names.
4491 (flip_stream_write) Limit numeric values to 8 characters and
4492 format system missing and very large and small values more
4495 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4497 * command.c: Fixed test on command return status for the correct
4498 value, which had been causing a crash under certain invalid input.
4500 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4502 * t-test.q: Added calculations for the one sample variant of the T-TEST
4504 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4506 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4507 in joined cells to be rendered outside box boundaries.
4509 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4511 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4512 SET seed=xx has been called.
4514 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4516 * random.c (rng_get_double): Fix always-returning-zero bug in my
4517 preferred way, and at the same time make sure rounding doesn't
4520 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4522 * html.c: (change_attributes) Dead code, removed.
4523 (escape_string) Eliminate code to call change_attributes() that
4524 never actually called it.
4525 (output_tab_table) Get rid of dependence on tab_hit
4526 and struct tab_joined_cell's hit member, which are abominations.
4528 * tab.c: (tab_output_text) Don't call
4529 d->class->text_set_font_by_name if it's a null pointer.
4530 (macro UNROLL_LOOP) Eliminate.
4531 (macro UNROLL_3_LOOPS) Eliminate.
4532 (tabi_render) Rewrite not to use the above macros.
4534 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4536 Start working on a new output driver system, one that doesn't suck
4537 so much, by adding a "device-independent" output driver. The idea
4538 is to write out only a single output stream, then use separate
4539 processes to translate them into whatever formats we want. This
4540 is similar to how "groff" works with its various output drivers
4541 (grops, grotty, grodvi, ...).
4543 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4545 * list.q: (write_all_headers) Stub out devind class.
4547 (determine_layout) Ditto.
4550 * output.c: (outp_init) Add devind class.
4552 * devind.c: New file.
4554 * devind.h: New file.
4556 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4558 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4559 to use the proper string length.
4561 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4563 * Fixed bug where FREQ would crash on alpha values
4565 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4567 * Removed bletcherous alloca() workarounds for AIX from top of
4568 many files. AIX can use the alternative alloca() implementation
4571 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4573 * ascii.c: (ascii_option) Fix implementation of headers option.
4575 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4577 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4578 multiple blank lines into one.
4579 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4580 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4581 (static var option_tab) Add squeeze entry.
4582 (ascii_option) Set squeeze_blank_lines.
4583 (output_lines) Implement squeezing blank lines.
4585 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4587 * Removed redundant code from output.h
4589 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4591 Dictionary classes: each variable is "ordinary", "system", or
4594 * var.h: (enum dict_class) New enum.
4596 * vars-prs.c: (dict_class_from_id) New function.
4597 (dict_class_to_name) New function.
4599 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4601 * var.h: (struct freq_tab_set) Removed (not used).
4603 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4605 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4607 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4609 * stats.c: (hypercube) Rename pow4(). All references updated.
4611 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4613 * rename-vars.c: (cmd_rename_variables) Rewritten.
4614 (compare_name) Removed.
4616 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4618 var_set feature, and code taking advantage of it.
4620 * crosstabs.q: (static var var_dict) Removed.
4621 (static var variables) New variable.
4622 (static var variables_cnt) New variable.
4623 (cmd_crosstabs) Free variables instead of var_dict.
4624 (internal_cmd_crosstabs) Initialize and use variables,
4625 variables_cnt instead of var_dict.
4626 (free_var_dict) Removed.
4627 (crs_custom_tables) Use var_set instead of a copied dictionary.
4628 (crs_custom_variables) Set up variables, variables_cnt instead of
4630 [DEBUGGING] (debug_print) Ditto.
4632 * means.q: (mns_custom_tables) Use var_set instead of a copied
4635 * vars-prs.c: (parse_vs_variable) New function.
4636 (parse_dict_variable) Rewritten.
4637 (parse_variable) Rewritten.
4638 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4639 (parse_variables) New function in terms of parse_var_set_vars().
4640 Now requires its first argument to be non-null. All references
4641 that passed a null pointer updated to pass default_dict instead.
4642 (macro id_dict) Removed.
4643 (parse_DATA_LIST_vars) Add assertions.
4644 (parse_mixed_vars) Ditto.
4645 (struct var_set) New structure.
4646 (var_set_get_cnt) New function.
4647 (var_set_get_var) New function.
4648 (var_set_lookup_var) New function.
4649 (var_set_destroy) New function.
4650 (dict_var_set_get_cnt) New function.
4651 (dict_var_set_get_var) New function.
4652 (dict_var_set_lookup_var) New function.
4653 (dict_var_set_destroy) New function.
4654 (var_set_create_from_dict) New function.
4655 (struct array_var_set) New structure.
4656 (array_var_set_get_cnt) New function.
4657 (array_var_set_get_var) New function.
4658 (array_var_set_lookup_var) New function.
4659 (array_var_set_destroy) New function.
4660 (var_set_create_from_array) New function.
4662 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4663 instead of parse_variables(NULL, ...) in output code.
4665 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4667 Change inp_init from a 2-bit vector to an ordinary array.
4668 Initialize it all in cmd_end_input_program() instead of in
4671 * inpt-pgm.c: (enum value_init_type) New enum.
4672 (global var inp_init) Change to `enum value_init_type *', make
4674 (inp_init_size) Removed.
4675 (inp_nval) Change to `size_t', make static.
4676 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4677 (cmd_end_input_program) Initialize inp_init, inp_nval.
4678 (init_case) Rewrite.
4679 (clear_case) Rewrite.
4681 * inpt-pgm.h: Removed.
4683 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4685 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4686 Colin Plumb hash. It is simpler and should better resist
4688 (hsh_hash_string) Ditto.
4690 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4692 * get.c: (export_write_case_func) Remove debug printing code.
4694 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4696 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4698 (save_write_case_func) Use &trns->h instead of cast.
4699 (cmd_export) Use &t->h instead of cast.
4701 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4703 Moved vectors into the dictionary.
4705 * var.h: (struct vector) Moved here from vector.h. `index' member
4706 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4709 * vector.h: Removed.
4711 * vector.c: (global var vec) Removed.
4712 (global var nvec) Removed.
4713 (cmd_vector) Rewritten.
4714 (find_vector) Removed.
4716 * dictionary.c: (dict_create_vector) New function.
4717 (dict_get_vector) New function, replaces reading global vec[]
4719 (dict_get_vector_cnt) New function, replaces reading global nvec
4721 (dict_lookup_vector) New function, replaces find_vector().
4722 (dict_clear_vectors) New function.
4724 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4726 Start to move away from `struct variable' p `union' member to void
4729 * var.h: (struct variable) Add `aux' member.
4731 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4733 Get rid of struct variable `foo' member.
4735 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4737 (frq_custom_variables) Ditto.
4738 (frq_custom_grouped) Ditto.
4740 * get.c: (struct save_trns) Change `var' member from `int *' to
4741 `struct variable **'.
4742 (cmd_save_internal) Use aux instead of foo.
4743 (save_trns_proc) Use revised `var' member.
4744 (static var mtf_seq_no) Renamed mtf_seq_num.
4745 (static var mtf_seq_nums) New static var.
4746 (cmd_match_files) Initialize mtf_seq_nums.
4747 (mtf_free) Free mtf_seq_nums.
4748 (mtf_processing) Use mtf_seq_nums instead of foo.
4749 (mtf_merge_dictionary) No need to initialize mv->foo.
4750 (cmd_export) Use aux instead of foo. Use revised `var' member.
4751 (mns_custom_tables) Don't use foo to check for duplicates, that's
4752 what PV_NO_DUPLICATE is for.
4754 * var.h: (struct variable) Remove `foo' member.
4755 (struct frequencies_proc) New member.
4757 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4759 Clean up COMPUTE and IF.
4761 * compute.c: More or less rewrite the darn thing.
4762 (struct compute_trns) Rename and reorder and add and delete
4764 (cmd_compute) Rewrite.
4765 (compute_num) Make conditional on test expression. Now used for
4766 both COMPUTE and IF.
4767 (compute_num_vec) Ditto.
4768 (compute_str) Ditto.
4769 (compute_str_vec) Ditto.
4772 (if_num_vec) Removed.
4774 (if_str_vec) Removed.
4775 (parse_target_expression) Renamed parse_rvalue_expression(),
4777 (new_trns) Renamed compute_trns_create(), rewritten.
4778 (delete_trns) Removed.
4779 (free_trns) Renamed compute_trns_free(), rewritten.
4780 (struct lvalue) New structure.
4781 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4782 (lvalue_get_type) New function.
4783 (lvalue_is_vector) New function.
4784 (lvalue_finalize) New function.
4785 (lvalue_destroy) New function.
4787 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4789 * command.def: Disallow MODIFY VARS in input mode, so that
4790 variables can't get dropped and confuse cmd_end_input_program()'s
4791 attempt to fill inp_init[].
4793 * modify-vars.c: (static var forward_positional_ordering) New
4795 (struct var_modification) Entirely changed.
4796 (rearrange_dict) Interface changed, rewritten.
4797 (cmd_modify_vars) Deal with modified struct var_modification, much
4799 (struct var_renaming) New structure.
4800 (compare_var_renaming_by_new_name) New function.
4801 (validate_var_modification) New function.
4803 * var.h: (struct modify_vars_proc) Removed.
4804 (struct variable) Removed member p.mfv.
4806 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4808 Make EVALUATE a valid command whether we're debugging or not, so
4809 that `make check' can succeed regardless of whether debugging is
4812 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4814 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4816 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4818 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4819 statement by a simple if test.
4821 * dfm.c: (dfm_get_record) Add assertion.
4823 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4825 For each file x.c, move #include "x.h" to the very top of the
4826 include list, to catch x.h failing to include the proper headers.
4828 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4830 * algorithm.c: (find) New function.
4831 (remove_equal) New function.
4832 (set_difference) New function.
4833 (adjacent_find_equal) New function.
4834 [TEST_UNIQUE] Removed test case.
4835 (copy_if) Find end test.
4837 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4839 * dictionary.c: (dict_get_case_weight) New convenience function.
4841 * aggregate.c: (accumulate_aggregate_info) Use
4842 dict_get_case_weight().
4844 * frequencies.q: (calc_general) Ditto.
4845 (calc_integer) Ditto.
4848 * t-test.q: (groups_calc) Ditto.
4851 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4853 * glob.c: (global var default_dict) Change from `struct
4854 dictionary' to `struct dictionary *'. All references changed.
4855 (init_glob) Initialize default_dict with dict_create().
4857 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4859 struct dictionary now made opaque. All related functions:
4861 * get.c: (rename_variables) Removed.
4862 (dict_delete_run) Removed.
4864 * temporary.c: (copy_variable) Removed.
4865 (new_dictionary) Removed.
4866 (save_dictionary) Removed.
4867 (restore_dictionary) Removed.
4868 (free_dictionary) Removed.
4870 * vars-atr.c: (clear_default_dict) Removed.
4871 (find_variable) Removed.
4872 (find_dict_variable) Removed.
4873 (create_variable) Removed.
4874 (delete_variable) Removed.
4875 (common_init_stuff) Removed.
4876 (init_variable) Removed. Updating of inp_init moved into
4877 cmd_end_input_program().
4878 (replace_variable) Removed.
4879 (rename_variable) Removed.
4880 (clear_variable) Removed.
4881 (dup_variable) Removed.
4883 * vars-prs.c: (is_varname) Removed.
4884 (is_dict_varname) Removed.
4885 (fill_all_vars) Removed.
4887 * vector.c: (find_vector) Removed.
4889 * weight.c: (stop_weighting) Removed.
4891 * dictionary.c: New file.
4892 (dict_create) New, replaces new_dictionary().
4893 (dict_clone) New, replaces save_dictionary() and
4894 restore_dictionary().
4895 (dict_clear) New, replaces clear_default_dict().
4896 (dict_destroy) New, replaces free_dictionary().
4897 (dict_get_var_cnt) New function, replaces references to
4899 (dict_get_var) New function, replaces references to dict->var[i].
4900 (dict_get_vars) New function, replaces fill_all_vars().
4901 (dict_create_var) New, replaces create_variable(). Interface
4902 drops `type' parameter, using a zero `width' to designate numeric.
4903 (dict_clone_var) New, replaces dup_variable().
4904 (dict_rename_var) New, replaces rename_variable().
4905 (dict_lookup_var) New, replaces find_variable(),
4906 find_dict_variable(), is_varname().
4907 (dict_contains_var) New function.
4908 (compare_variable_dblptrs) New function.
4909 (dict_delete_var) New function, replaces clear_variable().
4910 (dict_delete_vars) New function, replaces dict_delete_run().
4911 (dict_reorder_vars) New function.
4912 (dict_rename_vars) New function, replaces rename_variables().
4913 (dict_get_weight) New function, replaces reading dict->weight_var.
4914 (dict_set_weight) New function, replaces writing dict->weight_var
4915 or calling stop_weight(dict).
4916 (dict_get_filter) New function, replaces reading dict->filter_var.
4917 (dict_set_filter) New function, replaces writing dict->filter_var.
4918 (dict_get_case_limit) New function, replaces reading dict->N.
4919 (dict_set_case_limit) New function, replaces writing dict->N.
4920 (dict_get_value_cnt) New function, replaces reading dict->nval.
4921 (dict_compact_values) New function, replaces a loop that was
4922 replicated in several places.
4923 (dict_get_split_vars) New function, replaces reading dict->splits.
4924 (dict_get_split_cnt) New function, replaces reading
4926 (dict_set_split_vars) New function, replaces writing dict->splits.
4927 (dict_get_label) New function, replaces reading dict->label.
4928 (dict_set_label) New function, replaces writing dict->label.
4929 (dict_get_documents) New function, replaces reading
4931 (dict_set_documents) New function, replaces writing
4934 All references to above functions updated.
4936 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4937 old dictionary to new by hand, because dict_create() can't do it
4938 itself. Use dict_set_documents(), dict_set_split_vars().
4940 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4941 calling dict_destroy().
4943 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4945 (fixed_parse_compatible) Some slightly nontrivial changes for
4947 (dump_fmt_list) Ditto.
4950 * file-type.c: (create_col_var) Ditto.
4952 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4953 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4954 (rename_variables) Use dict_rename_vars().
4955 (mtf_merge_dictionary) Use dict_get_documents(),
4956 dict_set_documents(), dict_compact_values().
4958 * pfm-read.c: (read_variables) Deal with changes to weighting.
4960 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4961 is_varname() in output code.
4963 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4964 other dictionary functions.
4966 * title.c: (add_document_line) Use dict_get_documents(),
4967 dict_set_documents().
4969 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4970 reset default_handle by hand. dict_clear() will clear vectors so
4971 there's no need for that by hand.
4973 * vfm.c: (close_active_file) Move call to finish_compaction()
4974 earlier, so that we can do the compaction as a single step using
4975 dict_compact_values(). Use dict_clear_vectors().
4976 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4978 Some functions don't have replacements:
4980 * vars-atr.c: (force_create_variable) Removed. All references
4981 updated to dict_create_var() followed by an assertion.
4982 (force_dup_variable) Removed. All references updated to
4983 dict_clone_var() followed by an assertion.
4985 * weight.c: (update_weighting) Removed. No longer necessary, so
4986 all references removed.
4988 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4992 * aggregate.c: Eliminate separation of weighted and unweighted
4993 case. It made the code too obscure and I doubt it was actually
4994 faster. Instead, all code uses the "weighted" code, because
4995 that's a generalization of the "unweighted" code.
4998 (parse_aggregate_functions) No need to set FWEIGHT.
4999 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
5000 (dump_aggregate_info) Ditto.
5001 (initialize_aggregate_info) No need for special plain_function
5002 that gets rid of FWEIGHT option.
5004 * aggregate.c: Get rid of approximations.
5005 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
5007 (aggregate_single_case) Don't use approx_ne().
5009 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
5011 * ascii.c (ascii_line_width): Dead code, removed.
5013 * postscript.c (ps_line_width): Ditto.
5015 * q2c.c (xrealloc): Ditto.
5017 * count.c (internal_cmd_count): Ditto.
5019 * means.q (validate_dependent_endpoint): Ditto.
5021 * set.q: (cmd_gset) Ditto.
5023 * weight.c: [0] (weight_trns_proc) Ditto.
5025 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
5027 Make the code -Wmissing-prototypes clean.
5029 * Makefile.am (version.c): Add #include "version.h".
5031 * ascii.c: (ascii_open_global) Make static.
5032 (ascii_close_page) Ditto.
5033 (ascii_font_sizes) Ditto.
5034 (ascii_postopen_driver) Ditto.
5035 (ascii_close_driver) Ditto.
5036 (ascii_option) Ditto.
5037 (ascii_open_page) Ditto.
5038 (ascii_line_horz) Ditto.
5039 (ascii_line_vert) Ditto.
5040 (ascii_line_intersection) Ditto.
5042 (ascii_polyline_begin) Ditto.
5043 (ascii_polyline_point) Ditto.
5044 (ascii_polyline_end) Ditto.
5045 (ascii_text_set_font_by_name) Ditto.
5046 (ascii_text_set_font_by_position) Ditto.
5047 (ascii_text_set_font_by_family) Ditto.
5048 (ascii_text_get_font_name) Ditto.
5049 (ascii_text_get_font_family) Ditto.
5050 (ascii_text_set_size) Ditto.
5051 (ascii_text_get_size) Ditto.
5052 (ascii_text_metrics) Ditto.
5053 (ascii_text_draw) Ditto.
5054 (ascii_close_page) Ditto.
5056 * cmdline.h: New header for parse_command_line(). Used where
5059 * command.c: Move prototypes for cmd_*() functions to command.h.
5061 * command.h: Prototypes for cmd_*() functions moved here from
5064 * crosstabs.q: (gamma_int) Ditto.
5066 * file-handle.h: Add fh_init_files() prototype.
5068 * getline.c: (welcome) Ditto.
5070 * glob.h: New header for init_glob(). Used where appropriate.
5072 * hash.c: (comparison_helper) Ditto.
5074 * html.c: (html_open_global) Ditto.
5075 (html_close_global) Ditto.
5076 (html_preopen_driver) Ditto.
5077 (html_postopen_driver) Ditto.
5078 (html_close_driver) Ditto.
5079 (html_option) Ditto.
5080 (html_open_page) Ditto.
5081 (html_close_page) Ditto.
5082 (html_submit) Ditto.
5084 * inpt-pgm.c: (input_program_source_read) Ditto.
5086 * output.c: (find_defn_value) Ditto.
5087 (destroy_list) Ditto.
5089 * pfm-read.c: (read_int) Ditto.
5091 * postscript.c: (ps_open_global) Ditto.
5092 (ps_close_global) Ditto.
5093 (ps_font_sizes) Ditto.
5094 (ps_preopen_driver) Ditto.
5095 (ps_postopen_driver) Ditto.
5096 (ps_close_driver) Ditto.
5098 (ps_open_page) Ditto.
5099 (ps_close_page) Ditto.
5100 (ps_line_horz) Ditto.
5101 (ps_line_vert) Ditto.
5102 (ps_line_intersection) Ditto.
5104 (ps_polyline_begin) Ditto.
5105 (ps_polyline_point) Ditto.
5106 (ps_polyline_end) Ditto.
5107 (ps_text_set_font_by_name) Ditto.
5108 (ps_text_set_font_by_position) Ditto.
5109 (ps_text_set_font_family) Ditto.
5110 (ps_text_get_font_name) Ditto.
5111 (ps_text_get_font_family) Ditto.
5112 (ps_text_set_size) Ditto.
5113 (ps_text_get_size) Ditto.
5114 (ps_text_metrics) Ditto.
5115 (ps_text_draw) Ditto.
5117 * q2c.c: (finish_up) Ditto.
5126 (find_symbol) Ditto.
5129 (force_string) Ditto.
5131 (match_token) Ditto.
5134 (parse_setting) Ditto.
5135 (parse_specifier) Ditto.
5136 (parse_specifiers) Ditto.
5137 (parse_subcommand) Ditto.
5138 (dump_specifier_vars) Ditto.
5140 (make_identifier) Ditto.
5141 (dump_declarations) Ditto.
5142 (dump_specifier_init) Ditto.
5143 (dump_vars_init) Ditto.
5145 (dump_specifier_parse) Ditto.
5146 (dump_subcommand) Ditto.
5147 (dump_parser) Ditto.
5148 (dump_header) Ditto.
5150 (recognize_directive) Ditto.
5152 * recode.c: (string_to_long) Ditto.
5154 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
5156 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
5159 * sort.c: (sort_stream_read) Ditto.
5160 (sort_stream_mode) Ditto.
5162 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
5164 * algorithm.c (binary_search): Fix comparison.
5166 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
5168 * algorithm.c: (binary_search) Fix assertion.
5170 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
5172 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
5174 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
5176 * sort.c: (compare_case_lists) Rewrite.
5178 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
5180 * quicksort.c: Removed (not used).
5182 * quicksort.h: Removed (not used).
5184 * sort.c: Removed blp_quicksort() prototype.
5186 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
5188 * postscript.c: (int_2_compare) Rewrite.
5189 (compare_line) Rewrite.
5191 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
5193 * matrix-data.c (compare_factors) Use lexicographical_compare()
5195 (compare_doubles) New function.
5197 * algorithm.c: (lexicographical_compare) New algorithm.
5199 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
5201 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
5203 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
5205 * expr-prs.c: (cmp_func) Removed.
5206 (parse_function) Use binary_search() algorithm.
5207 (compare_functions) New function.
5208 (init_func_tab) Use sort() algorithm.
5210 * algorithm.c: (binary_search) New algorithm.
5212 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
5214 * descript.q: (display) Use sort() algorithm instead of qsort().
5215 (compare_func) Removed.
5216 (descriptives_compare_variables) New function.
5218 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
5220 Get rid of AVL trees. Hashes are more appropriate for everything
5223 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5229 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5231 Much code can be clarified by using C++ STL-like algorithms. Not
5232 all uses of these algorithms are listed below, only the ones where
5233 the change to an algorithm was the only change of interest.
5235 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5237 * algorithm.c: New file.
5239 * algorithm.h: New file.
5241 * modify-vars.c: (static var forward) Removed.
5242 (static var positional) Removed.
5243 (compare_variables) Removed.
5244 (struct ordering) New.
5245 (cmd_modify_vars) Use sort() algorithm.
5246 (compare_variables_given_ordering) New function.
5247 (rearrange_dict) Use sort() algorithm.
5249 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5250 (cmp_var_by_name) Removed.
5252 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5254 Make file handles use a hash table.
5256 * file-handle.q: (files) Change to hash table, make static.
5257 (cmd_file_handle) Use hash table functions.
5258 (fh_get_handle_by_filename) Ditto.
5259 (fh_get_handle_by_name) Ditto.
5260 (hash_file_handle) New function.
5261 (cmp_file_handle) Rewrite.
5262 (fh_init_files) Use hash table functions.
5264 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5266 Clean up FREQUENCIES.
5268 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5270 * frequencies.q: Remove a lot of old #if'd out code at the end.
5271 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5272 or calc_weight(). Initialize percentile_values.
5273 (calc) New function based on calc_weight() from frequencies.g.
5274 (precalc) Use hash functions.
5275 (static var comparison_func) Removed.
5276 (static var comparison_param) Removed.
5277 (comparison_helper) Removed.
5278 (get_freq_comparator) New function.
5279 (not_missing) New function.
5281 (postprocess_freq_tab) Use hash table functions, algorithms,
5282 get_freq_comparator(). Rewrite.
5283 (cleanup_freq_tab) Rephrase.
5284 (add_percentile) Clean up spacing.
5285 (hash_value_numeric) New function.
5286 (hash_value_alpha) New function.
5287 (compare_value_numeric_a) Rewrite.
5288 (compare_value_alpha_a) Rewrite.
5289 (compare_value_numeric_d) Rewrite.
5290 (compare_value_alpha_d) Rewrite.
5291 (compare_freq_numeric_a) Rewrite.
5292 (compare_freq_alpha_a) Rewrite.
5293 (compare_freq_numeric_d) Rewrite.
5294 (compare_freq_alpha_d) Rewrite.
5295 (calc_stats) Clean up mode, percentiles, max.
5296 (dump_statistics) Clean up spacing.
5298 * frequencies.g: Removed.
5300 * var.h: (struct freq_tab) Change `data' to hash table.
5302 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5304 * file-handle.h: Remove declaration of global variable `files',
5305 which wasn't used anywhere.
5307 * postscript.c: (add_encoding) Remove superfluous cast.
5310 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5313 * temporary.c: [0] (display_tree) Removed.
5315 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5317 Implement a new random number generator based on the alleged RC4
5320 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5323 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5324 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5326 (static var V[]) Removed.
5327 (static var Y) Removed.
5328 (static var X2) Removed.
5329 (setup_randomize) Removed.
5331 (rand_uniform) Removed.
5332 (rand_normal) Removed.
5333 (struct rng) New structure.
5334 (rng_create) New function.
5335 (rng_destroy) New function.
5336 (swap_byte) New static function.
5337 (rng_seed) New function.
5338 (rng_get_bytes) New function.
5339 (rng_get_int) New function.
5340 (rng_get_unsigned) New function.
5341 (rng_get_double) New function.
5342 (rng_get_double_normal) New function.
5343 (pspp_rng) New function.
5345 * random.h: Sync up to random.c.
5347 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5348 fraction of UINT_MAX, not 65536.
5349 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5352 * vfm.c: (open_active_file) No need to call setup_randomize() any
5355 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5357 Change dictionary name indexes to use hash tables instead of AVL
5360 * crosstabs.q: (free_var_dict) Use hash tables.
5361 (crs_custom_tables) Ditto.
5362 (calc_general) Ditto.
5363 (compare_table_entry) Rewrite.
5364 (enum_var_values) Reorder parameters. All references updated.
5367 * get.c: (rename_variable) Use hash tables.
5368 (mtf_merge_dictionary) Ditto.
5370 * glob.c: (init_glob) Use hash tables.
5371 (cmp_variable) Removed.
5373 * means.q: (mns_custom_tables) Use hash tables.
5375 * modify-vars.c: (rearrange_dict) Use hash tables.
5377 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5379 * sfm-read.c: (read_header) Use hash tables.
5380 (read_variables) Ditto.
5382 * temporary.c: (new_dictionary) Use hash tables.
5383 (save_dictionary) Ditto.
5384 (restore_dictionary) Ditto.
5386 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5387 hash table `name_tab'.
5389 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5390 [DEBUGGING] (dump_var_tree) Removed.
5391 (find_variable) Use hash tables.
5392 (find_dict_variable) Ditto.
5393 (common_init_stuff) Ditto.
5394 (rename_variable) Ditto.
5395 (clear_variable) Ditto. Also, remove debug code.
5396 (dup_variable) Use hash tables.
5398 * vars-prs.c: (fill_all_vars) Use hash tables.
5399 (is_dict_varname) Ditto.
5400 (parse_dict_variable) Ditto.
5402 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5404 Change value labels to use hash tables instead of AVL trees, and
5405 change value labels into an ADT.
5407 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5409 * value-labels.c: New file.
5411 * value-labels.h: New file.
5413 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5414 Get rid of a stupid use of goto.
5416 * autorecode.c: (compare_alpha_value) Rewrite.
5417 (hash_alpha_value) Ditto.
5418 (compare_numeric_value) Rewrite.
5419 (hash_numeric_value) Ditto.
5421 * frequencies.q: (dump_full) Use value label ADT.
5423 * pfm-read.c: (read_value_label) Use value label ADT.
5425 * pfm-write.c: (write_value_labels) Use value label ADT.
5427 * sfm-read.c: (read_variables) Use value label ADT.
5428 (read_value_labels) Rewrite.
5430 * sfm-write.c: (write_value_labels) Rewrite.
5432 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5433 (display_variables) Ditto.
5434 (describe_variable) Ditto.
5436 * t-test.q: (print_t_groups) Use value label ADT.
5438 * temporary.c: (copy_variable) Use value label ADT.
5439 (free_dictionary) Ditto.
5441 * val-labs.c: (verify_val_labs) Use value label ADT.
5443 (debug_print) Ditto.
5444 (val_lab_cmp) Removed.
5445 (inc_ref_count) Removed.
5446 (copy_value_labels) Removed.
5448 * var.h: (struct value_label) Removed.
5449 (struct variable) Change AVL tree `val_lab' into hash table
5452 * vars-atr.c: (init_variable) Use value label ADT.
5453 (clear_variable) Ditto.
5454 (free_value_label) Removed.
5455 (free_val_lab) Removed.
5456 (get_val_lab) Removed.
5457 (compare_variables) New function.
5458 (hash_variable) New function.
5460 * vfm.c: (dump_splits) Use value label ADT.
5462 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5464 Add to the hash table interface.
5466 * hash.c: (hsh_hash_bytes) Add assertion.
5467 (hsh_hash_string) Ditto.
5471 (hsh_create) Ditto. Also make minimum `size'.
5472 (hsh_destroy) Rephrase.
5473 (sort_nulls_last) Removed.
5474 (not_null) New function.
5476 (comparison_helper) Ditto.
5477 (hsh_sort) Rewritten.
5478 (hsh_data_copy) New function.
5479 (hsh_sort_copy) Ditto.
5481 (hsh_replace) Ditto.
5482 (hsh_hash_double) Ditto.
5483 (hsh_delete) Fix stupid bug.
5485 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5486 * added a calculation of the mode to FREQUENCIES
5488 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5490 * moved (un)defs of DEBUGGING to config.h
5492 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5494 * groff-font.c: (add_kern) Fix indentation.
5495 (add_kern) Use & instead of % to take power-of-2 modulus.
5496 (font_get_kern_adjust) Likewise.
5498 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5500 * autorecode.c: (recode) Replace stupid use of memcpy() by
5502 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5503 (hash_numeric_value) Ditto.
5504 (autorecode_proc_func) pool_strdup() was wrong here because the
5505 source string was not null-terminated. Use new pool_strndup()
5508 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5509 use of hsh_iterator_init().
5511 * data-in.c: (parse_N) Initialize i->v->f.
5513 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5516 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5517 (groff_read_font) Don't call hsh_next_prime(). Don't call
5519 (static var hash) Remove `size_p', `max_used' members.
5520 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5521 hsh_hash_string() instead of hashpjw(), & instead of %.
5522 (default_font) Don't call hsh_next_prime().
5524 * pool.c: (pool_strndup) New function.
5525 (pool_strdup) Reimplement in terms of pool_strndup.
5527 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5529 (hash_ps_encoding) Use hsh_hash_string().
5530 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5531 (hash_filename2font) Use hsh_hash_string().
5533 * som.c: Add #include <stdlib.h>.
5535 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5536 (by destroying its pool).
5538 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5540 Miscellaneous hash table code cleanup:
5542 * hash.h: (struct hsh_table) Moved into hash.c.
5543 (hsh_count) Ditto, and transformed into function.
5544 (hsh_compare_func) New typedef, used for defining otherwise-long
5545 function types here and in hash.c
5546 (hsh_hash_func) Ditto.
5547 (hsh_free_func) Ditto.
5549 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5550 `table' to `entries'. Removed `mp'. All references updated.
5551 (hsh_clear) Don't shrink entries array; if the hash was this big
5552 once, it probably will be again.
5553 (hsh_rehash) Made static.
5554 (force_hsh_insert) Renamed hsh_force_insert.
5555 (force_hsh_find) Renamed hsh_force_find.
5557 Made hash table sizes powers of 2, because that's fine with any
5558 reasonable hash function and because taking a power-of-2 modulus
5559 is faster than any other:
5561 (hsh_prime_tab) Removed;
5562 (hsh_next_prime) Ditto.
5563 (next_power_of_2) New function.
5564 (hsh_create) Use next_power_of_2.
5565 (hsh_rehash) Use & instead of %.
5567 Cleaned up hsh_sort:
5569 (internal_comparison_fn) Removed.
5570 (sort_nulls_last) New function.
5571 (hsh_sort) Removed second parameter, switched to using the new
5572 quicksort() function from quicksort.h to avoid using nasty need
5573 for static variables with qsort(). All references updated.
5575 Changed the hash functions offered, because there are better hash
5576 functions than the ones we had, and cleaned up the names to boot:
5578 * hash.c: (hashpjw_d) Removed.
5580 (hsh_hash_bytes) New function.
5581 (hsh_hash_string) New function.
5582 (hsh_hash_int) New function.
5584 Improved the hash table iteration interface:
5586 * hash.h: (hsh_iterator_init) Removed.
5587 (struct hsh_iterator) Removed `init' member, change `next' to
5590 * hash.c: (hsh_foreach) Removed. All references updated to use
5591 hsh_first/hsh_next instead.
5592 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5593 not treat a null pointer as an empty hash table.
5594 (hsh_next) New function.
5596 Made deletion possible, though slow:
5598 * hash.c: (locate_matching_entry) New function.
5599 (hsh_find) Use locate_matching_entry().
5600 (hsh_delete) New function also using locate_matching_entry().
5601 (hsh_force_delete) New function.
5603 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5605 * quicksort.c: New file implementing a sort routine with a
5606 interface better than qsort() because it passes a user-provided
5607 parameter to the sort routine.
5609 * Makefile.am: Add quicksort.c, quicksort.h.
5611 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5613 * All source files: Get rid of nasty special cases for Checker,
5614 which is pretty obsolete now.
5616 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5618 * Fixed a bug apparent when using the FREQUENCIES command with the
5619 html driver. The html driver was incorrectly trying to display
5622 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5624 * Makefile.am: Reorganized. Put locale dir in version.c instead
5625 of passing it to each compile command. Only put local gmp libs in
5626 LD_ADD if not installed on system. Remove `boast' target.
5628 * All source files: struct and union typedefs eliminated.
5629 `sizeof type' replaced by `sizeof object' where practical. Moved
5630 `unused' qualifiers from start to end of declarations for gcc
5631 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5632 assertions on pointers strictly compliant. Removed _ prefixes on
5633 some function parameter names.
5635 * alloc.c: New source file, containing these external linkage
5636 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5643 * ascii.c: Migrated from arenas to pools.
5644 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5645 c_string to len_string. All references changed.
5646 (ascii_option) Signature changed to comply to new output.c
5648 (count_fancy_chars) Removed.
5649 (delineate) Removed support for rich text.
5650 (ascii_text_metrics) Ditto.
5652 (output_shorts) Change `box', `off', `on' from c_string to
5653 len_string. Change `remaining' from int to size_t.
5654 (ascii_close_page) Make page numbering less haphazard.
5656 * autorecode.c: Migrate from arenas to pools.
5658 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5660 * bitvector.h: New file containing these macros from misc.h:
5661 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5663 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5664 word[3]. ncmd removed.
5665 (var empty_string) Removed.
5666 (var cmd_table) Declaration updated.
5667 (var cmdtab) Removed.
5668 (cmp_command) Removed.
5669 (split_words) Rewritten to use strtok_r().
5670 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5671 (find_command) Removed.
5672 (FILE_TYPE_okay) Rewritten.
5673 (cmd_parse) Rewritten. Semantics of the return value of command
5674 handlers has changed: they must now return one of the new CMD_*
5675 enumerals, rather than a magic value. This meant that all
5676 commands had to be modified, and they were.
5677 (figure_out_command) New function.
5679 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5680 #defines for INIT, INPU, etc.
5682 * command.h: New CMD_* enum series.
5683 (cur_proc) Make const char *, not char *.
5684 (cmd_init) Prototype.
5687 * common.c: Removed.
5689 * common.h: Removed.
5691 * correlations.q: New file.
5693 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5695 (custom_tables) Renamed crs_custom_tables().
5696 (custom_variables) Renamed crs_custom_variables().
5697 (calc_integer) Add in some `const' qualifiers.
5698 (table_value_missing) Change from a_string to len_string.
5699 (float_M_suffix) Change from a_string to len_string.
5701 * data-in.c: Rewritten. All references to
5702 parse_string_as_format() changed to data_in().
5704 * data-in.h: New file.
5706 * data-list.c: Change DLS_* from #define's to enums. Move from
5707 rpd_msg() to tmsg().
5708 (RPD_ERR) New #define.
5709 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5711 (read_from_data_list_fixed) Change from old
5712 parse_string_as_format() to new data_in().
5713 (read_from_data_list_free) Ditto.
5714 (read_from_data_list_list) Ditto.
5715 (cmd_repeating_data) Modify approach to checking for end of
5718 (rpd_parse_record) Change from old parse_string_as_format() to new
5719 data_in(). Change from old convert_format_to_string() to new
5721 (read_one_set_of_repetitions) Change dfm_push_cust() to
5722 dfm_push(), pop_cust() to dfm_pop().
5724 * data-out.c: Rewritten. All references to
5725 convert_format_to_string() changed to data_out().
5727 * descript.q: Migrate to new q2c.
5728 (cmd_descriptives) Removed.
5729 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5730 (custom_variables) Renamed dsc_custom_variables().
5732 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5734 (open_file_r) Initialize h->where.line_number. Migrate to new
5736 (open_file_w) Initialize h->where.line_number.
5737 (read_record) Change from ext->ln to h->where.line_number.
5738 Migrate to struct string.
5739 (dfm_put_record) Rephrased.
5740 (dfm_push_cust) Renamed dfm_push(), rewritten.
5741 (dfm_pop) New function.
5743 * error.c: All references updated.
5744 (glob var error_count) Renamed err_err_count.
5745 (glob var warning_count) Renamed err_warning_count.
5746 (glob var error_already_flagged) Renamed err_already_flagged.
5747 (glob var verbosity) Renamed err_verbosity.
5748 (glob var cust_fn) Removed.
5749 (glob var cust_ln) Removed.
5750 (static var file_loc) New.
5751 (static var nfile_loc) New.
5752 (static var mfile_loc) New.
5753 (tmsg) New function.
5754 (push_cust) Removed.
5757 (static var terminating) Removed.
5758 (failure) Renamed err_failure().
5759 (hcf) Renamed err_hcf().
5760 (err_push_file_locator) New function.
5761 (err_pop_file_locator) New function.
5762 (err_location) New function.
5763 (check_error_count) Renamed err_check_count().
5764 (vmsg) Renamed err_vmsg(). Interface changed.
5765 (verbose_msg) Removed.
5766 (err_cond_fail) New function.
5767 (error_break) Renamed err_break().
5769 * error.h: All references updated.
5770 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5771 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5773 (struct file_locator) New.
5775 (macro verbose_msg) Removed.
5776 (macro cond_fail) Removed.
5778 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5780 * expr-prs.c: Reorganized. All references updated.
5781 (exprtypename) Renamed expr_type_name().
5782 (typename) Renamed type_name().
5783 (free_expression) Renamed expr_free().
5784 (parse_expression) Renamed expr_parse(). Uses new type_check()
5786 (init_functab) Renamed init_func_tab().
5787 (type_check) New function.
5788 (parse_or) Rewritten to use new allocate_nonterminal() and
5789 append_nonterminal_arg() functions.
5792 (parse_rel) Ditto. Also simplified logic.
5797 (SYSMIS_func) Ditto.
5798 (VALUE_func) Rephrased.
5799 (CONCAT_func) Fix memory leak by replacing free by free_node on
5801 (generic_str_func) Ditto.
5802 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5804 (allocate_nonterminal) New function.
5805 (append_nonterminal_arg) New function.
5806 (static func_tab[]) Now at file level.
5808 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5810 * expr.h: (enum series OP_*) Moved to exprP.h.
5811 (OP_* defines) Ditto.
5812 (struct op_desc) Ditto.
5813 (global ops[]) Ditto.
5814 (struct num_con_node) Ditto.
5815 (struct str_con_node) Ditto.
5816 (struct var_node) Ditto.
5817 (struct lag_node) Ditto.
5818 (struct casenum_node) Ditto.
5819 (struct nonterm_node) Ditto.
5820 (union any_node) Members renamed.
5821 (struct sys_node) Removed.
5822 (struct val_node) Removed.
5823 (operator typedef) Removed.
5824 (typedef exprtype) Removed.
5825 (enum series EX_*) Moved to exprP.h.
5826 (struct expression) Ditto. Also renamed a lot of the members.
5827 (PXP_* defines) Changed to enums.
5828 (free_node prototype) Moved to exprP.h.
5830 * file-handle.h: (struct file_handle) New member `where'.
5832 * file-handle.q: Migrated to new q2c format.
5833 (prepend_current_directory) Removed (dead code).
5834 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5835 (fh_get_handle_by_filename) Removed dead code.
5836 Set new `where' member.
5838 * file-type.c: (file_type_source_read) References to
5839 parse_string_as_format() changed to data_in().
5840 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5842 * filename.c: All references updated.
5843 (init_filename) Renamed fn_init().
5844 (expand_line) Removed.
5845 (macro EXPAND_LINE) Removed.
5846 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5847 of custom functions.
5848 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5849 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5850 (normalize_filename) Renamed fn_normalize().
5851 (search_path) Renamed fn_search_path(), rewritten.
5852 (prepend_dir) Renamed fn_prepend_dir().
5853 (blp_getenv) Renamed fn_getenv().
5854 (blp_dirname) Renamed fn_dirname().
5855 (fn_basename) New function, not used.
5856 (absolute_filename_p) Renamed fn_absolute_p().
5857 (is_special_filename) Renamed fn_special_p().
5858 (file_exists) Renamed fn_exists_p().
5859 (readlink_malloc) Renamed fn_readlink().
5860 (getenv_default) Renamed fn_getenv_default().
5861 (open_file) Renamed fn_open().
5862 (close_file) Renamed fn_close().
5863 (open_file_ext) Renamed fn_open_ext().
5864 (close_file_ext) Renamed fn_close_ext().
5866 * font.h: Migrate from arenas to pools.
5868 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5870 * frequencies.g: Migrate from arenas to pools.
5872 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5875 * getline.c: All references updated.
5876 (global getl_buf) Changed from char * to struct string.
5877 (static getl_include_path) Ditto.
5878 (global getl_buf_len) Removed.
5879 (global getl_buf_size) Removed.
5880 (getl_include_path) Deal with new getl_buf, getl_include_path.
5881 (getl_uninitialize) New function.
5882 (getl_get_current_directory) Rewritten.
5883 (getl_clear_include_path) Rewritten.
5884 (getl_add_include_dir) Rewritten.
5885 (getl_add_file) Assertion fixed.
5886 (getl_add_virtual_file) Change initial value of `remaining_loops'
5888 (welcome) Rewritten.
5889 (handle_line_buffer) Make static. Change logic to make
5890 getl_add_virtual_file() change sensible. Use ds_*() strings.
5891 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5892 (getl_close_file) Moved.
5893 (getl_location) New function.
5895 * getline.h: All references updated.
5896 (macro curln) Removed.
5897 (macro curfn) Removed.
5898 (macro am_interactive) Renamed getl_am_interactive.
5899 (macro am_reading_script) Renamed getl_reading_script.
5901 * glob.c: (global fmt_parse_ignore_error) Removed.
5902 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5903 systems that support it (C99). Turn off SET ECHO by default. No
5904 necessary julcal initialization anymore.
5906 * groff-font.c: Migrate from arenas to pools.
5907 (groff_read_font) Use err_push_file_locator().
5908 (groff_read_DESC) Ditto.
5909 (font_msg) Use tmsg().
5911 * hash.c: (hsh_sort) Fix debug code.
5912 [GLOBAL_DEBUGGING] Include stdio.h.
5914 * hash.h: (macro force_hsh_insert) Rephrase.
5916 * heap.c: Rewritten.
5918 * heap.h: Rewritten.
5920 * html.c: (html_option) Change from outp_value to struct string.
5921 (postopen) Change from curfn to getl_location().
5922 (escape_string) Remove rich-text code. Signature changed.
5923 (output_tab_table) Switch from a_string to struct len_string.
5924 Remove rich text support.
5926 * lexer.c: All references updated. Largely rewritten. Major
5927 changes listed below. Removed tagged quote support. Adapted to
5928 struct string tokstr.
5929 (global tokstr) Changed to struct string.
5930 (global tokstr_size) Removed.
5931 (global tokstr_len) Removed.
5933 (global tokint) Removed.
5934 (global toklongstr) Removed.
5935 (C* defines) Removed.
5936 (static tbl[]) Removed.
5937 (static id[]) Removed.
5938 (static une[]) Removed.
5939 (discard_line) Renamed lex_discard_line().
5940 (get_entire_line) Renamed lex_entire_line().
5941 (get_rest_of_line) Renamed lex_rest_of_line().
5942 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5943 (make_hexit) Removed.
5944 (syntax_error) Renamed lex_error(). Return value removed.
5945 (get_token_representation) Renamed lex_token_representation().
5946 (putback) Renamed lex_put_back().
5947 (putfwd) Renamed lex_put_forward().
5948 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5949 (set_prog) Renamed lex_set_prog().
5950 (init_lex) Renamed lex_init().
5951 (reset_eof) Renamed lex_reset_eof().
5952 (lookahead) Renamed lex_look_ahead().
5953 (check_id) Rewritten.
5954 (yylex) Renamed lex_get(), rewritten.
5955 (lex_end_of_command) New function. Many commands were rephrased
5957 (lex_integer_p) New function. Replaces compare of tokint against
5959 (lex_integer) New function. Replaces tokint.
5960 (match_tok) Renamed lex_match().
5961 (match_id) Renamed lex_match_id().
5962 (match_int) Renamed lex_match_int().
5963 (force_match_id) Renamed lex_force_match_id(), added return value.
5964 (force_match) Renamed lex_force_match(), added return value.
5965 (force_string) Renamed lex_force_string(), added return value.
5966 (force_int) Renamed lex_force_int(), added return value.
5967 (lex_id_match_len) New function.
5968 (id_match) Renamed lex_id_match(), rewritten.
5969 (get_line) Renamed lex_get_line().
5970 (preprocess_line) Renamed lex_preprocess_line().
5971 (tokname) Renamed lex_token_name().
5972 (bin_value_func) Removed.
5973 (oct_value_func) Removed.
5974 (hex_value_func) Removed.
5975 (unexpected_eof) New function.
5976 (convert_numeric_string_to_char_string) New function.
5977 (parse_string) Rewritten, signature changed.
5978 (add_tokstr_char) Removed.
5979 (add_tokstr_unsigned) Removed.
5980 (add_tokstr_string) Removed.
5981 (parse_tagged_quote) Removed.
5982 (skip_comment) Renamed lex_skip_comment().
5984 * lexer.h: All references updated.
5985 (macro is_id1) Renamed CHAR_IS_ID1.
5986 (macro is_idn) Renamed CHAR_IS_IDN.
5987 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5988 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5989 (macro get_token) Removed.
5990 (macro id_match) Removed.
5991 (macro force_match_id) Removed.
5992 (macro force_match) Removed.
5993 (macro force_string) Removed.
5994 (macro force_int) Removed.
5995 (macro force_num) Removed.
5996 (macro force_id) Removed.
5998 * lexerP.h: Removed.
6000 * list.q: Migrated to new q2c format.
6001 (write_line) Deal with struct len_string.
6002 (write_varname) Ditto.
6003 (write_fallback_headers) Ditto.
6005 * magic.c: New file, incorporating the following global variables
6006 previously in other files: endian, second_lowest_value. And both
6007 of those are conditional on #define's.
6009 * magic.h: New file, incorporating the following global variable
6010 declarations: endian, second_lowest_value, and the following macro
6011 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
6013 * main.c: Added declarations of pgmname, finished, curdate,
6015 (main) Call new parse_script() function.
6016 (parse_script) New function.
6017 (execute_command) New function.
6018 (dump_token) Removed.
6019 (handle_error) New function.
6021 * matrix.c: New file.
6023 * matrix.h: New file.
6025 * matrix-data.c: Migrated from arenas to pools.
6026 (mget_token) Change from parse_string_as_format() to data_in().
6028 * means.q: Migrate to new q2c.
6029 (custom_tables) Renamed mns_custom_tables().
6030 (custom_crossbreak) Renamed mns_custom_crossbreak().
6031 (custom_variables) Renamed mns_custom_variables().
6033 * mis-val.c: (static var width) Changed from `int' to `size_t'.
6034 (parse_varnames) Prototype.
6035 (parse_numeric) Rephrasings.
6036 (parse_alpha) Adapt to new struct string tokstr.
6038 * misc.c: (intlog10) Rewritten.
6040 (ansi_rand) Renamed real_rand(), moved into random.c.
6041 (ansi_srand) Renamed real_srand(), moved into random.c.
6042 (setup_randomize) Moved to random.c.
6043 (rand_uniform) Ditto.
6044 (rand_normal) Ditto.
6045 (rand_simple) Ditto.
6046 (get_config_line) Removed.
6047 (reverse) Removed (dead code).
6049 * misc.h: (macro SET_BIT) Moved to bitvector.h.
6050 (macro CLEAR_BIT) Ditto.
6051 (macro TEST_BIT) Ditto.
6052 (macro SET_BIT_TO) Ditto.
6053 (macro BIT_INDEX) Ditto.
6055 * output.c: (outp_read_devices) Move to err_push_file_locator()
6056 from push_cust(). Use struct string.
6057 (expand_op_tokstr) Removed.
6058 (static var op_tokstr) Changed to struct string.
6059 (static var op_tokstr_size) Removed.
6060 (tokener) Rephrasings. Use struct string.
6061 (parse_options) Use struct string.
6062 (destroy_driver) Fix assertion.
6063 (outp_get_paper_size) Move to err_push_file_locator().
6064 [0] Removed dead code.
6065 (outp_string_width) Move to len_string.
6067 * output.h: Comment fixes.
6068 (TAG_* enum series) Removed.
6069 (struct outp_value) Removed.
6070 (enum OUTP_T_FANCY) Removed.
6071 (struct outp_text) `s' changed from a_string to len_string.
6072 (struct outp_class) `option' change arg 3 from outp_value to
6075 * pfm-read.c: (corrupt_msg) Rewritten.
6077 * pfm-write.c: (bufwrite) Fix assertion.
6079 * pool.c: New file, reference version.
6081 * pool.h: New file, reference version.
6083 * postscript.c: (ps_font_sizes) Fix assertion.
6084 (ps_option) Change arg 3 from outp_value to struct string.
6085 Adapt to struct string.
6086 (macro output_line) Removed.
6087 (macro add_string) Removed.
6088 (output_encodings) Adapted to struct string. Moved to
6089 err_push_file_locator().
6090 (find_encoding_file) Fix assertion.
6091 (read_ps_encodings) Move to err_push_file_locator().
6092 (postopen) Use getl_location() instead of curfn.
6093 (out_text_plain) Move to len_string.
6094 (text) Ditto. Remove rich text support.
6096 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
6097 (cmd_print_eject) Ditto.
6099 (internal_cmd_print) Now cleans up after itself. Uses
6100 fh_parse_file_handle() now.
6101 (cmd_print_space) Use PXP_NUMERIC to type-check.
6103 * q2c.c: Overhauled. Removed _("") i18n support. All references
6104 updated. All output functions updated to handle structures rather
6105 than local or static variables. Adapt to new PSPP lex_*()
6109 (macro MAX_N_SBC) Removed.
6110 (global bare) Removed.
6111 (enum STRING) Renamed T_STRING.
6112 (enum ID) Renamed T_ID.
6113 (get_buffer) Buffer size increased.
6114 (strlower) Renamed st_lower(), rephrased.
6115 (strupper) Renamed st_upper(), rephrased.
6116 (skip_ws) New function.
6117 (get_line) Don't special-case any types of lines (like those
6118 beginning with ! or $, for instance).
6119 (get_token) Renamed lex_get(). Rephrased.
6120 (static var `prefix') New.
6121 (parse) New function.
6122 (parse_setting) Minor rephrasing.
6123 (dump_specifier_vars) Ditto.
6124 (make_identifier) Put null terminator on identifier, duh.
6125 (dump_vars) Renamed dump_declarations(). Never indent. Never
6126 static. Output changed entirely.
6127 (dump_specifier_init) Rephrase.
6128 (dump_vars_init) No index variable needed. Other modifications.
6129 (dump_parser) Don't parse command name. Do dump functions instead
6130 of just code fragments.
6131 (dump_free) Dump function instead of code fragment.
6132 (recognize_directive) New function.
6133 (main) Use recognize_directive(). Don't rely on magic $ line
6134 beginning: instead, parse comments. Update list of headers.
6136 * random.c: New file, containing the following functions:
6137 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
6138 rand_normal, rand_simple.
6140 * random.h: New file.
6142 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
6143 function. `max_src_width', `max_dst_width' changed to size_t.
6144 (internal_cmd_recode) Removed.
6145 (parse_dest_spec) Merge similar cases.
6146 (parse_src_spec) Add assertion.
6148 * repeat.c: (recognize_keyword) New function.
6149 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
6150 REPEAT. Improve recognition of END REPEAT (use
6151 recognize_keyword()). Move from curfn to getl_location(). Use
6154 (perform_DO_REPEAT_substitutions) Adapt to struct string.
6156 * set.q: Adapt to new q2c.
6157 (cmd_set) Range-check some values better.
6158 (custom_blanks) Renamed stc_custom_blanks().
6159 (custom_length) Renamed stc_custom_length().
6160 (custom_results) Renamed stc_custom_results().
6161 (custom_seed) Renamed stc_custom_seed().
6162 (custom_width) Renamed stc_custom_width().
6163 (custom_format) Renamed stc_custom_format().
6164 (custom_journal) Renamed stc_custom_journal().
6165 (custom_color) Renamed stc_custom_color().
6166 (custom_listing) Renamed stc_custom_listing().
6167 (custom_disk) Renamed stc_custom_disk().
6168 (custom_log) Renamed stc_custom_log().
6169 (custom_rcolor) Renamed stc_custom_rcolor().
6170 (custom_viewlength) Renamed stc_custom_viewlength().
6171 (custom_workdev) Renamed stc_custom_workdev().
6173 * settings.h: Not necessary to include format.h any longer.
6175 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
6176 (corrupt_msg) Rewritten.
6178 * sort.c: Adapt to rewritten heap ADT.
6180 * str.c: (aa_strcpy) Removed.
6181 (ab_strcpy) Removed.
6182 (ac_strcpy) Removed.
6183 (ba_strcpy) Removed.
6184 (bb_strcpy) Removed.
6185 (ca_strcpy) Removed.
6186 (aa_strdup) Removed.
6187 (aa_strdupcpy) Removed.
6188 (ba_strdup) Removed.
6189 (sa_strdup) Removed.
6190 (memrev) Renamed mm_reverse().
6191 (memrmem) Renamed mm_find_reverse().
6192 (cmp_str) Renamed st_compare_pad().
6193 (strmaxcpy) Removed.
6194 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
6195 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
6197 (strpadcpy) Renamed st_pad_copy(), signature changed.
6198 (blpstrset) Removed.
6199 (ds_create) New function.
6200 (ds_init) New function.
6201 (ds_replace) New function.
6202 (ds_destroy) New function.
6203 (ds_clear) New function.
6204 (ds_extend) New function.
6205 (ds_shrink) New function.
6206 (ds_truncate) New function.
6207 (ds_length) New function.
6208 (ds_size) New function.
6209 (ds_value) New function.
6210 (ds_end) New function.
6211 (ds_concat) New function.
6212 (ds_concat_buffer) New function.
6213 (ds_printf) New function.
6214 (ds_putchar) New function.
6215 (ds_getline) New function.
6216 (ds_get_config_line) New function derived from the old
6217 misc.c:get_config_line().
6218 (ls_create) New function.
6219 (ls_create_buffer) New function.
6220 (ls_init) New function.
6221 (ls_shallow_copy) New function.
6222 (ls_destroy) New function.
6223 (ls_null) New function.
6224 (ls_null_p) New function.
6225 (ls_empty_p) New function.
6226 (ls_length) New function.
6227 (ls_value) New function.
6228 (ls_end) New function.
6230 * str.h: Reformatted.
6231 (struct a_string) Removed.
6232 (struct b_string) Removed.
6233 (struct c_string) Removed.
6234 (struct len_string) New.
6235 (struct string) New.
6236 (macro as_streq) Removed.
6237 (macro bs_streq) Removed.
6238 (macro cs_streq) Removed.
6239 (macro sa_streq) Removed.
6240 (macro sb_streq) Removed.
6241 [__GNUC__] (inline function ds_putchar) New function.
6242 [__GNUC__] (inline function ds_length) New function.
6243 [__GNUC__] (inline function ds_value) New function.
6244 [__GNUC__] (inline function ds_end) New function.
6246 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6247 (display_vectors) Fix missing i18n.
6249 * t-test.q: Migrate to new q2c.
6251 * tab.c: Migrate from arenas to pools.
6252 (tab_create) Use struct len_string.
6253 (tab_realloc) Ditto.
6254 (text_format) Ditto.
6255 (tab_joint_text) Ditto.
6256 (tab_natural_width) Remove rich text support.
6257 (tab_natural_height) Ditto.
6258 (tab_output_text) Handle TAT_FIX.
6259 (tab_raw) Change arg from a_string to len_string.
6260 (tabi_driver) Fix assertion. Use struct len_string.
6261 (render_strip) Use struct len_string. Remove rich text support.
6262 Add `const' qualifiers.
6264 * tab.h: (enum TAB_RICH) Remove.
6265 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6266 SOM_COL_* updated to read TAB_COL_*.
6267 (struct tab_table) Change arena to pool. Change a_string to
6270 * temporary.c: (restore_dictionary) Rewrite Checker code.
6272 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6273 LOWEST, HIGHEST) Moved here from common.h.
6274 (typedef any_trns) Removed. All references changed to `struct
6277 * vars-atr.c: (force_create_variable) Fix assertion.
6278 (force_dup_variable) Fix assertion.
6280 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6282 Using alphanumeric variables in functions under AGGREGATE
6283 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6284 <BZN-mdksh@t-online.de> for reporting this bug.
6286 * aggregate.c: (parse_aggregate_functions) When setting the
6287 FSTRING bit, also allocate memory for the `string' member of
6289 (free_aggregate_functions) Free iter->string. Don't use the
6290 non-function bits when indexing the array of functions.
6291 [DEBUGGING] (debug_print) Don't use the non-function bits when
6292 indexing the array of functions.
6294 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6296 Under certain circumstances, the final case would be omitted from
6297 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6298 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6300 * aggregate.c (agr_00x_end_func): Increment number of cases in
6301 sink before writing case. For streams that keep track of how many
6302 cases there are based on this value, this means that the last case
6303 will be read in on the next stream read.
6305 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6307 Undefined behavior was invoked by referencing a freed pointer.
6309 * vfm.c (memory_stream_write): Free pointer *after* checking for
6312 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6314 A wrong record size was displayed when paging the active file to
6317 * vfm.c: (memory_stream_write) Fix off-by-one error.
6319 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6321 Not having enough temporary space for sorting caused a core dump.
6324 * sort.c: (allocate_cases) Initialize i.
6326 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6328 Syntax errors in function descriptions on AGGREGATE caused core
6331 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6332 free_aggregate_functions(), since that function already frees
6335 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6337 A null pointer was dereferenced, causing a core dump, when
6338 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6339 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6340 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6342 * arena.c: (arena_malloc) If the arena hasn't been initialized
6343 already, initialize it.
6345 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6347 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6348 for compilation with Cygnus Windows B20. Not used by other
6351 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6353 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6354 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6356 * sort.c: (compare_case_lists) Reverse sense of comparison if
6357 sorting in descending order.
6358 (compare_record) Ditto.
6360 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6362 SPLIT FILE with a string variable caused a core dump. Fixed.
6364 * vfm.c: If the variable is a string then make a temporary value
6365 struct pointing to it. The underlying problem is a lot bigger
6366 than this (see TODO) but this is a stopgap for the simple case at
6369 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6371 Nested INCLUDEs didn't work. Fixed.
6373 * getline.c: (getl_include) Set first_line to NULL in allocated
6376 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6378 The MATCH FILES procedure set the values of variables not present
6379 to 0. It should have been SYSMIS. This is now fixed.
6381 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6383 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6385 The REMARK command was too aggressive about skipping lines. It
6386 didn't like being the last command in a file.
6388 * command.c: (cmd_remark) Call get_entire_line() instead of
6391 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6393 Comment parsing wasn't consistent with the rest of the code in its
6394 idea of where one command ends and another starts. This meant
6395 that sometimes commands would be mysteriously ignored. Thanks to
6396 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6398 * command.c: (parse_cmd) Hand off comment parsing to new function
6399 skip_comment() in lexer.c.
6400 * lexer.c: (skip_comment) New function.
6402 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6404 The TABLE subcommand on MATCH FILES worked only erratically at
6405 best. This fixes it. Thanks to Dr. Dirk Melcher
6406 <BZN-mdksh@t-online.de> for reporting this bug.
6408 * get.c: (mtf_compare_BY_values) When comparing string values, a
6409 difference of 1 is still a difference :-)
6410 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6411 advance TABLE files automatically when matched. Comment fixes.
6413 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6415 VARIABLE LABELS rejected a slash before the first variable
6416 specification, contradicting the documentation. Thanks to Walter
6417 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6419 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6420 command specification.
6422 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6424 Because of an incorrect optimization in memory allocation,
6425 CROSSTABS sometimes segfaulted when asked to output multiple
6426 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6429 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6430 are passed to output_pivot_table() for its use.
6431 (output_pivot_table) Instead of assuming the number of columns is
6432 constant, keep track with maxcols. In general mode, use maxcells
6433 to determine whether more matrix cells need to be allocated.
6435 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6437 CROSSTABS didn't display value labels for column and row
6438 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6441 * crosstabs.q: (table_value_missing) If the specified value has a
6442 value label for this variable, then show it instead of the raw
6444 (display_dimensions) Delegate display of value_labels to
6445 table_value_missing.
6447 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6449 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6450 <BZN-mdksh@t-online.de> for reporting this bug.
6452 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6453 if the file isn't declared as binary.
6455 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6457 MATCH FILES corrupted memory and dumped core on some syntax
6460 * get.c: (cmd_match_files) Set file->handle to NULL before
6462 (mtf_free_file) Don't free a null dictionary.
6464 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6466 MATCH FILES should set numeric values not available to the
6467 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6468 <BZN-mdksh@t-online.de> for reporting this bug.
6470 * get.c: (mtf_processing) Set unused records to system-missing,
6473 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6475 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6476 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6478 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6479 in newly created dictionary, and add each copied variable to the
6482 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6486 * get.c: (trim_dictionary) Free variable list for KEEP after
6489 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6491 Some systems didn't like the way open_file was coded. Thanks to
6492 Hankin <hankin@rogue.consultco.com> for pointing this out.
6494 * filename.c: (open_file) Don't try to store stdin, stdout,
6495 stderr as part of an array, because that doesn't always work.
6497 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6499 The SAVE procedure didn't save long string variables properly.
6500 Fixed by this patch. Thanks to Hankin
6501 <hankin@rogue.consultco.com> for this patch.
6503 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6504 out variable pad records.
6506 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6508 Previously, if PRINT SPACE were given a negative argument, it
6509 would report an error, then spin in an (almost) infinite loop.
6510 This fixes that behavior.
6512 * print.c: (print_space_trns_proc) After reporting a negative
6513 argument, set number of lines to print to 1.
6515 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6517 SPSS 8.0 outputs some new record types in its system files, and it
6518 allows longer value labels. Accept these system files.
6520 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6521 11 emitted by SPSS 8.0.
6523 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6525 The LIST procedure was too conservative in allocating space for
6526 buffers, which caused a bug that only showed up with very long
6527 output variables. Thanks to Hankin <hankin@dunno.com> for this
6530 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6532 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6534 Typo meant string format specifiers weren't checked properly. I
6535 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6536 willing to be corrected on this point.
6538 * format.c: (check_string_specifier) Fix obvious typo.
6540 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6542 Using $CASENUM in an expression didn't work. Here's a fix.
6543 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6546 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6548 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6550 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6552 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6553 other behavior, *sigh*. This patch hopefully fixes that. This
6554 time I've actually tested it.
6556 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6558 * data-list.c: (read_from_data_list_free,
6559 read_from_data_list_list) Call parse_string_as_format() directly
6560 without mucking around with the field width.
6562 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6564 Occasionally, you may encounter a script that wants to be
6565 interpreted in interactive mode. Make -i emulate this behavior to
6566 allow such scripts to be executed with PSPP.
6568 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6570 * cmdline.c: (pre_syntax_message[]) Update -i description.
6572 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6573 when -i is given on the command line) don't treat unindented lines
6574 as starting a new command.
6576 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6578 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6579 mostly caused by local initialized aggregates. After egcs is
6580 fixed upstream these can be removed, but for now they're not a big
6583 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6584 initialized arrays. Avoid this.
6586 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6589 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6591 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6592 following changes avoid. Currently I compile sources with egcs
6593 1.1.1 and gcc 2.7.2.3 before sending them out.
6595 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6597 * ascii.c: (option_tab[]) Initialize all struct members.
6599 * avl.h: (avl_traverser_init) New macro.
6601 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6604 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6607 * hash.c: Comment fix.
6609 * hash.h: (hsh_iterator_init) New macro.
6611 * html.c: (option_tab[]) Initialize all struct members.
6613 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6616 * postscript.c: (option_tab[]) Initialize all struct members.
6617 (output_encodings, preclose, dump_lines) Use new
6618 hsh_iterator_init() macro.
6620 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6623 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6626 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6628 * data-in.c: Examined each of the parsing functions to make sure
6629 that they wouldn't dump core if they were passed a string of the
6630 wrong length, since now the DATA LIST FREE/LIST routines don't
6631 check for field width before passing it to the data parser.
6632 (parse_RBHEX, parse_AHEX) Reject odd length input.
6633 (parse_string_as_format) Reject input that's too short or too
6636 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6637 a field to its entire declared output width then pass it to the
6638 data-in parsing routines. This contradicted the documented
6639 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6640 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6641 free-format parsing that differed from SPSS.
6642 (cut_field) Commas and spaces are treated identically. Returns
6643 the proper column instead of a fixed 1 value.
6644 (parse_field) Removed.
6645 (read_from_data_list_free, read_from_data_list_list) Call
6646 parse_string_as_format directly instead of parse_field.
6648 * heap.c: (heap_delete) Stylistic fixes.
6650 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6652 * loop.c: (loop_2_trns_proc) Formatting fix.
6654 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6656 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6658 * vfm.c: (macro FILTERED) New.
6659 (static var filter_var) New.
6660 (process_active_file_write_case) Use FILTERED.
6661 (setup_filter) Set filter_var.
6662 (close_active_file) Delete the filter if not
6663 FILTER_before_TEMPORARY.
6664 (procedure_write_case) Use FILTERED.
6666 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6668 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6670 * data-in.c: (parse_day_count) Message fix.
6671 (parse_month) Style fix.
6673 * data-list.c: (struct data_list_pgm) New member eof.
6674 (cmd_data_list) Init eof to 0.
6675 (do_reading) Implement the /END subcommand and read-past-eof
6678 * do-if.c: Include stdio.h when debugging.
6679 (cmd_else_if) Make sure the command is .-terminated.
6681 * glob.c: (init_glob) Capitalize the command prompt.
6683 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6684 (end_file_trns_proc) Debugging message.
6686 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6688 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6690 * main.c: (dump_token) Make kwtab[] const.
6692 * set.q: Spelling, comment fixes.
6694 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6697 * vars-prs.c: (fill_all_vars) Style fix.
6699 * vfm.c: (index_to_varname) Return const.
6701 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6703 * Changes in many source files for partial -ansi -pedantic and
6704 no-debugging compliance: Remove trailing common in enum
6705 declarations; add `unused' attributes; insert some appropriate
6708 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6710 * command.c: (shell) Make static.
6711 (run_command) Make static.
6713 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6715 * dfm.c: (cmd_begin_data) I18n fix.
6717 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6719 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6721 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6724 * file-handle.q: Don't prepend the source file directory name to
6725 the data file name. (Ongoing issue.)
6726 (prepend_current_directory) Comment out.
6727 (internal_cmd_file_handle) Don't call prepend_current_directory().
6728 (fh_get_handle_by_filename) Ditto.
6730 * filename.c: Append zero byte to readlink() return value.
6732 * getline.c: (getl_read_line) I18n fix.
6734 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6736 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6738 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6741 * postscript.c: (output_encodings) Don't use local_strdup().
6744 * print.c: Don't use gcc features if __STRICT_ANSI__.
6746 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6748 * recode.c: (parse_src_spec) Fully brace nested if's.
6750 * set.q: (global var set_testing_mode) New var.
6752 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6754 * ascii.c: Add some more `unused' attributes that only come into
6755 play when NDEBUG is defined.
6756 (ascii_close_page) Set s_len when reallocating s.
6758 * crosstabs.q: (delete_missing) New function.
6759 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6760 (make_summary_table) Create summary table reallocable.
6762 * postscript.c: Add more `unused' attributes as above.
6764 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6765 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6767 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6770 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6771 gratuitous space between parameter definition.
6773 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6774 complaints about running off the end of functions with NDEBUG
6777 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6779 * Several source files: Removed some PORTME notes when reflection
6780 revealed that ANSI forbids that sort of breakage. Also, added
6781 lots of `unused' qualifiers here and there.
6783 * aggregate.c: (accumulate_aggregate_info) Remove local var
6784 weighting that turned out not to be used.
6786 * avl.c: Update to version 1.1.0. Add unused specifier.
6787 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6789 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6790 (avl_find) Cast return value to void *.
6791 (avl_delete) q doesn't need to be initialized at the beginning of
6792 the function. Replace some instances of 1 with +1.
6793 (force_avl_delete) Renamed avl_force_delete, all references changed.
6794 (compare_ints) `param' marked unused.
6795 (print_int) `param' marked unused.
6796 (recurse_tree) Replace some instances of 1 with +1.
6798 * avl.h: Update to version 1.1.0. Only declares avl function
6799 types if not already declared.
6800 (AVL_MAX_HEIGHT) Only define if not already defined.
6801 (struct avl_node) New unused member char pad[2].
6802 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6803 (force_avl_insert) Renamed avl_force_insert.
6804 (force_avl_delete) Renamed avl_force_delete.
6806 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6808 (struct crosstab) Add new member `ofs'.
6809 (glob var int_tab) Removed.
6810 (custom_tables) In integer mode, assign v[i] properly through the
6812 (custom_variables) Now p.crs.max == max + 1.
6813 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6814 (precalc) Implement integer mode.
6815 (calc_integer) Implement integer mode.
6816 (compare_table_entry) Remove unused local variable `comparing'.
6817 (make_summary_table) Implement integer mode.
6818 (macro ns_rows) Implemented as static variable now.
6819 (several variables) Made static, from global.
6820 (output_pivot_table) Use table_value_missing() for column heads.
6821 Remove several unused local variables. Implement integer mode
6822 table summing. Count up ns_rows.
6823 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6824 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6825 calls that function or find_pivot_extent_integer.
6826 (find_pivot_extent_integer) New function.
6827 (enum_var_values) Implemented for integer mode.
6828 (table_value_missing) New function.
6829 (display_dimensions) Call table_value_missing() for heads.
6830 (float_M_suffix) New function.
6831 (display_crosstabulation) Call table_value_missing() for row
6832 heads. Handle missing values in /MISSING=REPORT mode.
6833 (calc_fisher) Remove unused var N.
6834 (calc_r) Remove unused var fact.
6836 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6837 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6839 * data-out.c: (insert_commas) Remove unused var cp.
6840 (convert_CCx) Remove unused vars save_set_decimal,
6843 * descript.q: (dump_z_table) Fix table dimensioning.
6844 (pre_calc) Remove unused var j.
6845 (display) Remove unused vars title, s. Fix table dimensioning.
6847 * expr-evl.c: Comment fixes.
6849 * frequencies.q: (full_dim) New function.
6850 (dump_full) Fix table dimensioning.
6851 (condensed_dim) New function.
6852 (dump_condensed) Fix table dimensioning.
6854 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6857 * html.c: (html_close_drive) Remove unused var i.
6858 (postopen) Remove unused vars title, curfn_len, cp.
6859 (preclose) Remove unused vars this, x.
6861 * lexer.c: Comment fixes.
6863 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6865 * means.q: (custom_tables) Remove unused var m_dim.
6867 * mis-val.c: Format fix.
6869 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6871 * output.c: (outp_get_paper_size) Remove unused var cp.
6873 * pfm-read.c: (read_float) Remove unused var save, unused label
6875 (read_variables) Remove unused vars cp, j.
6876 (read_value_label) Remove unused var j.
6878 * pfm-write.c: (bufwrite) Remove unused var i.
6880 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6882 (output_encodings) Remove unused vars char_cp, n_output.
6883 (read_ps_encodings) Remove unused var ep.
6884 (postopen) Remove unused var title.
6885 (preclose) Remove unused var fp.
6886 (ps_open_page) Remove unused vars true, false, orientation,
6887 mirror_horz, mirror_vert, width, length.
6888 (ps_text_metrics) Remove unused var x.
6890 * q2c.c: (find_symbol) Remove unused var y.
6891 (parse_setting) Remove unused parameter sbc, all references
6893 (dump_parser) Remove unused var cp.
6894 (dump_free) Remove unused var i.
6896 * set.q: (static vars args, n) Removed.
6897 (internal_cmd_gset) Removed.
6899 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6900 (read_machine_flt64_info) Removed unused var file_endian.
6901 (read_documents) Removed unused var i.
6902 (read_compressed_data) Removed unused parameter dict, all
6905 * sfm-write.c: (bufwrite) Removed unused var i.
6906 (sfm_write_case) Removed unused var i.
6908 * sort.c: (merge_once) Remove unused var t.
6909 (write_separate) #if 0 out as dead code.
6911 * split-file.c: (cmd_split_file) Remove unused var i.
6913 * sysfile-info.c: (sysfile_info_dim) New function.
6914 (cmd_sysfile_info) Fix table dimensioning.
6915 (variables_dim) New function.
6916 (display_variables) Fix table dimensioning.
6917 (describe_variable) Remove unused var prev_r.
6919 * t-test.q: (z_postcalc) Removed.
6920 (pairs_calc) Remove unused var bad_weight.
6921 (postcalc) Remove unused vars dfn, dfd.
6923 * tab.c: (tab_create) Set t->dim to NULL.
6924 (tab_dim) Make sure t->dim is NULL first.
6925 (tab_natural_width) Remove parameter `clamp'.
6926 (tab_value) Remove duplicate assertion for table.
6927 (tab_raw) New function.
6928 (nowrap_dim) New function.
6929 (wrap_dim) New function.
6930 (tab_output_text) Fix table dimensioning.
6932 * tab.h: (tab_raw) New macro.
6934 * val-labs.c: (get_label) Remove unused var type.
6935 (copy_value_labels) Remove unused var trav.
6937 * var.h: (struct crosstab_proc) Completely changed.
6939 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6941 * vfm.c: (open_active_file) Remove unused vars i, lp.
6943 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6945 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6947 * Makefile.am: Add apply-dict.c, flip.c.
6949 * apply-dict.c: New file.
6951 * command.c: (struct command) Make cmd[] larger for CLEAR
6952 TRANSFORMATIONS command name.
6953 (parse_cmd) Make sure we're in a valid state before using it as an
6954 index. Discard variables and reset state on invalid transitions.
6955 (cmd_clear_transformations) New function.
6957 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6958 Add unimplemented PRESERVE, RESTORE.
6960 * file-handle.h: Include stddef.h.
6964 * pfm-read.c: (parse_value) Pad value label values with spaces,
6967 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6968 (sfm_close) Decrement reference count, make sure it's zero.
6969 (sfm_maybe_close) New function.
6970 (sfm_read_dictionary) Handle reference counts.
6972 * vars-atr.c: (clear_default_dict) New function.
6973 (discard_variables) Use clear_default_dict().
6975 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6977 * Makefile.am: Add pfm-write.c.
6978 (LDADD) Add the libgmp2 libraries.
6980 * command.def: Define EXPORT.
6982 * get.c: (cmd_export) New function.
6983 (export_write_case_func) New function.
6985 * pfm-read.c: (static spss2ascii[]) Make it const.
6987 * pfm-write.c: New file.
6989 * sfm-write.c: Formatting, comment fixes.
6991 * var.h: Comment fix.
6993 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6995 * Makefile.am: Add pfm.h, pfm-read.c.
6997 * command.def: IMPORT is now implemented.
6999 * format.c: (glob var translate_fmt[]) New var.
7001 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
7002 (cmd_import) New function.
7003 (import_source_read) New function.
7004 (glob var import_source) New var.
7006 * pfm-read.c: New file.
7010 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
7012 (dump_dictionary) Disabled printing a couple of items.
7014 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
7016 * crosstabs.q: (postcalc) Call make_summary_table().
7017 (make_summary_table) New function.
7018 (insert_summary) New function.
7019 (display_dimensions) Remove some unnecessary arguments, all
7021 (output_pivot_table) Fix lots of problems with the risk table
7023 (submit) Don't display an empty table.
7024 (display_risk) Fix order of arguments to calc_risk().
7026 * glob.c: Always include assert.h and stdlib.h.
7028 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
7031 * tab.c: (tab_create) Cosmetic changes.
7033 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
7035 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
7039 * crosstabs.q: (output_pivot_table) Headers drawing and submission
7040 code simplified, moved into new function submit().
7041 (submit) New function.
7042 (crosstabs_dim) New function.
7043 (display_directional) Substitute variable names for %s where
7045 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
7046 (calc_symmetric) Initialize parameters only if non-NULL.
7047 Calculate Somers' d.
7048 (calc_directional) Calculate Somers' d (or copy it, really).
7051 * output.c: (outp_string_width) New function.
7053 * postscript.c: (postopen) Calculate font widths based on the
7054 width of the zero '0' character, not the width of the space
7055 character. Set paper-width and paper-length based on points, not
7057 (ps_open_page) Fix page setup string for landscape mode.
7059 * som.h: (struct som_dimension) Removed.
7060 (struct som_table_class) height, width members take int * not
7063 * tab.c: Many functions now have added parameter validation.
7064 (tab_height, tab_width) These functions were removed and merged
7065 into a single function tab_resize(), and all references changed.
7066 (tab_dim) Rewritten since the interface changed; reduced from
7067 hundreds of lines to two. All callers were changed. Currently
7068 most of them just use tab_natural_dimensions as their callback and
7069 await detailed translation of functionality.
7070 (tab_natural_width) New function.
7071 (tab_natural_height) New function.
7072 (tab_natural_dimensions) New function. This is a callback
7073 function, not something that you'd want to call directly.
7074 (tab_nat_dim) Removed.
7075 (tabi_table) Allocates t->w and t->h.
7076 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
7077 dimensions callback.
7078 (evaluate_dimensions) Removed.
7079 (sum_columns) Removed.
7081 * tab.h: (enum TAL_1THIN) Removed.
7082 (enum series t_*) Removed.
7083 (struct tab_table) Members trh, trv changed to unsigned char *
7084 from int *. Member dim changed to a function pointer from a
7085 unsigned char *. Member max_stack_height removed. New members
7087 (macros tab_l, tab_r, tab_t, tab_b) New.
7089 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
7091 * ascii.c: (delineate) Assign last_space_nchars before skipping
7092 spaces, to fix right justification.
7094 * crosstabs.q: (static vars risk, direct) New vars.
7095 (static var pearson_r) Removed.
7096 (glob var chisq_fisher) Made static.
7097 (static vars row_tot[], col_tot[]) Don't include grand total
7099 (static var grand_total) Renamed W, all references changed.
7100 (output_pivot_table) Only make `table' if num_cells != 0. Make
7101 risk and directional tables. Deal with grand total no longer part
7102 of col_tot[]. Free rows and cols after we're done with them.
7103 (display_risk) New function.
7104 (display_directional) New function.
7105 (clac_r) Rewritten so that it stores all its results into its
7106 arguments, so it can be used for Spearman's correlation too.
7107 (calc_symmetric) Added a t[] argument, all references changed.
7108 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
7109 Pearson's r, Cohen's kappa.
7110 (calc_risk) New function.
7111 (calc_directional) New function.
7113 * som.c: (som_submit) Improved debugging code.
7115 * stats.c: (hypercube) New function.
7116 (cube) New function.
7118 (normal_sig) Went back to old implementation, which actually
7121 * stats.h: (macros square, cube, hypercube) Removed. The
7122 equivalent functions in stats.c are inlined here; all references
7123 to square changed to sqr.
7125 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
7127 * crosstabs.q: (N_SYMMETRIC) New define.
7128 (postcalc) Disable debug printing.
7129 (static vars chisq_fisher, pearson_r) New.
7130 (output_pivot_table) Add support for symmetric measures. Add
7131 chi-square output of exact sigs.
7132 (display_chisq) Rewritten.
7133 (display_symmetric) New function.
7134 (gamma_int) New function.
7136 (swap) New function.
7137 (calc_fisher) New function.
7138 (calc_chisq) Check boundary conditions better. Calculate Yates,
7139 Fisher, Mantel-Haenszel tests.
7140 (calc_r) New function.
7141 (calc_symmetric) New function.
7143 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
7145 (chisq_sig) Better boundary conditions. Renamed from
7148 * tab.h: (struct tab_table) New member cf.
7150 * tab.c: (tab_create) Set cf.
7151 (tab_width) New function.
7152 (tab_realloc) Handle cf.
7153 (tab_vline) Handle cf.
7154 (tab_hline) Handle cf.
7155 (tab_box) Handle cf.
7156 (tab_value) Handle cf.
7157 (tab_float) Handle cf.
7158 (tab_text) Handle cf.
7159 (tab_joint_text) Handle cf.
7160 (tab_offset) Handle cf.
7161 (tab_next_row) Handle cf.
7162 (evaluate_dimensions) Handle cf.
7163 (render_strip) Handle cf.
7165 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
7167 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
7168 output_pivot_table().
7169 (output_pivot_table) Moved lots of local variables outside and
7170 made them static. Add beginnings of chi-square statistic
7171 support. Now column and row totals aren't in the main matrix.
7172 Always zero out any leftover rows & columns after we're done with
7173 the table entries. Move all output stuff into
7174 display_dimensions(), display_crosstabs(), display_chisq().
7175 (display_dimensions) New function.
7176 (display_crosstabulation) New function.
7177 (display_chisq) New function.
7178 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
7180 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
7181 references, simplify logic.
7183 * postscript.c: Remove scale, translate-x, translate-y,
7184 mirror-horz, mirror-vert, rotate-180 options.
7185 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
7186 All references deleted.
7187 (macro YT) New macro.
7188 (array option_tab[]) Removed options.
7189 (ps_option) Removed options.
7190 (ps_open_page) Write page setup explicitly to output file, without
7191 using now-deleted BP function.
7192 (macro dump_line) Use YT().
7193 (macro dump_thick_line) Use YT().
7194 (draw_headers) Use YT().
7195 (switch_font) Reorder arguments to SF function.
7196 (write_text) Use YT().
7198 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
7201 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
7203 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
7204 null-debugging code.
7205 (tab_realloc) Remove null-debugging code. Initialize new regions
7207 (tab_vline) Support offsets.
7208 (tab_hline) Support offsets.
7209 (tab_box) Support offsets.
7211 (tab_nulls) Removed.
7214 (evaluate_dimensions) Remove null-debugging code. Understand
7215 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
7216 TAB_EMPTY not present.
7218 * tab.h: New cell attribute TAB_EMPTY.
7219 (macros tab_nr, tab_nc, tab_row, tab_col) New.
7221 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
7222 try to read them from system files.
7224 * vfm.c: (dump_splits) Don't call tab_null().
7226 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7228 * crosstabs.q: (struct crosstab) Added `missing' member.
7229 (custom_tables) Init missing.
7230 (calc_general) Handle missing values.
7231 (calc_chisq) New function.
7232 (output_pivot_table) Start work on chi-square output. Update for
7233 new tab offset support functions. Shorten statistic names.
7235 * Several files: add in more `const's to placate gcc's warnings.
7237 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7240 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7241 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7242 tab_joint_text) Add col_ofs and row_ofs support.
7243 (tab_offset) New function.
7244 (tab_next_row) New function.
7245 (tab_row) New function.
7246 (tab_col) New function.
7247 (tabi_table) Add col_ofs and row_ofs support.
7249 * vars-atr.c: (is_system_missing) New function.
7251 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7253 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7254 (static var no_cells) Removed.
7255 (static var num_cells) New.
7256 (static var expected) New.
7257 (static var cells[]) New.
7258 (internal_cmd_crosstabs) Deal with new variables.
7259 (postcalc) Removed most of the meat and put it in new function
7260 output_pivot_table().
7261 (output_pivot_table) Calculates and outputs an entire pivot table.
7263 * postscript.c: (postopen) Fix problems with free()ing addresses
7264 not obtained from malloc().
7266 * som.c: (som_submit) Add assertion.
7268 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7271 * tab.c: (static var tab_names[]) New.
7272 (tab_realloc) -1 for nc or nr indicates no change.
7273 (tab_nulls) New function.
7274 (tab_dim) Use tab_names[].
7275 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7276 (evaluate_dimensions) Don't terminate on uninited cells, just put
7277 an X in them and emit a notice. Use tab_names[].
7279 * tab.h: Move bits into tab.def.
7281 * tab.def: New. Don't try to declare tab_table_class because then
7282 som.h has to be included.
7284 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7286 * command.def: New file, contains all the command definitions
7287 previously included bodily in command.c.
7289 * format.def: New file, contains all of the format definitions
7290 previously split across format.h, format.c, and sfm-write.c.
7292 * lexer.h: Renamed from tokens.h in order to match corresponding
7295 * lexerP.h: Moved some rarely used functions exported by lexer.c
7298 * Makefile.am: Commemorate renamed files.
7299 (EXTRA_DIST) Add command.def, format.def.
7301 * command.c: [0] (walk_cmdtable_func) Removed.
7303 * crosstabs.q: (postcalc) Made it work and print out matrices
7305 (enum_column_values) Renamed enum_var_values, generalized for any
7308 * format.h: (struct fmt_desc) New member `spss'.
7310 * q2c.c: (main) Generated code includes lexer.h instead of
7313 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7314 instead of an independent translation table.
7316 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7318 * Lots of source files: Added const to declarations.
7320 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7322 * arena.c: (arena_clear) Set prev pointer to null when done.
7324 * ascii.c: (ascii_option) Rename index as indx.
7326 * avl.c: This is now a separate library called libavl.
7327 (xmalloc) Make static.
7328 (avl_probe) Step A7 can use the cache instead of an explicit
7330 (avl_delete) Don't maintain a q pointer because it's always
7331 available in the pointer stack. Comment fix.
7333 * avl.h: This is now a separate library called libavl.
7335 * command.c: (cmd_table[]) Remove spurious trailing "".
7337 * common.h: Only include random() fix if this system needs it.
7339 * crosstabs.q: Include alloca headers.
7340 (n_sorted_tab) New global var.
7341 (postcalc) Mostly rewritten.
7342 (find_pivot_extent) Rewritten.
7343 (enum_column_values) Rewritten.
7345 * data-out.c: (convert_F) Rename inner n as n_spaces.
7347 * error.c: (dump_message) Don't have an outer var i.
7349 * file-handle.q: (static var f) Removed. All references removed.
7350 (internal_cmd_file_handle) Uses a local variable instead of f.
7352 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7353 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7356 * getline.h: Declare getl_history as extern. Reported by
7357 palme@uni-wuppertal.de (Hubert Palme).
7359 * postscript.c: (postopen) Some large mods for constness.
7361 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7364 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7366 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7367 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7370 * avl.c, avl.h: New files. These form a clean-room
7371 reimplementation of avllib. Iterative algorithms are used in
7372 place of recursive ones, so there is no resemblance in the code.
7374 * Lots of headers: Don't include other headers by default.
7376 * Lots of source files: Explicitly include all needed headers.
7378 * arena.c: (arena_clear) New function.
7380 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7381 (static var ar) Removed.
7382 (staitc vars ar_tc, ar_col) New.
7383 (cmd_crosstabs) Destroy the arenas.
7384 (internal_cmd_crosstabs) Create the arenas.
7385 (precalc) Don't need a free function for the hash.
7386 (calc_general) Make sure to zero out the trailer on the key data
7388 (print_table_entries) Updated.
7389 (postcalc) Worked on actually implementing.
7390 (find_pivot_extent) New function.
7391 (compare_value) New function.
7392 (enum_column_values) New function.
7394 * data-in.c: (parse_month) Make local array `static const'.
7396 * data-out.c: (convert_date) Make local array `static const'.
7397 (convert_WKDAY) Same.
7398 (convert_MONTH) Same.
7400 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7401 been renamed to avl_walk().
7403 * hash.c: Rewritten more efficiently.
7405 * hash.h: Add attribute const to hsh_next_prime declaration.
7407 * lexer.c: (id_match) Make arguments const.
7409 * postscript.c: (ps_postopen_driver) Make default fonts the
7412 * q2c.c: (main) Generated code needs stdlib.h.
7414 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7415 initialized to 0 now, not to NULL. All other references to
7416 avl_traverser were updated in the same way.
7418 * tokens.h: Macro version of id_match updated to use const
7421 * val-labs.c: (inc_ref_count) New function.
7422 (copy_value_labels) Simply through use of new avl_copy() function.
7424 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7426 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7427 (postcalc) Worked on this.
7429 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7430 (struct ps_driver_ext) New line_width_thick member.
7431 (ps_preopen_drive) Init line_width_thick.
7432 (option_tab[]) Add line-* options.
7433 (ps_option) Parse line-* options.
7434 (postopen) Add line_width_thick support. Strip leading spaces on
7435 prologue output lines.
7436 (ps_open_page) Include line_width_thick in output.
7437 (macro dump_thick_line) New.
7438 (dump_fancy_line) Support thick lines as well as double lines.
7440 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7442 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7443 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7445 * Many source files: Rename `options' to `pv_opts' as appropriate.
7447 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7449 * common.c: (xcalloc) New function.
7451 * crosstabs.q: New file. Not finished yet, though.
7453 * data-list.c: Comment fix.
7455 * error.c: Remove some old Checker cruft.
7457 * frequencies.q: (dump_full) Cumulate valid percent instead of
7460 * getline.c: Comment fix.
7462 * hash.c: Comment fixes.
7464 * hash.h: (struct hsh_table) Make hash functions return unsigned
7465 instead of int to avoid problems with taking the modulo of
7466 negative return values. All references changed.
7468 * misc.c: (intlog10) Make its table static const instead of auto.
7470 * sfm-read.c: (read_header) Make `prefix' static const instead of
7473 * var.h: (union value) Add member `hash'.
7474 (struct variable) Rename prv_index as `foo'--all references
7476 (typedef pv_opts) Removed. All references changed.
7478 * vars-prs.c: (parse_variables) Message fixes.
7480 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7482 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7483 they are being inserted. Don't check for BY variables of
7484 different types. Discard variables if the active file isn't
7485 included in the merge.
7486 (mtf_processing) Essentially rewritten.
7487 (mtf_merge_dictionary) Check for master/slave variables of
7488 different types/widths.
7490 * vfm.c: (static var not_canceled) New var.
7491 (process_active_file) Don't call vfm_source->read() if
7492 there's no vfm-source. Initialize not_canceled.
7493 (process_active_file_write_case) Honor and update not_canceled.
7494 (prepare_for_writing) Rollback changes from yesterday, they were
7496 (close_active_file) Don't destroy vfm_source unless it exists.
7498 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7500 * Lots of source files: Added { } around nested if/else constructs
7501 to avoid new gcc 2.8 warnings.
7503 * data-in.c: (parse_Z) Declare `int' type explicitly.
7506 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7507 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7508 prev members. Put TABLEs at the end of the chain and FILEs at the
7509 beginning. Don't allow the active file in STATE_INIT. Use proper
7510 `seen' value for the active file. Fill out the by members and
7511 make sure they're of consistent type. Do the actual merge
7513 (mtf_processing_finish) New function.
7514 (var_type_description) New function.
7515 (mtf_free_file) New function.
7516 (mtf_free) Rewritten.
7517 (mtf_delete_file_in_place) New function.
7518 (mtf_read_nonactive_records) New function.
7519 (mtf_compare_BY_values) New function.
7520 (static var mtf_seq_no) New var.
7521 (mtf_processing) New function.
7522 (mtf_merge_dictionary) Assign nval members for the system file
7523 dictionary. Assign fv values for its variables. Point each slave
7524 variable to the corresponding master variable.
7526 * hash.c: Include str.h.
7528 * mis-val.c: (copy_missing_values) src arg is const.
7530 * misc.c: (spacing) Make `max' var explicitly int.
7532 * sfm-read.c: (dump_dictionary) Message reformatting.
7533 (sfm_read_case) Add assertion.
7535 * sort.c: Esthetic fixes.
7537 * var.h: (struct match_files_proc) New struct.
7538 (struct variable) Add private data match_files_proc.
7540 * vars-atr.c: (delete_variable) Implement. Add argument for the
7541 dictionary that owning the variable.
7542 (dup_variable) Add assertion.
7544 * vfm.c: Comment fixes, hopefully the comments are correct now.
7545 (process_active_file) New function.
7546 (process_active_file_write_case) New function.
7547 (process_active_file_output_case) New function.
7548 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7550 (write_case) Renamed procedure_write_case(). Now write_case is a
7551 pointer to a function. Style fixes.
7553 1998-03-05 Ben Pfaff <blp@gnu.org>
7555 * Makefile.am: (q2c) Link with libmisc.
7556 (version.c) Define default_config_path, include_path,
7559 * ascii.c: (ascii_postopen_driver) When the default newline string
7560 is requested, open file in text mode. Suggested by
7561 palme@uni-wuppertal.de (Hubert Palme).
7562 (static vars line_buf, line_p) Change from char * to unsigned char
7564 (ascii_close_page) char * to unsigned char *.
7566 * cmdline.c: (parse_command_line) Implement -r option by
7567 prepending ~/.pspp/rc to the list of files to process.
7569 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7570 before pulling in a final line.
7571 (null_func, null_int_func) Removed (dead code).
7573 * descript.q: (display) Calculate width of variable name column
7574 properly. Calculate number of valid cases properly. Reported by
7575 palme@uni-wuppertal.de (Hubert Palme).
7577 * filename.c: (init_filename) Use default_config_path instead of
7578 now obsolete CONFIG_PATH.
7580 * getline.c: (getl_initialize) Use include_path instead of now
7581 obsolete INCLUDE_PATH.
7582 (getl_add_file) New argument `where'. All references changed.
7584 * groff.c: (find_font_file) Use groff_font_path instead of now
7585 obsolete GROFF_FONT_PATH.
7587 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7588 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7589 avoid problems with constness.
7591 * str.h: (macro cs_streq) New macro.
7593 * version.h: (glob var default_config_path, include_path,
7594 groff_font_path) New vars.
7596 1998-02-23 Ben Pfaff <blp@gnu.org>
7598 * Many source files: Change verbose_msg() priority levels and
7601 * aggregate.c: Include debug-print.h.
7603 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7605 (static var pre_syntax_message) Document --safer/-s and
7608 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7610 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7611 because it's not used but it's still copied.
7612 (open_file_r) Remove gratuitous debug message.
7614 * filename.c: (safety_violation) New function.
7615 (open_file) Remove gratuitous debug messages. Don't allow pipe
7616 files if set_safer is set.
7618 * get.c: Turn off debugging.
7620 * getline.c: (getl_add_virtual_file) New function.
7621 (getl_read_line) Add verbose_msg() call for opening new syntax
7623 (getl_perform_delayed_reset) Add a return value describing whether
7624 any action was taken. Call reset_eof().
7626 * getline.h: Comment fix.
7628 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7629 place of incorrect `continue'. Use strtok_r() instead of
7630 strtok(). Always check strtok_r() return value.
7631 (groff_read_DESC) Use strtok_r() instead of strtok().
7633 * lexer.c: (reset_eof) New function.
7635 * main.c: (parse) Get a token after performing a delayed reset
7636 action; allow empty syntax files.
7638 * postscript.c: (output_encodings) Use strtok_r() instead of
7641 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7643 * set.q: Comment fixes.
7644 (glob var set_safer) New var.
7645 (internal_cmd_set) Support SAFER.
7647 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7649 * temporary.c: (free_dictionary) Set d->splits to NULL after
7652 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7653 variable deleted, not if it *isn't* deleted.
7655 1998-02-16 Ben Pfaff <blp@gnu.org>
7657 * command.c: (array cmd_table[]) Add MATCH FILES.
7659 * common.c: Comment fixes.
7661 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7662 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7663 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7666 * expr-opt.c: Include str.h. Problem reported by
7667 palme@uni-wuppertal.de (Hubert Palme).
7669 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7670 (static var mtf_by) Change from char ** to variable **.
7671 (static var mtf_master) New var.
7672 (mtf_merge_dictionary) New function.
7673 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7674 var type. Reorder tests properly. Initialize file->dict. Detect
7675 TABLE= without BY=. Read file dictionaries and merge them. Give
7676 subcommand name with IN, LAST, FIRST error messages. Create IN,
7677 LAST, FIRST variables. Comment fixes.
7678 (mtf_free) Don't free default_dict. Free mtf_master.
7680 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7682 (handle_line_buffer) Cast int to size_t in comparison to avoid
7685 * getline.h: Declare getl_mode extern.
7687 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7688 (groff_read_DESC) Make line_size a size_t.
7689 (match_tok) Parenthesize name to avoid macro expansion.
7691 * mis-val.c: (copy_missing_values) New function.
7693 * postscript.c: (postopen) Make buf_size a size_t.
7695 * sfm-read.c: (dump_dictionary) Make global from static. Print
7696 variable info in parts for easier debugging with Checker.
7698 * temporary.c: (copy_variable) Use copy_value_labels().
7699 (new_dictionary) New arg: whether to copy file label, documents.
7701 * val-labs.c: (copy_value_labels) New function.
7703 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7705 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7707 (dup_variable) Set prv_index, get.fv, get.nv.
7709 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7711 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7713 * Many source files: For ANSI-compliance, add empty statement
7714 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7715 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7717 * data-in.c: (parse_numeric) Some header files break on
7718 -DBL_MIN_10_EXP because they get a --; add () for safety.
7719 Reported by palme@uni-wuppertal.de (Hubert Palme).
7721 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7722 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7723 (dfm_close) Use close_file_ext.
7724 (open_inline_file) Set file.file to NULL, not file.
7725 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7726 struct and use open_file_ext().
7727 (read_record) Use file.file.
7729 * file-handle.q: (prepend_current_directory) Pass through special
7732 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7733 (normalize_filename) Pass through special filenames.
7734 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7736 (dirname) Rename blp_dirname() because of name conflict on some
7737 OS. All references changed. Reported by palme@uni-wuppertal.de
7739 (is_special_filename) New function.
7741 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7742 (trim_dictionary) Conditionalize some of the options on whether
7743 GTSV_OPT_MATCH_FILES is in *options.
7744 (rename_variables) Don't allow variables to be renamed as scratch
7746 (MTF_*) New enum series.
7747 (struct mtf_file) New struct.
7748 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7750 (cmd_match_files, mtf_free) New functions.
7752 * lexer.c: (match_int) Needed parentheses around name to escape
7753 macro expansion. Reported by Micah Altman
7754 <maltman@www-vdc.fas.harvard.edu>.
7756 * print.c: Needed to include alloca.h. Reported by Micah Altman
7757 <maltman@www-vdc.fas.harvard.edu>.
7759 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7760 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7763 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7764 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7766 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7768 * html.c: (struct html_driver_ext) Move into htmlP.h.
7769 (html_preopen_driver) Initialize cp_x, cp_y.
7770 (html_submit) Implement as call to output_tab_table().
7771 (change_attributes) New function.
7772 (escape_string) New function.
7773 (output_tab_table) New function.
7775 * list.q: (write_all_headers) Add code for writing headers for the
7777 (clean_up) Write out the html close-table tag.
7778 (determine_layout) Ignore html driver.
7779 (list_cases) Write html data.
7781 * som.c: (som_submit) Move more of the code into output_table().
7783 * tab.c: (static var hit) Make a global var and rename tab_hit.
7784 (static var tab_table_class) Make a global var.
7786 * htmlP.h: New file.
7788 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7790 * dump-sysfile.c: Removed.
7792 * html.c: (preclose) Change comment in emitted code.
7794 * matrix-data.c: Debugging off by default. Comment fixes.
7795 (static var container) New var.
7796 (cmd_matrix_data) Create and destroy container. Initialize
7797 is_per_factor[] to 0s. Move code into new function
7798 string_to_content_type(). Require split values to be present in
7799 the data when ROWTYPE_ is explicit. Call specific function, not
7800 general read_matrices().
7801 (string_to_content_type) New function.
7802 (context) Exclude all whitespace, not just spaces.
7803 (mget_token) A dot is a number. Add assertion.
7804 (static var data) Renamed nr_data.
7805 (static var factor_values) Renamed nr_factor_values.
7806 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7807 only specific case. Close data_file before exit.
7808 (fill_matrix) New function.
7809 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7810 printing. Style fixes. Message fixes. Move code into
7812 (read_matrices_without_rowtype) Rename
7813 matrix_data_read_without_rowtype(). Fix off-by-one error on
7814 loops. Allocate nr_data[] memory from arena.
7815 (read_matrices_with_rowtype) Removed.
7816 (read_splits) Renamed nr_read_splits(). Style fixes.
7817 (read_factors) Renamed nr_read_factors().
7818 (dump_cell_content) Comment fixes. Arguments changed. Change
7819 debug printing. All references changed.
7820 (output_data) Renamed nr_output_data().
7821 (static var wr_content) New var.
7822 (struct factor_data) New struct.
7823 (static var wr_data) New var.
7824 (static var wr_current) New var.
7825 (matrix_data_source_destroy_source) Removed.
7826 (read_matrices_with_rowtype) New function.
7827 (matrix_data_read_with_rowtype) New function.
7828 (wr_read_splits) New function.
7829 (compare_factors) New function.
7830 (wr_output_data) New function.
7831 (wr_read_rowtype) New function.
7832 (wr_read_factors) New function.
7833 (wr_read_indeps) New function.
7834 (glob var matrix_data_source) Make destroy_source member NULL as
7837 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7839 * lexer.c: (syntax_error) Give better error message when at end of
7842 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7843 N_SCALAR to output as plain N.
7844 (mdump_token) Change output format.
7845 (context) Fix message output interaction with spaces in input.
7846 (another_token) New function.
7847 (force_eol) Improved error message.
7848 (static var max_cell_index) New var.
7849 (read_matrices) Init `cells'. factor_values is now per-cell.
7850 Init max_cell_index.
7851 (read_data_lines) Replace `compare' local with new `compare' arg.
7852 Debugging messages changed. Only read factors if per_factor.
7853 Propagate error return from read_factors(), force_eol().
7854 Copy N_SCALAR values across the N vector.
7855 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7856 check parentheses manually since we now have is_per_factor[].
7857 Call read_data_lines() with new args. Check for end of data after
7858 looping, using another_token().
7859 (read_factors) Arguments changed. Use max_cell_index to determine
7860 whether to read or compare factors. Message fixes.
7861 (dump_cell_content) New function.
7862 (output_data) Completely rewritten because content types were
7863 supported to be nested inside factor values, not vice versa.
7865 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7867 * lexer.c: (syntax_error) Support formatted varargs messages.
7869 * matrix-data.c: Turn debugging on by default.
7870 (static content_type[]) New array.
7871 (static content_names[]) New array.
7872 (static rowtype_, varname_) New vars.
7873 (static is_per_factor[]) New array.
7874 (static split_values) Moved declaration.
7875 (static n_continuous, first_continuous) New var.
7876 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7877 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7878 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7879 Check for continuous variables.
7880 [DEBUGGING] (debug_print) Remove content_names[].
7881 (mdump_token) New macro.
7882 (mget_token_dump) New function.
7883 (mdump_token) New function.
7884 (context) New function.
7885 (mget_token) Fix messages.
7886 (static var data, split_values, factor_values) New vars.
7887 (read_matrices) Manage split_values, factor_values.
7888 (read_data_lines) New function.
7889 (read_matrices_without_rowtype) Implemented.
7890 (read_splits) Message fixes. Uses `just_read'.
7891 (read_factors) New function.
7892 (output_data) New function.
7893 (matrix_data_source_destroy_source) Close the file handle.
7894 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7897 * str.c: (strpadcmp) Removed.
7899 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7901 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7903 * Lots of source files: Add cast to unsigned character to calls to
7904 tolower() and toupper().
7906 * aggregate.c: Set default_dict.splits to NULL.
7908 * command.c: (static variable tab[]) Add MATRIX DATA.
7910 * data-in.c: Add debugging defines. Formatting fixes.
7912 * expr-opt.c: Formatting fixes.
7914 * lexer.c: (syntax_error) Message fixes.
7916 * matrix-data.c: New enum series.
7917 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7918 split_values, n_factors, factors, cells, pop_n, contents,
7919 n_contents) New vars.
7920 (cmd_matrix_data) Finished implementation.
7921 (compare_variables_by_mxd_vartype) New function.
7922 [DEBUGGING] (debug_print) New function.
7923 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7924 (read_matrices) New function.
7925 (read_matrices_without_rowtype) New function.
7926 (read_matrices_with_rowtype) New function.
7927 (read_splits) New function.
7928 (mget_token) New function.
7929 (force_eol) New function.
7930 [0] (test_tokenizer) New function.
7931 (matrix_data_source_destroy_source) New function.
7932 (glob var matrix_data_source) New var.
7934 * misc.h: Include ieeefp.h if present.
7936 * split-file.h: (cmd_split_file) Changes corresponding to struct
7939 * str.h: Fix memmem prototype.
7941 * temporary.c: (save_dictionary, restore_dictionary,
7942 free_dictionary) Changes corresponding to struct dictionary
7945 * var.h: (MXD_* enums) New enum series.
7946 (struct matrix_data_proc) New struct.
7947 (struct split) Removed.
7948 (struct dictionary) Changed `splits' member from `split *' to
7950 (macro force_create_variable) New macro. Replaced lots of
7951 create_variable()/assert() calls with calls to this macro.
7953 * vars-atr.c: (discard_variables) Changed assertion.
7954 [GLOBAL_DEBUGGING] (force_create_variable) New function
7955 called by the macro of the same name.
7956 (clear_variable) Changes to delete splits from the dictionary
7957 corresponding to struct dictionary changes.
7959 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7960 corrupted variable `index' values in the dictionary passed in
7961 every time this function is called.
7963 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7964 to struct dictionary changes.
7966 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7968 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7970 * command.c: New includes.
7971 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7972 (cmd_erase) New function.
7973 [unix] (shell) New function.
7974 (run_command) New function.
7975 (cmd_host) New function.
7976 (cmd_new_file) New function.
7978 * expr-prs.c: (parse_primary) Message fix.
7980 * inpt-pgm.c: Formatting fix.
7981 (cmd_reread) Implement the FILE subcommand.
7983 * matrix-data.c: New file.
7985 * q2c.c: (dump_header) Change output commenting style.
7987 * weight.c: Comment fix.
7989 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7991 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7993 (buf_10x) Renamed buf_1xx, all references changed.
7994 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7995 cases now implemented).
7996 (create_sysfile) New function.
7997 (agr_11x_func) New function.
7999 * data-in.c: (parse_numeric) Work properly if there's an
8000 explicitly coded decimal point in the data and decimal places are
8001 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
8002 <el@linux.lisse.na>.
8004 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
8005 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
8006 Eberhard W Lisse <el@linux.lisse.na>.
8008 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
8009 strerror.c. Bug reported by Alexandre Oliva
8010 <oliva@dcc.unicamp.br>.
8012 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
8013 (static var separate_case_tab) New var.
8014 (cmd_sort_cases) Cancel temporary transformations here. Free
8015 v_sort before return.
8016 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
8017 we're reading from a sort stream. Don't cancel temporary
8018 transformations. Offload internal sorting to do_internal_sort().
8019 (do_internal_sort) New function. Handles internal sorting even
8020 when SEPARATE is nonzero. Doesn't free v_sort.
8021 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
8023 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
8024 sink if SEPARATE is zero.
8025 (read_output_cases) Renamed read_sort_output(), all references
8026 changed. Now uses separate_case_tab when it exists.
8027 (write_separate) New function.
8029 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
8030 memory_sink_cases. Don't redundantly call
8031 vfm_source->destroy_source().
8032 (memory_stream_mode) After switching over, set memory_sink_cases
8035 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
8037 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
8039 (static var prev_case) New, moved out of aggregate_single_case()
8041 (static var buf64_10x, buf_10x) New.
8042 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
8043 the 000, 001, 100, and 101 cases. Free prev_case.
8044 (parse_aggregate_functions) Disallow scratch variables.
8045 (free_aggregate_functions) Only free agr_dict if non-null. Use
8046 iter->function to determine numeric/string type, not
8048 (aggregate_single_case) Don't manage prev_case. Initialize
8049 aggregate info after dumping it.
8050 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
8051 mean, stddev, weighted stddev definitions.
8052 (dump_aggregate_info) Implemented.
8053 (initialize_aggregate_info) Renamed from
8054 initialize_aggregate_functions(). Initializes dbl[2].
8055 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
8056 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
8058 * cases.c: (alloc_val) Removed.
8060 * get.c: (cmd_save_internal) Initialize new `dict' member.
8062 * sfm-write.c: (sfm_write_dictionary, write_header,
8063 write_variable, write_value_labels, write_documents) Reorganize,
8064 simplify for new parameter structure.
8065 (write_variable) Only one variable * argument now.
8067 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
8068 replaced by new `dict' member.
8070 * temporary.c: (new_dictionary) Initialize n_documents.
8072 * vars-atr.c: (dup_variable) Allocate `value's from dict into
8074 (init_variable, replace_variable) Eliminate usage of alloc_val().
8076 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
8078 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
8079 signal that AGGREGATE is to be used for forming final cases.
8080 (close_active_file) Call end_func before stopping lagging. Cancel
8081 temporary after finishing compaction.
8082 (write_case) Comment fixes. Cleaned up.
8083 (compact_case) Let AGGREGATE handle compaction when `temporary' is
8086 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
8088 * Makefile.am: (BUILT_SOURCES) Add means.c.
8089 (pspp_SOURCES) Add means.c.
8090 (EXTRA_DIST) Add means.q.
8092 * command.c: (array cmd_table[]) Add MEANS.
8094 * common.h: Esthetic fixes. Comment fixes. Test for
8095 MAX_SHORT_STRING greater than 8.
8096 (macros LOWEST, HIGHEST) New.
8098 * data-in.c, data-list.c, recode.c: Comment fixes.
8100 * means.q: New file, base version.
8102 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
8103 with LOWEST, DBL_MAX with HIGHEST.
8105 * q2c.c: (dump_vars) Add an enum to array types giving the number
8106 of values for the enum.
8108 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
8109 Replace second_lowest_value with second_lowest_flt64.
8111 * sfm-write.c: (write_variable, write_rec_7_34) Replace
8112 second_lowest_value with second_lowest_flt64.
8114 * t-test.q: Comment fix.
8116 * temporary.c: (restore_dictionary) Esthetic fix.
8118 * tokens.h: (force_match_id, force_match, force_string, force_int,
8119 force_num, force_id) Replace msg() with syntax_error().
8121 * var.h: (struct means_proc) New.
8122 (struct variable) Add mns member to `p' union.
8124 * vars-prs.c: (parse_variable, parse_dict_variable,
8125 parse_variables, parse_DATA_LIST_vars) Replace msg() with
8128 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
8130 * Makefile.am: (pspp_SOURCES) Add tab.h.
8132 * Most source files: Added a cast to unsigned char in usages of
8133 the ctype is*() functions. Replaced `end of command expected'
8134 calls to msg() with calls to syntax_error().
8136 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
8138 * lexer.c: (hex_val) Removed (was dead code).
8139 (idmatch) Parenthesize function name to avoid macro expansion.
8141 * postscript.c: Comment fixes.
8142 (ps_preopen_driver) Change default font size to 10pt.
8144 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
8146 (parse_format_spec) Change system-file format spec argument type
8147 to int32. Parse the format spec with bitwise operators.
8149 * sfmP.h: (struct sysfile_format) Removed.
8150 (struct sysfile_variable) Changed print, write members from
8151 sysfile_format to int32.
8153 * tokens.h: Esthetic fixes.
8154 [__GNUC__] (macro id_match) New macro to hopefully speed up
8155 identifier matching.
8156 (macros match_id, match_tok, match_int) Implemented in
8157 compiler-independent manner; no longer GNU C only.
8159 * vfm.h: Include time.h.
8161 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
8163 * data-list.c: (dump_fixed_table) Change tab_dim().
8165 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
8167 * error.c: Include command.h.
8169 * frequencies.g: Formatting fixes.
8171 * frequencies.q: Add tab_dim() calls. Make the total cell a
8174 * glob.c: Include command.h.
8176 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
8178 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
8179 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
8180 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
8181 the other elements (is this right?).
8182 (read_variables) Use lowest, highest members.
8183 (parse_format_spec) New arg `vv' for more stringent checking.
8184 (dump_dictionary) Byteswaps nonexplicit data.
8185 (sfm_read_case) Byteswap numeric data.
8187 * som.c: Initialize table_num to 1.
8188 (render_segments) Remember to increment y_index after each table
8191 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
8192 avl_count() on a NULL tree. No title for the second table.
8193 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
8194 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
8195 fix call to display_variables().
8196 (display_variables) Default to 4 columns, not 3. Set up headers.
8197 Column title is Variable, not Name. Fix index column.
8198 Add joint text. Add tab_dim(). Handle value labels properly.
8199 Handle DISPLAY LABELS properly. Draw boxes correctly.
8200 (describe_variable) Value labels don't need titles. Don't clear
8201 nonexistent index column.
8202 (compare_vectors_by_name) New function.
8203 (display_vectors) New function.
8205 * tab.c: (tab_height) Add assertion.
8206 (tab_null) Add debug code.
8207 (evaluate_dimensions) Add debug code.
8209 * var.h: (struct variable) get_proc data is sometimes used
8210 simultaneously with other per-procedure info, therefore it was
8211 removed from the union. All references changed.
8213 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
8215 * ascii.c: (ascii_close_page) Put title on second line of headers
8216 if there is no subtitle.
8218 * command.c: (glob var cur_proc) Move definition here, from
8220 (cmd_remark) Emit blank line before remarks.
8222 * command.h: (glob var cur_proc) Move declaration here, from
8225 * data-list.c: (dump_fixed_table) Fix messages.
8226 (dump_free_table) Call tab_nat_dim().
8228 * descript.q: (dump_z_table) Modify tab_dim() call.
8230 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8232 (dump_statistics) Don't output header.
8234 * groff-font.c: Minor format fix.
8236 * html.c: Comment fix.
8238 * list.q: (write_varname) Indent after advancing page.
8240 * output.h: Minor reordering.
8242 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8243 a reference to eol[].
8244 (struct ps_driver_ext) New member eol[].
8245 (ps_preopen_driver) Initialize eol[].
8246 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8247 defaults. Handle headers. Fix test for minimum page length.
8248 (static var option_tab[]) Add `line-ends'.
8249 (ps_option) Handle line-ends to change eol[].
8250 (postopen) Scale prop_em_width and fixed_width properly. Set the
8251 prologue title to outp_title if applicable. Replace the prologue
8252 line ends with eol[]. Call draw_headers() if headers are enabled.
8253 (text_width) New function.
8254 (out_text_plain) New function.
8255 (draw_headers) New function.
8257 * print.c: (dump_table) Call tab_nat_dim().
8259 * som.c: (som_blank_line) Only advance a line if not at the top of
8261 (som_submit) Move several informational table calls here.
8262 Increment subtable_num if SOMF_NO_TITLE not set.
8263 (output_table) Advance a line if SOMF_NO_SPACING not set.
8264 (render_columns, render_segments, render_simple) Handle spacing
8265 between tables. Handle table titles. Remove debug output.
8267 * som.h: (SOMF_*) New enum series.
8268 (struct som_table_class) New member `flags'.
8270 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8272 (display_variables) Calls tab_nat_dim().
8273 (describe_variable) Remove restriction on number of value labels.
8274 Make value labels separated by thin lines.
8276 * tab.c: (tab_create) Default `flags' to none.
8277 (tab_float) New arg `w'. All references changed.
8278 (tab_nat_dim) New function.
8279 (tab_output_text) No title or spacing.
8280 (tab_flags) New function.
8281 (tabi_flags) New function.
8282 (tabi_title) New function.
8283 (strip_height) Removed.
8284 (tabi_render) Skip title when necessary.
8285 (static var tab_tab_class) Add tabi_flags, tabi_title.
8286 (evaluate_dimensions) Disable display of column, row size.
8287 (sum_columns) Add title height to top header.
8288 (render_strip) Moved within file.
8290 * tab.h: (struct tab_table) New member `flags'.
8292 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8294 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8296 * Most source files: Add `const' attribute in all appropriate
8299 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8300 column to the variables table for use by describe_variable().
8301 (cmd_display) Disable for the present.
8302 (display_documents) Don't wrap documents.
8303 (display_variables) Table has four columns now.
8304 (describe_variable) Table has four columns now. Don't use a
8305 subtable, use joined cells instead.
8307 * tab.c: (tab_create) Don't set `join'.
8308 (tab_realloc) ct array is not made up of a_string's.
8309 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8310 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8311 (text_format) New function.
8312 (tab_title) Rewritten, uses text_format().
8313 (tab_text) Rewritten, uses text_format().
8314 (tab_joint_text) New function.
8316 (static var hit) New variable.
8317 (render_strip) New args r1, r2. Implement joined cells that fit
8319 (tabi_render) Increment hit. Pass new args to render_strip().
8320 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8321 cells. For t_naw and t_nah, ignore joined cells and null cells in
8324 * tab.h: (struct tab_join_rect) Removed.
8325 (struct tab_table) Removed `join'.
8326 (TAB_JOIN_MAIN) Removed.
8327 (struct tab_joined_cell) New struct.
8328 (TAT_NOWRAP) New enum.
8330 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8332 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8334 (ascii_postopen_driver) Fix initialization of *_spacing so that
8335 the TAL_0 bit doesn't count.
8337 * data-list.c: (dump_fixed_table) Use natural width for Format
8340 * glob.c: (rerange) Removed.
8341 (get_date) Formatting fixes. Internationalization fix.
8343 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8346 * postscript.c: (ps_postopen_driver) Replace
8347 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8349 * som.c: (som_submit) Don't eject page before every table.
8350 (output_table) Fix order of arguments on call to area().
8351 (render_columns) Fix calculation of max_len.
8353 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8354 (render_strip) New function.
8355 (strip_height) New function.
8356 (tabi_render) Rewrite as calls to render_strip().
8358 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8359 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8360 with the TAB_* and OUTP_T_* constants.
8362 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8364 * Makefile.am: Formatting fixes.
8366 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8369 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8371 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8373 * dump-sysfile.c: (glob var length) Make type off_t.
8374 (usage) Fix arguments.
8377 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8378 Now right-justification is the default so many references had to
8380 (struct outp_class) Removed line_width, all references changed.
8381 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8382 (struct outp_driver) Add elements horiz_line_width,
8383 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8386 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8388 (postopen) Initialize all the informational members of
8391 * som.c: (som_blank_line) New function, renamed from blank_line(),
8392 all references changed.
8393 (som_submit) Disables drivers whose pages can't be opened.
8394 (render_columns, render_simple, render_segments) Add debug output.
8395 (render_columns) Fix loop range.
8396 (render_simple) Don't try to render the headers, they're taken
8397 care of automatically. Advance cp_y past the table when done.
8398 (render_segments) Fix loop ranges.
8400 * tab.c: Initialize new members of tab_table.
8401 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8402 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8403 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8406 (tab_dim) New function.
8407 (tab_col_width) Removed.
8408 (tab_row_height) Removed.
8409 (tab_output_text) Call tab_dim().
8410 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8411 (tabi_area) Implemented.
8412 (tabi_cumulate) Implemented.
8413 (tabi_render) Partially implemented, but broken.
8414 (var tab_table_class) Made static.
8415 (evaluate_dimensions) New function.
8416 (sum_columns) New function.
8418 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8419 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8420 t_scr, t_srr, t_sentinel. Removed: t_nat.
8421 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8422 max_stack_height, w, h. Removed: ce, re.
8423 (macro blank_line) Removed.
8424 (glob var zero_length) Removed.
8426 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8428 * Most source files: include some of the new include files broken
8431 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8434 * aggregate.c: (glob var outfile) Make static.
8436 * command.c: (glob var pgm_state) Move here.
8438 * common.c: (glob vars endian, second_lowest_value, pgmname,
8439 finished, curdate, cur_proc, start_interactive, history_file) Move
8442 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8444 * file-handle.q: (glob vars files, inline_file) Move here.
8446 * glob.c: Lost lots of glob vars, detailed in individual file
8448 (init_glob) set_printer, set_screen were obsolete, deleted.
8449 set_cprompt has fewer spaces because pspp has fewer letters than
8452 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8453 (inp_nval) Made static.
8455 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8456 tokstr_len, toklongstr, tokint) Move here.
8458 * misc.c: Lost several vars and functions.
8460 * set.q: (all the set_* variables) Move here.
8462 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8463 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8466 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8468 * tab.h: (enum series t_*) New enums.
8469 (struct tab_table) Use arena struct tag. New members ce, re.
8471 * tokens.h: Comment fixes.
8473 * var.h: Move lots of enums and variables and functions and
8474 structures to other files. Use and declare a lot more union and
8475 struct tags. Comment fixes.
8477 * vector.c: (glob vars vec, nvec) Move here.
8479 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8480 init_blanks, last_vfm_invocation) Move here.
8482 * cases.h: New file.
8483 (struct long_vec) Move here.
8484 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8487 * command.h: New file.
8488 (STATE_* enums) Move here.
8489 (glob var pgm_state) Move here.
8491 * format.c: New file.
8492 (glob var formats) Move here.
8493 (parse_format_specifier_name, fmt_to_string,
8494 check_input_specifier, check_output_specifier,
8495 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8498 * format.h: New file. Move functions now in format.c here.
8499 (FMT_* enums) Move here.
8500 (struct fmt_desc) Move here.
8501 (FCAT_* enums) Move here.
8502 (struct fmt_spec) Move here.
8503 (glob vars formats, fmt_parse_ignore_error) Move here.
8505 * inpt-pgm.h: New file.
8506 (INP_* enums) Move here, make #defines into enums.
8507 (glob vars inp_init, inp_init_size) Move here.
8510 (glob vars v_sort, nv_sort) Move here.
8511 (sort_cases, read_sort_output) Move here.
8513 * vector.h: New file.
8514 (struct vector) Move here, add struct tag.
8515 (glob vars vec, nvec) Move here.
8516 (find_vector) Move here.
8519 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8520 reinit_blanks, init_zero, init_blanks) Move here.
8521 (struct case_stream) Move here.
8522 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8523 vfm_disk_stream, sort_stream, data_list_source,
8524 input_program_source, file_type_source, get_source, n_lag) Move
8526 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8529 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8531 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8532 (LDADD) Add libdcdflib.
8534 * ascii.c: Comment and formatting fixes. Almost every external
8535 function had an assert added, checking driver_open and page_open.
8536 (ascii_init_driver) Broken into ascii_preopen_driver,
8537 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8538 (ascii_open_page) Sets page_open.
8539 (ascii_close_page) Clears page_open.
8541 * html.c: Comment and formatting fixes. Almost every external
8542 function had an assert added, checking driver_open and page_open.
8543 (html_init_driver) Broken into html_preopen_driver,
8544 html_postopen_driver, html_close_driver. Manages driver_open.
8545 (html_open_page) Sets page_open.
8546 (html_close_page) Clears page_open.
8547 (html_submit) Disabled.
8549 * lexer.c: (parse_string) Remove debugging printf.
8551 * list.q: (determine_layout) Open a page if one is not yet open.
8553 * output.c: Comment fixes.
8554 (add_class) Set the class member of the new list element.
8555 (parse_options) Don't handle device type.
8556 (colon_tokenize) New function.
8557 (configure_driver) New four-field format with a field for device
8558 type. Now initialize driver_open, page_open, next, and prev
8559 fields. Use new colon_tokenize() function. Don't do a memory
8560 copy to replace a driver, it doesn't work; instead delete the old
8561 driver and insert a new one.
8562 (destroy_driver) Don't call som_destroy_driver(). Close the page
8563 if it's open. Find the class in the list of classes and decrement
8564 that reference count. Remove the driver from the global driver
8566 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8567 references changed. Rewritten. Don't return a driver that's not
8569 (outp_eject_page) All references to som_internal_eject_page()
8570 changed to use this. Sets cp_x to 0 as well as cp_y.
8572 * output.h: (OUTP_I_* enums) Removed.
8573 (struct som_submission_form) Removed.
8574 (struct outp_class) init_driver broken into preopen_driver,
8575 postopen_driver, and close_driver. submit changed to take a
8578 * postscript.c: Comment and formatting fixes. Almost every
8579 external function had an assert added, checking driver_open and
8581 (ps_init_driver) Broken into ps_preopen_driver,
8582 ps_postopen_driver, ps_close_driver. Manages driver_open.
8583 (ps_open_page) Sets page_open.
8584 (ps_close_page) Clears page_open.
8586 * som.c: New file, base implementation.
8588 * som.h: (struct som_table) Add struct tag.
8589 (enum SOM_COL_ACROSS) Removed.
8590 (SOM_ROWS, SOM_COLUMNS) New enums.
8591 (struct som_table_class) Add member `cumulate'. Remove `segment';
8592 change `render' arguments.
8593 (struct som_point, struct som_rect) Removed.
8594 (som_submit_table) Fixed typo, should have been som_submit.
8596 * sysfile-info: (describe_variable) Don't try to insert a
8597 subtable; just destroy it for now.
8599 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8600 references to value labels.
8602 * tab.c: (tab_destroy) New function.
8603 (tab_columns) Change argument.
8604 [0] (tab_submit) Remove dead code.
8605 (tab_title) Allocate string from the table's arena.
8606 (tab_output_text) Only free the buffer if we allocated it.
8607 (tab_submit) New function.
8608 (static vars t, d) New static vars.
8609 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8610 tabi_headers, tabi_cumulate, tabi_render) New functions.
8611 (glob var tab_table_class) New global var.
8613 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8614 encapsulate the rectangle. All references changed.
8616 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8618 * All header files updated to use struct tags in addition to
8619 typedefs for all structures. Don't use word `struct' in struct
8622 * Makefile.am: (pspp_SOURCES) Remove html.c.
8623 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8624 all references updated.
8626 * command.c: (parse_cmd) Remove call to som_check_workspace.
8627 (output_line) Update to new som.
8629 * data-in.c: (parse_numeric) A single dot is not an error; it is
8630 the system-missing value.
8632 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8635 * data-out.c: Added `const' as appropriate to many prototypes.
8636 (convert_E, convert_F, convert_CCx) Take double argument instead
8637 of value * argument.
8638 (convert_format_to_string) Call changed functions appropriately.
8639 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8640 make a local copy of the value.
8642 * descript.q: Remove custom_variables() prototype now provided by
8644 (custom_variables) Don't increment sbc_variables, the caller does
8646 (dump_z_table, display) Update to new som.
8648 * error.c: (vmsg) Add const to prototype. Remove code to handle
8649 `too many errors' condition.
8650 (check_error_count) New function.
8651 (msg) Add const to prototype.
8653 * filename.c: (open_file) Rewrite for elegance.
8655 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8656 (dump_full, dump_condensed, dump_statistics) Update for new som.
8658 * list.q: Don't include somP.h. Change all references to
8659 som_driver_ext to refer to the new members of som_driver. Change
8660 som_internal_eject_page() references to outp_eject_page().
8662 * main.c: (parse) Rewrite for elegance. Add call to
8663 check_error_count().
8665 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8666 Rewrite or revise for new outp_driver_class_list structure.
8667 (outp_iterate_enabled_drivers) Fix comparison between disabled
8668 devices and current device type.
8669 (outp_eject_page) New function.
8671 * output.h: Comment fixes.
8672 (struct outp_driver) New members driver_open, page_open, cp_x,
8673 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8675 (struct outp_driver_class_list) New struct.
8676 (outp_class_list) Changed to type outp_driver_class_list; all
8679 * print.c: (dump_table, print_trns_proc) Updated for new som.
8681 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8682 prototypes for custom subcommands.
8683 (dump_subcommand) Always include the `else'.
8684 (dump_parser) Fix comments in output code.
8686 * set.q: Reordered functions.
8688 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8690 * som.h: Rewritten from scratch.
8692 * str.h: Remove dead code.
8694 * tab.c, tab.h: New files, base implementation.
8696 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8699 * t-test.q: New code from John Williams
8700 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8701 Many many new static vars and defines.
8702 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8703 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8704 (struct value_list) New struct.
8705 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8706 t_crt, t_sig, print_t_groups) New functions.
8707 (cmd_t_test) Implemented.
8709 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8712 * vfm.c: (dump_splits) Update to new som.
8714 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8716 * Makefile.am: (fiasco_SOURCES) Add html.c.
8718 * aggregate.c: Base source.
8720 * ascii.c: (postopen, preclose) Reformat.
8722 * data-out.c, expr-evl.c: Comment fixes.
8724 * filename.c: (open_file) When opening a file for writing, use
8725 line buffering instead of full buffering for better interactive
8726 performance. Suggested by Valerio Aimale
8727 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8728 names `stdin', `stdout', `stderr'.
8730 * groff-font.c: Comment fixes.
8732 * html.c: New file; base version.
8734 * list.q: (write_all_headers, clean_up, determine_layout,
8735 list_cases) Ignore `special' devices for now. Needs to be fixed
8738 * output.c: (outp_init) Add html driver to list; reverse list
8741 * output.h: (struct outp_class_struct) New members `special',
8742 `submit'; comment fixes. All references changed.
8744 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8745 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8747 (postopen) Comment fix.
8748 (preclose) Comment fixes, formatting fixes. Change x->file.file
8749 references to more proper f->file.
8751 * som-high.c: (som_submit_table) Special classes use their own
8754 * som.h: Comment fixes.
8756 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8759 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8761 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8763 * aggregate.c: Still working on this.
8765 * command.c: (cmd_table[]) Add AGGREGATE back in.
8766 (split_words) Make '-' a legal word separator as well as ' '.
8768 * main.c: Comment fixes.
8770 * q2c.c: (dump_parser) Don't require the procedure's full name to
8771 be present, in the generated source.
8773 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8774 multiply specified and let it be default; let MISSING, CRITERIA,
8775 FORMAT be multiply specified.
8776 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8777 (custom_groups) Fix defaults.
8778 (custom_pairs) Check whether this is a PAIRS subcommand before
8779 attempting to parse. Better garbage collection. Proper storage
8781 [DEBUGGING] (debug_print) New function.
8783 * temporary.c: Comment fixes.
8784 (copy_variable) Don't copy variable name and index.
8785 (save_dictionary) Copy variable name and index by hand.
8787 * vars-atr.c: Comment fixes.
8788 (create_variable) New dictionary argument. All references
8790 (common_init_stuff) New dictionary argument. All references
8792 (init_variable) New dictionary argument. All references changed.
8793 (dup_variable) New function.
8795 * vars-prs.c: (parse_variables) If there are any errors, we always
8796 return 0. Previously, it was possible for some types of errors to
8799 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8801 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8804 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8806 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8809 * q2c.c: Comment fixes.
8810 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8812 * t-test.q: (cmd_list) Rename cmd_t_test.
8814 * temporary.c: (new_dictionary) Don't declare as static.
8816 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8818 * aggregate.c: Changes, still not finished.
8820 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8822 * q2c.c: Comment fixes. Now its output is internationalized.
8823 (get_token) Fix parsing of escapes within literal strings.
8824 (main) Fix bad #line directives in output.
8826 * t-test.q: Base implementation.
8828 * temporary.c: (new_dictionary) New function.
8829 (restore_dictionary) [__CHECKER__] Change fill character to *
8832 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8834 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8836 * aggregate.c: Changes, still not finished.
8838 * descript.q, list.q: Comment fixes.
8840 * q2c.c: Almost completely rewritten.
8842 * t-test.q: New file, not complete.
8844 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8846 * aggregate.c: Changes, still not finished.
8848 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8851 * temporary.c: (cancel_temporary) New function.
8853 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8854 of doing it by hand.
8856 * vfm.c: (close_active_file) After restoring a TEMPORARY
8857 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8859 (SPLIT_FILE_procfunc) Comment fix.
8861 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8863 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8865 * aggregate.c: New file, not finished yet.
8867 * command.c: (cmd_table) Add AGGREGATE.
8869 * common.h: (pgm_state) Move declaration to var.h.
8871 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8873 (parse_string) Message fix.
8875 * recode.c: Comment fix.
8877 * sfm-read.c: (read_variables) Code esthetic fixes.
8878 (write_header) Default date is `Jan', not `JAN'.
8880 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8882 * sort.c: (cmd_sort_cases) Farm the work out to new function
8883 parse_sort_variables().
8884 (parse_sort_variables) New function.
8885 (sort_cases) New function. Cancels temporary transformations,
8886 which sorting didn't do previously.
8887 (cmd_sort_cases) Better garbage collection on error. Uses
8889 (write_initial_runs, merge_once) Improved code esthetics.
8890 (sort_stream_read) Reduced to one call to read_output_cases().
8891 (read_output_cases) New function.
8893 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8894 variable labels to 120 characters.
8896 * var.h: Comment fixes.
8897 (glob var pgm_state) From common.h.
8899 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8901 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8902 options. Set *names to NULL on error.
8904 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8906 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8908 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8909 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8911 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8913 * vfm.c: (page_to_disk) Added missing local variables.
8915 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8917 * get.c: Comment fix.
8919 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8920 source is anything other than a disk stream, not just if it's in a
8921 memory stream. Call page_to_disk() before external sort.
8922 (allocate_cases) Message fix.
8924 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8926 (page_to_disk) New function.
8928 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8930 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8932 * common.h: (macro strerror) Remove. From Alexandre Oliva
8933 <oliva@dcc.unicamp.br>.
8935 * get.c: (dict_delete_run) The number of variables to delete is
8936 not necessarily the number of variables that need to be shifted
8938 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8939 too many variables to be deleted.
8941 * postscript.c: Comment fix.
8943 * q2c.c: Include strerror.c. From Alexandre Oliva
8944 <oliva@dcc.unicamp.br>.
8946 * set.q: #undef ON and OFF. From Alexandre Oliva
8947 <oliva@dcc.unicamp.br>.
8949 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8950 early, otherwise errors cause a bad free().
8952 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8953 Oliva <oliva@dcc.unicamp.br>.
8955 * temporary.c: (save_dictionary) Don't allocate memory if
8958 * vfm.c: (memory_stream_write) Message fix.
8960 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8962 * command.c: (static var cmd_table[]) Define REPEATING DATA
8965 * common.h: Added support for broken systems that are missing
8966 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8968 * Many source files: Replace syntax error messages via msg() with
8969 call to syntax_error().
8971 * data-list.c: (dump_fixed_table) Add support for dumping table
8972 for REPEATING DATA as well as DATA LIST FIXED.
8973 (cmd_repeating_data) Allows and requires `/' between subcommands.
8974 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8975 CONTINUED specifications to be omitted. Forces CONTINUED to be
8976 specified if ID is. Calculates starts_end, cont_end from logical
8977 record length as reported by fhp. Calls dump_fixed_table() if
8978 requested. Fixed length of record copied by memcpy.
8979 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8981 (realize_value) Returns sensible value for out-of-range variable
8983 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8984 length of occurrences and length of line. Added warning for
8985 fields that exceed the line length. Fixed infinite loop.
8986 (read_one_set_of_repetitions) Numerous minor changes for more
8987 complete SPSS compliance. Message fixes.
8989 * dfm.c: (dfm_close) If the file being closed is the inline file,
8990 read all the remaining data before closing it.
8991 (dfm_get_record) Don't close the file on lossage, as either it
8992 has been closed already or it doesn't belong to us.
8994 * error.c: (puts_stdout) New function.
8995 (vmsg) Use puts_stdout instead of puts.
8997 * file-handle.q: (fh_record_width) New function.
8999 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
9002 (input_program_source_read) Made an old kluge an approved method.
9004 * lexer.c: (syntax_error) New function.
9006 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
9009 * output.c: (oupt_get_paper_size) Message fix.
9011 * q2c.c: Numerous fixes to formatting of generated code made to
9012 conform to GNU coding standards. Uses syntax_error() in generated
9013 code. Other miscellaneous generated message fixes. Added support
9014 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
9015 RAND_MAX, and/or strerror().
9017 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
9019 * data-in.c: Comment fixes.
9021 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
9022 (find_variable_input_spec) New function.
9023 (cmd_repeating_data) Initializes id_spec.
9024 (rpd_parse_record) Implemented.
9025 (read_one_set_of_repetitions) Returns -3 by default in order to
9026 kluge out some potential bugs.
9028 * data-out.c: Comment fixes.
9030 * file-type.c: (internal_cmd_record_type) Message fix.
9032 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
9033 for handling -3 return value.
9035 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
9037 * data-list.c: Comment fixes.
9038 (struct dls_var_spec) Reordered members.
9039 (read_from_data_list_fixed) Restructured.
9040 (struct repeating_data_trns) Reordered members. Renamed `starts'
9041 as `starts_beg', `ends' as `starts_end'.
9042 (cmd_repeating_data) Calculates length of repeated data if
9043 necessary and possible.
9044 (parse_num_or_var) Don't allow string variables.
9045 (realize_value) New function.
9046 (rpd_msg) New function.
9047 (rpd_parse_record) New function. Currently stubbed out.
9048 (read_one_set_of_repetitions) Implemented.
9050 * inpt-pgm.c: (input_program_source_read) Comment fix.
9052 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
9054 * command.c: (cmd_end_repeat_p) Removed.
9055 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
9056 (parse_cmd_name) Removed.
9058 * data-list.c: Comment fixes.
9059 (data_list_pgm) Removed `eof' member.
9060 (static var first) New var.
9061 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
9062 FILE TYPE file inside FILE TYPE structures.
9063 (append_var_spec) Appends to *first, not dls.spec.
9064 (parse_fixed) Message fixes.
9065 (struct rpd_num_or_var) New.
9066 (struct repeating_data_trns) New.
9067 (static var rpd) New.
9068 (cmd_repeating_data) New function.
9069 (parse_num_or_var) New function.
9070 (parse_repeating_data) New function.
9071 (read_one_set_of_repetitions) New function.
9073 * file-type.c: (cmd_file_type) Message fixes. Always
9074 default_handle to FILE TYPE file handle.
9075 (internal_cmd_record_type) Message fixes.
9077 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
9079 * repeat.c: Comment fix. Disable debugging.
9081 * temporary.c: (restore_dictionary) Sets splits to NULL and
9082 n_splits to 0 before destroying the variables because now doing
9083 this tries to remove split variables.
9085 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
9086 destroying the dictionary.
9087 (clear_variable) Removes a variable from splits after destroying
9090 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
9092 * cmdline.c: (set_compat) Removed.
9093 (pick_compat) Removed.
9094 (parse_command_line) Removed -c option.
9095 (pre_syntax_message) Removed -c option.
9096 (usage) Remove compatibility code.
9098 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
9099 (glob var compat) Removed.
9101 * compute.c: (type_check) Fixed messages about type mismatches.
9103 * data-list.c: (cmd_data_list) Removed compatibility code.
9104 (fixed_parse_compatible) Calls convert_negative_to_dash().
9105 Fixed bug where it only set the variable in fx.spec if it created
9106 the variable itself.
9107 (dump_fmt_list) Spelling fix.
9108 (cut_field) Removed compatibility code.
9110 * dfm.c: (cmd_begin_data) Don't require a command terminator on
9113 * expr-evl.c: (evaluate_expression) Implement LAG.
9115 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
9116 (parse_neg) Calls convert_negative_to_dash().
9117 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
9120 * expr.h: (struct expression_struct) Removed member max_lag.
9122 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
9123 (internal_cmd_record_type) Removed special handling to produce
9124 negative numbers from dash tokens.
9126 * getline.c: (static var DO_REPEAT_level) New var.
9127 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
9128 (handle_line_buffer) Copies the line into getl_buf; doesn't call
9129 copy_with_DO_REPEAT_substitutions().
9130 (getl_read_line) Maintains value of getl_mode. Calls
9131 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
9133 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
9135 * getline.h: (getl_mode) New glob var.
9137 * glob.c: Comment fixes.
9138 (init_glob) Restructured. Sets set_seed.
9139 (init_compat_dependent) Removed. All references removed.
9140 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
9141 (__htonl, __htons) Removed. (What were these for?)
9143 * lexer.c: (static var tbl) Dash set to class CNUM.
9144 (make_hexit) New function from data-out.c.
9145 (get_token_representation) Rewritten.
9146 (convert_negative_to_dash) New function.
9147 (lex_init_compat_dependent) Removed.
9148 (yylex) A dash is parsed as part of a number if it is followed by
9149 a digit. The ASCII representation of a number is copied to
9150 tokstr. String parsing farmed out to parse_string(). Comment
9152 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
9154 (preprocess_line) Line processing depends on interactive/batch
9155 mode, not on compatibility mode. Removed PC+ compatibility code.
9157 * loop.c: (loop_3_trns_proc) Comment fix.
9159 * main.c: Remove dead code.
9160 (main) Remove call to init_compat_dependent().
9162 * misc.c: (convert_fmt_ItoO) Make E format conversion more
9165 * print.c: (parse_string_argument) Calls
9166 convert_negative_to_dash().
9167 (fixed_parse_compatible) Calls convert_negative_to_dash().
9169 * repeat.c: (RPT_* defines) Removed.
9170 (struct rpt_numeric) Removed.
9171 (struct repeat_entry) New member type, changed `replacement' from
9173 (clean_up) Deallocation adapted to new repeat_entry.
9174 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
9175 usage. Creates vars for `type' of 1.
9176 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
9177 (store_numeric) Rewritten, new interface.
9178 (parse_numbers) Rewritten.
9179 (parse_strings) Rewritten.
9180 (find_DO_REPEAT_substitution) New function.
9181 (perform_DO_REPEAT_substitutions) New function.
9182 (copy_with_DO_REPEAT_substitutions) Removed.
9183 (debug_print) Rewritten.
9185 * set.q: Comment fix.
9186 (custom_results) Removed compatibility code.
9187 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
9190 * sysfile-info.c: (cmd_display) Removed compatibility code.
9192 * tokens.h: Comment fixes.
9193 (token types enum) Removed `toktype' typedef name for this int
9194 type. Removed SUBST. Restructured.
9196 * vars-atr.c: (discard_variables) Sets n_lag to 0.
9198 * vars-prs.c: Comment fix.
9200 * vfm.c: Comment fixes.
9201 (glob var n_lag) New var.
9202 (static vars lag_count, lag_head, lag_queue) New vars.
9203 (procedure) Removed argument nlag.
9204 (setup_lag) New function.
9205 (close_active_file) Discards lagging state.
9206 (lag_case) New function.
9207 (lagged_case) New function.
9208 (write_case) Lags a case if lagging.
9210 * weight.c: (cmd_weight) Removed compatibility code.
9212 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
9214 * getline.h: (struct getl_script) New members loop_index, macros.
9216 * getline.c: (getl_add_file) Sets first_line field to NULL.
9217 (getl_add_DO_REPEAT_file) New function.
9218 (handle_line_buffer) When the current line's length is negative,
9219 set the filename and line number. Increment line number after
9220 reading line. Pass the line to
9221 copy_with_DO_REPEAT_substitutions() for processing.
9222 (getl_close_file) Free DO REPEAT lines before freeing the
9223 filename, and just set the filename to NULL when doing this,
9224 because otherwise the filename gets freed twice.
9226 * glob.c: (glob var queuing) Removed. All references removed.
9228 * lexer.c: Comment fixes.
9229 (get_token_representation) New function.
9231 * repeat.c: Comment fixes.
9232 (struct repeat_entry) Replaced type and v union members with a
9234 (append_record) New function.
9235 (internal_cmd_do_repeat) Started reforming it for the new
9236 repeat_entry struct. Properly records filename changes in the
9237 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9238 strncasecmp() result usage. Uses append_record() to simplify.
9239 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9242 (copy_with_DO_REPEAT_substitutions) Started coding.
9244 [DEBUGGING] (debug_print_lines) New function.
9246 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9248 * tokens.h: (macro is_id1, is_idn) New macros.
9250 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9252 * cmdline.c: (static var pre_syntax_message) Changed `win'
9253 compatibility mode to `wnd'.
9255 * data-list.c: (fixed_parse_spss) Renamed
9256 fixed_parse_compatible().
9258 * glob.c: (init_glob) Excise unused code for
9259 program_invocation_short_name.
9261 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9264 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9266 * set.q: `win' compatibility renamed `wnd'.
9268 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9270 * filename.c: [__WIN32__] Change the included Windows header files
9272 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9273 second character is absolute.
9274 (dirname) Fix logic error. Don't printf() the results.
9275 (prepend_dir) Don't printf() the results.
9277 * getline.c: (handle_line_buffer) New function.
9278 (getl_read_line) Reads line with handle_line_buffer() when
9280 (getl_close_file) Discard line buffer data.
9282 * getline.h: Comment fixes.
9283 (struct getl_line_list) New struct.
9284 (getl_script_struct) Added line buffer members. These are hooks
9285 for use by DO REPEAT to allow it to insert virtual source code
9288 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9289 Override Borland C++ stupidity that claims Windows has a console
9292 * repeat.c: This is in the process of being restructured from
9293 using a token-buffering approach to the DO REPEAT facility to
9294 using the more flexible approach of a line-buffering approach in
9295 conjunction with the getline module. Comment fixes.
9296 (struct tok_struct) Removed.
9297 (static vars queue_index, queue_head, queue) Removed.
9298 (static vars line_buf_head, line_buf_tail) New vars.
9299 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9301 (pull_queue, destroy_queue) Removed.
9302 [DEBUGGING] (debug_print_tokens) Removed.
9304 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9306 * file-handle.q: (prepend_current_directory) New function.
9307 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9308 current directory before normalizing filename.
9310 * filename.c: (gnu_getcwd) New function.
9311 (absolute_filename_p) New function.
9312 (search_path) New argument, PREPEND. All references changed to
9313 pass NULL except those explicitly mentioned. Uses
9314 absolute_filename_p(). Prepends PREPEND before trying the
9316 (dirname, prepend_dir) New functions.
9318 * getline.c: (getl_get_current_directory) New function.
9319 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9322 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9324 * In several source files, the term `script' was replaced with
9325 `syntax file' inside error messages. Usage of the term `script'
9326 in the sense of a syntax file is now deprecated.
9328 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9331 * dump-sysfile.c: (usage) Update message.
9333 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9335 * getline.h: (glob var getl_include_path) Declare extern.
9337 * list.q: Define EXTERN as extern before #including somP.h.
9339 * var.h: Remove declaration of `disptype' variable.
9341 * vfm.c: (close_active_file) After switching the data sink to a
9342 data source, set vfm_sink to NULL, because it doesn't exist any
9345 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9347 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9348 _matherrl() to ignore all math errors.
9350 * sfm-read.c: (read_value_labels) When reading the labels from
9351 disk, read the little parts separately instead of as a struct;
9352 this avoids alignment problems.
9354 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9355 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9356 (write_header) Allocates and initializes elem_type.
9357 (sfm_write_case) Uses elem_type to determine how to handle each
9359 (sfm_close) Frees elem_type.
9361 * sfmP.h: Comment fix.
9362 [__BORLANDC__] Uses #pragma -a to adjust structure member
9365 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9367 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9369 * common.c: Fix typo.
9371 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9372 sense of the condition.
9374 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9375 line-continuation backslash.
9377 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9379 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9380 non-constant expression as an argument to sizeof.
9382 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9383 undefine gettext macro because that's a conio function.
9385 * hash.h: (hsh_prime_tab declaration) Remove.
9387 * list.q: (write_fallback_headers) Move `leader' allocation out of
9388 main loop. Change to local_alloc() allocation.
9390 * output.h: Formatting fixes. Put __attribute__ in right place on
9391 function prototypes.
9393 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9394 incorrect `SECOND_LOWEST_VALUE' references to proper
9395 `second_lowest_value'.
9397 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9398 value. This way 2 out of 3 of the som files define the vars
9399 extern, the correct way, that actually works under BC++.
9400 (som_set_float) Don't use nonconstant initializers for a struct.
9402 * som-high.c: Add the standard alloca() header.
9403 (replicate_table) Add prototype.
9405 Merged DISPLAY routine.
9406 * sysfile-info.c: (AS_*) New enum series.
9407 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9409 (cmd_display, display_macros, display_documents,
9410 display_variables) Stolen from defunct display.c.
9411 (describe_variable) New function.
9413 * temporary.c: [0] (display_tree) New debug function.
9414 (copy_variable) Performs shallow copy of value labels instead of
9415 deep copy; i.e., just copys the AVL tree and increments the
9418 * val-labs.c: Comment fixes.
9419 (do_value_labels) Optionally skip leading forward slash.
9420 (get_label) Creates only a single value label instead of many
9421 copies of one, and sets the reference count.
9423 * display.c: Removed.
9425 * dump-sysfile.c: New file, not yet complete.
9427 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9429 For lots of source files I added more verbose_msg's. These aren't
9430 listed below as they have tested as being benign. In some cases
9431 these replaced debug_printf() calls.
9433 * output.c: (outp_read_devices) Message fix.
9435 * postscript.c: (output_encodings) Message fix. Reports errors on
9437 (postopen) Message fix.
9439 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9441 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9443 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9446 * main.c: Remove <malloc.h> #include.
9448 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9449 instead of trying to just set the missing[] itself, which is a
9452 * sfm-read.c: (read_variables) Same.
9454 * str.h: Add memmem() prototype.
9456 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9458 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9460 * Makefile.am: (q2c) Don't include any libraries in the link.
9462 * dfm.c: (force_line_buffer_extension) New macro.
9463 (count_tabs) New function.
9464 (tabs_To_spaces) New function.
9465 (read_record) Calls tabs_to_spaces() on the line being processed.
9467 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9468 have to be compiled twice (once for CC, once for LOCAL_CC).
9470 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9472 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9473 (LDADD) Add @INTLLIBS@.
9474 (q2c) Add LIBS, @INTLLIBS@ to link step.
9476 * inpt-pgm.c: Turn off debugging.
9478 * postscript.c: (postopen) Format fix. local_free() blocks
9479 returned by local_alloc(); don't free() them.
9481 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9483 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9486 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9487 LEN arg, not simply the full string length.
9489 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9490 directories before generic temp file directories.
9492 * vfm.c: Disable debugging.
9494 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9496 * get.c: Comment fix.
9497 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9499 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9501 * expr-prs.c: (debug_print_postfix) Conditionally included on
9502 GLOBAL_DEBUGGING. Removed out_header() reference.
9504 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9506 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9508 * ascii.c: Removed obsolete ascii_close_page() prototype.
9510 * command.c: (output_line) Comment fix.
9512 * data-in.c: Formatting fix.
9513 (parse_string_as_format) Now the `fc' argument is used only for
9514 the purpose of error messages; it is not an index into the string
9515 passed. All references changed.
9517 * data-list.c: Comment fix.
9518 (cut_field) Comment fix. Now returns the column number of the
9519 position of the field cut out on success.
9520 (parse_field) Added `column' argument. Puts the column numbers in
9522 (read_from_data_list_free, read_from_data_list_list) Record the
9523 column number returned by cut_field(), pass it to parse_field().
9525 * dfm.c: Comment fix.
9527 * do-ifP.h: Comment fix.
9529 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9530 the SYSMIS function.
9532 * expr.h, exprP.h: Comment fix.
9534 * glob.c: (init_glob) Only calls setlocale() and family if
9537 * hash.h: Comment fix.
9539 * include.c: Comment fix.
9541 * output.c: Comment fix.
9543 * postscript.c: (ps_line_intersection) Simplified assertion.
9545 * repeat.c: Comment fix.
9547 * vars-atr.c: Comment fix.
9549 * vars-prs.c: Comment fix.
9551 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9552 behavior with usage of postincrement.
9553 (memory_stream_read) Discards cases as it goes.
9555 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9557 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9560 * Most source files: Includes debug-print.h, related comment
9563 * cases.c: (alloc_val) Removed complex allocation code. Merely
9564 increments default_dict.nval and returns the former value.
9565 (envector, devector) Removed references to lv member of struct
9568 * common.h: (macro VME) Replaced complex definition with simple
9571 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9572 read_active_file and cancel_input_pgm.
9573 (read_from_data_list, cancel_data_list) Removed.
9574 (data_list_source_read, data_list_source_destroy_source) New
9576 (glob var data_list_source) New var.
9578 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9579 (cmd_begin_data) Improved criteria for an input program accessing
9580 the inline file. Still not perfect.
9582 * do-if.c: (do_if_trns_proc) Simplified debug output.
9584 * expr-prs.c: Comment fixes.
9585 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9587 * file-handle.q: (fh_close_handle) Simplified debug output.
9589 * file-type.c: Comment fixes.
9590 (cmd_file_type) Sets vfm_source instead of read_active_file and
9592 (cmd_end_file_type) On failure, discards variables in place of
9593 just canceling the input program.
9594 (read_from_file_type) Renamed file_type_source_read.
9595 (cancel_file_type) Renamed file_type_source_destroy_source.
9596 (glob var file_type_source) New var.
9598 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9599 (cmd_get) Initializes options to GTSV_NONE before passing to
9600 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9601 instead of read_active_file and cancel_input_pgm.
9602 (cmd_save_internal) Initializes options before passing to
9603 trim_dictionary(). Local var `nval' removed.
9604 (dict_delete_run) Comment fixes.
9605 (trim_dictionary) Comment fixes. Disallows scratch variables if
9606 GTSV_OPT_SAVE set in options.
9607 (read_from_get) Renamed get_source_read.
9608 (cancel_get) Renamed get_source_destroy_source.
9609 (glob var get_source) New var.
9611 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9612 read_active_file and cancel_input_pgm.
9613 (read_from_input_program) Renamed input_program_source_read.
9614 Simplified debug output.
9615 (cancel_input_program) Renamed
9616 input_program_source_destroy_source.
9617 (glob var input_program_source) New var.
9619 * loop.c: (loop_1_trns_proc) Simplified debug output.
9621 * main.c: (dump_token) Made eof output more explicit.
9623 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9626 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9627 code for always-memory or always-disk cases. malloc's case-list
9628 based on vfm_source_info.ncases. Explicit support for
9629 memory_stream via memory_source_cases.
9630 (do_external_sort) Sets vfm_source instead of read_active_file and
9632 (allocate_file_handles) The temporary directory permissions are
9633 set to 0700 instead of 0777.
9634 (allocate_cases) Formatting fixes. Simplified debug output.
9635 (output_record) Compacts the case if necessary before writing it
9637 (close_handle, open_handle_w) Simplified debug output.
9638 (write_initial_runs) Destroys vfm_sink, then sets it to
9639 sort_stream. Writes records to memory based on
9640 vfm_sink_info.case_size.
9641 (write_to_sort_cases) Renamed sort_stream_write().
9642 (merge) Simplified error handling. Simplified debug output.
9644 (read_from_external_sort) Renamed sort_stream_read().
9645 Reads records based on vfm_source_info.case_size.
9646 (sort_stream_write) Writes records to memory based on
9647 vfm_sink_info.case_size.
9648 (sort_stream_mode) New function.
9649 (glob var sort_stream) New variable.
9651 * temporary.c: (cmd_temporary) Simplified debug output.
9652 (copy_variable) Removed references to `lv'.
9654 * title.c: (get_title) Simplified debug output.
9656 * var.h: Comment fixes.
9657 (struct get_proc) Removed member `lv'.
9658 (struct variable) Removed member `lv'. Comment fixes.
9659 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9661 (struct case_stream) New.
9663 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9664 read_active_file references to use vfm_source.
9665 (init_variable, replace_variable) Removed references to `lv'.
9667 * vfm.c: Comment fixes.
9668 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9670 (static var queue, qh, qt, n_lag) Removed. All references
9672 (glob var compaction_necessary, compaction_nval, compaction_case,
9673 paging) New variables.
9674 (record_case) Removed.
9675 (procedure) Comment fixes. Calls vfm_source->read() instead of
9678 (prepare_for_writing, arrange_compaction, make_temp_case,
9679 vector_initialization, setup_filter) New function.
9680 (open_active_file) Most of the code moved into the abovementioned
9681 new functions. Now sets temp_dict to &default_dict if there is no
9682 temporary dictionary, for convenience. New debug output.
9683 (close_active_file) Deals with changing the sink to the source.
9684 Calls finish_compaction(). Frees compaction_case. Mostly
9686 (glob vars disk_source_file, disk_sink_file) New vars.
9687 (destroy_active_file, read_from_memory) Removed.
9688 (disk_stream_init, disk_stream_read, disk_stream_write,
9689 disk_stream_mode, disk_stream_destroy_source,
9690 disk_stream_destroy_sink) New functions.
9691 (glob var vfm_disk_stream) New var.
9692 (glob vars memory_source_cases, memory_sink_cases,
9693 memory_sink_iter, memory_sink_max_cases) New vars.
9694 (memory_stream_init, memory_stream_read, memory_stream_write,
9695 memory_stream_mode, memory_stream_destroy_source,
9696 memory_stream_destroy_sink) New functions.
9697 (glob var vfm_memory_stream) New var.
9698 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9699 named `more_cases'. Simplified debug output. Otherwise mostly
9701 (record_case) Moved into the stream drivers. Removed.
9702 (transform) Removed (was dead code).
9703 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9704 common case that the splits don't change, we don't need to copy
9705 the case into prev_case again--pointless.
9706 (compact_case) New function.
9707 (finish_compaction) New function.
9709 * vfmP.h: Comment fixes.
9710 (DEV_* enum series) Removed.
9711 (struct storage) Renamed `stream_info'. Removed variant record.
9712 Removed `device' member.
9714 * debug-print.h: New file.
9716 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9718 * autorecode.c: Turned off debugging.
9720 * data-list.c: (destroy_dls) Closes the associated file handle.
9722 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9723 parse_variables() options.
9725 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9727 * display.c: (display_variables) Really fixed null cell bug.
9729 * file-handle.q: (fh_close_handle) Changed debugging message.
9731 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9732 parse_variables() options.
9734 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9735 (cmd_list) Fails if no variables specified.
9736 (determine_layout) Writes blank lines manually.
9738 * loop.c: (loop_1_trns_proc) Made debugging code only print
9739 messages if debugging.
9741 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9742 parse_variables() arguments.
9743 (main) Parses optional parenthesized options to varlist
9744 subcommands into sbc->message.
9746 * sfm-read.c: Format fix.
9748 * var.h: (FV_*) New enum series.
9749 (PV_*) New enum PV_NO_SCRATCH.
9751 * vars-prs.c: (find_var) Removed.
9752 (fill_all_vars) Takes FV_* enum instead of boolean third
9753 argument. Rewritten to deal with scratch as well as system
9755 (parse_variables) Error message on scratch variable if
9758 * vfm.c: (static var virt_begin_func) New var.
9759 (procedure) Sets up virt_begin_func.
9760 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9761 after dump_splits(). For succeeding groups changes, calls
9762 virt_begin_func() instead of begin_func().
9764 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9766 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9769 * dfm.c: Added some debugging messages, disabled by default.
9770 (open_file_r) Fixed error message.
9771 (read_record) On eof on inline_file, instead of calling
9772 fh_close_handle(), simply jump to eof label like a normal file.
9775 * display.c: Thin lines between rows for certain kinds of
9776 listing. Fixed `null cell' bug.
9778 * error.c: (failure) Flush stdout, stderr before failing.
9780 * file-handle.q: (fh_close_handle) Added debugging message.
9782 * frequencies.q: (dump_full) Bottom line extends across entire
9783 table width. Changed title formatting.
9784 (dump_condensed) Changed title formatting.
9785 (dump_statistics) Fixed title formatting.
9787 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9788 Sets default value of set_format.
9790 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9791 Passes write_all_headers() to procedure() as pre-group func.
9792 (write_all_headers) New function.
9793 (determine_layout) Removed calls to write_header().
9794 Calls blank_line() before and after write_fallback_headers().
9796 * recode.c: (recode_trns_free) Only attempts to free head->map if
9799 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9800 file variable names but gives a warning. Sets `left' based on
9801 first character being/not being `#'. On lossage frees dict->var.
9803 * som-high.c: (som_draw_title) Simplified title formatting.
9805 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9807 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9809 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9810 beginning. Frees v_src, v_dest on successful exit. Frees
9811 h_trans[*], h_trans on lossage.
9812 (recode) Frees h_trans[*], h_trans.
9814 * dfm.c: (dfm_close) Formatting change.
9815 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9816 longer allocates its own in inline_file.
9817 (open_file_r) Passes the local dfm_fhuser_ext to
9819 (open_file_w) Message fix.
9820 (read_record) Buffer reallocation strategy changed. Frees
9821 ext->line even in inline_file to prevent leaks.
9822 (dfm_put_record) Fixed bug where `ext' was cached before the file
9823 was opened and thus it would be NULL when the file really was
9825 (cmd_begin_data) Sets up inline_file basics itself, then calls
9826 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9828 * list.q: (write_line) Formatting fix.
9829 (clean_up) Minor strategy change. Sets proportional font after
9831 (determine_layout) Sets fixed font before writing regular headers,
9832 or after writing fallback headers.
9834 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9835 and KEEP vars after using them.
9837 * postscript.c: (ps_init_driver) Frees x->family.
9838 (postopen) When loading fonts, free the temporary font name buffer
9840 (ps_text_set_font_by_position) Free temporary font name buffer
9842 (text) Fixed code that calculated `lig' so that `lig' always gets
9843 initialized. Formatting fix.
9845 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9847 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9848 cells, not xmalloc(), so that the cells will get destroyed
9851 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9854 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9856 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9859 * dfm.c: Comment fix.
9861 * list.q: Comment fixes. Include somP.h. Removed static vars
9862 table, n_columns, n_rows, part. New struct list_ext. New static
9864 (n_lines_remaining, n_chars_width, write_line) New functions.
9865 (cmd_list, list_cases) Rewritten.
9866 (begin_row, end_row, flush_table) Removed.
9867 (write_header, clean_up, write_varname, write_fallback_headers,
9868 determine_layout) New functions.
9870 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9872 * output.h: Comment fix.
9874 * postscript.c: Comment fix.
9875 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9876 added font_size. All references changed.
9877 (ps_init_driver) Initializes font_size. Simplified space checking
9879 (static var option_tab[]) Removed prop-size, fixed-size; added
9881 (ps_option) Handles font_size.
9883 * som-high.c: Moved prototypes into somP.h.
9884 (som_init_driver) New function.
9885 (som_submit_table) Moved some code into new function
9887 (build_target) Moved some code into new function
9888 som_internal_eject_page().
9889 (som_eject_page) Uses som_internal_eject_page().
9890 (som_internal_eject_page) New function.
9892 * som-low.c: Moved prototypes into somP.h.
9894 * som.h: Formatting fixes.
9896 * somP.h: (struct som_driver_ext) Removed em_width;
9897 added prop_em_width, fixed_width.
9899 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9901 * Makefile.am: Added `localedir' definition. Added
9902 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9904 * ascii.c: (macro draw_line) Fixed capitalization.
9906 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9907 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9908 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9909 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9910 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9911 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9912 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9913 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9914 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9915 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9916 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9917 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9918 for internationlization.
9920 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9922 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9924 * do-if.c, sort.c, val-labs.c: Comment fixes.
9926 * glob.c: (init_glob) Uncommented, updated i18n support.
9928 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9929 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9930 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9931 the declarations of macros taking arguments a lot nicer.
9933 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9935 * error.h: Removed CE, CW aliases for SE, SW.
9937 * q2c.c: Removed explicit streq() definition since it's duplicated
9940 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9941 stats.h, str.h, tokens.h: Made the declarations of macros taking
9942 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9945 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9947 * cmdline.c: Comment fixes.
9948 (pick_compat) Changed return type to int. Now, instead of setting
9949 glob var `compat' to the emulation, returns the emulation. All
9951 (parse_command_line) Added terminating null to end of
9952 `long_options' array definition.
9953 (pre_syntax_message) Fixes.
9954 (usage) Shows the default emulation in the syntax message by
9955 calling pick_compat().
9957 * getline.c: (getl_add_include_dir) Separates paths with
9958 PATH_DELIMITER, not DIR_SEPARATOR.
9960 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9961 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9963 * output.c: (outp_configure_macro) Make earlier definitions for a
9964 particular key override later ones for the same key.
9966 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9968 * ascii.c: Comment fixes.
9970 * output.c: (outp_get_paper_size)
9971 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9973 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9975 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9976 <errno.h>. GNU libc 2 enforces this!
9978 * command.c: (parse_cmd) Fixed problem with `else' clause being
9979 paired with wrong `if'. Comment fix.
9981 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9983 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9984 blp_getline() to getline().
9986 * output.c: (outp_eval_dimension) Changed the fix from last time;
9987 there was no variable `a'.
9989 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9991 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9993 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9994 numbers having fractional parts. Added case of a fraction without
9995 a whole-number part.
9997 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9999 * ascii.c: (ascii_text_get_font_position) Removed.
10001 * expr.h, exprP.h: Disabled debugging.
10003 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
10006 * output.h: (struct outp_class_struct) Removed
10007 text_get_font_position method. All references deleted.
10009 * postscript.c: Big change here. Fontmaps were completely
10010 eliminated because of a change in philosophy. Comment fixes.
10011 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
10013 (struct ps_driver_ext) `position', `fontmap', `prop_name',
10014 `fixed_name' members removed. New members `prop_family',
10015 `fixed_family'. `family' member changed to type char *.
10016 (static var ps_fontmaps) Removed.
10018 (ps_init_driver) Removed obsolete references, updated.
10019 Initializes `translate_x', `translate_y', `scale'. Doesn't read
10020 fontmap, of course. Refers to font names through internal_name
10021 rather than subversive means. Frees proper items.
10022 (static var option_tab[]) Removed `fontmap-file' option; renamed
10023 `fixed-font', `prop-font'.
10024 (ps_option) Corresponds to option_tab[].
10025 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
10026 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
10027 hash_family) Removed.
10028 (postopen) Generates font names from family names. Gets
10029 PostScript font name properly. New prologue file comment `!!!'
10031 (ps_open_page) Adds translate_x, translate_y to BP prologue
10032 function; gives SF argument floating-point format.
10033 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
10034 font name. Doesn't change font family.
10035 (ps_text_set_font_by_position) Generates Groff font name from font
10036 family name instead of through table lookup.
10037 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
10038 all references changed. Reduced to simple string assignment.
10039 (ps_get_font_name) Removed.
10040 (ps_get_font_family) Reduced to string return.
10041 (text) Doesn't save `position' since it no longer exists. Ugly
10042 kluge to save font family--fix soon?
10043 (load_font) Removed PostScript name argument.
10045 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
10047 * postscript.c: Comment fix.
10048 (ps_open_page) Puts scale factor in PostScript output.
10050 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
10052 * Makefile.am: Distcleans q2c.
10054 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
10056 * ascii.c: (delineate) Sets text size even if width is zero.
10058 * command.c: Comment fix.
10059 (static var cmd_table[]) Re-enabled EVALUATE command.
10060 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
10061 of comments in script files. Now more liberal on criteria for
10062 performing a state transition--if *anything* happened correctly,
10063 not just if *everything* happened correctly.
10065 * data-out.c: (convert_F) Comment fix. Why in the fsck does
10066 Checker segfault on formatting large numbers and why in the fsck
10067 hadn't I noticed this before?
10069 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
10071 * list.q: (cmd_list) Commented out the actual output routine
10072 because of various problems. Probably will abandon the idea of
10073 using the general `crushed tables' for the LIST procedure.
10075 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
10076 clearing it. Allocates a new var_by_name dictionary before trying
10077 to add members to it.
10079 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
10080 `sib'. Changed type of `node' argument.
10081 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
10082 avl_walk_inorder().
10083 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
10084 [DEBUGGING] Only deletes the variable from var_by_name if that var
10087 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
10089 * Makefile.am: Added include files to SOURCES. Added
10090 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
10091 includes rules for q2c. Added `boast' target.
10093 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
10095 * Makefile.am: Maintainer-clean Makefile.in.
10097 * Makefile.am: Fixed redundant EXTRA_DIST line.
10099 * ascii.c: Comment fixes.
10100 (ascii_line_vert) Fixed overly aggressive range check.
10102 * display.c: Removed dead code.
10104 * list.q: Turn debugging on.
10105 (flush_table) New debug code.
10107 * sfm-read.c: (read_value_labels) malloc's the structure before
10108 trying to assign to its members.
10110 * sfm-write.c: Comment fix.
10112 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
10114 (output_table) No arguments anymore--gets them through `som'
10115 global. New debug code. In crushed tables, now sets `htv' as
10116 well as `hv' to avoid bad confusion later.
10117 (dump_crush_page) New debug code.
10119 * som-low.c: (som_dump_crush_page) New debug code.
10121 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
10123 All source files: Broke long lines into multiple lines.
10125 * ascii.c: (ascii_close_page) Uses host_system var in place of
10126 HOST_SYSTEM constant.
10128 * cmdline.c: (var syntax_message[]) Broke into
10129 pre_syntax_message[] and post_syntax_message[].
10130 (usage) Outputs both parts, separated by driver list.
10132 * error.h: Fixed broken formatting.
10134 * expr-opt.c: (str_search, str_rsearch) New functions.
10136 * misc.c: (blp_getdelim) Removed. All references changed to
10138 (str_search, str_rsearch) Removed.
10139 (memrmem) New function.
10141 * misc.h: (blp_getline) Removed. All reference changed to
10144 * stat.h: New file.
10146 * filename.c: Includes "stat.h", not <sys/stat.h>.
10147 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
10149 * output.c: (outp_list_classes) Changed output formatting.
10151 * sfm-write.c: (write_header) Uses host_system var instead of
10152 HOST_SYSTEM constant.
10153 (write_rec_7_34) Extracts version numbers from the version string.
10156 * sort.c: Includes "stat.h", not <sys/stat.h>.
10158 * str.c: (strcasecmp) Removed.
10160 * title.c: (cmd_document) Uses host_system var instead of
10161 HOST_SYSTEM constant.
10163 * version.c: Generated on-the-fly by the Makefile instead of being
10166 * str.h: Comment fixes. Doesn't substitute for missing memmove or
10168 [!HAVE_STRNCASECMP] Declares strncasecmp().
10170 * version.h: Removed stray character. Comment fixes.
10171 (vars host_system, build_system) New vars.
10173 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
10175 * Most source files: Changed formatting of copyright notice; fixed
10176 FSF address; reformatted to better conform to GNU standards;
10177 comment fixes. Added markups to prevent GNU indent from messing
10178 up my beautiful formatting :-).
10180 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
10181 that GNU indent markups can be passed through without problems.
10183 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
10185 * get.c: Turned off debugging.
10187 * glob.c: (init_glob) Turned on save-file compression by default.
10189 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
10190 compression than was possible in save files.
10192 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
10194 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
10196 * frequencies.q: Removed Fiasco extensions. Updated calculation
10197 algorithms. Polished output format.
10198 (struct frq_info_struct) Removed members `max_degree', `min_n',
10199 all references removed.
10200 (macro frq_extensions) Removed.
10201 (static vars min_n, max_degree) Removed, all references removed.
10202 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
10203 calculate `min_n', `max_degree'.
10204 (postcalc) Passes new arg to dump_statistics().
10205 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
10207 (dump_condensed) Adds variable name title.
10208 (sum_freqs) Removed.
10209 (calc_stats) Updated calculation algorithm.
10210 (dump_statistics) Removed warning for too-few observations.
10211 Changed table formatting. Adds variable name title if passed new
10214 * output.h: Comment fix.
10216 * recode.c, sample.c, sort.c: Disabled debug code.
10218 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
10219 Improved debug code.
10221 * var.h: (enum series frq_*) Removed Fiasco extensions.
10223 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10225 * command.c: Added PROCESS IF to command table.
10227 * Lots & lots of places, removed checks for NULLs preceding calls
10228 to free_expression(), which itself checks.
10230 * descript.q: Removed Fiasco extensions. Removed optimizations
10231 for non-weighted active files. Implemented some options.
10232 Finished polishing output format. Comment fixes. Merged
10234 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10235 max_degree, min_n) Removed.
10236 (macro dsc_extensions) Removed.
10237 (struct dsc_info_struct) Removed `min_n' member, all references
10239 (internal_cmd_descriptives) Removed calculation of min_n,
10240 max_degree. Only deals with one `calc' routine instead of two
10242 (precalc) Eliminated redundancy. Updated for changes to
10243 descriptives_proc structure.
10244 (calc) Moved here from `descript.g'. Rewritten to calculate
10245 statistics via `moments about the mean' rather than by summing,
10246 summing squares, summing cubes, and so on.
10247 (postcalc) Rewritten for new-style statistical calculation.
10248 (display) Removed support for displaying variables across rows.
10249 No longer crushes the descriptives table. Removed ancient code.
10250 Added display of N, by variable and listwise.
10252 * descript.g: Removed; merged into `descript.q'.
10254 * expr-evl.c: (evaluate_expression) Now returns a double. For
10255 numeric results, it returns the result as well as storing it in
10256 the passed `value' structure if non-NULL. For string results it
10257 just returns 0.0 and it must be passed non-NULL. Many references
10258 to this function were optimized by use of this change, especially
10259 but not exclusively in `compute.c'.
10261 * frequencies.g: Comment fix.
10263 * glob.c: (glob var process_if_expr) New global var.
10265 * postscript.c: (static var option_tab[]) Corrected entry for
10267 (postopen) Sets x->size to x->prop_size.
10268 (ps_text_set_font_by_name) Sets font size as well as typeface for
10269 PROP and FIXED fonts.
10271 * sel-if.c: (cmd_process_if) New function.
10273 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10274 (sfm_write_dictionary) Sets `n_cases' to 0.
10275 (sfm_write_case) Increments `n_cases'.
10276 (sfm_close) Attempts to seek the system file back to the header
10277 and write the number of cases in its proper slot.
10279 * som-frnt.c: (som_insert_table) Masks off expansion options since
10280 only SOPT_X_NORM seems to work sensibly.
10282 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10283 with a `fixed' value of 2.
10285 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10287 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10288 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10290 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10291 (struct descriptives_proc) Removed `miss_noweight'; new members
10292 `X_bar', `M2', `M3', `M4', `min', `max'.
10294 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10296 * vfm.c: (close_active_file) Cancels PROCESS IF.
10297 (write_case) Doesn't process cases unselected by PROCESS IF.
10299 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10301 * glob.c: (glob var err) Removed.
10303 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10304 doesn't have to take into account number of value labels since
10305 they're in a subtable anyway. Also, doesn't display more than 10
10306 value labels since we can't yet break pages in subtables.
10308 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10310 * som-frnt.c: (som_change_table_size) Simple change for elegance
10311 that shouldn't change behavior.
10312 (som_set_value) Comment fix.
10314 * som-high.c: (som_submit_table) Message fix.
10316 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10318 * command.c: Added SYSFILE INFO to command table.
10320 * file-handle.q: (fh_handle_filename) New function.
10322 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10325 * main.c: (parse) New return value for command functions, -3.
10327 * misc.h: Comment fix.
10329 * output.h: Comment fixes.
10330 (macro COMPONENTS) Removed.
10332 * postscript.c: (write_text) Modified literal_chars[] so that `('
10333 and ')' are not written to the output in strings as literals.
10335 * sfm-read.c: (sfm_read_dictionary) New argument.
10336 (read_header) New argument. Sets the information structure's
10337 values from the header information.
10338 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10339 bizarre Checker problem, I guess.
10340 (read_variables) Proper cleanup on lossage.
10342 * sfm.h: (struct sfm_read_info) New struct for use by
10343 sfm_read_dictionary().
10345 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10346 currently used just for tables that can be dynamically resized and
10347 thus have to be allocated with arena_malloc() instead of
10348 arena_alloc(). All references changed.
10349 (som_change_table_size) New function.
10350 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10352 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10353 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10356 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10358 (draw_intersection) Now takes an argument specifying the table in
10359 question. All references changed.
10360 (draw_table_cell) New function.
10361 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10362 (som_get_table_size) Many nice new explanatory comments.
10363 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10365 * som.h: New enum series SOM_CREATE_* for use as create flags with
10366 som_create_table().
10368 * str.h: Moved a comment here from TODO.
10370 * sysfile-info.c: New file. Reference implementation.
10372 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10374 * command.c: Added RENAME VARIABLES to table of commands.
10376 * data-in.c: (dls_error) Sets `cust_field'.
10377 (parse_N) Message fix.
10378 (parse_day_count) New function.
10379 (to_roman) Never outputs VX as a `short form' of V.
10380 (parse_month) Fixed parsing of Roman numerals.
10381 (parse_trailer) Message fix.
10382 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10383 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10384 the date is invalid.
10385 (parse_SDATE) Fixed swapped day, year.
10386 (parse_JDATE) Fixed bug for dates in 1582.
10387 (parse_DTIME) Allows days not between 1 and 31.
10388 (parse_numeric) Makes local copy of f.type for easier usage.
10391 * data-out.c: (convert_F) When outputting as scientific, properly
10392 sets f.type as fp->type.
10393 (insert_commas) Fixed operator precedence problem with setting of
10394 nitems. Changed strcpy to memcpy (no null terminator).
10395 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10396 (convert_CCx) Essentially rewritten, but now it works.
10398 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10399 feature of Fiasco).
10400 (display_documents) Implemented.
10402 * error.c: (glob var cust_field) New var.
10403 (vmsg) Displays cust_field as part of message classes DE and DW.
10405 * formats.c: (debug_print) Fixed to compile under updated
10408 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10411 * misc.c: (parse_format_specifier) Formatting fix.
10413 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10414 `n_rename' for clarity.
10415 (cmd_modify_vars) Initializes `forward' and `positional' at
10416 appropriate times. Frees lists of vars to rename on failure.
10417 Comment fix. Frees memory on success.
10418 (rearrange_dict) Simplified `for' loop condition.
10420 * rename-vars.c: New file (reference implementation).
10422 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10424 * sfm-read.c: (read_header) File label is created only if file
10425 label in file is not blank.
10426 (read_variables) Initializes `dict' local variable.
10427 (read_documents) Proper behavior on lossage.
10429 * sfm-write.c: (write_header) Doesn't blank out the file label
10430 (why was this here to begin with?!)
10432 * temporary.c: (save_dictionary) File label is copied only if
10433 non-NULL. Doesn't try to xstrdup() dictionary documents.
10434 Adapted so as to not irritate Checker.
10435 (free_dictionary) Only destroys var_by_name if non-NULL.
10437 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10438 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10439 lines to the document, indents the document. Also, it works now.
10440 (add_document_line) New function.
10442 * var.h: (struct dictionary) Reordering.
10444 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10445 bits if it was allocated to begin with.
10447 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10449 * command.c: Added MODIFY VARS to list of commands.
10451 * configure.in: Updated custom macros for autoconf 2.12. Removed
10452 mmap reference; fixed termcap library reference.
10454 * display.c: (display_variables) Fixed a few bugs although it's
10455 still not well written.
10457 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10458 (induce_segfault) Calls chkr_disp_call_chain() instead of
10459 inducing an actual SIGSEGV.
10461 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10462 str_search() and str_rsearch(). Fixed tests for matches on
10463 OP_INDEX and OP_RINDEX.
10465 * filename.c: (good_getcwd) Removed as the new libc for Checker
10466 doesn't contain this bug, apparently.
10468 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10469 consistency with GNU memmem.
10470 (blp_getdelim) Changed `len' from `int' to `size_t'.
10472 * modify-vars.c: Reference implementation.
10474 * som-frnt.c: (zero_length) New global var.
10475 (som_create_table) Message fix.
10477 * som.h: Added gcc attributions to som_set_text(),
10478 som_output_text() prototypes. blank_line() refers to
10479 zero_length[] instead of a literal null string to suppress gcc
10482 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10483 (allocate_cases) Decrements x_max so the last element of x[] can
10484 be used by the algorithm.
10486 * var.h: Changed minor details of `variable' declaration.
10487 (struct modify_vars_proc) New struct.
10488 (struct variable) Added field p.mfv.
10490 * vars-atr.c: Comment fix.
10492 * vars-prs.c: (fill_all_vars) More optimal implementation.
10494 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10495 character, which it shouldn't have to do but printf() seems to
10496 read the null byte even though I supply a maximum length...
10498 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10500 * command.c: Removed command alias X for QUIT.
10501 (parse_cmd) Fixed comment parsing.
10503 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10505 (read_record) Fixed references to len, size.
10506 (dfm_get_record) Restructured.
10508 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10511 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10514 * modify-vars.c: New file. Not complete.
10516 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10519 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10520 problems caused by int/size_t differences.
10522 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10525 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10526 being compared were of equal length.
10528 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10530 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10532 * lexer.c: (get_dotted_rest_of_line) New function.
10534 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10537 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10538 type 6 records. Frees the dictionary properly.
10539 (read_header) Initializes the dictionary instead of letting
10540 read_variables() do it. Sets the dictionary file label from the
10542 (read_documents) New function.
10544 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10545 write type 6 record if appropriate.
10546 (write_header) Writes file label from dictionary.
10547 (write_documents) New function.
10549 * temporary.c: (save_dictionary, restore_dictionary,
10550 free_dictionary) Properly handle new fields in dictionary struct.
10552 * title.c: (get_title) Returns after failure().
10553 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10554 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10556 * var.h: (struct dictionary) New fields `label', `n_documents',
10559 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10561 * command.c: Added FILTER to list of commands.
10563 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10566 * get.c: (cmd_save_internal) Removed weighting code since it's now
10567 handled by sfm-write.c. Properly commented out debug code.
10569 * glob.c: (glob var weighting) Removed.
10571 * sel-if.c: Comment fixes.
10572 (cmd_filter) New function.
10574 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10575 (sfm_read_dictionary) Sets weighting variable direct in the
10576 created dictionary now. (Apparently we previously didn't support
10578 (read_header) Sets weight_index field in sfm_fhuser_ext from
10579 header read from disk.
10581 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10582 (write_header) Now sets the weighting in the header from the
10583 passed primary dictionary instead of from the sfm_write_info.
10585 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10587 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10588 broke on boundary conditions.
10590 * var.h: (struct dictionary) New fields `weight_var',
10591 `weight_index', and `filter_var'.
10592 (glob var weighting) Removed. This is now part of struct
10593 dictionary. All references changed; the less mechanical changes
10594 are described above.
10596 * vars-atr.c: (find_dict_variable) New function.
10598 * vfm.c: (static var filter_index) New variable.
10599 (open_active_file) Initializes filter_index from default_dict.
10600 (write_case) Calls proc_func() only if the filter variable is
10601 nonzero; this implements FILTER behavior.
10603 * weight.c: (static var weight_varname) Removed.
10604 (cmd_weight) Modified default_dict instead of glob vars.
10605 (update_weighting) Changed the signature to modify a dictionary
10606 instead of glob vars. Now returns the weighting variable.
10607 (get_weighting_variable) Removed; its function is absorbed by
10608 update_weighting().
10609 (stop_weighting) Operates on a dictionary now.
10611 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10613 * sort.c: Removed debugging info from messages.
10614 (do_external_sort) Cleans up after itself by deleting the
10615 temporary directory on failure. (On success it is deleted by the
10617 (allocate_cases) Removed debug code. Added clean up code.
10618 (output_record) Removed debug code.
10619 (merge) Added code to close all the input files that are currently
10620 open. This is a likely location for bugs, because I'm not sure
10621 about boundary conditions. Removed an unnecesary heap_delete().
10622 (merge_once) Removed input file "optimization" that in fact
10623 screwed up the rest of the code. Message and comment fixes.
10625 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10627 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10629 * heap.c: (heap_delete) New argument.
10631 * sort.c: Finished implementation of external sort.
10633 * vfm.c: (read_from_disk) Returns after a disk error.
10635 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10637 * sort.c: (static var state) Removed.
10638 (static vars max_handles, tmp_basename, tmp_extname,
10639 huffman_queue) New variables.
10640 (do_external_sort) Moved most code to new functions.
10641 Creates huffman_queue.
10642 (allocate_file_handles, allocate_cases) New functions.
10643 (static vars run_no, run_length, file_index, case_count) New
10645 (output_record) Returns success. Now really writes to the output
10647 (begin_run, end_run) New functions.
10648 (write_initial_runs) Returns success. Initializes run_no to -1.
10649 Calls begin_run(), end_run() at appropriate times. Outputs debug
10651 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10653 (merge) New function.
10655 * heap.c, heap.h: New files. Hopefully in near-final form.
10657 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10659 * glob.c: Added write_active_file to global vars.
10661 * sort.c: Several new miscellaneous static variables.
10662 (cmd_sort_cases) Big comment fix.
10663 (perform_case_2) Renamed `do_external_sort' and completely
10665 (case_2_proc_func) Removed.
10666 (output_record, write_initial_runs, write_to_sort_cases,
10667 compare_record) New functions.
10669 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10671 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10673 * sort.c: (perform_case_2) Changed the method for allocation of
10674 lots of memory--now allocates one case at a time in hopes that
10675 more cases can be allocated with heavily fragmented memory.
10677 * var.h: (write_active_file) New global var.
10679 * vfm.c: (procedure, close_active_file, write_case,
10680 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10681 arguments to procedure() to be NULL. All references to
10682 procedure() that made use of dummy functions were changed to NULL
10684 (open_active_file) If write_active_file is non-NULL, the output
10685 device becomes DEV_PGM (a new enum).
10686 (close_active_file) Sets write_active_file to NULL.
10687 (read_from_memory) Comment fix.
10688 (record_case) Calls write_active_file() when the output device is
10691 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10693 * sort.c: New file.
10695 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10696 Fixed checking for duplicate varnames.
10697 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10699 (autorecode_trns_free) Destroys hash tables for each recoding
10701 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10703 * command.c: Added SORT CASES to cmd_table.
10704 (null_func, null_int_func) Prototyped.
10706 * descript.g: (calc_weight, calc_noweight) Computes own case
10709 * frequencies.q: (dump_statistics) Fixed problem with
10710 too-few-cases warning message.
10712 * get.c: (cmd_save_internal) Handles weighting properly.
10714 * hash.c: (hsh_dump) Output format changed.
10715 (force_hsh_insert) Actually works now, prototype changed.
10717 * list.q: (static var case_num) New variable.
10718 (cmd_list) Initializes case_num.
10719 (list_cases) Increments case_num.
10721 * var.h: Added definitions for SORT CASES. Comment fixes.
10723 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10724 fixes. `active' renamed vfm_active, `rep' renamed
10725 vfm_replacement, all references changed.
10726 (procedure) The procfunc no longer receives a case number. All
10727 references changed.
10728 (write_case) Subtle reordering.
10729 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10732 * weight.c: (get_weighting_variable) New function.
10734 * vfmP.h: New file with definitions from vfm.c.
10736 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10738 * command.c: (FILE_TYPE_okay) Commented out some tests because
10739 they're clumsy and not yet needed.
10741 * var.h: Most *_trns structures moved to their respective source
10742 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10743 (union any_trns) Changed to a typedef for trns_header.
10744 (struct input_program_pgm) Removed.
10746 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10747 was allocated in the first place.
10749 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10751 * autorecode.c: New file.
10753 * command.c: Added AUTORECODE to command table; re-enabled SET.
10755 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10757 * error.c: (vmsg) Comment fixes.
10759 * hash.c: Comment fix.
10760 (hashpjw_d) New function.
10761 (hashpjw) Reimplemented as call to more general function
10763 (internal_comparison_fn) Initializes pointers properly.
10764 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10765 (force_hsh_insert, force_hsh_find) New debugging wrapper
10768 * main.c: (main) Message fix.
10770 * output.c: (outp_read_devices) Message fix.
10772 * set.q: Comment fixes.
10773 (custom_results) Implemented Wnd/X form of subcommand.
10774 (set_routing) New function.
10775 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10777 * settings.h: (SET_ROUTE_*) New enum series.
10778 (set_results) Renamed set_results_file, all references changed.
10779 (set_messages) Removed.
10780 (glob vars set_errors, set_messages, set_results) New vars.
10782 * title.c: (get_title) Remembers to xstrdup() the result of
10783 get_rest_of_line().
10785 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10787 (union any_trns) New element `arc'.
10789 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10791 * command.c: (output_line) Removed references to set_screen.
10793 * error.c: (static var terminating) New var.
10794 (hcf) Sets terminating to 1.
10795 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10796 This prevents an infinite loop if an error occurs within hcf().
10798 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10799 statement circumlocution with `case 42000' trick.
10800 (evaluate_expression) New support for OP_STR_MIS.
10802 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10803 statement circumlocution with `case 42000' trick.
10804 (dump_node) Handles OP_STR_MIS.
10806 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10807 variables exceptions.
10808 (parse_function) Message fix.
10809 (ops[]) Added OP_STR_MIS.
10811 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10813 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10815 * glob.c: Removed set_scrnfile glob var.
10816 (init_glob) set_errorbreak set to 0 by default.
10818 * groff-font.c: Changed included files.
10819 (groff_read_font) Initializes font_arena local var correctly.
10820 (default_font) New function.
10822 * output.c: Comment fixes.
10823 (glob var disabled_devices) New variable.
10824 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10826 [GLOBAL_DEBUGGING] (reentrancy) New function.
10827 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10828 outp_iterate_enabled_drivers) Calls to reentrancy().
10829 (destroy_list) New function.
10830 (outp_done) Moved code to destroy_list().
10831 (parse_options) Parses `listing', `screen', `printer' options
10833 (configure_driver) Sets new `device' member of driver.
10834 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10836 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10837 (struct outp_driver_struct) New member `device'.
10839 * postscript.c: (find_encoding_file) Doesn't display its own error
10841 (default_encoding) New function.
10842 (switch_font) Calls default_encoding() if no encoding can be
10844 (text) Makes up a character metric if none exists for the desired
10846 (load_font) Properly copies a fallback filename. Calls
10847 default_font() for a font if none at all are known.
10849 * set.q: Comment fixes. Removed OUTPUT subcommand.
10850 (custom_listing) Calls outp_enable_device() to enable/disable
10852 (turn_screen_on) Removed.
10853 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10854 screen, printer devices.
10856 * settings.h: Comment fixes.
10857 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10860 * som-high.c: (som_submit_table, som_eject_page) Use
10861 outp_iterate_enabled_drivers() instead of iterating
10862 outp_driver_list directly.
10864 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10866 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10867 (parse_string_as_format) Handles new formats.
10868 (parse_numeric) Now handles DOT and PCT formats.
10870 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10872 (convert_date) Handle EDATE and SDATE formats.
10873 (convert_CCx) Now if there's not room for the currency characters,
10874 converts it as F format if it's positive instead of giving up
10875 quickly. Also fixed save-and-restore bug with decimal point
10877 (convert_format_to_string) Handles new formats.
10879 * misc.c: (formats[]) Added new formats.
10880 (convert_fmt_ItoO) Supports new formats.
10882 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10883 data checking. New argument, all references changed.
10885 * sfm-write.c: (write_format_spec) Supports new formats.
10887 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10890 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10892 * cmdline.c: Comment fixes.
10893 (parse_command_line) Changed return type to void.
10895 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10897 (parse_numeric) Handles international numbers (comma as decimal
10898 point). Some reformatting.
10900 * data-list.c: (parse_free) Default output format is now
10901 set_format instead of hard-coded F8.2.
10902 (read_from_data_list_list) Emits error message on undefined data
10903 only if set_undefined is nonzero.
10905 * data-out.c: (convert_E) Changes decimal point from period to
10906 comma if appropriate. Restructured. Better comments.
10907 (convert_F) Changes decimal point from period to comma if
10909 (insert_commas) Major bug with handling of negative values fixed.
10910 Also, inserts periods instead of commas if appropriate.
10911 (convert_CCx) New function.
10912 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10913 (num_to_string) Changed `.' to set_decimal.
10915 * dfm.c: Comment fixes.
10916 (dfm_close) Frees ext->line even in inline_file.
10917 (open_inline_file) New function.
10918 (open_file_r) When opening the inline file: now properly
10919 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10921 (read_record) Calls fh_close_handle() instead of dfm_close() to
10922 close the inline file. Makes a copy of the line getl_buf to avoid
10923 interlock problems.
10924 (dfm_get_record) Restructured. Now checks the return value of
10926 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10927 checking for use of inline file. No longer tries to close inline
10930 * error.c: (glob var error_already_flagged) New var.
10931 (vmsg) Message change. Now checks max number of errors/warnings,
10934 * file-handle.q: (fh_handle_name) Now allows closing of
10936 (fh_init_files) Reformatted.
10938 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10940 * getline.c: (getl_include) Fixed bug that popped up when called
10941 when file queue was empty.
10942 (read_console) Resets error_count, warning_count,
10943 error_already_flagged to zero.
10945 * glob.c: Many changes to update list of variables.
10946 (init_compat_dependent) Now this function is called whenever
10947 `compat' changes. It now sets set_seed only if it hasn't
10948 previously been referenced. It now calls
10949 lex_init_compat_dependent().
10951 * include.c: (cmd_include_at) Frees temporary buffer instead of
10953 (cmd_include) Doesn't make copy of include file name.
10955 * lexer.c: Comment fixes.
10956 (init_lex) Moved some code into new function
10957 lex_init_compat_dependent().
10958 (lex_init_compat_dependent) New function.
10959 (hex_val) Simplified.
10960 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10962 * main.c: Comment fixes.
10963 (main) Reformatted.
10965 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10966 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10967 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10968 (setup_randomize) Sets set_seed_used.
10970 * set.q: Comment fixes.
10971 (custom_results) Conditionalizes on `compat'.
10972 (custom_log) Calls custom_journal().
10973 (set_ccx) New function.
10974 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10975 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10976 when set_decimal changes. Range-checks values for MITERATE,
10977 MNEST. Message fixes.
10979 * settings.h: Comment fixes.
10980 (struct set_cust_currency) New struct.
10981 (set_cc[], set_grouping, set_seed_used) New global vars.
10983 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10984 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10986 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10988 * glob.c: Revised variables to correspond to settings.h.
10989 (init_glob) Initializes variables from settings.h properly.
10991 * set.q: Began long-overdue major revision to correspond to new
10992 philosophy. Most code changed.
10994 * settings.h: Mostly changed; reorganized, reordered, large new
10997 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10999 * get.c: (cmd_save_internal) No longer forces compression off.
11001 * sfm-read.c: (read_compressed_data) If eof is reached when
11002 reading a new instruction octet, only signal error if we're in the
11005 * sfm-write.c: (COMPRESSION_BIAS) New #define.
11006 (struct sfm_fhuser_ext) New member `end'.
11007 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
11008 (ensure_buf_space) New function.
11009 (sfm_write_case) Reimplemented in order to support compression.
11010 (sfm_close) Writes out the remaining contents of the compression
11013 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
11015 * command.c: Defined SAVE and XSAVE commands in command table.
11017 * common.h: second_lowest_value is of type flt64, not double.
11019 * file-handle.h: Comment fix.
11021 * get.c: Comment fixes.
11022 (static var `trns') New.
11023 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
11024 cmd_save_internal, cmd_save, cmd_xsave) New functions.
11025 (dict_delete_run) Clears the variables and frees them now.
11026 (trim_dictionary) Sets default for compression.
11027 On KEEP subcommand, frees deleted variables as well as clearing
11028 them. Finally got the sense of the test for deleting all
11030 [DEBUGGING] (dump_dict_variables) Message fix.
11032 * glob.c: (init_glob) set_compression set to 1 by default.
11034 * list.q: Properly #includes config.h.
11036 * misc.h: New macro REM_RND_UP.
11038 * settings.h: Comment fix.
11040 * sfm-read.c: (structs sysfile_header, sysfile_format,
11041 sysfile_variable; inline function bswap_int32) Moved to new file
11043 (corrupt_msg) [__CHECKER__] No longer induces segfault.
11044 (sfm_read_dictionary) Fixed bug caused by failing to initialize
11046 (read_machine_flt64_info) Fixed some problems caused by confusion
11047 between flt64 and double types.
11048 (read_header) Message fix.
11049 (read_variables) Fixed set of cases in which we byte-swap sv.print
11050 and sv.write. Fixed confusion of flt64 and double.
11052 * sfm.h: (struct sfm_write_info) New.
11054 * som-high.c: (som_draw_title) Properly frees `s'.
11056 * temporary.c: (save_dictionary) Comment fix.
11058 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
11059 (struct trns_header) Formatting fix.
11060 (struct save_trns) New.
11062 * vars-atr.c: (discard_variables) Comment fix.
11064 * sfm-write.c: New file, baseline release.
11066 * sfmP.h: New file, baseline release.
11068 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
11070 * cmdline.c: (parse_command_line) `--version' output updated.
11071 (glob var syntax_message[]) Added my e-mail address.
11073 * file-handle.q, lexer.c, vfm.c: Changed many instances of
11074 `illegal' to `invalid'.
11076 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
11077 uncompression buffer.
11078 (sfm_close) Frees decompression buffer.
11079 (sfm_read_dictionary) Initializes decompression buffer.
11080 (buffer_input, read_compressed_data) New functions.
11081 (sfm_read_case) Restructured; now calls read_compressed_data() to
11082 handle compressed system file data.
11084 * var.h: Comment fix.
11086 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
11088 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
11091 * get.c: New comments. New static var `get_file'.
11092 (cmd_get) Now fully implemented. Calls discard_variables();
11093 initializes fv and lv for all variables; new debug code; sets
11094 up the dictionary; sets up the input program.
11095 (read_from_get, cancel_get) New functions.
11097 * sfm-read.c: Comment fixes.
11098 (sfm_close) New static function.
11099 (sfm_read_dictionary) Properly sets up the class of the
11100 file_handle. No longer cares what size the data is in records of
11101 type 7. Also, on failure, properly cleans up the file_handle and
11102 free()s some stuff.
11103 (read_variables) No longer thinks it knows `nval' of the
11104 dictionary. Now sets p.get.fv, etc., instead of speculatively
11106 (read_value_labels) Fixed off-by-one error in indexing of
11108 (sfm_read_case) New function.
11109 (sfm_r_class) New static var.
11111 * var.h: (get_proc) New struct.
11112 (struct variable) New member p.get.
11114 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
11116 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
11117 the manual's meaning.
11118 (rename_variables) New function.
11119 (trim_variables) Doesn't try to parse MAP any more. Removed debug
11120 code. Now properly reorders the dictionary on the KEEP keyword.
11122 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
11123 garbage collection.
11125 * vars-atr.c: (clear_variable) New argument `dictionary *'.
11126 (rename_variable) New function.
11127 (free_val_lab) Reformatted.
11129 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
11131 * var.h: Reindented entire file. Comment fixes.
11132 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
11134 (glob var default_dict) New.
11135 (struct indirect_dictionary) Removed.
11137 * Many other source files were changed to add `default_dict.'
11138 before all references to the dictionary of the active file.
11140 * vars-atr.c: (make_indirect_dictionary) Removed.
11142 * glob.c: Reindented all variable declarations. Updated for
11143 changed var.h. Comment fixes.
11145 * temporary.c: (restore_dictionary, save_dictionary) Simplified
11146 because now we can mainly copy dictionary structs.
11148 * vars-prs.c: (is_dict_varname, parse_dict_variable,
11149 parse_variables) Takes dictionary instead of indirect_dictionary
11151 (parse_variables) Instead of calling make_indirect_dictionary,
11152 just sets DICT to &default_dict if DICT is NULL. Of course, lots
11153 of `*dict.' references had to be changed to `dict->'. Removed
11156 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
11158 * get.c: Added GTSV_OPT_* series of enums.
11159 (trim_dictionary, dict_delete_run) New functions.
11160 [DEBUGGING] (dump_dict_variables) New function.
11161 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
11162 [DEBUGGING] Calls dump_dict_variables() to display results.
11164 * glob.c: (cmp_variable) Now a public function declared in var.h.
11166 * sfm-read.c: Turned off debug code. Comment fixes.
11167 (read_machine_int32_info, read_machine_flt64_info) New functions
11168 to parse type 7 records.
11169 (sfm_read_dictionary) Properly byteswaps several fields now.
11170 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
11171 records. [DEBUGGING] Dumps dictionary.
11172 (read_variables) Sets `index' field of variables created properly.
11173 Constructs avl tree of variables in dictionary. [DEBUGGING] No
11174 longer dumps dictionary.
11175 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
11177 [DEBUGGING] (dump_dictionary) No longer stubbed out.
11179 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
11180 var before destroying any variables just to save a little time.
11182 * var.h: (struct variable) Reordered in order to make name[] the
11183 first member; this makes pointers to `variable' pointers to the
11184 variable name, simplifying avl trees, etc.
11185 (struct indirect_dictionary) New struct.
11187 * vars-atr.c: (find_variable) Rewritten for efficiency.
11188 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
11190 (is_varname) Rewritten for efficiency.
11191 (parse_variables) New argument, which is a `dictionary *'. All
11192 references changed. This function now reads variable names from
11193 the dictionary passed, or from the default dictionary if NULL.
11195 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
11197 * misc.h: Added new macro DIV_RND_UP to perform integer division,
11198 rounding up. Changed many references to ROUND_UP to use this
11201 * sfm-read.c: Includes avl.h.
11202 (corrupt_msg) Induces a segfault under Checker.
11203 (macro assertive_bufread) New. Many references to bufread() now
11205 (sfm_read_dictionary) Split up into several functions. Added code
11206 to read dictionary records following the the type 2 records. Not
11207 quite complete. New variable `var_by_index'.
11208 (read_header, read_variables) New functions extracted from
11209 sfm_read_dictionary().
11210 (read_value_labels) New function.
11211 (bufread) Checks ferror() if fread() doesn't return the expected
11212 value; if ferror() is zero it's just EOF.
11213 (dump_dictionary) Stubbed out.
11215 * BTW: The source code now exceeds 50000 lines!
11217 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
11219 * command.c: Added GET to cmd_table[].
11221 * list.q: Removed reference to alloca headers.
11222 (cmd_list) Gave prototype.
11224 * sfm-read.c: Added DEBUGGING comments.
11225 (sfm_read_dictionary) Checks bias correctly. Sets
11226 dict->var_by_name to NULL. Calculates long_string_count
11227 correctly. realloc's dict->var[] array to minimum size.
11228 [DEBUGGING] Calls dump_dictionary.
11229 [DEBUGGING] (dump_dictionary) New function.
11231 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11232 (restore_dictionary) If the dictionary contains a non-NULL
11233 var_by_name, uses that instead of generating one.
11234 (free_dictionary) Destroys var_by_name.
11236 * var.h: (struct dictionary) Added field `var_by_name'.
11238 * get.c: New file, not complete.
11240 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11242 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11243 (parse_num_or_range) New function.
11244 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11245 <n> THRU HIGH missing values.
11247 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11248 __attribute__((const)).
11250 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11252 * sfm-read.c: Finished reference implementation.
11254 * sfm.h: Includes var.h.
11256 * var.h: Comment fixes.
11257 (struct `variable') Reordered some fields.
11259 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11260 constants added previously.
11262 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11264 * common.h: Comment fixes. Added declaration of
11265 `second_lowest_value' as variable or macro. Made `compat_type',
11266 `pgm_state_type' into anonymous enums.
11268 * display.c: Comment fix.
11270 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11272 [!defined SECOND_LOWEST_VALUE] Added definition for
11273 `second_lowest_value' global var.
11274 (compat, pgm_state global vars) Changed types to `int'.
11275 (init_glob) Initializes `second_lowest_value'.
11277 * sfm-read.c: Continued work, not complete.
11279 * var.h: Added new MISSING_* constants to handle LOWEST and
11282 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11284 * sfm-read.c: New file, not complete.
11286 * cases.c: (vec_insert) Changed vector expansion algorithm.
11287 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11288 mucking up the RECODE transformation in particular.
11289 (envector) Harmless change in notation.
11291 dfm is now fairly well tested again.
11292 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11294 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11296 * recode.c: Comment fix.
11298 * sfm.h: Interface should be fairly final now, or at least for a
11301 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11302 (open_active_file) [DEBUGGING] Translates ccase indices into
11303 variable names now to make it easier to understand what's really
11306 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11308 * data-in.c: Comment fix.
11310 * data-list.c: Includes dfm.h.
11311 (do_reading) Uses new function dfm_push_cust().
11313 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11314 `return 1;' at end.
11316 * file-handle.h: Completely changed. Some parts split off into
11317 new file dfm.h. Implemented in file-handle.q.
11318 (enum FH_*) Removed.
11319 (struct fh_ext_class) New struct.
11320 (struct file_handle) Retained only these fields: name, norm_fn,
11321 fn, recform, lrecl, mode. New fields class, ext.
11322 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11323 close_handle, handle_name) Added `fh_' prefix to name, all
11324 references changed.
11326 * dfm.h: New file, implemented in dfm.c.
11327 (get_record, put_record, fwd_record, bkwd_record, set_record,
11328 get_cur_col) Functions moved from file-handle.h, now prefixed with
11330 (dfm_push_cust) New function.
11332 * sfm.h: New file. Incomplete.
11334 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11335 interface. Functions reordered, comments changed. Not well
11336 tested, probably full of bugs.
11337 (struct dfm_fhuser_ext) New struct.
11338 (dfm_close) New function.
11339 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11340 (open_file_w) User messages changed.
11341 (get_record) Comment fixed.
11342 (read_record) Increments ext->ln even for inline_file. Calls
11343 dfm_close() for inline_file when `END DATA.' encountered.
11344 (dfm_get_record) Experimental restructuring.
11345 (dfm_push_cust) New function.
11346 (cmd_begin_data) Detects whether the inline file was fully read by
11347 checking whether it is still open; detects whether it was read at
11348 all by checking whether the line number is greater than zero.
11350 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11351 interface. Functions reordered, comments changed. Not well
11352 tested, probably full of bugs.
11353 (init_file_handle) Removed initializers for obsolete fields, added
11355 (fh_close_handle) Much simpler, now mainly calls the class
11357 (fh_init_files) Renamed inline file internal filename.
11359 * file-type.c: Includes dfm.h.
11360 (read_from_file_type) Doesn't use dfm internal state anymore.
11362 * inpt-pgm.c, print.c: Include dfm.h.
11364 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11365 int in comparison with other int.
11367 * som-high.c: (build_target) Fixed operator precedence problem in
11368 if statement (& versus ==).
11370 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11372 * dfm.c: (read_record) Can now read fixed-length records; not
11374 (put_record) Can now write fixed-length records; not tested.
11376 * file-handle.h: FH_* defines changed to enums. New enum series
11378 (struct file_handle) New members recform, lrecl, mode.
11380 * file-handle.q: Parser changed.
11381 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11382 /LRECL subcommands. These are compatible with Windows.
11383 (init_file_handle) Initializes recform, mode fields.
11385 * q2c.c: (get_line) When outputting `!' comment lines, now
11386 increments the output file line number so that `#line' directives
11388 (make_identifier) New function that converts an arbitrary string
11389 into a valid C identifier.
11390 (dump_vars) Calls make_identifier() in two places in order to
11391 suppress some errors for bad identifiers.
11392 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11393 for NO. Allows numbers to be prefixed by underscores to make them
11394 acceptable C identifiers but still to be parsed as numbers by the
11397 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11399 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11401 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11402 was opened for writing.
11403 (open_file_w) New function.
11404 (read_record) Uses strncasecmp if available. Improved error
11405 messages, comments.
11406 (put_record) New function.
11408 * file-handle.h: Moved function comments into dfm.c and
11409 file-handle.q. Comment fixes. Removed declarations of
11410 tilde_expand() and normalize_filename().
11411 (struct file_handle) Changed `open' from boolean to enumerated
11412 field to allow for three states--closed, open for reading, open
11413 for writing--all references changed.
11415 * file-handle.q: Includes filename.h.
11417 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11418 references changed.
11419 (alloc_line) Makes allowance for line terminator characters in
11421 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11422 (print_space_trns_proc) Handles OUTFILE differences.
11424 * recode.c, sample.c: Comment fixes.
11426 * var.h: (struct print_trns) Changed boolean field `eject' to
11427 bitmapped field `options'; all references changed. New enums
11428 PRT_* for use with this field.
11430 * exception.h, test-exception.c: Removed.
11432 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11434 * ascii.c: (delineate) Turned off debug output.
11436 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11439 * data-in.c: (parse_string_as_format) Sets the entire string value
11440 to spaces, not just the short string part of it. Is this correct
11443 * data-out.c: (convert_date) Fixed DATETIME format problems with
11444 decimal places, removed debug code.
11446 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11447 middle of parsing BEGIN DATA that would cause the lexer to read
11448 from a wild pointer `prog'; now calls new function
11449 preprocess_line() in lexer.c.
11451 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11453 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11454 Now call induce_segfault() to induce the segfault.
11455 (induce_segfault) New function.
11457 * expr-opt.c: Comment fix.
11458 (parse_sysvar) New function.
11459 (parse_primary) Added system variable support--calls
11461 (global var ops) Added OP_CASENUM operator.
11463 * expr.h: Comment fixes.
11464 (OP_* enum) added OP_CASENUM operator.
11465 (struct casenum_node) New struct.
11466 (union any_union_union) New member `cas' of type `casenum_node'.
11468 * glob.c: (global var last_vfm_invocation) New var.
11469 (init_glob) Initializes last_vfm_invocation.
11471 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11473 * getline.c: (get_line) Split into get_line() and preprocess_line().
11474 (preprocess_line) New function.
11476 * var.h: Declares last_vfm_invocation.
11478 * vfm.c: (procedure) Sets last_vfm_invocation.
11480 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11482 * command.c: (parse_cmd) Fixed bad assertion related to
11485 * data-in.c: (parse_month) Implemented to parse months according
11486 to full interpretation of standard.
11487 (to_roman) New function.
11488 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11489 (parse_weekday) Bug fix (forgot to skip all the day name).
11491 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11492 up parsing of multirecord data items. Also fixed user message.
11494 * data-out.c: Comment fix.
11495 (year2, year4, convert_date, convert_time, convert_WKDAY,
11496 convert_MONTH) New functions to support time & date output.
11497 (convert_format_to_string) Calls new time & date output routines.
11499 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11501 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11504 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11506 * misc.c: (global var formats) Fixed declarations of DATETIME,
11509 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11510 the output_char buffer.
11512 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11513 memory bug. Fixed user messages.
11515 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11517 * Removed #pragma argsused from lots of places.
11519 * data-in.c: Implemented zoned decimal and time-date formats.
11520 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11523 * data-out.c: Implemented zoned decimal format.
11525 * expr.h: Moved yrmoda() declaration here from exprP.h.
11527 * misc.c: (global var formats) Minor fixes--added
11528 FCAT_SHIFT_DECIMAL to formats N and Z.
11529 (convert_fmt_ItoO) Added support for format Z.
11531 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11533 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11535 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11536 som_check_workspace() that is activated between commands.
11538 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11541 * list.q: (begin_row) Changed title expansion style from
11542 SOPT_X_VERT to SOPT_X_SHSP.
11544 * som-frnt.c: Now includes `somP.h'.
11545 (som_push_workspace, som_pop_workspace) New functions that, taken
11546 together, form a solution to the recursive table building problem
11547 mentioned yesterday. Surrounded every table output routine
11548 throughout the program with calls to these functions.
11549 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11550 (som_create_table) Checks that there's an active workspace.
11551 (som_destroy_all_tables, som_crush) Removed.
11553 * som-high.c: (global var som_preserve_tables) Removed, all
11554 references deleted.
11555 (som_submit_table) Checks that there's an active workspace.
11556 (dump_columnated_table) Doesn't columnate tables that would have
11557 just one row per column.
11558 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11559 (som_dump_crush_page) Moved row number labels from left side of
11560 tables to right side.
11561 (som_get_table_size) Added support for SOPT_X_SHSP.
11563 * som.h: New cell expansion type SOPT_X_SHSP.
11565 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11567 (global var curtab_arena) Moved from som-frnt.c.
11569 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11571 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11572 that causes bad location warnings to be suppressed.
11573 (delineate) Saves current font when calling draw_text(); fixed
11574 handling of NULLs when backing up. Also fixed line-wrapping bug.
11576 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11577 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11579 * common.c: Added code to cause assertion failure to dump core
11580 when run under Checker.
11582 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11583 there are still bugs.
11585 * glob.c: (__eprintf) Removed.
11587 * list.q: Inserted som_preserve_tables kluge that prevents tables
11588 from being thrown away due to recursive table building through
11589 som_output_line being called from a transformation during the LIST
11590 procedure invocation. This is a general problem that must be
11591 solved in a better way since it applies to all procedures in
11593 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11594 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11596 * numeric.c: Fixed several errors in the form of msg() calls.
11598 * print.c: Updated for use of som.
11599 (dump_table) Reimplemented.
11600 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11601 Calls som_output_text() instead of outs_line().
11603 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11605 (som_output_text) Function moved from som-low.c. Interface
11608 * som-high.c: (som_preserve_tables) New global public variable
11610 (som_submit_table) Destroys the tables only if som_preserve_tables
11612 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11613 one subrow per row. Now labels subrows if there's more than one
11615 (dump_crush_table) Added wishlist comment.
11616 (som_eject_page) New public function declared in som.h.
11618 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11619 more than one subrow per row.
11620 (som_output_text) Moved to som-frnt.c.
11622 * som.h: (SOM_TOPT_PRESERVE) Removed.
11624 * title.c: (get_title) Changed interface.
11625 (cmd_title) Changed `title' to `outp_title'.
11626 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11628 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11630 * list.q: (flush_table) Conforms to new partial options in
11631 som_submission_form.
11633 * som-high.c: (paginate_horizontally) Changed form of subrow
11635 (build_target) Omits spacing before table if
11636 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11637 (dump_crush_page) Changed interface. Only trims bottom rule if
11638 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11639 (dump_crush_table) Handles partial tables.
11640 (output_row_label) New function.
11641 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11642 rule on the right edge of narrow subrows.
11644 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11645 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11646 All references updated.
11648 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11650 * misc.c: Comment fix.
11652 * som-high.c: (examine_table) Treats crushed tables separates for
11653 purpose of determining header size.
11654 (paginate_horizontally) Allots space for line numbers in crushed
11655 tables with lots of subrows per row. Calculates the `maximum page
11656 width', the width of the widest horizontal page.
11657 (build_target) Removed trim argument; all references changed.
11658 Stricter assertions. (dump_crush_page) New function.
11659 (dump_crush_table) Reimplemented.
11661 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11662 (som_dump_crush_page) Reimplemented, interface changed.
11664 * somP.h: Many many new helper macros for use with crushed tables.
11665 (global var som) Removed `tv', `cum_y' members; all references
11666 removed. New members `mpw', `digit_space'.
11668 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11670 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11671 variable, changed to constant 1024.
11672 (arena_ca_strdup) Changed `sizeof(a_string)' to
11673 `sizeof(c_string)'.
11674 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11675 `(c_string *)' to `(char *)'; this fixed some offset problems.
11677 * filename.c: (readlink_malloc) Changed initial allocation from
11679 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11682 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11683 &fm->owner in several places.
11685 * som-high.c: (output_table) Changed interface to rest of world.
11686 (examine_crush_table) Removed. Crushed tables are re-broken now,
11687 in preparation for rewrite.
11689 * som.h: Comment fix.
11691 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11693 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11694 itself in the cleanup stage.
11696 * descript.q: (display) At least temporarily, changed the table
11697 format to a crushed table.
11699 * list.q: (begin_row) At least temporarily, added horizontal lines
11702 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11703 the horizontal "headers," that is, to the width of the far left
11704 and far right rules.
11705 (justify_pagination) Sets som.th to the width of the widest row
11706 in the crushed table. Fixed inner loop off-by-one error.
11708 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11711 * somP.h: Comment fix.
11713 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11715 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11716 before closing it; also, opens the constructed filename `s'
11717 instead of f->filename.
11719 * postscript.c: Moved initialization of x->loaded, x->prop,
11720 x->fixed, x->current, also the add_encoding() calls, into
11722 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11723 sets x->last_font to NULL; sets x->next_combo to zero.
11725 * som-high.c: (crushed_row_height) Moved definition farther up.
11726 (som_submit_table) Doesn't calculate line width, font size until
11727 after calling open_page(), to accomodate changes to PostScript
11729 (vert_headers) Removed; equivalent functionality moved to
11730 examine_table(), examine_crush_table().
11731 (justify_pagination) Replaced with different algorithm.
11732 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11733 at the bottom of the page.
11735 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11737 * command.c: Added cmd_list back into cmd_table.
11739 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11740 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11742 * list.q: (flush_table) Updated to new som_submission_form format.
11744 * som-frnt.c: Comment fix.
11746 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11747 (output_table) Calls som_get_table_size() directly; handles
11749 (examine_crush_table) New function; calls vert_headers().
11750 (examine_table) Moved some code into new function, vert_headers().
11751 (justify_pagination) New function.
11752 (dump_plain_table) Removed `static' from `cy'.
11753 (dump_crush_table) New function.
11755 * som-low.c: (som_dump_crush_page) New function.
11757 * som.h: Comment fixes.
11758 (enum SOM_TOPT_CRUSH) New.
11759 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11760 Temporarily set to zero to make do with LIST procedure.
11762 * somP.h: Re-ordering.
11764 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11766 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11768 * somP.h: New file for use by som-high.c, som-low.c.
11770 * q2c.c: Added definition for VME.
11771 (get_line) Now dumps `!' comment lines to the output file
11774 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11775 set.q: Changed format of `!' comment lines.
11777 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11779 * All source files: Added copyright notice.
11781 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11782 longs in msg() calls.
11784 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11786 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11788 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11790 * output.c: (outp_read_devices) Changed criteria for
11791 distinguishing different types of lines.
11793 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11795 * cmdline.c: Changed syntax message.
11797 * filename.c: (good_getcwd) Bug fix (?).
11798 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11800 (search_path) Appends DIR_SEPARATOR to directory name only if it
11801 does not already end with one.
11803 * glob.c: Checks STAT_PAGER envvar before PAGER.
11805 * output.c: Checks environment variables instead of just local
11808 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11810 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11811 when the pointer passed to the function was within the arena
11812 itself, so that it couldn't properly be set to NULL _after the
11815 * command.c: Re-enabled DISPLAY.
11817 * display.c: Rewritten to handle tables. Untested.
11819 * filename.c: (search_path) Fixed memory leak.
11821 * frequencies.q: (cmd_frequencies) Frees v_variables.
11822 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11823 (cleanup_freq_tab) New function to garbage collect.
11824 (dump_full) Elegantized.
11826 * main.c: New comment.
11828 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11830 * postscript.c: Comment fix.
11831 (release_fontmap, free_font_entry) New functions.
11832 (ps_init_driver) Sets free_font_entry() as the freefunc for
11833 hashtable `loaded'. Calls release_fontmap() when destroying a
11834 driver; also frees the output filename; also frees the
11835 ps_driver_ext block.
11836 (free_ps_encoding) Frees the filename as well as the encoding
11838 (output_encodings) Frees the line buffer and pops the msg-filename
11840 (read_fontmap) Frees the fontmap filename and the line buffer.
11841 (postopen, preclose) Misc. garbage collection fixes.
11842 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11843 to NULL; this fixes some output problems.
11844 (text) Handles TAG_NEWLINE. Untested.
11846 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11847 (som_set_string) Removed. All references changed to
11849 (som_set_text) Rewritten. New interface. More general.
11851 * som.h: Minor format changes.
11852 (struct som_value_cell) Removed; all references changed to
11854 (enums SOT_*) Changed.
11856 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11858 * command.c: Re-enabled SPLIT FILE.
11860 * postscript.c: Comment fix.
11862 * som.h: Added `SOT_NONE'.
11864 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11866 * vfm.c: (dump_splits) Reimplemented.
11868 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11870 * Compiled the project under gcc 2.7.2, which gave some new
11871 warnings. This led to many additions of casts from unsigned to
11872 int sprinkled throughout the code.
11874 * arena.c: Many uses of `unsigned' changed to `size_t'.
11876 * command.c: Added END FILE, END REPEAT to command table.
11877 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11878 (find_command, FILE_TYPE_okay) Not commented out anymore.
11879 (parse_cmd) Calls FILE_TYPE_okay again.
11880 (output_line) Added calls to som_output_text() to put the line
11881 in the output files.
11883 * common.c: (macro VME) Format changes.
11884 (xstrdup) Asserts that its argument is not NULL.
11886 * data-list.c: Implemented dump_fixed_table().
11888 * inpt-pgm.c: Formatting changes. Comment changes.
11889 (end_case_proc) Renamed end_case_trns_proc.
11890 (cmd_end_file, end_file_trns_proc) New functions.
11892 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11894 * misc.h: (local_strdup) New macro corresponding to strdup() but
11895 allocating its data through local_alloc() if possible--that is, if
11898 * postscript.c: Comment changes.
11899 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11900 (output_line, add_string) New macros supporting
11901 output_encodings().
11902 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11903 substitution vars. Calls output_encodings() when a line
11904 consisting of `!encodings' is encountered.
11905 (preclose) Some code moved into quote_ps_string().
11906 (dump_line) Changed into macro supporting dump_fancy_line().
11907 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11908 command when appropriate.
11909 (write_text) Fixed `literal_char' array (I think it's fixed, at
11911 (text) Fixed bug when width was zero. Now exits immediately on
11912 zero height_left. Now, when executing `goto restart;', checks
11913 that cp<end, so that we don't read beyond end-of-string. Also,
11914 outputs the correct code to the output file by outputting the code
11915 from the metric instead of the internal metric index.
11917 * repeat.c: (cmd_end_repeat) New function.
11919 * som.c: (var som) `headers' renamed `options' and semantics
11920 changed. All references changed.
11921 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11922 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11924 (som_text_table) Removed.
11925 (som_output_text) New function.
11927 * som.h: (struct som_submission_form) Removed `header', `reuse',
11928 replaced with bitmapped field `options'.
11929 (SOM_TOPT_*) New enum set for som_submission_form.options.
11930 (SOT_*) New enum set for som_output_text().
11932 * temporary.c: (copy_variable) When copying the var label, only
11933 calls xstrdup() if it's non-NULL.
11935 * var.h: (enum type `vartype') Removed; all references changed to
11938 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11941 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11943 * font.h: Comment changes.
11945 * groff-font.c: (groff_read_font) Initializes `name' field to
11946 NULL. Handles `encoding' field.
11948 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11950 * postscript.c: (struct font_entry) Removed `position' field.
11951 (struct ps_font_combo) New struct.
11952 (struct ps_driver_ext) Removed field `next_position'. New fields
11953 `combos', `next_combo'. `last_font' field changed from
11954 `font_entry *' to `ps_font_combo *'.
11955 (ps_init_driver) Reformatted; handles new fields. When
11956 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11958 (get_encoding, find_encoding_file) New functions.
11959 (add_encoding) Some code moved out into find_encoding_file().
11960 (postopen) Changed value for ${title}.
11961 (preclose) Sets `loaded' field to NULL after destroying the hash
11963 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11965 (ps_text_set_font_by_position) Figures out the current family if
11967 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11968 (switch_font) Implemented.
11969 (write_text) Calls switch_font() more often. Format changes.
11970 #undefs its macros after they're no longer useful.
11971 (text) Changed `continue' at one point to a jump to the top of the
11972 loop because we don't want `separate' reset to 0 at that point.
11973 (load_font) No longer sets `position' in the font_entry created.
11975 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11977 * font.h: (struct font_desc) New member `encoding', which is not
11978 properly handled yet.
11980 * glob.c: (init_glob) Some new i18n code, which is probably
11983 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11984 `size' local from `int' to `size_t'.
11986 * postscript.c: New driver configuration parameter `auto-encode'.
11987 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11988 (struct font_entry) New member `position'.
11989 (struct ps_driver_ext) Reordered. New hash table member
11990 `encodings'; new members `next_position', `next_encoding',
11991 `last_font'. Members `current', `prop', `fixed' changed from type
11992 `font_desc *' to `font_entry *'; all references changed.
11993 (struct ps_encoding) New struct.
11994 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11995 free_ps_encoding, add_encoding) New functions.
11996 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11997 x->output_options. Initializes new members of ps_driver_ext.
11998 Changed default value for prologue_fn, encoding_fn. Calls
11999 read_ps_encodings after loading default fonts.
12000 (option_tab[], ps_option) Handle new configuration parameter.
12001 (switch_font) New function.
12002 (struct output_char) `font' member changed from `font_desc *' to
12003 `font_entry *'. New member `separate'.
12004 (read_fontmap) Changed `size' from `int' to `size_t'.
12005 (output_line, put_number) New macros for write_text().
12006 (write_text) Optimizes text output by consolidating multiple
12007 calls to PostScript `show' operator.
12008 (text) Keeps track of when text arguments can't be consolidated by
12009 write_text(), and marks those spots in the output stream.
12010 (load_font) Sets `position' of the allocated font_entry to -1, cuz
12011 the font hasn't been switched to by switch_font(), which is where
12012 the position is important--the PostScript is what cares about the
12015 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
12017 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
12018 call a NULL free_func.
12019 (hsh_rehash) Elegantized.
12020 (hsh_probe) Fix bug that manifested when the table was expanded
12021 and thus had to change location in memory. Good thing
12022 too--otherwise could have been much more subtle.
12023 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
12024 (hsh_foreach) New function for hash table iteration.
12026 * hash.h: (struct hsh_iterator) New.
12028 * lexer.c: (parse_tagged_quote) Font and family name strings in
12029 tags are now null-terminated.
12031 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
12033 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
12034 documented. (Never before tested?)
12036 * output.h: Comment changes.
12038 * postscript.c: New driver options `optimize-text-size',
12039 `optimize-line-size', `max-fonts-simult'. New enum set for
12040 specing cached line types. Comment fixes.
12041 (struct line_form) New struct.
12042 (struct ps_driver_struct) New members `text_opt', `line_opt',
12043 `max_fonts', `lines'.
12044 (ps_init_driver) Initializes new members of ps_driver_struct.
12045 (user option type enum set) New member `nonneg_int_arg'.
12046 (static var option_tab[]) Supports new options.
12047 (ps_option) Handles new options.
12048 (find_ps_file) Made static. No longer calls hsh_dump().
12049 (ps_get_var) Made static.
12050 (preclose) Dumps out proper DSC trailer.
12051 (ps_open_page) Elegantized.
12052 (ps_close_page) Calls dump_lines() if appropriate.
12053 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
12054 wrappers around line().
12055 (int_2_compare, compare_line, dump_line, dump_fancy_line,
12056 dump_lines, hash_line, free_line, line) New functions for support
12058 (write_text, text) Made static.
12059 (text) Added to font support, not finished.
12061 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
12063 * font.h: (struct font_desc) New members ascent, descent.
12065 * groff-font.c: (groff_read_font) Calculates font ascent and
12066 descent from the ascent and descent of the `d' and `p' characters,
12067 respectively, as per a suggestion on comp.fonts.
12069 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
12070 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
12072 (write_text) Handles text right-justification and centering (not
12073 full justification). Still very inefficient. (One output line
12075 (struct output_char) Added fields for font and font size.
12076 (text) Many bugfixes.
12078 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
12080 * cmdline.c: (usage) Calls outp_list_classes().
12082 * font.h: Comment fix.
12084 * groff-font.c: New exported global var `space_index'.
12085 (groff_init) New function to initialize `space_index'.
12086 (hash_kern) Casts result to unsigned.
12087 (font_name_to_index) Renamed font_char_name_to_index. All
12088 references changed. Also, now returns the value of `space_index'
12089 when passed an ASCII space character as an argument. Fixed
12091 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
12092 Handles passed NULL pointers properly.
12094 * lexer.c: (parse_tagged_quote) Comment fix. Better range
12097 * output.c: (outp_list_drivers) Removed. Removed all references.
12099 * output.h: Comment fixes.
12101 * postscript.c: (ps_open_global) Calls groff_init().
12102 (output_char) New structure.
12103 (write_text) New function.
12104 (text) No longer stubbed out! Now the output is correct--with a
12105 few exceptions, one of them being that the page has to be held
12106 upside down into a mirror.
12108 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
12110 * font.h: Comment fix.
12112 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
12113 All callers changed.
12114 (number_to_index) Renamed font_number_to_index, made extern. All
12116 (font_get_kern_adjust, font_get_char_metrics) New functions.
12118 * output.h: New constant OUTP_T_INTERNAL_DRAW.
12120 * postscript.c: Changed default line width back to 1/2 point.
12121 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
12122 in the center of the space allotted for them, not just a fixed
12123 offset from the edge of the space; this fixes some bugs.
12124 (ps_line_intersection) Now supports all command line styles.
12125 (ps_text_get_size) Bug fix in computation of em width.
12126 (text) New function, the meat behind ps_text_metrics and
12127 ps_text_draw. Not complete.
12128 (ps_text_metrics, ps_text_draw) Removed the stub taken from
12129 ascii.c; call text().
12131 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
12133 * arena.c: (arena_free) Assert that the argument is non-NULL.
12135 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
12136 only if old_kern is non-NULL.
12138 * postscript.c: (ps_init_driver) Changed default line width to 1
12140 (postopen) New prologue variables.
12141 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
12142 more of the common line styles properly, but not all.
12143 (ps_text_metrics) Fixed problem with this stubbed out version that
12144 kept it from taking font sizes into account.
12146 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
12148 * arena.c: (arena_malloc) Bug fix.
12149 (arena_dump) [GLOBAL_DEBUGGING] New function.
12151 * ascii.c: Comment fix.
12152 (count_fancy_chars, delineate) Now static functions.
12154 * filename.c: (interp_vars) Bug fixes.
12156 * font.h: Comment fixes.
12158 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
12159 beginning in case we have an error message to display before
12160 initializing the display.
12162 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
12164 (groff_read_font) Bug fixes.
12165 (name_to_index) Increments hash.used. Sets `name' field of hash
12167 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
12169 * hash.c: Return type changed.
12171 * postscript.c: Continued development. Now marks lines on the
12172 paper, but very buggy.
12174 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
12176 * Changed comments in many source files from `/* xxx /* yyy */' to
12177 `/* xxx */ /* yyy */' for cleanliness.
12179 * arena.c: (arena_sd_strdup) New function.
12181 * ascii.c: (struct ascii_driver_ext) New member `file'.
12182 (ascii_init_driver) Fills out member `file' for initing; uses
12183 close_file_ext for closing drivers.
12184 (ascii_option) Changed %.*s back to %s because the a_string's are
12185 always null-terminated.
12186 (postopen, preclose) New functions.
12187 (ascii_open_page) Uses new style of open_file_ext.
12188 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
12189 instead of this->output.
12190 (__assert_fail) Removed.
12192 * cmdline.c: Changed syntax_message[].
12194 * error.c: #include's <readline/history.h> only if the history
12195 library is available, not if just the readline library is
12198 * filename.c: (expand_line) Removed alloca() support.
12199 (interp_vars) No longer tilde-expands argument. Limit on output
12201 (tilde_expand) Now treats argument as path rather than filename.
12202 [!unix] Now is a no-op function.
12203 (search_path) Better verbose message formatting.
12204 (open_file, close_file) Comment fixes.
12205 (close_file) [!unix] Doesn't bother with pipes.
12206 (open_file_ext) Completely rewritten, interface revamped.
12207 (close_file_ext) New function.
12209 * font.h: Comment changes.
12211 * frequencies.q: Removed AIX alloca support since it doesn't use
12214 * hash.c: Comment changes & additions.
12215 (hsh_create) Initializes entire table instead of first M entries.
12216 (hsh_probe) Stupid bug fixed. Now it works.
12217 (hsh_dump) [GLOBAL_DEBUGGING] New function.
12219 * main.c: (parse) Detects EOF properly in token-eating loop.
12220 Should the STOP token have its value changed to 0?
12222 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12223 (blp_getline) Now it's a macro.
12225 * output.h: (struct outp_driver) Removed members output, filename.
12227 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12228 drivers in driver table.
12229 (outp_read_devices) Frees buf. Warns if there are no active
12231 (outp_configure_clear) Sets outp_configure_vec to NULL after
12232 deleting its elements.
12233 (configure_driver, destroy_driver) Removed references to output,
12234 filename members of outp_driver.
12235 (outp_evaluate_dimension, internal_get_paper_size,
12236 outp_get_paper_size) New functions.
12238 * postscript.c: Continued development. Now links but doesn't make
12239 any marks on the page. Lotsa bugs I suppose.
12241 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12243 * str.h: Comment changes.
12245 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12247 * Removed dependencies on non-nested comments in several files.
12248 Also removed references to (unix || __unix__) in #if's since
12249 prefh.orig makes those two equivalent.
12251 * ascii.c: (ascii_open_global) Creates ascii_arena.
12252 (ascii_close_global) Destroys ascii_arena.
12253 (ascii_init_driver) Doesn't create ascii_arena.
12254 (ascii_copy_driver) Removed.
12255 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12256 (outp_class ascii_class) Removed ascii_copy_driver reference.
12258 * frequencies.q: Now can display all statistics except median.
12259 Still not finished.
12261 * output.c: Handles outp_class.ref_count so output class
12262 destructors are called properly.
12263 (add_class) Sets ref_count to 0.
12264 (configure_driver) Initializes class if ref_count++ is 0.
12265 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12266 class output file name.
12268 * output.h: (struct outp_class) Removed copy_driver, inited.
12271 * postscript.c: Completely replaced but not finished.
12273 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12275 * approx.h: #includes <float.h>.
12277 * arena.h, arena.c: Many functions changed to take an arena **
12278 instead of an arena *, for consistency. All callers changed.
12279 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12280 (arena_destroy) Sets *A to NULL.
12282 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12283 assertion that `width' be positive.
12285 * command.c: Removed #if's from cmd_table.
12286 (walk_cmdtable_func) [0] New function (debug code).
12287 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12288 (parse_cmd) Doesn't return failure for unimplemented commands.
12290 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12291 (SYSCODE) New constant macro.
12293 * descript.q: Checks for positive n_variables before performing
12296 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12297 avl_find instead of &fp as arg 2.
12299 * frequencies.g, frequencies.q: Continued updating; now compiles &
12300 works again, but not complete.
12302 * main.c: Changes to user messages.
12304 * misc.c: (reverse) [0] New function.
12306 * settings.h: Comment removed. #includes "common.h".
12308 * som.c: (som_set_null) New function.
12309 (som_set_value, som_set_string, som_set_text) More detailing
12311 (som_set_float) Implemented function.
12312 (dump_columnated_table) Bug fix regarding page breaks.
12313 (draw_cell) Bug fix regarding text that spilled out of a cell.
12314 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12316 (get_cell_size) Support SCON_EMPTY cells.
12317 (get_table_size) When calculating rules' widths and heights, mask
12318 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12320 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12322 (struct som_submission_form) New member `header'; all users
12325 * val-labs.c: (get_label) User messages changed.
12327 * var.h: Changed FREQUENCIES structures.
12329 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12332 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12334 * approx.h: Definition of EPSILON now depends on system's
12335 DBL_EPSILON. Removed GNU C specific code.
12336 (cmpapx) Renamed approx_compare.
12338 * frequencies.g, frequencies.q: Continued updating; still doesn't
12341 * groff-font.c: (name_to_index) Fix bug that kept it from
12344 * hash.c, hash.h: Completed work.
12346 * var.h: Changes to freq_tab, frequencies_proc.
12348 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12351 * hash.c, hash.h: New files. Not completed.
12352 * Makefile.am: Added hash.c to source file list.
12353 * font.h: (struct font_desc) New member kern_size_p.
12354 * groff-font.c: Uses hash.h.
12355 (hashpjw) Moved to hash.c.
12356 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12358 (static var hash) New member size_p.
12359 * var.h: Includes hash.h.
12360 (struct freq_tab) Changed AVL_TREE to hash_tab.
12362 * vars-prs.c: Comment, formatting fixes.
12364 * frequencies.g, frequencies.q: Continued updating. Not yet
12367 * formats.c: Bug fix.
12369 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12371 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12372 * descript.g: Comment fixes.
12373 * descript.q: Comment fixes. Moved some declarations into var.h.
12374 Made dsc_info a static table. Updated FIXMEs.
12375 (internal_cmd_descriptives) Beautified.
12377 * frequencies.q: Started updating into working order.
12378 * frequencies.g: New file analogous to descript.g.
12379 * var.h: Comment fixes. Added structures for FREQUENCIES.
12381 * som.c: Removed vestiges of crushing and partial table support.
12383 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12385 * Many more changes to som.c especially, but these will not be
12386 documented as I have resolved to remove them. This patchlevel is
12387 being released solely so that I can fall back to it if I decide
12388 that removing the changes is not a good idea.
12390 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12392 * som.c: (global var som) New member `cum_y'.
12393 (build_target) Properly handles titles for partial tables.
12394 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12395 Merged into single new function dump_partial(). Fixed problem
12396 with titles on partial tables.
12397 (dump_table) Calls dump_partial() for all parts of partial tables.
12398 (dump_page) Criteria for drawing title changed.
12400 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12402 * command.c: (cmd_table) Added LIST, WEIGHT.
12404 * command.c: (cmd_remark) No longer frees `s' since it's not
12405 dynamically allocated.
12407 * data-out.c: (convert_f) Now correctly handles the case where
12408 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12409 number of decimals.
12410 (som_destroy_all_tables) Removed argument. All callers changed.
12411 (som_vline, som_hline) Argument validity checking corrected.
12412 (som_set_value) Implemented half-heartedly.
12413 (replicate_table) Copies tables piece-by-piece when using Checker.
12415 * som.h: New line style SLIN_1THIN, currently equivalent to
12416 SLIN_0. New enum set SOM_SUB_*.
12417 (struct som_submission_form) Removed `seq_no'. Added `type'.
12419 * list.q: Newly working file; uses partial tables.
12421 * som.c: (som_reduce_table) Renamed som_set_table_height().
12422 (som_crush) Removed argument `group'.
12423 (global var som) Removed `nt', `seq_no'. Added `type'.
12424 (som_submit_table) Arguments changed.
12425 (output_table) Removed partial table code.
12426 (build_target) New arg; partial table support added. All callers
12428 (dump_plain_table) Removed partial table code.
12429 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12430 (dump_table) Supports partial tables.
12431 (dump_page) New argument to allow not drawing top and/or bottom
12432 headers. All callers changed. Supports partial tables.
12434 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12436 * data-out.c: Changed `#include <approx.h>' to `#include
12438 (convert_F) Comment fix. Now won't print `-.000', etc.
12440 * descript.q: Now Z-scores work, although there appears to
12441 be a bug (which might actually be in data-out.c:convert_F()).
12442 (descriptives_trns_proc, descriptives_trns_free) New functions.
12443 (run_z_pass) Implemented.
12445 * var.h: Comment fixes.
12446 (dsc_z_score, descriptives_trns) New structs.
12447 (descriptives_trns) Added to any_trns as `dsc'.
12449 * error.c, error.h: New error class, IS (Installation Script
12450 error), used in those instances where the error is in the
12451 installation, but there is a script file or installation file that
12452 can be usefully referred to.
12454 * output.c: Change many IE classes to IS classes.
12456 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12457 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12458 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12459 include the corresponding header?
12461 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12462 Don't bail out if termcap can't be read.
12464 * som.c: (som_destroy_table) Removed.
12465 (som_reduce_table, som_destroy_all_tables) New functions.
12466 (som_crush) New function, not implemented.
12468 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12469 som_submission_form. Function prototypes revised.
12471 Outputting huge tables (1000s of rows) a few rows at a time
12472 is supported, though untested. May even break everything.
12473 Actually, the code doesn't even compile right now.
12474 * som.c: (struct som) New fields htv, nt, seq_no.
12475 (som_submit_table) Multiple arguments changed to a single
12476 pointer to struct submission_form. Only increments subtable_num
12477 if seq_no is zero. Only destroys table if it's not going to
12479 (replicate_table) New function.
12480 (output_table) Comment fix.
12481 (examine_table) Changed inline code to code calling
12482 replicate_table(). Calculates htv. Supports partial tables.
12483 (draw_title) Removed comment.
12484 (build_target) Only allows for title on first part of partial
12486 (dump_plain_table) Only resets table chunk number on first part
12487 of partial tables; FIXME: doesn't work quite right. Supports
12489 (dump_page) Titles only on first part of partial tables.
12491 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12493 * Thanks to an unreliable IDE hard drive, I have spent the last
12494 day reconstructing my Debian GNU/Linux installation and redoing
12495 the previous day's changes--somehow I managed to save every file
12496 except for output.c and output.h. So the following changes could
12497 really be considered independent of the output.c, output.h changes
12500 * output.h, output.c: Moved the outp_configure_vec global var,
12501 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12502 outp_configure_vec is now static.
12504 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12506 * The entire philosophy behind configuration of the output drivers
12507 changed. Now there is a termcap-type configuration where drivers
12508 to be read are determined beforehand, rather than parsing the
12509 entire output init file and storing it in memory & deciding what
12510 to actually use later. Faster & more memory-efficient at the same
12513 * output.c: Comment fix. Removed outp_init_drivers global var.
12514 Removed all references to synonyms. New structure outp_defn. New
12515 global vars outp_macros, outp_configure_vec.
12516 (search_name, delete_name, add_name, check_configure_vec,
12517 expand_name, find_defn_value) New static functions.
12518 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12519 outp_read_devices) New extern functions.
12520 (outp_init) Much functionality moved into outp_read_devices.
12521 (outp_read_devices) Format of output init file changed; name of
12522 file is `devices' rather than `output' to avoid Makefile
12524 (outp_clear) Renamed outp_done.
12525 (outp_list_classes) Bug fix, cleaned up.
12526 (outp_list_drivers) Not implemented anymore.
12527 (outp_configure_driver) Now a static function; simplified; now
12528 interpolates macros; supports new structure.
12529 (outp_enable_driver, match_synonym) Removed; all references
12531 (find_driver) First argument removed.
12533 * output.h: Global var outp_init_drivers removed; new structure
12534 outp_names; new enum set OUTP_S_*; new global var
12535 outp_configure_vec; function prototypes for output.c exports
12538 * main.c: (main) Calls outp_read_devices() after parsing the
12541 * cmdline.c: (parse_command_line) New option -v --verbose;
12542 --version changed to -V. --device option changed syntax to just
12543 take a single device name. Accepts key=value declaration of
12544 output init file macros. Syntax message updated.
12546 * filename.c: (expand_line) New function.
12547 (interp_environ_vars) Renamed interp_vars; no longer uses
12549 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12550 overridden by real environment vars.
12551 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12552 * filename.h: interp_environ_vars() renamed interp_vars().
12554 * error.c, error.h: Added extern variable `verbosity', message
12557 * error.c: (vmsg) Support message class MM.
12558 (verbose_msg) New function.
12560 * descript.q: (generate_z_varname) Bug fix in generation of
12562 (dump_z_table) Bug fix in column headers.
12564 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12565 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12566 OPS_DONE]. Writes the uninit string when the driver is closed.
12567 (ascii_open_page) Write the init string before the first page.
12568 (output_shorts) Form of main loop changed from `while' to `for'.
12569 Bug fix with overstrikes: the character is printed *after* the
12570 backspace. Eliminated a lot of `& 0xff' modifiers.
12571 (advance_to_left_margin) New function.
12572 (return_carriage, output_lines) Handle left margin.
12574 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12576 * ascii.c: New option `carriage-return-style'.
12578 * ascii.c: (count_fancy_chars) New function.
12579 (delineate, text_metrics) Use new function; bug fixes regarding
12581 (text_draw) Bug fix with rich text.
12582 (output_string, output_shorts) Reordered.
12583 (output_shorts) Now handles boxchars and some overstrike font
12585 (output_char, return_carriage) New functions.
12586 (output_lines) Now handles overstriking and font changes properly;
12587 some code moved to output_shorts.
12589 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12592 * ascii.c: New member `debug' in ascii_driver_ext.
12593 (ascii_init_driver, delineate) Uses new member.
12595 Now you can set a vertical height on writing text.
12596 * ascii.c: (delineate) Keeps track of vertical position.
12597 (text_draw) No longer considers fully justified text an internal
12600 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12602 Tables' titles are drawn; they can have variable height.
12603 * som.c: `som' struct has new member, title_height.
12604 (draw_title) New argument. Moved within file. All caller
12606 (build_target) New argument, amount of space needed for first row.
12607 Calculates height of title, takes that into account. All callers
12609 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12611 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12613 (dump_columnated_table) Organized for readability.
12614 (dump_page) Makes use of som.title_height.
12616 * som.c: Many comment bug fixes.
12618 * descript.q: (try_name, generate_z_name) Bug fix regarding
12619 generation of Z-score variable names.
12620 * var.h: Removed num from descriptives_proc; all referents removed.
12622 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12624 * ascii.c: (ascii_line_horz, ascii_line_vert,
12625 ascii_line_intersection) Added debugging code.
12627 Added a descriptive line above each table to describe it.
12628 * command.c: (parse_cmd) Calls som_new_series.
12630 * som.c: New static vars table_num, subtable_num. New `som'
12632 (dump_page) New arguments.
12633 (som_submit_table) Handle new variables.
12635 * som.c, som.h: (som_submit_table) New arguments. All callers
12637 (som_new_series) New function.
12638 (build_target) Makes room for extra line.
12639 (draw_title) New function.
12640 (dump_page) Calls draw_title. Bug fix: doesn't always set
12643 Columnation of tables support.
12644 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12646 * som.c: Deleted references to fr, lr, ri.
12647 (som_columnate) Bux fix: sets group member of table.
12648 (som_add_options) Function removed.
12649 (dump_table) Split into three functions; extensively reworked.
12651 * descript.q: (dump_z_table) Better output table formatting; added
12652 title support to correspond to som.h changes.
12653 (display) Title support.
12655 * output.h: Added OUTP_T_NONE.
12657 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12659 * descript.q: Improved handling of Z scores; still not perfect.
12661 * output.h, ascii.c: Added hook for getting em width of current
12664 * som.c: Uses new em-width hook. Added debugging code to
12666 (som_columnate) New argument.
12667 (som_add_options) Removed.
12669 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12671 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12672 rules as a property of the table instead of as a property of the
12675 * ascii.c: Added `header' to table of options.
12677 * descript.q: Added even shorter statistic names; modified to work
12678 with new som interface.
12680 * misc.c (blp_getdelim): Bug fix.
12682 * version.c: includes 'conf.h'.
12684 ----------------------------------------------------------------------
12687 version-control: never
projects / pspp-builds.git / blob