1 Mon Oct 24 13:42:32 WST 2005 John Darrington <john@darrington.wattle.id.au>
3 Moved some definitions to make it easier to abstract a dictionary
6 * format-prs.c lex-def.[ch]: New files.
8 * Makefile.am lexer.[ch] dictionary.c vars-atr.c vfm.c algorithm.c
9 format.c: Moved some functions between modules.
11 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
13 Work to get rid of GCC 4.0 warnings, part 1.
15 In many files, change count parameters to parse_variables(),
16 etc. from `int' to `size_t'. Also change related variables and
17 struct members. Also change messages as needed (e.g. %d to %u
18 with cast to unsigned). Also change arithmetic as necessary
19 (e.g. n >= m - 1 to n + 1 >= m).
21 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
24 * q2c.c: (dump_declarations) Generate code for size_t instead of
27 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
29 * output.c: (outp_read_devices) Fix message.
31 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
33 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
34 address is passed to dict_get_vars() from size_t to int to match
37 * modify-vars.c: (validate_var_modification) Ditto.
39 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
41 * dictionary.[ch] Changed cnt from size_t* to int* since that's
42 what it's called as, and on x86_64 machines they're different sizes.
44 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
46 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
48 * lexer.c: (lex_sbc_only_once) New function.
49 (lex_sbc_missing) New function.
51 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
53 * case.h: (case_str) Make it return `unsigned char'.
55 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
57 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
58 subcommands that we didn't support. Fix bug 13911. Fix bug
59 reported by Adam Pierson (COMPRESSED and other subcommands didn't
60 work on SAVE). Refactor all related code.
62 * command.def: Add XEXPORT command.
64 * dictionary.c: (dict_delete_scratch_vars) New function.
66 * get.c: (cmd_get) Fix parsing.
67 (struct save_trns) Removed.
68 (cmd_save_internal) Removed.
70 (do_write_case) Removed.
71 (save_write_case_func) Removed.
72 (save_trns_proc) Removed.
73 (save_trns_free) Removed.
74 (trim_dictionary) Removed.
75 (struct export_proc) Removed.
77 (export_write_case_func) Removed.
78 (export_proc_free) Removed.
79 (enum writer_type) New enum.
80 (enum command_type) New enum.
81 (struct any_writer) New struct.
82 (any_writer_destroy) New function.
83 (parse_write_command) New function.
84 (any_writer_write_case) New function.
85 (parse_output_proc) New function.
86 (output_proc) New function.
89 (struct output_trns) New struct.
90 (parse_output_trns) New function.
91 (output_trns_proc) New function.
92 (output_trns_free) New function.
94 (cmd_xexport) New function.
95 (parse_dict_trim) New function.
96 (struct mtf_proc) Change `by_cnt' member type to `int'.
99 * pfm-write.c: (struct pfm_writer) Add `digits' member.
100 (pfm_writer_default_options) New function.
101 (pfm_open_writer) Add `opts' argument and handle options.
102 (write_float) Write only as many digits as `digits' member says.
103 (format_trig_double) Limit base-10 precision to LDBL_DIG.
105 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
106 (struct pfm_write_options) New struct.
108 * sfm-write.c: (sfm_writer_default_options) New function.
109 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
110 `opts' argument. Implement options.
112 * sfm-write.h: (struct sfm_write_options) New struct.
114 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
115 char *' instead of `char *'.
117 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
119 * factor_stats.c: Needed <config.h> included earlier.
121 * percentiles.c: Needed to include <config.h>.
123 * val.h: Don't include "config.h".
125 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
127 Clean up treatment of missing values by moving all the code into
128 one place. All references to the missing value function were
129 updated, but only major changes are detailed below.
131 * Makefile.am: Add missing-values.c, missing-values.h to sources.
133 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
135 * dictionary.c: (dict_create_var) Initialize `miss' member with
137 (dict_clone_var) Copy `miss' member with mv_copy().
139 * get.c: (mtf_merge_dictionary) Use mv_copy().
141 * missing-values.c: New file.
143 * missing-values.h: New file.
145 * mis-val.c: Rewrite. New version implements updated semantics.
147 * pfm-read.c: (read_variables) Rewrite missing value handling.
149 * pfm-write.c: (write_variables) Rewrite missing value handling.
151 * sfm-read.c: (read_variables) Rewrite missing value handling.
153 * sfm-write.c: (write_variable) Rewrite missing value handling.
155 * sfmP.h: Include "magic.h" to get definition of
158 * sysfile-info.c: (describe_variable) Rewrite missing value
161 * val.h: Include "magic.h" to get definition of
164 * var.h: Include "missing-values.h". Drop MISSING_* enums.
165 (struct variable) Remove `miss_type', `missing'. Add `miss'.
167 * vars-atr.c: (is_num_user_missing) Removed--use
168 mv_is_num_user_missing().
169 (is_str_user_missing) Removed--use mv_is_str_user_missing().
170 (is_system_missing) Removed--use mv_is_value_system_missing().
171 (is_missing) Removed--use mv_is_value_missing().
172 (is_user_missing) Removed--use mv_is_value_user_missing().
174 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
176 Adopt use of gnulib for portability.
178 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
181 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
182 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
185 * In many source files, added an explicit inclusion of gettext.h
186 and definition of _ macro. These are no longer in pref.h because
187 it interfered with definitions in a few gnulib source files.
189 * In many source files, changed #include "bool.h" to #include
190 <stdbool.h>, which is provided by gnulib.
192 * alloc.c: Removed functions defined in gnulib:
197 (out_of_memory) Redefined as wrapper for xalloc_die().
199 * alloc.h: Replace prototypes by #include "xalloc.h".
201 * casefile.c: Use full_read() and full_write() from gnulib instead
202 of our home-grown versions.
204 (full_write) Removed.
206 * getline.c: Renamed getl.c.
208 * getline.h: Renamed getl.h, updated all references.
210 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
213 * glob.c: Just #include <time.h> instead of the crazy rigmarole
215 (init_glob) Call set_program_name() to initial gnulib progname
218 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
220 * permissions.c: Use "stat-macros.h" from gnulib.
222 * postscript.c: Just #include <time.h> instead of the crazy
223 rigmarole here before.
225 * q2c.c: (main) Make generated code #include "gettext.h".
227 * str.h: Get rid of most explicit declarations of standard
228 functions, in favor of including gnulib header files.
230 * expressions/evaluate.c: Ditto.
232 * expressions/operations.h.pl: Make generated code #include
233 <stdbool.h>, not "bool.h".
235 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
237 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
240 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
242 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
243 null pointer to printf for %.*s.
245 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
247 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
250 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
252 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
254 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
256 * postscript.c: (postopen) Cast `char' to `unsigned char' before
257 passing to isspace().
259 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
261 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
263 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
265 * histogram.c: Include <config.h>.
267 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
269 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
271 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
273 * format.c: (check_common_specifier) Fix msg() bug found by
275 (check_output_specifier) Ditto.
277 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
279 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
282 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
284 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
285 avoid "unused variable" warning.
287 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
289 * command.c: (find_word) Cast `char' to `unsigned char' before
290 passing to isspace().
292 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
294 * case.c: (case_compare) Implement as delegating to
295 case_compare_2dict().
297 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
299 * algorithm.c: Inclusion of <alloca.h> is unneeded.
301 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
303 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
304 -ansi changes the behavior of header files significantly. It
305 causes __STRICT_ANSI__ to be defined, and some headers interpret
306 that as cause to e.g. not use `long long' or __attribute__. The
307 former example is bad when off_t is supposed to be `long long',
308 and the latter prevents -Wformat from working.
310 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
312 Get rid of dependency on libgmp by writing our own routine for
313 floating-point base conversion.
315 * pfm-write.c: (write_float) Rewrote.
317 (pow30_nonnegative) New function.
318 (pow30) New function.
319 (trig_to_char) New function.
320 (format_trig_digits) New function.
321 (recurse_format_trig_int) New function.
322 (format_trig_int) New function.
323 (should_round_up) New function.
324 (try_round_up) New function.
325 (format_trig_double) New function.
327 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
329 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
332 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
334 * pfm-read.c: (read_version_data) Read and ignore author field.
336 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
338 * get.c: (mtf_processing) Don't assume that
339 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
340 returns a negative, zero, or positive result. Fixes MATCH FILES
341 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
343 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
345 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
346 preprocessor test for sys/types.h was accidentally inverted. This
349 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
351 * get.c: (cmd_match_files) Fix memory leak on `by' and on
354 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
357 * vfm.c: (close_active_file) Remove unnecessary test.
359 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
361 Fix NDEBUG compile errors.
363 * hash.h: Needed explicit #include <assert.h>.
365 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
368 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
370 Implement embedding for PostScript driver. Fixes bug 12970.
372 * ascii.c: Fix compiler warnings.
376 * chart.h: Add `file' member.
378 * output.h: (struct outp_class) initialise_chart, finalise_chart
379 should take outp_driver *, not outp_class *. Update all
382 * plot-chart.c: (chart_create) Fix segfault when there are no
383 output drivers at all.
384 (chart_submit) Call d->class->finalise_chart.
386 * postscript.c: (ps_open_page) Set cp_y to 0.
387 (ps_submit) New function.
388 (ps_chart_initialise) Implement.
389 (ps_chart_finalise) Implement.
390 (static var postscript_class) Add ps_submit.
391 (static var epsf_class) Add ps_submit.
394 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
396 Did some more work on bug 12859 and then realized that a *good*
397 solution would require some fundamental restructuring. For now,
398 I'm marking REPEATING DATA unimplemented, and then we can revisit
401 * command.def: Make REPEATING DATA unimplemented.
403 * data-list.c: (cmd_repeating_data) Assume inline file is 80
405 (realize_value) Revert previous changes; no longer needed.
408 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
409 file_loc, to avoid bad references later.
413 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
415 Make some code tolerant of reentry. Should not be needed if other
416 code is correct but it is good to be generally tolerant.
418 * error.c: (err_hcf) Set file_loc to null after free().
420 * output.c: (outp_done) Similar changes.
422 * str.c: (ds_destroy) Ditto.
424 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
426 Continue work on bug 12859, plus some code cleanup.
428 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
429 boolean variables. Don't try to compute starts_end, cont_end for
430 inline file. Calculate length only after parsing variable
431 specifications. Add proper transformation to list.
432 (realize_value) If the rpd_num_or_var has no value, return new
433 DEFAULT_MEMBER argument (for use with inline file).
434 (repeating_data_trns_proc) Pass default values.
436 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
437 open, and only if we actually started reading data.
439 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
443 * output.c: (outp_read_devices) Fix message.
445 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
447 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
448 of the sort algorithm from the parser for the SORT command.
450 * rank.q: Added the parser for the RANK command.
452 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
456 * sort.c: (sort_parse_criteria) Only set *saw_direction if
457 saw_direction is non-null. Thanks to John Darrington for
460 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
462 * get.c: (mtf_processing) Handle case of a lookup table as the
463 active file. Thanks to John Darrington for reporting this bug.
465 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
467 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
468 POSIX calloc function.
470 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
471 reflect new signature.
473 * sfm-read.c: Now much more robust in the face of badly formed
476 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
478 *sfm-read.c: Fixed some bugs regarding long string continuation
479 records, which the previous fix uncovered.
481 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
483 * sfm-read.c, sfmP.h: Allow reading of system files when the
484 case_size value in the header is -1. Also changed some Errors to
485 Warnings when reading system files.
487 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
489 * data-list.c: (data_list_trns_free) Don't free the argument
490 because cancel_transformations() will do that itself.
491 (data_list_source_destroy) Destroy the argument to
492 data_list_trns_free(), because it no longer does so itself.
494 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
496 * data-out.c: (format_and_round) Don't output leading `-' if value
499 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
503 * som.c: (output_encodings) If some cell in the table won't fit
504 with the horizontal or vertical headers, cancel those headers.
506 * som.h: (struct som_table_class) Add fits_width, fits_length,
509 * tab.c: (tabi_fits_width) New function.
510 (tabi_fits_length) New function.
511 (tabi_set_headers) New function.
512 (global var tab_table_class) Add the new functions as appropriate
515 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
517 Fix rest of bug 13054.
519 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
520 DATETIME, TIME system/portable file values.
522 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
524 * data-list.c: (parse_free) Use make_input_format().
526 * data-out.c: (num_to_string) Use make_output_format().
528 * dictionary.c: (dict_create_var) Ditto.
530 * format.c: (global var f8_2) New var.
531 (make_input_format) New function.
532 (make_output_format) New function.
534 * get.c: (cmd_match_files) Use make_output_format().
536 * list.q: (cmd_list) Ditto.
538 * matrix-data.c: Ditto.
540 * sfm-read.c: (parse_format_spec) Check output specifier
543 * tab.c: (tab_float) Use make_output_format().
545 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
547 Fix more of bug 13054.
549 * format.def: FMT_A should allow 255-character output. FMT_AHEX
550 should allow 510-character input and output.
552 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
553 (convert_E) Handle non-finite values.
555 (format_and_round) New function.
556 (convert_infinite) New function used by try_F() and convert_E().
558 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
560 Regularize string and buffer function names so that they make some
563 * str.c: (mm_reverse) Rename buf_reverse(). Update all
565 (mm_find_reverse) Rename buf_find_reverse(). Update all
567 (mm_case_compare) Rename buf_compare_case(). Update all
569 (st_compare_pad) Rename buf_compare_rpad(). Update all
571 (str_compare_rpad) New function.
572 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
574 (buf_copy_str_lpad) New function.
575 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
577 (st_pad_copy) Rename str_copy_rpad(). Update all references.
578 (st_trim_copy) Rename str_copy_trunc(). Update all references.
579 (st_uppercase) Renamed str_uppercase(). Update all references.
581 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
583 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
586 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
588 * data-in.c: (data_in) Add assertion to check input specifier.
590 * data-out.c: (data_out) Add assertion to check output specifier.
592 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
594 Start to fix bug 13054.
596 * format.c: (check_input_specifier) Improve error message.
597 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
598 valid decimal places.
599 (check_output_specifier) Ditto (but different criteria).
600 (convert_fmt_ItoO) Assert valid input and output specifiers.
601 Also, if input specifier has *any* decimal places, make the output
602 specifier 1 place wider.
604 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
606 * sysfile-info.c: Fixed bug [# 13024 ]
608 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
610 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
611 actually implement it.
613 * command.c: (FILE_TYPE_okay) Always return 1.
615 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
617 * file-type.c: Add prototypes to get rid of warnings.
619 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
621 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
622 more ISO/IEC 9899:1990 conformance issues.
624 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
626 Fix bug 12948. See also new test in
627 tests/bugs/match-file-scratch.sh.
629 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
630 that deletes scratch variables that someone else might be using,
631 and because we can't reassign our sources' value indexes.
632 Instead, simply don't copy scratch variables into the master
635 * dictionary.c: (dict_compact_values) Delete variables from the
636 dictionary passed in, not from default_dict (!).
638 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
640 Improve hash.c comments, error-checking.
642 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
643 (hsh_create) size == 0 should *not* return NULL! Set
645 (hsh_clear) Set hash_ordered.
646 (locate_matching_entry) Check hash_ordered.
647 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
648 (hsh_data) Set hash_ordered. Add const-ness to return value and
652 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
654 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
656 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
658 * copyleft.c: Updated copyright date.
660 * Makefile.am: Removed erroneous explicit "-lplot"
662 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
664 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
666 * command.c command.def: Added description string for unimplemented commands.
668 * oneway.q: Sorted the hash tables before shipping out the results. Closes
671 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
675 * data-list.c: (parse_fixed) Use lex_end_of_command().
677 (cmd_repeating_data) Set cont_end.num in right situations.
678 (parse_repeating_data) Remove redundant test.
680 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
682 Partial fix for bug 12859.
684 * data-list.c: (cmd_data_list) Add transformation properly in
685 vfm_source == NULL case.
687 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
689 * lexer.c: (lex_error) Improve error messages.
691 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
693 * get.c: (cmd_match_files) Check token type before trying to match
694 tokid. Fixes bug 12923.
696 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
698 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
701 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
703 * expressions/generate.pl: (get_token) Make use of /g
704 backward-compatible with Perl 5.6.1.
706 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
708 * var-display.c: (cmd_variable_alignment) Fix memory leak.
709 (cmd_variable_level) Ditto.
711 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
713 Hash table had buggy deletion function. The fix required changing
714 other functions to do probing in the required order.
716 * hash.c: (locate_matching_entry) Rewrite and change interface.
717 (hsh_rehash) Rewrite to use locate_matching_entry().
720 (hsh_delete) Ditto. Also, fix stupid bugs.
722 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
724 * dictionary.c: (dict_clone) Properly copy vectors.
726 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
728 New implementation of long variable names. Each variable has a
729 "normal" name, which may be up to 64 bytes long and which is used
730 for all normal operations. Variables may have a "short" name,
731 which is limited to 8 bytes and used only for system and portable
732 file input and output.
734 Make tokid case-preserving. Update most uses of tokid to treat it
737 Update many commands to deal with long variable names.
739 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
741 * command.c: (cmd_parse) Ditto.
742 (match_strings) Use toupper() before comparing characters.
743 (conflicting_3char_prefixes) Use mm_case_compare() instead of
745 (cmd_match_words) Ditto.
747 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
750 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
751 Use st_trim_copy() instead of strcpy().
753 * data-in.c: (parse_enum) Use mm_case_compare() instead of
756 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
758 (parse_free) Use st_trim_copy() instead of strcpy().
760 * descript.c: (struct dsc_var) Change z_name[] to fit long var
762 (try_name) Use strcasecmp() instead of strcmp().
763 (generate_z_varname) Use st_trim_copy() instead of strcpy().
764 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
767 * dictionary.c: (struct dictionary) Removed `long_name_tab'
769 (compare_long_names) Removed.
770 (hash_long_name) Removed.
771 (dict_create) Don't initialize `long_name_tab' member.
772 (dict_clone) Copy short names into new dictionary.
773 (dict_clear) Don't clear `long_name_tab' member.
774 (dict_get_varname_block) Removed.
775 (dict_add_longvar_entry) Removed.
777 (dict_destroy) Don't destroy `long_name_tab' member.
778 (dict_create_var_from_short) Removed.
779 (dict_create_var_x) Removed.
780 (dict_create_var) Get rid of longname handling.
782 (dict_clone_var) Get rid of longname parameter and longname
784 (dict_lookup_var) Get rid of longname handling.
785 (dict_reorder_var) New function.
786 (dict_rename_var) Clear short name.
787 (dict_rename_vars) Get rid of longname handling. Clear short
789 (dict_create_vector) Support long vector names.
790 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
791 (quasi_base27) Removed.
792 (make_short_name) Removed.
793 (compare_strings) New function.
794 (hash_string) New function.
795 (dict_assign_short_names) New function.
797 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
799 (get_handle_for_filename) Support long handle names.
801 * file-type.c: (struct col_spec) Make `name' fit long var names.
802 (cmd_file_type) Use strcasecmp() instead of strcmp().
804 * flip.c: (make_new_var) Rewrite.
805 (flip_sink_write) Use st_trim_copy() instead of strncpy().
807 * format.c: (parse_format_specifier_name) Use mm_case_compare()
810 * get.c: (cmd_save_internal) Rephrase.
811 (rename_variables) Drop test for identical variable name.
812 (struct mtf_proc) Change `first', `last' to fit long var name.
814 * hash.c: (hsh_hash_case_string) New function for case-insensitive
817 * lexer.c: (restore_token) Use st_trim_copy() instead of
819 (lex_get) Don't uppercase string when copying into tokid.
820 (lex_put_back_id) Use st_trim_copy() instead of
823 * list.q: (determine_layout) Consider length of variable names in
824 choosing vertical layout.
826 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
828 (string_to_content_type) Ditto.
830 * modify-vars.c: (compare_variables_given_ordering) Ditto.
831 (struct var_renaming) Change `new_name' to fit long var name.
832 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
835 * pfm-read.c: (read_variables) Disallow system variables in system
837 (write_variables) Call dict_assign_short_names() and use
838 short_name[] members.
840 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
843 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
844 map. Reorder variables into same order as long variable map.
845 (read_variables) Set short name.
847 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
848 (write_variable) Use st_bare_pad_copy().
849 (write_longvar_table) Rewrite.
851 * str.c: (mm_case_compare) New function.
853 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
856 * t-test.q: (tts_custom_groups) Remove redundant test.
857 (tts_custom_pairs) Ditto.
859 * var.h: (struct variable) Change `name' to fit long var names.
860 Remove `longname'. Add `short_name' member. Reorder some
862 (struct name_table_entry) Removed.
863 (struct vector) Change `name' to fit long vector names.
865 * vars-atr.c: (var_is_valid_name) Allow long var names.
866 (compare_var_names) Use strcasecmp() instead of strcmp().
867 (compare_var_ptr_names) Ditto.
868 (hash_var_name) Use hsh_hash_case_string().
869 (hash_var_ptr_name) Ditto.
870 (var_set_short_name) New function.
871 (var_clear_short_name) New function.
872 (var_set_short_name_suffix) New function.
874 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
875 Use strcasecmp() instead of strcmp().
876 (struct array_var_set) Removed `longname_tab'.
877 (array_var_set_lookup_var_idx) Drop longname_tab support.
878 (array_var_set_destroy) Don't destroy `longname_tab'.
879 (var_set_create_from_array) Don't create `longname_tab'.
881 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
884 * expressions/parse.c: (word_matches) Use mm_case_compare()
886 (compare_strings) New function.
887 (lookup_function) Use compare_strings() instead of strcmp().
889 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
891 * algorithm.c: (move_element) New function.
893 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
895 * aggregate.c: (parse_aggregate_functions) Always initialize
898 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
900 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
902 * dictionary.c: (dict_clone) Ditto.
903 (dict_clone_var_assert) New function.
905 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
907 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
909 * error.c: Added a string for the compiler version to the
910 request_bug_report_and_abort function.
912 * groff_font.c, font.c: Removed manpage(1) style references from
913 comments, because RMS frowns upon them.
915 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
917 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
919 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
921 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
924 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
926 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
927 which should be LONG_NAME_LEN
929 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
931 * command.def echo.c: Added the ECHO command.
933 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
935 Finish fixing MATCH FILES (bug 11677).
937 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
938 keep_variables(), rename_variables().
939 (drop_variables) New function.
940 (keep_variables) New function.
941 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
942 (cmd_match_files) Deal with in_var. Use drop_variables(),
943 keep_variables(). When IN is specified, require BY. Set master
944 variables after master dictionary is complete. Add IN variables
945 after master dictionary is complete.
946 (mtf_free_file) Free `in_name'.
947 (mtf_delete_file_in_place) Set in_var value to 0.
948 (mtf_read_nonactive_records) Rephrase.
949 (mtf_processing) Support IN. Rephrase. Fix bugs.
950 (mtf_merge_dictionary) Don't set master variables; we do that
952 (get_master) Don't insist that there's a master variable.
954 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
956 Kluge to make some variable renaming sort of work.
959 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
961 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
963 Add functions for comparing sets of variables between cases.
966 * case.c: (case_compare) New function.
967 (case_compare_2dict) New function.
969 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
971 (cmd_aggregate) Nullify break_case. Don't call
972 initialize_aggregate_info().
973 (agr_destroy) Destroy break_case.
974 (aggregate_single_case) Rewrite. Use case_compare().
975 (dump_aggregate_info) Copy from break_case into output.
976 (initialize_aggregate_info) Copy break_case from input.
978 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
980 * vfm.c: (equal_splits) Use case_compare().
982 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
984 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
986 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
988 Start work on fixing MATCH FILES.
990 * get.c: (enum operation) Remove OP_MATCH.
991 (trim_dictionary) Change return value to bool. Don't support
993 (struct mtf_file) Remove `first', `last' members.
994 (struct mtf_proc) Add `first', `last' members. Change mtf_case
995 from `struct ccase *' to `struct ccase'. Remove `by' member.
996 (cmd_match_files) Essentially rewrite.
997 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
998 (mtf_read_nonactive_records) mtf_ parameter is not unused.
999 (mtf_processing) Ditto. Also rephrase some code.
1000 (mtf_merge_dictionary) Rewrite for easy comprehension.
1002 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
1004 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
1007 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
1009 Thu Apr 14 2005 John Darrington
1011 * var-display.c: New file.
1013 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
1014 display_width, measure and alignment parameters to variables.
1016 * aggregate.c command.def compute.c count.c data-list.c descript.c
1017 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
1018 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
1019 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
1020 vars-prs.c vector.c :
1021 - Replaced literal constants representing maximum variable name
1022 length with macro definitions.
1023 - Added support for long variable names.
1024 - Changed lexer such that it no longer makes tokens upper
1025 case, but relies upon case insensitive behaviour of commands.
1027 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
1029 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
1030 fails, don't dereference the resulting null pointer (bug 12427).
1031 Also, fix double free error.
1033 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
1035 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
1036 (accumulate_aggregate_info) Set int1 to 1 for SUM.
1037 (dump_aggregate_info) Only make SUM non-missing if there was at
1040 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
1042 * aggregate.c: (dump_aggregate_info) Properly test whether the
1043 destination variable is numeric, when making the result
1044 system-missing for columnwise missing values.
1046 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
1048 * misc.h: Remove GCC specializations.
1050 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
1052 Make sort stable (bug 12313).
1054 * sort.c: Don't need to include some headers anymore.
1055 (static var min_buffers) New variable.
1056 (static var max_buffers) New variable.
1057 (static var allow_internal_sort) New variable.
1058 (cmd_sort_cases) Add test mode.
1059 (sort_execute) Rephrase.
1060 (do_internal_sort) Don't try internal sorting if
1061 allow_internal_sort is set.
1062 (struct external_sort) Renamed `initial_runs' to `runs' and
1063 updated all references.
1064 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
1065 (macro MIN_BUFFER_SIZE_BYTES) Removed.
1066 (macro MIN_BUFFER_SIZE_RECS) Removed.
1067 (compare_initial_runs) Removed.
1068 (struct record_run) Add member `idx'.
1069 (write_initial_runs) Pass increasing values to process_case() as
1071 (process_case) Add `idx' parameter and use it to initialize new
1073 (allocate_cases) Limit allocated buffers to max_buffers.
1074 (compare_record_run) Use new `idx' member for last resort
1075 comparison, for stability.
1076 (end_run) Call casefile_sleep() on irs->casefile, to prevent
1077 running out of file descriptors.
1078 (struct merge_state) Removed.
1079 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
1080 unless we have fewer runs left. Always merge consecutive runs,
1081 for stability. Return the final run.
1083 (choose_merge) New function.
1084 (merge_once) Rewritten.
1086 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
1088 * cmdline.c: (static var testing_mode) Move into
1089 parse_command_line().
1091 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
1093 * algorithm.c: (remove_range) New function.
1094 (remove_element) New function.
1096 * dictionary.c: (dict_delete_var) Use remove_element().
1098 * flip.c: (cmd_flip) Ditto.
1100 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
1102 * file-handle.q: (struct file_handle) `open_mode' should not be
1105 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
1107 First phase of making SORT CASES stable (bug 12313).
1109 * sort.c: (struct indexed_case) New structure.
1110 (do_internal_sort) Rewrite to make internal sorting stable.
1111 (compare_case_dblptrs) Removed.
1112 (compare_indexed_cases) New function.
1114 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
1118 * casefile.c: (casereader_read_xfer_assert) New function.
1120 * dictionary.c: (dict_compact_case) New function.
1122 * flip.c: (struct flip_pgm) New member idx_to_fv.
1123 (cmd_flip) Initialize idx_to_fv member.
1124 (destroy_flip_pgm) Free idx_to_fv member.
1125 (flip_sink_write) Use struct flip_pgm member instead of case_sink
1127 (flip_sink_write) Ditto.
1129 * vfm.c: (write_case) Use dict_compact_case() instead of
1131 (compact_case) Removed.
1132 (storage_source_create) Removed `dict' parameter. All references
1135 * vfm.h: (struct case_source) Removed `value_cnt' member. All
1137 (struct case_sink) Removed `dict', `idx_to_fv' members. All
1140 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
1142 More AGGREGATE fixes.
1144 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
1145 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
1147 (initialize_aggregate_info) Fix initialization for MIN, MAX for
1150 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
1152 Start work on testing and debugging AGGREGATE.
1154 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
1155 of a bit-map. Require proper subcommand ordering. Make OUTFILE
1156 subcommand mandatory.
1157 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
1158 functions' arguments are in the correct order and swap them if
1160 (accumulate_aggregate_info) Make SUM include weights. Add various
1162 (dump_aggregate_info) Add various string functions.
1163 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
1165 * sort.c: (sort_parse_criteria) Add parameter for returning
1166 whether any directions were specified. All callers updated.
1168 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
1170 * t-test.q: Fixed erroneous logic in compare_group_binary.
1172 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
1174 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
1175 keywords (bug 11628).
1177 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
1179 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
1180 called *before* close_active_file().
1182 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
1184 * file-handle.q: (struct file_handle) Change open_mode from
1185 character pointer to 3-char array, for safety. Updated all
1188 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
1190 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
1193 * pfm-read.c: (read_header) Improve error message for many cases
1194 in which the input is not actually a portable file.
1196 * file-handle.q: (fh_open) When we give an error message, actually
1199 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
1201 * format.c: (check_common_specifier) New function for checks
1202 common to check_input_specifier() and check_output_specifier().
1203 (check_input_specifier) Use check_common_specifier().
1204 (check_output_specifier) Use check_common_specifier().
1205 (check_string_specifier) Removed.
1206 (check_specifier_type) New function.
1207 (check_specifier_width) New function.
1208 (get_format_var_width) Fix bug.
1210 * formats.c: (internal_cmd_formats) Only accept numeric variables.
1212 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
1213 update all references. Make case-insensitive.
1215 * pfm-read.c: Essentially rewrite the whole file. Now much
1218 * print.c: (check_string_width) New function.
1219 (fixed_parse_compatible) Use check_string_width(),
1220 check_specifier_type().
1221 (dump_fmt_list) Ditto.
1223 * str.c: (st_trim_copy) New function.
1224 (st_uppercase) New function.
1226 * vars-atr.c: (var_is_valid_name) New function.
1228 * expressions/parse.c: (type_coercion_core) Use
1229 check_specifier_type().
1231 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
1233 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
1235 * expressions/parse.c: (no_match) Ditto.
1237 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
1239 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
1241 * expressions/helpers.c: (struct func_params) Removed.
1242 (generalized_idf) Removed.
1245 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
1247 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
1248 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1249 Implement SIG.F, which I had overlooked previously.
1251 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1253 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1254 available only in testing mode.
1256 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1258 * data-in.c: Use `bool' throughout, where relevant.
1260 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1262 DATA LIST with free-field formats should not have implied decimal
1263 places (bug 12035). Also clean up data-in.c a bit.
1265 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1267 * data-in.c: (apply_implied_decimals) New function.
1268 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1269 set. Also, get rid of gotos.
1270 (parse_Z) Use apply_implied_decimals() if the field doesn't
1271 contain a decimal point.
1272 (parse_N) Use apply_implied_decimals().
1278 (parse_enum) New function.
1279 (macro CHAR_IS_ROMAN) Removed.
1280 (macro ROMAN_VALUE) Removed.
1281 (parse_month) Use parse_enum().
1282 (parse_weekday) Use parse_enum().
1283 (parse_DATETIME) Use long for weekday.
1285 * data-list.c: (read_from_data_list_fixed) Use
1286 DI_IMPLIED_DECIMALS.
1288 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1290 When the lexer sees something like `-5' in the input, it has to
1291 decide whether it's a negative numeric constant token or a '-'
1292 token followed by a positive numeric constant token. It always
1293 decides on the former, and then the parser can call
1294 lex_negative_to_dash() if it wants the latter. However, this
1295 doesn't work for the case of `-0', because negative zero is
1296 (portably) indistinguishable from positive zero. So now we divide
1297 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1298 distinction clear. This requires a little bit of extra effort,
1299 because there were several references to T_NUM in the code base.
1301 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1302 positive and negative numeric constants.
1303 (lex_double_p) Renamed lex_is_number(). Changed return type to
1304 bool. Updated all relevant references to T_NUM to instead use
1306 (lex_double) Renamed lex_number(). All references updated.
1307 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1308 bool. All references updated.
1309 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1310 (lex_negative_to_dash) Ditto.
1313 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1315 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1317 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1319 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1321 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1322 values as system-missing.
1324 * expressions/parse.c: (parse_vector_element) Fix order of
1325 arguments in call to expr_allocate_binary().
1327 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1329 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1332 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1333 failure, as indicated by function comment.
1334 (parse_binary_operators) Always return NULL on type_coercion()
1335 failure. Should have been doing this anyway, but bug in
1336 type_coercion_core() filtered through.
1337 (parse_add) Fix typo in user message.
1338 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1340 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1342 * expressions/operations.def: Add VALUE function.
1344 * expressions/parse.c: (parse_function) Need an unary composite
1345 node for variables in A TO B, not a variable node. Use
1346 allocate_unary_variable().
1347 (parse_primary) Use allocate_unary_variable().
1348 (allocate_unary_variable) New function.
1350 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1352 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1353 but fixed the real problem that was preventing the build from a
1354 separate directory. I liked it my way better ;-)
1356 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1358 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1359 John Darrington <john@darrington.wattle.id.au> for reporting this
1362 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1364 * expressions/Makefile.am expressions/evaluate.h.pl
1365 expressions/evaluate.inc.pl expressions/operations.h.pl
1366 expressions/optimize.inc.pl expressions/parse.inc.p:
1368 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1371 Fixed everything so that it can be built from an arbitrary
1374 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1376 * Makefile.am : Fixed up CLEANFILES target.
1378 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1380 * str.h: Changed `struct len_string' to `struct fixed_string', a
1381 more accurate name. Updated all references.
1383 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1385 Redo calendar support. Should now be bug-for-bug compatible.
1387 * calendar.c: New file.
1389 * calendar.h: New file.
1391 * data-in.c: Use new calendar functions.
1392 (parse_sign) Change sense of return value.
1393 (calendar_error) New function.
1394 (ymd_to_ofs) New function.
1395 (ymd_to_date) New function.
1396 (parse_DATE) Use new function.
1397 (parse_ADATE) Ditto.
1398 (parse_EDATE) Ditto.
1399 (parse_SDATE) Ditto.
1400 (parse_JDATE) Ditto.
1405 (parse_DTIME) Ditto.
1406 (parse_DATETIME) Ditto.
1408 * data-out.c: (convert_date) Use new calendar functions.
1410 * error.c: (err_vmsg) Changed interface to be more sensible.
1411 Updated all callers.
1412 (dump_message) Don't double new-lines (why did we do this
1415 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1417 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1418 (macro FLT64_MAX) Moved here from pref.h.orig.
1420 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1422 * set.q: Support SET EPOCH.
1423 (static var set_epoch) New var.
1424 (aux_stc_custom_epoch) New function.
1425 (stc_custom_epoch) New function.
1426 (get_epoch) New function.
1427 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1429 * format.c: Make it possible just to check whether a specifier is
1430 valid without emitting an error message.
1431 (parse_format_specifier_name) Change interface, update all
1433 (check_input_specifier) Ditto.
1434 (check_output_specifier) Ditto.
1435 (parse_format_specifier) Ditto.
1437 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1439 * command.def: Add DEBUG POOL.
1441 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1443 (pool_clear) Properly account for size of pool gizmo.
1444 (pool_realloc) Ditto.
1445 (pool_clone) New function.
1447 * pool.h: Mark our allocation functions MALLOC_LIKE.
1449 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1451 * Makefile.am: Move many definitions into new top-level
1452 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1453 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1456 * case.c: (case_resize) New function.
1457 (case_swap) New function.
1459 * casefile.c: Include mkfile.h.
1461 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1463 * sfm-read.c: Fixed a buglet which caused a crash when trying
1464 to read a non-existent file.
1466 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1470 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1471 Important part: get rid of spurious copying of function->format to
1472 destvar->print and destvar->write.
1474 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1476 Fix bug 11916, which was confusing a variable's `index' member
1477 with the variable's position in a var_set. Although these are
1478 usually the same, they are not for array `var_set's.
1480 Took advantage of this bug as an opportunity to clean up and
1481 rewrite parse_var_set_vars().
1483 * vars-prs.c: (parse_vs_variable_idx) New function.
1484 (parse_vs_variable) Reimplement in terms of
1485 parse_vs_variable_idx().
1486 (parse_var_idx_class) New function.
1487 (add_variable) New function.
1488 (add_variables) New function.
1489 (parse_var_set_vars) Rewritten.
1490 (struct var_set) Change `lookup_var' member that returns a
1491 variable into `lookup_var_idx' member that returns an int.
1492 Updated the var set implementations in obvious corresponding ways.
1493 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1495 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1497 Use our global variable compare & hash functions and give them
1498 better names. Add similar functions for dealing with double
1499 pointers to variables.
1501 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1502 (hash_variable) Renamed hash_var_name().
1503 (compare_var_ptr_names) New function.
1504 (hash_var_ptr_name) New function.
1506 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1508 (compare_var_name) Removed.
1509 (hash_var_name) Removed.
1511 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1515 * dictionary.c: (compare_variable_dblptrs) Rename
1516 compare_var_ptrs() and fix it to properly dereference the double
1519 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1521 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1522 declare subcommands as mandatory. Closed bug #11843
1524 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1526 * getline.c command.[ch] command.def: Added (very rudimentary)
1527 support for line completion when in interactive mode. Partially
1528 addresses bug #11693
1530 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1532 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1533 problems revealed by valgrind.
1536 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1538 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1539 whether or not PAGER is set.
1541 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1543 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1544 "invalid free" errors. Hopefully fixes bug #11722
1546 * compute.c expr-prs.c: Check that lvalues are populated before
1547 attempting to destroy them. Closes bug #11676
1549 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1551 * aggregate.c: Initialised the complete agr_proc structure.
1555 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1557 * print.c: (print_trns_free) Close the dfm writer if there is one,
1558 fixing a memory leak.
1560 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1562 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1566 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1568 * linked-list.[ch] Added
1570 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1571 set.q: Yet more memory leaks
1573 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1575 * t-test.q examine.q : More memory leaks fixed.
1577 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1579 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1582 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1584 * ascii.c cartesian.c casefile.c chart.h devind.c
1585 examine.q frequencies.q
1586 html.c output.h piechart.c plot-chart.c plot-hist.c
1588 Integrated the chart rendering into the output stream
1589 (currently only works for html).
1591 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1592 dummy-chart.c for compiling without charts.
1594 * mkfile.[ch] Created.
1596 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1597 Added type element so we can tell if it's a chart or a table.
1599 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1600 API of charts to be more like that of tables.
1602 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1604 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1605 main.c. Removed the handler for SIGQUIT.
1607 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1609 * casefile.c: Added a signal handler to delete temp files on
1612 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1614 * command.def Added a lot more unimplemented commands.
1616 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1618 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1620 * sort.c: (compare_initial_runs) Needed additional level of
1622 (merge_once) Fix plenty of stupid mistakes.
1624 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1626 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1627 calling casefile_to_disk() or we will lose the last block in the
1628 file if the casefile started out as disk-based.
1629 (casefile_get_reader) Initialize reader->destructive to 0.
1630 (cmd_debug_casefile) Add new test pattern.
1631 (test_casefile) Define new test pattern to make sure
1632 casefile_sleep() works properly.
1634 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1636 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1637 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1638 attempt to seperate the creation and processing of charts from their
1641 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1644 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1646 * main.c Added a signal handler for SIGFPE
1648 * sort.c Somewhat more robust fix to the previous entry.
1650 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1652 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1653 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1654 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1657 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1659 * case.h Fixed bug # 11307
1661 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1663 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1666 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1668 * pfm-read.c: (read_variables) Remove direct manipulation of
1669 v->aux, which is no longer needed. Fixes bug 11483.
1671 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1673 * data-list.c Fixed a bug in parsing delimiters.
1675 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1678 * percentiles.c Properly handled calculation of Tukey hinges where
1679 the number of data is small.
1681 * oneway.q Used the generic value_to_string function for independent
1682 variable instead of trying to do it ourselves.
1684 * box-whisker.c Fixed a buglet which caused a crash if the number of
1688 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1690 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1692 * percentiles.c Fixed some bugs when calculating percentiles when
1693 there's a small number of cases.
1695 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1697 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1699 * examine.q factor_stats.[ch] Added calculation of percentiles
1701 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1703 * t-test.q Fixed bug #11227 Made t-test work when the independent
1706 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1708 * factor_stats.c Fixed calculation of trimmed mean under various
1711 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1713 * histogram.c chart.[ch] factor_stats.c frequencies.q
1715 Added code to calculate sensible histogram ranges and limits.
1717 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1719 * chart.h Updated to reflect many API changes.
1721 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1722 cartesian.c and into chart.c
1724 * factorstats.[ch] Added the histogram calculations
1726 * casefile.c Removed an unused variable.
1728 * frequencies.q examine.q histogram.c Reworked the API for
1731 * piechart.c Revised the API for piecharts.
1733 * var.h Moved the definitions of freq_tab and freq out of var.h
1734 and into frequencies.q where they belong.
1736 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1738 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1739 using AC_TYPE_OFF_T.
1741 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1743 * flip.c: (flip_file) If fseeko() is not available, use long int
1744 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1745 reporting the problem.
1747 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1749 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1750 conflict with stdio.
1752 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1754 * var-labs.c (var_to_string) Now returns null if the variable is null
1756 * value-labels.c (value_to_string) Made it return null if either the
1757 value or the variable is null.
1759 * hash.c (hsh_clear) Fixed a buglet.
1761 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1762 with the wrong model.
1764 * casefile.[ch] Added a function to return the casereader.case_idx
1767 * examine.q Implemented the extreme values results.
1769 John Darrington <john@darrington.wattle.id.au>
1771 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1772 output.[ch] getline.c
1774 Plugged some memory leaks
1776 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1778 Adopt GSL random number generators, paving the way for providing
1779 the complete suite of random number generators on expressions.
1781 * Makefile.am: Remove random.c, random.h.
1783 * random.c: Removed.
1785 * random.h: Removed.
1787 * algorithm.c: (algo_default_random) Use GSL functions.
1789 * casefile.c: (test_casefile) Use GSL RNG functions.
1791 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1794 * sample.c: (cmd_sample) Use GSL RNG functions.
1795 (sample_trns_proc) Ditto.
1797 * set.q: (static var set_seed) Removed.
1798 (static var seed_flag) Removed.
1799 (static var rng) New variable.
1800 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1801 (stc_custom_seed) Use new seed functions.
1802 (seed_is_set) Removed.
1803 (get_rng) New function that composes the entire external
1805 (set_rng) New function.
1806 (random_seed) New function.
1808 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1810 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1811 John Darrington <john@darrington.wattle.id.au> for reporting this
1814 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1816 * permissions.c command.def Added the PERMISSIONS command
1818 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1820 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1821 output file because that will precede #include <config.h>, which
1823 (main) Add needed headers to /* (header) */ code.
1825 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1827 Instead of making system or portable file readers responsible for
1828 dropping and reordering variables, make them read full cases and
1829 let the caller take care of any changes.
1831 * get.c: New "case map" structure to handle this. Use for GET,
1832 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1834 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1835 changed appropriately.
1837 * sfm-read.c: (sfm_read_case) Ditto.
1839 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1841 Decided that case_serialize() and case_unserialize() were too
1842 abstract. Also we need a couple more functions to avoid excessive
1843 copying for data in/out fast paths.
1845 * case.c: (case_serial_size) Removed.
1846 (case_serialize) Rename case_to_values() and make its argument
1847 explicitly an array of union values.
1848 (case_unserialize) Rename case_from_values() and make its argument
1849 explicitly an array of union values.
1850 (case_data_all) New function.
1851 (case_data_all_rw) New function.
1853 * casefile.c: (struct casefile) Change buffer from array of
1854 unsigned char to array of union value for better accuracy.
1855 Redefine buffer_used and buffer_size in terms of values, not
1856 bytes. Remove case_size because it is now redundant with
1857 value_cnt. Fix up all references to these members.
1859 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1861 * barchart.c: (struct subcat) Make `label' member const to silence
1862 GCC warning with -Wwrite-strings.
1864 * cartesian.c: (struct dataset) Ditto.
1866 * case.c: Don't re-define NDEBUG if already defined.
1867 Add lots of comments.
1869 * str.c: Fix includes.
1871 * crosstabs.q: Fix includes.
1873 * examine.q: Fix includes. Fix GCC warning about unused
1876 * frequencies.q: (stat macro) Removed and replaced where used by
1879 * list.q: Fix includes.
1881 * oneway.q: Fix includes.
1883 * piechart.c: Fix includes. Only define M_PI if not already
1886 * sfm-read.c: (bswap) New function.
1887 (bswap_int32) Write in terms of bswap.
1888 (bswap_flt64) Ditto.
1890 * str.c: (ds_data) Add external definition here, needed because
1891 str.h has only an `extern inline' version.
1893 * value-labels.c: Fix includes.
1895 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1897 Instead of providing a system or portable file writer with a raw
1898 case in the format needed for output, provide it with a regular
1899 case. The writer takes care of any needed translation.
1901 * aggregate.c: Adopt new scheme for AGGREGATE.
1902 (struct agr_proc) sfm_agr_case member removed.
1903 (write_case_to_sfm) Removed because the new interface is easier to
1906 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1908 * pfm-write.c: Implement new scheme.
1910 * sfm-write.c: Ditto.
1912 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1914 Instead of treating `struct file_handle' as a class to subclass
1915 into data files, system files, and portable files, instead use it
1916 as a helper that coordinates access. Now it is opaque, too.
1918 This means that most references to a struct file_handle are now
1919 changed into references to one of struct dfm_reader, struct
1920 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1921 pfm_reader, or struct pfm_writer, according to what's being read
1924 Most related changes are only worth summarizing briefly.
1926 * dictionary.c: (dict_clear) Destroy aux data in deleted
1928 (dict_clear_aux) New function.
1929 (dict_create_var) Initialize aux, aux_dtor.
1930 (dict_delete_var) Destroy aux data in deleted variable.
1932 * file-handle.h: (struct fh_ext_class) Removed.
1933 (struct file_handle) Removed.
1934 (fh_init_files) Removed.
1936 * file-handle.q: Changed references to a handle's `private' member
1937 to direct references.
1938 (struct private_file_handle) Renamed file_handle.
1939 Add next, open_cnt, type, open_mode, aux members.
1940 (struct file_handle_list) Removed.
1941 (extern var inline_file) Removed.
1942 (static var file_handles) Changed from file_handle_list * to
1944 (create_file_handle) Initialize new members.
1945 (fh_close_handle) Removed.
1946 (mode_name) New function.
1947 (fh_open) New function.
1948 (fh_close) New function.
1949 (fh_parse_file_handle) Renamed fh_parse().
1951 * glob.c: (init_glob) Remove fh_init_files() call.
1953 * aggregate.c: use sfm_writer.
1954 (create_sysfile) Removed because the new interface is simpler.
1956 * apply-dict.c: Use sfm_reader.
1958 * data-list.c: Use dfm_reader.
1960 * file-type.c: Use dfm_reader.
1962 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1964 * inpt-pgm.c: Use dfm_reader.
1966 * print.c: Use dfm_writer.
1968 * sysfile-info: Use sfm_reader.
1970 * dfm-read.c: Adopt new file handle infrastructure.
1972 * dfm-write.c: Ditto.
1974 * pfm-read.c: Ditto.
1976 * pfm-write.c: Ditto.
1978 * sfm-read.c: Ditto.
1980 * sfm-write.c: Ditto.
1982 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1984 Break dictionary functions into separate header file.
1986 * dictionary.h: New file.
1988 * var.h: Moved dict_*() functions to dictionary.h.
1990 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1992 Get rid of procedure-specific union in struct variable, using
1993 instead a void * pointer and a destructor function.
1995 Most related changes are only worth brief summaries.
1997 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1998 old p.crs member in struct variable.
2000 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
2001 of old p.frq member in struct variable.
2003 * histogram.c: (draw_histogram) Takes new freq_tab arg because
2004 it's no longer possible to grab this from var->p.frq.
2006 * piechart.c: (draw_piechart) Ditto.
2008 * group.c: (group_proc_get) New function.
2010 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
2017 * main.c: (execute_command) Clear aux data in default_dict after
2018 each command. (It's debatable whether this should be done.)
2020 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
2021 member in struct variable.
2023 * means.q: Get rid of integer mode, which is not included in
2024 recent SPSS and was the only code that wanted per-variable private
2027 * var.h: (struct crosstab_proc) Removed.
2028 (struct frequencies_proc) Removed.
2029 (struct list_proc) Removed.
2030 (struct get_proc) Removed.
2031 (struct means_proc) Removed.
2032 (struct matrix_data_proc) Removed.
2033 (struct match_files_proc) Removed.
2034 (lots of enums) Removed.
2035 (struct variable) Removed members `p', `get'. Add member
2038 * vars-atr.c: (var_attach_aux) New function.
2039 (var_detach_aux) New function.
2040 (var_clear_aux) New function.
2041 (var_dtor_free) New function.
2042 (discard_variables) Use NULL instead of inline_file.
2044 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2046 * value-labs.c Fixed the implmentation of value_to_string, so
2047 that it properly handles alpha values.
2049 * oneway.q Changed instances where labels were being probed manually,
2050 to use the canonical {var,value}_to_string functions
2052 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2054 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
2055 plots. Changed the API of the cartesian plot to be a much lower level
2058 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
2060 * examine.q Added some of the parametric calculations
2062 * factor_stats.[ch] Created
2064 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2066 * examine.q Changed the definition of factors to be a composite, and
2067 dealt with the consequences.
2069 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
2071 * examine.q Fixed problem where examine wasn't dealing properly with
2074 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
2076 * oneway.q Fixed problem where oneway wasn't dealing properly with
2079 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
2081 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
2082 command which had settings didn't get the appropriate code
2085 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
2086 to convert variables/values to strings.
2088 * examine.q Added framework for the EXAMINE command.
2090 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
2092 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
2093 subcommand types. Changed frequencies.q to use it rather then the
2094 custom parser. Dealt with the consequences. Added a test for NTILES
2095 subcommand of frequencies.
2097 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
2099 * oneway.q Fixed up the behaviour when given missing values
2101 * levene.c oneway.q Fixed a buglet with the levene statistic and
2102 incorporated the levene test into the oneway command.
2104 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
2105 global scope, since they're only relevant to T-TEST
2107 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
2109 * group.c group.h group_proc.h levene.c oneway.q t-test.q
2111 Made the t-test more consistent
2112 with the way it handles groups. That is, it now uses a hash instead
2113 of an array of 2. Also, made the levene.c file independent of the
2114 implementation of the t-test. So now levene should be fine for both
2117 * Added an oneway.q file for one way anova
2119 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
2121 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
2124 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
2128 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
2129 (data_list_trns_free) Free dls->delims.
2131 * t-test.q: (tts_custom_pairs) Free vars.
2132 (ssbox_one_sample_init) Fix tab_vline() argument.
2133 (ssbox_independent_samples_init) Ditto.
2134 (trbox_paired_init) Ditto.
2135 (trbox_one_sample_init) Ditto.
2137 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
2139 Generalize casefiles to the extent that we can use them for
2140 sorting and other kinds of data transformations. Change cases to
2141 be copy-on-write to improve memory efficiency in common cases.
2142 Every access to a member of a `struct ccase' was changed to be a
2143 call to a case_*() function, especially case_data(), case_num(),
2144 case_str(), or case_data_rw(). Many instances of a local variable
2145 named "case_num" were changed to "case_idx" as a consequence.
2146 Many `struct ccase *' were changed to actual `struct ccase'
2147 because of copying semantics of cases. In several places there
2148 was a choice between updating debug code to work with the new ADTs
2149 or just deleting it because it was useless; I chose to delete it.
2151 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
2157 * aggregate.c: (struct agr_proc) Change type of `sort' to
2158 sort_criteria *. Add `break_vars', `break_var_cnt' members.
2159 Rename `vars' to `agr_vars', all references updated. Change
2160 `agr_case' to type `struct ccase'.
2161 (cmd_aggregate) Deal with new members. Use case_create(),
2162 sort_active_file_in_place(), sort_active_file_to_casefile().
2163 (agr_destroy) Deal with new members.
2164 (aggregate_single_case) Ditto.
2165 (dump_aggregate_info) Ditto.
2166 (initialize_aggregate_info) Ditto.
2167 (agr_to_active_file) Ditto.
2168 (presorted_agr_to_sysfile) Ditto.
2169 (sort_agr_to_sysfile) Removed.
2171 * alloc.c: (out_of_memory) Make non-static.
2173 * alloc.h: Prototype out_of_memory().
2175 * casefile.c: Switched from a linked list in-memory representation
2176 to a two-level array-style representation. The linked list was
2177 appropriate when we could stick a header onto cases, but that's no
2178 longer the case. Also, the two-level array will allow for random
2179 in-memory access in case that's ever wanted. Also added the
2180 concept of a `destructive casereader', one that destroys cases in
2181 the underlying casefile as they are read out.
2182 (macro CASES_PER_BLOCK) New macro.
2183 (struct casefile) New members `value_cnt', `case_list_size',
2184 `case_acct_size', `being_destroyed', `cases'. Removed `head',
2186 (struct casereader) Removed `cur'. Added `destructive', `c'.
2187 (global var casefiles) Made static.
2188 (static var case_bytes) New var.
2189 (casefile_create) Takes a value count, not a case size in bytes,
2190 to conform to the case interface. All callers updated. Deal with
2191 new and removed members.
2192 (casefile_destroy) Deal with new and removed members.
2193 (casefile_sleep) New function.
2194 (casefile_get_case_size) Removed.
2195 (casefile_get_value_cnt) New function.
2196 (casefile_append) Rewritten to deal with new and removed members.
2197 (casefile_append_xfer) New function.
2198 (write_case_to_disk) Use case_serialize().
2199 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
2200 Couldn't figure out why.
2201 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
2202 deal with new and removed members.
2204 (merge_sort) Removed.
2205 (casefile_sort) Removed.
2206 (casefile_get_reader) Deal with new and removed members.
2207 (casefile_get_destructive_reader) New function.
2208 (reader_open_file) Make code more readable. Create case for
2210 (casereader_get_casefile) New function.
2211 (casereader_read) Deal with new and removed members. Now returns
2212 a copy of the case, so that the caller is responsible for
2213 destroying the returned case.
2214 (casereader_read_xfer) New function.
2215 (casereader_destroy) Destroy reader's case.
2216 (test_casefile) Second arg is now a value count, all callers
2217 updated. Now tests destructive readers too.
2218 (get_random_case) Deal with new case ADT.
2219 (write_random_case) Ditto.
2220 (read_and_verify_random_case) Ditto.
2222 * crosstabs.q: Remove debug code.
2224 * descript.q: (calc_descriptives) Deal with new case, casefile
2227 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
2229 * do-if.c: Remove unneeded header inclusion.
2231 * expr-prs.c: Remove debug code.
2233 * exprP.h: Remove debug code.
2235 * flip.c: (flip_file) Use fseeko() if available.
2237 * formats.c: Remove debug code.
2239 * get.c: Remove debug code.
2240 (struct mtf_file) Change `input' from `union value *' to `struct
2241 ccase', all references updated.
2243 * levene.c: (levene) Deal with new case, casefile ADTs.
2245 * list.q: Remove debug code.
2247 * loop.c: Remove debug code.
2249 * matrix-data.c: Remove debug code.
2251 * means.q: Remove debug code.
2253 * mis-val.c: Remove debug code.
2255 * pfm-read.c: Remove debug code.
2256 (pfm_read_code) Change second arg from `union value *' to `struct
2257 ccase *', all references updated.
2259 * recode.c: (string_to_long) Make first arg const.
2260 (convert_to_double) Ditto.
2262 * repeat.c: Remove debug code.
2264 * sample.c: Remove debug code.
2266 * sfm-read.c: Remove debug code.
2267 (sfm_read_case) Change second arg from `union value *' to `struct
2270 * sort.c: Redone in terms of casefiles.
2271 (enum sort_direction) Moved here from sort.h.
2272 (struct sort_criterion) New structure.
2273 (struct sort_criteria) New structure.
2274 (cmd_sort_cases) Rewritten.
2275 (prepare_to_sort_active_file) New function.
2276 (sort_active_file_in_place) New function.
2277 (sort_active_file_to_casefile) New function.
2278 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2279 changed, all callers updated.
2280 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2281 rewritten & interface changed, all callers updated.
2282 (sort_cases) Renamed sort_execute(), rewritten & interface
2283 changed, all callers updated.
2284 (struct internal_sort) Removed.
2285 (do_internal_sort) Rewritten, interface changed.
2286 (destroy_internal_sort) Removed.
2287 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2288 (struct initial_run) Removed; an initial run is now just a
2290 (compare_initial_runs) Rewritten.
2291 (struct external_sort) Changed almost completely.
2292 (do_external_sort) Rewritten, interface changed.
2293 (destroy_external_sort) Rewritten.
2294 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2295 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2296 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2297 (init_external_sort) Removed.
2298 (simulate_error) Removed.
2299 (rmdir_temp_dir) Removed.
2300 (get_temp_file_name) Removed.
2301 (open_temp_file) Removed.
2302 (close_temp_file) Removed.
2303 (remove_temp_file) Removed.
2304 (write_temp_file) Removed.
2305 (read_temp_file) Removed.
2306 (struct record_run) Change `record' from `struct case_lit *' to
2308 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2309 `file_idx', `output_file'. Add `run', casefile'. Change
2310 `last_output' from `struct case_list *' to `struct ccase'.
2311 (write_initial_runs) Change interface, rewrite.
2312 (sort_sink_write) Renamed process_case(), changed interfaced,
2314 (destroy_initial_run_state) Rewritten.
2315 (allocate_cases) Rewritten.
2316 (compare_record) Interface changed, rewritten.
2317 (start_run) Rewritten.
2318 (end_run) Rewritten.
2319 (output_record) Rewritten.
2320 (grab_case) Removed.
2321 (release_case) Removed.
2322 (struct merge_case) Change `cases' from double pointer to single
2324 (merge) Deal with new case and casefile ADTs.
2325 (struct run) Removed.
2326 (merge_once) Rewritten, interface changed.
2327 (fill_run_buffer) Removed.
2328 (sort_sink_make_source) Removed.
2329 (sort_sink_class) Removed.
2330 (struct sort_source_aux) Removed.
2331 (sort_source_read_helper) Removed.
2332 (sort_source_read) Removed.
2333 (read_sort_output) Removed.
2334 (read_internal_sort_output) Removed.
2335 (read_external_sort_output) Removed.
2336 (sort_source_destroy) Removed.
2337 (sort_source_class) Removed.
2339 * sort.h: (struct sort_cases_pgm) Removed.
2340 (enum sort_direction) Moved to sort.c.
2342 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2344 * tab.c: Remove debug code.
2346 * var-labs.c: Remove debug code.
2348 * var.h: (struct ccase) Removed.
2349 (struct case_list) Removed.
2351 * vars-atr.c: (discard_variables) Use free_case_source().
2353 * vars-prs.c: (parse_vs_variable) Make arg const.
2354 (parse_dict_variable) Ditto.
2355 (parse_variables) Make struct dictionary * arg const.
2356 (parse_var_set_vars) Make struct var_set * arg const.
2357 (struct var_set) Add const to some of the function pointers' args.
2358 (var_set_get_cnt) Make arg const.
2359 (var_set_get_var) Make first arg const.
2360 (var_set_lookup_var) Make first arg const.
2361 (dict_var_set_get_cnt) Make arg const.
2362 (dict_var_set_get_var) Make first arg const.
2363 (dict_var_set_lookup_var) Make first arg const.
2364 (var_set_create_from_dict) Make arg const. Add cast to aux
2366 (struct array_var_set) Add const to var member.
2367 (array_var_set_get_cnt) Make arg const.
2368 (array_var_set_get_var) Make first arg const.
2369 (array_var_set_lookup_var) Make first arg const.
2370 (var_set_create_from_array) Make first arg const. Insert cast.
2372 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2373 members from `struct ccase *' to `struct ccase'.
2374 (static var lag_queue) Change from double to single pointer.
2375 (procedure) Optimize trivial case.
2376 (internal_procedure) Deal with changed case, case_source ADTs.
2377 (create_trns_case) Changed interface, rewrote.
2378 (open_active_interface) Initialize modified lag queue.
2379 (write_case) Deal with changed case ADT.
2380 (lag_case) Deal with modified lag queue.
2381 (close_active_file) Destroy modified lag queue.
2382 Deal with changed case_source, case_sink ADTs.
2383 (destroy_storage_stream_info) Make null arg into no-op.
2384 (storage_sink_make_source) Set aux in created source.
2385 (storage_source_read) Deal with changed case, casefile ADTs.
2386 (storage_source_create) New function.
2387 (lagged_case) Rewrite.
2388 (free_case_source) New function.
2389 (free_case_sink) Rewrite.
2390 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2392 (procedure_with_splits) Deal with changed prev_case.
2393 (procedure_with_splits_callback) Ditto.
2394 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2396 (multipass_procedure_with_splits) Deal with changed prev_case.
2397 (multipass_split_callback) Ditto.
2400 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2402 The workspace idea didn't work out.
2404 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2406 * workspace.c: Removed.
2408 * workspace.h: Removed.
2410 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2412 Fully implement arbitrary delimiters on DATA LIST, extending the
2413 half implementation that was already there.
2415 * data-list.c: (struct data_list_pgm) Remove `delim', add
2416 `delims', `delim_cnt'.
2417 (cmd_data_list) Initialize new members. Parse delimiters and
2418 clean up code a bit.
2419 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2420 handling of leading commas.
2421 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2423 (read_from_data_list_free) Adapt to new DFM interfaces.
2424 (read_from_data_list_list) Ditto.
2425 (repeating_data_trns_proc) Ditto.
2427 * dfm.c: Split up reader and writer into separate code, because
2428 they do different things. Use struct string instead of explicit
2429 allocation code, for clarity.
2430 (enum dfm_reader_flags) New enum.
2431 (struct dfm_fhuser_ext) Removed.
2432 (struct dfm_reader_ext) New.
2433 (get_reader) New function, used by just about all the reader
2435 (dfm_close) Removed.
2436 (close_reader) New function.
2437 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2438 (dfm_open_for_writing) Ditto.
2439 (macro force_line_buffer_expansion) Removed.
2440 (count_tabs) Removed.
2441 (tabs_to_spaces) Removed.
2442 (read_record) Deal with new dfm_reader_ext. Use struct string
2443 functions. Don't convert tabs to spaces.
2444 (dfm_eof) New function.
2445 (dfm_get_record) Changed interface, rewrote.
2446 (dfm_expand_tabs) New function.
2447 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2448 dfm_reader_ext, rewritten.
2449 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2450 dfm_reader_ext, rewritten.
2451 (dfm_set_record) Removed in favor of dfm_forward_columns().
2452 (dfm_forward_columns) New function.
2453 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2454 dfm_reader_ext, rewritten.
2455 (static var dfm_r_class) Use close_reader for the destructor.
2456 (struct dfm_writer_ext) New.
2457 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2458 bounce buffer now instead of local allocation.
2459 (close_writer) New function.
2460 (static var dfm_writer_ext) Use close_writer for destructor.
2461 (cmd_begin_data) Adapt to new dfm_reader_ext.
2463 * file-handle.q: Add support for per-file tab width.
2464 (struct private_file_handle) Add tab_width member.
2465 (q2c specifications) Add tabwidth subcommand.
2466 (cmd_file_handle) Put parsed tab width into private_file_handle.
2467 (create_file_handle) Set default tab width.
2468 (handle_get_tab_width) New function.
2470 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2472 * inpt-pgm.c: (reread_trns_proc) Ditto.
2474 * matrix-data.c: (context) Ditto.
2475 (another_token) Ditto.
2479 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2481 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2483 (casereader_destroy) Don't close file descriptor -1.
2485 * recode.c: (cmd_recode) Fix memory leak.
2487 * set.q: (q2c specifications) Fix typo in user message.
2489 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2490 undefined behavior for overlapping arguments.
2492 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2494 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2495 don't call it when we're running under valgrind.
2496 (call_posix_fadvise) New function.
2497 (casefile_to_disk) Use call_posix_fadvise().
2498 (reader_open_file) Ditto.
2500 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2502 Update our string ADTs, struct string and struct len_string. Get
2503 rid of pool support, which was largely unused. Rename lots of
2504 functions to have more obvious or consistent names.
2506 * ascii.c: Get rid of ascii_pool. It was only used for string
2508 (ascii_open_global) Don't create ascii_pool.
2509 (ascii_close_driver) Don't destroy ascii_pool.
2510 (ascii_postopen_driver) Don't use pool.
2511 (ascii_close_driver) Destroy strings manually.
2513 * str.c: (ds_create) Remove pool argument, all references updated.
2515 (ds_replace) Remove pool support, make more efficient when we
2516 don't need to reallocate.
2517 (ds_destroy) Remove pool support.
2518 (ds_rpad) New function.
2519 (ds_size) Renamed ds_capacity(), all references updated.
2520 (ds_value) Renamed ds_c_str(), all references updated.
2521 (ds_concat) Renamed ds_puts(), all references updated.
2522 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2523 (ds_putchar) Renamed ds_putc(), all references updated.
2524 (ds_getline) Renamed ds_gets(), all references updated.
2525 (ls_create) Remove pool argument, all references updated.
2526 (ls_create_buffer) Ditto.
2527 (ls_destroy) Removed pool support.
2528 (ls_value) Renamed ls_c_str(), all references updated.
2530 * str.h: (ls_length) [__GNUC__] Add inline version.
2531 (ls_c_str) [__GNUC__] Add inline version.
2532 (ls_end) [__GNUC__] Add inline version.
2533 (struct string) Remove pool member. Rename `size' to `capacity',
2534 all references updated.
2536 * tab.c: (text_format) Instead of using pool argument to
2537 ls_create_buffer(), call pool_register() on allocated data.
2539 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2541 We're abusing the current ASCII driver by telling it to allocate a
2542 9999-line, 9999-character page in the tests. This causes some
2543 systems to curl up and die because it allocates 20 MB of
2544 contiguous RAM. This change alleviates at least part of the
2545 problem. It is mostly a stop-gap until the new output system is
2548 * ascii.c: (struct line) New structure.
2549 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2550 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2551 (ascii_preopen_driver) Initialize new members, not old ones.
2552 (ascii_close_driver) Destroy new members, not old ones.
2553 (ascii_open_page) Allocate new members, not old ones.
2554 (expand_line) Allocate room in line.
2555 (draw_line) Use new members.
2556 (ascii_line_horz) Ditto.
2557 (ascii_line_vert) Ditto.
2558 (ascii_line_intersection) Ditto.
2560 (output_lines) Ditto.
2561 (ascii_close_page) Ditto.
2563 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2565 * matrix.c: Dead code. Removed.
2567 * matrix.h: Dead code. Removed.
2569 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2571 Contrary to what I'd always understood, there is an efficient
2572 algorithm for deletion from a hash table populated via linear
2573 probing. This change implements it.
2575 * hash.c: (hsh_rehash) Probe in increasing order.
2577 (locate_matching_entry) Ditto.
2578 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2580 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2582 * moments.c (calc_moments): Adjust calculation of kurtosis to
2583 avoid subtracting huge numbers from huge numbers, on Michael
2586 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2588 Rework moments routines for improved numerical stability based on
2589 Michael Kiefte's advice. Any bugs or remaining numerical problems
2590 are still mine though.
2592 There is now a struct moments1 for use with one-pass moments. It
2593 uses a provisional means algorithm as an attempt to improve
2594 accuracy of higher moments. The older struct moments now only
2595 handles two-pass moments.
2597 * aggregate.c: Use moments1 instead moments.
2599 * descript.c: Revert previous change, which is no longer needed
2600 due to the moments revision.
2602 * moments.c: (calc_moments) New function for calculating variance,
2604 (moments_pass_one) Only accumulate weights bigger than zero.
2605 (moments_calculate) Allow calculating the mean on pass one, others
2606 require pass two. Implement in terms of calc_moments().
2607 (struct moments1) New structure.
2608 (init_moments1) New function.
2609 (moments1_clear) Ditto.
2610 (moments1_create) Ditto.
2611 (moments1_add) Ditto.
2612 (moments1_calculate) Ditto.
2613 (moments1_destroy) Ditto.
2614 (cmd_debug_moments) Deal with `struct moments' or `struct
2615 moments1' as requested by user.
2617 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2619 * Makefile.am (pspp_SOURCES): Remove debug.c.
2621 * debug.c: Removed. It was empty anyway.
2623 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2625 * descript.c (calc_descriptives): Fix assert failure when only
2626 MOMENT_MEAN is needed.
2628 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2632 fixed problem with parsing in match_statistic() causing
2633 "DESCRIPTIVE STAT=MEAN." to barf.
2635 "MEAN" is now default if "SORT" given without specification.
2637 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2638 generally less forgiving of syntax errors: better to have it do
2639 nothing and type it in again then to not know what it actually did
2642 z-score transformation now checks score for user-missing values
2643 and checks std_dev for SYSMIS.
2645 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2647 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2648 Changed dict_get_case_weight() to accept an additional int * flag
2649 to complain about system-missing, user-missing, zero, or negative
2650 weights and updated existing functions to pass int * to
2651 dict_get_case_weight().
2653 2004-04-05 jmd <jmd@gnu.org>
2655 * main.c: Fixed configuration problems with gsl
2657 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2659 2004-04-03 blp <blp@gnu.org>
2661 * lexer.c, ChangeLog:
2662 Fix infinite loop on comment at end of file, add test.
2664 2004-04-03 jmd <jmd@gnu.org>
2666 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2667 Fixed the calculation of percentiles and added --syntax and --algorithm options
2669 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2671 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2674 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2676 * frequencies.q: Fixed the calculation of percentiles
2678 * Makefile.am: Added the --ansi flag and dealt with the
2679 consequences. Added some entries to PSPP_sources so that
2680 make distcheck would pass
2682 * cmdline.c: Added the --syntax and --algorithm options
2684 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2686 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2688 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2689 use the new multipass_split_... mechanism.
2691 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2693 * frequencies.q: (calc_stats) Use moments data structure and
2694 calc_seskew(), calc_sekurt() functions.
2696 * set.q main.c settings.h Added support for --syntax and --algorithm
2699 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2701 * vfm.c: Had to get last call to multipass_split_output() inside
2702 open_active_file()/close_active_file() pairing, so introduce new
2704 (internal_procedure) Move procedure() code here, except for calls
2705 to open_active_file() and close_active_file().
2706 (procedure) Wrap open_active_file() and close_active_file() around
2707 internal_procedure().
2708 (multipass_procedure_with_splits) Wrap open_active_file() and
2709 close_active_file() around internal_procedure().
2711 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2713 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2715 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2717 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2719 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2721 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2723 * algorithm.c: By default turn off some of the more expensive
2725 (expensive_assert) New macro which expands to assert if
2726 EXTRA_CHECKS is defined, to nothing otherwise.
2727 (unique) Use expensive_assert().
2728 (binary_search) Ditto.
2734 * command.c: (conflicting_3char_prefixes) Words that are the same
2735 don't cause conflicts when they are abbreviated to the first three
2738 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2739 nonterm_node's n earlier.
2740 (generic_str_func) Ditto.
2742 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2744 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2745 test multipass support, take advantage of new moments
2746 calculation, and to not be such crappy code. Get rid of q2c
2747 processing for DESCRIPTIVES.
2749 * vfm.c: (struct multipass_split_aux_data) New structure.
2750 (multipass_procedure_with_splits) New function.
2751 (multipass_split_callback) New function.
2752 (multipass_split_output) New function.
2753 * descript.q: Removed.
2755 * descript.c: New file.
2757 * var.h: Removed descriptives enums.
2758 (struct descriptives_proc) Removed.
2759 (struct variable) Removed p.dsc.
2761 * Makefile.am: (q_sources_c) Remove descript.c.
2762 (q_sources_q) Removed descript.q.
2764 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2766 New manager for keeping track of used workspace.
2768 * workspace.c: New file.
2770 * workspace.h: New file.
2772 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2774 * sort.c: (do_internal_sort) Use workspace_malloc().
2775 (destroy_internal_sort) Use workspace_free().
2777 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2779 New `struct casefile' for managing sets of cases.
2781 * casefile.c: New file.
2783 * casefile.h: New file.
2785 * command.def: Add DEBUG CASEFILE command.
2787 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2789 * sort.c: (sort_cases) Move logic for sending storage file to disk
2790 into do_external_sort().
2791 (struct internal_sort) Use an array of ccase pointers instead of a
2793 (do_internal_sort) Rewrite to handle casefiles.
2794 (compare_case_list) Removed.
2795 (compare_cases) New function.
2796 (compare_case_dblptrs) New function.
2797 (read_internal_sort_output) Deal with new struct internal_sort.
2799 * vfm.c: (static var workspace_overflow) Removed.
2800 (struct storage_stream_info) Removed all the members. Added
2801 struct casefile * member.
2802 (storage_sink_open) Use casefile.
2803 (open_storage_file) Removed.
2804 (write_storage_file) Removed.
2805 (storage_to_disk) Removed.
2806 (destroy_storage_stream_info) Use casefile.
2807 (storage_sink_write) Use casefile.
2808 (storage_sink_make_source) Use casefile.
2809 (storage_source_count) Use casefile.
2810 (storage_source_read) Use casefile.
2811 (storage_source_on_disk) Removed.
2812 (storage_source_get_cases) Removed.
2813 (storage_source_set_cases) Removed.
2814 (storage_source_get_casefile) New function.
2816 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2818 New `struct moments' for calculating moments.
2824 * moments.c: New file.
2826 * moments.h: New file.
2828 * command.def: Add DEBUG MOMENTS command.
2830 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2833 * aggregate.c: Modify AGGREGATE to use the new moments
2834 calculation, even if not in such a great way.
2835 (struct agr_var) Add `moments' member.
2836 (parse_aggregate_functions) Set `moments' member to null.
2837 (agr_destroy) Destroy `moments' member.
2838 (accumulate_aggregate_info) Use `moments' for standard deviation.
2839 (dump_aggregate_info) Ditto.
2840 (initialize_aggregate_info) Create or clear `moments'.
2842 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2843 cube(), pow4() that were in stats.h. All references updated.
2845 * crosstabs.q: stats.h had chi-square significance functions. Use
2847 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2849 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2850 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2852 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2854 * dictionary.c: (dict_compact_values) Compacted values need to
2857 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2859 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2860 `/' at start. Check return value of parse_variables() for error
2863 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2865 Revamp expressions: make the code a little nicer, and fix bugs
2868 * expr-evl.c: (expr_evaluate) Make expression argument const.
2869 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2870 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2871 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2872 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2873 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2874 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2875 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2876 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2877 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2878 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2879 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2880 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2881 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2883 * expr-opt.c: (optimize_expression) Rewrite.
2888 (macro s0l) Removed.
2890 (macro s1l) Removed.
2892 (macro s2l) Removed.
2895 (eq_num_con) New function.
2896 (optimize_tree) New function.
2897 (macro rnc) Removed.
2898 (macro frnc) Removed.
2899 (str_search) Add const to string params.
2900 (str_rsearch) Ditto.
2901 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2902 str[], str_len[] locals to substitute for most of removed macros.
2903 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2904 Removed support for missing values because we're never called with
2905 missing values. Use set_number() or set_number_errno() instead of
2906 rnc or frnc. Removed any stuff that caused trouble in testing.
2907 We can re-add it later if it really slows anything. Fix some
2909 (evaluate_tree_with_missing) Not yet supported. To be added later
2911 (repl_num_con) Removed.
2912 (collapse_node) New function.
2913 (force_repl_num_con) Removed.
2914 (set_number) New function.
2915 (set_number_errno) New function.
2916 (repl_str_con) Removed.
2917 (set_string) New function.
2918 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2920 (dump_node) No special case for OP_AND, OP_OR.
2922 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2923 (expr_get_type) New function.
2924 (type_check) Rewrite.
2925 (type_coercion) New function.
2926 (struct operator) New structure.
2927 (match_operator New function.
2928 (parse_binary_operators) New function.
2929 (parse_inverting_unary_operator) New function.
2930 (parse_or) Rewritten.
2931 (parse_and) Rewritten.
2932 (parse_not) Rewritten.
2933 (parse_rel) Rewritten.
2934 (parse_add) Rewritten.
2935 (parse_mul) Rewritten.
2936 (parse_neg) Rewritten.
2937 (parse_exp) Rewritten.
2938 (parse_sysvar) Add $TRUE, $FALSE system variables.
2939 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2940 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2942 (struct function) Remove desc, change `func' prototype.
2943 (unary_func) Remove special cases.
2944 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2945 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2946 (VALUE_func) Use allocate_var_node().
2947 (nary_num_func) Allow MIN and MAX for strings.
2948 Use allocate_var_node(). Properly clean up.
2950 (generic_str_func) Use local table instead of removed `desc'
2951 member. Mostly rewrite.
2952 (get_num_args) Revise error message.
2953 (parse_function) Return EXPR_ERROR, not 0 on error.
2955 (macro varies) Removed.
2956 (ops[]) Use expr.def.
2957 (free_node) Do nothing if node is null.
2958 (allocate_num_con) New function.
2959 (allocate_str_con) New function.
2960 (allocate_var_node) New function.
2961 (allocate_binary_nonterminal) New function.
2962 (append_nonterminal_arg) Removed.
2963 (static var func_tab[]) Revised.
2964 (expr_debug_print_postfix) Make parameter const.
2965 Use printf() instead of debug_printf().
2967 * expr.def: New file.
2969 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2970 use named enum instead of unnamed, all references updated. Add
2971 EXPR_ANY, EXPR_NO_OPTIMIZE.
2973 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2974 instead of defining OP_* directly.
2975 (macro IS_TERMINAL) New macro.
2976 (macro IS_NONTERMINAL) New macro.
2977 (enum OP_NO_FLAGS) New.
2979 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2981 * error.c: (err_assert_fail) msg variable needs to be non-const.
2983 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2985 * debug.c: (cmd_debug_evaluate) Rewrite.
2987 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2989 Fix some CROSSTABS bit rot stupidity.
2991 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2992 (internal_cmd_crosstabs) Initializes cells[] correctly.
2993 (float_M_suffix) Rename format_cell_entry(), change prototype,
2995 (display_crosstabulation) Fix cell formatting.
2997 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2999 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
3000 to call lex_discard_line() to do that.
3002 * command.c: (run_command) Call lex_discard_line() after
3005 * lexer.c: (lex_entire_end) Change behavior.
3006 (lex_rest_of_line) Change behavior. Return const char *.
3007 (lex_discard_line) Don't clear getl_buf, don't emit message.
3009 * main.c: (handle_error) Emit message here.
3011 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
3012 instead of lex_entire_line().
3014 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
3016 * title.c: (get_title) Call lex_discard_line() after
3018 (cmd_file_label) Ditto.
3019 (cmd_document) Deal with const char * return value.
3021 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
3023 Removed REMARK command.
3025 * command.c: (extract_prefix) Removed.
3026 (output_line) Removed.
3027 (cmd_remark) Removed.
3029 * command.def: Remove REMARK.
3031 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
3033 Added abort() after lots of assert(0) invocations to avoid some
3034 compiler warnings. We really need a NOT_REACHED macro.
3036 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3038 * sort.c: Added missing call to temp_file_close. Changed error
3039 messages to warnings.
3041 * set.q: Improved setting of set_view{length,width} to be more tolerant
3044 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
3046 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
3047 used with incorrect syntax.
3049 * error.c, error.h et al: Overridden definition of assert for a
3052 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
3053 subcommand was given when it ought to have been.
3055 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
3057 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
3061 (tab_joint_text) Ditto.
3063 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
3065 * levene.c: Add #include.
3067 * set.q: (set_viewport) Add `int' argument to make its prototype
3068 correct for signal().
3070 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
3072 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
3075 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
3077 Changed DFM from open-at-first-access to explicit-open. Before,
3078 calling dfm_get_record() or dfm_put_record() would automatically
3079 open the file. Now, you have to call dfm_open_for_reading() or
3080 dfm_open_for_writing() explicitly. This makes it possible to
3081 check permissions, file existence, etc. earlier.
3083 Also made struct file_handle more opaque, and clean up in general.
3085 * data-list.c: (cmd_data_list) Open handle for reading.
3087 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
3089 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
3090 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
3091 (open_inline_file) Removed.
3092 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
3093 it. Deal with line_number in extension record instead of file
3095 (dfm_get_record) Rewrote.
3096 (dfm_put_record) Rewrote.
3097 (dfm_push) Assert file is open and one of ours. Deal with
3098 line_number in extension record instead of file handle.
3099 (dfm_pop) Assert file is open and one of ours. Deal with
3100 line_number in extension record instead of file handle.
3101 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
3104 * file-handle.h: (enum constants RH_RF_*) Removed.
3105 (enum constants FH_MD_*) Removed.
3106 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
3107 `recform', `lrecl', `mode' members. Public references to
3108 `recform' changed to use handle_get_mode(), references to `lrecl'
3109 changed to use handle_get_record_width(). Added `private' member.
3110 (enum file_handle_mode) New.
3112 * file-handle.q: (struct private_file_handle) New structure.
3113 (struct file_handle_list) New structure.
3114 (static var files) New.
3115 (static var file_handles) Removed.
3116 (init_file_handle) Removed.
3117 (create_file_handle) Removed.
3118 (get_handle_with_name) New function.
3119 (get_handle_for_filename) New function.
3120 (cmd_file_handle) Rewritten.
3121 (hash_file_handle) Removed.
3122 (cmp_file_handle) Removed.
3123 (fh_init_files) Rewritten.
3124 (fh_parse_file_handle) Rewritten. Allows identifiers as
3126 (fh_get_handle_by_name) Renamed handle_get_name(), all references
3128 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
3129 references updated. Rewritten.
3130 (fh_record_width) Renamed handle_get_record_width(), all
3131 references updated. Rewritten.
3132 (handle_get_mode) New function.
3134 * file-type.c: (cmd_file_type) Open handle for reading.
3136 * filename.c: [unix] (struct file_identity) New structure.
3137 [unix] (fn_get_identity) New function.
3138 [unix] (fn_free_identity) New function.
3139 [unix] (fn_compare_file_identities) New function.
3140 [!unix] (struct file_identity) New structure.
3141 [!unix] (fn_get_identity) New function.
3142 [!unix] (fn_free_identity) New function.
3143 [!unix] (fn_compare_file_identities) New function.
3145 * lexer.c: (static var put) Renamed put_token, all references
3147 (static var put_tokstr) New.
3148 (static var put_tokval) New.
3149 (lex_init) Initialize put_tokstr().
3150 (restore_token) New function.
3151 (save_token) New function.
3152 (lex_get) Use restore_token().
3153 (lex_put_back) Use save_token().
3154 (lex_put_back_id) New function.
3155 (lex_put_forward) Removed.
3156 (lex_preprocess_line) Set put_token instead of using
3158 (lex_negative_to_dash) Use save_token(), set put_token directly.
3159 (dump_token) Use stderr instead of stdout.
3161 * main.c: (main) Remove call to cmd_init().
3163 * matrix-data.c: (cmd_matrix_data) Open file for reading.
3165 * pfm-read.c: Use handle_get_filename() instead of trying to use
3166 h->fn directly, all over.
3168 * pfm-write.c: Ditto.
3170 * print.c: (internal_cmd_print) Open handle for writing.
3171 (dump_table) Use handle_get_filename().
3172 (print_trns_proc) Use handle_get_mode().
3173 (cmd_print_space) Use fh_parse_file_handle().
3174 Open handle for writing.
3175 [0] (debug_print) Removed.
3177 * sfm-read.c: Use handle_get_filename() instead of trying to use
3178 h->fn directly, all over.
3180 * sfm-write.c: Ditto.
3182 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
3186 * autorecode.c: (arc_free) Free arc->src_values.
3188 * error.c: (msg) Free buf.
3190 * val-labs.c: (do_value_labels) Always free vars.
3192 * vfm.c: (close_active_file) If sink has no make_source then call
3193 its destroy function.
3195 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
3197 Fixed cmd_parse() so that it always skips past a full command
3198 name. A few special commands for which this would be bad get
3199 special treatment. This lets us drop code for skipping past the
3200 end of a command name in most cmd_*() functions. It's not worth
3201 listing all the commands affected.
3203 * command.c: (struct command) Remove `cmd' member, replace by
3204 `name' member, all references updated. Remove `word', `next',
3205 `skip_entire_name' members.
3206 (macro DEFCMD) Deal with revised `struct command'.
3207 (macro UNIMPL) Ditto.
3208 (macro SPCCMD) New macro for commands whose last word shouldn't be
3210 (static array cmd_table[]) Make const, rename `commands', remove
3212 (macro COMMAND_CNT) New macro.
3213 (split_words) Removed.
3215 (FILE_TYPE_okay) Make parameter const.
3216 (cmd_parse) Improve error messages.
3217 (match_strings) New function.
3218 (next_word) New function.
3219 (enum command_match) New enum.
3220 (conflicting_3char_prefixes) New function.
3221 (conflicting_3char_prefix_command) New function.
3222 (cmd_match_words) New function.
3223 (count_matching_commands) New function.
3224 (get_command_name) New function.
3225 (free_words) New function.
3226 (unknown_command_error) New function.
3227 (figure_out_command) Renamed parse_command_name(), rewritten.
3229 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
3230 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
3231 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
3234 * command.h: (macro SPCCMD) New.
3236 * include.c: (cmd_include_at) Removed.
3237 (cmd_include) Allow identifier to be used as filename.
3239 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
3241 * t-test.q: (cmd_t_test) Command name is now parsed for us.
3244 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
3246 Start work on better test framework.
3248 * Makefile.am: (pspp_sources) Add debug.c.
3250 * debug.c: New file.
3252 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3253 cmd_debug_evaluate().
3255 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3257 * expr.h: (enum constant PXP_DUMP) Removed.
3259 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3261 * set.q: Implemented the SHOW command, and synced it to the existing
3264 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3265 changes as the window size is changed.
3267 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3268 environment variables if other methods are not available.
3270 glob.c: Removed a lot of global variables from glob.c and encapsulated
3273 random.c: Tidied up the way the random seed is set.
3275 str.c: Added a ds_vprintf function.
3277 error.c: Extended dump_message so that messages are always broken at
3280 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3282 * pfm-write.c: (bufwrite) Write out the correct element for string
3283 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3285 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3287 Get rid of static and global (!) vars in matrix-data.c.
3289 * matrix-data.c: (static var nr_data) Removed.
3290 (static var nr_factor_values) Removed.
3291 (static var max_cell_index) Removed.
3292 (static var split_values) Removed.
3293 (struct nr_aux_data) New structure.
3294 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3295 place of static vars, pass to create_case_source() and procedure()
3297 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3298 struct matrix_data_pgm *.
3299 (nr_read_splits) Ditto.
3300 (nr_read_factors) Ditto.
3301 (nr_output_data) Ditto.
3302 (static var wr_content) Removed.
3303 (global var wr_data) Removed.
3304 (global var wr_current) Removed.
3305 (struct wr_aux_data) New structure.
3306 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3307 place of static vars, pass to create_case_source() and procedure()
3309 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3310 instead of matrix_data_pgm *.
3311 (wr_read_splits) Ditto.
3312 (wr_output_data) Ditto.
3313 (wr_read_rowtype) Ditto.
3314 (wr_read_factors) Ditto.
3315 (wr_read_indeps) Ditto.
3317 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3319 Get rid of static vars in autorecode.c.
3321 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3322 `n_arc' to `spec_cnt'. All references updated.
3323 (static var v_src) Removed.
3324 (static var v_dest) Removed.
3325 (static var h_trns) Removed.
3326 (static var nv_src) Removed.
3327 (static var descend) Removed.
3328 (static var print) Removed.
3329 (enum direction) New enum.
3330 (struct autorecode_pgm) New structure.
3331 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3332 Move n_dest local var into struct autorecode_pgm for ease of
3333 clean-up. Use arc_free().
3334 (arc_free) New function.
3335 (recode) Modify to take struct autorecode_pgm * parameter instead
3336 of using statics. Let the caller clean up.
3337 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3338 instead of statics. Rearrange code a little.
3340 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3342 Get rid of static, global vars in recode.c. Remove debug code.
3344 * recode.c: (static var head) Removed.
3345 (global var v) Removed.
3346 (global var nv) Removed.
3347 (cmd_recode) New local variables head, v, nv. Initialize and free
3348 v. Don't call debug_print().
3349 [DEBUGGING] (dump_dest) Removed.
3350 [DEBUGGING] (debug_print) Removed.
3352 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3354 Get rid of static vars in expr-opt.c.
3356 * expr-opt.c: (static var e) Removed.
3357 (static var nop) Removed.
3358 (static var mop) Removed.
3359 (static var ndbl) Removed.
3360 (static var mdbl) Removed.
3361 (static var nstr) Removed.
3362 (static var mstr) Removed.
3363 (static var nvars) Removed.
3364 (static var mvars) Removed.
3365 (struct expr_dump_state) New structure.
3366 (dump_expression) Use new struct expr_dump_state instead of static
3367 vars and pass to functions we call.
3368 (dump_node) Use struct expr_dump_state * parameter.
3370 (emit_num_con) Ditto.
3371 (emit_str_con) Ditto.
3374 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3376 Get rid of static var in COUNT.
3378 * count.c: (static var head) Move into cmd_count().
3379 (cmd_count) [DEBUGGING] Don't call debug_print.
3380 [DEBUGGING] (debug_print) Removed.
3382 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3384 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3386 * val-labs.c: (static var v) Removed.
3387 (static var nv) Removed.
3388 [DEBUGGING] (debug_print) Removed.
3389 (verify_val_labs) Add struct variable **, int parameters.
3390 (get_label) Ditto. Improve error messages, streamline.
3391 (erase_labels) New function for erasing value labels, taking over
3392 part of verify_val_labs()'s function.
3395 (cmd_value_labels) No need to call init() or done() anymore.
3396 (cmd_add_value_labels) Ditto.
3397 (do_value_labels) Add vars, var_cnt local variables. Clean up
3398 after them internally. Call erase_labels() if we should. Don't
3401 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3403 Get rid of static vars in MATCH FILES.
3405 * get.c: (static var mtf_head) Removed.
3406 (static var mtf_tail) Removed.
3407 (static var mtf_by) Removed.
3408 (static var mtf_n_by) Removed.
3409 (static var mtf_master) Removed.
3410 (static var mtf_seq_num) Removed.
3411 (static var mtf_seq_nums) Removed.
3412 (static var mtf_sink) Removed.
3413 (static var mtf_case) Removed.
3414 (struct mtf_proc) New structure.
3415 (cmd_match_files) Use struct mtf_proc instead of static vars.
3416 (mtf_processing_finish) Ditto.
3418 (mtf_delete_file_in_place) Ditto.
3419 (mtf_read_nonactive_records) Ditto.
3420 (mtf_compare_BY_values) Ditto.
3421 (mtf_processing) Ditto.
3422 (mtf_merge_dictionary) Ditto.
3424 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3426 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3428 * dictionary.c: (dict_rename_var) Add assertion.
3429 (dict_contains_var) Check by index instead of name.
3431 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3433 Get rid of compaction_necessary, compaction_nval, compaction_case.
3434 Redo VFM interface. Replace disk_sink and memory_sink by
3435 storage_sink, disk_source and memory_source by storage_source.
3437 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3441 (struct write_case_data) Remove `begin_func', `end_func',
3442 `func_aux' members. Add `aux', `trns_case', `sink_case',
3443 `cases_written', `cases_analyzed' members.
3444 (global var compaction_necessary) Make static.
3445 (global var compaction_nval) Removed.
3446 (global var compaction_case) Removed.
3447 (static var case_count) Removed.
3448 (struct procedure_aux_data) Removed.
3449 (struct split_aux_data) Removed.
3450 (procedure) Remove begin_func, end_func parameters. Rewrite.
3451 (static var not_canceled) Removed.
3452 (process_active_file) Removed.
3453 (process_active_file_write_case) Removed.
3454 (process_active_file_output_case) Removed.
3455 (prepare_for_writing) Moved into open_active_file().
3456 (arrange_compaction) Ditto.
3458 (open_active_file) Rewrote.
3459 (write_case) New function.
3460 [DEBUGGING] (index_to_varname) Removed.
3461 (execute_transformations) New function.
3462 (exclude_this_case) Renamed filter_case(), changed interface.
3463 (clear_case) Added struct ccase * parameter to interface.
3464 (close_active_file) Added struct write_case_data * parameter,
3466 (disk_sink_create) Removed.
3467 (disk_sink_destroy) Removed.
3468 (disk_sink_make_source) Removed.
3469 (disk_sink_write) Removed.
3470 (disk_source_count) Removed.
3471 (disk_source_destroy) Removed.
3472 (disk_source_read) Removed.
3473 (global var disk_sink_class) Removed.
3474 (global var disk_source_class) Removed.
3475 (global var memory_sink_class) Removed.
3476 (global var memory_source_class) Removed.
3477 (memory_sink_create) Removed.
3478 (memory_sink_destroy) Removed.
3479 (memory_sink_make_source) Removed.
3480 (memory_sink_write) Removed.
3481 (memory_source_count) Removed.
3482 (memory_source_destroy) Removed.
3483 (memory_source_get_cases) Removed.
3484 (memory_source_read) Removed.
3485 (memory_source_set_cases) Removed.
3486 (struct disk_stream_info) Removed.
3487 (struct memory_sink_info) Removed.
3488 (struct memory_source_info) Removed.
3489 (write_active_file_to_disk) Removed.
3490 (destroy_storage_stream_info) New function.
3491 (global var null_sink_class) New var.
3492 (global var storage_sink_class) New var.
3493 (global var storage_source_class) New var.
3494 (open_storage_file) New function.
3495 (storage_sink_destroy) New function.
3496 (storage_sink_make_source) New function.
3497 (storage_sink_open) New function.
3498 (storage_sink_write) New function.
3499 (storage_source_count) New function.
3500 (storage_source_destroy) New function.
3501 (storage_source_get_cases) New function.
3502 (storage_source_on_disk) New function.
3503 (storage_source_read) New function.
3504 (storage_source_set_cases) New function.
3505 (storage_source_to_disk) New function.
3506 (storage_to_disk) New function.
3507 (struct storage_stream_info) New structure.
3508 (write_storage_file) New function.
3509 (procedure_write_case) Removed.
3510 (create_case_source) Add `struct dictionary *' parameter, all
3512 (create_case_sink) Ditto.
3513 (free_case_sink) New function.
3514 (struct split_aux_data) New structure.
3515 (procedure_with_splits) New function implementing what procedure()
3517 (SPLIT_FILE_proc_func) Removed.
3518 (procedure_with_splits_callback) New function.
3519 (equal_splits) New function.
3521 * aggregate.c: Pass around a struct instead of using statics.
3522 (static var outfile) Remove.
3523 (enum type) Give it tag `missing_treatment'.
3524 (static var missing) Remove.
3525 (static var sort) Remove.
3526 (static var agr_first) Remove.
3527 (static var agr_next) Remove.
3528 (static var case_count) Remove.
3529 (static var prev_case) Remove.
3530 (static var buf64_1xx) Remove.
3531 (static var buf_1xx) Remove.
3532 (struct agr_proc) New structure incorporating the above.
3533 (cmd_aggregate) Use new struct. Clean up error handling using
3534 agr_destroy(). Completely rewrite actual implementation of
3536 (create_sysfile) Add struct agr_proc * parameter, modify
3538 (parse_aggregate_functions) Ditto.
3539 (free_aggregate_functions) Ditto. Rename agr_destroy().
3540 (aggregate_single_case) Add struct agr_proc * parameter, modify
3542 (accumulate_aggregate_info) Ditto.
3543 (dump_aggregate_info) Ditto.
3544 (initialize_aggregate_info) Ditto.
3545 (agr_00x_trns_proc) Removed.
3546 (agr_00x_end_func) Removed.
3547 (agr_10x_trns_proc) Removed.
3548 (agr_10x_trns_free) Removed.
3549 (agr_10x_end_func) Removed.
3550 (agr_11x_read) Removed.
3551 (agr_11x_finish) Removed.
3552 [DEBUGGING] (debug_print) Removed.
3553 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3555 (agr_to_active_file) New function.
3556 (presorted_agr_to_sysfile) New function.
3557 (sort_agr_to_sysfile) New function.
3559 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3561 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3563 * descript.q: (cmd_descriptives) Ditto.
3565 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3566 to new procedure() interface.
3568 * command.c: (cmd_execute) Adapt to new procedure() interface.
3570 * dictionary.c: (dict_compact_values) Also delete scratch
3572 (dict_get_compacted_value_cnt) New function.
3573 (dict_get_compacted_idx_to_fv) New function.
3575 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3576 (cmd_flip) Adapt to new procedure() interface.
3577 (flip_sink_write) Use sink->idx_to_fv.
3579 * frequencies.q: (internal_cmd_frequencies) Use
3580 procedure_with_splits().
3582 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3583 (static var mtf_sink) New static var.
3584 (static var mtf_case) New static var.
3585 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3586 we actually implement the matching.
3587 (mtf_delete_file_in_place) Use mtf_case.
3588 (mtf_processing) Use mtf_case and mtf_sink.
3589 (cmd_export) Adapt to new procedure() interface.
3591 * levene.c: (levene) Use procedure_with_splits().
3593 * list.q: (cmd_list) Use procedure_with_splits().
3595 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3596 procedure() interface.
3597 (read_matrices_with_rowtype) Ditto.
3599 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3600 TEMPORARY. Adapt to new procedure() interface.
3602 * rename-vars.c: Warn about and cancel TEMPORARY.
3604 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3605 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3606 compaction_nval. Adapt to new procedure() interface. Use
3607 storage_source_to_disk().
3608 (do_internal_sort) Don't try to dump the cases to memory.
3609 (compare_case_lists) Pass null idx_to_fv.
3610 (struct initial_run_state) Add `idx_to_fv' member. Remove
3612 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3613 new procedure() interface. Reset irs->idx_to_fv after calling
3615 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3616 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3618 (destroy_initial_run_state) Don't dereference irs after freeing
3620 (allocate_cases) Don't calculate case_size locally.
3621 (compare_record) Add idx_to_fv parameter.
3622 (compare_record_run) Change parameter from struct sort_cases_pgm *
3623 to struct initial_run_state *. Pass irs->idx_to_fv to
3625 (compare_record_run) Third parameter now a struct
3626 initial_run_state *.
3627 (output_record) No need for out_case anymore. Pass irs, not
3628 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3630 (merge) Use case_size from struct sort_cases_pgm.
3631 (merge_once) Use case_size from struct sort_cases_pgm.
3632 Pass null pointer to compare_record() as idx_to_fv.
3633 (global var sort_sink_class) Make static.
3635 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3637 * temporary.c: Remove debugging crap.
3639 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3641 * t-test.q, levene.c: Fixed up the handling of MISSING values
3644 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3646 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3649 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3651 Change explicit variable name checks into use of
3652 dict_class_from_id().
3654 * dictionary.c: (dict_create_var) Change explicit variable name
3655 check into use of dict_class_from_id().
3657 * get.c: (trim_dictionary) Ditto.
3659 * sel-if.c: (cmd_filter) Ditto.
3661 * sysfile-info.c: (cmd_display) Ditto.
3663 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3665 * vfm.c: (arrange_compaction) Ditto.
3667 * weight.c: (cmd_weight) Ditto.
3669 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3671 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3672 transformation following the input program, if any, for some
3673 reason we special-cased f_trns. That's just wrong. It should
3674 always be set to n_trns.
3676 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3678 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3679 introduced in last check-in.
3681 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3683 * format.c: (global array translate_fmt[]) Removed.
3684 (translate_fmt) New function as replacement.
3685 (parse_format_specifier_name) Rewrite.
3687 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3690 * sfm-read.c: (parse_format_spec) Ditto.
3692 * postscript.c: (text) Fix handling of fonts with missing
3695 * sort.c: (struct external_sort) Add temp_name member.
3696 (destroy_external_sort) Free temp_dir, temp_name members.
3697 (init_external_sort) Allocate temp_name.
3698 (get_temp_file_name) Change prototype.
3699 (open_temp_file) Deal with change to get_temp_file_name().
3700 (close_temp_file) Ditto.
3701 (remove_temp_file) Ditto.
3702 (write_temp_file) Ditto.
3703 (read_temp_file) Ditto.
3704 (sort_sink_destroy) Removed.
3705 (sort_sink_class) Change destroy member to null.
3707 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3709 Eliminate temp_case.
3711 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3712 anymore. Use agr_11x_finish().
3713 (aggregate_single_case) Make first param const.
3714 (accumulate_aggregate_info) Ditto.
3715 (agr_00x_end_func) Use compaction_case, not temp_case.
3716 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3718 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3719 (cmd_data_list) Initialize case_size.
3720 (read_from_data_list_fixed) Add struct ccase * param, use instead
3722 (read_from_data_list_free) Ditto.
3723 (read_from_data_list_list) Ditto.
3724 (read_one_case) Rename data_list_trns_proc(), all references
3725 updated. Add argument in calling above functions. Use c
3726 argument instead of temp_case.
3727 (destroy_dls) Rename data_list_trns_free(), all references
3730 * expr-evl.c: (expr_evaluate) Make second parameter const.
3732 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3733 (cmd_end_file_type) Initialize `case_size'.
3734 (file_type_source_read) Add struct ccase * parameter. Use instead
3737 * flip.c: Rewritten.
3739 * get.c: (struct get_pgm) New structure to keep track of
3741 (cmd_get) Initialize case_size.
3743 (get_source) Deal with struct get_pgm.
3744 (get_source_read) Add struct ccase * parameter, use instead of
3746 (import_source_read) Ditto.
3748 * get.c: Use a null pointer instead of temp_case to represent the
3749 "current case" in a struct mtf_file's input member.
3750 (mtf_processing_finish) Pass null to mtf_processing(), not
3752 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3753 (mtf_compare_BY_values) Add extra arg, use instead of null input
3755 (mtf_processing) Use c parameter instead of temp_case. Pass
3756 compaction_case to process_active_file_output_case().
3758 * glob.c: (global variable temp_case) Removed.
3760 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3761 (cmd_input_program) Initialize case_size. Set
3762 vfm_source->value_cnt.
3763 (init_case) Add struct ccase * parameter, use instead of
3766 (input_program_source_read) Ditto.
3768 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3769 (dump_cell_content) Ditto.
3770 (nr_output_data) Ditto.
3771 (read_matrices_without_rowtype) Ditto.
3772 (matrix_data_read_with_rowtype) Ditto.
3773 (wr_read_splits) Ditto.
3774 (wr_output_data) Ditto.
3776 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3778 * sort.c: (sort_cases) Initialize scp->case_size.
3779 (struct external_sort) Remove `case_size' member.
3780 (write_initial_runs) Only call vfm_sink->class_destroy if
3782 (struct sort_source_aux) New structure.
3783 (sort_source_read_helper) New function.
3784 (sort_source_read) Use sort_source_read_helper().
3785 (read_sort_output) Change interface to be more reasonable.
3786 (read_internal_sort_output) Ditto.
3787 (read_external_sort_output) Ditto.
3789 * vars-prs.c: (dict_class_to_name) Pass return value through
3792 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3793 (procedure) Initialize trns_case.
3794 (procedure) Pass trns_case to vfm_source->class->read().
3796 (process_active_file) Start using struct procedure_aux_data.
3797 (process_active_file_write_case) Pass trns_case to
3798 transformations, lag_case(), clear_case().
3799 (process_active_file_output_case) Add struct ccase * parameter.
3800 (create_trns_case) New function.
3801 (make_temp_case) Removed.
3802 (vector_initialization) Removed.
3803 (close_active_file) Only call make_source if non-null, otherwise
3804 set vfm_source to null pointer. Don't free temp_case.
3805 (disk_source_read) Add struct ccase * parameter, use instead of
3807 (memory_source_read) Ditto.
3808 (lag_case) Add const struct ccase * member.
3809 (procedure_write_case) Use trns_case instead of temp_case.
3810 (clear_case) Add struct ccase * member, use instead of temp_case.
3811 (exclude_this_case) Ditto.
3812 (create_case_source) Add struct dictionary * parameter, use to
3813 initialize source->value_cnt.
3815 * vfm.h: (struct case_source) Add `value_cnt' member.
3816 (struct case_source_class) Add struct ccase * parameter to `read'
3817 member function pointer.
3818 (struct case_sink_class) Make struct ccase * parameter const in
3819 `write' member function pointer.
3821 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3823 Fix a lot of "possibly uninitialized variable" warnings. Some of
3824 them are even real bugs. A few of them make me wonder how the
3827 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3829 * ascii.c: (output_lines) Add default case to switch.
3831 * crosstabs.q: Remove static variable `expected' and all
3833 (display_crosstabulation) Always calculate expected value.
3835 (output_pivot_table) Initialize `cmp'.
3836 (display_crosstabulation) New variable `last_row', which is
3839 * data-in.c: (parse_numeric) Always initialize sign. How did this
3842 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3843 Always set info.ofs. (How did this work?!)
3845 * expr-opt.c: (optimize_tree) Always initialize `m'.
3846 (evaluate_tree) Always initialize `c'. (How did this work?)
3848 * frequencies.q: (frq_custom_variables) Always initialize min,
3850 (frq_custom_grouped) Always initialize `dl'.
3852 * groff-font.c: (groff_read_font) Always initialize char_set.
3854 * matrix-data.c: (nr_output_data) Initialize `split'.
3855 (wr_read_splits) Remove shadowing split_cnt declaration.
3856 (wr_output_data) Initialize `split'.
3858 * output.c: (tokener) Skip add character on syntax error.
3860 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3862 * postscript.c: (read_ps_encodings) Use line.string instead of
3864 (write_text) Add default case to switch.
3865 (text) Always initialize multiple variables. Fix bug with
3868 * print.c: (fixed_parse_fortran) Initialize head.
3869 (alloc_line) Add default case to switch.
3871 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3872 (recode_trns_proc) Move variable declaration inward. Add default
3875 * sfm-read.c: (read_header) Initialize skip_amt.
3877 * sysfile-info.c: (display_variables) Always initialize pc.
3879 * vars-prs.c: Initialized `included'.
3881 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3883 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3884 Just use signal() instead.
3886 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3888 Get rid of vfm_sink_info and vfm_source_info.
3890 * aggregate.c: (agr_00x_end_func) Don't increment
3891 sfm_sink_info.ncases.
3893 * sort.c: (do_internal_sort) Get case count from
3894 vfm_source->class->count().
3895 (struct external_sort) Add `case_size' member.
3896 (do_external_sort) Initialize case_size.
3897 (struct initial_run_state) Add `case_size' member.
3898 (write_initial_runs) Initialize case_size.
3899 (sort_sink_write) Use case_size.
3900 (read_external_sort_output) Use case_size. Get case_cnt from
3903 * vfm.c: (struct write_case_data) Add underscores to existing arg
3904 names, all references updated. Renamed `aux' as `func_aux', all
3905 references updated. Added new `aux' member.
3906 (global var vfm_source_info) Removed.
3907 (global var vfm_sink_info) Removed.
3908 (struct procedure_aux_data) New.
3909 (struct split_aux_data) New.
3910 (procedure) Use `aux' fields for procedure_aux_data,
3912 (process_active_file_write_case) Pass case_count + 1 to
3913 transformation procedures, exclude_this_case().
3914 (process_active_file_output_case) Don't increment
3915 vfm_sink_info.ncases.
3916 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3917 to send data to disk early.
3918 (make_temp_case) Don't use vfm_sink_info.case_size.
3919 (close_active_file) Don't initialize vfm_source_info.
3920 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3921 (disk_sink_create) Initialize and/or update disk_stream_info.
3922 (disk_sink_write) Ditto.
3923 (disk_sink_destroy) Ditto.
3924 (disk_sink_make_source) Ditto.
3925 (disk_source_read) Ditto.
3926 (disk_source_destroy) Ditto.
3927 (global var disk_source_class) Add disk_source_count().
3928 (disk_source_count) New function.
3929 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3930 (struct memory_source_info) Ditto.
3931 (memory_sink_create) Deal with case_cnt, case_size.
3932 (memory_sink_write) Ditto.
3933 (memory_sink_make_source) Ditto.
3934 (memory_source_read) Ditto.
3935 (memory_source_count) New function.
3936 (memory_source_class) Add memory_source_count().
3937 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3938 proc_aux->cases_written, and pass it to transformation procedures
3939 and exclude_this_case ().
3940 (exclude_this_case) Add case_num parameter. Pass it to
3942 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3945 * vfm.h: (struct case_source_class) Add `count' member.
3947 * vfmP.h: (struct stream_info) Removed.
3948 (global variable vfm_source_info) Removed.
3949 (global variable vfm_sink_info) Removed.
3951 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3953 * var.h: (typedef trns_proc_func) New typedef.
3954 (trns_free_func) New typedef.
3955 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3956 to type trns_free_func. This only changes the actual type of
3957 trns_proc_func, adding a `case_num' parameter. Updated all
3958 implementations to use the typedefs instead.
3960 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3961 (compute_num_vec) Ditto.
3962 (compute_str) Ditto.
3963 (compute_str_vec) Ditto.
3965 * do-if.c: (do_if_trns_proc) Ditto.
3967 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3970 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3971 pass to transformation functions.
3972 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3974 * loop.c: (loop_1_trns_proc) Ditto.
3975 (loop_2_trns_proc) Ditto.
3976 (loop_3_trns_proc) Ditto.
3978 * print.c: (print_space_trns_proc) Ditto.
3980 * sel-if.c: (select_if_proc) Ditto.
3982 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3984 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3985 destroying hash table.
3987 * glob.c: (read_active_file) Variable not referenced, removed.
3988 (cancel_input_pgm) Ditto.
3990 * levene.c: Add #include <stdlib.h> needed to call free().
3992 * aggregate.c: (parse_aggregate_functions) Make `function'
3995 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3997 Start working to eliminate VFM dependence on static variables.
3999 * command.c: (cmd_parse) Use case_source_is_class().
4001 * data-list.c: Rewrite to eliminate use of static variables.
4003 * dfm.c: (cmd_begin_data) Use case_source_is_class().
4005 * file-handle.q: (fh_handle_name) Make parameter const.
4007 * file-type.c: Rewrite to eliminate use of static variables.
4009 * flip.c: Rewrite to eliminate use of static variables.
4011 * format.c: (get_format_var_width) New function.
4013 * get.c: Eliminate use of static variables.
4015 * inpt-pgm.c: Eliminate use of static variables.
4017 * matrix-data.c: Eliminate use of static variables.
4019 * set.q: (set_max_workspace) New variable.
4020 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
4022 * var.h: (struct case_list) Move here from vfmP.h.
4024 * vars-atr.c: (discard_variables) Handle new vfm_source type.
4026 * vfm.c: (vfm_source) Change type from struct case_stream to
4028 (vfm_sink) Change type from struct case_stream to struct
4030 (static var paging) Rename workspace_overflow, all references
4032 (procedure) Use new class structures.
4033 (process_active_file) Ditto.
4034 (process_active_file_write_case) Ditto.
4035 (prepare_for_writing) Use set_max_workspace. Use new class
4037 (close_active_file) Use new class structures. Free old sink.
4038 (global var disk_source_file) Removed.
4039 (global var disk_sink_file) Removed.
4040 (disk_stream_init) Removed.
4041 (disk_stream_read) Removed.
4042 (disk_stream_write) Removed.
4043 (disk_stream_mode) Removed.
4044 (disk_stream_destroy_source) Removed.
4045 (disk_stream_destroy_sink) Removed.
4046 (global var vfm_disk_stream) Removed.
4047 (disk_sink_create) New function.
4048 (disk_sink_write) New function.
4049 (disk_sink_destroy) New function.
4050 (disk_sink_make_source) New function.
4051 (disk_sink_class) New static var.
4052 (disk_source_read) New function.
4053 (disk_source_destroy) New function.
4054 (global var vfm_source_class) New var.
4055 (global var memory_source_cases) Removed.
4056 (global var memory_sink_cases) Removed.
4057 (global var memory_sink_max_cases) Removed.
4058 (struct memory_sink_info) New struct.
4059 (memory_stream_init) Removed.
4060 (memory_stream_read) Removed.
4061 (memory_stream_write) Removed.
4062 (memory_stream_mode) Removed.
4063 (memory_stream_destroy_source) Removed.
4064 (memory_stream_destroy_sink) Removed.
4065 (global var vfm_memory_stream) Removed.
4066 (page_to_disk) Renamed write_active_file_to_disk().
4067 (memory_sink_create) New function.
4068 (memory_sink_write) New function.
4069 (memory_sink_destroy) New function.
4070 (memory_sink_make_source) New function.
4071 (memory_sink_class) New static var.
4072 (memory_source_read) New function.
4073 (memory_source_destroy) New function.
4074 (memory_source_get_cases) New function.
4075 (memory_source_set_cases) New function.
4076 (global var vfm_source_class) New var.
4077 (procedure_write_case) Use new class structures.
4078 (create_case_source) New function.
4079 (case_source_is_complex) New function.
4080 (case_source_is_class) New function.
4081 (create_case_sink) New function.
4083 * vfm.h: (global variable reinit_sysmis) Not used, removed.
4084 (global variable reinit_blanks) Not used, removed.
4085 (global variable init_zero) Not used, removed.
4086 (global variable init_blanks) Not used, removed.
4087 (struct case_source) New struct.
4088 (struct case_source_class) New struct.
4089 (struct case_sink) New struct.
4090 (struct case_sink_class) New struct.
4091 (struct case_stream) Removed.
4093 * vfmP.h: (struct case_list) Moved to var.h.
4095 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
4097 * algorithm.c: (count_equal) New function.
4098 (count_if) New function.
4099 (unique) Add assertions.
4100 (partition) Add assertions.
4101 (is_partitioned) New function.
4102 (copy_if) Add assertions.
4103 (remove_equal) Add assertions.
4104 (lexicographical_compare) Rename lexicographical_compare_3way.
4105 (sort) Add assertions. Rephrase some code.
4106 (is_sorted) New function.
4108 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
4112 * sort.c: Completely rewrite.
4114 * sort.h: Expose interface via struct sort_cases_pgm, not via
4117 * aggregate.c: (sort) New static var.
4118 (cmd_aggregate) Use sort.
4119 (create_sysfile) Ditto.
4120 (aggregate_single_case) Ditto.
4121 (dump_aggregate_info) Ditto.
4122 (agr_00x_end_func) Ditto.
4123 (debug_print) Ditto.
4125 * var.h: (enum SRT_ASCEND) Removed.
4126 (enum SRT_DESCEND) Removed.
4127 (struct sort_cases_proc) Removed.
4128 (struct variable) Remove p.srt member.
4130 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
4132 Get rid of the old, crappy heap structure and replace it by a new,
4133 shiny, C++ STL-like heap structure.
4135 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
4137 * algorithm.c: (push_heap) New function.
4148 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
4150 Increase warning level.
4152 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
4154 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
4156 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
4158 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
4160 * dictionary.c: (dict_create_var) Fix root cause of bug worked
4161 around by previous change log entry.
4163 * compute.c: (lvalue_finalize) Remove workaround from previous
4166 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4168 * compute.c: Fixed a bug where the Format was not getting set for
4169 computed variables (thus causing a crash when SAVEing).
4171 * Added a test to stop this bug ever coming back
4173 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
4175 Got rid of approx.h. In general, replaced all references to
4176 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
4179 * Makefile.am: (pspp_SOURCES) Removed approx.h.
4181 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
4182 test for mag < EPSILON.
4184 * misc.h: Add definition of EPSILON.
4186 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
4188 * vfm.c: (procedure) Add check to prevent recursive call.
4190 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
4192 * Moved the declarations relating to values to their own header file
4195 * Added levene.c and levene.h
4197 * vars-atr.c: Changed the signature of compare_values to
4198 take const * arguments.
4200 * t-test.q: Changed the structure of struct t_test_proc
4201 variables now contain their own group statistics information.
4202 Eventually, t_test_proc might get renamed, because it'd be
4203 applicable to other commands too.
4205 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
4207 * data-out.c: Clean up. Changed interface of convert_*() to take
4208 either a `double' or a `const char *' instead of a `const union
4209 value *'. Update all implementations of those interfaces.
4210 (data_out) Use switch statements instead of a table.
4211 (convert_AHEX) Rewrite.
4213 * format.h: Update comment.
4215 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
4217 * q2c.c: (dump_header) Add an Emacs header line to output files
4218 that makes generated .c files read-only by default, to make it
4219 difficult to accidentally change generated files.
4221 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
4223 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
4224 not bogus a->v.c <=> b->v.c pointer compare.
4225 (compare_freq_alpha_a) Ditto.
4226 (compare_freq_numeric_d) Ditto.
4227 (compare_freq_alpha_d) Ditto.
4229 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
4231 Changed data_out() to store string data directly into a `union
4232 value''s s member, not indirectly into c.
4234 * crosstabs.q: (output_pivot_table) Use format_short() instead of
4236 (table_value_missing) Ditto.
4237 (float_M_suffix) Ditto.
4238 (format_short) New function.
4240 * data-in.h: (data_in_finite_line) Remove inline definition.
4242 * data-list.c: (destroy_dls_var_spec) New function.
4243 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
4244 (data_list_source_destroy_source) Avoid cast.
4245 (struct repeating_data_trns) New field `id_value'. Update
4247 (cmd_repeating_data) Initialize id_value. Use new
4248 repeating_data_trns_free() for freeing REPEATING DATA
4250 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4251 (repeating_data_trns_free) New function.
4253 * data-out.c: (data_out) Change return type to `void' by replacing
4254 error returns by writing a message into the output buffer.
4255 (convert_A) Read from v->s instead of v->c.
4256 (convert_AHEX) Ditto.
4258 * expr-evl.c: Update comment.
4259 (expr_evaluate) Add assertion in OP_STRING case.
4261 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4263 * list.q: (list_cases) Update for new data_out() semantics.
4265 * print.c: (print_trns_proc) Ditto.
4267 * tab.c: (tab_value) Ditto.
4268 (tab_float) Avoid stupid cast.
4270 * var.h: Update comments.
4271 (macro MAX_STRING) New macro.
4272 (macro MAX_ELEMS_PER_VALUE) New macro.
4274 * vars-atr.c: (compare_values) New function.
4276 * vfm.c: (dump_splits) Update for new data_out() semantics.
4278 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4280 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4282 (struct crosstab) Rename v[] to vars[]. All references updated.
4283 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4284 same time, which caused the hash value to depend only on a single
4285 value, not all of the variables' values.
4287 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4289 Clean up struct dictionary's value_cnt usage.
4291 * dictionary.c: Add a function comment to each function.
4292 (struct dictionary) Rename value_cnt to next_value_idx, which more
4293 accurately reflects its meaning. All references updated.
4294 (dict_rename_vars) Add assertion.
4295 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4297 (dict_get_case_size) New function.
4299 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4301 * get.c: (mtf_read_nonactive_records) Ditto.
4303 * sort.c: (allocate_cases) Ditto.
4304 (write_initial_runs) Ditto.
4308 * vfm.c: (prepare_for_writing) Ditto.
4312 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4314 Make vfm.c slightly less grotesque.
4316 * vfm.c: (filter_var) Removed.
4317 (filter_index) Removed.
4318 (FILTERED macro) Removed.
4319 (exclude_this_case) New function.
4320 (process_active_file_write_case) Use exclude_this_case() instead
4321 of FILTERED and inline tests.
4322 (procedure_write_case) Ditto.
4323 (setup_filter) Removed.
4324 (open_active_file) Don't call setup_filter().
4325 (close_active_file) Call dict_get_filter() instead of checking
4328 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4330 * var.h: (struct variable) Update comments.
4332 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4334 New functions dict_create_var_assert(), dict_lookup_var_assert().
4335 Converted several dict_*_var()/assert pairs into a single
4336 dict_*_var_assert().
4338 * dictionary.c: (dict_create_var_assert) New function.
4339 (dict_lookup_var_assert) New function.
4341 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4343 Got rid of "struct long_vec", envector(), devector(), etc. Added
4344 two members `init', `reinit' to struct variable as a substitute.
4346 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4352 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4355 * autorecode.c: (cmd_autorecode) destvars don't need init.
4357 * compute.c: (lvalue_finalize) Set reinit.
4359 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4360 (dump_fmt_list) Ditto.
4363 * descript.q: (run_z_pass) Don't need init for z-scores.
4365 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4367 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4369 * glob.c: (init_glob) Remove vec_init() calls.
4371 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4373 * loop.c: (internal_cmd_loop) Don't need to call envector().
4375 * numeric.c: (cmd_numeric) Ditto.
4377 (cmd_leave) Ditto. Set `init', `reinit' members.
4379 * recode.c: (cmd_recode) Don't need to call envector().
4381 * repeat.c: (internal_cmd_do_repeat) Ditto.
4383 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4384 (force_create_variable) Removed prototype.
4385 (force_dup_variable) Ditto.
4387 * vector.c: (cmd_vector) Don't need to call envector().
4389 * vfm.c: (reinit_sysmis) Removed.
4390 (reinit_blanks) Removed.
4391 (init_zero) Removed.
4392 (init_blanks) Removed.
4393 (process_active_file_write_case) No need to deal with vectors.
4394 Call clear_temp_case().
4395 (vector_initialization) Rewrite to use `init', `reinit'.
4396 (close_active_file) No need to call vec_clear().
4397 (procedure_write_case) Call clear_temp_case().
4398 (clear_temp_case) New function.
4400 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4402 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4405 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4407 Add auxiliary argument to procedure() interface. Associated small
4408 clean-ups of vfm interface.
4410 * Updated every caller of procedure() and process_active_file() to
4411 reflect modified interface. Simple, ordinary changes not listed
4414 * Updated every function that implements struct case_stream's
4415 `read' function to take a write_case_func and a write_case_data.
4416 Also updated every caller of write_case() to instead call them
4417 through these arguments. In some cases this meant that the extra
4418 args had to be threaded through a couple of extra levels. This
4419 wasn't difficult or interesting so the details won't be given.
4421 * data-list.c: (struct repeating_data_trns) Add members
4422 `write_case', `wc_data' as kluge.
4423 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4425 (repeating_data_set_write_case) New function.
4427 * data-list.h: New file to declare repeating_data_trns_proc() and
4428 repeating_data_set_write_case().
4430 * inpt-pgm.c: (input_program_source_read) Call
4431 repeating_data_set_write_case() for all the REPEATING DATA
4432 transformations, so that they know where to send their cases.
4433 It's a big kluge. Also kluge in END CASE.
4434 (end_case_trns_proc) Never called anymore, but we still need it,
4437 * sort.c: (read_sort_output) Update to match struct case_stream
4440 * vfm.c: (struct write_case_data) New structure.
4441 (proc_func) Removed.
4442 (virt_proc_func) Removed.
4443 (begin_func) Removed.
4444 (virt_begin_func) Removed.
4446 (write_case) Removed.
4447 (procedure) Added an auxiliary parameter to each function pointer
4448 argument's prototype. Added an auxiliary data parameter.
4450 (process_active_file) Ditto.
4451 (process_active_file_write_case) Pass aux data along.
4452 (close_active_file) Ditto.
4453 (procedure_write_case) Ditto.
4454 (SPLIT_FILE_procfunc) Ditto.
4456 * vfm.h: (typedef write_case_data) New.
4457 (typedef write_case_func) New.
4458 (struct case_stream) Add parameters to `read' member prototype.
4460 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4462 * t-test.q: Added calculations for independent samples. (But no Levene
4465 * Makefile.am: Moved q_sources_c into own variable
4467 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4469 Miscellaneous cleanups.
4471 * Change unused to UNUSED in many source files to reflect modified
4472 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4473 __CYGWIN32__, __unix__, and unix not to assume that they're
4474 defined to a nonzero value. Change use of __attribute__ to use
4475 NO_RETURN or PRINTF_FORMAT instead.
4477 * alloc.h: Move definitions for local_alloc(), local_free() here
4478 from ../pref.h.orig and simplify.
4480 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4481 use a pool allocator unconditionally.
4482 (CHECK_STRING_SPACE) Removed.
4483 (ALLOC_STRING_SPACE) Removed.
4484 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4487 * expr-opt.c: (dump_expression) Allocate string pool.
4489 * expr-prs.c: (expr_free) Free string pool.
4491 * pool.c: (pool_destroy) This pool must be removed from its
4492 parent's list of gizmos, not from its own. Use free_all_gizmos().
4493 (pool_clear) New function.
4494 (free_all_gizmos) New function.
4495 (pool_alloc) Use space in empty block after this one if any.
4496 (pool_release) Only empty out blocks, don't actually free() them.
4498 * print.c: Get rid of PAGED_STACK special case by always
4499 dynamically allocating line buffers.
4500 (struct print_trns) Always include the `line' member.
4501 (internal_cmd_print) Always initialize the `line' member.
4502 (alloc_line) Always allocate memory for `line'.
4503 (print_trns_proc) Always initialize buf from `line' member.
4504 (print_trns_free) Always free `line' memory.
4506 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4509 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4511 * flip.c: Fixed crash from FLIP when a numeric variable is
4512 specified on NEWNAMES and a large value is used, and a couple of
4513 other minor bugs besides.
4514 (struct varname) Make name a 9-character fixed-size array
4515 instead of a 1-character variable size array.
4516 (make_new_var) Allow digits in variable names.
4517 (flip_stream_write) Limit numeric values to 8 characters and
4518 format system missing and very large and small values more
4521 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4523 * command.c: Fixed test on command return status for the correct
4524 value, which had been causing a crash under certain invalid input.
4526 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4528 * t-test.q: Added calculations for the one sample variant of the T-TEST
4530 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4532 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4533 in joined cells to be rendered outside box boundaries.
4535 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4537 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4538 SET seed=xx has been called.
4540 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4542 * random.c (rng_get_double): Fix always-returning-zero bug in my
4543 preferred way, and at the same time make sure rounding doesn't
4546 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4548 * html.c: (change_attributes) Dead code, removed.
4549 (escape_string) Eliminate code to call change_attributes() that
4550 never actually called it.
4551 (output_tab_table) Get rid of dependence on tab_hit
4552 and struct tab_joined_cell's hit member, which are abominations.
4554 * tab.c: (tab_output_text) Don't call
4555 d->class->text_set_font_by_name if it's a null pointer.
4556 (macro UNROLL_LOOP) Eliminate.
4557 (macro UNROLL_3_LOOPS) Eliminate.
4558 (tabi_render) Rewrite not to use the above macros.
4560 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4562 Start working on a new output driver system, one that doesn't suck
4563 so much, by adding a "device-independent" output driver. The idea
4564 is to write out only a single output stream, then use separate
4565 processes to translate them into whatever formats we want. This
4566 is similar to how "groff" works with its various output drivers
4567 (grops, grotty, grodvi, ...).
4569 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4571 * list.q: (write_all_headers) Stub out devind class.
4573 (determine_layout) Ditto.
4576 * output.c: (outp_init) Add devind class.
4578 * devind.c: New file.
4580 * devind.h: New file.
4582 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4584 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4585 to use the proper string length.
4587 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4589 * Fixed bug where FREQ would crash on alpha values
4591 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4593 * Removed bletcherous alloca() workarounds for AIX from top of
4594 many files. AIX can use the alternative alloca() implementation
4597 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4599 * ascii.c: (ascii_option) Fix implementation of headers option.
4601 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4603 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4604 multiple blank lines into one.
4605 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4606 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4607 (static var option_tab) Add squeeze entry.
4608 (ascii_option) Set squeeze_blank_lines.
4609 (output_lines) Implement squeezing blank lines.
4611 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4613 * Removed redundant code from output.h
4615 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4617 Dictionary classes: each variable is "ordinary", "system", or
4620 * var.h: (enum dict_class) New enum.
4622 * vars-prs.c: (dict_class_from_id) New function.
4623 (dict_class_to_name) New function.
4625 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4627 * var.h: (struct freq_tab_set) Removed (not used).
4629 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4631 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4633 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4635 * stats.c: (hypercube) Rename pow4(). All references updated.
4637 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4639 * rename-vars.c: (cmd_rename_variables) Rewritten.
4640 (compare_name) Removed.
4642 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4644 var_set feature, and code taking advantage of it.
4646 * crosstabs.q: (static var var_dict) Removed.
4647 (static var variables) New variable.
4648 (static var variables_cnt) New variable.
4649 (cmd_crosstabs) Free variables instead of var_dict.
4650 (internal_cmd_crosstabs) Initialize and use variables,
4651 variables_cnt instead of var_dict.
4652 (free_var_dict) Removed.
4653 (crs_custom_tables) Use var_set instead of a copied dictionary.
4654 (crs_custom_variables) Set up variables, variables_cnt instead of
4656 [DEBUGGING] (debug_print) Ditto.
4658 * means.q: (mns_custom_tables) Use var_set instead of a copied
4661 * vars-prs.c: (parse_vs_variable) New function.
4662 (parse_dict_variable) Rewritten.
4663 (parse_variable) Rewritten.
4664 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4665 (parse_variables) New function in terms of parse_var_set_vars().
4666 Now requires its first argument to be non-null. All references
4667 that passed a null pointer updated to pass default_dict instead.
4668 (macro id_dict) Removed.
4669 (parse_DATA_LIST_vars) Add assertions.
4670 (parse_mixed_vars) Ditto.
4671 (struct var_set) New structure.
4672 (var_set_get_cnt) New function.
4673 (var_set_get_var) New function.
4674 (var_set_lookup_var) New function.
4675 (var_set_destroy) New function.
4676 (dict_var_set_get_cnt) New function.
4677 (dict_var_set_get_var) New function.
4678 (dict_var_set_lookup_var) New function.
4679 (dict_var_set_destroy) New function.
4680 (var_set_create_from_dict) New function.
4681 (struct array_var_set) New structure.
4682 (array_var_set_get_cnt) New function.
4683 (array_var_set_get_var) New function.
4684 (array_var_set_lookup_var) New function.
4685 (array_var_set_destroy) New function.
4686 (var_set_create_from_array) New function.
4688 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4689 instead of parse_variables(NULL, ...) in output code.
4691 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4693 Change inp_init from a 2-bit vector to an ordinary array.
4694 Initialize it all in cmd_end_input_program() instead of in
4697 * inpt-pgm.c: (enum value_init_type) New enum.
4698 (global var inp_init) Change to `enum value_init_type *', make
4700 (inp_init_size) Removed.
4701 (inp_nval) Change to `size_t', make static.
4702 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4703 (cmd_end_input_program) Initialize inp_init, inp_nval.
4704 (init_case) Rewrite.
4705 (clear_case) Rewrite.
4707 * inpt-pgm.h: Removed.
4709 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4711 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4712 Colin Plumb hash. It is simpler and should better resist
4714 (hsh_hash_string) Ditto.
4716 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4718 * get.c: (export_write_case_func) Remove debug printing code.
4720 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4722 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4724 (save_write_case_func) Use &trns->h instead of cast.
4725 (cmd_export) Use &t->h instead of cast.
4727 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4729 Moved vectors into the dictionary.
4731 * var.h: (struct vector) Moved here from vector.h. `index' member
4732 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4735 * vector.h: Removed.
4737 * vector.c: (global var vec) Removed.
4738 (global var nvec) Removed.
4739 (cmd_vector) Rewritten.
4740 (find_vector) Removed.
4742 * dictionary.c: (dict_create_vector) New function.
4743 (dict_get_vector) New function, replaces reading global vec[]
4745 (dict_get_vector_cnt) New function, replaces reading global nvec
4747 (dict_lookup_vector) New function, replaces find_vector().
4748 (dict_clear_vectors) New function.
4750 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4752 Start to move away from `struct variable' p `union' member to void
4755 * var.h: (struct variable) Add `aux' member.
4757 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4759 Get rid of struct variable `foo' member.
4761 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4763 (frq_custom_variables) Ditto.
4764 (frq_custom_grouped) Ditto.
4766 * get.c: (struct save_trns) Change `var' member from `int *' to
4767 `struct variable **'.
4768 (cmd_save_internal) Use aux instead of foo.
4769 (save_trns_proc) Use revised `var' member.
4770 (static var mtf_seq_no) Renamed mtf_seq_num.
4771 (static var mtf_seq_nums) New static var.
4772 (cmd_match_files) Initialize mtf_seq_nums.
4773 (mtf_free) Free mtf_seq_nums.
4774 (mtf_processing) Use mtf_seq_nums instead of foo.
4775 (mtf_merge_dictionary) No need to initialize mv->foo.
4776 (cmd_export) Use aux instead of foo. Use revised `var' member.
4777 (mns_custom_tables) Don't use foo to check for duplicates, that's
4778 what PV_NO_DUPLICATE is for.
4780 * var.h: (struct variable) Remove `foo' member.
4781 (struct frequencies_proc) New member.
4783 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4785 Clean up COMPUTE and IF.
4787 * compute.c: More or less rewrite the darn thing.
4788 (struct compute_trns) Rename and reorder and add and delete
4790 (cmd_compute) Rewrite.
4791 (compute_num) Make conditional on test expression. Now used for
4792 both COMPUTE and IF.
4793 (compute_num_vec) Ditto.
4794 (compute_str) Ditto.
4795 (compute_str_vec) Ditto.
4798 (if_num_vec) Removed.
4800 (if_str_vec) Removed.
4801 (parse_target_expression) Renamed parse_rvalue_expression(),
4803 (new_trns) Renamed compute_trns_create(), rewritten.
4804 (delete_trns) Removed.
4805 (free_trns) Renamed compute_trns_free(), rewritten.
4806 (struct lvalue) New structure.
4807 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4808 (lvalue_get_type) New function.
4809 (lvalue_is_vector) New function.
4810 (lvalue_finalize) New function.
4811 (lvalue_destroy) New function.
4813 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4815 * command.def: Disallow MODIFY VARS in input mode, so that
4816 variables can't get dropped and confuse cmd_end_input_program()'s
4817 attempt to fill inp_init[].
4819 * modify-vars.c: (static var forward_positional_ordering) New
4821 (struct var_modification) Entirely changed.
4822 (rearrange_dict) Interface changed, rewritten.
4823 (cmd_modify_vars) Deal with modified struct var_modification, much
4825 (struct var_renaming) New structure.
4826 (compare_var_renaming_by_new_name) New function.
4827 (validate_var_modification) New function.
4829 * var.h: (struct modify_vars_proc) Removed.
4830 (struct variable) Removed member p.mfv.
4832 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4834 Make EVALUATE a valid command whether we're debugging or not, so
4835 that `make check' can succeed regardless of whether debugging is
4838 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4840 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4842 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4844 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4845 statement by a simple if test.
4847 * dfm.c: (dfm_get_record) Add assertion.
4849 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4851 For each file x.c, move #include "x.h" to the very top of the
4852 include list, to catch x.h failing to include the proper headers.
4854 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4856 * algorithm.c: (find) New function.
4857 (remove_equal) New function.
4858 (set_difference) New function.
4859 (adjacent_find_equal) New function.
4860 [TEST_UNIQUE] Removed test case.
4861 (copy_if) Find end test.
4863 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4865 * dictionary.c: (dict_get_case_weight) New convenience function.
4867 * aggregate.c: (accumulate_aggregate_info) Use
4868 dict_get_case_weight().
4870 * frequencies.q: (calc_general) Ditto.
4871 (calc_integer) Ditto.
4874 * t-test.q: (groups_calc) Ditto.
4877 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4879 * glob.c: (global var default_dict) Change from `struct
4880 dictionary' to `struct dictionary *'. All references changed.
4881 (init_glob) Initialize default_dict with dict_create().
4883 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4885 struct dictionary now made opaque. All related functions:
4887 * get.c: (rename_variables) Removed.
4888 (dict_delete_run) Removed.
4890 * temporary.c: (copy_variable) Removed.
4891 (new_dictionary) Removed.
4892 (save_dictionary) Removed.
4893 (restore_dictionary) Removed.
4894 (free_dictionary) Removed.
4896 * vars-atr.c: (clear_default_dict) Removed.
4897 (find_variable) Removed.
4898 (find_dict_variable) Removed.
4899 (create_variable) Removed.
4900 (delete_variable) Removed.
4901 (common_init_stuff) Removed.
4902 (init_variable) Removed. Updating of inp_init moved into
4903 cmd_end_input_program().
4904 (replace_variable) Removed.
4905 (rename_variable) Removed.
4906 (clear_variable) Removed.
4907 (dup_variable) Removed.
4909 * vars-prs.c: (is_varname) Removed.
4910 (is_dict_varname) Removed.
4911 (fill_all_vars) Removed.
4913 * vector.c: (find_vector) Removed.
4915 * weight.c: (stop_weighting) Removed.
4917 * dictionary.c: New file.
4918 (dict_create) New, replaces new_dictionary().
4919 (dict_clone) New, replaces save_dictionary() and
4920 restore_dictionary().
4921 (dict_clear) New, replaces clear_default_dict().
4922 (dict_destroy) New, replaces free_dictionary().
4923 (dict_get_var_cnt) New function, replaces references to
4925 (dict_get_var) New function, replaces references to dict->var[i].
4926 (dict_get_vars) New function, replaces fill_all_vars().
4927 (dict_create_var) New, replaces create_variable(). Interface
4928 drops `type' parameter, using a zero `width' to designate numeric.
4929 (dict_clone_var) New, replaces dup_variable().
4930 (dict_rename_var) New, replaces rename_variable().
4931 (dict_lookup_var) New, replaces find_variable(),
4932 find_dict_variable(), is_varname().
4933 (dict_contains_var) New function.
4934 (compare_variable_dblptrs) New function.
4935 (dict_delete_var) New function, replaces clear_variable().
4936 (dict_delete_vars) New function, replaces dict_delete_run().
4937 (dict_reorder_vars) New function.
4938 (dict_rename_vars) New function, replaces rename_variables().
4939 (dict_get_weight) New function, replaces reading dict->weight_var.
4940 (dict_set_weight) New function, replaces writing dict->weight_var
4941 or calling stop_weight(dict).
4942 (dict_get_filter) New function, replaces reading dict->filter_var.
4943 (dict_set_filter) New function, replaces writing dict->filter_var.
4944 (dict_get_case_limit) New function, replaces reading dict->N.
4945 (dict_set_case_limit) New function, replaces writing dict->N.
4946 (dict_get_value_cnt) New function, replaces reading dict->nval.
4947 (dict_compact_values) New function, replaces a loop that was
4948 replicated in several places.
4949 (dict_get_split_vars) New function, replaces reading dict->splits.
4950 (dict_get_split_cnt) New function, replaces reading
4952 (dict_set_split_vars) New function, replaces writing dict->splits.
4953 (dict_get_label) New function, replaces reading dict->label.
4954 (dict_set_label) New function, replaces writing dict->label.
4955 (dict_get_documents) New function, replaces reading
4957 (dict_set_documents) New function, replaces writing
4960 All references to above functions updated.
4962 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4963 old dictionary to new by hand, because dict_create() can't do it
4964 itself. Use dict_set_documents(), dict_set_split_vars().
4966 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4967 calling dict_destroy().
4969 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4971 (fixed_parse_compatible) Some slightly nontrivial changes for
4973 (dump_fmt_list) Ditto.
4976 * file-type.c: (create_col_var) Ditto.
4978 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4979 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4980 (rename_variables) Use dict_rename_vars().
4981 (mtf_merge_dictionary) Use dict_get_documents(),
4982 dict_set_documents(), dict_compact_values().
4984 * pfm-read.c: (read_variables) Deal with changes to weighting.
4986 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4987 is_varname() in output code.
4989 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4990 other dictionary functions.
4992 * title.c: (add_document_line) Use dict_get_documents(),
4993 dict_set_documents().
4995 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4996 reset default_handle by hand. dict_clear() will clear vectors so
4997 there's no need for that by hand.
4999 * vfm.c: (close_active_file) Move call to finish_compaction()
5000 earlier, so that we can do the compaction as a single step using
5001 dict_compact_values(). Use dict_clear_vectors().
5002 (finish_compaction) Use dict_delete_var(), dict_compact_values().
5004 Some functions don't have replacements:
5006 * vars-atr.c: (force_create_variable) Removed. All references
5007 updated to dict_create_var() followed by an assertion.
5008 (force_dup_variable) Removed. All references updated to
5009 dict_clone_var() followed by an assertion.
5011 * weight.c: (update_weighting) Removed. No longer necessary, so
5012 all references removed.
5014 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
5018 * aggregate.c: Eliminate separation of weighted and unweighted
5019 case. It made the code too obscure and I doubt it was actually
5020 faster. Instead, all code uses the "weighted" code, because
5021 that's a generalization of the "unweighted" code.
5024 (parse_aggregate_functions) No need to set FWEIGHT.
5025 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
5026 (dump_aggregate_info) Ditto.
5027 (initialize_aggregate_info) No need for special plain_function
5028 that gets rid of FWEIGHT option.
5030 * aggregate.c: Get rid of approximations.
5031 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
5033 (aggregate_single_case) Don't use approx_ne().
5035 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
5037 * ascii.c (ascii_line_width): Dead code, removed.
5039 * postscript.c (ps_line_width): Ditto.
5041 * q2c.c (xrealloc): Ditto.
5043 * count.c (internal_cmd_count): Ditto.
5045 * means.q (validate_dependent_endpoint): Ditto.
5047 * set.q: (cmd_gset) Ditto.
5049 * weight.c: [0] (weight_trns_proc) Ditto.
5051 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
5053 Make the code -Wmissing-prototypes clean.
5055 * Makefile.am (version.c): Add #include "version.h".
5057 * ascii.c: (ascii_open_global) Make static.
5058 (ascii_close_page) Ditto.
5059 (ascii_font_sizes) Ditto.
5060 (ascii_postopen_driver) Ditto.
5061 (ascii_close_driver) Ditto.
5062 (ascii_option) Ditto.
5063 (ascii_open_page) Ditto.
5064 (ascii_line_horz) Ditto.
5065 (ascii_line_vert) Ditto.
5066 (ascii_line_intersection) Ditto.
5068 (ascii_polyline_begin) Ditto.
5069 (ascii_polyline_point) Ditto.
5070 (ascii_polyline_end) Ditto.
5071 (ascii_text_set_font_by_name) Ditto.
5072 (ascii_text_set_font_by_position) Ditto.
5073 (ascii_text_set_font_by_family) Ditto.
5074 (ascii_text_get_font_name) Ditto.
5075 (ascii_text_get_font_family) Ditto.
5076 (ascii_text_set_size) Ditto.
5077 (ascii_text_get_size) Ditto.
5078 (ascii_text_metrics) Ditto.
5079 (ascii_text_draw) Ditto.
5080 (ascii_close_page) Ditto.
5082 * cmdline.h: New header for parse_command_line(). Used where
5085 * command.c: Move prototypes for cmd_*() functions to command.h.
5087 * command.h: Prototypes for cmd_*() functions moved here from
5090 * crosstabs.q: (gamma_int) Ditto.
5092 * file-handle.h: Add fh_init_files() prototype.
5094 * getline.c: (welcome) Ditto.
5096 * glob.h: New header for init_glob(). Used where appropriate.
5098 * hash.c: (comparison_helper) Ditto.
5100 * html.c: (html_open_global) Ditto.
5101 (html_close_global) Ditto.
5102 (html_preopen_driver) Ditto.
5103 (html_postopen_driver) Ditto.
5104 (html_close_driver) Ditto.
5105 (html_option) Ditto.
5106 (html_open_page) Ditto.
5107 (html_close_page) Ditto.
5108 (html_submit) Ditto.
5110 * inpt-pgm.c: (input_program_source_read) Ditto.
5112 * output.c: (find_defn_value) Ditto.
5113 (destroy_list) Ditto.
5115 * pfm-read.c: (read_int) Ditto.
5117 * postscript.c: (ps_open_global) Ditto.
5118 (ps_close_global) Ditto.
5119 (ps_font_sizes) Ditto.
5120 (ps_preopen_driver) Ditto.
5121 (ps_postopen_driver) Ditto.
5122 (ps_close_driver) Ditto.
5124 (ps_open_page) Ditto.
5125 (ps_close_page) Ditto.
5126 (ps_line_horz) Ditto.
5127 (ps_line_vert) Ditto.
5128 (ps_line_intersection) Ditto.
5130 (ps_polyline_begin) Ditto.
5131 (ps_polyline_point) Ditto.
5132 (ps_polyline_end) Ditto.
5133 (ps_text_set_font_by_name) Ditto.
5134 (ps_text_set_font_by_position) Ditto.
5135 (ps_text_set_font_family) Ditto.
5136 (ps_text_get_font_name) Ditto.
5137 (ps_text_get_font_family) Ditto.
5138 (ps_text_set_size) Ditto.
5139 (ps_text_get_size) Ditto.
5140 (ps_text_metrics) Ditto.
5141 (ps_text_draw) Ditto.
5143 * q2c.c: (finish_up) Ditto.
5152 (find_symbol) Ditto.
5155 (force_string) Ditto.
5157 (match_token) Ditto.
5160 (parse_setting) Ditto.
5161 (parse_specifier) Ditto.
5162 (parse_specifiers) Ditto.
5163 (parse_subcommand) Ditto.
5164 (dump_specifier_vars) Ditto.
5166 (make_identifier) Ditto.
5167 (dump_declarations) Ditto.
5168 (dump_specifier_init) Ditto.
5169 (dump_vars_init) Ditto.
5171 (dump_specifier_parse) Ditto.
5172 (dump_subcommand) Ditto.
5173 (dump_parser) Ditto.
5174 (dump_header) Ditto.
5176 (recognize_directive) Ditto.
5178 * recode.c: (string_to_long) Ditto.
5180 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
5182 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
5185 * sort.c: (sort_stream_read) Ditto.
5186 (sort_stream_mode) Ditto.
5188 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
5190 * algorithm.c (binary_search): Fix comparison.
5192 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
5194 * algorithm.c: (binary_search) Fix assertion.
5196 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
5198 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
5200 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
5202 * sort.c: (compare_case_lists) Rewrite.
5204 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
5206 * quicksort.c: Removed (not used).
5208 * quicksort.h: Removed (not used).
5210 * sort.c: Removed blp_quicksort() prototype.
5212 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
5214 * postscript.c: (int_2_compare) Rewrite.
5215 (compare_line) Rewrite.
5217 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
5219 * matrix-data.c (compare_factors) Use lexicographical_compare()
5221 (compare_doubles) New function.
5223 * algorithm.c: (lexicographical_compare) New algorithm.
5225 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
5227 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
5229 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
5231 * expr-prs.c: (cmp_func) Removed.
5232 (parse_function) Use binary_search() algorithm.
5233 (compare_functions) New function.
5234 (init_func_tab) Use sort() algorithm.
5236 * algorithm.c: (binary_search) New algorithm.
5238 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
5240 * descript.q: (display) Use sort() algorithm instead of qsort().
5241 (compare_func) Removed.
5242 (descriptives_compare_variables) New function.
5244 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
5246 Get rid of AVL trees. Hashes are more appropriate for everything
5249 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5255 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5257 Much code can be clarified by using C++ STL-like algorithms. Not
5258 all uses of these algorithms are listed below, only the ones where
5259 the change to an algorithm was the only change of interest.
5261 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5263 * algorithm.c: New file.
5265 * algorithm.h: New file.
5267 * modify-vars.c: (static var forward) Removed.
5268 (static var positional) Removed.
5269 (compare_variables) Removed.
5270 (struct ordering) New.
5271 (cmd_modify_vars) Use sort() algorithm.
5272 (compare_variables_given_ordering) New function.
5273 (rearrange_dict) Use sort() algorithm.
5275 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5276 (cmp_var_by_name) Removed.
5278 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5280 Make file handles use a hash table.
5282 * file-handle.q: (files) Change to hash table, make static.
5283 (cmd_file_handle) Use hash table functions.
5284 (fh_get_handle_by_filename) Ditto.
5285 (fh_get_handle_by_name) Ditto.
5286 (hash_file_handle) New function.
5287 (cmp_file_handle) Rewrite.
5288 (fh_init_files) Use hash table functions.
5290 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5292 Clean up FREQUENCIES.
5294 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5296 * frequencies.q: Remove a lot of old #if'd out code at the end.
5297 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5298 or calc_weight(). Initialize percentile_values.
5299 (calc) New function based on calc_weight() from frequencies.g.
5300 (precalc) Use hash functions.
5301 (static var comparison_func) Removed.
5302 (static var comparison_param) Removed.
5303 (comparison_helper) Removed.
5304 (get_freq_comparator) New function.
5305 (not_missing) New function.
5307 (postprocess_freq_tab) Use hash table functions, algorithms,
5308 get_freq_comparator(). Rewrite.
5309 (cleanup_freq_tab) Rephrase.
5310 (add_percentile) Clean up spacing.
5311 (hash_value_numeric) New function.
5312 (hash_value_alpha) New function.
5313 (compare_value_numeric_a) Rewrite.
5314 (compare_value_alpha_a) Rewrite.
5315 (compare_value_numeric_d) Rewrite.
5316 (compare_value_alpha_d) Rewrite.
5317 (compare_freq_numeric_a) Rewrite.
5318 (compare_freq_alpha_a) Rewrite.
5319 (compare_freq_numeric_d) Rewrite.
5320 (compare_freq_alpha_d) Rewrite.
5321 (calc_stats) Clean up mode, percentiles, max.
5322 (dump_statistics) Clean up spacing.
5324 * frequencies.g: Removed.
5326 * var.h: (struct freq_tab) Change `data' to hash table.
5328 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5330 * file-handle.h: Remove declaration of global variable `files',
5331 which wasn't used anywhere.
5333 * postscript.c: (add_encoding) Remove superfluous cast.
5336 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5339 * temporary.c: [0] (display_tree) Removed.
5341 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5343 Implement a new random number generator based on the alleged RC4
5346 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5349 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5350 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5352 (static var V[]) Removed.
5353 (static var Y) Removed.
5354 (static var X2) Removed.
5355 (setup_randomize) Removed.
5357 (rand_uniform) Removed.
5358 (rand_normal) Removed.
5359 (struct rng) New structure.
5360 (rng_create) New function.
5361 (rng_destroy) New function.
5362 (swap_byte) New static function.
5363 (rng_seed) New function.
5364 (rng_get_bytes) New function.
5365 (rng_get_int) New function.
5366 (rng_get_unsigned) New function.
5367 (rng_get_double) New function.
5368 (rng_get_double_normal) New function.
5369 (pspp_rng) New function.
5371 * random.h: Sync up to random.c.
5373 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5374 fraction of UINT_MAX, not 65536.
5375 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5378 * vfm.c: (open_active_file) No need to call setup_randomize() any
5381 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5383 Change dictionary name indexes to use hash tables instead of AVL
5386 * crosstabs.q: (free_var_dict) Use hash tables.
5387 (crs_custom_tables) Ditto.
5388 (calc_general) Ditto.
5389 (compare_table_entry) Rewrite.
5390 (enum_var_values) Reorder parameters. All references updated.
5393 * get.c: (rename_variable) Use hash tables.
5394 (mtf_merge_dictionary) Ditto.
5396 * glob.c: (init_glob) Use hash tables.
5397 (cmp_variable) Removed.
5399 * means.q: (mns_custom_tables) Use hash tables.
5401 * modify-vars.c: (rearrange_dict) Use hash tables.
5403 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5405 * sfm-read.c: (read_header) Use hash tables.
5406 (read_variables) Ditto.
5408 * temporary.c: (new_dictionary) Use hash tables.
5409 (save_dictionary) Ditto.
5410 (restore_dictionary) Ditto.
5412 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5413 hash table `name_tab'.
5415 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5416 [DEBUGGING] (dump_var_tree) Removed.
5417 (find_variable) Use hash tables.
5418 (find_dict_variable) Ditto.
5419 (common_init_stuff) Ditto.
5420 (rename_variable) Ditto.
5421 (clear_variable) Ditto. Also, remove debug code.
5422 (dup_variable) Use hash tables.
5424 * vars-prs.c: (fill_all_vars) Use hash tables.
5425 (is_dict_varname) Ditto.
5426 (parse_dict_variable) Ditto.
5428 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5430 Change value labels to use hash tables instead of AVL trees, and
5431 change value labels into an ADT.
5433 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5435 * value-labels.c: New file.
5437 * value-labels.h: New file.
5439 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5440 Get rid of a stupid use of goto.
5442 * autorecode.c: (compare_alpha_value) Rewrite.
5443 (hash_alpha_value) Ditto.
5444 (compare_numeric_value) Rewrite.
5445 (hash_numeric_value) Ditto.
5447 * frequencies.q: (dump_full) Use value label ADT.
5449 * pfm-read.c: (read_value_label) Use value label ADT.
5451 * pfm-write.c: (write_value_labels) Use value label ADT.
5453 * sfm-read.c: (read_variables) Use value label ADT.
5454 (read_value_labels) Rewrite.
5456 * sfm-write.c: (write_value_labels) Rewrite.
5458 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5459 (display_variables) Ditto.
5460 (describe_variable) Ditto.
5462 * t-test.q: (print_t_groups) Use value label ADT.
5464 * temporary.c: (copy_variable) Use value label ADT.
5465 (free_dictionary) Ditto.
5467 * val-labs.c: (verify_val_labs) Use value label ADT.
5469 (debug_print) Ditto.
5470 (val_lab_cmp) Removed.
5471 (inc_ref_count) Removed.
5472 (copy_value_labels) Removed.
5474 * var.h: (struct value_label) Removed.
5475 (struct variable) Change AVL tree `val_lab' into hash table
5478 * vars-atr.c: (init_variable) Use value label ADT.
5479 (clear_variable) Ditto.
5480 (free_value_label) Removed.
5481 (free_val_lab) Removed.
5482 (get_val_lab) Removed.
5483 (compare_variables) New function.
5484 (hash_variable) New function.
5486 * vfm.c: (dump_splits) Use value label ADT.
5488 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5490 Add to the hash table interface.
5492 * hash.c: (hsh_hash_bytes) Add assertion.
5493 (hsh_hash_string) Ditto.
5497 (hsh_create) Ditto. Also make minimum `size'.
5498 (hsh_destroy) Rephrase.
5499 (sort_nulls_last) Removed.
5500 (not_null) New function.
5502 (comparison_helper) Ditto.
5503 (hsh_sort) Rewritten.
5504 (hsh_data_copy) New function.
5505 (hsh_sort_copy) Ditto.
5507 (hsh_replace) Ditto.
5508 (hsh_hash_double) Ditto.
5509 (hsh_delete) Fix stupid bug.
5511 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5512 * added a calculation of the mode to FREQUENCIES
5514 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5516 * moved (un)defs of DEBUGGING to config.h
5518 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5520 * groff-font.c: (add_kern) Fix indentation.
5521 (add_kern) Use & instead of % to take power-of-2 modulus.
5522 (font_get_kern_adjust) Likewise.
5524 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5526 * autorecode.c: (recode) Replace stupid use of memcpy() by
5528 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5529 (hash_numeric_value) Ditto.
5530 (autorecode_proc_func) pool_strdup() was wrong here because the
5531 source string was not null-terminated. Use new pool_strndup()
5534 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5535 use of hsh_iterator_init().
5537 * data-in.c: (parse_N) Initialize i->v->f.
5539 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5542 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5543 (groff_read_font) Don't call hsh_next_prime(). Don't call
5545 (static var hash) Remove `size_p', `max_used' members.
5546 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5547 hsh_hash_string() instead of hashpjw(), & instead of %.
5548 (default_font) Don't call hsh_next_prime().
5550 * pool.c: (pool_strndup) New function.
5551 (pool_strdup) Reimplement in terms of pool_strndup.
5553 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5555 (hash_ps_encoding) Use hsh_hash_string().
5556 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5557 (hash_filename2font) Use hsh_hash_string().
5559 * som.c: Add #include <stdlib.h>.
5561 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5562 (by destroying its pool).
5564 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5566 Miscellaneous hash table code cleanup:
5568 * hash.h: (struct hsh_table) Moved into hash.c.
5569 (hsh_count) Ditto, and transformed into function.
5570 (hsh_compare_func) New typedef, used for defining otherwise-long
5571 function types here and in hash.c
5572 (hsh_hash_func) Ditto.
5573 (hsh_free_func) Ditto.
5575 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5576 `table' to `entries'. Removed `mp'. All references updated.
5577 (hsh_clear) Don't shrink entries array; if the hash was this big
5578 once, it probably will be again.
5579 (hsh_rehash) Made static.
5580 (force_hsh_insert) Renamed hsh_force_insert.
5581 (force_hsh_find) Renamed hsh_force_find.
5583 Made hash table sizes powers of 2, because that's fine with any
5584 reasonable hash function and because taking a power-of-2 modulus
5585 is faster than any other:
5587 (hsh_prime_tab) Removed;
5588 (hsh_next_prime) Ditto.
5589 (next_power_of_2) New function.
5590 (hsh_create) Use next_power_of_2.
5591 (hsh_rehash) Use & instead of %.
5593 Cleaned up hsh_sort:
5595 (internal_comparison_fn) Removed.
5596 (sort_nulls_last) New function.
5597 (hsh_sort) Removed second parameter, switched to using the new
5598 quicksort() function from quicksort.h to avoid using nasty need
5599 for static variables with qsort(). All references updated.
5601 Changed the hash functions offered, because there are better hash
5602 functions than the ones we had, and cleaned up the names to boot:
5604 * hash.c: (hashpjw_d) Removed.
5606 (hsh_hash_bytes) New function.
5607 (hsh_hash_string) New function.
5608 (hsh_hash_int) New function.
5610 Improved the hash table iteration interface:
5612 * hash.h: (hsh_iterator_init) Removed.
5613 (struct hsh_iterator) Removed `init' member, change `next' to
5616 * hash.c: (hsh_foreach) Removed. All references updated to use
5617 hsh_first/hsh_next instead.
5618 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5619 not treat a null pointer as an empty hash table.
5620 (hsh_next) New function.
5622 Made deletion possible, though slow:
5624 * hash.c: (locate_matching_entry) New function.
5625 (hsh_find) Use locate_matching_entry().
5626 (hsh_delete) New function also using locate_matching_entry().
5627 (hsh_force_delete) New function.
5629 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5631 * quicksort.c: New file implementing a sort routine with a
5632 interface better than qsort() because it passes a user-provided
5633 parameter to the sort routine.
5635 * Makefile.am: Add quicksort.c, quicksort.h.
5637 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5639 * All source files: Get rid of nasty special cases for Checker,
5640 which is pretty obsolete now.
5642 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5644 * Fixed a bug apparent when using the FREQUENCIES command with the
5645 html driver. The html driver was incorrectly trying to display
5648 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5650 * Makefile.am: Reorganized. Put locale dir in version.c instead
5651 of passing it to each compile command. Only put local gmp libs in
5652 LD_ADD if not installed on system. Remove `boast' target.
5654 * All source files: struct and union typedefs eliminated.
5655 `sizeof type' replaced by `sizeof object' where practical. Moved
5656 `unused' qualifiers from start to end of declarations for gcc
5657 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5658 assertions on pointers strictly compliant. Removed _ prefixes on
5659 some function parameter names.
5661 * alloc.c: New source file, containing these external linkage
5662 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5669 * ascii.c: Migrated from arenas to pools.
5670 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5671 c_string to len_string. All references changed.
5672 (ascii_option) Signature changed to comply to new output.c
5674 (count_fancy_chars) Removed.
5675 (delineate) Removed support for rich text.
5676 (ascii_text_metrics) Ditto.
5678 (output_shorts) Change `box', `off', `on' from c_string to
5679 len_string. Change `remaining' from int to size_t.
5680 (ascii_close_page) Make page numbering less haphazard.
5682 * autorecode.c: Migrate from arenas to pools.
5684 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5686 * bitvector.h: New file containing these macros from misc.h:
5687 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5689 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5690 word[3]. ncmd removed.
5691 (var empty_string) Removed.
5692 (var cmd_table) Declaration updated.
5693 (var cmdtab) Removed.
5694 (cmp_command) Removed.
5695 (split_words) Rewritten to use strtok_r().
5696 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5697 (find_command) Removed.
5698 (FILE_TYPE_okay) Rewritten.
5699 (cmd_parse) Rewritten. Semantics of the return value of command
5700 handlers has changed: they must now return one of the new CMD_*
5701 enumerals, rather than a magic value. This meant that all
5702 commands had to be modified, and they were.
5703 (figure_out_command) New function.
5705 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5706 #defines for INIT, INPU, etc.
5708 * command.h: New CMD_* enum series.
5709 (cur_proc) Make const char *, not char *.
5710 (cmd_init) Prototype.
5713 * common.c: Removed.
5715 * common.h: Removed.
5717 * correlations.q: New file.
5719 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5721 (custom_tables) Renamed crs_custom_tables().
5722 (custom_variables) Renamed crs_custom_variables().
5723 (calc_integer) Add in some `const' qualifiers.
5724 (table_value_missing) Change from a_string to len_string.
5725 (float_M_suffix) Change from a_string to len_string.
5727 * data-in.c: Rewritten. All references to
5728 parse_string_as_format() changed to data_in().
5730 * data-in.h: New file.
5732 * data-list.c: Change DLS_* from #define's to enums. Move from
5733 rpd_msg() to tmsg().
5734 (RPD_ERR) New #define.
5735 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5737 (read_from_data_list_fixed) Change from old
5738 parse_string_as_format() to new data_in().
5739 (read_from_data_list_free) Ditto.
5740 (read_from_data_list_list) Ditto.
5741 (cmd_repeating_data) Modify approach to checking for end of
5744 (rpd_parse_record) Change from old parse_string_as_format() to new
5745 data_in(). Change from old convert_format_to_string() to new
5747 (read_one_set_of_repetitions) Change dfm_push_cust() to
5748 dfm_push(), pop_cust() to dfm_pop().
5750 * data-out.c: Rewritten. All references to
5751 convert_format_to_string() changed to data_out().
5753 * descript.q: Migrate to new q2c.
5754 (cmd_descriptives) Removed.
5755 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5756 (custom_variables) Renamed dsc_custom_variables().
5758 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5760 (open_file_r) Initialize h->where.line_number. Migrate to new
5762 (open_file_w) Initialize h->where.line_number.
5763 (read_record) Change from ext->ln to h->where.line_number.
5764 Migrate to struct string.
5765 (dfm_put_record) Rephrased.
5766 (dfm_push_cust) Renamed dfm_push(), rewritten.
5767 (dfm_pop) New function.
5769 * error.c: All references updated.
5770 (glob var error_count) Renamed err_err_count.
5771 (glob var warning_count) Renamed err_warning_count.
5772 (glob var error_already_flagged) Renamed err_already_flagged.
5773 (glob var verbosity) Renamed err_verbosity.
5774 (glob var cust_fn) Removed.
5775 (glob var cust_ln) Removed.
5776 (static var file_loc) New.
5777 (static var nfile_loc) New.
5778 (static var mfile_loc) New.
5779 (tmsg) New function.
5780 (push_cust) Removed.
5783 (static var terminating) Removed.
5784 (failure) Renamed err_failure().
5785 (hcf) Renamed err_hcf().
5786 (err_push_file_locator) New function.
5787 (err_pop_file_locator) New function.
5788 (err_location) New function.
5789 (check_error_count) Renamed err_check_count().
5790 (vmsg) Renamed err_vmsg(). Interface changed.
5791 (verbose_msg) Removed.
5792 (err_cond_fail) New function.
5793 (error_break) Renamed err_break().
5795 * error.h: All references updated.
5796 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5797 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5799 (struct file_locator) New.
5801 (macro verbose_msg) Removed.
5802 (macro cond_fail) Removed.
5804 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5806 * expr-prs.c: Reorganized. All references updated.
5807 (exprtypename) Renamed expr_type_name().
5808 (typename) Renamed type_name().
5809 (free_expression) Renamed expr_free().
5810 (parse_expression) Renamed expr_parse(). Uses new type_check()
5812 (init_functab) Renamed init_func_tab().
5813 (type_check) New function.
5814 (parse_or) Rewritten to use new allocate_nonterminal() and
5815 append_nonterminal_arg() functions.
5818 (parse_rel) Ditto. Also simplified logic.
5823 (SYSMIS_func) Ditto.
5824 (VALUE_func) Rephrased.
5825 (CONCAT_func) Fix memory leak by replacing free by free_node on
5827 (generic_str_func) Ditto.
5828 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5830 (allocate_nonterminal) New function.
5831 (append_nonterminal_arg) New function.
5832 (static func_tab[]) Now at file level.
5834 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5836 * expr.h: (enum series OP_*) Moved to exprP.h.
5837 (OP_* defines) Ditto.
5838 (struct op_desc) Ditto.
5839 (global ops[]) Ditto.
5840 (struct num_con_node) Ditto.
5841 (struct str_con_node) Ditto.
5842 (struct var_node) Ditto.
5843 (struct lag_node) Ditto.
5844 (struct casenum_node) Ditto.
5845 (struct nonterm_node) Ditto.
5846 (union any_node) Members renamed.
5847 (struct sys_node) Removed.
5848 (struct val_node) Removed.
5849 (operator typedef) Removed.
5850 (typedef exprtype) Removed.
5851 (enum series EX_*) Moved to exprP.h.
5852 (struct expression) Ditto. Also renamed a lot of the members.
5853 (PXP_* defines) Changed to enums.
5854 (free_node prototype) Moved to exprP.h.
5856 * file-handle.h: (struct file_handle) New member `where'.
5858 * file-handle.q: Migrated to new q2c format.
5859 (prepend_current_directory) Removed (dead code).
5860 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5861 (fh_get_handle_by_filename) Removed dead code.
5862 Set new `where' member.
5864 * file-type.c: (file_type_source_read) References to
5865 parse_string_as_format() changed to data_in().
5866 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5868 * filename.c: All references updated.
5869 (init_filename) Renamed fn_init().
5870 (expand_line) Removed.
5871 (macro EXPAND_LINE) Removed.
5872 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5873 of custom functions.
5874 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5875 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5876 (normalize_filename) Renamed fn_normalize().
5877 (search_path) Renamed fn_search_path(), rewritten.
5878 (prepend_dir) Renamed fn_prepend_dir().
5879 (blp_getenv) Renamed fn_getenv().
5880 (blp_dirname) Renamed fn_dirname().
5881 (fn_basename) New function, not used.
5882 (absolute_filename_p) Renamed fn_absolute_p().
5883 (is_special_filename) Renamed fn_special_p().
5884 (file_exists) Renamed fn_exists_p().
5885 (readlink_malloc) Renamed fn_readlink().
5886 (getenv_default) Renamed fn_getenv_default().
5887 (open_file) Renamed fn_open().
5888 (close_file) Renamed fn_close().
5889 (open_file_ext) Renamed fn_open_ext().
5890 (close_file_ext) Renamed fn_close_ext().
5892 * font.h: Migrate from arenas to pools.
5894 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5896 * frequencies.g: Migrate from arenas to pools.
5898 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5901 * getline.c: All references updated.
5902 (global getl_buf) Changed from char * to struct string.
5903 (static getl_include_path) Ditto.
5904 (global getl_buf_len) Removed.
5905 (global getl_buf_size) Removed.
5906 (getl_include_path) Deal with new getl_buf, getl_include_path.
5907 (getl_uninitialize) New function.
5908 (getl_get_current_directory) Rewritten.
5909 (getl_clear_include_path) Rewritten.
5910 (getl_add_include_dir) Rewritten.
5911 (getl_add_file) Assertion fixed.
5912 (getl_add_virtual_file) Change initial value of `remaining_loops'
5914 (welcome) Rewritten.
5915 (handle_line_buffer) Make static. Change logic to make
5916 getl_add_virtual_file() change sensible. Use ds_*() strings.
5917 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5918 (getl_close_file) Moved.
5919 (getl_location) New function.
5921 * getline.h: All references updated.
5922 (macro curln) Removed.
5923 (macro curfn) Removed.
5924 (macro am_interactive) Renamed getl_am_interactive.
5925 (macro am_reading_script) Renamed getl_reading_script.
5927 * glob.c: (global fmt_parse_ignore_error) Removed.
5928 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5929 systems that support it (C99). Turn off SET ECHO by default. No
5930 necessary julcal initialization anymore.
5932 * groff-font.c: Migrate from arenas to pools.
5933 (groff_read_font) Use err_push_file_locator().
5934 (groff_read_DESC) Ditto.
5935 (font_msg) Use tmsg().
5937 * hash.c: (hsh_sort) Fix debug code.
5938 [GLOBAL_DEBUGGING] Include stdio.h.
5940 * hash.h: (macro force_hsh_insert) Rephrase.
5942 * heap.c: Rewritten.
5944 * heap.h: Rewritten.
5946 * html.c: (html_option) Change from outp_value to struct string.
5947 (postopen) Change from curfn to getl_location().
5948 (escape_string) Remove rich-text code. Signature changed.
5949 (output_tab_table) Switch from a_string to struct len_string.
5950 Remove rich text support.
5952 * lexer.c: All references updated. Largely rewritten. Major
5953 changes listed below. Removed tagged quote support. Adapted to
5954 struct string tokstr.
5955 (global tokstr) Changed to struct string.
5956 (global tokstr_size) Removed.
5957 (global tokstr_len) Removed.
5959 (global tokint) Removed.
5960 (global toklongstr) Removed.
5961 (C* defines) Removed.
5962 (static tbl[]) Removed.
5963 (static id[]) Removed.
5964 (static une[]) Removed.
5965 (discard_line) Renamed lex_discard_line().
5966 (get_entire_line) Renamed lex_entire_line().
5967 (get_rest_of_line) Renamed lex_rest_of_line().
5968 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5969 (make_hexit) Removed.
5970 (syntax_error) Renamed lex_error(). Return value removed.
5971 (get_token_representation) Renamed lex_token_representation().
5972 (putback) Renamed lex_put_back().
5973 (putfwd) Renamed lex_put_forward().
5974 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5975 (set_prog) Renamed lex_set_prog().
5976 (init_lex) Renamed lex_init().
5977 (reset_eof) Renamed lex_reset_eof().
5978 (lookahead) Renamed lex_look_ahead().
5979 (check_id) Rewritten.
5980 (yylex) Renamed lex_get(), rewritten.
5981 (lex_end_of_command) New function. Many commands were rephrased
5983 (lex_integer_p) New function. Replaces compare of tokint against
5985 (lex_integer) New function. Replaces tokint.
5986 (match_tok) Renamed lex_match().
5987 (match_id) Renamed lex_match_id().
5988 (match_int) Renamed lex_match_int().
5989 (force_match_id) Renamed lex_force_match_id(), added return value.
5990 (force_match) Renamed lex_force_match(), added return value.
5991 (force_string) Renamed lex_force_string(), added return value.
5992 (force_int) Renamed lex_force_int(), added return value.
5993 (lex_id_match_len) New function.
5994 (id_match) Renamed lex_id_match(), rewritten.
5995 (get_line) Renamed lex_get_line().
5996 (preprocess_line) Renamed lex_preprocess_line().
5997 (tokname) Renamed lex_token_name().
5998 (bin_value_func) Removed.
5999 (oct_value_func) Removed.
6000 (hex_value_func) Removed.
6001 (unexpected_eof) New function.
6002 (convert_numeric_string_to_char_string) New function.
6003 (parse_string) Rewritten, signature changed.
6004 (add_tokstr_char) Removed.
6005 (add_tokstr_unsigned) Removed.
6006 (add_tokstr_string) Removed.
6007 (parse_tagged_quote) Removed.
6008 (skip_comment) Renamed lex_skip_comment().
6010 * lexer.h: All references updated.
6011 (macro is_id1) Renamed CHAR_IS_ID1.
6012 (macro is_idn) Renamed CHAR_IS_IDN.
6013 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
6014 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
6015 (macro get_token) Removed.
6016 (macro id_match) Removed.
6017 (macro force_match_id) Removed.
6018 (macro force_match) Removed.
6019 (macro force_string) Removed.
6020 (macro force_int) Removed.
6021 (macro force_num) Removed.
6022 (macro force_id) Removed.
6024 * lexerP.h: Removed.
6026 * list.q: Migrated to new q2c format.
6027 (write_line) Deal with struct len_string.
6028 (write_varname) Ditto.
6029 (write_fallback_headers) Ditto.
6031 * magic.c: New file, incorporating the following global variables
6032 previously in other files: endian, second_lowest_value. And both
6033 of those are conditional on #define's.
6035 * magic.h: New file, incorporating the following global variable
6036 declarations: endian, second_lowest_value, and the following macro
6037 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
6039 * main.c: Added declarations of pgmname, finished, curdate,
6041 (main) Call new parse_script() function.
6042 (parse_script) New function.
6043 (execute_command) New function.
6044 (dump_token) Removed.
6045 (handle_error) New function.
6047 * matrix.c: New file.
6049 * matrix.h: New file.
6051 * matrix-data.c: Migrated from arenas to pools.
6052 (mget_token) Change from parse_string_as_format() to data_in().
6054 * means.q: Migrate to new q2c.
6055 (custom_tables) Renamed mns_custom_tables().
6056 (custom_crossbreak) Renamed mns_custom_crossbreak().
6057 (custom_variables) Renamed mns_custom_variables().
6059 * mis-val.c: (static var width) Changed from `int' to `size_t'.
6060 (parse_varnames) Prototype.
6061 (parse_numeric) Rephrasings.
6062 (parse_alpha) Adapt to new struct string tokstr.
6064 * misc.c: (intlog10) Rewritten.
6066 (ansi_rand) Renamed real_rand(), moved into random.c.
6067 (ansi_srand) Renamed real_srand(), moved into random.c.
6068 (setup_randomize) Moved to random.c.
6069 (rand_uniform) Ditto.
6070 (rand_normal) Ditto.
6071 (rand_simple) Ditto.
6072 (get_config_line) Removed.
6073 (reverse) Removed (dead code).
6075 * misc.h: (macro SET_BIT) Moved to bitvector.h.
6076 (macro CLEAR_BIT) Ditto.
6077 (macro TEST_BIT) Ditto.
6078 (macro SET_BIT_TO) Ditto.
6079 (macro BIT_INDEX) Ditto.
6081 * output.c: (outp_read_devices) Move to err_push_file_locator()
6082 from push_cust(). Use struct string.
6083 (expand_op_tokstr) Removed.
6084 (static var op_tokstr) Changed to struct string.
6085 (static var op_tokstr_size) Removed.
6086 (tokener) Rephrasings. Use struct string.
6087 (parse_options) Use struct string.
6088 (destroy_driver) Fix assertion.
6089 (outp_get_paper_size) Move to err_push_file_locator().
6090 [0] Removed dead code.
6091 (outp_string_width) Move to len_string.
6093 * output.h: Comment fixes.
6094 (TAG_* enum series) Removed.
6095 (struct outp_value) Removed.
6096 (enum OUTP_T_FANCY) Removed.
6097 (struct outp_text) `s' changed from a_string to len_string.
6098 (struct outp_class) `option' change arg 3 from outp_value to
6101 * pfm-read.c: (corrupt_msg) Rewritten.
6103 * pfm-write.c: (bufwrite) Fix assertion.
6105 * pool.c: New file, reference version.
6107 * pool.h: New file, reference version.
6109 * postscript.c: (ps_font_sizes) Fix assertion.
6110 (ps_option) Change arg 3 from outp_value to struct string.
6111 Adapt to struct string.
6112 (macro output_line) Removed.
6113 (macro add_string) Removed.
6114 (output_encodings) Adapted to struct string. Moved to
6115 err_push_file_locator().
6116 (find_encoding_file) Fix assertion.
6117 (read_ps_encodings) Move to err_push_file_locator().
6118 (postopen) Use getl_location() instead of curfn.
6119 (out_text_plain) Move to len_string.
6120 (text) Ditto. Remove rich text support.
6122 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
6123 (cmd_print_eject) Ditto.
6125 (internal_cmd_print) Now cleans up after itself. Uses
6126 fh_parse_file_handle() now.
6127 (cmd_print_space) Use PXP_NUMERIC to type-check.
6129 * q2c.c: Overhauled. Removed _("") i18n support. All references
6130 updated. All output functions updated to handle structures rather
6131 than local or static variables. Adapt to new PSPP lex_*()
6135 (macro MAX_N_SBC) Removed.
6136 (global bare) Removed.
6137 (enum STRING) Renamed T_STRING.
6138 (enum ID) Renamed T_ID.
6139 (get_buffer) Buffer size increased.
6140 (strlower) Renamed st_lower(), rephrased.
6141 (strupper) Renamed st_upper(), rephrased.
6142 (skip_ws) New function.
6143 (get_line) Don't special-case any types of lines (like those
6144 beginning with ! or $, for instance).
6145 (get_token) Renamed lex_get(). Rephrased.
6146 (static var `prefix') New.
6147 (parse) New function.
6148 (parse_setting) Minor rephrasing.
6149 (dump_specifier_vars) Ditto.
6150 (make_identifier) Put null terminator on identifier, duh.
6151 (dump_vars) Renamed dump_declarations(). Never indent. Never
6152 static. Output changed entirely.
6153 (dump_specifier_init) Rephrase.
6154 (dump_vars_init) No index variable needed. Other modifications.
6155 (dump_parser) Don't parse command name. Do dump functions instead
6156 of just code fragments.
6157 (dump_free) Dump function instead of code fragment.
6158 (recognize_directive) New function.
6159 (main) Use recognize_directive(). Don't rely on magic $ line
6160 beginning: instead, parse comments. Update list of headers.
6162 * random.c: New file, containing the following functions:
6163 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
6164 rand_normal, rand_simple.
6166 * random.h: New file.
6168 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
6169 function. `max_src_width', `max_dst_width' changed to size_t.
6170 (internal_cmd_recode) Removed.
6171 (parse_dest_spec) Merge similar cases.
6172 (parse_src_spec) Add assertion.
6174 * repeat.c: (recognize_keyword) New function.
6175 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
6176 REPEAT. Improve recognition of END REPEAT (use
6177 recognize_keyword()). Move from curfn to getl_location(). Use
6180 (perform_DO_REPEAT_substitutions) Adapt to struct string.
6182 * set.q: Adapt to new q2c.
6183 (cmd_set) Range-check some values better.
6184 (custom_blanks) Renamed stc_custom_blanks().
6185 (custom_length) Renamed stc_custom_length().
6186 (custom_results) Renamed stc_custom_results().
6187 (custom_seed) Renamed stc_custom_seed().
6188 (custom_width) Renamed stc_custom_width().
6189 (custom_format) Renamed stc_custom_format().
6190 (custom_journal) Renamed stc_custom_journal().
6191 (custom_color) Renamed stc_custom_color().
6192 (custom_listing) Renamed stc_custom_listing().
6193 (custom_disk) Renamed stc_custom_disk().
6194 (custom_log) Renamed stc_custom_log().
6195 (custom_rcolor) Renamed stc_custom_rcolor().
6196 (custom_viewlength) Renamed stc_custom_viewlength().
6197 (custom_workdev) Renamed stc_custom_workdev().
6199 * settings.h: Not necessary to include format.h any longer.
6201 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
6202 (corrupt_msg) Rewritten.
6204 * sort.c: Adapt to rewritten heap ADT.
6206 * str.c: (aa_strcpy) Removed.
6207 (ab_strcpy) Removed.
6208 (ac_strcpy) Removed.
6209 (ba_strcpy) Removed.
6210 (bb_strcpy) Removed.
6211 (ca_strcpy) Removed.
6212 (aa_strdup) Removed.
6213 (aa_strdupcpy) Removed.
6214 (ba_strdup) Removed.
6215 (sa_strdup) Removed.
6216 (memrev) Renamed mm_reverse().
6217 (memrmem) Renamed mm_find_reverse().
6218 (cmp_str) Renamed st_compare_pad().
6219 (strmaxcpy) Removed.
6220 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
6221 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
6223 (strpadcpy) Renamed st_pad_copy(), signature changed.
6224 (blpstrset) Removed.
6225 (ds_create) New function.
6226 (ds_init) New function.
6227 (ds_replace) New function.
6228 (ds_destroy) New function.
6229 (ds_clear) New function.
6230 (ds_extend) New function.
6231 (ds_shrink) New function.
6232 (ds_truncate) New function.
6233 (ds_length) New function.
6234 (ds_size) New function.
6235 (ds_value) New function.
6236 (ds_end) New function.
6237 (ds_concat) New function.
6238 (ds_concat_buffer) New function.
6239 (ds_printf) New function.
6240 (ds_putchar) New function.
6241 (ds_getline) New function.
6242 (ds_get_config_line) New function derived from the old
6243 misc.c:get_config_line().
6244 (ls_create) New function.
6245 (ls_create_buffer) New function.
6246 (ls_init) New function.
6247 (ls_shallow_copy) New function.
6248 (ls_destroy) New function.
6249 (ls_null) New function.
6250 (ls_null_p) New function.
6251 (ls_empty_p) New function.
6252 (ls_length) New function.
6253 (ls_value) New function.
6254 (ls_end) New function.
6256 * str.h: Reformatted.
6257 (struct a_string) Removed.
6258 (struct b_string) Removed.
6259 (struct c_string) Removed.
6260 (struct len_string) New.
6261 (struct string) New.
6262 (macro as_streq) Removed.
6263 (macro bs_streq) Removed.
6264 (macro cs_streq) Removed.
6265 (macro sa_streq) Removed.
6266 (macro sb_streq) Removed.
6267 [__GNUC__] (inline function ds_putchar) New function.
6268 [__GNUC__] (inline function ds_length) New function.
6269 [__GNUC__] (inline function ds_value) New function.
6270 [__GNUC__] (inline function ds_end) New function.
6272 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6273 (display_vectors) Fix missing i18n.
6275 * t-test.q: Migrate to new q2c.
6277 * tab.c: Migrate from arenas to pools.
6278 (tab_create) Use struct len_string.
6279 (tab_realloc) Ditto.
6280 (text_format) Ditto.
6281 (tab_joint_text) Ditto.
6282 (tab_natural_width) Remove rich text support.
6283 (tab_natural_height) Ditto.
6284 (tab_output_text) Handle TAT_FIX.
6285 (tab_raw) Change arg from a_string to len_string.
6286 (tabi_driver) Fix assertion. Use struct len_string.
6287 (render_strip) Use struct len_string. Remove rich text support.
6288 Add `const' qualifiers.
6290 * tab.h: (enum TAB_RICH) Remove.
6291 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6292 SOM_COL_* updated to read TAB_COL_*.
6293 (struct tab_table) Change arena to pool. Change a_string to
6296 * temporary.c: (restore_dictionary) Rewrite Checker code.
6298 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6299 LOWEST, HIGHEST) Moved here from common.h.
6300 (typedef any_trns) Removed. All references changed to `struct
6303 * vars-atr.c: (force_create_variable) Fix assertion.
6304 (force_dup_variable) Fix assertion.
6306 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6308 Using alphanumeric variables in functions under AGGREGATE
6309 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6310 <BZN-mdksh@t-online.de> for reporting this bug.
6312 * aggregate.c: (parse_aggregate_functions) When setting the
6313 FSTRING bit, also allocate memory for the `string' member of
6315 (free_aggregate_functions) Free iter->string. Don't use the
6316 non-function bits when indexing the array of functions.
6317 [DEBUGGING] (debug_print) Don't use the non-function bits when
6318 indexing the array of functions.
6320 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6322 Under certain circumstances, the final case would be omitted from
6323 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6324 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6326 * aggregate.c (agr_00x_end_func): Increment number of cases in
6327 sink before writing case. For streams that keep track of how many
6328 cases there are based on this value, this means that the last case
6329 will be read in on the next stream read.
6331 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6333 Undefined behavior was invoked by referencing a freed pointer.
6335 * vfm.c (memory_stream_write): Free pointer *after* checking for
6338 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6340 A wrong record size was displayed when paging the active file to
6343 * vfm.c: (memory_stream_write) Fix off-by-one error.
6345 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6347 Not having enough temporary space for sorting caused a core dump.
6350 * sort.c: (allocate_cases) Initialize i.
6352 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6354 Syntax errors in function descriptions on AGGREGATE caused core
6357 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6358 free_aggregate_functions(), since that function already frees
6361 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6363 A null pointer was dereferenced, causing a core dump, when
6364 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6365 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6366 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6368 * arena.c: (arena_malloc) If the arena hasn't been initialized
6369 already, initialize it.
6371 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6373 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6374 for compilation with Cygnus Windows B20. Not used by other
6377 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6379 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6380 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6382 * sort.c: (compare_case_lists) Reverse sense of comparison if
6383 sorting in descending order.
6384 (compare_record) Ditto.
6386 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6388 SPLIT FILE with a string variable caused a core dump. Fixed.
6390 * vfm.c: If the variable is a string then make a temporary value
6391 struct pointing to it. The underlying problem is a lot bigger
6392 than this (see TODO) but this is a stopgap for the simple case at
6395 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6397 Nested INCLUDEs didn't work. Fixed.
6399 * getline.c: (getl_include) Set first_line to NULL in allocated
6402 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6404 The MATCH FILES procedure set the values of variables not present
6405 to 0. It should have been SYSMIS. This is now fixed.
6407 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6409 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6411 The REMARK command was too aggressive about skipping lines. It
6412 didn't like being the last command in a file.
6414 * command.c: (cmd_remark) Call get_entire_line() instead of
6417 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6419 Comment parsing wasn't consistent with the rest of the code in its
6420 idea of where one command ends and another starts. This meant
6421 that sometimes commands would be mysteriously ignored. Thanks to
6422 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6424 * command.c: (parse_cmd) Hand off comment parsing to new function
6425 skip_comment() in lexer.c.
6426 * lexer.c: (skip_comment) New function.
6428 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6430 The TABLE subcommand on MATCH FILES worked only erratically at
6431 best. This fixes it. Thanks to Dr. Dirk Melcher
6432 <BZN-mdksh@t-online.de> for reporting this bug.
6434 * get.c: (mtf_compare_BY_values) When comparing string values, a
6435 difference of 1 is still a difference :-)
6436 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6437 advance TABLE files automatically when matched. Comment fixes.
6439 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6441 VARIABLE LABELS rejected a slash before the first variable
6442 specification, contradicting the documentation. Thanks to Walter
6443 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6445 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6446 command specification.
6448 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6450 Because of an incorrect optimization in memory allocation,
6451 CROSSTABS sometimes segfaulted when asked to output multiple
6452 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6455 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6456 are passed to output_pivot_table() for its use.
6457 (output_pivot_table) Instead of assuming the number of columns is
6458 constant, keep track with maxcols. In general mode, use maxcells
6459 to determine whether more matrix cells need to be allocated.
6461 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6463 CROSSTABS didn't display value labels for column and row
6464 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6467 * crosstabs.q: (table_value_missing) If the specified value has a
6468 value label for this variable, then show it instead of the raw
6470 (display_dimensions) Delegate display of value_labels to
6471 table_value_missing.
6473 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6475 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6476 <BZN-mdksh@t-online.de> for reporting this bug.
6478 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6479 if the file isn't declared as binary.
6481 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6483 MATCH FILES corrupted memory and dumped core on some syntax
6486 * get.c: (cmd_match_files) Set file->handle to NULL before
6488 (mtf_free_file) Don't free a null dictionary.
6490 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6492 MATCH FILES should set numeric values not available to the
6493 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6494 <BZN-mdksh@t-online.de> for reporting this bug.
6496 * get.c: (mtf_processing) Set unused records to system-missing,
6499 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6501 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6502 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6504 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6505 in newly created dictionary, and add each copied variable to the
6508 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6512 * get.c: (trim_dictionary) Free variable list for KEEP after
6515 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6517 Some systems didn't like the way open_file was coded. Thanks to
6518 Hankin <hankin@rogue.consultco.com> for pointing this out.
6520 * filename.c: (open_file) Don't try to store stdin, stdout,
6521 stderr as part of an array, because that doesn't always work.
6523 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6525 The SAVE procedure didn't save long string variables properly.
6526 Fixed by this patch. Thanks to Hankin
6527 <hankin@rogue.consultco.com> for this patch.
6529 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6530 out variable pad records.
6532 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6534 Previously, if PRINT SPACE were given a negative argument, it
6535 would report an error, then spin in an (almost) infinite loop.
6536 This fixes that behavior.
6538 * print.c: (print_space_trns_proc) After reporting a negative
6539 argument, set number of lines to print to 1.
6541 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6543 SPSS 8.0 outputs some new record types in its system files, and it
6544 allows longer value labels. Accept these system files.
6546 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6547 11 emitted by SPSS 8.0.
6549 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6551 The LIST procedure was too conservative in allocating space for
6552 buffers, which caused a bug that only showed up with very long
6553 output variables. Thanks to Hankin <hankin@dunno.com> for this
6556 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6558 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6560 Typo meant string format specifiers weren't checked properly. I
6561 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6562 willing to be corrected on this point.
6564 * format.c: (check_string_specifier) Fix obvious typo.
6566 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6568 Using $CASENUM in an expression didn't work. Here's a fix.
6569 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6572 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6574 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6576 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6578 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6579 other behavior, *sigh*. This patch hopefully fixes that. This
6580 time I've actually tested it.
6582 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6584 * data-list.c: (read_from_data_list_free,
6585 read_from_data_list_list) Call parse_string_as_format() directly
6586 without mucking around with the field width.
6588 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6590 Occasionally, you may encounter a script that wants to be
6591 interpreted in interactive mode. Make -i emulate this behavior to
6592 allow such scripts to be executed with PSPP.
6594 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6596 * cmdline.c: (pre_syntax_message[]) Update -i description.
6598 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6599 when -i is given on the command line) don't treat unindented lines
6600 as starting a new command.
6602 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6604 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6605 mostly caused by local initialized aggregates. After egcs is
6606 fixed upstream these can be removed, but for now they're not a big
6609 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6610 initialized arrays. Avoid this.
6612 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6615 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6617 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6618 following changes avoid. Currently I compile sources with egcs
6619 1.1.1 and gcc 2.7.2.3 before sending them out.
6621 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6623 * ascii.c: (option_tab[]) Initialize all struct members.
6625 * avl.h: (avl_traverser_init) New macro.
6627 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6630 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6633 * hash.c: Comment fix.
6635 * hash.h: (hsh_iterator_init) New macro.
6637 * html.c: (option_tab[]) Initialize all struct members.
6639 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6642 * postscript.c: (option_tab[]) Initialize all struct members.
6643 (output_encodings, preclose, dump_lines) Use new
6644 hsh_iterator_init() macro.
6646 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6649 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6652 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6654 * data-in.c: Examined each of the parsing functions to make sure
6655 that they wouldn't dump core if they were passed a string of the
6656 wrong length, since now the DATA LIST FREE/LIST routines don't
6657 check for field width before passing it to the data parser.
6658 (parse_RBHEX, parse_AHEX) Reject odd length input.
6659 (parse_string_as_format) Reject input that's too short or too
6662 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6663 a field to its entire declared output width then pass it to the
6664 data-in parsing routines. This contradicted the documented
6665 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6666 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6667 free-format parsing that differed from SPSS.
6668 (cut_field) Commas and spaces are treated identically. Returns
6669 the proper column instead of a fixed 1 value.
6670 (parse_field) Removed.
6671 (read_from_data_list_free, read_from_data_list_list) Call
6672 parse_string_as_format directly instead of parse_field.
6674 * heap.c: (heap_delete) Stylistic fixes.
6676 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6678 * loop.c: (loop_2_trns_proc) Formatting fix.
6680 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6682 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6684 * vfm.c: (macro FILTERED) New.
6685 (static var filter_var) New.
6686 (process_active_file_write_case) Use FILTERED.
6687 (setup_filter) Set filter_var.
6688 (close_active_file) Delete the filter if not
6689 FILTER_before_TEMPORARY.
6690 (procedure_write_case) Use FILTERED.
6692 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6694 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6696 * data-in.c: (parse_day_count) Message fix.
6697 (parse_month) Style fix.
6699 * data-list.c: (struct data_list_pgm) New member eof.
6700 (cmd_data_list) Init eof to 0.
6701 (do_reading) Implement the /END subcommand and read-past-eof
6704 * do-if.c: Include stdio.h when debugging.
6705 (cmd_else_if) Make sure the command is .-terminated.
6707 * glob.c: (init_glob) Capitalize the command prompt.
6709 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6710 (end_file_trns_proc) Debugging message.
6712 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6714 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6716 * main.c: (dump_token) Make kwtab[] const.
6718 * set.q: Spelling, comment fixes.
6720 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6723 * vars-prs.c: (fill_all_vars) Style fix.
6725 * vfm.c: (index_to_varname) Return const.
6727 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6729 * Changes in many source files for partial -ansi -pedantic and
6730 no-debugging compliance: Remove trailing common in enum
6731 declarations; add `unused' attributes; insert some appropriate
6734 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6736 * command.c: (shell) Make static.
6737 (run_command) Make static.
6739 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6741 * dfm.c: (cmd_begin_data) I18n fix.
6743 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6745 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6747 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6750 * file-handle.q: Don't prepend the source file directory name to
6751 the data file name. (Ongoing issue.)
6752 (prepend_current_directory) Comment out.
6753 (internal_cmd_file_handle) Don't call prepend_current_directory().
6754 (fh_get_handle_by_filename) Ditto.
6756 * filename.c: Append zero byte to readlink() return value.
6758 * getline.c: (getl_read_line) I18n fix.
6760 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6762 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6764 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6767 * postscript.c: (output_encodings) Don't use local_strdup().
6770 * print.c: Don't use gcc features if __STRICT_ANSI__.
6772 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6774 * recode.c: (parse_src_spec) Fully brace nested if's.
6776 * set.q: (global var set_testing_mode) New var.
6778 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6780 * ascii.c: Add some more `unused' attributes that only come into
6781 play when NDEBUG is defined.
6782 (ascii_close_page) Set s_len when reallocating s.
6784 * crosstabs.q: (delete_missing) New function.
6785 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6786 (make_summary_table) Create summary table reallocable.
6788 * postscript.c: Add more `unused' attributes as above.
6790 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6791 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6793 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6796 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6797 gratuitous space between parameter definition.
6799 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6800 complaints about running off the end of functions with NDEBUG
6803 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6805 * Several source files: Removed some PORTME notes when reflection
6806 revealed that ANSI forbids that sort of breakage. Also, added
6807 lots of `unused' qualifiers here and there.
6809 * aggregate.c: (accumulate_aggregate_info) Remove local var
6810 weighting that turned out not to be used.
6812 * avl.c: Update to version 1.1.0. Add unused specifier.
6813 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6815 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6816 (avl_find) Cast return value to void *.
6817 (avl_delete) q doesn't need to be initialized at the beginning of
6818 the function. Replace some instances of 1 with +1.
6819 (force_avl_delete) Renamed avl_force_delete, all references changed.
6820 (compare_ints) `param' marked unused.
6821 (print_int) `param' marked unused.
6822 (recurse_tree) Replace some instances of 1 with +1.
6824 * avl.h: Update to version 1.1.0. Only declares avl function
6825 types if not already declared.
6826 (AVL_MAX_HEIGHT) Only define if not already defined.
6827 (struct avl_node) New unused member char pad[2].
6828 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6829 (force_avl_insert) Renamed avl_force_insert.
6830 (force_avl_delete) Renamed avl_force_delete.
6832 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6834 (struct crosstab) Add new member `ofs'.
6835 (glob var int_tab) Removed.
6836 (custom_tables) In integer mode, assign v[i] properly through the
6838 (custom_variables) Now p.crs.max == max + 1.
6839 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6840 (precalc) Implement integer mode.
6841 (calc_integer) Implement integer mode.
6842 (compare_table_entry) Remove unused local variable `comparing'.
6843 (make_summary_table) Implement integer mode.
6844 (macro ns_rows) Implemented as static variable now.
6845 (several variables) Made static, from global.
6846 (output_pivot_table) Use table_value_missing() for column heads.
6847 Remove several unused local variables. Implement integer mode
6848 table summing. Count up ns_rows.
6849 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6850 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6851 calls that function or find_pivot_extent_integer.
6852 (find_pivot_extent_integer) New function.
6853 (enum_var_values) Implemented for integer mode.
6854 (table_value_missing) New function.
6855 (display_dimensions) Call table_value_missing() for heads.
6856 (float_M_suffix) New function.
6857 (display_crosstabulation) Call table_value_missing() for row
6858 heads. Handle missing values in /MISSING=REPORT mode.
6859 (calc_fisher) Remove unused var N.
6860 (calc_r) Remove unused var fact.
6862 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6863 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6865 * data-out.c: (insert_commas) Remove unused var cp.
6866 (convert_CCx) Remove unused vars save_set_decimal,
6869 * descript.q: (dump_z_table) Fix table dimensioning.
6870 (pre_calc) Remove unused var j.
6871 (display) Remove unused vars title, s. Fix table dimensioning.
6873 * expr-evl.c: Comment fixes.
6875 * frequencies.q: (full_dim) New function.
6876 (dump_full) Fix table dimensioning.
6877 (condensed_dim) New function.
6878 (dump_condensed) Fix table dimensioning.
6880 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6883 * html.c: (html_close_drive) Remove unused var i.
6884 (postopen) Remove unused vars title, curfn_len, cp.
6885 (preclose) Remove unused vars this, x.
6887 * lexer.c: Comment fixes.
6889 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6891 * means.q: (custom_tables) Remove unused var m_dim.
6893 * mis-val.c: Format fix.
6895 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6897 * output.c: (outp_get_paper_size) Remove unused var cp.
6899 * pfm-read.c: (read_float) Remove unused var save, unused label
6901 (read_variables) Remove unused vars cp, j.
6902 (read_value_label) Remove unused var j.
6904 * pfm-write.c: (bufwrite) Remove unused var i.
6906 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6908 (output_encodings) Remove unused vars char_cp, n_output.
6909 (read_ps_encodings) Remove unused var ep.
6910 (postopen) Remove unused var title.
6911 (preclose) Remove unused var fp.
6912 (ps_open_page) Remove unused vars true, false, orientation,
6913 mirror_horz, mirror_vert, width, length.
6914 (ps_text_metrics) Remove unused var x.
6916 * q2c.c: (find_symbol) Remove unused var y.
6917 (parse_setting) Remove unused parameter sbc, all references
6919 (dump_parser) Remove unused var cp.
6920 (dump_free) Remove unused var i.
6922 * set.q: (static vars args, n) Removed.
6923 (internal_cmd_gset) Removed.
6925 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6926 (read_machine_flt64_info) Removed unused var file_endian.
6927 (read_documents) Removed unused var i.
6928 (read_compressed_data) Removed unused parameter dict, all
6931 * sfm-write.c: (bufwrite) Removed unused var i.
6932 (sfm_write_case) Removed unused var i.
6934 * sort.c: (merge_once) Remove unused var t.
6935 (write_separate) #if 0 out as dead code.
6937 * split-file.c: (cmd_split_file) Remove unused var i.
6939 * sysfile-info.c: (sysfile_info_dim) New function.
6940 (cmd_sysfile_info) Fix table dimensioning.
6941 (variables_dim) New function.
6942 (display_variables) Fix table dimensioning.
6943 (describe_variable) Remove unused var prev_r.
6945 * t-test.q: (z_postcalc) Removed.
6946 (pairs_calc) Remove unused var bad_weight.
6947 (postcalc) Remove unused vars dfn, dfd.
6949 * tab.c: (tab_create) Set t->dim to NULL.
6950 (tab_dim) Make sure t->dim is NULL first.
6951 (tab_natural_width) Remove parameter `clamp'.
6952 (tab_value) Remove duplicate assertion for table.
6953 (tab_raw) New function.
6954 (nowrap_dim) New function.
6955 (wrap_dim) New function.
6956 (tab_output_text) Fix table dimensioning.
6958 * tab.h: (tab_raw) New macro.
6960 * val-labs.c: (get_label) Remove unused var type.
6961 (copy_value_labels) Remove unused var trav.
6963 * var.h: (struct crosstab_proc) Completely changed.
6965 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6967 * vfm.c: (open_active_file) Remove unused vars i, lp.
6969 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6971 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6973 * Makefile.am: Add apply-dict.c, flip.c.
6975 * apply-dict.c: New file.
6977 * command.c: (struct command) Make cmd[] larger for CLEAR
6978 TRANSFORMATIONS command name.
6979 (parse_cmd) Make sure we're in a valid state before using it as an
6980 index. Discard variables and reset state on invalid transitions.
6981 (cmd_clear_transformations) New function.
6983 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6984 Add unimplemented PRESERVE, RESTORE.
6986 * file-handle.h: Include stddef.h.
6990 * pfm-read.c: (parse_value) Pad value label values with spaces,
6993 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6994 (sfm_close) Decrement reference count, make sure it's zero.
6995 (sfm_maybe_close) New function.
6996 (sfm_read_dictionary) Handle reference counts.
6998 * vars-atr.c: (clear_default_dict) New function.
6999 (discard_variables) Use clear_default_dict().
7001 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
7003 * Makefile.am: Add pfm-write.c.
7004 (LDADD) Add the libgmp2 libraries.
7006 * command.def: Define EXPORT.
7008 * get.c: (cmd_export) New function.
7009 (export_write_case_func) New function.
7011 * pfm-read.c: (static spss2ascii[]) Make it const.
7013 * pfm-write.c: New file.
7015 * sfm-write.c: Formatting, comment fixes.
7017 * var.h: Comment fix.
7019 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
7021 * Makefile.am: Add pfm.h, pfm-read.c.
7023 * command.def: IMPORT is now implemented.
7025 * format.c: (glob var translate_fmt[]) New var.
7027 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
7028 (cmd_import) New function.
7029 (import_source_read) New function.
7030 (glob var import_source) New var.
7032 * pfm-read.c: New file.
7036 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
7038 (dump_dictionary) Disabled printing a couple of items.
7040 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
7042 * crosstabs.q: (postcalc) Call make_summary_table().
7043 (make_summary_table) New function.
7044 (insert_summary) New function.
7045 (display_dimensions) Remove some unnecessary arguments, all
7047 (output_pivot_table) Fix lots of problems with the risk table
7049 (submit) Don't display an empty table.
7050 (display_risk) Fix order of arguments to calc_risk().
7052 * glob.c: Always include assert.h and stdlib.h.
7054 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
7057 * tab.c: (tab_create) Cosmetic changes.
7059 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
7061 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
7065 * crosstabs.q: (output_pivot_table) Headers drawing and submission
7066 code simplified, moved into new function submit().
7067 (submit) New function.
7068 (crosstabs_dim) New function.
7069 (display_directional) Substitute variable names for %s where
7071 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
7072 (calc_symmetric) Initialize parameters only if non-NULL.
7073 Calculate Somers' d.
7074 (calc_directional) Calculate Somers' d (or copy it, really).
7077 * output.c: (outp_string_width) New function.
7079 * postscript.c: (postopen) Calculate font widths based on the
7080 width of the zero '0' character, not the width of the space
7081 character. Set paper-width and paper-length based on points, not
7083 (ps_open_page) Fix page setup string for landscape mode.
7085 * som.h: (struct som_dimension) Removed.
7086 (struct som_table_class) height, width members take int * not
7089 * tab.c: Many functions now have added parameter validation.
7090 (tab_height, tab_width) These functions were removed and merged
7091 into a single function tab_resize(), and all references changed.
7092 (tab_dim) Rewritten since the interface changed; reduced from
7093 hundreds of lines to two. All callers were changed. Currently
7094 most of them just use tab_natural_dimensions as their callback and
7095 await detailed translation of functionality.
7096 (tab_natural_width) New function.
7097 (tab_natural_height) New function.
7098 (tab_natural_dimensions) New function. This is a callback
7099 function, not something that you'd want to call directly.
7100 (tab_nat_dim) Removed.
7101 (tabi_table) Allocates t->w and t->h.
7102 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
7103 dimensions callback.
7104 (evaluate_dimensions) Removed.
7105 (sum_columns) Removed.
7107 * tab.h: (enum TAL_1THIN) Removed.
7108 (enum series t_*) Removed.
7109 (struct tab_table) Members trh, trv changed to unsigned char *
7110 from int *. Member dim changed to a function pointer from a
7111 unsigned char *. Member max_stack_height removed. New members
7113 (macros tab_l, tab_r, tab_t, tab_b) New.
7115 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
7117 * ascii.c: (delineate) Assign last_space_nchars before skipping
7118 spaces, to fix right justification.
7120 * crosstabs.q: (static vars risk, direct) New vars.
7121 (static var pearson_r) Removed.
7122 (glob var chisq_fisher) Made static.
7123 (static vars row_tot[], col_tot[]) Don't include grand total
7125 (static var grand_total) Renamed W, all references changed.
7126 (output_pivot_table) Only make `table' if num_cells != 0. Make
7127 risk and directional tables. Deal with grand total no longer part
7128 of col_tot[]. Free rows and cols after we're done with them.
7129 (display_risk) New function.
7130 (display_directional) New function.
7131 (clac_r) Rewritten so that it stores all its results into its
7132 arguments, so it can be used for Spearman's correlation too.
7133 (calc_symmetric) Added a t[] argument, all references changed.
7134 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
7135 Pearson's r, Cohen's kappa.
7136 (calc_risk) New function.
7137 (calc_directional) New function.
7139 * som.c: (som_submit) Improved debugging code.
7141 * stats.c: (hypercube) New function.
7142 (cube) New function.
7144 (normal_sig) Went back to old implementation, which actually
7147 * stats.h: (macros square, cube, hypercube) Removed. The
7148 equivalent functions in stats.c are inlined here; all references
7149 to square changed to sqr.
7151 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
7153 * crosstabs.q: (N_SYMMETRIC) New define.
7154 (postcalc) Disable debug printing.
7155 (static vars chisq_fisher, pearson_r) New.
7156 (output_pivot_table) Add support for symmetric measures. Add
7157 chi-square output of exact sigs.
7158 (display_chisq) Rewritten.
7159 (display_symmetric) New function.
7160 (gamma_int) New function.
7162 (swap) New function.
7163 (calc_fisher) New function.
7164 (calc_chisq) Check boundary conditions better. Calculate Yates,
7165 Fisher, Mantel-Haenszel tests.
7166 (calc_r) New function.
7167 (calc_symmetric) New function.
7169 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
7171 (chisq_sig) Better boundary conditions. Renamed from
7174 * tab.h: (struct tab_table) New member cf.
7176 * tab.c: (tab_create) Set cf.
7177 (tab_width) New function.
7178 (tab_realloc) Handle cf.
7179 (tab_vline) Handle cf.
7180 (tab_hline) Handle cf.
7181 (tab_box) Handle cf.
7182 (tab_value) Handle cf.
7183 (tab_float) Handle cf.
7184 (tab_text) Handle cf.
7185 (tab_joint_text) Handle cf.
7186 (tab_offset) Handle cf.
7187 (tab_next_row) Handle cf.
7188 (evaluate_dimensions) Handle cf.
7189 (render_strip) Handle cf.
7191 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
7193 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
7194 output_pivot_table().
7195 (output_pivot_table) Moved lots of local variables outside and
7196 made them static. Add beginnings of chi-square statistic
7197 support. Now column and row totals aren't in the main matrix.
7198 Always zero out any leftover rows & columns after we're done with
7199 the table entries. Move all output stuff into
7200 display_dimensions(), display_crosstabs(), display_chisq().
7201 (display_dimensions) New function.
7202 (display_crosstabulation) New function.
7203 (display_chisq) New function.
7204 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
7206 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
7207 references, simplify logic.
7209 * postscript.c: Remove scale, translate-x, translate-y,
7210 mirror-horz, mirror-vert, rotate-180 options.
7211 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
7212 All references deleted.
7213 (macro YT) New macro.
7214 (array option_tab[]) Removed options.
7215 (ps_option) Removed options.
7216 (ps_open_page) Write page setup explicitly to output file, without
7217 using now-deleted BP function.
7218 (macro dump_line) Use YT().
7219 (macro dump_thick_line) Use YT().
7220 (draw_headers) Use YT().
7221 (switch_font) Reorder arguments to SF function.
7222 (write_text) Use YT().
7224 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
7227 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
7229 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
7230 null-debugging code.
7231 (tab_realloc) Remove null-debugging code. Initialize new regions
7233 (tab_vline) Support offsets.
7234 (tab_hline) Support offsets.
7235 (tab_box) Support offsets.
7237 (tab_nulls) Removed.
7240 (evaluate_dimensions) Remove null-debugging code. Understand
7241 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
7242 TAB_EMPTY not present.
7244 * tab.h: New cell attribute TAB_EMPTY.
7245 (macros tab_nr, tab_nc, tab_row, tab_col) New.
7247 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
7248 try to read them from system files.
7250 * vfm.c: (dump_splits) Don't call tab_null().
7252 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7254 * crosstabs.q: (struct crosstab) Added `missing' member.
7255 (custom_tables) Init missing.
7256 (calc_general) Handle missing values.
7257 (calc_chisq) New function.
7258 (output_pivot_table) Start work on chi-square output. Update for
7259 new tab offset support functions. Shorten statistic names.
7261 * Several files: add in more `const's to placate gcc's warnings.
7263 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7266 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7267 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7268 tab_joint_text) Add col_ofs and row_ofs support.
7269 (tab_offset) New function.
7270 (tab_next_row) New function.
7271 (tab_row) New function.
7272 (tab_col) New function.
7273 (tabi_table) Add col_ofs and row_ofs support.
7275 * vars-atr.c: (is_system_missing) New function.
7277 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7279 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7280 (static var no_cells) Removed.
7281 (static var num_cells) New.
7282 (static var expected) New.
7283 (static var cells[]) New.
7284 (internal_cmd_crosstabs) Deal with new variables.
7285 (postcalc) Removed most of the meat and put it in new function
7286 output_pivot_table().
7287 (output_pivot_table) Calculates and outputs an entire pivot table.
7289 * postscript.c: (postopen) Fix problems with free()ing addresses
7290 not obtained from malloc().
7292 * som.c: (som_submit) Add assertion.
7294 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7297 * tab.c: (static var tab_names[]) New.
7298 (tab_realloc) -1 for nc or nr indicates no change.
7299 (tab_nulls) New function.
7300 (tab_dim) Use tab_names[].
7301 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7302 (evaluate_dimensions) Don't terminate on uninited cells, just put
7303 an X in them and emit a notice. Use tab_names[].
7305 * tab.h: Move bits into tab.def.
7307 * tab.def: New. Don't try to declare tab_table_class because then
7308 som.h has to be included.
7310 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7312 * command.def: New file, contains all the command definitions
7313 previously included bodily in command.c.
7315 * format.def: New file, contains all of the format definitions
7316 previously split across format.h, format.c, and sfm-write.c.
7318 * lexer.h: Renamed from tokens.h in order to match corresponding
7321 * lexerP.h: Moved some rarely used functions exported by lexer.c
7324 * Makefile.am: Commemorate renamed files.
7325 (EXTRA_DIST) Add command.def, format.def.
7327 * command.c: [0] (walk_cmdtable_func) Removed.
7329 * crosstabs.q: (postcalc) Made it work and print out matrices
7331 (enum_column_values) Renamed enum_var_values, generalized for any
7334 * format.h: (struct fmt_desc) New member `spss'.
7336 * q2c.c: (main) Generated code includes lexer.h instead of
7339 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7340 instead of an independent translation table.
7342 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7344 * Lots of source files: Added const to declarations.
7346 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7348 * arena.c: (arena_clear) Set prev pointer to null when done.
7350 * ascii.c: (ascii_option) Rename index as indx.
7352 * avl.c: This is now a separate library called libavl.
7353 (xmalloc) Make static.
7354 (avl_probe) Step A7 can use the cache instead of an explicit
7356 (avl_delete) Don't maintain a q pointer because it's always
7357 available in the pointer stack. Comment fix.
7359 * avl.h: This is now a separate library called libavl.
7361 * command.c: (cmd_table[]) Remove spurious trailing "".
7363 * common.h: Only include random() fix if this system needs it.
7365 * crosstabs.q: Include alloca headers.
7366 (n_sorted_tab) New global var.
7367 (postcalc) Mostly rewritten.
7368 (find_pivot_extent) Rewritten.
7369 (enum_column_values) Rewritten.
7371 * data-out.c: (convert_F) Rename inner n as n_spaces.
7373 * error.c: (dump_message) Don't have an outer var i.
7375 * file-handle.q: (static var f) Removed. All references removed.
7376 (internal_cmd_file_handle) Uses a local variable instead of f.
7378 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7379 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7382 * getline.h: Declare getl_history as extern. Reported by
7383 palme@uni-wuppertal.de (Hubert Palme).
7385 * postscript.c: (postopen) Some large mods for constness.
7387 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7390 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7392 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7393 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7396 * avl.c, avl.h: New files. These form a clean-room
7397 reimplementation of avllib. Iterative algorithms are used in
7398 place of recursive ones, so there is no resemblance in the code.
7400 * Lots of headers: Don't include other headers by default.
7402 * Lots of source files: Explicitly include all needed headers.
7404 * arena.c: (arena_clear) New function.
7406 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7407 (static var ar) Removed.
7408 (staitc vars ar_tc, ar_col) New.
7409 (cmd_crosstabs) Destroy the arenas.
7410 (internal_cmd_crosstabs) Create the arenas.
7411 (precalc) Don't need a free function for the hash.
7412 (calc_general) Make sure to zero out the trailer on the key data
7414 (print_table_entries) Updated.
7415 (postcalc) Worked on actually implementing.
7416 (find_pivot_extent) New function.
7417 (compare_value) New function.
7418 (enum_column_values) New function.
7420 * data-in.c: (parse_month) Make local array `static const'.
7422 * data-out.c: (convert_date) Make local array `static const'.
7423 (convert_WKDAY) Same.
7424 (convert_MONTH) Same.
7426 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7427 been renamed to avl_walk().
7429 * hash.c: Rewritten more efficiently.
7431 * hash.h: Add attribute const to hsh_next_prime declaration.
7433 * lexer.c: (id_match) Make arguments const.
7435 * postscript.c: (ps_postopen_driver) Make default fonts the
7438 * q2c.c: (main) Generated code needs stdlib.h.
7440 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7441 initialized to 0 now, not to NULL. All other references to
7442 avl_traverser were updated in the same way.
7444 * tokens.h: Macro version of id_match updated to use const
7447 * val-labs.c: (inc_ref_count) New function.
7448 (copy_value_labels) Simply through use of new avl_copy() function.
7450 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7452 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7453 (postcalc) Worked on this.
7455 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7456 (struct ps_driver_ext) New line_width_thick member.
7457 (ps_preopen_drive) Init line_width_thick.
7458 (option_tab[]) Add line-* options.
7459 (ps_option) Parse line-* options.
7460 (postopen) Add line_width_thick support. Strip leading spaces on
7461 prologue output lines.
7462 (ps_open_page) Include line_width_thick in output.
7463 (macro dump_thick_line) New.
7464 (dump_fancy_line) Support thick lines as well as double lines.
7466 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7468 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7469 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7471 * Many source files: Rename `options' to `pv_opts' as appropriate.
7473 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7475 * common.c: (xcalloc) New function.
7477 * crosstabs.q: New file. Not finished yet, though.
7479 * data-list.c: Comment fix.
7481 * error.c: Remove some old Checker cruft.
7483 * frequencies.q: (dump_full) Cumulate valid percent instead of
7486 * getline.c: Comment fix.
7488 * hash.c: Comment fixes.
7490 * hash.h: (struct hsh_table) Make hash functions return unsigned
7491 instead of int to avoid problems with taking the modulo of
7492 negative return values. All references changed.
7494 * misc.c: (intlog10) Make its table static const instead of auto.
7496 * sfm-read.c: (read_header) Make `prefix' static const instead of
7499 * var.h: (union value) Add member `hash'.
7500 (struct variable) Rename prv_index as `foo'--all references
7502 (typedef pv_opts) Removed. All references changed.
7504 * vars-prs.c: (parse_variables) Message fixes.
7506 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7508 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7509 they are being inserted. Don't check for BY variables of
7510 different types. Discard variables if the active file isn't
7511 included in the merge.
7512 (mtf_processing) Essentially rewritten.
7513 (mtf_merge_dictionary) Check for master/slave variables of
7514 different types/widths.
7516 * vfm.c: (static var not_canceled) New var.
7517 (process_active_file) Don't call vfm_source->read() if
7518 there's no vfm-source. Initialize not_canceled.
7519 (process_active_file_write_case) Honor and update not_canceled.
7520 (prepare_for_writing) Rollback changes from yesterday, they were
7522 (close_active_file) Don't destroy vfm_source unless it exists.
7524 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7526 * Lots of source files: Added { } around nested if/else constructs
7527 to avoid new gcc 2.8 warnings.
7529 * data-in.c: (parse_Z) Declare `int' type explicitly.
7532 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7533 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7534 prev members. Put TABLEs at the end of the chain and FILEs at the
7535 beginning. Don't allow the active file in STATE_INIT. Use proper
7536 `seen' value for the active file. Fill out the by members and
7537 make sure they're of consistent type. Do the actual merge
7539 (mtf_processing_finish) New function.
7540 (var_type_description) New function.
7541 (mtf_free_file) New function.
7542 (mtf_free) Rewritten.
7543 (mtf_delete_file_in_place) New function.
7544 (mtf_read_nonactive_records) New function.
7545 (mtf_compare_BY_values) New function.
7546 (static var mtf_seq_no) New var.
7547 (mtf_processing) New function.
7548 (mtf_merge_dictionary) Assign nval members for the system file
7549 dictionary. Assign fv values for its variables. Point each slave
7550 variable to the corresponding master variable.
7552 * hash.c: Include str.h.
7554 * mis-val.c: (copy_missing_values) src arg is const.
7556 * misc.c: (spacing) Make `max' var explicitly int.
7558 * sfm-read.c: (dump_dictionary) Message reformatting.
7559 (sfm_read_case) Add assertion.
7561 * sort.c: Esthetic fixes.
7563 * var.h: (struct match_files_proc) New struct.
7564 (struct variable) Add private data match_files_proc.
7566 * vars-atr.c: (delete_variable) Implement. Add argument for the
7567 dictionary that owning the variable.
7568 (dup_variable) Add assertion.
7570 * vfm.c: Comment fixes, hopefully the comments are correct now.
7571 (process_active_file) New function.
7572 (process_active_file_write_case) New function.
7573 (process_active_file_output_case) New function.
7574 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7576 (write_case) Renamed procedure_write_case(). Now write_case is a
7577 pointer to a function. Style fixes.
7579 1998-03-05 Ben Pfaff <blp@gnu.org>
7581 * Makefile.am: (q2c) Link with libmisc.
7582 (version.c) Define default_config_path, include_path,
7585 * ascii.c: (ascii_postopen_driver) When the default newline string
7586 is requested, open file in text mode. Suggested by
7587 palme@uni-wuppertal.de (Hubert Palme).
7588 (static vars line_buf, line_p) Change from char * to unsigned char
7590 (ascii_close_page) char * to unsigned char *.
7592 * cmdline.c: (parse_command_line) Implement -r option by
7593 prepending ~/.pspp/rc to the list of files to process.
7595 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7596 before pulling in a final line.
7597 (null_func, null_int_func) Removed (dead code).
7599 * descript.q: (display) Calculate width of variable name column
7600 properly. Calculate number of valid cases properly. Reported by
7601 palme@uni-wuppertal.de (Hubert Palme).
7603 * filename.c: (init_filename) Use default_config_path instead of
7604 now obsolete CONFIG_PATH.
7606 * getline.c: (getl_initialize) Use include_path instead of now
7607 obsolete INCLUDE_PATH.
7608 (getl_add_file) New argument `where'. All references changed.
7610 * groff.c: (find_font_file) Use groff_font_path instead of now
7611 obsolete GROFF_FONT_PATH.
7613 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7614 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7615 avoid problems with constness.
7617 * str.h: (macro cs_streq) New macro.
7619 * version.h: (glob var default_config_path, include_path,
7620 groff_font_path) New vars.
7622 1998-02-23 Ben Pfaff <blp@gnu.org>
7624 * Many source files: Change verbose_msg() priority levels and
7627 * aggregate.c: Include debug-print.h.
7629 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7631 (static var pre_syntax_message) Document --safer/-s and
7634 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7636 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7637 because it's not used but it's still copied.
7638 (open_file_r) Remove gratuitous debug message.
7640 * filename.c: (safety_violation) New function.
7641 (open_file) Remove gratuitous debug messages. Don't allow pipe
7642 files if set_safer is set.
7644 * get.c: Turn off debugging.
7646 * getline.c: (getl_add_virtual_file) New function.
7647 (getl_read_line) Add verbose_msg() call for opening new syntax
7649 (getl_perform_delayed_reset) Add a return value describing whether
7650 any action was taken. Call reset_eof().
7652 * getline.h: Comment fix.
7654 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7655 place of incorrect `continue'. Use strtok_r() instead of
7656 strtok(). Always check strtok_r() return value.
7657 (groff_read_DESC) Use strtok_r() instead of strtok().
7659 * lexer.c: (reset_eof) New function.
7661 * main.c: (parse) Get a token after performing a delayed reset
7662 action; allow empty syntax files.
7664 * postscript.c: (output_encodings) Use strtok_r() instead of
7667 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7669 * set.q: Comment fixes.
7670 (glob var set_safer) New var.
7671 (internal_cmd_set) Support SAFER.
7673 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7675 * temporary.c: (free_dictionary) Set d->splits to NULL after
7678 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7679 variable deleted, not if it *isn't* deleted.
7681 1998-02-16 Ben Pfaff <blp@gnu.org>
7683 * command.c: (array cmd_table[]) Add MATCH FILES.
7685 * common.c: Comment fixes.
7687 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7688 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7689 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7692 * expr-opt.c: Include str.h. Problem reported by
7693 palme@uni-wuppertal.de (Hubert Palme).
7695 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7696 (static var mtf_by) Change from char ** to variable **.
7697 (static var mtf_master) New var.
7698 (mtf_merge_dictionary) New function.
7699 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7700 var type. Reorder tests properly. Initialize file->dict. Detect
7701 TABLE= without BY=. Read file dictionaries and merge them. Give
7702 subcommand name with IN, LAST, FIRST error messages. Create IN,
7703 LAST, FIRST variables. Comment fixes.
7704 (mtf_free) Don't free default_dict. Free mtf_master.
7706 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7708 (handle_line_buffer) Cast int to size_t in comparison to avoid
7711 * getline.h: Declare getl_mode extern.
7713 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7714 (groff_read_DESC) Make line_size a size_t.
7715 (match_tok) Parenthesize name to avoid macro expansion.
7717 * mis-val.c: (copy_missing_values) New function.
7719 * postscript.c: (postopen) Make buf_size a size_t.
7721 * sfm-read.c: (dump_dictionary) Make global from static. Print
7722 variable info in parts for easier debugging with Checker.
7724 * temporary.c: (copy_variable) Use copy_value_labels().
7725 (new_dictionary) New arg: whether to copy file label, documents.
7727 * val-labs.c: (copy_value_labels) New function.
7729 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7731 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7733 (dup_variable) Set prv_index, get.fv, get.nv.
7735 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7737 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7739 * Many source files: For ANSI-compliance, add empty statement
7740 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7741 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7743 * data-in.c: (parse_numeric) Some header files break on
7744 -DBL_MIN_10_EXP because they get a --; add () for safety.
7745 Reported by palme@uni-wuppertal.de (Hubert Palme).
7747 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7748 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7749 (dfm_close) Use close_file_ext.
7750 (open_inline_file) Set file.file to NULL, not file.
7751 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7752 struct and use open_file_ext().
7753 (read_record) Use file.file.
7755 * file-handle.q: (prepend_current_directory) Pass through special
7758 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7759 (normalize_filename) Pass through special filenames.
7760 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7762 (dirname) Rename blp_dirname() because of name conflict on some
7763 OS. All references changed. Reported by palme@uni-wuppertal.de
7765 (is_special_filename) New function.
7767 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7768 (trim_dictionary) Conditionalize some of the options on whether
7769 GTSV_OPT_MATCH_FILES is in *options.
7770 (rename_variables) Don't allow variables to be renamed as scratch
7772 (MTF_*) New enum series.
7773 (struct mtf_file) New struct.
7774 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7776 (cmd_match_files, mtf_free) New functions.
7778 * lexer.c: (match_int) Needed parentheses around name to escape
7779 macro expansion. Reported by Micah Altman
7780 <maltman@www-vdc.fas.harvard.edu>.
7782 * print.c: Needed to include alloca.h. Reported by Micah Altman
7783 <maltman@www-vdc.fas.harvard.edu>.
7785 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7786 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7789 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7790 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7792 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7794 * html.c: (struct html_driver_ext) Move into htmlP.h.
7795 (html_preopen_driver) Initialize cp_x, cp_y.
7796 (html_submit) Implement as call to output_tab_table().
7797 (change_attributes) New function.
7798 (escape_string) New function.
7799 (output_tab_table) New function.
7801 * list.q: (write_all_headers) Add code for writing headers for the
7803 (clean_up) Write out the html close-table tag.
7804 (determine_layout) Ignore html driver.
7805 (list_cases) Write html data.
7807 * som.c: (som_submit) Move more of the code into output_table().
7809 * tab.c: (static var hit) Make a global var and rename tab_hit.
7810 (static var tab_table_class) Make a global var.
7812 * htmlP.h: New file.
7814 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7816 * dump-sysfile.c: Removed.
7818 * html.c: (preclose) Change comment in emitted code.
7820 * matrix-data.c: Debugging off by default. Comment fixes.
7821 (static var container) New var.
7822 (cmd_matrix_data) Create and destroy container. Initialize
7823 is_per_factor[] to 0s. Move code into new function
7824 string_to_content_type(). Require split values to be present in
7825 the data when ROWTYPE_ is explicit. Call specific function, not
7826 general read_matrices().
7827 (string_to_content_type) New function.
7828 (context) Exclude all whitespace, not just spaces.
7829 (mget_token) A dot is a number. Add assertion.
7830 (static var data) Renamed nr_data.
7831 (static var factor_values) Renamed nr_factor_values.
7832 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7833 only specific case. Close data_file before exit.
7834 (fill_matrix) New function.
7835 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7836 printing. Style fixes. Message fixes. Move code into
7838 (read_matrices_without_rowtype) Rename
7839 matrix_data_read_without_rowtype(). Fix off-by-one error on
7840 loops. Allocate nr_data[] memory from arena.
7841 (read_matrices_with_rowtype) Removed.
7842 (read_splits) Renamed nr_read_splits(). Style fixes.
7843 (read_factors) Renamed nr_read_factors().
7844 (dump_cell_content) Comment fixes. Arguments changed. Change
7845 debug printing. All references changed.
7846 (output_data) Renamed nr_output_data().
7847 (static var wr_content) New var.
7848 (struct factor_data) New struct.
7849 (static var wr_data) New var.
7850 (static var wr_current) New var.
7851 (matrix_data_source_destroy_source) Removed.
7852 (read_matrices_with_rowtype) New function.
7853 (matrix_data_read_with_rowtype) New function.
7854 (wr_read_splits) New function.
7855 (compare_factors) New function.
7856 (wr_output_data) New function.
7857 (wr_read_rowtype) New function.
7858 (wr_read_factors) New function.
7859 (wr_read_indeps) New function.
7860 (glob var matrix_data_source) Make destroy_source member NULL as
7863 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7865 * lexer.c: (syntax_error) Give better error message when at end of
7868 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7869 N_SCALAR to output as plain N.
7870 (mdump_token) Change output format.
7871 (context) Fix message output interaction with spaces in input.
7872 (another_token) New function.
7873 (force_eol) Improved error message.
7874 (static var max_cell_index) New var.
7875 (read_matrices) Init `cells'. factor_values is now per-cell.
7876 Init max_cell_index.
7877 (read_data_lines) Replace `compare' local with new `compare' arg.
7878 Debugging messages changed. Only read factors if per_factor.
7879 Propagate error return from read_factors(), force_eol().
7880 Copy N_SCALAR values across the N vector.
7881 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7882 check parentheses manually since we now have is_per_factor[].
7883 Call read_data_lines() with new args. Check for end of data after
7884 looping, using another_token().
7885 (read_factors) Arguments changed. Use max_cell_index to determine
7886 whether to read or compare factors. Message fixes.
7887 (dump_cell_content) New function.
7888 (output_data) Completely rewritten because content types were
7889 supported to be nested inside factor values, not vice versa.
7891 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7893 * lexer.c: (syntax_error) Support formatted varargs messages.
7895 * matrix-data.c: Turn debugging on by default.
7896 (static content_type[]) New array.
7897 (static content_names[]) New array.
7898 (static rowtype_, varname_) New vars.
7899 (static is_per_factor[]) New array.
7900 (static split_values) Moved declaration.
7901 (static n_continuous, first_continuous) New var.
7902 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7903 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7904 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7905 Check for continuous variables.
7906 [DEBUGGING] (debug_print) Remove content_names[].
7907 (mdump_token) New macro.
7908 (mget_token_dump) New function.
7909 (mdump_token) New function.
7910 (context) New function.
7911 (mget_token) Fix messages.
7912 (static var data, split_values, factor_values) New vars.
7913 (read_matrices) Manage split_values, factor_values.
7914 (read_data_lines) New function.
7915 (read_matrices_without_rowtype) Implemented.
7916 (read_splits) Message fixes. Uses `just_read'.
7917 (read_factors) New function.
7918 (output_data) New function.
7919 (matrix_data_source_destroy_source) Close the file handle.
7920 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7923 * str.c: (strpadcmp) Removed.
7925 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7927 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7929 * Lots of source files: Add cast to unsigned character to calls to
7930 tolower() and toupper().
7932 * aggregate.c: Set default_dict.splits to NULL.
7934 * command.c: (static variable tab[]) Add MATRIX DATA.
7936 * data-in.c: Add debugging defines. Formatting fixes.
7938 * expr-opt.c: Formatting fixes.
7940 * lexer.c: (syntax_error) Message fixes.
7942 * matrix-data.c: New enum series.
7943 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7944 split_values, n_factors, factors, cells, pop_n, contents,
7945 n_contents) New vars.
7946 (cmd_matrix_data) Finished implementation.
7947 (compare_variables_by_mxd_vartype) New function.
7948 [DEBUGGING] (debug_print) New function.
7949 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7950 (read_matrices) New function.
7951 (read_matrices_without_rowtype) New function.
7952 (read_matrices_with_rowtype) New function.
7953 (read_splits) New function.
7954 (mget_token) New function.
7955 (force_eol) New function.
7956 [0] (test_tokenizer) New function.
7957 (matrix_data_source_destroy_source) New function.
7958 (glob var matrix_data_source) New var.
7960 * misc.h: Include ieeefp.h if present.
7962 * split-file.h: (cmd_split_file) Changes corresponding to struct
7965 * str.h: Fix memmem prototype.
7967 * temporary.c: (save_dictionary, restore_dictionary,
7968 free_dictionary) Changes corresponding to struct dictionary
7971 * var.h: (MXD_* enums) New enum series.
7972 (struct matrix_data_proc) New struct.
7973 (struct split) Removed.
7974 (struct dictionary) Changed `splits' member from `split *' to
7976 (macro force_create_variable) New macro. Replaced lots of
7977 create_variable()/assert() calls with calls to this macro.
7979 * vars-atr.c: (discard_variables) Changed assertion.
7980 [GLOBAL_DEBUGGING] (force_create_variable) New function
7981 called by the macro of the same name.
7982 (clear_variable) Changes to delete splits from the dictionary
7983 corresponding to struct dictionary changes.
7985 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7986 corrupted variable `index' values in the dictionary passed in
7987 every time this function is called.
7989 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7990 to struct dictionary changes.
7992 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7994 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7996 * command.c: New includes.
7997 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7998 (cmd_erase) New function.
7999 [unix] (shell) New function.
8000 (run_command) New function.
8001 (cmd_host) New function.
8002 (cmd_new_file) New function.
8004 * expr-prs.c: (parse_primary) Message fix.
8006 * inpt-pgm.c: Formatting fix.
8007 (cmd_reread) Implement the FILE subcommand.
8009 * matrix-data.c: New file.
8011 * q2c.c: (dump_header) Change output commenting style.
8013 * weight.c: Comment fix.
8015 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
8017 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
8019 (buf_10x) Renamed buf_1xx, all references changed.
8020 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
8021 cases now implemented).
8022 (create_sysfile) New function.
8023 (agr_11x_func) New function.
8025 * data-in.c: (parse_numeric) Work properly if there's an
8026 explicitly coded decimal point in the data and decimal places are
8027 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
8028 <el@linux.lisse.na>.
8030 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
8031 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
8032 Eberhard W Lisse <el@linux.lisse.na>.
8034 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
8035 strerror.c. Bug reported by Alexandre Oliva
8036 <oliva@dcc.unicamp.br>.
8038 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
8039 (static var separate_case_tab) New var.
8040 (cmd_sort_cases) Cancel temporary transformations here. Free
8041 v_sort before return.
8042 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
8043 we're reading from a sort stream. Don't cancel temporary
8044 transformations. Offload internal sorting to do_internal_sort().
8045 (do_internal_sort) New function. Handles internal sorting even
8046 when SEPARATE is nonzero. Doesn't free v_sort.
8047 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
8049 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
8050 sink if SEPARATE is zero.
8051 (read_output_cases) Renamed read_sort_output(), all references
8052 changed. Now uses separate_case_tab when it exists.
8053 (write_separate) New function.
8055 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
8056 memory_sink_cases. Don't redundantly call
8057 vfm_source->destroy_source().
8058 (memory_stream_mode) After switching over, set memory_sink_cases
8061 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
8063 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
8065 (static var prev_case) New, moved out of aggregate_single_case()
8067 (static var buf64_10x, buf_10x) New.
8068 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
8069 the 000, 001, 100, and 101 cases. Free prev_case.
8070 (parse_aggregate_functions) Disallow scratch variables.
8071 (free_aggregate_functions) Only free agr_dict if non-null. Use
8072 iter->function to determine numeric/string type, not
8074 (aggregate_single_case) Don't manage prev_case. Initialize
8075 aggregate info after dumping it.
8076 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
8077 mean, stddev, weighted stddev definitions.
8078 (dump_aggregate_info) Implemented.
8079 (initialize_aggregate_info) Renamed from
8080 initialize_aggregate_functions(). Initializes dbl[2].
8081 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
8082 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
8084 * cases.c: (alloc_val) Removed.
8086 * get.c: (cmd_save_internal) Initialize new `dict' member.
8088 * sfm-write.c: (sfm_write_dictionary, write_header,
8089 write_variable, write_value_labels, write_documents) Reorganize,
8090 simplify for new parameter structure.
8091 (write_variable) Only one variable * argument now.
8093 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
8094 replaced by new `dict' member.
8096 * temporary.c: (new_dictionary) Initialize n_documents.
8098 * vars-atr.c: (dup_variable) Allocate `value's from dict into
8100 (init_variable, replace_variable) Eliminate usage of alloc_val().
8102 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
8104 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
8105 signal that AGGREGATE is to be used for forming final cases.
8106 (close_active_file) Call end_func before stopping lagging. Cancel
8107 temporary after finishing compaction.
8108 (write_case) Comment fixes. Cleaned up.
8109 (compact_case) Let AGGREGATE handle compaction when `temporary' is
8112 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
8114 * Makefile.am: (BUILT_SOURCES) Add means.c.
8115 (pspp_SOURCES) Add means.c.
8116 (EXTRA_DIST) Add means.q.
8118 * command.c: (array cmd_table[]) Add MEANS.
8120 * common.h: Esthetic fixes. Comment fixes. Test for
8121 MAX_SHORT_STRING greater than 8.
8122 (macros LOWEST, HIGHEST) New.
8124 * data-in.c, data-list.c, recode.c: Comment fixes.
8126 * means.q: New file, base version.
8128 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
8129 with LOWEST, DBL_MAX with HIGHEST.
8131 * q2c.c: (dump_vars) Add an enum to array types giving the number
8132 of values for the enum.
8134 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
8135 Replace second_lowest_value with second_lowest_flt64.
8137 * sfm-write.c: (write_variable, write_rec_7_34) Replace
8138 second_lowest_value with second_lowest_flt64.
8140 * t-test.q: Comment fix.
8142 * temporary.c: (restore_dictionary) Esthetic fix.
8144 * tokens.h: (force_match_id, force_match, force_string, force_int,
8145 force_num, force_id) Replace msg() with syntax_error().
8147 * var.h: (struct means_proc) New.
8148 (struct variable) Add mns member to `p' union.
8150 * vars-prs.c: (parse_variable, parse_dict_variable,
8151 parse_variables, parse_DATA_LIST_vars) Replace msg() with
8154 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
8156 * Makefile.am: (pspp_SOURCES) Add tab.h.
8158 * Most source files: Added a cast to unsigned char in usages of
8159 the ctype is*() functions. Replaced `end of command expected'
8160 calls to msg() with calls to syntax_error().
8162 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
8164 * lexer.c: (hex_val) Removed (was dead code).
8165 (idmatch) Parenthesize function name to avoid macro expansion.
8167 * postscript.c: Comment fixes.
8168 (ps_preopen_driver) Change default font size to 10pt.
8170 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
8172 (parse_format_spec) Change system-file format spec argument type
8173 to int32. Parse the format spec with bitwise operators.
8175 * sfmP.h: (struct sysfile_format) Removed.
8176 (struct sysfile_variable) Changed print, write members from
8177 sysfile_format to int32.
8179 * tokens.h: Esthetic fixes.
8180 [__GNUC__] (macro id_match) New macro to hopefully speed up
8181 identifier matching.
8182 (macros match_id, match_tok, match_int) Implemented in
8183 compiler-independent manner; no longer GNU C only.
8185 * vfm.h: Include time.h.
8187 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
8189 * data-list.c: (dump_fixed_table) Change tab_dim().
8191 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
8193 * error.c: Include command.h.
8195 * frequencies.g: Formatting fixes.
8197 * frequencies.q: Add tab_dim() calls. Make the total cell a
8200 * glob.c: Include command.h.
8202 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
8204 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
8205 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
8206 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
8207 the other elements (is this right?).
8208 (read_variables) Use lowest, highest members.
8209 (parse_format_spec) New arg `vv' for more stringent checking.
8210 (dump_dictionary) Byteswaps nonexplicit data.
8211 (sfm_read_case) Byteswap numeric data.
8213 * som.c: Initialize table_num to 1.
8214 (render_segments) Remember to increment y_index after each table
8217 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
8218 avl_count() on a NULL tree. No title for the second table.
8219 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
8220 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
8221 fix call to display_variables().
8222 (display_variables) Default to 4 columns, not 3. Set up headers.
8223 Column title is Variable, not Name. Fix index column.
8224 Add joint text. Add tab_dim(). Handle value labels properly.
8225 Handle DISPLAY LABELS properly. Draw boxes correctly.
8226 (describe_variable) Value labels don't need titles. Don't clear
8227 nonexistent index column.
8228 (compare_vectors_by_name) New function.
8229 (display_vectors) New function.
8231 * tab.c: (tab_height) Add assertion.
8232 (tab_null) Add debug code.
8233 (evaluate_dimensions) Add debug code.
8235 * var.h: (struct variable) get_proc data is sometimes used
8236 simultaneously with other per-procedure info, therefore it was
8237 removed from the union. All references changed.
8239 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
8241 * ascii.c: (ascii_close_page) Put title on second line of headers
8242 if there is no subtitle.
8244 * command.c: (glob var cur_proc) Move definition here, from
8246 (cmd_remark) Emit blank line before remarks.
8248 * command.h: (glob var cur_proc) Move declaration here, from
8251 * data-list.c: (dump_fixed_table) Fix messages.
8252 (dump_free_table) Call tab_nat_dim().
8254 * descript.q: (dump_z_table) Modify tab_dim() call.
8256 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8258 (dump_statistics) Don't output header.
8260 * groff-font.c: Minor format fix.
8262 * html.c: Comment fix.
8264 * list.q: (write_varname) Indent after advancing page.
8266 * output.h: Minor reordering.
8268 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8269 a reference to eol[].
8270 (struct ps_driver_ext) New member eol[].
8271 (ps_preopen_driver) Initialize eol[].
8272 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8273 defaults. Handle headers. Fix test for minimum page length.
8274 (static var option_tab[]) Add `line-ends'.
8275 (ps_option) Handle line-ends to change eol[].
8276 (postopen) Scale prop_em_width and fixed_width properly. Set the
8277 prologue title to outp_title if applicable. Replace the prologue
8278 line ends with eol[]. Call draw_headers() if headers are enabled.
8279 (text_width) New function.
8280 (out_text_plain) New function.
8281 (draw_headers) New function.
8283 * print.c: (dump_table) Call tab_nat_dim().
8285 * som.c: (som_blank_line) Only advance a line if not at the top of
8287 (som_submit) Move several informational table calls here.
8288 Increment subtable_num if SOMF_NO_TITLE not set.
8289 (output_table) Advance a line if SOMF_NO_SPACING not set.
8290 (render_columns, render_segments, render_simple) Handle spacing
8291 between tables. Handle table titles. Remove debug output.
8293 * som.h: (SOMF_*) New enum series.
8294 (struct som_table_class) New member `flags'.
8296 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8298 (display_variables) Calls tab_nat_dim().
8299 (describe_variable) Remove restriction on number of value labels.
8300 Make value labels separated by thin lines.
8302 * tab.c: (tab_create) Default `flags' to none.
8303 (tab_float) New arg `w'. All references changed.
8304 (tab_nat_dim) New function.
8305 (tab_output_text) No title or spacing.
8306 (tab_flags) New function.
8307 (tabi_flags) New function.
8308 (tabi_title) New function.
8309 (strip_height) Removed.
8310 (tabi_render) Skip title when necessary.
8311 (static var tab_tab_class) Add tabi_flags, tabi_title.
8312 (evaluate_dimensions) Disable display of column, row size.
8313 (sum_columns) Add title height to top header.
8314 (render_strip) Moved within file.
8316 * tab.h: (struct tab_table) New member `flags'.
8318 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8320 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8322 * Most source files: Add `const' attribute in all appropriate
8325 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8326 column to the variables table for use by describe_variable().
8327 (cmd_display) Disable for the present.
8328 (display_documents) Don't wrap documents.
8329 (display_variables) Table has four columns now.
8330 (describe_variable) Table has four columns now. Don't use a
8331 subtable, use joined cells instead.
8333 * tab.c: (tab_create) Don't set `join'.
8334 (tab_realloc) ct array is not made up of a_string's.
8335 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8336 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8337 (text_format) New function.
8338 (tab_title) Rewritten, uses text_format().
8339 (tab_text) Rewritten, uses text_format().
8340 (tab_joint_text) New function.
8342 (static var hit) New variable.
8343 (render_strip) New args r1, r2. Implement joined cells that fit
8345 (tabi_render) Increment hit. Pass new args to render_strip().
8346 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8347 cells. For t_naw and t_nah, ignore joined cells and null cells in
8350 * tab.h: (struct tab_join_rect) Removed.
8351 (struct tab_table) Removed `join'.
8352 (TAB_JOIN_MAIN) Removed.
8353 (struct tab_joined_cell) New struct.
8354 (TAT_NOWRAP) New enum.
8356 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8358 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8360 (ascii_postopen_driver) Fix initialization of *_spacing so that
8361 the TAL_0 bit doesn't count.
8363 * data-list.c: (dump_fixed_table) Use natural width for Format
8366 * glob.c: (rerange) Removed.
8367 (get_date) Formatting fixes. Internationalization fix.
8369 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8372 * postscript.c: (ps_postopen_driver) Replace
8373 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8375 * som.c: (som_submit) Don't eject page before every table.
8376 (output_table) Fix order of arguments on call to area().
8377 (render_columns) Fix calculation of max_len.
8379 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8380 (render_strip) New function.
8381 (strip_height) New function.
8382 (tabi_render) Rewrite as calls to render_strip().
8384 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8385 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8386 with the TAB_* and OUTP_T_* constants.
8388 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8390 * Makefile.am: Formatting fixes.
8392 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8395 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8397 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8399 * dump-sysfile.c: (glob var length) Make type off_t.
8400 (usage) Fix arguments.
8403 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8404 Now right-justification is the default so many references had to
8406 (struct outp_class) Removed line_width, all references changed.
8407 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8408 (struct outp_driver) Add elements horiz_line_width,
8409 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8412 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8414 (postopen) Initialize all the informational members of
8417 * som.c: (som_blank_line) New function, renamed from blank_line(),
8418 all references changed.
8419 (som_submit) Disables drivers whose pages can't be opened.
8420 (render_columns, render_simple, render_segments) Add debug output.
8421 (render_columns) Fix loop range.
8422 (render_simple) Don't try to render the headers, they're taken
8423 care of automatically. Advance cp_y past the table when done.
8424 (render_segments) Fix loop ranges.
8426 * tab.c: Initialize new members of tab_table.
8427 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8428 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8429 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8432 (tab_dim) New function.
8433 (tab_col_width) Removed.
8434 (tab_row_height) Removed.
8435 (tab_output_text) Call tab_dim().
8436 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8437 (tabi_area) Implemented.
8438 (tabi_cumulate) Implemented.
8439 (tabi_render) Partially implemented, but broken.
8440 (var tab_table_class) Made static.
8441 (evaluate_dimensions) New function.
8442 (sum_columns) New function.
8444 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8445 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8446 t_scr, t_srr, t_sentinel. Removed: t_nat.
8447 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8448 max_stack_height, w, h. Removed: ce, re.
8449 (macro blank_line) Removed.
8450 (glob var zero_length) Removed.
8452 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8454 * Most source files: include some of the new include files broken
8457 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8460 * aggregate.c: (glob var outfile) Make static.
8462 * command.c: (glob var pgm_state) Move here.
8464 * common.c: (glob vars endian, second_lowest_value, pgmname,
8465 finished, curdate, cur_proc, start_interactive, history_file) Move
8468 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8470 * file-handle.q: (glob vars files, inline_file) Move here.
8472 * glob.c: Lost lots of glob vars, detailed in individual file
8474 (init_glob) set_printer, set_screen were obsolete, deleted.
8475 set_cprompt has fewer spaces because pspp has fewer letters than
8478 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8479 (inp_nval) Made static.
8481 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8482 tokstr_len, toklongstr, tokint) Move here.
8484 * misc.c: Lost several vars and functions.
8486 * set.q: (all the set_* variables) Move here.
8488 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8489 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8492 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8494 * tab.h: (enum series t_*) New enums.
8495 (struct tab_table) Use arena struct tag. New members ce, re.
8497 * tokens.h: Comment fixes.
8499 * var.h: Move lots of enums and variables and functions and
8500 structures to other files. Use and declare a lot more union and
8501 struct tags. Comment fixes.
8503 * vector.c: (glob vars vec, nvec) Move here.
8505 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8506 init_blanks, last_vfm_invocation) Move here.
8508 * cases.h: New file.
8509 (struct long_vec) Move here.
8510 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8513 * command.h: New file.
8514 (STATE_* enums) Move here.
8515 (glob var pgm_state) Move here.
8517 * format.c: New file.
8518 (glob var formats) Move here.
8519 (parse_format_specifier_name, fmt_to_string,
8520 check_input_specifier, check_output_specifier,
8521 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8524 * format.h: New file. Move functions now in format.c here.
8525 (FMT_* enums) Move here.
8526 (struct fmt_desc) Move here.
8527 (FCAT_* enums) Move here.
8528 (struct fmt_spec) Move here.
8529 (glob vars formats, fmt_parse_ignore_error) Move here.
8531 * inpt-pgm.h: New file.
8532 (INP_* enums) Move here, make #defines into enums.
8533 (glob vars inp_init, inp_init_size) Move here.
8536 (glob vars v_sort, nv_sort) Move here.
8537 (sort_cases, read_sort_output) Move here.
8539 * vector.h: New file.
8540 (struct vector) Move here, add struct tag.
8541 (glob vars vec, nvec) Move here.
8542 (find_vector) Move here.
8545 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8546 reinit_blanks, init_zero, init_blanks) Move here.
8547 (struct case_stream) Move here.
8548 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8549 vfm_disk_stream, sort_stream, data_list_source,
8550 input_program_source, file_type_source, get_source, n_lag) Move
8552 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8555 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8557 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8558 (LDADD) Add libdcdflib.
8560 * ascii.c: Comment and formatting fixes. Almost every external
8561 function had an assert added, checking driver_open and page_open.
8562 (ascii_init_driver) Broken into ascii_preopen_driver,
8563 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8564 (ascii_open_page) Sets page_open.
8565 (ascii_close_page) Clears page_open.
8567 * html.c: Comment and formatting fixes. Almost every external
8568 function had an assert added, checking driver_open and page_open.
8569 (html_init_driver) Broken into html_preopen_driver,
8570 html_postopen_driver, html_close_driver. Manages driver_open.
8571 (html_open_page) Sets page_open.
8572 (html_close_page) Clears page_open.
8573 (html_submit) Disabled.
8575 * lexer.c: (parse_string) Remove debugging printf.
8577 * list.q: (determine_layout) Open a page if one is not yet open.
8579 * output.c: Comment fixes.
8580 (add_class) Set the class member of the new list element.
8581 (parse_options) Don't handle device type.
8582 (colon_tokenize) New function.
8583 (configure_driver) New four-field format with a field for device
8584 type. Now initialize driver_open, page_open, next, and prev
8585 fields. Use new colon_tokenize() function. Don't do a memory
8586 copy to replace a driver, it doesn't work; instead delete the old
8587 driver and insert a new one.
8588 (destroy_driver) Don't call som_destroy_driver(). Close the page
8589 if it's open. Find the class in the list of classes and decrement
8590 that reference count. Remove the driver from the global driver
8592 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8593 references changed. Rewritten. Don't return a driver that's not
8595 (outp_eject_page) All references to som_internal_eject_page()
8596 changed to use this. Sets cp_x to 0 as well as cp_y.
8598 * output.h: (OUTP_I_* enums) Removed.
8599 (struct som_submission_form) Removed.
8600 (struct outp_class) init_driver broken into preopen_driver,
8601 postopen_driver, and close_driver. submit changed to take a
8604 * postscript.c: Comment and formatting fixes. Almost every
8605 external function had an assert added, checking driver_open and
8607 (ps_init_driver) Broken into ps_preopen_driver,
8608 ps_postopen_driver, ps_close_driver. Manages driver_open.
8609 (ps_open_page) Sets page_open.
8610 (ps_close_page) Clears page_open.
8612 * som.c: New file, base implementation.
8614 * som.h: (struct som_table) Add struct tag.
8615 (enum SOM_COL_ACROSS) Removed.
8616 (SOM_ROWS, SOM_COLUMNS) New enums.
8617 (struct som_table_class) Add member `cumulate'. Remove `segment';
8618 change `render' arguments.
8619 (struct som_point, struct som_rect) Removed.
8620 (som_submit_table) Fixed typo, should have been som_submit.
8622 * sysfile-info: (describe_variable) Don't try to insert a
8623 subtable; just destroy it for now.
8625 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8626 references to value labels.
8628 * tab.c: (tab_destroy) New function.
8629 (tab_columns) Change argument.
8630 [0] (tab_submit) Remove dead code.
8631 (tab_title) Allocate string from the table's arena.
8632 (tab_output_text) Only free the buffer if we allocated it.
8633 (tab_submit) New function.
8634 (static vars t, d) New static vars.
8635 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8636 tabi_headers, tabi_cumulate, tabi_render) New functions.
8637 (glob var tab_table_class) New global var.
8639 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8640 encapsulate the rectangle. All references changed.
8642 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8644 * All header files updated to use struct tags in addition to
8645 typedefs for all structures. Don't use word `struct' in struct
8648 * Makefile.am: (pspp_SOURCES) Remove html.c.
8649 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8650 all references updated.
8652 * command.c: (parse_cmd) Remove call to som_check_workspace.
8653 (output_line) Update to new som.
8655 * data-in.c: (parse_numeric) A single dot is not an error; it is
8656 the system-missing value.
8658 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8661 * data-out.c: Added `const' as appropriate to many prototypes.
8662 (convert_E, convert_F, convert_CCx) Take double argument instead
8663 of value * argument.
8664 (convert_format_to_string) Call changed functions appropriately.
8665 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8666 make a local copy of the value.
8668 * descript.q: Remove custom_variables() prototype now provided by
8670 (custom_variables) Don't increment sbc_variables, the caller does
8672 (dump_z_table, display) Update to new som.
8674 * error.c: (vmsg) Add const to prototype. Remove code to handle
8675 `too many errors' condition.
8676 (check_error_count) New function.
8677 (msg) Add const to prototype.
8679 * filename.c: (open_file) Rewrite for elegance.
8681 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8682 (dump_full, dump_condensed, dump_statistics) Update for new som.
8684 * list.q: Don't include somP.h. Change all references to
8685 som_driver_ext to refer to the new members of som_driver. Change
8686 som_internal_eject_page() references to outp_eject_page().
8688 * main.c: (parse) Rewrite for elegance. Add call to
8689 check_error_count().
8691 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8692 Rewrite or revise for new outp_driver_class_list structure.
8693 (outp_iterate_enabled_drivers) Fix comparison between disabled
8694 devices and current device type.
8695 (outp_eject_page) New function.
8697 * output.h: Comment fixes.
8698 (struct outp_driver) New members driver_open, page_open, cp_x,
8699 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8701 (struct outp_driver_class_list) New struct.
8702 (outp_class_list) Changed to type outp_driver_class_list; all
8705 * print.c: (dump_table, print_trns_proc) Updated for new som.
8707 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8708 prototypes for custom subcommands.
8709 (dump_subcommand) Always include the `else'.
8710 (dump_parser) Fix comments in output code.
8712 * set.q: Reordered functions.
8714 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8716 * som.h: Rewritten from scratch.
8718 * str.h: Remove dead code.
8720 * tab.c, tab.h: New files, base implementation.
8722 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8725 * t-test.q: New code from John Williams
8726 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8727 Many many new static vars and defines.
8728 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8729 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8730 (struct value_list) New struct.
8731 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8732 t_crt, t_sig, print_t_groups) New functions.
8733 (cmd_t_test) Implemented.
8735 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8738 * vfm.c: (dump_splits) Update to new som.
8740 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8742 * Makefile.am: (fiasco_SOURCES) Add html.c.
8744 * aggregate.c: Base source.
8746 * ascii.c: (postopen, preclose) Reformat.
8748 * data-out.c, expr-evl.c: Comment fixes.
8750 * filename.c: (open_file) When opening a file for writing, use
8751 line buffering instead of full buffering for better interactive
8752 performance. Suggested by Valerio Aimale
8753 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8754 names `stdin', `stdout', `stderr'.
8756 * groff-font.c: Comment fixes.
8758 * html.c: New file; base version.
8760 * list.q: (write_all_headers, clean_up, determine_layout,
8761 list_cases) Ignore `special' devices for now. Needs to be fixed
8764 * output.c: (outp_init) Add html driver to list; reverse list
8767 * output.h: (struct outp_class_struct) New members `special',
8768 `submit'; comment fixes. All references changed.
8770 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8771 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8773 (postopen) Comment fix.
8774 (preclose) Comment fixes, formatting fixes. Change x->file.file
8775 references to more proper f->file.
8777 * som-high.c: (som_submit_table) Special classes use their own
8780 * som.h: Comment fixes.
8782 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8785 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8787 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8789 * aggregate.c: Still working on this.
8791 * command.c: (cmd_table[]) Add AGGREGATE back in.
8792 (split_words) Make '-' a legal word separator as well as ' '.
8794 * main.c: Comment fixes.
8796 * q2c.c: (dump_parser) Don't require the procedure's full name to
8797 be present, in the generated source.
8799 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8800 multiply specified and let it be default; let MISSING, CRITERIA,
8801 FORMAT be multiply specified.
8802 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8803 (custom_groups) Fix defaults.
8804 (custom_pairs) Check whether this is a PAIRS subcommand before
8805 attempting to parse. Better garbage collection. Proper storage
8807 [DEBUGGING] (debug_print) New function.
8809 * temporary.c: Comment fixes.
8810 (copy_variable) Don't copy variable name and index.
8811 (save_dictionary) Copy variable name and index by hand.
8813 * vars-atr.c: Comment fixes.
8814 (create_variable) New dictionary argument. All references
8816 (common_init_stuff) New dictionary argument. All references
8818 (init_variable) New dictionary argument. All references changed.
8819 (dup_variable) New function.
8821 * vars-prs.c: (parse_variables) If there are any errors, we always
8822 return 0. Previously, it was possible for some types of errors to
8825 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8827 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8830 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8832 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8835 * q2c.c: Comment fixes.
8836 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8838 * t-test.q: (cmd_list) Rename cmd_t_test.
8840 * temporary.c: (new_dictionary) Don't declare as static.
8842 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8844 * aggregate.c: Changes, still not finished.
8846 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8848 * q2c.c: Comment fixes. Now its output is internationalized.
8849 (get_token) Fix parsing of escapes within literal strings.
8850 (main) Fix bad #line directives in output.
8852 * t-test.q: Base implementation.
8854 * temporary.c: (new_dictionary) New function.
8855 (restore_dictionary) [__CHECKER__] Change fill character to *
8858 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8860 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8862 * aggregate.c: Changes, still not finished.
8864 * descript.q, list.q: Comment fixes.
8866 * q2c.c: Almost completely rewritten.
8868 * t-test.q: New file, not complete.
8870 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8872 * aggregate.c: Changes, still not finished.
8874 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8877 * temporary.c: (cancel_temporary) New function.
8879 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8880 of doing it by hand.
8882 * vfm.c: (close_active_file) After restoring a TEMPORARY
8883 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8885 (SPLIT_FILE_procfunc) Comment fix.
8887 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8889 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8891 * aggregate.c: New file, not finished yet.
8893 * command.c: (cmd_table) Add AGGREGATE.
8895 * common.h: (pgm_state) Move declaration to var.h.
8897 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8899 (parse_string) Message fix.
8901 * recode.c: Comment fix.
8903 * sfm-read.c: (read_variables) Code esthetic fixes.
8904 (write_header) Default date is `Jan', not `JAN'.
8906 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8908 * sort.c: (cmd_sort_cases) Farm the work out to new function
8909 parse_sort_variables().
8910 (parse_sort_variables) New function.
8911 (sort_cases) New function. Cancels temporary transformations,
8912 which sorting didn't do previously.
8913 (cmd_sort_cases) Better garbage collection on error. Uses
8915 (write_initial_runs, merge_once) Improved code esthetics.
8916 (sort_stream_read) Reduced to one call to read_output_cases().
8917 (read_output_cases) New function.
8919 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8920 variable labels to 120 characters.
8922 * var.h: Comment fixes.
8923 (glob var pgm_state) From common.h.
8925 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8927 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8928 options. Set *names to NULL on error.
8930 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8932 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8934 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8935 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8937 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8939 * vfm.c: (page_to_disk) Added missing local variables.
8941 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8943 * get.c: Comment fix.
8945 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8946 source is anything other than a disk stream, not just if it's in a
8947 memory stream. Call page_to_disk() before external sort.
8948 (allocate_cases) Message fix.
8950 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8952 (page_to_disk) New function.
8954 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8956 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8958 * common.h: (macro strerror) Remove. From Alexandre Oliva
8959 <oliva@dcc.unicamp.br>.
8961 * get.c: (dict_delete_run) The number of variables to delete is
8962 not necessarily the number of variables that need to be shifted
8964 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8965 too many variables to be deleted.
8967 * postscript.c: Comment fix.
8969 * q2c.c: Include strerror.c. From Alexandre Oliva
8970 <oliva@dcc.unicamp.br>.
8972 * set.q: #undef ON and OFF. From Alexandre Oliva
8973 <oliva@dcc.unicamp.br>.
8975 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8976 early, otherwise errors cause a bad free().
8978 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8979 Oliva <oliva@dcc.unicamp.br>.
8981 * temporary.c: (save_dictionary) Don't allocate memory if
8984 * vfm.c: (memory_stream_write) Message fix.
8986 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8988 * command.c: (static var cmd_table[]) Define REPEATING DATA
8991 * common.h: Added support for broken systems that are missing
8992 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8994 * Many source files: Replace syntax error messages via msg() with
8995 call to syntax_error().
8997 * data-list.c: (dump_fixed_table) Add support for dumping table
8998 for REPEATING DATA as well as DATA LIST FIXED.
8999 (cmd_repeating_data) Allows and requires `/' between subcommands.
9000 Does proper thing with allowing rpd.starts_end to stay 0. Allows
9001 CONTINUED specifications to be omitted. Forces CONTINUED to be
9002 specified if ID is. Calculates starts_end, cont_end from logical
9003 record length as reported by fhp. Calls dump_fixed_table() if
9004 requested. Fixed length of record copied by memcpy.
9005 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
9007 (realize_value) Returns sensible value for out-of-range variable
9009 (rpd_parse_record) New argument `ofs'. Fixed confusion between
9010 length of occurrences and length of line. Added warning for
9011 fields that exceed the line length. Fixed infinite loop.
9012 (read_one_set_of_repetitions) Numerous minor changes for more
9013 complete SPSS compliance. Message fixes.
9015 * dfm.c: (dfm_close) If the file being closed is the inline file,
9016 read all the remaining data before closing it.
9017 (dfm_get_record) Don't close the file on lossage, as either it
9018 has been closed already or it doesn't belong to us.
9020 * error.c: (puts_stdout) New function.
9021 (vmsg) Use puts_stdout instead of puts.
9023 * file-handle.q: (fh_record_width) New function.
9025 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
9028 (input_program_source_read) Made an old kluge an approved method.
9030 * lexer.c: (syntax_error) New function.
9032 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
9035 * output.c: (oupt_get_paper_size) Message fix.
9037 * q2c.c: Numerous fixes to formatting of generated code made to
9038 conform to GNU coding standards. Uses syntax_error() in generated
9039 code. Other miscellaneous generated message fixes. Added support
9040 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
9041 RAND_MAX, and/or strerror().
9043 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
9045 * data-in.c: Comment fixes.
9047 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
9048 (find_variable_input_spec) New function.
9049 (cmd_repeating_data) Initializes id_spec.
9050 (rpd_parse_record) Implemented.
9051 (read_one_set_of_repetitions) Returns -3 by default in order to
9052 kluge out some potential bugs.
9054 * data-out.c: Comment fixes.
9056 * file-type.c: (internal_cmd_record_type) Message fix.
9058 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
9059 for handling -3 return value.
9061 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
9063 * data-list.c: Comment fixes.
9064 (struct dls_var_spec) Reordered members.
9065 (read_from_data_list_fixed) Restructured.
9066 (struct repeating_data_trns) Reordered members. Renamed `starts'
9067 as `starts_beg', `ends' as `starts_end'.
9068 (cmd_repeating_data) Calculates length of repeated data if
9069 necessary and possible.
9070 (parse_num_or_var) Don't allow string variables.
9071 (realize_value) New function.
9072 (rpd_msg) New function.
9073 (rpd_parse_record) New function. Currently stubbed out.
9074 (read_one_set_of_repetitions) Implemented.
9076 * inpt-pgm.c: (input_program_source_read) Comment fix.
9078 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
9080 * command.c: (cmd_end_repeat_p) Removed.
9081 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
9082 (parse_cmd_name) Removed.
9084 * data-list.c: Comment fixes.
9085 (data_list_pgm) Removed `eof' member.
9086 (static var first) New var.
9087 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
9088 FILE TYPE file inside FILE TYPE structures.
9089 (append_var_spec) Appends to *first, not dls.spec.
9090 (parse_fixed) Message fixes.
9091 (struct rpd_num_or_var) New.
9092 (struct repeating_data_trns) New.
9093 (static var rpd) New.
9094 (cmd_repeating_data) New function.
9095 (parse_num_or_var) New function.
9096 (parse_repeating_data) New function.
9097 (read_one_set_of_repetitions) New function.
9099 * file-type.c: (cmd_file_type) Message fixes. Always
9100 default_handle to FILE TYPE file handle.
9101 (internal_cmd_record_type) Message fixes.
9103 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
9105 * repeat.c: Comment fix. Disable debugging.
9107 * temporary.c: (restore_dictionary) Sets splits to NULL and
9108 n_splits to 0 before destroying the variables because now doing
9109 this tries to remove split variables.
9111 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
9112 destroying the dictionary.
9113 (clear_variable) Removes a variable from splits after destroying
9116 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
9118 * cmdline.c: (set_compat) Removed.
9119 (pick_compat) Removed.
9120 (parse_command_line) Removed -c option.
9121 (pre_syntax_message) Removed -c option.
9122 (usage) Remove compatibility code.
9124 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
9125 (glob var compat) Removed.
9127 * compute.c: (type_check) Fixed messages about type mismatches.
9129 * data-list.c: (cmd_data_list) Removed compatibility code.
9130 (fixed_parse_compatible) Calls convert_negative_to_dash().
9131 Fixed bug where it only set the variable in fx.spec if it created
9132 the variable itself.
9133 (dump_fmt_list) Spelling fix.
9134 (cut_field) Removed compatibility code.
9136 * dfm.c: (cmd_begin_data) Don't require a command terminator on
9139 * expr-evl.c: (evaluate_expression) Implement LAG.
9141 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
9142 (parse_neg) Calls convert_negative_to_dash().
9143 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
9146 * expr.h: (struct expression_struct) Removed member max_lag.
9148 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
9149 (internal_cmd_record_type) Removed special handling to produce
9150 negative numbers from dash tokens.
9152 * getline.c: (static var DO_REPEAT_level) New var.
9153 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
9154 (handle_line_buffer) Copies the line into getl_buf; doesn't call
9155 copy_with_DO_REPEAT_substitutions().
9156 (getl_read_line) Maintains value of getl_mode. Calls
9157 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
9159 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
9161 * getline.h: (getl_mode) New glob var.
9163 * glob.c: Comment fixes.
9164 (init_glob) Restructured. Sets set_seed.
9165 (init_compat_dependent) Removed. All references removed.
9166 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
9167 (__htonl, __htons) Removed. (What were these for?)
9169 * lexer.c: (static var tbl) Dash set to class CNUM.
9170 (make_hexit) New function from data-out.c.
9171 (get_token_representation) Rewritten.
9172 (convert_negative_to_dash) New function.
9173 (lex_init_compat_dependent) Removed.
9174 (yylex) A dash is parsed as part of a number if it is followed by
9175 a digit. The ASCII representation of a number is copied to
9176 tokstr. String parsing farmed out to parse_string(). Comment
9178 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
9180 (preprocess_line) Line processing depends on interactive/batch
9181 mode, not on compatibility mode. Removed PC+ compatibility code.
9183 * loop.c: (loop_3_trns_proc) Comment fix.
9185 * main.c: Remove dead code.
9186 (main) Remove call to init_compat_dependent().
9188 * misc.c: (convert_fmt_ItoO) Make E format conversion more
9191 * print.c: (parse_string_argument) Calls
9192 convert_negative_to_dash().
9193 (fixed_parse_compatible) Calls convert_negative_to_dash().
9195 * repeat.c: (RPT_* defines) Removed.
9196 (struct rpt_numeric) Removed.
9197 (struct repeat_entry) New member type, changed `replacement' from
9199 (clean_up) Deallocation adapted to new repeat_entry.
9200 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
9201 usage. Creates vars for `type' of 1.
9202 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
9203 (store_numeric) Rewritten, new interface.
9204 (parse_numbers) Rewritten.
9205 (parse_strings) Rewritten.
9206 (find_DO_REPEAT_substitution) New function.
9207 (perform_DO_REPEAT_substitutions) New function.
9208 (copy_with_DO_REPEAT_substitutions) Removed.
9209 (debug_print) Rewritten.
9211 * set.q: Comment fix.
9212 (custom_results) Removed compatibility code.
9213 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
9216 * sysfile-info.c: (cmd_display) Removed compatibility code.
9218 * tokens.h: Comment fixes.
9219 (token types enum) Removed `toktype' typedef name for this int
9220 type. Removed SUBST. Restructured.
9222 * vars-atr.c: (discard_variables) Sets n_lag to 0.
9224 * vars-prs.c: Comment fix.
9226 * vfm.c: Comment fixes.
9227 (glob var n_lag) New var.
9228 (static vars lag_count, lag_head, lag_queue) New vars.
9229 (procedure) Removed argument nlag.
9230 (setup_lag) New function.
9231 (close_active_file) Discards lagging state.
9232 (lag_case) New function.
9233 (lagged_case) New function.
9234 (write_case) Lags a case if lagging.
9236 * weight.c: (cmd_weight) Removed compatibility code.
9238 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
9240 * getline.h: (struct getl_script) New members loop_index, macros.
9242 * getline.c: (getl_add_file) Sets first_line field to NULL.
9243 (getl_add_DO_REPEAT_file) New function.
9244 (handle_line_buffer) When the current line's length is negative,
9245 set the filename and line number. Increment line number after
9246 reading line. Pass the line to
9247 copy_with_DO_REPEAT_substitutions() for processing.
9248 (getl_close_file) Free DO REPEAT lines before freeing the
9249 filename, and just set the filename to NULL when doing this,
9250 because otherwise the filename gets freed twice.
9252 * glob.c: (glob var queuing) Removed. All references removed.
9254 * lexer.c: Comment fixes.
9255 (get_token_representation) New function.
9257 * repeat.c: Comment fixes.
9258 (struct repeat_entry) Replaced type and v union members with a
9260 (append_record) New function.
9261 (internal_cmd_do_repeat) Started reforming it for the new
9262 repeat_entry struct. Properly records filename changes in the
9263 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9264 strncasecmp() result usage. Uses append_record() to simplify.
9265 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9268 (copy_with_DO_REPEAT_substitutions) Started coding.
9270 [DEBUGGING] (debug_print_lines) New function.
9272 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9274 * tokens.h: (macro is_id1, is_idn) New macros.
9276 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9278 * cmdline.c: (static var pre_syntax_message) Changed `win'
9279 compatibility mode to `wnd'.
9281 * data-list.c: (fixed_parse_spss) Renamed
9282 fixed_parse_compatible().
9284 * glob.c: (init_glob) Excise unused code for
9285 program_invocation_short_name.
9287 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9290 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9292 * set.q: `win' compatibility renamed `wnd'.
9294 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9296 * filename.c: [__WIN32__] Change the included Windows header files
9298 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9299 second character is absolute.
9300 (dirname) Fix logic error. Don't printf() the results.
9301 (prepend_dir) Don't printf() the results.
9303 * getline.c: (handle_line_buffer) New function.
9304 (getl_read_line) Reads line with handle_line_buffer() when
9306 (getl_close_file) Discard line buffer data.
9308 * getline.h: Comment fixes.
9309 (struct getl_line_list) New struct.
9310 (getl_script_struct) Added line buffer members. These are hooks
9311 for use by DO REPEAT to allow it to insert virtual source code
9314 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9315 Override Borland C++ stupidity that claims Windows has a console
9318 * repeat.c: This is in the process of being restructured from
9319 using a token-buffering approach to the DO REPEAT facility to
9320 using the more flexible approach of a line-buffering approach in
9321 conjunction with the getline module. Comment fixes.
9322 (struct tok_struct) Removed.
9323 (static vars queue_index, queue_head, queue) Removed.
9324 (static vars line_buf_head, line_buf_tail) New vars.
9325 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9327 (pull_queue, destroy_queue) Removed.
9328 [DEBUGGING] (debug_print_tokens) Removed.
9330 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9332 * file-handle.q: (prepend_current_directory) New function.
9333 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9334 current directory before normalizing filename.
9336 * filename.c: (gnu_getcwd) New function.
9337 (absolute_filename_p) New function.
9338 (search_path) New argument, PREPEND. All references changed to
9339 pass NULL except those explicitly mentioned. Uses
9340 absolute_filename_p(). Prepends PREPEND before trying the
9342 (dirname, prepend_dir) New functions.
9344 * getline.c: (getl_get_current_directory) New function.
9345 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9348 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9350 * In several source files, the term `script' was replaced with
9351 `syntax file' inside error messages. Usage of the term `script'
9352 in the sense of a syntax file is now deprecated.
9354 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9357 * dump-sysfile.c: (usage) Update message.
9359 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9361 * getline.h: (glob var getl_include_path) Declare extern.
9363 * list.q: Define EXTERN as extern before #including somP.h.
9365 * var.h: Remove declaration of `disptype' variable.
9367 * vfm.c: (close_active_file) After switching the data sink to a
9368 data source, set vfm_sink to NULL, because it doesn't exist any
9371 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9373 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9374 _matherrl() to ignore all math errors.
9376 * sfm-read.c: (read_value_labels) When reading the labels from
9377 disk, read the little parts separately instead of as a struct;
9378 this avoids alignment problems.
9380 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9381 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9382 (write_header) Allocates and initializes elem_type.
9383 (sfm_write_case) Uses elem_type to determine how to handle each
9385 (sfm_close) Frees elem_type.
9387 * sfmP.h: Comment fix.
9388 [__BORLANDC__] Uses #pragma -a to adjust structure member
9391 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9393 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9395 * common.c: Fix typo.
9397 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9398 sense of the condition.
9400 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9401 line-continuation backslash.
9403 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9405 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9406 non-constant expression as an argument to sizeof.
9408 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9409 undefine gettext macro because that's a conio function.
9411 * hash.h: (hsh_prime_tab declaration) Remove.
9413 * list.q: (write_fallback_headers) Move `leader' allocation out of
9414 main loop. Change to local_alloc() allocation.
9416 * output.h: Formatting fixes. Put __attribute__ in right place on
9417 function prototypes.
9419 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9420 incorrect `SECOND_LOWEST_VALUE' references to proper
9421 `second_lowest_value'.
9423 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9424 value. This way 2 out of 3 of the som files define the vars
9425 extern, the correct way, that actually works under BC++.
9426 (som_set_float) Don't use nonconstant initializers for a struct.
9428 * som-high.c: Add the standard alloca() header.
9429 (replicate_table) Add prototype.
9431 Merged DISPLAY routine.
9432 * sysfile-info.c: (AS_*) New enum series.
9433 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9435 (cmd_display, display_macros, display_documents,
9436 display_variables) Stolen from defunct display.c.
9437 (describe_variable) New function.
9439 * temporary.c: [0] (display_tree) New debug function.
9440 (copy_variable) Performs shallow copy of value labels instead of
9441 deep copy; i.e., just copys the AVL tree and increments the
9444 * val-labs.c: Comment fixes.
9445 (do_value_labels) Optionally skip leading forward slash.
9446 (get_label) Creates only a single value label instead of many
9447 copies of one, and sets the reference count.
9449 * display.c: Removed.
9451 * dump-sysfile.c: New file, not yet complete.
9453 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9455 For lots of source files I added more verbose_msg's. These aren't
9456 listed below as they have tested as being benign. In some cases
9457 these replaced debug_printf() calls.
9459 * output.c: (outp_read_devices) Message fix.
9461 * postscript.c: (output_encodings) Message fix. Reports errors on
9463 (postopen) Message fix.
9465 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9467 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9469 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9472 * main.c: Remove <malloc.h> #include.
9474 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9475 instead of trying to just set the missing[] itself, which is a
9478 * sfm-read.c: (read_variables) Same.
9480 * str.h: Add memmem() prototype.
9482 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9484 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9486 * Makefile.am: (q2c) Don't include any libraries in the link.
9488 * dfm.c: (force_line_buffer_extension) New macro.
9489 (count_tabs) New function.
9490 (tabs_To_spaces) New function.
9491 (read_record) Calls tabs_to_spaces() on the line being processed.
9493 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9494 have to be compiled twice (once for CC, once for LOCAL_CC).
9496 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9498 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9499 (LDADD) Add @INTLLIBS@.
9500 (q2c) Add LIBS, @INTLLIBS@ to link step.
9502 * inpt-pgm.c: Turn off debugging.
9504 * postscript.c: (postopen) Format fix. local_free() blocks
9505 returned by local_alloc(); don't free() them.
9507 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9509 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9512 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9513 LEN arg, not simply the full string length.
9515 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9516 directories before generic temp file directories.
9518 * vfm.c: Disable debugging.
9520 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9522 * get.c: Comment fix.
9523 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9525 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9527 * expr-prs.c: (debug_print_postfix) Conditionally included on
9528 GLOBAL_DEBUGGING. Removed out_header() reference.
9530 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9532 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9534 * ascii.c: Removed obsolete ascii_close_page() prototype.
9536 * command.c: (output_line) Comment fix.
9538 * data-in.c: Formatting fix.
9539 (parse_string_as_format) Now the `fc' argument is used only for
9540 the purpose of error messages; it is not an index into the string
9541 passed. All references changed.
9543 * data-list.c: Comment fix.
9544 (cut_field) Comment fix. Now returns the column number of the
9545 position of the field cut out on success.
9546 (parse_field) Added `column' argument. Puts the column numbers in
9548 (read_from_data_list_free, read_from_data_list_list) Record the
9549 column number returned by cut_field(), pass it to parse_field().
9551 * dfm.c: Comment fix.
9553 * do-ifP.h: Comment fix.
9555 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9556 the SYSMIS function.
9558 * expr.h, exprP.h: Comment fix.
9560 * glob.c: (init_glob) Only calls setlocale() and family if
9563 * hash.h: Comment fix.
9565 * include.c: Comment fix.
9567 * output.c: Comment fix.
9569 * postscript.c: (ps_line_intersection) Simplified assertion.
9571 * repeat.c: Comment fix.
9573 * vars-atr.c: Comment fix.
9575 * vars-prs.c: Comment fix.
9577 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9578 behavior with usage of postincrement.
9579 (memory_stream_read) Discards cases as it goes.
9581 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9583 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9586 * Most source files: Includes debug-print.h, related comment
9589 * cases.c: (alloc_val) Removed complex allocation code. Merely
9590 increments default_dict.nval and returns the former value.
9591 (envector, devector) Removed references to lv member of struct
9594 * common.h: (macro VME) Replaced complex definition with simple
9597 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9598 read_active_file and cancel_input_pgm.
9599 (read_from_data_list, cancel_data_list) Removed.
9600 (data_list_source_read, data_list_source_destroy_source) New
9602 (glob var data_list_source) New var.
9604 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9605 (cmd_begin_data) Improved criteria for an input program accessing
9606 the inline file. Still not perfect.
9608 * do-if.c: (do_if_trns_proc) Simplified debug output.
9610 * expr-prs.c: Comment fixes.
9611 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9613 * file-handle.q: (fh_close_handle) Simplified debug output.
9615 * file-type.c: Comment fixes.
9616 (cmd_file_type) Sets vfm_source instead of read_active_file and
9618 (cmd_end_file_type) On failure, discards variables in place of
9619 just canceling the input program.
9620 (read_from_file_type) Renamed file_type_source_read.
9621 (cancel_file_type) Renamed file_type_source_destroy_source.
9622 (glob var file_type_source) New var.
9624 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9625 (cmd_get) Initializes options to GTSV_NONE before passing to
9626 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9627 instead of read_active_file and cancel_input_pgm.
9628 (cmd_save_internal) Initializes options before passing to
9629 trim_dictionary(). Local var `nval' removed.
9630 (dict_delete_run) Comment fixes.
9631 (trim_dictionary) Comment fixes. Disallows scratch variables if
9632 GTSV_OPT_SAVE set in options.
9633 (read_from_get) Renamed get_source_read.
9634 (cancel_get) Renamed get_source_destroy_source.
9635 (glob var get_source) New var.
9637 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9638 read_active_file and cancel_input_pgm.
9639 (read_from_input_program) Renamed input_program_source_read.
9640 Simplified debug output.
9641 (cancel_input_program) Renamed
9642 input_program_source_destroy_source.
9643 (glob var input_program_source) New var.
9645 * loop.c: (loop_1_trns_proc) Simplified debug output.
9647 * main.c: (dump_token) Made eof output more explicit.
9649 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9652 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9653 code for always-memory or always-disk cases. malloc's case-list
9654 based on vfm_source_info.ncases. Explicit support for
9655 memory_stream via memory_source_cases.
9656 (do_external_sort) Sets vfm_source instead of read_active_file and
9658 (allocate_file_handles) The temporary directory permissions are
9659 set to 0700 instead of 0777.
9660 (allocate_cases) Formatting fixes. Simplified debug output.
9661 (output_record) Compacts the case if necessary before writing it
9663 (close_handle, open_handle_w) Simplified debug output.
9664 (write_initial_runs) Destroys vfm_sink, then sets it to
9665 sort_stream. Writes records to memory based on
9666 vfm_sink_info.case_size.
9667 (write_to_sort_cases) Renamed sort_stream_write().
9668 (merge) Simplified error handling. Simplified debug output.
9670 (read_from_external_sort) Renamed sort_stream_read().
9671 Reads records based on vfm_source_info.case_size.
9672 (sort_stream_write) Writes records to memory based on
9673 vfm_sink_info.case_size.
9674 (sort_stream_mode) New function.
9675 (glob var sort_stream) New variable.
9677 * temporary.c: (cmd_temporary) Simplified debug output.
9678 (copy_variable) Removed references to `lv'.
9680 * title.c: (get_title) Simplified debug output.
9682 * var.h: Comment fixes.
9683 (struct get_proc) Removed member `lv'.
9684 (struct variable) Removed member `lv'. Comment fixes.
9685 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9687 (struct case_stream) New.
9689 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9690 read_active_file references to use vfm_source.
9691 (init_variable, replace_variable) Removed references to `lv'.
9693 * vfm.c: Comment fixes.
9694 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9696 (static var queue, qh, qt, n_lag) Removed. All references
9698 (glob var compaction_necessary, compaction_nval, compaction_case,
9699 paging) New variables.
9700 (record_case) Removed.
9701 (procedure) Comment fixes. Calls vfm_source->read() instead of
9704 (prepare_for_writing, arrange_compaction, make_temp_case,
9705 vector_initialization, setup_filter) New function.
9706 (open_active_file) Most of the code moved into the abovementioned
9707 new functions. Now sets temp_dict to &default_dict if there is no
9708 temporary dictionary, for convenience. New debug output.
9709 (close_active_file) Deals with changing the sink to the source.
9710 Calls finish_compaction(). Frees compaction_case. Mostly
9712 (glob vars disk_source_file, disk_sink_file) New vars.
9713 (destroy_active_file, read_from_memory) Removed.
9714 (disk_stream_init, disk_stream_read, disk_stream_write,
9715 disk_stream_mode, disk_stream_destroy_source,
9716 disk_stream_destroy_sink) New functions.
9717 (glob var vfm_disk_stream) New var.
9718 (glob vars memory_source_cases, memory_sink_cases,
9719 memory_sink_iter, memory_sink_max_cases) New vars.
9720 (memory_stream_init, memory_stream_read, memory_stream_write,
9721 memory_stream_mode, memory_stream_destroy_source,
9722 memory_stream_destroy_sink) New functions.
9723 (glob var vfm_memory_stream) New var.
9724 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9725 named `more_cases'. Simplified debug output. Otherwise mostly
9727 (record_case) Moved into the stream drivers. Removed.
9728 (transform) Removed (was dead code).
9729 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9730 common case that the splits don't change, we don't need to copy
9731 the case into prev_case again--pointless.
9732 (compact_case) New function.
9733 (finish_compaction) New function.
9735 * vfmP.h: Comment fixes.
9736 (DEV_* enum series) Removed.
9737 (struct storage) Renamed `stream_info'. Removed variant record.
9738 Removed `device' member.
9740 * debug-print.h: New file.
9742 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9744 * autorecode.c: Turned off debugging.
9746 * data-list.c: (destroy_dls) Closes the associated file handle.
9748 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9749 parse_variables() options.
9751 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9753 * display.c: (display_variables) Really fixed null cell bug.
9755 * file-handle.q: (fh_close_handle) Changed debugging message.
9757 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9758 parse_variables() options.
9760 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9761 (cmd_list) Fails if no variables specified.
9762 (determine_layout) Writes blank lines manually.
9764 * loop.c: (loop_1_trns_proc) Made debugging code only print
9765 messages if debugging.
9767 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9768 parse_variables() arguments.
9769 (main) Parses optional parenthesized options to varlist
9770 subcommands into sbc->message.
9772 * sfm-read.c: Format fix.
9774 * var.h: (FV_*) New enum series.
9775 (PV_*) New enum PV_NO_SCRATCH.
9777 * vars-prs.c: (find_var) Removed.
9778 (fill_all_vars) Takes FV_* enum instead of boolean third
9779 argument. Rewritten to deal with scratch as well as system
9781 (parse_variables) Error message on scratch variable if
9784 * vfm.c: (static var virt_begin_func) New var.
9785 (procedure) Sets up virt_begin_func.
9786 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9787 after dump_splits(). For succeeding groups changes, calls
9788 virt_begin_func() instead of begin_func().
9790 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9792 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9795 * dfm.c: Added some debugging messages, disabled by default.
9796 (open_file_r) Fixed error message.
9797 (read_record) On eof on inline_file, instead of calling
9798 fh_close_handle(), simply jump to eof label like a normal file.
9801 * display.c: Thin lines between rows for certain kinds of
9802 listing. Fixed `null cell' bug.
9804 * error.c: (failure) Flush stdout, stderr before failing.
9806 * file-handle.q: (fh_close_handle) Added debugging message.
9808 * frequencies.q: (dump_full) Bottom line extends across entire
9809 table width. Changed title formatting.
9810 (dump_condensed) Changed title formatting.
9811 (dump_statistics) Fixed title formatting.
9813 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9814 Sets default value of set_format.
9816 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9817 Passes write_all_headers() to procedure() as pre-group func.
9818 (write_all_headers) New function.
9819 (determine_layout) Removed calls to write_header().
9820 Calls blank_line() before and after write_fallback_headers().
9822 * recode.c: (recode_trns_free) Only attempts to free head->map if
9825 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9826 file variable names but gives a warning. Sets `left' based on
9827 first character being/not being `#'. On lossage frees dict->var.
9829 * som-high.c: (som_draw_title) Simplified title formatting.
9831 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9833 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9835 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9836 beginning. Frees v_src, v_dest on successful exit. Frees
9837 h_trans[*], h_trans on lossage.
9838 (recode) Frees h_trans[*], h_trans.
9840 * dfm.c: (dfm_close) Formatting change.
9841 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9842 longer allocates its own in inline_file.
9843 (open_file_r) Passes the local dfm_fhuser_ext to
9845 (open_file_w) Message fix.
9846 (read_record) Buffer reallocation strategy changed. Frees
9847 ext->line even in inline_file to prevent leaks.
9848 (dfm_put_record) Fixed bug where `ext' was cached before the file
9849 was opened and thus it would be NULL when the file really was
9851 (cmd_begin_data) Sets up inline_file basics itself, then calls
9852 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9854 * list.q: (write_line) Formatting fix.
9855 (clean_up) Minor strategy change. Sets proportional font after
9857 (determine_layout) Sets fixed font before writing regular headers,
9858 or after writing fallback headers.
9860 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9861 and KEEP vars after using them.
9863 * postscript.c: (ps_init_driver) Frees x->family.
9864 (postopen) When loading fonts, free the temporary font name buffer
9866 (ps_text_set_font_by_position) Free temporary font name buffer
9868 (text) Fixed code that calculated `lig' so that `lig' always gets
9869 initialized. Formatting fix.
9871 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9873 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9874 cells, not xmalloc(), so that the cells will get destroyed
9877 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9880 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9882 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9885 * dfm.c: Comment fix.
9887 * list.q: Comment fixes. Include somP.h. Removed static vars
9888 table, n_columns, n_rows, part. New struct list_ext. New static
9890 (n_lines_remaining, n_chars_width, write_line) New functions.
9891 (cmd_list, list_cases) Rewritten.
9892 (begin_row, end_row, flush_table) Removed.
9893 (write_header, clean_up, write_varname, write_fallback_headers,
9894 determine_layout) New functions.
9896 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9898 * output.h: Comment fix.
9900 * postscript.c: Comment fix.
9901 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9902 added font_size. All references changed.
9903 (ps_init_driver) Initializes font_size. Simplified space checking
9905 (static var option_tab[]) Removed prop-size, fixed-size; added
9907 (ps_option) Handles font_size.
9909 * som-high.c: Moved prototypes into somP.h.
9910 (som_init_driver) New function.
9911 (som_submit_table) Moved some code into new function
9913 (build_target) Moved some code into new function
9914 som_internal_eject_page().
9915 (som_eject_page) Uses som_internal_eject_page().
9916 (som_internal_eject_page) New function.
9918 * som-low.c: Moved prototypes into somP.h.
9920 * som.h: Formatting fixes.
9922 * somP.h: (struct som_driver_ext) Removed em_width;
9923 added prop_em_width, fixed_width.
9925 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9927 * Makefile.am: Added `localedir' definition. Added
9928 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9930 * ascii.c: (macro draw_line) Fixed capitalization.
9932 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9933 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9934 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9935 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9936 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9937 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9938 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9939 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9940 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9941 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9942 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9943 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9944 for internationlization.
9946 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9948 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9950 * do-if.c, sort.c, val-labs.c: Comment fixes.
9952 * glob.c: (init_glob) Uncommented, updated i18n support.
9954 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9955 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9956 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9957 the declarations of macros taking arguments a lot nicer.
9959 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9961 * error.h: Removed CE, CW aliases for SE, SW.
9963 * q2c.c: Removed explicit streq() definition since it's duplicated
9966 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9967 stats.h, str.h, tokens.h: Made the declarations of macros taking
9968 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9971 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9973 * cmdline.c: Comment fixes.
9974 (pick_compat) Changed return type to int. Now, instead of setting
9975 glob var `compat' to the emulation, returns the emulation. All
9977 (parse_command_line) Added terminating null to end of
9978 `long_options' array definition.
9979 (pre_syntax_message) Fixes.
9980 (usage) Shows the default emulation in the syntax message by
9981 calling pick_compat().
9983 * getline.c: (getl_add_include_dir) Separates paths with
9984 PATH_DELIMITER, not DIR_SEPARATOR.
9986 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9987 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9989 * output.c: (outp_configure_macro) Make earlier definitions for a
9990 particular key override later ones for the same key.
9992 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9994 * ascii.c: Comment fixes.
9996 * output.c: (outp_get_paper_size)
9997 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9999 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
10001 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
10002 <errno.h>. GNU libc 2 enforces this!
10004 * command.c: (parse_cmd) Fixed problem with `else' clause being
10005 paired with wrong `if'. Comment fix.
10007 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
10009 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
10010 blp_getline() to getline().
10012 * output.c: (outp_eval_dimension) Changed the fix from last time;
10013 there was no variable `a'.
10015 * q2c.c: (get_line) Fixed boundary condition overrun bug.
10017 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
10019 * output.c: (outp_evaluate_dimension) Fixed handling of negative
10020 numbers having fractional parts. Added case of a fraction without
10021 a whole-number part.
10023 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
10025 * ascii.c: (ascii_text_get_font_position) Removed.
10027 * expr.h, exprP.h: Disabled debugging.
10029 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
10032 * output.h: (struct outp_class_struct) Removed
10033 text_get_font_position method. All references deleted.
10035 * postscript.c: Big change here. Fontmaps were completely
10036 eliminated because of a change in philosophy. Comment fixes.
10037 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
10039 (struct ps_driver_ext) `position', `fontmap', `prop_name',
10040 `fixed_name' members removed. New members `prop_family',
10041 `fixed_family'. `family' member changed to type char *.
10042 (static var ps_fontmaps) Removed.
10044 (ps_init_driver) Removed obsolete references, updated.
10045 Initializes `translate_x', `translate_y', `scale'. Doesn't read
10046 fontmap, of course. Refers to font names through internal_name
10047 rather than subversive means. Frees proper items.
10048 (static var option_tab[]) Removed `fontmap-file' option; renamed
10049 `fixed-font', `prop-font'.
10050 (ps_option) Corresponds to option_tab[].
10051 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
10052 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
10053 hash_family) Removed.
10054 (postopen) Generates font names from family names. Gets
10055 PostScript font name properly. New prologue file comment `!!!'
10057 (ps_open_page) Adds translate_x, translate_y to BP prologue
10058 function; gives SF argument floating-point format.
10059 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
10060 font name. Doesn't change font family.
10061 (ps_text_set_font_by_position) Generates Groff font name from font
10062 family name instead of through table lookup.
10063 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
10064 all references changed. Reduced to simple string assignment.
10065 (ps_get_font_name) Removed.
10066 (ps_get_font_family) Reduced to string return.
10067 (text) Doesn't save `position' since it no longer exists. Ugly
10068 kluge to save font family--fix soon?
10069 (load_font) Removed PostScript name argument.
10071 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
10073 * postscript.c: Comment fix.
10074 (ps_open_page) Puts scale factor in PostScript output.
10076 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
10078 * Makefile.am: Distcleans q2c.
10080 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
10082 * ascii.c: (delineate) Sets text size even if width is zero.
10084 * command.c: Comment fix.
10085 (static var cmd_table[]) Re-enabled EVALUATE command.
10086 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
10087 of comments in script files. Now more liberal on criteria for
10088 performing a state transition--if *anything* happened correctly,
10089 not just if *everything* happened correctly.
10091 * data-out.c: (convert_F) Comment fix. Why in the fsck does
10092 Checker segfault on formatting large numbers and why in the fsck
10093 hadn't I noticed this before?
10095 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
10097 * list.q: (cmd_list) Commented out the actual output routine
10098 because of various problems. Probably will abandon the idea of
10099 using the general `crushed tables' for the LIST procedure.
10101 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
10102 clearing it. Allocates a new var_by_name dictionary before trying
10103 to add members to it.
10105 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
10106 `sib'. Changed type of `node' argument.
10107 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
10108 avl_walk_inorder().
10109 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
10110 [DEBUGGING] Only deletes the variable from var_by_name if that var
10113 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
10115 * Makefile.am: Added include files to SOURCES. Added
10116 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
10117 includes rules for q2c. Added `boast' target.
10119 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
10121 * Makefile.am: Maintainer-clean Makefile.in.
10123 * Makefile.am: Fixed redundant EXTRA_DIST line.
10125 * ascii.c: Comment fixes.
10126 (ascii_line_vert) Fixed overly aggressive range check.
10128 * display.c: Removed dead code.
10130 * list.q: Turn debugging on.
10131 (flush_table) New debug code.
10133 * sfm-read.c: (read_value_labels) malloc's the structure before
10134 trying to assign to its members.
10136 * sfm-write.c: Comment fix.
10138 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
10140 (output_table) No arguments anymore--gets them through `som'
10141 global. New debug code. In crushed tables, now sets `htv' as
10142 well as `hv' to avoid bad confusion later.
10143 (dump_crush_page) New debug code.
10145 * som-low.c: (som_dump_crush_page) New debug code.
10147 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
10149 All source files: Broke long lines into multiple lines.
10151 * ascii.c: (ascii_close_page) Uses host_system var in place of
10152 HOST_SYSTEM constant.
10154 * cmdline.c: (var syntax_message[]) Broke into
10155 pre_syntax_message[] and post_syntax_message[].
10156 (usage) Outputs both parts, separated by driver list.
10158 * error.h: Fixed broken formatting.
10160 * expr-opt.c: (str_search, str_rsearch) New functions.
10162 * misc.c: (blp_getdelim) Removed. All references changed to
10164 (str_search, str_rsearch) Removed.
10165 (memrmem) New function.
10167 * misc.h: (blp_getline) Removed. All reference changed to
10170 * stat.h: New file.
10172 * filename.c: Includes "stat.h", not <sys/stat.h>.
10173 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
10175 * output.c: (outp_list_classes) Changed output formatting.
10177 * sfm-write.c: (write_header) Uses host_system var instead of
10178 HOST_SYSTEM constant.
10179 (write_rec_7_34) Extracts version numbers from the version string.
10182 * sort.c: Includes "stat.h", not <sys/stat.h>.
10184 * str.c: (strcasecmp) Removed.
10186 * title.c: (cmd_document) Uses host_system var instead of
10187 HOST_SYSTEM constant.
10189 * version.c: Generated on-the-fly by the Makefile instead of being
10192 * str.h: Comment fixes. Doesn't substitute for missing memmove or
10194 [!HAVE_STRNCASECMP] Declares strncasecmp().
10196 * version.h: Removed stray character. Comment fixes.
10197 (vars host_system, build_system) New vars.
10199 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
10201 * Most source files: Changed formatting of copyright notice; fixed
10202 FSF address; reformatted to better conform to GNU standards;
10203 comment fixes. Added markups to prevent GNU indent from messing
10204 up my beautiful formatting :-).
10206 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
10207 that GNU indent markups can be passed through without problems.
10209 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
10211 * get.c: Turned off debugging.
10213 * glob.c: (init_glob) Turned on save-file compression by default.
10215 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
10216 compression than was possible in save files.
10218 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
10220 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
10222 * frequencies.q: Removed Fiasco extensions. Updated calculation
10223 algorithms. Polished output format.
10224 (struct frq_info_struct) Removed members `max_degree', `min_n',
10225 all references removed.
10226 (macro frq_extensions) Removed.
10227 (static vars min_n, max_degree) Removed, all references removed.
10228 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
10229 calculate `min_n', `max_degree'.
10230 (postcalc) Passes new arg to dump_statistics().
10231 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
10233 (dump_condensed) Adds variable name title.
10234 (sum_freqs) Removed.
10235 (calc_stats) Updated calculation algorithm.
10236 (dump_statistics) Removed warning for too-few observations.
10237 Changed table formatting. Adds variable name title if passed new
10240 * output.h: Comment fix.
10242 * recode.c, sample.c, sort.c: Disabled debug code.
10244 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
10245 Improved debug code.
10247 * var.h: (enum series frq_*) Removed Fiasco extensions.
10249 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10251 * command.c: Added PROCESS IF to command table.
10253 * Lots & lots of places, removed checks for NULLs preceding calls
10254 to free_expression(), which itself checks.
10256 * descript.q: Removed Fiasco extensions. Removed optimizations
10257 for non-weighted active files. Implemented some options.
10258 Finished polishing output format. Comment fixes. Merged
10260 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10261 max_degree, min_n) Removed.
10262 (macro dsc_extensions) Removed.
10263 (struct dsc_info_struct) Removed `min_n' member, all references
10265 (internal_cmd_descriptives) Removed calculation of min_n,
10266 max_degree. Only deals with one `calc' routine instead of two
10268 (precalc) Eliminated redundancy. Updated for changes to
10269 descriptives_proc structure.
10270 (calc) Moved here from `descript.g'. Rewritten to calculate
10271 statistics via `moments about the mean' rather than by summing,
10272 summing squares, summing cubes, and so on.
10273 (postcalc) Rewritten for new-style statistical calculation.
10274 (display) Removed support for displaying variables across rows.
10275 No longer crushes the descriptives table. Removed ancient code.
10276 Added display of N, by variable and listwise.
10278 * descript.g: Removed; merged into `descript.q'.
10280 * expr-evl.c: (evaluate_expression) Now returns a double. For
10281 numeric results, it returns the result as well as storing it in
10282 the passed `value' structure if non-NULL. For string results it
10283 just returns 0.0 and it must be passed non-NULL. Many references
10284 to this function were optimized by use of this change, especially
10285 but not exclusively in `compute.c'.
10287 * frequencies.g: Comment fix.
10289 * glob.c: (glob var process_if_expr) New global var.
10291 * postscript.c: (static var option_tab[]) Corrected entry for
10293 (postopen) Sets x->size to x->prop_size.
10294 (ps_text_set_font_by_name) Sets font size as well as typeface for
10295 PROP and FIXED fonts.
10297 * sel-if.c: (cmd_process_if) New function.
10299 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10300 (sfm_write_dictionary) Sets `n_cases' to 0.
10301 (sfm_write_case) Increments `n_cases'.
10302 (sfm_close) Attempts to seek the system file back to the header
10303 and write the number of cases in its proper slot.
10305 * som-frnt.c: (som_insert_table) Masks off expansion options since
10306 only SOPT_X_NORM seems to work sensibly.
10308 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10309 with a `fixed' value of 2.
10311 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10313 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10314 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10316 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10317 (struct descriptives_proc) Removed `miss_noweight'; new members
10318 `X_bar', `M2', `M3', `M4', `min', `max'.
10320 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10322 * vfm.c: (close_active_file) Cancels PROCESS IF.
10323 (write_case) Doesn't process cases unselected by PROCESS IF.
10325 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10327 * glob.c: (glob var err) Removed.
10329 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10330 doesn't have to take into account number of value labels since
10331 they're in a subtable anyway. Also, doesn't display more than 10
10332 value labels since we can't yet break pages in subtables.
10334 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10336 * som-frnt.c: (som_change_table_size) Simple change for elegance
10337 that shouldn't change behavior.
10338 (som_set_value) Comment fix.
10340 * som-high.c: (som_submit_table) Message fix.
10342 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10344 * command.c: Added SYSFILE INFO to command table.
10346 * file-handle.q: (fh_handle_filename) New function.
10348 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10351 * main.c: (parse) New return value for command functions, -3.
10353 * misc.h: Comment fix.
10355 * output.h: Comment fixes.
10356 (macro COMPONENTS) Removed.
10358 * postscript.c: (write_text) Modified literal_chars[] so that `('
10359 and ')' are not written to the output in strings as literals.
10361 * sfm-read.c: (sfm_read_dictionary) New argument.
10362 (read_header) New argument. Sets the information structure's
10363 values from the header information.
10364 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10365 bizarre Checker problem, I guess.
10366 (read_variables) Proper cleanup on lossage.
10368 * sfm.h: (struct sfm_read_info) New struct for use by
10369 sfm_read_dictionary().
10371 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10372 currently used just for tables that can be dynamically resized and
10373 thus have to be allocated with arena_malloc() instead of
10374 arena_alloc(). All references changed.
10375 (som_change_table_size) New function.
10376 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10378 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10379 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10382 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10384 (draw_intersection) Now takes an argument specifying the table in
10385 question. All references changed.
10386 (draw_table_cell) New function.
10387 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10388 (som_get_table_size) Many nice new explanatory comments.
10389 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10391 * som.h: New enum series SOM_CREATE_* for use as create flags with
10392 som_create_table().
10394 * str.h: Moved a comment here from TODO.
10396 * sysfile-info.c: New file. Reference implementation.
10398 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10400 * command.c: Added RENAME VARIABLES to table of commands.
10402 * data-in.c: (dls_error) Sets `cust_field'.
10403 (parse_N) Message fix.
10404 (parse_day_count) New function.
10405 (to_roman) Never outputs VX as a `short form' of V.
10406 (parse_month) Fixed parsing of Roman numerals.
10407 (parse_trailer) Message fix.
10408 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10409 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10410 the date is invalid.
10411 (parse_SDATE) Fixed swapped day, year.
10412 (parse_JDATE) Fixed bug for dates in 1582.
10413 (parse_DTIME) Allows days not between 1 and 31.
10414 (parse_numeric) Makes local copy of f.type for easier usage.
10417 * data-out.c: (convert_F) When outputting as scientific, properly
10418 sets f.type as fp->type.
10419 (insert_commas) Fixed operator precedence problem with setting of
10420 nitems. Changed strcpy to memcpy (no null terminator).
10421 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10422 (convert_CCx) Essentially rewritten, but now it works.
10424 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10425 feature of Fiasco).
10426 (display_documents) Implemented.
10428 * error.c: (glob var cust_field) New var.
10429 (vmsg) Displays cust_field as part of message classes DE and DW.
10431 * formats.c: (debug_print) Fixed to compile under updated
10434 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10437 * misc.c: (parse_format_specifier) Formatting fix.
10439 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10440 `n_rename' for clarity.
10441 (cmd_modify_vars) Initializes `forward' and `positional' at
10442 appropriate times. Frees lists of vars to rename on failure.
10443 Comment fix. Frees memory on success.
10444 (rearrange_dict) Simplified `for' loop condition.
10446 * rename-vars.c: New file (reference implementation).
10448 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10450 * sfm-read.c: (read_header) File label is created only if file
10451 label in file is not blank.
10452 (read_variables) Initializes `dict' local variable.
10453 (read_documents) Proper behavior on lossage.
10455 * sfm-write.c: (write_header) Doesn't blank out the file label
10456 (why was this here to begin with?!)
10458 * temporary.c: (save_dictionary) File label is copied only if
10459 non-NULL. Doesn't try to xstrdup() dictionary documents.
10460 Adapted so as to not irritate Checker.
10461 (free_dictionary) Only destroys var_by_name if non-NULL.
10463 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10464 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10465 lines to the document, indents the document. Also, it works now.
10466 (add_document_line) New function.
10468 * var.h: (struct dictionary) Reordering.
10470 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10471 bits if it was allocated to begin with.
10473 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10475 * command.c: Added MODIFY VARS to list of commands.
10477 * configure.in: Updated custom macros for autoconf 2.12. Removed
10478 mmap reference; fixed termcap library reference.
10480 * display.c: (display_variables) Fixed a few bugs although it's
10481 still not well written.
10483 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10484 (induce_segfault) Calls chkr_disp_call_chain() instead of
10485 inducing an actual SIGSEGV.
10487 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10488 str_search() and str_rsearch(). Fixed tests for matches on
10489 OP_INDEX and OP_RINDEX.
10491 * filename.c: (good_getcwd) Removed as the new libc for Checker
10492 doesn't contain this bug, apparently.
10494 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10495 consistency with GNU memmem.
10496 (blp_getdelim) Changed `len' from `int' to `size_t'.
10498 * modify-vars.c: Reference implementation.
10500 * som-frnt.c: (zero_length) New global var.
10501 (som_create_table) Message fix.
10503 * som.h: Added gcc attributions to som_set_text(),
10504 som_output_text() prototypes. blank_line() refers to
10505 zero_length[] instead of a literal null string to suppress gcc
10508 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10509 (allocate_cases) Decrements x_max so the last element of x[] can
10510 be used by the algorithm.
10512 * var.h: Changed minor details of `variable' declaration.
10513 (struct modify_vars_proc) New struct.
10514 (struct variable) Added field p.mfv.
10516 * vars-atr.c: Comment fix.
10518 * vars-prs.c: (fill_all_vars) More optimal implementation.
10520 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10521 character, which it shouldn't have to do but printf() seems to
10522 read the null byte even though I supply a maximum length...
10524 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10526 * command.c: Removed command alias X for QUIT.
10527 (parse_cmd) Fixed comment parsing.
10529 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10531 (read_record) Fixed references to len, size.
10532 (dfm_get_record) Restructured.
10534 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10537 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10540 * modify-vars.c: New file. Not complete.
10542 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10545 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10546 problems caused by int/size_t differences.
10548 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10551 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10552 being compared were of equal length.
10554 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10556 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10558 * lexer.c: (get_dotted_rest_of_line) New function.
10560 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10563 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10564 type 6 records. Frees the dictionary properly.
10565 (read_header) Initializes the dictionary instead of letting
10566 read_variables() do it. Sets the dictionary file label from the
10568 (read_documents) New function.
10570 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10571 write type 6 record if appropriate.
10572 (write_header) Writes file label from dictionary.
10573 (write_documents) New function.
10575 * temporary.c: (save_dictionary, restore_dictionary,
10576 free_dictionary) Properly handle new fields in dictionary struct.
10578 * title.c: (get_title) Returns after failure().
10579 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10580 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10582 * var.h: (struct dictionary) New fields `label', `n_documents',
10585 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10587 * command.c: Added FILTER to list of commands.
10589 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10592 * get.c: (cmd_save_internal) Removed weighting code since it's now
10593 handled by sfm-write.c. Properly commented out debug code.
10595 * glob.c: (glob var weighting) Removed.
10597 * sel-if.c: Comment fixes.
10598 (cmd_filter) New function.
10600 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10601 (sfm_read_dictionary) Sets weighting variable direct in the
10602 created dictionary now. (Apparently we previously didn't support
10604 (read_header) Sets weight_index field in sfm_fhuser_ext from
10605 header read from disk.
10607 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10608 (write_header) Now sets the weighting in the header from the
10609 passed primary dictionary instead of from the sfm_write_info.
10611 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10613 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10614 broke on boundary conditions.
10616 * var.h: (struct dictionary) New fields `weight_var',
10617 `weight_index', and `filter_var'.
10618 (glob var weighting) Removed. This is now part of struct
10619 dictionary. All references changed; the less mechanical changes
10620 are described above.
10622 * vars-atr.c: (find_dict_variable) New function.
10624 * vfm.c: (static var filter_index) New variable.
10625 (open_active_file) Initializes filter_index from default_dict.
10626 (write_case) Calls proc_func() only if the filter variable is
10627 nonzero; this implements FILTER behavior.
10629 * weight.c: (static var weight_varname) Removed.
10630 (cmd_weight) Modified default_dict instead of glob vars.
10631 (update_weighting) Changed the signature to modify a dictionary
10632 instead of glob vars. Now returns the weighting variable.
10633 (get_weighting_variable) Removed; its function is absorbed by
10634 update_weighting().
10635 (stop_weighting) Operates on a dictionary now.
10637 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10639 * sort.c: Removed debugging info from messages.
10640 (do_external_sort) Cleans up after itself by deleting the
10641 temporary directory on failure. (On success it is deleted by the
10643 (allocate_cases) Removed debug code. Added clean up code.
10644 (output_record) Removed debug code.
10645 (merge) Added code to close all the input files that are currently
10646 open. This is a likely location for bugs, because I'm not sure
10647 about boundary conditions. Removed an unnecesary heap_delete().
10648 (merge_once) Removed input file "optimization" that in fact
10649 screwed up the rest of the code. Message and comment fixes.
10651 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10653 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10655 * heap.c: (heap_delete) New argument.
10657 * sort.c: Finished implementation of external sort.
10659 * vfm.c: (read_from_disk) Returns after a disk error.
10661 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10663 * sort.c: (static var state) Removed.
10664 (static vars max_handles, tmp_basename, tmp_extname,
10665 huffman_queue) New variables.
10666 (do_external_sort) Moved most code to new functions.
10667 Creates huffman_queue.
10668 (allocate_file_handles, allocate_cases) New functions.
10669 (static vars run_no, run_length, file_index, case_count) New
10671 (output_record) Returns success. Now really writes to the output
10673 (begin_run, end_run) New functions.
10674 (write_initial_runs) Returns success. Initializes run_no to -1.
10675 Calls begin_run(), end_run() at appropriate times. Outputs debug
10677 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10679 (merge) New function.
10681 * heap.c, heap.h: New files. Hopefully in near-final form.
10683 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10685 * glob.c: Added write_active_file to global vars.
10687 * sort.c: Several new miscellaneous static variables.
10688 (cmd_sort_cases) Big comment fix.
10689 (perform_case_2) Renamed `do_external_sort' and completely
10691 (case_2_proc_func) Removed.
10692 (output_record, write_initial_runs, write_to_sort_cases,
10693 compare_record) New functions.
10695 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10697 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10699 * sort.c: (perform_case_2) Changed the method for allocation of
10700 lots of memory--now allocates one case at a time in hopes that
10701 more cases can be allocated with heavily fragmented memory.
10703 * var.h: (write_active_file) New global var.
10705 * vfm.c: (procedure, close_active_file, write_case,
10706 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10707 arguments to procedure() to be NULL. All references to
10708 procedure() that made use of dummy functions were changed to NULL
10710 (open_active_file) If write_active_file is non-NULL, the output
10711 device becomes DEV_PGM (a new enum).
10712 (close_active_file) Sets write_active_file to NULL.
10713 (read_from_memory) Comment fix.
10714 (record_case) Calls write_active_file() when the output device is
10717 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10719 * sort.c: New file.
10721 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10722 Fixed checking for duplicate varnames.
10723 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10725 (autorecode_trns_free) Destroys hash tables for each recoding
10727 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10729 * command.c: Added SORT CASES to cmd_table.
10730 (null_func, null_int_func) Prototyped.
10732 * descript.g: (calc_weight, calc_noweight) Computes own case
10735 * frequencies.q: (dump_statistics) Fixed problem with
10736 too-few-cases warning message.
10738 * get.c: (cmd_save_internal) Handles weighting properly.
10740 * hash.c: (hsh_dump) Output format changed.
10741 (force_hsh_insert) Actually works now, prototype changed.
10743 * list.q: (static var case_num) New variable.
10744 (cmd_list) Initializes case_num.
10745 (list_cases) Increments case_num.
10747 * var.h: Added definitions for SORT CASES. Comment fixes.
10749 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10750 fixes. `active' renamed vfm_active, `rep' renamed
10751 vfm_replacement, all references changed.
10752 (procedure) The procfunc no longer receives a case number. All
10753 references changed.
10754 (write_case) Subtle reordering.
10755 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10758 * weight.c: (get_weighting_variable) New function.
10760 * vfmP.h: New file with definitions from vfm.c.
10762 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10764 * command.c: (FILE_TYPE_okay) Commented out some tests because
10765 they're clumsy and not yet needed.
10767 * var.h: Most *_trns structures moved to their respective source
10768 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10769 (union any_trns) Changed to a typedef for trns_header.
10770 (struct input_program_pgm) Removed.
10772 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10773 was allocated in the first place.
10775 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10777 * autorecode.c: New file.
10779 * command.c: Added AUTORECODE to command table; re-enabled SET.
10781 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10783 * error.c: (vmsg) Comment fixes.
10785 * hash.c: Comment fix.
10786 (hashpjw_d) New function.
10787 (hashpjw) Reimplemented as call to more general function
10789 (internal_comparison_fn) Initializes pointers properly.
10790 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10791 (force_hsh_insert, force_hsh_find) New debugging wrapper
10794 * main.c: (main) Message fix.
10796 * output.c: (outp_read_devices) Message fix.
10798 * set.q: Comment fixes.
10799 (custom_results) Implemented Wnd/X form of subcommand.
10800 (set_routing) New function.
10801 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10803 * settings.h: (SET_ROUTE_*) New enum series.
10804 (set_results) Renamed set_results_file, all references changed.
10805 (set_messages) Removed.
10806 (glob vars set_errors, set_messages, set_results) New vars.
10808 * title.c: (get_title) Remembers to xstrdup() the result of
10809 get_rest_of_line().
10811 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10813 (union any_trns) New element `arc'.
10815 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10817 * command.c: (output_line) Removed references to set_screen.
10819 * error.c: (static var terminating) New var.
10820 (hcf) Sets terminating to 1.
10821 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10822 This prevents an infinite loop if an error occurs within hcf().
10824 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10825 statement circumlocution with `case 42000' trick.
10826 (evaluate_expression) New support for OP_STR_MIS.
10828 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10829 statement circumlocution with `case 42000' trick.
10830 (dump_node) Handles OP_STR_MIS.
10832 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10833 variables exceptions.
10834 (parse_function) Message fix.
10835 (ops[]) Added OP_STR_MIS.
10837 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10839 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10841 * glob.c: Removed set_scrnfile glob var.
10842 (init_glob) set_errorbreak set to 0 by default.
10844 * groff-font.c: Changed included files.
10845 (groff_read_font) Initializes font_arena local var correctly.
10846 (default_font) New function.
10848 * output.c: Comment fixes.
10849 (glob var disabled_devices) New variable.
10850 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10852 [GLOBAL_DEBUGGING] (reentrancy) New function.
10853 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10854 outp_iterate_enabled_drivers) Calls to reentrancy().
10855 (destroy_list) New function.
10856 (outp_done) Moved code to destroy_list().
10857 (parse_options) Parses `listing', `screen', `printer' options
10859 (configure_driver) Sets new `device' member of driver.
10860 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10862 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10863 (struct outp_driver_struct) New member `device'.
10865 * postscript.c: (find_encoding_file) Doesn't display its own error
10867 (default_encoding) New function.
10868 (switch_font) Calls default_encoding() if no encoding can be
10870 (text) Makes up a character metric if none exists for the desired
10872 (load_font) Properly copies a fallback filename. Calls
10873 default_font() for a font if none at all are known.
10875 * set.q: Comment fixes. Removed OUTPUT subcommand.
10876 (custom_listing) Calls outp_enable_device() to enable/disable
10878 (turn_screen_on) Removed.
10879 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10880 screen, printer devices.
10882 * settings.h: Comment fixes.
10883 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10886 * som-high.c: (som_submit_table, som_eject_page) Use
10887 outp_iterate_enabled_drivers() instead of iterating
10888 outp_driver_list directly.
10890 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10892 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10893 (parse_string_as_format) Handles new formats.
10894 (parse_numeric) Now handles DOT and PCT formats.
10896 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10898 (convert_date) Handle EDATE and SDATE formats.
10899 (convert_CCx) Now if there's not room for the currency characters,
10900 converts it as F format if it's positive instead of giving up
10901 quickly. Also fixed save-and-restore bug with decimal point
10903 (convert_format_to_string) Handles new formats.
10905 * misc.c: (formats[]) Added new formats.
10906 (convert_fmt_ItoO) Supports new formats.
10908 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10909 data checking. New argument, all references changed.
10911 * sfm-write.c: (write_format_spec) Supports new formats.
10913 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10916 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10918 * cmdline.c: Comment fixes.
10919 (parse_command_line) Changed return type to void.
10921 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10923 (parse_numeric) Handles international numbers (comma as decimal
10924 point). Some reformatting.
10926 * data-list.c: (parse_free) Default output format is now
10927 set_format instead of hard-coded F8.2.
10928 (read_from_data_list_list) Emits error message on undefined data
10929 only if set_undefined is nonzero.
10931 * data-out.c: (convert_E) Changes decimal point from period to
10932 comma if appropriate. Restructured. Better comments.
10933 (convert_F) Changes decimal point from period to comma if
10935 (insert_commas) Major bug with handling of negative values fixed.
10936 Also, inserts periods instead of commas if appropriate.
10937 (convert_CCx) New function.
10938 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10939 (num_to_string) Changed `.' to set_decimal.
10941 * dfm.c: Comment fixes.
10942 (dfm_close) Frees ext->line even in inline_file.
10943 (open_inline_file) New function.
10944 (open_file_r) When opening the inline file: now properly
10945 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10947 (read_record) Calls fh_close_handle() instead of dfm_close() to
10948 close the inline file. Makes a copy of the line getl_buf to avoid
10949 interlock problems.
10950 (dfm_get_record) Restructured. Now checks the return value of
10952 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10953 checking for use of inline file. No longer tries to close inline
10956 * error.c: (glob var error_already_flagged) New var.
10957 (vmsg) Message change. Now checks max number of errors/warnings,
10960 * file-handle.q: (fh_handle_name) Now allows closing of
10962 (fh_init_files) Reformatted.
10964 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10966 * getline.c: (getl_include) Fixed bug that popped up when called
10967 when file queue was empty.
10968 (read_console) Resets error_count, warning_count,
10969 error_already_flagged to zero.
10971 * glob.c: Many changes to update list of variables.
10972 (init_compat_dependent) Now this function is called whenever
10973 `compat' changes. It now sets set_seed only if it hasn't
10974 previously been referenced. It now calls
10975 lex_init_compat_dependent().
10977 * include.c: (cmd_include_at) Frees temporary buffer instead of
10979 (cmd_include) Doesn't make copy of include file name.
10981 * lexer.c: Comment fixes.
10982 (init_lex) Moved some code into new function
10983 lex_init_compat_dependent().
10984 (lex_init_compat_dependent) New function.
10985 (hex_val) Simplified.
10986 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10988 * main.c: Comment fixes.
10989 (main) Reformatted.
10991 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10992 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10993 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10994 (setup_randomize) Sets set_seed_used.
10996 * set.q: Comment fixes.
10997 (custom_results) Conditionalizes on `compat'.
10998 (custom_log) Calls custom_journal().
10999 (set_ccx) New function.
11000 (cmd_set) Calls init_compat_dependent() when `compat' changes.
11001 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
11002 when set_decimal changes. Range-checks values for MITERATE,
11003 MNEST. Message fixes.
11005 * settings.h: Comment fixes.
11006 (struct set_cust_currency) New struct.
11007 (set_cc[], set_grouping, set_seed_used) New global vars.
11009 * var.h: (FMT_CCA...FMT_CCE) New output formats.
11010 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
11012 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
11014 * glob.c: Revised variables to correspond to settings.h.
11015 (init_glob) Initializes variables from settings.h properly.
11017 * set.q: Began long-overdue major revision to correspond to new
11018 philosophy. Most code changed.
11020 * settings.h: Mostly changed; reorganized, reordered, large new
11023 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
11025 * get.c: (cmd_save_internal) No longer forces compression off.
11027 * sfm-read.c: (read_compressed_data) If eof is reached when
11028 reading a new instruction octet, only signal error if we're in the
11031 * sfm-write.c: (COMPRESSION_BIAS) New #define.
11032 (struct sfm_fhuser_ext) New member `end'.
11033 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
11034 (ensure_buf_space) New function.
11035 (sfm_write_case) Reimplemented in order to support compression.
11036 (sfm_close) Writes out the remaining contents of the compression
11039 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
11041 * command.c: Defined SAVE and XSAVE commands in command table.
11043 * common.h: second_lowest_value is of type flt64, not double.
11045 * file-handle.h: Comment fix.
11047 * get.c: Comment fixes.
11048 (static var `trns') New.
11049 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
11050 cmd_save_internal, cmd_save, cmd_xsave) New functions.
11051 (dict_delete_run) Clears the variables and frees them now.
11052 (trim_dictionary) Sets default for compression.
11053 On KEEP subcommand, frees deleted variables as well as clearing
11054 them. Finally got the sense of the test for deleting all
11056 [DEBUGGING] (dump_dict_variables) Message fix.
11058 * glob.c: (init_glob) set_compression set to 1 by default.
11060 * list.q: Properly #includes config.h.
11062 * misc.h: New macro REM_RND_UP.
11064 * settings.h: Comment fix.
11066 * sfm-read.c: (structs sysfile_header, sysfile_format,
11067 sysfile_variable; inline function bswap_int32) Moved to new file
11069 (corrupt_msg) [__CHECKER__] No longer induces segfault.
11070 (sfm_read_dictionary) Fixed bug caused by failing to initialize
11072 (read_machine_flt64_info) Fixed some problems caused by confusion
11073 between flt64 and double types.
11074 (read_header) Message fix.
11075 (read_variables) Fixed set of cases in which we byte-swap sv.print
11076 and sv.write. Fixed confusion of flt64 and double.
11078 * sfm.h: (struct sfm_write_info) New.
11080 * som-high.c: (som_draw_title) Properly frees `s'.
11082 * temporary.c: (save_dictionary) Comment fix.
11084 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
11085 (struct trns_header) Formatting fix.
11086 (struct save_trns) New.
11088 * vars-atr.c: (discard_variables) Comment fix.
11090 * sfm-write.c: New file, baseline release.
11092 * sfmP.h: New file, baseline release.
11094 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
11096 * cmdline.c: (parse_command_line) `--version' output updated.
11097 (glob var syntax_message[]) Added my e-mail address.
11099 * file-handle.q, lexer.c, vfm.c: Changed many instances of
11100 `illegal' to `invalid'.
11102 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
11103 uncompression buffer.
11104 (sfm_close) Frees decompression buffer.
11105 (sfm_read_dictionary) Initializes decompression buffer.
11106 (buffer_input, read_compressed_data) New functions.
11107 (sfm_read_case) Restructured; now calls read_compressed_data() to
11108 handle compressed system file data.
11110 * var.h: Comment fix.
11112 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
11114 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
11117 * get.c: New comments. New static var `get_file'.
11118 (cmd_get) Now fully implemented. Calls discard_variables();
11119 initializes fv and lv for all variables; new debug code; sets
11120 up the dictionary; sets up the input program.
11121 (read_from_get, cancel_get) New functions.
11123 * sfm-read.c: Comment fixes.
11124 (sfm_close) New static function.
11125 (sfm_read_dictionary) Properly sets up the class of the
11126 file_handle. No longer cares what size the data is in records of
11127 type 7. Also, on failure, properly cleans up the file_handle and
11128 free()s some stuff.
11129 (read_variables) No longer thinks it knows `nval' of the
11130 dictionary. Now sets p.get.fv, etc., instead of speculatively
11132 (read_value_labels) Fixed off-by-one error in indexing of
11134 (sfm_read_case) New function.
11135 (sfm_r_class) New static var.
11137 * var.h: (get_proc) New struct.
11138 (struct variable) New member p.get.
11140 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
11142 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
11143 the manual's meaning.
11144 (rename_variables) New function.
11145 (trim_variables) Doesn't try to parse MAP any more. Removed debug
11146 code. Now properly reorders the dictionary on the KEEP keyword.
11148 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
11149 garbage collection.
11151 * vars-atr.c: (clear_variable) New argument `dictionary *'.
11152 (rename_variable) New function.
11153 (free_val_lab) Reformatted.
11155 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
11157 * var.h: Reindented entire file. Comment fixes.
11158 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
11160 (glob var default_dict) New.
11161 (struct indirect_dictionary) Removed.
11163 * Many other source files were changed to add `default_dict.'
11164 before all references to the dictionary of the active file.
11166 * vars-atr.c: (make_indirect_dictionary) Removed.
11168 * glob.c: Reindented all variable declarations. Updated for
11169 changed var.h. Comment fixes.
11171 * temporary.c: (restore_dictionary, save_dictionary) Simplified
11172 because now we can mainly copy dictionary structs.
11174 * vars-prs.c: (is_dict_varname, parse_dict_variable,
11175 parse_variables) Takes dictionary instead of indirect_dictionary
11177 (parse_variables) Instead of calling make_indirect_dictionary,
11178 just sets DICT to &default_dict if DICT is NULL. Of course, lots
11179 of `*dict.' references had to be changed to `dict->'. Removed
11182 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
11184 * get.c: Added GTSV_OPT_* series of enums.
11185 (trim_dictionary, dict_delete_run) New functions.
11186 [DEBUGGING] (dump_dict_variables) New function.
11187 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
11188 [DEBUGGING] Calls dump_dict_variables() to display results.
11190 * glob.c: (cmp_variable) Now a public function declared in var.h.
11192 * sfm-read.c: Turned off debug code. Comment fixes.
11193 (read_machine_int32_info, read_machine_flt64_info) New functions
11194 to parse type 7 records.
11195 (sfm_read_dictionary) Properly byteswaps several fields now.
11196 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
11197 records. [DEBUGGING] Dumps dictionary.
11198 (read_variables) Sets `index' field of variables created properly.
11199 Constructs avl tree of variables in dictionary. [DEBUGGING] No
11200 longer dumps dictionary.
11201 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
11203 [DEBUGGING] (dump_dictionary) No longer stubbed out.
11205 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
11206 var before destroying any variables just to save a little time.
11208 * var.h: (struct variable) Reordered in order to make name[] the
11209 first member; this makes pointers to `variable' pointers to the
11210 variable name, simplifying avl trees, etc.
11211 (struct indirect_dictionary) New struct.
11213 * vars-atr.c: (find_variable) Rewritten for efficiency.
11214 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
11216 (is_varname) Rewritten for efficiency.
11217 (parse_variables) New argument, which is a `dictionary *'. All
11218 references changed. This function now reads variable names from
11219 the dictionary passed, or from the default dictionary if NULL.
11221 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
11223 * misc.h: Added new macro DIV_RND_UP to perform integer division,
11224 rounding up. Changed many references to ROUND_UP to use this
11227 * sfm-read.c: Includes avl.h.
11228 (corrupt_msg) Induces a segfault under Checker.
11229 (macro assertive_bufread) New. Many references to bufread() now
11231 (sfm_read_dictionary) Split up into several functions. Added code
11232 to read dictionary records following the the type 2 records. Not
11233 quite complete. New variable `var_by_index'.
11234 (read_header, read_variables) New functions extracted from
11235 sfm_read_dictionary().
11236 (read_value_labels) New function.
11237 (bufread) Checks ferror() if fread() doesn't return the expected
11238 value; if ferror() is zero it's just EOF.
11239 (dump_dictionary) Stubbed out.
11241 * BTW: The source code now exceeds 50000 lines!
11243 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
11245 * command.c: Added GET to cmd_table[].
11247 * list.q: Removed reference to alloca headers.
11248 (cmd_list) Gave prototype.
11250 * sfm-read.c: Added DEBUGGING comments.
11251 (sfm_read_dictionary) Checks bias correctly. Sets
11252 dict->var_by_name to NULL. Calculates long_string_count
11253 correctly. realloc's dict->var[] array to minimum size.
11254 [DEBUGGING] Calls dump_dictionary.
11255 [DEBUGGING] (dump_dictionary) New function.
11257 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11258 (restore_dictionary) If the dictionary contains a non-NULL
11259 var_by_name, uses that instead of generating one.
11260 (free_dictionary) Destroys var_by_name.
11262 * var.h: (struct dictionary) Added field `var_by_name'.
11264 * get.c: New file, not complete.
11266 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11268 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11269 (parse_num_or_range) New function.
11270 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11271 <n> THRU HIGH missing values.
11273 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11274 __attribute__((const)).
11276 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11278 * sfm-read.c: Finished reference implementation.
11280 * sfm.h: Includes var.h.
11282 * var.h: Comment fixes.
11283 (struct `variable') Reordered some fields.
11285 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11286 constants added previously.
11288 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11290 * common.h: Comment fixes. Added declaration of
11291 `second_lowest_value' as variable or macro. Made `compat_type',
11292 `pgm_state_type' into anonymous enums.
11294 * display.c: Comment fix.
11296 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11298 [!defined SECOND_LOWEST_VALUE] Added definition for
11299 `second_lowest_value' global var.
11300 (compat, pgm_state global vars) Changed types to `int'.
11301 (init_glob) Initializes `second_lowest_value'.
11303 * sfm-read.c: Continued work, not complete.
11305 * var.h: Added new MISSING_* constants to handle LOWEST and
11308 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11310 * sfm-read.c: New file, not complete.
11312 * cases.c: (vec_insert) Changed vector expansion algorithm.
11313 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11314 mucking up the RECODE transformation in particular.
11315 (envector) Harmless change in notation.
11317 dfm is now fairly well tested again.
11318 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11320 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11322 * recode.c: Comment fix.
11324 * sfm.h: Interface should be fairly final now, or at least for a
11327 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11328 (open_active_file) [DEBUGGING] Translates ccase indices into
11329 variable names now to make it easier to understand what's really
11332 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11334 * data-in.c: Comment fix.
11336 * data-list.c: Includes dfm.h.
11337 (do_reading) Uses new function dfm_push_cust().
11339 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11340 `return 1;' at end.
11342 * file-handle.h: Completely changed. Some parts split off into
11343 new file dfm.h. Implemented in file-handle.q.
11344 (enum FH_*) Removed.
11345 (struct fh_ext_class) New struct.
11346 (struct file_handle) Retained only these fields: name, norm_fn,
11347 fn, recform, lrecl, mode. New fields class, ext.
11348 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11349 close_handle, handle_name) Added `fh_' prefix to name, all
11350 references changed.
11352 * dfm.h: New file, implemented in dfm.c.
11353 (get_record, put_record, fwd_record, bkwd_record, set_record,
11354 get_cur_col) Functions moved from file-handle.h, now prefixed with
11356 (dfm_push_cust) New function.
11358 * sfm.h: New file. Incomplete.
11360 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11361 interface. Functions reordered, comments changed. Not well
11362 tested, probably full of bugs.
11363 (struct dfm_fhuser_ext) New struct.
11364 (dfm_close) New function.
11365 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11366 (open_file_w) User messages changed.
11367 (get_record) Comment fixed.
11368 (read_record) Increments ext->ln even for inline_file. Calls
11369 dfm_close() for inline_file when `END DATA.' encountered.
11370 (dfm_get_record) Experimental restructuring.
11371 (dfm_push_cust) New function.
11372 (cmd_begin_data) Detects whether the inline file was fully read by
11373 checking whether it is still open; detects whether it was read at
11374 all by checking whether the line number is greater than zero.
11376 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11377 interface. Functions reordered, comments changed. Not well
11378 tested, probably full of bugs.
11379 (init_file_handle) Removed initializers for obsolete fields, added
11381 (fh_close_handle) Much simpler, now mainly calls the class
11383 (fh_init_files) Renamed inline file internal filename.
11385 * file-type.c: Includes dfm.h.
11386 (read_from_file_type) Doesn't use dfm internal state anymore.
11388 * inpt-pgm.c, print.c: Include dfm.h.
11390 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11391 int in comparison with other int.
11393 * som-high.c: (build_target) Fixed operator precedence problem in
11394 if statement (& versus ==).
11396 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11398 * dfm.c: (read_record) Can now read fixed-length records; not
11400 (put_record) Can now write fixed-length records; not tested.
11402 * file-handle.h: FH_* defines changed to enums. New enum series
11404 (struct file_handle) New members recform, lrecl, mode.
11406 * file-handle.q: Parser changed.
11407 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11408 /LRECL subcommands. These are compatible with Windows.
11409 (init_file_handle) Initializes recform, mode fields.
11411 * q2c.c: (get_line) When outputting `!' comment lines, now
11412 increments the output file line number so that `#line' directives
11414 (make_identifier) New function that converts an arbitrary string
11415 into a valid C identifier.
11416 (dump_vars) Calls make_identifier() in two places in order to
11417 suppress some errors for bad identifiers.
11418 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11419 for NO. Allows numbers to be prefixed by underscores to make them
11420 acceptable C identifiers but still to be parsed as numbers by the
11423 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11425 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11427 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11428 was opened for writing.
11429 (open_file_w) New function.
11430 (read_record) Uses strncasecmp if available. Improved error
11431 messages, comments.
11432 (put_record) New function.
11434 * file-handle.h: Moved function comments into dfm.c and
11435 file-handle.q. Comment fixes. Removed declarations of
11436 tilde_expand() and normalize_filename().
11437 (struct file_handle) Changed `open' from boolean to enumerated
11438 field to allow for three states--closed, open for reading, open
11439 for writing--all references changed.
11441 * file-handle.q: Includes filename.h.
11443 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11444 references changed.
11445 (alloc_line) Makes allowance for line terminator characters in
11447 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11448 (print_space_trns_proc) Handles OUTFILE differences.
11450 * recode.c, sample.c: Comment fixes.
11452 * var.h: (struct print_trns) Changed boolean field `eject' to
11453 bitmapped field `options'; all references changed. New enums
11454 PRT_* for use with this field.
11456 * exception.h, test-exception.c: Removed.
11458 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11460 * ascii.c: (delineate) Turned off debug output.
11462 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11465 * data-in.c: (parse_string_as_format) Sets the entire string value
11466 to spaces, not just the short string part of it. Is this correct
11469 * data-out.c: (convert_date) Fixed DATETIME format problems with
11470 decimal places, removed debug code.
11472 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11473 middle of parsing BEGIN DATA that would cause the lexer to read
11474 from a wild pointer `prog'; now calls new function
11475 preprocess_line() in lexer.c.
11477 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11479 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11480 Now call induce_segfault() to induce the segfault.
11481 (induce_segfault) New function.
11483 * expr-opt.c: Comment fix.
11484 (parse_sysvar) New function.
11485 (parse_primary) Added system variable support--calls
11487 (global var ops) Added OP_CASENUM operator.
11489 * expr.h: Comment fixes.
11490 (OP_* enum) added OP_CASENUM operator.
11491 (struct casenum_node) New struct.
11492 (union any_union_union) New member `cas' of type `casenum_node'.
11494 * glob.c: (global var last_vfm_invocation) New var.
11495 (init_glob) Initializes last_vfm_invocation.
11497 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11499 * getline.c: (get_line) Split into get_line() and preprocess_line().
11500 (preprocess_line) New function.
11502 * var.h: Declares last_vfm_invocation.
11504 * vfm.c: (procedure) Sets last_vfm_invocation.
11506 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11508 * command.c: (parse_cmd) Fixed bad assertion related to
11511 * data-in.c: (parse_month) Implemented to parse months according
11512 to full interpretation of standard.
11513 (to_roman) New function.
11514 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11515 (parse_weekday) Bug fix (forgot to skip all the day name).
11517 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11518 up parsing of multirecord data items. Also fixed user message.
11520 * data-out.c: Comment fix.
11521 (year2, year4, convert_date, convert_time, convert_WKDAY,
11522 convert_MONTH) New functions to support time & date output.
11523 (convert_format_to_string) Calls new time & date output routines.
11525 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11527 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11530 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11532 * misc.c: (global var formats) Fixed declarations of DATETIME,
11535 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11536 the output_char buffer.
11538 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11539 memory bug. Fixed user messages.
11541 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11543 * Removed #pragma argsused from lots of places.
11545 * data-in.c: Implemented zoned decimal and time-date formats.
11546 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11549 * data-out.c: Implemented zoned decimal format.
11551 * expr.h: Moved yrmoda() declaration here from exprP.h.
11553 * misc.c: (global var formats) Minor fixes--added
11554 FCAT_SHIFT_DECIMAL to formats N and Z.
11555 (convert_fmt_ItoO) Added support for format Z.
11557 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11559 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11561 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11562 som_check_workspace() that is activated between commands.
11564 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11567 * list.q: (begin_row) Changed title expansion style from
11568 SOPT_X_VERT to SOPT_X_SHSP.
11570 * som-frnt.c: Now includes `somP.h'.
11571 (som_push_workspace, som_pop_workspace) New functions that, taken
11572 together, form a solution to the recursive table building problem
11573 mentioned yesterday. Surrounded every table output routine
11574 throughout the program with calls to these functions.
11575 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11576 (som_create_table) Checks that there's an active workspace.
11577 (som_destroy_all_tables, som_crush) Removed.
11579 * som-high.c: (global var som_preserve_tables) Removed, all
11580 references deleted.
11581 (som_submit_table) Checks that there's an active workspace.
11582 (dump_columnated_table) Doesn't columnate tables that would have
11583 just one row per column.
11584 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11585 (som_dump_crush_page) Moved row number labels from left side of
11586 tables to right side.
11587 (som_get_table_size) Added support for SOPT_X_SHSP.
11589 * som.h: New cell expansion type SOPT_X_SHSP.
11591 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11593 (global var curtab_arena) Moved from som-frnt.c.
11595 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11597 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11598 that causes bad location warnings to be suppressed.
11599 (delineate) Saves current font when calling draw_text(); fixed
11600 handling of NULLs when backing up. Also fixed line-wrapping bug.
11602 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11603 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11605 * common.c: Added code to cause assertion failure to dump core
11606 when run under Checker.
11608 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11609 there are still bugs.
11611 * glob.c: (__eprintf) Removed.
11613 * list.q: Inserted som_preserve_tables kluge that prevents tables
11614 from being thrown away due to recursive table building through
11615 som_output_line being called from a transformation during the LIST
11616 procedure invocation. This is a general problem that must be
11617 solved in a better way since it applies to all procedures in
11619 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11620 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11622 * numeric.c: Fixed several errors in the form of msg() calls.
11624 * print.c: Updated for use of som.
11625 (dump_table) Reimplemented.
11626 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11627 Calls som_output_text() instead of outs_line().
11629 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11631 (som_output_text) Function moved from som-low.c. Interface
11634 * som-high.c: (som_preserve_tables) New global public variable
11636 (som_submit_table) Destroys the tables only if som_preserve_tables
11638 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11639 one subrow per row. Now labels subrows if there's more than one
11641 (dump_crush_table) Added wishlist comment.
11642 (som_eject_page) New public function declared in som.h.
11644 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11645 more than one subrow per row.
11646 (som_output_text) Moved to som-frnt.c.
11648 * som.h: (SOM_TOPT_PRESERVE) Removed.
11650 * title.c: (get_title) Changed interface.
11651 (cmd_title) Changed `title' to `outp_title'.
11652 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11654 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11656 * list.q: (flush_table) Conforms to new partial options in
11657 som_submission_form.
11659 * som-high.c: (paginate_horizontally) Changed form of subrow
11661 (build_target) Omits spacing before table if
11662 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11663 (dump_crush_page) Changed interface. Only trims bottom rule if
11664 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11665 (dump_crush_table) Handles partial tables.
11666 (output_row_label) New function.
11667 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11668 rule on the right edge of narrow subrows.
11670 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11671 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11672 All references updated.
11674 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11676 * misc.c: Comment fix.
11678 * som-high.c: (examine_table) Treats crushed tables separates for
11679 purpose of determining header size.
11680 (paginate_horizontally) Allots space for line numbers in crushed
11681 tables with lots of subrows per row. Calculates the `maximum page
11682 width', the width of the widest horizontal page.
11683 (build_target) Removed trim argument; all references changed.
11684 Stricter assertions. (dump_crush_page) New function.
11685 (dump_crush_table) Reimplemented.
11687 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11688 (som_dump_crush_page) Reimplemented, interface changed.
11690 * somP.h: Many many new helper macros for use with crushed tables.
11691 (global var som) Removed `tv', `cum_y' members; all references
11692 removed. New members `mpw', `digit_space'.
11694 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11696 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11697 variable, changed to constant 1024.
11698 (arena_ca_strdup) Changed `sizeof(a_string)' to
11699 `sizeof(c_string)'.
11700 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11701 `(c_string *)' to `(char *)'; this fixed some offset problems.
11703 * filename.c: (readlink_malloc) Changed initial allocation from
11705 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11708 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11709 &fm->owner in several places.
11711 * som-high.c: (output_table) Changed interface to rest of world.
11712 (examine_crush_table) Removed. Crushed tables are re-broken now,
11713 in preparation for rewrite.
11715 * som.h: Comment fix.
11717 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11719 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11720 itself in the cleanup stage.
11722 * descript.q: (display) At least temporarily, changed the table
11723 format to a crushed table.
11725 * list.q: (begin_row) At least temporarily, added horizontal lines
11728 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11729 the horizontal "headers," that is, to the width of the far left
11730 and far right rules.
11731 (justify_pagination) Sets som.th to the width of the widest row
11732 in the crushed table. Fixed inner loop off-by-one error.
11734 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11737 * somP.h: Comment fix.
11739 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11741 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11742 before closing it; also, opens the constructed filename `s'
11743 instead of f->filename.
11745 * postscript.c: Moved initialization of x->loaded, x->prop,
11746 x->fixed, x->current, also the add_encoding() calls, into
11748 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11749 sets x->last_font to NULL; sets x->next_combo to zero.
11751 * som-high.c: (crushed_row_height) Moved definition farther up.
11752 (som_submit_table) Doesn't calculate line width, font size until
11753 after calling open_page(), to accomodate changes to PostScript
11755 (vert_headers) Removed; equivalent functionality moved to
11756 examine_table(), examine_crush_table().
11757 (justify_pagination) Replaced with different algorithm.
11758 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11759 at the bottom of the page.
11761 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11763 * command.c: Added cmd_list back into cmd_table.
11765 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11766 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11768 * list.q: (flush_table) Updated to new som_submission_form format.
11770 * som-frnt.c: Comment fix.
11772 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11773 (output_table) Calls som_get_table_size() directly; handles
11775 (examine_crush_table) New function; calls vert_headers().
11776 (examine_table) Moved some code into new function, vert_headers().
11777 (justify_pagination) New function.
11778 (dump_plain_table) Removed `static' from `cy'.
11779 (dump_crush_table) New function.
11781 * som-low.c: (som_dump_crush_page) New function.
11783 * som.h: Comment fixes.
11784 (enum SOM_TOPT_CRUSH) New.
11785 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11786 Temporarily set to zero to make do with LIST procedure.
11788 * somP.h: Re-ordering.
11790 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11792 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11794 * somP.h: New file for use by som-high.c, som-low.c.
11796 * q2c.c: Added definition for VME.
11797 (get_line) Now dumps `!' comment lines to the output file
11800 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11801 set.q: Changed format of `!' comment lines.
11803 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11805 * All source files: Added copyright notice.
11807 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11808 longs in msg() calls.
11810 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11812 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11814 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11816 * output.c: (outp_read_devices) Changed criteria for
11817 distinguishing different types of lines.
11819 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11821 * cmdline.c: Changed syntax message.
11823 * filename.c: (good_getcwd) Bug fix (?).
11824 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11826 (search_path) Appends DIR_SEPARATOR to directory name only if it
11827 does not already end with one.
11829 * glob.c: Checks STAT_PAGER envvar before PAGER.
11831 * output.c: Checks environment variables instead of just local
11834 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11836 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11837 when the pointer passed to the function was within the arena
11838 itself, so that it couldn't properly be set to NULL _after the
11841 * command.c: Re-enabled DISPLAY.
11843 * display.c: Rewritten to handle tables. Untested.
11845 * filename.c: (search_path) Fixed memory leak.
11847 * frequencies.q: (cmd_frequencies) Frees v_variables.
11848 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11849 (cleanup_freq_tab) New function to garbage collect.
11850 (dump_full) Elegantized.
11852 * main.c: New comment.
11854 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11856 * postscript.c: Comment fix.
11857 (release_fontmap, free_font_entry) New functions.
11858 (ps_init_driver) Sets free_font_entry() as the freefunc for
11859 hashtable `loaded'. Calls release_fontmap() when destroying a
11860 driver; also frees the output filename; also frees the
11861 ps_driver_ext block.
11862 (free_ps_encoding) Frees the filename as well as the encoding
11864 (output_encodings) Frees the line buffer and pops the msg-filename
11866 (read_fontmap) Frees the fontmap filename and the line buffer.
11867 (postopen, preclose) Misc. garbage collection fixes.
11868 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11869 to NULL; this fixes some output problems.
11870 (text) Handles TAG_NEWLINE. Untested.
11872 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11873 (som_set_string) Removed. All references changed to
11875 (som_set_text) Rewritten. New interface. More general.
11877 * som.h: Minor format changes.
11878 (struct som_value_cell) Removed; all references changed to
11880 (enums SOT_*) Changed.
11882 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11884 * command.c: Re-enabled SPLIT FILE.
11886 * postscript.c: Comment fix.
11888 * som.h: Added `SOT_NONE'.
11890 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11892 * vfm.c: (dump_splits) Reimplemented.
11894 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11896 * Compiled the project under gcc 2.7.2, which gave some new
11897 warnings. This led to many additions of casts from unsigned to
11898 int sprinkled throughout the code.
11900 * arena.c: Many uses of `unsigned' changed to `size_t'.
11902 * command.c: Added END FILE, END REPEAT to command table.
11903 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11904 (find_command, FILE_TYPE_okay) Not commented out anymore.
11905 (parse_cmd) Calls FILE_TYPE_okay again.
11906 (output_line) Added calls to som_output_text() to put the line
11907 in the output files.
11909 * common.c: (macro VME) Format changes.
11910 (xstrdup) Asserts that its argument is not NULL.
11912 * data-list.c: Implemented dump_fixed_table().
11914 * inpt-pgm.c: Formatting changes. Comment changes.
11915 (end_case_proc) Renamed end_case_trns_proc.
11916 (cmd_end_file, end_file_trns_proc) New functions.
11918 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11920 * misc.h: (local_strdup) New macro corresponding to strdup() but
11921 allocating its data through local_alloc() if possible--that is, if
11924 * postscript.c: Comment changes.
11925 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11926 (output_line, add_string) New macros supporting
11927 output_encodings().
11928 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11929 substitution vars. Calls output_encodings() when a line
11930 consisting of `!encodings' is encountered.
11931 (preclose) Some code moved into quote_ps_string().
11932 (dump_line) Changed into macro supporting dump_fancy_line().
11933 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11934 command when appropriate.
11935 (write_text) Fixed `literal_char' array (I think it's fixed, at
11937 (text) Fixed bug when width was zero. Now exits immediately on
11938 zero height_left. Now, when executing `goto restart;', checks
11939 that cp<end, so that we don't read beyond end-of-string. Also,
11940 outputs the correct code to the output file by outputting the code
11941 from the metric instead of the internal metric index.
11943 * repeat.c: (cmd_end_repeat) New function.
11945 * som.c: (var som) `headers' renamed `options' and semantics
11946 changed. All references changed.
11947 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11948 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11950 (som_text_table) Removed.
11951 (som_output_text) New function.
11953 * som.h: (struct som_submission_form) Removed `header', `reuse',
11954 replaced with bitmapped field `options'.
11955 (SOM_TOPT_*) New enum set for som_submission_form.options.
11956 (SOT_*) New enum set for som_output_text().
11958 * temporary.c: (copy_variable) When copying the var label, only
11959 calls xstrdup() if it's non-NULL.
11961 * var.h: (enum type `vartype') Removed; all references changed to
11964 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11967 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11969 * font.h: Comment changes.
11971 * groff-font.c: (groff_read_font) Initializes `name' field to
11972 NULL. Handles `encoding' field.
11974 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11976 * postscript.c: (struct font_entry) Removed `position' field.
11977 (struct ps_font_combo) New struct.
11978 (struct ps_driver_ext) Removed field `next_position'. New fields
11979 `combos', `next_combo'. `last_font' field changed from
11980 `font_entry *' to `ps_font_combo *'.
11981 (ps_init_driver) Reformatted; handles new fields. When
11982 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11984 (get_encoding, find_encoding_file) New functions.
11985 (add_encoding) Some code moved out into find_encoding_file().
11986 (postopen) Changed value for ${title}.
11987 (preclose) Sets `loaded' field to NULL after destroying the hash
11989 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11991 (ps_text_set_font_by_position) Figures out the current family if
11993 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11994 (switch_font) Implemented.
11995 (write_text) Calls switch_font() more often. Format changes.
11996 #undefs its macros after they're no longer useful.
11997 (text) Changed `continue' at one point to a jump to the top of the
11998 loop because we don't want `separate' reset to 0 at that point.
11999 (load_font) No longer sets `position' in the font_entry created.
12001 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
12003 * font.h: (struct font_desc) New member `encoding', which is not
12004 properly handled yet.
12006 * glob.c: (init_glob) Some new i18n code, which is probably
12009 * output.c: (outp_read_devices, outp_get_paper_size) Changed
12010 `size' local from `int' to `size_t'.
12012 * postscript.c: New driver configuration parameter `auto-encode'.
12013 New enums OPO_AUTO_ENCODE, ODA_COUNT.
12014 (struct font_entry) New member `position'.
12015 (struct ps_driver_ext) Reordered. New hash table member
12016 `encodings'; new members `next_position', `next_encoding',
12017 `last_font'. Members `current', `prop', `fixed' changed from type
12018 `font_desc *' to `font_entry *'; all references changed.
12019 (struct ps_encoding) New struct.
12020 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
12021 free_ps_encoding, add_encoding) New functions.
12022 (ps_init_driver) Added OPO_AUTO_ENCODE to default
12023 x->output_options. Initializes new members of ps_driver_ext.
12024 Changed default value for prologue_fn, encoding_fn. Calls
12025 read_ps_encodings after loading default fonts.
12026 (option_tab[], ps_option) Handle new configuration parameter.
12027 (switch_font) New function.
12028 (struct output_char) `font' member changed from `font_desc *' to
12029 `font_entry *'. New member `separate'.
12030 (read_fontmap) Changed `size' from `int' to `size_t'.
12031 (output_line, put_number) New macros for write_text().
12032 (write_text) Optimizes text output by consolidating multiple
12033 calls to PostScript `show' operator.
12034 (text) Keeps track of when text arguments can't be consolidated by
12035 write_text(), and marks those spots in the output stream.
12036 (load_font) Sets `position' of the allocated font_entry to -1, cuz
12037 the font hasn't been switched to by switch_font(), which is where
12038 the position is important--the PostScript is what cares about the
12041 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
12043 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
12044 call a NULL free_func.
12045 (hsh_rehash) Elegantized.
12046 (hsh_probe) Fix bug that manifested when the table was expanded
12047 and thus had to change location in memory. Good thing
12048 too--otherwise could have been much more subtle.
12049 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
12050 (hsh_foreach) New function for hash table iteration.
12052 * hash.h: (struct hsh_iterator) New.
12054 * lexer.c: (parse_tagged_quote) Font and family name strings in
12055 tags are now null-terminated.
12057 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
12059 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
12060 documented. (Never before tested?)
12062 * output.h: Comment changes.
12064 * postscript.c: New driver options `optimize-text-size',
12065 `optimize-line-size', `max-fonts-simult'. New enum set for
12066 specing cached line types. Comment fixes.
12067 (struct line_form) New struct.
12068 (struct ps_driver_struct) New members `text_opt', `line_opt',
12069 `max_fonts', `lines'.
12070 (ps_init_driver) Initializes new members of ps_driver_struct.
12071 (user option type enum set) New member `nonneg_int_arg'.
12072 (static var option_tab[]) Supports new options.
12073 (ps_option) Handles new options.
12074 (find_ps_file) Made static. No longer calls hsh_dump().
12075 (ps_get_var) Made static.
12076 (preclose) Dumps out proper DSC trailer.
12077 (ps_open_page) Elegantized.
12078 (ps_close_page) Calls dump_lines() if appropriate.
12079 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
12080 wrappers around line().
12081 (int_2_compare, compare_line, dump_line, dump_fancy_line,
12082 dump_lines, hash_line, free_line, line) New functions for support
12084 (write_text, text) Made static.
12085 (text) Added to font support, not finished.
12087 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
12089 * font.h: (struct font_desc) New members ascent, descent.
12091 * groff-font.c: (groff_read_font) Calculates font ascent and
12092 descent from the ascent and descent of the `d' and `p' characters,
12093 respectively, as per a suggestion on comp.fonts.
12095 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
12096 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
12098 (write_text) Handles text right-justification and centering (not
12099 full justification). Still very inefficient. (One output line
12101 (struct output_char) Added fields for font and font size.
12102 (text) Many bugfixes.
12104 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
12106 * cmdline.c: (usage) Calls outp_list_classes().
12108 * font.h: Comment fix.
12110 * groff-font.c: New exported global var `space_index'.
12111 (groff_init) New function to initialize `space_index'.
12112 (hash_kern) Casts result to unsigned.
12113 (font_name_to_index) Renamed font_char_name_to_index. All
12114 references changed. Also, now returns the value of `space_index'
12115 when passed an ASCII space character as an argument. Fixed
12117 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
12118 Handles passed NULL pointers properly.
12120 * lexer.c: (parse_tagged_quote) Comment fix. Better range
12123 * output.c: (outp_list_drivers) Removed. Removed all references.
12125 * output.h: Comment fixes.
12127 * postscript.c: (ps_open_global) Calls groff_init().
12128 (output_char) New structure.
12129 (write_text) New function.
12130 (text) No longer stubbed out! Now the output is correct--with a
12131 few exceptions, one of them being that the page has to be held
12132 upside down into a mirror.
12134 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
12136 * font.h: Comment fix.
12138 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
12139 All callers changed.
12140 (number_to_index) Renamed font_number_to_index, made extern. All
12142 (font_get_kern_adjust, font_get_char_metrics) New functions.
12144 * output.h: New constant OUTP_T_INTERNAL_DRAW.
12146 * postscript.c: Changed default line width back to 1/2 point.
12147 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
12148 in the center of the space allotted for them, not just a fixed
12149 offset from the edge of the space; this fixes some bugs.
12150 (ps_line_intersection) Now supports all command line styles.
12151 (ps_text_get_size) Bug fix in computation of em width.
12152 (text) New function, the meat behind ps_text_metrics and
12153 ps_text_draw. Not complete.
12154 (ps_text_metrics, ps_text_draw) Removed the stub taken from
12155 ascii.c; call text().
12157 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
12159 * arena.c: (arena_free) Assert that the argument is non-NULL.
12161 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
12162 only if old_kern is non-NULL.
12164 * postscript.c: (ps_init_driver) Changed default line width to 1
12166 (postopen) New prologue variables.
12167 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
12168 more of the common line styles properly, but not all.
12169 (ps_text_metrics) Fixed problem with this stubbed out version that
12170 kept it from taking font sizes into account.
12172 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
12174 * arena.c: (arena_malloc) Bug fix.
12175 (arena_dump) [GLOBAL_DEBUGGING] New function.
12177 * ascii.c: Comment fix.
12178 (count_fancy_chars, delineate) Now static functions.
12180 * filename.c: (interp_vars) Bug fixes.
12182 * font.h: Comment fixes.
12184 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
12185 beginning in case we have an error message to display before
12186 initializing the display.
12188 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
12190 (groff_read_font) Bug fixes.
12191 (name_to_index) Increments hash.used. Sets `name' field of hash
12193 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
12195 * hash.c: Return type changed.
12197 * postscript.c: Continued development. Now marks lines on the
12198 paper, but very buggy.
12200 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
12202 * Changed comments in many source files from `/* xxx /* yyy */' to
12203 `/* xxx */ /* yyy */' for cleanliness.
12205 * arena.c: (arena_sd_strdup) New function.
12207 * ascii.c: (struct ascii_driver_ext) New member `file'.
12208 (ascii_init_driver) Fills out member `file' for initing; uses
12209 close_file_ext for closing drivers.
12210 (ascii_option) Changed %.*s back to %s because the a_string's are
12211 always null-terminated.
12212 (postopen, preclose) New functions.
12213 (ascii_open_page) Uses new style of open_file_ext.
12214 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
12215 instead of this->output.
12216 (__assert_fail) Removed.
12218 * cmdline.c: Changed syntax_message[].
12220 * error.c: #include's <readline/history.h> only if the history
12221 library is available, not if just the readline library is
12224 * filename.c: (expand_line) Removed alloca() support.
12225 (interp_vars) No longer tilde-expands argument. Limit on output
12227 (tilde_expand) Now treats argument as path rather than filename.
12228 [!unix] Now is a no-op function.
12229 (search_path) Better verbose message formatting.
12230 (open_file, close_file) Comment fixes.
12231 (close_file) [!unix] Doesn't bother with pipes.
12232 (open_file_ext) Completely rewritten, interface revamped.
12233 (close_file_ext) New function.
12235 * font.h: Comment changes.
12237 * frequencies.q: Removed AIX alloca support since it doesn't use
12240 * hash.c: Comment changes & additions.
12241 (hsh_create) Initializes entire table instead of first M entries.
12242 (hsh_probe) Stupid bug fixed. Now it works.
12243 (hsh_dump) [GLOBAL_DEBUGGING] New function.
12245 * main.c: (parse) Detects EOF properly in token-eating loop.
12246 Should the STOP token have its value changed to 0?
12248 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12249 (blp_getline) Now it's a macro.
12251 * output.h: (struct outp_driver) Removed members output, filename.
12253 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12254 drivers in driver table.
12255 (outp_read_devices) Frees buf. Warns if there are no active
12257 (outp_configure_clear) Sets outp_configure_vec to NULL after
12258 deleting its elements.
12259 (configure_driver, destroy_driver) Removed references to output,
12260 filename members of outp_driver.
12261 (outp_evaluate_dimension, internal_get_paper_size,
12262 outp_get_paper_size) New functions.
12264 * postscript.c: Continued development. Now links but doesn't make
12265 any marks on the page. Lotsa bugs I suppose.
12267 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12269 * str.h: Comment changes.
12271 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12273 * Removed dependencies on non-nested comments in several files.
12274 Also removed references to (unix || __unix__) in #if's since
12275 prefh.orig makes those two equivalent.
12277 * ascii.c: (ascii_open_global) Creates ascii_arena.
12278 (ascii_close_global) Destroys ascii_arena.
12279 (ascii_init_driver) Doesn't create ascii_arena.
12280 (ascii_copy_driver) Removed.
12281 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12282 (outp_class ascii_class) Removed ascii_copy_driver reference.
12284 * frequencies.q: Now can display all statistics except median.
12285 Still not finished.
12287 * output.c: Handles outp_class.ref_count so output class
12288 destructors are called properly.
12289 (add_class) Sets ref_count to 0.
12290 (configure_driver) Initializes class if ref_count++ is 0.
12291 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12292 class output file name.
12294 * output.h: (struct outp_class) Removed copy_driver, inited.
12297 * postscript.c: Completely replaced but not finished.
12299 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12301 * approx.h: #includes <float.h>.
12303 * arena.h, arena.c: Many functions changed to take an arena **
12304 instead of an arena *, for consistency. All callers changed.
12305 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12306 (arena_destroy) Sets *A to NULL.
12308 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12309 assertion that `width' be positive.
12311 * command.c: Removed #if's from cmd_table.
12312 (walk_cmdtable_func) [0] New function (debug code).
12313 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12314 (parse_cmd) Doesn't return failure for unimplemented commands.
12316 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12317 (SYSCODE) New constant macro.
12319 * descript.q: Checks for positive n_variables before performing
12322 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12323 avl_find instead of &fp as arg 2.
12325 * frequencies.g, frequencies.q: Continued updating; now compiles &
12326 works again, but not complete.
12328 * main.c: Changes to user messages.
12330 * misc.c: (reverse) [0] New function.
12332 * settings.h: Comment removed. #includes "common.h".
12334 * som.c: (som_set_null) New function.
12335 (som_set_value, som_set_string, som_set_text) More detailing
12337 (som_set_float) Implemented function.
12338 (dump_columnated_table) Bug fix regarding page breaks.
12339 (draw_cell) Bug fix regarding text that spilled out of a cell.
12340 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12342 (get_cell_size) Support SCON_EMPTY cells.
12343 (get_table_size) When calculating rules' widths and heights, mask
12344 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12346 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12348 (struct som_submission_form) New member `header'; all users
12351 * val-labs.c: (get_label) User messages changed.
12353 * var.h: Changed FREQUENCIES structures.
12355 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12358 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12360 * approx.h: Definition of EPSILON now depends on system's
12361 DBL_EPSILON. Removed GNU C specific code.
12362 (cmpapx) Renamed approx_compare.
12364 * frequencies.g, frequencies.q: Continued updating; still doesn't
12367 * groff-font.c: (name_to_index) Fix bug that kept it from
12370 * hash.c, hash.h: Completed work.
12372 * var.h: Changes to freq_tab, frequencies_proc.
12374 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12377 * hash.c, hash.h: New files. Not completed.
12378 * Makefile.am: Added hash.c to source file list.
12379 * font.h: (struct font_desc) New member kern_size_p.
12380 * groff-font.c: Uses hash.h.
12381 (hashpjw) Moved to hash.c.
12382 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12384 (static var hash) New member size_p.
12385 * var.h: Includes hash.h.
12386 (struct freq_tab) Changed AVL_TREE to hash_tab.
12388 * vars-prs.c: Comment, formatting fixes.
12390 * frequencies.g, frequencies.q: Continued updating. Not yet
12393 * formats.c: Bug fix.
12395 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12397 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12398 * descript.g: Comment fixes.
12399 * descript.q: Comment fixes. Moved some declarations into var.h.
12400 Made dsc_info a static table. Updated FIXMEs.
12401 (internal_cmd_descriptives) Beautified.
12403 * frequencies.q: Started updating into working order.
12404 * frequencies.g: New file analogous to descript.g.
12405 * var.h: Comment fixes. Added structures for FREQUENCIES.
12407 * som.c: Removed vestiges of crushing and partial table support.
12409 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12411 * Many more changes to som.c especially, but these will not be
12412 documented as I have resolved to remove them. This patchlevel is
12413 being released solely so that I can fall back to it if I decide
12414 that removing the changes is not a good idea.
12416 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12418 * som.c: (global var som) New member `cum_y'.
12419 (build_target) Properly handles titles for partial tables.
12420 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12421 Merged into single new function dump_partial(). Fixed problem
12422 with titles on partial tables.
12423 (dump_table) Calls dump_partial() for all parts of partial tables.
12424 (dump_page) Criteria for drawing title changed.
12426 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12428 * command.c: (cmd_table) Added LIST, WEIGHT.
12430 * command.c: (cmd_remark) No longer frees `s' since it's not
12431 dynamically allocated.
12433 * data-out.c: (convert_f) Now correctly handles the case where
12434 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12435 number of decimals.
12436 (som_destroy_all_tables) Removed argument. All callers changed.
12437 (som_vline, som_hline) Argument validity checking corrected.
12438 (som_set_value) Implemented half-heartedly.
12439 (replicate_table) Copies tables piece-by-piece when using Checker.
12441 * som.h: New line style SLIN_1THIN, currently equivalent to
12442 SLIN_0. New enum set SOM_SUB_*.
12443 (struct som_submission_form) Removed `seq_no'. Added `type'.
12445 * list.q: Newly working file; uses partial tables.
12447 * som.c: (som_reduce_table) Renamed som_set_table_height().
12448 (som_crush) Removed argument `group'.
12449 (global var som) Removed `nt', `seq_no'. Added `type'.
12450 (som_submit_table) Arguments changed.
12451 (output_table) Removed partial table code.
12452 (build_target) New arg; partial table support added. All callers
12454 (dump_plain_table) Removed partial table code.
12455 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12456 (dump_table) Supports partial tables.
12457 (dump_page) New argument to allow not drawing top and/or bottom
12458 headers. All callers changed. Supports partial tables.
12460 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12462 * data-out.c: Changed `#include <approx.h>' to `#include
12464 (convert_F) Comment fix. Now won't print `-.000', etc.
12466 * descript.q: Now Z-scores work, although there appears to
12467 be a bug (which might actually be in data-out.c:convert_F()).
12468 (descriptives_trns_proc, descriptives_trns_free) New functions.
12469 (run_z_pass) Implemented.
12471 * var.h: Comment fixes.
12472 (dsc_z_score, descriptives_trns) New structs.
12473 (descriptives_trns) Added to any_trns as `dsc'.
12475 * error.c, error.h: New error class, IS (Installation Script
12476 error), used in those instances where the error is in the
12477 installation, but there is a script file or installation file that
12478 can be usefully referred to.
12480 * output.c: Change many IE classes to IS classes.
12482 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12483 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12484 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12485 include the corresponding header?
12487 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12488 Don't bail out if termcap can't be read.
12490 * som.c: (som_destroy_table) Removed.
12491 (som_reduce_table, som_destroy_all_tables) New functions.
12492 (som_crush) New function, not implemented.
12494 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12495 som_submission_form. Function prototypes revised.
12497 Outputting huge tables (1000s of rows) a few rows at a time
12498 is supported, though untested. May even break everything.
12499 Actually, the code doesn't even compile right now.
12500 * som.c: (struct som) New fields htv, nt, seq_no.
12501 (som_submit_table) Multiple arguments changed to a single
12502 pointer to struct submission_form. Only increments subtable_num
12503 if seq_no is zero. Only destroys table if it's not going to
12505 (replicate_table) New function.
12506 (output_table) Comment fix.
12507 (examine_table) Changed inline code to code calling
12508 replicate_table(). Calculates htv. Supports partial tables.
12509 (draw_title) Removed comment.
12510 (build_target) Only allows for title on first part of partial
12512 (dump_plain_table) Only resets table chunk number on first part
12513 of partial tables; FIXME: doesn't work quite right. Supports
12515 (dump_page) Titles only on first part of partial tables.
12517 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12519 * Thanks to an unreliable IDE hard drive, I have spent the last
12520 day reconstructing my Debian GNU/Linux installation and redoing
12521 the previous day's changes--somehow I managed to save every file
12522 except for output.c and output.h. So the following changes could
12523 really be considered independent of the output.c, output.h changes
12526 * output.h, output.c: Moved the outp_configure_vec global var,
12527 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12528 outp_configure_vec is now static.
12530 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12532 * The entire philosophy behind configuration of the output drivers
12533 changed. Now there is a termcap-type configuration where drivers
12534 to be read are determined beforehand, rather than parsing the
12535 entire output init file and storing it in memory & deciding what
12536 to actually use later. Faster & more memory-efficient at the same
12539 * output.c: Comment fix. Removed outp_init_drivers global var.
12540 Removed all references to synonyms. New structure outp_defn. New
12541 global vars outp_macros, outp_configure_vec.
12542 (search_name, delete_name, add_name, check_configure_vec,
12543 expand_name, find_defn_value) New static functions.
12544 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12545 outp_read_devices) New extern functions.
12546 (outp_init) Much functionality moved into outp_read_devices.
12547 (outp_read_devices) Format of output init file changed; name of
12548 file is `devices' rather than `output' to avoid Makefile
12550 (outp_clear) Renamed outp_done.
12551 (outp_list_classes) Bug fix, cleaned up.
12552 (outp_list_drivers) Not implemented anymore.
12553 (outp_configure_driver) Now a static function; simplified; now
12554 interpolates macros; supports new structure.
12555 (outp_enable_driver, match_synonym) Removed; all references
12557 (find_driver) First argument removed.
12559 * output.h: Global var outp_init_drivers removed; new structure
12560 outp_names; new enum set OUTP_S_*; new global var
12561 outp_configure_vec; function prototypes for output.c exports
12564 * main.c: (main) Calls outp_read_devices() after parsing the
12567 * cmdline.c: (parse_command_line) New option -v --verbose;
12568 --version changed to -V. --device option changed syntax to just
12569 take a single device name. Accepts key=value declaration of
12570 output init file macros. Syntax message updated.
12572 * filename.c: (expand_line) New function.
12573 (interp_environ_vars) Renamed interp_vars; no longer uses
12575 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12576 overridden by real environment vars.
12577 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12578 * filename.h: interp_environ_vars() renamed interp_vars().
12580 * error.c, error.h: Added extern variable `verbosity', message
12583 * error.c: (vmsg) Support message class MM.
12584 (verbose_msg) New function.
12586 * descript.q: (generate_z_varname) Bug fix in generation of
12588 (dump_z_table) Bug fix in column headers.
12590 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12591 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12592 OPS_DONE]. Writes the uninit string when the driver is closed.
12593 (ascii_open_page) Write the init string before the first page.
12594 (output_shorts) Form of main loop changed from `while' to `for'.
12595 Bug fix with overstrikes: the character is printed *after* the
12596 backspace. Eliminated a lot of `& 0xff' modifiers.
12597 (advance_to_left_margin) New function.
12598 (return_carriage, output_lines) Handle left margin.
12600 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12602 * ascii.c: New option `carriage-return-style'.
12604 * ascii.c: (count_fancy_chars) New function.
12605 (delineate, text_metrics) Use new function; bug fixes regarding
12607 (text_draw) Bug fix with rich text.
12608 (output_string, output_shorts) Reordered.
12609 (output_shorts) Now handles boxchars and some overstrike font
12611 (output_char, return_carriage) New functions.
12612 (output_lines) Now handles overstriking and font changes properly;
12613 some code moved to output_shorts.
12615 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12618 * ascii.c: New member `debug' in ascii_driver_ext.
12619 (ascii_init_driver, delineate) Uses new member.
12621 Now you can set a vertical height on writing text.
12622 * ascii.c: (delineate) Keeps track of vertical position.
12623 (text_draw) No longer considers fully justified text an internal
12626 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12628 Tables' titles are drawn; they can have variable height.
12629 * som.c: `som' struct has new member, title_height.
12630 (draw_title) New argument. Moved within file. All caller
12632 (build_target) New argument, amount of space needed for first row.
12633 Calculates height of title, takes that into account. All callers
12635 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12637 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12639 (dump_columnated_table) Organized for readability.
12640 (dump_page) Makes use of som.title_height.
12642 * som.c: Many comment bug fixes.
12644 * descript.q: (try_name, generate_z_name) Bug fix regarding
12645 generation of Z-score variable names.
12646 * var.h: Removed num from descriptives_proc; all referents removed.
12648 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12650 * ascii.c: (ascii_line_horz, ascii_line_vert,
12651 ascii_line_intersection) Added debugging code.
12653 Added a descriptive line above each table to describe it.
12654 * command.c: (parse_cmd) Calls som_new_series.
12656 * som.c: New static vars table_num, subtable_num. New `som'
12658 (dump_page) New arguments.
12659 (som_submit_table) Handle new variables.
12661 * som.c, som.h: (som_submit_table) New arguments. All callers
12663 (som_new_series) New function.
12664 (build_target) Makes room for extra line.
12665 (draw_title) New function.
12666 (dump_page) Calls draw_title. Bug fix: doesn't always set
12669 Columnation of tables support.
12670 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12672 * som.c: Deleted references to fr, lr, ri.
12673 (som_columnate) Bux fix: sets group member of table.
12674 (som_add_options) Function removed.
12675 (dump_table) Split into three functions; extensively reworked.
12677 * descript.q: (dump_z_table) Better output table formatting; added
12678 title support to correspond to som.h changes.
12679 (display) Title support.
12681 * output.h: Added OUTP_T_NONE.
12683 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12685 * descript.q: Improved handling of Z scores; still not perfect.
12687 * output.h, ascii.c: Added hook for getting em width of current
12690 * som.c: Uses new em-width hook. Added debugging code to
12692 (som_columnate) New argument.
12693 (som_add_options) Removed.
12695 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12697 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12698 rules as a property of the table instead of as a property of the
12701 * ascii.c: Added `header' to table of options.
12703 * descript.q: Added even shorter statistic names; modified to work
12704 with new som interface.
12706 * misc.c (blp_getdelim): Bug fix.
12708 * version.c: includes 'conf.h'.
12710 ----------------------------------------------------------------------
12713 version-control: never
projects / pspp-builds.git / blob