1 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3 Got rid of approx.h. In general, replaced all references to
4 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
7 * Makefile.am: (pspp_SOURCES) Removed approx.h.
9 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
10 test for mag < EPSILON.
12 * misc.h: Add definition of EPSILON.
14 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
16 * vfm.c: (procedure) Add check to prevent recursive call.
18 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
20 * Moved the declarations relating to values to their own header file
23 * Added levene.c and levene.h
25 * vars-atr.c: Changed the signature of compare_values to
26 take const * arguments.
28 * t-test.q: Changed the structure of struct t_test_proc
29 variables now contain their own group statistics information.
30 Eventually, t_test_proc might get renamed, because it'd be
31 applicable to other commands too.
33 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
35 * data-out.c: Clean up. Changed interface of convert_*() to take
36 either a `double' or a `const char *' instead of a `const union
37 value *'. Update all implementations of those interfaces.
38 (data_out) Use switch statements instead of a table.
39 (convert_AHEX) Rewrite.
41 * format.h: Update comment.
43 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
45 * q2c.c: (dump_header) Add an Emacs header line to output files
46 that makes generated .c files read-only by default, to make it
47 difficult to accidentally change generated files.
49 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
51 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
52 not bogus a->v.c <=> b->v.c pointer compare.
53 (compare_freq_alpha_a) Ditto.
54 (compare_freq_numeric_d) Ditto.
55 (compare_freq_alpha_d) Ditto.
57 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
59 Changed data_out() to store string data directly into a `union
60 value''s s member, not indirectly into c.
62 * crosstabs.q: (output_pivot_table) Use format_short() instead of
64 (table_value_missing) Ditto.
65 (float_M_suffix) Ditto.
66 (format_short) New function.
68 * data-in.h: (data_in_finite_line) Remove inline definition.
70 * data-list.c: (destroy_dls_var_spec) New function.
71 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
72 (data_list_source_destroy_source) Avoid cast.
73 (struct repeating_data_trns) New field `id_value'. Update
75 (cmd_repeating_data) Initialize id_value. Use new
76 repeating_data_trns_free() for freeing REPEATING DATA
78 (rpd_parse_record) Rewrite support for record ID to be less bogus.
79 (repeating_data_trns_free) New function.
81 * data-out.c: (data_out) Change return type to `void' by replacing
82 error returns by writing a message into the output buffer.
83 (convert_A) Read from v->s instead of v->c.
86 * expr-evl.c: Update comment.
87 (expr_evaluate) Add assertion in OP_STRING case.
89 * format.h: (macro MAX_FORMATTED_LEN) New macro.
91 * list.q: (list_cases) Update for new data_out() semantics.
93 * print.c: (print_trns_proc) Ditto.
95 * tab.c: (tab_value) Ditto.
96 (tab_float) Avoid stupid cast.
98 * var.h: Update comments.
99 (macro MAX_STRING) New macro.
100 (macro MAX_ELEMS_PER_VALUE) New macro.
102 * vars-atr.c: (compare_values) New function.
104 * vfm.c: (dump_splits) Update for new data_out() semantics.
106 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
108 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
110 (struct crosstab) Rename v[] to vars[]. All references updated.
111 (hash_table_entry) Replace the hash algorithm and fix a bug at the
112 same time, which caused the hash value to depend only on a single
113 value, not all of the variables' values.
115 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
117 Clean up struct dictionary's value_cnt usage.
119 * dictionary.c: Add a function comment to each function.
120 (struct dictionary) Rename value_cnt to next_value_idx, which more
121 accurately reflects its meaning. All references updated.
122 (dict_rename_vars) Add assertion.
123 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
125 (dict_get_case_size) New function.
127 * aggregate.c: (create_sysfile) Use dict_get_case_size().
129 * get.c: (mtf_read_nonactive_records) Ditto.
131 * sort.c: (allocate_cases) Ditto.
132 (write_initial_runs) Ditto.
136 * vfm.c: (prepare_for_writing) Ditto.
140 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
142 Make vfm.c slightly less grotesque.
144 * vfm.c: (filter_var) Removed.
145 (filter_index) Removed.
146 (FILTERED macro) Removed.
147 (exclude_this_case) New function.
148 (process_active_file_write_case) Use exclude_this_case() instead
149 of FILTERED and inline tests.
150 (procedure_write_case) Ditto.
151 (setup_filter) Removed.
152 (open_active_file) Don't call setup_filter().
153 (close_active_file) Call dict_get_filter() instead of checking
156 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
158 * var.h: (struct variable) Update comments.
160 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
162 New functions dict_create_var_assert(), dict_lookup_var_assert().
163 Converted several dict_*_var()/assert pairs into a single
166 * dictionary.c: (dict_create_var_assert) New function.
167 (dict_lookup_var_assert) New function.
169 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
171 Got rid of "struct long_vec", envector(), devector(), etc. Added
172 two members `init', `reinit' to struct variable as a substitute.
174 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
180 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
183 * autorecode.c: (cmd_autorecode) destvars don't need init.
185 * compute.c: (lvalue_finalize) Set reinit.
187 * data-list.c: (fixed_parse_compatible) Don't need init usually.
188 (dump_fmt_list) Ditto.
191 * descript.q: (run_z_pass) Don't need init for z-scores.
193 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
195 (dict_clone_var) Copy `reinit' member, initialize `init' member.
197 * glob.c: (init_glob) Remove vec_init() calls.
199 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
201 * loop.c: (internal_cmd_loop) Don't need to call envector().
203 * numeric.c: (cmd_numeric) Ditto.
205 (cmd_leave) Ditto. Set `init', `reinit' members.
207 * recode.c: (cmd_recode) Don't need to call envector().
209 * repeat.c: (internal_cmd_do_repeat) Ditto.
211 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
212 (force_create_variable) Removed prototype.
213 (force_dup_variable) Ditto.
215 * vector.c: (cmd_vector) Don't need to call envector().
217 * vfm.c: (reinit_sysmis) Removed.
218 (reinit_blanks) Removed.
220 (init_blanks) Removed.
221 (process_active_file_write_case) No need to deal with vectors.
222 Call clear_temp_case().
223 (vector_initialization) Rewrite to use `init', `reinit'.
224 (close_active_file) No need to call vec_clear().
225 (procedure_write_case) Call clear_temp_case().
226 (clear_temp_case) New function.
228 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
230 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
233 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
235 Add auxiliary argument to procedure() interface. Associated small
236 clean-ups of vfm interface.
238 * Updated every caller of procedure() and process_active_file() to
239 reflect modified interface. Simple, ordinary changes not listed
242 * Updated every function that implements struct case_stream's
243 `read' function to take a write_case_func and a write_case_data.
244 Also updated every caller of write_case() to instead call them
245 through these arguments. In some cases this meant that the extra
246 args had to be threaded through a couple of extra levels. This
247 wasn't difficult or interesting so the details won't be given.
249 * data-list.c: (struct repeating_data_trns) Add members
250 `write_case', `wc_data' as kluge.
251 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
253 (repeating_data_set_write_case) New function.
255 * data-list.h: New file to declare repeating_data_trns_proc() and
256 repeating_data_set_write_case().
258 * inpt-pgm.c: (input_program_source_read) Call
259 repeating_data_set_write_case() for all the REPEATING DATA
260 transformations, so that they know where to send their cases.
261 It's a big kluge. Also kluge in END CASE.
262 (end_case_trns_proc) Never called anymore, but we still need it,
265 * sort.c: (read_sort_output) Update to match struct case_stream
268 * vfm.c: (struct write_case_data) New structure.
270 (virt_proc_func) Removed.
271 (begin_func) Removed.
272 (virt_begin_func) Removed.
274 (write_case) Removed.
275 (procedure) Added an auxiliary parameter to each function pointer
276 argument's prototype. Added an auxiliary data parameter.
278 (process_active_file) Ditto.
279 (process_active_file_write_case) Pass aux data along.
280 (close_active_file) Ditto.
281 (procedure_write_case) Ditto.
282 (SPLIT_FILE_procfunc) Ditto.
284 * vfm.h: (typedef write_case_data) New.
285 (typedef write_case_func) New.
286 (struct case_stream) Add parameters to `read' member prototype.
288 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
290 * t-test.q: Added calculations for independent samples. (But no Levene
293 * Makefile.am: Moved q_sources_c into own variable
295 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
297 Miscellaneous cleanups.
299 * Change unused to UNUSED in many source files to reflect modified
300 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
301 __CYGWIN32__, __unix__, and unix not to assume that they're
302 defined to a nonzero value. Change use of __attribute__ to use
303 NO_RETURN or PRINTF_FORMAT instead.
305 * alloc.h: Move definitions for local_alloc(), local_free() here
306 from ../pref.h.orig and simplify.
308 * expr-evl.c: Instead of working differently based on PAGED_STACK,
309 use a pool allocator unconditionally.
310 (CHECK_STRING_SPACE) Removed.
311 (ALLOC_STRING_SPACE) Removed.
312 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
315 * expr-opt.c: (dump_expression) Allocate string pool.
317 * expr-prs.c: (expr_free) Free string pool.
319 * pool.c: (pool_destroy) This pool must be removed from its
320 parent's list of gizmos, not from its own. Use free_all_gizmos().
321 (pool_clear) New function.
322 (free_all_gizmos) New function.
323 (pool_alloc) Use space in empty block after this one if any.
324 (pool_release) Only empty out blocks, don't actually free() them.
326 * print.c: Get rid of PAGED_STACK special case by always
327 dynamically allocating line buffers.
328 (struct print_trns) Always include the `line' member.
329 (internal_cmd_print) Always initialize the `line' member.
330 (alloc_line) Always allocate memory for `line'.
331 (print_trns_proc) Always initialize buf from `line' member.
332 (print_trns_free) Always free `line' memory.
334 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
337 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
339 * flip.c: Fixed crash from FLIP when a numeric variable is
340 specified on NEWNAMES and a large value is used, and a couple of
341 other minor bugs besides.
342 (struct varname) Make name a 9-character fixed-size array
343 instead of a 1-character variable size array.
344 (make_new_var) Allow digits in variable names.
345 (flip_stream_write) Limit numeric values to 8 characters and
346 format system missing and very large and small values more
349 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
351 * command.c: Fixed test on command return status for the correct
352 value, which had been causing a crash under certain invalid input.
354 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
356 * t-test.q: Added calculations for the one sample variant of the T-TEST
358 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
360 * tab.c: (render_strip) Fix bug that sometimes caused joined text
361 in joined cells to be rendered outside box boundaries.
363 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
365 * random.c (rng_create): Fixed seeding so that it gets reseeded after
366 SET seed=xx has been called.
368 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
370 * random.c (rng_get_double): Fix always-returning-zero bug in my
371 preferred way, and at the same time make sure rounding doesn't
374 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
376 * html.c: (change_attributes) Dead code, removed.
377 (escape_string) Eliminate code to call change_attributes() that
378 never actually called it.
379 (output_tab_table) Get rid of dependence on tab_hit
380 and struct tab_joined_cell's hit member, which are abominations.
382 * tab.c: (tab_output_text) Don't call
383 d->class->text_set_font_by_name if it's a null pointer.
384 (macro UNROLL_LOOP) Eliminate.
385 (macro UNROLL_3_LOOPS) Eliminate.
386 (tabi_render) Rewrite not to use the above macros.
388 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
390 Start working on a new output driver system, one that doesn't suck
391 so much, by adding a "device-independent" output driver. The idea
392 is to write out only a single output stream, then use separate
393 processes to translate them into whatever formats we want. This
394 is similar to how "groff" works with its various output drivers
395 (grops, grotty, grodvi, ...).
397 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
399 * list.q: (write_all_headers) Stub out devind class.
401 (determine_layout) Ditto.
404 * output.c: (outp_init) Add devind class.
406 * devind.c: New file.
408 * devind.h: New file.
410 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
412 * frequencies.q: (hash_value_alpha) Fixed up the previous change
413 to use the proper string length.
415 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
417 * Fixed bug where FREQ would crash on alpha values
419 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
421 * Removed bletcherous alloca() workarounds for AIX from top of
422 many files. AIX can use the alternative alloca() implementation
425 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
427 * ascii.c: (ascii_option) Fix implementation of headers option.
429 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
431 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
432 multiple blank lines into one.
433 (struct ascii_driver_ext) Add squeeze_blank_lines option.
434 (ascii_preopen_driver) Initialize squeeze_blank_lines.
435 (static var option_tab) Add squeeze entry.
436 (ascii_option) Set squeeze_blank_lines.
437 (output_lines) Implement squeezing blank lines.
439 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
441 * Removed redundant code from output.h
443 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
445 Dictionary classes: each variable is "ordinary", "system", or
448 * var.h: (enum dict_class) New enum.
450 * vars-prs.c: (dict_class_from_id) New function.
451 (dict_class_to_name) New function.
453 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
455 * var.h: (struct freq_tab_set) Removed (not used).
457 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
459 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
461 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
463 * stats.c: (hypercube) Rename pow4(). All references updated.
465 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
467 * rename-vars.c: (cmd_rename_variables) Rewritten.
468 (compare_name) Removed.
470 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
472 var_set feature, and code taking advantage of it.
474 * crosstabs.q: (static var var_dict) Removed.
475 (static var variables) New variable.
476 (static var variables_cnt) New variable.
477 (cmd_crosstabs) Free variables instead of var_dict.
478 (internal_cmd_crosstabs) Initialize and use variables,
479 variables_cnt instead of var_dict.
480 (free_var_dict) Removed.
481 (crs_custom_tables) Use var_set instead of a copied dictionary.
482 (crs_custom_variables) Set up variables, variables_cnt instead of
484 [DEBUGGING] (debug_print) Ditto.
486 * means.q: (mns_custom_tables) Use var_set instead of a copied
489 * vars-prs.c: (parse_vs_variable) New function.
490 (parse_dict_variable) Rewritten.
491 (parse_variable) Rewritten.
492 (parse_variables) Renamed parse_var_set_vars(), rewritten.
493 (parse_variables) New function in terms of parse_var_set_vars().
494 Now requires its first argument to be non-null. All references
495 that passed a null pointer updated to pass default_dict instead.
496 (macro id_dict) Removed.
497 (parse_DATA_LIST_vars) Add assertions.
498 (parse_mixed_vars) Ditto.
499 (struct var_set) New structure.
500 (var_set_get_cnt) New function.
501 (var_set_get_var) New function.
502 (var_set_lookup_var) New function.
503 (var_set_destroy) New function.
504 (dict_var_set_get_cnt) New function.
505 (dict_var_set_get_var) New function.
506 (dict_var_set_lookup_var) New function.
507 (dict_var_set_destroy) New function.
508 (var_set_create_from_dict) New function.
509 (struct array_var_set) New structure.
510 (array_var_set_get_cnt) New function.
511 (array_var_set_get_var) New function.
512 (array_var_set_lookup_var) New function.
513 (array_var_set_destroy) New function.
514 (var_set_create_from_array) New function.
516 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
517 instead of parse_variables(NULL, ...) in output code.
519 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
521 Change inp_init from a 2-bit vector to an ordinary array.
522 Initialize it all in cmd_end_input_program() instead of in
525 * inpt-pgm.c: (enum value_init_type) New enum.
526 (global var inp_init) Change to `enum value_init_type *', make
528 (inp_init_size) Removed.
529 (inp_nval) Change to `size_t', make static.
530 (cmd_input_program) Don't initialize inp_init or inp_init_size.
531 (cmd_end_input_program) Initialize inp_init, inp_nval.
533 (clear_case) Rewrite.
535 * inpt-pgm.h: Removed.
537 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
539 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
540 Colin Plumb hash. It is simpler and should better resist
542 (hsh_hash_string) Ditto.
544 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
546 * get.c: (export_write_case_func) Remove debug printing code.
548 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
550 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
552 (save_write_case_func) Use &trns->h instead of cast.
553 (cmd_export) Use &t->h instead of cast.
555 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
557 Moved vectors into the dictionary.
559 * var.h: (struct vector) Moved here from vector.h. `index' member
560 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
565 * vector.c: (global var vec) Removed.
566 (global var nvec) Removed.
567 (cmd_vector) Rewritten.
568 (find_vector) Removed.
570 * dictionary.c: (dict_create_vector) New function.
571 (dict_get_vector) New function, replaces reading global vec[]
573 (dict_get_vector_cnt) New function, replaces reading global nvec
575 (dict_lookup_vector) New function, replaces find_vector().
576 (dict_clear_vectors) New function.
578 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
580 Start to move away from `struct variable' p `union' member to void
583 * var.h: (struct variable) Add `aux' member.
585 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
587 Get rid of struct variable `foo' member.
589 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
591 (frq_custom_variables) Ditto.
592 (frq_custom_grouped) Ditto.
594 * get.c: (struct save_trns) Change `var' member from `int *' to
595 `struct variable **'.
596 (cmd_save_internal) Use aux instead of foo.
597 (save_trns_proc) Use revised `var' member.
598 (static var mtf_seq_no) Renamed mtf_seq_num.
599 (static var mtf_seq_nums) New static var.
600 (cmd_match_files) Initialize mtf_seq_nums.
601 (mtf_free) Free mtf_seq_nums.
602 (mtf_processing) Use mtf_seq_nums instead of foo.
603 (mtf_merge_dictionary) No need to initialize mv->foo.
604 (cmd_export) Use aux instead of foo. Use revised `var' member.
605 (mns_custom_tables) Don't use foo to check for duplicates, that's
606 what PV_NO_DUPLICATE is for.
608 * var.h: (struct variable) Remove `foo' member.
609 (struct frequencies_proc) New member.
611 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
613 Clean up COMPUTE and IF.
615 * compute.c: More or less rewrite the darn thing.
616 (struct compute_trns) Rename and reorder and add and delete
618 (cmd_compute) Rewrite.
619 (compute_num) Make conditional on test expression. Now used for
621 (compute_num_vec) Ditto.
623 (compute_str_vec) Ditto.
626 (if_num_vec) Removed.
628 (if_str_vec) Removed.
629 (parse_target_expression) Renamed parse_rvalue_expression(),
631 (new_trns) Renamed compute_trns_create(), rewritten.
632 (delete_trns) Removed.
633 (free_trns) Renamed compute_trns_free(), rewritten.
634 (struct lvalue) New structure.
635 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
636 (lvalue_get_type) New function.
637 (lvalue_is_vector) New function.
638 (lvalue_finalize) New function.
639 (lvalue_destroy) New function.
641 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
643 * command.def: Disallow MODIFY VARS in input mode, so that
644 variables can't get dropped and confuse cmd_end_input_program()'s
645 attempt to fill inp_init[].
647 * modify-vars.c: (static var forward_positional_ordering) New
649 (struct var_modification) Entirely changed.
650 (rearrange_dict) Interface changed, rewritten.
651 (cmd_modify_vars) Deal with modified struct var_modification, much
653 (struct var_renaming) New structure.
654 (compare_var_renaming_by_new_name) New function.
655 (validate_var_modification) New function.
657 * var.h: (struct modify_vars_proc) Removed.
658 (struct variable) Removed member p.mfv.
660 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
662 Make EVALUATE a valid command whether we're debugging or not, so
663 that `make check' can succeed regardless of whether debugging is
666 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
668 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
670 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
672 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
673 statement by a simple if test.
675 * dfm.c: (dfm_get_record) Add assertion.
677 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
679 For each file x.c, move #include "x.h" to the very top of the
680 include list, to catch x.h failing to include the proper headers.
682 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
684 * algorithm.c: (find) New function.
685 (remove_equal) New function.
686 (set_difference) New function.
687 (adjacent_find_equal) New function.
688 [TEST_UNIQUE] Removed test case.
689 (copy_if) Find end test.
691 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
693 * dictionary.c: (dict_get_case_weight) New convenience function.
695 * aggregate.c: (accumulate_aggregate_info) Use
696 dict_get_case_weight().
698 * frequencies.q: (calc_general) Ditto.
699 (calc_integer) Ditto.
702 * t-test.q: (groups_calc) Ditto.
705 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
707 * glob.c: (global var default_dict) Change from `struct
708 dictionary' to `struct dictionary *'. All references changed.
709 (init_glob) Initialize default_dict with dict_create().
711 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
713 struct dictionary now made opaque. All related functions:
715 * get.c: (rename_variables) Removed.
716 (dict_delete_run) Removed.
718 * temporary.c: (copy_variable) Removed.
719 (new_dictionary) Removed.
720 (save_dictionary) Removed.
721 (restore_dictionary) Removed.
722 (free_dictionary) Removed.
724 * vars-atr.c: (clear_default_dict) Removed.
725 (find_variable) Removed.
726 (find_dict_variable) Removed.
727 (create_variable) Removed.
728 (delete_variable) Removed.
729 (common_init_stuff) Removed.
730 (init_variable) Removed. Updating of inp_init moved into
731 cmd_end_input_program().
732 (replace_variable) Removed.
733 (rename_variable) Removed.
734 (clear_variable) Removed.
735 (dup_variable) Removed.
737 * vars-prs.c: (is_varname) Removed.
738 (is_dict_varname) Removed.
739 (fill_all_vars) Removed.
741 * vector.c: (find_vector) Removed.
743 * weight.c: (stop_weighting) Removed.
745 * dictionary.c: New file.
746 (dict_create) New, replaces new_dictionary().
747 (dict_clone) New, replaces save_dictionary() and
748 restore_dictionary().
749 (dict_clear) New, replaces clear_default_dict().
750 (dict_destroy) New, replaces free_dictionary().
751 (dict_get_var_cnt) New function, replaces references to
753 (dict_get_var) New function, replaces references to dict->var[i].
754 (dict_get_vars) New function, replaces fill_all_vars().
755 (dict_create_var) New, replaces create_variable(). Interface
756 drops `type' parameter, using a zero `width' to designate numeric.
757 (dict_clone_var) New, replaces dup_variable().
758 (dict_rename_var) New, replaces rename_variable().
759 (dict_lookup_var) New, replaces find_variable(),
760 find_dict_variable(), is_varname().
761 (dict_contains_var) New function.
762 (compare_variable_dblptrs) New function.
763 (dict_delete_var) New function, replaces clear_variable().
764 (dict_delete_vars) New function, replaces dict_delete_run().
765 (dict_reorder_vars) New function.
766 (dict_rename_vars) New function, replaces rename_variables().
767 (dict_get_weight) New function, replaces reading dict->weight_var.
768 (dict_set_weight) New function, replaces writing dict->weight_var
769 or calling stop_weight(dict).
770 (dict_get_filter) New function, replaces reading dict->filter_var.
771 (dict_set_filter) New function, replaces writing dict->filter_var.
772 (dict_get_case_limit) New function, replaces reading dict->N.
773 (dict_set_case_limit) New function, replaces writing dict->N.
774 (dict_get_value_cnt) New function, replaces reading dict->nval.
775 (dict_compact_values) New function, replaces a loop that was
776 replicated in several places.
777 (dict_get_split_vars) New function, replaces reading dict->splits.
778 (dict_get_split_cnt) New function, replaces reading
780 (dict_set_split_vars) New function, replaces writing dict->splits.
781 (dict_get_label) New function, replaces reading dict->label.
782 (dict_set_label) New function, replaces writing dict->label.
783 (dict_get_documents) New function, replaces reading
785 (dict_set_documents) New function, replaces writing
788 All references to above functions updated.
790 * aggregate.c: (cmd_aggregate) Copy file label and documents from
791 old dictionary to new by hand, because dict_create() can't do it
792 itself. Use dict_set_documents(), dict_set_split_vars().
794 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
795 calling dict_destroy().
797 * data-list.c: (dls_var_spec) Remove `type' member, replace by
799 (fixed_parse_compatible) Some slightly nontrivial changes for
801 (dump_fmt_list) Ditto.
804 * file-type.c: (create_col_var) Ditto.
806 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
807 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
808 (rename_variables) Use dict_rename_vars().
809 (mtf_merge_dictionary) Use dict_get_documents(),
810 dict_set_documents(), dict_compact_values().
812 * pfm-read.c: (read_variables) Deal with changes to weighting.
814 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
815 is_varname() in output code.
817 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
818 other dictionary functions.
820 * title.c: (add_document_line) Use dict_get_documents(),
821 dict_set_documents().
823 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
824 reset default_handle by hand. dict_clear() will clear vectors so
825 there's no need for that by hand.
827 * vfm.c: (close_active_file) Move call to finish_compaction()
828 earlier, so that we can do the compaction as a single step using
829 dict_compact_values(). Use dict_clear_vectors().
830 (finish_compaction) Use dict_delete_var(), dict_compact_values().
832 Some functions don't have replacements:
834 * vars-atr.c: (force_create_variable) Removed. All references
835 updated to dict_create_var() followed by an assertion.
836 (force_dup_variable) Removed. All references updated to
837 dict_clone_var() followed by an assertion.
839 * weight.c: (update_weighting) Removed. No longer necessary, so
840 all references removed.
842 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
846 * aggregate.c: Eliminate separation of weighted and unweighted
847 case. It made the code too obscure and I doubt it was actually
848 faster. Instead, all code uses the "weighted" code, because
849 that's a generalization of the "unweighted" code.
852 (parse_aggregate_functions) No need to set FWEIGHT.
853 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
854 (dump_aggregate_info) Ditto.
855 (initialize_aggregate_info) No need for special plain_function
856 that gets rid of FWEIGHT option.
858 * aggregate.c: Get rid of approximations.
859 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
861 (aggregate_single_case) Don't use approx_ne().
863 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
865 * ascii.c (ascii_line_width): Dead code, removed.
867 * postscript.c (ps_line_width): Ditto.
869 * q2c.c (xrealloc): Ditto.
871 * count.c (internal_cmd_count): Ditto.
873 * means.q (validate_dependent_endpoint): Ditto.
875 * set.q: (cmd_gset) Ditto.
877 * weight.c: [0] (weight_trns_proc) Ditto.
879 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
881 Make the code -Wmissing-prototypes clean.
883 * Makefile.am (version.c): Add #include "version.h".
885 * ascii.c: (ascii_open_global) Make static.
886 (ascii_close_page) Ditto.
887 (ascii_font_sizes) Ditto.
888 (ascii_postopen_driver) Ditto.
889 (ascii_close_driver) Ditto.
890 (ascii_option) Ditto.
891 (ascii_open_page) Ditto.
892 (ascii_line_horz) Ditto.
893 (ascii_line_vert) Ditto.
894 (ascii_line_intersection) Ditto.
896 (ascii_polyline_begin) Ditto.
897 (ascii_polyline_point) Ditto.
898 (ascii_polyline_end) Ditto.
899 (ascii_text_set_font_by_name) Ditto.
900 (ascii_text_set_font_by_position) Ditto.
901 (ascii_text_set_font_by_family) Ditto.
902 (ascii_text_get_font_name) Ditto.
903 (ascii_text_get_font_family) Ditto.
904 (ascii_text_set_size) Ditto.
905 (ascii_text_get_size) Ditto.
906 (ascii_text_metrics) Ditto.
907 (ascii_text_draw) Ditto.
908 (ascii_close_page) Ditto.
910 * cmdline.h: New header for parse_command_line(). Used where
913 * command.c: Move prototypes for cmd_*() functions to command.h.
915 * command.h: Prototypes for cmd_*() functions moved here from
918 * crosstabs.q: (gamma_int) Ditto.
920 * file-handle.h: Add fh_init_files() prototype.
922 * getline.c: (welcome) Ditto.
924 * glob.h: New header for init_glob(). Used where appropriate.
926 * hash.c: (comparison_helper) Ditto.
928 * html.c: (html_open_global) Ditto.
929 (html_close_global) Ditto.
930 (html_preopen_driver) Ditto.
931 (html_postopen_driver) Ditto.
932 (html_close_driver) Ditto.
934 (html_open_page) Ditto.
935 (html_close_page) Ditto.
938 * inpt-pgm.c: (input_program_source_read) Ditto.
940 * output.c: (find_defn_value) Ditto.
941 (destroy_list) Ditto.
943 * pfm-read.c: (read_int) Ditto.
945 * postscript.c: (ps_open_global) Ditto.
946 (ps_close_global) Ditto.
947 (ps_font_sizes) Ditto.
948 (ps_preopen_driver) Ditto.
949 (ps_postopen_driver) Ditto.
950 (ps_close_driver) Ditto.
952 (ps_open_page) Ditto.
953 (ps_close_page) Ditto.
954 (ps_line_horz) Ditto.
955 (ps_line_vert) Ditto.
956 (ps_line_intersection) Ditto.
958 (ps_polyline_begin) Ditto.
959 (ps_polyline_point) Ditto.
960 (ps_polyline_end) Ditto.
961 (ps_text_set_font_by_name) Ditto.
962 (ps_text_set_font_by_position) Ditto.
963 (ps_text_set_font_family) Ditto.
964 (ps_text_get_font_name) Ditto.
965 (ps_text_get_font_family) Ditto.
966 (ps_text_set_size) Ditto.
967 (ps_text_get_size) Ditto.
968 (ps_text_metrics) Ditto.
969 (ps_text_draw) Ditto.
971 * q2c.c: (finish_up) Ditto.
983 (force_string) Ditto.
988 (parse_setting) Ditto.
989 (parse_specifier) Ditto.
990 (parse_specifiers) Ditto.
991 (parse_subcommand) Ditto.
992 (dump_specifier_vars) Ditto.
994 (make_identifier) Ditto.
995 (dump_declarations) Ditto.
996 (dump_specifier_init) Ditto.
997 (dump_vars_init) Ditto.
999 (dump_specifier_parse) Ditto.
1000 (dump_subcommand) Ditto.
1001 (dump_parser) Ditto.
1002 (dump_header) Ditto.
1004 (recognize_directive) Ditto.
1006 * recode.c: (string_to_long) Ditto.
1008 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
1010 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
1013 * sort.c: (sort_stream_read) Ditto.
1014 (sort_stream_mode) Ditto.
1016 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
1018 * algorithm.c (binary_search): Fix comparison.
1020 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
1022 * algorithm.c: (binary_search) Fix assertion.
1024 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
1026 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
1028 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
1030 * sort.c: (compare_case_lists) Rewrite.
1032 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
1034 * quicksort.c: Removed (not used).
1036 * quicksort.h: Removed (not used).
1038 * sort.c: Removed blp_quicksort() prototype.
1040 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
1042 * postscript.c: (int_2_compare) Rewrite.
1043 (compare_line) Rewrite.
1045 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
1047 * matrix-data.c (compare_factors) Use lexicographical_compare()
1049 (compare_doubles) New function.
1051 * algorithm.c: (lexicographical_compare) New algorithm.
1053 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
1055 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
1057 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
1059 * expr-prs.c: (cmp_func) Removed.
1060 (parse_function) Use binary_search() algorithm.
1061 (compare_functions) New function.
1062 (init_func_tab) Use sort() algorithm.
1064 * algorithm.c: (binary_search) New algorithm.
1066 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
1068 * descript.q: (display) Use sort() algorithm instead of qsort().
1069 (compare_func) Removed.
1070 (descriptives_compare_variables) New function.
1072 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
1074 Get rid of AVL trees. Hashes are more appropriate for everything
1077 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
1083 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
1085 Much code can be clarified by using C++ STL-like algorithms. Not
1086 all uses of these algorithms are listed below, only the ones where
1087 the change to an algorithm was the only change of interest.
1089 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
1091 * algorithm.c: New file.
1093 * algorithm.h: New file.
1095 * modify-vars.c: (static var forward) Removed.
1096 (static var positional) Removed.
1097 (compare_variables) Removed.
1098 (struct ordering) New.
1099 (cmd_modify_vars) Use sort() algorithm.
1100 (compare_variables_given_ordering) New function.
1101 (rearrange_dict) Use sort() algorithm.
1103 * sysfile-info.c: (cmd_display) Use sort() algorithm.
1104 (cmp_var_by_name) Removed.
1106 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
1108 Make file handles use a hash table.
1110 * file-handle.q: (files) Change to hash table, make static.
1111 (cmd_file_handle) Use hash table functions.
1112 (fh_get_handle_by_filename) Ditto.
1113 (fh_get_handle_by_name) Ditto.
1114 (hash_file_handle) New function.
1115 (cmp_file_handle) Rewrite.
1116 (fh_init_files) Use hash table functions.
1118 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
1120 Clean up FREQUENCIES.
1122 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
1124 * frequencies.q: Remove a lot of old #if'd out code at the end.
1125 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
1126 or calc_weight(). Initialize percentile_values.
1127 (calc) New function based on calc_weight() from frequencies.g.
1128 (precalc) Use hash functions.
1129 (static var comparison_func) Removed.
1130 (static var comparison_param) Removed.
1131 (comparison_helper) Removed.
1132 (get_freq_comparator) New function.
1133 (not_missing) New function.
1135 (postprocess_freq_tab) Use hash table functions, algorithms,
1136 get_freq_comparator(). Rewrite.
1137 (cleanup_freq_tab) Rephrase.
1138 (add_percentile) Clean up spacing.
1139 (hash_value_numeric) New function.
1140 (hash_value_alpha) New function.
1141 (compare_value_numeric_a) Rewrite.
1142 (compare_value_alpha_a) Rewrite.
1143 (compare_value_numeric_d) Rewrite.
1144 (compare_value_alpha_d) Rewrite.
1145 (compare_freq_numeric_a) Rewrite.
1146 (compare_freq_alpha_a) Rewrite.
1147 (compare_freq_numeric_d) Rewrite.
1148 (compare_freq_alpha_d) Rewrite.
1149 (calc_stats) Clean up mode, percentiles, max.
1150 (dump_statistics) Clean up spacing.
1152 * frequencies.g: Removed.
1154 * var.h: (struct freq_tab) Change `data' to hash table.
1156 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
1158 * file-handle.h: Remove declaration of global variable `files',
1159 which wasn't used anywhere.
1161 * postscript.c: (add_encoding) Remove superfluous cast.
1164 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
1167 * temporary.c: [0] (display_tree) Removed.
1169 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
1171 Implement a new random number generator based on the alleged RC4
1174 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
1177 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
1178 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
1180 (static var V[]) Removed.
1181 (static var Y) Removed.
1182 (static var X2) Removed.
1183 (setup_randomize) Removed.
1185 (rand_uniform) Removed.
1186 (rand_normal) Removed.
1187 (struct rng) New structure.
1188 (rng_create) New function.
1189 (rng_destroy) New function.
1190 (swap_byte) New static function.
1191 (rng_seed) New function.
1192 (rng_get_bytes) New function.
1193 (rng_get_int) New function.
1194 (rng_get_unsigned) New function.
1195 (rng_get_double) New function.
1196 (rng_get_double_normal) New function.
1197 (pspp_rng) New function.
1199 * random.h: Sync up to random.c.
1201 * sample.c: (struct sample_trns) Make `frac' unsigned and a
1202 fraction of UINT_MAX, not 65536.
1203 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
1206 * vfm.c: (open_active_file) No need to call setup_randomize() any
1209 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
1211 Change dictionary name indexes to use hash tables instead of AVL
1214 * crosstabs.q: (free_var_dict) Use hash tables.
1215 (crs_custom_tables) Ditto.
1216 (calc_general) Ditto.
1217 (compare_table_entry) Rewrite.
1218 (enum_var_values) Reorder parameters. All references updated.
1221 * get.c: (rename_variable) Use hash tables.
1222 (mtf_merge_dictionary) Ditto.
1224 * glob.c: (init_glob) Use hash tables.
1225 (cmp_variable) Removed.
1227 * means.q: (mns_custom_tables) Use hash tables.
1229 * modify-vars.c: (rearrange_dict) Use hash tables.
1231 * rename-vars.c: (cmd_rename_variables) Use hash tables.
1233 * sfm-read.c: (read_header) Use hash tables.
1234 (read_variables) Ditto.
1236 * temporary.c: (new_dictionary) Use hash tables.
1237 (save_dictionary) Ditto.
1238 (restore_dictionary) Ditto.
1240 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
1241 hash table `name_tab'.
1243 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
1244 [DEBUGGING] (dump_var_tree) Removed.
1245 (find_variable) Use hash tables.
1246 (find_dict_variable) Ditto.
1247 (common_init_stuff) Ditto.
1248 (rename_variable) Ditto.
1249 (clear_variable) Ditto. Also, remove debug code.
1250 (dup_variable) Use hash tables.
1252 * vars-prs.c: (fill_all_vars) Use hash tables.
1253 (is_dict_varname) Ditto.
1254 (parse_dict_variable) Ditto.
1256 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
1258 Change value labels to use hash tables instead of AVL trees, and
1259 change value labels into an ADT.
1261 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
1263 * value-labels.c: New file.
1265 * value-labels.h: New file.
1267 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
1268 Get rid of a stupid use of goto.
1270 * autorecode.c: (compare_alpha_value) Rewrite.
1271 (hash_alpha_value) Ditto.
1272 (compare_numeric_value) Rewrite.
1273 (hash_numeric_value) Ditto.
1275 * frequencies.q: (dump_full) Use value label ADT.
1277 * pfm-read.c: (read_value_label) Use value label ADT.
1279 * pfm-write.c: (write_value_labels) Use value label ADT.
1281 * sfm-read.c: (read_variables) Use value label ADT.
1282 (read_value_labels) Rewrite.
1284 * sfm-write.c: (write_value_labels) Rewrite.
1286 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
1287 (display_variables) Ditto.
1288 (describe_variable) Ditto.
1290 * t-test.q: (print_t_groups) Use value label ADT.
1292 * temporary.c: (copy_variable) Use value label ADT.
1293 (free_dictionary) Ditto.
1295 * val-labs.c: (verify_val_labs) Use value label ADT.
1297 (debug_print) Ditto.
1298 (val_lab_cmp) Removed.
1299 (inc_ref_count) Removed.
1300 (copy_value_labels) Removed.
1302 * var.h: (struct value_label) Removed.
1303 (struct variable) Change AVL tree `val_lab' into hash table
1306 * vars-atr.c: (init_variable) Use value label ADT.
1307 (clear_variable) Ditto.
1308 (free_value_label) Removed.
1309 (free_val_lab) Removed.
1310 (get_val_lab) Removed.
1311 (compare_variables) New function.
1312 (hash_variable) New function.
1314 * vfm.c: (dump_splits) Use value label ADT.
1316 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
1318 Add to the hash table interface.
1320 * hash.c: (hsh_hash_bytes) Add assertion.
1321 (hsh_hash_string) Ditto.
1325 (hsh_create) Ditto. Also make minimum `size'.
1326 (hsh_destroy) Rephrase.
1327 (sort_nulls_last) Removed.
1328 (not_null) New function.
1330 (comparison_helper) Ditto.
1331 (hsh_sort) Rewritten.
1332 (hsh_data_copy) New function.
1333 (hsh_sort_copy) Ditto.
1335 (hsh_replace) Ditto.
1336 (hsh_hash_double) Ditto.
1337 (hsh_delete) Fix stupid bug.
1339 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
1340 * added a calculation of the mode to FREQUENCIES
1342 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
1344 * moved (un)defs of DEBUGGING to config.h
1346 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
1348 * groff-font.c: (add_kern) Fix indentation.
1349 (add_kern) Use & instead of % to take power-of-2 modulus.
1350 (font_get_kern_adjust) Likewise.
1352 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
1354 * autorecode.c: (recode) Replace stupid use of memcpy() by
1356 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
1357 (hash_numeric_value) Ditto.
1358 (autorecode_proc_func) pool_strdup() was wrong here because the
1359 source string was not null-terminated. Use new pool_strndup()
1362 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
1363 use of hsh_iterator_init().
1365 * data-in.c: (parse_N) Initialize i->v->f.
1367 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
1370 * groff-font.c: Use power-of-2 hash table sizes, not prime.
1371 (groff_read_font) Don't call hsh_next_prime(). Don't call
1373 (static var hash) Remove `size_p', `max_used' members.
1374 (font_char_name_to_index) Don't call hsh_next_prime(). Use
1375 hsh_hash_string() instead of hashpjw(), & instead of %.
1376 (default_font) Don't call hsh_next_prime().
1378 * pool.c: (pool_strndup) New function.
1379 (pool_strdup) Reimplement in terms of pool_strndup.
1381 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
1383 (hash_ps_encoding) Use hsh_hash_string().
1384 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
1385 (hash_filename2font) Use hsh_hash_string().
1387 * som.c: Add #include <stdlib.h>.
1389 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
1390 (by destroying its pool).
1392 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
1394 Miscellaneous hash table code cleanup:
1396 * hash.h: (struct hsh_table) Moved into hash.c.
1397 (hsh_count) Ditto, and transformed into function.
1398 (hsh_compare_func) New typedef, used for defining otherwise-long
1399 function types here and in hash.c
1400 (hsh_hash_func) Ditto.
1401 (hsh_free_func) Ditto.
1403 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
1404 `table' to `entries'. Removed `mp'. All references updated.
1405 (hsh_clear) Don't shrink entries array; if the hash was this big
1406 once, it probably will be again.
1407 (hsh_rehash) Made static.
1408 (force_hsh_insert) Renamed hsh_force_insert.
1409 (force_hsh_find) Renamed hsh_force_find.
1411 Made hash table sizes powers of 2, because that's fine with any
1412 reasonable hash function and because taking a power-of-2 modulus
1413 is faster than any other:
1415 (hsh_prime_tab) Removed;
1416 (hsh_next_prime) Ditto.
1417 (next_power_of_2) New function.
1418 (hsh_create) Use next_power_of_2.
1419 (hsh_rehash) Use & instead of %.
1421 Cleaned up hsh_sort:
1423 (internal_comparison_fn) Removed.
1424 (sort_nulls_last) New function.
1425 (hsh_sort) Removed second parameter, switched to using the new
1426 quicksort() function from quicksort.h to avoid using nasty need
1427 for static variables with qsort(). All references updated.
1429 Changed the hash functions offered, because there are better hash
1430 functions than the ones we had, and cleaned up the names to boot:
1432 * hash.c: (hashpjw_d) Removed.
1434 (hsh_hash_bytes) New function.
1435 (hsh_hash_string) New function.
1436 (hsh_hash_int) New function.
1438 Improved the hash table iteration interface:
1440 * hash.h: (hsh_iterator_init) Removed.
1441 (struct hsh_iterator) Removed `init' member, change `next' to
1444 * hash.c: (hsh_foreach) Removed. All references updated to use
1445 hsh_first/hsh_next instead.
1446 (hsh_first) New function. Notably, unlike hsh_foreach() it does
1447 not treat a null pointer as an empty hash table.
1448 (hsh_next) New function.
1450 Made deletion possible, though slow:
1452 * hash.c: (locate_matching_entry) New function.
1453 (hsh_find) Use locate_matching_entry().
1454 (hsh_delete) New function also using locate_matching_entry().
1455 (hsh_force_delete) New function.
1457 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
1459 * quicksort.c: New file implementing a sort routine with a
1460 interface better than qsort() because it passes a user-provided
1461 parameter to the sort routine.
1463 * Makefile.am: Add quicksort.c, quicksort.h.
1465 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
1467 * All source files: Get rid of nasty special cases for Checker,
1468 which is pretty obsolete now.
1470 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
1472 * Fixed a bug apparent when using the FREQUENCIES command with the
1473 html driver. The html driver was incorrectly trying to display
1476 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
1478 * Makefile.am: Reorganized. Put locale dir in version.c instead
1479 of passing it to each compile command. Only put local gmp libs in
1480 LD_ADD if not installed on system. Remove `boast' target.
1482 * All source files: struct and union typedefs eliminated.
1483 `sizeof type' replaced by `sizeof object' where practical. Moved
1484 `unused' qualifiers from start to end of declarations for gcc
1485 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
1486 assertions on pointers strictly compliant. Removed _ prefixes on
1487 some function parameter names.
1489 * alloc.c: New source file, containing these external linkage
1490 functions removed from common.c: xmalloc, xcalloc, xrealloc,
1497 * ascii.c: Migrated from arenas to pools.
1498 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
1499 c_string to len_string. All references changed.
1500 (ascii_option) Signature changed to comply to new output.c
1502 (count_fancy_chars) Removed.
1503 (delineate) Removed support for rich text.
1504 (ascii_text_metrics) Ditto.
1506 (output_shorts) Change `box', `off', `on' from c_string to
1507 len_string. Change `remaining' from int to size_t.
1508 (ascii_close_page) Make page numbering less haphazard.
1510 * autorecode.c: Migrate from arenas to pools.
1512 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
1514 * bitvector.h: New file containing these macros from misc.h:
1515 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
1517 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
1518 word[3]. ncmd removed.
1519 (var empty_string) Removed.
1520 (var cmd_table) Declaration updated.
1521 (var cmdtab) Removed.
1522 (cmp_command) Removed.
1523 (split_words) Rewritten to use strtok_r().
1524 (init_cmd_parser) Renamed cmd_init(). Rewritten.
1525 (find_command) Removed.
1526 (FILE_TYPE_okay) Rewritten.
1527 (cmd_parse) Rewritten. Semantics of the return value of command
1528 handlers has changed: they must now return one of the new CMD_*
1529 enumerals, rather than a magic value. This meant that all
1530 commands had to be modified, and they were.
1531 (figure_out_command) New function.
1533 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
1534 #defines for INIT, INPU, etc.
1536 * command.h: New CMD_* enum series.
1537 (cur_proc) Make const char *, not char *.
1538 (cmd_init) Prototype.
1541 * common.c: Removed.
1543 * common.h: Removed.
1545 * correlations.q: New file.
1547 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
1549 (custom_tables) Renamed crs_custom_tables().
1550 (custom_variables) Renamed crs_custom_variables().
1551 (calc_integer) Add in some `const' qualifiers.
1552 (table_value_missing) Change from a_string to len_string.
1553 (float_M_suffix) Change from a_string to len_string.
1555 * data-in.c: Rewritten. All references to
1556 parse_string_as_format() changed to data_in().
1558 * data-in.h: New file.
1560 * data-list.c: Change DLS_* from #define's to enums. Move from
1561 rpd_msg() to tmsg().
1562 (RPD_ERR) New #define.
1563 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
1565 (read_from_data_list_fixed) Change from old
1566 parse_string_as_format() to new data_in().
1567 (read_from_data_list_free) Ditto.
1568 (read_from_data_list_list) Ditto.
1569 (cmd_repeating_data) Modify approach to checking for end of
1572 (rpd_parse_record) Change from old parse_string_as_format() to new
1573 data_in(). Change from old convert_format_to_string() to new
1575 (read_one_set_of_repetitions) Change dfm_push_cust() to
1576 dfm_push(), pop_cust() to dfm_pop().
1578 * data-out.c: Rewritten. All references to
1579 convert_format_to_string() changed to data_out().
1581 * descript.q: Migrate to new q2c.
1582 (cmd_descriptives) Removed.
1583 (internal_cmd_descriptives) Renamed cmd_descriptives ().
1584 (custom_variables) Renamed dsc_custom_variables().
1586 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
1588 (open_file_r) Initialize h->where.line_number. Migrate to new
1590 (open_file_w) Initialize h->where.line_number.
1591 (read_record) Change from ext->ln to h->where.line_number.
1592 Migrate to struct string.
1593 (dfm_put_record) Rephrased.
1594 (dfm_push_cust) Renamed dfm_push(), rewritten.
1595 (dfm_pop) New function.
1597 * error.c: All references updated.
1598 (glob var error_count) Renamed err_err_count.
1599 (glob var warning_count) Renamed err_warning_count.
1600 (glob var error_already_flagged) Renamed err_already_flagged.
1601 (glob var verbosity) Renamed err_verbosity.
1602 (glob var cust_fn) Removed.
1603 (glob var cust_ln) Removed.
1604 (static var file_loc) New.
1605 (static var nfile_loc) New.
1606 (static var mfile_loc) New.
1607 (tmsg) New function.
1608 (push_cust) Removed.
1611 (static var terminating) Removed.
1612 (failure) Renamed err_failure().
1613 (hcf) Renamed err_hcf().
1614 (err_push_file_locator) New function.
1615 (err_pop_file_locator) New function.
1616 (err_location) New function.
1617 (check_error_count) Renamed err_check_count().
1618 (vmsg) Renamed err_vmsg(). Interface changed.
1619 (verbose_msg) Removed.
1620 (err_cond_fail) New function.
1621 (error_break) Renamed err_break().
1623 * error.h: All references updated.
1624 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
1625 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
1627 (struct file_locator) New.
1629 (macro verbose_msg) Removed.
1630 (macro cond_fail) Removed.
1632 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
1634 * expr-prs.c: Reorganized. All references updated.
1635 (exprtypename) Renamed expr_type_name().
1636 (typename) Renamed type_name().
1637 (free_expression) Renamed expr_free().
1638 (parse_expression) Renamed expr_parse(). Uses new type_check()
1640 (init_functab) Renamed init_func_tab().
1641 (type_check) New function.
1642 (parse_or) Rewritten to use new allocate_nonterminal() and
1643 append_nonterminal_arg() functions.
1646 (parse_rel) Ditto. Also simplified logic.
1651 (SYSMIS_func) Ditto.
1652 (VALUE_func) Rephrased.
1653 (CONCAT_func) Fix memory leak by replacing free by free_node on
1655 (generic_str_func) Ditto.
1656 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
1658 (allocate_nonterminal) New function.
1659 (append_nonterminal_arg) New function.
1660 (static func_tab[]) Now at file level.
1662 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
1664 * expr.h: (enum series OP_*) Moved to exprP.h.
1665 (OP_* defines) Ditto.
1666 (struct op_desc) Ditto.
1667 (global ops[]) Ditto.
1668 (struct num_con_node) Ditto.
1669 (struct str_con_node) Ditto.
1670 (struct var_node) Ditto.
1671 (struct lag_node) Ditto.
1672 (struct casenum_node) Ditto.
1673 (struct nonterm_node) Ditto.
1674 (union any_node) Members renamed.
1675 (struct sys_node) Removed.
1676 (struct val_node) Removed.
1677 (operator typedef) Removed.
1678 (typedef exprtype) Removed.
1679 (enum series EX_*) Moved to exprP.h.
1680 (struct expression) Ditto. Also renamed a lot of the members.
1681 (PXP_* defines) Changed to enums.
1682 (free_node prototype) Moved to exprP.h.
1684 * file-handle.h: (struct file_handle) New member `where'.
1686 * file-handle.q: Migrated to new q2c format.
1687 (prepend_current_directory) Removed (dead code).
1688 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
1689 (fh_get_handle_by_filename) Removed dead code.
1690 Set new `where' member.
1692 * file-type.c: (file_type_source_read) References to
1693 parse_string_as_format() changed to data_in().
1694 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
1696 * filename.c: All references updated.
1697 (init_filename) Renamed fn_init().
1698 (expand_line) Removed.
1699 (macro EXPAND_LINE) Removed.
1700 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
1701 of custom functions.
1702 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
1703 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
1704 (normalize_filename) Renamed fn_normalize().
1705 (search_path) Renamed fn_search_path(), rewritten.
1706 (prepend_dir) Renamed fn_prepend_dir().
1707 (blp_getenv) Renamed fn_getenv().
1708 (blp_dirname) Renamed fn_dirname().
1709 (fn_basename) New function, not used.
1710 (absolute_filename_p) Renamed fn_absolute_p().
1711 (is_special_filename) Renamed fn_special_p().
1712 (file_exists) Renamed fn_exists_p().
1713 (readlink_malloc) Renamed fn_readlink().
1714 (getenv_default) Renamed fn_getenv_default().
1715 (open_file) Renamed fn_open().
1716 (close_file) Renamed fn_close().
1717 (open_file_ext) Renamed fn_open_ext().
1718 (close_file_ext) Renamed fn_close_ext().
1720 * font.h: Migrate from arenas to pools.
1722 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
1724 * frequencies.g: Migrate from arenas to pools.
1726 * frequencies.q: Migrate to new q2c version. Migrate from arenas
1729 * getline.c: All references updated.
1730 (global getl_buf) Changed from char * to struct string.
1731 (static getl_include_path) Ditto.
1732 (global getl_buf_len) Removed.
1733 (global getl_buf_size) Removed.
1734 (getl_include_path) Deal with new getl_buf, getl_include_path.
1735 (getl_uninitialize) New function.
1736 (getl_get_current_directory) Rewritten.
1737 (getl_clear_include_path) Rewritten.
1738 (getl_add_include_dir) Rewritten.
1739 (getl_add_file) Assertion fixed.
1740 (getl_add_virtual_file) Change initial value of `remaining_loops'
1742 (welcome) Rewritten.
1743 (handle_line_buffer) Make static. Change logic to make
1744 getl_add_virtual_file() change sensible. Use ds_*() strings.
1745 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
1746 (getl_close_file) Moved.
1747 (getl_location) New function.
1749 * getline.h: All references updated.
1750 (macro curln) Removed.
1751 (macro curfn) Removed.
1752 (macro am_interactive) Renamed getl_am_interactive.
1753 (macro am_reading_script) Renamed getl_reading_script.
1755 * glob.c: (global fmt_parse_ignore_error) Removed.
1756 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
1757 systems that support it (C99). Turn off SET ECHO by default. No
1758 necessary julcal initialization anymore.
1760 * groff-font.c: Migrate from arenas to pools.
1761 (groff_read_font) Use err_push_file_locator().
1762 (groff_read_DESC) Ditto.
1763 (font_msg) Use tmsg().
1765 * hash.c: (hsh_sort) Fix debug code.
1766 [GLOBAL_DEBUGGING] Include stdio.h.
1768 * hash.h: (macro force_hsh_insert) Rephrase.
1770 * heap.c: Rewritten.
1772 * heap.h: Rewritten.
1774 * html.c: (html_option) Change from outp_value to struct string.
1775 (postopen) Change from curfn to getl_location().
1776 (escape_string) Remove rich-text code. Signature changed.
1777 (output_tab_table) Switch from a_string to struct len_string.
1778 Remove rich text support.
1780 * lexer.c: All references updated. Largely rewritten. Major
1781 changes listed below. Removed tagged quote support. Adapted to
1782 struct string tokstr.
1783 (global tokstr) Changed to struct string.
1784 (global tokstr_size) Removed.
1785 (global tokstr_len) Removed.
1787 (global tokint) Removed.
1788 (global toklongstr) Removed.
1789 (C* defines) Removed.
1790 (static tbl[]) Removed.
1791 (static id[]) Removed.
1792 (static une[]) Removed.
1793 (discard_line) Renamed lex_discard_line().
1794 (get_entire_line) Renamed lex_entire_line().
1795 (get_rest_of_line) Renamed lex_rest_of_line().
1796 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
1797 (make_hexit) Removed.
1798 (syntax_error) Renamed lex_error(). Return value removed.
1799 (get_token_representation) Renamed lex_token_representation().
1800 (putback) Renamed lex_put_back().
1801 (putfwd) Renamed lex_put_forward().
1802 (convert_negative_to_dash) Renamed lex_negative_to_dash().
1803 (set_prog) Renamed lex_set_prog().
1804 (init_lex) Renamed lex_init().
1805 (reset_eof) Renamed lex_reset_eof().
1806 (lookahead) Renamed lex_look_ahead().
1807 (check_id) Rewritten.
1808 (yylex) Renamed lex_get(), rewritten.
1809 (lex_end_of_command) New function. Many commands were rephrased
1811 (lex_integer_p) New function. Replaces compare of tokint against
1813 (lex_integer) New function. Replaces tokint.
1814 (match_tok) Renamed lex_match().
1815 (match_id) Renamed lex_match_id().
1816 (match_int) Renamed lex_match_int().
1817 (force_match_id) Renamed lex_force_match_id(), added return value.
1818 (force_match) Renamed lex_force_match(), added return value.
1819 (force_string) Renamed lex_force_string(), added return value.
1820 (force_int) Renamed lex_force_int(), added return value.
1821 (lex_id_match_len) New function.
1822 (id_match) Renamed lex_id_match(), rewritten.
1823 (get_line) Renamed lex_get_line().
1824 (preprocess_line) Renamed lex_preprocess_line().
1825 (tokname) Renamed lex_token_name().
1826 (bin_value_func) Removed.
1827 (oct_value_func) Removed.
1828 (hex_value_func) Removed.
1829 (unexpected_eof) New function.
1830 (convert_numeric_string_to_char_string) New function.
1831 (parse_string) Rewritten, signature changed.
1832 (add_tokstr_char) Removed.
1833 (add_tokstr_unsigned) Removed.
1834 (add_tokstr_string) Removed.
1835 (parse_tagged_quote) Removed.
1836 (skip_comment) Renamed lex_skip_comment().
1838 * lexer.h: All references updated.
1839 (macro is_id1) Renamed CHAR_IS_ID1.
1840 (macro is_idn) Renamed CHAR_IS_IDN.
1841 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
1842 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
1843 (macro get_token) Removed.
1844 (macro id_match) Removed.
1845 (macro force_match_id) Removed.
1846 (macro force_match) Removed.
1847 (macro force_string) Removed.
1848 (macro force_int) Removed.
1849 (macro force_num) Removed.
1850 (macro force_id) Removed.
1852 * lexerP.h: Removed.
1854 * list.q: Migrated to new q2c format.
1855 (write_line) Deal with struct len_string.
1856 (write_varname) Ditto.
1857 (write_fallback_headers) Ditto.
1859 * magic.c: New file, incorporating the following global variables
1860 previously in other files: endian, second_lowest_value. And both
1861 of those are conditional on #define's.
1863 * magic.h: New file, incorporating the following global variable
1864 declarations: endian, second_lowest_value, and the following macro
1865 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
1867 * main.c: Added declarations of pgmname, finished, curdate,
1869 (main) Call new parse_script() function.
1870 (parse_script) New function.
1871 (execute_command) New function.
1872 (dump_token) Removed.
1873 (handle_error) New function.
1875 * matrix.c: New file.
1877 * matrix.h: New file.
1879 * matrix-data.c: Migrated from arenas to pools.
1880 (mget_token) Change from parse_string_as_format() to data_in().
1882 * means.q: Migrate to new q2c.
1883 (custom_tables) Renamed mns_custom_tables().
1884 (custom_crossbreak) Renamed mns_custom_crossbreak().
1885 (custom_variables) Renamed mns_custom_variables().
1887 * mis-val.c: (static var width) Changed from `int' to `size_t'.
1888 (parse_varnames) Prototype.
1889 (parse_numeric) Rephrasings.
1890 (parse_alpha) Adapt to new struct string tokstr.
1892 * misc.c: (intlog10) Rewritten.
1894 (ansi_rand) Renamed real_rand(), moved into random.c.
1895 (ansi_srand) Renamed real_srand(), moved into random.c.
1896 (setup_randomize) Moved to random.c.
1897 (rand_uniform) Ditto.
1898 (rand_normal) Ditto.
1899 (rand_simple) Ditto.
1900 (get_config_line) Removed.
1901 (reverse) Removed (dead code).
1903 * misc.h: (macro SET_BIT) Moved to bitvector.h.
1904 (macro CLEAR_BIT) Ditto.
1905 (macro TEST_BIT) Ditto.
1906 (macro SET_BIT_TO) Ditto.
1907 (macro BIT_INDEX) Ditto.
1909 * output.c: (outp_read_devices) Move to err_push_file_locator()
1910 from push_cust(). Use struct string.
1911 (expand_op_tokstr) Removed.
1912 (static var op_tokstr) Changed to struct string.
1913 (static var op_tokstr_size) Removed.
1914 (tokener) Rephrasings. Use struct string.
1915 (parse_options) Use struct string.
1916 (destroy_driver) Fix assertion.
1917 (outp_get_paper_size) Move to err_push_file_locator().
1918 [0] Removed dead code.
1919 (outp_string_width) Move to len_string.
1921 * output.h: Comment fixes.
1922 (TAG_* enum series) Removed.
1923 (struct outp_value) Removed.
1924 (enum OUTP_T_FANCY) Removed.
1925 (struct outp_text) `s' changed from a_string to len_string.
1926 (struct outp_class) `option' change arg 3 from outp_value to
1929 * pfm-read.c: (corrupt_msg) Rewritten.
1931 * pfm-write.c: (bufwrite) Fix assertion.
1933 * pool.c: New file, reference version.
1935 * pool.h: New file, reference version.
1937 * postscript.c: (ps_font_sizes) Fix assertion.
1938 (ps_option) Change arg 3 from outp_value to struct string.
1939 Adapt to struct string.
1940 (macro output_line) Removed.
1941 (macro add_string) Removed.
1942 (output_encodings) Adapted to struct string. Moved to
1943 err_push_file_locator().
1944 (find_encoding_file) Fix assertion.
1945 (read_ps_encodings) Move to err_push_file_locator().
1946 (postopen) Use getl_location() instead of curfn.
1947 (out_text_plain) Move to len_string.
1948 (text) Ditto. Remove rich text support.
1950 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
1951 (cmd_print_eject) Ditto.
1953 (internal_cmd_print) Now cleans up after itself. Uses
1954 fh_parse_file_handle() now.
1955 (cmd_print_space) Use PXP_NUMERIC to type-check.
1957 * q2c.c: Overhauled. Removed _("") i18n support. All references
1958 updated. All output functions updated to handle structures rather
1959 than local or static variables. Adapt to new PSPP lex_*()
1963 (macro MAX_N_SBC) Removed.
1964 (global bare) Removed.
1965 (enum STRING) Renamed T_STRING.
1966 (enum ID) Renamed T_ID.
1967 (get_buffer) Buffer size increased.
1968 (strlower) Renamed st_lower(), rephrased.
1969 (strupper) Renamed st_upper(), rephrased.
1970 (skip_ws) New function.
1971 (get_line) Don't special-case any types of lines (like those
1972 beginning with ! or $, for instance).
1973 (get_token) Renamed lex_get(). Rephrased.
1974 (static var `prefix') New.
1975 (parse) New function.
1976 (parse_setting) Minor rephrasing.
1977 (dump_specifier_vars) Ditto.
1978 (make_identifier) Put null terminator on identifier, duh.
1979 (dump_vars) Renamed dump_declarations(). Never indent. Never
1980 static. Output changed entirely.
1981 (dump_specifier_init) Rephrase.
1982 (dump_vars_init) No index variable needed. Other modifications.
1983 (dump_parser) Don't parse command name. Do dump functions instead
1984 of just code fragments.
1985 (dump_free) Dump function instead of code fragment.
1986 (recognize_directive) New function.
1987 (main) Use recognize_directive(). Don't rely on magic $ line
1988 beginning: instead, parse comments. Update list of headers.
1990 * random.c: New file, containing the following functions:
1991 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
1992 rand_normal, rand_simple.
1994 * random.h: New file.
1996 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
1997 function. `max_src_width', `max_dst_width' changed to size_t.
1998 (internal_cmd_recode) Removed.
1999 (parse_dest_spec) Merge similar cases.
2000 (parse_src_spec) Add assertion.
2002 * repeat.c: (recognize_keyword) New function.
2003 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
2004 REPEAT. Improve recognition of END REPEAT (use
2005 recognize_keyword()). Move from curfn to getl_location(). Use
2008 (perform_DO_REPEAT_substitutions) Adapt to struct string.
2010 * set.q: Adapt to new q2c.
2011 (cmd_set) Range-check some values better.
2012 (custom_blanks) Renamed stc_custom_blanks().
2013 (custom_length) Renamed stc_custom_length().
2014 (custom_results) Renamed stc_custom_results().
2015 (custom_seed) Renamed stc_custom_seed().
2016 (custom_width) Renamed stc_custom_width().
2017 (custom_format) Renamed stc_custom_format().
2018 (custom_journal) Renamed stc_custom_journal().
2019 (custom_color) Renamed stc_custom_color().
2020 (custom_listing) Renamed stc_custom_listing().
2021 (custom_disk) Renamed stc_custom_disk().
2022 (custom_log) Renamed stc_custom_log().
2023 (custom_rcolor) Renamed stc_custom_rcolor().
2024 (custom_viewlength) Renamed stc_custom_viewlength().
2025 (custom_workdev) Renamed stc_custom_workdev().
2027 * settings.h: Not necessary to include format.h any longer.
2029 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
2030 (corrupt_msg) Rewritten.
2032 * sort.c: Adapt to rewritten heap ADT.
2034 * str.c: (aa_strcpy) Removed.
2035 (ab_strcpy) Removed.
2036 (ac_strcpy) Removed.
2037 (ba_strcpy) Removed.
2038 (bb_strcpy) Removed.
2039 (ca_strcpy) Removed.
2040 (aa_strdup) Removed.
2041 (aa_strdupcpy) Removed.
2042 (ba_strdup) Removed.
2043 (sa_strdup) Removed.
2044 (memrev) Renamed mm_reverse().
2045 (memrmem) Renamed mm_find_reverse().
2046 (cmp_str) Renamed st_compare_pad().
2047 (strmaxcpy) Removed.
2048 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
2049 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
2051 (strpadcpy) Renamed st_pad_copy(), signature changed.
2052 (blpstrset) Removed.
2053 (ds_create) New function.
2054 (ds_init) New function.
2055 (ds_replace) New function.
2056 (ds_destroy) New function.
2057 (ds_clear) New function.
2058 (ds_extend) New function.
2059 (ds_shrink) New function.
2060 (ds_truncate) New function.
2061 (ds_length) New function.
2062 (ds_size) New function.
2063 (ds_value) New function.
2064 (ds_end) New function.
2065 (ds_concat) New function.
2066 (ds_concat_buffer) New function.
2067 (ds_printf) New function.
2068 (ds_putchar) New function.
2069 (ds_getline) New function.
2070 (ds_get_config_line) New function derived from the old
2071 misc.c:get_config_line().
2072 (ls_create) New function.
2073 (ls_create_buffer) New function.
2074 (ls_init) New function.
2075 (ls_shallow_copy) New function.
2076 (ls_destroy) New function.
2077 (ls_null) New function.
2078 (ls_null_p) New function.
2079 (ls_empty_p) New function.
2080 (ls_length) New function.
2081 (ls_value) New function.
2082 (ls_end) New function.
2084 * str.h: Reformatted.
2085 (struct a_string) Removed.
2086 (struct b_string) Removed.
2087 (struct c_string) Removed.
2088 (struct len_string) New.
2089 (struct string) New.
2090 (macro as_streq) Removed.
2091 (macro bs_streq) Removed.
2092 (macro cs_streq) Removed.
2093 (macro sa_streq) Removed.
2094 (macro sb_streq) Removed.
2095 [__GNUC__] (inline function ds_putchar) New function.
2096 [__GNUC__] (inline function ds_length) New function.
2097 [__GNUC__] (inline function ds_value) New function.
2098 [__GNUC__] (inline function ds_end) New function.
2100 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
2101 (display_vectors) Fix missing i18n.
2103 * t-test.q: Migrate to new q2c.
2105 * tab.c: Migrate from arenas to pools.
2106 (tab_create) Use struct len_string.
2107 (tab_realloc) Ditto.
2108 (text_format) Ditto.
2109 (tab_joint_text) Ditto.
2110 (tab_natural_width) Remove rich text support.
2111 (tab_natural_height) Ditto.
2112 (tab_output_text) Handle TAT_FIX.
2113 (tab_raw) Change arg from a_string to len_string.
2114 (tabi_driver) Fix assertion. Use struct len_string.
2115 (render_strip) Use struct len_string. Remove rich text support.
2116 Add `const' qualifiers.
2118 * tab.h: (enum TAB_RICH) Remove.
2119 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
2120 SOM_COL_* updated to read TAB_COL_*.
2121 (struct tab_table) Change arena to pool. Change a_string to
2124 * temporary.c: (restore_dictionary) Rewrite Checker code.
2126 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
2127 LOWEST, HIGHEST) Moved here from common.h.
2128 (typedef any_trns) Removed. All references changed to `struct
2131 * vars-atr.c: (force_create_variable) Fix assertion.
2132 (force_dup_variable) Fix assertion.
2134 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
2136 Using alphanumeric variables in functions under AGGREGATE
2137 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
2138 <BZN-mdksh@t-online.de> for reporting this bug.
2140 * aggregate.c: (parse_aggregate_functions) When setting the
2141 FSTRING bit, also allocate memory for the `string' member of
2143 (free_aggregate_functions) Free iter->string. Don't use the
2144 non-function bits when indexing the array of functions.
2145 [DEBUGGING] (debug_print) Don't use the non-function bits when
2146 indexing the array of functions.
2148 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
2150 Under certain circumstances, the final case would be omitted from
2151 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
2152 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2154 * aggregate.c (agr_00x_end_func): Increment number of cases in
2155 sink before writing case. For streams that keep track of how many
2156 cases there are based on this value, this means that the last case
2157 will be read in on the next stream read.
2159 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
2161 Undefined behavior was invoked by referencing a freed pointer.
2163 * vfm.c (memory_stream_write): Free pointer *after* checking for
2166 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
2168 A wrong record size was displayed when paging the active file to
2171 * vfm.c: (memory_stream_write) Fix off-by-one error.
2173 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
2175 Not having enough temporary space for sorting caused a core dump.
2178 * sort.c: (allocate_cases) Initialize i.
2180 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
2182 Syntax errors in function descriptions on AGGREGATE caused core
2185 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
2186 free_aggregate_functions(), since that function already frees
2189 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
2191 A null pointer was dereferenced, causing a core dump, when
2192 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
2193 but PSPP still doesn't calculate percentiles. Thanks to Regnor
2194 Jernsletten <rjernsle@eunet.no> for reporting this problem.
2196 * arena.c: (arena_malloc) If the arena hasn't been initialized
2197 already, initialize it.
2199 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
2201 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
2202 for compilation with Cygnus Windows B20. Not used by other
2205 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
2207 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
2208 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2210 * sort.c: (compare_case_lists) Reverse sense of comparison if
2211 sorting in descending order.
2212 (compare_record) Ditto.
2214 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
2216 SPLIT FILE with a string variable caused a core dump. Fixed.
2218 * vfm.c: If the variable is a string then make a temporary value
2219 struct pointing to it. The underlying problem is a lot bigger
2220 than this (see TODO) but this is a stopgap for the simple case at
2223 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
2225 Nested INCLUDEs didn't work. Fixed.
2227 * getline.c: (getl_include) Set first_line to NULL in allocated
2230 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
2232 The MATCH FILES procedure set the values of variables not present
2233 to 0. It should have been SYSMIS. This is now fixed.
2235 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
2237 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
2239 The REMARK command was too aggressive about skipping lines. It
2240 didn't like being the last command in a file.
2242 * command.c: (cmd_remark) Call get_entire_line() instead of
2245 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
2247 Comment parsing wasn't consistent with the rest of the code in its
2248 idea of where one command ends and another starts. This meant
2249 that sometimes commands would be mysteriously ignored. Thanks to
2250 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2252 * command.c: (parse_cmd) Hand off comment parsing to new function
2253 skip_comment() in lexer.c.
2254 * lexer.c: (skip_comment) New function.
2256 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
2258 The TABLE subcommand on MATCH FILES worked only erratically at
2259 best. This fixes it. Thanks to Dr. Dirk Melcher
2260 <BZN-mdksh@t-online.de> for reporting this bug.
2262 * get.c: (mtf_compare_BY_values) When comparing string values, a
2263 difference of 1 is still a difference :-)
2264 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
2265 advance TABLE files automatically when matched. Comment fixes.
2267 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
2269 VARIABLE LABELS rejected a slash before the first variable
2270 specification, contradicting the documentation. Thanks to Walter
2271 M. Gray <graywm@northernc.on.ca> for reporting this bug.
2273 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
2274 command specification.
2276 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
2278 Because of an incorrect optimization in memory allocation,
2279 CROSSTABS sometimes segfaulted when asked to output multiple
2280 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
2283 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
2284 are passed to output_pivot_table() for its use.
2285 (output_pivot_table) Instead of assuming the number of columns is
2286 constant, keep track with maxcols. In general mode, use maxcells
2287 to determine whether more matrix cells need to be allocated.
2289 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
2291 CROSSTABS didn't display value labels for column and row
2292 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
2295 * crosstabs.q: (table_value_missing) If the specified value has a
2296 value label for this variable, then show it instead of the raw
2298 (display_dimensions) Delegate display of value_labels to
2299 table_value_missing.
2301 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
2303 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
2304 <BZN-mdksh@t-online.de> for reporting this bug.
2306 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
2307 if the file isn't declared as binary.
2309 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
2311 MATCH FILES corrupted memory and dumped core on some syntax
2314 * get.c: (cmd_match_files) Set file->handle to NULL before
2316 (mtf_free_file) Don't free a null dictionary.
2318 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
2320 MATCH FILES should set numeric values not available to the
2321 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
2322 <BZN-mdksh@t-online.de> for reporting this bug.
2324 * get.c: (mtf_processing) Set unused records to system-missing,
2327 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
2329 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
2330 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
2332 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
2333 in newly created dictionary, and add each copied variable to the
2336 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
2340 * get.c: (trim_dictionary) Free variable list for KEEP after
2343 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
2345 Some systems didn't like the way open_file was coded. Thanks to
2346 Hankin <hankin@rogue.consultco.com> for pointing this out.
2348 * filename.c: (open_file) Don't try to store stdin, stdout,
2349 stderr as part of an array, because that doesn't always work.
2351 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
2353 The SAVE procedure didn't save long string variables properly.
2354 Fixed by this patch. Thanks to Hankin
2355 <hankin@rogue.consultco.com> for this patch.
2357 * sfm-write.c: (write_variable) Fix off-by-one error in writing
2358 out variable pad records.
2360 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
2362 Previously, if PRINT SPACE were given a negative argument, it
2363 would report an error, then spin in an (almost) infinite loop.
2364 This fixes that behavior.
2366 * print.c: (print_space_trns_proc) After reporting a negative
2367 argument, set number of lines to print to 1.
2369 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
2371 SPSS 8.0 outputs some new record types in its system files, and it
2372 allows longer value labels. Accept these system files.
2374 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
2375 11 emitted by SPSS 8.0.
2377 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
2379 The LIST procedure was too conservative in allocating space for
2380 buffers, which caused a bug that only showed up with very long
2381 output variables. Thanks to Hankin <hankin@dunno.com> for this
2384 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
2386 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
2388 Typo meant string format specifiers weren't checked properly. I
2389 think that Hankin <hankin@dunno.com> sent me this report, but I'm
2390 willing to be corrected on this point.
2392 * format.c: (check_string_specifier) Fix obvious typo.
2394 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
2396 Using $CASENUM in an expression didn't work. Here's a fix.
2397 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
2400 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
2402 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
2404 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
2406 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
2407 other behavior, *sigh*. This patch hopefully fixes that. This
2408 time I've actually tested it.
2410 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
2412 * data-list.c: (read_from_data_list_free,
2413 read_from_data_list_list) Call parse_string_as_format() directly
2414 without mucking around with the field width.
2416 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
2418 Occasionally, you may encounter a script that wants to be
2419 interpreted in interactive mode. Make -i emulate this behavior to
2420 allow such scripts to be executed with PSPP.
2422 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
2424 * cmdline.c: (pre_syntax_message[]) Update -i description.
2426 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
2427 when -i is given on the command line) don't treat unindented lines
2428 as starting a new command.
2430 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
2432 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
2433 mostly caused by local initialized aggregates. After egcs is
2434 fixed upstream these can be removed, but for now they're not a big
2437 * ascii.c: (ascii_postopen_driver) Checker chokes on local
2438 initialized arrays. Avoid this.
2440 * sfm-write.c: (sfm_write_dictionary) Don't use a local
2443 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
2445 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
2446 following changes avoid. Currently I compile sources with egcs
2447 1.1.1 and gcc 2.7.2.3 before sending them out.
2449 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
2451 * ascii.c: (option_tab[]) Initialize all struct members.
2453 * avl.h: (avl_traverser_init) New macro.
2455 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
2458 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
2461 * hash.c: Comment fix.
2463 * hash.h: (hsh_iterator_init) New macro.
2465 * html.c: (option_tab[]) Initialize all struct members.
2467 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
2470 * postscript.c: (option_tab[]) Initialize all struct members.
2471 (output_encodings, preclose, dump_lines) Use new
2472 hsh_iterator_init() macro.
2474 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
2477 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
2480 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
2482 * data-in.c: Examined each of the parsing functions to make sure
2483 that they wouldn't dump core if they were passed a string of the
2484 wrong length, since now the DATA LIST FREE/LIST routines don't
2485 check for field width before passing it to the data parser.
2486 (parse_RBHEX, parse_AHEX) Reject odd length input.
2487 (parse_string_as_format) Reject input that's too short or too
2490 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
2491 a field to its entire declared output width then pass it to the
2492 data-in parsing routines. This contradicted the documented
2493 behavior. This is fixed in these changes. Thanks to Mark H. Wood
2494 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
2495 free-format parsing that differed from SPSS.
2496 (cut_field) Commas and spaces are treated identically. Returns
2497 the proper column instead of a fixed 1 value.
2498 (parse_field) Removed.
2499 (read_from_data_list_free, read_from_data_list_list) Call
2500 parse_string_as_format directly instead of parse_field.
2502 * heap.c: (heap_delete) Stylistic fixes.
2504 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
2506 * loop.c: (loop_2_trns_proc) Formatting fix.
2508 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
2510 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
2512 * vfm.c: (macro FILTERED) New.
2513 (static var filter_var) New.
2514 (process_active_file_write_case) Use FILTERED.
2515 (setup_filter) Set filter_var.
2516 (close_active_file) Delete the filter if not
2517 FILTER_before_TEMPORARY.
2518 (procedure_write_case) Use FILTERED.
2520 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
2522 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
2524 * data-in.c: (parse_day_count) Message fix.
2525 (parse_month) Style fix.
2527 * data-list.c: (struct data_list_pgm) New member eof.
2528 (cmd_data_list) Init eof to 0.
2529 (do_reading) Implement the /END subcommand and read-past-eof
2532 * do-if.c: Include stdio.h when debugging.
2533 (cmd_else_if) Make sure the command is .-terminated.
2535 * glob.c: (init_glob) Capitalize the command prompt.
2537 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
2538 (end_file_trns_proc) Debugging message.
2540 * loop.c: (internal_cmd_loop) Make it work when there's no loop
2542 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
2544 * main.c: (dump_token) Make kwtab[] const.
2546 * set.q: Spelling, comment fixes.
2548 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
2551 * vars-prs.c: (fill_all_vars) Style fix.
2553 * vfm.c: (index_to_varname) Return const.
2555 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
2557 * Changes in many source files for partial -ansi -pedantic and
2558 no-debugging compliance: Remove trailing common in enum
2559 declarations; add `unused' attributes; insert some appropriate
2562 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
2564 * command.c: (shell) Make static.
2565 (run_command) Make static.
2567 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
2569 * dfm.c: (cmd_begin_data) I18n fix.
2571 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
2573 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
2575 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
2578 * file-handle.q: Don't prepend the source file directory name to
2579 the data file name. (Ongoing issue.)
2580 (prepend_current_directory) Comment out.
2581 (internal_cmd_file_handle) Don't call prepend_current_directory().
2582 (fh_get_handle_by_filename) Ditto.
2584 * filename.c: Append zero byte to readlink() return value.
2586 * getline.c: (getl_read_line) I18n fix.
2588 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
2590 * misc.h: Don't use gcc features if __STRICT_ANSI__.
2592 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
2595 * postscript.c: (output_encodings) Don't use local_strdup().
2598 * print.c: Don't use gcc features if __STRICT_ANSI__.
2600 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
2602 * recode.c: (parse_src_spec) Fully brace nested if's.
2604 * set.q: (global var set_testing_mode) New var.
2606 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
2608 * ascii.c: Add some more `unused' attributes that only come into
2609 play when NDEBUG is defined.
2610 (ascii_close_page) Set s_len when reallocating s.
2612 * crosstabs.q: (delete_missing) New function.
2613 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
2614 (make_summary_table) Create summary table reallocable.
2616 * postscript.c: Add more `unused' attributes as above.
2618 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
2619 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
2621 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
2624 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
2625 gratuitous space between parameter definition.
2627 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
2628 complaints about running off the end of functions with NDEBUG
2631 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
2633 * Several source files: Removed some PORTME notes when reflection
2634 revealed that ANSI forbids that sort of breakage. Also, added
2635 lots of `unused' qualifiers here and there.
2637 * aggregate.c: (accumulate_aggregate_info) Remove local var
2638 weighting that turned out not to be used.
2640 * avl.c: Update to version 1.1.0. Add unused specifier.
2641 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
2643 (avl_probe) Replace some instances of 1 with +1 where appropriate.
2644 (avl_find) Cast return value to void *.
2645 (avl_delete) q doesn't need to be initialized at the beginning of
2646 the function. Replace some instances of 1 with +1.
2647 (force_avl_delete) Renamed avl_force_delete, all references changed.
2648 (compare_ints) `param' marked unused.
2649 (print_int) `param' marked unused.
2650 (recurse_tree) Replace some instances of 1 with +1.
2652 * avl.h: Update to version 1.1.0. Only declares avl function
2653 types if not already declared.
2654 (AVL_MAX_HEIGHT) Only define if not already defined.
2655 (struct avl_node) New unused member char pad[2].
2656 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
2657 (force_avl_insert) Renamed avl_force_insert.
2658 (force_avl_delete) Renamed avl_force_delete.
2660 * crosstabs.q: (struct table_entry) Put `freq' into a union with
2662 (struct crosstab) Add new member `ofs'.
2663 (glob var int_tab) Removed.
2664 (custom_tables) In integer mode, assign v[i] properly through the
2666 (custom_variables) Now p.crs.max == max + 1.
2667 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
2668 (precalc) Implement integer mode.
2669 (calc_integer) Implement integer mode.
2670 (compare_table_entry) Remove unused local variable `comparing'.
2671 (make_summary_table) Implement integer mode.
2672 (macro ns_rows) Implemented as static variable now.
2673 (several variables) Made static, from global.
2674 (output_pivot_table) Use table_value_missing() for column heads.
2675 Remove several unused local variables. Implement integer mode
2676 table summing. Count up ns_rows.
2677 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
2678 (find_pivot_extent) Moved into find_pivot_extent_general; now just
2679 calls that function or find_pivot_extent_integer.
2680 (find_pivot_extent_integer) New function.
2681 (enum_var_values) Implemented for integer mode.
2682 (table_value_missing) New function.
2683 (display_dimensions) Call table_value_missing() for heads.
2684 (float_M_suffix) New function.
2685 (display_crosstabulation) Call table_value_missing() for row
2686 heads. Handle missing values in /MISSING=REPORT mode.
2687 (calc_fisher) Remove unused var N.
2688 (calc_r) Remove unused var fact.
2690 * data-list.c: (dump_fixed_table) Fix table dimensioning.
2691 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
2693 * data-out.c: (insert_commas) Remove unused var cp.
2694 (convert_CCx) Remove unused vars save_set_decimal,
2697 * descript.q: (dump_z_table) Fix table dimensioning.
2698 (pre_calc) Remove unused var j.
2699 (display) Remove unused vars title, s. Fix table dimensioning.
2701 * expr-evl.c: Comment fixes.
2703 * frequencies.q: (full_dim) New function.
2704 (dump_full) Fix table dimensioning.
2705 (condensed_dim) New function.
2706 (dump_condensed) Fix table dimensioning.
2708 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
2711 * html.c: (html_close_drive) Remove unused var i.
2712 (postopen) Remove unused vars title, curfn_len, cp.
2713 (preclose) Remove unused vars this, x.
2715 * lexer.c: Comment fixes.
2717 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
2719 * means.q: (custom_tables) Remove unused var m_dim.
2721 * mis-val.c: Format fix.
2723 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
2725 * output.c: (outp_get_paper_size) Remove unused var cp.
2727 * pfm-read.c: (read_float) Remove unused var save, unused label
2729 (read_variables) Remove unused vars cp, j.
2730 (read_value_label) Remove unused var j.
2732 * pfm-write.c: (bufwrite) Remove unused var i.
2734 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
2736 (output_encodings) Remove unused vars char_cp, n_output.
2737 (read_ps_encodings) Remove unused var ep.
2738 (postopen) Remove unused var title.
2739 (preclose) Remove unused var fp.
2740 (ps_open_page) Remove unused vars true, false, orientation,
2741 mirror_horz, mirror_vert, width, length.
2742 (ps_text_metrics) Remove unused var x.
2744 * q2c.c: (find_symbol) Remove unused var y.
2745 (parse_setting) Remove unused parameter sbc, all references
2747 (dump_parser) Remove unused var cp.
2748 (dump_free) Remove unused var i.
2750 * set.q: (static vars args, n) Removed.
2751 (internal_cmd_gset) Removed.
2753 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
2754 (read_machine_flt64_info) Removed unused var file_endian.
2755 (read_documents) Removed unused var i.
2756 (read_compressed_data) Removed unused parameter dict, all
2759 * sfm-write.c: (bufwrite) Removed unused var i.
2760 (sfm_write_case) Removed unused var i.
2762 * sort.c: (merge_once) Remove unused var t.
2763 (write_separate) #if 0 out as dead code.
2765 * split-file.c: (cmd_split_file) Remove unused var i.
2767 * sysfile-info.c: (sysfile_info_dim) New function.
2768 (cmd_sysfile_info) Fix table dimensioning.
2769 (variables_dim) New function.
2770 (display_variables) Fix table dimensioning.
2771 (describe_variable) Remove unused var prev_r.
2773 * t-test.q: (z_postcalc) Removed.
2774 (pairs_calc) Remove unused var bad_weight.
2775 (postcalc) Remove unused vars dfn, dfd.
2777 * tab.c: (tab_create) Set t->dim to NULL.
2778 (tab_dim) Make sure t->dim is NULL first.
2779 (tab_natural_width) Remove parameter `clamp'.
2780 (tab_value) Remove duplicate assertion for table.
2781 (tab_raw) New function.
2782 (nowrap_dim) New function.
2783 (wrap_dim) New function.
2784 (tab_output_text) Fix table dimensioning.
2786 * tab.h: (tab_raw) New macro.
2788 * val-labs.c: (get_label) Remove unused var type.
2789 (copy_value_labels) Remove unused var trav.
2791 * var.h: (struct crosstab_proc) Completely changed.
2793 * vars-prs.c: (parse_dict_variable) Remove unused var v.
2795 * vfm.c: (open_active_file) Remove unused vars i, lp.
2797 * weight.c: (weight_trns_proc) #if 0 out as dead code.
2799 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
2801 * Makefile.am: Add apply-dict.c, flip.c.
2803 * apply-dict.c: New file.
2805 * command.c: (struct command) Make cmd[] larger for CLEAR
2806 TRANSFORMATIONS command name.
2807 (parse_cmd) Make sure we're in a valid state before using it as an
2808 index. Discard variables and reset state on invalid transitions.
2809 (cmd_clear_transformations) New function.
2811 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
2812 Add unimplemented PRESERVE, RESTORE.
2814 * file-handle.h: Include stddef.h.
2818 * pfm-read.c: (parse_value) Pad value label values with spaces,
2821 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
2822 (sfm_close) Decrement reference count, make sure it's zero.
2823 (sfm_maybe_close) New function.
2824 (sfm_read_dictionary) Handle reference counts.
2826 * vars-atr.c: (clear_default_dict) New function.
2827 (discard_variables) Use clear_default_dict().
2829 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
2831 * Makefile.am: Add pfm-write.c.
2832 (LDADD) Add the libgmp2 libraries.
2834 * command.def: Define EXPORT.
2836 * get.c: (cmd_export) New function.
2837 (export_write_case_func) New function.
2839 * pfm-read.c: (static spss2ascii[]) Make it const.
2841 * pfm-write.c: New file.
2843 * sfm-write.c: Formatting, comment fixes.
2845 * var.h: Comment fix.
2847 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
2849 * Makefile.am: Add pfm.h, pfm-read.c.
2851 * command.def: IMPORT is now implemented.
2853 * format.c: (glob var translate_fmt[]) New var.
2855 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
2856 (cmd_import) New function.
2857 (import_source_read) New function.
2858 (glob var import_source) New var.
2860 * pfm-read.c: New file.
2864 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
2866 (dump_dictionary) Disabled printing a couple of items.
2868 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
2870 * crosstabs.q: (postcalc) Call make_summary_table().
2871 (make_summary_table) New function.
2872 (insert_summary) New function.
2873 (display_dimensions) Remove some unnecessary arguments, all
2875 (output_pivot_table) Fix lots of problems with the risk table
2877 (submit) Don't display an empty table.
2878 (display_risk) Fix order of arguments to calc_risk().
2880 * glob.c: Always include assert.h and stdlib.h.
2882 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
2885 * tab.c: (tab_create) Cosmetic changes.
2887 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
2889 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
2893 * crosstabs.q: (output_pivot_table) Headers drawing and submission
2894 code simplified, moved into new function submit().
2895 (submit) New function.
2896 (crosstabs_dim) New function.
2897 (display_directional) Substitute variable names for %s where
2899 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
2900 (calc_symmetric) Initialize parameters only if non-NULL.
2901 Calculate Somers' d.
2902 (calc_directional) Calculate Somers' d (or copy it, really).
2905 * output.c: (outp_string_width) New function.
2907 * postscript.c: (postopen) Calculate font widths based on the
2908 width of the zero '0' character, not the width of the space
2909 character. Set paper-width and paper-length based on points, not
2911 (ps_open_page) Fix page setup string for landscape mode.
2913 * som.h: (struct som_dimension) Removed.
2914 (struct som_table_class) height, width members take int * not
2917 * tab.c: Many functions now have added parameter validation.
2918 (tab_height, tab_width) These functions were removed and merged
2919 into a single function tab_resize(), and all references changed.
2920 (tab_dim) Rewritten since the interface changed; reduced from
2921 hundreds of lines to two. All callers were changed. Currently
2922 most of them just use tab_natural_dimensions as their callback and
2923 await detailed translation of functionality.
2924 (tab_natural_width) New function.
2925 (tab_natural_height) New function.
2926 (tab_natural_dimensions) New function. This is a callback
2927 function, not something that you'd want to call directly.
2928 (tab_nat_dim) Removed.
2929 (tabi_table) Allocates t->w and t->h.
2930 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
2931 dimensions callback.
2932 (evaluate_dimensions) Removed.
2933 (sum_columns) Removed.
2935 * tab.h: (enum TAL_1THIN) Removed.
2936 (enum series t_*) Removed.
2937 (struct tab_table) Members trh, trv changed to unsigned char *
2938 from int *. Member dim changed to a function pointer from a
2939 unsigned char *. Member max_stack_height removed. New members
2941 (macros tab_l, tab_r, tab_t, tab_b) New.
2943 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
2945 * ascii.c: (delineate) Assign last_space_nchars before skipping
2946 spaces, to fix right justification.
2948 * crosstabs.q: (static vars risk, direct) New vars.
2949 (static var pearson_r) Removed.
2950 (glob var chisq_fisher) Made static.
2951 (static vars row_tot[], col_tot[]) Don't include grand total
2953 (static var grand_total) Renamed W, all references changed.
2954 (output_pivot_table) Only make `table' if num_cells != 0. Make
2955 risk and directional tables. Deal with grand total no longer part
2956 of col_tot[]. Free rows and cols after we're done with them.
2957 (display_risk) New function.
2958 (display_directional) New function.
2959 (clac_r) Rewritten so that it stores all its results into its
2960 arguments, so it can be used for Spearman's correlation too.
2961 (calc_symmetric) Added a t[] argument, all references changed.
2962 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
2963 Pearson's r, Cohen's kappa.
2964 (calc_risk) New function.
2965 (calc_directional) New function.
2967 * som.c: (som_submit) Improved debugging code.
2969 * stats.c: (hypercube) New function.
2970 (cube) New function.
2972 (normal_sig) Went back to old implementation, which actually
2975 * stats.h: (macros square, cube, hypercube) Removed. The
2976 equivalent functions in stats.c are inlined here; all references
2977 to square changed to sqr.
2979 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
2981 * crosstabs.q: (N_SYMMETRIC) New define.
2982 (postcalc) Disable debug printing.
2983 (static vars chisq_fisher, pearson_r) New.
2984 (output_pivot_table) Add support for symmetric measures. Add
2985 chi-square output of exact sigs.
2986 (display_chisq) Rewritten.
2987 (display_symmetric) New function.
2988 (gamma_int) New function.
2990 (swap) New function.
2991 (calc_fisher) New function.
2992 (calc_chisq) Check boundary conditions better. Calculate Yates,
2993 Fisher, Mantel-Haenszel tests.
2994 (calc_r) New function.
2995 (calc_symmetric) New function.
2997 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
2999 (chisq_sig) Better boundary conditions. Renamed from
3002 * tab.h: (struct tab_table) New member cf.
3004 * tab.c: (tab_create) Set cf.
3005 (tab_width) New function.
3006 (tab_realloc) Handle cf.
3007 (tab_vline) Handle cf.
3008 (tab_hline) Handle cf.
3009 (tab_box) Handle cf.
3010 (tab_value) Handle cf.
3011 (tab_float) Handle cf.
3012 (tab_text) Handle cf.
3013 (tab_joint_text) Handle cf.
3014 (tab_offset) Handle cf.
3015 (tab_next_row) Handle cf.
3016 (evaluate_dimensions) Handle cf.
3017 (render_strip) Handle cf.
3019 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
3021 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
3022 output_pivot_table().
3023 (output_pivot_table) Moved lots of local variables outside and
3024 made them static. Add beginnings of chi-square statistic
3025 support. Now column and row totals aren't in the main matrix.
3026 Always zero out any leftover rows & columns after we're done with
3027 the table entries. Move all output stuff into
3028 display_dimensions(), display_crosstabs(), display_chisq().
3029 (display_dimensions) New function.
3030 (display_crosstabulation) New function.
3031 (display_chisq) New function.
3032 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
3034 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
3035 references, simplify logic.
3037 * postscript.c: Remove scale, translate-x, translate-y,
3038 mirror-horz, mirror-vert, rotate-180 options.
3039 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
3040 All references deleted.
3041 (macro YT) New macro.
3042 (array option_tab[]) Removed options.
3043 (ps_option) Removed options.
3044 (ps_open_page) Write page setup explicitly to output file, without
3045 using now-deleted BP function.
3046 (macro dump_line) Use YT().
3047 (macro dump_thick_line) Use YT().
3048 (draw_headers) Use YT().
3049 (switch_font) Reorder arguments to SF function.
3050 (write_text) Use YT().
3052 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
3055 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
3057 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
3058 null-debugging code.
3059 (tab_realloc) Remove null-debugging code. Initialize new regions
3061 (tab_vline) Support offsets.
3062 (tab_hline) Support offsets.
3063 (tab_box) Support offsets.
3065 (tab_nulls) Removed.
3068 (evaluate_dimensions) Remove null-debugging code. Understand
3069 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
3070 TAB_EMPTY not present.
3072 * tab.h: New cell attribute TAB_EMPTY.
3073 (macros tab_nr, tab_nc, tab_row, tab_col) New.
3075 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
3076 try to read them from system files.
3078 * vfm.c: (dump_splits) Don't call tab_null().
3080 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
3082 * crosstabs.q: (struct crosstab) Added `missing' member.
3083 (custom_tables) Init missing.
3084 (calc_general) Handle missing values.
3085 (calc_chisq) New function.
3086 (output_pivot_table) Start work on chi-square output. Update for
3087 new tab offset support functions. Shorten statistic names.
3089 * Several files: add in more `const's to placate gcc's warnings.
3091 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
3094 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
3095 tab_null, tab_nulls, tab_value, tab_float, tab_text,
3096 tab_joint_text) Add col_ofs and row_ofs support.
3097 (tab_offset) New function.
3098 (tab_next_row) New function.
3099 (tab_row) New function.
3100 (tab_col) New function.
3101 (tabi_table) Add col_ofs and row_ofs support.
3103 * vars-atr.c: (is_system_missing) New function.
3105 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
3107 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
3108 (static var no_cells) Removed.
3109 (static var num_cells) New.
3110 (static var expected) New.
3111 (static var cells[]) New.
3112 (internal_cmd_crosstabs) Deal with new variables.
3113 (postcalc) Removed most of the meat and put it in new function
3114 output_pivot_table().
3115 (output_pivot_table) Calculates and outputs an entire pivot table.
3117 * postscript.c: (postopen) Fix problems with free()ing addresses
3118 not obtained from malloc().
3120 * som.c: (som_submit) Add assertion.
3122 * sysfile-info.c: (describe_variable) Use new tab_nulls()
3125 * tab.c: (static var tab_names[]) New.
3126 (tab_realloc) -1 for nc or nr indicates no change.
3127 (tab_nulls) New function.
3128 (tab_dim) Use tab_names[].
3129 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
3130 (evaluate_dimensions) Don't terminate on uninited cells, just put
3131 an X in them and emit a notice. Use tab_names[].
3133 * tab.h: Move bits into tab.def.
3135 * tab.def: New. Don't try to declare tab_table_class because then
3136 som.h has to be included.
3138 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
3140 * command.def: New file, contains all the command definitions
3141 previously included bodily in command.c.
3143 * format.def: New file, contains all of the format definitions
3144 previously split across format.h, format.c, and sfm-write.c.
3146 * lexer.h: Renamed from tokens.h in order to match corresponding
3149 * lexerP.h: Moved some rarely used functions exported by lexer.c
3152 * Makefile.am: Commemorate renamed files.
3153 (EXTRA_DIST) Add command.def, format.def.
3155 * command.c: [0] (walk_cmdtable_func) Removed.
3157 * crosstabs.q: (postcalc) Made it work and print out matrices
3159 (enum_column_values) Renamed enum_var_values, generalized for any
3162 * format.h: (struct fmt_desc) New member `spss'.
3164 * q2c.c: (main) Generated code includes lexer.h instead of
3167 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
3168 instead of an independent translation table.
3170 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
3172 * Lots of source files: Added const to declarations.
3174 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
3176 * arena.c: (arena_clear) Set prev pointer to null when done.
3178 * ascii.c: (ascii_option) Rename index as indx.
3180 * avl.c: This is now a separate library called libavl.
3181 (xmalloc) Make static.
3182 (avl_probe) Step A7 can use the cache instead of an explicit
3184 (avl_delete) Don't maintain a q pointer because it's always
3185 available in the pointer stack. Comment fix.
3187 * avl.h: This is now a separate library called libavl.
3189 * command.c: (cmd_table[]) Remove spurious trailing "".
3191 * common.h: Only include random() fix if this system needs it.
3193 * crosstabs.q: Include alloca headers.
3194 (n_sorted_tab) New global var.
3195 (postcalc) Mostly rewritten.
3196 (find_pivot_extent) Rewritten.
3197 (enum_column_values) Rewritten.
3199 * data-out.c: (convert_F) Rename inner n as n_spaces.
3201 * error.c: (dump_message) Don't have an outer var i.
3203 * file-handle.q: (static var f) Removed. All references removed.
3204 (internal_cmd_file_handle) Uses a local variable instead of f.
3206 * get.c: (trim_dictionary) Change scope of i, i1, i2.
3207 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
3210 * getline.h: Declare getl_history as extern. Reported by
3211 palme@uni-wuppertal.de (Hubert Palme).
3213 * postscript.c: (postopen) Some large mods for constness.
3215 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
3218 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
3220 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
3221 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
3224 * avl.c, avl.h: New files. These form a clean-room
3225 reimplementation of avllib. Iterative algorithms are used in
3226 place of recursive ones, so there is no resemblance in the code.
3228 * Lots of headers: Don't include other headers by default.
3230 * Lots of source files: Explicitly include all needed headers.
3232 * arena.c: (arena_clear) New function.
3234 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
3235 (static var ar) Removed.
3236 (staitc vars ar_tc, ar_col) New.
3237 (cmd_crosstabs) Destroy the arenas.
3238 (internal_cmd_crosstabs) Create the arenas.
3239 (precalc) Don't need a free function for the hash.
3240 (calc_general) Make sure to zero out the trailer on the key data
3242 (print_table_entries) Updated.
3243 (postcalc) Worked on actually implementing.
3244 (find_pivot_extent) New function.
3245 (compare_value) New function.
3246 (enum_column_values) New function.
3248 * data-in.c: (parse_month) Make local array `static const'.
3250 * data-out.c: (convert_date) Make local array `static const'.
3251 (convert_WKDAY) Same.
3252 (convert_MONTH) Same.
3254 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
3255 been renamed to avl_walk().
3257 * hash.c: Rewritten more efficiently.
3259 * hash.h: Add attribute const to hsh_next_prime declaration.
3261 * lexer.c: (id_match) Make arguments const.
3263 * postscript.c: (ps_postopen_driver) Make default fonts the
3266 * q2c.c: (main) Generated code needs stdlib.h.
3268 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
3269 initialized to 0 now, not to NULL. All other references to
3270 avl_traverser were updated in the same way.
3272 * tokens.h: Macro version of id_match updated to use const
3275 * val-labs.c: (inc_ref_count) New function.
3276 (copy_value_labels) Simply through use of new avl_copy() function.
3278 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
3280 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
3281 (postcalc) Worked on this.
3283 * postscript.c: (OPO_DOUBLE_LINE) New enum.
3284 (struct ps_driver_ext) New line_width_thick member.
3285 (ps_preopen_drive) Init line_width_thick.
3286 (option_tab[]) Add line-* options.
3287 (ps_option) Parse line-* options.
3288 (postopen) Add line_width_thick support. Strip leading spaces on
3289 prologue output lines.
3290 (ps_open_page) Include line_width_thick in output.
3291 (macro dump_thick_line) New.
3292 (dump_fancy_line) Support thick lines as well as double lines.
3294 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
3296 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
3297 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
3299 * Many source files: Rename `options' to `pv_opts' as appropriate.
3301 * command.c: (static var cmd_table[]) Add CROSSTABS command.
3303 * common.c: (xcalloc) New function.
3305 * crosstabs.q: New file. Not finished yet, though.
3307 * data-list.c: Comment fix.
3309 * error.c: Remove some old Checker cruft.
3311 * frequencies.q: (dump_full) Cumulate valid percent instead of
3314 * getline.c: Comment fix.
3316 * hash.c: Comment fixes.
3318 * hash.h: (struct hsh_table) Make hash functions return unsigned
3319 instead of int to avoid problems with taking the modulo of
3320 negative return values. All references changed.
3322 * misc.c: (intlog10) Make its table static const instead of auto.
3324 * sfm-read.c: (read_header) Make `prefix' static const instead of
3327 * var.h: (union value) Add member `hash'.
3328 (struct variable) Rename prv_index as `foo'--all references
3330 (typedef pv_opts) Removed. All references changed.
3332 * vars-prs.c: (parse_variables) Message fixes.
3334 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
3336 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
3337 they are being inserted. Don't check for BY variables of
3338 different types. Discard variables if the active file isn't
3339 included in the merge.
3340 (mtf_processing) Essentially rewritten.
3341 (mtf_merge_dictionary) Check for master/slave variables of
3342 different types/widths.
3344 * vfm.c: (static var not_canceled) New var.
3345 (process_active_file) Don't call vfm_source->read() if
3346 there's no vfm-source. Initialize not_canceled.
3347 (process_active_file_write_case) Honor and update not_canceled.
3348 (prepare_for_writing) Rollback changes from yesterday, they were
3350 (close_active_file) Don't destroy vfm_source unless it exists.
3352 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
3354 * Lots of source files: Added { } around nested if/else constructs
3355 to avoid new gcc 2.8 warnings.
3357 * data-in.c: (parse_Z) Declare `int' type explicitly.
3360 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
3361 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
3362 prev members. Put TABLEs at the end of the chain and FILEs at the
3363 beginning. Don't allow the active file in STATE_INIT. Use proper
3364 `seen' value for the active file. Fill out the by members and
3365 make sure they're of consistent type. Do the actual merge
3367 (mtf_processing_finish) New function.
3368 (var_type_description) New function.
3369 (mtf_free_file) New function.
3370 (mtf_free) Rewritten.
3371 (mtf_delete_file_in_place) New function.
3372 (mtf_read_nonactive_records) New function.
3373 (mtf_compare_BY_values) New function.
3374 (static var mtf_seq_no) New var.
3375 (mtf_processing) New function.
3376 (mtf_merge_dictionary) Assign nval members for the system file
3377 dictionary. Assign fv values for its variables. Point each slave
3378 variable to the corresponding master variable.
3380 * hash.c: Include str.h.
3382 * mis-val.c: (copy_missing_values) src arg is const.
3384 * misc.c: (spacing) Make `max' var explicitly int.
3386 * sfm-read.c: (dump_dictionary) Message reformatting.
3387 (sfm_read_case) Add assertion.
3389 * sort.c: Esthetic fixes.
3391 * var.h: (struct match_files_proc) New struct.
3392 (struct variable) Add private data match_files_proc.
3394 * vars-atr.c: (delete_variable) Implement. Add argument for the
3395 dictionary that owning the variable.
3396 (dup_variable) Add assertion.
3398 * vfm.c: Comment fixes, hopefully the comments are correct now.
3399 (process_active_file) New function.
3400 (process_active_file_write_case) New function.
3401 (process_active_file_output_case) New function.
3402 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
3404 (write_case) Renamed procedure_write_case(). Now write_case is a
3405 pointer to a function. Style fixes.
3407 1998-03-05 Ben Pfaff <blp@gnu.org>
3409 * Makefile.am: (q2c) Link with libmisc.
3410 (version.c) Define default_config_path, include_path,
3413 * ascii.c: (ascii_postopen_driver) When the default newline string
3414 is requested, open file in text mode. Suggested by
3415 palme@uni-wuppertal.de (Hubert Palme).
3416 (static vars line_buf, line_p) Change from char * to unsigned char
3418 (ascii_close_page) char * to unsigned char *.
3420 * cmdline.c: (parse_command_line) Implement -r option by
3421 prepending ~/.pspp/rc to the list of files to process.
3423 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
3424 before pulling in a final line.
3425 (null_func, null_int_func) Removed (dead code).
3427 * descript.q: (display) Calculate width of variable name column
3428 properly. Calculate number of valid cases properly. Reported by
3429 palme@uni-wuppertal.de (Hubert Palme).
3431 * filename.c: (init_filename) Use default_config_path instead of
3432 now obsolete CONFIG_PATH.
3434 * getline.c: (getl_initialize) Use include_path instead of now
3435 obsolete INCLUDE_PATH.
3436 (getl_add_file) New argument `where'. All references changed.
3438 * groff.c: (find_font_file) Use groff_font_path instead of now
3439 obsolete GROFF_FONT_PATH.
3441 * postscript.c: (find_ps_file) Use groff_font_path instead of now
3442 obsolete GROFF_FONT_PATH. Copy through temporary variable to
3443 avoid problems with constness.
3445 * str.h: (macro cs_streq) New macro.
3447 * version.h: (glob var default_config_path, include_path,
3448 groff_font_path) New vars.
3450 1998-02-23 Ben Pfaff <blp@gnu.org>
3452 * Many source files: Change verbose_msg() priority levels and
3455 * aggregate.c: Include debug-print.h.
3457 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
3459 (static var pre_syntax_message) Document --safer/-s and
3462 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
3464 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
3465 because it's not used but it's still copied.
3466 (open_file_r) Remove gratuitous debug message.
3468 * filename.c: (safety_violation) New function.
3469 (open_file) Remove gratuitous debug messages. Don't allow pipe
3470 files if set_safer is set.
3472 * get.c: Turn off debugging.
3474 * getline.c: (getl_add_virtual_file) New function.
3475 (getl_read_line) Add verbose_msg() call for opening new syntax
3477 (getl_perform_delayed_reset) Add a return value describing whether
3478 any action was taken. Call reset_eof().
3480 * getline.h: Comment fix.
3482 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
3483 place of incorrect `continue'. Use strtok_r() instead of
3484 strtok(). Always check strtok_r() return value.
3485 (groff_read_DESC) Use strtok_r() instead of strtok().
3487 * lexer.c: (reset_eof) New function.
3489 * main.c: (parse) Get a token after performing a delayed reset
3490 action; allow empty syntax files.
3492 * postscript.c: (output_encodings) Use strtok_r() instead of
3495 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
3497 * set.q: Comment fixes.
3498 (glob var set_safer) New var.
3499 (internal_cmd_set) Support SAFER.
3501 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
3503 * temporary.c: (free_dictionary) Set d->splits to NULL after
3506 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
3507 variable deleted, not if it *isn't* deleted.
3509 1998-02-16 Ben Pfaff <blp@gnu.org>
3511 * command.c: (array cmd_table[]) Add MATCH FILES.
3513 * common.c: Comment fixes.
3515 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
3516 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
3517 Include alloca.h. Problem reported by palme@uni-wuppertal.de
3520 * expr-opt.c: Include str.h. Problem reported by
3521 palme@uni-wuppertal.de (Hubert Palme).
3523 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
3524 (static var mtf_by) Change from char ** to variable **.
3525 (static var mtf_master) New var.
3526 (mtf_merge_dictionary) New function.
3527 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
3528 var type. Reorder tests properly. Initialize file->dict. Detect
3529 TABLE= without BY=. Read file dictionaries and merge them. Give
3530 subcommand name with IN, LAST, FIRST error messages. Create IN,
3531 LAST, FIRST variables. Comment fixes.
3532 (mtf_free) Don't free default_dict. Free mtf_master.
3534 * getline.c: Define getl_mode. Change getl_buf_size to size_t
3536 (handle_line_buffer) Cast int to size_t in comparison to avoid
3539 * getline.h: Declare getl_mode extern.
3541 * groff-font.c: (groff_read_font) Type-fix calls to getline.
3542 (groff_read_DESC) Make line_size a size_t.
3543 (match_tok) Parenthesize name to avoid macro expansion.
3545 * mis-val.c: (copy_missing_values) New function.
3547 * postscript.c: (postopen) Make buf_size a size_t.
3549 * sfm-read.c: (dump_dictionary) Make global from static. Print
3550 variable info in parts for easier debugging with Checker.
3552 * temporary.c: (copy_variable) Use copy_value_labels().
3553 (new_dictionary) New arg: whether to copy file label, documents.
3555 * val-labs.c: (copy_value_labels) New function.
3557 * var.h: (enums MISSING_*) Add MISSING_COUNT.
3559 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
3561 (dup_variable) Set prv_index, get.fv, get.nv.
3563 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
3565 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
3567 * Many source files: For ANSI-compliance, add empty statement
3568 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
3569 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3571 * data-in.c: (parse_numeric) Some header files break on
3572 -DBL_MIN_10_EXP because they get a --; add () for safety.
3573 Reported by palme@uni-wuppertal.de (Hubert Palme).
3575 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
3576 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
3577 (dfm_close) Use close_file_ext.
3578 (open_inline_file) Set file.file to NULL, not file.
3579 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
3580 struct and use open_file_ext().
3581 (read_record) Use file.file.
3583 * file-handle.q: (prepend_current_directory) Pass through special
3586 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
3587 (normalize_filename) Pass through special filenames.
3588 (open_file, close_file) Accept pipe| and |pipe syntaxes as
3590 (dirname) Rename blp_dirname() because of name conflict on some
3591 OS. All references changed. Reported by palme@uni-wuppertal.de
3593 (is_special_filename) New function.
3595 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
3596 (trim_dictionary) Conditionalize some of the options on whether
3597 GTSV_OPT_MATCH_FILES is in *options.
3598 (rename_variables) Don't allow variables to be renamed as scratch
3600 (MTF_*) New enum series.
3601 (struct mtf_file) New struct.
3602 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
3604 (cmd_match_files, mtf_free) New functions.
3606 * lexer.c: (match_int) Needed parentheses around name to escape
3607 macro expansion. Reported by Micah Altman
3608 <maltman@www-vdc.fas.harvard.edu>.
3610 * print.c: Needed to include alloca.h. Reported by Micah Altman
3611 <maltman@www-vdc.fas.harvard.edu>.
3613 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
3614 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
3617 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
3618 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3620 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
3622 * html.c: (struct html_driver_ext) Move into htmlP.h.
3623 (html_preopen_driver) Initialize cp_x, cp_y.
3624 (html_submit) Implement as call to output_tab_table().
3625 (change_attributes) New function.
3626 (escape_string) New function.
3627 (output_tab_table) New function.
3629 * list.q: (write_all_headers) Add code for writing headers for the
3631 (clean_up) Write out the html close-table tag.
3632 (determine_layout) Ignore html driver.
3633 (list_cases) Write html data.
3635 * som.c: (som_submit) Move more of the code into output_table().
3637 * tab.c: (static var hit) Make a global var and rename tab_hit.
3638 (static var tab_table_class) Make a global var.
3640 * htmlP.h: New file.
3642 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
3644 * dump-sysfile.c: Removed.
3646 * html.c: (preclose) Change comment in emitted code.
3648 * matrix-data.c: Debugging off by default. Comment fixes.
3649 (static var container) New var.
3650 (cmd_matrix_data) Create and destroy container. Initialize
3651 is_per_factor[] to 0s. Move code into new function
3652 string_to_content_type(). Require split values to be present in
3653 the data when ROWTYPE_ is explicit. Call specific function, not
3654 general read_matrices().
3655 (string_to_content_type) New function.
3656 (context) Exclude all whitespace, not just spaces.
3657 (mget_token) A dot is a number. Add assertion.
3658 (static var data) Renamed nr_data.
3659 (static var factor_values) Renamed nr_factor_values.
3660 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
3661 only specific case. Close data_file before exit.
3662 (fill_matrix) New function.
3663 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
3664 printing. Style fixes. Message fixes. Move code into
3666 (read_matrices_without_rowtype) Rename
3667 matrix_data_read_without_rowtype(). Fix off-by-one error on
3668 loops. Allocate nr_data[] memory from arena.
3669 (read_matrices_with_rowtype) Removed.
3670 (read_splits) Renamed nr_read_splits(). Style fixes.
3671 (read_factors) Renamed nr_read_factors().
3672 (dump_cell_content) Comment fixes. Arguments changed. Change
3673 debug printing. All references changed.
3674 (output_data) Renamed nr_output_data().
3675 (static var wr_content) New var.
3676 (struct factor_data) New struct.
3677 (static var wr_data) New var.
3678 (static var wr_current) New var.
3679 (matrix_data_source_destroy_source) Removed.
3680 (read_matrices_with_rowtype) New function.
3681 (matrix_data_read_with_rowtype) New function.
3682 (wr_read_splits) New function.
3683 (compare_factors) New function.
3684 (wr_output_data) New function.
3685 (wr_read_rowtype) New function.
3686 (wr_read_factors) New function.
3687 (wr_read_indeps) New function.
3688 (glob var matrix_data_source) Make destroy_source member NULL as
3691 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
3693 * lexer.c: (syntax_error) Give better error message when at end of
3696 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
3697 N_SCALAR to output as plain N.
3698 (mdump_token) Change output format.
3699 (context) Fix message output interaction with spaces in input.
3700 (another_token) New function.
3701 (force_eol) Improved error message.
3702 (static var max_cell_index) New var.
3703 (read_matrices) Init `cells'. factor_values is now per-cell.
3704 Init max_cell_index.
3705 (read_data_lines) Replace `compare' local with new `compare' arg.
3706 Debugging messages changed. Only read factors if per_factor.
3707 Propagate error return from read_factors(), force_eol().
3708 Copy N_SCALAR values across the N vector.
3709 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
3710 check parentheses manually since we now have is_per_factor[].
3711 Call read_data_lines() with new args. Check for end of data after
3712 looping, using another_token().
3713 (read_factors) Arguments changed. Use max_cell_index to determine
3714 whether to read or compare factors. Message fixes.
3715 (dump_cell_content) New function.
3716 (output_data) Completely rewritten because content types were
3717 supported to be nested inside factor values, not vice versa.
3719 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
3721 * lexer.c: (syntax_error) Support formatted varargs messages.
3723 * matrix-data.c: Turn debugging on by default.
3724 (static content_type[]) New array.
3725 (static content_names[]) New array.
3726 (static rowtype_, varname_) New vars.
3727 (static is_per_factor[]) New array.
3728 (static split_values) Moved declaration.
3729 (static n_continuous, first_continuous) New var.
3730 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
3731 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
3732 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
3733 Check for continuous variables.
3734 [DEBUGGING] (debug_print) Remove content_names[].
3735 (mdump_token) New macro.
3736 (mget_token_dump) New function.
3737 (mdump_token) New function.
3738 (context) New function.
3739 (mget_token) Fix messages.
3740 (static var data, split_values, factor_values) New vars.
3741 (read_matrices) Manage split_values, factor_values.
3742 (read_data_lines) New function.
3743 (read_matrices_without_rowtype) Implemented.
3744 (read_splits) Message fixes. Uses `just_read'.
3745 (read_factors) New function.
3746 (output_data) New function.
3747 (matrix_data_source_destroy_source) Close the file handle.
3748 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
3751 * str.c: (strpadcmp) Removed.
3753 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
3755 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
3757 * Lots of source files: Add cast to unsigned character to calls to
3758 tolower() and toupper().
3760 * aggregate.c: Set default_dict.splits to NULL.
3762 * command.c: (static variable tab[]) Add MATRIX DATA.
3764 * data-in.c: Add debugging defines. Formatting fixes.
3766 * expr-opt.c: Formatting fixes.
3768 * lexer.c: (syntax_error) Message fixes.
3770 * matrix-data.c: New enum series.
3771 (static vars fmt, section, diag, explicit_rowtype, signle_split,
3772 split_values, n_factors, factors, cells, pop_n, contents,
3773 n_contents) New vars.
3774 (cmd_matrix_data) Finished implementation.
3775 (compare_variables_by_mxd_vartype) New function.
3776 [DEBUGGING] (debug_print) New function.
3777 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
3778 (read_matrices) New function.
3779 (read_matrices_without_rowtype) New function.
3780 (read_matrices_with_rowtype) New function.
3781 (read_splits) New function.
3782 (mget_token) New function.
3783 (force_eol) New function.
3784 [0] (test_tokenizer) New function.
3785 (matrix_data_source_destroy_source) New function.
3786 (glob var matrix_data_source) New var.
3788 * misc.h: Include ieeefp.h if present.
3790 * split-file.h: (cmd_split_file) Changes corresponding to struct
3793 * str.h: Fix memmem prototype.
3795 * temporary.c: (save_dictionary, restore_dictionary,
3796 free_dictionary) Changes corresponding to struct dictionary
3799 * var.h: (MXD_* enums) New enum series.
3800 (struct matrix_data_proc) New struct.
3801 (struct split) Removed.
3802 (struct dictionary) Changed `splits' member from `split *' to
3804 (macro force_create_variable) New macro. Replaced lots of
3805 create_variable()/assert() calls with calls to this macro.
3807 * vars-atr.c: (discard_variables) Changed assertion.
3808 [GLOBAL_DEBUGGING] (force_create_variable) New function
3809 called by the macro of the same name.
3810 (clear_variable) Changes to delete splits from the dictionary
3811 corresponding to struct dictionary changes.
3813 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
3814 corrupted variable `index' values in the dictionary passed in
3815 every time this function is called.
3817 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
3818 to struct dictionary changes.
3820 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
3822 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
3824 * command.c: New includes.
3825 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
3826 (cmd_erase) New function.
3827 [unix] (shell) New function.
3828 (run_command) New function.
3829 (cmd_host) New function.
3830 (cmd_new_file) New function.
3832 * expr-prs.c: (parse_primary) Message fix.
3834 * inpt-pgm.c: Formatting fix.
3835 (cmd_reread) Implement the FILE subcommand.
3837 * matrix-data.c: New file.
3839 * q2c.c: (dump_header) Change output commenting style.
3841 * weight.c: Comment fix.
3843 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
3845 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
3847 (buf_10x) Renamed buf_1xx, all references changed.
3848 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
3849 cases now implemented).
3850 (create_sysfile) New function.
3851 (agr_11x_func) New function.
3853 * data-in.c: (parse_numeric) Work properly if there's an
3854 explicitly coded decimal point in the data and decimal places are
3855 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
3856 <el@linux.lisse.na>.
3858 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
3859 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
3860 Eberhard W Lisse <el@linux.lisse.na>.
3862 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
3863 strerror.c. Bug reported by Alexandre Oliva
3864 <oliva@dcc.unicamp.br>.
3866 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
3867 (static var separate_case_tab) New var.
3868 (cmd_sort_cases) Cancel temporary transformations here. Free
3869 v_sort before return.
3870 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
3871 we're reading from a sort stream. Don't cancel temporary
3872 transformations. Offload internal sorting to do_internal_sort().
3873 (do_internal_sort) New function. Handles internal sorting even
3874 when SEPARATE is nonzero. Doesn't free v_sort.
3875 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
3877 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
3878 sink if SEPARATE is zero.
3879 (read_output_cases) Renamed read_sort_output(), all references
3880 changed. Now uses separate_case_tab when it exists.
3881 (write_separate) New function.
3883 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
3884 memory_sink_cases. Don't redundantly call
3885 vfm_source->destroy_source().
3886 (memory_stream_mode) After switching over, set memory_sink_cases
3889 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
3891 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
3893 (static var prev_case) New, moved out of aggregate_single_case()
3895 (static var buf64_10x, buf_10x) New.
3896 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
3897 the 000, 001, 100, and 101 cases. Free prev_case.
3898 (parse_aggregate_functions) Disallow scratch variables.
3899 (free_aggregate_functions) Only free agr_dict if non-null. Use
3900 iter->function to determine numeric/string type, not
3902 (aggregate_single_case) Don't manage prev_case. Initialize
3903 aggregate info after dumping it.
3904 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
3905 mean, stddev, weighted stddev definitions.
3906 (dump_aggregate_info) Implemented.
3907 (initialize_aggregate_info) Renamed from
3908 initialize_aggregate_functions(). Initializes dbl[2].
3909 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
3910 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
3912 * cases.c: (alloc_val) Removed.
3914 * get.c: (cmd_save_internal) Initialize new `dict' member.
3916 * sfm-write.c: (sfm_write_dictionary, write_header,
3917 write_variable, write_value_labels, write_documents) Reorganize,
3918 simplify for new parameter structure.
3919 (write_variable) Only one variable * argument now.
3921 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
3922 replaced by new `dict' member.
3924 * temporary.c: (new_dictionary) Initialize n_documents.
3926 * vars-atr.c: (dup_variable) Allocate `value's from dict into
3928 (init_variable, replace_variable) Eliminate usage of alloc_val().
3930 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
3932 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
3933 signal that AGGREGATE is to be used for forming final cases.
3934 (close_active_file) Call end_func before stopping lagging. Cancel
3935 temporary after finishing compaction.
3936 (write_case) Comment fixes. Cleaned up.
3937 (compact_case) Let AGGREGATE handle compaction when `temporary' is
3940 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
3942 * Makefile.am: (BUILT_SOURCES) Add means.c.
3943 (pspp_SOURCES) Add means.c.
3944 (EXTRA_DIST) Add means.q.
3946 * command.c: (array cmd_table[]) Add MEANS.
3948 * common.h: Esthetic fixes. Comment fixes. Test for
3949 MAX_SHORT_STRING greater than 8.
3950 (macros LOWEST, HIGHEST) New.
3952 * data-in.c, data-list.c, recode.c: Comment fixes.
3954 * means.q: New file, base version.
3956 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
3957 with LOWEST, DBL_MAX with HIGHEST.
3959 * q2c.c: (dump_vars) Add an enum to array types giving the number
3960 of values for the enum.
3962 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
3963 Replace second_lowest_value with second_lowest_flt64.
3965 * sfm-write.c: (write_variable, write_rec_7_34) Replace
3966 second_lowest_value with second_lowest_flt64.
3968 * t-test.q: Comment fix.
3970 * temporary.c: (restore_dictionary) Esthetic fix.
3972 * tokens.h: (force_match_id, force_match, force_string, force_int,
3973 force_num, force_id) Replace msg() with syntax_error().
3975 * var.h: (struct means_proc) New.
3976 (struct variable) Add mns member to `p' union.
3978 * vars-prs.c: (parse_variable, parse_dict_variable,
3979 parse_variables, parse_DATA_LIST_vars) Replace msg() with
3982 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
3984 * Makefile.am: (pspp_SOURCES) Add tab.h.
3986 * Most source files: Added a cast to unsigned char in usages of
3987 the ctype is*() functions. Replaced `end of command expected'
3988 calls to msg() with calls to syntax_error().
3990 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
3992 * lexer.c: (hex_val) Removed (was dead code).
3993 (idmatch) Parenthesize function name to avoid macro expansion.
3995 * postscript.c: Comment fixes.
3996 (ps_preopen_driver) Change default font size to 10pt.
3998 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
4000 (parse_format_spec) Change system-file format spec argument type
4001 to int32. Parse the format spec with bitwise operators.
4003 * sfmP.h: (struct sysfile_format) Removed.
4004 (struct sysfile_variable) Changed print, write members from
4005 sysfile_format to int32.
4007 * tokens.h: Esthetic fixes.
4008 [__GNUC__] (macro id_match) New macro to hopefully speed up
4009 identifier matching.
4010 (macros match_id, match_tok, match_int) Implemented in
4011 compiler-independent manner; no longer GNU C only.
4013 * vfm.h: Include time.h.
4015 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
4017 * data-list.c: (dump_fixed_table) Change tab_dim().
4019 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
4021 * error.c: Include command.h.
4023 * frequencies.g: Formatting fixes.
4025 * frequencies.q: Add tab_dim() calls. Make the total cell a
4028 * glob.c: Include command.h.
4030 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
4032 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
4033 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
4034 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
4035 the other elements (is this right?).
4036 (read_variables) Use lowest, highest members.
4037 (parse_format_spec) New arg `vv' for more stringent checking.
4038 (dump_dictionary) Byteswaps nonexplicit data.
4039 (sfm_read_case) Byteswap numeric data.
4041 * som.c: Initialize table_num to 1.
4042 (render_segments) Remember to increment y_index after each table
4045 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
4046 avl_count() on a NULL tree. No title for the second table.
4047 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
4048 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
4049 fix call to display_variables().
4050 (display_variables) Default to 4 columns, not 3. Set up headers.
4051 Column title is Variable, not Name. Fix index column.
4052 Add joint text. Add tab_dim(). Handle value labels properly.
4053 Handle DISPLAY LABELS properly. Draw boxes correctly.
4054 (describe_variable) Value labels don't need titles. Don't clear
4055 nonexistent index column.
4056 (compare_vectors_by_name) New function.
4057 (display_vectors) New function.
4059 * tab.c: (tab_height) Add assertion.
4060 (tab_null) Add debug code.
4061 (evaluate_dimensions) Add debug code.
4063 * var.h: (struct variable) get_proc data is sometimes used
4064 simultaneously with other per-procedure info, therefore it was
4065 removed from the union. All references changed.
4067 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
4069 * ascii.c: (ascii_close_page) Put title on second line of headers
4070 if there is no subtitle.
4072 * command.c: (glob var cur_proc) Move definition here, from
4074 (cmd_remark) Emit blank line before remarks.
4076 * command.h: (glob var cur_proc) Move declaration here, from
4079 * data-list.c: (dump_fixed_table) Fix messages.
4080 (dump_free_table) Call tab_nat_dim().
4082 * descript.q: (dump_z_table) Modify tab_dim() call.
4084 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
4086 (dump_statistics) Don't output header.
4088 * groff-font.c: Minor format fix.
4090 * html.c: Comment fix.
4092 * list.q: (write_varname) Indent after advancing page.
4094 * output.h: Minor reordering.
4096 * postscript.c: Comment fixes. Many places, '\n' was replaced by
4097 a reference to eol[].
4098 (struct ps_driver_ext) New member eol[].
4099 (ps_preopen_driver) Initialize eol[].
4100 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
4101 defaults. Handle headers. Fix test for minimum page length.
4102 (static var option_tab[]) Add `line-ends'.
4103 (ps_option) Handle line-ends to change eol[].
4104 (postopen) Scale prop_em_width and fixed_width properly. Set the
4105 prologue title to outp_title if applicable. Replace the prologue
4106 line ends with eol[]. Call draw_headers() if headers are enabled.
4107 (text_width) New function.
4108 (out_text_plain) New function.
4109 (draw_headers) New function.
4111 * print.c: (dump_table) Call tab_nat_dim().
4113 * som.c: (som_blank_line) Only advance a line if not at the top of
4115 (som_submit) Move several informational table calls here.
4116 Increment subtable_num if SOMF_NO_TITLE not set.
4117 (output_table) Advance a line if SOMF_NO_SPACING not set.
4118 (render_columns, render_segments, render_simple) Handle spacing
4119 between tables. Handle table titles. Remove debug output.
4121 * som.h: (SOMF_*) New enum series.
4122 (struct som_table_class) New member `flags'.
4124 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
4126 (display_variables) Calls tab_nat_dim().
4127 (describe_variable) Remove restriction on number of value labels.
4128 Make value labels separated by thin lines.
4130 * tab.c: (tab_create) Default `flags' to none.
4131 (tab_float) New arg `w'. All references changed.
4132 (tab_nat_dim) New function.
4133 (tab_output_text) No title or spacing.
4134 (tab_flags) New function.
4135 (tabi_flags) New function.
4136 (tabi_title) New function.
4137 (strip_height) Removed.
4138 (tabi_render) Skip title when necessary.
4139 (static var tab_tab_class) Add tabi_flags, tabi_title.
4140 (evaluate_dimensions) Disable display of column, row size.
4141 (sum_columns) Add title height to top header.
4142 (render_strip) Moved within file.
4144 * tab.h: (struct tab_table) New member `flags'.
4146 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
4148 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
4150 * Most source files: Add `const' attribute in all appropriate
4153 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
4154 column to the variables table for use by describe_variable().
4155 (cmd_display) Disable for the present.
4156 (display_documents) Don't wrap documents.
4157 (display_variables) Table has four columns now.
4158 (describe_variable) Table has four columns now. Don't use a
4159 subtable, use joined cells instead.
4161 * tab.c: (tab_create) Don't set `join'.
4162 (tab_realloc) ct array is not made up of a_string's.
4163 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
4164 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
4165 (text_format) New function.
4166 (tab_title) Rewritten, uses text_format().
4167 (tab_text) Rewritten, uses text_format().
4168 (tab_joint_text) New function.
4170 (static var hit) New variable.
4171 (render_strip) New args r1, r2. Implement joined cells that fit
4173 (tabi_render) Increment hit. Pass new args to render_strip().
4174 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
4175 cells. For t_naw and t_nah, ignore joined cells and null cells in
4178 * tab.h: (struct tab_join_rect) Removed.
4179 (struct tab_table) Removed `join'.
4180 (TAB_JOIN_MAIN) Removed.
4181 (struct tab_joined_cell) New struct.
4182 (TAT_NOWRAP) New enum.
4184 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
4186 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
4188 (ascii_postopen_driver) Fix initialization of *_spacing so that
4189 the TAL_0 bit doesn't count.
4191 * data-list.c: (dump_fixed_table) Use natural width for Format
4194 * glob.c: (rerange) Removed.
4195 (get_date) Formatting fixes. Internationalization fix.
4197 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
4200 * postscript.c: (ps_postopen_driver) Replace
4201 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
4203 * som.c: (som_submit) Don't eject page before every table.
4204 (output_table) Fix order of arguments on call to area().
4205 (render_columns) Fix calculation of max_len.
4207 * tab.c: (tabi_cumulate) Minor change to increase elegance.
4208 (render_strip) New function.
4209 (strip_height) New function.
4210 (tabi_render) Rewrite as calls to render_strip().
4212 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
4213 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
4214 with the TAB_* and OUTP_T_* constants.
4216 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
4218 * Makefile.am: Formatting fixes.
4220 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
4223 * data-list.c: (dump_fixed_table) Add tab_dim() call.
4225 * descript.q: (dump_z_table, display) Add tab_dim() calls.
4227 * dump-sysfile.c: (glob var length) Make type off_t.
4228 (usage) Fix arguments.
4231 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
4232 Now right-justification is the default so many references had to
4234 (struct outp_class) Removed line_width, all references changed.
4235 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
4236 (struct outp_driver) Add elements horiz_line_width,
4237 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
4240 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
4242 (postopen) Initialize all the informational members of
4245 * som.c: (som_blank_line) New function, renamed from blank_line(),
4246 all references changed.
4247 (som_submit) Disables drivers whose pages can't be opened.
4248 (render_columns, render_simple, render_segments) Add debug output.
4249 (render_columns) Fix loop range.
4250 (render_simple) Don't try to render the headers, they're taken
4251 care of automatically. Advance cp_y past the table when done.
4252 (render_segments) Fix loop ranges.
4254 * tab.c: Initialize new members of tab_table.
4255 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
4256 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
4257 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
4260 (tab_dim) New function.
4261 (tab_col_width) Removed.
4262 (tab_row_height) Removed.
4263 (tab_output_text) Call tab_dim().
4264 (tabi_driver) Call evaluate_dimensions(), sum_columns().
4265 (tabi_area) Implemented.
4266 (tabi_cumulate) Implemented.
4267 (tabi_render) Partially implemented, but broken.
4268 (var tab_table_class) Made static.
4269 (evaluate_dimensions) New function.
4270 (sum_columns) New function.
4272 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
4273 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
4274 t_scr, t_srr, t_sentinel. Removed: t_nat.
4275 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
4276 max_stack_height, w, h. Removed: ce, re.
4277 (macro blank_line) Removed.
4278 (glob var zero_length) Removed.
4280 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
4282 * Most source files: include some of the new include files broken
4285 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
4288 * aggregate.c: (glob var outfile) Make static.
4290 * command.c: (glob var pgm_state) Move here.
4292 * common.c: (glob vars endian, second_lowest_value, pgmname,
4293 finished, curdate, cur_proc, start_interactive, history_file) Move
4296 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
4298 * file-handle.q: (glob vars files, inline_file) Move here.
4300 * glob.c: Lost lots of glob vars, detailed in individual file
4302 (init_glob) set_printer, set_screen were obsolete, deleted.
4303 set_cprompt has fewer spaces because pspp has fewer letters than
4306 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
4307 (inp_nval) Made static.
4309 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
4310 tokstr_len, toklongstr, tokint) Move here.
4312 * misc.c: Lost several vars and functions.
4314 * set.q: (all the set_* variables) Move here.
4316 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
4317 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
4320 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
4322 * tab.h: (enum series t_*) New enums.
4323 (struct tab_table) Use arena struct tag. New members ce, re.
4325 * tokens.h: Comment fixes.
4327 * var.h: Move lots of enums and variables and functions and
4328 structures to other files. Use and declare a lot more union and
4329 struct tags. Comment fixes.
4331 * vector.c: (glob vars vec, nvec) Move here.
4333 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
4334 init_blanks, last_vfm_invocation) Move here.
4336 * cases.h: New file.
4337 (struct long_vec) Move here.
4338 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
4341 * command.h: New file.
4342 (STATE_* enums) Move here.
4343 (glob var pgm_state) Move here.
4345 * format.c: New file.
4346 (glob var formats) Move here.
4347 (parse_format_specifier_name, fmt_to_string,
4348 check_input_specifier, check_output_specifier,
4349 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
4352 * format.h: New file. Move functions now in format.c here.
4353 (FMT_* enums) Move here.
4354 (struct fmt_desc) Move here.
4355 (FCAT_* enums) Move here.
4356 (struct fmt_spec) Move here.
4357 (glob vars formats, fmt_parse_ignore_error) Move here.
4359 * inpt-pgm.h: New file.
4360 (INP_* enums) Move here, make #defines into enums.
4361 (glob vars inp_init, inp_init_size) Move here.
4364 (glob vars v_sort, nv_sort) Move here.
4365 (sort_cases, read_sort_output) Move here.
4367 * vector.h: New file.
4368 (struct vector) Move here, add struct tag.
4369 (glob vars vec, nvec) Move here.
4370 (find_vector) Move here.
4373 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
4374 reinit_blanks, init_zero, init_blanks) Move here.
4375 (struct case_stream) Move here.
4376 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
4377 vfm_disk_stream, sort_stream, data_list_source,
4378 input_program_source, file_type_source, get_source, n_lag) Move
4380 (procedure, write_case, lagged_case, compact_case, page_to_disk)
4383 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
4385 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
4386 (LDADD) Add libdcdflib.
4388 * ascii.c: Comment and formatting fixes. Almost every external
4389 function had an assert added, checking driver_open and page_open.
4390 (ascii_init_driver) Broken into ascii_preopen_driver,
4391 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
4392 (ascii_open_page) Sets page_open.
4393 (ascii_close_page) Clears page_open.
4395 * html.c: Comment and formatting fixes. Almost every external
4396 function had an assert added, checking driver_open and page_open.
4397 (html_init_driver) Broken into html_preopen_driver,
4398 html_postopen_driver, html_close_driver. Manages driver_open.
4399 (html_open_page) Sets page_open.
4400 (html_close_page) Clears page_open.
4401 (html_submit) Disabled.
4403 * lexer.c: (parse_string) Remove debugging printf.
4405 * list.q: (determine_layout) Open a page if one is not yet open.
4407 * output.c: Comment fixes.
4408 (add_class) Set the class member of the new list element.
4409 (parse_options) Don't handle device type.
4410 (colon_tokenize) New function.
4411 (configure_driver) New four-field format with a field for device
4412 type. Now initialize driver_open, page_open, next, and prev
4413 fields. Use new colon_tokenize() function. Don't do a memory
4414 copy to replace a driver, it doesn't work; instead delete the old
4415 driver and insert a new one.
4416 (destroy_driver) Don't call som_destroy_driver(). Close the page
4417 if it's open. Find the class in the list of classes and decrement
4418 that reference count. Remove the driver from the global driver
4420 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
4421 references changed. Rewritten. Don't return a driver that's not
4423 (outp_eject_page) All references to som_internal_eject_page()
4424 changed to use this. Sets cp_x to 0 as well as cp_y.
4426 * output.h: (OUTP_I_* enums) Removed.
4427 (struct som_submission_form) Removed.
4428 (struct outp_class) init_driver broken into preopen_driver,
4429 postopen_driver, and close_driver. submit changed to take a
4432 * postscript.c: Comment and formatting fixes. Almost every
4433 external function had an assert added, checking driver_open and
4435 (ps_init_driver) Broken into ps_preopen_driver,
4436 ps_postopen_driver, ps_close_driver. Manages driver_open.
4437 (ps_open_page) Sets page_open.
4438 (ps_close_page) Clears page_open.
4440 * som.c: New file, base implementation.
4442 * som.h: (struct som_table) Add struct tag.
4443 (enum SOM_COL_ACROSS) Removed.
4444 (SOM_ROWS, SOM_COLUMNS) New enums.
4445 (struct som_table_class) Add member `cumulate'. Remove `segment';
4446 change `render' arguments.
4447 (struct som_point, struct som_rect) Removed.
4448 (som_submit_table) Fixed typo, should have been som_submit.
4450 * sysfile-info: (describe_variable) Don't try to insert a
4451 subtable; just destroy it for now.
4453 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
4454 references to value labels.
4456 * tab.c: (tab_destroy) New function.
4457 (tab_columns) Change argument.
4458 [0] (tab_submit) Remove dead code.
4459 (tab_title) Allocate string from the table's arena.
4460 (tab_output_text) Only free the buffer if we allocated it.
4461 (tab_submit) New function.
4462 (static vars t, d) New static vars.
4463 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
4464 tabi_headers, tabi_cumulate, tabi_render) New functions.
4465 (glob var tab_table_class) New global var.
4467 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
4468 encapsulate the rectangle. All references changed.
4470 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
4472 * All header files updated to use struct tags in addition to
4473 typedefs for all structures. Don't use word `struct' in struct
4476 * Makefile.am: (pspp_SOURCES) Remove html.c.
4477 (INCLUDES) Replace the lib/* includes with a single lib/ include;
4478 all references updated.
4480 * command.c: (parse_cmd) Remove call to som_check_workspace.
4481 (output_line) Update to new som.
4483 * data-in.c: (parse_numeric) A single dot is not an error; it is
4484 the system-missing value.
4486 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
4489 * data-out.c: Added `const' as appropriate to many prototypes.
4490 (convert_E, convert_F, convert_CCx) Take double argument instead
4491 of value * argument.
4492 (convert_format_to_string) Call changed functions appropriately.
4493 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
4494 make a local copy of the value.
4496 * descript.q: Remove custom_variables() prototype now provided by
4498 (custom_variables) Don't increment sbc_variables, the caller does
4500 (dump_z_table, display) Update to new som.
4502 * error.c: (vmsg) Add const to prototype. Remove code to handle
4503 `too many errors' condition.
4504 (check_error_count) New function.
4505 (msg) Add const to prototype.
4507 * filename.c: (open_file) Rewrite for elegance.
4509 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
4510 (dump_full, dump_condensed, dump_statistics) Update for new som.
4512 * list.q: Don't include somP.h. Change all references to
4513 som_driver_ext to refer to the new members of som_driver. Change
4514 som_internal_eject_page() references to outp_eject_page().
4516 * main.c: (parse) Rewrite for elegance. Add call to
4517 check_error_count().
4519 * output.c: (add_class, outp_list_classes, outp_configure_driver)
4520 Rewrite or revise for new outp_driver_class_list structure.
4521 (outp_iterate_enabled_drivers) Fix comparison between disabled
4522 devices and current device type.
4523 (outp_eject_page) New function.
4525 * output.h: Comment fixes.
4526 (struct outp_driver) New members driver_open, page_open, cp_x,
4527 cp_y, font_height, prop_em_width, fixed_width. Deleted members
4529 (struct outp_driver_class_list) New struct.
4530 (outp_class_list) Changed to type outp_driver_class_list; all
4533 * print.c: (dump_table, print_trns_proc) Updated for new som.
4535 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
4536 prototypes for custom subcommands.
4537 (dump_subcommand) Always include the `else'.
4538 (dump_parser) Fix comments in output code.
4540 * set.q: Reordered functions.
4542 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
4544 * som.h: Rewritten from scratch.
4546 * str.h: Remove dead code.
4548 * tab.c, tab.h: New files, base implementation.
4550 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
4553 * t-test.q: New code from John Williams
4554 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
4555 Many many new static vars and defines.
4556 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
4557 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
4558 (struct value_list) New struct.
4559 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
4560 t_crt, t_sig, print_t_groups) New functions.
4561 (cmd_t_test) Implemented.
4563 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
4566 * vfm.c: (dump_splits) Update to new som.
4568 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
4570 * Makefile.am: (fiasco_SOURCES) Add html.c.
4572 * aggregate.c: Base source.
4574 * ascii.c: (postopen, preclose) Reformat.
4576 * data-out.c, expr-evl.c: Comment fixes.
4578 * filename.c: (open_file) When opening a file for writing, use
4579 line buffering instead of full buffering for better interactive
4580 performance. Suggested by Valerio Aimale
4581 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
4582 names `stdin', `stdout', `stderr'.
4584 * groff-font.c: Comment fixes.
4586 * html.c: New file; base version.
4588 * list.q: (write_all_headers, clean_up, determine_layout,
4589 list_cases) Ignore `special' devices for now. Needs to be fixed
4592 * output.c: (outp_init) Add html driver to list; reverse list
4595 * output.h: (struct outp_class_struct) New members `special',
4596 `submit'; comment fixes. All references changed.
4598 * postscript.c: (ps_init_driver) Make defaults for text_opt,
4599 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
4601 (postopen) Comment fix.
4602 (preclose) Comment fixes, formatting fixes. Change x->file.file
4603 references to more proper f->file.
4605 * som-high.c: (som_submit_table) Special classes use their own
4608 * som.h: Comment fixes.
4610 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
4613 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
4615 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
4617 * aggregate.c: Still working on this.
4619 * command.c: (cmd_table[]) Add AGGREGATE back in.
4620 (split_words) Make '-' a legal word separator as well as ' '.
4622 * main.c: Comment fixes.
4624 * q2c.c: (dump_parser) Don't require the procedure's full name to
4625 be present, in the generated source.
4627 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
4628 multiply specified and let it be default; let MISSING, CRITERIA,
4629 FORMAT be multiply specified.
4630 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
4631 (custom_groups) Fix defaults.
4632 (custom_pairs) Check whether this is a PAIRS subcommand before
4633 attempting to parse. Better garbage collection. Proper storage
4635 [DEBUGGING] (debug_print) New function.
4637 * temporary.c: Comment fixes.
4638 (copy_variable) Don't copy variable name and index.
4639 (save_dictionary) Copy variable name and index by hand.
4641 * vars-atr.c: Comment fixes.
4642 (create_variable) New dictionary argument. All references
4644 (common_init_stuff) New dictionary argument. All references
4646 (init_variable) New dictionary argument. All references changed.
4647 (dup_variable) New function.
4649 * vars-prs.c: (parse_variables) If there are any errors, we always
4650 return 0. Previously, it was possible for some types of errors to
4653 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
4655 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
4658 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
4660 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
4663 * q2c.c: Comment fixes.
4664 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
4666 * t-test.q: (cmd_list) Rename cmd_t_test.
4668 * temporary.c: (new_dictionary) Don't declare as static.
4670 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
4672 * aggregate.c: Changes, still not finished.
4674 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
4676 * q2c.c: Comment fixes. Now its output is internationalized.
4677 (get_token) Fix parsing of escapes within literal strings.
4678 (main) Fix bad #line directives in output.
4680 * t-test.q: Base implementation.
4682 * temporary.c: (new_dictionary) New function.
4683 (restore_dictionary) [__CHECKER__] Change fill character to *
4686 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
4688 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
4690 * aggregate.c: Changes, still not finished.
4692 * descript.q, list.q: Comment fixes.
4694 * q2c.c: Almost completely rewritten.
4696 * t-test.q: New file, not complete.
4698 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
4700 * aggregate.c: Changes, still not finished.
4702 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
4705 * temporary.c: (cancel_temporary) New function.
4707 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
4708 of doing it by hand.
4710 * vfm.c: (close_active_file) After restoring a TEMPORARY
4711 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
4713 (SPLIT_FILE_procfunc) Comment fix.
4715 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
4717 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
4719 * aggregate.c: New file, not finished yet.
4721 * command.c: (cmd_table) Add AGGREGATE.
4723 * common.h: (pgm_state) Move declaration to var.h.
4725 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
4727 (parse_string) Message fix.
4729 * recode.c: Comment fix.
4731 * sfm-read.c: (read_variables) Code esthetic fixes.
4732 (write_header) Default date is `Jan', not `JAN'.
4734 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
4736 * sort.c: (cmd_sort_cases) Farm the work out to new function
4737 parse_sort_variables().
4738 (parse_sort_variables) New function.
4739 (sort_cases) New function. Cancels temporary transformations,
4740 which sorting didn't do previously.
4741 (cmd_sort_cases) Better garbage collection on error. Uses
4743 (write_initial_runs, merge_once) Improved code esthetics.
4744 (sort_stream_read) Reduced to one call to read_output_cases().
4745 (read_output_cases) New function.
4747 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
4748 variable labels to 120 characters.
4750 * var.h: Comment fixes.
4751 (glob var pgm_state) From common.h.
4753 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
4755 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
4756 options. Set *names to NULL on error.
4758 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
4760 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
4762 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
4763 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
4765 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
4767 * vfm.c: (page_to_disk) Added missing local variables.
4769 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
4771 * get.c: Comment fix.
4773 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
4774 source is anything other than a disk stream, not just if it's in a
4775 memory stream. Call page_to_disk() before external sort.
4776 (allocate_cases) Message fix.
4778 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
4780 (page_to_disk) New function.
4782 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
4784 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
4786 * common.h: (macro strerror) Remove. From Alexandre Oliva
4787 <oliva@dcc.unicamp.br>.
4789 * get.c: (dict_delete_run) The number of variables to delete is
4790 not necessarily the number of variables that need to be shifted
4792 (trim_dictionary) Don't set *options to 0. Fix bug that caused
4793 too many variables to be deleted.
4795 * postscript.c: Comment fix.
4797 * q2c.c: Include strerror.c. From Alexandre Oliva
4798 <oliva@dcc.unicamp.br>.
4800 * set.q: #undef ON and OFF. From Alexandre Oliva
4801 <oliva@dcc.unicamp.br>.
4803 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
4804 early, otherwise errors cause a bad free().
4806 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
4807 Oliva <oliva@dcc.unicamp.br>.
4809 * temporary.c: (save_dictionary) Don't allocate memory if
4812 * vfm.c: (memory_stream_write) Message fix.
4814 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
4816 * command.c: (static var cmd_table[]) Define REPEATING DATA
4819 * common.h: Added support for broken systems that are missing
4820 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
4822 * Many source files: Replace syntax error messages via msg() with
4823 call to syntax_error().
4825 * data-list.c: (dump_fixed_table) Add support for dumping table
4826 for REPEATING DATA as well as DATA LIST FIXED.
4827 (cmd_repeating_data) Allows and requires `/' between subcommands.
4828 Does proper thing with allowing rpd.starts_end to stay 0. Allows
4829 CONTINUED specifications to be omitted. Forces CONTINUED to be
4830 specified if ID is. Calculates starts_end, cont_end from logical
4831 record length as reported by fhp. Calls dump_fixed_table() if
4832 requested. Fixed length of record copied by memcpy.
4833 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
4835 (realize_value) Returns sensible value for out-of-range variable
4837 (rpd_parse_record) New argument `ofs'. Fixed confusion between
4838 length of occurrences and length of line. Added warning for
4839 fields that exceed the line length. Fixed infinite loop.
4840 (read_one_set_of_repetitions) Numerous minor changes for more
4841 complete SPSS compliance. Message fixes.
4843 * dfm.c: (dfm_close) If the file being closed is the inline file,
4844 read all the remaining data before closing it.
4845 (dfm_get_record) Don't close the file on lossage, as either it
4846 has been closed already or it doesn't belong to us.
4848 * error.c: (puts_stdout) New function.
4849 (vmsg) Use puts_stdout instead of puts.
4851 * file-handle.q: (fh_record_width) New function.
4853 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
4856 (input_program_source_read) Made an old kluge an approved method.
4858 * lexer.c: (syntax_error) New function.
4860 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
4863 * output.c: (oupt_get_paper_size) Message fix.
4865 * q2c.c: Numerous fixes to formatting of generated code made to
4866 conform to GNU coding standards. Uses syntax_error() in generated
4867 code. Other miscellaneous generated message fixes. Added support
4868 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
4869 RAND_MAX, and/or strerror().
4871 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
4873 * data-in.c: Comment fixes.
4875 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
4876 (find_variable_input_spec) New function.
4877 (cmd_repeating_data) Initializes id_spec.
4878 (rpd_parse_record) Implemented.
4879 (read_one_set_of_repetitions) Returns -3 by default in order to
4880 kluge out some potential bugs.
4882 * data-out.c: Comment fixes.
4884 * file-type.c: (internal_cmd_record_type) Message fix.
4886 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
4887 for handling -3 return value.
4889 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
4891 * data-list.c: Comment fixes.
4892 (struct dls_var_spec) Reordered members.
4893 (read_from_data_list_fixed) Restructured.
4894 (struct repeating_data_trns) Reordered members. Renamed `starts'
4895 as `starts_beg', `ends' as `starts_end'.
4896 (cmd_repeating_data) Calculates length of repeated data if
4897 necessary and possible.
4898 (parse_num_or_var) Don't allow string variables.
4899 (realize_value) New function.
4900 (rpd_msg) New function.
4901 (rpd_parse_record) New function. Currently stubbed out.
4902 (read_one_set_of_repetitions) Implemented.
4904 * inpt-pgm.c: (input_program_source_read) Comment fix.
4906 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
4908 * command.c: (cmd_end_repeat_p) Removed.
4909 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
4910 (parse_cmd_name) Removed.
4912 * data-list.c: Comment fixes.
4913 (data_list_pgm) Removed `eof' member.
4914 (static var first) New var.
4915 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
4916 FILE TYPE file inside FILE TYPE structures.
4917 (append_var_spec) Appends to *first, not dls.spec.
4918 (parse_fixed) Message fixes.
4919 (struct rpd_num_or_var) New.
4920 (struct repeating_data_trns) New.
4921 (static var rpd) New.
4922 (cmd_repeating_data) New function.
4923 (parse_num_or_var) New function.
4924 (parse_repeating_data) New function.
4925 (read_one_set_of_repetitions) New function.
4927 * file-type.c: (cmd_file_type) Message fixes. Always
4928 default_handle to FILE TYPE file handle.
4929 (internal_cmd_record_type) Message fixes.
4931 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
4933 * repeat.c: Comment fix. Disable debugging.
4935 * temporary.c: (restore_dictionary) Sets splits to NULL and
4936 n_splits to 0 before destroying the variables because now doing
4937 this tries to remove split variables.
4939 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
4940 destroying the dictionary.
4941 (clear_variable) Removes a variable from splits after destroying
4944 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
4946 * cmdline.c: (set_compat) Removed.
4947 (pick_compat) Removed.
4948 (parse_command_line) Removed -c option.
4949 (pre_syntax_message) Removed -c option.
4950 (usage) Remove compatibility code.
4952 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
4953 (glob var compat) Removed.
4955 * compute.c: (type_check) Fixed messages about type mismatches.
4957 * data-list.c: (cmd_data_list) Removed compatibility code.
4958 (fixed_parse_compatible) Calls convert_negative_to_dash().
4959 Fixed bug where it only set the variable in fx.spec if it created
4960 the variable itself.
4961 (dump_fmt_list) Spelling fix.
4962 (cut_field) Removed compatibility code.
4964 * dfm.c: (cmd_begin_data) Don't require a command terminator on
4967 * expr-evl.c: (evaluate_expression) Implement LAG.
4969 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
4970 (parse_neg) Calls convert_negative_to_dash().
4971 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
4974 * expr.h: (struct expression_struct) Removed member max_lag.
4976 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
4977 (internal_cmd_record_type) Removed special handling to produce
4978 negative numbers from dash tokens.
4980 * getline.c: (static var DO_REPEAT_level) New var.
4981 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
4982 (handle_line_buffer) Copies the line into getl_buf; doesn't call
4983 copy_with_DO_REPEAT_substitutions().
4984 (getl_read_line) Maintains value of getl_mode. Calls
4985 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
4987 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
4989 * getline.h: (getl_mode) New glob var.
4991 * glob.c: Comment fixes.
4992 (init_glob) Restructured. Sets set_seed.
4993 (init_compat_dependent) Removed. All references removed.
4994 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
4995 (__htonl, __htons) Removed. (What were these for?)
4997 * lexer.c: (static var tbl) Dash set to class CNUM.
4998 (make_hexit) New function from data-out.c.
4999 (get_token_representation) Rewritten.
5000 (convert_negative_to_dash) New function.
5001 (lex_init_compat_dependent) Removed.
5002 (yylex) A dash is parsed as part of a number if it is followed by
5003 a digit. The ASCII representation of a number is copied to
5004 tokstr. String parsing farmed out to parse_string(). Comment
5006 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
5008 (preprocess_line) Line processing depends on interactive/batch
5009 mode, not on compatibility mode. Removed PC+ compatibility code.
5011 * loop.c: (loop_3_trns_proc) Comment fix.
5013 * main.c: Remove dead code.
5014 (main) Remove call to init_compat_dependent().
5016 * misc.c: (convert_fmt_ItoO) Make E format conversion more
5019 * print.c: (parse_string_argument) Calls
5020 convert_negative_to_dash().
5021 (fixed_parse_compatible) Calls convert_negative_to_dash().
5023 * repeat.c: (RPT_* defines) Removed.
5024 (struct rpt_numeric) Removed.
5025 (struct repeat_entry) New member type, changed `replacement' from
5027 (clean_up) Deallocation adapted to new repeat_entry.
5028 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
5029 usage. Creates vars for `type' of 1.
5030 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
5031 (store_numeric) Rewritten, new interface.
5032 (parse_numbers) Rewritten.
5033 (parse_strings) Rewritten.
5034 (find_DO_REPEAT_substitution) New function.
5035 (perform_DO_REPEAT_substitutions) New function.
5036 (copy_with_DO_REPEAT_substitutions) Removed.
5037 (debug_print) Rewritten.
5039 * set.q: Comment fix.
5040 (custom_results) Removed compatibility code.
5041 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
5044 * sysfile-info.c: (cmd_display) Removed compatibility code.
5046 * tokens.h: Comment fixes.
5047 (token types enum) Removed `toktype' typedef name for this int
5048 type. Removed SUBST. Restructured.
5050 * vars-atr.c: (discard_variables) Sets n_lag to 0.
5052 * vars-prs.c: Comment fix.
5054 * vfm.c: Comment fixes.
5055 (glob var n_lag) New var.
5056 (static vars lag_count, lag_head, lag_queue) New vars.
5057 (procedure) Removed argument nlag.
5058 (setup_lag) New function.
5059 (close_active_file) Discards lagging state.
5060 (lag_case) New function.
5061 (lagged_case) New function.
5062 (write_case) Lags a case if lagging.
5064 * weight.c: (cmd_weight) Removed compatibility code.
5066 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
5068 * getline.h: (struct getl_script) New members loop_index, macros.
5070 * getline.c: (getl_add_file) Sets first_line field to NULL.
5071 (getl_add_DO_REPEAT_file) New function.
5072 (handle_line_buffer) When the current line's length is negative,
5073 set the filename and line number. Increment line number after
5074 reading line. Pass the line to
5075 copy_with_DO_REPEAT_substitutions() for processing.
5076 (getl_close_file) Free DO REPEAT lines before freeing the
5077 filename, and just set the filename to NULL when doing this,
5078 because otherwise the filename gets freed twice.
5080 * glob.c: (glob var queuing) Removed. All references removed.
5082 * lexer.c: Comment fixes.
5083 (get_token_representation) New function.
5085 * repeat.c: Comment fixes.
5086 (struct repeat_entry) Replaced type and v union members with a
5088 (append_record) New function.
5089 (internal_cmd_do_repeat) Started reforming it for the new
5090 repeat_entry struct. Properly records filename changes in the
5091 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
5092 strncasecmp() result usage. Uses append_record() to simplify.
5093 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
5096 (copy_with_DO_REPEAT_substitutions) Started coding.
5098 [DEBUGGING] (debug_print_lines) New function.
5100 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
5102 * tokens.h: (macro is_id1, is_idn) New macros.
5104 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
5106 * cmdline.c: (static var pre_syntax_message) Changed `win'
5107 compatibility mode to `wnd'.
5109 * data-list.c: (fixed_parse_spss) Renamed
5110 fixed_parse_compatible().
5112 * glob.c: (init_glob) Excise unused code for
5113 program_invocation_short_name.
5115 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
5118 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
5120 * set.q: `win' compatibility renamed `wnd'.
5122 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
5124 * filename.c: [__WIN32__] Change the included Windows header files
5126 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
5127 second character is absolute.
5128 (dirname) Fix logic error. Don't printf() the results.
5129 (prepend_dir) Don't printf() the results.
5131 * getline.c: (handle_line_buffer) New function.
5132 (getl_read_line) Reads line with handle_line_buffer() when
5134 (getl_close_file) Discard line buffer data.
5136 * getline.h: Comment fixes.
5137 (struct getl_line_list) New struct.
5138 (getl_script_struct) Added line buffer members. These are hooks
5139 for use by DO REPEAT to allow it to insert virtual source code
5142 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
5143 Override Borland C++ stupidity that claims Windows has a console
5146 * repeat.c: This is in the process of being restructured from
5147 using a token-buffering approach to the DO REPEAT facility to
5148 using the more flexible approach of a line-buffering approach in
5149 conjunction with the getline module. Comment fixes.
5150 (struct tok_struct) Removed.
5151 (static vars queue_index, queue_head, queue) Removed.
5152 (static vars line_buf_head, line_buf_tail) New vars.
5153 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
5155 (pull_queue, destroy_queue) Removed.
5156 [DEBUGGING] (debug_print_tokens) Removed.
5158 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
5160 * file-handle.q: (prepend_current_directory) New function.
5161 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
5162 current directory before normalizing filename.
5164 * filename.c: (gnu_getcwd) New function.
5165 (absolute_filename_p) New function.
5166 (search_path) New argument, PREPEND. All references changed to
5167 pass NULL except those explicitly mentioned. Uses
5168 absolute_filename_p(). Prepends PREPEND before trying the
5170 (dirname, prepend_dir) New functions.
5172 * getline.c: (getl_get_current_directory) New function.
5173 (getl_include) Passes getl_get_current_directory() as PREPEND arg
5176 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
5178 * In several source files, the term `script' was replaced with
5179 `syntax file' inside error messages. Usage of the term `script'
5180 in the sense of a syntax file is now deprecated.
5182 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
5185 * dump-sysfile.c: (usage) Update message.
5187 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
5189 * getline.h: (glob var getl_include_path) Declare extern.
5191 * list.q: Define EXTERN as extern before #including somP.h.
5193 * var.h: Remove declaration of `disptype' variable.
5195 * vfm.c: (close_active_file) After switching the data sink to a
5196 data source, set vfm_sink to NULL, because it doesn't exist any
5199 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
5201 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
5202 _matherrl() to ignore all math errors.
5204 * sfm-read.c: (read_value_labels) When reading the labels from
5205 disk, read the little parts separately instead of as a struct;
5206 this avoids alignment problems.
5208 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
5209 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
5210 (write_header) Allocates and initializes elem_type.
5211 (sfm_write_case) Uses elem_type to determine how to handle each
5213 (sfm_close) Frees elem_type.
5215 * sfmP.h: Comment fix.
5216 [__BORLANDC__] Uses #pragma -a to adjust structure member
5219 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
5221 * Makefile.am: (fiasco_SOURCES) Remove display.c.
5223 * common.c: Fix typo.
5225 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
5226 sense of the condition.
5228 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
5229 line-continuation backslash.
5231 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
5233 * frequencies.q: (custom_grouped, add_percentile) Don't use a
5234 non-constant expression as an argument to sizeof.
5236 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
5237 undefine gettext macro because that's a conio function.
5239 * hash.h: (hsh_prime_tab declaration) Remove.
5241 * list.q: (write_fallback_headers) Move `leader' allocation out of
5242 main loop. Change to local_alloc() allocation.
5244 * output.h: Formatting fixes. Put __attribute__ in right place on
5245 function prototypes.
5247 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
5248 incorrect `SECOND_LOWEST_VALUE' references to proper
5249 `second_lowest_value'.
5251 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
5252 value. This way 2 out of 3 of the som files define the vars
5253 extern, the correct way, that actually works under BC++.
5254 (som_set_float) Don't use nonconstant initializers for a struct.
5256 * som-high.c: Add the standard alloca() header.
5257 (replicate_table) Add prototype.
5259 Merged DISPLAY routine.
5260 * sysfile-info.c: (AS_*) New enum series.
5261 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
5263 (cmd_display, display_macros, display_documents,
5264 display_variables) Stolen from defunct display.c.
5265 (describe_variable) New function.
5267 * temporary.c: [0] (display_tree) New debug function.
5268 (copy_variable) Performs shallow copy of value labels instead of
5269 deep copy; i.e., just copys the AVL tree and increments the
5272 * val-labs.c: Comment fixes.
5273 (do_value_labels) Optionally skip leading forward slash.
5274 (get_label) Creates only a single value label instead of many
5275 copies of one, and sets the reference count.
5277 * display.c: Removed.
5279 * dump-sysfile.c: New file, not yet complete.
5281 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
5283 For lots of source files I added more verbose_msg's. These aren't
5284 listed below as they have tested as being benign. In some cases
5285 these replaced debug_printf() calls.
5287 * output.c: (outp_read_devices) Message fix.
5289 * postscript.c: (output_encodings) Message fix. Reports errors on
5291 (postopen) Message fix.
5293 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
5295 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
5297 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
5300 * main.c: Remove <malloc.h> #include.
5302 * mis-val.c: (parse_numeric) Set .f member for each missing[]
5303 instead of trying to just set the missing[] itself, which is a
5306 * sfm-read.c: (read_variables) Same.
5308 * str.h: Add memmem() prototype.
5310 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
5312 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
5314 * Makefile.am: (q2c) Don't include any libraries in the link.
5316 * dfm.c: (force_line_buffer_extension) New macro.
5317 (count_tabs) New function.
5318 (tabs_To_spaces) New function.
5319 (read_record) Calls tabs_to_spaces() on the line being processed.
5321 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
5322 have to be compiled twice (once for CC, once for LOCAL_CC).
5324 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
5326 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
5327 (LDADD) Add @INTLLIBS@.
5328 (q2c) Add LIBS, @INTLLIBS@ to link step.
5330 * inpt-pgm.c: Turn off debugging.
5332 * postscript.c: (postopen) Format fix. local_free() blocks
5333 returned by local_alloc(); don't free() them.
5335 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
5337 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
5340 * data-list.c: (read_from_data_list_fixed) Pass proper value for
5341 LEN arg, not simply the full string length.
5343 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
5344 directories before generic temp file directories.
5346 * vfm.c: Disable debugging.
5348 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
5350 * get.c: Comment fix.
5351 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
5353 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
5355 * expr-prs.c: (debug_print_postfix) Conditionally included on
5356 GLOBAL_DEBUGGING. Removed out_header() reference.
5358 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
5360 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
5362 * ascii.c: Removed obsolete ascii_close_page() prototype.
5364 * command.c: (output_line) Comment fix.
5366 * data-in.c: Formatting fix.
5367 (parse_string_as_format) Now the `fc' argument is used only for
5368 the purpose of error messages; it is not an index into the string
5369 passed. All references changed.
5371 * data-list.c: Comment fix.
5372 (cut_field) Comment fix. Now returns the column number of the
5373 position of the field cut out on success.
5374 (parse_field) Added `column' argument. Puts the column numbers in
5376 (read_from_data_list_free, read_from_data_list_list) Record the
5377 column number returned by cut_field(), pass it to parse_field().
5379 * dfm.c: Comment fix.
5381 * do-ifP.h: Comment fix.
5383 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
5384 the SYSMIS function.
5386 * expr.h, exprP.h: Comment fix.
5388 * glob.c: (init_glob) Only calls setlocale() and family if
5391 * hash.h: Comment fix.
5393 * include.c: Comment fix.
5395 * output.c: Comment fix.
5397 * postscript.c: (ps_line_intersection) Simplified assertion.
5399 * repeat.c: Comment fix.
5401 * vars-atr.c: Comment fix.
5403 * vars-prs.c: Comment fix.
5405 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
5406 behavior with usage of postincrement.
5407 (memory_stream_read) Discards cases as it goes.
5409 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
5411 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
5414 * Most source files: Includes debug-print.h, related comment
5417 * cases.c: (alloc_val) Removed complex allocation code. Merely
5418 increments default_dict.nval and returns the former value.
5419 (envector, devector) Removed references to lv member of struct
5422 * common.h: (macro VME) Replaced complex definition with simple
5425 * data-list.c: (cmd_data_list) Sets vfm_source instead of
5426 read_active_file and cancel_input_pgm.
5427 (read_from_data_list, cancel_data_list) Removed.
5428 (data_list_source_read, data_list_source_destroy_source) New
5430 (glob var data_list_source) New var.
5432 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
5433 (cmd_begin_data) Improved criteria for an input program accessing
5434 the inline file. Still not perfect.
5436 * do-if.c: (do_if_trns_proc) Simplified debug output.
5438 * expr-prs.c: Comment fixes.
5439 [DEBUGGING] (debug_print_postfix) Simplified debug output.
5441 * file-handle.q: (fh_close_handle) Simplified debug output.
5443 * file-type.c: Comment fixes.
5444 (cmd_file_type) Sets vfm_source instead of read_active_file and
5446 (cmd_end_file_type) On failure, discards variables in place of
5447 just canceling the input program.
5448 (read_from_file_type) Renamed file_type_source_read.
5449 (cancel_file_type) Renamed file_type_source_destroy_source.
5450 (glob var file_type_source) New var.
5452 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
5453 (cmd_get) Initializes options to GTSV_NONE before passing to
5454 trim_dictionary(). Removed `lv' reference. Sets vfm_source
5455 instead of read_active_file and cancel_input_pgm.
5456 (cmd_save_internal) Initializes options before passing to
5457 trim_dictionary(). Local var `nval' removed.
5458 (dict_delete_run) Comment fixes.
5459 (trim_dictionary) Comment fixes. Disallows scratch variables if
5460 GTSV_OPT_SAVE set in options.
5461 (read_from_get) Renamed get_source_read.
5462 (cancel_get) Renamed get_source_destroy_source.
5463 (glob var get_source) New var.
5465 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
5466 read_active_file and cancel_input_pgm.
5467 (read_from_input_program) Renamed input_program_source_read.
5468 Simplified debug output.
5469 (cancel_input_program) Renamed
5470 input_program_source_destroy_source.
5471 (glob var input_program_source) New var.
5473 * loop.c: (loop_1_trns_proc) Simplified debug output.
5475 * main.c: (dump_token) Made eof output more explicit.
5477 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
5480 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
5481 code for always-memory or always-disk cases. malloc's case-list
5482 based on vfm_source_info.ncases. Explicit support for
5483 memory_stream via memory_source_cases.
5484 (do_external_sort) Sets vfm_source instead of read_active_file and
5486 (allocate_file_handles) The temporary directory permissions are
5487 set to 0700 instead of 0777.
5488 (allocate_cases) Formatting fixes. Simplified debug output.
5489 (output_record) Compacts the case if necessary before writing it
5491 (close_handle, open_handle_w) Simplified debug output.
5492 (write_initial_runs) Destroys vfm_sink, then sets it to
5493 sort_stream. Writes records to memory based on
5494 vfm_sink_info.case_size.
5495 (write_to_sort_cases) Renamed sort_stream_write().
5496 (merge) Simplified error handling. Simplified debug output.
5498 (read_from_external_sort) Renamed sort_stream_read().
5499 Reads records based on vfm_source_info.case_size.
5500 (sort_stream_write) Writes records to memory based on
5501 vfm_sink_info.case_size.
5502 (sort_stream_mode) New function.
5503 (glob var sort_stream) New variable.
5505 * temporary.c: (cmd_temporary) Simplified debug output.
5506 (copy_variable) Removed references to `lv'.
5508 * title.c: (get_title) Simplified debug output.
5510 * var.h: Comment fixes.
5511 (struct get_proc) Removed member `lv'.
5512 (struct variable) Removed member `lv'. Comment fixes.
5513 (glob vars read_active_file, write_active_file, cancel_input_pgm)
5515 (struct case_stream) New.
5517 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
5518 read_active_file references to use vfm_source.
5519 (init_variable, replace_variable) Removed references to `lv'.
5521 * vfm.c: Comment fixes.
5522 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
5524 (static var queue, qh, qt, n_lag) Removed. All references
5526 (glob var compaction_necessary, compaction_nval, compaction_case,
5527 paging) New variables.
5528 (record_case) Removed.
5529 (procedure) Comment fixes. Calls vfm_source->read() instead of
5532 (prepare_for_writing, arrange_compaction, make_temp_case,
5533 vector_initialization, setup_filter) New function.
5534 (open_active_file) Most of the code moved into the abovementioned
5535 new functions. Now sets temp_dict to &default_dict if there is no
5536 temporary dictionary, for convenience. New debug output.
5537 (close_active_file) Deals with changing the sink to the source.
5538 Calls finish_compaction(). Frees compaction_case. Mostly
5540 (glob vars disk_source_file, disk_sink_file) New vars.
5541 (destroy_active_file, read_from_memory) Removed.
5542 (disk_stream_init, disk_stream_read, disk_stream_write,
5543 disk_stream_mode, disk_stream_destroy_source,
5544 disk_stream_destroy_sink) New functions.
5545 (glob var vfm_disk_stream) New var.
5546 (glob vars memory_source_cases, memory_sink_cases,
5547 memory_sink_iter, memory_sink_max_cases) New vars.
5548 (memory_stream_init, memory_stream_read, memory_stream_write,
5549 memory_stream_mode, memory_stream_destroy_source,
5550 memory_stream_destroy_sink) New functions.
5551 (glob var vfm_memory_stream) New var.
5552 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
5553 named `more_cases'. Simplified debug output. Otherwise mostly
5555 (record_case) Moved into the stream drivers. Removed.
5556 (transform) Removed (was dead code).
5557 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
5558 common case that the splits don't change, we don't need to copy
5559 the case into prev_case again--pointless.
5560 (compact_case) New function.
5561 (finish_compaction) New function.
5563 * vfmP.h: Comment fixes.
5564 (DEV_* enum series) Removed.
5565 (struct storage) Renamed `stream_info'. Removed variant record.
5566 Removed `device' member.
5568 * debug-print.h: New file.
5570 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
5572 * autorecode.c: Turned off debugging.
5574 * data-list.c: (destroy_dls) Closes the associated file handle.
5576 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
5577 parse_variables() options.
5579 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
5581 * display.c: (display_variables) Really fixed null cell bug.
5583 * file-handle.q: (fh_close_handle) Changed debugging message.
5585 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
5586 parse_variables() options.
5588 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
5589 (cmd_list) Fails if no variables specified.
5590 (determine_layout) Writes blank lines manually.
5592 * loop.c: (loop_1_trns_proc) Made debugging code only print
5593 messages if debugging.
5595 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
5596 parse_variables() arguments.
5597 (main) Parses optional parenthesized options to varlist
5598 subcommands into sbc->message.
5600 * sfm-read.c: Format fix.
5602 * var.h: (FV_*) New enum series.
5603 (PV_*) New enum PV_NO_SCRATCH.
5605 * vars-prs.c: (find_var) Removed.
5606 (fill_all_vars) Takes FV_* enum instead of boolean third
5607 argument. Rewritten to deal with scratch as well as system
5609 (parse_variables) Error message on scratch variable if
5612 * vfm.c: (static var virt_begin_func) New var.
5613 (procedure) Sets up virt_begin_func.
5614 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
5615 after dump_splits(). For succeeding groups changes, calls
5616 virt_begin_func() instead of begin_func().
5618 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
5620 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
5623 * dfm.c: Added some debugging messages, disabled by default.
5624 (open_file_r) Fixed error message.
5625 (read_record) On eof on inline_file, instead of calling
5626 fh_close_handle(), simply jump to eof label like a normal file.
5629 * display.c: Thin lines between rows for certain kinds of
5630 listing. Fixed `null cell' bug.
5632 * error.c: (failure) Flush stdout, stderr before failing.
5634 * file-handle.q: (fh_close_handle) Added debugging message.
5636 * frequencies.q: (dump_full) Bottom line extends across entire
5637 table width. Changed title formatting.
5638 (dump_condensed) Changed title formatting.
5639 (dump_statistics) Fixed title formatting.
5641 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
5642 Sets default value of set_format.
5644 * list.q: (cmd_list) Calls blank_line() before determine_layout().
5645 Passes write_all_headers() to procedure() as pre-group func.
5646 (write_all_headers) New function.
5647 (determine_layout) Removed calls to write_header().
5648 Calls blank_line() before and after write_fallback_headers().
5650 * recode.c: (recode_trns_free) Only attempts to free head->map if
5653 * sfm-read.c: (read_variables) Allows `#' at beginning of system
5654 file variable names but gives a warning. Sets `left' based on
5655 first character being/not being `#'. On lossage frees dict->var.
5657 * som-high.c: (som_draw_title) Simplified title formatting.
5659 * vfm.c: (dump_splits) Fixed and changed splits formatting.
5661 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
5663 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
5664 beginning. Frees v_src, v_dest on successful exit. Frees
5665 h_trans[*], h_trans on lossage.
5666 (recode) Frees h_trans[*], h_trans.
5668 * dfm.c: (dfm_close) Formatting change.
5669 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
5670 longer allocates its own in inline_file.
5671 (open_file_r) Passes the local dfm_fhuser_ext to
5673 (open_file_w) Message fix.
5674 (read_record) Buffer reallocation strategy changed. Frees
5675 ext->line even in inline_file to prevent leaks.
5676 (dfm_put_record) Fixed bug where `ext' was cached before the file
5677 was opened and thus it would be NULL when the file really was
5679 (cmd_begin_data) Sets up inline_file basics itself, then calls
5680 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
5682 * list.q: (write_line) Formatting fix.
5683 (clean_up) Minor strategy change. Sets proportional font after
5685 (determine_layout) Sets fixed font before writing regular headers,
5686 or after writing fallback headers.
5688 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
5689 and KEEP vars after using them.
5691 * postscript.c: (ps_init_driver) Frees x->family.
5692 (postopen) When loading fonts, free the temporary font name buffer
5694 (ps_text_set_font_by_position) Free temporary font name buffer
5696 (text) Fixed code that calculated `lig' so that `lig' always gets
5697 initialized. Formatting fix.
5699 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
5701 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
5702 cells, not xmalloc(), so that the cells will get destroyed
5705 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
5708 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
5710 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
5713 * dfm.c: Comment fix.
5715 * list.q: Comment fixes. Include somP.h. Removed static vars
5716 table, n_columns, n_rows, part. New struct list_ext. New static
5718 (n_lines_remaining, n_chars_width, write_line) New functions.
5719 (cmd_list, list_cases) Rewritten.
5720 (begin_row, end_row, flush_table) Removed.
5721 (write_header, clean_up, write_varname, write_fallback_headers,
5722 determine_layout) New functions.
5724 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
5726 * output.h: Comment fix.
5728 * postscript.c: Comment fix.
5729 (struct ps_driver_ext) Removed prop_size, fixed_size members;
5730 added font_size. All references changed.
5731 (ps_init_driver) Initializes font_size. Simplified space checking
5733 (static var option_tab[]) Removed prop-size, fixed-size; added
5735 (ps_option) Handles font_size.
5737 * som-high.c: Moved prototypes into somP.h.
5738 (som_init_driver) New function.
5739 (som_submit_table) Moved some code into new function
5741 (build_target) Moved some code into new function
5742 som_internal_eject_page().
5743 (som_eject_page) Uses som_internal_eject_page().
5744 (som_internal_eject_page) New function.
5746 * som-low.c: Moved prototypes into somP.h.
5748 * som.h: Formatting fixes.
5750 * somP.h: (struct som_driver_ext) Removed em_width;
5751 added prop_em_width, fixed_width.
5753 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
5755 * Makefile.am: Added `localedir' definition. Added
5756 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
5758 * ascii.c: (macro draw_line) Fixed capitalization.
5760 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
5761 compute.c, count.c, data-in.c, data-list.c, data-out.c,
5762 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
5763 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
5764 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
5765 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
5766 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
5767 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
5768 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
5769 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
5770 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
5771 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
5772 for internationlization.
5774 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
5776 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
5778 * do-if.c, sort.c, val-labs.c: Comment fixes.
5780 * glob.c: (init_glob) Uncommented, updated i18n support.
5782 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
5783 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
5784 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
5785 the declarations of macros taking arguments a lot nicer.
5787 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
5789 * error.h: Removed CE, CW aliases for SE, SW.
5791 * q2c.c: Removed explicit streq() definition since it's duplicated
5794 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
5795 stats.h, str.h, tokens.h: Made the declarations of macros taking
5796 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
5799 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
5801 * cmdline.c: Comment fixes.
5802 (pick_compat) Changed return type to int. Now, instead of setting
5803 glob var `compat' to the emulation, returns the emulation. All
5805 (parse_command_line) Added terminating null to end of
5806 `long_options' array definition.
5807 (pre_syntax_message) Fixes.
5808 (usage) Shows the default emulation in the syntax message by
5809 calling pick_compat().
5811 * getline.c: (getl_add_include_dir) Separates paths with
5812 PATH_DELIMITER, not DIR_SEPARATOR.
5814 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
5815 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
5817 * output.c: (outp_configure_macro) Make earlier definitions for a
5818 particular key override later ones for the same key.
5820 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
5822 * ascii.c: Comment fixes.
5824 * output.c: (outp_get_paper_size)
5825 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
5827 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
5829 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
5830 <errno.h>. GNU libc 2 enforces this!
5832 * command.c: (parse_cmd) Fixed problem with `else' clause being
5833 paired with wrong `if'. Comment fix.
5835 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
5837 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
5838 blp_getline() to getline().
5840 * output.c: (outp_eval_dimension) Changed the fix from last time;
5841 there was no variable `a'.
5843 * q2c.c: (get_line) Fixed boundary condition overrun bug.
5845 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
5847 * output.c: (outp_evaluate_dimension) Fixed handling of negative
5848 numbers having fractional parts. Added case of a fraction without
5849 a whole-number part.
5851 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
5853 * ascii.c: (ascii_text_get_font_position) Removed.
5855 * expr.h, exprP.h: Disabled debugging.
5857 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
5860 * output.h: (struct outp_class_struct) Removed
5861 text_get_font_position method. All references deleted.
5863 * postscript.c: Big change here. Fontmaps were completely
5864 eliminated because of a change in philosophy. Comment fixes.
5865 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
5867 (struct ps_driver_ext) `position', `fontmap', `prop_name',
5868 `fixed_name' members removed. New members `prop_family',
5869 `fixed_family'. `family' member changed to type char *.
5870 (static var ps_fontmaps) Removed.
5872 (ps_init_driver) Removed obsolete references, updated.
5873 Initializes `translate_x', `translate_y', `scale'. Doesn't read
5874 fontmap, of course. Refers to font names through internal_name
5875 rather than subversive means. Frees proper items.
5876 (static var option_tab[]) Removed `fontmap-file' option; renamed
5877 `fixed-font', `prop-font'.
5878 (ps_option) Corresponds to option_tab[].
5879 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
5880 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
5881 hash_family) Removed.
5882 (postopen) Generates font names from family names. Gets
5883 PostScript font name properly. New prologue file comment `!!!'
5885 (ps_open_page) Adds translate_x, translate_y to BP prologue
5886 function; gives SF argument floating-point format.
5887 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
5888 font name. Doesn't change font family.
5889 (ps_text_set_font_by_position) Generates Groff font name from font
5890 family name instead of through table lookup.
5891 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
5892 all references changed. Reduced to simple string assignment.
5893 (ps_get_font_name) Removed.
5894 (ps_get_font_family) Reduced to string return.
5895 (text) Doesn't save `position' since it no longer exists. Ugly
5896 kluge to save font family--fix soon?
5897 (load_font) Removed PostScript name argument.
5899 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
5901 * postscript.c: Comment fix.
5902 (ps_open_page) Puts scale factor in PostScript output.
5904 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
5906 * Makefile.am: Distcleans q2c.
5908 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
5910 * ascii.c: (delineate) Sets text size even if width is zero.
5912 * command.c: Comment fix.
5913 (static var cmd_table[]) Re-enabled EVALUATE command.
5914 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
5915 of comments in script files. Now more liberal on criteria for
5916 performing a state transition--if *anything* happened correctly,
5917 not just if *everything* happened correctly.
5919 * data-out.c: (convert_F) Comment fix. Why in the fsck does
5920 Checker segfault on formatting large numbers and why in the fsck
5921 hadn't I noticed this before?
5923 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
5925 * list.q: (cmd_list) Commented out the actual output routine
5926 because of various problems. Probably will abandon the idea of
5927 using the general `crushed tables' for the LIST procedure.
5929 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
5930 clearing it. Allocates a new var_by_name dictionary before trying
5931 to add members to it.
5933 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
5934 `sib'. Changed type of `node' argument.
5935 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
5937 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
5938 [DEBUGGING] Only deletes the variable from var_by_name if that var
5941 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
5943 * Makefile.am: Added include files to SOURCES. Added
5944 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
5945 includes rules for q2c. Added `boast' target.
5947 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
5949 * Makefile.am: Maintainer-clean Makefile.in.
5951 * Makefile.am: Fixed redundant EXTRA_DIST line.
5953 * ascii.c: Comment fixes.
5954 (ascii_line_vert) Fixed overly aggressive range check.
5956 * display.c: Removed dead code.
5958 * list.q: Turn debugging on.
5959 (flush_table) New debug code.
5961 * sfm-read.c: (read_value_labels) malloc's the structure before
5962 trying to assign to its members.
5964 * sfm-write.c: Comment fix.
5966 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
5968 (output_table) No arguments anymore--gets them through `som'
5969 global. New debug code. In crushed tables, now sets `htv' as
5970 well as `hv' to avoid bad confusion later.
5971 (dump_crush_page) New debug code.
5973 * som-low.c: (som_dump_crush_page) New debug code.
5975 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
5977 All source files: Broke long lines into multiple lines.
5979 * ascii.c: (ascii_close_page) Uses host_system var in place of
5980 HOST_SYSTEM constant.
5982 * cmdline.c: (var syntax_message[]) Broke into
5983 pre_syntax_message[] and post_syntax_message[].
5984 (usage) Outputs both parts, separated by driver list.
5986 * error.h: Fixed broken formatting.
5988 * expr-opt.c: (str_search, str_rsearch) New functions.
5990 * misc.c: (blp_getdelim) Removed. All references changed to
5992 (str_search, str_rsearch) Removed.
5993 (memrmem) New function.
5995 * misc.h: (blp_getline) Removed. All reference changed to
6000 * filename.c: Includes "stat.h", not <sys/stat.h>.
6001 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
6003 * output.c: (outp_list_classes) Changed output formatting.
6005 * sfm-write.c: (write_header) Uses host_system var instead of
6006 HOST_SYSTEM constant.
6007 (write_rec_7_34) Extracts version numbers from the version string.
6010 * sort.c: Includes "stat.h", not <sys/stat.h>.
6012 * str.c: (strcasecmp) Removed.
6014 * title.c: (cmd_document) Uses host_system var instead of
6015 HOST_SYSTEM constant.
6017 * version.c: Generated on-the-fly by the Makefile instead of being
6020 * str.h: Comment fixes. Doesn't substitute for missing memmove or
6022 [!HAVE_STRNCASECMP] Declares strncasecmp().
6024 * version.h: Removed stray character. Comment fixes.
6025 (vars host_system, build_system) New vars.
6027 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
6029 * Most source files: Changed formatting of copyright notice; fixed
6030 FSF address; reformatted to better conform to GNU standards;
6031 comment fixes. Added markups to prevent GNU indent from messing
6032 up my beautiful formatting :-).
6034 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
6035 that GNU indent markups can be passed through without problems.
6037 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
6039 * get.c: Turned off debugging.
6041 * glob.c: (init_glob) Turned on save-file compression by default.
6043 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
6044 compression than was possible in save files.
6046 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
6048 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
6050 * frequencies.q: Removed Fiasco extensions. Updated calculation
6051 algorithms. Polished output format.
6052 (struct frq_info_struct) Removed members `max_degree', `min_n',
6053 all references removed.
6054 (macro frq_extensions) Removed.
6055 (static vars min_n, max_degree) Removed, all references removed.
6056 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
6057 calculate `min_n', `max_degree'.
6058 (postcalc) Passes new arg to dump_statistics().
6059 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
6061 (dump_condensed) Adds variable name title.
6062 (sum_freqs) Removed.
6063 (calc_stats) Updated calculation algorithm.
6064 (dump_statistics) Removed warning for too-few observations.
6065 Changed table formatting. Adds variable name title if passed new
6068 * output.h: Comment fix.
6070 * recode.c, sample.c, sort.c: Disabled debug code.
6072 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
6073 Improved debug code.
6075 * var.h: (enum series frq_*) Removed Fiasco extensions.
6077 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
6079 * command.c: Added PROCESS IF to command table.
6081 * Lots & lots of places, removed checks for NULLs preceding calls
6082 to free_expression(), which itself checks.
6084 * descript.q: Removed Fiasco extensions. Removed optimizations
6085 for non-weighted active files. Implemented some options.
6086 Finished polishing output format. Comment fixes. Merged
6088 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
6089 max_degree, min_n) Removed.
6090 (macro dsc_extensions) Removed.
6091 (struct dsc_info_struct) Removed `min_n' member, all references
6093 (internal_cmd_descriptives) Removed calculation of min_n,
6094 max_degree. Only deals with one `calc' routine instead of two
6096 (precalc) Eliminated redundancy. Updated for changes to
6097 descriptives_proc structure.
6098 (calc) Moved here from `descript.g'. Rewritten to calculate
6099 statistics via `moments about the mean' rather than by summing,
6100 summing squares, summing cubes, and so on.
6101 (postcalc) Rewritten for new-style statistical calculation.
6102 (display) Removed support for displaying variables across rows.
6103 No longer crushes the descriptives table. Removed ancient code.
6104 Added display of N, by variable and listwise.
6106 * descript.g: Removed; merged into `descript.q'.
6108 * expr-evl.c: (evaluate_expression) Now returns a double. For
6109 numeric results, it returns the result as well as storing it in
6110 the passed `value' structure if non-NULL. For string results it
6111 just returns 0.0 and it must be passed non-NULL. Many references
6112 to this function were optimized by use of this change, especially
6113 but not exclusively in `compute.c'.
6115 * frequencies.g: Comment fix.
6117 * glob.c: (glob var process_if_expr) New global var.
6119 * postscript.c: (static var option_tab[]) Corrected entry for
6121 (postopen) Sets x->size to x->prop_size.
6122 (ps_text_set_font_by_name) Sets font size as well as typeface for
6123 PROP and FIXED fonts.
6125 * sel-if.c: (cmd_process_if) New function.
6127 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
6128 (sfm_write_dictionary) Sets `n_cases' to 0.
6129 (sfm_write_case) Increments `n_cases'.
6130 (sfm_close) Attempts to seek the system file back to the header
6131 and write the number of cases in its proper slot.
6133 * som-frnt.c: (som_insert_table) Masks off expansion options since
6134 only SOPT_X_NORM seems to work sensibly.
6136 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
6137 with a `fixed' value of 2.
6139 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
6141 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
6142 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
6144 * var.h: (enum series dsc_*) Removed Fiasco extensions.
6145 (struct descriptives_proc) Removed `miss_noweight'; new members
6146 `X_bar', `M2', `M3', `M4', `min', `max'.
6148 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
6150 * vfm.c: (close_active_file) Cancels PROCESS IF.
6151 (write_case) Doesn't process cases unselected by PROCESS IF.
6153 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
6155 * glob.c: (glob var err) Removed.
6157 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
6158 doesn't have to take into account number of value labels since
6159 they're in a subtable anyway. Also, doesn't display more than 10
6160 value labels since we can't yet break pages in subtables.
6162 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
6164 * som-frnt.c: (som_change_table_size) Simple change for elegance
6165 that shouldn't change behavior.
6166 (som_set_value) Comment fix.
6168 * som-high.c: (som_submit_table) Message fix.
6170 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
6172 * command.c: Added SYSFILE INFO to command table.
6174 * file-handle.q: (fh_handle_filename) New function.
6176 * get.c: (save_trns_proc) Fixed a bug in padding of output data
6179 * main.c: (parse) New return value for command functions, -3.
6181 * misc.h: Comment fix.
6183 * output.h: Comment fixes.
6184 (macro COMPONENTS) Removed.
6186 * postscript.c: (write_text) Modified literal_chars[] so that `('
6187 and ')' are not written to the output in strings as literals.
6189 * sfm-read.c: (sfm_read_dictionary) New argument.
6190 (read_header) New argument. Sets the information structure's
6191 values from the header information.
6192 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
6193 bizarre Checker problem, I guess.
6194 (read_variables) Proper cleanup on lossage.
6196 * sfm.h: (struct sfm_read_info) New struct for use by
6197 sfm_read_dictionary().
6199 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
6200 currently used just for tables that can be dynamically resized and
6201 thus have to be allocated with arena_malloc() instead of
6202 arena_alloc(). All references changed.
6203 (som_change_table_size) New function.
6204 (som_insert_table) Bugfix: now inserts `cell', not `c'!
6206 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
6207 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
6210 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
6212 (draw_intersection) Now takes an argument specifying the table in
6213 question. All references changed.
6214 (draw_table_cell) New function.
6215 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
6216 (som_get_table_size) Many nice new explanatory comments.
6217 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
6219 * som.h: New enum series SOM_CREATE_* for use as create flags with
6222 * str.h: Moved a comment here from TODO.
6224 * sysfile-info.c: New file. Reference implementation.
6226 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
6228 * command.c: Added RENAME VARIABLES to table of commands.
6230 * data-in.c: (dls_error) Sets `cust_field'.
6231 (parse_N) Message fix.
6232 (parse_day_count) New function.
6233 (to_roman) Never outputs VX as a `short form' of V.
6234 (parse_month) Fixed parsing of Roman numerals.
6235 (parse_trailer) Message fix.
6236 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
6237 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
6238 the date is invalid.
6239 (parse_SDATE) Fixed swapped day, year.
6240 (parse_JDATE) Fixed bug for dates in 1582.
6241 (parse_DTIME) Allows days not between 1 and 31.
6242 (parse_numeric) Makes local copy of f.type for easier usage.
6245 * data-out.c: (convert_F) When outputting as scientific, properly
6246 sets f.type as fp->type.
6247 (insert_commas) Fixed operator precedence problem with setting of
6248 nitems. Changed strcpy to memcpy (no null terminator).
6249 (convert_date) Fixed FMT_JDATE: added 1900 to year.
6250 (convert_CCx) Essentially rewritten, but now it works.
6252 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
6254 (display_documents) Implemented.
6256 * error.c: (glob var cust_field) New var.
6257 (vmsg) Displays cust_field as part of message classes DE and DW.
6259 * formats.c: (debug_print) Fixed to compile under updated
6262 * get.c: (cmd_get, cmd_save_internal) Close file handle on
6265 * misc.c: (parse_format_specifier) Formatting fix.
6267 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
6268 `n_rename' for clarity.
6269 (cmd_modify_vars) Initializes `forward' and `positional' at
6270 appropriate times. Frees lists of vars to rename on failure.
6271 Comment fix. Frees memory on success.
6272 (rearrange_dict) Simplified `for' loop condition.
6274 * rename-vars.c: New file (reference implementation).
6276 * set.q: (internal_cmd_set) Fixed `emu' test condition.
6278 * sfm-read.c: (read_header) File label is created only if file
6279 label in file is not blank.
6280 (read_variables) Initializes `dict' local variable.
6281 (read_documents) Proper behavior on lossage.
6283 * sfm-write.c: (write_header) Doesn't blank out the file label
6284 (why was this here to begin with?!)
6286 * temporary.c: (save_dictionary) File label is copied only if
6287 non-NULL. Doesn't try to xstrdup() dictionary documents.
6288 Adapted so as to not irritate Checker.
6289 (free_dictionary) Only destroys var_by_name if non-NULL.
6291 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
6292 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
6293 lines to the document, indents the document. Also, it works now.
6294 (add_document_line) New function.
6296 * var.h: (struct dictionary) Reordering.
6298 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
6299 bits if it was allocated to begin with.
6301 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
6303 * command.c: Added MODIFY VARS to list of commands.
6305 * configure.in: Updated custom macros for autoconf 2.12. Removed
6306 mmap reference; fixed termcap library reference.
6308 * display.c: (display_variables) Fixed a few bugs although it's
6309 still not well written.
6311 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
6312 (induce_segfault) Calls chkr_disp_call_chain() instead of
6313 inducing an actual SIGSEGV.
6315 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
6316 str_search() and str_rsearch(). Fixed tests for matches on
6317 OP_INDEX and OP_RINDEX.
6319 * filename.c: (good_getcwd) Removed as the new libc for Checker
6320 doesn't contain this bug, apparently.
6322 * misc.c: (str_search, str_rsearch) Changed order of arguments for
6323 consistency with GNU memmem.
6324 (blp_getdelim) Changed `len' from `int' to `size_t'.
6326 * modify-vars.c: Reference implementation.
6328 * som-frnt.c: (zero_length) New global var.
6329 (som_create_table) Message fix.
6331 * som.h: Added gcc attributions to som_set_text(),
6332 som_output_text() prototypes. blank_line() refers to
6333 zero_length[] instead of a literal null string to suppress gcc
6336 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
6337 (allocate_cases) Decrements x_max so the last element of x[] can
6338 be used by the algorithm.
6340 * var.h: Changed minor details of `variable' declaration.
6341 (struct modify_vars_proc) New struct.
6342 (struct variable) Added field p.mfv.
6344 * vars-atr.c: Comment fix.
6346 * vars-prs.c: (fill_all_vars) More optimal implementation.
6348 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
6349 character, which it shouldn't have to do but printf() seems to
6350 read the null byte even though I supply a maximum length...
6352 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
6354 * command.c: Removed command alias X for QUIT.
6355 (parse_cmd) Fixed comment parsing.
6357 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
6359 (read_record) Fixed references to len, size.
6360 (dfm_get_record) Restructured.
6362 * file-handle.h: (struct file_handle) Field `lrecl' now of type
6365 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
6368 * modify-vars.c: New file. Not complete.
6370 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
6373 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
6374 problems caused by int/size_t differences.
6376 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
6379 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
6380 being compared were of equal length.
6382 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
6384 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
6386 * lexer.c: (get_dotted_rest_of_line) New function.
6388 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
6391 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
6392 type 6 records. Frees the dictionary properly.
6393 (read_header) Initializes the dictionary instead of letting
6394 read_variables() do it. Sets the dictionary file label from the
6396 (read_documents) New function.
6398 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
6399 write type 6 record if appropriate.
6400 (write_header) Writes file label from dictionary.
6401 (write_documents) New function.
6403 * temporary.c: (save_dictionary, restore_dictionary,
6404 free_dictionary) Properly handle new fields in dictionary struct.
6406 * title.c: (get_title) Returns after failure().
6407 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
6408 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
6410 * var.h: (struct dictionary) New fields `label', `n_documents',
6413 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
6415 * command.c: Added FILTER to list of commands.
6417 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
6420 * get.c: (cmd_save_internal) Removed weighting code since it's now
6421 handled by sfm-write.c. Properly commented out debug code.
6423 * glob.c: (glob var weighting) Removed.
6425 * sel-if.c: Comment fixes.
6426 (cmd_filter) New function.
6428 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
6429 (sfm_read_dictionary) Sets weighting variable direct in the
6430 created dictionary now. (Apparently we previously didn't support
6432 (read_header) Sets weight_index field in sfm_fhuser_ext from
6433 header read from disk.
6435 * sfm-write.c: (sfm_write_dictionary) Comment fix.
6436 (write_header) Now sets the weighting in the header from the
6437 passed primary dictionary instead of from the sfm_write_info.
6439 * sfm.h: (struct sfm_write_info) Removed field `weight'.
6441 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
6442 broke on boundary conditions.
6444 * var.h: (struct dictionary) New fields `weight_var',
6445 `weight_index', and `filter_var'.
6446 (glob var weighting) Removed. This is now part of struct
6447 dictionary. All references changed; the less mechanical changes
6448 are described above.
6450 * vars-atr.c: (find_dict_variable) New function.
6452 * vfm.c: (static var filter_index) New variable.
6453 (open_active_file) Initializes filter_index from default_dict.
6454 (write_case) Calls proc_func() only if the filter variable is
6455 nonzero; this implements FILTER behavior.
6457 * weight.c: (static var weight_varname) Removed.
6458 (cmd_weight) Modified default_dict instead of glob vars.
6459 (update_weighting) Changed the signature to modify a dictionary
6460 instead of glob vars. Now returns the weighting variable.
6461 (get_weighting_variable) Removed; its function is absorbed by
6463 (stop_weighting) Operates on a dictionary now.
6465 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
6467 * sort.c: Removed debugging info from messages.
6468 (do_external_sort) Cleans up after itself by deleting the
6469 temporary directory on failure. (On success it is deleted by the
6471 (allocate_cases) Removed debug code. Added clean up code.
6472 (output_record) Removed debug code.
6473 (merge) Added code to close all the input files that are currently
6474 open. This is a likely location for bugs, because I'm not sure
6475 about boundary conditions. Removed an unnecesary heap_delete().
6476 (merge_once) Removed input file "optimization" that in fact
6477 screwed up the rest of the code. Message and comment fixes.
6479 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
6481 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
6483 * heap.c: (heap_delete) New argument.
6485 * sort.c: Finished implementation of external sort.
6487 * vfm.c: (read_from_disk) Returns after a disk error.
6489 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
6491 * sort.c: (static var state) Removed.
6492 (static vars max_handles, tmp_basename, tmp_extname,
6493 huffman_queue) New variables.
6494 (do_external_sort) Moved most code to new functions.
6495 Creates huffman_queue.
6496 (allocate_file_handles, allocate_cases) New functions.
6497 (static vars run_no, run_length, file_index, case_count) New
6499 (output_record) Returns success. Now really writes to the output
6501 (begin_run, end_run) New functions.
6502 (write_initial_runs) Returns success. Initializes run_no to -1.
6503 Calls begin_run(), end_run() at appropriate times. Outputs debug
6505 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
6507 (merge) New function.
6509 * heap.c, heap.h: New files. Hopefully in near-final form.
6511 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
6513 * glob.c: Added write_active_file to global vars.
6515 * sort.c: Several new miscellaneous static variables.
6516 (cmd_sort_cases) Big comment fix.
6517 (perform_case_2) Renamed `do_external_sort' and completely
6519 (case_2_proc_func) Removed.
6520 (output_record, write_initial_runs, write_to_sort_cases,
6521 compare_record) New functions.
6523 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
6525 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
6527 * sort.c: (perform_case_2) Changed the method for allocation of
6528 lots of memory--now allocates one case at a time in hopes that
6529 more cases can be allocated with heavily fragmented memory.
6531 * var.h: (write_active_file) New global var.
6533 * vfm.c: (procedure, close_active_file, write_case,
6534 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
6535 arguments to procedure() to be NULL. All references to
6536 procedure() that made use of dummy functions were changed to NULL
6538 (open_active_file) If write_active_file is non-NULL, the output
6539 device becomes DEV_PGM (a new enum).
6540 (close_active_file) Sets write_active_file to NULL.
6541 (read_from_memory) Comment fix.
6542 (record_case) Calls write_active_file() when the output device is
6545 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
6549 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
6550 Fixed checking for duplicate varnames.
6551 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
6553 (autorecode_trns_free) Destroys hash tables for each recoding
6555 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
6557 * command.c: Added SORT CASES to cmd_table.
6558 (null_func, null_int_func) Prototyped.
6560 * descript.g: (calc_weight, calc_noweight) Computes own case
6563 * frequencies.q: (dump_statistics) Fixed problem with
6564 too-few-cases warning message.
6566 * get.c: (cmd_save_internal) Handles weighting properly.
6568 * hash.c: (hsh_dump) Output format changed.
6569 (force_hsh_insert) Actually works now, prototype changed.
6571 * list.q: (static var case_num) New variable.
6572 (cmd_list) Initializes case_num.
6573 (list_cases) Increments case_num.
6575 * var.h: Added definitions for SORT CASES. Comment fixes.
6577 * vfm.c: Some definitions moved to new file vfmP.h. Comment
6578 fixes. `active' renamed vfm_active, `rep' renamed
6579 vfm_replacement, all references changed.
6580 (procedure) The procfunc no longer receives a case number. All
6582 (write_case) Subtle reordering.
6583 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
6586 * weight.c: (get_weighting_variable) New function.
6588 * vfmP.h: New file with definitions from vfm.c.
6590 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
6592 * command.c: (FILE_TYPE_okay) Commented out some tests because
6593 they're clumsy and not yet needed.
6595 * var.h: Most *_trns structures moved to their respective source
6596 files. Some were moved into a new file, do-ifP.h. Comment fixes.
6597 (union any_trns) Changed to a typedef for trns_header.
6598 (struct input_program_pgm) Removed.
6600 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
6601 was allocated in the first place.
6603 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
6605 * autorecode.c: New file.
6607 * command.c: Added AUTORECODE to command table; re-enabled SET.
6609 * data-out.c: (convert_F) Handles infinities and NaNs properly.
6611 * error.c: (vmsg) Comment fixes.
6613 * hash.c: Comment fix.
6614 (hashpjw_d) New function.
6615 (hashpjw) Reimplemented as call to more general function
6617 (internal_comparison_fn) Initializes pointers properly.
6618 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
6619 (force_hsh_insert, force_hsh_find) New debugging wrapper
6622 * main.c: (main) Message fix.
6624 * output.c: (outp_read_devices) Message fix.
6626 * set.q: Comment fixes.
6627 (custom_results) Implemented Wnd/X form of subcommand.
6628 (set_routing) New function.
6629 (internal_cmd_set) Implemented ERRORS, MESSAGES.
6631 * settings.h: (SET_ROUTE_*) New enum series.
6632 (set_results) Renamed set_results_file, all references changed.
6633 (set_messages) Removed.
6634 (glob vars set_errors, set_messages, set_results) New vars.
6636 * title.c: (get_title) Remembers to xstrdup() the result of
6639 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
6641 (union any_trns) New element `arc'.
6643 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
6645 * command.c: (output_line) Removed references to set_screen.
6647 * error.c: (static var terminating) New var.
6648 (hcf) Sets terminating to 1.
6649 (vmsg) If terminating is nonzero, does not attempt to call hcf().
6650 This prevents an infinite loop if an error occurs within hcf().
6652 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
6653 statement circumlocution with `case 42000' trick.
6654 (evaluate_expression) New support for OP_STR_MIS.
6656 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
6657 statement circumlocution with `case 42000' trick.
6658 (dump_node) Handles OP_STR_MIS.
6660 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
6661 variables exceptions.
6662 (parse_function) Message fix.
6663 (ops[]) Added OP_STR_MIS.
6665 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
6667 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
6669 * glob.c: Removed set_scrnfile glob var.
6670 (init_glob) set_errorbreak set to 0 by default.
6672 * groff-font.c: Changed included files.
6673 (groff_read_font) Initializes font_arena local var correctly.
6674 (default_font) New function.
6676 * output.c: Comment fixes.
6677 (glob var disabled_devices) New variable.
6678 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
6680 [GLOBAL_DEBUGGING] (reentrancy) New function.
6681 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
6682 outp_iterate_enabled_drivers) Calls to reentrancy().
6683 (destroy_list) New function.
6684 (outp_done) Moved code to destroy_list().
6685 (parse_options) Parses `listing', `screen', `printer' options
6687 (configure_driver) Sets new `device' member of driver.
6688 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
6690 * output.h: Comment fixes. New enum series OUTP_DEV_*.
6691 (struct outp_driver_struct) New member `device'.
6693 * postscript.c: (find_encoding_file) Doesn't display its own error
6695 (default_encoding) New function.
6696 (switch_font) Calls default_encoding() if no encoding can be
6698 (text) Makes up a character metric if none exists for the desired
6700 (load_font) Properly copies a fallback filename. Calls
6701 default_font() for a font if none at all are known.
6703 * set.q: Comment fixes. Removed OUTPUT subcommand.
6704 (custom_listing) Calls outp_enable_device() to enable/disable
6706 (turn_screen_on) Removed.
6707 (internal_cmd_set) Calls outp_enable_device() to enable/disable
6708 screen, printer devices.
6710 * settings.h: Comment fixes.
6711 (glob vars set_output, set_printer, set_screen, set_scrnfile)
6714 * som-high.c: (som_submit_table, som_eject_page) Use
6715 outp_iterate_enabled_drivers() instead of iterating
6716 outp_driver_list directly.
6718 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
6720 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
6721 (parse_string_as_format) Handles new formats.
6722 (parse_numeric) Now handles DOT and PCT formats.
6724 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
6726 (convert_date) Handle EDATE and SDATE formats.
6727 (convert_CCx) Now if there's not room for the currency characters,
6728 converts it as F format if it's positive instead of giving up
6729 quickly. Also fixed save-and-restore bug with decimal point
6731 (convert_format_to_string) Handles new formats.
6733 * misc.c: (formats[]) Added new formats.
6734 (convert_fmt_ItoO) Supports new formats.
6736 * sfm-read.c: (parse_format_spec) Supports new formats. Better
6737 data checking. New argument, all references changed.
6739 * sfm-write.c: (write_format_spec) Supports new formats.
6741 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
6744 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
6746 * cmdline.c: Comment fixes.
6747 (parse_command_line) Changed return type to void.
6749 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
6751 (parse_numeric) Handles international numbers (comma as decimal
6752 point). Some reformatting.
6754 * data-list.c: (parse_free) Default output format is now
6755 set_format instead of hard-coded F8.2.
6756 (read_from_data_list_list) Emits error message on undefined data
6757 only if set_undefined is nonzero.
6759 * data-out.c: (convert_E) Changes decimal point from period to
6760 comma if appropriate. Restructured. Better comments.
6761 (convert_F) Changes decimal point from period to comma if
6763 (insert_commas) Major bug with handling of negative values fixed.
6764 Also, inserts periods instead of commas if appropriate.
6765 (convert_CCx) New function.
6766 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
6767 (num_to_string) Changed `.' to set_decimal.
6769 * dfm.c: Comment fixes.
6770 (dfm_close) Frees ext->line even in inline_file.
6771 (open_inline_file) New function.
6772 (open_file_r) When opening the inline file: now properly
6773 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
6775 (read_record) Calls fh_close_handle() instead of dfm_close() to
6776 close the inline file. Makes a copy of the line getl_buf to avoid
6778 (dfm_get_record) Restructured. Now checks the return value of
6780 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
6781 checking for use of inline file. No longer tries to close inline
6784 * error.c: (glob var error_already_flagged) New var.
6785 (vmsg) Message change. Now checks max number of errors/warnings,
6788 * file-handle.q: (fh_handle_name) Now allows closing of
6790 (fh_init_files) Reformatted.
6792 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
6794 * getline.c: (getl_include) Fixed bug that popped up when called
6795 when file queue was empty.
6796 (read_console) Resets error_count, warning_count,
6797 error_already_flagged to zero.
6799 * glob.c: Many changes to update list of variables.
6800 (init_compat_dependent) Now this function is called whenever
6801 `compat' changes. It now sets set_seed only if it hasn't
6802 previously been referenced. It now calls
6803 lex_init_compat_dependent().
6805 * include.c: (cmd_include_at) Frees temporary buffer instead of
6807 (cmd_include) Doesn't make copy of include file name.
6809 * lexer.c: Comment fixes.
6810 (init_lex) Moved some code into new function
6811 lex_init_compat_dependent().
6812 (lex_init_compat_dependent) New function.
6813 (hex_val) Simplified.
6814 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
6816 * main.c: Comment fixes.
6819 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
6820 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
6821 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
6822 (setup_randomize) Sets set_seed_used.
6824 * set.q: Comment fixes.
6825 (custom_results) Conditionalizes on `compat'.
6826 (custom_log) Calls custom_journal().
6827 (set_ccx) New function.
6828 (cmd_set) Calls init_compat_dependent() when `compat' changes.
6829 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
6830 when set_decimal changes. Range-checks values for MITERATE,
6831 MNEST. Message fixes.
6833 * settings.h: Comment fixes.
6834 (struct set_cust_currency) New struct.
6835 (set_cc[], set_grouping, set_seed_used) New global vars.
6837 * var.h: (FMT_CCA...FMT_CCE) New output formats.
6838 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
6840 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
6842 * glob.c: Revised variables to correspond to settings.h.
6843 (init_glob) Initializes variables from settings.h properly.
6845 * set.q: Began long-overdue major revision to correspond to new
6846 philosophy. Most code changed.
6848 * settings.h: Mostly changed; reorganized, reordered, large new
6851 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
6853 * get.c: (cmd_save_internal) No longer forces compression off.
6855 * sfm-read.c: (read_compressed_data) If eof is reached when
6856 reading a new instruction octet, only signal error if we're in the
6859 * sfm-write.c: (COMPRESSION_BIAS) New #define.
6860 (struct sfm_fhuser_ext) New member `end'.
6861 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
6862 (ensure_buf_space) New function.
6863 (sfm_write_case) Reimplemented in order to support compression.
6864 (sfm_close) Writes out the remaining contents of the compression
6867 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
6869 * command.c: Defined SAVE and XSAVE commands in command table.
6871 * common.h: second_lowest_value is of type flt64, not double.
6873 * file-handle.h: Comment fix.
6875 * get.c: Comment fixes.
6876 (static var `trns') New.
6877 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
6878 cmd_save_internal, cmd_save, cmd_xsave) New functions.
6879 (dict_delete_run) Clears the variables and frees them now.
6880 (trim_dictionary) Sets default for compression.
6881 On KEEP subcommand, frees deleted variables as well as clearing
6882 them. Finally got the sense of the test for deleting all
6884 [DEBUGGING] (dump_dict_variables) Message fix.
6886 * glob.c: (init_glob) set_compression set to 1 by default.
6888 * list.q: Properly #includes config.h.
6890 * misc.h: New macro REM_RND_UP.
6892 * settings.h: Comment fix.
6894 * sfm-read.c: (structs sysfile_header, sysfile_format,
6895 sysfile_variable; inline function bswap_int32) Moved to new file
6897 (corrupt_msg) [__CHECKER__] No longer induces segfault.
6898 (sfm_read_dictionary) Fixed bug caused by failing to initialize
6900 (read_machine_flt64_info) Fixed some problems caused by confusion
6901 between flt64 and double types.
6902 (read_header) Message fix.
6903 (read_variables) Fixed set of cases in which we byte-swap sv.print
6904 and sv.write. Fixed confusion of flt64 and double.
6906 * sfm.h: (struct sfm_write_info) New.
6908 * som-high.c: (som_draw_title) Properly frees `s'.
6910 * temporary.c: (save_dictionary) Comment fix.
6912 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
6913 (struct trns_header) Formatting fix.
6914 (struct save_trns) New.
6916 * vars-atr.c: (discard_variables) Comment fix.
6918 * sfm-write.c: New file, baseline release.
6920 * sfmP.h: New file, baseline release.
6922 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
6924 * cmdline.c: (parse_command_line) `--version' output updated.
6925 (glob var syntax_message[]) Added my e-mail address.
6927 * file-handle.q, lexer.c, vfm.c: Changed many instances of
6928 `illegal' to `invalid'.
6930 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
6931 uncompression buffer.
6932 (sfm_close) Frees decompression buffer.
6933 (sfm_read_dictionary) Initializes decompression buffer.
6934 (buffer_input, read_compressed_data) New functions.
6935 (sfm_read_case) Restructured; now calls read_compressed_data() to
6936 handle compressed system file data.
6938 * var.h: Comment fix.
6940 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
6942 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
6945 * get.c: New comments. New static var `get_file'.
6946 (cmd_get) Now fully implemented. Calls discard_variables();
6947 initializes fv and lv for all variables; new debug code; sets
6948 up the dictionary; sets up the input program.
6949 (read_from_get, cancel_get) New functions.
6951 * sfm-read.c: Comment fixes.
6952 (sfm_close) New static function.
6953 (sfm_read_dictionary) Properly sets up the class of the
6954 file_handle. No longer cares what size the data is in records of
6955 type 7. Also, on failure, properly cleans up the file_handle and
6957 (read_variables) No longer thinks it knows `nval' of the
6958 dictionary. Now sets p.get.fv, etc., instead of speculatively
6960 (read_value_labels) Fixed off-by-one error in indexing of
6962 (sfm_read_case) New function.
6963 (sfm_r_class) New static var.
6965 * var.h: (get_proc) New struct.
6966 (struct variable) New member p.get.
6968 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
6970 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
6971 the manual's meaning.
6972 (rename_variables) New function.
6973 (trim_variables) Doesn't try to parse MAP any more. Removed debug
6974 code. Now properly reorders the dictionary on the KEEP keyword.
6976 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
6979 * vars-atr.c: (clear_variable) New argument `dictionary *'.
6980 (rename_variable) New function.
6981 (free_val_lab) Reformatted.
6983 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
6985 * var.h: Reindented entire file. Comment fixes.
6986 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
6988 (glob var default_dict) New.
6989 (struct indirect_dictionary) Removed.
6991 * Many other source files were changed to add `default_dict.'
6992 before all references to the dictionary of the active file.
6994 * vars-atr.c: (make_indirect_dictionary) Removed.
6996 * glob.c: Reindented all variable declarations. Updated for
6997 changed var.h. Comment fixes.
6999 * temporary.c: (restore_dictionary, save_dictionary) Simplified
7000 because now we can mainly copy dictionary structs.
7002 * vars-prs.c: (is_dict_varname, parse_dict_variable,
7003 parse_variables) Takes dictionary instead of indirect_dictionary
7005 (parse_variables) Instead of calling make_indirect_dictionary,
7006 just sets DICT to &default_dict if DICT is NULL. Of course, lots
7007 of `*dict.' references had to be changed to `dict->'. Removed
7010 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
7012 * get.c: Added GTSV_OPT_* series of enums.
7013 (trim_dictionary, dict_delete_run) New functions.
7014 [DEBUGGING] (dump_dict_variables) New function.
7015 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
7016 [DEBUGGING] Calls dump_dict_variables() to display results.
7018 * glob.c: (cmp_variable) Now a public function declared in var.h.
7020 * sfm-read.c: Turned off debug code. Comment fixes.
7021 (read_machine_int32_info, read_machine_flt64_info) New functions
7022 to parse type 7 records.
7023 (sfm_read_dictionary) Properly byteswaps several fields now.
7024 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
7025 records. [DEBUGGING] Dumps dictionary.
7026 (read_variables) Sets `index' field of variables created properly.
7027 Constructs avl tree of variables in dictionary. [DEBUGGING] No
7028 longer dumps dictionary.
7029 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
7031 [DEBUGGING] (dump_dictionary) No longer stubbed out.
7033 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
7034 var before destroying any variables just to save a little time.
7036 * var.h: (struct variable) Reordered in order to make name[] the
7037 first member; this makes pointers to `variable' pointers to the
7038 variable name, simplifying avl trees, etc.
7039 (struct indirect_dictionary) New struct.
7041 * vars-atr.c: (find_variable) Rewritten for efficiency.
7042 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
7044 (is_varname) Rewritten for efficiency.
7045 (parse_variables) New argument, which is a `dictionary *'. All
7046 references changed. This function now reads variable names from
7047 the dictionary passed, or from the default dictionary if NULL.
7049 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
7051 * misc.h: Added new macro DIV_RND_UP to perform integer division,
7052 rounding up. Changed many references to ROUND_UP to use this
7055 * sfm-read.c: Includes avl.h.
7056 (corrupt_msg) Induces a segfault under Checker.
7057 (macro assertive_bufread) New. Many references to bufread() now
7059 (sfm_read_dictionary) Split up into several functions. Added code
7060 to read dictionary records following the the type 2 records. Not
7061 quite complete. New variable `var_by_index'.
7062 (read_header, read_variables) New functions extracted from
7063 sfm_read_dictionary().
7064 (read_value_labels) New function.
7065 (bufread) Checks ferror() if fread() doesn't return the expected
7066 value; if ferror() is zero it's just EOF.
7067 (dump_dictionary) Stubbed out.
7069 * BTW: The source code now exceeds 50000 lines!
7071 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
7073 * command.c: Added GET to cmd_table[].
7075 * list.q: Removed reference to alloca headers.
7076 (cmd_list) Gave prototype.
7078 * sfm-read.c: Added DEBUGGING comments.
7079 (sfm_read_dictionary) Checks bias correctly. Sets
7080 dict->var_by_name to NULL. Calculates long_string_count
7081 correctly. realloc's dict->var[] array to minimum size.
7082 [DEBUGGING] Calls dump_dictionary.
7083 [DEBUGGING] (dump_dictionary) New function.
7085 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
7086 (restore_dictionary) If the dictionary contains a non-NULL
7087 var_by_name, uses that instead of generating one.
7088 (free_dictionary) Destroys var_by_name.
7090 * var.h: (struct dictionary) Added field `var_by_name'.
7092 * get.c: New file, not complete.
7094 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
7096 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
7097 (parse_num_or_range) New function.
7098 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
7099 <n> THRU HIGH missing values.
7101 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
7102 __attribute__((const)).
7104 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
7106 * sfm-read.c: Finished reference implementation.
7108 * sfm.h: Includes var.h.
7110 * var.h: Comment fixes.
7111 (struct `variable') Reordered some fields.
7113 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
7114 constants added previously.
7116 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
7118 * common.h: Comment fixes. Added declaration of
7119 `second_lowest_value' as variable or macro. Made `compat_type',
7120 `pgm_state_type' into anonymous enums.
7122 * display.c: Comment fix.
7124 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
7126 [!defined SECOND_LOWEST_VALUE] Added definition for
7127 `second_lowest_value' global var.
7128 (compat, pgm_state global vars) Changed types to `int'.
7129 (init_glob) Initializes `second_lowest_value'.
7131 * sfm-read.c: Continued work, not complete.
7133 * var.h: Added new MISSING_* constants to handle LOWEST and
7136 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
7138 * sfm-read.c: New file, not complete.
7140 * cases.c: (vec_insert) Changed vector expansion algorithm.
7141 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
7142 mucking up the RECODE transformation in particular.
7143 (envector) Harmless change in notation.
7145 dfm is now fairly well tested again.
7146 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
7148 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
7150 * recode.c: Comment fix.
7152 * sfm.h: Interface should be fairly final now, or at least for a
7155 * vfm.c: [DEBUGGING] (index_to_varname) New function.
7156 (open_active_file) [DEBUGGING] Translates ccase indices into
7157 variable names now to make it easier to understand what's really
7160 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
7162 * data-in.c: Comment fix.
7164 * data-list.c: Includes dfm.h.
7165 (do_reading) Uses new function dfm_push_cust().
7167 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
7170 * file-handle.h: Completely changed. Some parts split off into
7171 new file dfm.h. Implemented in file-handle.q.
7172 (enum FH_*) Removed.
7173 (struct fh_ext_class) New struct.
7174 (struct file_handle) Retained only these fields: name, norm_fn,
7175 fn, recform, lrecl, mode. New fields class, ext.
7176 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
7177 close_handle, handle_name) Added `fh_' prefix to name, all
7180 * dfm.h: New file, implemented in dfm.c.
7181 (get_record, put_record, fwd_record, bkwd_record, set_record,
7182 get_cur_col) Functions moved from file-handle.h, now prefixed with
7184 (dfm_push_cust) New function.
7186 * sfm.h: New file. Incomplete.
7188 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
7189 interface. Functions reordered, comments changed. Not well
7190 tested, probably full of bugs.
7191 (struct dfm_fhuser_ext) New struct.
7192 (dfm_close) New function.
7193 (open_file_r) Pickier about finding `BEGIN DATA.' line.
7194 (open_file_w) User messages changed.
7195 (get_record) Comment fixed.
7196 (read_record) Increments ext->ln even for inline_file. Calls
7197 dfm_close() for inline_file when `END DATA.' encountered.
7198 (dfm_get_record) Experimental restructuring.
7199 (dfm_push_cust) New function.
7200 (cmd_begin_data) Detects whether the inline file was fully read by
7201 checking whether it is still open; detects whether it was read at
7202 all by checking whether the line number is greater than zero.
7204 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
7205 interface. Functions reordered, comments changed. Not well
7206 tested, probably full of bugs.
7207 (init_file_handle) Removed initializers for obsolete fields, added
7209 (fh_close_handle) Much simpler, now mainly calls the class
7211 (fh_init_files) Renamed inline file internal filename.
7213 * file-type.c: Includes dfm.h.
7214 (read_from_file_type) Doesn't use dfm internal state anymore.
7216 * inpt-pgm.c, print.c: Include dfm.h.
7218 * recode.c: (internal_cmd_recode) Casts strlen() return value to
7219 int in comparison with other int.
7221 * som-high.c: (build_target) Fixed operator precedence problem in
7222 if statement (& versus ==).
7224 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
7226 * dfm.c: (read_record) Can now read fixed-length records; not
7228 (put_record) Can now write fixed-length records; not tested.
7230 * file-handle.h: FH_* defines changed to enums. New enum series
7232 (struct file_handle) New members recform, lrecl, mode.
7234 * file-handle.q: Parser changed.
7235 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
7236 /LRECL subcommands. These are compatible with Windows.
7237 (init_file_handle) Initializes recform, mode fields.
7239 * q2c.c: (get_line) When outputting `!' comment lines, now
7240 increments the output file line number so that `#line' directives
7242 (make_identifier) New function that converts an arbitrary string
7243 into a valid C identifier.
7244 (dump_vars) Calls make_identifier() in two places in order to
7245 suppress some errors for bad identifiers.
7246 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
7247 for NO. Allows numbers to be prefixed by underscores to make them
7248 acceptable C identifiers but still to be parsed as numbers by the
7251 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
7253 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
7255 * dfm.c: Comment fixes. (get_record) Gives error if file handle
7256 was opened for writing.
7257 (open_file_w) New function.
7258 (read_record) Uses strncasecmp if available. Improved error
7260 (put_record) New function.
7262 * file-handle.h: Moved function comments into dfm.c and
7263 file-handle.q. Comment fixes. Removed declarations of
7264 tilde_expand() and normalize_filename().
7265 (struct file_handle) Changed `open' from boolean to enumerated
7266 field to allow for three states--closed, open for reading, open
7267 for writing--all references changed.
7269 * file-handle.q: Includes filename.h.
7271 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
7273 (alloc_line) Makes allowance for line terminator characters in
7275 (print_trns_proc) Now handles OUTFILE, WRITE differences.
7276 (print_space_trns_proc) Handles OUTFILE differences.
7278 * recode.c, sample.c: Comment fixes.
7280 * var.h: (struct print_trns) Changed boolean field `eject' to
7281 bitmapped field `options'; all references changed. New enums
7282 PRT_* for use with this field.
7284 * exception.h, test-exception.c: Removed.
7286 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
7288 * ascii.c: (delineate) Turned off debug output.
7290 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
7293 * data-in.c: (parse_string_as_format) Sets the entire string value
7294 to spaces, not just the short string part of it. Is this correct
7297 * data-out.c: (convert_date) Fixed DATETIME format problems with
7298 decimal places, removed debug code.
7300 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
7301 middle of parsing BEGIN DATA that would cause the lexer to read
7302 from a wild pointer `prog'; now calls new function
7303 preprocess_line() in lexer.c.
7305 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
7307 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
7308 Now call induce_segfault() to induce the segfault.
7309 (induce_segfault) New function.
7311 * expr-opt.c: Comment fix.
7312 (parse_sysvar) New function.
7313 (parse_primary) Added system variable support--calls
7315 (global var ops) Added OP_CASENUM operator.
7317 * expr.h: Comment fixes.
7318 (OP_* enum) added OP_CASENUM operator.
7319 (struct casenum_node) New struct.
7320 (union any_union_union) New member `cas' of type `casenum_node'.
7322 * glob.c: (global var last_vfm_invocation) New var.
7323 (init_glob) Initializes last_vfm_invocation.
7325 * lexer.c: (lookahead) Fixed reversed condition on if statement.
7327 * getline.c: (get_line) Split into get_line() and preprocess_line().
7328 (preprocess_line) New function.
7330 * var.h: Declares last_vfm_invocation.
7332 * vfm.c: (procedure) Sets last_vfm_invocation.
7334 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
7336 * command.c: (parse_cmd) Fixed bad assertion related to
7339 * data-in.c: (parse_month) Implemented to parse months according
7340 to full interpretation of standard.
7341 (to_roman) New function.
7342 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
7343 (parse_weekday) Bug fix (forgot to skip all the day name).
7345 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
7346 up parsing of multirecord data items. Also fixed user message.
7348 * data-out.c: Comment fix.
7349 (year2, year4, convert_date, convert_time, convert_WKDAY,
7350 convert_MONTH) New functions to support time & date output.
7351 (convert_format_to_string) Calls new time & date output routines.
7353 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
7355 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
7358 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
7360 * misc.c: (global var formats) Fixed declarations of DATETIME,
7363 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
7364 the output_char buffer.
7366 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
7367 memory bug. Fixed user messages.
7369 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
7371 * Removed #pragma argsused from lots of places.
7373 * data-in.c: Implemented zoned decimal and time-date formats.
7374 Untested. This is a huge chunk of code--maybe 1000 lines and 50
7377 * data-out.c: Implemented zoned decimal format.
7379 * expr.h: Moved yrmoda() declaration here from exprP.h.
7381 * misc.c: (global var formats) Minor fixes--added
7382 FCAT_SHIFT_DECIMAL to formats N and Z.
7383 (convert_fmt_ItoO) Added support for format Z.
7385 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
7387 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
7389 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
7390 som_check_workspace() that is activated between commands.
7392 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
7395 * list.q: (begin_row) Changed title expansion style from
7396 SOPT_X_VERT to SOPT_X_SHSP.
7398 * som-frnt.c: Now includes `somP.h'.
7399 (som_push_workspace, som_pop_workspace) New functions that, taken
7400 together, form a solution to the recursive table building problem
7401 mentioned yesterday. Surrounded every table output routine
7402 throughout the program with calls to these functions.
7403 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
7404 (som_create_table) Checks that there's an active workspace.
7405 (som_destroy_all_tables, som_crush) Removed.
7407 * som-high.c: (global var som_preserve_tables) Removed, all
7409 (som_submit_table) Checks that there's an active workspace.
7410 (dump_columnated_table) Doesn't columnate tables that would have
7411 just one row per column.
7412 (dump_crush_page, som_dump_crush_page) Removed debugging code.
7413 (som_dump_crush_page) Moved row number labels from left side of
7414 tables to right side.
7415 (som_get_table_size) Added support for SOPT_X_SHSP.
7417 * som.h: New cell expansion type SOPT_X_SHSP.
7419 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
7421 (global var curtab_arena) Moved from som-frnt.c.
7423 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
7425 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
7426 that causes bad location warnings to be suppressed.
7427 (delineate) Saves current font when calling draw_text(); fixed
7428 handling of NULLs when backing up. Also fixed line-wrapping bug.
7430 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
7431 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
7433 * common.c: Added code to cause assertion failure to dump core
7434 when run under Checker.
7436 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
7437 there are still bugs.
7439 * glob.c: (__eprintf) Removed.
7441 * list.q: Inserted som_preserve_tables kluge that prevents tables
7442 from being thrown away due to recursive table building through
7443 som_output_line being called from a transformation during the LIST
7444 procedure invocation. This is a general problem that must be
7445 solved in a better way since it applies to all procedures in
7447 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
7448 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
7450 * numeric.c: Fixed several errors in the form of msg() calls.
7452 * print.c: Updated for use of som.
7453 (dump_table) Reimplemented.
7454 (print_trns_proc) Calls som_eject_page() instead of eject_page().
7455 Calls som_output_text() instead of outs_line().
7457 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
7459 (som_output_text) Function moved from som-low.c. Interface
7462 * som-high.c: (som_preserve_tables) New global public variable
7464 (som_submit_table) Destroys the tables only if som_preserve_tables
7466 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
7467 one subrow per row. Now labels subrows if there's more than one
7469 (dump_crush_table) Added wishlist comment.
7470 (som_eject_page) New public function declared in som.h.
7472 * som-low.c: (som_dump_crush_page) Draws row labels if there's
7473 more than one subrow per row.
7474 (som_output_text) Moved to som-frnt.c.
7476 * som.h: (SOM_TOPT_PRESERVE) Removed.
7478 * title.c: (get_title) Changed interface.
7479 (cmd_title) Changed `title' to `outp_title'.
7480 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
7482 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
7484 * list.q: (flush_table) Conforms to new partial options in
7485 som_submission_form.
7487 * som-high.c: (paginate_horizontally) Changed form of subrow
7489 (build_target) Omits spacing before table if
7490 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
7491 (dump_crush_page) Changed interface. Only trims bottom rule if
7492 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
7493 (dump_crush_table) Handles partial tables.
7494 (output_row_label) New function.
7495 (som_dump_crush_page) Emits subrow number labels. Draws vertical
7496 rule on the right edge of narrow subrows.
7498 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
7499 constants to a series of SOM_TOPT_PARTIAL_* submission options.
7500 All references updated.
7502 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
7504 * misc.c: Comment fix.
7506 * som-high.c: (examine_table) Treats crushed tables separates for
7507 purpose of determining header size.
7508 (paginate_horizontally) Allots space for line numbers in crushed
7509 tables with lots of subrows per row. Calculates the `maximum page
7510 width', the width of the widest horizontal page.
7511 (build_target) Removed trim argument; all references changed.
7512 Stricter assertions. (dump_crush_page) New function.
7513 (dump_crush_table) Reimplemented.
7515 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
7516 (som_dump_crush_page) Reimplemented, interface changed.
7518 * somP.h: Many many new helper macros for use with crushed tables.
7519 (global var som) Removed `tv', `cum_y' members; all references
7520 removed. New members `mpw', `digit_space'.
7522 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
7524 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
7525 variable, changed to constant 1024.
7526 (arena_ca_strdup) Changed `sizeof(a_string)' to
7528 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
7529 `(c_string *)' to `(char *)'; this fixed some offset problems.
7531 * filename.c: (readlink_malloc) Changed initial allocation from
7533 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
7536 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
7537 &fm->owner in several places.
7539 * som-high.c: (output_table) Changed interface to rest of world.
7540 (examine_crush_table) Removed. Crushed tables are re-broken now,
7541 in preparation for rewrite.
7543 * som.h: Comment fix.
7545 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
7547 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
7548 itself in the cleanup stage.
7550 * descript.q: (display) At least temporarily, changed the table
7551 format to a crushed table.
7553 * list.q: (begin_row) At least temporarily, added horizontal lines
7556 * som-high.c: (examine_crush_table) Sets som.hh to the width of
7557 the horizontal "headers," that is, to the width of the far left
7558 and far right rules.
7559 (justify_pagination) Sets som.th to the width of the widest row
7560 in the crushed table. Fixed inner loop off-by-one error.
7562 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
7565 * somP.h: Comment fix.
7567 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
7569 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
7570 before closing it; also, opens the constructed filename `s'
7571 instead of f->filename.
7573 * postscript.c: Moved initialization of x->loaded, x->prop,
7574 x->fixed, x->current, also the add_encoding() calls, into
7576 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
7577 sets x->last_font to NULL; sets x->next_combo to zero.
7579 * som-high.c: (crushed_row_height) Moved definition farther up.
7580 (som_submit_table) Doesn't calculate line width, font size until
7581 after calling open_page(), to accomodate changes to PostScript
7583 (vert_headers) Removed; equivalent functionality moved to
7584 examine_table(), examine_crush_table().
7585 (justify_pagination) Replaced with different algorithm.
7586 (dump_crush_table) Bugfix that caused tables to fail to be clipped
7587 at the bottom of the page.
7589 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
7591 * command.c: Added cmd_list back into cmd_table.
7593 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
7594 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
7596 * list.q: (flush_table) Updated to new som_submission_form format.
7598 * som-frnt.c: Comment fix.
7600 * som-high.c: Changed `#endif' to `#undef EXTERN'.
7601 (output_table) Calls som_get_table_size() directly; handles
7603 (examine_crush_table) New function; calls vert_headers().
7604 (examine_table) Moved some code into new function, vert_headers().
7605 (justify_pagination) New function.
7606 (dump_plain_table) Removed `static' from `cy'.
7607 (dump_crush_table) New function.
7609 * som-low.c: (som_dump_crush_page) New function.
7611 * som.h: Comment fixes.
7612 (enum SOM_TOPT_CRUSH) New.
7613 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
7614 Temporarily set to zero to make do with LIST procedure.
7616 * somP.h: Re-ordering.
7618 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
7620 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
7622 * somP.h: New file for use by som-high.c, som-low.c.
7624 * q2c.c: Added definition for VME.
7625 (get_line) Now dumps `!' comment lines to the output file
7628 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
7629 set.q: Changed format of `!' comment lines.
7631 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
7633 * All source files: Added copyright notice.
7635 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
7636 longs in msg() calls.
7638 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
7640 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
7642 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
7644 * output.c: (outp_read_devices) Changed criteria for
7645 distinguishing different types of lines.
7647 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
7649 * cmdline.c: Changed syntax message.
7651 * filename.c: (good_getcwd) Bug fix (?).
7652 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
7654 (search_path) Appends DIR_SEPARATOR to directory name only if it
7655 does not already end with one.
7657 * glob.c: Checks STAT_PAGER envvar before PAGER.
7659 * output.c: Checks environment variables instead of just local
7662 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
7664 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
7665 when the pointer passed to the function was within the arena
7666 itself, so that it couldn't properly be set to NULL _after the
7669 * command.c: Re-enabled DISPLAY.
7671 * display.c: Rewritten to handle tables. Untested.
7673 * filename.c: (search_path) Fixed memory leak.
7675 * frequencies.q: (cmd_frequencies) Frees v_variables.
7676 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
7677 (cleanup_freq_tab) New function to garbage collect.
7678 (dump_full) Elegantized.
7680 * main.c: New comment.
7682 * output.h: New tag for tagged quotes: TAG_NEWLINE.
7684 * postscript.c: Comment fix.
7685 (release_fontmap, free_font_entry) New functions.
7686 (ps_init_driver) Sets free_font_entry() as the freefunc for
7687 hashtable `loaded'. Calls release_fontmap() when destroying a
7688 driver; also frees the output filename; also frees the
7689 ps_driver_ext block.
7690 (free_ps_encoding) Frees the filename as well as the encoding
7692 (output_encodings) Frees the line buffer and pops the msg-filename
7694 (read_fontmap) Frees the fontmap filename and the line buffer.
7695 (postopen, preclose) Misc. garbage collection fixes.
7696 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
7697 to NULL; this fixes some output problems.
7698 (text) Handles TAG_NEWLINE. Untested.
7700 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
7701 (som_set_string) Removed. All references changed to
7703 (som_set_text) Rewritten. New interface. More general.
7705 * som.h: Minor format changes.
7706 (struct som_value_cell) Removed; all references changed to
7708 (enums SOT_*) Changed.
7710 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
7712 * command.c: Re-enabled SPLIT FILE.
7714 * postscript.c: Comment fix.
7716 * som.h: Added `SOT_NONE'.
7718 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
7720 * vfm.c: (dump_splits) Reimplemented.
7722 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
7724 * Compiled the project under gcc 2.7.2, which gave some new
7725 warnings. This led to many additions of casts from unsigned to
7726 int sprinkled throughout the code.
7728 * arena.c: Many uses of `unsigned' changed to `size_t'.
7730 * command.c: Added END FILE, END REPEAT to command table.
7731 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
7732 (find_command, FILE_TYPE_okay) Not commented out anymore.
7733 (parse_cmd) Calls FILE_TYPE_okay again.
7734 (output_line) Added calls to som_output_text() to put the line
7735 in the output files.
7737 * common.c: (macro VME) Format changes.
7738 (xstrdup) Asserts that its argument is not NULL.
7740 * data-list.c: Implemented dump_fixed_table().
7742 * inpt-pgm.c: Formatting changes. Comment changes.
7743 (end_case_proc) Renamed end_case_trns_proc.
7744 (cmd_end_file, end_file_trns_proc) New functions.
7746 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
7748 * misc.h: (local_strdup) New macro corresponding to strdup() but
7749 allocating its data through local_alloc() if possible--that is, if
7752 * postscript.c: Comment changes.
7753 (quote_ps_name, quote_ps_string, output_encodings) New functions.
7754 (output_line, add_string) New macros supporting
7756 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
7757 substitution vars. Calls output_encodings() when a line
7758 consisting of `!encodings' is encountered.
7759 (preclose) Some code moved into quote_ps_string().
7760 (dump_line) Changed into macro supporting dump_fancy_line().
7761 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
7762 command when appropriate.
7763 (write_text) Fixed `literal_char' array (I think it's fixed, at
7765 (text) Fixed bug when width was zero. Now exits immediately on
7766 zero height_left. Now, when executing `goto restart;', checks
7767 that cp<end, so that we don't read beyond end-of-string. Also,
7768 outputs the correct code to the output file by outputting the code
7769 from the metric instead of the internal metric index.
7771 * repeat.c: (cmd_end_repeat) New function.
7773 * som.c: (var som) `headers' renamed `options' and semantics
7774 changed. All references changed.
7775 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
7776 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
7778 (som_text_table) Removed.
7779 (som_output_text) New function.
7781 * som.h: (struct som_submission_form) Removed `header', `reuse',
7782 replaced with bitmapped field `options'.
7783 (SOM_TOPT_*) New enum set for som_submission_form.options.
7784 (SOT_*) New enum set for som_output_text().
7786 * temporary.c: (copy_variable) When copying the var label, only
7787 calls xstrdup() if it's non-NULL.
7789 * var.h: (enum type `vartype') Removed; all references changed to
7792 * vars-atr.c: (init_variable) Changed local var `nbytes' from
7795 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
7797 * font.h: Comment changes.
7799 * groff-font.c: (groff_read_font) Initializes `name' field to
7800 NULL. Handles `encoding' field.
7802 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
7804 * postscript.c: (struct font_entry) Removed `position' field.
7805 (struct ps_font_combo) New struct.
7806 (struct ps_driver_ext) Removed field `next_position'. New fields
7807 `combos', `next_combo'. `last_font' field changed from
7808 `font_entry *' to `ps_font_combo *'.
7809 (ps_init_driver) Reformatted; handles new fields. When
7810 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
7812 (get_encoding, find_encoding_file) New functions.
7813 (add_encoding) Some code moved out into find_encoding_file().
7814 (postopen) Changed value for ${title}.
7815 (preclose) Sets `loaded' field to NULL after destroying the hash
7817 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
7819 (ps_text_set_font_by_position) Figures out the current family if
7821 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
7822 (switch_font) Implemented.
7823 (write_text) Calls switch_font() more often. Format changes.
7824 #undefs its macros after they're no longer useful.
7825 (text) Changed `continue' at one point to a jump to the top of the
7826 loop because we don't want `separate' reset to 0 at that point.
7827 (load_font) No longer sets `position' in the font_entry created.
7829 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
7831 * font.h: (struct font_desc) New member `encoding', which is not
7832 properly handled yet.
7834 * glob.c: (init_glob) Some new i18n code, which is probably
7837 * output.c: (outp_read_devices, outp_get_paper_size) Changed
7838 `size' local from `int' to `size_t'.
7840 * postscript.c: New driver configuration parameter `auto-encode'.
7841 New enums OPO_AUTO_ENCODE, ODA_COUNT.
7842 (struct font_entry) New member `position'.
7843 (struct ps_driver_ext) Reordered. New hash table member
7844 `encodings'; new members `next_position', `next_encoding',
7845 `last_font'. Members `current', `prop', `fixed' changed from type
7846 `font_desc *' to `font_entry *'; all references changed.
7847 (struct ps_encoding) New struct.
7848 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
7849 free_ps_encoding, add_encoding) New functions.
7850 (ps_init_driver) Added OPO_AUTO_ENCODE to default
7851 x->output_options. Initializes new members of ps_driver_ext.
7852 Changed default value for prologue_fn, encoding_fn. Calls
7853 read_ps_encodings after loading default fonts.
7854 (option_tab[], ps_option) Handle new configuration parameter.
7855 (switch_font) New function.
7856 (struct output_char) `font' member changed from `font_desc *' to
7857 `font_entry *'. New member `separate'.
7858 (read_fontmap) Changed `size' from `int' to `size_t'.
7859 (output_line, put_number) New macros for write_text().
7860 (write_text) Optimizes text output by consolidating multiple
7861 calls to PostScript `show' operator.
7862 (text) Keeps track of when text arguments can't be consolidated by
7863 write_text(), and marks those spots in the output stream.
7864 (load_font) Sets `position' of the allocated font_entry to -1, cuz
7865 the font hasn't been switched to by switch_font(), which is where
7866 the position is important--the PostScript is what cares about the
7869 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
7871 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
7872 call a NULL free_func.
7873 (hsh_rehash) Elegantized.
7874 (hsh_probe) Fix bug that manifested when the table was expanded
7875 and thus had to change location in memory. Good thing
7876 too--otherwise could have been much more subtle.
7877 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
7878 (hsh_foreach) New function for hash table iteration.
7880 * hash.h: (struct hsh_iterator) New.
7882 * lexer.c: (parse_tagged_quote) Font and family name strings in
7883 tags are now null-terminated.
7885 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
7887 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
7888 documented. (Never before tested?)
7890 * output.h: Comment changes.
7892 * postscript.c: New driver options `optimize-text-size',
7893 `optimize-line-size', `max-fonts-simult'. New enum set for
7894 specing cached line types. Comment fixes.
7895 (struct line_form) New struct.
7896 (struct ps_driver_struct) New members `text_opt', `line_opt',
7897 `max_fonts', `lines'.
7898 (ps_init_driver) Initializes new members of ps_driver_struct.
7899 (user option type enum set) New member `nonneg_int_arg'.
7900 (static var option_tab[]) Supports new options.
7901 (ps_option) Handles new options.
7902 (find_ps_file) Made static. No longer calls hsh_dump().
7903 (ps_get_var) Made static.
7904 (preclose) Dumps out proper DSC trailer.
7905 (ps_open_page) Elegantized.
7906 (ps_close_page) Calls dump_lines() if appropriate.
7907 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
7908 wrappers around line().
7909 (int_2_compare, compare_line, dump_line, dump_fancy_line,
7910 dump_lines, hash_line, free_line, line) New functions for support
7912 (write_text, text) Made static.
7913 (text) Added to font support, not finished.
7915 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
7917 * font.h: (struct font_desc) New members ascent, descent.
7919 * groff-font.c: (groff_read_font) Calculates font ascent and
7920 descent from the ascent and descent of the `d' and `p' characters,
7921 respectively, as per a suggestion on comp.fonts.
7923 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
7924 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
7926 (write_text) Handles text right-justification and centering (not
7927 full justification). Still very inefficient. (One output line
7929 (struct output_char) Added fields for font and font size.
7930 (text) Many bugfixes.
7932 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
7934 * cmdline.c: (usage) Calls outp_list_classes().
7936 * font.h: Comment fix.
7938 * groff-font.c: New exported global var `space_index'.
7939 (groff_init) New function to initialize `space_index'.
7940 (hash_kern) Casts result to unsigned.
7941 (font_name_to_index) Renamed font_char_name_to_index. All
7942 references changed. Also, now returns the value of `space_index'
7943 when passed an ASCII space character as an argument. Fixed
7945 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
7946 Handles passed NULL pointers properly.
7948 * lexer.c: (parse_tagged_quote) Comment fix. Better range
7951 * output.c: (outp_list_drivers) Removed. Removed all references.
7953 * output.h: Comment fixes.
7955 * postscript.c: (ps_open_global) Calls groff_init().
7956 (output_char) New structure.
7957 (write_text) New function.
7958 (text) No longer stubbed out! Now the output is correct--with a
7959 few exceptions, one of them being that the page has to be held
7960 upside down into a mirror.
7962 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
7964 * font.h: Comment fix.
7966 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
7967 All callers changed.
7968 (number_to_index) Renamed font_number_to_index, made extern. All
7970 (font_get_kern_adjust, font_get_char_metrics) New functions.
7972 * output.h: New constant OUTP_T_INTERNAL_DRAW.
7974 * postscript.c: Changed default line width back to 1/2 point.
7975 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
7976 in the center of the space allotted for them, not just a fixed
7977 offset from the edge of the space; this fixes some bugs.
7978 (ps_line_intersection) Now supports all command line styles.
7979 (ps_text_get_size) Bug fix in computation of em width.
7980 (text) New function, the meat behind ps_text_metrics and
7981 ps_text_draw. Not complete.
7982 (ps_text_metrics, ps_text_draw) Removed the stub taken from
7983 ascii.c; call text().
7985 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
7987 * arena.c: (arena_free) Assert that the argument is non-NULL.
7989 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
7990 only if old_kern is non-NULL.
7992 * postscript.c: (ps_init_driver) Changed default line width to 1
7994 (postopen) New prologue variables.
7995 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
7996 more of the common line styles properly, but not all.
7997 (ps_text_metrics) Fixed problem with this stubbed out version that
7998 kept it from taking font sizes into account.
8000 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
8002 * arena.c: (arena_malloc) Bug fix.
8003 (arena_dump) [GLOBAL_DEBUGGING] New function.
8005 * ascii.c: Comment fix.
8006 (count_fancy_chars, delineate) Now static functions.
8008 * filename.c: (interp_vars) Bug fixes.
8010 * font.h: Comment fixes.
8012 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
8013 beginning in case we have an error message to display before
8014 initializing the display.
8016 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
8018 (groff_read_font) Bug fixes.
8019 (name_to_index) Increments hash.used. Sets `name' field of hash
8021 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
8023 * hash.c: Return type changed.
8025 * postscript.c: Continued development. Now marks lines on the
8026 paper, but very buggy.
8028 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
8030 * Changed comments in many source files from `/* xxx /* yyy */' to
8031 `/* xxx */ /* yyy */' for cleanliness.
8033 * arena.c: (arena_sd_strdup) New function.
8035 * ascii.c: (struct ascii_driver_ext) New member `file'.
8036 (ascii_init_driver) Fills out member `file' for initing; uses
8037 close_file_ext for closing drivers.
8038 (ascii_option) Changed %.*s back to %s because the a_string's are
8039 always null-terminated.
8040 (postopen, preclose) New functions.
8041 (ascii_open_page) Uses new style of open_file_ext.
8042 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
8043 instead of this->output.
8044 (__assert_fail) Removed.
8046 * cmdline.c: Changed syntax_message[].
8048 * error.c: #include's <readline/history.h> only if the history
8049 library is available, not if just the readline library is
8052 * filename.c: (expand_line) Removed alloca() support.
8053 (interp_vars) No longer tilde-expands argument. Limit on output
8055 (tilde_expand) Now treats argument as path rather than filename.
8056 [!unix] Now is a no-op function.
8057 (search_path) Better verbose message formatting.
8058 (open_file, close_file) Comment fixes.
8059 (close_file) [!unix] Doesn't bother with pipes.
8060 (open_file_ext) Completely rewritten, interface revamped.
8061 (close_file_ext) New function.
8063 * font.h: Comment changes.
8065 * frequencies.q: Removed AIX alloca support since it doesn't use
8068 * hash.c: Comment changes & additions.
8069 (hsh_create) Initializes entire table instead of first M entries.
8070 (hsh_probe) Stupid bug fixed. Now it works.
8071 (hsh_dump) [GLOBAL_DEBUGGING] New function.
8073 * main.c: (parse) Detects EOF properly in token-eating loop.
8074 Should the STOP token have its value changed to 0?
8076 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
8077 (blp_getline) Now it's a macro.
8079 * output.h: (struct outp_driver) Removed members output, filename.
8081 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
8082 drivers in driver table.
8083 (outp_read_devices) Frees buf. Warns if there are no active
8085 (outp_configure_clear) Sets outp_configure_vec to NULL after
8086 deleting its elements.
8087 (configure_driver, destroy_driver) Removed references to output,
8088 filename members of outp_driver.
8089 (outp_evaluate_dimension, internal_get_paper_size,
8090 outp_get_paper_size) New functions.
8092 * postscript.c: Continued development. Now links but doesn't make
8093 any marks on the page. Lotsa bugs I suppose.
8095 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
8097 * str.h: Comment changes.
8099 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
8101 * Removed dependencies on non-nested comments in several files.
8102 Also removed references to (unix || __unix__) in #if's since
8103 prefh.orig makes those two equivalent.
8105 * ascii.c: (ascii_open_global) Creates ascii_arena.
8106 (ascii_close_global) Destroys ascii_arena.
8107 (ascii_init_driver) Doesn't create ascii_arena.
8108 (ascii_copy_driver) Removed.
8109 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
8110 (outp_class ascii_class) Removed ascii_copy_driver reference.
8112 * frequencies.q: Now can display all statistics except median.
8115 * output.c: Handles outp_class.ref_count so output class
8116 destructors are called properly.
8117 (add_class) Sets ref_count to 0.
8118 (configure_driver) Initializes class if ref_count++ is 0.
8119 (destroy_driver) Destructs class if --ref_count is 0. Frees the
8120 class output file name.
8122 * output.h: (struct outp_class) Removed copy_driver, inited.
8125 * postscript.c: Completely replaced but not finished.
8127 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
8129 * approx.h: #includes <float.h>.
8131 * arena.h, arena.c: Many functions changed to take an arena **
8132 instead of an arena *, for consistency. All callers changed.
8133 (arena_alloc) Now creates a new arena if passed *A that is NULL.
8134 (arena_destroy) Sets *A to NULL.
8136 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
8137 assertion that `width' be positive.
8139 * command.c: Removed #if's from cmd_table.
8140 (walk_cmdtable_func) [0] New function (debug code).
8141 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
8142 (parse_cmd) Doesn't return failure for unimplemented commands.
8144 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
8145 (SYSCODE) New constant macro.
8147 * descript.q: Checks for positive n_variables before performing
8150 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
8151 avl_find instead of &fp as arg 2.
8153 * frequencies.g, frequencies.q: Continued updating; now compiles &
8154 works again, but not complete.
8156 * main.c: Changes to user messages.
8158 * misc.c: (reverse) [0] New function.
8160 * settings.h: Comment removed. #includes "common.h".
8162 * som.c: (som_set_null) New function.
8163 (som_set_value, som_set_string, som_set_text) More detailing
8165 (som_set_float) Implemented function.
8166 (dump_columnated_table) Bug fix regarding page breaks.
8167 (draw_cell) Bug fix regarding text that spilled out of a cell.
8168 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
8170 (get_cell_size) Support SCON_EMPTY cells.
8171 (get_table_size) When calculating rules' widths and heights, mask
8172 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
8174 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
8176 (struct som_submission_form) New member `header'; all users
8179 * val-labs.c: (get_label) User messages changed.
8181 * var.h: Changed FREQUENCIES structures.
8183 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
8186 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
8188 * approx.h: Definition of EPSILON now depends on system's
8189 DBL_EPSILON. Removed GNU C specific code.
8190 (cmpapx) Renamed approx_compare.
8192 * frequencies.g, frequencies.q: Continued updating; still doesn't
8195 * groff-font.c: (name_to_index) Fix bug that kept it from
8198 * hash.c, hash.h: Completed work.
8200 * var.h: Changes to freq_tab, frequencies_proc.
8202 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
8205 * hash.c, hash.h: New files. Not completed.
8206 * Makefile.am: Added hash.c to source file list.
8207 * font.h: (struct font_desc) New member kern_size_p.
8208 * groff-font.c: Uses hash.h.
8209 (hashpjw) Moved to hash.c.
8210 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
8212 (static var hash) New member size_p.
8213 * var.h: Includes hash.h.
8214 (struct freq_tab) Changed AVL_TREE to hash_tab.
8216 * vars-prs.c: Comment, formatting fixes.
8218 * frequencies.g, frequencies.q: Continued updating. Not yet
8221 * formats.c: Bug fix.
8223 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
8225 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
8226 * descript.g: Comment fixes.
8227 * descript.q: Comment fixes. Moved some declarations into var.h.
8228 Made dsc_info a static table. Updated FIXMEs.
8229 (internal_cmd_descriptives) Beautified.
8231 * frequencies.q: Started updating into working order.
8232 * frequencies.g: New file analogous to descript.g.
8233 * var.h: Comment fixes. Added structures for FREQUENCIES.
8235 * som.c: Removed vestiges of crushing and partial table support.
8237 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
8239 * Many more changes to som.c especially, but these will not be
8240 documented as I have resolved to remove them. This patchlevel is
8241 being released solely so that I can fall back to it if I decide
8242 that removing the changes is not a good idea.
8244 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
8246 * som.c: (global var som) New member `cum_y'.
8247 (build_target) Properly handles titles for partial tables.
8248 (dump_partial_beg, dump_partial_mid, dump_partial_end)
8249 Merged into single new function dump_partial(). Fixed problem
8250 with titles on partial tables.
8251 (dump_table) Calls dump_partial() for all parts of partial tables.
8252 (dump_page) Criteria for drawing title changed.
8254 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
8256 * command.c: (cmd_table) Added LIST, WEIGHT.
8258 * command.c: (cmd_remark) No longer frees `s' since it's not
8259 dynamically allocated.
8261 * data-out.c: (convert_f) Now correctly handles the case where
8262 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
8264 (som_destroy_all_tables) Removed argument. All callers changed.
8265 (som_vline, som_hline) Argument validity checking corrected.
8266 (som_set_value) Implemented half-heartedly.
8267 (replicate_table) Copies tables piece-by-piece when using Checker.
8269 * som.h: New line style SLIN_1THIN, currently equivalent to
8270 SLIN_0. New enum set SOM_SUB_*.
8271 (struct som_submission_form) Removed `seq_no'. Added `type'.
8273 * list.q: Newly working file; uses partial tables.
8275 * som.c: (som_reduce_table) Renamed som_set_table_height().
8276 (som_crush) Removed argument `group'.
8277 (global var som) Removed `nt', `seq_no'. Added `type'.
8278 (som_submit_table) Arguments changed.
8279 (output_table) Removed partial table code.
8280 (build_target) New arg; partial table support added. All callers
8282 (dump_plain_table) Removed partial table code.
8283 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
8284 (dump_table) Supports partial tables.
8285 (dump_page) New argument to allow not drawing top and/or bottom
8286 headers. All callers changed. Supports partial tables.
8288 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
8290 * data-out.c: Changed `#include <approx.h>' to `#include
8292 (convert_F) Comment fix. Now won't print `-.000', etc.
8294 * descript.q: Now Z-scores work, although there appears to
8295 be a bug (which might actually be in data-out.c:convert_F()).
8296 (descriptives_trns_proc, descriptives_trns_free) New functions.
8297 (run_z_pass) Implemented.
8299 * var.h: Comment fixes.
8300 (dsc_z_score, descriptives_trns) New structs.
8301 (descriptives_trns) Added to any_trns as `dsc'.
8303 * error.c, error.h: New error class, IS (Installation Script
8304 error), used in those instances where the error is in the
8305 installation, but there is a script file or installation file that
8306 can be usefully referred to.
8308 * output.c: Change many IE classes to IS classes.
8310 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
8311 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
8312 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
8313 include the corresponding header?
8315 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
8316 Don't bail out if termcap can't be read.
8318 * som.c: (som_destroy_table) Removed.
8319 (som_reduce_table, som_destroy_all_tables) New functions.
8320 (som_crush) New function, not implemented.
8322 * som.h: New table option STAB_CRUSH. Comment fix. New struct
8323 som_submission_form. Function prototypes revised.
8325 Outputting huge tables (1000s of rows) a few rows at a time
8326 is supported, though untested. May even break everything.
8327 Actually, the code doesn't even compile right now.
8328 * som.c: (struct som) New fields htv, nt, seq_no.
8329 (som_submit_table) Multiple arguments changed to a single
8330 pointer to struct submission_form. Only increments subtable_num
8331 if seq_no is zero. Only destroys table if it's not going to
8333 (replicate_table) New function.
8334 (output_table) Comment fix.
8335 (examine_table) Changed inline code to code calling
8336 replicate_table(). Calculates htv. Supports partial tables.
8337 (draw_title) Removed comment.
8338 (build_target) Only allows for title on first part of partial
8340 (dump_plain_table) Only resets table chunk number on first part
8341 of partial tables; FIXME: doesn't work quite right. Supports
8343 (dump_page) Titles only on first part of partial tables.
8345 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
8347 * Thanks to an unreliable IDE hard drive, I have spent the last
8348 day reconstructing my Debian GNU/Linux installation and redoing
8349 the previous day's changes--somehow I managed to save every file
8350 except for output.c and output.h. So the following changes could
8351 really be considered independent of the output.c, output.h changes
8354 * output.h, output.c: Moved the outp_configure_vec global var,
8355 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
8356 outp_configure_vec is now static.
8358 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
8360 * The entire philosophy behind configuration of the output drivers
8361 changed. Now there is a termcap-type configuration where drivers
8362 to be read are determined beforehand, rather than parsing the
8363 entire output init file and storing it in memory & deciding what
8364 to actually use later. Faster & more memory-efficient at the same
8367 * output.c: Comment fix. Removed outp_init_drivers global var.
8368 Removed all references to synonyms. New structure outp_defn. New
8369 global vars outp_macros, outp_configure_vec.
8370 (search_name, delete_name, add_name, check_configure_vec,
8371 expand_name, find_defn_value) New static functions.
8372 (outp_configure_clear, outp_configure_add, outp_configure_macro,
8373 outp_read_devices) New extern functions.
8374 (outp_init) Much functionality moved into outp_read_devices.
8375 (outp_read_devices) Format of output init file changed; name of
8376 file is `devices' rather than `output' to avoid Makefile
8378 (outp_clear) Renamed outp_done.
8379 (outp_list_classes) Bug fix, cleaned up.
8380 (outp_list_drivers) Not implemented anymore.
8381 (outp_configure_driver) Now a static function; simplified; now
8382 interpolates macros; supports new structure.
8383 (outp_enable_driver, match_synonym) Removed; all references
8385 (find_driver) First argument removed.
8387 * output.h: Global var outp_init_drivers removed; new structure
8388 outp_names; new enum set OUTP_S_*; new global var
8389 outp_configure_vec; function prototypes for output.c exports
8392 * main.c: (main) Calls outp_read_devices() after parsing the
8395 * cmdline.c: (parse_command_line) New option -v --verbose;
8396 --version changed to -V. --device option changed syntax to just
8397 take a single device name. Accepts key=value declaration of
8398 output init file macros. Syntax message updated.
8400 * filename.c: (expand_line) New function.
8401 (interp_environ_vars) Renamed interp_vars; no longer uses
8403 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
8404 overridden by real environment vars.
8405 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
8406 * filename.h: interp_environ_vars() renamed interp_vars().
8408 * error.c, error.h: Added extern variable `verbosity', message
8411 * error.c: (vmsg) Support message class MM.
8412 (verbose_msg) New function.
8414 * descript.q: (generate_z_varname) Bug fix in generation of
8416 (dump_z_table) Bug fix in column headers.
8418 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
8419 page from 29 to 15. Don't set a default for ops[OPS_INIT,
8420 OPS_DONE]. Writes the uninit string when the driver is closed.
8421 (ascii_open_page) Write the init string before the first page.
8422 (output_shorts) Form of main loop changed from `while' to `for'.
8423 Bug fix with overstrikes: the character is printed *after* the
8424 backspace. Eliminated a lot of `& 0xff' modifiers.
8425 (advance_to_left_margin) New function.
8426 (return_carriage, output_lines) Handle left margin.
8428 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
8430 * ascii.c: New option `carriage-return-style'.
8432 * ascii.c: (count_fancy_chars) New function.
8433 (delineate, text_metrics) Use new function; bug fixes regarding
8435 (text_draw) Bug fix with rich text.
8436 (output_string, output_shorts) Reordered.
8437 (output_shorts) Now handles boxchars and some overstrike font
8439 (output_char, return_carriage) New functions.
8440 (output_lines) Now handles overstriking and font changes properly;
8441 some code moved to output_shorts.
8443 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
8446 * ascii.c: New member `debug' in ascii_driver_ext.
8447 (ascii_init_driver, delineate) Uses new member.
8449 Now you can set a vertical height on writing text.
8450 * ascii.c: (delineate) Keeps track of vertical position.
8451 (text_draw) No longer considers fully justified text an internal
8454 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
8456 Tables' titles are drawn; they can have variable height.
8457 * som.c: `som' struct has new member, title_height.
8458 (draw_title) New argument. Moved within file. All caller
8460 (build_target) New argument, amount of space needed for first row.
8461 Calculates height of title, takes that into account. All callers
8463 (dump_plain_table, dump_columnated_table) Took calculation of y1,
8465 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
8467 (dump_columnated_table) Organized for readability.
8468 (dump_page) Makes use of som.title_height.
8470 * som.c: Many comment bug fixes.
8472 * descript.q: (try_name, generate_z_name) Bug fix regarding
8473 generation of Z-score variable names.
8474 * var.h: Removed num from descriptives_proc; all referents removed.
8476 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
8478 * ascii.c: (ascii_line_horz, ascii_line_vert,
8479 ascii_line_intersection) Added debugging code.
8481 Added a descriptive line above each table to describe it.
8482 * command.c: (parse_cmd) Calls som_new_series.
8484 * som.c: New static vars table_num, subtable_num. New `som'
8486 (dump_page) New arguments.
8487 (som_submit_table) Handle new variables.
8489 * som.c, som.h: (som_submit_table) New arguments. All callers
8491 (som_new_series) New function.
8492 (build_target) Makes room for extra line.
8493 (draw_title) New function.
8494 (dump_page) Calls draw_title. Bug fix: doesn't always set
8497 Columnation of tables support.
8498 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
8500 * som.c: Deleted references to fr, lr, ri.
8501 (som_columnate) Bux fix: sets group member of table.
8502 (som_add_options) Function removed.
8503 (dump_table) Split into three functions; extensively reworked.
8505 * descript.q: (dump_z_table) Better output table formatting; added
8506 title support to correspond to som.h changes.
8507 (display) Title support.
8509 * output.h: Added OUTP_T_NONE.
8511 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
8513 * descript.q: Improved handling of Z scores; still not perfect.
8515 * output.h, ascii.c: Added hook for getting em width of current
8518 * som.c: Uses new em-width hook. Added debugging code to
8520 (som_columnate) New argument.
8521 (som_add_options) Removed.
8523 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
8525 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
8526 rules as a property of the table instead of as a property of the
8529 * ascii.c: Added `header' to table of options.
8531 * descript.q: Added even shorter statistic names; modified to work
8532 with new som interface.
8534 * misc.c (blp_getdelim): Bug fix.
8536 * version.c: includes 'conf.h'.
8538 ----------------------------------------------------------------------
8541 version-control: never
projects / pspp-builds.git / blob