1 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
5 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
6 DATETIME, TIME system/portable file values.
8 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
10 * data-list.c: (parse_free) Use make_input_format().
12 * data-out.c: (num_to_string) Use make_output_format().
14 * dictionary.c: (dict_create_var) Ditto.
16 * format.c: (global var f8_2) New var.
17 (make_input_format) New function.
18 (make_output_format) New function.
20 * get.c: (cmd_match_files) Use make_output_format().
22 * list.q: (cmd_list) Ditto.
24 * matrix-data.c: Ditto.
26 * sfm-read.c: (parse_format_spec) Check output specifier
29 * tab.c: (tab_float) Use make_output_format().
31 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
35 * format.def: FMT_A should allow 255-character output. FMT_AHEX
36 should allow 510-character input and output.
38 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
39 (convert_E) Handle non-finite values.
41 (format_and_round) New function.
42 (convert_infinite) New function used by try_F() and convert_E().
44 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
46 Regularize string and buffer function names so that they make some
49 * str.c: (mm_reverse) Rename buf_reverse(). Update all
51 (mm_find_reverse) Rename buf_find_reverse(). Update all
53 (mm_case_compare) Rename buf_compare_case(). Update all
55 (st_compare_pad) Rename buf_compare_rpad(). Update all
57 (str_compare_rpad) New function.
58 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
60 (buf_copy_str_lpad) New function.
61 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
63 (st_pad_copy) Rename str_copy_rpad(). Update all references.
64 (st_trim_copy) Rename str_copy_trunc(). Update all references.
65 (st_uppercase) Renamed str_uppercase(). Update all references.
67 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
69 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
72 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
74 * data-in.c: (data_in) Add assertion to check input specifier.
76 * data-out.c: (data_out) Add assertion to check output specifier.
78 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
80 Start to fix PR 13054.
82 * format.c: (check_input_specifier) Improve error message.
83 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
85 (check_output_specifier) Ditto (but different criteria).
86 (convert_fmt_ItoO) Assert valid input and output specifiers.
87 Also, if input specifier has *any* decimal places, make the output
88 specifier 1 place wider.
90 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
92 * sysfile-info.c: Fixed bug [# 13024 ]
94 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
96 "Fix" PR 13021 by disabling FILE TYPE. Eventually, we should
97 actually implement it.
99 * command.c: (FILE_TYPE_okay) Always return 1.
101 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
103 * file-type.c: Add prototypes to get rid of warnings.
105 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
107 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
108 more ISO/IEC 9899:1990 conformance issues.
110 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
112 Fix PR 12948. See also new test in
113 tests/bugs/match-file-scratch.sh.
115 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
116 that deletes scratch variables that someone else might be using,
117 and because we can't reassign our sources' value indexes.
118 Instead, simply don't copy scratch variables into the master
121 * dictionary.c: (dict_compact_values) Delete variables from the
122 dictionary passed in, not from default_dict (!).
124 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
126 Improve hash.c comments, error-checking.
128 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
129 (hsh_create) size == 0 should *not* return NULL! Set
131 (hsh_clear) Set hash_ordered.
132 (locate_matching_entry) Check hash_ordered.
133 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
134 (hsh_data) Set hash_ordered. Add const-ness to return value and
138 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
140 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
142 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
144 * copyleft.c: Updated copyright date.
146 * Makefile.am: Removed erroneous explicit "-lplot"
148 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
150 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
152 * command.c command.def: Added description string for unimplemented commands.
154 * oneway.q: Sorted the hash tables before shipping out the results. Closes
157 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
161 * data-list.c: (parse_fixed) Use lex_end_of_command().
163 (cmd_repeating_data) Set cont_end.num in right situations.
164 (parse_repeating_data) Remove redundant test.
166 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
168 Partial fix for PR 12859.
170 * data-list.c: (cmd_data_list) Add transformation properly in
171 vfm_source == NULL case.
173 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
175 * lexer.c: (lex_error) Improve error messages.
177 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
179 * get.c: (cmd_match_files) Check token type before trying to match
180 tokid. Fixes PR 12923.
182 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
184 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes PR
187 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
189 * expressions/generate.pl: (get_token) Make use of /g
190 backward-compatible with Perl 5.6.1.
192 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
194 * var-display.c: (cmd_variable_alignment) Fix memory leak.
195 (cmd_variable_level) Ditto.
197 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
199 Hash table had buggy deletion function. The fix required changing
200 other functions to do probing in the required order.
202 * hash.c: (locate_matching_entry) Rewrite and change interface.
203 (hsh_rehash) Rewrite to use locate_matching_entry().
206 (hsh_delete) Ditto. Also, fix stupid bugs.
208 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
210 * dictionary.c: (dict_clone) Properly copy vectors.
212 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
214 New implementation of long variable names. Each variable has a
215 "normal" name, which may be up to 64 bytes long and which is used
216 for all normal operations. Variables may have a "short" name,
217 which is limited to 8 bytes and used only for system and portable
218 file input and output.
220 Make tokid case-preserving. Update most uses of tokid to treat it
223 Update many commands to deal with long variable names.
225 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
227 * command.c: (cmd_parse) Ditto.
228 (match_strings) Use toupper() before comparing characters.
229 (conflicting_3char_prefixes) Use mm_case_compare() instead of
231 (cmd_match_words) Ditto.
233 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
236 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
237 Use st_trim_copy() instead of strcpy().
239 * data-in.c: (parse_enum) Use mm_case_compare() instead of
242 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
244 (parse_free) Use st_trim_copy() instead of strcpy().
246 * descript.c: (struct dsc_var) Change z_name[] to fit long var
248 (try_name) Use strcasecmp() instead of strcmp().
249 (generate_z_varname) Use st_trim_copy() instead of strcpy().
250 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
253 * dictionary.c: (struct dictionary) Removed `long_name_tab'
255 (compare_long_names) Removed.
256 (hash_long_name) Removed.
257 (dict_create) Don't initialize `long_name_tab' member.
258 (dict_clone) Copy short names into new dictionary.
259 (dict_clear) Don't clear `long_name_tab' member.
260 (dict_get_varname_block) Removed.
261 (dict_add_longvar_entry) Removed.
263 (dict_destroy) Don't destroy `long_name_tab' member.
264 (dict_create_var_from_short) Removed.
265 (dict_create_var_x) Removed.
266 (dict_create_var) Get rid of longname handling.
268 (dict_clone_var) Get rid of longname parameter and longname
270 (dict_lookup_var) Get rid of longname handling.
271 (dict_reorder_var) New function.
272 (dict_rename_var) Clear short name.
273 (dict_rename_vars) Get rid of longname handling. Clear short
275 (dict_create_vector) Support long vector names.
276 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
277 (quasi_base27) Removed.
278 (make_short_name) Removed.
279 (compare_strings) New function.
280 (hash_string) New function.
281 (dict_assign_short_names) New function.
283 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
285 (get_handle_for_filename) Support long handle names.
287 * file-type.c: (struct col_spec) Make `name' fit long var names.
288 (cmd_file_type) Use strcasecmp() instead of strcmp().
290 * flip.c: (make_new_var) Rewrite.
291 (flip_sink_write) Use st_trim_copy() instead of strncpy().
293 * format.c: (parse_format_specifier_name) Use mm_case_compare()
296 * get.c: (cmd_save_internal) Rephrase.
297 (rename_variables) Drop test for identical variable name.
298 (struct mtf_proc) Change `first', `last' to fit long var name.
300 * hash.c: (hsh_hash_case_string) New function for case-insensitive
303 * lexer.c: (restore_token) Use st_trim_copy() instead of
305 (lex_get) Don't uppercase string when copying into tokid.
306 (lex_put_back_id) Use st_trim_copy() instead of
309 * list.q: (determine_layout) Consider length of variable names in
310 choosing vertical layout.
312 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
314 (string_to_content_type) Ditto.
316 * modify-vars.c: (compare_variables_given_ordering) Ditto.
317 (struct var_renaming) Change `new_name' to fit long var name.
318 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
321 * pfm-read.c: (read_variables) Disallow system variables in system
323 (write_variables) Call dict_assign_short_names() and use
324 short_name[] members.
326 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
329 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
330 map. Reorder variables into same order as long variable map.
331 (read_variables) Set short name.
333 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
334 (write_variable) Use st_bare_pad_copy().
335 (write_longvar_table) Rewrite.
337 * str.c: (mm_case_compare) New function.
339 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
342 * t-test.q: (tts_custom_groups) Remove redundant test.
343 (tts_custom_pairs) Ditto.
345 * var.h: (struct variable) Change `name' to fit long var names.
346 Remove `longname'. Add `short_name' member. Reorder some
348 (struct name_table_entry) Removed.
349 (struct vector) Change `name' to fit long vector names.
351 * vars-atr.c: (var_is_valid_name) Allow long var names.
352 (compare_var_names) Use strcasecmp() instead of strcmp().
353 (compare_var_ptr_names) Ditto.
354 (hash_var_name) Use hsh_hash_case_string().
355 (hash_var_ptr_name) Ditto.
356 (var_set_short_name) New function.
357 (var_clear_short_name) New function.
358 (var_set_short_name_suffix) New function.
360 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
361 Use strcasecmp() instead of strcmp().
362 (struct array_var_set) Removed `longname_tab'.
363 (array_var_set_lookup_var_idx) Drop longname_tab support.
364 (array_var_set_destroy) Don't destroy `longname_tab'.
365 (var_set_create_from_array) Don't create `longname_tab'.
367 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
370 * expressions/parse.c: (word_matches) Use mm_case_compare()
372 (compare_strings) New function.
373 (lookup_function) Use compare_strings() instead of strcmp().
375 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
377 * algorithm.c: (move_element) New function.
379 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
381 * aggregate.c: (parse_aggregate_functions) Always initialize
384 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
386 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
388 * dictionary.c: (dict_clone) Ditto.
389 (dict_clone_var_assert) New function.
391 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
393 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
395 * error.c: Added a string for the compiler version to the
396 request_bug_report_and_abort function.
398 * groff_font.c, font.c: Removed manpage(1) style references from
399 comments, because RMS frowns upon them.
401 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
403 * expressions/parse.c: Improve previous fix for PR 12858 (LAG).
405 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
407 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
410 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
412 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
413 which should be LONG_NAME_LEN
415 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
417 * command.def echo.c: Added the ECHO command.
419 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
421 Finish fixing MATCH FILES (PR 11677).
423 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
424 keep_variables(), rename_variables().
425 (drop_variables) New function.
426 (keep_variables) New function.
427 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
428 (cmd_match_files) Deal with in_var. Use drop_variables(),
429 keep_variables(). When IN is specified, require BY. Set master
430 variables after master dictionary is complete. Add IN variables
431 after master dictionary is complete.
432 (mtf_free_file) Free `in_name'.
433 (mtf_delete_file_in_place) Set in_var value to 0.
434 (mtf_read_nonactive_records) Rephrase.
435 (mtf_processing) Support IN. Rephrase. Fix bugs.
436 (mtf_merge_dictionary) Don't set master variables; we do that
438 (get_master) Don't insist that there's a master variable.
440 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
442 Kluge to make some variable renaming sort of work.
445 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
447 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
449 Add functions for comparing sets of variables between cases.
452 * case.c: (case_compare) New function.
453 (case_compare_2dict) New function.
455 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
457 (cmd_aggregate) Nullify break_case. Don't call
458 initialize_aggregate_info().
459 (agr_destroy) Destroy break_case.
460 (aggregate_single_case) Rewrite. Use case_compare().
461 (dump_aggregate_info) Copy from break_case into output.
462 (initialize_aggregate_info) Copy break_case from input.
464 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
466 * vfm.c: (equal_splits) Use case_compare().
468 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
470 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
472 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
474 Start work on fixing MATCH FILES.
476 * get.c: (enum operation) Remove OP_MATCH.
477 (trim_dictionary) Change return value to bool. Don't support
479 (struct mtf_file) Remove `first', `last' members.
480 (struct mtf_proc) Add `first', `last' members. Change mtf_case
481 from `struct ccase *' to `struct ccase'. Remove `by' member.
482 (cmd_match_files) Essentially rewrite.
483 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
484 (mtf_read_nonactive_records) mtf_ parameter is not unused.
485 (mtf_processing) Ditto. Also rephrase some code.
486 (mtf_merge_dictionary) Rewrite for easy comprehension.
488 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
490 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
493 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
495 Thu Apr 14 2005 John Darrington
497 * var-display.c: New file.
499 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
500 display_width, measure and alignment parameters to variables.
502 * aggregate.c command.def compute.c count.c data-list.c descript.c
503 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
504 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
505 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
506 vars-prs.c vector.c :
507 - Replaced literal constants representing maximum variable name
508 length with macro definitions.
509 - Added support for long variable names.
510 - Changed lexer such that it no longer makes tokens upper
511 case, but relies upon case insensitive behaviour of commands.
513 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
515 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
516 fails, don't dereference the resulting null pointer (PR 12427).
517 Also, fix double free error.
519 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
521 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
522 (accumulate_aggregate_info) Set int1 to 1 for SUM.
523 (dump_aggregate_info) Only make SUM non-missing if there was at
526 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
528 * aggregate.c: (dump_aggregate_info) Properly test whether the
529 destination variable is numeric, when making the result
530 system-missing for columnwise missing values.
532 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
534 * misc.h: Remove GCC specializations.
536 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
538 Make sort stable (PR 12313).
540 * sort.c: Don't need to include some headers anymore.
541 (static var min_buffers) New variable.
542 (static var max_buffers) New variable.
543 (static var allow_internal_sort) New variable.
544 (cmd_sort_cases) Add test mode.
545 (sort_execute) Rephrase.
546 (do_internal_sort) Don't try internal sorting if
547 allow_internal_sort is set.
548 (struct external_sort) Renamed `initial_runs' to `runs' and
549 updated all references.
550 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
551 (macro MIN_BUFFER_SIZE_BYTES) Removed.
552 (macro MIN_BUFFER_SIZE_RECS) Removed.
553 (compare_initial_runs) Removed.
554 (struct record_run) Add member `idx'.
555 (write_initial_runs) Pass increasing values to process_case() as
557 (process_case) Add `idx' parameter and use it to initialize new
559 (allocate_cases) Limit allocated buffers to max_buffers.
560 (compare_record_run) Use new `idx' member for last resort
561 comparison, for stability.
562 (end_run) Call casefile_sleep() on irs->casefile, to prevent
563 running out of file descriptors.
564 (struct merge_state) Removed.
565 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
566 unless we have fewer runs left. Always merge consecutive runs,
567 for stability. Return the final run.
569 (choose_merge) New function.
570 (merge_once) Rewritten.
572 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
574 * cmdline.c: (static var testing_mode) Move into
575 parse_command_line().
577 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
579 * algorithm.c: (remove_range) New function.
580 (remove_element) New function.
582 * dictionary.c: (dict_delete_var) Use remove_element().
584 * flip.c: (cmd_flip) Ditto.
586 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
588 * file-handle.q: (struct file_handle) `open_mode' should not be
591 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
593 First phase of making SORT CASES stable (PR 12313).
595 * sort.c: (struct indexed_case) New structure.
596 (do_internal_sort) Rewrite to make internal sorting stable.
597 (compare_case_dblptrs) Removed.
598 (compare_indexed_cases) New function.
600 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
604 * casefile.c: (casereader_read_xfer_assert) New function.
606 * dictionary.c: (dict_compact_case) New function.
608 * flip.c: (struct flip_pgm) New member idx_to_fv.
609 (cmd_flip) Initialize idx_to_fv member.
610 (destroy_flip_pgm) Free idx_to_fv member.
611 (flip_sink_write) Use struct flip_pgm member instead of case_sink
613 (flip_sink_write) Ditto.
615 * vfm.c: (write_case) Use dict_compact_case() instead of
617 (compact_case) Removed.
618 (storage_source_create) Removed `dict' parameter. All references
621 * vfm.h: (struct case_source) Removed `value_cnt' member. All
623 (struct case_sink) Removed `dict', `idx_to_fv' members. All
626 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
628 More AGGREGATE fixes.
630 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
631 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
633 (initialize_aggregate_info) Fix initialization for MIN, MAX for
636 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
638 Start work on testing and debugging AGGREGATE.
640 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
641 of a bit-map. Require proper subcommand ordering. Make OUTFILE
642 subcommand mandatory.
643 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
644 functions' arguments are in the correct order and swap them if
646 (accumulate_aggregate_info) Make SUM include weights. Add various
648 (dump_aggregate_info) Add various string functions.
649 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
651 * sort.c: (sort_parse_criteria) Add parameter for returning
652 whether any directions were specified. All callers updated.
654 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
656 * t-test.q: Fixed erroneous logic in compare_group_binary.
658 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
660 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
663 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
665 * vfm.c: (procedure_with_splits) Fix PR 11492: end_func() must be
666 called *before* close_active_file().
668 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
670 * file-handle.q: (struct file_handle) Change open_mode from
671 character pointer to 3-char array, for safety. Updated all
674 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
676 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
679 * pfm-read.c: (read_header) Improve error message for many cases
680 in which the input is not actually a portable file.
682 * file-handle.q: (fh_open) When we give an error message, actually
685 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
687 * format.c: (check_common_specifier) New function for checks
688 common to check_input_specifier() and check_output_specifier().
689 (check_input_specifier) Use check_common_specifier().
690 (check_output_specifier) Use check_common_specifier().
691 (check_string_specifier) Removed.
692 (check_specifier_type) New function.
693 (check_specifier_width) New function.
694 (get_format_var_width) Fix bug.
696 * formats.c: (internal_cmd_formats) Only accept numeric variables.
698 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
699 update all references. Make case-insensitive.
701 * pfm-read.c: Essentially rewrite the whole file. Now much
704 * print.c: (check_string_width) New function.
705 (fixed_parse_compatible) Use check_string_width(),
706 check_specifier_type().
707 (dump_fmt_list) Ditto.
709 * str.c: (st_trim_copy) New function.
710 (st_uppercase) New function.
712 * vars-atr.c: (var_is_valid_name) New function.
714 * expressions/parse.c: (type_coercion_core) Use
715 check_specifier_type().
717 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
719 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
721 * expressions/parse.c: (no_match) Ditto.
723 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
725 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
727 * expressions/helpers.c: (struct func_params) Removed.
728 (generalized_idf) Removed.
731 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
733 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
734 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
735 Implement SIG.F, which I had overlooked previously.
737 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
739 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
740 available only in testing mode.
742 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
744 * data-in.c: Use `bool' throughout, where relevant.
746 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
748 DATA LIST with free-field formats should not have implied decimal
749 places (PR 12035). Also clean up data-in.c a bit.
751 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
753 * data-in.c: (apply_implied_decimals) New function.
754 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
755 set. Also, get rid of gotos.
756 (parse_Z) Use apply_implied_decimals() if the field doesn't
757 contain a decimal point.
758 (parse_N) Use apply_implied_decimals().
764 (parse_enum) New function.
765 (macro CHAR_IS_ROMAN) Removed.
766 (macro ROMAN_VALUE) Removed.
767 (parse_month) Use parse_enum().
768 (parse_weekday) Use parse_enum().
769 (parse_DATETIME) Use long for weekday.
771 * data-list.c: (read_from_data_list_fixed) Use
774 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
776 When the lexer sees something like `-5' in the input, it has to
777 decide whether it's a negative numeric constant token or a '-'
778 token followed by a positive numeric constant token. It always
779 decides on the former, and then the parser can call
780 lex_negative_to_dash() if it wants the latter. However, this
781 doesn't work for the case of `-0', because negative zero is
782 (portably) indistinguishable from positive zero. So now we divide
783 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
784 distinction clear. This requires a little bit of extra effort,
785 because there were several references to T_NUM in the code base.
787 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
788 positive and negative numeric constants.
789 (lex_double_p) Renamed lex_is_number(). Changed return type to
790 bool. Updated all relevant references to T_NUM to instead use
792 (lex_double) Renamed lex_number(). All references updated.
793 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
794 bool. All references updated.
795 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
796 (lex_negative_to_dash) Ditto.
799 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
801 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
803 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
805 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
807 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
808 values as system-missing.
810 * expressions/parse.c: (parse_vector_element) Fix order of
811 arguments in call to expr_allocate_binary().
813 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
815 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
818 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
819 failure, as indicated by function comment.
820 (parse_binary_operators) Always return NULL on type_coercion()
821 failure. Should have been doing this anyway, but bug in
822 type_coercion_core() filtered through.
823 (parse_add) Fix typo in user message.
824 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
826 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
828 * expressions/operations.def: Add VALUE function.
830 * expressions/parse.c: (parse_function) Need an unary composite
831 node for variables in A TO B, not a variable node. Use
832 allocate_unary_variable().
833 (parse_primary) Use allocate_unary_variable().
834 (allocate_unary_variable) New function.
836 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
838 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
839 but fixed the real problem that was preventing the build from a
840 separate directory. I liked it my way better ;-)
842 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
844 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
845 John Darrington <john@darrington.wattle.id.au> for reporting this
848 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
850 * expressions/Makefile.am expressions/evaluate.h.pl
851 expressions/evaluate.inc.pl expressions/operations.h.pl
852 expressions/optimize.inc.pl expressions/parse.inc.p:
854 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
857 Fixed everything so that it can be built from an arbitrary
860 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
862 * Makefile.am : Fixed up CLEANFILES target.
864 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
866 * str.h: Changed `struct len_string' to `struct fixed_string', a
867 more accurate name. Updated all references.
869 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
871 Redo calendar support. Should now be bug-for-bug compatible.
873 * calendar.c: New file.
875 * calendar.h: New file.
877 * data-in.c: Use new calendar functions.
878 (parse_sign) Change sense of return value.
879 (calendar_error) New function.
880 (ymd_to_ofs) New function.
881 (ymd_to_date) New function.
882 (parse_DATE) Use new function.
892 (parse_DATETIME) Ditto.
894 * data-out.c: (convert_date) Use new calendar functions.
896 * error.c: (err_vmsg) Changed interface to be more sensible.
898 (dump_message) Don't double new-lines (why did we do this
901 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
903 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
904 (macro FLT64_MAX) Moved here from pref.h.orig.
906 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
908 * set.q: Support SET EPOCH.
909 (static var set_epoch) New var.
910 (aux_stc_custom_epoch) New function.
911 (stc_custom_epoch) New function.
912 (get_epoch) New function.
913 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
915 * format.c: Make it possible just to check whether a specifier is
916 valid without emitting an error message.
917 (parse_format_specifier_name) Change interface, update all
919 (check_input_specifier) Ditto.
920 (check_output_specifier) Ditto.
921 (parse_format_specifier) Ditto.
923 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
925 * command.def: Add DEBUG POOL.
927 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
929 (pool_clear) Properly account for size of pool gizmo.
930 (pool_realloc) Ditto.
931 (pool_clone) New function.
933 * pool.h: Mark our allocation functions MALLOC_LIKE.
935 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
937 * Makefile.am: Move many definitions into new top-level
938 Make.build. Add expressions to SUBDIRS. Add calendar.c,
939 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
942 * case.c: (case_resize) New function.
943 (case_swap) New function.
945 * casefile.c: Include mkfile.h.
947 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
949 * sfm-read.c: Fixed a buglet which caused a crash when trying
950 to read a non-existent file.
952 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
956 * aggregate.c: (parse_aggregate_functions) Code cleanup.
957 Important part: get rid of spurious copying of function->format to
958 destvar->print and destvar->write.
960 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
962 Fix PR 11916, which was confusing a variable's `index' member
963 with the variable's position in a var_set. Although these are
964 usually the same, they are not for array `var_set's.
966 Took advantage of this bug as an opportunity to clean up and
967 rewrite parse_var_set_vars().
969 * vars-prs.c: (parse_vs_variable_idx) New function.
970 (parse_vs_variable) Reimplement in terms of
971 parse_vs_variable_idx().
972 (parse_var_idx_class) New function.
973 (add_variable) New function.
974 (add_variables) New function.
975 (parse_var_set_vars) Rewritten.
976 (struct var_set) Change `lookup_var' member that returns a
977 variable into `lookup_var_idx' member that returns an int.
978 Updated the var set implementations in obvious corresponding ways.
979 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
981 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
983 Use our global variable compare & hash functions and give them
984 better names. Add similar functions for dealing with double
985 pointers to variables.
987 * vars-atr.c: (compare_variables) Renamed compare_var_names().
988 (hash_variable) Renamed hash_var_name().
989 (compare_var_ptr_names) New function.
990 (hash_var_ptr_name) New function.
992 * t-test.q: (cmd_t_test) Use global compare_var_names(),
994 (compare_var_name) Removed.
995 (hash_var_name) Removed.
997 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1001 * dictionary.c: (compare_variable_dblptrs) Rename
1002 compare_var_ptrs() and fix it to properly dereference the double
1005 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1007 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1008 declare subcommands as mandatory. Closed bug #11843
1010 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1012 * getline.c command.[ch] command.def: Added (very rudimentary)
1013 support for line completion when in interactive mode. Partially
1014 addresses bug #11693
1016 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1018 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1019 problems revealed by valgrind.
1022 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1024 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1025 whether or not PAGER is set.
1027 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1029 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1030 "invalid free" errors. Hopefully fixes bug #11722
1032 * compute.c expr-prs.c: Check that lvalues are populated before
1033 attempting to destroy them. Closes bug #11676
1035 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1037 * aggregate.c: Initialised the complete agr_proc structure.
1041 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1043 * print.c: (print_trns_free) Close the dfm writer if there is one,
1044 fixing a memory leak.
1046 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1048 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1052 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1054 * linked-list.[ch] Added
1056 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1057 set.q: Yet more memory leaks
1059 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1061 * t-test.q examine.q : More memory leaks fixed.
1063 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1065 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1068 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1070 * ascii.c cartesian.c casefile.c chart.h devind.c
1071 examine.q frequencies.q
1072 html.c output.h piechart.c plot-chart.c plot-hist.c
1074 Integrated the chart rendering into the output stream
1075 (currently only works for html).
1077 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1078 dummy-chart.c for compiling without charts.
1080 * mkfile.[ch] Created.
1082 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1083 Added type element so we can tell if it's a chart or a table.
1085 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1086 API of charts to be more like that of tables.
1088 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1090 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1091 main.c. Removed the handler for SIGQUIT.
1093 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1095 * casefile.c: Added a signal handler to delete temp files on
1098 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1100 * command.def Added a lot more unimplemented commands.
1102 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1104 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1106 * sort.c: (compare_initial_runs) Needed additional level of
1108 (merge_once) Fix plenty of stupid mistakes.
1110 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1112 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1113 calling casefile_to_disk() or we will lose the last block in the
1114 file if the casefile started out as disk-based.
1115 (casefile_get_reader) Initialize reader->destructive to 0.
1116 (cmd_debug_casefile) Add new test pattern.
1117 (test_casefile) Define new test pattern to make sure
1118 casefile_sleep() works properly.
1120 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1122 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1123 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1124 attempt to seperate the creation and processing of charts from their
1127 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1130 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1132 * main.c Added a signal handler for SIGFPE
1134 * sort.c Somewhat more robust fix to the previous entry.
1136 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1138 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1139 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1140 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1143 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1145 * case.h Fixed bug # 11307
1147 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1149 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1152 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1154 * pfm-read.c: (read_variables) Remove direct manipulation of
1155 v->aux, which is no longer needed. Fixes PR 11483.
1157 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1159 * data-list.c Fixed a bug in parsing delimiters.
1161 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1164 * percentiles.c Properly handled calculation of Tukey hinges where
1165 the number of data is small.
1167 * oneway.q Used the generic value_to_string function for independent
1168 variable instead of trying to do it ourselves.
1170 * box-whisker.c Fixed a buglet which caused a crash if the number of
1174 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1176 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1178 * percentiles.c Fixed some bugs when calculating percentiles when
1179 there's a small number of cases.
1181 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1183 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1185 * examine.q factor_stats.[ch] Added calculation of percentiles
1187 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1189 * t-test.q Fixed bug #11227 Made t-test work when the independent
1192 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1194 * factor_stats.c Fixed calculation of trimmed mean under various
1197 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1199 * histogram.c chart.[ch] factor_stats.c frequencies.q
1201 Added code to calculate sensible histogram ranges and limits.
1203 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1205 * chart.h Updated to reflect many API changes.
1207 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1208 cartesian.c and into chart.c
1210 * factorstats.[ch] Added the histogram calculations
1212 * casefile.c Removed an unused variable.
1214 * frequencies.q examine.q histogram.c Reworked the API for
1217 * piechart.c Revised the API for piecharts.
1219 * var.h Moved the definitions of freq_tab and freq out of var.h
1220 and into frequencies.q where they belong.
1222 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1224 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1225 using AC_TYPE_OFF_T.
1227 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1229 * flip.c: (flip_file) If fseeko() is not available, use long int
1230 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1231 reporting the problem.
1233 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1235 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1236 conflict with stdio.
1238 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1240 * var-labs.c (var_to_string) Now returns null if the variable is null
1242 * value-labels.c (value_to_string) Made it return null if either the
1243 value or the variable is null.
1245 * hash.c (hsh_clear) Fixed a buglet.
1247 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1248 with the wrong model.
1250 * casefile.[ch] Added a function to return the casereader.case_idx
1253 * examine.q Implemented the extreme values results.
1255 John Darrington <john@darrington.wattle.id.au>
1257 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1258 output.[ch] getline.c
1260 Plugged some memory leaks
1262 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1264 Adopt GSL random number generators, paving the way for providing
1265 the complete suite of random number generators on expressions.
1267 * Makefile.am: Remove random.c, random.h.
1269 * random.c: Removed.
1271 * random.h: Removed.
1273 * algorithm.c: (algo_default_random) Use GSL functions.
1275 * casefile.c: (test_casefile) Use GSL RNG functions.
1277 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1280 * sample.c: (cmd_sample) Use GSL RNG functions.
1281 (sample_trns_proc) Ditto.
1283 * set.q: (static var set_seed) Removed.
1284 (static var seed_flag) Removed.
1285 (static var rng) New variable.
1286 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1287 (stc_custom_seed) Use new seed functions.
1288 (seed_is_set) Removed.
1289 (get_rng) New function that composes the entire external
1291 (set_rng) New function.
1292 (random_seed) New function.
1294 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1296 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1297 John Darrington <john@darrington.wattle.id.au> for reporting this
1300 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1302 * permissions.c command.def Added the PERMISSIONS command
1304 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1306 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1307 output file because that will precede #include <config.h>, which
1309 (main) Add needed headers to /* (header) */ code.
1311 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1313 Instead of making system or portable file readers responsible for
1314 dropping and reordering variables, make them read full cases and
1315 let the caller take care of any changes.
1317 * get.c: New "case map" structure to handle this. Use for GET,
1318 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1320 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1321 changed appropriately.
1323 * sfm-read.c: (sfm_read_case) Ditto.
1325 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1327 Decided that case_serialize() and case_unserialize() were too
1328 abstract. Also we need a couple more functions to avoid excessive
1329 copying for data in/out fast paths.
1331 * case.c: (case_serial_size) Removed.
1332 (case_serialize) Rename case_to_values() and make its argument
1333 explicitly an array of union values.
1334 (case_unserialize) Rename case_from_values() and make its argument
1335 explicitly an array of union values.
1336 (case_data_all) New function.
1337 (case_data_all_rw) New function.
1339 * casefile.c: (struct casefile) Change buffer from array of
1340 unsigned char to array of union value for better accuracy.
1341 Redefine buffer_used and buffer_size in terms of values, not
1342 bytes. Remove case_size because it is now redundant with
1343 value_cnt. Fix up all references to these members.
1345 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1347 * barchart.c: (struct subcat) Make `label' member const to silence
1348 GCC warning with -Wwrite-strings.
1350 * cartesian.c: (struct dataset) Ditto.
1352 * case.c: Don't re-define NDEBUG if already defined.
1353 Add lots of comments.
1355 * str.c: Fix includes.
1357 * crosstabs.q: Fix includes.
1359 * examine.q: Fix includes. Fix GCC warning about unused
1362 * frequencies.q: (stat macro) Removed and replaced where used by
1365 * list.q: Fix includes.
1367 * oneway.q: Fix includes.
1369 * piechart.c: Fix includes. Only define M_PI if not already
1372 * sfm-read.c: (bswap) New function.
1373 (bswap_int32) Write in terms of bswap.
1374 (bswap_flt64) Ditto.
1376 * str.c: (ds_data) Add external definition here, needed because
1377 str.h has only an `extern inline' version.
1379 * value-labels.c: Fix includes.
1381 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1383 Instead of providing a system or portable file writer with a raw
1384 case in the format needed for output, provide it with a regular
1385 case. The writer takes care of any needed translation.
1387 * aggregate.c: Adopt new scheme for AGGREGATE.
1388 (struct agr_proc) sfm_agr_case member removed.
1389 (write_case_to_sfm) Removed because the new interface is easier to
1392 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1394 * pfm-write.c: Implement new scheme.
1396 * sfm-write.c: Ditto.
1398 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1400 Instead of treating `struct file_handle' as a class to subclass
1401 into data files, system files, and portable files, instead use it
1402 as a helper that coordinates access. Now it is opaque, too.
1404 This means that most references to a struct file_handle are now
1405 changed into references to one of struct dfm_reader, struct
1406 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1407 pfm_reader, or struct pfm_writer, according to what's being read
1410 Most related changes are only worth summarizing briefly.
1412 * dictionary.c: (dict_clear) Destroy aux data in deleted
1414 (dict_clear_aux) New function.
1415 (dict_create_var) Initialize aux, aux_dtor.
1416 (dict_delete_var) Destroy aux data in deleted variable.
1418 * file-handle.h: (struct fh_ext_class) Removed.
1419 (struct file_handle) Removed.
1420 (fh_init_files) Removed.
1422 * file-handle.q: Changed references to a handle's `private' member
1423 to direct references.
1424 (struct private_file_handle) Renamed file_handle.
1425 Add next, open_cnt, type, open_mode, aux members.
1426 (struct file_handle_list) Removed.
1427 (extern var inline_file) Removed.
1428 (static var file_handles) Changed from file_handle_list * to
1430 (create_file_handle) Initialize new members.
1431 (fh_close_handle) Removed.
1432 (mode_name) New function.
1433 (fh_open) New function.
1434 (fh_close) New function.
1435 (fh_parse_file_handle) Renamed fh_parse().
1437 * glob.c: (init_glob) Remove fh_init_files() call.
1439 * aggregate.c: use sfm_writer.
1440 (create_sysfile) Removed because the new interface is simpler.
1442 * apply-dict.c: Use sfm_reader.
1444 * data-list.c: Use dfm_reader.
1446 * file-type.c: Use dfm_reader.
1448 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1450 * inpt-pgm.c: Use dfm_reader.
1452 * print.c: Use dfm_writer.
1454 * sysfile-info: Use sfm_reader.
1456 * dfm-read.c: Adopt new file handle infrastructure.
1458 * dfm-write.c: Ditto.
1460 * pfm-read.c: Ditto.
1462 * pfm-write.c: Ditto.
1464 * sfm-read.c: Ditto.
1466 * sfm-write.c: Ditto.
1468 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1470 Break dictionary functions into separate header file.
1472 * dictionary.h: New file.
1474 * var.h: Moved dict_*() functions to dictionary.h.
1476 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1478 Get rid of procedure-specific union in struct variable, using
1479 instead a void * pointer and a destructor function.
1481 Most related changes are only worth brief summaries.
1483 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1484 old p.crs member in struct variable.
1486 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1487 of old p.frq member in struct variable.
1489 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1490 it's no longer possible to grab this from var->p.frq.
1492 * piechart.c: (draw_piechart) Ditto.
1494 * group.c: (group_proc_get) New function.
1496 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1503 * main.c: (execute_command) Clear aux data in default_dict after
1504 each command. (It's debatable whether this should be done.)
1506 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1507 member in struct variable.
1509 * means.q: Get rid of integer mode, which is not included in
1510 recent SPSS and was the only code that wanted per-variable private
1513 * var.h: (struct crosstab_proc) Removed.
1514 (struct frequencies_proc) Removed.
1515 (struct list_proc) Removed.
1516 (struct get_proc) Removed.
1517 (struct means_proc) Removed.
1518 (struct matrix_data_proc) Removed.
1519 (struct match_files_proc) Removed.
1520 (lots of enums) Removed.
1521 (struct variable) Removed members `p', `get'. Add member
1524 * vars-atr.c: (var_attach_aux) New function.
1525 (var_detach_aux) New function.
1526 (var_clear_aux) New function.
1527 (var_dtor_free) New function.
1528 (discard_variables) Use NULL instead of inline_file.
1530 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1532 * value-labs.c Fixed the implmentation of value_to_string, so
1533 that it properly handles alpha values.
1535 * oneway.q Changed instances where labels were being probed manually,
1536 to use the canonical {var,value}_to_string functions
1538 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1540 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1541 plots. Changed the API of the cartesian plot to be a much lower level
1544 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1546 * examine.q Added some of the parametric calculations
1548 * factor_stats.[ch] Created
1550 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1552 * examine.q Changed the definition of factors to be a composite, and
1553 dealt with the consequences.
1555 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1557 * examine.q Fixed problem where examine wasn't dealing properly with
1560 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1562 * oneway.q Fixed problem where oneway wasn't dealing properly with
1565 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1567 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1568 command which had settings didn't get the appropriate code
1571 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1572 to convert variables/values to strings.
1574 * examine.q Added framework for the EXAMINE command.
1576 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1578 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1579 subcommand types. Changed frequencies.q to use it rather then the
1580 custom parser. Dealt with the consequences. Added a test for NTILES
1581 subcommand of frequencies.
1583 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1585 * oneway.q Fixed up the behaviour when given missing values
1587 * levene.c oneway.q Fixed a buglet with the levene statistic and
1588 incorporated the levene test into the oneway command.
1590 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1591 global scope, since they're only relevant to T-TEST
1593 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1595 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1597 Made the t-test more consistent
1598 with the way it handles groups. That is, it now uses a hash instead
1599 of an array of 2. Also, made the levene.c file independent of the
1600 implementation of the t-test. So now levene should be fine for both
1603 * Added an oneway.q file for one way anova
1605 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1607 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1610 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1614 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1615 (data_list_trns_free) Free dls->delims.
1617 * t-test.q: (tts_custom_pairs) Free vars.
1618 (ssbox_one_sample_init) Fix tab_vline() argument.
1619 (ssbox_independent_samples_init) Ditto.
1620 (trbox_paired_init) Ditto.
1621 (trbox_one_sample_init) Ditto.
1623 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1625 Generalize casefiles to the extent that we can use them for
1626 sorting and other kinds of data transformations. Change cases to
1627 be copy-on-write to improve memory efficiency in common cases.
1628 Every access to a member of a `struct ccase' was changed to be a
1629 call to a case_*() function, especially case_data(), case_num(),
1630 case_str(), or case_data_rw(). Many instances of a local variable
1631 named "case_num" were changed to "case_idx" as a consequence.
1632 Many `struct ccase *' were changed to actual `struct ccase'
1633 because of copying semantics of cases. In several places there
1634 was a choice between updating debug code to work with the new ADTs
1635 or just deleting it because it was useless; I chose to delete it.
1637 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1643 * aggregate.c: (struct agr_proc) Change type of `sort' to
1644 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1645 Rename `vars' to `agr_vars', all references updated. Change
1646 `agr_case' to type `struct ccase'.
1647 (cmd_aggregate) Deal with new members. Use case_create(),
1648 sort_active_file_in_place(), sort_active_file_to_casefile().
1649 (agr_destroy) Deal with new members.
1650 (aggregate_single_case) Ditto.
1651 (dump_aggregate_info) Ditto.
1652 (initialize_aggregate_info) Ditto.
1653 (agr_to_active_file) Ditto.
1654 (presorted_agr_to_sysfile) Ditto.
1655 (sort_agr_to_sysfile) Removed.
1657 * alloc.c: (out_of_memory) Make non-static.
1659 * alloc.h: Prototype out_of_memory().
1661 * casefile.c: Switched from a linked list in-memory representation
1662 to a two-level array-style representation. The linked list was
1663 appropriate when we could stick a header onto cases, but that's no
1664 longer the case. Also, the two-level array will allow for random
1665 in-memory access in case that's ever wanted. Also added the
1666 concept of a `destructive casereader', one that destroys cases in
1667 the underlying casefile as they are read out.
1668 (macro CASES_PER_BLOCK) New macro.
1669 (struct casefile) New members `value_cnt', `case_list_size',
1670 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1672 (struct casereader) Removed `cur'. Added `destructive', `c'.
1673 (global var casefiles) Made static.
1674 (static var case_bytes) New var.
1675 (casefile_create) Takes a value count, not a case size in bytes,
1676 to conform to the case interface. All callers updated. Deal with
1677 new and removed members.
1678 (casefile_destroy) Deal with new and removed members.
1679 (casefile_sleep) New function.
1680 (casefile_get_case_size) Removed.
1681 (casefile_get_value_cnt) New function.
1682 (casefile_append) Rewritten to deal with new and removed members.
1683 (casefile_append_xfer) New function.
1684 (write_case_to_disk) Use case_serialize().
1685 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1686 Couldn't figure out why.
1687 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1688 deal with new and removed members.
1690 (merge_sort) Removed.
1691 (casefile_sort) Removed.
1692 (casefile_get_reader) Deal with new and removed members.
1693 (casefile_get_destructive_reader) New function.
1694 (reader_open_file) Make code more readable. Create case for
1696 (casereader_get_casefile) New function.
1697 (casereader_read) Deal with new and removed members. Now returns
1698 a copy of the case, so that the caller is responsible for
1699 destroying the returned case.
1700 (casereader_read_xfer) New function.
1701 (casereader_destroy) Destroy reader's case.
1702 (test_casefile) Second arg is now a value count, all callers
1703 updated. Now tests destructive readers too.
1704 (get_random_case) Deal with new case ADT.
1705 (write_random_case) Ditto.
1706 (read_and_verify_random_case) Ditto.
1708 * crosstabs.q: Remove debug code.
1710 * descript.q: (calc_descriptives) Deal with new case, casefile
1713 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1715 * do-if.c: Remove unneeded header inclusion.
1717 * expr-prs.c: Remove debug code.
1719 * exprP.h: Remove debug code.
1721 * flip.c: (flip_file) Use fseeko() if available.
1723 * formats.c: Remove debug code.
1725 * get.c: Remove debug code.
1726 (struct mtf_file) Change `input' from `union value *' to `struct
1727 ccase', all references updated.
1729 * levene.c: (levene) Deal with new case, casefile ADTs.
1731 * list.q: Remove debug code.
1733 * loop.c: Remove debug code.
1735 * matrix-data.c: Remove debug code.
1737 * means.q: Remove debug code.
1739 * mis-val.c: Remove debug code.
1741 * pfm-read.c: Remove debug code.
1742 (pfm_read_code) Change second arg from `union value *' to `struct
1743 ccase *', all references updated.
1745 * recode.c: (string_to_long) Make first arg const.
1746 (convert_to_double) Ditto.
1748 * repeat.c: Remove debug code.
1750 * sample.c: Remove debug code.
1752 * sfm-read.c: Remove debug code.
1753 (sfm_read_case) Change second arg from `union value *' to `struct
1756 * sort.c: Redone in terms of casefiles.
1757 (enum sort_direction) Moved here from sort.h.
1758 (struct sort_criterion) New structure.
1759 (struct sort_criteria) New structure.
1760 (cmd_sort_cases) Rewritten.
1761 (prepare_to_sort_active_file) New function.
1762 (sort_active_file_in_place) New function.
1763 (sort_active_file_to_casefile) New function.
1764 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1765 changed, all callers updated.
1766 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1767 rewritten & interface changed, all callers updated.
1768 (sort_cases) Renamed sort_execute(), rewritten & interface
1769 changed, all callers updated.
1770 (struct internal_sort) Removed.
1771 (do_internal_sort) Rewritten, interface changed.
1772 (destroy_internal_sort) Removed.
1773 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1774 (struct initial_run) Removed; an initial run is now just a
1776 (compare_initial_runs) Rewritten.
1777 (struct external_sort) Changed almost completely.
1778 (do_external_sort) Rewritten, interface changed.
1779 (destroy_external_sort) Rewritten.
1780 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1781 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1782 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1783 (init_external_sort) Removed.
1784 (simulate_error) Removed.
1785 (rmdir_temp_dir) Removed.
1786 (get_temp_file_name) Removed.
1787 (open_temp_file) Removed.
1788 (close_temp_file) Removed.
1789 (remove_temp_file) Removed.
1790 (write_temp_file) Removed.
1791 (read_temp_file) Removed.
1792 (struct record_run) Change `record' from `struct case_lit *' to
1794 (struct initial_run_state) Remove `idx_to_fv', `free_list',
1795 `file_idx', `output_file'. Add `run', casefile'. Change
1796 `last_output' from `struct case_list *' to `struct ccase'.
1797 (write_initial_runs) Change interface, rewrite.
1798 (sort_sink_write) Renamed process_case(), changed interfaced,
1800 (destroy_initial_run_state) Rewritten.
1801 (allocate_cases) Rewritten.
1802 (compare_record) Interface changed, rewritten.
1803 (start_run) Rewritten.
1804 (end_run) Rewritten.
1805 (output_record) Rewritten.
1806 (grab_case) Removed.
1807 (release_case) Removed.
1808 (struct merge_case) Change `cases' from double pointer to single
1810 (merge) Deal with new case and casefile ADTs.
1811 (struct run) Removed.
1812 (merge_once) Rewritten, interface changed.
1813 (fill_run_buffer) Removed.
1814 (sort_sink_make_source) Removed.
1815 (sort_sink_class) Removed.
1816 (struct sort_source_aux) Removed.
1817 (sort_source_read_helper) Removed.
1818 (sort_source_read) Removed.
1819 (read_sort_output) Removed.
1820 (read_internal_sort_output) Removed.
1821 (read_external_sort_output) Removed.
1822 (sort_source_destroy) Removed.
1823 (sort_source_class) Removed.
1825 * sort.h: (struct sort_cases_pgm) Removed.
1826 (enum sort_direction) Moved to sort.c.
1828 * t-test.q: (calculate) Deal with new case, casefile ADTs.
1830 * tab.c: Remove debug code.
1832 * var-labs.c: Remove debug code.
1834 * var.h: (struct ccase) Removed.
1835 (struct case_list) Removed.
1837 * vars-atr.c: (discard_variables) Use free_case_source().
1839 * vars-prs.c: (parse_vs_variable) Make arg const.
1840 (parse_dict_variable) Ditto.
1841 (parse_variables) Make struct dictionary * arg const.
1842 (parse_var_set_vars) Make struct var_set * arg const.
1843 (struct var_set) Add const to some of the function pointers' args.
1844 (var_set_get_cnt) Make arg const.
1845 (var_set_get_var) Make first arg const.
1846 (var_set_lookup_var) Make first arg const.
1847 (dict_var_set_get_cnt) Make arg const.
1848 (dict_var_set_get_var) Make first arg const.
1849 (dict_var_set_lookup_var) Make first arg const.
1850 (var_set_create_from_dict) Make arg const. Add cast to aux
1852 (struct array_var_set) Add const to var member.
1853 (array_var_set_get_cnt) Make arg const.
1854 (array_var_set_get_var) Make first arg const.
1855 (array_var_set_lookup_var) Make first arg const.
1856 (var_set_create_from_array) Make first arg const. Insert cast.
1858 * vfm.c: (struct write_case_data) Change trns_case, sink_case
1859 members from `struct ccase *' to `struct ccase'.
1860 (static var lag_queue) Change from double to single pointer.
1861 (procedure) Optimize trivial case.
1862 (internal_procedure) Deal with changed case, case_source ADTs.
1863 (create_trns_case) Changed interface, rewrote.
1864 (open_active_interface) Initialize modified lag queue.
1865 (write_case) Deal with changed case ADT.
1866 (lag_case) Deal with modified lag queue.
1867 (close_active_file) Destroy modified lag queue.
1868 Deal with changed case_source, case_sink ADTs.
1869 (destroy_storage_stream_info) Make null arg into no-op.
1870 (storage_sink_make_source) Set aux in created source.
1871 (storage_source_read) Deal with changed case, casefile ADTs.
1872 (storage_source_create) New function.
1873 (lagged_case) Rewrite.
1874 (free_case_source) New function.
1875 (free_case_sink) Rewrite.
1876 (struct split_aux_data) Changed prev_case from `struct ccase *' to
1878 (procedure_with_splits) Deal with changed prev_case.
1879 (procedure_with_splits_callback) Ditto.
1880 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
1882 (multipass_procedure_with_splits) Deal with changed prev_case.
1883 (multipass_split_callback) Ditto.
1886 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
1888 The workspace idea didn't work out.
1890 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
1892 * workspace.c: Removed.
1894 * workspace.h: Removed.
1896 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
1898 Fully implement arbitrary delimiters on DATA LIST, extending the
1899 half implementation that was already there.
1901 * data-list.c: (struct data_list_pgm) Remove `delim', add
1902 `delims', `delim_cnt'.
1903 (cmd_data_list) Initialize new members. Parse delimiters and
1904 clean up code a bit.
1905 (cut_field) Extract fields with arbitrary delimiters. Also, fix
1906 handling of leading commas.
1907 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
1909 (read_from_data_list_free) Adapt to new DFM interfaces.
1910 (read_from_data_list_list) Ditto.
1911 (repeating_data_trns_proc) Ditto.
1913 * dfm.c: Split up reader and writer into separate code, because
1914 they do different things. Use struct string instead of explicit
1915 allocation code, for clarity.
1916 (enum dfm_reader_flags) New enum.
1917 (struct dfm_fhuser_ext) Removed.
1918 (struct dfm_reader_ext) New.
1919 (get_reader) New function, used by just about all the reader
1921 (dfm_close) Removed.
1922 (close_reader) New function.
1923 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
1924 (dfm_open_for_writing) Ditto.
1925 (macro force_line_buffer_expansion) Removed.
1926 (count_tabs) Removed.
1927 (tabs_to_spaces) Removed.
1928 (read_record) Deal with new dfm_reader_ext. Use struct string
1929 functions. Don't convert tabs to spaces.
1930 (dfm_eof) New function.
1931 (dfm_get_record) Changed interface, rewrote.
1932 (dfm_expand_tabs) New function.
1933 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
1934 dfm_reader_ext, rewritten.
1935 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
1936 dfm_reader_ext, rewritten.
1937 (dfm_set_record) Removed in favor of dfm_forward_columns().
1938 (dfm_forward_columns) New function.
1939 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
1940 dfm_reader_ext, rewritten.
1941 (static var dfm_r_class) Use close_reader for the destructor.
1942 (struct dfm_writer_ext) New.
1943 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
1944 bounce buffer now instead of local allocation.
1945 (close_writer) New function.
1946 (static var dfm_writer_ext) Use close_writer for destructor.
1947 (cmd_begin_data) Adapt to new dfm_reader_ext.
1949 * file-handle.q: Add support for per-file tab width.
1950 (struct private_file_handle) Add tab_width member.
1951 (q2c specifications) Add tabwidth subcommand.
1952 (cmd_file_handle) Put parsed tab width into private_file_handle.
1953 (create_file_handle) Set default tab width.
1954 (handle_get_tab_width) New function.
1956 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
1958 * inpt-pgm.c: (reread_trns_proc) Ditto.
1960 * matrix-data.c: (context) Ditto.
1961 (another_token) Ditto.
1965 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
1967 * casefile.c: (casefile_destroy) Fix memory leak by freeing
1969 (casereader_destroy) Don't close file descriptor -1.
1971 * recode.c: (cmd_recode) Fix memory leak.
1973 * set.q: (q2c specifications) Fix typo in user message.
1975 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
1976 undefined behavior for overlapping arguments.
1978 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
1980 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
1981 don't call it when we're running under valgrind.
1982 (call_posix_fadvise) New function.
1983 (casefile_to_disk) Use call_posix_fadvise().
1984 (reader_open_file) Ditto.
1986 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
1988 Update our string ADTs, struct string and struct len_string. Get
1989 rid of pool support, which was largely unused. Rename lots of
1990 functions to have more obvious or consistent names.
1992 * ascii.c: Get rid of ascii_pool. It was only used for string
1994 (ascii_open_global) Don't create ascii_pool.
1995 (ascii_close_driver) Don't destroy ascii_pool.
1996 (ascii_postopen_driver) Don't use pool.
1997 (ascii_close_driver) Destroy strings manually.
1999 * str.c: (ds_create) Remove pool argument, all references updated.
2001 (ds_replace) Remove pool support, make more efficient when we
2002 don't need to reallocate.
2003 (ds_destroy) Remove pool support.
2004 (ds_rpad) New function.
2005 (ds_size) Renamed ds_capacity(), all references updated.
2006 (ds_value) Renamed ds_c_str(), all references updated.
2007 (ds_concat) Renamed ds_puts(), all references updated.
2008 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2009 (ds_putchar) Renamed ds_putc(), all references updated.
2010 (ds_getline) Renamed ds_gets(), all references updated.
2011 (ls_create) Remove pool argument, all references updated.
2012 (ls_create_buffer) Ditto.
2013 (ls_destroy) Removed pool support.
2014 (ls_value) Renamed ls_c_str(), all references updated.
2016 * str.h: (ls_length) [__GNUC__] Add inline version.
2017 (ls_c_str) [__GNUC__] Add inline version.
2018 (ls_end) [__GNUC__] Add inline version.
2019 (struct string) Remove pool member. Rename `size' to `capacity',
2020 all references updated.
2022 * tab.c: (text_format) Instead of using pool argument to
2023 ls_create_buffer(), call pool_register() on allocated data.
2025 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2027 We're abusing the current ASCII driver by telling it to allocate a
2028 9999-line, 9999-character page in the tests. This causes some
2029 systems to curl up and die because it allocates 20 MB of
2030 contiguous RAM. This change alleviates at least part of the
2031 problem. It is mostly a stop-gap until the new output system is
2034 * ascii.c: (struct line) New structure.
2035 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2036 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2037 (ascii_preopen_driver) Initialize new members, not old ones.
2038 (ascii_close_driver) Destroy new members, not old ones.
2039 (ascii_open_page) Allocate new members, not old ones.
2040 (expand_line) Allocate room in line.
2041 (draw_line) Use new members.
2042 (ascii_line_horz) Ditto.
2043 (ascii_line_vert) Ditto.
2044 (ascii_line_intersection) Ditto.
2046 (output_lines) Ditto.
2047 (ascii_close_page) Ditto.
2049 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2051 * matrix.c: Dead code. Removed.
2053 * matrix.h: Dead code. Removed.
2055 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2057 Contrary to what I'd always understood, there is an efficient
2058 algorithm for deletion from a hash table populated via linear
2059 probing. This change implements it.
2061 * hash.c: (hsh_rehash) Probe in increasing order.
2063 (locate_matching_entry) Ditto.
2064 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2066 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2068 * moments.c (calc_moments): Adjust calculation of kurtosis to
2069 avoid subtracting huge numbers from huge numbers, on Michael
2072 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2074 Rework moments routines for improved numerical stability based on
2075 Michael Kiefte's advice. Any bugs or remaining numerical problems
2076 are still mine though.
2078 There is now a struct moments1 for use with one-pass moments. It
2079 uses a provisional means algorithm as an attempt to improve
2080 accuracy of higher moments. The older struct moments now only
2081 handles two-pass moments.
2083 * aggregate.c: Use moments1 instead moments.
2085 * descript.c: Revert previous change, which is no longer needed
2086 due to the moments revision.
2088 * moments.c: (calc_moments) New function for calculating variance,
2090 (moments_pass_one) Only accumulate weights bigger than zero.
2091 (moments_calculate) Allow calculating the mean on pass one, others
2092 require pass two. Implement in terms of calc_moments().
2093 (struct moments1) New structure.
2094 (init_moments1) New function.
2095 (moments1_clear) Ditto.
2096 (moments1_create) Ditto.
2097 (moments1_add) Ditto.
2098 (moments1_calculate) Ditto.
2099 (moments1_destroy) Ditto.
2100 (cmd_debug_moments) Deal with `struct moments' or `struct
2101 moments1' as requested by user.
2103 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2105 * Makefile.am (pspp_SOURCES): Remove debug.c.
2107 * debug.c: Removed. It was empty anyway.
2109 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2111 * descript.c (calc_descriptives): Fix assert failure when only
2112 MOMENT_MEAN is needed.
2114 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2118 fixed problem with parsing in match_statistic() causing
2119 "DESCRIPTIVE STAT=MEAN." to barf.
2121 "MEAN" is now default if "SORT" given without specification.
2123 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2124 generally less forgiving of syntax errors: better to have it do
2125 nothing and type it in again then to not know what it actually did
2128 z-score transformation now checks score for user-missing values
2129 and checks std_dev for SYSMIS.
2131 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2133 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2134 Changed dict_get_case_weight() to accept an additional int * flag
2135 to complain about system-missing, user-missing, zero, or negative
2136 weights and updated existing functions to pass int * to
2137 dict_get_case_weight().
2139 2004-04-05 jmd <jmd@gnu.org>
2141 * main.c: Fixed configuration problems with gsl
2143 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2145 2004-04-03 blp <blp@gnu.org>
2147 * lexer.c, ChangeLog:
2148 Fix infinite loop on comment at end of file, add test.
2150 2004-04-03 jmd <jmd@gnu.org>
2152 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2153 Fixed the calculation of percentiles and added --syntax and --algorithm options
2155 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2157 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2160 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2162 * frequencies.q: Fixed the calculation of percentiles
2164 * Makefile.am: Added the --ansi flag and dealt with the
2165 consequences. Added some entries to PSPP_sources so that
2166 make distcheck would pass
2168 * cmdline.c: Added the --syntax and --algorithm options
2170 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2172 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2174 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2175 use the new multipass_split_... mechanism.
2177 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2179 * frequencies.q: (calc_stats) Use moments data structure and
2180 calc_seskew(), calc_sekurt() functions.
2182 * set.q main.c settings.h Added support for --syntax and --algorithm
2185 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2187 * vfm.c: Had to get last call to multipass_split_output() inside
2188 open_active_file()/close_active_file() pairing, so introduce new
2190 (internal_procedure) Move procedure() code here, except for calls
2191 to open_active_file() and close_active_file().
2192 (procedure) Wrap open_active_file() and close_active_file() around
2193 internal_procedure().
2194 (multipass_procedure_with_splits) Wrap open_active_file() and
2195 close_active_file() around internal_procedure().
2197 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2199 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2201 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2203 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2205 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2207 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2209 * algorithm.c: By default turn off some of the more expensive
2211 (expensive_assert) New macro which expands to assert if
2212 EXTRA_CHECKS is defined, to nothing otherwise.
2213 (unique) Use expensive_assert().
2214 (binary_search) Ditto.
2220 * command.c: (conflicting_3char_prefixes) Words that are the same
2221 don't cause conflicts when they are abbreviated to the first three
2224 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2225 nonterm_node's n earlier.
2226 (generic_str_func) Ditto.
2228 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2230 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2231 test multipass support, take advantage of new moments
2232 calculation, and to not be such crappy code. Get rid of q2c
2233 processing for DESCRIPTIVES.
2235 * vfm.c: (struct multipass_split_aux_data) New structure.
2236 (multipass_procedure_with_splits) New function.
2237 (multipass_split_callback) New function.
2238 (multipass_split_output) New function.
2239 * descript.q: Removed.
2241 * descript.c: New file.
2243 * var.h: Removed descriptives enums.
2244 (struct descriptives_proc) Removed.
2245 (struct variable) Removed p.dsc.
2247 * Makefile.am: (q_sources_c) Remove descript.c.
2248 (q_sources_q) Removed descript.q.
2250 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2252 New manager for keeping track of used workspace.
2254 * workspace.c: New file.
2256 * workspace.h: New file.
2258 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2260 * sort.c: (do_internal_sort) Use workspace_malloc().
2261 (destroy_internal_sort) Use workspace_free().
2263 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2265 New `struct casefile' for managing sets of cases.
2267 * casefile.c: New file.
2269 * casefile.h: New file.
2271 * command.def: Add DEBUG CASEFILE command.
2273 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2275 * sort.c: (sort_cases) Move logic for sending storage file to disk
2276 into do_external_sort().
2277 (struct internal_sort) Use an array of ccase pointers instead of a
2279 (do_internal_sort) Rewrite to handle casefiles.
2280 (compare_case_list) Removed.
2281 (compare_cases) New function.
2282 (compare_case_dblptrs) New function.
2283 (read_internal_sort_output) Deal with new struct internal_sort.
2285 * vfm.c: (static var workspace_overflow) Removed.
2286 (struct storage_stream_info) Removed all the members. Added
2287 struct casefile * member.
2288 (storage_sink_open) Use casefile.
2289 (open_storage_file) Removed.
2290 (write_storage_file) Removed.
2291 (storage_to_disk) Removed.
2292 (destroy_storage_stream_info) Use casefile.
2293 (storage_sink_write) Use casefile.
2294 (storage_sink_make_source) Use casefile.
2295 (storage_source_count) Use casefile.
2296 (storage_source_read) Use casefile.
2297 (storage_source_on_disk) Removed.
2298 (storage_source_get_cases) Removed.
2299 (storage_source_set_cases) Removed.
2300 (storage_source_get_casefile) New function.
2302 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2304 New `struct moments' for calculating moments.
2310 * moments.c: New file.
2312 * moments.h: New file.
2314 * command.def: Add DEBUG MOMENTS command.
2316 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2319 * aggregate.c: Modify AGGREGATE to use the new moments
2320 calculation, even if not in such a great way.
2321 (struct agr_var) Add `moments' member.
2322 (parse_aggregate_functions) Set `moments' member to null.
2323 (agr_destroy) Destroy `moments' member.
2324 (accumulate_aggregate_info) Use `moments' for standard deviation.
2325 (dump_aggregate_info) Ditto.
2326 (initialize_aggregate_info) Create or clear `moments'.
2328 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2329 cube(), pow4() that were in stats.h. All references updated.
2331 * crosstabs.q: stats.h had chi-square significance functions. Use
2333 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2335 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2336 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2338 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2340 * dictionary.c: (dict_compact_values) Compacted values need to
2343 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2345 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2346 `/' at start. Check return value of parse_variables() for error
2349 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2351 Revamp expressions: make the code a little nicer, and fix bugs
2354 * expr-evl.c: (expr_evaluate) Make expression argument const.
2355 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2356 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2357 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2358 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2359 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2360 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2361 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2362 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2363 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2364 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2365 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2366 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2367 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2369 * expr-opt.c: (optimize_expression) Rewrite.
2374 (macro s0l) Removed.
2376 (macro s1l) Removed.
2378 (macro s2l) Removed.
2381 (eq_num_con) New function.
2382 (optimize_tree) New function.
2383 (macro rnc) Removed.
2384 (macro frnc) Removed.
2385 (str_search) Add const to string params.
2386 (str_rsearch) Ditto.
2387 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2388 str[], str_len[] locals to substitute for most of removed macros.
2389 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2390 Removed support for missing values because we're never called with
2391 missing values. Use set_number() or set_number_errno() instead of
2392 rnc or frnc. Removed any stuff that caused trouble in testing.
2393 We can re-add it later if it really slows anything. Fix some
2395 (evaluate_tree_with_missing) Not yet supported. To be added later
2397 (repl_num_con) Removed.
2398 (collapse_node) New function.
2399 (force_repl_num_con) Removed.
2400 (set_number) New function.
2401 (set_number_errno) New function.
2402 (repl_str_con) Removed.
2403 (set_string) New function.
2404 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2406 (dump_node) No special case for OP_AND, OP_OR.
2408 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2409 (expr_get_type) New function.
2410 (type_check) Rewrite.
2411 (type_coercion) New function.
2412 (struct operator) New structure.
2413 (match_operator New function.
2414 (parse_binary_operators) New function.
2415 (parse_inverting_unary_operator) New function.
2416 (parse_or) Rewritten.
2417 (parse_and) Rewritten.
2418 (parse_not) Rewritten.
2419 (parse_rel) Rewritten.
2420 (parse_add) Rewritten.
2421 (parse_mul) Rewritten.
2422 (parse_neg) Rewritten.
2423 (parse_exp) Rewritten.
2424 (parse_sysvar) Add $TRUE, $FALSE system variables.
2425 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2426 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2428 (struct function) Remove desc, change `func' prototype.
2429 (unary_func) Remove special cases.
2430 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2431 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2432 (VALUE_func) Use allocate_var_node().
2433 (nary_num_func) Allow MIN and MAX for strings.
2434 Use allocate_var_node(). Properly clean up.
2436 (generic_str_func) Use local table instead of removed `desc'
2437 member. Mostly rewrite.
2438 (get_num_args) Revise error message.
2439 (parse_function) Return EXPR_ERROR, not 0 on error.
2441 (macro varies) Removed.
2442 (ops[]) Use expr.def.
2443 (free_node) Do nothing if node is null.
2444 (allocate_num_con) New function.
2445 (allocate_str_con) New function.
2446 (allocate_var_node) New function.
2447 (allocate_binary_nonterminal) New function.
2448 (append_nonterminal_arg) Removed.
2449 (static var func_tab[]) Revised.
2450 (expr_debug_print_postfix) Make parameter const.
2451 Use printf() instead of debug_printf().
2453 * expr.def: New file.
2455 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2456 use named enum instead of unnamed, all references updated. Add
2457 EXPR_ANY, EXPR_NO_OPTIMIZE.
2459 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2460 instead of defining OP_* directly.
2461 (macro IS_TERMINAL) New macro.
2462 (macro IS_NONTERMINAL) New macro.
2463 (enum OP_NO_FLAGS) New.
2465 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2467 * error.c: (err_assert_fail) msg variable needs to be non-const.
2469 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2471 * debug.c: (cmd_debug_evaluate) Rewrite.
2473 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2475 Fix some CROSSTABS bit rot stupidity.
2477 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2478 (internal_cmd_crosstabs) Initializes cells[] correctly.
2479 (float_M_suffix) Rename format_cell_entry(), change prototype,
2481 (display_crosstabulation) Fix cell formatting.
2483 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2485 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2486 to call lex_discard_line() to do that.
2488 * command.c: (run_command) Call lex_discard_line() after
2491 * lexer.c: (lex_entire_end) Change behavior.
2492 (lex_rest_of_line) Change behavior. Return const char *.
2493 (lex_discard_line) Don't clear getl_buf, don't emit message.
2495 * main.c: (handle_error) Emit message here.
2497 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2498 instead of lex_entire_line().
2500 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2502 * title.c: (get_title) Call lex_discard_line() after
2504 (cmd_file_label) Ditto.
2505 (cmd_document) Deal with const char * return value.
2507 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2509 Removed REMARK command.
2511 * command.c: (extract_prefix) Removed.
2512 (output_line) Removed.
2513 (cmd_remark) Removed.
2515 * command.def: Remove REMARK.
2517 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2519 Added abort() after lots of assert(0) invocations to avoid some
2520 compiler warnings. We really need a NOT_REACHED macro.
2522 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2524 * sort.c: Added missing call to temp_file_close. Changed error
2525 messages to warnings.
2527 * set.q: Improved setting of set_view{length,width} to be more tolerant
2530 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2532 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2533 used with incorrect syntax.
2535 * error.c, error.h et al: Overridden definition of assert for a
2538 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2539 subcommand was given when it ought to have been.
2541 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2543 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2547 (tab_joint_text) Ditto.
2549 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2551 * levene.c: Add #include.
2553 * set.q: (set_viewport) Add `int' argument to make its prototype
2554 correct for signal().
2556 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2558 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2561 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2563 Changed DFM from open-at-first-access to explicit-open. Before,
2564 calling dfm_get_record() or dfm_put_record() would automatically
2565 open the file. Now, you have to call dfm_open_for_reading() or
2566 dfm_open_for_writing() explicitly. This makes it possible to
2567 check permissions, file existence, etc. earlier.
2569 Also made struct file_handle more opaque, and clean up in general.
2571 * data-list.c: (cmd_data_list) Open handle for reading.
2573 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2575 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2576 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2577 (open_inline_file) Removed.
2578 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2579 it. Deal with line_number in extension record instead of file
2581 (dfm_get_record) Rewrote.
2582 (dfm_put_record) Rewrote.
2583 (dfm_push) Assert file is open and one of ours. Deal with
2584 line_number in extension record instead of file handle.
2585 (dfm_pop) Assert file is open and one of ours. Deal with
2586 line_number in extension record instead of file handle.
2587 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2590 * file-handle.h: (enum constants RH_RF_*) Removed.
2591 (enum constants FH_MD_*) Removed.
2592 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2593 `recform', `lrecl', `mode' members. Public references to
2594 `recform' changed to use handle_get_mode(), references to `lrecl'
2595 changed to use handle_get_record_width(). Added `private' member.
2596 (enum file_handle_mode) New.
2598 * file-handle.q: (struct private_file_handle) New structure.
2599 (struct file_handle_list) New structure.
2600 (static var files) New.
2601 (static var file_handles) Removed.
2602 (init_file_handle) Removed.
2603 (create_file_handle) Removed.
2604 (get_handle_with_name) New function.
2605 (get_handle_for_filename) New function.
2606 (cmd_file_handle) Rewritten.
2607 (hash_file_handle) Removed.
2608 (cmp_file_handle) Removed.
2609 (fh_init_files) Rewritten.
2610 (fh_parse_file_handle) Rewritten. Allows identifiers as
2612 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2614 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2615 references updated. Rewritten.
2616 (fh_record_width) Renamed handle_get_record_width(), all
2617 references updated. Rewritten.
2618 (handle_get_mode) New function.
2620 * file-type.c: (cmd_file_type) Open handle for reading.
2622 * filename.c: [unix] (struct file_identity) New structure.
2623 [unix] (fn_get_identity) New function.
2624 [unix] (fn_free_identity) New function.
2625 [unix] (fn_compare_file_identities) New function.
2626 [!unix] (struct file_identity) New structure.
2627 [!unix] (fn_get_identity) New function.
2628 [!unix] (fn_free_identity) New function.
2629 [!unix] (fn_compare_file_identities) New function.
2631 * lexer.c: (static var put) Renamed put_token, all references
2633 (static var put_tokstr) New.
2634 (static var put_tokval) New.
2635 (lex_init) Initialize put_tokstr().
2636 (restore_token) New function.
2637 (save_token) New function.
2638 (lex_get) Use restore_token().
2639 (lex_put_back) Use save_token().
2640 (lex_put_back_id) New function.
2641 (lex_put_forward) Removed.
2642 (lex_preprocess_line) Set put_token instead of using
2644 (lex_negative_to_dash) Use save_token(), set put_token directly.
2645 (dump_token) Use stderr instead of stdout.
2647 * main.c: (main) Remove call to cmd_init().
2649 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2651 * pfm-read.c: Use handle_get_filename() instead of trying to use
2652 h->fn directly, all over.
2654 * pfm-write.c: Ditto.
2656 * print.c: (internal_cmd_print) Open handle for writing.
2657 (dump_table) Use handle_get_filename().
2658 (print_trns_proc) Use handle_get_mode().
2659 (cmd_print_space) Use fh_parse_file_handle().
2660 Open handle for writing.
2661 [0] (debug_print) Removed.
2663 * sfm-read.c: Use handle_get_filename() instead of trying to use
2664 h->fn directly, all over.
2666 * sfm-write.c: Ditto.
2668 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2672 * autorecode.c: (arc_free) Free arc->src_values.
2674 * error.c: (msg) Free buf.
2676 * val-labs.c: (do_value_labels) Always free vars.
2678 * vfm.c: (close_active_file) If sink has no make_source then call
2679 its destroy function.
2681 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2683 Fixed cmd_parse() so that it always skips past a full command
2684 name. A few special commands for which this would be bad get
2685 special treatment. This lets us drop code for skipping past the
2686 end of a command name in most cmd_*() functions. It's not worth
2687 listing all the commands affected.
2689 * command.c: (struct command) Remove `cmd' member, replace by
2690 `name' member, all references updated. Remove `word', `next',
2691 `skip_entire_name' members.
2692 (macro DEFCMD) Deal with revised `struct command'.
2693 (macro UNIMPL) Ditto.
2694 (macro SPCCMD) New macro for commands whose last word shouldn't be
2696 (static array cmd_table[]) Make const, rename `commands', remove
2698 (macro COMMAND_CNT) New macro.
2699 (split_words) Removed.
2701 (FILE_TYPE_okay) Make parameter const.
2702 (cmd_parse) Improve error messages.
2703 (match_strings) New function.
2704 (next_word) New function.
2705 (enum command_match) New enum.
2706 (conflicting_3char_prefixes) New function.
2707 (conflicting_3char_prefix_command) New function.
2708 (cmd_match_words) New function.
2709 (count_matching_commands) New function.
2710 (get_command_name) New function.
2711 (free_words) New function.
2712 (unknown_command_error) New function.
2713 (figure_out_command) Renamed parse_command_name(), rewritten.
2715 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2716 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2717 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2720 * command.h: (macro SPCCMD) New.
2722 * include.c: (cmd_include_at) Removed.
2723 (cmd_include) Allow identifier to be used as filename.
2725 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2727 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2730 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2732 Start work on better test framework.
2734 * Makefile.am: (pspp_sources) Add debug.c.
2736 * debug.c: New file.
2738 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2739 cmd_debug_evaluate().
2741 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2743 * expr.h: (enum constant PXP_DUMP) Removed.
2745 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2747 * set.q: Implemented the SHOW command, and synced it to the existing
2750 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2751 changes as the window size is changed.
2753 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2754 environment variables if other methods are not available.
2756 glob.c: Removed a lot of global variables from glob.c and encapsulated
2759 random.c: Tidied up the way the random seed is set.
2761 str.c: Added a ds_vprintf function.
2763 error.c: Extended dump_message so that messages are always broken at
2766 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2768 * pfm-write.c: (bufwrite) Write out the correct element for string
2769 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2771 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2773 Get rid of static and global (!) vars in matrix-data.c.
2775 * matrix-data.c: (static var nr_data) Removed.
2776 (static var nr_factor_values) Removed.
2777 (static var max_cell_index) Removed.
2778 (static var split_values) Removed.
2779 (struct nr_aux_data) New structure.
2780 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2781 place of static vars, pass to create_case_source() and procedure()
2783 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2784 struct matrix_data_pgm *.
2785 (nr_read_splits) Ditto.
2786 (nr_read_factors) Ditto.
2787 (nr_output_data) Ditto.
2788 (static var wr_content) Removed.
2789 (global var wr_data) Removed.
2790 (global var wr_current) Removed.
2791 (struct wr_aux_data) New structure.
2792 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2793 place of static vars, pass to create_case_source() and procedure()
2795 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
2796 instead of matrix_data_pgm *.
2797 (wr_read_splits) Ditto.
2798 (wr_output_data) Ditto.
2799 (wr_read_rowtype) Ditto.
2800 (wr_read_factors) Ditto.
2801 (wr_read_indeps) Ditto.
2803 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
2805 Get rid of static vars in autorecode.c.
2807 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
2808 `n_arc' to `spec_cnt'. All references updated.
2809 (static var v_src) Removed.
2810 (static var v_dest) Removed.
2811 (static var h_trns) Removed.
2812 (static var nv_src) Removed.
2813 (static var descend) Removed.
2814 (static var print) Removed.
2815 (enum direction) New enum.
2816 (struct autorecode_pgm) New structure.
2817 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
2818 Move n_dest local var into struct autorecode_pgm for ease of
2819 clean-up. Use arc_free().
2820 (arc_free) New function.
2821 (recode) Modify to take struct autorecode_pgm * parameter instead
2822 of using statics. Let the caller clean up.
2823 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
2824 instead of statics. Rearrange code a little.
2826 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
2828 Get rid of static, global vars in recode.c. Remove debug code.
2830 * recode.c: (static var head) Removed.
2831 (global var v) Removed.
2832 (global var nv) Removed.
2833 (cmd_recode) New local variables head, v, nv. Initialize and free
2834 v. Don't call debug_print().
2835 [DEBUGGING] (dump_dest) Removed.
2836 [DEBUGGING] (debug_print) Removed.
2838 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
2840 Get rid of static vars in expr-opt.c.
2842 * expr-opt.c: (static var e) Removed.
2843 (static var nop) Removed.
2844 (static var mop) Removed.
2845 (static var ndbl) Removed.
2846 (static var mdbl) Removed.
2847 (static var nstr) Removed.
2848 (static var mstr) Removed.
2849 (static var nvars) Removed.
2850 (static var mvars) Removed.
2851 (struct expr_dump_state) New structure.
2852 (dump_expression) Use new struct expr_dump_state instead of static
2853 vars and pass to functions we call.
2854 (dump_node) Use struct expr_dump_state * parameter.
2856 (emit_num_con) Ditto.
2857 (emit_str_con) Ditto.
2860 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
2862 Get rid of static var in COUNT.
2864 * count.c: (static var head) Move into cmd_count().
2865 (cmd_count) [DEBUGGING] Don't call debug_print.
2866 [DEBUGGING] (debug_print) Removed.
2868 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
2870 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
2872 * val-labs.c: (static var v) Removed.
2873 (static var nv) Removed.
2874 [DEBUGGING] (debug_print) Removed.
2875 (verify_val_labs) Add struct variable **, int parameters.
2876 (get_label) Ditto. Improve error messages, streamline.
2877 (erase_labels) New function for erasing value labels, taking over
2878 part of verify_val_labs()'s function.
2881 (cmd_value_labels) No need to call init() or done() anymore.
2882 (cmd_add_value_labels) Ditto.
2883 (do_value_labels) Add vars, var_cnt local variables. Clean up
2884 after them internally. Call erase_labels() if we should. Don't
2887 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
2889 Get rid of static vars in MATCH FILES.
2891 * get.c: (static var mtf_head) Removed.
2892 (static var mtf_tail) Removed.
2893 (static var mtf_by) Removed.
2894 (static var mtf_n_by) Removed.
2895 (static var mtf_master) Removed.
2896 (static var mtf_seq_num) Removed.
2897 (static var mtf_seq_nums) Removed.
2898 (static var mtf_sink) Removed.
2899 (static var mtf_case) Removed.
2900 (struct mtf_proc) New structure.
2901 (cmd_match_files) Use struct mtf_proc instead of static vars.
2902 (mtf_processing_finish) Ditto.
2904 (mtf_delete_file_in_place) Ditto.
2905 (mtf_read_nonactive_records) Ditto.
2906 (mtf_compare_BY_values) Ditto.
2907 (mtf_processing) Ditto.
2908 (mtf_merge_dictionary) Ditto.
2910 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
2912 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
2914 * dictionary.c: (dict_rename_var) Add assertion.
2915 (dict_contains_var) Check by index instead of name.
2917 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
2919 Get rid of compaction_necessary, compaction_nval, compaction_case.
2920 Redo VFM interface. Replace disk_sink and memory_sink by
2921 storage_sink, disk_source and memory_source by storage_source.
2923 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
2927 (struct write_case_data) Remove `begin_func', `end_func',
2928 `func_aux' members. Add `aux', `trns_case', `sink_case',
2929 `cases_written', `cases_analyzed' members.
2930 (global var compaction_necessary) Make static.
2931 (global var compaction_nval) Removed.
2932 (global var compaction_case) Removed.
2933 (static var case_count) Removed.
2934 (struct procedure_aux_data) Removed.
2935 (struct split_aux_data) Removed.
2936 (procedure) Remove begin_func, end_func parameters. Rewrite.
2937 (static var not_canceled) Removed.
2938 (process_active_file) Removed.
2939 (process_active_file_write_case) Removed.
2940 (process_active_file_output_case) Removed.
2941 (prepare_for_writing) Moved into open_active_file().
2942 (arrange_compaction) Ditto.
2944 (open_active_file) Rewrote.
2945 (write_case) New function.
2946 [DEBUGGING] (index_to_varname) Removed.
2947 (execute_transformations) New function.
2948 (exclude_this_case) Renamed filter_case(), changed interface.
2949 (clear_case) Added struct ccase * parameter to interface.
2950 (close_active_file) Added struct write_case_data * parameter,
2952 (disk_sink_create) Removed.
2953 (disk_sink_destroy) Removed.
2954 (disk_sink_make_source) Removed.
2955 (disk_sink_write) Removed.
2956 (disk_source_count) Removed.
2957 (disk_source_destroy) Removed.
2958 (disk_source_read) Removed.
2959 (global var disk_sink_class) Removed.
2960 (global var disk_source_class) Removed.
2961 (global var memory_sink_class) Removed.
2962 (global var memory_source_class) Removed.
2963 (memory_sink_create) Removed.
2964 (memory_sink_destroy) Removed.
2965 (memory_sink_make_source) Removed.
2966 (memory_sink_write) Removed.
2967 (memory_source_count) Removed.
2968 (memory_source_destroy) Removed.
2969 (memory_source_get_cases) Removed.
2970 (memory_source_read) Removed.
2971 (memory_source_set_cases) Removed.
2972 (struct disk_stream_info) Removed.
2973 (struct memory_sink_info) Removed.
2974 (struct memory_source_info) Removed.
2975 (write_active_file_to_disk) Removed.
2976 (destroy_storage_stream_info) New function.
2977 (global var null_sink_class) New var.
2978 (global var storage_sink_class) New var.
2979 (global var storage_source_class) New var.
2980 (open_storage_file) New function.
2981 (storage_sink_destroy) New function.
2982 (storage_sink_make_source) New function.
2983 (storage_sink_open) New function.
2984 (storage_sink_write) New function.
2985 (storage_source_count) New function.
2986 (storage_source_destroy) New function.
2987 (storage_source_get_cases) New function.
2988 (storage_source_on_disk) New function.
2989 (storage_source_read) New function.
2990 (storage_source_set_cases) New function.
2991 (storage_source_to_disk) New function.
2992 (storage_to_disk) New function.
2993 (struct storage_stream_info) New structure.
2994 (write_storage_file) New function.
2995 (procedure_write_case) Removed.
2996 (create_case_source) Add `struct dictionary *' parameter, all
2998 (create_case_sink) Ditto.
2999 (free_case_sink) New function.
3000 (struct split_aux_data) New structure.
3001 (procedure_with_splits) New function implementing what procedure()
3003 (SPLIT_FILE_proc_func) Removed.
3004 (procedure_with_splits_callback) New function.
3005 (equal_splits) New function.
3007 * aggregate.c: Pass around a struct instead of using statics.
3008 (static var outfile) Remove.
3009 (enum type) Give it tag `missing_treatment'.
3010 (static var missing) Remove.
3011 (static var sort) Remove.
3012 (static var agr_first) Remove.
3013 (static var agr_next) Remove.
3014 (static var case_count) Remove.
3015 (static var prev_case) Remove.
3016 (static var buf64_1xx) Remove.
3017 (static var buf_1xx) Remove.
3018 (struct agr_proc) New structure incorporating the above.
3019 (cmd_aggregate) Use new struct. Clean up error handling using
3020 agr_destroy(). Completely rewrite actual implementation of
3022 (create_sysfile) Add struct agr_proc * parameter, modify
3024 (parse_aggregate_functions) Ditto.
3025 (free_aggregate_functions) Ditto. Rename agr_destroy().
3026 (aggregate_single_case) Add struct agr_proc * parameter, modify
3028 (accumulate_aggregate_info) Ditto.
3029 (dump_aggregate_info) Ditto.
3030 (initialize_aggregate_info) Ditto.
3031 (agr_00x_trns_proc) Removed.
3032 (agr_00x_end_func) Removed.
3033 (agr_10x_trns_proc) Removed.
3034 (agr_10x_trns_free) Removed.
3035 (agr_10x_end_func) Removed.
3036 (agr_11x_read) Removed.
3037 (agr_11x_finish) Removed.
3038 [DEBUGGING] (debug_print) Removed.
3039 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3041 (agr_to_active_file) New function.
3042 (presorted_agr_to_sysfile) New function.
3043 (sort_agr_to_sysfile) New function.
3045 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3047 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3049 * descript.q: (cmd_descriptives) Ditto.
3051 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3052 to new procedure() interface.
3054 * command.c: (cmd_execute) Adapt to new procedure() interface.
3056 * dictionary.c: (dict_compact_values) Also delete scratch
3058 (dict_get_compacted_value_cnt) New function.
3059 (dict_get_compacted_idx_to_fv) New function.
3061 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3062 (cmd_flip) Adapt to new procedure() interface.
3063 (flip_sink_write) Use sink->idx_to_fv.
3065 * frequencies.q: (internal_cmd_frequencies) Use
3066 procedure_with_splits().
3068 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3069 (static var mtf_sink) New static var.
3070 (static var mtf_case) New static var.
3071 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3072 we actually implement the matching.
3073 (mtf_delete_file_in_place) Use mtf_case.
3074 (mtf_processing) Use mtf_case and mtf_sink.
3075 (cmd_export) Adapt to new procedure() interface.
3077 * levene.c: (levene) Use procedure_with_splits().
3079 * list.q: (cmd_list) Use procedure_with_splits().
3081 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3082 procedure() interface.
3083 (read_matrices_with_rowtype) Ditto.
3085 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3086 TEMPORARY. Adapt to new procedure() interface.
3088 * rename-vars.c: Warn about and cancel TEMPORARY.
3090 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3091 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3092 compaction_nval. Adapt to new procedure() interface. Use
3093 storage_source_to_disk().
3094 (do_internal_sort) Don't try to dump the cases to memory.
3095 (compare_case_lists) Pass null idx_to_fv.
3096 (struct initial_run_state) Add `idx_to_fv' member. Remove
3098 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3099 new procedure() interface. Reset irs->idx_to_fv after calling
3101 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3102 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3104 (destroy_initial_run_state) Don't dereference irs after freeing
3106 (allocate_cases) Don't calculate case_size locally.
3107 (compare_record) Add idx_to_fv parameter.
3108 (compare_record_run) Change parameter from struct sort_cases_pgm *
3109 to struct initial_run_state *. Pass irs->idx_to_fv to
3111 (compare_record_run) Third parameter now a struct
3112 initial_run_state *.
3113 (output_record) No need for out_case anymore. Pass irs, not
3114 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3116 (merge) Use case_size from struct sort_cases_pgm.
3117 (merge_once) Use case_size from struct sort_cases_pgm.
3118 Pass null pointer to compare_record() as idx_to_fv.
3119 (global var sort_sink_class) Make static.
3121 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3123 * temporary.c: Remove debugging crap.
3125 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3127 * t-test.q, levene.c: Fixed up the handling of MISSING values
3130 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3132 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3135 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3137 Change explicit variable name checks into use of
3138 dict_class_from_id().
3140 * dictionary.c: (dict_create_var) Change explicit variable name
3141 check into use of dict_class_from_id().
3143 * get.c: (trim_dictionary) Ditto.
3145 * sel-if.c: (cmd_filter) Ditto.
3147 * sysfile-info.c: (cmd_display) Ditto.
3149 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3151 * vfm.c: (arrange_compaction) Ditto.
3153 * weight.c: (cmd_weight) Ditto.
3155 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3157 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3158 transformation following the input program, if any, for some
3159 reason we special-cased f_trns. That's just wrong. It should
3160 always be set to n_trns.
3162 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3164 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3165 introduced in last check-in.
3167 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3169 * format.c: (global array translate_fmt[]) Removed.
3170 (translate_fmt) New function as replacement.
3171 (parse_format_specifier_name) Rewrite.
3173 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3176 * sfm-read.c: (parse_format_spec) Ditto.
3178 * postscript.c: (text) Fix handling of fonts with missing
3181 * sort.c: (struct external_sort) Add temp_name member.
3182 (destroy_external_sort) Free temp_dir, temp_name members.
3183 (init_external_sort) Allocate temp_name.
3184 (get_temp_file_name) Change prototype.
3185 (open_temp_file) Deal with change to get_temp_file_name().
3186 (close_temp_file) Ditto.
3187 (remove_temp_file) Ditto.
3188 (write_temp_file) Ditto.
3189 (read_temp_file) Ditto.
3190 (sort_sink_destroy) Removed.
3191 (sort_sink_class) Change destroy member to null.
3193 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3195 Eliminate temp_case.
3197 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3198 anymore. Use agr_11x_finish().
3199 (aggregate_single_case) Make first param const.
3200 (accumulate_aggregate_info) Ditto.
3201 (agr_00x_end_func) Use compaction_case, not temp_case.
3202 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3204 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3205 (cmd_data_list) Initialize case_size.
3206 (read_from_data_list_fixed) Add struct ccase * param, use instead
3208 (read_from_data_list_free) Ditto.
3209 (read_from_data_list_list) Ditto.
3210 (read_one_case) Rename data_list_trns_proc(), all references
3211 updated. Add argument in calling above functions. Use c
3212 argument instead of temp_case.
3213 (destroy_dls) Rename data_list_trns_free(), all references
3216 * expr-evl.c: (expr_evaluate) Make second parameter const.
3218 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3219 (cmd_end_file_type) Initialize `case_size'.
3220 (file_type_source_read) Add struct ccase * parameter. Use instead
3223 * flip.c: Rewritten.
3225 * get.c: (struct get_pgm) New structure to keep track of
3227 (cmd_get) Initialize case_size.
3229 (get_source) Deal with struct get_pgm.
3230 (get_source_read) Add struct ccase * parameter, use instead of
3232 (import_source_read) Ditto.
3234 * get.c: Use a null pointer instead of temp_case to represent the
3235 "current case" in a struct mtf_file's input member.
3236 (mtf_processing_finish) Pass null to mtf_processing(), not
3238 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3239 (mtf_compare_BY_values) Add extra arg, use instead of null input
3241 (mtf_processing) Use c parameter instead of temp_case. Pass
3242 compaction_case to process_active_file_output_case().
3244 * glob.c: (global variable temp_case) Removed.
3246 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3247 (cmd_input_program) Initialize case_size. Set
3248 vfm_source->value_cnt.
3249 (init_case) Add struct ccase * parameter, use instead of
3252 (input_program_source_read) Ditto.
3254 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3255 (dump_cell_content) Ditto.
3256 (nr_output_data) Ditto.
3257 (read_matrices_without_rowtype) Ditto.
3258 (matrix_data_read_with_rowtype) Ditto.
3259 (wr_read_splits) Ditto.
3260 (wr_output_data) Ditto.
3262 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3264 * sort.c: (sort_cases) Initialize scp->case_size.
3265 (struct external_sort) Remove `case_size' member.
3266 (write_initial_runs) Only call vfm_sink->class_destroy if
3268 (struct sort_source_aux) New structure.
3269 (sort_source_read_helper) New function.
3270 (sort_source_read) Use sort_source_read_helper().
3271 (read_sort_output) Change interface to be more reasonable.
3272 (read_internal_sort_output) Ditto.
3273 (read_external_sort_output) Ditto.
3275 * vars-prs.c: (dict_class_to_name) Pass return value through
3278 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3279 (procedure) Initialize trns_case.
3280 (procedure) Pass trns_case to vfm_source->class->read().
3282 (process_active_file) Start using struct procedure_aux_data.
3283 (process_active_file_write_case) Pass trns_case to
3284 transformations, lag_case(), clear_case().
3285 (process_active_file_output_case) Add struct ccase * parameter.
3286 (create_trns_case) New function.
3287 (make_temp_case) Removed.
3288 (vector_initialization) Removed.
3289 (close_active_file) Only call make_source if non-null, otherwise
3290 set vfm_source to null pointer. Don't free temp_case.
3291 (disk_source_read) Add struct ccase * parameter, use instead of
3293 (memory_source_read) Ditto.
3294 (lag_case) Add const struct ccase * member.
3295 (procedure_write_case) Use trns_case instead of temp_case.
3296 (clear_case) Add struct ccase * member, use instead of temp_case.
3297 (exclude_this_case) Ditto.
3298 (create_case_source) Add struct dictionary * parameter, use to
3299 initialize source->value_cnt.
3301 * vfm.h: (struct case_source) Add `value_cnt' member.
3302 (struct case_source_class) Add struct ccase * parameter to `read'
3303 member function pointer.
3304 (struct case_sink_class) Make struct ccase * parameter const in
3305 `write' member function pointer.
3307 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3309 Fix a lot of "possibly uninitialized variable" warnings. Some of
3310 them are even real bugs. A few of them make me wonder how the
3313 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3315 * ascii.c: (output_lines) Add default case to switch.
3317 * crosstabs.q: Remove static variable `expected' and all
3319 (display_crosstabulation) Always calculate expected value.
3321 (output_pivot_table) Initialize `cmp'.
3322 (display_crosstabulation) New variable `last_row', which is
3325 * data-in.c: (parse_numeric) Always initialize sign. How did this
3328 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3329 Always set info.ofs. (How did this work?!)
3331 * expr-opt.c: (optimize_tree) Always initialize `m'.
3332 (evaluate_tree) Always initialize `c'. (How did this work?)
3334 * frequencies.q: (frq_custom_variables) Always initialize min,
3336 (frq_custom_grouped) Always initialize `dl'.
3338 * groff-font.c: (groff_read_font) Always initialize char_set.
3340 * matrix-data.c: (nr_output_data) Initialize `split'.
3341 (wr_read_splits) Remove shadowing split_cnt declaration.
3342 (wr_output_data) Initialize `split'.
3344 * output.c: (tokener) Skip add character on syntax error.
3346 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3348 * postscript.c: (read_ps_encodings) Use line.string instead of
3350 (write_text) Add default case to switch.
3351 (text) Always initialize multiple variables. Fix bug with
3354 * print.c: (fixed_parse_fortran) Initialize head.
3355 (alloc_line) Add default case to switch.
3357 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3358 (recode_trns_proc) Move variable declaration inward. Add default
3361 * sfm-read.c: (read_header) Initialize skip_amt.
3363 * sysfile-info.c: (display_variables) Always initialize pc.
3365 * vars-prs.c: Initialized `included'.
3367 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3369 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3370 Just use signal() instead.
3372 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3374 Get rid of vfm_sink_info and vfm_source_info.
3376 * aggregate.c: (agr_00x_end_func) Don't increment
3377 sfm_sink_info.ncases.
3379 * sort.c: (do_internal_sort) Get case count from
3380 vfm_source->class->count().
3381 (struct external_sort) Add `case_size' member.
3382 (do_external_sort) Initialize case_size.
3383 (struct initial_run_state) Add `case_size' member.
3384 (write_initial_runs) Initialize case_size.
3385 (sort_sink_write) Use case_size.
3386 (read_external_sort_output) Use case_size. Get case_cnt from
3389 * vfm.c: (struct write_case_data) Add underscores to existing arg
3390 names, all references updated. Renamed `aux' as `func_aux', all
3391 references updated. Added new `aux' member.
3392 (global var vfm_source_info) Removed.
3393 (global var vfm_sink_info) Removed.
3394 (struct procedure_aux_data) New.
3395 (struct split_aux_data) New.
3396 (procedure) Use `aux' fields for procedure_aux_data,
3398 (process_active_file_write_case) Pass case_count + 1 to
3399 transformation procedures, exclude_this_case().
3400 (process_active_file_output_case) Don't increment
3401 vfm_sink_info.ncases.
3402 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3403 to send data to disk early.
3404 (make_temp_case) Don't use vfm_sink_info.case_size.
3405 (close_active_file) Don't initialize vfm_source_info.
3406 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3407 (disk_sink_create) Initialize and/or update disk_stream_info.
3408 (disk_sink_write) Ditto.
3409 (disk_sink_destroy) Ditto.
3410 (disk_sink_make_source) Ditto.
3411 (disk_source_read) Ditto.
3412 (disk_source_destroy) Ditto.
3413 (global var disk_source_class) Add disk_source_count().
3414 (disk_source_count) New function.
3415 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3416 (struct memory_source_info) Ditto.
3417 (memory_sink_create) Deal with case_cnt, case_size.
3418 (memory_sink_write) Ditto.
3419 (memory_sink_make_source) Ditto.
3420 (memory_source_read) Ditto.
3421 (memory_source_count) New function.
3422 (memory_source_class) Add memory_source_count().
3423 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3424 proc_aux->cases_written, and pass it to transformation procedures
3425 and exclude_this_case ().
3426 (exclude_this_case) Add case_num parameter. Pass it to
3428 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3431 * vfm.h: (struct case_source_class) Add `count' member.
3433 * vfmP.h: (struct stream_info) Removed.
3434 (global variable vfm_source_info) Removed.
3435 (global variable vfm_sink_info) Removed.
3437 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3439 * var.h: (typedef trns_proc_func) New typedef.
3440 (trns_free_func) New typedef.
3441 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3442 to type trns_free_func. This only changes the actual type of
3443 trns_proc_func, adding a `case_num' parameter. Updated all
3444 implementations to use the typedefs instead.
3446 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3447 (compute_num_vec) Ditto.
3448 (compute_str) Ditto.
3449 (compute_str_vec) Ditto.
3451 * do-if.c: (do_if_trns_proc) Ditto.
3453 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3456 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3457 pass to transformation functions.
3458 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3460 * loop.c: (loop_1_trns_proc) Ditto.
3461 (loop_2_trns_proc) Ditto.
3462 (loop_3_trns_proc) Ditto.
3464 * print.c: (print_space_trns_proc) Ditto.
3466 * sel-if.c: (select_if_proc) Ditto.
3468 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3470 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3471 destroying hash table.
3473 * glob.c: (read_active_file) Variable not referenced, removed.
3474 (cancel_input_pgm) Ditto.
3476 * levene.c: Add #include <stdlib.h> needed to call free().
3478 * aggregate.c: (parse_aggregate_functions) Make `function'
3481 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3483 Start working to eliminate VFM dependence on static variables.
3485 * command.c: (cmd_parse) Use case_source_is_class().
3487 * data-list.c: Rewrite to eliminate use of static variables.
3489 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3491 * file-handle.q: (fh_handle_name) Make parameter const.
3493 * file-type.c: Rewrite to eliminate use of static variables.
3495 * flip.c: Rewrite to eliminate use of static variables.
3497 * format.c: (get_format_var_width) New function.
3499 * get.c: Eliminate use of static variables.
3501 * inpt-pgm.c: Eliminate use of static variables.
3503 * matrix-data.c: Eliminate use of static variables.
3505 * set.q: (set_max_workspace) New variable.
3506 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3508 * var.h: (struct case_list) Move here from vfmP.h.
3510 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3512 * vfm.c: (vfm_source) Change type from struct case_stream to
3514 (vfm_sink) Change type from struct case_stream to struct
3516 (static var paging) Rename workspace_overflow, all references
3518 (procedure) Use new class structures.
3519 (process_active_file) Ditto.
3520 (process_active_file_write_case) Ditto.
3521 (prepare_for_writing) Use set_max_workspace. Use new class
3523 (close_active_file) Use new class structures. Free old sink.
3524 (global var disk_source_file) Removed.
3525 (global var disk_sink_file) Removed.
3526 (disk_stream_init) Removed.
3527 (disk_stream_read) Removed.
3528 (disk_stream_write) Removed.
3529 (disk_stream_mode) Removed.
3530 (disk_stream_destroy_source) Removed.
3531 (disk_stream_destroy_sink) Removed.
3532 (global var vfm_disk_stream) Removed.
3533 (disk_sink_create) New function.
3534 (disk_sink_write) New function.
3535 (disk_sink_destroy) New function.
3536 (disk_sink_make_source) New function.
3537 (disk_sink_class) New static var.
3538 (disk_source_read) New function.
3539 (disk_source_destroy) New function.
3540 (global var vfm_source_class) New var.
3541 (global var memory_source_cases) Removed.
3542 (global var memory_sink_cases) Removed.
3543 (global var memory_sink_max_cases) Removed.
3544 (struct memory_sink_info) New struct.
3545 (memory_stream_init) Removed.
3546 (memory_stream_read) Removed.
3547 (memory_stream_write) Removed.
3548 (memory_stream_mode) Removed.
3549 (memory_stream_destroy_source) Removed.
3550 (memory_stream_destroy_sink) Removed.
3551 (global var vfm_memory_stream) Removed.
3552 (page_to_disk) Renamed write_active_file_to_disk().
3553 (memory_sink_create) New function.
3554 (memory_sink_write) New function.
3555 (memory_sink_destroy) New function.
3556 (memory_sink_make_source) New function.
3557 (memory_sink_class) New static var.
3558 (memory_source_read) New function.
3559 (memory_source_destroy) New function.
3560 (memory_source_get_cases) New function.
3561 (memory_source_set_cases) New function.
3562 (global var vfm_source_class) New var.
3563 (procedure_write_case) Use new class structures.
3564 (create_case_source) New function.
3565 (case_source_is_complex) New function.
3566 (case_source_is_class) New function.
3567 (create_case_sink) New function.
3569 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3570 (global variable reinit_blanks) Not used, removed.
3571 (global variable init_zero) Not used, removed.
3572 (global variable init_blanks) Not used, removed.
3573 (struct case_source) New struct.
3574 (struct case_source_class) New struct.
3575 (struct case_sink) New struct.
3576 (struct case_sink_class) New struct.
3577 (struct case_stream) Removed.
3579 * vfmP.h: (struct case_list) Moved to var.h.
3581 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3583 * algorithm.c: (count_equal) New function.
3584 (count_if) New function.
3585 (unique) Add assertions.
3586 (partition) Add assertions.
3587 (is_partitioned) New function.
3588 (copy_if) Add assertions.
3589 (remove_equal) Add assertions.
3590 (lexicographical_compare) Rename lexicographical_compare_3way.
3591 (sort) Add assertions. Rephrase some code.
3592 (is_sorted) New function.
3594 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3598 * sort.c: Completely rewrite.
3600 * sort.h: Expose interface via struct sort_cases_pgm, not via
3603 * aggregate.c: (sort) New static var.
3604 (cmd_aggregate) Use sort.
3605 (create_sysfile) Ditto.
3606 (aggregate_single_case) Ditto.
3607 (dump_aggregate_info) Ditto.
3608 (agr_00x_end_func) Ditto.
3609 (debug_print) Ditto.
3611 * var.h: (enum SRT_ASCEND) Removed.
3612 (enum SRT_DESCEND) Removed.
3613 (struct sort_cases_proc) Removed.
3614 (struct variable) Remove p.srt member.
3616 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3618 Get rid of the old, crappy heap structure and replace it by a new,
3619 shiny, C++ STL-like heap structure.
3621 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3623 * algorithm.c: (push_heap) New function.
3634 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3636 Increase warning level.
3638 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3640 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3642 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3644 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3646 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3647 around by previous change log entry.
3649 * compute.c: (lvalue_finalize) Remove workaround from previous
3652 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3654 * compute.c: Fixed a bug where the Format was not getting set for
3655 computed variables (thus causing a crash when SAVEing).
3657 * Added a test to stop this bug ever coming back
3659 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3661 Got rid of approx.h. In general, replaced all references to
3662 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3665 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3667 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3668 test for mag < EPSILON.
3670 * misc.h: Add definition of EPSILON.
3672 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3674 * vfm.c: (procedure) Add check to prevent recursive call.
3676 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3678 * Moved the declarations relating to values to their own header file
3681 * Added levene.c and levene.h
3683 * vars-atr.c: Changed the signature of compare_values to
3684 take const * arguments.
3686 * t-test.q: Changed the structure of struct t_test_proc
3687 variables now contain their own group statistics information.
3688 Eventually, t_test_proc might get renamed, because it'd be
3689 applicable to other commands too.
3691 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3693 * data-out.c: Clean up. Changed interface of convert_*() to take
3694 either a `double' or a `const char *' instead of a `const union
3695 value *'. Update all implementations of those interfaces.
3696 (data_out) Use switch statements instead of a table.
3697 (convert_AHEX) Rewrite.
3699 * format.h: Update comment.
3701 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3703 * q2c.c: (dump_header) Add an Emacs header line to output files
3704 that makes generated .c files read-only by default, to make it
3705 difficult to accidentally change generated files.
3707 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3709 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3710 not bogus a->v.c <=> b->v.c pointer compare.
3711 (compare_freq_alpha_a) Ditto.
3712 (compare_freq_numeric_d) Ditto.
3713 (compare_freq_alpha_d) Ditto.
3715 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3717 Changed data_out() to store string data directly into a `union
3718 value''s s member, not indirectly into c.
3720 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3722 (table_value_missing) Ditto.
3723 (float_M_suffix) Ditto.
3724 (format_short) New function.
3726 * data-in.h: (data_in_finite_line) Remove inline definition.
3728 * data-list.c: (destroy_dls_var_spec) New function.
3729 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3730 (data_list_source_destroy_source) Avoid cast.
3731 (struct repeating_data_trns) New field `id_value'. Update
3733 (cmd_repeating_data) Initialize id_value. Use new
3734 repeating_data_trns_free() for freeing REPEATING DATA
3736 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3737 (repeating_data_trns_free) New function.
3739 * data-out.c: (data_out) Change return type to `void' by replacing
3740 error returns by writing a message into the output buffer.
3741 (convert_A) Read from v->s instead of v->c.
3742 (convert_AHEX) Ditto.
3744 * expr-evl.c: Update comment.
3745 (expr_evaluate) Add assertion in OP_STRING case.
3747 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3749 * list.q: (list_cases) Update for new data_out() semantics.
3751 * print.c: (print_trns_proc) Ditto.
3753 * tab.c: (tab_value) Ditto.
3754 (tab_float) Avoid stupid cast.
3756 * var.h: Update comments.
3757 (macro MAX_STRING) New macro.
3758 (macro MAX_ELEMS_PER_VALUE) New macro.
3760 * vars-atr.c: (compare_values) New function.
3762 * vfm.c: (dump_splits) Update for new data_out() semantics.
3764 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3766 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3768 (struct crosstab) Rename v[] to vars[]. All references updated.
3769 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3770 same time, which caused the hash value to depend only on a single
3771 value, not all of the variables' values.
3773 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3775 Clean up struct dictionary's value_cnt usage.
3777 * dictionary.c: Add a function comment to each function.
3778 (struct dictionary) Rename value_cnt to next_value_idx, which more
3779 accurately reflects its meaning. All references updated.
3780 (dict_rename_vars) Add assertion.
3781 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3783 (dict_get_case_size) New function.
3785 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3787 * get.c: (mtf_read_nonactive_records) Ditto.
3789 * sort.c: (allocate_cases) Ditto.
3790 (write_initial_runs) Ditto.
3794 * vfm.c: (prepare_for_writing) Ditto.
3798 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
3800 Make vfm.c slightly less grotesque.
3802 * vfm.c: (filter_var) Removed.
3803 (filter_index) Removed.
3804 (FILTERED macro) Removed.
3805 (exclude_this_case) New function.
3806 (process_active_file_write_case) Use exclude_this_case() instead
3807 of FILTERED and inline tests.
3808 (procedure_write_case) Ditto.
3809 (setup_filter) Removed.
3810 (open_active_file) Don't call setup_filter().
3811 (close_active_file) Call dict_get_filter() instead of checking
3814 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
3816 * var.h: (struct variable) Update comments.
3818 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
3820 New functions dict_create_var_assert(), dict_lookup_var_assert().
3821 Converted several dict_*_var()/assert pairs into a single
3822 dict_*_var_assert().
3824 * dictionary.c: (dict_create_var_assert) New function.
3825 (dict_lookup_var_assert) New function.
3827 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
3829 Got rid of "struct long_vec", envector(), devector(), etc. Added
3830 two members `init', `reinit' to struct variable as a substitute.
3832 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
3838 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
3841 * autorecode.c: (cmd_autorecode) destvars don't need init.
3843 * compute.c: (lvalue_finalize) Set reinit.
3845 * data-list.c: (fixed_parse_compatible) Don't need init usually.
3846 (dump_fmt_list) Ditto.
3849 * descript.q: (run_z_pass) Don't need init for z-scores.
3851 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
3853 (dict_clone_var) Copy `reinit' member, initialize `init' member.
3855 * glob.c: (init_glob) Remove vec_init() calls.
3857 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
3859 * loop.c: (internal_cmd_loop) Don't need to call envector().
3861 * numeric.c: (cmd_numeric) Ditto.
3863 (cmd_leave) Ditto. Set `init', `reinit' members.
3865 * recode.c: (cmd_recode) Don't need to call envector().
3867 * repeat.c: (internal_cmd_do_repeat) Ditto.
3869 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
3870 (force_create_variable) Removed prototype.
3871 (force_dup_variable) Ditto.
3873 * vector.c: (cmd_vector) Don't need to call envector().
3875 * vfm.c: (reinit_sysmis) Removed.
3876 (reinit_blanks) Removed.
3877 (init_zero) Removed.
3878 (init_blanks) Removed.
3879 (process_active_file_write_case) No need to deal with vectors.
3880 Call clear_temp_case().
3881 (vector_initialization) Rewrite to use `init', `reinit'.
3882 (close_active_file) No need to call vec_clear().
3883 (procedure_write_case) Call clear_temp_case().
3884 (clear_temp_case) New function.
3886 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
3888 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
3891 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
3893 Add auxiliary argument to procedure() interface. Associated small
3894 clean-ups of vfm interface.
3896 * Updated every caller of procedure() and process_active_file() to
3897 reflect modified interface. Simple, ordinary changes not listed
3900 * Updated every function that implements struct case_stream's
3901 `read' function to take a write_case_func and a write_case_data.
3902 Also updated every caller of write_case() to instead call them
3903 through these arguments. In some cases this meant that the extra
3904 args had to be threaded through a couple of extra levels. This
3905 wasn't difficult or interesting so the details won't be given.
3907 * data-list.c: (struct repeating_data_trns) Add members
3908 `write_case', `wc_data' as kluge.
3909 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
3911 (repeating_data_set_write_case) New function.
3913 * data-list.h: New file to declare repeating_data_trns_proc() and
3914 repeating_data_set_write_case().
3916 * inpt-pgm.c: (input_program_source_read) Call
3917 repeating_data_set_write_case() for all the REPEATING DATA
3918 transformations, so that they know where to send their cases.
3919 It's a big kluge. Also kluge in END CASE.
3920 (end_case_trns_proc) Never called anymore, but we still need it,
3923 * sort.c: (read_sort_output) Update to match struct case_stream
3926 * vfm.c: (struct write_case_data) New structure.
3927 (proc_func) Removed.
3928 (virt_proc_func) Removed.
3929 (begin_func) Removed.
3930 (virt_begin_func) Removed.
3932 (write_case) Removed.
3933 (procedure) Added an auxiliary parameter to each function pointer
3934 argument's prototype. Added an auxiliary data parameter.
3936 (process_active_file) Ditto.
3937 (process_active_file_write_case) Pass aux data along.
3938 (close_active_file) Ditto.
3939 (procedure_write_case) Ditto.
3940 (SPLIT_FILE_procfunc) Ditto.
3942 * vfm.h: (typedef write_case_data) New.
3943 (typedef write_case_func) New.
3944 (struct case_stream) Add parameters to `read' member prototype.
3946 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
3948 * t-test.q: Added calculations for independent samples. (But no Levene
3951 * Makefile.am: Moved q_sources_c into own variable
3953 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
3955 Miscellaneous cleanups.
3957 * Change unused to UNUSED in many source files to reflect modified
3958 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
3959 __CYGWIN32__, __unix__, and unix not to assume that they're
3960 defined to a nonzero value. Change use of __attribute__ to use
3961 NO_RETURN or PRINTF_FORMAT instead.
3963 * alloc.h: Move definitions for local_alloc(), local_free() here
3964 from ../pref.h.orig and simplify.
3966 * expr-evl.c: Instead of working differently based on PAGED_STACK,
3967 use a pool allocator unconditionally.
3968 (CHECK_STRING_SPACE) Removed.
3969 (ALLOC_STRING_SPACE) Removed.
3970 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
3973 * expr-opt.c: (dump_expression) Allocate string pool.
3975 * expr-prs.c: (expr_free) Free string pool.
3977 * pool.c: (pool_destroy) This pool must be removed from its
3978 parent's list of gizmos, not from its own. Use free_all_gizmos().
3979 (pool_clear) New function.
3980 (free_all_gizmos) New function.
3981 (pool_alloc) Use space in empty block after this one if any.
3982 (pool_release) Only empty out blocks, don't actually free() them.
3984 * print.c: Get rid of PAGED_STACK special case by always
3985 dynamically allocating line buffers.
3986 (struct print_trns) Always include the `line' member.
3987 (internal_cmd_print) Always initialize the `line' member.
3988 (alloc_line) Always allocate memory for `line'.
3989 (print_trns_proc) Always initialize buf from `line' member.
3990 (print_trns_free) Always free `line' memory.
3992 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
3995 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
3997 * flip.c: Fixed crash from FLIP when a numeric variable is
3998 specified on NEWNAMES and a large value is used, and a couple of
3999 other minor bugs besides.
4000 (struct varname) Make name a 9-character fixed-size array
4001 instead of a 1-character variable size array.
4002 (make_new_var) Allow digits in variable names.
4003 (flip_stream_write) Limit numeric values to 8 characters and
4004 format system missing and very large and small values more
4007 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4009 * command.c: Fixed test on command return status for the correct
4010 value, which had been causing a crash under certain invalid input.
4012 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4014 * t-test.q: Added calculations for the one sample variant of the T-TEST
4016 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4018 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4019 in joined cells to be rendered outside box boundaries.
4021 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4023 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4024 SET seed=xx has been called.
4026 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4028 * random.c (rng_get_double): Fix always-returning-zero bug in my
4029 preferred way, and at the same time make sure rounding doesn't
4032 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4034 * html.c: (change_attributes) Dead code, removed.
4035 (escape_string) Eliminate code to call change_attributes() that
4036 never actually called it.
4037 (output_tab_table) Get rid of dependence on tab_hit
4038 and struct tab_joined_cell's hit member, which are abominations.
4040 * tab.c: (tab_output_text) Don't call
4041 d->class->text_set_font_by_name if it's a null pointer.
4042 (macro UNROLL_LOOP) Eliminate.
4043 (macro UNROLL_3_LOOPS) Eliminate.
4044 (tabi_render) Rewrite not to use the above macros.
4046 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4048 Start working on a new output driver system, one that doesn't suck
4049 so much, by adding a "device-independent" output driver. The idea
4050 is to write out only a single output stream, then use separate
4051 processes to translate them into whatever formats we want. This
4052 is similar to how "groff" works with its various output drivers
4053 (grops, grotty, grodvi, ...).
4055 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4057 * list.q: (write_all_headers) Stub out devind class.
4059 (determine_layout) Ditto.
4062 * output.c: (outp_init) Add devind class.
4064 * devind.c: New file.
4066 * devind.h: New file.
4068 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4070 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4071 to use the proper string length.
4073 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4075 * Fixed bug where FREQ would crash on alpha values
4077 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4079 * Removed bletcherous alloca() workarounds for AIX from top of
4080 many files. AIX can use the alternative alloca() implementation
4083 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4085 * ascii.c: (ascii_option) Fix implementation of headers option.
4087 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4089 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4090 multiple blank lines into one.
4091 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4092 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4093 (static var option_tab) Add squeeze entry.
4094 (ascii_option) Set squeeze_blank_lines.
4095 (output_lines) Implement squeezing blank lines.
4097 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4099 * Removed redundant code from output.h
4101 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4103 Dictionary classes: each variable is "ordinary", "system", or
4106 * var.h: (enum dict_class) New enum.
4108 * vars-prs.c: (dict_class_from_id) New function.
4109 (dict_class_to_name) New function.
4111 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4113 * var.h: (struct freq_tab_set) Removed (not used).
4115 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4117 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4119 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4121 * stats.c: (hypercube) Rename pow4(). All references updated.
4123 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4125 * rename-vars.c: (cmd_rename_variables) Rewritten.
4126 (compare_name) Removed.
4128 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4130 var_set feature, and code taking advantage of it.
4132 * crosstabs.q: (static var var_dict) Removed.
4133 (static var variables) New variable.
4134 (static var variables_cnt) New variable.
4135 (cmd_crosstabs) Free variables instead of var_dict.
4136 (internal_cmd_crosstabs) Initialize and use variables,
4137 variables_cnt instead of var_dict.
4138 (free_var_dict) Removed.
4139 (crs_custom_tables) Use var_set instead of a copied dictionary.
4140 (crs_custom_variables) Set up variables, variables_cnt instead of
4142 [DEBUGGING] (debug_print) Ditto.
4144 * means.q: (mns_custom_tables) Use var_set instead of a copied
4147 * vars-prs.c: (parse_vs_variable) New function.
4148 (parse_dict_variable) Rewritten.
4149 (parse_variable) Rewritten.
4150 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4151 (parse_variables) New function in terms of parse_var_set_vars().
4152 Now requires its first argument to be non-null. All references
4153 that passed a null pointer updated to pass default_dict instead.
4154 (macro id_dict) Removed.
4155 (parse_DATA_LIST_vars) Add assertions.
4156 (parse_mixed_vars) Ditto.
4157 (struct var_set) New structure.
4158 (var_set_get_cnt) New function.
4159 (var_set_get_var) New function.
4160 (var_set_lookup_var) New function.
4161 (var_set_destroy) New function.
4162 (dict_var_set_get_cnt) New function.
4163 (dict_var_set_get_var) New function.
4164 (dict_var_set_lookup_var) New function.
4165 (dict_var_set_destroy) New function.
4166 (var_set_create_from_dict) New function.
4167 (struct array_var_set) New structure.
4168 (array_var_set_get_cnt) New function.
4169 (array_var_set_get_var) New function.
4170 (array_var_set_lookup_var) New function.
4171 (array_var_set_destroy) New function.
4172 (var_set_create_from_array) New function.
4174 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4175 instead of parse_variables(NULL, ...) in output code.
4177 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4179 Change inp_init from a 2-bit vector to an ordinary array.
4180 Initialize it all in cmd_end_input_program() instead of in
4183 * inpt-pgm.c: (enum value_init_type) New enum.
4184 (global var inp_init) Change to `enum value_init_type *', make
4186 (inp_init_size) Removed.
4187 (inp_nval) Change to `size_t', make static.
4188 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4189 (cmd_end_input_program) Initialize inp_init, inp_nval.
4190 (init_case) Rewrite.
4191 (clear_case) Rewrite.
4193 * inpt-pgm.h: Removed.
4195 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4197 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4198 Colin Plumb hash. It is simpler and should better resist
4200 (hsh_hash_string) Ditto.
4202 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4204 * get.c: (export_write_case_func) Remove debug printing code.
4206 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4208 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4210 (save_write_case_func) Use &trns->h instead of cast.
4211 (cmd_export) Use &t->h instead of cast.
4213 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4215 Moved vectors into the dictionary.
4217 * var.h: (struct vector) Moved here from vector.h. `index' member
4218 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4221 * vector.h: Removed.
4223 * vector.c: (global var vec) Removed.
4224 (global var nvec) Removed.
4225 (cmd_vector) Rewritten.
4226 (find_vector) Removed.
4228 * dictionary.c: (dict_create_vector) New function.
4229 (dict_get_vector) New function, replaces reading global vec[]
4231 (dict_get_vector_cnt) New function, replaces reading global nvec
4233 (dict_lookup_vector) New function, replaces find_vector().
4234 (dict_clear_vectors) New function.
4236 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4238 Start to move away from `struct variable' p `union' member to void
4241 * var.h: (struct variable) Add `aux' member.
4243 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4245 Get rid of struct variable `foo' member.
4247 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4249 (frq_custom_variables) Ditto.
4250 (frq_custom_grouped) Ditto.
4252 * get.c: (struct save_trns) Change `var' member from `int *' to
4253 `struct variable **'.
4254 (cmd_save_internal) Use aux instead of foo.
4255 (save_trns_proc) Use revised `var' member.
4256 (static var mtf_seq_no) Renamed mtf_seq_num.
4257 (static var mtf_seq_nums) New static var.
4258 (cmd_match_files) Initialize mtf_seq_nums.
4259 (mtf_free) Free mtf_seq_nums.
4260 (mtf_processing) Use mtf_seq_nums instead of foo.
4261 (mtf_merge_dictionary) No need to initialize mv->foo.
4262 (cmd_export) Use aux instead of foo. Use revised `var' member.
4263 (mns_custom_tables) Don't use foo to check for duplicates, that's
4264 what PV_NO_DUPLICATE is for.
4266 * var.h: (struct variable) Remove `foo' member.
4267 (struct frequencies_proc) New member.
4269 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4271 Clean up COMPUTE and IF.
4273 * compute.c: More or less rewrite the darn thing.
4274 (struct compute_trns) Rename and reorder and add and delete
4276 (cmd_compute) Rewrite.
4277 (compute_num) Make conditional on test expression. Now used for
4278 both COMPUTE and IF.
4279 (compute_num_vec) Ditto.
4280 (compute_str) Ditto.
4281 (compute_str_vec) Ditto.
4284 (if_num_vec) Removed.
4286 (if_str_vec) Removed.
4287 (parse_target_expression) Renamed parse_rvalue_expression(),
4289 (new_trns) Renamed compute_trns_create(), rewritten.
4290 (delete_trns) Removed.
4291 (free_trns) Renamed compute_trns_free(), rewritten.
4292 (struct lvalue) New structure.
4293 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4294 (lvalue_get_type) New function.
4295 (lvalue_is_vector) New function.
4296 (lvalue_finalize) New function.
4297 (lvalue_destroy) New function.
4299 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4301 * command.def: Disallow MODIFY VARS in input mode, so that
4302 variables can't get dropped and confuse cmd_end_input_program()'s
4303 attempt to fill inp_init[].
4305 * modify-vars.c: (static var forward_positional_ordering) New
4307 (struct var_modification) Entirely changed.
4308 (rearrange_dict) Interface changed, rewritten.
4309 (cmd_modify_vars) Deal with modified struct var_modification, much
4311 (struct var_renaming) New structure.
4312 (compare_var_renaming_by_new_name) New function.
4313 (validate_var_modification) New function.
4315 * var.h: (struct modify_vars_proc) Removed.
4316 (struct variable) Removed member p.mfv.
4318 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4320 Make EVALUATE a valid command whether we're debugging or not, so
4321 that `make check' can succeed regardless of whether debugging is
4324 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4326 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4328 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4330 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4331 statement by a simple if test.
4333 * dfm.c: (dfm_get_record) Add assertion.
4335 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4337 For each file x.c, move #include "x.h" to the very top of the
4338 include list, to catch x.h failing to include the proper headers.
4340 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4342 * algorithm.c: (find) New function.
4343 (remove_equal) New function.
4344 (set_difference) New function.
4345 (adjacent_find_equal) New function.
4346 [TEST_UNIQUE] Removed test case.
4347 (copy_if) Find end test.
4349 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4351 * dictionary.c: (dict_get_case_weight) New convenience function.
4353 * aggregate.c: (accumulate_aggregate_info) Use
4354 dict_get_case_weight().
4356 * frequencies.q: (calc_general) Ditto.
4357 (calc_integer) Ditto.
4360 * t-test.q: (groups_calc) Ditto.
4363 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4365 * glob.c: (global var default_dict) Change from `struct
4366 dictionary' to `struct dictionary *'. All references changed.
4367 (init_glob) Initialize default_dict with dict_create().
4369 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4371 struct dictionary now made opaque. All related functions:
4373 * get.c: (rename_variables) Removed.
4374 (dict_delete_run) Removed.
4376 * temporary.c: (copy_variable) Removed.
4377 (new_dictionary) Removed.
4378 (save_dictionary) Removed.
4379 (restore_dictionary) Removed.
4380 (free_dictionary) Removed.
4382 * vars-atr.c: (clear_default_dict) Removed.
4383 (find_variable) Removed.
4384 (find_dict_variable) Removed.
4385 (create_variable) Removed.
4386 (delete_variable) Removed.
4387 (common_init_stuff) Removed.
4388 (init_variable) Removed. Updating of inp_init moved into
4389 cmd_end_input_program().
4390 (replace_variable) Removed.
4391 (rename_variable) Removed.
4392 (clear_variable) Removed.
4393 (dup_variable) Removed.
4395 * vars-prs.c: (is_varname) Removed.
4396 (is_dict_varname) Removed.
4397 (fill_all_vars) Removed.
4399 * vector.c: (find_vector) Removed.
4401 * weight.c: (stop_weighting) Removed.
4403 * dictionary.c: New file.
4404 (dict_create) New, replaces new_dictionary().
4405 (dict_clone) New, replaces save_dictionary() and
4406 restore_dictionary().
4407 (dict_clear) New, replaces clear_default_dict().
4408 (dict_destroy) New, replaces free_dictionary().
4409 (dict_get_var_cnt) New function, replaces references to
4411 (dict_get_var) New function, replaces references to dict->var[i].
4412 (dict_get_vars) New function, replaces fill_all_vars().
4413 (dict_create_var) New, replaces create_variable(). Interface
4414 drops `type' parameter, using a zero `width' to designate numeric.
4415 (dict_clone_var) New, replaces dup_variable().
4416 (dict_rename_var) New, replaces rename_variable().
4417 (dict_lookup_var) New, replaces find_variable(),
4418 find_dict_variable(), is_varname().
4419 (dict_contains_var) New function.
4420 (compare_variable_dblptrs) New function.
4421 (dict_delete_var) New function, replaces clear_variable().
4422 (dict_delete_vars) New function, replaces dict_delete_run().
4423 (dict_reorder_vars) New function.
4424 (dict_rename_vars) New function, replaces rename_variables().
4425 (dict_get_weight) New function, replaces reading dict->weight_var.
4426 (dict_set_weight) New function, replaces writing dict->weight_var
4427 or calling stop_weight(dict).
4428 (dict_get_filter) New function, replaces reading dict->filter_var.
4429 (dict_set_filter) New function, replaces writing dict->filter_var.
4430 (dict_get_case_limit) New function, replaces reading dict->N.
4431 (dict_set_case_limit) New function, replaces writing dict->N.
4432 (dict_get_value_cnt) New function, replaces reading dict->nval.
4433 (dict_compact_values) New function, replaces a loop that was
4434 replicated in several places.
4435 (dict_get_split_vars) New function, replaces reading dict->splits.
4436 (dict_get_split_cnt) New function, replaces reading
4438 (dict_set_split_vars) New function, replaces writing dict->splits.
4439 (dict_get_label) New function, replaces reading dict->label.
4440 (dict_set_label) New function, replaces writing dict->label.
4441 (dict_get_documents) New function, replaces reading
4443 (dict_set_documents) New function, replaces writing
4446 All references to above functions updated.
4448 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4449 old dictionary to new by hand, because dict_create() can't do it
4450 itself. Use dict_set_documents(), dict_set_split_vars().
4452 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4453 calling dict_destroy().
4455 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4457 (fixed_parse_compatible) Some slightly nontrivial changes for
4459 (dump_fmt_list) Ditto.
4462 * file-type.c: (create_col_var) Ditto.
4464 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4465 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4466 (rename_variables) Use dict_rename_vars().
4467 (mtf_merge_dictionary) Use dict_get_documents(),
4468 dict_set_documents(), dict_compact_values().
4470 * pfm-read.c: (read_variables) Deal with changes to weighting.
4472 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4473 is_varname() in output code.
4475 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4476 other dictionary functions.
4478 * title.c: (add_document_line) Use dict_get_documents(),
4479 dict_set_documents().
4481 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4482 reset default_handle by hand. dict_clear() will clear vectors so
4483 there's no need for that by hand.
4485 * vfm.c: (close_active_file) Move call to finish_compaction()
4486 earlier, so that we can do the compaction as a single step using
4487 dict_compact_values(). Use dict_clear_vectors().
4488 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4490 Some functions don't have replacements:
4492 * vars-atr.c: (force_create_variable) Removed. All references
4493 updated to dict_create_var() followed by an assertion.
4494 (force_dup_variable) Removed. All references updated to
4495 dict_clone_var() followed by an assertion.
4497 * weight.c: (update_weighting) Removed. No longer necessary, so
4498 all references removed.
4500 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4504 * aggregate.c: Eliminate separation of weighted and unweighted
4505 case. It made the code too obscure and I doubt it was actually
4506 faster. Instead, all code uses the "weighted" code, because
4507 that's a generalization of the "unweighted" code.
4510 (parse_aggregate_functions) No need to set FWEIGHT.
4511 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4512 (dump_aggregate_info) Ditto.
4513 (initialize_aggregate_info) No need for special plain_function
4514 that gets rid of FWEIGHT option.
4516 * aggregate.c: Get rid of approximations.
4517 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4519 (aggregate_single_case) Don't use approx_ne().
4521 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4523 * ascii.c (ascii_line_width): Dead code, removed.
4525 * postscript.c (ps_line_width): Ditto.
4527 * q2c.c (xrealloc): Ditto.
4529 * count.c (internal_cmd_count): Ditto.
4531 * means.q (validate_dependent_endpoint): Ditto.
4533 * set.q: (cmd_gset) Ditto.
4535 * weight.c: [0] (weight_trns_proc) Ditto.
4537 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4539 Make the code -Wmissing-prototypes clean.
4541 * Makefile.am (version.c): Add #include "version.h".
4543 * ascii.c: (ascii_open_global) Make static.
4544 (ascii_close_page) Ditto.
4545 (ascii_font_sizes) Ditto.
4546 (ascii_postopen_driver) Ditto.
4547 (ascii_close_driver) Ditto.
4548 (ascii_option) Ditto.
4549 (ascii_open_page) Ditto.
4550 (ascii_line_horz) Ditto.
4551 (ascii_line_vert) Ditto.
4552 (ascii_line_intersection) Ditto.
4554 (ascii_polyline_begin) Ditto.
4555 (ascii_polyline_point) Ditto.
4556 (ascii_polyline_end) Ditto.
4557 (ascii_text_set_font_by_name) Ditto.
4558 (ascii_text_set_font_by_position) Ditto.
4559 (ascii_text_set_font_by_family) Ditto.
4560 (ascii_text_get_font_name) Ditto.
4561 (ascii_text_get_font_family) Ditto.
4562 (ascii_text_set_size) Ditto.
4563 (ascii_text_get_size) Ditto.
4564 (ascii_text_metrics) Ditto.
4565 (ascii_text_draw) Ditto.
4566 (ascii_close_page) Ditto.
4568 * cmdline.h: New header for parse_command_line(). Used where
4571 * command.c: Move prototypes for cmd_*() functions to command.h.
4573 * command.h: Prototypes for cmd_*() functions moved here from
4576 * crosstabs.q: (gamma_int) Ditto.
4578 * file-handle.h: Add fh_init_files() prototype.
4580 * getline.c: (welcome) Ditto.
4582 * glob.h: New header for init_glob(). Used where appropriate.
4584 * hash.c: (comparison_helper) Ditto.
4586 * html.c: (html_open_global) Ditto.
4587 (html_close_global) Ditto.
4588 (html_preopen_driver) Ditto.
4589 (html_postopen_driver) Ditto.
4590 (html_close_driver) Ditto.
4591 (html_option) Ditto.
4592 (html_open_page) Ditto.
4593 (html_close_page) Ditto.
4594 (html_submit) Ditto.
4596 * inpt-pgm.c: (input_program_source_read) Ditto.
4598 * output.c: (find_defn_value) Ditto.
4599 (destroy_list) Ditto.
4601 * pfm-read.c: (read_int) Ditto.
4603 * postscript.c: (ps_open_global) Ditto.
4604 (ps_close_global) Ditto.
4605 (ps_font_sizes) Ditto.
4606 (ps_preopen_driver) Ditto.
4607 (ps_postopen_driver) Ditto.
4608 (ps_close_driver) Ditto.
4610 (ps_open_page) Ditto.
4611 (ps_close_page) Ditto.
4612 (ps_line_horz) Ditto.
4613 (ps_line_vert) Ditto.
4614 (ps_line_intersection) Ditto.
4616 (ps_polyline_begin) Ditto.
4617 (ps_polyline_point) Ditto.
4618 (ps_polyline_end) Ditto.
4619 (ps_text_set_font_by_name) Ditto.
4620 (ps_text_set_font_by_position) Ditto.
4621 (ps_text_set_font_family) Ditto.
4622 (ps_text_get_font_name) Ditto.
4623 (ps_text_get_font_family) Ditto.
4624 (ps_text_set_size) Ditto.
4625 (ps_text_get_size) Ditto.
4626 (ps_text_metrics) Ditto.
4627 (ps_text_draw) Ditto.
4629 * q2c.c: (finish_up) Ditto.
4638 (find_symbol) Ditto.
4641 (force_string) Ditto.
4643 (match_token) Ditto.
4646 (parse_setting) Ditto.
4647 (parse_specifier) Ditto.
4648 (parse_specifiers) Ditto.
4649 (parse_subcommand) Ditto.
4650 (dump_specifier_vars) Ditto.
4652 (make_identifier) Ditto.
4653 (dump_declarations) Ditto.
4654 (dump_specifier_init) Ditto.
4655 (dump_vars_init) Ditto.
4657 (dump_specifier_parse) Ditto.
4658 (dump_subcommand) Ditto.
4659 (dump_parser) Ditto.
4660 (dump_header) Ditto.
4662 (recognize_directive) Ditto.
4664 * recode.c: (string_to_long) Ditto.
4666 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4668 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4671 * sort.c: (sort_stream_read) Ditto.
4672 (sort_stream_mode) Ditto.
4674 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4676 * algorithm.c (binary_search): Fix comparison.
4678 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4680 * algorithm.c: (binary_search) Fix assertion.
4682 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4684 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4686 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4688 * sort.c: (compare_case_lists) Rewrite.
4690 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4692 * quicksort.c: Removed (not used).
4694 * quicksort.h: Removed (not used).
4696 * sort.c: Removed blp_quicksort() prototype.
4698 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4700 * postscript.c: (int_2_compare) Rewrite.
4701 (compare_line) Rewrite.
4703 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4705 * matrix-data.c (compare_factors) Use lexicographical_compare()
4707 (compare_doubles) New function.
4709 * algorithm.c: (lexicographical_compare) New algorithm.
4711 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4713 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4715 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4717 * expr-prs.c: (cmp_func) Removed.
4718 (parse_function) Use binary_search() algorithm.
4719 (compare_functions) New function.
4720 (init_func_tab) Use sort() algorithm.
4722 * algorithm.c: (binary_search) New algorithm.
4724 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4726 * descript.q: (display) Use sort() algorithm instead of qsort().
4727 (compare_func) Removed.
4728 (descriptives_compare_variables) New function.
4730 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4732 Get rid of AVL trees. Hashes are more appropriate for everything
4735 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4741 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4743 Much code can be clarified by using C++ STL-like algorithms. Not
4744 all uses of these algorithms are listed below, only the ones where
4745 the change to an algorithm was the only change of interest.
4747 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4749 * algorithm.c: New file.
4751 * algorithm.h: New file.
4753 * modify-vars.c: (static var forward) Removed.
4754 (static var positional) Removed.
4755 (compare_variables) Removed.
4756 (struct ordering) New.
4757 (cmd_modify_vars) Use sort() algorithm.
4758 (compare_variables_given_ordering) New function.
4759 (rearrange_dict) Use sort() algorithm.
4761 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4762 (cmp_var_by_name) Removed.
4764 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4766 Make file handles use a hash table.
4768 * file-handle.q: (files) Change to hash table, make static.
4769 (cmd_file_handle) Use hash table functions.
4770 (fh_get_handle_by_filename) Ditto.
4771 (fh_get_handle_by_name) Ditto.
4772 (hash_file_handle) New function.
4773 (cmp_file_handle) Rewrite.
4774 (fh_init_files) Use hash table functions.
4776 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4778 Clean up FREQUENCIES.
4780 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4782 * frequencies.q: Remove a lot of old #if'd out code at the end.
4783 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4784 or calc_weight(). Initialize percentile_values.
4785 (calc) New function based on calc_weight() from frequencies.g.
4786 (precalc) Use hash functions.
4787 (static var comparison_func) Removed.
4788 (static var comparison_param) Removed.
4789 (comparison_helper) Removed.
4790 (get_freq_comparator) New function.
4791 (not_missing) New function.
4793 (postprocess_freq_tab) Use hash table functions, algorithms,
4794 get_freq_comparator(). Rewrite.
4795 (cleanup_freq_tab) Rephrase.
4796 (add_percentile) Clean up spacing.
4797 (hash_value_numeric) New function.
4798 (hash_value_alpha) New function.
4799 (compare_value_numeric_a) Rewrite.
4800 (compare_value_alpha_a) Rewrite.
4801 (compare_value_numeric_d) Rewrite.
4802 (compare_value_alpha_d) Rewrite.
4803 (compare_freq_numeric_a) Rewrite.
4804 (compare_freq_alpha_a) Rewrite.
4805 (compare_freq_numeric_d) Rewrite.
4806 (compare_freq_alpha_d) Rewrite.
4807 (calc_stats) Clean up mode, percentiles, max.
4808 (dump_statistics) Clean up spacing.
4810 * frequencies.g: Removed.
4812 * var.h: (struct freq_tab) Change `data' to hash table.
4814 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
4816 * file-handle.h: Remove declaration of global variable `files',
4817 which wasn't used anywhere.
4819 * postscript.c: (add_encoding) Remove superfluous cast.
4822 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
4825 * temporary.c: [0] (display_tree) Removed.
4827 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
4829 Implement a new random number generator based on the alleged RC4
4832 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
4835 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
4836 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
4838 (static var V[]) Removed.
4839 (static var Y) Removed.
4840 (static var X2) Removed.
4841 (setup_randomize) Removed.
4843 (rand_uniform) Removed.
4844 (rand_normal) Removed.
4845 (struct rng) New structure.
4846 (rng_create) New function.
4847 (rng_destroy) New function.
4848 (swap_byte) New static function.
4849 (rng_seed) New function.
4850 (rng_get_bytes) New function.
4851 (rng_get_int) New function.
4852 (rng_get_unsigned) New function.
4853 (rng_get_double) New function.
4854 (rng_get_double_normal) New function.
4855 (pspp_rng) New function.
4857 * random.h: Sync up to random.c.
4859 * sample.c: (struct sample_trns) Make `frac' unsigned and a
4860 fraction of UINT_MAX, not 65536.
4861 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
4864 * vfm.c: (open_active_file) No need to call setup_randomize() any
4867 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
4869 Change dictionary name indexes to use hash tables instead of AVL
4872 * crosstabs.q: (free_var_dict) Use hash tables.
4873 (crs_custom_tables) Ditto.
4874 (calc_general) Ditto.
4875 (compare_table_entry) Rewrite.
4876 (enum_var_values) Reorder parameters. All references updated.
4879 * get.c: (rename_variable) Use hash tables.
4880 (mtf_merge_dictionary) Ditto.
4882 * glob.c: (init_glob) Use hash tables.
4883 (cmp_variable) Removed.
4885 * means.q: (mns_custom_tables) Use hash tables.
4887 * modify-vars.c: (rearrange_dict) Use hash tables.
4889 * rename-vars.c: (cmd_rename_variables) Use hash tables.
4891 * sfm-read.c: (read_header) Use hash tables.
4892 (read_variables) Ditto.
4894 * temporary.c: (new_dictionary) Use hash tables.
4895 (save_dictionary) Ditto.
4896 (restore_dictionary) Ditto.
4898 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
4899 hash table `name_tab'.
4901 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
4902 [DEBUGGING] (dump_var_tree) Removed.
4903 (find_variable) Use hash tables.
4904 (find_dict_variable) Ditto.
4905 (common_init_stuff) Ditto.
4906 (rename_variable) Ditto.
4907 (clear_variable) Ditto. Also, remove debug code.
4908 (dup_variable) Use hash tables.
4910 * vars-prs.c: (fill_all_vars) Use hash tables.
4911 (is_dict_varname) Ditto.
4912 (parse_dict_variable) Ditto.
4914 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
4916 Change value labels to use hash tables instead of AVL trees, and
4917 change value labels into an ADT.
4919 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
4921 * value-labels.c: New file.
4923 * value-labels.h: New file.
4925 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
4926 Get rid of a stupid use of goto.
4928 * autorecode.c: (compare_alpha_value) Rewrite.
4929 (hash_alpha_value) Ditto.
4930 (compare_numeric_value) Rewrite.
4931 (hash_numeric_value) Ditto.
4933 * frequencies.q: (dump_full) Use value label ADT.
4935 * pfm-read.c: (read_value_label) Use value label ADT.
4937 * pfm-write.c: (write_value_labels) Use value label ADT.
4939 * sfm-read.c: (read_variables) Use value label ADT.
4940 (read_value_labels) Rewrite.
4942 * sfm-write.c: (write_value_labels) Rewrite.
4944 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
4945 (display_variables) Ditto.
4946 (describe_variable) Ditto.
4948 * t-test.q: (print_t_groups) Use value label ADT.
4950 * temporary.c: (copy_variable) Use value label ADT.
4951 (free_dictionary) Ditto.
4953 * val-labs.c: (verify_val_labs) Use value label ADT.
4955 (debug_print) Ditto.
4956 (val_lab_cmp) Removed.
4957 (inc_ref_count) Removed.
4958 (copy_value_labels) Removed.
4960 * var.h: (struct value_label) Removed.
4961 (struct variable) Change AVL tree `val_lab' into hash table
4964 * vars-atr.c: (init_variable) Use value label ADT.
4965 (clear_variable) Ditto.
4966 (free_value_label) Removed.
4967 (free_val_lab) Removed.
4968 (get_val_lab) Removed.
4969 (compare_variables) New function.
4970 (hash_variable) New function.
4972 * vfm.c: (dump_splits) Use value label ADT.
4974 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
4976 Add to the hash table interface.
4978 * hash.c: (hsh_hash_bytes) Add assertion.
4979 (hsh_hash_string) Ditto.
4983 (hsh_create) Ditto. Also make minimum `size'.
4984 (hsh_destroy) Rephrase.
4985 (sort_nulls_last) Removed.
4986 (not_null) New function.
4988 (comparison_helper) Ditto.
4989 (hsh_sort) Rewritten.
4990 (hsh_data_copy) New function.
4991 (hsh_sort_copy) Ditto.
4993 (hsh_replace) Ditto.
4994 (hsh_hash_double) Ditto.
4995 (hsh_delete) Fix stupid bug.
4997 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4998 * added a calculation of the mode to FREQUENCIES
5000 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5002 * moved (un)defs of DEBUGGING to config.h
5004 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5006 * groff-font.c: (add_kern) Fix indentation.
5007 (add_kern) Use & instead of % to take power-of-2 modulus.
5008 (font_get_kern_adjust) Likewise.
5010 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5012 * autorecode.c: (recode) Replace stupid use of memcpy() by
5014 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5015 (hash_numeric_value) Ditto.
5016 (autorecode_proc_func) pool_strdup() was wrong here because the
5017 source string was not null-terminated. Use new pool_strndup()
5020 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5021 use of hsh_iterator_init().
5023 * data-in.c: (parse_N) Initialize i->v->f.
5025 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5028 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5029 (groff_read_font) Don't call hsh_next_prime(). Don't call
5031 (static var hash) Remove `size_p', `max_used' members.
5032 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5033 hsh_hash_string() instead of hashpjw(), & instead of %.
5034 (default_font) Don't call hsh_next_prime().
5036 * pool.c: (pool_strndup) New function.
5037 (pool_strdup) Reimplement in terms of pool_strndup.
5039 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5041 (hash_ps_encoding) Use hsh_hash_string().
5042 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5043 (hash_filename2font) Use hsh_hash_string().
5045 * som.c: Add #include <stdlib.h>.
5047 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5048 (by destroying its pool).
5050 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5052 Miscellaneous hash table code cleanup:
5054 * hash.h: (struct hsh_table) Moved into hash.c.
5055 (hsh_count) Ditto, and transformed into function.
5056 (hsh_compare_func) New typedef, used for defining otherwise-long
5057 function types here and in hash.c
5058 (hsh_hash_func) Ditto.
5059 (hsh_free_func) Ditto.
5061 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5062 `table' to `entries'. Removed `mp'. All references updated.
5063 (hsh_clear) Don't shrink entries array; if the hash was this big
5064 once, it probably will be again.
5065 (hsh_rehash) Made static.
5066 (force_hsh_insert) Renamed hsh_force_insert.
5067 (force_hsh_find) Renamed hsh_force_find.
5069 Made hash table sizes powers of 2, because that's fine with any
5070 reasonable hash function and because taking a power-of-2 modulus
5071 is faster than any other:
5073 (hsh_prime_tab) Removed;
5074 (hsh_next_prime) Ditto.
5075 (next_power_of_2) New function.
5076 (hsh_create) Use next_power_of_2.
5077 (hsh_rehash) Use & instead of %.
5079 Cleaned up hsh_sort:
5081 (internal_comparison_fn) Removed.
5082 (sort_nulls_last) New function.
5083 (hsh_sort) Removed second parameter, switched to using the new
5084 quicksort() function from quicksort.h to avoid using nasty need
5085 for static variables with qsort(). All references updated.
5087 Changed the hash functions offered, because there are better hash
5088 functions than the ones we had, and cleaned up the names to boot:
5090 * hash.c: (hashpjw_d) Removed.
5092 (hsh_hash_bytes) New function.
5093 (hsh_hash_string) New function.
5094 (hsh_hash_int) New function.
5096 Improved the hash table iteration interface:
5098 * hash.h: (hsh_iterator_init) Removed.
5099 (struct hsh_iterator) Removed `init' member, change `next' to
5102 * hash.c: (hsh_foreach) Removed. All references updated to use
5103 hsh_first/hsh_next instead.
5104 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5105 not treat a null pointer as an empty hash table.
5106 (hsh_next) New function.
5108 Made deletion possible, though slow:
5110 * hash.c: (locate_matching_entry) New function.
5111 (hsh_find) Use locate_matching_entry().
5112 (hsh_delete) New function also using locate_matching_entry().
5113 (hsh_force_delete) New function.
5115 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5117 * quicksort.c: New file implementing a sort routine with a
5118 interface better than qsort() because it passes a user-provided
5119 parameter to the sort routine.
5121 * Makefile.am: Add quicksort.c, quicksort.h.
5123 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5125 * All source files: Get rid of nasty special cases for Checker,
5126 which is pretty obsolete now.
5128 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5130 * Fixed a bug apparent when using the FREQUENCIES command with the
5131 html driver. The html driver was incorrectly trying to display
5134 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5136 * Makefile.am: Reorganized. Put locale dir in version.c instead
5137 of passing it to each compile command. Only put local gmp libs in
5138 LD_ADD if not installed on system. Remove `boast' target.
5140 * All source files: struct and union typedefs eliminated.
5141 `sizeof type' replaced by `sizeof object' where practical. Moved
5142 `unused' qualifiers from start to end of declarations for gcc
5143 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5144 assertions on pointers strictly compliant. Removed _ prefixes on
5145 some function parameter names.
5147 * alloc.c: New source file, containing these external linkage
5148 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5155 * ascii.c: Migrated from arenas to pools.
5156 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5157 c_string to len_string. All references changed.
5158 (ascii_option) Signature changed to comply to new output.c
5160 (count_fancy_chars) Removed.
5161 (delineate) Removed support for rich text.
5162 (ascii_text_metrics) Ditto.
5164 (output_shorts) Change `box', `off', `on' from c_string to
5165 len_string. Change `remaining' from int to size_t.
5166 (ascii_close_page) Make page numbering less haphazard.
5168 * autorecode.c: Migrate from arenas to pools.
5170 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5172 * bitvector.h: New file containing these macros from misc.h:
5173 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5175 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5176 word[3]. ncmd removed.
5177 (var empty_string) Removed.
5178 (var cmd_table) Declaration updated.
5179 (var cmdtab) Removed.
5180 (cmp_command) Removed.
5181 (split_words) Rewritten to use strtok_r().
5182 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5183 (find_command) Removed.
5184 (FILE_TYPE_okay) Rewritten.
5185 (cmd_parse) Rewritten. Semantics of the return value of command
5186 handlers has changed: they must now return one of the new CMD_*
5187 enumerals, rather than a magic value. This meant that all
5188 commands had to be modified, and they were.
5189 (figure_out_command) New function.
5191 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5192 #defines for INIT, INPU, etc.
5194 * command.h: New CMD_* enum series.
5195 (cur_proc) Make const char *, not char *.
5196 (cmd_init) Prototype.
5199 * common.c: Removed.
5201 * common.h: Removed.
5203 * correlations.q: New file.
5205 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5207 (custom_tables) Renamed crs_custom_tables().
5208 (custom_variables) Renamed crs_custom_variables().
5209 (calc_integer) Add in some `const' qualifiers.
5210 (table_value_missing) Change from a_string to len_string.
5211 (float_M_suffix) Change from a_string to len_string.
5213 * data-in.c: Rewritten. All references to
5214 parse_string_as_format() changed to data_in().
5216 * data-in.h: New file.
5218 * data-list.c: Change DLS_* from #define's to enums. Move from
5219 rpd_msg() to tmsg().
5220 (RPD_ERR) New #define.
5221 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5223 (read_from_data_list_fixed) Change from old
5224 parse_string_as_format() to new data_in().
5225 (read_from_data_list_free) Ditto.
5226 (read_from_data_list_list) Ditto.
5227 (cmd_repeating_data) Modify approach to checking for end of
5230 (rpd_parse_record) Change from old parse_string_as_format() to new
5231 data_in(). Change from old convert_format_to_string() to new
5233 (read_one_set_of_repetitions) Change dfm_push_cust() to
5234 dfm_push(), pop_cust() to dfm_pop().
5236 * data-out.c: Rewritten. All references to
5237 convert_format_to_string() changed to data_out().
5239 * descript.q: Migrate to new q2c.
5240 (cmd_descriptives) Removed.
5241 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5242 (custom_variables) Renamed dsc_custom_variables().
5244 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5246 (open_file_r) Initialize h->where.line_number. Migrate to new
5248 (open_file_w) Initialize h->where.line_number.
5249 (read_record) Change from ext->ln to h->where.line_number.
5250 Migrate to struct string.
5251 (dfm_put_record) Rephrased.
5252 (dfm_push_cust) Renamed dfm_push(), rewritten.
5253 (dfm_pop) New function.
5255 * error.c: All references updated.
5256 (glob var error_count) Renamed err_err_count.
5257 (glob var warning_count) Renamed err_warning_count.
5258 (glob var error_already_flagged) Renamed err_already_flagged.
5259 (glob var verbosity) Renamed err_verbosity.
5260 (glob var cust_fn) Removed.
5261 (glob var cust_ln) Removed.
5262 (static var file_loc) New.
5263 (static var nfile_loc) New.
5264 (static var mfile_loc) New.
5265 (tmsg) New function.
5266 (push_cust) Removed.
5269 (static var terminating) Removed.
5270 (failure) Renamed err_failure().
5271 (hcf) Renamed err_hcf().
5272 (err_push_file_locator) New function.
5273 (err_pop_file_locator) New function.
5274 (err_location) New function.
5275 (check_error_count) Renamed err_check_count().
5276 (vmsg) Renamed err_vmsg(). Interface changed.
5277 (verbose_msg) Removed.
5278 (err_cond_fail) New function.
5279 (error_break) Renamed err_break().
5281 * error.h: All references updated.
5282 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5283 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5285 (struct file_locator) New.
5287 (macro verbose_msg) Removed.
5288 (macro cond_fail) Removed.
5290 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5292 * expr-prs.c: Reorganized. All references updated.
5293 (exprtypename) Renamed expr_type_name().
5294 (typename) Renamed type_name().
5295 (free_expression) Renamed expr_free().
5296 (parse_expression) Renamed expr_parse(). Uses new type_check()
5298 (init_functab) Renamed init_func_tab().
5299 (type_check) New function.
5300 (parse_or) Rewritten to use new allocate_nonterminal() and
5301 append_nonterminal_arg() functions.
5304 (parse_rel) Ditto. Also simplified logic.
5309 (SYSMIS_func) Ditto.
5310 (VALUE_func) Rephrased.
5311 (CONCAT_func) Fix memory leak by replacing free by free_node on
5313 (generic_str_func) Ditto.
5314 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5316 (allocate_nonterminal) New function.
5317 (append_nonterminal_arg) New function.
5318 (static func_tab[]) Now at file level.
5320 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5322 * expr.h: (enum series OP_*) Moved to exprP.h.
5323 (OP_* defines) Ditto.
5324 (struct op_desc) Ditto.
5325 (global ops[]) Ditto.
5326 (struct num_con_node) Ditto.
5327 (struct str_con_node) Ditto.
5328 (struct var_node) Ditto.
5329 (struct lag_node) Ditto.
5330 (struct casenum_node) Ditto.
5331 (struct nonterm_node) Ditto.
5332 (union any_node) Members renamed.
5333 (struct sys_node) Removed.
5334 (struct val_node) Removed.
5335 (operator typedef) Removed.
5336 (typedef exprtype) Removed.
5337 (enum series EX_*) Moved to exprP.h.
5338 (struct expression) Ditto. Also renamed a lot of the members.
5339 (PXP_* defines) Changed to enums.
5340 (free_node prototype) Moved to exprP.h.
5342 * file-handle.h: (struct file_handle) New member `where'.
5344 * file-handle.q: Migrated to new q2c format.
5345 (prepend_current_directory) Removed (dead code).
5346 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5347 (fh_get_handle_by_filename) Removed dead code.
5348 Set new `where' member.
5350 * file-type.c: (file_type_source_read) References to
5351 parse_string_as_format() changed to data_in().
5352 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5354 * filename.c: All references updated.
5355 (init_filename) Renamed fn_init().
5356 (expand_line) Removed.
5357 (macro EXPAND_LINE) Removed.
5358 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5359 of custom functions.
5360 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5361 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5362 (normalize_filename) Renamed fn_normalize().
5363 (search_path) Renamed fn_search_path(), rewritten.
5364 (prepend_dir) Renamed fn_prepend_dir().
5365 (blp_getenv) Renamed fn_getenv().
5366 (blp_dirname) Renamed fn_dirname().
5367 (fn_basename) New function, not used.
5368 (absolute_filename_p) Renamed fn_absolute_p().
5369 (is_special_filename) Renamed fn_special_p().
5370 (file_exists) Renamed fn_exists_p().
5371 (readlink_malloc) Renamed fn_readlink().
5372 (getenv_default) Renamed fn_getenv_default().
5373 (open_file) Renamed fn_open().
5374 (close_file) Renamed fn_close().
5375 (open_file_ext) Renamed fn_open_ext().
5376 (close_file_ext) Renamed fn_close_ext().
5378 * font.h: Migrate from arenas to pools.
5380 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5382 * frequencies.g: Migrate from arenas to pools.
5384 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5387 * getline.c: All references updated.
5388 (global getl_buf) Changed from char * to struct string.
5389 (static getl_include_path) Ditto.
5390 (global getl_buf_len) Removed.
5391 (global getl_buf_size) Removed.
5392 (getl_include_path) Deal with new getl_buf, getl_include_path.
5393 (getl_uninitialize) New function.
5394 (getl_get_current_directory) Rewritten.
5395 (getl_clear_include_path) Rewritten.
5396 (getl_add_include_dir) Rewritten.
5397 (getl_add_file) Assertion fixed.
5398 (getl_add_virtual_file) Change initial value of `remaining_loops'
5400 (welcome) Rewritten.
5401 (handle_line_buffer) Make static. Change logic to make
5402 getl_add_virtual_file() change sensible. Use ds_*() strings.
5403 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5404 (getl_close_file) Moved.
5405 (getl_location) New function.
5407 * getline.h: All references updated.
5408 (macro curln) Removed.
5409 (macro curfn) Removed.
5410 (macro am_interactive) Renamed getl_am_interactive.
5411 (macro am_reading_script) Renamed getl_reading_script.
5413 * glob.c: (global fmt_parse_ignore_error) Removed.
5414 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5415 systems that support it (C99). Turn off SET ECHO by default. No
5416 necessary julcal initialization anymore.
5418 * groff-font.c: Migrate from arenas to pools.
5419 (groff_read_font) Use err_push_file_locator().
5420 (groff_read_DESC) Ditto.
5421 (font_msg) Use tmsg().
5423 * hash.c: (hsh_sort) Fix debug code.
5424 [GLOBAL_DEBUGGING] Include stdio.h.
5426 * hash.h: (macro force_hsh_insert) Rephrase.
5428 * heap.c: Rewritten.
5430 * heap.h: Rewritten.
5432 * html.c: (html_option) Change from outp_value to struct string.
5433 (postopen) Change from curfn to getl_location().
5434 (escape_string) Remove rich-text code. Signature changed.
5435 (output_tab_table) Switch from a_string to struct len_string.
5436 Remove rich text support.
5438 * lexer.c: All references updated. Largely rewritten. Major
5439 changes listed below. Removed tagged quote support. Adapted to
5440 struct string tokstr.
5441 (global tokstr) Changed to struct string.
5442 (global tokstr_size) Removed.
5443 (global tokstr_len) Removed.
5445 (global tokint) Removed.
5446 (global toklongstr) Removed.
5447 (C* defines) Removed.
5448 (static tbl[]) Removed.
5449 (static id[]) Removed.
5450 (static une[]) Removed.
5451 (discard_line) Renamed lex_discard_line().
5452 (get_entire_line) Renamed lex_entire_line().
5453 (get_rest_of_line) Renamed lex_rest_of_line().
5454 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5455 (make_hexit) Removed.
5456 (syntax_error) Renamed lex_error(). Return value removed.
5457 (get_token_representation) Renamed lex_token_representation().
5458 (putback) Renamed lex_put_back().
5459 (putfwd) Renamed lex_put_forward().
5460 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5461 (set_prog) Renamed lex_set_prog().
5462 (init_lex) Renamed lex_init().
5463 (reset_eof) Renamed lex_reset_eof().
5464 (lookahead) Renamed lex_look_ahead().
5465 (check_id) Rewritten.
5466 (yylex) Renamed lex_get(), rewritten.
5467 (lex_end_of_command) New function. Many commands were rephrased
5469 (lex_integer_p) New function. Replaces compare of tokint against
5471 (lex_integer) New function. Replaces tokint.
5472 (match_tok) Renamed lex_match().
5473 (match_id) Renamed lex_match_id().
5474 (match_int) Renamed lex_match_int().
5475 (force_match_id) Renamed lex_force_match_id(), added return value.
5476 (force_match) Renamed lex_force_match(), added return value.
5477 (force_string) Renamed lex_force_string(), added return value.
5478 (force_int) Renamed lex_force_int(), added return value.
5479 (lex_id_match_len) New function.
5480 (id_match) Renamed lex_id_match(), rewritten.
5481 (get_line) Renamed lex_get_line().
5482 (preprocess_line) Renamed lex_preprocess_line().
5483 (tokname) Renamed lex_token_name().
5484 (bin_value_func) Removed.
5485 (oct_value_func) Removed.
5486 (hex_value_func) Removed.
5487 (unexpected_eof) New function.
5488 (convert_numeric_string_to_char_string) New function.
5489 (parse_string) Rewritten, signature changed.
5490 (add_tokstr_char) Removed.
5491 (add_tokstr_unsigned) Removed.
5492 (add_tokstr_string) Removed.
5493 (parse_tagged_quote) Removed.
5494 (skip_comment) Renamed lex_skip_comment().
5496 * lexer.h: All references updated.
5497 (macro is_id1) Renamed CHAR_IS_ID1.
5498 (macro is_idn) Renamed CHAR_IS_IDN.
5499 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5500 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5501 (macro get_token) Removed.
5502 (macro id_match) Removed.
5503 (macro force_match_id) Removed.
5504 (macro force_match) Removed.
5505 (macro force_string) Removed.
5506 (macro force_int) Removed.
5507 (macro force_num) Removed.
5508 (macro force_id) Removed.
5510 * lexerP.h: Removed.
5512 * list.q: Migrated to new q2c format.
5513 (write_line) Deal with struct len_string.
5514 (write_varname) Ditto.
5515 (write_fallback_headers) Ditto.
5517 * magic.c: New file, incorporating the following global variables
5518 previously in other files: endian, second_lowest_value. And both
5519 of those are conditional on #define's.
5521 * magic.h: New file, incorporating the following global variable
5522 declarations: endian, second_lowest_value, and the following macro
5523 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5525 * main.c: Added declarations of pgmname, finished, curdate,
5527 (main) Call new parse_script() function.
5528 (parse_script) New function.
5529 (execute_command) New function.
5530 (dump_token) Removed.
5531 (handle_error) New function.
5533 * matrix.c: New file.
5535 * matrix.h: New file.
5537 * matrix-data.c: Migrated from arenas to pools.
5538 (mget_token) Change from parse_string_as_format() to data_in().
5540 * means.q: Migrate to new q2c.
5541 (custom_tables) Renamed mns_custom_tables().
5542 (custom_crossbreak) Renamed mns_custom_crossbreak().
5543 (custom_variables) Renamed mns_custom_variables().
5545 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5546 (parse_varnames) Prototype.
5547 (parse_numeric) Rephrasings.
5548 (parse_alpha) Adapt to new struct string tokstr.
5550 * misc.c: (intlog10) Rewritten.
5552 (ansi_rand) Renamed real_rand(), moved into random.c.
5553 (ansi_srand) Renamed real_srand(), moved into random.c.
5554 (setup_randomize) Moved to random.c.
5555 (rand_uniform) Ditto.
5556 (rand_normal) Ditto.
5557 (rand_simple) Ditto.
5558 (get_config_line) Removed.
5559 (reverse) Removed (dead code).
5561 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5562 (macro CLEAR_BIT) Ditto.
5563 (macro TEST_BIT) Ditto.
5564 (macro SET_BIT_TO) Ditto.
5565 (macro BIT_INDEX) Ditto.
5567 * output.c: (outp_read_devices) Move to err_push_file_locator()
5568 from push_cust(). Use struct string.
5569 (expand_op_tokstr) Removed.
5570 (static var op_tokstr) Changed to struct string.
5571 (static var op_tokstr_size) Removed.
5572 (tokener) Rephrasings. Use struct string.
5573 (parse_options) Use struct string.
5574 (destroy_driver) Fix assertion.
5575 (outp_get_paper_size) Move to err_push_file_locator().
5576 [0] Removed dead code.
5577 (outp_string_width) Move to len_string.
5579 * output.h: Comment fixes.
5580 (TAG_* enum series) Removed.
5581 (struct outp_value) Removed.
5582 (enum OUTP_T_FANCY) Removed.
5583 (struct outp_text) `s' changed from a_string to len_string.
5584 (struct outp_class) `option' change arg 3 from outp_value to
5587 * pfm-read.c: (corrupt_msg) Rewritten.
5589 * pfm-write.c: (bufwrite) Fix assertion.
5591 * pool.c: New file, reference version.
5593 * pool.h: New file, reference version.
5595 * postscript.c: (ps_font_sizes) Fix assertion.
5596 (ps_option) Change arg 3 from outp_value to struct string.
5597 Adapt to struct string.
5598 (macro output_line) Removed.
5599 (macro add_string) Removed.
5600 (output_encodings) Adapted to struct string. Moved to
5601 err_push_file_locator().
5602 (find_encoding_file) Fix assertion.
5603 (read_ps_encodings) Move to err_push_file_locator().
5604 (postopen) Use getl_location() instead of curfn.
5605 (out_text_plain) Move to len_string.
5606 (text) Ditto. Remove rich text support.
5608 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5609 (cmd_print_eject) Ditto.
5611 (internal_cmd_print) Now cleans up after itself. Uses
5612 fh_parse_file_handle() now.
5613 (cmd_print_space) Use PXP_NUMERIC to type-check.
5615 * q2c.c: Overhauled. Removed _("") i18n support. All references
5616 updated. All output functions updated to handle structures rather
5617 than local or static variables. Adapt to new PSPP lex_*()
5621 (macro MAX_N_SBC) Removed.
5622 (global bare) Removed.
5623 (enum STRING) Renamed T_STRING.
5624 (enum ID) Renamed T_ID.
5625 (get_buffer) Buffer size increased.
5626 (strlower) Renamed st_lower(), rephrased.
5627 (strupper) Renamed st_upper(), rephrased.
5628 (skip_ws) New function.
5629 (get_line) Don't special-case any types of lines (like those
5630 beginning with ! or $, for instance).
5631 (get_token) Renamed lex_get(). Rephrased.
5632 (static var `prefix') New.
5633 (parse) New function.
5634 (parse_setting) Minor rephrasing.
5635 (dump_specifier_vars) Ditto.
5636 (make_identifier) Put null terminator on identifier, duh.
5637 (dump_vars) Renamed dump_declarations(). Never indent. Never
5638 static. Output changed entirely.
5639 (dump_specifier_init) Rephrase.
5640 (dump_vars_init) No index variable needed. Other modifications.
5641 (dump_parser) Don't parse command name. Do dump functions instead
5642 of just code fragments.
5643 (dump_free) Dump function instead of code fragment.
5644 (recognize_directive) New function.
5645 (main) Use recognize_directive(). Don't rely on magic $ line
5646 beginning: instead, parse comments. Update list of headers.
5648 * random.c: New file, containing the following functions:
5649 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5650 rand_normal, rand_simple.
5652 * random.h: New file.
5654 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5655 function. `max_src_width', `max_dst_width' changed to size_t.
5656 (internal_cmd_recode) Removed.
5657 (parse_dest_spec) Merge similar cases.
5658 (parse_src_spec) Add assertion.
5660 * repeat.c: (recognize_keyword) New function.
5661 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5662 REPEAT. Improve recognition of END REPEAT (use
5663 recognize_keyword()). Move from curfn to getl_location(). Use
5666 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5668 * set.q: Adapt to new q2c.
5669 (cmd_set) Range-check some values better.
5670 (custom_blanks) Renamed stc_custom_blanks().
5671 (custom_length) Renamed stc_custom_length().
5672 (custom_results) Renamed stc_custom_results().
5673 (custom_seed) Renamed stc_custom_seed().
5674 (custom_width) Renamed stc_custom_width().
5675 (custom_format) Renamed stc_custom_format().
5676 (custom_journal) Renamed stc_custom_journal().
5677 (custom_color) Renamed stc_custom_color().
5678 (custom_listing) Renamed stc_custom_listing().
5679 (custom_disk) Renamed stc_custom_disk().
5680 (custom_log) Renamed stc_custom_log().
5681 (custom_rcolor) Renamed stc_custom_rcolor().
5682 (custom_viewlength) Renamed stc_custom_viewlength().
5683 (custom_workdev) Renamed stc_custom_workdev().
5685 * settings.h: Not necessary to include format.h any longer.
5687 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5688 (corrupt_msg) Rewritten.
5690 * sort.c: Adapt to rewritten heap ADT.
5692 * str.c: (aa_strcpy) Removed.
5693 (ab_strcpy) Removed.
5694 (ac_strcpy) Removed.
5695 (ba_strcpy) Removed.
5696 (bb_strcpy) Removed.
5697 (ca_strcpy) Removed.
5698 (aa_strdup) Removed.
5699 (aa_strdupcpy) Removed.
5700 (ba_strdup) Removed.
5701 (sa_strdup) Removed.
5702 (memrev) Renamed mm_reverse().
5703 (memrmem) Renamed mm_find_reverse().
5704 (cmp_str) Renamed st_compare_pad().
5705 (strmaxcpy) Removed.
5706 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5707 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5709 (strpadcpy) Renamed st_pad_copy(), signature changed.
5710 (blpstrset) Removed.
5711 (ds_create) New function.
5712 (ds_init) New function.
5713 (ds_replace) New function.
5714 (ds_destroy) New function.
5715 (ds_clear) New function.
5716 (ds_extend) New function.
5717 (ds_shrink) New function.
5718 (ds_truncate) New function.
5719 (ds_length) New function.
5720 (ds_size) New function.
5721 (ds_value) New function.
5722 (ds_end) New function.
5723 (ds_concat) New function.
5724 (ds_concat_buffer) New function.
5725 (ds_printf) New function.
5726 (ds_putchar) New function.
5727 (ds_getline) New function.
5728 (ds_get_config_line) New function derived from the old
5729 misc.c:get_config_line().
5730 (ls_create) New function.
5731 (ls_create_buffer) New function.
5732 (ls_init) New function.
5733 (ls_shallow_copy) New function.
5734 (ls_destroy) New function.
5735 (ls_null) New function.
5736 (ls_null_p) New function.
5737 (ls_empty_p) New function.
5738 (ls_length) New function.
5739 (ls_value) New function.
5740 (ls_end) New function.
5742 * str.h: Reformatted.
5743 (struct a_string) Removed.
5744 (struct b_string) Removed.
5745 (struct c_string) Removed.
5746 (struct len_string) New.
5747 (struct string) New.
5748 (macro as_streq) Removed.
5749 (macro bs_streq) Removed.
5750 (macro cs_streq) Removed.
5751 (macro sa_streq) Removed.
5752 (macro sb_streq) Removed.
5753 [__GNUC__] (inline function ds_putchar) New function.
5754 [__GNUC__] (inline function ds_length) New function.
5755 [__GNUC__] (inline function ds_value) New function.
5756 [__GNUC__] (inline function ds_end) New function.
5758 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5759 (display_vectors) Fix missing i18n.
5761 * t-test.q: Migrate to new q2c.
5763 * tab.c: Migrate from arenas to pools.
5764 (tab_create) Use struct len_string.
5765 (tab_realloc) Ditto.
5766 (text_format) Ditto.
5767 (tab_joint_text) Ditto.
5768 (tab_natural_width) Remove rich text support.
5769 (tab_natural_height) Ditto.
5770 (tab_output_text) Handle TAT_FIX.
5771 (tab_raw) Change arg from a_string to len_string.
5772 (tabi_driver) Fix assertion. Use struct len_string.
5773 (render_strip) Use struct len_string. Remove rich text support.
5774 Add `const' qualifiers.
5776 * tab.h: (enum TAB_RICH) Remove.
5777 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5778 SOM_COL_* updated to read TAB_COL_*.
5779 (struct tab_table) Change arena to pool. Change a_string to
5782 * temporary.c: (restore_dictionary) Rewrite Checker code.
5784 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5785 LOWEST, HIGHEST) Moved here from common.h.
5786 (typedef any_trns) Removed. All references changed to `struct
5789 * vars-atr.c: (force_create_variable) Fix assertion.
5790 (force_dup_variable) Fix assertion.
5792 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5794 Using alphanumeric variables in functions under AGGREGATE
5795 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
5796 <BZN-mdksh@t-online.de> for reporting this bug.
5798 * aggregate.c: (parse_aggregate_functions) When setting the
5799 FSTRING bit, also allocate memory for the `string' member of
5801 (free_aggregate_functions) Free iter->string. Don't use the
5802 non-function bits when indexing the array of functions.
5803 [DEBUGGING] (debug_print) Don't use the non-function bits when
5804 indexing the array of functions.
5806 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
5808 Under certain circumstances, the final case would be omitted from
5809 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
5810 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5812 * aggregate.c (agr_00x_end_func): Increment number of cases in
5813 sink before writing case. For streams that keep track of how many
5814 cases there are based on this value, this means that the last case
5815 will be read in on the next stream read.
5817 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
5819 Undefined behavior was invoked by referencing a freed pointer.
5821 * vfm.c (memory_stream_write): Free pointer *after* checking for
5824 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
5826 A wrong record size was displayed when paging the active file to
5829 * vfm.c: (memory_stream_write) Fix off-by-one error.
5831 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
5833 Not having enough temporary space for sorting caused a core dump.
5836 * sort.c: (allocate_cases) Initialize i.
5838 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
5840 Syntax errors in function descriptions on AGGREGATE caused core
5843 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
5844 free_aggregate_functions(), since that function already frees
5847 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
5849 A null pointer was dereferenced, causing a core dump, when
5850 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
5851 but PSPP still doesn't calculate percentiles. Thanks to Regnor
5852 Jernsletten <rjernsle@eunet.no> for reporting this problem.
5854 * arena.c: (arena_malloc) If the arena hasn't been initialized
5855 already, initialize it.
5857 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
5859 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
5860 for compilation with Cygnus Windows B20. Not used by other
5863 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
5865 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
5866 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5868 * sort.c: (compare_case_lists) Reverse sense of comparison if
5869 sorting in descending order.
5870 (compare_record) Ditto.
5872 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
5874 SPLIT FILE with a string variable caused a core dump. Fixed.
5876 * vfm.c: If the variable is a string then make a temporary value
5877 struct pointing to it. The underlying problem is a lot bigger
5878 than this (see TODO) but this is a stopgap for the simple case at
5881 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
5883 Nested INCLUDEs didn't work. Fixed.
5885 * getline.c: (getl_include) Set first_line to NULL in allocated
5888 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
5890 The MATCH FILES procedure set the values of variables not present
5891 to 0. It should have been SYSMIS. This is now fixed.
5893 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
5895 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
5897 The REMARK command was too aggressive about skipping lines. It
5898 didn't like being the last command in a file.
5900 * command.c: (cmd_remark) Call get_entire_line() instead of
5903 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
5905 Comment parsing wasn't consistent with the rest of the code in its
5906 idea of where one command ends and another starts. This meant
5907 that sometimes commands would be mysteriously ignored. Thanks to
5908 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5910 * command.c: (parse_cmd) Hand off comment parsing to new function
5911 skip_comment() in lexer.c.
5912 * lexer.c: (skip_comment) New function.
5914 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
5916 The TABLE subcommand on MATCH FILES worked only erratically at
5917 best. This fixes it. Thanks to Dr. Dirk Melcher
5918 <BZN-mdksh@t-online.de> for reporting this bug.
5920 * get.c: (mtf_compare_BY_values) When comparing string values, a
5921 difference of 1 is still a difference :-)
5922 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
5923 advance TABLE files automatically when matched. Comment fixes.
5925 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
5927 VARIABLE LABELS rejected a slash before the first variable
5928 specification, contradicting the documentation. Thanks to Walter
5929 M. Gray <graywm@northernc.on.ca> for reporting this bug.
5931 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
5932 command specification.
5934 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
5936 Because of an incorrect optimization in memory allocation,
5937 CROSSTABS sometimes segfaulted when asked to output multiple
5938 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5941 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
5942 are passed to output_pivot_table() for its use.
5943 (output_pivot_table) Instead of assuming the number of columns is
5944 constant, keep track with maxcols. In general mode, use maxcells
5945 to determine whether more matrix cells need to be allocated.
5947 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
5949 CROSSTABS didn't display value labels for column and row
5950 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5953 * crosstabs.q: (table_value_missing) If the specified value has a
5954 value label for this variable, then show it instead of the raw
5956 (display_dimensions) Delegate display of value_labels to
5957 table_value_missing.
5959 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
5961 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
5962 <BZN-mdksh@t-online.de> for reporting this bug.
5964 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
5965 if the file isn't declared as binary.
5967 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
5969 MATCH FILES corrupted memory and dumped core on some syntax
5972 * get.c: (cmd_match_files) Set file->handle to NULL before
5974 (mtf_free_file) Don't free a null dictionary.
5976 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
5978 MATCH FILES should set numeric values not available to the
5979 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
5980 <BZN-mdksh@t-online.de> for reporting this bug.
5982 * get.c: (mtf_processing) Set unused records to system-missing,
5985 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
5987 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
5988 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
5990 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
5991 in newly created dictionary, and add each copied variable to the
5994 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
5998 * get.c: (trim_dictionary) Free variable list for KEEP after
6001 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6003 Some systems didn't like the way open_file was coded. Thanks to
6004 Hankin <hankin@rogue.consultco.com> for pointing this out.
6006 * filename.c: (open_file) Don't try to store stdin, stdout,
6007 stderr as part of an array, because that doesn't always work.
6009 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6011 The SAVE procedure didn't save long string variables properly.
6012 Fixed by this patch. Thanks to Hankin
6013 <hankin@rogue.consultco.com> for this patch.
6015 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6016 out variable pad records.
6018 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6020 Previously, if PRINT SPACE were given a negative argument, it
6021 would report an error, then spin in an (almost) infinite loop.
6022 This fixes that behavior.
6024 * print.c: (print_space_trns_proc) After reporting a negative
6025 argument, set number of lines to print to 1.
6027 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6029 SPSS 8.0 outputs some new record types in its system files, and it
6030 allows longer value labels. Accept these system files.
6032 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6033 11 emitted by SPSS 8.0.
6035 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6037 The LIST procedure was too conservative in allocating space for
6038 buffers, which caused a bug that only showed up with very long
6039 output variables. Thanks to Hankin <hankin@dunno.com> for this
6042 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6044 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6046 Typo meant string format specifiers weren't checked properly. I
6047 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6048 willing to be corrected on this point.
6050 * format.c: (check_string_specifier) Fix obvious typo.
6052 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6054 Using $CASENUM in an expression didn't work. Here's a fix.
6055 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6058 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6060 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6062 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6064 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6065 other behavior, *sigh*. This patch hopefully fixes that. This
6066 time I've actually tested it.
6068 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6070 * data-list.c: (read_from_data_list_free,
6071 read_from_data_list_list) Call parse_string_as_format() directly
6072 without mucking around with the field width.
6074 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6076 Occasionally, you may encounter a script that wants to be
6077 interpreted in interactive mode. Make -i emulate this behavior to
6078 allow such scripts to be executed with PSPP.
6080 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6082 * cmdline.c: (pre_syntax_message[]) Update -i description.
6084 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6085 when -i is given on the command line) don't treat unindented lines
6086 as starting a new command.
6088 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6090 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6091 mostly caused by local initialized aggregates. After egcs is
6092 fixed upstream these can be removed, but for now they're not a big
6095 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6096 initialized arrays. Avoid this.
6098 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6101 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6103 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6104 following changes avoid. Currently I compile sources with egcs
6105 1.1.1 and gcc 2.7.2.3 before sending them out.
6107 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6109 * ascii.c: (option_tab[]) Initialize all struct members.
6111 * avl.h: (avl_traverser_init) New macro.
6113 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6116 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6119 * hash.c: Comment fix.
6121 * hash.h: (hsh_iterator_init) New macro.
6123 * html.c: (option_tab[]) Initialize all struct members.
6125 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6128 * postscript.c: (option_tab[]) Initialize all struct members.
6129 (output_encodings, preclose, dump_lines) Use new
6130 hsh_iterator_init() macro.
6132 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6135 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6138 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6140 * data-in.c: Examined each of the parsing functions to make sure
6141 that they wouldn't dump core if they were passed a string of the
6142 wrong length, since now the DATA LIST FREE/LIST routines don't
6143 check for field width before passing it to the data parser.
6144 (parse_RBHEX, parse_AHEX) Reject odd length input.
6145 (parse_string_as_format) Reject input that's too short or too
6148 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6149 a field to its entire declared output width then pass it to the
6150 data-in parsing routines. This contradicted the documented
6151 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6152 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6153 free-format parsing that differed from SPSS.
6154 (cut_field) Commas and spaces are treated identically. Returns
6155 the proper column instead of a fixed 1 value.
6156 (parse_field) Removed.
6157 (read_from_data_list_free, read_from_data_list_list) Call
6158 parse_string_as_format directly instead of parse_field.
6160 * heap.c: (heap_delete) Stylistic fixes.
6162 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6164 * loop.c: (loop_2_trns_proc) Formatting fix.
6166 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6168 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6170 * vfm.c: (macro FILTERED) New.
6171 (static var filter_var) New.
6172 (process_active_file_write_case) Use FILTERED.
6173 (setup_filter) Set filter_var.
6174 (close_active_file) Delete the filter if not
6175 FILTER_before_TEMPORARY.
6176 (procedure_write_case) Use FILTERED.
6178 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6180 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6182 * data-in.c: (parse_day_count) Message fix.
6183 (parse_month) Style fix.
6185 * data-list.c: (struct data_list_pgm) New member eof.
6186 (cmd_data_list) Init eof to 0.
6187 (do_reading) Implement the /END subcommand and read-past-eof
6190 * do-if.c: Include stdio.h when debugging.
6191 (cmd_else_if) Make sure the command is .-terminated.
6193 * glob.c: (init_glob) Capitalize the command prompt.
6195 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6196 (end_file_trns_proc) Debugging message.
6198 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6200 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6202 * main.c: (dump_token) Make kwtab[] const.
6204 * set.q: Spelling, comment fixes.
6206 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6209 * vars-prs.c: (fill_all_vars) Style fix.
6211 * vfm.c: (index_to_varname) Return const.
6213 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6215 * Changes in many source files for partial -ansi -pedantic and
6216 no-debugging compliance: Remove trailing common in enum
6217 declarations; add `unused' attributes; insert some appropriate
6220 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6222 * command.c: (shell) Make static.
6223 (run_command) Make static.
6225 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6227 * dfm.c: (cmd_begin_data) I18n fix.
6229 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6231 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6233 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6236 * file-handle.q: Don't prepend the source file directory name to
6237 the data file name. (Ongoing issue.)
6238 (prepend_current_directory) Comment out.
6239 (internal_cmd_file_handle) Don't call prepend_current_directory().
6240 (fh_get_handle_by_filename) Ditto.
6242 * filename.c: Append zero byte to readlink() return value.
6244 * getline.c: (getl_read_line) I18n fix.
6246 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6248 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6250 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6253 * postscript.c: (output_encodings) Don't use local_strdup().
6256 * print.c: Don't use gcc features if __STRICT_ANSI__.
6258 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6260 * recode.c: (parse_src_spec) Fully brace nested if's.
6262 * set.q: (global var set_testing_mode) New var.
6264 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6266 * ascii.c: Add some more `unused' attributes that only come into
6267 play when NDEBUG is defined.
6268 (ascii_close_page) Set s_len when reallocating s.
6270 * crosstabs.q: (delete_missing) New function.
6271 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6272 (make_summary_table) Create summary table reallocable.
6274 * postscript.c: Add more `unused' attributes as above.
6276 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6277 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6279 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6282 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6283 gratuitous space between parameter definition.
6285 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6286 complaints about running off the end of functions with NDEBUG
6289 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6291 * Several source files: Removed some PORTME notes when reflection
6292 revealed that ANSI forbids that sort of breakage. Also, added
6293 lots of `unused' qualifiers here and there.
6295 * aggregate.c: (accumulate_aggregate_info) Remove local var
6296 weighting that turned out not to be used.
6298 * avl.c: Update to version 1.1.0. Add unused specifier.
6299 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6301 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6302 (avl_find) Cast return value to void *.
6303 (avl_delete) q doesn't need to be initialized at the beginning of
6304 the function. Replace some instances of 1 with +1.
6305 (force_avl_delete) Renamed avl_force_delete, all references changed.
6306 (compare_ints) `param' marked unused.
6307 (print_int) `param' marked unused.
6308 (recurse_tree) Replace some instances of 1 with +1.
6310 * avl.h: Update to version 1.1.0. Only declares avl function
6311 types if not already declared.
6312 (AVL_MAX_HEIGHT) Only define if not already defined.
6313 (struct avl_node) New unused member char pad[2].
6314 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6315 (force_avl_insert) Renamed avl_force_insert.
6316 (force_avl_delete) Renamed avl_force_delete.
6318 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6320 (struct crosstab) Add new member `ofs'.
6321 (glob var int_tab) Removed.
6322 (custom_tables) In integer mode, assign v[i] properly through the
6324 (custom_variables) Now p.crs.max == max + 1.
6325 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6326 (precalc) Implement integer mode.
6327 (calc_integer) Implement integer mode.
6328 (compare_table_entry) Remove unused local variable `comparing'.
6329 (make_summary_table) Implement integer mode.
6330 (macro ns_rows) Implemented as static variable now.
6331 (several variables) Made static, from global.
6332 (output_pivot_table) Use table_value_missing() for column heads.
6333 Remove several unused local variables. Implement integer mode
6334 table summing. Count up ns_rows.
6335 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6336 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6337 calls that function or find_pivot_extent_integer.
6338 (find_pivot_extent_integer) New function.
6339 (enum_var_values) Implemented for integer mode.
6340 (table_value_missing) New function.
6341 (display_dimensions) Call table_value_missing() for heads.
6342 (float_M_suffix) New function.
6343 (display_crosstabulation) Call table_value_missing() for row
6344 heads. Handle missing values in /MISSING=REPORT mode.
6345 (calc_fisher) Remove unused var N.
6346 (calc_r) Remove unused var fact.
6348 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6349 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6351 * data-out.c: (insert_commas) Remove unused var cp.
6352 (convert_CCx) Remove unused vars save_set_decimal,
6355 * descript.q: (dump_z_table) Fix table dimensioning.
6356 (pre_calc) Remove unused var j.
6357 (display) Remove unused vars title, s. Fix table dimensioning.
6359 * expr-evl.c: Comment fixes.
6361 * frequencies.q: (full_dim) New function.
6362 (dump_full) Fix table dimensioning.
6363 (condensed_dim) New function.
6364 (dump_condensed) Fix table dimensioning.
6366 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6369 * html.c: (html_close_drive) Remove unused var i.
6370 (postopen) Remove unused vars title, curfn_len, cp.
6371 (preclose) Remove unused vars this, x.
6373 * lexer.c: Comment fixes.
6375 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6377 * means.q: (custom_tables) Remove unused var m_dim.
6379 * mis-val.c: Format fix.
6381 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6383 * output.c: (outp_get_paper_size) Remove unused var cp.
6385 * pfm-read.c: (read_float) Remove unused var save, unused label
6387 (read_variables) Remove unused vars cp, j.
6388 (read_value_label) Remove unused var j.
6390 * pfm-write.c: (bufwrite) Remove unused var i.
6392 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6394 (output_encodings) Remove unused vars char_cp, n_output.
6395 (read_ps_encodings) Remove unused var ep.
6396 (postopen) Remove unused var title.
6397 (preclose) Remove unused var fp.
6398 (ps_open_page) Remove unused vars true, false, orientation,
6399 mirror_horz, mirror_vert, width, length.
6400 (ps_text_metrics) Remove unused var x.
6402 * q2c.c: (find_symbol) Remove unused var y.
6403 (parse_setting) Remove unused parameter sbc, all references
6405 (dump_parser) Remove unused var cp.
6406 (dump_free) Remove unused var i.
6408 * set.q: (static vars args, n) Removed.
6409 (internal_cmd_gset) Removed.
6411 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6412 (read_machine_flt64_info) Removed unused var file_endian.
6413 (read_documents) Removed unused var i.
6414 (read_compressed_data) Removed unused parameter dict, all
6417 * sfm-write.c: (bufwrite) Removed unused var i.
6418 (sfm_write_case) Removed unused var i.
6420 * sort.c: (merge_once) Remove unused var t.
6421 (write_separate) #if 0 out as dead code.
6423 * split-file.c: (cmd_split_file) Remove unused var i.
6425 * sysfile-info.c: (sysfile_info_dim) New function.
6426 (cmd_sysfile_info) Fix table dimensioning.
6427 (variables_dim) New function.
6428 (display_variables) Fix table dimensioning.
6429 (describe_variable) Remove unused var prev_r.
6431 * t-test.q: (z_postcalc) Removed.
6432 (pairs_calc) Remove unused var bad_weight.
6433 (postcalc) Remove unused vars dfn, dfd.
6435 * tab.c: (tab_create) Set t->dim to NULL.
6436 (tab_dim) Make sure t->dim is NULL first.
6437 (tab_natural_width) Remove parameter `clamp'.
6438 (tab_value) Remove duplicate assertion for table.
6439 (tab_raw) New function.
6440 (nowrap_dim) New function.
6441 (wrap_dim) New function.
6442 (tab_output_text) Fix table dimensioning.
6444 * tab.h: (tab_raw) New macro.
6446 * val-labs.c: (get_label) Remove unused var type.
6447 (copy_value_labels) Remove unused var trav.
6449 * var.h: (struct crosstab_proc) Completely changed.
6451 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6453 * vfm.c: (open_active_file) Remove unused vars i, lp.
6455 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6457 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6459 * Makefile.am: Add apply-dict.c, flip.c.
6461 * apply-dict.c: New file.
6463 * command.c: (struct command) Make cmd[] larger for CLEAR
6464 TRANSFORMATIONS command name.
6465 (parse_cmd) Make sure we're in a valid state before using it as an
6466 index. Discard variables and reset state on invalid transitions.
6467 (cmd_clear_transformations) New function.
6469 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6470 Add unimplemented PRESERVE, RESTORE.
6472 * file-handle.h: Include stddef.h.
6476 * pfm-read.c: (parse_value) Pad value label values with spaces,
6479 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6480 (sfm_close) Decrement reference count, make sure it's zero.
6481 (sfm_maybe_close) New function.
6482 (sfm_read_dictionary) Handle reference counts.
6484 * vars-atr.c: (clear_default_dict) New function.
6485 (discard_variables) Use clear_default_dict().
6487 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6489 * Makefile.am: Add pfm-write.c.
6490 (LDADD) Add the libgmp2 libraries.
6492 * command.def: Define EXPORT.
6494 * get.c: (cmd_export) New function.
6495 (export_write_case_func) New function.
6497 * pfm-read.c: (static spss2ascii[]) Make it const.
6499 * pfm-write.c: New file.
6501 * sfm-write.c: Formatting, comment fixes.
6503 * var.h: Comment fix.
6505 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6507 * Makefile.am: Add pfm.h, pfm-read.c.
6509 * command.def: IMPORT is now implemented.
6511 * format.c: (glob var translate_fmt[]) New var.
6513 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6514 (cmd_import) New function.
6515 (import_source_read) New function.
6516 (glob var import_source) New var.
6518 * pfm-read.c: New file.
6522 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6524 (dump_dictionary) Disabled printing a couple of items.
6526 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6528 * crosstabs.q: (postcalc) Call make_summary_table().
6529 (make_summary_table) New function.
6530 (insert_summary) New function.
6531 (display_dimensions) Remove some unnecessary arguments, all
6533 (output_pivot_table) Fix lots of problems with the risk table
6535 (submit) Don't display an empty table.
6536 (display_risk) Fix order of arguments to calc_risk().
6538 * glob.c: Always include assert.h and stdlib.h.
6540 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6543 * tab.c: (tab_create) Cosmetic changes.
6545 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6547 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6551 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6552 code simplified, moved into new function submit().
6553 (submit) New function.
6554 (crosstabs_dim) New function.
6555 (display_directional) Substitute variable names for %s where
6557 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6558 (calc_symmetric) Initialize parameters only if non-NULL.
6559 Calculate Somers' d.
6560 (calc_directional) Calculate Somers' d (or copy it, really).
6563 * output.c: (outp_string_width) New function.
6565 * postscript.c: (postopen) Calculate font widths based on the
6566 width of the zero '0' character, not the width of the space
6567 character. Set paper-width and paper-length based on points, not
6569 (ps_open_page) Fix page setup string for landscape mode.
6571 * som.h: (struct som_dimension) Removed.
6572 (struct som_table_class) height, width members take int * not
6575 * tab.c: Many functions now have added parameter validation.
6576 (tab_height, tab_width) These functions were removed and merged
6577 into a single function tab_resize(), and all references changed.
6578 (tab_dim) Rewritten since the interface changed; reduced from
6579 hundreds of lines to two. All callers were changed. Currently
6580 most of them just use tab_natural_dimensions as their callback and
6581 await detailed translation of functionality.
6582 (tab_natural_width) New function.
6583 (tab_natural_height) New function.
6584 (tab_natural_dimensions) New function. This is a callback
6585 function, not something that you'd want to call directly.
6586 (tab_nat_dim) Removed.
6587 (tabi_table) Allocates t->w and t->h.
6588 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6589 dimensions callback.
6590 (evaluate_dimensions) Removed.
6591 (sum_columns) Removed.
6593 * tab.h: (enum TAL_1THIN) Removed.
6594 (enum series t_*) Removed.
6595 (struct tab_table) Members trh, trv changed to unsigned char *
6596 from int *. Member dim changed to a function pointer from a
6597 unsigned char *. Member max_stack_height removed. New members
6599 (macros tab_l, tab_r, tab_t, tab_b) New.
6601 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6603 * ascii.c: (delineate) Assign last_space_nchars before skipping
6604 spaces, to fix right justification.
6606 * crosstabs.q: (static vars risk, direct) New vars.
6607 (static var pearson_r) Removed.
6608 (glob var chisq_fisher) Made static.
6609 (static vars row_tot[], col_tot[]) Don't include grand total
6611 (static var grand_total) Renamed W, all references changed.
6612 (output_pivot_table) Only make `table' if num_cells != 0. Make
6613 risk and directional tables. Deal with grand total no longer part
6614 of col_tot[]. Free rows and cols after we're done with them.
6615 (display_risk) New function.
6616 (display_directional) New function.
6617 (clac_r) Rewritten so that it stores all its results into its
6618 arguments, so it can be used for Spearman's correlation too.
6619 (calc_symmetric) Added a t[] argument, all references changed.
6620 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6621 Pearson's r, Cohen's kappa.
6622 (calc_risk) New function.
6623 (calc_directional) New function.
6625 * som.c: (som_submit) Improved debugging code.
6627 * stats.c: (hypercube) New function.
6628 (cube) New function.
6630 (normal_sig) Went back to old implementation, which actually
6633 * stats.h: (macros square, cube, hypercube) Removed. The
6634 equivalent functions in stats.c are inlined here; all references
6635 to square changed to sqr.
6637 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6639 * crosstabs.q: (N_SYMMETRIC) New define.
6640 (postcalc) Disable debug printing.
6641 (static vars chisq_fisher, pearson_r) New.
6642 (output_pivot_table) Add support for symmetric measures. Add
6643 chi-square output of exact sigs.
6644 (display_chisq) Rewritten.
6645 (display_symmetric) New function.
6646 (gamma_int) New function.
6648 (swap) New function.
6649 (calc_fisher) New function.
6650 (calc_chisq) Check boundary conditions better. Calculate Yates,
6651 Fisher, Mantel-Haenszel tests.
6652 (calc_r) New function.
6653 (calc_symmetric) New function.
6655 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6657 (chisq_sig) Better boundary conditions. Renamed from
6660 * tab.h: (struct tab_table) New member cf.
6662 * tab.c: (tab_create) Set cf.
6663 (tab_width) New function.
6664 (tab_realloc) Handle cf.
6665 (tab_vline) Handle cf.
6666 (tab_hline) Handle cf.
6667 (tab_box) Handle cf.
6668 (tab_value) Handle cf.
6669 (tab_float) Handle cf.
6670 (tab_text) Handle cf.
6671 (tab_joint_text) Handle cf.
6672 (tab_offset) Handle cf.
6673 (tab_next_row) Handle cf.
6674 (evaluate_dimensions) Handle cf.
6675 (render_strip) Handle cf.
6677 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6679 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6680 output_pivot_table().
6681 (output_pivot_table) Moved lots of local variables outside and
6682 made them static. Add beginnings of chi-square statistic
6683 support. Now column and row totals aren't in the main matrix.
6684 Always zero out any leftover rows & columns after we're done with
6685 the table entries. Move all output stuff into
6686 display_dimensions(), display_crosstabs(), display_chisq().
6687 (display_dimensions) New function.
6688 (display_crosstabulation) New function.
6689 (display_chisq) New function.
6690 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6692 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6693 references, simplify logic.
6695 * postscript.c: Remove scale, translate-x, translate-y,
6696 mirror-horz, mirror-vert, rotate-180 options.
6697 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6698 All references deleted.
6699 (macro YT) New macro.
6700 (array option_tab[]) Removed options.
6701 (ps_option) Removed options.
6702 (ps_open_page) Write page setup explicitly to output file, without
6703 using now-deleted BP function.
6704 (macro dump_line) Use YT().
6705 (macro dump_thick_line) Use YT().
6706 (draw_headers) Use YT().
6707 (switch_font) Reorder arguments to SF function.
6708 (write_text) Use YT().
6710 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6713 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6715 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6716 null-debugging code.
6717 (tab_realloc) Remove null-debugging code. Initialize new regions
6719 (tab_vline) Support offsets.
6720 (tab_hline) Support offsets.
6721 (tab_box) Support offsets.
6723 (tab_nulls) Removed.
6726 (evaluate_dimensions) Remove null-debugging code. Understand
6727 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6728 TAB_EMPTY not present.
6730 * tab.h: New cell attribute TAB_EMPTY.
6731 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6733 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6734 try to read them from system files.
6736 * vfm.c: (dump_splits) Don't call tab_null().
6738 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6740 * crosstabs.q: (struct crosstab) Added `missing' member.
6741 (custom_tables) Init missing.
6742 (calc_general) Handle missing values.
6743 (calc_chisq) New function.
6744 (output_pivot_table) Start work on chi-square output. Update for
6745 new tab offset support functions. Shorten statistic names.
6747 * Several files: add in more `const's to placate gcc's warnings.
6749 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6752 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6753 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6754 tab_joint_text) Add col_ofs and row_ofs support.
6755 (tab_offset) New function.
6756 (tab_next_row) New function.
6757 (tab_row) New function.
6758 (tab_col) New function.
6759 (tabi_table) Add col_ofs and row_ofs support.
6761 * vars-atr.c: (is_system_missing) New function.
6763 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6765 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6766 (static var no_cells) Removed.
6767 (static var num_cells) New.
6768 (static var expected) New.
6769 (static var cells[]) New.
6770 (internal_cmd_crosstabs) Deal with new variables.
6771 (postcalc) Removed most of the meat and put it in new function
6772 output_pivot_table().
6773 (output_pivot_table) Calculates and outputs an entire pivot table.
6775 * postscript.c: (postopen) Fix problems with free()ing addresses
6776 not obtained from malloc().
6778 * som.c: (som_submit) Add assertion.
6780 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6783 * tab.c: (static var tab_names[]) New.
6784 (tab_realloc) -1 for nc or nr indicates no change.
6785 (tab_nulls) New function.
6786 (tab_dim) Use tab_names[].
6787 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6788 (evaluate_dimensions) Don't terminate on uninited cells, just put
6789 an X in them and emit a notice. Use tab_names[].
6791 * tab.h: Move bits into tab.def.
6793 * tab.def: New. Don't try to declare tab_table_class because then
6794 som.h has to be included.
6796 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
6798 * command.def: New file, contains all the command definitions
6799 previously included bodily in command.c.
6801 * format.def: New file, contains all of the format definitions
6802 previously split across format.h, format.c, and sfm-write.c.
6804 * lexer.h: Renamed from tokens.h in order to match corresponding
6807 * lexerP.h: Moved some rarely used functions exported by lexer.c
6810 * Makefile.am: Commemorate renamed files.
6811 (EXTRA_DIST) Add command.def, format.def.
6813 * command.c: [0] (walk_cmdtable_func) Removed.
6815 * crosstabs.q: (postcalc) Made it work and print out matrices
6817 (enum_column_values) Renamed enum_var_values, generalized for any
6820 * format.h: (struct fmt_desc) New member `spss'.
6822 * q2c.c: (main) Generated code includes lexer.h instead of
6825 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
6826 instead of an independent translation table.
6828 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
6830 * Lots of source files: Added const to declarations.
6832 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
6834 * arena.c: (arena_clear) Set prev pointer to null when done.
6836 * ascii.c: (ascii_option) Rename index as indx.
6838 * avl.c: This is now a separate library called libavl.
6839 (xmalloc) Make static.
6840 (avl_probe) Step A7 can use the cache instead of an explicit
6842 (avl_delete) Don't maintain a q pointer because it's always
6843 available in the pointer stack. Comment fix.
6845 * avl.h: This is now a separate library called libavl.
6847 * command.c: (cmd_table[]) Remove spurious trailing "".
6849 * common.h: Only include random() fix if this system needs it.
6851 * crosstabs.q: Include alloca headers.
6852 (n_sorted_tab) New global var.
6853 (postcalc) Mostly rewritten.
6854 (find_pivot_extent) Rewritten.
6855 (enum_column_values) Rewritten.
6857 * data-out.c: (convert_F) Rename inner n as n_spaces.
6859 * error.c: (dump_message) Don't have an outer var i.
6861 * file-handle.q: (static var f) Removed. All references removed.
6862 (internal_cmd_file_handle) Uses a local variable instead of f.
6864 * get.c: (trim_dictionary) Change scope of i, i1, i2.
6865 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
6868 * getline.h: Declare getl_history as extern. Reported by
6869 palme@uni-wuppertal.de (Hubert Palme).
6871 * postscript.c: (postopen) Some large mods for constness.
6873 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
6876 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
6878 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
6879 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
6882 * avl.c, avl.h: New files. These form a clean-room
6883 reimplementation of avllib. Iterative algorithms are used in
6884 place of recursive ones, so there is no resemblance in the code.
6886 * Lots of headers: Don't include other headers by default.
6888 * Lots of source files: Explicitly include all needed headers.
6890 * arena.c: (arena_clear) New function.
6892 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
6893 (static var ar) Removed.
6894 (staitc vars ar_tc, ar_col) New.
6895 (cmd_crosstabs) Destroy the arenas.
6896 (internal_cmd_crosstabs) Create the arenas.
6897 (precalc) Don't need a free function for the hash.
6898 (calc_general) Make sure to zero out the trailer on the key data
6900 (print_table_entries) Updated.
6901 (postcalc) Worked on actually implementing.
6902 (find_pivot_extent) New function.
6903 (compare_value) New function.
6904 (enum_column_values) New function.
6906 * data-in.c: (parse_month) Make local array `static const'.
6908 * data-out.c: (convert_date) Make local array `static const'.
6909 (convert_WKDAY) Same.
6910 (convert_MONTH) Same.
6912 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
6913 been renamed to avl_walk().
6915 * hash.c: Rewritten more efficiently.
6917 * hash.h: Add attribute const to hsh_next_prime declaration.
6919 * lexer.c: (id_match) Make arguments const.
6921 * postscript.c: (ps_postopen_driver) Make default fonts the
6924 * q2c.c: (main) Generated code needs stdlib.h.
6926 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
6927 initialized to 0 now, not to NULL. All other references to
6928 avl_traverser were updated in the same way.
6930 * tokens.h: Macro version of id_match updated to use const
6933 * val-labs.c: (inc_ref_count) New function.
6934 (copy_value_labels) Simply through use of new avl_copy() function.
6936 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
6938 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
6939 (postcalc) Worked on this.
6941 * postscript.c: (OPO_DOUBLE_LINE) New enum.
6942 (struct ps_driver_ext) New line_width_thick member.
6943 (ps_preopen_drive) Init line_width_thick.
6944 (option_tab[]) Add line-* options.
6945 (ps_option) Parse line-* options.
6946 (postopen) Add line_width_thick support. Strip leading spaces on
6947 prologue output lines.
6948 (ps_open_page) Include line_width_thick in output.
6949 (macro dump_thick_line) New.
6950 (dump_fancy_line) Support thick lines as well as double lines.
6952 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
6954 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
6955 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
6957 * Many source files: Rename `options' to `pv_opts' as appropriate.
6959 * command.c: (static var cmd_table[]) Add CROSSTABS command.
6961 * common.c: (xcalloc) New function.
6963 * crosstabs.q: New file. Not finished yet, though.
6965 * data-list.c: Comment fix.
6967 * error.c: Remove some old Checker cruft.
6969 * frequencies.q: (dump_full) Cumulate valid percent instead of
6972 * getline.c: Comment fix.
6974 * hash.c: Comment fixes.
6976 * hash.h: (struct hsh_table) Make hash functions return unsigned
6977 instead of int to avoid problems with taking the modulo of
6978 negative return values. All references changed.
6980 * misc.c: (intlog10) Make its table static const instead of auto.
6982 * sfm-read.c: (read_header) Make `prefix' static const instead of
6985 * var.h: (union value) Add member `hash'.
6986 (struct variable) Rename prv_index as `foo'--all references
6988 (typedef pv_opts) Removed. All references changed.
6990 * vars-prs.c: (parse_variables) Message fixes.
6992 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
6994 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
6995 they are being inserted. Don't check for BY variables of
6996 different types. Discard variables if the active file isn't
6997 included in the merge.
6998 (mtf_processing) Essentially rewritten.
6999 (mtf_merge_dictionary) Check for master/slave variables of
7000 different types/widths.
7002 * vfm.c: (static var not_canceled) New var.
7003 (process_active_file) Don't call vfm_source->read() if
7004 there's no vfm-source. Initialize not_canceled.
7005 (process_active_file_write_case) Honor and update not_canceled.
7006 (prepare_for_writing) Rollback changes from yesterday, they were
7008 (close_active_file) Don't destroy vfm_source unless it exists.
7010 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7012 * Lots of source files: Added { } around nested if/else constructs
7013 to avoid new gcc 2.8 warnings.
7015 * data-in.c: (parse_Z) Declare `int' type explicitly.
7018 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7019 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7020 prev members. Put TABLEs at the end of the chain and FILEs at the
7021 beginning. Don't allow the active file in STATE_INIT. Use proper
7022 `seen' value for the active file. Fill out the by members and
7023 make sure they're of consistent type. Do the actual merge
7025 (mtf_processing_finish) New function.
7026 (var_type_description) New function.
7027 (mtf_free_file) New function.
7028 (mtf_free) Rewritten.
7029 (mtf_delete_file_in_place) New function.
7030 (mtf_read_nonactive_records) New function.
7031 (mtf_compare_BY_values) New function.
7032 (static var mtf_seq_no) New var.
7033 (mtf_processing) New function.
7034 (mtf_merge_dictionary) Assign nval members for the system file
7035 dictionary. Assign fv values for its variables. Point each slave
7036 variable to the corresponding master variable.
7038 * hash.c: Include str.h.
7040 * mis-val.c: (copy_missing_values) src arg is const.
7042 * misc.c: (spacing) Make `max' var explicitly int.
7044 * sfm-read.c: (dump_dictionary) Message reformatting.
7045 (sfm_read_case) Add assertion.
7047 * sort.c: Esthetic fixes.
7049 * var.h: (struct match_files_proc) New struct.
7050 (struct variable) Add private data match_files_proc.
7052 * vars-atr.c: (delete_variable) Implement. Add argument for the
7053 dictionary that owning the variable.
7054 (dup_variable) Add assertion.
7056 * vfm.c: Comment fixes, hopefully the comments are correct now.
7057 (process_active_file) New function.
7058 (process_active_file_write_case) New function.
7059 (process_active_file_output_case) New function.
7060 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7062 (write_case) Renamed procedure_write_case(). Now write_case is a
7063 pointer to a function. Style fixes.
7065 1998-03-05 Ben Pfaff <blp@gnu.org>
7067 * Makefile.am: (q2c) Link with libmisc.
7068 (version.c) Define default_config_path, include_path,
7071 * ascii.c: (ascii_postopen_driver) When the default newline string
7072 is requested, open file in text mode. Suggested by
7073 palme@uni-wuppertal.de (Hubert Palme).
7074 (static vars line_buf, line_p) Change from char * to unsigned char
7076 (ascii_close_page) char * to unsigned char *.
7078 * cmdline.c: (parse_command_line) Implement -r option by
7079 prepending ~/.pspp/rc to the list of files to process.
7081 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7082 before pulling in a final line.
7083 (null_func, null_int_func) Removed (dead code).
7085 * descript.q: (display) Calculate width of variable name column
7086 properly. Calculate number of valid cases properly. Reported by
7087 palme@uni-wuppertal.de (Hubert Palme).
7089 * filename.c: (init_filename) Use default_config_path instead of
7090 now obsolete CONFIG_PATH.
7092 * getline.c: (getl_initialize) Use include_path instead of now
7093 obsolete INCLUDE_PATH.
7094 (getl_add_file) New argument `where'. All references changed.
7096 * groff.c: (find_font_file) Use groff_font_path instead of now
7097 obsolete GROFF_FONT_PATH.
7099 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7100 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7101 avoid problems with constness.
7103 * str.h: (macro cs_streq) New macro.
7105 * version.h: (glob var default_config_path, include_path,
7106 groff_font_path) New vars.
7108 1998-02-23 Ben Pfaff <blp@gnu.org>
7110 * Many source files: Change verbose_msg() priority levels and
7113 * aggregate.c: Include debug-print.h.
7115 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7117 (static var pre_syntax_message) Document --safer/-s and
7120 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7122 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7123 because it's not used but it's still copied.
7124 (open_file_r) Remove gratuitous debug message.
7126 * filename.c: (safety_violation) New function.
7127 (open_file) Remove gratuitous debug messages. Don't allow pipe
7128 files if set_safer is set.
7130 * get.c: Turn off debugging.
7132 * getline.c: (getl_add_virtual_file) New function.
7133 (getl_read_line) Add verbose_msg() call for opening new syntax
7135 (getl_perform_delayed_reset) Add a return value describing whether
7136 any action was taken. Call reset_eof().
7138 * getline.h: Comment fix.
7140 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7141 place of incorrect `continue'. Use strtok_r() instead of
7142 strtok(). Always check strtok_r() return value.
7143 (groff_read_DESC) Use strtok_r() instead of strtok().
7145 * lexer.c: (reset_eof) New function.
7147 * main.c: (parse) Get a token after performing a delayed reset
7148 action; allow empty syntax files.
7150 * postscript.c: (output_encodings) Use strtok_r() instead of
7153 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7155 * set.q: Comment fixes.
7156 (glob var set_safer) New var.
7157 (internal_cmd_set) Support SAFER.
7159 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7161 * temporary.c: (free_dictionary) Set d->splits to NULL after
7164 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7165 variable deleted, not if it *isn't* deleted.
7167 1998-02-16 Ben Pfaff <blp@gnu.org>
7169 * command.c: (array cmd_table[]) Add MATCH FILES.
7171 * common.c: Comment fixes.
7173 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7174 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7175 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7178 * expr-opt.c: Include str.h. Problem reported by
7179 palme@uni-wuppertal.de (Hubert Palme).
7181 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7182 (static var mtf_by) Change from char ** to variable **.
7183 (static var mtf_master) New var.
7184 (mtf_merge_dictionary) New function.
7185 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7186 var type. Reorder tests properly. Initialize file->dict. Detect
7187 TABLE= without BY=. Read file dictionaries and merge them. Give
7188 subcommand name with IN, LAST, FIRST error messages. Create IN,
7189 LAST, FIRST variables. Comment fixes.
7190 (mtf_free) Don't free default_dict. Free mtf_master.
7192 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7194 (handle_line_buffer) Cast int to size_t in comparison to avoid
7197 * getline.h: Declare getl_mode extern.
7199 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7200 (groff_read_DESC) Make line_size a size_t.
7201 (match_tok) Parenthesize name to avoid macro expansion.
7203 * mis-val.c: (copy_missing_values) New function.
7205 * postscript.c: (postopen) Make buf_size a size_t.
7207 * sfm-read.c: (dump_dictionary) Make global from static. Print
7208 variable info in parts for easier debugging with Checker.
7210 * temporary.c: (copy_variable) Use copy_value_labels().
7211 (new_dictionary) New arg: whether to copy file label, documents.
7213 * val-labs.c: (copy_value_labels) New function.
7215 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7217 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7219 (dup_variable) Set prv_index, get.fv, get.nv.
7221 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7223 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7225 * Many source files: For ANSI-compliance, add empty statement
7226 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7227 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7229 * data-in.c: (parse_numeric) Some header files break on
7230 -DBL_MIN_10_EXP because they get a --; add () for safety.
7231 Reported by palme@uni-wuppertal.de (Hubert Palme).
7233 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7234 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7235 (dfm_close) Use close_file_ext.
7236 (open_inline_file) Set file.file to NULL, not file.
7237 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7238 struct and use open_file_ext().
7239 (read_record) Use file.file.
7241 * file-handle.q: (prepend_current_directory) Pass through special
7244 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7245 (normalize_filename) Pass through special filenames.
7246 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7248 (dirname) Rename blp_dirname() because of name conflict on some
7249 OS. All references changed. Reported by palme@uni-wuppertal.de
7251 (is_special_filename) New function.
7253 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7254 (trim_dictionary) Conditionalize some of the options on whether
7255 GTSV_OPT_MATCH_FILES is in *options.
7256 (rename_variables) Don't allow variables to be renamed as scratch
7258 (MTF_*) New enum series.
7259 (struct mtf_file) New struct.
7260 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7262 (cmd_match_files, mtf_free) New functions.
7264 * lexer.c: (match_int) Needed parentheses around name to escape
7265 macro expansion. Reported by Micah Altman
7266 <maltman@www-vdc.fas.harvard.edu>.
7268 * print.c: Needed to include alloca.h. Reported by Micah Altman
7269 <maltman@www-vdc.fas.harvard.edu>.
7271 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7272 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7275 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7276 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7278 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7280 * html.c: (struct html_driver_ext) Move into htmlP.h.
7281 (html_preopen_driver) Initialize cp_x, cp_y.
7282 (html_submit) Implement as call to output_tab_table().
7283 (change_attributes) New function.
7284 (escape_string) New function.
7285 (output_tab_table) New function.
7287 * list.q: (write_all_headers) Add code for writing headers for the
7289 (clean_up) Write out the html close-table tag.
7290 (determine_layout) Ignore html driver.
7291 (list_cases) Write html data.
7293 * som.c: (som_submit) Move more of the code into output_table().
7295 * tab.c: (static var hit) Make a global var and rename tab_hit.
7296 (static var tab_table_class) Make a global var.
7298 * htmlP.h: New file.
7300 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7302 * dump-sysfile.c: Removed.
7304 * html.c: (preclose) Change comment in emitted code.
7306 * matrix-data.c: Debugging off by default. Comment fixes.
7307 (static var container) New var.
7308 (cmd_matrix_data) Create and destroy container. Initialize
7309 is_per_factor[] to 0s. Move code into new function
7310 string_to_content_type(). Require split values to be present in
7311 the data when ROWTYPE_ is explicit. Call specific function, not
7312 general read_matrices().
7313 (string_to_content_type) New function.
7314 (context) Exclude all whitespace, not just spaces.
7315 (mget_token) A dot is a number. Add assertion.
7316 (static var data) Renamed nr_data.
7317 (static var factor_values) Renamed nr_factor_values.
7318 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7319 only specific case. Close data_file before exit.
7320 (fill_matrix) New function.
7321 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7322 printing. Style fixes. Message fixes. Move code into
7324 (read_matrices_without_rowtype) Rename
7325 matrix_data_read_without_rowtype(). Fix off-by-one error on
7326 loops. Allocate nr_data[] memory from arena.
7327 (read_matrices_with_rowtype) Removed.
7328 (read_splits) Renamed nr_read_splits(). Style fixes.
7329 (read_factors) Renamed nr_read_factors().
7330 (dump_cell_content) Comment fixes. Arguments changed. Change
7331 debug printing. All references changed.
7332 (output_data) Renamed nr_output_data().
7333 (static var wr_content) New var.
7334 (struct factor_data) New struct.
7335 (static var wr_data) New var.
7336 (static var wr_current) New var.
7337 (matrix_data_source_destroy_source) Removed.
7338 (read_matrices_with_rowtype) New function.
7339 (matrix_data_read_with_rowtype) New function.
7340 (wr_read_splits) New function.
7341 (compare_factors) New function.
7342 (wr_output_data) New function.
7343 (wr_read_rowtype) New function.
7344 (wr_read_factors) New function.
7345 (wr_read_indeps) New function.
7346 (glob var matrix_data_source) Make destroy_source member NULL as
7349 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7351 * lexer.c: (syntax_error) Give better error message when at end of
7354 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7355 N_SCALAR to output as plain N.
7356 (mdump_token) Change output format.
7357 (context) Fix message output interaction with spaces in input.
7358 (another_token) New function.
7359 (force_eol) Improved error message.
7360 (static var max_cell_index) New var.
7361 (read_matrices) Init `cells'. factor_values is now per-cell.
7362 Init max_cell_index.
7363 (read_data_lines) Replace `compare' local with new `compare' arg.
7364 Debugging messages changed. Only read factors if per_factor.
7365 Propagate error return from read_factors(), force_eol().
7366 Copy N_SCALAR values across the N vector.
7367 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7368 check parentheses manually since we now have is_per_factor[].
7369 Call read_data_lines() with new args. Check for end of data after
7370 looping, using another_token().
7371 (read_factors) Arguments changed. Use max_cell_index to determine
7372 whether to read or compare factors. Message fixes.
7373 (dump_cell_content) New function.
7374 (output_data) Completely rewritten because content types were
7375 supported to be nested inside factor values, not vice versa.
7377 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7379 * lexer.c: (syntax_error) Support formatted varargs messages.
7381 * matrix-data.c: Turn debugging on by default.
7382 (static content_type[]) New array.
7383 (static content_names[]) New array.
7384 (static rowtype_, varname_) New vars.
7385 (static is_per_factor[]) New array.
7386 (static split_values) Moved declaration.
7387 (static n_continuous, first_continuous) New var.
7388 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7389 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7390 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7391 Check for continuous variables.
7392 [DEBUGGING] (debug_print) Remove content_names[].
7393 (mdump_token) New macro.
7394 (mget_token_dump) New function.
7395 (mdump_token) New function.
7396 (context) New function.
7397 (mget_token) Fix messages.
7398 (static var data, split_values, factor_values) New vars.
7399 (read_matrices) Manage split_values, factor_values.
7400 (read_data_lines) New function.
7401 (read_matrices_without_rowtype) Implemented.
7402 (read_splits) Message fixes. Uses `just_read'.
7403 (read_factors) New function.
7404 (output_data) New function.
7405 (matrix_data_source_destroy_source) Close the file handle.
7406 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7409 * str.c: (strpadcmp) Removed.
7411 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7413 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7415 * Lots of source files: Add cast to unsigned character to calls to
7416 tolower() and toupper().
7418 * aggregate.c: Set default_dict.splits to NULL.
7420 * command.c: (static variable tab[]) Add MATRIX DATA.
7422 * data-in.c: Add debugging defines. Formatting fixes.
7424 * expr-opt.c: Formatting fixes.
7426 * lexer.c: (syntax_error) Message fixes.
7428 * matrix-data.c: New enum series.
7429 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7430 split_values, n_factors, factors, cells, pop_n, contents,
7431 n_contents) New vars.
7432 (cmd_matrix_data) Finished implementation.
7433 (compare_variables_by_mxd_vartype) New function.
7434 [DEBUGGING] (debug_print) New function.
7435 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7436 (read_matrices) New function.
7437 (read_matrices_without_rowtype) New function.
7438 (read_matrices_with_rowtype) New function.
7439 (read_splits) New function.
7440 (mget_token) New function.
7441 (force_eol) New function.
7442 [0] (test_tokenizer) New function.
7443 (matrix_data_source_destroy_source) New function.
7444 (glob var matrix_data_source) New var.
7446 * misc.h: Include ieeefp.h if present.
7448 * split-file.h: (cmd_split_file) Changes corresponding to struct
7451 * str.h: Fix memmem prototype.
7453 * temporary.c: (save_dictionary, restore_dictionary,
7454 free_dictionary) Changes corresponding to struct dictionary
7457 * var.h: (MXD_* enums) New enum series.
7458 (struct matrix_data_proc) New struct.
7459 (struct split) Removed.
7460 (struct dictionary) Changed `splits' member from `split *' to
7462 (macro force_create_variable) New macro. Replaced lots of
7463 create_variable()/assert() calls with calls to this macro.
7465 * vars-atr.c: (discard_variables) Changed assertion.
7466 [GLOBAL_DEBUGGING] (force_create_variable) New function
7467 called by the macro of the same name.
7468 (clear_variable) Changes to delete splits from the dictionary
7469 corresponding to struct dictionary changes.
7471 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7472 corrupted variable `index' values in the dictionary passed in
7473 every time this function is called.
7475 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7476 to struct dictionary changes.
7478 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7480 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7482 * command.c: New includes.
7483 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7484 (cmd_erase) New function.
7485 [unix] (shell) New function.
7486 (run_command) New function.
7487 (cmd_host) New function.
7488 (cmd_new_file) New function.
7490 * expr-prs.c: (parse_primary) Message fix.
7492 * inpt-pgm.c: Formatting fix.
7493 (cmd_reread) Implement the FILE subcommand.
7495 * matrix-data.c: New file.
7497 * q2c.c: (dump_header) Change output commenting style.
7499 * weight.c: Comment fix.
7501 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7503 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7505 (buf_10x) Renamed buf_1xx, all references changed.
7506 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7507 cases now implemented).
7508 (create_sysfile) New function.
7509 (agr_11x_func) New function.
7511 * data-in.c: (parse_numeric) Work properly if there's an
7512 explicitly coded decimal point in the data and decimal places are
7513 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7514 <el@linux.lisse.na>.
7516 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7517 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7518 Eberhard W Lisse <el@linux.lisse.na>.
7520 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7521 strerror.c. Bug reported by Alexandre Oliva
7522 <oliva@dcc.unicamp.br>.
7524 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7525 (static var separate_case_tab) New var.
7526 (cmd_sort_cases) Cancel temporary transformations here. Free
7527 v_sort before return.
7528 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7529 we're reading from a sort stream. Don't cancel temporary
7530 transformations. Offload internal sorting to do_internal_sort().
7531 (do_internal_sort) New function. Handles internal sorting even
7532 when SEPARATE is nonzero. Doesn't free v_sort.
7533 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7535 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7536 sink if SEPARATE is zero.
7537 (read_output_cases) Renamed read_sort_output(), all references
7538 changed. Now uses separate_case_tab when it exists.
7539 (write_separate) New function.
7541 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7542 memory_sink_cases. Don't redundantly call
7543 vfm_source->destroy_source().
7544 (memory_stream_mode) After switching over, set memory_sink_cases
7547 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7549 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7551 (static var prev_case) New, moved out of aggregate_single_case()
7553 (static var buf64_10x, buf_10x) New.
7554 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7555 the 000, 001, 100, and 101 cases. Free prev_case.
7556 (parse_aggregate_functions) Disallow scratch variables.
7557 (free_aggregate_functions) Only free agr_dict if non-null. Use
7558 iter->function to determine numeric/string type, not
7560 (aggregate_single_case) Don't manage prev_case. Initialize
7561 aggregate info after dumping it.
7562 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7563 mean, stddev, weighted stddev definitions.
7564 (dump_aggregate_info) Implemented.
7565 (initialize_aggregate_info) Renamed from
7566 initialize_aggregate_functions(). Initializes dbl[2].
7567 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7568 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7570 * cases.c: (alloc_val) Removed.
7572 * get.c: (cmd_save_internal) Initialize new `dict' member.
7574 * sfm-write.c: (sfm_write_dictionary, write_header,
7575 write_variable, write_value_labels, write_documents) Reorganize,
7576 simplify for new parameter structure.
7577 (write_variable) Only one variable * argument now.
7579 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7580 replaced by new `dict' member.
7582 * temporary.c: (new_dictionary) Initialize n_documents.
7584 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7586 (init_variable, replace_variable) Eliminate usage of alloc_val().
7588 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7590 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7591 signal that AGGREGATE is to be used for forming final cases.
7592 (close_active_file) Call end_func before stopping lagging. Cancel
7593 temporary after finishing compaction.
7594 (write_case) Comment fixes. Cleaned up.
7595 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7598 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7600 * Makefile.am: (BUILT_SOURCES) Add means.c.
7601 (pspp_SOURCES) Add means.c.
7602 (EXTRA_DIST) Add means.q.
7604 * command.c: (array cmd_table[]) Add MEANS.
7606 * common.h: Esthetic fixes. Comment fixes. Test for
7607 MAX_SHORT_STRING greater than 8.
7608 (macros LOWEST, HIGHEST) New.
7610 * data-in.c, data-list.c, recode.c: Comment fixes.
7612 * means.q: New file, base version.
7614 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7615 with LOWEST, DBL_MAX with HIGHEST.
7617 * q2c.c: (dump_vars) Add an enum to array types giving the number
7618 of values for the enum.
7620 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7621 Replace second_lowest_value with second_lowest_flt64.
7623 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7624 second_lowest_value with second_lowest_flt64.
7626 * t-test.q: Comment fix.
7628 * temporary.c: (restore_dictionary) Esthetic fix.
7630 * tokens.h: (force_match_id, force_match, force_string, force_int,
7631 force_num, force_id) Replace msg() with syntax_error().
7633 * var.h: (struct means_proc) New.
7634 (struct variable) Add mns member to `p' union.
7636 * vars-prs.c: (parse_variable, parse_dict_variable,
7637 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7640 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7642 * Makefile.am: (pspp_SOURCES) Add tab.h.
7644 * Most source files: Added a cast to unsigned char in usages of
7645 the ctype is*() functions. Replaced `end of command expected'
7646 calls to msg() with calls to syntax_error().
7648 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7650 * lexer.c: (hex_val) Removed (was dead code).
7651 (idmatch) Parenthesize function name to avoid macro expansion.
7653 * postscript.c: Comment fixes.
7654 (ps_preopen_driver) Change default font size to 10pt.
7656 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7658 (parse_format_spec) Change system-file format spec argument type
7659 to int32. Parse the format spec with bitwise operators.
7661 * sfmP.h: (struct sysfile_format) Removed.
7662 (struct sysfile_variable) Changed print, write members from
7663 sysfile_format to int32.
7665 * tokens.h: Esthetic fixes.
7666 [__GNUC__] (macro id_match) New macro to hopefully speed up
7667 identifier matching.
7668 (macros match_id, match_tok, match_int) Implemented in
7669 compiler-independent manner; no longer GNU C only.
7671 * vfm.h: Include time.h.
7673 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7675 * data-list.c: (dump_fixed_table) Change tab_dim().
7677 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7679 * error.c: Include command.h.
7681 * frequencies.g: Formatting fixes.
7683 * frequencies.q: Add tab_dim() calls. Make the total cell a
7686 * glob.c: Include command.h.
7688 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7690 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7691 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7692 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7693 the other elements (is this right?).
7694 (read_variables) Use lowest, highest members.
7695 (parse_format_spec) New arg `vv' for more stringent checking.
7696 (dump_dictionary) Byteswaps nonexplicit data.
7697 (sfm_read_case) Byteswap numeric data.
7699 * som.c: Initialize table_num to 1.
7700 (render_segments) Remember to increment y_index after each table
7703 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7704 avl_count() on a NULL tree. No title for the second table.
7705 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7706 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7707 fix call to display_variables().
7708 (display_variables) Default to 4 columns, not 3. Set up headers.
7709 Column title is Variable, not Name. Fix index column.
7710 Add joint text. Add tab_dim(). Handle value labels properly.
7711 Handle DISPLAY LABELS properly. Draw boxes correctly.
7712 (describe_variable) Value labels don't need titles. Don't clear
7713 nonexistent index column.
7714 (compare_vectors_by_name) New function.
7715 (display_vectors) New function.
7717 * tab.c: (tab_height) Add assertion.
7718 (tab_null) Add debug code.
7719 (evaluate_dimensions) Add debug code.
7721 * var.h: (struct variable) get_proc data is sometimes used
7722 simultaneously with other per-procedure info, therefore it was
7723 removed from the union. All references changed.
7725 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7727 * ascii.c: (ascii_close_page) Put title on second line of headers
7728 if there is no subtitle.
7730 * command.c: (glob var cur_proc) Move definition here, from
7732 (cmd_remark) Emit blank line before remarks.
7734 * command.h: (glob var cur_proc) Move declaration here, from
7737 * data-list.c: (dump_fixed_table) Fix messages.
7738 (dump_free_table) Call tab_nat_dim().
7740 * descript.q: (dump_z_table) Modify tab_dim() call.
7742 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7744 (dump_statistics) Don't output header.
7746 * groff-font.c: Minor format fix.
7748 * html.c: Comment fix.
7750 * list.q: (write_varname) Indent after advancing page.
7752 * output.h: Minor reordering.
7754 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7755 a reference to eol[].
7756 (struct ps_driver_ext) New member eol[].
7757 (ps_preopen_driver) Initialize eol[].
7758 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7759 defaults. Handle headers. Fix test for minimum page length.
7760 (static var option_tab[]) Add `line-ends'.
7761 (ps_option) Handle line-ends to change eol[].
7762 (postopen) Scale prop_em_width and fixed_width properly. Set the
7763 prologue title to outp_title if applicable. Replace the prologue
7764 line ends with eol[]. Call draw_headers() if headers are enabled.
7765 (text_width) New function.
7766 (out_text_plain) New function.
7767 (draw_headers) New function.
7769 * print.c: (dump_table) Call tab_nat_dim().
7771 * som.c: (som_blank_line) Only advance a line if not at the top of
7773 (som_submit) Move several informational table calls here.
7774 Increment subtable_num if SOMF_NO_TITLE not set.
7775 (output_table) Advance a line if SOMF_NO_SPACING not set.
7776 (render_columns, render_segments, render_simple) Handle spacing
7777 between tables. Handle table titles. Remove debug output.
7779 * som.h: (SOMF_*) New enum series.
7780 (struct som_table_class) New member `flags'.
7782 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7784 (display_variables) Calls tab_nat_dim().
7785 (describe_variable) Remove restriction on number of value labels.
7786 Make value labels separated by thin lines.
7788 * tab.c: (tab_create) Default `flags' to none.
7789 (tab_float) New arg `w'. All references changed.
7790 (tab_nat_dim) New function.
7791 (tab_output_text) No title or spacing.
7792 (tab_flags) New function.
7793 (tabi_flags) New function.
7794 (tabi_title) New function.
7795 (strip_height) Removed.
7796 (tabi_render) Skip title when necessary.
7797 (static var tab_tab_class) Add tabi_flags, tabi_title.
7798 (evaluate_dimensions) Disable display of column, row size.
7799 (sum_columns) Add title height to top header.
7800 (render_strip) Moved within file.
7802 * tab.h: (struct tab_table) New member `flags'.
7804 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
7806 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
7808 * Most source files: Add `const' attribute in all appropriate
7811 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
7812 column to the variables table for use by describe_variable().
7813 (cmd_display) Disable for the present.
7814 (display_documents) Don't wrap documents.
7815 (display_variables) Table has four columns now.
7816 (describe_variable) Table has four columns now. Don't use a
7817 subtable, use joined cells instead.
7819 * tab.c: (tab_create) Don't set `join'.
7820 (tab_realloc) ct array is not made up of a_string's.
7821 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
7822 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
7823 (text_format) New function.
7824 (tab_title) Rewritten, uses text_format().
7825 (tab_text) Rewritten, uses text_format().
7826 (tab_joint_text) New function.
7828 (static var hit) New variable.
7829 (render_strip) New args r1, r2. Implement joined cells that fit
7831 (tabi_render) Increment hit. Pass new args to render_strip().
7832 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
7833 cells. For t_naw and t_nah, ignore joined cells and null cells in
7836 * tab.h: (struct tab_join_rect) Removed.
7837 (struct tab_table) Removed `join'.
7838 (TAB_JOIN_MAIN) Removed.
7839 (struct tab_joined_cell) New struct.
7840 (TAT_NOWRAP) New enum.
7842 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
7844 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
7846 (ascii_postopen_driver) Fix initialization of *_spacing so that
7847 the TAL_0 bit doesn't count.
7849 * data-list.c: (dump_fixed_table) Use natural width for Format
7852 * glob.c: (rerange) Removed.
7853 (get_date) Formatting fixes. Internationalization fix.
7855 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
7858 * postscript.c: (ps_postopen_driver) Replace
7859 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
7861 * som.c: (som_submit) Don't eject page before every table.
7862 (output_table) Fix order of arguments on call to area().
7863 (render_columns) Fix calculation of max_len.
7865 * tab.c: (tabi_cumulate) Minor change to increase elegance.
7866 (render_strip) New function.
7867 (strip_height) New function.
7868 (tabi_render) Rewrite as calls to render_strip().
7870 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
7871 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
7872 with the TAB_* and OUTP_T_* constants.
7874 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
7876 * Makefile.am: Formatting fixes.
7878 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
7881 * data-list.c: (dump_fixed_table) Add tab_dim() call.
7883 * descript.q: (dump_z_table, display) Add tab_dim() calls.
7885 * dump-sysfile.c: (glob var length) Make type off_t.
7886 (usage) Fix arguments.
7889 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
7890 Now right-justification is the default so many references had to
7892 (struct outp_class) Removed line_width, all references changed.
7893 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
7894 (struct outp_driver) Add elements horiz_line_width,
7895 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
7898 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
7900 (postopen) Initialize all the informational members of
7903 * som.c: (som_blank_line) New function, renamed from blank_line(),
7904 all references changed.
7905 (som_submit) Disables drivers whose pages can't be opened.
7906 (render_columns, render_simple, render_segments) Add debug output.
7907 (render_columns) Fix loop range.
7908 (render_simple) Don't try to render the headers, they're taken
7909 care of automatically. Advance cp_y past the table when done.
7910 (render_segments) Fix loop ranges.
7912 * tab.c: Initialize new members of tab_table.
7913 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
7914 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
7915 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
7918 (tab_dim) New function.
7919 (tab_col_width) Removed.
7920 (tab_row_height) Removed.
7921 (tab_output_text) Call tab_dim().
7922 (tabi_driver) Call evaluate_dimensions(), sum_columns().
7923 (tabi_area) Implemented.
7924 (tabi_cumulate) Implemented.
7925 (tabi_render) Partially implemented, but broken.
7926 (var tab_table_class) Made static.
7927 (evaluate_dimensions) New function.
7928 (sum_columns) New function.
7930 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
7931 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
7932 t_scr, t_srr, t_sentinel. Removed: t_nat.
7933 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
7934 max_stack_height, w, h. Removed: ce, re.
7935 (macro blank_line) Removed.
7936 (glob var zero_length) Removed.
7938 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
7940 * Most source files: include some of the new include files broken
7943 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
7946 * aggregate.c: (glob var outfile) Make static.
7948 * command.c: (glob var pgm_state) Move here.
7950 * common.c: (glob vars endian, second_lowest_value, pgmname,
7951 finished, curdate, cur_proc, start_interactive, history_file) Move
7954 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
7956 * file-handle.q: (glob vars files, inline_file) Move here.
7958 * glob.c: Lost lots of glob vars, detailed in individual file
7960 (init_glob) set_printer, set_screen were obsolete, deleted.
7961 set_cprompt has fewer spaces because pspp has fewer letters than
7964 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
7965 (inp_nval) Made static.
7967 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
7968 tokstr_len, toklongstr, tokint) Move here.
7970 * misc.c: Lost several vars and functions.
7972 * set.q: (all the set_* variables) Move here.
7974 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
7975 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
7978 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
7980 * tab.h: (enum series t_*) New enums.
7981 (struct tab_table) Use arena struct tag. New members ce, re.
7983 * tokens.h: Comment fixes.
7985 * var.h: Move lots of enums and variables and functions and
7986 structures to other files. Use and declare a lot more union and
7987 struct tags. Comment fixes.
7989 * vector.c: (glob vars vec, nvec) Move here.
7991 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
7992 init_blanks, last_vfm_invocation) Move here.
7994 * cases.h: New file.
7995 (struct long_vec) Move here.
7996 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
7999 * command.h: New file.
8000 (STATE_* enums) Move here.
8001 (glob var pgm_state) Move here.
8003 * format.c: New file.
8004 (glob var formats) Move here.
8005 (parse_format_specifier_name, fmt_to_string,
8006 check_input_specifier, check_output_specifier,
8007 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8010 * format.h: New file. Move functions now in format.c here.
8011 (FMT_* enums) Move here.
8012 (struct fmt_desc) Move here.
8013 (FCAT_* enums) Move here.
8014 (struct fmt_spec) Move here.
8015 (glob vars formats, fmt_parse_ignore_error) Move here.
8017 * inpt-pgm.h: New file.
8018 (INP_* enums) Move here, make #defines into enums.
8019 (glob vars inp_init, inp_init_size) Move here.
8022 (glob vars v_sort, nv_sort) Move here.
8023 (sort_cases, read_sort_output) Move here.
8025 * vector.h: New file.
8026 (struct vector) Move here, add struct tag.
8027 (glob vars vec, nvec) Move here.
8028 (find_vector) Move here.
8031 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8032 reinit_blanks, init_zero, init_blanks) Move here.
8033 (struct case_stream) Move here.
8034 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8035 vfm_disk_stream, sort_stream, data_list_source,
8036 input_program_source, file_type_source, get_source, n_lag) Move
8038 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8041 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8043 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8044 (LDADD) Add libdcdflib.
8046 * ascii.c: Comment and formatting fixes. Almost every external
8047 function had an assert added, checking driver_open and page_open.
8048 (ascii_init_driver) Broken into ascii_preopen_driver,
8049 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8050 (ascii_open_page) Sets page_open.
8051 (ascii_close_page) Clears page_open.
8053 * html.c: Comment and formatting fixes. Almost every external
8054 function had an assert added, checking driver_open and page_open.
8055 (html_init_driver) Broken into html_preopen_driver,
8056 html_postopen_driver, html_close_driver. Manages driver_open.
8057 (html_open_page) Sets page_open.
8058 (html_close_page) Clears page_open.
8059 (html_submit) Disabled.
8061 * lexer.c: (parse_string) Remove debugging printf.
8063 * list.q: (determine_layout) Open a page if one is not yet open.
8065 * output.c: Comment fixes.
8066 (add_class) Set the class member of the new list element.
8067 (parse_options) Don't handle device type.
8068 (colon_tokenize) New function.
8069 (configure_driver) New four-field format with a field for device
8070 type. Now initialize driver_open, page_open, next, and prev
8071 fields. Use new colon_tokenize() function. Don't do a memory
8072 copy to replace a driver, it doesn't work; instead delete the old
8073 driver and insert a new one.
8074 (destroy_driver) Don't call som_destroy_driver(). Close the page
8075 if it's open. Find the class in the list of classes and decrement
8076 that reference count. Remove the driver from the global driver
8078 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8079 references changed. Rewritten. Don't return a driver that's not
8081 (outp_eject_page) All references to som_internal_eject_page()
8082 changed to use this. Sets cp_x to 0 as well as cp_y.
8084 * output.h: (OUTP_I_* enums) Removed.
8085 (struct som_submission_form) Removed.
8086 (struct outp_class) init_driver broken into preopen_driver,
8087 postopen_driver, and close_driver. submit changed to take a
8090 * postscript.c: Comment and formatting fixes. Almost every
8091 external function had an assert added, checking driver_open and
8093 (ps_init_driver) Broken into ps_preopen_driver,
8094 ps_postopen_driver, ps_close_driver. Manages driver_open.
8095 (ps_open_page) Sets page_open.
8096 (ps_close_page) Clears page_open.
8098 * som.c: New file, base implementation.
8100 * som.h: (struct som_table) Add struct tag.
8101 (enum SOM_COL_ACROSS) Removed.
8102 (SOM_ROWS, SOM_COLUMNS) New enums.
8103 (struct som_table_class) Add member `cumulate'. Remove `segment';
8104 change `render' arguments.
8105 (struct som_point, struct som_rect) Removed.
8106 (som_submit_table) Fixed typo, should have been som_submit.
8108 * sysfile-info: (describe_variable) Don't try to insert a
8109 subtable; just destroy it for now.
8111 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8112 references to value labels.
8114 * tab.c: (tab_destroy) New function.
8115 (tab_columns) Change argument.
8116 [0] (tab_submit) Remove dead code.
8117 (tab_title) Allocate string from the table's arena.
8118 (tab_output_text) Only free the buffer if we allocated it.
8119 (tab_submit) New function.
8120 (static vars t, d) New static vars.
8121 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8122 tabi_headers, tabi_cumulate, tabi_render) New functions.
8123 (glob var tab_table_class) New global var.
8125 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8126 encapsulate the rectangle. All references changed.
8128 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8130 * All header files updated to use struct tags in addition to
8131 typedefs for all structures. Don't use word `struct' in struct
8134 * Makefile.am: (pspp_SOURCES) Remove html.c.
8135 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8136 all references updated.
8138 * command.c: (parse_cmd) Remove call to som_check_workspace.
8139 (output_line) Update to new som.
8141 * data-in.c: (parse_numeric) A single dot is not an error; it is
8142 the system-missing value.
8144 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8147 * data-out.c: Added `const' as appropriate to many prototypes.
8148 (convert_E, convert_F, convert_CCx) Take double argument instead
8149 of value * argument.
8150 (convert_format_to_string) Call changed functions appropriately.
8151 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8152 make a local copy of the value.
8154 * descript.q: Remove custom_variables() prototype now provided by
8156 (custom_variables) Don't increment sbc_variables, the caller does
8158 (dump_z_table, display) Update to new som.
8160 * error.c: (vmsg) Add const to prototype. Remove code to handle
8161 `too many errors' condition.
8162 (check_error_count) New function.
8163 (msg) Add const to prototype.
8165 * filename.c: (open_file) Rewrite for elegance.
8167 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8168 (dump_full, dump_condensed, dump_statistics) Update for new som.
8170 * list.q: Don't include somP.h. Change all references to
8171 som_driver_ext to refer to the new members of som_driver. Change
8172 som_internal_eject_page() references to outp_eject_page().
8174 * main.c: (parse) Rewrite for elegance. Add call to
8175 check_error_count().
8177 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8178 Rewrite or revise for new outp_driver_class_list structure.
8179 (outp_iterate_enabled_drivers) Fix comparison between disabled
8180 devices and current device type.
8181 (outp_eject_page) New function.
8183 * output.h: Comment fixes.
8184 (struct outp_driver) New members driver_open, page_open, cp_x,
8185 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8187 (struct outp_driver_class_list) New struct.
8188 (outp_class_list) Changed to type outp_driver_class_list; all
8191 * print.c: (dump_table, print_trns_proc) Updated for new som.
8193 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8194 prototypes for custom subcommands.
8195 (dump_subcommand) Always include the `else'.
8196 (dump_parser) Fix comments in output code.
8198 * set.q: Reordered functions.
8200 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8202 * som.h: Rewritten from scratch.
8204 * str.h: Remove dead code.
8206 * tab.c, tab.h: New files, base implementation.
8208 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8211 * t-test.q: New code from John Williams
8212 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8213 Many many new static vars and defines.
8214 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8215 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8216 (struct value_list) New struct.
8217 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8218 t_crt, t_sig, print_t_groups) New functions.
8219 (cmd_t_test) Implemented.
8221 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8224 * vfm.c: (dump_splits) Update to new som.
8226 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8228 * Makefile.am: (fiasco_SOURCES) Add html.c.
8230 * aggregate.c: Base source.
8232 * ascii.c: (postopen, preclose) Reformat.
8234 * data-out.c, expr-evl.c: Comment fixes.
8236 * filename.c: (open_file) When opening a file for writing, use
8237 line buffering instead of full buffering for better interactive
8238 performance. Suggested by Valerio Aimale
8239 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8240 names `stdin', `stdout', `stderr'.
8242 * groff-font.c: Comment fixes.
8244 * html.c: New file; base version.
8246 * list.q: (write_all_headers, clean_up, determine_layout,
8247 list_cases) Ignore `special' devices for now. Needs to be fixed
8250 * output.c: (outp_init) Add html driver to list; reverse list
8253 * output.h: (struct outp_class_struct) New members `special',
8254 `submit'; comment fixes. All references changed.
8256 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8257 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8259 (postopen) Comment fix.
8260 (preclose) Comment fixes, formatting fixes. Change x->file.file
8261 references to more proper f->file.
8263 * som-high.c: (som_submit_table) Special classes use their own
8266 * som.h: Comment fixes.
8268 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8271 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8273 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8275 * aggregate.c: Still working on this.
8277 * command.c: (cmd_table[]) Add AGGREGATE back in.
8278 (split_words) Make '-' a legal word separator as well as ' '.
8280 * main.c: Comment fixes.
8282 * q2c.c: (dump_parser) Don't require the procedure's full name to
8283 be present, in the generated source.
8285 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8286 multiply specified and let it be default; let MISSING, CRITERIA,
8287 FORMAT be multiply specified.
8288 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8289 (custom_groups) Fix defaults.
8290 (custom_pairs) Check whether this is a PAIRS subcommand before
8291 attempting to parse. Better garbage collection. Proper storage
8293 [DEBUGGING] (debug_print) New function.
8295 * temporary.c: Comment fixes.
8296 (copy_variable) Don't copy variable name and index.
8297 (save_dictionary) Copy variable name and index by hand.
8299 * vars-atr.c: Comment fixes.
8300 (create_variable) New dictionary argument. All references
8302 (common_init_stuff) New dictionary argument. All references
8304 (init_variable) New dictionary argument. All references changed.
8305 (dup_variable) New function.
8307 * vars-prs.c: (parse_variables) If there are any errors, we always
8308 return 0. Previously, it was possible for some types of errors to
8311 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8313 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8316 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8318 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8321 * q2c.c: Comment fixes.
8322 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8324 * t-test.q: (cmd_list) Rename cmd_t_test.
8326 * temporary.c: (new_dictionary) Don't declare as static.
8328 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8330 * aggregate.c: Changes, still not finished.
8332 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8334 * q2c.c: Comment fixes. Now its output is internationalized.
8335 (get_token) Fix parsing of escapes within literal strings.
8336 (main) Fix bad #line directives in output.
8338 * t-test.q: Base implementation.
8340 * temporary.c: (new_dictionary) New function.
8341 (restore_dictionary) [__CHECKER__] Change fill character to *
8344 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8346 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8348 * aggregate.c: Changes, still not finished.
8350 * descript.q, list.q: Comment fixes.
8352 * q2c.c: Almost completely rewritten.
8354 * t-test.q: New file, not complete.
8356 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8358 * aggregate.c: Changes, still not finished.
8360 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8363 * temporary.c: (cancel_temporary) New function.
8365 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8366 of doing it by hand.
8368 * vfm.c: (close_active_file) After restoring a TEMPORARY
8369 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8371 (SPLIT_FILE_procfunc) Comment fix.
8373 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8375 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8377 * aggregate.c: New file, not finished yet.
8379 * command.c: (cmd_table) Add AGGREGATE.
8381 * common.h: (pgm_state) Move declaration to var.h.
8383 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8385 (parse_string) Message fix.
8387 * recode.c: Comment fix.
8389 * sfm-read.c: (read_variables) Code esthetic fixes.
8390 (write_header) Default date is `Jan', not `JAN'.
8392 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8394 * sort.c: (cmd_sort_cases) Farm the work out to new function
8395 parse_sort_variables().
8396 (parse_sort_variables) New function.
8397 (sort_cases) New function. Cancels temporary transformations,
8398 which sorting didn't do previously.
8399 (cmd_sort_cases) Better garbage collection on error. Uses
8401 (write_initial_runs, merge_once) Improved code esthetics.
8402 (sort_stream_read) Reduced to one call to read_output_cases().
8403 (read_output_cases) New function.
8405 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8406 variable labels to 120 characters.
8408 * var.h: Comment fixes.
8409 (glob var pgm_state) From common.h.
8411 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8413 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8414 options. Set *names to NULL on error.
8416 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8418 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8420 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8421 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8423 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8425 * vfm.c: (page_to_disk) Added missing local variables.
8427 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8429 * get.c: Comment fix.
8431 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8432 source is anything other than a disk stream, not just if it's in a
8433 memory stream. Call page_to_disk() before external sort.
8434 (allocate_cases) Message fix.
8436 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8438 (page_to_disk) New function.
8440 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8442 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8444 * common.h: (macro strerror) Remove. From Alexandre Oliva
8445 <oliva@dcc.unicamp.br>.
8447 * get.c: (dict_delete_run) The number of variables to delete is
8448 not necessarily the number of variables that need to be shifted
8450 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8451 too many variables to be deleted.
8453 * postscript.c: Comment fix.
8455 * q2c.c: Include strerror.c. From Alexandre Oliva
8456 <oliva@dcc.unicamp.br>.
8458 * set.q: #undef ON and OFF. From Alexandre Oliva
8459 <oliva@dcc.unicamp.br>.
8461 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8462 early, otherwise errors cause a bad free().
8464 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8465 Oliva <oliva@dcc.unicamp.br>.
8467 * temporary.c: (save_dictionary) Don't allocate memory if
8470 * vfm.c: (memory_stream_write) Message fix.
8472 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8474 * command.c: (static var cmd_table[]) Define REPEATING DATA
8477 * common.h: Added support for broken systems that are missing
8478 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8480 * Many source files: Replace syntax error messages via msg() with
8481 call to syntax_error().
8483 * data-list.c: (dump_fixed_table) Add support for dumping table
8484 for REPEATING DATA as well as DATA LIST FIXED.
8485 (cmd_repeating_data) Allows and requires `/' between subcommands.
8486 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8487 CONTINUED specifications to be omitted. Forces CONTINUED to be
8488 specified if ID is. Calculates starts_end, cont_end from logical
8489 record length as reported by fhp. Calls dump_fixed_table() if
8490 requested. Fixed length of record copied by memcpy.
8491 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8493 (realize_value) Returns sensible value for out-of-range variable
8495 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8496 length of occurrences and length of line. Added warning for
8497 fields that exceed the line length. Fixed infinite loop.
8498 (read_one_set_of_repetitions) Numerous minor changes for more
8499 complete SPSS compliance. Message fixes.
8501 * dfm.c: (dfm_close) If the file being closed is the inline file,
8502 read all the remaining data before closing it.
8503 (dfm_get_record) Don't close the file on lossage, as either it
8504 has been closed already or it doesn't belong to us.
8506 * error.c: (puts_stdout) New function.
8507 (vmsg) Use puts_stdout instead of puts.
8509 * file-handle.q: (fh_record_width) New function.
8511 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8514 (input_program_source_read) Made an old kluge an approved method.
8516 * lexer.c: (syntax_error) New function.
8518 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8521 * output.c: (oupt_get_paper_size) Message fix.
8523 * q2c.c: Numerous fixes to formatting of generated code made to
8524 conform to GNU coding standards. Uses syntax_error() in generated
8525 code. Other miscellaneous generated message fixes. Added support
8526 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8527 RAND_MAX, and/or strerror().
8529 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8531 * data-in.c: Comment fixes.
8533 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8534 (find_variable_input_spec) New function.
8535 (cmd_repeating_data) Initializes id_spec.
8536 (rpd_parse_record) Implemented.
8537 (read_one_set_of_repetitions) Returns -3 by default in order to
8538 kluge out some potential bugs.
8540 * data-out.c: Comment fixes.
8542 * file-type.c: (internal_cmd_record_type) Message fix.
8544 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8545 for handling -3 return value.
8547 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8549 * data-list.c: Comment fixes.
8550 (struct dls_var_spec) Reordered members.
8551 (read_from_data_list_fixed) Restructured.
8552 (struct repeating_data_trns) Reordered members. Renamed `starts'
8553 as `starts_beg', `ends' as `starts_end'.
8554 (cmd_repeating_data) Calculates length of repeated data if
8555 necessary and possible.
8556 (parse_num_or_var) Don't allow string variables.
8557 (realize_value) New function.
8558 (rpd_msg) New function.
8559 (rpd_parse_record) New function. Currently stubbed out.
8560 (read_one_set_of_repetitions) Implemented.
8562 * inpt-pgm.c: (input_program_source_read) Comment fix.
8564 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8566 * command.c: (cmd_end_repeat_p) Removed.
8567 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8568 (parse_cmd_name) Removed.
8570 * data-list.c: Comment fixes.
8571 (data_list_pgm) Removed `eof' member.
8572 (static var first) New var.
8573 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8574 FILE TYPE file inside FILE TYPE structures.
8575 (append_var_spec) Appends to *first, not dls.spec.
8576 (parse_fixed) Message fixes.
8577 (struct rpd_num_or_var) New.
8578 (struct repeating_data_trns) New.
8579 (static var rpd) New.
8580 (cmd_repeating_data) New function.
8581 (parse_num_or_var) New function.
8582 (parse_repeating_data) New function.
8583 (read_one_set_of_repetitions) New function.
8585 * file-type.c: (cmd_file_type) Message fixes. Always
8586 default_handle to FILE TYPE file handle.
8587 (internal_cmd_record_type) Message fixes.
8589 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8591 * repeat.c: Comment fix. Disable debugging.
8593 * temporary.c: (restore_dictionary) Sets splits to NULL and
8594 n_splits to 0 before destroying the variables because now doing
8595 this tries to remove split variables.
8597 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8598 destroying the dictionary.
8599 (clear_variable) Removes a variable from splits after destroying
8602 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8604 * cmdline.c: (set_compat) Removed.
8605 (pick_compat) Removed.
8606 (parse_command_line) Removed -c option.
8607 (pre_syntax_message) Removed -c option.
8608 (usage) Remove compatibility code.
8610 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8611 (glob var compat) Removed.
8613 * compute.c: (type_check) Fixed messages about type mismatches.
8615 * data-list.c: (cmd_data_list) Removed compatibility code.
8616 (fixed_parse_compatible) Calls convert_negative_to_dash().
8617 Fixed bug where it only set the variable in fx.spec if it created
8618 the variable itself.
8619 (dump_fmt_list) Spelling fix.
8620 (cut_field) Removed compatibility code.
8622 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8625 * expr-evl.c: (evaluate_expression) Implement LAG.
8627 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8628 (parse_neg) Calls convert_negative_to_dash().
8629 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8632 * expr.h: (struct expression_struct) Removed member max_lag.
8634 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8635 (internal_cmd_record_type) Removed special handling to produce
8636 negative numbers from dash tokens.
8638 * getline.c: (static var DO_REPEAT_level) New var.
8639 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8640 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8641 copy_with_DO_REPEAT_substitutions().
8642 (getl_read_line) Maintains value of getl_mode. Calls
8643 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8645 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8647 * getline.h: (getl_mode) New glob var.
8649 * glob.c: Comment fixes.
8650 (init_glob) Restructured. Sets set_seed.
8651 (init_compat_dependent) Removed. All references removed.
8652 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8653 (__htonl, __htons) Removed. (What were these for?)
8655 * lexer.c: (static var tbl) Dash set to class CNUM.
8656 (make_hexit) New function from data-out.c.
8657 (get_token_representation) Rewritten.
8658 (convert_negative_to_dash) New function.
8659 (lex_init_compat_dependent) Removed.
8660 (yylex) A dash is parsed as part of a number if it is followed by
8661 a digit. The ASCII representation of a number is copied to
8662 tokstr. String parsing farmed out to parse_string(). Comment
8664 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8666 (preprocess_line) Line processing depends on interactive/batch
8667 mode, not on compatibility mode. Removed PC+ compatibility code.
8669 * loop.c: (loop_3_trns_proc) Comment fix.
8671 * main.c: Remove dead code.
8672 (main) Remove call to init_compat_dependent().
8674 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8677 * print.c: (parse_string_argument) Calls
8678 convert_negative_to_dash().
8679 (fixed_parse_compatible) Calls convert_negative_to_dash().
8681 * repeat.c: (RPT_* defines) Removed.
8682 (struct rpt_numeric) Removed.
8683 (struct repeat_entry) New member type, changed `replacement' from
8685 (clean_up) Deallocation adapted to new repeat_entry.
8686 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8687 usage. Creates vars for `type' of 1.
8688 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8689 (store_numeric) Rewritten, new interface.
8690 (parse_numbers) Rewritten.
8691 (parse_strings) Rewritten.
8692 (find_DO_REPEAT_substitution) New function.
8693 (perform_DO_REPEAT_substitutions) New function.
8694 (copy_with_DO_REPEAT_substitutions) Removed.
8695 (debug_print) Rewritten.
8697 * set.q: Comment fix.
8698 (custom_results) Removed compatibility code.
8699 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8702 * sysfile-info.c: (cmd_display) Removed compatibility code.
8704 * tokens.h: Comment fixes.
8705 (token types enum) Removed `toktype' typedef name for this int
8706 type. Removed SUBST. Restructured.
8708 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8710 * vars-prs.c: Comment fix.
8712 * vfm.c: Comment fixes.
8713 (glob var n_lag) New var.
8714 (static vars lag_count, lag_head, lag_queue) New vars.
8715 (procedure) Removed argument nlag.
8716 (setup_lag) New function.
8717 (close_active_file) Discards lagging state.
8718 (lag_case) New function.
8719 (lagged_case) New function.
8720 (write_case) Lags a case if lagging.
8722 * weight.c: (cmd_weight) Removed compatibility code.
8724 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8726 * getline.h: (struct getl_script) New members loop_index, macros.
8728 * getline.c: (getl_add_file) Sets first_line field to NULL.
8729 (getl_add_DO_REPEAT_file) New function.
8730 (handle_line_buffer) When the current line's length is negative,
8731 set the filename and line number. Increment line number after
8732 reading line. Pass the line to
8733 copy_with_DO_REPEAT_substitutions() for processing.
8734 (getl_close_file) Free DO REPEAT lines before freeing the
8735 filename, and just set the filename to NULL when doing this,
8736 because otherwise the filename gets freed twice.
8738 * glob.c: (glob var queuing) Removed. All references removed.
8740 * lexer.c: Comment fixes.
8741 (get_token_representation) New function.
8743 * repeat.c: Comment fixes.
8744 (struct repeat_entry) Replaced type and v union members with a
8746 (append_record) New function.
8747 (internal_cmd_do_repeat) Started reforming it for the new
8748 repeat_entry struct. Properly records filename changes in the
8749 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8750 strncasecmp() result usage. Uses append_record() to simplify.
8751 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8754 (copy_with_DO_REPEAT_substitutions) Started coding.
8756 [DEBUGGING] (debug_print_lines) New function.
8758 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8760 * tokens.h: (macro is_id1, is_idn) New macros.
8762 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8764 * cmdline.c: (static var pre_syntax_message) Changed `win'
8765 compatibility mode to `wnd'.
8767 * data-list.c: (fixed_parse_spss) Renamed
8768 fixed_parse_compatible().
8770 * glob.c: (init_glob) Excise unused code for
8771 program_invocation_short_name.
8773 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8776 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8778 * set.q: `win' compatibility renamed `wnd'.
8780 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8782 * filename.c: [__WIN32__] Change the included Windows header files
8784 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8785 second character is absolute.
8786 (dirname) Fix logic error. Don't printf() the results.
8787 (prepend_dir) Don't printf() the results.
8789 * getline.c: (handle_line_buffer) New function.
8790 (getl_read_line) Reads line with handle_line_buffer() when
8792 (getl_close_file) Discard line buffer data.
8794 * getline.h: Comment fixes.
8795 (struct getl_line_list) New struct.
8796 (getl_script_struct) Added line buffer members. These are hooks
8797 for use by DO REPEAT to allow it to insert virtual source code
8800 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
8801 Override Borland C++ stupidity that claims Windows has a console
8804 * repeat.c: This is in the process of being restructured from
8805 using a token-buffering approach to the DO REPEAT facility to
8806 using the more flexible approach of a line-buffering approach in
8807 conjunction with the getline module. Comment fixes.
8808 (struct tok_struct) Removed.
8809 (static vars queue_index, queue_head, queue) Removed.
8810 (static vars line_buf_head, line_buf_tail) New vars.
8811 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
8813 (pull_queue, destroy_queue) Removed.
8814 [DEBUGGING] (debug_print_tokens) Removed.
8816 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
8818 * file-handle.q: (prepend_current_directory) New function.
8819 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
8820 current directory before normalizing filename.
8822 * filename.c: (gnu_getcwd) New function.
8823 (absolute_filename_p) New function.
8824 (search_path) New argument, PREPEND. All references changed to
8825 pass NULL except those explicitly mentioned. Uses
8826 absolute_filename_p(). Prepends PREPEND before trying the
8828 (dirname, prepend_dir) New functions.
8830 * getline.c: (getl_get_current_directory) New function.
8831 (getl_include) Passes getl_get_current_directory() as PREPEND arg
8834 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
8836 * In several source files, the term `script' was replaced with
8837 `syntax file' inside error messages. Usage of the term `script'
8838 in the sense of a syntax file is now deprecated.
8840 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
8843 * dump-sysfile.c: (usage) Update message.
8845 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
8847 * getline.h: (glob var getl_include_path) Declare extern.
8849 * list.q: Define EXTERN as extern before #including somP.h.
8851 * var.h: Remove declaration of `disptype' variable.
8853 * vfm.c: (close_active_file) After switching the data sink to a
8854 data source, set vfm_sink to NULL, because it doesn't exist any
8857 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
8859 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
8860 _matherrl() to ignore all math errors.
8862 * sfm-read.c: (read_value_labels) When reading the labels from
8863 disk, read the little parts separately instead of as a struct;
8864 this avoids alignment problems.
8866 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
8867 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
8868 (write_header) Allocates and initializes elem_type.
8869 (sfm_write_case) Uses elem_type to determine how to handle each
8871 (sfm_close) Frees elem_type.
8873 * sfmP.h: Comment fix.
8874 [__BORLANDC__] Uses #pragma -a to adjust structure member
8877 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
8879 * Makefile.am: (fiasco_SOURCES) Remove display.c.
8881 * common.c: Fix typo.
8883 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
8884 sense of the condition.
8886 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
8887 line-continuation backslash.
8889 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
8891 * frequencies.q: (custom_grouped, add_percentile) Don't use a
8892 non-constant expression as an argument to sizeof.
8894 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
8895 undefine gettext macro because that's a conio function.
8897 * hash.h: (hsh_prime_tab declaration) Remove.
8899 * list.q: (write_fallback_headers) Move `leader' allocation out of
8900 main loop. Change to local_alloc() allocation.
8902 * output.h: Formatting fixes. Put __attribute__ in right place on
8903 function prototypes.
8905 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
8906 incorrect `SECOND_LOWEST_VALUE' references to proper
8907 `second_lowest_value'.
8909 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
8910 value. This way 2 out of 3 of the som files define the vars
8911 extern, the correct way, that actually works under BC++.
8912 (som_set_float) Don't use nonconstant initializers for a struct.
8914 * som-high.c: Add the standard alloca() header.
8915 (replicate_table) Add prototype.
8917 Merged DISPLAY routine.
8918 * sysfile-info.c: (AS_*) New enum series.
8919 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
8921 (cmd_display, display_macros, display_documents,
8922 display_variables) Stolen from defunct display.c.
8923 (describe_variable) New function.
8925 * temporary.c: [0] (display_tree) New debug function.
8926 (copy_variable) Performs shallow copy of value labels instead of
8927 deep copy; i.e., just copys the AVL tree and increments the
8930 * val-labs.c: Comment fixes.
8931 (do_value_labels) Optionally skip leading forward slash.
8932 (get_label) Creates only a single value label instead of many
8933 copies of one, and sets the reference count.
8935 * display.c: Removed.
8937 * dump-sysfile.c: New file, not yet complete.
8939 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
8941 For lots of source files I added more verbose_msg's. These aren't
8942 listed below as they have tested as being benign. In some cases
8943 these replaced debug_printf() calls.
8945 * output.c: (outp_read_devices) Message fix.
8947 * postscript.c: (output_encodings) Message fix. Reports errors on
8949 (postopen) Message fix.
8951 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
8953 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
8955 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
8958 * main.c: Remove <malloc.h> #include.
8960 * mis-val.c: (parse_numeric) Set .f member for each missing[]
8961 instead of trying to just set the missing[] itself, which is a
8964 * sfm-read.c: (read_variables) Same.
8966 * str.h: Add memmem() prototype.
8968 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
8970 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
8972 * Makefile.am: (q2c) Don't include any libraries in the link.
8974 * dfm.c: (force_line_buffer_extension) New macro.
8975 (count_tabs) New function.
8976 (tabs_To_spaces) New function.
8977 (read_record) Calls tabs_to_spaces() on the line being processed.
8979 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
8980 have to be compiled twice (once for CC, once for LOCAL_CC).
8982 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
8984 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
8985 (LDADD) Add @INTLLIBS@.
8986 (q2c) Add LIBS, @INTLLIBS@ to link step.
8988 * inpt-pgm.c: Turn off debugging.
8990 * postscript.c: (postopen) Format fix. local_free() blocks
8991 returned by local_alloc(); don't free() them.
8993 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
8995 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
8998 * data-list.c: (read_from_data_list_fixed) Pass proper value for
8999 LEN arg, not simply the full string length.
9001 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9002 directories before generic temp file directories.
9004 * vfm.c: Disable debugging.
9006 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9008 * get.c: Comment fix.
9009 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9011 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9013 * expr-prs.c: (debug_print_postfix) Conditionally included on
9014 GLOBAL_DEBUGGING. Removed out_header() reference.
9016 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9018 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9020 * ascii.c: Removed obsolete ascii_close_page() prototype.
9022 * command.c: (output_line) Comment fix.
9024 * data-in.c: Formatting fix.
9025 (parse_string_as_format) Now the `fc' argument is used only for
9026 the purpose of error messages; it is not an index into the string
9027 passed. All references changed.
9029 * data-list.c: Comment fix.
9030 (cut_field) Comment fix. Now returns the column number of the
9031 position of the field cut out on success.
9032 (parse_field) Added `column' argument. Puts the column numbers in
9034 (read_from_data_list_free, read_from_data_list_list) Record the
9035 column number returned by cut_field(), pass it to parse_field().
9037 * dfm.c: Comment fix.
9039 * do-ifP.h: Comment fix.
9041 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9042 the SYSMIS function.
9044 * expr.h, exprP.h: Comment fix.
9046 * glob.c: (init_glob) Only calls setlocale() and family if
9049 * hash.h: Comment fix.
9051 * include.c: Comment fix.
9053 * output.c: Comment fix.
9055 * postscript.c: (ps_line_intersection) Simplified assertion.
9057 * repeat.c: Comment fix.
9059 * vars-atr.c: Comment fix.
9061 * vars-prs.c: Comment fix.
9063 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9064 behavior with usage of postincrement.
9065 (memory_stream_read) Discards cases as it goes.
9067 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9069 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9072 * Most source files: Includes debug-print.h, related comment
9075 * cases.c: (alloc_val) Removed complex allocation code. Merely
9076 increments default_dict.nval and returns the former value.
9077 (envector, devector) Removed references to lv member of struct
9080 * common.h: (macro VME) Replaced complex definition with simple
9083 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9084 read_active_file and cancel_input_pgm.
9085 (read_from_data_list, cancel_data_list) Removed.
9086 (data_list_source_read, data_list_source_destroy_source) New
9088 (glob var data_list_source) New var.
9090 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9091 (cmd_begin_data) Improved criteria for an input program accessing
9092 the inline file. Still not perfect.
9094 * do-if.c: (do_if_trns_proc) Simplified debug output.
9096 * expr-prs.c: Comment fixes.
9097 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9099 * file-handle.q: (fh_close_handle) Simplified debug output.
9101 * file-type.c: Comment fixes.
9102 (cmd_file_type) Sets vfm_source instead of read_active_file and
9104 (cmd_end_file_type) On failure, discards variables in place of
9105 just canceling the input program.
9106 (read_from_file_type) Renamed file_type_source_read.
9107 (cancel_file_type) Renamed file_type_source_destroy_source.
9108 (glob var file_type_source) New var.
9110 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9111 (cmd_get) Initializes options to GTSV_NONE before passing to
9112 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9113 instead of read_active_file and cancel_input_pgm.
9114 (cmd_save_internal) Initializes options before passing to
9115 trim_dictionary(). Local var `nval' removed.
9116 (dict_delete_run) Comment fixes.
9117 (trim_dictionary) Comment fixes. Disallows scratch variables if
9118 GTSV_OPT_SAVE set in options.
9119 (read_from_get) Renamed get_source_read.
9120 (cancel_get) Renamed get_source_destroy_source.
9121 (glob var get_source) New var.
9123 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9124 read_active_file and cancel_input_pgm.
9125 (read_from_input_program) Renamed input_program_source_read.
9126 Simplified debug output.
9127 (cancel_input_program) Renamed
9128 input_program_source_destroy_source.
9129 (glob var input_program_source) New var.
9131 * loop.c: (loop_1_trns_proc) Simplified debug output.
9133 * main.c: (dump_token) Made eof output more explicit.
9135 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9138 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9139 code for always-memory or always-disk cases. malloc's case-list
9140 based on vfm_source_info.ncases. Explicit support for
9141 memory_stream via memory_source_cases.
9142 (do_external_sort) Sets vfm_source instead of read_active_file and
9144 (allocate_file_handles) The temporary directory permissions are
9145 set to 0700 instead of 0777.
9146 (allocate_cases) Formatting fixes. Simplified debug output.
9147 (output_record) Compacts the case if necessary before writing it
9149 (close_handle, open_handle_w) Simplified debug output.
9150 (write_initial_runs) Destroys vfm_sink, then sets it to
9151 sort_stream. Writes records to memory based on
9152 vfm_sink_info.case_size.
9153 (write_to_sort_cases) Renamed sort_stream_write().
9154 (merge) Simplified error handling. Simplified debug output.
9156 (read_from_external_sort) Renamed sort_stream_read().
9157 Reads records based on vfm_source_info.case_size.
9158 (sort_stream_write) Writes records to memory based on
9159 vfm_sink_info.case_size.
9160 (sort_stream_mode) New function.
9161 (glob var sort_stream) New variable.
9163 * temporary.c: (cmd_temporary) Simplified debug output.
9164 (copy_variable) Removed references to `lv'.
9166 * title.c: (get_title) Simplified debug output.
9168 * var.h: Comment fixes.
9169 (struct get_proc) Removed member `lv'.
9170 (struct variable) Removed member `lv'. Comment fixes.
9171 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9173 (struct case_stream) New.
9175 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9176 read_active_file references to use vfm_source.
9177 (init_variable, replace_variable) Removed references to `lv'.
9179 * vfm.c: Comment fixes.
9180 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9182 (static var queue, qh, qt, n_lag) Removed. All references
9184 (glob var compaction_necessary, compaction_nval, compaction_case,
9185 paging) New variables.
9186 (record_case) Removed.
9187 (procedure) Comment fixes. Calls vfm_source->read() instead of
9190 (prepare_for_writing, arrange_compaction, make_temp_case,
9191 vector_initialization, setup_filter) New function.
9192 (open_active_file) Most of the code moved into the abovementioned
9193 new functions. Now sets temp_dict to &default_dict if there is no
9194 temporary dictionary, for convenience. New debug output.
9195 (close_active_file) Deals with changing the sink to the source.
9196 Calls finish_compaction(). Frees compaction_case. Mostly
9198 (glob vars disk_source_file, disk_sink_file) New vars.
9199 (destroy_active_file, read_from_memory) Removed.
9200 (disk_stream_init, disk_stream_read, disk_stream_write,
9201 disk_stream_mode, disk_stream_destroy_source,
9202 disk_stream_destroy_sink) New functions.
9203 (glob var vfm_disk_stream) New var.
9204 (glob vars memory_source_cases, memory_sink_cases,
9205 memory_sink_iter, memory_sink_max_cases) New vars.
9206 (memory_stream_init, memory_stream_read, memory_stream_write,
9207 memory_stream_mode, memory_stream_destroy_source,
9208 memory_stream_destroy_sink) New functions.
9209 (glob var vfm_memory_stream) New var.
9210 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9211 named `more_cases'. Simplified debug output. Otherwise mostly
9213 (record_case) Moved into the stream drivers. Removed.
9214 (transform) Removed (was dead code).
9215 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9216 common case that the splits don't change, we don't need to copy
9217 the case into prev_case again--pointless.
9218 (compact_case) New function.
9219 (finish_compaction) New function.
9221 * vfmP.h: Comment fixes.
9222 (DEV_* enum series) Removed.
9223 (struct storage) Renamed `stream_info'. Removed variant record.
9224 Removed `device' member.
9226 * debug-print.h: New file.
9228 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9230 * autorecode.c: Turned off debugging.
9232 * data-list.c: (destroy_dls) Closes the associated file handle.
9234 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9235 parse_variables() options.
9237 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9239 * display.c: (display_variables) Really fixed null cell bug.
9241 * file-handle.q: (fh_close_handle) Changed debugging message.
9243 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9244 parse_variables() options.
9246 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9247 (cmd_list) Fails if no variables specified.
9248 (determine_layout) Writes blank lines manually.
9250 * loop.c: (loop_1_trns_proc) Made debugging code only print
9251 messages if debugging.
9253 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9254 parse_variables() arguments.
9255 (main) Parses optional parenthesized options to varlist
9256 subcommands into sbc->message.
9258 * sfm-read.c: Format fix.
9260 * var.h: (FV_*) New enum series.
9261 (PV_*) New enum PV_NO_SCRATCH.
9263 * vars-prs.c: (find_var) Removed.
9264 (fill_all_vars) Takes FV_* enum instead of boolean third
9265 argument. Rewritten to deal with scratch as well as system
9267 (parse_variables) Error message on scratch variable if
9270 * vfm.c: (static var virt_begin_func) New var.
9271 (procedure) Sets up virt_begin_func.
9272 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9273 after dump_splits(). For succeeding groups changes, calls
9274 virt_begin_func() instead of begin_func().
9276 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9278 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9281 * dfm.c: Added some debugging messages, disabled by default.
9282 (open_file_r) Fixed error message.
9283 (read_record) On eof on inline_file, instead of calling
9284 fh_close_handle(), simply jump to eof label like a normal file.
9287 * display.c: Thin lines between rows for certain kinds of
9288 listing. Fixed `null cell' bug.
9290 * error.c: (failure) Flush stdout, stderr before failing.
9292 * file-handle.q: (fh_close_handle) Added debugging message.
9294 * frequencies.q: (dump_full) Bottom line extends across entire
9295 table width. Changed title formatting.
9296 (dump_condensed) Changed title formatting.
9297 (dump_statistics) Fixed title formatting.
9299 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9300 Sets default value of set_format.
9302 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9303 Passes write_all_headers() to procedure() as pre-group func.
9304 (write_all_headers) New function.
9305 (determine_layout) Removed calls to write_header().
9306 Calls blank_line() before and after write_fallback_headers().
9308 * recode.c: (recode_trns_free) Only attempts to free head->map if
9311 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9312 file variable names but gives a warning. Sets `left' based on
9313 first character being/not being `#'. On lossage frees dict->var.
9315 * som-high.c: (som_draw_title) Simplified title formatting.
9317 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9319 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9321 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9322 beginning. Frees v_src, v_dest on successful exit. Frees
9323 h_trans[*], h_trans on lossage.
9324 (recode) Frees h_trans[*], h_trans.
9326 * dfm.c: (dfm_close) Formatting change.
9327 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9328 longer allocates its own in inline_file.
9329 (open_file_r) Passes the local dfm_fhuser_ext to
9331 (open_file_w) Message fix.
9332 (read_record) Buffer reallocation strategy changed. Frees
9333 ext->line even in inline_file to prevent leaks.
9334 (dfm_put_record) Fixed bug where `ext' was cached before the file
9335 was opened and thus it would be NULL when the file really was
9337 (cmd_begin_data) Sets up inline_file basics itself, then calls
9338 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9340 * list.q: (write_line) Formatting fix.
9341 (clean_up) Minor strategy change. Sets proportional font after
9343 (determine_layout) Sets fixed font before writing regular headers,
9344 or after writing fallback headers.
9346 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9347 and KEEP vars after using them.
9349 * postscript.c: (ps_init_driver) Frees x->family.
9350 (postopen) When loading fonts, free the temporary font name buffer
9352 (ps_text_set_font_by_position) Free temporary font name buffer
9354 (text) Fixed code that calculated `lig' so that `lig' always gets
9355 initialized. Formatting fix.
9357 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9359 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9360 cells, not xmalloc(), so that the cells will get destroyed
9363 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9366 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9368 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9371 * dfm.c: Comment fix.
9373 * list.q: Comment fixes. Include somP.h. Removed static vars
9374 table, n_columns, n_rows, part. New struct list_ext. New static
9376 (n_lines_remaining, n_chars_width, write_line) New functions.
9377 (cmd_list, list_cases) Rewritten.
9378 (begin_row, end_row, flush_table) Removed.
9379 (write_header, clean_up, write_varname, write_fallback_headers,
9380 determine_layout) New functions.
9382 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9384 * output.h: Comment fix.
9386 * postscript.c: Comment fix.
9387 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9388 added font_size. All references changed.
9389 (ps_init_driver) Initializes font_size. Simplified space checking
9391 (static var option_tab[]) Removed prop-size, fixed-size; added
9393 (ps_option) Handles font_size.
9395 * som-high.c: Moved prototypes into somP.h.
9396 (som_init_driver) New function.
9397 (som_submit_table) Moved some code into new function
9399 (build_target) Moved some code into new function
9400 som_internal_eject_page().
9401 (som_eject_page) Uses som_internal_eject_page().
9402 (som_internal_eject_page) New function.
9404 * som-low.c: Moved prototypes into somP.h.
9406 * som.h: Formatting fixes.
9408 * somP.h: (struct som_driver_ext) Removed em_width;
9409 added prop_em_width, fixed_width.
9411 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9413 * Makefile.am: Added `localedir' definition. Added
9414 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9416 * ascii.c: (macro draw_line) Fixed capitalization.
9418 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9419 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9420 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9421 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9422 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9423 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9424 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9425 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9426 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9427 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9428 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9429 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9430 for internationlization.
9432 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9434 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9436 * do-if.c, sort.c, val-labs.c: Comment fixes.
9438 * glob.c: (init_glob) Uncommented, updated i18n support.
9440 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9441 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9442 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9443 the declarations of macros taking arguments a lot nicer.
9445 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9447 * error.h: Removed CE, CW aliases for SE, SW.
9449 * q2c.c: Removed explicit streq() definition since it's duplicated
9452 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9453 stats.h, str.h, tokens.h: Made the declarations of macros taking
9454 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9457 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9459 * cmdline.c: Comment fixes.
9460 (pick_compat) Changed return type to int. Now, instead of setting
9461 glob var `compat' to the emulation, returns the emulation. All
9463 (parse_command_line) Added terminating null to end of
9464 `long_options' array definition.
9465 (pre_syntax_message) Fixes.
9466 (usage) Shows the default emulation in the syntax message by
9467 calling pick_compat().
9469 * getline.c: (getl_add_include_dir) Separates paths with
9470 PATH_DELIMITER, not DIR_SEPARATOR.
9472 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9473 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9475 * output.c: (outp_configure_macro) Make earlier definitions for a
9476 particular key override later ones for the same key.
9478 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9480 * ascii.c: Comment fixes.
9482 * output.c: (outp_get_paper_size)
9483 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9485 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9487 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9488 <errno.h>. GNU libc 2 enforces this!
9490 * command.c: (parse_cmd) Fixed problem with `else' clause being
9491 paired with wrong `if'. Comment fix.
9493 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9495 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9496 blp_getline() to getline().
9498 * output.c: (outp_eval_dimension) Changed the fix from last time;
9499 there was no variable `a'.
9501 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9503 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9505 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9506 numbers having fractional parts. Added case of a fraction without
9507 a whole-number part.
9509 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9511 * ascii.c: (ascii_text_get_font_position) Removed.
9513 * expr.h, exprP.h: Disabled debugging.
9515 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9518 * output.h: (struct outp_class_struct) Removed
9519 text_get_font_position method. All references deleted.
9521 * postscript.c: Big change here. Fontmaps were completely
9522 eliminated because of a change in philosophy. Comment fixes.
9523 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9525 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9526 `fixed_name' members removed. New members `prop_family',
9527 `fixed_family'. `family' member changed to type char *.
9528 (static var ps_fontmaps) Removed.
9530 (ps_init_driver) Removed obsolete references, updated.
9531 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9532 fontmap, of course. Refers to font names through internal_name
9533 rather than subversive means. Frees proper items.
9534 (static var option_tab[]) Removed `fontmap-file' option; renamed
9535 `fixed-font', `prop-font'.
9536 (ps_option) Corresponds to option_tab[].
9537 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9538 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9539 hash_family) Removed.
9540 (postopen) Generates font names from family names. Gets
9541 PostScript font name properly. New prologue file comment `!!!'
9543 (ps_open_page) Adds translate_x, translate_y to BP prologue
9544 function; gives SF argument floating-point format.
9545 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9546 font name. Doesn't change font family.
9547 (ps_text_set_font_by_position) Generates Groff font name from font
9548 family name instead of through table lookup.
9549 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9550 all references changed. Reduced to simple string assignment.
9551 (ps_get_font_name) Removed.
9552 (ps_get_font_family) Reduced to string return.
9553 (text) Doesn't save `position' since it no longer exists. Ugly
9554 kluge to save font family--fix soon?
9555 (load_font) Removed PostScript name argument.
9557 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9559 * postscript.c: Comment fix.
9560 (ps_open_page) Puts scale factor in PostScript output.
9562 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9564 * Makefile.am: Distcleans q2c.
9566 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9568 * ascii.c: (delineate) Sets text size even if width is zero.
9570 * command.c: Comment fix.
9571 (static var cmd_table[]) Re-enabled EVALUATE command.
9572 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9573 of comments in script files. Now more liberal on criteria for
9574 performing a state transition--if *anything* happened correctly,
9575 not just if *everything* happened correctly.
9577 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9578 Checker segfault on formatting large numbers and why in the fsck
9579 hadn't I noticed this before?
9581 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9583 * list.q: (cmd_list) Commented out the actual output routine
9584 because of various problems. Probably will abandon the idea of
9585 using the general `crushed tables' for the LIST procedure.
9587 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9588 clearing it. Allocates a new var_by_name dictionary before trying
9589 to add members to it.
9591 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9592 `sib'. Changed type of `node' argument.
9593 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9595 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9596 [DEBUGGING] Only deletes the variable from var_by_name if that var
9599 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9601 * Makefile.am: Added include files to SOURCES. Added
9602 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9603 includes rules for q2c. Added `boast' target.
9605 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9607 * Makefile.am: Maintainer-clean Makefile.in.
9609 * Makefile.am: Fixed redundant EXTRA_DIST line.
9611 * ascii.c: Comment fixes.
9612 (ascii_line_vert) Fixed overly aggressive range check.
9614 * display.c: Removed dead code.
9616 * list.q: Turn debugging on.
9617 (flush_table) New debug code.
9619 * sfm-read.c: (read_value_labels) malloc's the structure before
9620 trying to assign to its members.
9622 * sfm-write.c: Comment fix.
9624 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9626 (output_table) No arguments anymore--gets them through `som'
9627 global. New debug code. In crushed tables, now sets `htv' as
9628 well as `hv' to avoid bad confusion later.
9629 (dump_crush_page) New debug code.
9631 * som-low.c: (som_dump_crush_page) New debug code.
9633 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9635 All source files: Broke long lines into multiple lines.
9637 * ascii.c: (ascii_close_page) Uses host_system var in place of
9638 HOST_SYSTEM constant.
9640 * cmdline.c: (var syntax_message[]) Broke into
9641 pre_syntax_message[] and post_syntax_message[].
9642 (usage) Outputs both parts, separated by driver list.
9644 * error.h: Fixed broken formatting.
9646 * expr-opt.c: (str_search, str_rsearch) New functions.
9648 * misc.c: (blp_getdelim) Removed. All references changed to
9650 (str_search, str_rsearch) Removed.
9651 (memrmem) New function.
9653 * misc.h: (blp_getline) Removed. All reference changed to
9658 * filename.c: Includes "stat.h", not <sys/stat.h>.
9659 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9661 * output.c: (outp_list_classes) Changed output formatting.
9663 * sfm-write.c: (write_header) Uses host_system var instead of
9664 HOST_SYSTEM constant.
9665 (write_rec_7_34) Extracts version numbers from the version string.
9668 * sort.c: Includes "stat.h", not <sys/stat.h>.
9670 * str.c: (strcasecmp) Removed.
9672 * title.c: (cmd_document) Uses host_system var instead of
9673 HOST_SYSTEM constant.
9675 * version.c: Generated on-the-fly by the Makefile instead of being
9678 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9680 [!HAVE_STRNCASECMP] Declares strncasecmp().
9682 * version.h: Removed stray character. Comment fixes.
9683 (vars host_system, build_system) New vars.
9685 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9687 * Most source files: Changed formatting of copyright notice; fixed
9688 FSF address; reformatted to better conform to GNU standards;
9689 comment fixes. Added markups to prevent GNU indent from messing
9690 up my beautiful formatting :-).
9692 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9693 that GNU indent markups can be passed through without problems.
9695 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9697 * get.c: Turned off debugging.
9699 * glob.c: (init_glob) Turned on save-file compression by default.
9701 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9702 compression than was possible in save files.
9704 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9706 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9708 * frequencies.q: Removed Fiasco extensions. Updated calculation
9709 algorithms. Polished output format.
9710 (struct frq_info_struct) Removed members `max_degree', `min_n',
9711 all references removed.
9712 (macro frq_extensions) Removed.
9713 (static vars min_n, max_degree) Removed, all references removed.
9714 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9715 calculate `min_n', `max_degree'.
9716 (postcalc) Passes new arg to dump_statistics().
9717 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9719 (dump_condensed) Adds variable name title.
9720 (sum_freqs) Removed.
9721 (calc_stats) Updated calculation algorithm.
9722 (dump_statistics) Removed warning for too-few observations.
9723 Changed table formatting. Adds variable name title if passed new
9726 * output.h: Comment fix.
9728 * recode.c, sample.c, sort.c: Disabled debug code.
9730 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9731 Improved debug code.
9733 * var.h: (enum series frq_*) Removed Fiasco extensions.
9735 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9737 * command.c: Added PROCESS IF to command table.
9739 * Lots & lots of places, removed checks for NULLs preceding calls
9740 to free_expression(), which itself checks.
9742 * descript.q: Removed Fiasco extensions. Removed optimizations
9743 for non-weighted active files. Implemented some options.
9744 Finished polishing output format. Comment fixes. Merged
9746 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9747 max_degree, min_n) Removed.
9748 (macro dsc_extensions) Removed.
9749 (struct dsc_info_struct) Removed `min_n' member, all references
9751 (internal_cmd_descriptives) Removed calculation of min_n,
9752 max_degree. Only deals with one `calc' routine instead of two
9754 (precalc) Eliminated redundancy. Updated for changes to
9755 descriptives_proc structure.
9756 (calc) Moved here from `descript.g'. Rewritten to calculate
9757 statistics via `moments about the mean' rather than by summing,
9758 summing squares, summing cubes, and so on.
9759 (postcalc) Rewritten for new-style statistical calculation.
9760 (display) Removed support for displaying variables across rows.
9761 No longer crushes the descriptives table. Removed ancient code.
9762 Added display of N, by variable and listwise.
9764 * descript.g: Removed; merged into `descript.q'.
9766 * expr-evl.c: (evaluate_expression) Now returns a double. For
9767 numeric results, it returns the result as well as storing it in
9768 the passed `value' structure if non-NULL. For string results it
9769 just returns 0.0 and it must be passed non-NULL. Many references
9770 to this function were optimized by use of this change, especially
9771 but not exclusively in `compute.c'.
9773 * frequencies.g: Comment fix.
9775 * glob.c: (glob var process_if_expr) New global var.
9777 * postscript.c: (static var option_tab[]) Corrected entry for
9779 (postopen) Sets x->size to x->prop_size.
9780 (ps_text_set_font_by_name) Sets font size as well as typeface for
9781 PROP and FIXED fonts.
9783 * sel-if.c: (cmd_process_if) New function.
9785 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9786 (sfm_write_dictionary) Sets `n_cases' to 0.
9787 (sfm_write_case) Increments `n_cases'.
9788 (sfm_close) Attempts to seek the system file back to the header
9789 and write the number of cases in its proper slot.
9791 * som-frnt.c: (som_insert_table) Masks off expansion options since
9792 only SOPT_X_NORM seems to work sensibly.
9794 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
9795 with a `fixed' value of 2.
9797 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
9799 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
9800 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
9802 * var.h: (enum series dsc_*) Removed Fiasco extensions.
9803 (struct descriptives_proc) Removed `miss_noweight'; new members
9804 `X_bar', `M2', `M3', `M4', `min', `max'.
9806 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
9808 * vfm.c: (close_active_file) Cancels PROCESS IF.
9809 (write_case) Doesn't process cases unselected by PROCESS IF.
9811 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
9813 * glob.c: (glob var err) Removed.
9815 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
9816 doesn't have to take into account number of value labels since
9817 they're in a subtable anyway. Also, doesn't display more than 10
9818 value labels since we can't yet break pages in subtables.
9820 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
9822 * som-frnt.c: (som_change_table_size) Simple change for elegance
9823 that shouldn't change behavior.
9824 (som_set_value) Comment fix.
9826 * som-high.c: (som_submit_table) Message fix.
9828 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
9830 * command.c: Added SYSFILE INFO to command table.
9832 * file-handle.q: (fh_handle_filename) New function.
9834 * get.c: (save_trns_proc) Fixed a bug in padding of output data
9837 * main.c: (parse) New return value for command functions, -3.
9839 * misc.h: Comment fix.
9841 * output.h: Comment fixes.
9842 (macro COMPONENTS) Removed.
9844 * postscript.c: (write_text) Modified literal_chars[] so that `('
9845 and ')' are not written to the output in strings as literals.
9847 * sfm-read.c: (sfm_read_dictionary) New argument.
9848 (read_header) New argument. Sets the information structure's
9849 values from the header information.
9850 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
9851 bizarre Checker problem, I guess.
9852 (read_variables) Proper cleanup on lossage.
9854 * sfm.h: (struct sfm_read_info) New struct for use by
9855 sfm_read_dictionary().
9857 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
9858 currently used just for tables that can be dynamically resized and
9859 thus have to be allocated with arena_malloc() instead of
9860 arena_alloc(). All references changed.
9861 (som_change_table_size) New function.
9862 (som_insert_table) Bugfix: now inserts `cell', not `c'!
9864 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
9865 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
9868 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
9870 (draw_intersection) Now takes an argument specifying the table in
9871 question. All references changed.
9872 (draw_table_cell) New function.
9873 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
9874 (som_get_table_size) Many nice new explanatory comments.
9875 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
9877 * som.h: New enum series SOM_CREATE_* for use as create flags with
9880 * str.h: Moved a comment here from TODO.
9882 * sysfile-info.c: New file. Reference implementation.
9884 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
9886 * command.c: Added RENAME VARIABLES to table of commands.
9888 * data-in.c: (dls_error) Sets `cust_field'.
9889 (parse_N) Message fix.
9890 (parse_day_count) New function.
9891 (to_roman) Never outputs VX as a `short form' of V.
9892 (parse_month) Fixed parsing of Roman numerals.
9893 (parse_trailer) Message fix.
9894 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
9895 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
9896 the date is invalid.
9897 (parse_SDATE) Fixed swapped day, year.
9898 (parse_JDATE) Fixed bug for dates in 1582.
9899 (parse_DTIME) Allows days not between 1 and 31.
9900 (parse_numeric) Makes local copy of f.type for easier usage.
9903 * data-out.c: (convert_F) When outputting as scientific, properly
9904 sets f.type as fp->type.
9905 (insert_commas) Fixed operator precedence problem with setting of
9906 nitems. Changed strcpy to memcpy (no null terminator).
9907 (convert_date) Fixed FMT_JDATE: added 1900 to year.
9908 (convert_CCx) Essentially rewritten, but now it works.
9910 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
9912 (display_documents) Implemented.
9914 * error.c: (glob var cust_field) New var.
9915 (vmsg) Displays cust_field as part of message classes DE and DW.
9917 * formats.c: (debug_print) Fixed to compile under updated
9920 * get.c: (cmd_get, cmd_save_internal) Close file handle on
9923 * misc.c: (parse_format_specifier) Formatting fix.
9925 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
9926 `n_rename' for clarity.
9927 (cmd_modify_vars) Initializes `forward' and `positional' at
9928 appropriate times. Frees lists of vars to rename on failure.
9929 Comment fix. Frees memory on success.
9930 (rearrange_dict) Simplified `for' loop condition.
9932 * rename-vars.c: New file (reference implementation).
9934 * set.q: (internal_cmd_set) Fixed `emu' test condition.
9936 * sfm-read.c: (read_header) File label is created only if file
9937 label in file is not blank.
9938 (read_variables) Initializes `dict' local variable.
9939 (read_documents) Proper behavior on lossage.
9941 * sfm-write.c: (write_header) Doesn't blank out the file label
9942 (why was this here to begin with?!)
9944 * temporary.c: (save_dictionary) File label is copied only if
9945 non-NULL. Doesn't try to xstrdup() dictionary documents.
9946 Adapted so as to not irritate Checker.
9947 (free_dictionary) Only destroys var_by_name if non-NULL.
9949 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
9950 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
9951 lines to the document, indents the document. Also, it works now.
9952 (add_document_line) New function.
9954 * var.h: (struct dictionary) Reordering.
9956 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
9957 bits if it was allocated to begin with.
9959 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
9961 * command.c: Added MODIFY VARS to list of commands.
9963 * configure.in: Updated custom macros for autoconf 2.12. Removed
9964 mmap reference; fixed termcap library reference.
9966 * display.c: (display_variables) Fixed a few bugs although it's
9967 still not well written.
9969 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
9970 (induce_segfault) Calls chkr_disp_call_chain() instead of
9971 inducing an actual SIGSEGV.
9973 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
9974 str_search() and str_rsearch(). Fixed tests for matches on
9975 OP_INDEX and OP_RINDEX.
9977 * filename.c: (good_getcwd) Removed as the new libc for Checker
9978 doesn't contain this bug, apparently.
9980 * misc.c: (str_search, str_rsearch) Changed order of arguments for
9981 consistency with GNU memmem.
9982 (blp_getdelim) Changed `len' from `int' to `size_t'.
9984 * modify-vars.c: Reference implementation.
9986 * som-frnt.c: (zero_length) New global var.
9987 (som_create_table) Message fix.
9989 * som.h: Added gcc attributions to som_set_text(),
9990 som_output_text() prototypes. blank_line() refers to
9991 zero_length[] instead of a literal null string to suppress gcc
9994 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
9995 (allocate_cases) Decrements x_max so the last element of x[] can
9996 be used by the algorithm.
9998 * var.h: Changed minor details of `variable' declaration.
9999 (struct modify_vars_proc) New struct.
10000 (struct variable) Added field p.mfv.
10002 * vars-atr.c: Comment fix.
10004 * vars-prs.c: (fill_all_vars) More optimal implementation.
10006 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10007 character, which it shouldn't have to do but printf() seems to
10008 read the null byte even though I supply a maximum length...
10010 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10012 * command.c: Removed command alias X for QUIT.
10013 (parse_cmd) Fixed comment parsing.
10015 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10017 (read_record) Fixed references to len, size.
10018 (dfm_get_record) Restructured.
10020 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10023 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10026 * modify-vars.c: New file. Not complete.
10028 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10031 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10032 problems caused by int/size_t differences.
10034 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10037 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10038 being compared were of equal length.
10040 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10042 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10044 * lexer.c: (get_dotted_rest_of_line) New function.
10046 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10049 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10050 type 6 records. Frees the dictionary properly.
10051 (read_header) Initializes the dictionary instead of letting
10052 read_variables() do it. Sets the dictionary file label from the
10054 (read_documents) New function.
10056 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10057 write type 6 record if appropriate.
10058 (write_header) Writes file label from dictionary.
10059 (write_documents) New function.
10061 * temporary.c: (save_dictionary, restore_dictionary,
10062 free_dictionary) Properly handle new fields in dictionary struct.
10064 * title.c: (get_title) Returns after failure().
10065 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10066 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10068 * var.h: (struct dictionary) New fields `label', `n_documents',
10071 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10073 * command.c: Added FILTER to list of commands.
10075 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10078 * get.c: (cmd_save_internal) Removed weighting code since it's now
10079 handled by sfm-write.c. Properly commented out debug code.
10081 * glob.c: (glob var weighting) Removed.
10083 * sel-if.c: Comment fixes.
10084 (cmd_filter) New function.
10086 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10087 (sfm_read_dictionary) Sets weighting variable direct in the
10088 created dictionary now. (Apparently we previously didn't support
10090 (read_header) Sets weight_index field in sfm_fhuser_ext from
10091 header read from disk.
10093 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10094 (write_header) Now sets the weighting in the header from the
10095 passed primary dictionary instead of from the sfm_write_info.
10097 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10099 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10100 broke on boundary conditions.
10102 * var.h: (struct dictionary) New fields `weight_var',
10103 `weight_index', and `filter_var'.
10104 (glob var weighting) Removed. This is now part of struct
10105 dictionary. All references changed; the less mechanical changes
10106 are described above.
10108 * vars-atr.c: (find_dict_variable) New function.
10110 * vfm.c: (static var filter_index) New variable.
10111 (open_active_file) Initializes filter_index from default_dict.
10112 (write_case) Calls proc_func() only if the filter variable is
10113 nonzero; this implements FILTER behavior.
10115 * weight.c: (static var weight_varname) Removed.
10116 (cmd_weight) Modified default_dict instead of glob vars.
10117 (update_weighting) Changed the signature to modify a dictionary
10118 instead of glob vars. Now returns the weighting variable.
10119 (get_weighting_variable) Removed; its function is absorbed by
10120 update_weighting().
10121 (stop_weighting) Operates on a dictionary now.
10123 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10125 * sort.c: Removed debugging info from messages.
10126 (do_external_sort) Cleans up after itself by deleting the
10127 temporary directory on failure. (On success it is deleted by the
10129 (allocate_cases) Removed debug code. Added clean up code.
10130 (output_record) Removed debug code.
10131 (merge) Added code to close all the input files that are currently
10132 open. This is a likely location for bugs, because I'm not sure
10133 about boundary conditions. Removed an unnecesary heap_delete().
10134 (merge_once) Removed input file "optimization" that in fact
10135 screwed up the rest of the code. Message and comment fixes.
10137 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10139 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10141 * heap.c: (heap_delete) New argument.
10143 * sort.c: Finished implementation of external sort.
10145 * vfm.c: (read_from_disk) Returns after a disk error.
10147 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10149 * sort.c: (static var state) Removed.
10150 (static vars max_handles, tmp_basename, tmp_extname,
10151 huffman_queue) New variables.
10152 (do_external_sort) Moved most code to new functions.
10153 Creates huffman_queue.
10154 (allocate_file_handles, allocate_cases) New functions.
10155 (static vars run_no, run_length, file_index, case_count) New
10157 (output_record) Returns success. Now really writes to the output
10159 (begin_run, end_run) New functions.
10160 (write_initial_runs) Returns success. Initializes run_no to -1.
10161 Calls begin_run(), end_run() at appropriate times. Outputs debug
10163 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10165 (merge) New function.
10167 * heap.c, heap.h: New files. Hopefully in near-final form.
10169 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10171 * glob.c: Added write_active_file to global vars.
10173 * sort.c: Several new miscellaneous static variables.
10174 (cmd_sort_cases) Big comment fix.
10175 (perform_case_2) Renamed `do_external_sort' and completely
10177 (case_2_proc_func) Removed.
10178 (output_record, write_initial_runs, write_to_sort_cases,
10179 compare_record) New functions.
10181 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10183 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10185 * sort.c: (perform_case_2) Changed the method for allocation of
10186 lots of memory--now allocates one case at a time in hopes that
10187 more cases can be allocated with heavily fragmented memory.
10189 * var.h: (write_active_file) New global var.
10191 * vfm.c: (procedure, close_active_file, write_case,
10192 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10193 arguments to procedure() to be NULL. All references to
10194 procedure() that made use of dummy functions were changed to NULL
10196 (open_active_file) If write_active_file is non-NULL, the output
10197 device becomes DEV_PGM (a new enum).
10198 (close_active_file) Sets write_active_file to NULL.
10199 (read_from_memory) Comment fix.
10200 (record_case) Calls write_active_file() when the output device is
10203 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10205 * sort.c: New file.
10207 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10208 Fixed checking for duplicate varnames.
10209 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10211 (autorecode_trns_free) Destroys hash tables for each recoding
10213 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10215 * command.c: Added SORT CASES to cmd_table.
10216 (null_func, null_int_func) Prototyped.
10218 * descript.g: (calc_weight, calc_noweight) Computes own case
10221 * frequencies.q: (dump_statistics) Fixed problem with
10222 too-few-cases warning message.
10224 * get.c: (cmd_save_internal) Handles weighting properly.
10226 * hash.c: (hsh_dump) Output format changed.
10227 (force_hsh_insert) Actually works now, prototype changed.
10229 * list.q: (static var case_num) New variable.
10230 (cmd_list) Initializes case_num.
10231 (list_cases) Increments case_num.
10233 * var.h: Added definitions for SORT CASES. Comment fixes.
10235 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10236 fixes. `active' renamed vfm_active, `rep' renamed
10237 vfm_replacement, all references changed.
10238 (procedure) The procfunc no longer receives a case number. All
10239 references changed.
10240 (write_case) Subtle reordering.
10241 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10244 * weight.c: (get_weighting_variable) New function.
10246 * vfmP.h: New file with definitions from vfm.c.
10248 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10250 * command.c: (FILE_TYPE_okay) Commented out some tests because
10251 they're clumsy and not yet needed.
10253 * var.h: Most *_trns structures moved to their respective source
10254 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10255 (union any_trns) Changed to a typedef for trns_header.
10256 (struct input_program_pgm) Removed.
10258 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10259 was allocated in the first place.
10261 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10263 * autorecode.c: New file.
10265 * command.c: Added AUTORECODE to command table; re-enabled SET.
10267 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10269 * error.c: (vmsg) Comment fixes.
10271 * hash.c: Comment fix.
10272 (hashpjw_d) New function.
10273 (hashpjw) Reimplemented as call to more general function
10275 (internal_comparison_fn) Initializes pointers properly.
10276 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10277 (force_hsh_insert, force_hsh_find) New debugging wrapper
10280 * main.c: (main) Message fix.
10282 * output.c: (outp_read_devices) Message fix.
10284 * set.q: Comment fixes.
10285 (custom_results) Implemented Wnd/X form of subcommand.
10286 (set_routing) New function.
10287 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10289 * settings.h: (SET_ROUTE_*) New enum series.
10290 (set_results) Renamed set_results_file, all references changed.
10291 (set_messages) Removed.
10292 (glob vars set_errors, set_messages, set_results) New vars.
10294 * title.c: (get_title) Remembers to xstrdup() the result of
10295 get_rest_of_line().
10297 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10299 (union any_trns) New element `arc'.
10301 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10303 * command.c: (output_line) Removed references to set_screen.
10305 * error.c: (static var terminating) New var.
10306 (hcf) Sets terminating to 1.
10307 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10308 This prevents an infinite loop if an error occurs within hcf().
10310 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10311 statement circumlocution with `case 42000' trick.
10312 (evaluate_expression) New support for OP_STR_MIS.
10314 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10315 statement circumlocution with `case 42000' trick.
10316 (dump_node) Handles OP_STR_MIS.
10318 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10319 variables exceptions.
10320 (parse_function) Message fix.
10321 (ops[]) Added OP_STR_MIS.
10323 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10325 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10327 * glob.c: Removed set_scrnfile glob var.
10328 (init_glob) set_errorbreak set to 0 by default.
10330 * groff-font.c: Changed included files.
10331 (groff_read_font) Initializes font_arena local var correctly.
10332 (default_font) New function.
10334 * output.c: Comment fixes.
10335 (glob var disabled_devices) New variable.
10336 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10338 [GLOBAL_DEBUGGING] (reentrancy) New function.
10339 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10340 outp_iterate_enabled_drivers) Calls to reentrancy().
10341 (destroy_list) New function.
10342 (outp_done) Moved code to destroy_list().
10343 (parse_options) Parses `listing', `screen', `printer' options
10345 (configure_driver) Sets new `device' member of driver.
10346 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10348 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10349 (struct outp_driver_struct) New member `device'.
10351 * postscript.c: (find_encoding_file) Doesn't display its own error
10353 (default_encoding) New function.
10354 (switch_font) Calls default_encoding() if no encoding can be
10356 (text) Makes up a character metric if none exists for the desired
10358 (load_font) Properly copies a fallback filename. Calls
10359 default_font() for a font if none at all are known.
10361 * set.q: Comment fixes. Removed OUTPUT subcommand.
10362 (custom_listing) Calls outp_enable_device() to enable/disable
10364 (turn_screen_on) Removed.
10365 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10366 screen, printer devices.
10368 * settings.h: Comment fixes.
10369 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10372 * som-high.c: (som_submit_table, som_eject_page) Use
10373 outp_iterate_enabled_drivers() instead of iterating
10374 outp_driver_list directly.
10376 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10378 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10379 (parse_string_as_format) Handles new formats.
10380 (parse_numeric) Now handles DOT and PCT formats.
10382 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10384 (convert_date) Handle EDATE and SDATE formats.
10385 (convert_CCx) Now if there's not room for the currency characters,
10386 converts it as F format if it's positive instead of giving up
10387 quickly. Also fixed save-and-restore bug with decimal point
10389 (convert_format_to_string) Handles new formats.
10391 * misc.c: (formats[]) Added new formats.
10392 (convert_fmt_ItoO) Supports new formats.
10394 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10395 data checking. New argument, all references changed.
10397 * sfm-write.c: (write_format_spec) Supports new formats.
10399 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10402 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10404 * cmdline.c: Comment fixes.
10405 (parse_command_line) Changed return type to void.
10407 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10409 (parse_numeric) Handles international numbers (comma as decimal
10410 point). Some reformatting.
10412 * data-list.c: (parse_free) Default output format is now
10413 set_format instead of hard-coded F8.2.
10414 (read_from_data_list_list) Emits error message on undefined data
10415 only if set_undefined is nonzero.
10417 * data-out.c: (convert_E) Changes decimal point from period to
10418 comma if appropriate. Restructured. Better comments.
10419 (convert_F) Changes decimal point from period to comma if
10421 (insert_commas) Major bug with handling of negative values fixed.
10422 Also, inserts periods instead of commas if appropriate.
10423 (convert_CCx) New function.
10424 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10425 (num_to_string) Changed `.' to set_decimal.
10427 * dfm.c: Comment fixes.
10428 (dfm_close) Frees ext->line even in inline_file.
10429 (open_inline_file) New function.
10430 (open_file_r) When opening the inline file: now properly
10431 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10433 (read_record) Calls fh_close_handle() instead of dfm_close() to
10434 close the inline file. Makes a copy of the line getl_buf to avoid
10435 interlock problems.
10436 (dfm_get_record) Restructured. Now checks the return value of
10438 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10439 checking for use of inline file. No longer tries to close inline
10442 * error.c: (glob var error_already_flagged) New var.
10443 (vmsg) Message change. Now checks max number of errors/warnings,
10446 * file-handle.q: (fh_handle_name) Now allows closing of
10448 (fh_init_files) Reformatted.
10450 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10452 * getline.c: (getl_include) Fixed bug that popped up when called
10453 when file queue was empty.
10454 (read_console) Resets error_count, warning_count,
10455 error_already_flagged to zero.
10457 * glob.c: Many changes to update list of variables.
10458 (init_compat_dependent) Now this function is called whenever
10459 `compat' changes. It now sets set_seed only if it hasn't
10460 previously been referenced. It now calls
10461 lex_init_compat_dependent().
10463 * include.c: (cmd_include_at) Frees temporary buffer instead of
10465 (cmd_include) Doesn't make copy of include file name.
10467 * lexer.c: Comment fixes.
10468 (init_lex) Moved some code into new function
10469 lex_init_compat_dependent().
10470 (lex_init_compat_dependent) New function.
10471 (hex_val) Simplified.
10472 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10474 * main.c: Comment fixes.
10475 (main) Reformatted.
10477 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10478 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10479 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10480 (setup_randomize) Sets set_seed_used.
10482 * set.q: Comment fixes.
10483 (custom_results) Conditionalizes on `compat'.
10484 (custom_log) Calls custom_journal().
10485 (set_ccx) New function.
10486 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10487 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10488 when set_decimal changes. Range-checks values for MITERATE,
10489 MNEST. Message fixes.
10491 * settings.h: Comment fixes.
10492 (struct set_cust_currency) New struct.
10493 (set_cc[], set_grouping, set_seed_used) New global vars.
10495 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10496 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10498 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10500 * glob.c: Revised variables to correspond to settings.h.
10501 (init_glob) Initializes variables from settings.h properly.
10503 * set.q: Began long-overdue major revision to correspond to new
10504 philosophy. Most code changed.
10506 * settings.h: Mostly changed; reorganized, reordered, large new
10509 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10511 * get.c: (cmd_save_internal) No longer forces compression off.
10513 * sfm-read.c: (read_compressed_data) If eof is reached when
10514 reading a new instruction octet, only signal error if we're in the
10517 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10518 (struct sfm_fhuser_ext) New member `end'.
10519 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10520 (ensure_buf_space) New function.
10521 (sfm_write_case) Reimplemented in order to support compression.
10522 (sfm_close) Writes out the remaining contents of the compression
10525 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10527 * command.c: Defined SAVE and XSAVE commands in command table.
10529 * common.h: second_lowest_value is of type flt64, not double.
10531 * file-handle.h: Comment fix.
10533 * get.c: Comment fixes.
10534 (static var `trns') New.
10535 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10536 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10537 (dict_delete_run) Clears the variables and frees them now.
10538 (trim_dictionary) Sets default for compression.
10539 On KEEP subcommand, frees deleted variables as well as clearing
10540 them. Finally got the sense of the test for deleting all
10542 [DEBUGGING] (dump_dict_variables) Message fix.
10544 * glob.c: (init_glob) set_compression set to 1 by default.
10546 * list.q: Properly #includes config.h.
10548 * misc.h: New macro REM_RND_UP.
10550 * settings.h: Comment fix.
10552 * sfm-read.c: (structs sysfile_header, sysfile_format,
10553 sysfile_variable; inline function bswap_int32) Moved to new file
10555 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10556 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10558 (read_machine_flt64_info) Fixed some problems caused by confusion
10559 between flt64 and double types.
10560 (read_header) Message fix.
10561 (read_variables) Fixed set of cases in which we byte-swap sv.print
10562 and sv.write. Fixed confusion of flt64 and double.
10564 * sfm.h: (struct sfm_write_info) New.
10566 * som-high.c: (som_draw_title) Properly frees `s'.
10568 * temporary.c: (save_dictionary) Comment fix.
10570 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10571 (struct trns_header) Formatting fix.
10572 (struct save_trns) New.
10574 * vars-atr.c: (discard_variables) Comment fix.
10576 * sfm-write.c: New file, baseline release.
10578 * sfmP.h: New file, baseline release.
10580 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10582 * cmdline.c: (parse_command_line) `--version' output updated.
10583 (glob var syntax_message[]) Added my e-mail address.
10585 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10586 `illegal' to `invalid'.
10588 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10589 uncompression buffer.
10590 (sfm_close) Frees decompression buffer.
10591 (sfm_read_dictionary) Initializes decompression buffer.
10592 (buffer_input, read_compressed_data) New functions.
10593 (sfm_read_case) Restructured; now calls read_compressed_data() to
10594 handle compressed system file data.
10596 * var.h: Comment fix.
10598 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10600 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10603 * get.c: New comments. New static var `get_file'.
10604 (cmd_get) Now fully implemented. Calls discard_variables();
10605 initializes fv and lv for all variables; new debug code; sets
10606 up the dictionary; sets up the input program.
10607 (read_from_get, cancel_get) New functions.
10609 * sfm-read.c: Comment fixes.
10610 (sfm_close) New static function.
10611 (sfm_read_dictionary) Properly sets up the class of the
10612 file_handle. No longer cares what size the data is in records of
10613 type 7. Also, on failure, properly cleans up the file_handle and
10614 free()s some stuff.
10615 (read_variables) No longer thinks it knows `nval' of the
10616 dictionary. Now sets p.get.fv, etc., instead of speculatively
10618 (read_value_labels) Fixed off-by-one error in indexing of
10620 (sfm_read_case) New function.
10621 (sfm_r_class) New static var.
10623 * var.h: (get_proc) New struct.
10624 (struct variable) New member p.get.
10626 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10628 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10629 the manual's meaning.
10630 (rename_variables) New function.
10631 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10632 code. Now properly reorders the dictionary on the KEEP keyword.
10634 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10635 garbage collection.
10637 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10638 (rename_variable) New function.
10639 (free_val_lab) Reformatted.
10641 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10643 * var.h: Reindented entire file. Comment fixes.
10644 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10646 (glob var default_dict) New.
10647 (struct indirect_dictionary) Removed.
10649 * Many other source files were changed to add `default_dict.'
10650 before all references to the dictionary of the active file.
10652 * vars-atr.c: (make_indirect_dictionary) Removed.
10654 * glob.c: Reindented all variable declarations. Updated for
10655 changed var.h. Comment fixes.
10657 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10658 because now we can mainly copy dictionary structs.
10660 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10661 parse_variables) Takes dictionary instead of indirect_dictionary
10663 (parse_variables) Instead of calling make_indirect_dictionary,
10664 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10665 of `*dict.' references had to be changed to `dict->'. Removed
10668 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10670 * get.c: Added GTSV_OPT_* series of enums.
10671 (trim_dictionary, dict_delete_run) New functions.
10672 [DEBUGGING] (dump_dict_variables) New function.
10673 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10674 [DEBUGGING] Calls dump_dict_variables() to display results.
10676 * glob.c: (cmp_variable) Now a public function declared in var.h.
10678 * sfm-read.c: Turned off debug code. Comment fixes.
10679 (read_machine_int32_info, read_machine_flt64_info) New functions
10680 to parse type 7 records.
10681 (sfm_read_dictionary) Properly byteswaps several fields now.
10682 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10683 records. [DEBUGGING] Dumps dictionary.
10684 (read_variables) Sets `index' field of variables created properly.
10685 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10686 longer dumps dictionary.
10687 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10689 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10691 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10692 var before destroying any variables just to save a little time.
10694 * var.h: (struct variable) Reordered in order to make name[] the
10695 first member; this makes pointers to `variable' pointers to the
10696 variable name, simplifying avl trees, etc.
10697 (struct indirect_dictionary) New struct.
10699 * vars-atr.c: (find_variable) Rewritten for efficiency.
10700 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10702 (is_varname) Rewritten for efficiency.
10703 (parse_variables) New argument, which is a `dictionary *'. All
10704 references changed. This function now reads variable names from
10705 the dictionary passed, or from the default dictionary if NULL.
10707 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10709 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10710 rounding up. Changed many references to ROUND_UP to use this
10713 * sfm-read.c: Includes avl.h.
10714 (corrupt_msg) Induces a segfault under Checker.
10715 (macro assertive_bufread) New. Many references to bufread() now
10717 (sfm_read_dictionary) Split up into several functions. Added code
10718 to read dictionary records following the the type 2 records. Not
10719 quite complete. New variable `var_by_index'.
10720 (read_header, read_variables) New functions extracted from
10721 sfm_read_dictionary().
10722 (read_value_labels) New function.
10723 (bufread) Checks ferror() if fread() doesn't return the expected
10724 value; if ferror() is zero it's just EOF.
10725 (dump_dictionary) Stubbed out.
10727 * BTW: The source code now exceeds 50000 lines!
10729 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10731 * command.c: Added GET to cmd_table[].
10733 * list.q: Removed reference to alloca headers.
10734 (cmd_list) Gave prototype.
10736 * sfm-read.c: Added DEBUGGING comments.
10737 (sfm_read_dictionary) Checks bias correctly. Sets
10738 dict->var_by_name to NULL. Calculates long_string_count
10739 correctly. realloc's dict->var[] array to minimum size.
10740 [DEBUGGING] Calls dump_dictionary.
10741 [DEBUGGING] (dump_dictionary) New function.
10743 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10744 (restore_dictionary) If the dictionary contains a non-NULL
10745 var_by_name, uses that instead of generating one.
10746 (free_dictionary) Destroys var_by_name.
10748 * var.h: (struct dictionary) Added field `var_by_name'.
10750 * get.c: New file, not complete.
10752 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10754 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10755 (parse_num_or_range) New function.
10756 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10757 <n> THRU HIGH missing values.
10759 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10760 __attribute__((const)).
10762 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10764 * sfm-read.c: Finished reference implementation.
10766 * sfm.h: Includes var.h.
10768 * var.h: Comment fixes.
10769 (struct `variable') Reordered some fields.
10771 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10772 constants added previously.
10774 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10776 * common.h: Comment fixes. Added declaration of
10777 `second_lowest_value' as variable or macro. Made `compat_type',
10778 `pgm_state_type' into anonymous enums.
10780 * display.c: Comment fix.
10782 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10784 [!defined SECOND_LOWEST_VALUE] Added definition for
10785 `second_lowest_value' global var.
10786 (compat, pgm_state global vars) Changed types to `int'.
10787 (init_glob) Initializes `second_lowest_value'.
10789 * sfm-read.c: Continued work, not complete.
10791 * var.h: Added new MISSING_* constants to handle LOWEST and
10794 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
10796 * sfm-read.c: New file, not complete.
10798 * cases.c: (vec_insert) Changed vector expansion algorithm.
10799 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
10800 mucking up the RECODE transformation in particular.
10801 (envector) Harmless change in notation.
10803 dfm is now fairly well tested again.
10804 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
10806 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
10808 * recode.c: Comment fix.
10810 * sfm.h: Interface should be fairly final now, or at least for a
10813 * vfm.c: [DEBUGGING] (index_to_varname) New function.
10814 (open_active_file) [DEBUGGING] Translates ccase indices into
10815 variable names now to make it easier to understand what's really
10818 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
10820 * data-in.c: Comment fix.
10822 * data-list.c: Includes dfm.h.
10823 (do_reading) Uses new function dfm_push_cust().
10825 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
10826 `return 1;' at end.
10828 * file-handle.h: Completely changed. Some parts split off into
10829 new file dfm.h. Implemented in file-handle.q.
10830 (enum FH_*) Removed.
10831 (struct fh_ext_class) New struct.
10832 (struct file_handle) Retained only these fields: name, norm_fn,
10833 fn, recform, lrecl, mode. New fields class, ext.
10834 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
10835 close_handle, handle_name) Added `fh_' prefix to name, all
10836 references changed.
10838 * dfm.h: New file, implemented in dfm.c.
10839 (get_record, put_record, fwd_record, bkwd_record, set_record,
10840 get_cur_col) Functions moved from file-handle.h, now prefixed with
10842 (dfm_push_cust) New function.
10844 * sfm.h: New file. Incomplete.
10846 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
10847 interface. Functions reordered, comments changed. Not well
10848 tested, probably full of bugs.
10849 (struct dfm_fhuser_ext) New struct.
10850 (dfm_close) New function.
10851 (open_file_r) Pickier about finding `BEGIN DATA.' line.
10852 (open_file_w) User messages changed.
10853 (get_record) Comment fixed.
10854 (read_record) Increments ext->ln even for inline_file. Calls
10855 dfm_close() for inline_file when `END DATA.' encountered.
10856 (dfm_get_record) Experimental restructuring.
10857 (dfm_push_cust) New function.
10858 (cmd_begin_data) Detects whether the inline file was fully read by
10859 checking whether it is still open; detects whether it was read at
10860 all by checking whether the line number is greater than zero.
10862 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
10863 interface. Functions reordered, comments changed. Not well
10864 tested, probably full of bugs.
10865 (init_file_handle) Removed initializers for obsolete fields, added
10867 (fh_close_handle) Much simpler, now mainly calls the class
10869 (fh_init_files) Renamed inline file internal filename.
10871 * file-type.c: Includes dfm.h.
10872 (read_from_file_type) Doesn't use dfm internal state anymore.
10874 * inpt-pgm.c, print.c: Include dfm.h.
10876 * recode.c: (internal_cmd_recode) Casts strlen() return value to
10877 int in comparison with other int.
10879 * som-high.c: (build_target) Fixed operator precedence problem in
10880 if statement (& versus ==).
10882 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
10884 * dfm.c: (read_record) Can now read fixed-length records; not
10886 (put_record) Can now write fixed-length records; not tested.
10888 * file-handle.h: FH_* defines changed to enums. New enum series
10890 (struct file_handle) New members recform, lrecl, mode.
10892 * file-handle.q: Parser changed.
10893 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
10894 /LRECL subcommands. These are compatible with Windows.
10895 (init_file_handle) Initializes recform, mode fields.
10897 * q2c.c: (get_line) When outputting `!' comment lines, now
10898 increments the output file line number so that `#line' directives
10900 (make_identifier) New function that converts an arbitrary string
10901 into a valid C identifier.
10902 (dump_vars) Calls make_identifier() in two places in order to
10903 suppress some errors for bad identifiers.
10904 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
10905 for NO. Allows numbers to be prefixed by underscores to make them
10906 acceptable C identifiers but still to be parsed as numbers by the
10909 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
10911 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
10913 * dfm.c: Comment fixes. (get_record) Gives error if file handle
10914 was opened for writing.
10915 (open_file_w) New function.
10916 (read_record) Uses strncasecmp if available. Improved error
10917 messages, comments.
10918 (put_record) New function.
10920 * file-handle.h: Moved function comments into dfm.c and
10921 file-handle.q. Comment fixes. Removed declarations of
10922 tilde_expand() and normalize_filename().
10923 (struct file_handle) Changed `open' from boolean to enumerated
10924 field to allow for three states--closed, open for reading, open
10925 for writing--all references changed.
10927 * file-handle.q: Includes filename.h.
10929 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
10930 references changed.
10931 (alloc_line) Makes allowance for line terminator characters in
10933 (print_trns_proc) Now handles OUTFILE, WRITE differences.
10934 (print_space_trns_proc) Handles OUTFILE differences.
10936 * recode.c, sample.c: Comment fixes.
10938 * var.h: (struct print_trns) Changed boolean field `eject' to
10939 bitmapped field `options'; all references changed. New enums
10940 PRT_* for use with this field.
10942 * exception.h, test-exception.c: Removed.
10944 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
10946 * ascii.c: (delineate) Turned off debug output.
10948 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
10951 * data-in.c: (parse_string_as_format) Sets the entire string value
10952 to spaces, not just the short string part of it. Is this correct
10955 * data-out.c: (convert_date) Fixed DATETIME format problems with
10956 decimal places, removed debug code.
10958 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
10959 middle of parsing BEGIN DATA that would cause the lexer to read
10960 from a wild pointer `prog'; now calls new function
10961 preprocess_line() in lexer.c.
10963 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
10965 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
10966 Now call induce_segfault() to induce the segfault.
10967 (induce_segfault) New function.
10969 * expr-opt.c: Comment fix.
10970 (parse_sysvar) New function.
10971 (parse_primary) Added system variable support--calls
10973 (global var ops) Added OP_CASENUM operator.
10975 * expr.h: Comment fixes.
10976 (OP_* enum) added OP_CASENUM operator.
10977 (struct casenum_node) New struct.
10978 (union any_union_union) New member `cas' of type `casenum_node'.
10980 * glob.c: (global var last_vfm_invocation) New var.
10981 (init_glob) Initializes last_vfm_invocation.
10983 * lexer.c: (lookahead) Fixed reversed condition on if statement.
10985 * getline.c: (get_line) Split into get_line() and preprocess_line().
10986 (preprocess_line) New function.
10988 * var.h: Declares last_vfm_invocation.
10990 * vfm.c: (procedure) Sets last_vfm_invocation.
10992 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
10994 * command.c: (parse_cmd) Fixed bad assertion related to
10997 * data-in.c: (parse_month) Implemented to parse months according
10998 to full interpretation of standard.
10999 (to_roman) New function.
11000 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11001 (parse_weekday) Bug fix (forgot to skip all the day name).
11003 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11004 up parsing of multirecord data items. Also fixed user message.
11006 * data-out.c: Comment fix.
11007 (year2, year4, convert_date, convert_time, convert_WKDAY,
11008 convert_MONTH) New functions to support time & date output.
11009 (convert_format_to_string) Calls new time & date output routines.
11011 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11013 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11016 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11018 * misc.c: (global var formats) Fixed declarations of DATETIME,
11021 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11022 the output_char buffer.
11024 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11025 memory bug. Fixed user messages.
11027 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11029 * Removed #pragma argsused from lots of places.
11031 * data-in.c: Implemented zoned decimal and time-date formats.
11032 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11035 * data-out.c: Implemented zoned decimal format.
11037 * expr.h: Moved yrmoda() declaration here from exprP.h.
11039 * misc.c: (global var formats) Minor fixes--added
11040 FCAT_SHIFT_DECIMAL to formats N and Z.
11041 (convert_fmt_ItoO) Added support for format Z.
11043 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11045 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11047 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11048 som_check_workspace() that is activated between commands.
11050 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11053 * list.q: (begin_row) Changed title expansion style from
11054 SOPT_X_VERT to SOPT_X_SHSP.
11056 * som-frnt.c: Now includes `somP.h'.
11057 (som_push_workspace, som_pop_workspace) New functions that, taken
11058 together, form a solution to the recursive table building problem
11059 mentioned yesterday. Surrounded every table output routine
11060 throughout the program with calls to these functions.
11061 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11062 (som_create_table) Checks that there's an active workspace.
11063 (som_destroy_all_tables, som_crush) Removed.
11065 * som-high.c: (global var som_preserve_tables) Removed, all
11066 references deleted.
11067 (som_submit_table) Checks that there's an active workspace.
11068 (dump_columnated_table) Doesn't columnate tables that would have
11069 just one row per column.
11070 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11071 (som_dump_crush_page) Moved row number labels from left side of
11072 tables to right side.
11073 (som_get_table_size) Added support for SOPT_X_SHSP.
11075 * som.h: New cell expansion type SOPT_X_SHSP.
11077 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11079 (global var curtab_arena) Moved from som-frnt.c.
11081 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11083 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11084 that causes bad location warnings to be suppressed.
11085 (delineate) Saves current font when calling draw_text(); fixed
11086 handling of NULLs when backing up. Also fixed line-wrapping bug.
11088 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11089 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11091 * common.c: Added code to cause assertion failure to dump core
11092 when run under Checker.
11094 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11095 there are still bugs.
11097 * glob.c: (__eprintf) Removed.
11099 * list.q: Inserted som_preserve_tables kluge that prevents tables
11100 from being thrown away due to recursive table building through
11101 som_output_line being called from a transformation during the LIST
11102 procedure invocation. This is a general problem that must be
11103 solved in a better way since it applies to all procedures in
11105 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11106 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11108 * numeric.c: Fixed several errors in the form of msg() calls.
11110 * print.c: Updated for use of som.
11111 (dump_table) Reimplemented.
11112 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11113 Calls som_output_text() instead of outs_line().
11115 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11117 (som_output_text) Function moved from som-low.c. Interface
11120 * som-high.c: (som_preserve_tables) New global public variable
11122 (som_submit_table) Destroys the tables only if som_preserve_tables
11124 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11125 one subrow per row. Now labels subrows if there's more than one
11127 (dump_crush_table) Added wishlist comment.
11128 (som_eject_page) New public function declared in som.h.
11130 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11131 more than one subrow per row.
11132 (som_output_text) Moved to som-frnt.c.
11134 * som.h: (SOM_TOPT_PRESERVE) Removed.
11136 * title.c: (get_title) Changed interface.
11137 (cmd_title) Changed `title' to `outp_title'.
11138 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11140 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11142 * list.q: (flush_table) Conforms to new partial options in
11143 som_submission_form.
11145 * som-high.c: (paginate_horizontally) Changed form of subrow
11147 (build_target) Omits spacing before table if
11148 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11149 (dump_crush_page) Changed interface. Only trims bottom rule if
11150 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11151 (dump_crush_table) Handles partial tables.
11152 (output_row_label) New function.
11153 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11154 rule on the right edge of narrow subrows.
11156 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11157 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11158 All references updated.
11160 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11162 * misc.c: Comment fix.
11164 * som-high.c: (examine_table) Treats crushed tables separates for
11165 purpose of determining header size.
11166 (paginate_horizontally) Allots space for line numbers in crushed
11167 tables with lots of subrows per row. Calculates the `maximum page
11168 width', the width of the widest horizontal page.
11169 (build_target) Removed trim argument; all references changed.
11170 Stricter assertions. (dump_crush_page) New function.
11171 (dump_crush_table) Reimplemented.
11173 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11174 (som_dump_crush_page) Reimplemented, interface changed.
11176 * somP.h: Many many new helper macros for use with crushed tables.
11177 (global var som) Removed `tv', `cum_y' members; all references
11178 removed. New members `mpw', `digit_space'.
11180 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11182 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11183 variable, changed to constant 1024.
11184 (arena_ca_strdup) Changed `sizeof(a_string)' to
11185 `sizeof(c_string)'.
11186 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11187 `(c_string *)' to `(char *)'; this fixed some offset problems.
11189 * filename.c: (readlink_malloc) Changed initial allocation from
11191 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11194 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11195 &fm->owner in several places.
11197 * som-high.c: (output_table) Changed interface to rest of world.
11198 (examine_crush_table) Removed. Crushed tables are re-broken now,
11199 in preparation for rewrite.
11201 * som.h: Comment fix.
11203 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11205 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11206 itself in the cleanup stage.
11208 * descript.q: (display) At least temporarily, changed the table
11209 format to a crushed table.
11211 * list.q: (begin_row) At least temporarily, added horizontal lines
11214 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11215 the horizontal "headers," that is, to the width of the far left
11216 and far right rules.
11217 (justify_pagination) Sets som.th to the width of the widest row
11218 in the crushed table. Fixed inner loop off-by-one error.
11220 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11223 * somP.h: Comment fix.
11225 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11227 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11228 before closing it; also, opens the constructed filename `s'
11229 instead of f->filename.
11231 * postscript.c: Moved initialization of x->loaded, x->prop,
11232 x->fixed, x->current, also the add_encoding() calls, into
11234 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11235 sets x->last_font to NULL; sets x->next_combo to zero.
11237 * som-high.c: (crushed_row_height) Moved definition farther up.
11238 (som_submit_table) Doesn't calculate line width, font size until
11239 after calling open_page(), to accomodate changes to PostScript
11241 (vert_headers) Removed; equivalent functionality moved to
11242 examine_table(), examine_crush_table().
11243 (justify_pagination) Replaced with different algorithm.
11244 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11245 at the bottom of the page.
11247 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11249 * command.c: Added cmd_list back into cmd_table.
11251 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11252 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11254 * list.q: (flush_table) Updated to new som_submission_form format.
11256 * som-frnt.c: Comment fix.
11258 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11259 (output_table) Calls som_get_table_size() directly; handles
11261 (examine_crush_table) New function; calls vert_headers().
11262 (examine_table) Moved some code into new function, vert_headers().
11263 (justify_pagination) New function.
11264 (dump_plain_table) Removed `static' from `cy'.
11265 (dump_crush_table) New function.
11267 * som-low.c: (som_dump_crush_page) New function.
11269 * som.h: Comment fixes.
11270 (enum SOM_TOPT_CRUSH) New.
11271 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11272 Temporarily set to zero to make do with LIST procedure.
11274 * somP.h: Re-ordering.
11276 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11278 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11280 * somP.h: New file for use by som-high.c, som-low.c.
11282 * q2c.c: Added definition for VME.
11283 (get_line) Now dumps `!' comment lines to the output file
11286 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11287 set.q: Changed format of `!' comment lines.
11289 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11291 * All source files: Added copyright notice.
11293 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11294 longs in msg() calls.
11296 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11298 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11300 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11302 * output.c: (outp_read_devices) Changed criteria for
11303 distinguishing different types of lines.
11305 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11307 * cmdline.c: Changed syntax message.
11309 * filename.c: (good_getcwd) Bug fix (?).
11310 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11312 (search_path) Appends DIR_SEPARATOR to directory name only if it
11313 does not already end with one.
11315 * glob.c: Checks STAT_PAGER envvar before PAGER.
11317 * output.c: Checks environment variables instead of just local
11320 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11322 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11323 when the pointer passed to the function was within the arena
11324 itself, so that it couldn't properly be set to NULL _after the
11327 * command.c: Re-enabled DISPLAY.
11329 * display.c: Rewritten to handle tables. Untested.
11331 * filename.c: (search_path) Fixed memory leak.
11333 * frequencies.q: (cmd_frequencies) Frees v_variables.
11334 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11335 (cleanup_freq_tab) New function to garbage collect.
11336 (dump_full) Elegantized.
11338 * main.c: New comment.
11340 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11342 * postscript.c: Comment fix.
11343 (release_fontmap, free_font_entry) New functions.
11344 (ps_init_driver) Sets free_font_entry() as the freefunc for
11345 hashtable `loaded'. Calls release_fontmap() when destroying a
11346 driver; also frees the output filename; also frees the
11347 ps_driver_ext block.
11348 (free_ps_encoding) Frees the filename as well as the encoding
11350 (output_encodings) Frees the line buffer and pops the msg-filename
11352 (read_fontmap) Frees the fontmap filename and the line buffer.
11353 (postopen, preclose) Misc. garbage collection fixes.
11354 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11355 to NULL; this fixes some output problems.
11356 (text) Handles TAG_NEWLINE. Untested.
11358 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11359 (som_set_string) Removed. All references changed to
11361 (som_set_text) Rewritten. New interface. More general.
11363 * som.h: Minor format changes.
11364 (struct som_value_cell) Removed; all references changed to
11366 (enums SOT_*) Changed.
11368 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11370 * command.c: Re-enabled SPLIT FILE.
11372 * postscript.c: Comment fix.
11374 * som.h: Added `SOT_NONE'.
11376 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11378 * vfm.c: (dump_splits) Reimplemented.
11380 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11382 * Compiled the project under gcc 2.7.2, which gave some new
11383 warnings. This led to many additions of casts from unsigned to
11384 int sprinkled throughout the code.
11386 * arena.c: Many uses of `unsigned' changed to `size_t'.
11388 * command.c: Added END FILE, END REPEAT to command table.
11389 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11390 (find_command, FILE_TYPE_okay) Not commented out anymore.
11391 (parse_cmd) Calls FILE_TYPE_okay again.
11392 (output_line) Added calls to som_output_text() to put the line
11393 in the output files.
11395 * common.c: (macro VME) Format changes.
11396 (xstrdup) Asserts that its argument is not NULL.
11398 * data-list.c: Implemented dump_fixed_table().
11400 * inpt-pgm.c: Formatting changes. Comment changes.
11401 (end_case_proc) Renamed end_case_trns_proc.
11402 (cmd_end_file, end_file_trns_proc) New functions.
11404 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11406 * misc.h: (local_strdup) New macro corresponding to strdup() but
11407 allocating its data through local_alloc() if possible--that is, if
11410 * postscript.c: Comment changes.
11411 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11412 (output_line, add_string) New macros supporting
11413 output_encodings().
11414 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11415 substitution vars. Calls output_encodings() when a line
11416 consisting of `!encodings' is encountered.
11417 (preclose) Some code moved into quote_ps_string().
11418 (dump_line) Changed into macro supporting dump_fancy_line().
11419 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11420 command when appropriate.
11421 (write_text) Fixed `literal_char' array (I think it's fixed, at
11423 (text) Fixed bug when width was zero. Now exits immediately on
11424 zero height_left. Now, when executing `goto restart;', checks
11425 that cp<end, so that we don't read beyond end-of-string. Also,
11426 outputs the correct code to the output file by outputting the code
11427 from the metric instead of the internal metric index.
11429 * repeat.c: (cmd_end_repeat) New function.
11431 * som.c: (var som) `headers' renamed `options' and semantics
11432 changed. All references changed.
11433 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11434 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11436 (som_text_table) Removed.
11437 (som_output_text) New function.
11439 * som.h: (struct som_submission_form) Removed `header', `reuse',
11440 replaced with bitmapped field `options'.
11441 (SOM_TOPT_*) New enum set for som_submission_form.options.
11442 (SOT_*) New enum set for som_output_text().
11444 * temporary.c: (copy_variable) When copying the var label, only
11445 calls xstrdup() if it's non-NULL.
11447 * var.h: (enum type `vartype') Removed; all references changed to
11450 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11453 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11455 * font.h: Comment changes.
11457 * groff-font.c: (groff_read_font) Initializes `name' field to
11458 NULL. Handles `encoding' field.
11460 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11462 * postscript.c: (struct font_entry) Removed `position' field.
11463 (struct ps_font_combo) New struct.
11464 (struct ps_driver_ext) Removed field `next_position'. New fields
11465 `combos', `next_combo'. `last_font' field changed from
11466 `font_entry *' to `ps_font_combo *'.
11467 (ps_init_driver) Reformatted; handles new fields. When
11468 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11470 (get_encoding, find_encoding_file) New functions.
11471 (add_encoding) Some code moved out into find_encoding_file().
11472 (postopen) Changed value for ${title}.
11473 (preclose) Sets `loaded' field to NULL after destroying the hash
11475 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11477 (ps_text_set_font_by_position) Figures out the current family if
11479 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11480 (switch_font) Implemented.
11481 (write_text) Calls switch_font() more often. Format changes.
11482 #undefs its macros after they're no longer useful.
11483 (text) Changed `continue' at one point to a jump to the top of the
11484 loop because we don't want `separate' reset to 0 at that point.
11485 (load_font) No longer sets `position' in the font_entry created.
11487 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11489 * font.h: (struct font_desc) New member `encoding', which is not
11490 properly handled yet.
11492 * glob.c: (init_glob) Some new i18n code, which is probably
11495 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11496 `size' local from `int' to `size_t'.
11498 * postscript.c: New driver configuration parameter `auto-encode'.
11499 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11500 (struct font_entry) New member `position'.
11501 (struct ps_driver_ext) Reordered. New hash table member
11502 `encodings'; new members `next_position', `next_encoding',
11503 `last_font'. Members `current', `prop', `fixed' changed from type
11504 `font_desc *' to `font_entry *'; all references changed.
11505 (struct ps_encoding) New struct.
11506 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11507 free_ps_encoding, add_encoding) New functions.
11508 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11509 x->output_options. Initializes new members of ps_driver_ext.
11510 Changed default value for prologue_fn, encoding_fn. Calls
11511 read_ps_encodings after loading default fonts.
11512 (option_tab[], ps_option) Handle new configuration parameter.
11513 (switch_font) New function.
11514 (struct output_char) `font' member changed from `font_desc *' to
11515 `font_entry *'. New member `separate'.
11516 (read_fontmap) Changed `size' from `int' to `size_t'.
11517 (output_line, put_number) New macros for write_text().
11518 (write_text) Optimizes text output by consolidating multiple
11519 calls to PostScript `show' operator.
11520 (text) Keeps track of when text arguments can't be consolidated by
11521 write_text(), and marks those spots in the output stream.
11522 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11523 the font hasn't been switched to by switch_font(), which is where
11524 the position is important--the PostScript is what cares about the
11527 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11529 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11530 call a NULL free_func.
11531 (hsh_rehash) Elegantized.
11532 (hsh_probe) Fix bug that manifested when the table was expanded
11533 and thus had to change location in memory. Good thing
11534 too--otherwise could have been much more subtle.
11535 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11536 (hsh_foreach) New function for hash table iteration.
11538 * hash.h: (struct hsh_iterator) New.
11540 * lexer.c: (parse_tagged_quote) Font and family name strings in
11541 tags are now null-terminated.
11543 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11545 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11546 documented. (Never before tested?)
11548 * output.h: Comment changes.
11550 * postscript.c: New driver options `optimize-text-size',
11551 `optimize-line-size', `max-fonts-simult'. New enum set for
11552 specing cached line types. Comment fixes.
11553 (struct line_form) New struct.
11554 (struct ps_driver_struct) New members `text_opt', `line_opt',
11555 `max_fonts', `lines'.
11556 (ps_init_driver) Initializes new members of ps_driver_struct.
11557 (user option type enum set) New member `nonneg_int_arg'.
11558 (static var option_tab[]) Supports new options.
11559 (ps_option) Handles new options.
11560 (find_ps_file) Made static. No longer calls hsh_dump().
11561 (ps_get_var) Made static.
11562 (preclose) Dumps out proper DSC trailer.
11563 (ps_open_page) Elegantized.
11564 (ps_close_page) Calls dump_lines() if appropriate.
11565 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11566 wrappers around line().
11567 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11568 dump_lines, hash_line, free_line, line) New functions for support
11570 (write_text, text) Made static.
11571 (text) Added to font support, not finished.
11573 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11575 * font.h: (struct font_desc) New members ascent, descent.
11577 * groff-font.c: (groff_read_font) Calculates font ascent and
11578 descent from the ascent and descent of the `d' and `p' characters,
11579 respectively, as per a suggestion on comp.fonts.
11581 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11582 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11584 (write_text) Handles text right-justification and centering (not
11585 full justification). Still very inefficient. (One output line
11587 (struct output_char) Added fields for font and font size.
11588 (text) Many bugfixes.
11590 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11592 * cmdline.c: (usage) Calls outp_list_classes().
11594 * font.h: Comment fix.
11596 * groff-font.c: New exported global var `space_index'.
11597 (groff_init) New function to initialize `space_index'.
11598 (hash_kern) Casts result to unsigned.
11599 (font_name_to_index) Renamed font_char_name_to_index. All
11600 references changed. Also, now returns the value of `space_index'
11601 when passed an ASCII space character as an argument. Fixed
11603 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11604 Handles passed NULL pointers properly.
11606 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11609 * output.c: (outp_list_drivers) Removed. Removed all references.
11611 * output.h: Comment fixes.
11613 * postscript.c: (ps_open_global) Calls groff_init().
11614 (output_char) New structure.
11615 (write_text) New function.
11616 (text) No longer stubbed out! Now the output is correct--with a
11617 few exceptions, one of them being that the page has to be held
11618 upside down into a mirror.
11620 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11622 * font.h: Comment fix.
11624 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11625 All callers changed.
11626 (number_to_index) Renamed font_number_to_index, made extern. All
11628 (font_get_kern_adjust, font_get_char_metrics) New functions.
11630 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11632 * postscript.c: Changed default line width back to 1/2 point.
11633 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11634 in the center of the space allotted for them, not just a fixed
11635 offset from the edge of the space; this fixes some bugs.
11636 (ps_line_intersection) Now supports all command line styles.
11637 (ps_text_get_size) Bug fix in computation of em width.
11638 (text) New function, the meat behind ps_text_metrics and
11639 ps_text_draw. Not complete.
11640 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11641 ascii.c; call text().
11643 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11645 * arena.c: (arena_free) Assert that the argument is non-NULL.
11647 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11648 only if old_kern is non-NULL.
11650 * postscript.c: (ps_init_driver) Changed default line width to 1
11652 (postopen) New prologue variables.
11653 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11654 more of the common line styles properly, but not all.
11655 (ps_text_metrics) Fixed problem with this stubbed out version that
11656 kept it from taking font sizes into account.
11658 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11660 * arena.c: (arena_malloc) Bug fix.
11661 (arena_dump) [GLOBAL_DEBUGGING] New function.
11663 * ascii.c: Comment fix.
11664 (count_fancy_chars, delineate) Now static functions.
11666 * filename.c: (interp_vars) Bug fixes.
11668 * font.h: Comment fixes.
11670 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11671 beginning in case we have an error message to display before
11672 initializing the display.
11674 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11676 (groff_read_font) Bug fixes.
11677 (name_to_index) Increments hash.used. Sets `name' field of hash
11679 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11681 * hash.c: Return type changed.
11683 * postscript.c: Continued development. Now marks lines on the
11684 paper, but very buggy.
11686 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11688 * Changed comments in many source files from `/* xxx /* yyy */' to
11689 `/* xxx */ /* yyy */' for cleanliness.
11691 * arena.c: (arena_sd_strdup) New function.
11693 * ascii.c: (struct ascii_driver_ext) New member `file'.
11694 (ascii_init_driver) Fills out member `file' for initing; uses
11695 close_file_ext for closing drivers.
11696 (ascii_option) Changed %.*s back to %s because the a_string's are
11697 always null-terminated.
11698 (postopen, preclose) New functions.
11699 (ascii_open_page) Uses new style of open_file_ext.
11700 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11701 instead of this->output.
11702 (__assert_fail) Removed.
11704 * cmdline.c: Changed syntax_message[].
11706 * error.c: #include's <readline/history.h> only if the history
11707 library is available, not if just the readline library is
11710 * filename.c: (expand_line) Removed alloca() support.
11711 (interp_vars) No longer tilde-expands argument. Limit on output
11713 (tilde_expand) Now treats argument as path rather than filename.
11714 [!unix] Now is a no-op function.
11715 (search_path) Better verbose message formatting.
11716 (open_file, close_file) Comment fixes.
11717 (close_file) [!unix] Doesn't bother with pipes.
11718 (open_file_ext) Completely rewritten, interface revamped.
11719 (close_file_ext) New function.
11721 * font.h: Comment changes.
11723 * frequencies.q: Removed AIX alloca support since it doesn't use
11726 * hash.c: Comment changes & additions.
11727 (hsh_create) Initializes entire table instead of first M entries.
11728 (hsh_probe) Stupid bug fixed. Now it works.
11729 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11731 * main.c: (parse) Detects EOF properly in token-eating loop.
11732 Should the STOP token have its value changed to 0?
11734 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11735 (blp_getline) Now it's a macro.
11737 * output.h: (struct outp_driver) Removed members output, filename.
11739 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11740 drivers in driver table.
11741 (outp_read_devices) Frees buf. Warns if there are no active
11743 (outp_configure_clear) Sets outp_configure_vec to NULL after
11744 deleting its elements.
11745 (configure_driver, destroy_driver) Removed references to output,
11746 filename members of outp_driver.
11747 (outp_evaluate_dimension, internal_get_paper_size,
11748 outp_get_paper_size) New functions.
11750 * postscript.c: Continued development. Now links but doesn't make
11751 any marks on the page. Lotsa bugs I suppose.
11753 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11755 * str.h: Comment changes.
11757 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11759 * Removed dependencies on non-nested comments in several files.
11760 Also removed references to (unix || __unix__) in #if's since
11761 prefh.orig makes those two equivalent.
11763 * ascii.c: (ascii_open_global) Creates ascii_arena.
11764 (ascii_close_global) Destroys ascii_arena.
11765 (ascii_init_driver) Doesn't create ascii_arena.
11766 (ascii_copy_driver) Removed.
11767 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11768 (outp_class ascii_class) Removed ascii_copy_driver reference.
11770 * frequencies.q: Now can display all statistics except median.
11771 Still not finished.
11773 * output.c: Handles outp_class.ref_count so output class
11774 destructors are called properly.
11775 (add_class) Sets ref_count to 0.
11776 (configure_driver) Initializes class if ref_count++ is 0.
11777 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11778 class output file name.
11780 * output.h: (struct outp_class) Removed copy_driver, inited.
11783 * postscript.c: Completely replaced but not finished.
11785 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11787 * approx.h: #includes <float.h>.
11789 * arena.h, arena.c: Many functions changed to take an arena **
11790 instead of an arena *, for consistency. All callers changed.
11791 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11792 (arena_destroy) Sets *A to NULL.
11794 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
11795 assertion that `width' be positive.
11797 * command.c: Removed #if's from cmd_table.
11798 (walk_cmdtable_func) [0] New function (debug code).
11799 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
11800 (parse_cmd) Doesn't return failure for unimplemented commands.
11802 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
11803 (SYSCODE) New constant macro.
11805 * descript.q: Checks for positive n_variables before performing
11808 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
11809 avl_find instead of &fp as arg 2.
11811 * frequencies.g, frequencies.q: Continued updating; now compiles &
11812 works again, but not complete.
11814 * main.c: Changes to user messages.
11816 * misc.c: (reverse) [0] New function.
11818 * settings.h: Comment removed. #includes "common.h".
11820 * som.c: (som_set_null) New function.
11821 (som_set_value, som_set_string, som_set_text) More detailing
11823 (som_set_float) Implemented function.
11824 (dump_columnated_table) Bug fix regarding page breaks.
11825 (draw_cell) Bug fix regarding text that spilled out of a cell.
11826 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
11828 (get_cell_size) Support SCON_EMPTY cells.
11829 (get_table_size) When calculating rules' widths and heights, mask
11830 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
11832 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
11834 (struct som_submission_form) New member `header'; all users
11837 * val-labs.c: (get_label) User messages changed.
11839 * var.h: Changed FREQUENCIES structures.
11841 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
11844 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
11846 * approx.h: Definition of EPSILON now depends on system's
11847 DBL_EPSILON. Removed GNU C specific code.
11848 (cmpapx) Renamed approx_compare.
11850 * frequencies.g, frequencies.q: Continued updating; still doesn't
11853 * groff-font.c: (name_to_index) Fix bug that kept it from
11856 * hash.c, hash.h: Completed work.
11858 * var.h: Changes to freq_tab, frequencies_proc.
11860 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
11863 * hash.c, hash.h: New files. Not completed.
11864 * Makefile.am: Added hash.c to source file list.
11865 * font.h: (struct font_desc) New member kern_size_p.
11866 * groff-font.c: Uses hash.h.
11867 (hashpjw) Moved to hash.c.
11868 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
11870 (static var hash) New member size_p.
11871 * var.h: Includes hash.h.
11872 (struct freq_tab) Changed AVL_TREE to hash_tab.
11874 * vars-prs.c: Comment, formatting fixes.
11876 * frequencies.g, frequencies.q: Continued updating. Not yet
11879 * formats.c: Bug fix.
11881 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
11883 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
11884 * descript.g: Comment fixes.
11885 * descript.q: Comment fixes. Moved some declarations into var.h.
11886 Made dsc_info a static table. Updated FIXMEs.
11887 (internal_cmd_descriptives) Beautified.
11889 * frequencies.q: Started updating into working order.
11890 * frequencies.g: New file analogous to descript.g.
11891 * var.h: Comment fixes. Added structures for FREQUENCIES.
11893 * som.c: Removed vestiges of crushing and partial table support.
11895 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
11897 * Many more changes to som.c especially, but these will not be
11898 documented as I have resolved to remove them. This patchlevel is
11899 being released solely so that I can fall back to it if I decide
11900 that removing the changes is not a good idea.
11902 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
11904 * som.c: (global var som) New member `cum_y'.
11905 (build_target) Properly handles titles for partial tables.
11906 (dump_partial_beg, dump_partial_mid, dump_partial_end)
11907 Merged into single new function dump_partial(). Fixed problem
11908 with titles on partial tables.
11909 (dump_table) Calls dump_partial() for all parts of partial tables.
11910 (dump_page) Criteria for drawing title changed.
11912 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
11914 * command.c: (cmd_table) Added LIST, WEIGHT.
11916 * command.c: (cmd_remark) No longer frees `s' since it's not
11917 dynamically allocated.
11919 * data-out.c: (convert_f) Now correctly handles the case where
11920 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
11921 number of decimals.
11922 (som_destroy_all_tables) Removed argument. All callers changed.
11923 (som_vline, som_hline) Argument validity checking corrected.
11924 (som_set_value) Implemented half-heartedly.
11925 (replicate_table) Copies tables piece-by-piece when using Checker.
11927 * som.h: New line style SLIN_1THIN, currently equivalent to
11928 SLIN_0. New enum set SOM_SUB_*.
11929 (struct som_submission_form) Removed `seq_no'. Added `type'.
11931 * list.q: Newly working file; uses partial tables.
11933 * som.c: (som_reduce_table) Renamed som_set_table_height().
11934 (som_crush) Removed argument `group'.
11935 (global var som) Removed `nt', `seq_no'. Added `type'.
11936 (som_submit_table) Arguments changed.
11937 (output_table) Removed partial table code.
11938 (build_target) New arg; partial table support added. All callers
11940 (dump_plain_table) Removed partial table code.
11941 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
11942 (dump_table) Supports partial tables.
11943 (dump_page) New argument to allow not drawing top and/or bottom
11944 headers. All callers changed. Supports partial tables.
11946 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
11948 * data-out.c: Changed `#include <approx.h>' to `#include
11950 (convert_F) Comment fix. Now won't print `-.000', etc.
11952 * descript.q: Now Z-scores work, although there appears to
11953 be a bug (which might actually be in data-out.c:convert_F()).
11954 (descriptives_trns_proc, descriptives_trns_free) New functions.
11955 (run_z_pass) Implemented.
11957 * var.h: Comment fixes.
11958 (dsc_z_score, descriptives_trns) New structs.
11959 (descriptives_trns) Added to any_trns as `dsc'.
11961 * error.c, error.h: New error class, IS (Installation Script
11962 error), used in those instances where the error is in the
11963 installation, but there is a script file or installation file that
11964 can be usefully referred to.
11966 * output.c: Change many IE classes to IS classes.
11968 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
11969 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
11970 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
11971 include the corresponding header?
11973 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
11974 Don't bail out if termcap can't be read.
11976 * som.c: (som_destroy_table) Removed.
11977 (som_reduce_table, som_destroy_all_tables) New functions.
11978 (som_crush) New function, not implemented.
11980 * som.h: New table option STAB_CRUSH. Comment fix. New struct
11981 som_submission_form. Function prototypes revised.
11983 Outputting huge tables (1000s of rows) a few rows at a time
11984 is supported, though untested. May even break everything.
11985 Actually, the code doesn't even compile right now.
11986 * som.c: (struct som) New fields htv, nt, seq_no.
11987 (som_submit_table) Multiple arguments changed to a single
11988 pointer to struct submission_form. Only increments subtable_num
11989 if seq_no is zero. Only destroys table if it's not going to
11991 (replicate_table) New function.
11992 (output_table) Comment fix.
11993 (examine_table) Changed inline code to code calling
11994 replicate_table(). Calculates htv. Supports partial tables.
11995 (draw_title) Removed comment.
11996 (build_target) Only allows for title on first part of partial
11998 (dump_plain_table) Only resets table chunk number on first part
11999 of partial tables; FIXME: doesn't work quite right. Supports
12001 (dump_page) Titles only on first part of partial tables.
12003 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12005 * Thanks to an unreliable IDE hard drive, I have spent the last
12006 day reconstructing my Debian GNU/Linux installation and redoing
12007 the previous day's changes--somehow I managed to save every file
12008 except for output.c and output.h. So the following changes could
12009 really be considered independent of the output.c, output.h changes
12012 * output.h, output.c: Moved the outp_configure_vec global var,
12013 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12014 outp_configure_vec is now static.
12016 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12018 * The entire philosophy behind configuration of the output drivers
12019 changed. Now there is a termcap-type configuration where drivers
12020 to be read are determined beforehand, rather than parsing the
12021 entire output init file and storing it in memory & deciding what
12022 to actually use later. Faster & more memory-efficient at the same
12025 * output.c: Comment fix. Removed outp_init_drivers global var.
12026 Removed all references to synonyms. New structure outp_defn. New
12027 global vars outp_macros, outp_configure_vec.
12028 (search_name, delete_name, add_name, check_configure_vec,
12029 expand_name, find_defn_value) New static functions.
12030 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12031 outp_read_devices) New extern functions.
12032 (outp_init) Much functionality moved into outp_read_devices.
12033 (outp_read_devices) Format of output init file changed; name of
12034 file is `devices' rather than `output' to avoid Makefile
12036 (outp_clear) Renamed outp_done.
12037 (outp_list_classes) Bug fix, cleaned up.
12038 (outp_list_drivers) Not implemented anymore.
12039 (outp_configure_driver) Now a static function; simplified; now
12040 interpolates macros; supports new structure.
12041 (outp_enable_driver, match_synonym) Removed; all references
12043 (find_driver) First argument removed.
12045 * output.h: Global var outp_init_drivers removed; new structure
12046 outp_names; new enum set OUTP_S_*; new global var
12047 outp_configure_vec; function prototypes for output.c exports
12050 * main.c: (main) Calls outp_read_devices() after parsing the
12053 * cmdline.c: (parse_command_line) New option -v --verbose;
12054 --version changed to -V. --device option changed syntax to just
12055 take a single device name. Accepts key=value declaration of
12056 output init file macros. Syntax message updated.
12058 * filename.c: (expand_line) New function.
12059 (interp_environ_vars) Renamed interp_vars; no longer uses
12061 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12062 overridden by real environment vars.
12063 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12064 * filename.h: interp_environ_vars() renamed interp_vars().
12066 * error.c, error.h: Added extern variable `verbosity', message
12069 * error.c: (vmsg) Support message class MM.
12070 (verbose_msg) New function.
12072 * descript.q: (generate_z_varname) Bug fix in generation of
12074 (dump_z_table) Bug fix in column headers.
12076 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12077 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12078 OPS_DONE]. Writes the uninit string when the driver is closed.
12079 (ascii_open_page) Write the init string before the first page.
12080 (output_shorts) Form of main loop changed from `while' to `for'.
12081 Bug fix with overstrikes: the character is printed *after* the
12082 backspace. Eliminated a lot of `& 0xff' modifiers.
12083 (advance_to_left_margin) New function.
12084 (return_carriage, output_lines) Handle left margin.
12086 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12088 * ascii.c: New option `carriage-return-style'.
12090 * ascii.c: (count_fancy_chars) New function.
12091 (delineate, text_metrics) Use new function; bug fixes regarding
12093 (text_draw) Bug fix with rich text.
12094 (output_string, output_shorts) Reordered.
12095 (output_shorts) Now handles boxchars and some overstrike font
12097 (output_char, return_carriage) New functions.
12098 (output_lines) Now handles overstriking and font changes properly;
12099 some code moved to output_shorts.
12101 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12104 * ascii.c: New member `debug' in ascii_driver_ext.
12105 (ascii_init_driver, delineate) Uses new member.
12107 Now you can set a vertical height on writing text.
12108 * ascii.c: (delineate) Keeps track of vertical position.
12109 (text_draw) No longer considers fully justified text an internal
12112 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12114 Tables' titles are drawn; they can have variable height.
12115 * som.c: `som' struct has new member, title_height.
12116 (draw_title) New argument. Moved within file. All caller
12118 (build_target) New argument, amount of space needed for first row.
12119 Calculates height of title, takes that into account. All callers
12121 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12123 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12125 (dump_columnated_table) Organized for readability.
12126 (dump_page) Makes use of som.title_height.
12128 * som.c: Many comment bug fixes.
12130 * descript.q: (try_name, generate_z_name) Bug fix regarding
12131 generation of Z-score variable names.
12132 * var.h: Removed num from descriptives_proc; all referents removed.
12134 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12136 * ascii.c: (ascii_line_horz, ascii_line_vert,
12137 ascii_line_intersection) Added debugging code.
12139 Added a descriptive line above each table to describe it.
12140 * command.c: (parse_cmd) Calls som_new_series.
12142 * som.c: New static vars table_num, subtable_num. New `som'
12144 (dump_page) New arguments.
12145 (som_submit_table) Handle new variables.
12147 * som.c, som.h: (som_submit_table) New arguments. All callers
12149 (som_new_series) New function.
12150 (build_target) Makes room for extra line.
12151 (draw_title) New function.
12152 (dump_page) Calls draw_title. Bug fix: doesn't always set
12155 Columnation of tables support.
12156 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12158 * som.c: Deleted references to fr, lr, ri.
12159 (som_columnate) Bux fix: sets group member of table.
12160 (som_add_options) Function removed.
12161 (dump_table) Split into three functions; extensively reworked.
12163 * descript.q: (dump_z_table) Better output table formatting; added
12164 title support to correspond to som.h changes.
12165 (display) Title support.
12167 * output.h: Added OUTP_T_NONE.
12169 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12171 * descript.q: Improved handling of Z scores; still not perfect.
12173 * output.h, ascii.c: Added hook for getting em width of current
12176 * som.c: Uses new em-width hook. Added debugging code to
12178 (som_columnate) New argument.
12179 (som_add_options) Removed.
12181 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12183 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12184 rules as a property of the table instead of as a property of the
12187 * ascii.c: Added `header' to table of options.
12189 * descript.q: Added even shorter statistic names; modified to work
12190 with new som interface.
12192 * misc.c (blp_getdelim): Bug fix.
12194 * version.c: includes 'conf.h'.
12196 ----------------------------------------------------------------------
12199 version-control: never