1 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
3 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4 in joined cells to be rendered outside box boundaries.
6 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
8 * random.c (rng_create): Fixed seeding so that it gets reseeded after
9 SET seed=xx has been called.
11 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
13 * random.c (rng_get_double): Fix always-returning-zero bug in my
14 preferred way, and at the same time make sure rounding doesn't
17 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
19 * html.c: (change_attributes) Dead code, removed.
20 (escape_string) Eliminate code to call change_attributes() that
21 never actually called it.
22 (output_tab_table) Get rid of dependence on tab_hit
23 and struct tab_joined_cell's hit member, which are abominations.
25 * tab.c: (tab_output_text) Don't call
26 d->class->text_set_font_by_name if it's a null pointer.
27 (macro UNROLL_LOOP) Eliminate.
28 (macro UNROLL_3_LOOPS) Eliminate.
29 (tabi_render) Rewrite not to use the above macros.
31 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
33 Start working on a new output driver system, one that doesn't suck
34 so much, by adding a "device-independent" output driver. The idea
35 is to write out only a single output stream, then use separate
36 processes to translate them into whatever formats we want. This
37 is similar to how "groff" works with its various output drivers
38 (grops, grotty, grodvi, ...).
40 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
42 * list.q: (write_all_headers) Stub out devind class.
44 (determine_layout) Ditto.
47 * output.c: (outp_init) Add devind class.
53 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
55 * frequencies.q: (hash_value_alpha) Fixed up the previous change
56 to use the proper string length.
58 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
60 * Fixed bug where FREQ would crash on alpha values
62 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
64 * Removed bletcherous alloca() workarounds for AIX from top of
65 many files. AIX can use the alternative alloca() implementation
68 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
70 * ascii.c: (ascii_option) Fix implementation of headers option.
72 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
74 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
75 multiple blank lines into one.
76 (struct ascii_driver_ext) Add squeeze_blank_lines option.
77 (ascii_preopen_driver) Initialize squeeze_blank_lines.
78 (static var option_tab) Add squeeze entry.
79 (ascii_option) Set squeeze_blank_lines.
80 (output_lines) Implement squeezing blank lines.
82 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
84 * Removed redundant code from output.h
86 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
88 Dictionary classes: each variable is "ordinary", "system", or
91 * var.h: (enum dict_class) New enum.
93 * vars-prs.c: (dict_class_from_id) New function.
94 (dict_class_to_name) New function.
96 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
98 * var.h: (struct freq_tab_set) Removed (not used).
100 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
102 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
104 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
106 * stats.c: (hypercube) Rename pow4(). All references updated.
108 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
110 * rename-vars.c: (cmd_rename_variables) Rewritten.
111 (compare_name) Removed.
113 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
115 var_set feature, and code taking advantage of it.
117 * crosstabs.q: (static var var_dict) Removed.
118 (static var variables) New variable.
119 (static var variables_cnt) New variable.
120 (cmd_crosstabs) Free variables instead of var_dict.
121 (internal_cmd_crosstabs) Initialize and use variables,
122 variables_cnt instead of var_dict.
123 (free_var_dict) Removed.
124 (crs_custom_tables) Use var_set instead of a copied dictionary.
125 (crs_custom_variables) Set up variables, variables_cnt instead of
127 [DEBUGGING] (debug_print) Ditto.
129 * means.q: (mns_custom_tables) Use var_set instead of a copied
132 * vars-prs.c: (parse_vs_variable) New function.
133 (parse_dict_variable) Rewritten.
134 (parse_variable) Rewritten.
135 (parse_variables) Renamed parse_var_set_vars(), rewritten.
136 (parse_variables) New function in terms of parse_var_set_vars().
137 Now requires its first argument to be non-null. All references
138 that passed a null pointer updated to pass default_dict instead.
139 (macro id_dict) Removed.
140 (parse_DATA_LIST_vars) Add assertions.
141 (parse_mixed_vars) Ditto.
142 (struct var_set) New structure.
143 (var_set_get_cnt) New function.
144 (var_set_get_var) New function.
145 (var_set_lookup_var) New function.
146 (var_set_destroy) New function.
147 (dict_var_set_get_cnt) New function.
148 (dict_var_set_get_var) New function.
149 (dict_var_set_lookup_var) New function.
150 (dict_var_set_destroy) New function.
151 (var_set_create_from_dict) New function.
152 (struct array_var_set) New structure.
153 (array_var_set_get_cnt) New function.
154 (array_var_set_get_var) New function.
155 (array_var_set_lookup_var) New function.
156 (array_var_set_destroy) New function.
157 (var_set_create_from_array) New function.
159 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
160 instead of parse_variables(NULL, ...) in output code.
162 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
164 Change inp_init from a 2-bit vector to an ordinary array.
165 Initialize it all in cmd_end_input_program() instead of in
168 * inpt-pgm.c: (enum value_init_type) New enum.
169 (global var inp_init) Change to `enum value_init_type *', make
171 (inp_init_size) Removed.
172 (inp_nval) Change to `size_t', make static.
173 (cmd_input_program) Don't initialize inp_init or inp_init_size.
174 (cmd_end_input_program) Initialize inp_init, inp_nval.
176 (clear_case) Rewrite.
178 * inpt-pgm.h: Removed.
180 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
182 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
183 Colin Plumb hash. It is simpler and should better resist
185 (hsh_hash_string) Ditto.
187 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
189 * get.c: (export_write_case_func) Remove debug printing code.
191 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
193 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
195 (save_write_case_func) Use &trns->h instead of cast.
196 (cmd_export) Use &t->h instead of cast.
198 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
200 Moved vectors into the dictionary.
202 * var.h: (struct vector) Moved here from vector.h. `index' member
203 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
208 * vector.c: (global var vec) Removed.
209 (global var nvec) Removed.
210 (cmd_vector) Rewritten.
211 (find_vector) Removed.
213 * dictionary.c: (dict_create_vector) New function.
214 (dict_get_vector) New function, replaces reading global vec[]
216 (dict_get_vector_cnt) New function, replaces reading global nvec
218 (dict_lookup_vector) New function, replaces find_vector().
219 (dict_clear_vectors) New function.
221 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
223 Start to move away from `struct variable' p `union' member to void
226 * var.h: (struct variable) Add `aux' member.
228 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
230 Get rid of struct variable `foo' member.
232 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
234 (frq_custom_variables) Ditto.
235 (frq_custom_grouped) Ditto.
237 * get.c: (struct save_trns) Change `var' member from `int *' to
238 `struct variable **'.
239 (cmd_save_internal) Use aux instead of foo.
240 (save_trns_proc) Use revised `var' member.
241 (static var mtf_seq_no) Renamed mtf_seq_num.
242 (static var mtf_seq_nums) New static var.
243 (cmd_match_files) Initialize mtf_seq_nums.
244 (mtf_free) Free mtf_seq_nums.
245 (mtf_processing) Use mtf_seq_nums instead of foo.
246 (mtf_merge_dictionary) No need to initialize mv->foo.
247 (cmd_export) Use aux instead of foo. Use revised `var' member.
248 (mns_custom_tables) Don't use foo to check for duplicates, that's
249 what PV_NO_DUPLICATE is for.
251 * var.h: (struct variable) Remove `foo' member.
252 (struct frequencies_proc) New member.
254 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
256 Clean up COMPUTE and IF.
258 * compute.c: More or less rewrite the darn thing.
259 (struct compute_trns) Rename and reorder and add and delete
261 (cmd_compute) Rewrite.
262 (compute_num) Make conditional on test expression. Now used for
264 (compute_num_vec) Ditto.
266 (compute_str_vec) Ditto.
269 (if_num_vec) Removed.
271 (if_str_vec) Removed.
272 (parse_target_expression) Renamed parse_rvalue_expression(),
274 (new_trns) Renamed compute_trns_create(), rewritten.
275 (delete_trns) Removed.
276 (free_trns) Renamed compute_trns_free(), rewritten.
277 (struct lvalue) New structure.
278 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
279 (lvalue_get_type) New function.
280 (lvalue_is_vector) New function.
281 (lvalue_finalize) New function.
282 (lvalue_destroy) New function.
284 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
286 * command.def: Disallow MODIFY VARS in input mode, so that
287 variables can't get dropped and confuse cmd_end_input_program()'s
288 attempt to fill inp_init[].
290 * modify-vars.c: (static var forward_positional_ordering) New
292 (struct var_modification) Entirely changed.
293 (rearrange_dict) Interface changed, rewritten.
294 (cmd_modify_vars) Deal with modified struct var_modification, much
296 (struct var_renaming) New structure.
297 (compare_var_renaming_by_new_name) New function.
298 (validate_var_modification) New function.
300 * var.h: (struct modify_vars_proc) Removed.
301 (struct variable) Removed member p.mfv.
303 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
305 Make EVALUATE a valid command whether we're debugging or not, so
306 that `make check' can succeed regardless of whether debugging is
309 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
311 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
313 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
315 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
316 statement by a simple if test.
318 * dfm.c: (dfm_get_record) Add assertion.
320 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
322 For each file x.c, move #include "x.h" to the very top of the
323 include list, to catch x.h failing to include the proper headers.
325 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
327 * algorithm.c: (find) New function.
328 (remove_equal) New function.
329 (set_difference) New function.
330 (adjacent_find_equal) New function.
331 [TEST_UNIQUE] Removed test case.
332 (copy_if) Find end test.
334 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
336 * dictionary.c: (dict_get_case_weight) New convenience function.
338 * aggregate.c: (accumulate_aggregate_info) Use
339 dict_get_case_weight().
341 * frequencies.q: (calc_general) Ditto.
342 (calc_integer) Ditto.
345 * t-test.q: (groups_calc) Ditto.
348 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
350 * glob.c: (global var default_dict) Change from `struct
351 dictionary' to `struct dictionary *'. All references changed.
352 (init_glob) Initialize default_dict with dict_create().
354 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
356 struct dictionary now made opaque. All related functions:
358 * get.c: (rename_variables) Removed.
359 (dict_delete_run) Removed.
361 * temporary.c: (copy_variable) Removed.
362 (new_dictionary) Removed.
363 (save_dictionary) Removed.
364 (restore_dictionary) Removed.
365 (free_dictionary) Removed.
367 * vars-atr.c: (clear_default_dict) Removed.
368 (find_variable) Removed.
369 (find_dict_variable) Removed.
370 (create_variable) Removed.
371 (delete_variable) Removed.
372 (common_init_stuff) Removed.
373 (init_variable) Removed. Updating of inp_init moved into
374 cmd_end_input_program().
375 (replace_variable) Removed.
376 (rename_variable) Removed.
377 (clear_variable) Removed.
378 (dup_variable) Removed.
380 * vars-prs.c: (is_varname) Removed.
381 (is_dict_varname) Removed.
382 (fill_all_vars) Removed.
384 * vector.c: (find_vector) Removed.
386 * weight.c: (stop_weighting) Removed.
388 * dictionary.c: New file.
389 (dict_create) New, replaces new_dictionary().
390 (dict_clone) New, replaces save_dictionary() and
391 restore_dictionary().
392 (dict_clear) New, replaces clear_default_dict().
393 (dict_destroy) New, replaces free_dictionary().
394 (dict_get_var_cnt) New function, replaces references to
396 (dict_get_var) New function, replaces references to dict->var[i].
397 (dict_get_vars) New function, replaces fill_all_vars().
398 (dict_create_var) New, replaces create_variable(). Interface
399 drops `type' parameter, using a zero `width' to designate numeric.
400 (dict_clone_var) New, replaces dup_variable().
401 (dict_rename_var) New, replaces rename_variable().
402 (dict_lookup_var) New, replaces find_variable(),
403 find_dict_variable(), is_varname().
404 (dict_contains_var) New function.
405 (compare_variable_dblptrs) New function.
406 (dict_delete_var) New function, replaces clear_variable().
407 (dict_delete_vars) New function, replaces dict_delete_run().
408 (dict_reorder_vars) New function.
409 (dict_rename_vars) New function, replaces rename_variables().
410 (dict_get_weight) New function, replaces reading dict->weight_var.
411 (dict_set_weight) New function, replaces writing dict->weight_var
412 or calling stop_weight(dict).
413 (dict_get_filter) New function, replaces reading dict->filter_var.
414 (dict_set_filter) New function, replaces writing dict->filter_var.
415 (dict_get_case_limit) New function, replaces reading dict->N.
416 (dict_set_case_limit) New function, replaces writing dict->N.
417 (dict_get_value_cnt) New function, replaces reading dict->nval.
418 (dict_compact_values) New function, replaces a loop that was
419 replicated in several places.
420 (dict_get_split_vars) New function, replaces reading dict->splits.
421 (dict_get_split_cnt) New function, replaces reading
423 (dict_set_split_vars) New function, replaces writing dict->splits.
424 (dict_get_label) New function, replaces reading dict->label.
425 (dict_set_label) New function, replaces writing dict->label.
426 (dict_get_documents) New function, replaces reading
428 (dict_set_documents) New function, replaces writing
431 All references to above functions updated.
433 * aggregate.c: (cmd_aggregate) Copy file label and documents from
434 old dictionary to new by hand, because dict_create() can't do it
435 itself. Use dict_set_documents(), dict_set_split_vars().
437 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
438 calling dict_destroy().
440 * data-list.c: (dls_var_spec) Remove `type' member, replace by
442 (fixed_parse_compatible) Some slightly nontrivial changes for
444 (dump_fmt_list) Ditto.
447 * file-type.c: (create_col_var) Ditto.
449 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
450 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
451 (rename_variables) Use dict_rename_vars().
452 (mtf_merge_dictionary) Use dict_get_documents(),
453 dict_set_documents(), dict_compact_values().
455 * pfm-read.c: (read_variables) Deal with changes to weighting.
457 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
458 is_varname() in output code.
460 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
461 other dictionary functions.
463 * title.c: (add_document_line) Use dict_get_documents(),
464 dict_set_documents().
466 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
467 reset default_handle by hand. dict_clear() will clear vectors so
468 there's no need for that by hand.
470 * vfm.c: (close_active_file) Move call to finish_compaction()
471 earlier, so that we can do the compaction as a single step using
472 dict_compact_values(). Use dict_clear_vectors().
473 (finish_compaction) Use dict_delete_var(), dict_compact_values().
475 Some functions don't have replacements:
477 * vars-atr.c: (force_create_variable) Removed. All references
478 updated to dict_create_var() followed by an assertion.
479 (force_dup_variable) Removed. All references updated to
480 dict_clone_var() followed by an assertion.
482 * weight.c: (update_weighting) Removed. No longer necessary, so
483 all references removed.
485 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
489 * aggregate.c: Eliminate separation of weighted and unweighted
490 case. It made the code too obscure and I doubt it was actually
491 faster. Instead, all code uses the "weighted" code, because
492 that's a generalization of the "unweighted" code.
495 (parse_aggregate_functions) No need to set FWEIGHT.
496 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
497 (dump_aggregate_info) Ditto.
498 (initialize_aggregate_info) No need for special plain_function
499 that gets rid of FWEIGHT option.
501 * aggregate.c: Get rid of approximations.
502 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
504 (aggregate_single_case) Don't use approx_ne().
506 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
508 * ascii.c (ascii_line_width): Dead code, removed.
510 * postscript.c (ps_line_width): Ditto.
512 * q2c.c (xrealloc): Ditto.
514 * count.c (internal_cmd_count): Ditto.
516 * means.q (validate_dependent_endpoint): Ditto.
518 * set.q: (cmd_gset) Ditto.
520 * weight.c: [0] (weight_trns_proc) Ditto.
522 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
524 Make the code -Wmissing-prototypes clean.
526 * Makefile.am (version.c): Add #include "version.h".
528 * ascii.c: (ascii_open_global) Make static.
529 (ascii_close_page) Ditto.
530 (ascii_font_sizes) Ditto.
531 (ascii_postopen_driver) Ditto.
532 (ascii_close_driver) Ditto.
533 (ascii_option) Ditto.
534 (ascii_open_page) Ditto.
535 (ascii_line_horz) Ditto.
536 (ascii_line_vert) Ditto.
537 (ascii_line_intersection) Ditto.
539 (ascii_polyline_begin) Ditto.
540 (ascii_polyline_point) Ditto.
541 (ascii_polyline_end) Ditto.
542 (ascii_text_set_font_by_name) Ditto.
543 (ascii_text_set_font_by_position) Ditto.
544 (ascii_text_set_font_by_family) Ditto.
545 (ascii_text_get_font_name) Ditto.
546 (ascii_text_get_font_family) Ditto.
547 (ascii_text_set_size) Ditto.
548 (ascii_text_get_size) Ditto.
549 (ascii_text_metrics) Ditto.
550 (ascii_text_draw) Ditto.
551 (ascii_close_page) Ditto.
553 * cmdline.h: New header for parse_command_line(). Used where
556 * command.c: Move prototypes for cmd_*() functions to command.h.
558 * command.h: Prototypes for cmd_*() functions moved here from
561 * crosstabs.q: (gamma_int) Ditto.
563 * file-handle.h: Add fh_init_files() prototype.
565 * getline.c: (welcome) Ditto.
567 * glob.h: New header for init_glob(). Used where appropriate.
569 * hash.c: (comparison_helper) Ditto.
571 * html.c: (html_open_global) Ditto.
572 (html_close_global) Ditto.
573 (html_preopen_driver) Ditto.
574 (html_postopen_driver) Ditto.
575 (html_close_driver) Ditto.
577 (html_open_page) Ditto.
578 (html_close_page) Ditto.
581 * inpt-pgm.c: (input_program_source_read) Ditto.
583 * output.c: (find_defn_value) Ditto.
584 (destroy_list) Ditto.
586 * pfm-read.c: (read_int) Ditto.
588 * postscript.c: (ps_open_global) Ditto.
589 (ps_close_global) Ditto.
590 (ps_font_sizes) Ditto.
591 (ps_preopen_driver) Ditto.
592 (ps_postopen_driver) Ditto.
593 (ps_close_driver) Ditto.
595 (ps_open_page) Ditto.
596 (ps_close_page) Ditto.
597 (ps_line_horz) Ditto.
598 (ps_line_vert) Ditto.
599 (ps_line_intersection) Ditto.
601 (ps_polyline_begin) Ditto.
602 (ps_polyline_point) Ditto.
603 (ps_polyline_end) Ditto.
604 (ps_text_set_font_by_name) Ditto.
605 (ps_text_set_font_by_position) Ditto.
606 (ps_text_set_font_family) Ditto.
607 (ps_text_get_font_name) Ditto.
608 (ps_text_get_font_family) Ditto.
609 (ps_text_set_size) Ditto.
610 (ps_text_get_size) Ditto.
611 (ps_text_metrics) Ditto.
612 (ps_text_draw) Ditto.
614 * q2c.c: (finish_up) Ditto.
626 (force_string) Ditto.
631 (parse_setting) Ditto.
632 (parse_specifier) Ditto.
633 (parse_specifiers) Ditto.
634 (parse_subcommand) Ditto.
635 (dump_specifier_vars) Ditto.
637 (make_identifier) Ditto.
638 (dump_declarations) Ditto.
639 (dump_specifier_init) Ditto.
640 (dump_vars_init) Ditto.
642 (dump_specifier_parse) Ditto.
643 (dump_subcommand) Ditto.
647 (recognize_directive) Ditto.
649 * recode.c: (string_to_long) Ditto.
651 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
653 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
656 * sort.c: (sort_stream_read) Ditto.
657 (sort_stream_mode) Ditto.
659 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
661 * algorithm.c (binary_search): Fix comparison.
663 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
665 * algorithm.c: (binary_search) Fix assertion.
667 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
669 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
671 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
673 * sort.c: (compare_case_lists) Rewrite.
675 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
677 * quicksort.c: Removed (not used).
679 * quicksort.h: Removed (not used).
681 * sort.c: Removed blp_quicksort() prototype.
683 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
685 * postscript.c: (int_2_compare) Rewrite.
686 (compare_line) Rewrite.
688 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
690 * matrix-data.c (compare_factors) Use lexicographical_compare()
692 (compare_doubles) New function.
694 * algorithm.c: (lexicographical_compare) New algorithm.
696 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
698 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
700 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
702 * expr-prs.c: (cmp_func) Removed.
703 (parse_function) Use binary_search() algorithm.
704 (compare_functions) New function.
705 (init_func_tab) Use sort() algorithm.
707 * algorithm.c: (binary_search) New algorithm.
709 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
711 * descript.q: (display) Use sort() algorithm instead of qsort().
712 (compare_func) Removed.
713 (descriptives_compare_variables) New function.
715 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
717 Get rid of AVL trees. Hashes are more appropriate for everything
720 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
726 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
728 Much code can be clarified by using C++ STL-like algorithms. Not
729 all uses of these algorithms are listed below, only the ones where
730 the change to an algorithm was the only change of interest.
732 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
734 * algorithm.c: New file.
736 * algorithm.h: New file.
738 * modify-vars.c: (static var forward) Removed.
739 (static var positional) Removed.
740 (compare_variables) Removed.
741 (struct ordering) New.
742 (cmd_modify_vars) Use sort() algorithm.
743 (compare_variables_given_ordering) New function.
744 (rearrange_dict) Use sort() algorithm.
746 * sysfile-info.c: (cmd_display) Use sort() algorithm.
747 (cmp_var_by_name) Removed.
749 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
751 Make file handles use a hash table.
753 * file-handle.q: (files) Change to hash table, make static.
754 (cmd_file_handle) Use hash table functions.
755 (fh_get_handle_by_filename) Ditto.
756 (fh_get_handle_by_name) Ditto.
757 (hash_file_handle) New function.
758 (cmp_file_handle) Rewrite.
759 (fh_init_files) Use hash table functions.
761 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
763 Clean up FREQUENCIES.
765 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
767 * frequencies.q: Remove a lot of old #if'd out code at the end.
768 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
769 or calc_weight(). Initialize percentile_values.
770 (calc) New function based on calc_weight() from frequencies.g.
771 (precalc) Use hash functions.
772 (static var comparison_func) Removed.
773 (static var comparison_param) Removed.
774 (comparison_helper) Removed.
775 (get_freq_comparator) New function.
776 (not_missing) New function.
778 (postprocess_freq_tab) Use hash table functions, algorithms,
779 get_freq_comparator(). Rewrite.
780 (cleanup_freq_tab) Rephrase.
781 (add_percentile) Clean up spacing.
782 (hash_value_numeric) New function.
783 (hash_value_alpha) New function.
784 (compare_value_numeric_a) Rewrite.
785 (compare_value_alpha_a) Rewrite.
786 (compare_value_numeric_d) Rewrite.
787 (compare_value_alpha_d) Rewrite.
788 (compare_freq_numeric_a) Rewrite.
789 (compare_freq_alpha_a) Rewrite.
790 (compare_freq_numeric_d) Rewrite.
791 (compare_freq_alpha_d) Rewrite.
792 (calc_stats) Clean up mode, percentiles, max.
793 (dump_statistics) Clean up spacing.
795 * frequencies.g: Removed.
797 * var.h: (struct freq_tab) Change `data' to hash table.
799 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
801 * file-handle.h: Remove declaration of global variable `files',
802 which wasn't used anywhere.
804 * postscript.c: (add_encoding) Remove superfluous cast.
807 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
810 * temporary.c: [0] (display_tree) Removed.
812 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
814 Implement a new random number generator based on the alleged RC4
817 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
820 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
821 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
823 (static var V[]) Removed.
824 (static var Y) Removed.
825 (static var X2) Removed.
826 (setup_randomize) Removed.
828 (rand_uniform) Removed.
829 (rand_normal) Removed.
830 (struct rng) New structure.
831 (rng_create) New function.
832 (rng_destroy) New function.
833 (swap_byte) New static function.
834 (rng_seed) New function.
835 (rng_get_bytes) New function.
836 (rng_get_int) New function.
837 (rng_get_unsigned) New function.
838 (rng_get_double) New function.
839 (rng_get_double_normal) New function.
840 (pspp_rng) New function.
842 * random.h: Sync up to random.c.
844 * sample.c: (struct sample_trns) Make `frac' unsigned and a
845 fraction of UINT_MAX, not 65536.
846 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
849 * vfm.c: (open_active_file) No need to call setup_randomize() any
852 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
854 Change dictionary name indexes to use hash tables instead of AVL
857 * crosstabs.q: (free_var_dict) Use hash tables.
858 (crs_custom_tables) Ditto.
859 (calc_general) Ditto.
860 (compare_table_entry) Rewrite.
861 (enum_var_values) Reorder parameters. All references updated.
864 * get.c: (rename_variable) Use hash tables.
865 (mtf_merge_dictionary) Ditto.
867 * glob.c: (init_glob) Use hash tables.
868 (cmp_variable) Removed.
870 * means.q: (mns_custom_tables) Use hash tables.
872 * modify-vars.c: (rearrange_dict) Use hash tables.
874 * rename-vars.c: (cmd_rename_variables) Use hash tables.
876 * sfm-read.c: (read_header) Use hash tables.
877 (read_variables) Ditto.
879 * temporary.c: (new_dictionary) Use hash tables.
880 (save_dictionary) Ditto.
881 (restore_dictionary) Ditto.
883 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
884 hash table `name_tab'.
886 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
887 [DEBUGGING] (dump_var_tree) Removed.
888 (find_variable) Use hash tables.
889 (find_dict_variable) Ditto.
890 (common_init_stuff) Ditto.
891 (rename_variable) Ditto.
892 (clear_variable) Ditto. Also, remove debug code.
893 (dup_variable) Use hash tables.
895 * vars-prs.c: (fill_all_vars) Use hash tables.
896 (is_dict_varname) Ditto.
897 (parse_dict_variable) Ditto.
899 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
901 Change value labels to use hash tables instead of AVL trees, and
902 change value labels into an ADT.
904 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
906 * value-labels.c: New file.
908 * value-labels.h: New file.
910 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
911 Get rid of a stupid use of goto.
913 * autorecode.c: (compare_alpha_value) Rewrite.
914 (hash_alpha_value) Ditto.
915 (compare_numeric_value) Rewrite.
916 (hash_numeric_value) Ditto.
918 * frequencies.q: (dump_full) Use value label ADT.
920 * pfm-read.c: (read_value_label) Use value label ADT.
922 * pfm-write.c: (write_value_labels) Use value label ADT.
924 * sfm-read.c: (read_variables) Use value label ADT.
925 (read_value_labels) Rewrite.
927 * sfm-write.c: (write_value_labels) Rewrite.
929 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
930 (display_variables) Ditto.
931 (describe_variable) Ditto.
933 * t-test.q: (print_t_groups) Use value label ADT.
935 * temporary.c: (copy_variable) Use value label ADT.
936 (free_dictionary) Ditto.
938 * val-labs.c: (verify_val_labs) Use value label ADT.
941 (val_lab_cmp) Removed.
942 (inc_ref_count) Removed.
943 (copy_value_labels) Removed.
945 * var.h: (struct value_label) Removed.
946 (struct variable) Change AVL tree `val_lab' into hash table
949 * vars-atr.c: (init_variable) Use value label ADT.
950 (clear_variable) Ditto.
951 (free_value_label) Removed.
952 (free_val_lab) Removed.
953 (get_val_lab) Removed.
954 (compare_variables) New function.
955 (hash_variable) New function.
957 * vfm.c: (dump_splits) Use value label ADT.
959 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
961 Add to the hash table interface.
963 * hash.c: (hsh_hash_bytes) Add assertion.
964 (hsh_hash_string) Ditto.
968 (hsh_create) Ditto. Also make minimum `size'.
969 (hsh_destroy) Rephrase.
970 (sort_nulls_last) Removed.
971 (not_null) New function.
973 (comparison_helper) Ditto.
974 (hsh_sort) Rewritten.
975 (hsh_data_copy) New function.
976 (hsh_sort_copy) Ditto.
979 (hsh_hash_double) Ditto.
980 (hsh_delete) Fix stupid bug.
982 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
983 * added a calculation of the mode to FREQUENCIES
985 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
987 * moved (un)defs of DEBUGGING to config.h
989 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
991 * groff-font.c: (add_kern) Fix indentation.
992 (add_kern) Use & instead of % to take power-of-2 modulus.
993 (font_get_kern_adjust) Likewise.
995 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
997 * autorecode.c: (recode) Replace stupid use of memcpy() by
999 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
1000 (hash_numeric_value) Ditto.
1001 (autorecode_proc_func) pool_strdup() was wrong here because the
1002 source string was not null-terminated. Use new pool_strndup()
1005 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
1006 use of hsh_iterator_init().
1008 * data-in.c: (parse_N) Initialize i->v->f.
1010 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
1013 * groff-font.c: Use power-of-2 hash table sizes, not prime.
1014 (groff_read_font) Don't call hsh_next_prime(). Don't call
1016 (static var hash) Remove `size_p', `max_used' members.
1017 (font_char_name_to_index) Don't call hsh_next_prime(). Use
1018 hsh_hash_string() instead of hashpjw(), & instead of %.
1019 (default_font) Don't call hsh_next_prime().
1021 * pool.c: (pool_strndup) New function.
1022 (pool_strdup) Reimplement in terms of pool_strndup.
1024 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
1026 (hash_ps_encoding) Use hsh_hash_string().
1027 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
1028 (hash_filename2font) Use hsh_hash_string().
1030 * som.c: Add #include <stdlib.h>.
1032 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
1033 (by destroying its pool).
1035 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
1037 Miscellaneous hash table code cleanup:
1039 * hash.h: (struct hsh_table) Moved into hash.c.
1040 (hsh_count) Ditto, and transformed into function.
1041 (hsh_compare_func) New typedef, used for defining otherwise-long
1042 function types here and in hash.c
1043 (hsh_hash_func) Ditto.
1044 (hsh_free_func) Ditto.
1046 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
1047 `table' to `entries'. Removed `mp'. All references updated.
1048 (hsh_clear) Don't shrink entries array; if the hash was this big
1049 once, it probably will be again.
1050 (hsh_rehash) Made static.
1051 (force_hsh_insert) Renamed hsh_force_insert.
1052 (force_hsh_find) Renamed hsh_force_find.
1054 Made hash table sizes powers of 2, because that's fine with any
1055 reasonable hash function and because taking a power-of-2 modulus
1056 is faster than any other:
1058 (hsh_prime_tab) Removed;
1059 (hsh_next_prime) Ditto.
1060 (next_power_of_2) New function.
1061 (hsh_create) Use next_power_of_2.
1062 (hsh_rehash) Use & instead of %.
1064 Cleaned up hsh_sort:
1066 (internal_comparison_fn) Removed.
1067 (sort_nulls_last) New function.
1068 (hsh_sort) Removed second parameter, switched to using the new
1069 quicksort() function from quicksort.h to avoid using nasty need
1070 for static variables with qsort(). All references updated.
1072 Changed the hash functions offered, because there are better hash
1073 functions than the ones we had, and cleaned up the names to boot:
1075 * hash.c: (hashpjw_d) Removed.
1077 (hsh_hash_bytes) New function.
1078 (hsh_hash_string) New function.
1079 (hsh_hash_int) New function.
1081 Improved the hash table iteration interface:
1083 * hash.h: (hsh_iterator_init) Removed.
1084 (struct hsh_iterator) Removed `init' member, change `next' to
1087 * hash.c: (hsh_foreach) Removed. All references updated to use
1088 hsh_first/hsh_next instead.
1089 (hsh_first) New function. Notably, unlike hsh_foreach() it does
1090 not treat a null pointer as an empty hash table.
1091 (hsh_next) New function.
1093 Made deletion possible, though slow:
1095 * hash.c: (locate_matching_entry) New function.
1096 (hsh_find) Use locate_matching_entry().
1097 (hsh_delete) New function also using locate_matching_entry().
1098 (hsh_force_delete) New function.
1100 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
1102 * quicksort.c: New file implementing a sort routine with a
1103 interface better than qsort() because it passes a user-provided
1104 parameter to the sort routine.
1106 * Makefile.am: Add quicksort.c, quicksort.h.
1108 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
1110 * All source files: Get rid of nasty special cases for Checker,
1111 which is pretty obsolete now.
1113 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
1115 * Fixed a bug apparent when using the FREQUENCIES command with the
1116 html driver. The html driver was incorrectly trying to display
1119 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
1121 * Makefile.am: Reorganized. Put locale dir in version.c instead
1122 of passing it to each compile command. Only put local gmp libs in
1123 LD_ADD if not installed on system. Remove `boast' target.
1125 * All source files: struct and union typedefs eliminated.
1126 `sizeof type' replaced by `sizeof object' where practical. Moved
1127 `unused' qualifiers from start to end of declarations for gcc
1128 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
1129 assertions on pointers strictly compliant. Removed _ prefixes on
1130 some function parameter names.
1132 * alloc.c: New source file, containing these external linkage
1133 functions removed from common.c: xmalloc, xcalloc, xrealloc,
1140 * ascii.c: Migrated from arenas to pools.
1141 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
1142 c_string to len_string. All references changed.
1143 (ascii_option) Signature changed to comply to new output.c
1145 (count_fancy_chars) Removed.
1146 (delineate) Removed support for rich text.
1147 (ascii_text_metrics) Ditto.
1149 (output_shorts) Change `box', `off', `on' from c_string to
1150 len_string. Change `remaining' from int to size_t.
1151 (ascii_close_page) Make page numbering less haphazard.
1153 * autorecode.c: Migrate from arenas to pools.
1155 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
1157 * bitvector.h: New file containing these macros from misc.h:
1158 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
1160 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
1161 word[3]. ncmd removed.
1162 (var empty_string) Removed.
1163 (var cmd_table) Declaration updated.
1164 (var cmdtab) Removed.
1165 (cmp_command) Removed.
1166 (split_words) Rewritten to use strtok_r().
1167 (init_cmd_parser) Renamed cmd_init(). Rewritten.
1168 (find_command) Removed.
1169 (FILE_TYPE_okay) Rewritten.
1170 (cmd_parse) Rewritten. Semantics of the return value of command
1171 handlers has changed: they must now return one of the new CMD_*
1172 enumerals, rather than a magic value. This meant that all
1173 commands had to be modified, and they were.
1174 (figure_out_command) New function.
1176 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
1177 #defines for INIT, INPU, etc.
1179 * command.h: New CMD_* enum series.
1180 (cur_proc) Make const char *, not char *.
1181 (cmd_init) Prototype.
1184 * common.c: Removed.
1186 * common.h: Removed.
1188 * correlations.q: New file.
1190 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
1192 (custom_tables) Renamed crs_custom_tables().
1193 (custom_variables) Renamed crs_custom_variables().
1194 (calc_integer) Add in some `const' qualifiers.
1195 (table_value_missing) Change from a_string to len_string.
1196 (float_M_suffix) Change from a_string to len_string.
1198 * data-in.c: Rewritten. All references to
1199 parse_string_as_format() changed to data_in().
1201 * data-in.h: New file.
1203 * data-list.c: Change DLS_* from #define's to enums. Move from
1204 rpd_msg() to tmsg().
1205 (RPD_ERR) New #define.
1206 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
1208 (read_from_data_list_fixed) Change from old
1209 parse_string_as_format() to new data_in().
1210 (read_from_data_list_free) Ditto.
1211 (read_from_data_list_list) Ditto.
1212 (cmd_repeating_data) Modify approach to checking for end of
1215 (rpd_parse_record) Change from old parse_string_as_format() to new
1216 data_in(). Change from old convert_format_to_string() to new
1218 (read_one_set_of_repetitions) Change dfm_push_cust() to
1219 dfm_push(), pop_cust() to dfm_pop().
1221 * data-out.c: Rewritten. All references to
1222 convert_format_to_string() changed to data_out().
1224 * descript.q: Migrate to new q2c.
1225 (cmd_descriptives) Removed.
1226 (internal_cmd_descriptives) Renamed cmd_descriptives ().
1227 (custom_variables) Renamed dsc_custom_variables().
1229 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
1231 (open_file_r) Initialize h->where.line_number. Migrate to new
1233 (open_file_w) Initialize h->where.line_number.
1234 (read_record) Change from ext->ln to h->where.line_number.
1235 Migrate to struct string.
1236 (dfm_put_record) Rephrased.
1237 (dfm_push_cust) Renamed dfm_push(), rewritten.
1238 (dfm_pop) New function.
1240 * error.c: All references updated.
1241 (glob var error_count) Renamed err_err_count.
1242 (glob var warning_count) Renamed err_warning_count.
1243 (glob var error_already_flagged) Renamed err_already_flagged.
1244 (glob var verbosity) Renamed err_verbosity.
1245 (glob var cust_fn) Removed.
1246 (glob var cust_ln) Removed.
1247 (static var file_loc) New.
1248 (static var nfile_loc) New.
1249 (static var mfile_loc) New.
1250 (tmsg) New function.
1251 (push_cust) Removed.
1254 (static var terminating) Removed.
1255 (failure) Renamed err_failure().
1256 (hcf) Renamed err_hcf().
1257 (err_push_file_locator) New function.
1258 (err_pop_file_locator) New function.
1259 (err_location) New function.
1260 (check_error_count) Renamed err_check_count().
1261 (vmsg) Renamed err_vmsg(). Interface changed.
1262 (verbose_msg) Removed.
1263 (err_cond_fail) New function.
1264 (error_break) Renamed err_break().
1266 * error.h: All references updated.
1267 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
1268 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
1270 (struct file_locator) New.
1272 (macro verbose_msg) Removed.
1273 (macro cond_fail) Removed.
1275 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
1277 * expr-prs.c: Reorganized. All references updated.
1278 (exprtypename) Renamed expr_type_name().
1279 (typename) Renamed type_name().
1280 (free_expression) Renamed expr_free().
1281 (parse_expression) Renamed expr_parse(). Uses new type_check()
1283 (init_functab) Renamed init_func_tab().
1284 (type_check) New function.
1285 (parse_or) Rewritten to use new allocate_nonterminal() and
1286 append_nonterminal_arg() functions.
1289 (parse_rel) Ditto. Also simplified logic.
1294 (SYSMIS_func) Ditto.
1295 (VALUE_func) Rephrased.
1296 (CONCAT_func) Fix memory leak by replacing free by free_node on
1298 (generic_str_func) Ditto.
1299 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
1301 (allocate_nonterminal) New function.
1302 (append_nonterminal_arg) New function.
1303 (static func_tab[]) Now at file level.
1305 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
1307 * expr.h: (enum series OP_*) Moved to exprP.h.
1308 (OP_* defines) Ditto.
1309 (struct op_desc) Ditto.
1310 (global ops[]) Ditto.
1311 (struct num_con_node) Ditto.
1312 (struct str_con_node) Ditto.
1313 (struct var_node) Ditto.
1314 (struct lag_node) Ditto.
1315 (struct casenum_node) Ditto.
1316 (struct nonterm_node) Ditto.
1317 (union any_node) Members renamed.
1318 (struct sys_node) Removed.
1319 (struct val_node) Removed.
1320 (operator typedef) Removed.
1321 (typedef exprtype) Removed.
1322 (enum series EX_*) Moved to exprP.h.
1323 (struct expression) Ditto. Also renamed a lot of the members.
1324 (PXP_* defines) Changed to enums.
1325 (free_node prototype) Moved to exprP.h.
1327 * file-handle.h: (struct file_handle) New member `where'.
1329 * file-handle.q: Migrated to new q2c format.
1330 (prepend_current_directory) Removed (dead code).
1331 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
1332 (fh_get_handle_by_filename) Removed dead code.
1333 Set new `where' member.
1335 * file-type.c: (file_type_source_read) References to
1336 parse_string_as_format() changed to data_in().
1337 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
1339 * filename.c: All references updated.
1340 (init_filename) Renamed fn_init().
1341 (expand_line) Removed.
1342 (macro EXPAND_LINE) Removed.
1343 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
1344 of custom functions.
1345 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
1346 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
1347 (normalize_filename) Renamed fn_normalize().
1348 (search_path) Renamed fn_search_path(), rewritten.
1349 (prepend_dir) Renamed fn_prepend_dir().
1350 (blp_getenv) Renamed fn_getenv().
1351 (blp_dirname) Renamed fn_dirname().
1352 (fn_basename) New function, not used.
1353 (absolute_filename_p) Renamed fn_absolute_p().
1354 (is_special_filename) Renamed fn_special_p().
1355 (file_exists) Renamed fn_exists_p().
1356 (readlink_malloc) Renamed fn_readlink().
1357 (getenv_default) Renamed fn_getenv_default().
1358 (open_file) Renamed fn_open().
1359 (close_file) Renamed fn_close().
1360 (open_file_ext) Renamed fn_open_ext().
1361 (close_file_ext) Renamed fn_close_ext().
1363 * font.h: Migrate from arenas to pools.
1365 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
1367 * frequencies.g: Migrate from arenas to pools.
1369 * frequencies.q: Migrate to new q2c version. Migrate from arenas
1372 * getline.c: All references updated.
1373 (global getl_buf) Changed from char * to struct string.
1374 (static getl_include_path) Ditto.
1375 (global getl_buf_len) Removed.
1376 (global getl_buf_size) Removed.
1377 (getl_include_path) Deal with new getl_buf, getl_include_path.
1378 (getl_uninitialize) New function.
1379 (getl_get_current_directory) Rewritten.
1380 (getl_clear_include_path) Rewritten.
1381 (getl_add_include_dir) Rewritten.
1382 (getl_add_file) Assertion fixed.
1383 (getl_add_virtual_file) Change initial value of `remaining_loops'
1385 (welcome) Rewritten.
1386 (handle_line_buffer) Make static. Change logic to make
1387 getl_add_virtual_file() change sensible. Use ds_*() strings.
1388 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
1389 (getl_close_file) Moved.
1390 (getl_location) New function.
1392 * getline.h: All references updated.
1393 (macro curln) Removed.
1394 (macro curfn) Removed.
1395 (macro am_interactive) Renamed getl_am_interactive.
1396 (macro am_reading_script) Renamed getl_reading_script.
1398 * glob.c: (global fmt_parse_ignore_error) Removed.
1399 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
1400 systems that support it (C99). Turn off SET ECHO by default. No
1401 necessary julcal initialization anymore.
1403 * groff-font.c: Migrate from arenas to pools.
1404 (groff_read_font) Use err_push_file_locator().
1405 (groff_read_DESC) Ditto.
1406 (font_msg) Use tmsg().
1408 * hash.c: (hsh_sort) Fix debug code.
1409 [GLOBAL_DEBUGGING] Include stdio.h.
1411 * hash.h: (macro force_hsh_insert) Rephrase.
1413 * heap.c: Rewritten.
1415 * heap.h: Rewritten.
1417 * html.c: (html_option) Change from outp_value to struct string.
1418 (postopen) Change from curfn to getl_location().
1419 (escape_string) Remove rich-text code. Signature changed.
1420 (output_tab_table) Switch from a_string to struct len_string.
1421 Remove rich text support.
1423 * lexer.c: All references updated. Largely rewritten. Major
1424 changes listed below. Removed tagged quote support. Adapted to
1425 struct string tokstr.
1426 (global tokstr) Changed to struct string.
1427 (global tokstr_size) Removed.
1428 (global tokstr_len) Removed.
1430 (global tokint) Removed.
1431 (global toklongstr) Removed.
1432 (C* defines) Removed.
1433 (static tbl[]) Removed.
1434 (static id[]) Removed.
1435 (static une[]) Removed.
1436 (discard_line) Renamed lex_discard_line().
1437 (get_entire_line) Renamed lex_entire_line().
1438 (get_rest_of_line) Renamed lex_rest_of_line().
1439 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
1440 (make_hexit) Removed.
1441 (syntax_error) Renamed lex_error(). Return value removed.
1442 (get_token_representation) Renamed lex_token_representation().
1443 (putback) Renamed lex_put_back().
1444 (putfwd) Renamed lex_put_forward().
1445 (convert_negative_to_dash) Renamed lex_negative_to_dash().
1446 (set_prog) Renamed lex_set_prog().
1447 (init_lex) Renamed lex_init().
1448 (reset_eof) Renamed lex_reset_eof().
1449 (lookahead) Renamed lex_look_ahead().
1450 (check_id) Rewritten.
1451 (yylex) Renamed lex_get(), rewritten.
1452 (lex_end_of_command) New function. Many commands were rephrased
1454 (lex_integer_p) New function. Replaces compare of tokint against
1456 (lex_integer) New function. Replaces tokint.
1457 (match_tok) Renamed lex_match().
1458 (match_id) Renamed lex_match_id().
1459 (match_int) Renamed lex_match_int().
1460 (force_match_id) Renamed lex_force_match_id(), added return value.
1461 (force_match) Renamed lex_force_match(), added return value.
1462 (force_string) Renamed lex_force_string(), added return value.
1463 (force_int) Renamed lex_force_int(), added return value.
1464 (lex_id_match_len) New function.
1465 (id_match) Renamed lex_id_match(), rewritten.
1466 (get_line) Renamed lex_get_line().
1467 (preprocess_line) Renamed lex_preprocess_line().
1468 (tokname) Renamed lex_token_name().
1469 (bin_value_func) Removed.
1470 (oct_value_func) Removed.
1471 (hex_value_func) Removed.
1472 (unexpected_eof) New function.
1473 (convert_numeric_string_to_char_string) New function.
1474 (parse_string) Rewritten, signature changed.
1475 (add_tokstr_char) Removed.
1476 (add_tokstr_unsigned) Removed.
1477 (add_tokstr_string) Removed.
1478 (parse_tagged_quote) Removed.
1479 (skip_comment) Renamed lex_skip_comment().
1481 * lexer.h: All references updated.
1482 (macro is_id1) Renamed CHAR_IS_ID1.
1483 (macro is_idn) Renamed CHAR_IS_IDN.
1484 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
1485 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
1486 (macro get_token) Removed.
1487 (macro id_match) Removed.
1488 (macro force_match_id) Removed.
1489 (macro force_match) Removed.
1490 (macro force_string) Removed.
1491 (macro force_int) Removed.
1492 (macro force_num) Removed.
1493 (macro force_id) Removed.
1495 * lexerP.h: Removed.
1497 * list.q: Migrated to new q2c format.
1498 (write_line) Deal with struct len_string.
1499 (write_varname) Ditto.
1500 (write_fallback_headers) Ditto.
1502 * magic.c: New file, incorporating the following global variables
1503 previously in other files: endian, second_lowest_value. And both
1504 of those are conditional on #define's.
1506 * magic.h: New file, incorporating the following global variable
1507 declarations: endian, second_lowest_value, and the following macro
1508 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
1510 * main.c: Added declarations of pgmname, finished, curdate,
1512 (main) Call new parse_script() function.
1513 (parse_script) New function.
1514 (execute_command) New function.
1515 (dump_token) Removed.
1516 (handle_error) New function.
1518 * matrix.c: New file.
1520 * matrix.h: New file.
1522 * matrix-data.c: Migrated from arenas to pools.
1523 (mget_token) Change from parse_string_as_format() to data_in().
1525 * means.q: Migrate to new q2c.
1526 (custom_tables) Renamed mns_custom_tables().
1527 (custom_crossbreak) Renamed mns_custom_crossbreak().
1528 (custom_variables) Renamed mns_custom_variables().
1530 * mis-val.c: (static var width) Changed from `int' to `size_t'.
1531 (parse_varnames) Prototype.
1532 (parse_numeric) Rephrasings.
1533 (parse_alpha) Adapt to new struct string tokstr.
1535 * misc.c: (intlog10) Rewritten.
1537 (ansi_rand) Renamed real_rand(), moved into random.c.
1538 (ansi_srand) Renamed real_srand(), moved into random.c.
1539 (setup_randomize) Moved to random.c.
1540 (rand_uniform) Ditto.
1541 (rand_normal) Ditto.
1542 (rand_simple) Ditto.
1543 (get_config_line) Removed.
1544 (reverse) Removed (dead code).
1546 * misc.h: (macro SET_BIT) Moved to bitvector.h.
1547 (macro CLEAR_BIT) Ditto.
1548 (macro TEST_BIT) Ditto.
1549 (macro SET_BIT_TO) Ditto.
1550 (macro BIT_INDEX) Ditto.
1552 * output.c: (outp_read_devices) Move to err_push_file_locator()
1553 from push_cust(). Use struct string.
1554 (expand_op_tokstr) Removed.
1555 (static var op_tokstr) Changed to struct string.
1556 (static var op_tokstr_size) Removed.
1557 (tokener) Rephrasings. Use struct string.
1558 (parse_options) Use struct string.
1559 (destroy_driver) Fix assertion.
1560 (outp_get_paper_size) Move to err_push_file_locator().
1561 [0] Removed dead code.
1562 (outp_string_width) Move to len_string.
1564 * output.h: Comment fixes.
1565 (TAG_* enum series) Removed.
1566 (struct outp_value) Removed.
1567 (enum OUTP_T_FANCY) Removed.
1568 (struct outp_text) `s' changed from a_string to len_string.
1569 (struct outp_class) `option' change arg 3 from outp_value to
1572 * pfm-read.c: (corrupt_msg) Rewritten.
1574 * pfm-write.c: (bufwrite) Fix assertion.
1576 * pool.c: New file, reference version.
1578 * pool.h: New file, reference version.
1580 * postscript.c: (ps_font_sizes) Fix assertion.
1581 (ps_option) Change arg 3 from outp_value to struct string.
1582 Adapt to struct string.
1583 (macro output_line) Removed.
1584 (macro add_string) Removed.
1585 (output_encodings) Adapted to struct string. Moved to
1586 err_push_file_locator().
1587 (find_encoding_file) Fix assertion.
1588 (read_ps_encodings) Move to err_push_file_locator().
1589 (postopen) Use getl_location() instead of curfn.
1590 (out_text_plain) Move to len_string.
1591 (text) Ditto. Remove rich text support.
1593 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
1594 (cmd_print_eject) Ditto.
1596 (internal_cmd_print) Now cleans up after itself. Uses
1597 fh_parse_file_handle() now.
1598 (cmd_print_space) Use PXP_NUMERIC to type-check.
1600 * q2c.c: Overhauled. Removed _("") i18n support. All references
1601 updated. All output functions updated to handle structures rather
1602 than local or static variables. Adapt to new PSPP lex_*()
1606 (macro MAX_N_SBC) Removed.
1607 (global bare) Removed.
1608 (enum STRING) Renamed T_STRING.
1609 (enum ID) Renamed T_ID.
1610 (get_buffer) Buffer size increased.
1611 (strlower) Renamed st_lower(), rephrased.
1612 (strupper) Renamed st_upper(), rephrased.
1613 (skip_ws) New function.
1614 (get_line) Don't special-case any types of lines (like those
1615 beginning with ! or $, for instance).
1616 (get_token) Renamed lex_get(). Rephrased.
1617 (static var `prefix') New.
1618 (parse) New function.
1619 (parse_setting) Minor rephrasing.
1620 (dump_specifier_vars) Ditto.
1621 (make_identifier) Put null terminator on identifier, duh.
1622 (dump_vars) Renamed dump_declarations(). Never indent. Never
1623 static. Output changed entirely.
1624 (dump_specifier_init) Rephrase.
1625 (dump_vars_init) No index variable needed. Other modifications.
1626 (dump_parser) Don't parse command name. Do dump functions instead
1627 of just code fragments.
1628 (dump_free) Dump function instead of code fragment.
1629 (recognize_directive) New function.
1630 (main) Use recognize_directive(). Don't rely on magic $ line
1631 beginning: instead, parse comments. Update list of headers.
1633 * random.c: New file, containing the following functions:
1634 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
1635 rand_normal, rand_simple.
1637 * random.h: New file.
1639 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
1640 function. `max_src_width', `max_dst_width' changed to size_t.
1641 (internal_cmd_recode) Removed.
1642 (parse_dest_spec) Merge similar cases.
1643 (parse_src_spec) Add assertion.
1645 * repeat.c: (recognize_keyword) New function.
1646 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
1647 REPEAT. Improve recognition of END REPEAT (use
1648 recognize_keyword()). Move from curfn to getl_location(). Use
1651 (perform_DO_REPEAT_substitutions) Adapt to struct string.
1653 * set.q: Adapt to new q2c.
1654 (cmd_set) Range-check some values better.
1655 (custom_blanks) Renamed stc_custom_blanks().
1656 (custom_length) Renamed stc_custom_length().
1657 (custom_results) Renamed stc_custom_results().
1658 (custom_seed) Renamed stc_custom_seed().
1659 (custom_width) Renamed stc_custom_width().
1660 (custom_format) Renamed stc_custom_format().
1661 (custom_journal) Renamed stc_custom_journal().
1662 (custom_color) Renamed stc_custom_color().
1663 (custom_listing) Renamed stc_custom_listing().
1664 (custom_disk) Renamed stc_custom_disk().
1665 (custom_log) Renamed stc_custom_log().
1666 (custom_rcolor) Renamed stc_custom_rcolor().
1667 (custom_viewlength) Renamed stc_custom_viewlength().
1668 (custom_workdev) Renamed stc_custom_workdev().
1670 * settings.h: Not necessary to include format.h any longer.
1672 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
1673 (corrupt_msg) Rewritten.
1675 * sort.c: Adapt to rewritten heap ADT.
1677 * str.c: (aa_strcpy) Removed.
1678 (ab_strcpy) Removed.
1679 (ac_strcpy) Removed.
1680 (ba_strcpy) Removed.
1681 (bb_strcpy) Removed.
1682 (ca_strcpy) Removed.
1683 (aa_strdup) Removed.
1684 (aa_strdupcpy) Removed.
1685 (ba_strdup) Removed.
1686 (sa_strdup) Removed.
1687 (memrev) Renamed mm_reverse().
1688 (memrmem) Renamed mm_find_reverse().
1689 (cmp_str) Renamed st_compare_pad().
1690 (strmaxcpy) Removed.
1691 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
1692 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
1694 (strpadcpy) Renamed st_pad_copy(), signature changed.
1695 (blpstrset) Removed.
1696 (ds_create) New function.
1697 (ds_init) New function.
1698 (ds_replace) New function.
1699 (ds_destroy) New function.
1700 (ds_clear) New function.
1701 (ds_extend) New function.
1702 (ds_shrink) New function.
1703 (ds_truncate) New function.
1704 (ds_length) New function.
1705 (ds_size) New function.
1706 (ds_value) New function.
1707 (ds_end) New function.
1708 (ds_concat) New function.
1709 (ds_concat_buffer) New function.
1710 (ds_printf) New function.
1711 (ds_putchar) New function.
1712 (ds_getline) New function.
1713 (ds_get_config_line) New function derived from the old
1714 misc.c:get_config_line().
1715 (ls_create) New function.
1716 (ls_create_buffer) New function.
1717 (ls_init) New function.
1718 (ls_shallow_copy) New function.
1719 (ls_destroy) New function.
1720 (ls_null) New function.
1721 (ls_null_p) New function.
1722 (ls_empty_p) New function.
1723 (ls_length) New function.
1724 (ls_value) New function.
1725 (ls_end) New function.
1727 * str.h: Reformatted.
1728 (struct a_string) Removed.
1729 (struct b_string) Removed.
1730 (struct c_string) Removed.
1731 (struct len_string) New.
1732 (struct string) New.
1733 (macro as_streq) Removed.
1734 (macro bs_streq) Removed.
1735 (macro cs_streq) Removed.
1736 (macro sa_streq) Removed.
1737 (macro sb_streq) Removed.
1738 [__GNUC__] (inline function ds_putchar) New function.
1739 [__GNUC__] (inline function ds_length) New function.
1740 [__GNUC__] (inline function ds_value) New function.
1741 [__GNUC__] (inline function ds_end) New function.
1743 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
1744 (display_vectors) Fix missing i18n.
1746 * t-test.q: Migrate to new q2c.
1748 * tab.c: Migrate from arenas to pools.
1749 (tab_create) Use struct len_string.
1750 (tab_realloc) Ditto.
1751 (text_format) Ditto.
1752 (tab_joint_text) Ditto.
1753 (tab_natural_width) Remove rich text support.
1754 (tab_natural_height) Ditto.
1755 (tab_output_text) Handle TAT_FIX.
1756 (tab_raw) Change arg from a_string to len_string.
1757 (tabi_driver) Fix assertion. Use struct len_string.
1758 (render_strip) Use struct len_string. Remove rich text support.
1759 Add `const' qualifiers.
1761 * tab.h: (enum TAB_RICH) Remove.
1762 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
1763 SOM_COL_* updated to read TAB_COL_*.
1764 (struct tab_table) Change arena to pool. Change a_string to
1767 * temporary.c: (restore_dictionary) Rewrite Checker code.
1769 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
1770 LOWEST, HIGHEST) Moved here from common.h.
1771 (typedef any_trns) Removed. All references changed to `struct
1774 * vars-atr.c: (force_create_variable) Fix assertion.
1775 (force_dup_variable) Fix assertion.
1777 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
1779 Using alphanumeric variables in functions under AGGREGATE
1780 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
1781 <BZN-mdksh@t-online.de> for reporting this bug.
1783 * aggregate.c: (parse_aggregate_functions) When setting the
1784 FSTRING bit, also allocate memory for the `string' member of
1786 (free_aggregate_functions) Free iter->string. Don't use the
1787 non-function bits when indexing the array of functions.
1788 [DEBUGGING] (debug_print) Don't use the non-function bits when
1789 indexing the array of functions.
1791 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
1793 Under certain circumstances, the final case would be omitted from
1794 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
1795 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
1797 * aggregate.c (agr_00x_end_func): Increment number of cases in
1798 sink before writing case. For streams that keep track of how many
1799 cases there are based on this value, this means that the last case
1800 will be read in on the next stream read.
1802 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
1804 Undefined behavior was invoked by referencing a freed pointer.
1806 * vfm.c (memory_stream_write): Free pointer *after* checking for
1809 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
1811 A wrong record size was displayed when paging the active file to
1814 * vfm.c: (memory_stream_write) Fix off-by-one error.
1816 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
1818 Not having enough temporary space for sorting caused a core dump.
1821 * sort.c: (allocate_cases) Initialize i.
1823 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
1825 Syntax errors in function descriptions on AGGREGATE caused core
1828 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
1829 free_aggregate_functions(), since that function already frees
1832 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
1834 A null pointer was dereferenced, causing a core dump, when
1835 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
1836 but PSPP still doesn't calculate percentiles. Thanks to Regnor
1837 Jernsletten <rjernsle@eunet.no> for reporting this problem.
1839 * arena.c: (arena_malloc) If the arena hasn't been initialized
1840 already, initialize it.
1842 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
1844 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
1845 for compilation with Cygnus Windows B20. Not used by other
1848 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
1850 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
1851 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
1853 * sort.c: (compare_case_lists) Reverse sense of comparison if
1854 sorting in descending order.
1855 (compare_record) Ditto.
1857 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
1859 SPLIT FILE with a string variable caused a core dump. Fixed.
1861 * vfm.c: If the variable is a string then make a temporary value
1862 struct pointing to it. The underlying problem is a lot bigger
1863 than this (see TODO) but this is a stopgap for the simple case at
1866 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
1868 Nested INCLUDEs didn't work. Fixed.
1870 * getline.c: (getl_include) Set first_line to NULL in allocated
1873 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
1875 The MATCH FILES procedure set the values of variables not present
1876 to 0. It should have been SYSMIS. This is now fixed.
1878 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
1880 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
1882 The REMARK command was too aggressive about skipping lines. It
1883 didn't like being the last command in a file.
1885 * command.c: (cmd_remark) Call get_entire_line() instead of
1888 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
1890 Comment parsing wasn't consistent with the rest of the code in its
1891 idea of where one command ends and another starts. This meant
1892 that sometimes commands would be mysteriously ignored. Thanks to
1893 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
1895 * command.c: (parse_cmd) Hand off comment parsing to new function
1896 skip_comment() in lexer.c.
1897 * lexer.c: (skip_comment) New function.
1899 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
1901 The TABLE subcommand on MATCH FILES worked only erratically at
1902 best. This fixes it. Thanks to Dr. Dirk Melcher
1903 <BZN-mdksh@t-online.de> for reporting this bug.
1905 * get.c: (mtf_compare_BY_values) When comparing string values, a
1906 difference of 1 is still a difference :-)
1907 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
1908 advance TABLE files automatically when matched. Comment fixes.
1910 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
1912 VARIABLE LABELS rejected a slash before the first variable
1913 specification, contradicting the documentation. Thanks to Walter
1914 M. Gray <graywm@northernc.on.ca> for reporting this bug.
1916 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
1917 command specification.
1919 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
1921 Because of an incorrect optimization in memory allocation,
1922 CROSSTABS sometimes segfaulted when asked to output multiple
1923 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
1926 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
1927 are passed to output_pivot_table() for its use.
1928 (output_pivot_table) Instead of assuming the number of columns is
1929 constant, keep track with maxcols. In general mode, use maxcells
1930 to determine whether more matrix cells need to be allocated.
1932 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
1934 CROSSTABS didn't display value labels for column and row
1935 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
1938 * crosstabs.q: (table_value_missing) If the specified value has a
1939 value label for this variable, then show it instead of the raw
1941 (display_dimensions) Delegate display of value_labels to
1942 table_value_missing.
1944 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
1946 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
1947 <BZN-mdksh@t-online.de> for reporting this bug.
1949 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
1950 if the file isn't declared as binary.
1952 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
1954 MATCH FILES corrupted memory and dumped core on some syntax
1957 * get.c: (cmd_match_files) Set file->handle to NULL before
1959 (mtf_free_file) Don't free a null dictionary.
1961 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
1963 MATCH FILES should set numeric values not available to the
1964 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
1965 <BZN-mdksh@t-online.de> for reporting this bug.
1967 * get.c: (mtf_processing) Set unused records to system-missing,
1970 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
1972 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
1973 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
1975 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
1976 in newly created dictionary, and add each copied variable to the
1979 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
1983 * get.c: (trim_dictionary) Free variable list for KEEP after
1986 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
1988 Some systems didn't like the way open_file was coded. Thanks to
1989 Hankin <hankin@rogue.consultco.com> for pointing this out.
1991 * filename.c: (open_file) Don't try to store stdin, stdout,
1992 stderr as part of an array, because that doesn't always work.
1994 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
1996 The SAVE procedure didn't save long string variables properly.
1997 Fixed by this patch. Thanks to Hankin
1998 <hankin@rogue.consultco.com> for this patch.
2000 * sfm-write.c: (write_variable) Fix off-by-one error in writing
2001 out variable pad records.
2003 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
2005 Previously, if PRINT SPACE were given a negative argument, it
2006 would report an error, then spin in an (almost) infinite loop.
2007 This fixes that behavior.
2009 * print.c: (print_space_trns_proc) After reporting a negative
2010 argument, set number of lines to print to 1.
2012 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
2014 SPSS 8.0 outputs some new record types in its system files, and it
2015 allows longer value labels. Accept these system files.
2017 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
2018 11 emitted by SPSS 8.0.
2020 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
2022 The LIST procedure was too conservative in allocating space for
2023 buffers, which caused a bug that only showed up with very long
2024 output variables. Thanks to Hankin <hankin@dunno.com> for this
2027 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
2029 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
2031 Typo meant string format specifiers weren't checked properly. I
2032 think that Hankin <hankin@dunno.com> sent me this report, but I'm
2033 willing to be corrected on this point.
2035 * format.c: (check_string_specifier) Fix obvious typo.
2037 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
2039 Using $CASENUM in an expression didn't work. Here's a fix.
2040 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
2043 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
2045 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
2047 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
2049 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
2050 other behavior, *sigh*. This patch hopefully fixes that. This
2051 time I've actually tested it.
2053 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
2055 * data-list.c: (read_from_data_list_free,
2056 read_from_data_list_list) Call parse_string_as_format() directly
2057 without mucking around with the field width.
2059 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
2061 Occasionally, you may encounter a script that wants to be
2062 interpreted in interactive mode. Make -i emulate this behavior to
2063 allow such scripts to be executed with PSPP.
2065 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
2067 * cmdline.c: (pre_syntax_message[]) Update -i description.
2069 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
2070 when -i is given on the command line) don't treat unindented lines
2071 as starting a new command.
2073 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
2075 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
2076 mostly caused by local initialized aggregates. After egcs is
2077 fixed upstream these can be removed, but for now they're not a big
2080 * ascii.c: (ascii_postopen_driver) Checker chokes on local
2081 initialized arrays. Avoid this.
2083 * sfm-write.c: (sfm_write_dictionary) Don't use a local
2086 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
2088 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
2089 following changes avoid. Currently I compile sources with egcs
2090 1.1.1 and gcc 2.7.2.3 before sending them out.
2092 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
2094 * ascii.c: (option_tab[]) Initialize all struct members.
2096 * avl.h: (avl_traverser_init) New macro.
2098 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
2101 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
2104 * hash.c: Comment fix.
2106 * hash.h: (hsh_iterator_init) New macro.
2108 * html.c: (option_tab[]) Initialize all struct members.
2110 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
2113 * postscript.c: (option_tab[]) Initialize all struct members.
2114 (output_encodings, preclose, dump_lines) Use new
2115 hsh_iterator_init() macro.
2117 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
2120 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
2123 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
2125 * data-in.c: Examined each of the parsing functions to make sure
2126 that they wouldn't dump core if they were passed a string of the
2127 wrong length, since now the DATA LIST FREE/LIST routines don't
2128 check for field width before passing it to the data parser.
2129 (parse_RBHEX, parse_AHEX) Reject odd length input.
2130 (parse_string_as_format) Reject input that's too short or too
2133 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
2134 a field to its entire declared output width then pass it to the
2135 data-in parsing routines. This contradicted the documented
2136 behavior. This is fixed in these changes. Thanks to Mark H. Wood
2137 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
2138 free-format parsing that differed from SPSS.
2139 (cut_field) Commas and spaces are treated identically. Returns
2140 the proper column instead of a fixed 1 value.
2141 (parse_field) Removed.
2142 (read_from_data_list_free, read_from_data_list_list) Call
2143 parse_string_as_format directly instead of parse_field.
2145 * heap.c: (heap_delete) Stylistic fixes.
2147 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
2149 * loop.c: (loop_2_trns_proc) Formatting fix.
2151 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
2153 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
2155 * vfm.c: (macro FILTERED) New.
2156 (static var filter_var) New.
2157 (process_active_file_write_case) Use FILTERED.
2158 (setup_filter) Set filter_var.
2159 (close_active_file) Delete the filter if not
2160 FILTER_before_TEMPORARY.
2161 (procedure_write_case) Use FILTERED.
2163 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
2165 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
2167 * data-in.c: (parse_day_count) Message fix.
2168 (parse_month) Style fix.
2170 * data-list.c: (struct data_list_pgm) New member eof.
2171 (cmd_data_list) Init eof to 0.
2172 (do_reading) Implement the /END subcommand and read-past-eof
2175 * do-if.c: Include stdio.h when debugging.
2176 (cmd_else_if) Make sure the command is .-terminated.
2178 * glob.c: (init_glob) Capitalize the command prompt.
2180 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
2181 (end_file_trns_proc) Debugging message.
2183 * loop.c: (internal_cmd_loop) Make it work when there's no loop
2185 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
2187 * main.c: (dump_token) Make kwtab[] const.
2189 * set.q: Spelling, comment fixes.
2191 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
2194 * vars-prs.c: (fill_all_vars) Style fix.
2196 * vfm.c: (index_to_varname) Return const.
2198 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
2200 * Changes in many source files for partial -ansi -pedantic and
2201 no-debugging compliance: Remove trailing common in enum
2202 declarations; add `unused' attributes; insert some appropriate
2205 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
2207 * command.c: (shell) Make static.
2208 (run_command) Make static.
2210 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
2212 * dfm.c: (cmd_begin_data) I18n fix.
2214 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
2216 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
2218 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
2221 * file-handle.q: Don't prepend the source file directory name to
2222 the data file name. (Ongoing issue.)
2223 (prepend_current_directory) Comment out.
2224 (internal_cmd_file_handle) Don't call prepend_current_directory().
2225 (fh_get_handle_by_filename) Ditto.
2227 * filename.c: Append zero byte to readlink() return value.
2229 * getline.c: (getl_read_line) I18n fix.
2231 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
2233 * misc.h: Don't use gcc features if __STRICT_ANSI__.
2235 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
2238 * postscript.c: (output_encodings) Don't use local_strdup().
2241 * print.c: Don't use gcc features if __STRICT_ANSI__.
2243 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
2245 * recode.c: (parse_src_spec) Fully brace nested if's.
2247 * set.q: (global var set_testing_mode) New var.
2249 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
2251 * ascii.c: Add some more `unused' attributes that only come into
2252 play when NDEBUG is defined.
2253 (ascii_close_page) Set s_len when reallocating s.
2255 * crosstabs.q: (delete_missing) New function.
2256 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
2257 (make_summary_table) Create summary table reallocable.
2259 * postscript.c: Add more `unused' attributes as above.
2261 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
2262 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
2264 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
2267 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
2268 gratuitous space between parameter definition.
2270 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
2271 complaints about running off the end of functions with NDEBUG
2274 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
2276 * Several source files: Removed some PORTME notes when reflection
2277 revealed that ANSI forbids that sort of breakage. Also, added
2278 lots of `unused' qualifiers here and there.
2280 * aggregate.c: (accumulate_aggregate_info) Remove local var
2281 weighting that turned out not to be used.
2283 * avl.c: Update to version 1.1.0. Add unused specifier.
2284 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
2286 (avl_probe) Replace some instances of 1 with +1 where appropriate.
2287 (avl_find) Cast return value to void *.
2288 (avl_delete) q doesn't need to be initialized at the beginning of
2289 the function. Replace some instances of 1 with +1.
2290 (force_avl_delete) Renamed avl_force_delete, all references changed.
2291 (compare_ints) `param' marked unused.
2292 (print_int) `param' marked unused.
2293 (recurse_tree) Replace some instances of 1 with +1.
2295 * avl.h: Update to version 1.1.0. Only declares avl function
2296 types if not already declared.
2297 (AVL_MAX_HEIGHT) Only define if not already defined.
2298 (struct avl_node) New unused member char pad[2].
2299 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
2300 (force_avl_insert) Renamed avl_force_insert.
2301 (force_avl_delete) Renamed avl_force_delete.
2303 * crosstabs.q: (struct table_entry) Put `freq' into a union with
2305 (struct crosstab) Add new member `ofs'.
2306 (glob var int_tab) Removed.
2307 (custom_tables) In integer mode, assign v[i] properly through the
2309 (custom_variables) Now p.crs.max == max + 1.
2310 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
2311 (precalc) Implement integer mode.
2312 (calc_integer) Implement integer mode.
2313 (compare_table_entry) Remove unused local variable `comparing'.
2314 (make_summary_table) Implement integer mode.
2315 (macro ns_rows) Implemented as static variable now.
2316 (several variables) Made static, from global.
2317 (output_pivot_table) Use table_value_missing() for column heads.
2318 Remove several unused local variables. Implement integer mode
2319 table summing. Count up ns_rows.
2320 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
2321 (find_pivot_extent) Moved into find_pivot_extent_general; now just
2322 calls that function or find_pivot_extent_integer.
2323 (find_pivot_extent_integer) New function.
2324 (enum_var_values) Implemented for integer mode.
2325 (table_value_missing) New function.
2326 (display_dimensions) Call table_value_missing() for heads.
2327 (float_M_suffix) New function.
2328 (display_crosstabulation) Call table_value_missing() for row
2329 heads. Handle missing values in /MISSING=REPORT mode.
2330 (calc_fisher) Remove unused var N.
2331 (calc_r) Remove unused var fact.
2333 * data-list.c: (dump_fixed_table) Fix table dimensioning.
2334 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
2336 * data-out.c: (insert_commas) Remove unused var cp.
2337 (convert_CCx) Remove unused vars save_set_decimal,
2340 * descript.q: (dump_z_table) Fix table dimensioning.
2341 (pre_calc) Remove unused var j.
2342 (display) Remove unused vars title, s. Fix table dimensioning.
2344 * expr-evl.c: Comment fixes.
2346 * frequencies.q: (full_dim) New function.
2347 (dump_full) Fix table dimensioning.
2348 (condensed_dim) New function.
2349 (dump_condensed) Fix table dimensioning.
2351 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
2354 * html.c: (html_close_drive) Remove unused var i.
2355 (postopen) Remove unused vars title, curfn_len, cp.
2356 (preclose) Remove unused vars this, x.
2358 * lexer.c: Comment fixes.
2360 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
2362 * means.q: (custom_tables) Remove unused var m_dim.
2364 * mis-val.c: Format fix.
2366 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
2368 * output.c: (outp_get_paper_size) Remove unused var cp.
2370 * pfm-read.c: (read_float) Remove unused var save, unused label
2372 (read_variables) Remove unused vars cp, j.
2373 (read_value_label) Remove unused var j.
2375 * pfm-write.c: (bufwrite) Remove unused var i.
2377 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
2379 (output_encodings) Remove unused vars char_cp, n_output.
2380 (read_ps_encodings) Remove unused var ep.
2381 (postopen) Remove unused var title.
2382 (preclose) Remove unused var fp.
2383 (ps_open_page) Remove unused vars true, false, orientation,
2384 mirror_horz, mirror_vert, width, length.
2385 (ps_text_metrics) Remove unused var x.
2387 * q2c.c: (find_symbol) Remove unused var y.
2388 (parse_setting) Remove unused parameter sbc, all references
2390 (dump_parser) Remove unused var cp.
2391 (dump_free) Remove unused var i.
2393 * set.q: (static vars args, n) Removed.
2394 (internal_cmd_gset) Removed.
2396 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
2397 (read_machine_flt64_info) Removed unused var file_endian.
2398 (read_documents) Removed unused var i.
2399 (read_compressed_data) Removed unused parameter dict, all
2402 * sfm-write.c: (bufwrite) Removed unused var i.
2403 (sfm_write_case) Removed unused var i.
2405 * sort.c: (merge_once) Remove unused var t.
2406 (write_separate) #if 0 out as dead code.
2408 * split-file.c: (cmd_split_file) Remove unused var i.
2410 * sysfile-info.c: (sysfile_info_dim) New function.
2411 (cmd_sysfile_info) Fix table dimensioning.
2412 (variables_dim) New function.
2413 (display_variables) Fix table dimensioning.
2414 (describe_variable) Remove unused var prev_r.
2416 * t-test.q: (z_postcalc) Removed.
2417 (pairs_calc) Remove unused var bad_weight.
2418 (postcalc) Remove unused vars dfn, dfd.
2420 * tab.c: (tab_create) Set t->dim to NULL.
2421 (tab_dim) Make sure t->dim is NULL first.
2422 (tab_natural_width) Remove parameter `clamp'.
2423 (tab_value) Remove duplicate assertion for table.
2424 (tab_raw) New function.
2425 (nowrap_dim) New function.
2426 (wrap_dim) New function.
2427 (tab_output_text) Fix table dimensioning.
2429 * tab.h: (tab_raw) New macro.
2431 * val-labs.c: (get_label) Remove unused var type.
2432 (copy_value_labels) Remove unused var trav.
2434 * var.h: (struct crosstab_proc) Completely changed.
2436 * vars-prs.c: (parse_dict_variable) Remove unused var v.
2438 * vfm.c: (open_active_file) Remove unused vars i, lp.
2440 * weight.c: (weight_trns_proc) #if 0 out as dead code.
2442 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
2444 * Makefile.am: Add apply-dict.c, flip.c.
2446 * apply-dict.c: New file.
2448 * command.c: (struct command) Make cmd[] larger for CLEAR
2449 TRANSFORMATIONS command name.
2450 (parse_cmd) Make sure we're in a valid state before using it as an
2451 index. Discard variables and reset state on invalid transitions.
2452 (cmd_clear_transformations) New function.
2454 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
2455 Add unimplemented PRESERVE, RESTORE.
2457 * file-handle.h: Include stddef.h.
2461 * pfm-read.c: (parse_value) Pad value label values with spaces,
2464 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
2465 (sfm_close) Decrement reference count, make sure it's zero.
2466 (sfm_maybe_close) New function.
2467 (sfm_read_dictionary) Handle reference counts.
2469 * vars-atr.c: (clear_default_dict) New function.
2470 (discard_variables) Use clear_default_dict().
2472 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
2474 * Makefile.am: Add pfm-write.c.
2475 (LDADD) Add the libgmp2 libraries.
2477 * command.def: Define EXPORT.
2479 * get.c: (cmd_export) New function.
2480 (export_write_case_func) New function.
2482 * pfm-read.c: (static spss2ascii[]) Make it const.
2484 * pfm-write.c: New file.
2486 * sfm-write.c: Formatting, comment fixes.
2488 * var.h: Comment fix.
2490 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
2492 * Makefile.am: Add pfm.h, pfm-read.c.
2494 * command.def: IMPORT is now implemented.
2496 * format.c: (glob var translate_fmt[]) New var.
2498 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
2499 (cmd_import) New function.
2500 (import_source_read) New function.
2501 (glob var import_source) New var.
2503 * pfm-read.c: New file.
2507 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
2509 (dump_dictionary) Disabled printing a couple of items.
2511 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
2513 * crosstabs.q: (postcalc) Call make_summary_table().
2514 (make_summary_table) New function.
2515 (insert_summary) New function.
2516 (display_dimensions) Remove some unnecessary arguments, all
2518 (output_pivot_table) Fix lots of problems with the risk table
2520 (submit) Don't display an empty table.
2521 (display_risk) Fix order of arguments to calc_risk().
2523 * glob.c: Always include assert.h and stdlib.h.
2525 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
2528 * tab.c: (tab_create) Cosmetic changes.
2530 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
2532 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
2536 * crosstabs.q: (output_pivot_table) Headers drawing and submission
2537 code simplified, moved into new function submit().
2538 (submit) New function.
2539 (crosstabs_dim) New function.
2540 (display_directional) Substitute variable names for %s where
2542 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
2543 (calc_symmetric) Initialize parameters only if non-NULL.
2544 Calculate Somers' d.
2545 (calc_directional) Calculate Somers' d (or copy it, really).
2548 * output.c: (outp_string_width) New function.
2550 * postscript.c: (postopen) Calculate font widths based on the
2551 width of the zero '0' character, not the width of the space
2552 character. Set paper-width and paper-length based on points, not
2554 (ps_open_page) Fix page setup string for landscape mode.
2556 * som.h: (struct som_dimension) Removed.
2557 (struct som_table_class) height, width members take int * not
2560 * tab.c: Many functions now have added parameter validation.
2561 (tab_height, tab_width) These functions were removed and merged
2562 into a single function tab_resize(), and all references changed.
2563 (tab_dim) Rewritten since the interface changed; reduced from
2564 hundreds of lines to two. All callers were changed. Currently
2565 most of them just use tab_natural_dimensions as their callback and
2566 await detailed translation of functionality.
2567 (tab_natural_width) New function.
2568 (tab_natural_height) New function.
2569 (tab_natural_dimensions) New function. This is a callback
2570 function, not something that you'd want to call directly.
2571 (tab_nat_dim) Removed.
2572 (tabi_table) Allocates t->w and t->h.
2573 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
2574 dimensions callback.
2575 (evaluate_dimensions) Removed.
2576 (sum_columns) Removed.
2578 * tab.h: (enum TAL_1THIN) Removed.
2579 (enum series t_*) Removed.
2580 (struct tab_table) Members trh, trv changed to unsigned char *
2581 from int *. Member dim changed to a function pointer from a
2582 unsigned char *. Member max_stack_height removed. New members
2584 (macros tab_l, tab_r, tab_t, tab_b) New.
2586 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
2588 * ascii.c: (delineate) Assign last_space_nchars before skipping
2589 spaces, to fix right justification.
2591 * crosstabs.q: (static vars risk, direct) New vars.
2592 (static var pearson_r) Removed.
2593 (glob var chisq_fisher) Made static.
2594 (static vars row_tot[], col_tot[]) Don't include grand total
2596 (static var grand_total) Renamed W, all references changed.
2597 (output_pivot_table) Only make `table' if num_cells != 0. Make
2598 risk and directional tables. Deal with grand total no longer part
2599 of col_tot[]. Free rows and cols after we're done with them.
2600 (display_risk) New function.
2601 (display_directional) New function.
2602 (clac_r) Rewritten so that it stores all its results into its
2603 arguments, so it can be used for Spearman's correlation too.
2604 (calc_symmetric) Added a t[] argument, all references changed.
2605 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
2606 Pearson's r, Cohen's kappa.
2607 (calc_risk) New function.
2608 (calc_directional) New function.
2610 * som.c: (som_submit) Improved debugging code.
2612 * stats.c: (hypercube) New function.
2613 (cube) New function.
2615 (normal_sig) Went back to old implementation, which actually
2618 * stats.h: (macros square, cube, hypercube) Removed. The
2619 equivalent functions in stats.c are inlined here; all references
2620 to square changed to sqr.
2622 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
2624 * crosstabs.q: (N_SYMMETRIC) New define.
2625 (postcalc) Disable debug printing.
2626 (static vars chisq_fisher, pearson_r) New.
2627 (output_pivot_table) Add support for symmetric measures. Add
2628 chi-square output of exact sigs.
2629 (display_chisq) Rewritten.
2630 (display_symmetric) New function.
2631 (gamma_int) New function.
2633 (swap) New function.
2634 (calc_fisher) New function.
2635 (calc_chisq) Check boundary conditions better. Calculate Yates,
2636 Fisher, Mantel-Haenszel tests.
2637 (calc_r) New function.
2638 (calc_symmetric) New function.
2640 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
2642 (chisq_sig) Better boundary conditions. Renamed from
2645 * tab.h: (struct tab_table) New member cf.
2647 * tab.c: (tab_create) Set cf.
2648 (tab_width) New function.
2649 (tab_realloc) Handle cf.
2650 (tab_vline) Handle cf.
2651 (tab_hline) Handle cf.
2652 (tab_box) Handle cf.
2653 (tab_value) Handle cf.
2654 (tab_float) Handle cf.
2655 (tab_text) Handle cf.
2656 (tab_joint_text) Handle cf.
2657 (tab_offset) Handle cf.
2658 (tab_next_row) Handle cf.
2659 (evaluate_dimensions) Handle cf.
2660 (render_strip) Handle cf.
2662 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
2664 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
2665 output_pivot_table().
2666 (output_pivot_table) Moved lots of local variables outside and
2667 made them static. Add beginnings of chi-square statistic
2668 support. Now column and row totals aren't in the main matrix.
2669 Always zero out any leftover rows & columns after we're done with
2670 the table entries. Move all output stuff into
2671 display_dimensions(), display_crosstabs(), display_chisq().
2672 (display_dimensions) New function.
2673 (display_crosstabulation) New function.
2674 (display_chisq) New function.
2675 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
2677 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
2678 references, simplify logic.
2680 * postscript.c: Remove scale, translate-x, translate-y,
2681 mirror-horz, mirror-vert, rotate-180 options.
2682 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
2683 All references deleted.
2684 (macro YT) New macro.
2685 (array option_tab[]) Removed options.
2686 (ps_option) Removed options.
2687 (ps_open_page) Write page setup explicitly to output file, without
2688 using now-deleted BP function.
2689 (macro dump_line) Use YT().
2690 (macro dump_thick_line) Use YT().
2691 (draw_headers) Use YT().
2692 (switch_font) Reorder arguments to SF function.
2693 (write_text) Use YT().
2695 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
2698 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
2700 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
2701 null-debugging code.
2702 (tab_realloc) Remove null-debugging code. Initialize new regions
2704 (tab_vline) Support offsets.
2705 (tab_hline) Support offsets.
2706 (tab_box) Support offsets.
2708 (tab_nulls) Removed.
2711 (evaluate_dimensions) Remove null-debugging code. Understand
2712 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
2713 TAB_EMPTY not present.
2715 * tab.h: New cell attribute TAB_EMPTY.
2716 (macros tab_nr, tab_nc, tab_row, tab_col) New.
2718 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
2719 try to read them from system files.
2721 * vfm.c: (dump_splits) Don't call tab_null().
2723 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
2725 * crosstabs.q: (struct crosstab) Added `missing' member.
2726 (custom_tables) Init missing.
2727 (calc_general) Handle missing values.
2728 (calc_chisq) New function.
2729 (output_pivot_table) Start work on chi-square output. Update for
2730 new tab offset support functions. Shorten statistic names.
2732 * Several files: add in more `const's to placate gcc's warnings.
2734 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
2737 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
2738 tab_null, tab_nulls, tab_value, tab_float, tab_text,
2739 tab_joint_text) Add col_ofs and row_ofs support.
2740 (tab_offset) New function.
2741 (tab_next_row) New function.
2742 (tab_row) New function.
2743 (tab_col) New function.
2744 (tabi_table) Add col_ofs and row_ofs support.
2746 * vars-atr.c: (is_system_missing) New function.
2748 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
2750 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
2751 (static var no_cells) Removed.
2752 (static var num_cells) New.
2753 (static var expected) New.
2754 (static var cells[]) New.
2755 (internal_cmd_crosstabs) Deal with new variables.
2756 (postcalc) Removed most of the meat and put it in new function
2757 output_pivot_table().
2758 (output_pivot_table) Calculates and outputs an entire pivot table.
2760 * postscript.c: (postopen) Fix problems with free()ing addresses
2761 not obtained from malloc().
2763 * som.c: (som_submit) Add assertion.
2765 * sysfile-info.c: (describe_variable) Use new tab_nulls()
2768 * tab.c: (static var tab_names[]) New.
2769 (tab_realloc) -1 for nc or nr indicates no change.
2770 (tab_nulls) New function.
2771 (tab_dim) Use tab_names[].
2772 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
2773 (evaluate_dimensions) Don't terminate on uninited cells, just put
2774 an X in them and emit a notice. Use tab_names[].
2776 * tab.h: Move bits into tab.def.
2778 * tab.def: New. Don't try to declare tab_table_class because then
2779 som.h has to be included.
2781 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
2783 * command.def: New file, contains all the command definitions
2784 previously included bodily in command.c.
2786 * format.def: New file, contains all of the format definitions
2787 previously split across format.h, format.c, and sfm-write.c.
2789 * lexer.h: Renamed from tokens.h in order to match corresponding
2792 * lexerP.h: Moved some rarely used functions exported by lexer.c
2795 * Makefile.am: Commemorate renamed files.
2796 (EXTRA_DIST) Add command.def, format.def.
2798 * command.c: [0] (walk_cmdtable_func) Removed.
2800 * crosstabs.q: (postcalc) Made it work and print out matrices
2802 (enum_column_values) Renamed enum_var_values, generalized for any
2805 * format.h: (struct fmt_desc) New member `spss'.
2807 * q2c.c: (main) Generated code includes lexer.h instead of
2810 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
2811 instead of an independent translation table.
2813 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
2815 * Lots of source files: Added const to declarations.
2817 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
2819 * arena.c: (arena_clear) Set prev pointer to null when done.
2821 * ascii.c: (ascii_option) Rename index as indx.
2823 * avl.c: This is now a separate library called libavl.
2824 (xmalloc) Make static.
2825 (avl_probe) Step A7 can use the cache instead of an explicit
2827 (avl_delete) Don't maintain a q pointer because it's always
2828 available in the pointer stack. Comment fix.
2830 * avl.h: This is now a separate library called libavl.
2832 * command.c: (cmd_table[]) Remove spurious trailing "".
2834 * common.h: Only include random() fix if this system needs it.
2836 * crosstabs.q: Include alloca headers.
2837 (n_sorted_tab) New global var.
2838 (postcalc) Mostly rewritten.
2839 (find_pivot_extent) Rewritten.
2840 (enum_column_values) Rewritten.
2842 * data-out.c: (convert_F) Rename inner n as n_spaces.
2844 * error.c: (dump_message) Don't have an outer var i.
2846 * file-handle.q: (static var f) Removed. All references removed.
2847 (internal_cmd_file_handle) Uses a local variable instead of f.
2849 * get.c: (trim_dictionary) Change scope of i, i1, i2.
2850 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
2853 * getline.h: Declare getl_history as extern. Reported by
2854 palme@uni-wuppertal.de (Hubert Palme).
2856 * postscript.c: (postopen) Some large mods for constness.
2858 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
2861 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
2863 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
2864 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
2867 * avl.c, avl.h: New files. These form a clean-room
2868 reimplementation of avllib. Iterative algorithms are used in
2869 place of recursive ones, so there is no resemblance in the code.
2871 * Lots of headers: Don't include other headers by default.
2873 * Lots of source files: Explicitly include all needed headers.
2875 * arena.c: (arena_clear) New function.
2877 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
2878 (static var ar) Removed.
2879 (staitc vars ar_tc, ar_col) New.
2880 (cmd_crosstabs) Destroy the arenas.
2881 (internal_cmd_crosstabs) Create the arenas.
2882 (precalc) Don't need a free function for the hash.
2883 (calc_general) Make sure to zero out the trailer on the key data
2885 (print_table_entries) Updated.
2886 (postcalc) Worked on actually implementing.
2887 (find_pivot_extent) New function.
2888 (compare_value) New function.
2889 (enum_column_values) New function.
2891 * data-in.c: (parse_month) Make local array `static const'.
2893 * data-out.c: (convert_date) Make local array `static const'.
2894 (convert_WKDAY) Same.
2895 (convert_MONTH) Same.
2897 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
2898 been renamed to avl_walk().
2900 * hash.c: Rewritten more efficiently.
2902 * hash.h: Add attribute const to hsh_next_prime declaration.
2904 * lexer.c: (id_match) Make arguments const.
2906 * postscript.c: (ps_postopen_driver) Make default fonts the
2909 * q2c.c: (main) Generated code needs stdlib.h.
2911 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
2912 initialized to 0 now, not to NULL. All other references to
2913 avl_traverser were updated in the same way.
2915 * tokens.h: Macro version of id_match updated to use const
2918 * val-labs.c: (inc_ref_count) New function.
2919 (copy_value_labels) Simply through use of new avl_copy() function.
2921 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
2923 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
2924 (postcalc) Worked on this.
2926 * postscript.c: (OPO_DOUBLE_LINE) New enum.
2927 (struct ps_driver_ext) New line_width_thick member.
2928 (ps_preopen_drive) Init line_width_thick.
2929 (option_tab[]) Add line-* options.
2930 (ps_option) Parse line-* options.
2931 (postopen) Add line_width_thick support. Strip leading spaces on
2932 prologue output lines.
2933 (ps_open_page) Include line_width_thick in output.
2934 (macro dump_thick_line) New.
2935 (dump_fancy_line) Support thick lines as well as double lines.
2937 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
2939 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
2940 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
2942 * Many source files: Rename `options' to `pv_opts' as appropriate.
2944 * command.c: (static var cmd_table[]) Add CROSSTABS command.
2946 * common.c: (xcalloc) New function.
2948 * crosstabs.q: New file. Not finished yet, though.
2950 * data-list.c: Comment fix.
2952 * error.c: Remove some old Checker cruft.
2954 * frequencies.q: (dump_full) Cumulate valid percent instead of
2957 * getline.c: Comment fix.
2959 * hash.c: Comment fixes.
2961 * hash.h: (struct hsh_table) Make hash functions return unsigned
2962 instead of int to avoid problems with taking the modulo of
2963 negative return values. All references changed.
2965 * misc.c: (intlog10) Make its table static const instead of auto.
2967 * sfm-read.c: (read_header) Make `prefix' static const instead of
2970 * var.h: (union value) Add member `hash'.
2971 (struct variable) Rename prv_index as `foo'--all references
2973 (typedef pv_opts) Removed. All references changed.
2975 * vars-prs.c: (parse_variables) Message fixes.
2977 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
2979 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
2980 they are being inserted. Don't check for BY variables of
2981 different types. Discard variables if the active file isn't
2982 included in the merge.
2983 (mtf_processing) Essentially rewritten.
2984 (mtf_merge_dictionary) Check for master/slave variables of
2985 different types/widths.
2987 * vfm.c: (static var not_canceled) New var.
2988 (process_active_file) Don't call vfm_source->read() if
2989 there's no vfm-source. Initialize not_canceled.
2990 (process_active_file_write_case) Honor and update not_canceled.
2991 (prepare_for_writing) Rollback changes from yesterday, they were
2993 (close_active_file) Don't destroy vfm_source unless it exists.
2995 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
2997 * Lots of source files: Added { } around nested if/else constructs
2998 to avoid new gcc 2.8 warnings.
3000 * data-in.c: (parse_Z) Declare `int' type explicitly.
3003 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
3004 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
3005 prev members. Put TABLEs at the end of the chain and FILEs at the
3006 beginning. Don't allow the active file in STATE_INIT. Use proper
3007 `seen' value for the active file. Fill out the by members and
3008 make sure they're of consistent type. Do the actual merge
3010 (mtf_processing_finish) New function.
3011 (var_type_description) New function.
3012 (mtf_free_file) New function.
3013 (mtf_free) Rewritten.
3014 (mtf_delete_file_in_place) New function.
3015 (mtf_read_nonactive_records) New function.
3016 (mtf_compare_BY_values) New function.
3017 (static var mtf_seq_no) New var.
3018 (mtf_processing) New function.
3019 (mtf_merge_dictionary) Assign nval members for the system file
3020 dictionary. Assign fv values for its variables. Point each slave
3021 variable to the corresponding master variable.
3023 * hash.c: Include str.h.
3025 * mis-val.c: (copy_missing_values) src arg is const.
3027 * misc.c: (spacing) Make `max' var explicitly int.
3029 * sfm-read.c: (dump_dictionary) Message reformatting.
3030 (sfm_read_case) Add assertion.
3032 * sort.c: Esthetic fixes.
3034 * var.h: (struct match_files_proc) New struct.
3035 (struct variable) Add private data match_files_proc.
3037 * vars-atr.c: (delete_variable) Implement. Add argument for the
3038 dictionary that owning the variable.
3039 (dup_variable) Add assertion.
3041 * vfm.c: Comment fixes, hopefully the comments are correct now.
3042 (process_active_file) New function.
3043 (process_active_file_write_case) New function.
3044 (process_active_file_output_case) New function.
3045 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
3047 (write_case) Renamed procedure_write_case(). Now write_case is a
3048 pointer to a function. Style fixes.
3050 1998-03-05 Ben Pfaff <blp@gnu.org>
3052 * Makefile.am: (q2c) Link with libmisc.
3053 (version.c) Define default_config_path, include_path,
3056 * ascii.c: (ascii_postopen_driver) When the default newline string
3057 is requested, open file in text mode. Suggested by
3058 palme@uni-wuppertal.de (Hubert Palme).
3059 (static vars line_buf, line_p) Change from char * to unsigned char
3061 (ascii_close_page) char * to unsigned char *.
3063 * cmdline.c: (parse_command_line) Implement -r option by
3064 prepending ~/.pspp/rc to the list of files to process.
3066 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
3067 before pulling in a final line.
3068 (null_func, null_int_func) Removed (dead code).
3070 * descript.q: (display) Calculate width of variable name column
3071 properly. Calculate number of valid cases properly. Reported by
3072 palme@uni-wuppertal.de (Hubert Palme).
3074 * filename.c: (init_filename) Use default_config_path instead of
3075 now obsolete CONFIG_PATH.
3077 * getline.c: (getl_initialize) Use include_path instead of now
3078 obsolete INCLUDE_PATH.
3079 (getl_add_file) New argument `where'. All references changed.
3081 * groff.c: (find_font_file) Use groff_font_path instead of now
3082 obsolete GROFF_FONT_PATH.
3084 * postscript.c: (find_ps_file) Use groff_font_path instead of now
3085 obsolete GROFF_FONT_PATH. Copy through temporary variable to
3086 avoid problems with constness.
3088 * str.h: (macro cs_streq) New macro.
3090 * version.h: (glob var default_config_path, include_path,
3091 groff_font_path) New vars.
3093 1998-02-23 Ben Pfaff <blp@gnu.org>
3095 * Many source files: Change verbose_msg() priority levels and
3098 * aggregate.c: Include debug-print.h.
3100 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
3102 (static var pre_syntax_message) Document --safer/-s and
3105 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
3107 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
3108 because it's not used but it's still copied.
3109 (open_file_r) Remove gratuitous debug message.
3111 * filename.c: (safety_violation) New function.
3112 (open_file) Remove gratuitous debug messages. Don't allow pipe
3113 files if set_safer is set.
3115 * get.c: Turn off debugging.
3117 * getline.c: (getl_add_virtual_file) New function.
3118 (getl_read_line) Add verbose_msg() call for opening new syntax
3120 (getl_perform_delayed_reset) Add a return value describing whether
3121 any action was taken. Call reset_eof().
3123 * getline.h: Comment fix.
3125 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
3126 place of incorrect `continue'. Use strtok_r() instead of
3127 strtok(). Always check strtok_r() return value.
3128 (groff_read_DESC) Use strtok_r() instead of strtok().
3130 * lexer.c: (reset_eof) New function.
3132 * main.c: (parse) Get a token after performing a delayed reset
3133 action; allow empty syntax files.
3135 * postscript.c: (output_encodings) Use strtok_r() instead of
3138 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
3140 * set.q: Comment fixes.
3141 (glob var set_safer) New var.
3142 (internal_cmd_set) Support SAFER.
3144 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
3146 * temporary.c: (free_dictionary) Set d->splits to NULL after
3149 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
3150 variable deleted, not if it *isn't* deleted.
3152 1998-02-16 Ben Pfaff <blp@gnu.org>
3154 * command.c: (array cmd_table[]) Add MATCH FILES.
3156 * common.c: Comment fixes.
3158 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
3159 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
3160 Include alloca.h. Problem reported by palme@uni-wuppertal.de
3163 * expr-opt.c: Include str.h. Problem reported by
3164 palme@uni-wuppertal.de (Hubert Palme).
3166 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
3167 (static var mtf_by) Change from char ** to variable **.
3168 (static var mtf_master) New var.
3169 (mtf_merge_dictionary) New function.
3170 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
3171 var type. Reorder tests properly. Initialize file->dict. Detect
3172 TABLE= without BY=. Read file dictionaries and merge them. Give
3173 subcommand name with IN, LAST, FIRST error messages. Create IN,
3174 LAST, FIRST variables. Comment fixes.
3175 (mtf_free) Don't free default_dict. Free mtf_master.
3177 * getline.c: Define getl_mode. Change getl_buf_size to size_t
3179 (handle_line_buffer) Cast int to size_t in comparison to avoid
3182 * getline.h: Declare getl_mode extern.
3184 * groff-font.c: (groff_read_font) Type-fix calls to getline.
3185 (groff_read_DESC) Make line_size a size_t.
3186 (match_tok) Parenthesize name to avoid macro expansion.
3188 * mis-val.c: (copy_missing_values) New function.
3190 * postscript.c: (postopen) Make buf_size a size_t.
3192 * sfm-read.c: (dump_dictionary) Make global from static. Print
3193 variable info in parts for easier debugging with Checker.
3195 * temporary.c: (copy_variable) Use copy_value_labels().
3196 (new_dictionary) New arg: whether to copy file label, documents.
3198 * val-labs.c: (copy_value_labels) New function.
3200 * var.h: (enums MISSING_*) Add MISSING_COUNT.
3202 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
3204 (dup_variable) Set prv_index, get.fv, get.nv.
3206 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
3208 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
3210 * Many source files: For ANSI-compliance, add empty statement
3211 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
3212 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3214 * data-in.c: (parse_numeric) Some header files break on
3215 -DBL_MIN_10_EXP because they get a --; add () for safety.
3216 Reported by palme@uni-wuppertal.de (Hubert Palme).
3218 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
3219 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
3220 (dfm_close) Use close_file_ext.
3221 (open_inline_file) Set file.file to NULL, not file.
3222 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
3223 struct and use open_file_ext().
3224 (read_record) Use file.file.
3226 * file-handle.q: (prepend_current_directory) Pass through special
3229 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
3230 (normalize_filename) Pass through special filenames.
3231 (open_file, close_file) Accept pipe| and |pipe syntaxes as
3233 (dirname) Rename blp_dirname() because of name conflict on some
3234 OS. All references changed. Reported by palme@uni-wuppertal.de
3236 (is_special_filename) New function.
3238 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
3239 (trim_dictionary) Conditionalize some of the options on whether
3240 GTSV_OPT_MATCH_FILES is in *options.
3241 (rename_variables) Don't allow variables to be renamed as scratch
3243 (MTF_*) New enum series.
3244 (struct mtf_file) New struct.
3245 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
3247 (cmd_match_files, mtf_free) New functions.
3249 * lexer.c: (match_int) Needed parentheses around name to escape
3250 macro expansion. Reported by Micah Altman
3251 <maltman@www-vdc.fas.harvard.edu>.
3253 * print.c: Needed to include alloca.h. Reported by Micah Altman
3254 <maltman@www-vdc.fas.harvard.edu>.
3256 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
3257 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
3260 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
3261 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3263 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
3265 * html.c: (struct html_driver_ext) Move into htmlP.h.
3266 (html_preopen_driver) Initialize cp_x, cp_y.
3267 (html_submit) Implement as call to output_tab_table().
3268 (change_attributes) New function.
3269 (escape_string) New function.
3270 (output_tab_table) New function.
3272 * list.q: (write_all_headers) Add code for writing headers for the
3274 (clean_up) Write out the html close-table tag.
3275 (determine_layout) Ignore html driver.
3276 (list_cases) Write html data.
3278 * som.c: (som_submit) Move more of the code into output_table().
3280 * tab.c: (static var hit) Make a global var and rename tab_hit.
3281 (static var tab_table_class) Make a global var.
3283 * htmlP.h: New file.
3285 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
3287 * dump-sysfile.c: Removed.
3289 * html.c: (preclose) Change comment in emitted code.
3291 * matrix-data.c: Debugging off by default. Comment fixes.
3292 (static var container) New var.
3293 (cmd_matrix_data) Create and destroy container. Initialize
3294 is_per_factor[] to 0s. Move code into new function
3295 string_to_content_type(). Require split values to be present in
3296 the data when ROWTYPE_ is explicit. Call specific function, not
3297 general read_matrices().
3298 (string_to_content_type) New function.
3299 (context) Exclude all whitespace, not just spaces.
3300 (mget_token) A dot is a number. Add assertion.
3301 (static var data) Renamed nr_data.
3302 (static var factor_values) Renamed nr_factor_values.
3303 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
3304 only specific case. Close data_file before exit.
3305 (fill_matrix) New function.
3306 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
3307 printing. Style fixes. Message fixes. Move code into
3309 (read_matrices_without_rowtype) Rename
3310 matrix_data_read_without_rowtype(). Fix off-by-one error on
3311 loops. Allocate nr_data[] memory from arena.
3312 (read_matrices_with_rowtype) Removed.
3313 (read_splits) Renamed nr_read_splits(). Style fixes.
3314 (read_factors) Renamed nr_read_factors().
3315 (dump_cell_content) Comment fixes. Arguments changed. Change
3316 debug printing. All references changed.
3317 (output_data) Renamed nr_output_data().
3318 (static var wr_content) New var.
3319 (struct factor_data) New struct.
3320 (static var wr_data) New var.
3321 (static var wr_current) New var.
3322 (matrix_data_source_destroy_source) Removed.
3323 (read_matrices_with_rowtype) New function.
3324 (matrix_data_read_with_rowtype) New function.
3325 (wr_read_splits) New function.
3326 (compare_factors) New function.
3327 (wr_output_data) New function.
3328 (wr_read_rowtype) New function.
3329 (wr_read_factors) New function.
3330 (wr_read_indeps) New function.
3331 (glob var matrix_data_source) Make destroy_source member NULL as
3334 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
3336 * lexer.c: (syntax_error) Give better error message when at end of
3339 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
3340 N_SCALAR to output as plain N.
3341 (mdump_token) Change output format.
3342 (context) Fix message output interaction with spaces in input.
3343 (another_token) New function.
3344 (force_eol) Improved error message.
3345 (static var max_cell_index) New var.
3346 (read_matrices) Init `cells'. factor_values is now per-cell.
3347 Init max_cell_index.
3348 (read_data_lines) Replace `compare' local with new `compare' arg.
3349 Debugging messages changed. Only read factors if per_factor.
3350 Propagate error return from read_factors(), force_eol().
3351 Copy N_SCALAR values across the N vector.
3352 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
3353 check parentheses manually since we now have is_per_factor[].
3354 Call read_data_lines() with new args. Check for end of data after
3355 looping, using another_token().
3356 (read_factors) Arguments changed. Use max_cell_index to determine
3357 whether to read or compare factors. Message fixes.
3358 (dump_cell_content) New function.
3359 (output_data) Completely rewritten because content types were
3360 supported to be nested inside factor values, not vice versa.
3362 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
3364 * lexer.c: (syntax_error) Support formatted varargs messages.
3366 * matrix-data.c: Turn debugging on by default.
3367 (static content_type[]) New array.
3368 (static content_names[]) New array.
3369 (static rowtype_, varname_) New vars.
3370 (static is_per_factor[]) New array.
3371 (static split_values) Moved declaration.
3372 (static n_continuous, first_continuous) New var.
3373 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
3374 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
3375 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
3376 Check for continuous variables.
3377 [DEBUGGING] (debug_print) Remove content_names[].
3378 (mdump_token) New macro.
3379 (mget_token_dump) New function.
3380 (mdump_token) New function.
3381 (context) New function.
3382 (mget_token) Fix messages.
3383 (static var data, split_values, factor_values) New vars.
3384 (read_matrices) Manage split_values, factor_values.
3385 (read_data_lines) New function.
3386 (read_matrices_without_rowtype) Implemented.
3387 (read_splits) Message fixes. Uses `just_read'.
3388 (read_factors) New function.
3389 (output_data) New function.
3390 (matrix_data_source_destroy_source) Close the file handle.
3391 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
3394 * str.c: (strpadcmp) Removed.
3396 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
3398 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
3400 * Lots of source files: Add cast to unsigned character to calls to
3401 tolower() and toupper().
3403 * aggregate.c: Set default_dict.splits to NULL.
3405 * command.c: (static variable tab[]) Add MATRIX DATA.
3407 * data-in.c: Add debugging defines. Formatting fixes.
3409 * expr-opt.c: Formatting fixes.
3411 * lexer.c: (syntax_error) Message fixes.
3413 * matrix-data.c: New enum series.
3414 (static vars fmt, section, diag, explicit_rowtype, signle_split,
3415 split_values, n_factors, factors, cells, pop_n, contents,
3416 n_contents) New vars.
3417 (cmd_matrix_data) Finished implementation.
3418 (compare_variables_by_mxd_vartype) New function.
3419 [DEBUGGING] (debug_print) New function.
3420 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
3421 (read_matrices) New function.
3422 (read_matrices_without_rowtype) New function.
3423 (read_matrices_with_rowtype) New function.
3424 (read_splits) New function.
3425 (mget_token) New function.
3426 (force_eol) New function.
3427 [0] (test_tokenizer) New function.
3428 (matrix_data_source_destroy_source) New function.
3429 (glob var matrix_data_source) New var.
3431 * misc.h: Include ieeefp.h if present.
3433 * split-file.h: (cmd_split_file) Changes corresponding to struct
3436 * str.h: Fix memmem prototype.
3438 * temporary.c: (save_dictionary, restore_dictionary,
3439 free_dictionary) Changes corresponding to struct dictionary
3442 * var.h: (MXD_* enums) New enum series.
3443 (struct matrix_data_proc) New struct.
3444 (struct split) Removed.
3445 (struct dictionary) Changed `splits' member from `split *' to
3447 (macro force_create_variable) New macro. Replaced lots of
3448 create_variable()/assert() calls with calls to this macro.
3450 * vars-atr.c: (discard_variables) Changed assertion.
3451 [GLOBAL_DEBUGGING] (force_create_variable) New function
3452 called by the macro of the same name.
3453 (clear_variable) Changes to delete splits from the dictionary
3454 corresponding to struct dictionary changes.
3456 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
3457 corrupted variable `index' values in the dictionary passed in
3458 every time this function is called.
3460 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
3461 to struct dictionary changes.
3463 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
3465 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
3467 * command.c: New includes.
3468 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
3469 (cmd_erase) New function.
3470 [unix] (shell) New function.
3471 (run_command) New function.
3472 (cmd_host) New function.
3473 (cmd_new_file) New function.
3475 * expr-prs.c: (parse_primary) Message fix.
3477 * inpt-pgm.c: Formatting fix.
3478 (cmd_reread) Implement the FILE subcommand.
3480 * matrix-data.c: New file.
3482 * q2c.c: (dump_header) Change output commenting style.
3484 * weight.c: Comment fix.
3486 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
3488 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
3490 (buf_10x) Renamed buf_1xx, all references changed.
3491 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
3492 cases now implemented).
3493 (create_sysfile) New function.
3494 (agr_11x_func) New function.
3496 * data-in.c: (parse_numeric) Work properly if there's an
3497 explicitly coded decimal point in the data and decimal places are
3498 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
3499 <el@linux.lisse.na>.
3501 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
3502 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
3503 Eberhard W Lisse <el@linux.lisse.na>.
3505 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
3506 strerror.c. Bug reported by Alexandre Oliva
3507 <oliva@dcc.unicamp.br>.
3509 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
3510 (static var separate_case_tab) New var.
3511 (cmd_sort_cases) Cancel temporary transformations here. Free
3512 v_sort before return.
3513 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
3514 we're reading from a sort stream. Don't cancel temporary
3515 transformations. Offload internal sorting to do_internal_sort().
3516 (do_internal_sort) New function. Handles internal sorting even
3517 when SEPARATE is nonzero. Doesn't free v_sort.
3518 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
3520 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
3521 sink if SEPARATE is zero.
3522 (read_output_cases) Renamed read_sort_output(), all references
3523 changed. Now uses separate_case_tab when it exists.
3524 (write_separate) New function.
3526 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
3527 memory_sink_cases. Don't redundantly call
3528 vfm_source->destroy_source().
3529 (memory_stream_mode) After switching over, set memory_sink_cases
3532 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
3534 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
3536 (static var prev_case) New, moved out of aggregate_single_case()
3538 (static var buf64_10x, buf_10x) New.
3539 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
3540 the 000, 001, 100, and 101 cases. Free prev_case.
3541 (parse_aggregate_functions) Disallow scratch variables.
3542 (free_aggregate_functions) Only free agr_dict if non-null. Use
3543 iter->function to determine numeric/string type, not
3545 (aggregate_single_case) Don't manage prev_case. Initialize
3546 aggregate info after dumping it.
3547 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
3548 mean, stddev, weighted stddev definitions.
3549 (dump_aggregate_info) Implemented.
3550 (initialize_aggregate_info) Renamed from
3551 initialize_aggregate_functions(). Initializes dbl[2].
3552 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
3553 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
3555 * cases.c: (alloc_val) Removed.
3557 * get.c: (cmd_save_internal) Initialize new `dict' member.
3559 * sfm-write.c: (sfm_write_dictionary, write_header,
3560 write_variable, write_value_labels, write_documents) Reorganize,
3561 simplify for new parameter structure.
3562 (write_variable) Only one variable * argument now.
3564 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
3565 replaced by new `dict' member.
3567 * temporary.c: (new_dictionary) Initialize n_documents.
3569 * vars-atr.c: (dup_variable) Allocate `value's from dict into
3571 (init_variable, replace_variable) Eliminate usage of alloc_val().
3573 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
3575 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
3576 signal that AGGREGATE is to be used for forming final cases.
3577 (close_active_file) Call end_func before stopping lagging. Cancel
3578 temporary after finishing compaction.
3579 (write_case) Comment fixes. Cleaned up.
3580 (compact_case) Let AGGREGATE handle compaction when `temporary' is
3583 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
3585 * Makefile.am: (BUILT_SOURCES) Add means.c.
3586 (pspp_SOURCES) Add means.c.
3587 (EXTRA_DIST) Add means.q.
3589 * command.c: (array cmd_table[]) Add MEANS.
3591 * common.h: Esthetic fixes. Comment fixes. Test for
3592 MAX_SHORT_STRING greater than 8.
3593 (macros LOWEST, HIGHEST) New.
3595 * data-in.c, data-list.c, recode.c: Comment fixes.
3597 * means.q: New file, base version.
3599 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
3600 with LOWEST, DBL_MAX with HIGHEST.
3602 * q2c.c: (dump_vars) Add an enum to array types giving the number
3603 of values for the enum.
3605 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
3606 Replace second_lowest_value with second_lowest_flt64.
3608 * sfm-write.c: (write_variable, write_rec_7_34) Replace
3609 second_lowest_value with second_lowest_flt64.
3611 * t-test.q: Comment fix.
3613 * temporary.c: (restore_dictionary) Esthetic fix.
3615 * tokens.h: (force_match_id, force_match, force_string, force_int,
3616 force_num, force_id) Replace msg() with syntax_error().
3618 * var.h: (struct means_proc) New.
3619 (struct variable) Add mns member to `p' union.
3621 * vars-prs.c: (parse_variable, parse_dict_variable,
3622 parse_variables, parse_DATA_LIST_vars) Replace msg() with
3625 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
3627 * Makefile.am: (pspp_SOURCES) Add tab.h.
3629 * Most source files: Added a cast to unsigned char in usages of
3630 the ctype is*() functions. Replaced `end of command expected'
3631 calls to msg() with calls to syntax_error().
3633 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
3635 * lexer.c: (hex_val) Removed (was dead code).
3636 (idmatch) Parenthesize function name to avoid macro expansion.
3638 * postscript.c: Comment fixes.
3639 (ps_preopen_driver) Change default font size to 10pt.
3641 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
3643 (parse_format_spec) Change system-file format spec argument type
3644 to int32. Parse the format spec with bitwise operators.
3646 * sfmP.h: (struct sysfile_format) Removed.
3647 (struct sysfile_variable) Changed print, write members from
3648 sysfile_format to int32.
3650 * tokens.h: Esthetic fixes.
3651 [__GNUC__] (macro id_match) New macro to hopefully speed up
3652 identifier matching.
3653 (macros match_id, match_tok, match_int) Implemented in
3654 compiler-independent manner; no longer GNU C only.
3656 * vfm.h: Include time.h.
3658 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
3660 * data-list.c: (dump_fixed_table) Change tab_dim().
3662 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
3664 * error.c: Include command.h.
3666 * frequencies.g: Formatting fixes.
3668 * frequencies.q: Add tab_dim() calls. Make the total cell a
3671 * glob.c: Include command.h.
3673 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
3675 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
3676 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
3677 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
3678 the other elements (is this right?).
3679 (read_variables) Use lowest, highest members.
3680 (parse_format_spec) New arg `vv' for more stringent checking.
3681 (dump_dictionary) Byteswaps nonexplicit data.
3682 (sfm_read_case) Byteswap numeric data.
3684 * som.c: Initialize table_num to 1.
3685 (render_segments) Remember to increment y_index after each table
3688 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
3689 avl_count() on a NULL tree. No title for the second table.
3690 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
3691 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
3692 fix call to display_variables().
3693 (display_variables) Default to 4 columns, not 3. Set up headers.
3694 Column title is Variable, not Name. Fix index column.
3695 Add joint text. Add tab_dim(). Handle value labels properly.
3696 Handle DISPLAY LABELS properly. Draw boxes correctly.
3697 (describe_variable) Value labels don't need titles. Don't clear
3698 nonexistent index column.
3699 (compare_vectors_by_name) New function.
3700 (display_vectors) New function.
3702 * tab.c: (tab_height) Add assertion.
3703 (tab_null) Add debug code.
3704 (evaluate_dimensions) Add debug code.
3706 * var.h: (struct variable) get_proc data is sometimes used
3707 simultaneously with other per-procedure info, therefore it was
3708 removed from the union. All references changed.
3710 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
3712 * ascii.c: (ascii_close_page) Put title on second line of headers
3713 if there is no subtitle.
3715 * command.c: (glob var cur_proc) Move definition here, from
3717 (cmd_remark) Emit blank line before remarks.
3719 * command.h: (glob var cur_proc) Move declaration here, from
3722 * data-list.c: (dump_fixed_table) Fix messages.
3723 (dump_free_table) Call tab_nat_dim().
3725 * descript.q: (dump_z_table) Modify tab_dim() call.
3727 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
3729 (dump_statistics) Don't output header.
3731 * groff-font.c: Minor format fix.
3733 * html.c: Comment fix.
3735 * list.q: (write_varname) Indent after advancing page.
3737 * output.h: Minor reordering.
3739 * postscript.c: Comment fixes. Many places, '\n' was replaced by
3740 a reference to eol[].
3741 (struct ps_driver_ext) New member eol[].
3742 (ps_preopen_driver) Initialize eol[].
3743 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
3744 defaults. Handle headers. Fix test for minimum page length.
3745 (static var option_tab[]) Add `line-ends'.
3746 (ps_option) Handle line-ends to change eol[].
3747 (postopen) Scale prop_em_width and fixed_width properly. Set the
3748 prologue title to outp_title if applicable. Replace the prologue
3749 line ends with eol[]. Call draw_headers() if headers are enabled.
3750 (text_width) New function.
3751 (out_text_plain) New function.
3752 (draw_headers) New function.
3754 * print.c: (dump_table) Call tab_nat_dim().
3756 * som.c: (som_blank_line) Only advance a line if not at the top of
3758 (som_submit) Move several informational table calls here.
3759 Increment subtable_num if SOMF_NO_TITLE not set.
3760 (output_table) Advance a line if SOMF_NO_SPACING not set.
3761 (render_columns, render_segments, render_simple) Handle spacing
3762 between tables. Handle table titles. Remove debug output.
3764 * som.h: (SOMF_*) New enum series.
3765 (struct som_table_class) New member `flags'.
3767 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
3769 (display_variables) Calls tab_nat_dim().
3770 (describe_variable) Remove restriction on number of value labels.
3771 Make value labels separated by thin lines.
3773 * tab.c: (tab_create) Default `flags' to none.
3774 (tab_float) New arg `w'. All references changed.
3775 (tab_nat_dim) New function.
3776 (tab_output_text) No title or spacing.
3777 (tab_flags) New function.
3778 (tabi_flags) New function.
3779 (tabi_title) New function.
3780 (strip_height) Removed.
3781 (tabi_render) Skip title when necessary.
3782 (static var tab_tab_class) Add tabi_flags, tabi_title.
3783 (evaluate_dimensions) Disable display of column, row size.
3784 (sum_columns) Add title height to top header.
3785 (render_strip) Moved within file.
3787 * tab.h: (struct tab_table) New member `flags'.
3789 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
3791 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
3793 * Most source files: Add `const' attribute in all appropriate
3796 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
3797 column to the variables table for use by describe_variable().
3798 (cmd_display) Disable for the present.
3799 (display_documents) Don't wrap documents.
3800 (display_variables) Table has four columns now.
3801 (describe_variable) Table has four columns now. Don't use a
3802 subtable, use joined cells instead.
3804 * tab.c: (tab_create) Don't set `join'.
3805 (tab_realloc) ct array is not made up of a_string's.
3806 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
3807 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
3808 (text_format) New function.
3809 (tab_title) Rewritten, uses text_format().
3810 (tab_text) Rewritten, uses text_format().
3811 (tab_joint_text) New function.
3813 (static var hit) New variable.
3814 (render_strip) New args r1, r2. Implement joined cells that fit
3816 (tabi_render) Increment hit. Pass new args to render_strip().
3817 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
3818 cells. For t_naw and t_nah, ignore joined cells and null cells in
3821 * tab.h: (struct tab_join_rect) Removed.
3822 (struct tab_table) Removed `join'.
3823 (TAB_JOIN_MAIN) Removed.
3824 (struct tab_joined_cell) New struct.
3825 (TAT_NOWRAP) New enum.
3827 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
3829 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
3831 (ascii_postopen_driver) Fix initialization of *_spacing so that
3832 the TAL_0 bit doesn't count.
3834 * data-list.c: (dump_fixed_table) Use natural width for Format
3837 * glob.c: (rerange) Removed.
3838 (get_date) Formatting fixes. Internationalization fix.
3840 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
3843 * postscript.c: (ps_postopen_driver) Replace
3844 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
3846 * som.c: (som_submit) Don't eject page before every table.
3847 (output_table) Fix order of arguments on call to area().
3848 (render_columns) Fix calculation of max_len.
3850 * tab.c: (tabi_cumulate) Minor change to increase elegance.
3851 (render_strip) New function.
3852 (strip_height) New function.
3853 (tabi_render) Rewrite as calls to render_strip().
3855 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
3856 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
3857 with the TAB_* and OUTP_T_* constants.
3859 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
3861 * Makefile.am: Formatting fixes.
3863 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
3866 * data-list.c: (dump_fixed_table) Add tab_dim() call.
3868 * descript.q: (dump_z_table, display) Add tab_dim() calls.
3870 * dump-sysfile.c: (glob var length) Make type off_t.
3871 (usage) Fix arguments.
3874 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
3875 Now right-justification is the default so many references had to
3877 (struct outp_class) Removed line_width, all references changed.
3878 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
3879 (struct outp_driver) Add elements horiz_line_width,
3880 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
3883 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
3885 (postopen) Initialize all the informational members of
3888 * som.c: (som_blank_line) New function, renamed from blank_line(),
3889 all references changed.
3890 (som_submit) Disables drivers whose pages can't be opened.
3891 (render_columns, render_simple, render_segments) Add debug output.
3892 (render_columns) Fix loop range.
3893 (render_simple) Don't try to render the headers, they're taken
3894 care of automatically. Advance cp_y past the table when done.
3895 (render_segments) Fix loop ranges.
3897 * tab.c: Initialize new members of tab_table.
3898 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
3899 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
3900 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
3903 (tab_dim) New function.
3904 (tab_col_width) Removed.
3905 (tab_row_height) Removed.
3906 (tab_output_text) Call tab_dim().
3907 (tabi_driver) Call evaluate_dimensions(), sum_columns().
3908 (tabi_area) Implemented.
3909 (tabi_cumulate) Implemented.
3910 (tabi_render) Partially implemented, but broken.
3911 (var tab_table_class) Made static.
3912 (evaluate_dimensions) New function.
3913 (sum_columns) New function.
3915 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
3916 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
3917 t_scr, t_srr, t_sentinel. Removed: t_nat.
3918 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
3919 max_stack_height, w, h. Removed: ce, re.
3920 (macro blank_line) Removed.
3921 (glob var zero_length) Removed.
3923 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
3925 * Most source files: include some of the new include files broken
3928 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
3931 * aggregate.c: (glob var outfile) Make static.
3933 * command.c: (glob var pgm_state) Move here.
3935 * common.c: (glob vars endian, second_lowest_value, pgmname,
3936 finished, curdate, cur_proc, start_interactive, history_file) Move
3939 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
3941 * file-handle.q: (glob vars files, inline_file) Move here.
3943 * glob.c: Lost lots of glob vars, detailed in individual file
3945 (init_glob) set_printer, set_screen were obsolete, deleted.
3946 set_cprompt has fewer spaces because pspp has fewer letters than
3949 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
3950 (inp_nval) Made static.
3952 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
3953 tokstr_len, toklongstr, tokint) Move here.
3955 * misc.c: Lost several vars and functions.
3957 * set.q: (all the set_* variables) Move here.
3959 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
3960 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
3963 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
3965 * tab.h: (enum series t_*) New enums.
3966 (struct tab_table) Use arena struct tag. New members ce, re.
3968 * tokens.h: Comment fixes.
3970 * var.h: Move lots of enums and variables and functions and
3971 structures to other files. Use and declare a lot more union and
3972 struct tags. Comment fixes.
3974 * vector.c: (glob vars vec, nvec) Move here.
3976 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
3977 init_blanks, last_vfm_invocation) Move here.
3979 * cases.h: New file.
3980 (struct long_vec) Move here.
3981 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
3984 * command.h: New file.
3985 (STATE_* enums) Move here.
3986 (glob var pgm_state) Move here.
3988 * format.c: New file.
3989 (glob var formats) Move here.
3990 (parse_format_specifier_name, fmt_to_string,
3991 check_input_specifier, check_output_specifier,
3992 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
3995 * format.h: New file. Move functions now in format.c here.
3996 (FMT_* enums) Move here.
3997 (struct fmt_desc) Move here.
3998 (FCAT_* enums) Move here.
3999 (struct fmt_spec) Move here.
4000 (glob vars formats, fmt_parse_ignore_error) Move here.
4002 * inpt-pgm.h: New file.
4003 (INP_* enums) Move here, make #defines into enums.
4004 (glob vars inp_init, inp_init_size) Move here.
4007 (glob vars v_sort, nv_sort) Move here.
4008 (sort_cases, read_sort_output) Move here.
4010 * vector.h: New file.
4011 (struct vector) Move here, add struct tag.
4012 (glob vars vec, nvec) Move here.
4013 (find_vector) Move here.
4016 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
4017 reinit_blanks, init_zero, init_blanks) Move here.
4018 (struct case_stream) Move here.
4019 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
4020 vfm_disk_stream, sort_stream, data_list_source,
4021 input_program_source, file_type_source, get_source, n_lag) Move
4023 (procedure, write_case, lagged_case, compact_case, page_to_disk)
4026 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
4028 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
4029 (LDADD) Add libdcdflib.
4031 * ascii.c: Comment and formatting fixes. Almost every external
4032 function had an assert added, checking driver_open and page_open.
4033 (ascii_init_driver) Broken into ascii_preopen_driver,
4034 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
4035 (ascii_open_page) Sets page_open.
4036 (ascii_close_page) Clears page_open.
4038 * html.c: Comment and formatting fixes. Almost every external
4039 function had an assert added, checking driver_open and page_open.
4040 (html_init_driver) Broken into html_preopen_driver,
4041 html_postopen_driver, html_close_driver. Manages driver_open.
4042 (html_open_page) Sets page_open.
4043 (html_close_page) Clears page_open.
4044 (html_submit) Disabled.
4046 * lexer.c: (parse_string) Remove debugging printf.
4048 * list.q: (determine_layout) Open a page if one is not yet open.
4050 * output.c: Comment fixes.
4051 (add_class) Set the class member of the new list element.
4052 (parse_options) Don't handle device type.
4053 (colon_tokenize) New function.
4054 (configure_driver) New four-field format with a field for device
4055 type. Now initialize driver_open, page_open, next, and prev
4056 fields. Use new colon_tokenize() function. Don't do a memory
4057 copy to replace a driver, it doesn't work; instead delete the old
4058 driver and insert a new one.
4059 (destroy_driver) Don't call som_destroy_driver(). Close the page
4060 if it's open. Find the class in the list of classes and decrement
4061 that reference count. Remove the driver from the global driver
4063 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
4064 references changed. Rewritten. Don't return a driver that's not
4066 (outp_eject_page) All references to som_internal_eject_page()
4067 changed to use this. Sets cp_x to 0 as well as cp_y.
4069 * output.h: (OUTP_I_* enums) Removed.
4070 (struct som_submission_form) Removed.
4071 (struct outp_class) init_driver broken into preopen_driver,
4072 postopen_driver, and close_driver. submit changed to take a
4075 * postscript.c: Comment and formatting fixes. Almost every
4076 external function had an assert added, checking driver_open and
4078 (ps_init_driver) Broken into ps_preopen_driver,
4079 ps_postopen_driver, ps_close_driver. Manages driver_open.
4080 (ps_open_page) Sets page_open.
4081 (ps_close_page) Clears page_open.
4083 * som.c: New file, base implementation.
4085 * som.h: (struct som_table) Add struct tag.
4086 (enum SOM_COL_ACROSS) Removed.
4087 (SOM_ROWS, SOM_COLUMNS) New enums.
4088 (struct som_table_class) Add member `cumulate'. Remove `segment';
4089 change `render' arguments.
4090 (struct som_point, struct som_rect) Removed.
4091 (som_submit_table) Fixed typo, should have been som_submit.
4093 * sysfile-info: (describe_variable) Don't try to insert a
4094 subtable; just destroy it for now.
4096 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
4097 references to value labels.
4099 * tab.c: (tab_destroy) New function.
4100 (tab_columns) Change argument.
4101 [0] (tab_submit) Remove dead code.
4102 (tab_title) Allocate string from the table's arena.
4103 (tab_output_text) Only free the buffer if we allocated it.
4104 (tab_submit) New function.
4105 (static vars t, d) New static vars.
4106 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
4107 tabi_headers, tabi_cumulate, tabi_render) New functions.
4108 (glob var tab_table_class) New global var.
4110 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
4111 encapsulate the rectangle. All references changed.
4113 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
4115 * All header files updated to use struct tags in addition to
4116 typedefs for all structures. Don't use word `struct' in struct
4119 * Makefile.am: (pspp_SOURCES) Remove html.c.
4120 (INCLUDES) Replace the lib/* includes with a single lib/ include;
4121 all references updated.
4123 * command.c: (parse_cmd) Remove call to som_check_workspace.
4124 (output_line) Update to new som.
4126 * data-in.c: (parse_numeric) A single dot is not an error; it is
4127 the system-missing value.
4129 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
4132 * data-out.c: Added `const' as appropriate to many prototypes.
4133 (convert_E, convert_F, convert_CCx) Take double argument instead
4134 of value * argument.
4135 (convert_format_to_string) Call changed functions appropriately.
4136 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
4137 make a local copy of the value.
4139 * descript.q: Remove custom_variables() prototype now provided by
4141 (custom_variables) Don't increment sbc_variables, the caller does
4143 (dump_z_table, display) Update to new som.
4145 * error.c: (vmsg) Add const to prototype. Remove code to handle
4146 `too many errors' condition.
4147 (check_error_count) New function.
4148 (msg) Add const to prototype.
4150 * filename.c: (open_file) Rewrite for elegance.
4152 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
4153 (dump_full, dump_condensed, dump_statistics) Update for new som.
4155 * list.q: Don't include somP.h. Change all references to
4156 som_driver_ext to refer to the new members of som_driver. Change
4157 som_internal_eject_page() references to outp_eject_page().
4159 * main.c: (parse) Rewrite for elegance. Add call to
4160 check_error_count().
4162 * output.c: (add_class, outp_list_classes, outp_configure_driver)
4163 Rewrite or revise for new outp_driver_class_list structure.
4164 (outp_iterate_enabled_drivers) Fix comparison between disabled
4165 devices and current device type.
4166 (outp_eject_page) New function.
4168 * output.h: Comment fixes.
4169 (struct outp_driver) New members driver_open, page_open, cp_x,
4170 cp_y, font_height, prop_em_width, fixed_width. Deleted members
4172 (struct outp_driver_class_list) New struct.
4173 (outp_class_list) Changed to type outp_driver_class_list; all
4176 * print.c: (dump_table, print_trns_proc) Updated for new som.
4178 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
4179 prototypes for custom subcommands.
4180 (dump_subcommand) Always include the `else'.
4181 (dump_parser) Fix comments in output code.
4183 * set.q: Reordered functions.
4185 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
4187 * som.h: Rewritten from scratch.
4189 * str.h: Remove dead code.
4191 * tab.c, tab.h: New files, base implementation.
4193 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
4196 * t-test.q: New code from John Williams
4197 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
4198 Many many new static vars and defines.
4199 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
4200 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
4201 (struct value_list) New struct.
4202 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
4203 t_crt, t_sig, print_t_groups) New functions.
4204 (cmd_t_test) Implemented.
4206 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
4209 * vfm.c: (dump_splits) Update to new som.
4211 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
4213 * Makefile.am: (fiasco_SOURCES) Add html.c.
4215 * aggregate.c: Base source.
4217 * ascii.c: (postopen, preclose) Reformat.
4219 * data-out.c, expr-evl.c: Comment fixes.
4221 * filename.c: (open_file) When opening a file for writing, use
4222 line buffering instead of full buffering for better interactive
4223 performance. Suggested by Valerio Aimale
4224 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
4225 names `stdin', `stdout', `stderr'.
4227 * groff-font.c: Comment fixes.
4229 * html.c: New file; base version.
4231 * list.q: (write_all_headers, clean_up, determine_layout,
4232 list_cases) Ignore `special' devices for now. Needs to be fixed
4235 * output.c: (outp_init) Add html driver to list; reverse list
4238 * output.h: (struct outp_class_struct) New members `special',
4239 `submit'; comment fixes. All references changed.
4241 * postscript.c: (ps_init_driver) Make defaults for text_opt,
4242 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
4244 (postopen) Comment fix.
4245 (preclose) Comment fixes, formatting fixes. Change x->file.file
4246 references to more proper f->file.
4248 * som-high.c: (som_submit_table) Special classes use their own
4251 * som.h: Comment fixes.
4253 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
4256 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
4258 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
4260 * aggregate.c: Still working on this.
4262 * command.c: (cmd_table[]) Add AGGREGATE back in.
4263 (split_words) Make '-' a legal word separator as well as ' '.
4265 * main.c: Comment fixes.
4267 * q2c.c: (dump_parser) Don't require the procedure's full name to
4268 be present, in the generated source.
4270 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
4271 multiply specified and let it be default; let MISSING, CRITERIA,
4272 FORMAT be multiply specified.
4273 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
4274 (custom_groups) Fix defaults.
4275 (custom_pairs) Check whether this is a PAIRS subcommand before
4276 attempting to parse. Better garbage collection. Proper storage
4278 [DEBUGGING] (debug_print) New function.
4280 * temporary.c: Comment fixes.
4281 (copy_variable) Don't copy variable name and index.
4282 (save_dictionary) Copy variable name and index by hand.
4284 * vars-atr.c: Comment fixes.
4285 (create_variable) New dictionary argument. All references
4287 (common_init_stuff) New dictionary argument. All references
4289 (init_variable) New dictionary argument. All references changed.
4290 (dup_variable) New function.
4292 * vars-prs.c: (parse_variables) If there are any errors, we always
4293 return 0. Previously, it was possible for some types of errors to
4296 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
4298 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
4301 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
4303 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
4306 * q2c.c: Comment fixes.
4307 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
4309 * t-test.q: (cmd_list) Rename cmd_t_test.
4311 * temporary.c: (new_dictionary) Don't declare as static.
4313 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
4315 * aggregate.c: Changes, still not finished.
4317 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
4319 * q2c.c: Comment fixes. Now its output is internationalized.
4320 (get_token) Fix parsing of escapes within literal strings.
4321 (main) Fix bad #line directives in output.
4323 * t-test.q: Base implementation.
4325 * temporary.c: (new_dictionary) New function.
4326 (restore_dictionary) [__CHECKER__] Change fill character to *
4329 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
4331 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
4333 * aggregate.c: Changes, still not finished.
4335 * descript.q, list.q: Comment fixes.
4337 * q2c.c: Almost completely rewritten.
4339 * t-test.q: New file, not complete.
4341 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
4343 * aggregate.c: Changes, still not finished.
4345 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
4348 * temporary.c: (cancel_temporary) New function.
4350 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
4351 of doing it by hand.
4353 * vfm.c: (close_active_file) After restoring a TEMPORARY
4354 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
4356 (SPLIT_FILE_procfunc) Comment fix.
4358 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
4360 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
4362 * aggregate.c: New file, not finished yet.
4364 * command.c: (cmd_table) Add AGGREGATE.
4366 * common.h: (pgm_state) Move declaration to var.h.
4368 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
4370 (parse_string) Message fix.
4372 * recode.c: Comment fix.
4374 * sfm-read.c: (read_variables) Code esthetic fixes.
4375 (write_header) Default date is `Jan', not `JAN'.
4377 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
4379 * sort.c: (cmd_sort_cases) Farm the work out to new function
4380 parse_sort_variables().
4381 (parse_sort_variables) New function.
4382 (sort_cases) New function. Cancels temporary transformations,
4383 which sorting didn't do previously.
4384 (cmd_sort_cases) Better garbage collection on error. Uses
4386 (write_initial_runs, merge_once) Improved code esthetics.
4387 (sort_stream_read) Reduced to one call to read_output_cases().
4388 (read_output_cases) New function.
4390 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
4391 variable labels to 120 characters.
4393 * var.h: Comment fixes.
4394 (glob var pgm_state) From common.h.
4396 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
4398 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
4399 options. Set *names to NULL on error.
4401 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
4403 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
4405 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
4406 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
4408 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
4410 * vfm.c: (page_to_disk) Added missing local variables.
4412 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
4414 * get.c: Comment fix.
4416 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
4417 source is anything other than a disk stream, not just if it's in a
4418 memory stream. Call page_to_disk() before external sort.
4419 (allocate_cases) Message fix.
4421 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
4423 (page_to_disk) New function.
4425 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
4427 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
4429 * common.h: (macro strerror) Remove. From Alexandre Oliva
4430 <oliva@dcc.unicamp.br>.
4432 * get.c: (dict_delete_run) The number of variables to delete is
4433 not necessarily the number of variables that need to be shifted
4435 (trim_dictionary) Don't set *options to 0. Fix bug that caused
4436 too many variables to be deleted.
4438 * postscript.c: Comment fix.
4440 * q2c.c: Include strerror.c. From Alexandre Oliva
4441 <oliva@dcc.unicamp.br>.
4443 * set.q: #undef ON and OFF. From Alexandre Oliva
4444 <oliva@dcc.unicamp.br>.
4446 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
4447 early, otherwise errors cause a bad free().
4449 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
4450 Oliva <oliva@dcc.unicamp.br>.
4452 * temporary.c: (save_dictionary) Don't allocate memory if
4455 * vfm.c: (memory_stream_write) Message fix.
4457 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
4459 * command.c: (static var cmd_table[]) Define REPEATING DATA
4462 * common.h: Added support for broken systems that are missing
4463 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
4465 * Many source files: Replace syntax error messages via msg() with
4466 call to syntax_error().
4468 * data-list.c: (dump_fixed_table) Add support for dumping table
4469 for REPEATING DATA as well as DATA LIST FIXED.
4470 (cmd_repeating_data) Allows and requires `/' between subcommands.
4471 Does proper thing with allowing rpd.starts_end to stay 0. Allows
4472 CONTINUED specifications to be omitted. Forces CONTINUED to be
4473 specified if ID is. Calculates starts_end, cont_end from logical
4474 record length as reported by fhp. Calls dump_fixed_table() if
4475 requested. Fixed length of record copied by memcpy.
4476 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
4478 (realize_value) Returns sensible value for out-of-range variable
4480 (rpd_parse_record) New argument `ofs'. Fixed confusion between
4481 length of occurrences and length of line. Added warning for
4482 fields that exceed the line length. Fixed infinite loop.
4483 (read_one_set_of_repetitions) Numerous minor changes for more
4484 complete SPSS compliance. Message fixes.
4486 * dfm.c: (dfm_close) If the file being closed is the inline file,
4487 read all the remaining data before closing it.
4488 (dfm_get_record) Don't close the file on lossage, as either it
4489 has been closed already or it doesn't belong to us.
4491 * error.c: (puts_stdout) New function.
4492 (vmsg) Use puts_stdout instead of puts.
4494 * file-handle.q: (fh_record_width) New function.
4496 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
4499 (input_program_source_read) Made an old kluge an approved method.
4501 * lexer.c: (syntax_error) New function.
4503 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
4506 * output.c: (oupt_get_paper_size) Message fix.
4508 * q2c.c: Numerous fixes to formatting of generated code made to
4509 conform to GNU coding standards. Uses syntax_error() in generated
4510 code. Other miscellaneous generated message fixes. Added support
4511 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
4512 RAND_MAX, and/or strerror().
4514 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
4516 * data-in.c: Comment fixes.
4518 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
4519 (find_variable_input_spec) New function.
4520 (cmd_repeating_data) Initializes id_spec.
4521 (rpd_parse_record) Implemented.
4522 (read_one_set_of_repetitions) Returns -3 by default in order to
4523 kluge out some potential bugs.
4525 * data-out.c: Comment fixes.
4527 * file-type.c: (internal_cmd_record_type) Message fix.
4529 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
4530 for handling -3 return value.
4532 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
4534 * data-list.c: Comment fixes.
4535 (struct dls_var_spec) Reordered members.
4536 (read_from_data_list_fixed) Restructured.
4537 (struct repeating_data_trns) Reordered members. Renamed `starts'
4538 as `starts_beg', `ends' as `starts_end'.
4539 (cmd_repeating_data) Calculates length of repeated data if
4540 necessary and possible.
4541 (parse_num_or_var) Don't allow string variables.
4542 (realize_value) New function.
4543 (rpd_msg) New function.
4544 (rpd_parse_record) New function. Currently stubbed out.
4545 (read_one_set_of_repetitions) Implemented.
4547 * inpt-pgm.c: (input_program_source_read) Comment fix.
4549 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
4551 * command.c: (cmd_end_repeat_p) Removed.
4552 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
4553 (parse_cmd_name) Removed.
4555 * data-list.c: Comment fixes.
4556 (data_list_pgm) Removed `eof' member.
4557 (static var first) New var.
4558 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
4559 FILE TYPE file inside FILE TYPE structures.
4560 (append_var_spec) Appends to *first, not dls.spec.
4561 (parse_fixed) Message fixes.
4562 (struct rpd_num_or_var) New.
4563 (struct repeating_data_trns) New.
4564 (static var rpd) New.
4565 (cmd_repeating_data) New function.
4566 (parse_num_or_var) New function.
4567 (parse_repeating_data) New function.
4568 (read_one_set_of_repetitions) New function.
4570 * file-type.c: (cmd_file_type) Message fixes. Always
4571 default_handle to FILE TYPE file handle.
4572 (internal_cmd_record_type) Message fixes.
4574 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
4576 * repeat.c: Comment fix. Disable debugging.
4578 * temporary.c: (restore_dictionary) Sets splits to NULL and
4579 n_splits to 0 before destroying the variables because now doing
4580 this tries to remove split variables.
4582 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
4583 destroying the dictionary.
4584 (clear_variable) Removes a variable from splits after destroying
4587 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
4589 * cmdline.c: (set_compat) Removed.
4590 (pick_compat) Removed.
4591 (parse_command_line) Removed -c option.
4592 (pre_syntax_message) Removed -c option.
4593 (usage) Remove compatibility code.
4595 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
4596 (glob var compat) Removed.
4598 * compute.c: (type_check) Fixed messages about type mismatches.
4600 * data-list.c: (cmd_data_list) Removed compatibility code.
4601 (fixed_parse_compatible) Calls convert_negative_to_dash().
4602 Fixed bug where it only set the variable in fx.spec if it created
4603 the variable itself.
4604 (dump_fmt_list) Spelling fix.
4605 (cut_field) Removed compatibility code.
4607 * dfm.c: (cmd_begin_data) Don't require a command terminator on
4610 * expr-evl.c: (evaluate_expression) Implement LAG.
4612 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
4613 (parse_neg) Calls convert_negative_to_dash().
4614 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
4617 * expr.h: (struct expression_struct) Removed member max_lag.
4619 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
4620 (internal_cmd_record_type) Removed special handling to produce
4621 negative numbers from dash tokens.
4623 * getline.c: (static var DO_REPEAT_level) New var.
4624 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
4625 (handle_line_buffer) Copies the line into getl_buf; doesn't call
4626 copy_with_DO_REPEAT_substitutions().
4627 (getl_read_line) Maintains value of getl_mode. Calls
4628 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
4630 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
4632 * getline.h: (getl_mode) New glob var.
4634 * glob.c: Comment fixes.
4635 (init_glob) Restructured. Sets set_seed.
4636 (init_compat_dependent) Removed. All references removed.
4637 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
4638 (__htonl, __htons) Removed. (What were these for?)
4640 * lexer.c: (static var tbl) Dash set to class CNUM.
4641 (make_hexit) New function from data-out.c.
4642 (get_token_representation) Rewritten.
4643 (convert_negative_to_dash) New function.
4644 (lex_init_compat_dependent) Removed.
4645 (yylex) A dash is parsed as part of a number if it is followed by
4646 a digit. The ASCII representation of a number is copied to
4647 tokstr. String parsing farmed out to parse_string(). Comment
4649 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
4651 (preprocess_line) Line processing depends on interactive/batch
4652 mode, not on compatibility mode. Removed PC+ compatibility code.
4654 * loop.c: (loop_3_trns_proc) Comment fix.
4656 * main.c: Remove dead code.
4657 (main) Remove call to init_compat_dependent().
4659 * misc.c: (convert_fmt_ItoO) Make E format conversion more
4662 * print.c: (parse_string_argument) Calls
4663 convert_negative_to_dash().
4664 (fixed_parse_compatible) Calls convert_negative_to_dash().
4666 * repeat.c: (RPT_* defines) Removed.
4667 (struct rpt_numeric) Removed.
4668 (struct repeat_entry) New member type, changed `replacement' from
4670 (clean_up) Deallocation adapted to new repeat_entry.
4671 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
4672 usage. Creates vars for `type' of 1.
4673 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
4674 (store_numeric) Rewritten, new interface.
4675 (parse_numbers) Rewritten.
4676 (parse_strings) Rewritten.
4677 (find_DO_REPEAT_substitution) New function.
4678 (perform_DO_REPEAT_substitutions) New function.
4679 (copy_with_DO_REPEAT_substitutions) Removed.
4680 (debug_print) Rewritten.
4682 * set.q: Comment fix.
4683 (custom_results) Removed compatibility code.
4684 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
4687 * sysfile-info.c: (cmd_display) Removed compatibility code.
4689 * tokens.h: Comment fixes.
4690 (token types enum) Removed `toktype' typedef name for this int
4691 type. Removed SUBST. Restructured.
4693 * vars-atr.c: (discard_variables) Sets n_lag to 0.
4695 * vars-prs.c: Comment fix.
4697 * vfm.c: Comment fixes.
4698 (glob var n_lag) New var.
4699 (static vars lag_count, lag_head, lag_queue) New vars.
4700 (procedure) Removed argument nlag.
4701 (setup_lag) New function.
4702 (close_active_file) Discards lagging state.
4703 (lag_case) New function.
4704 (lagged_case) New function.
4705 (write_case) Lags a case if lagging.
4707 * weight.c: (cmd_weight) Removed compatibility code.
4709 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
4711 * getline.h: (struct getl_script) New members loop_index, macros.
4713 * getline.c: (getl_add_file) Sets first_line field to NULL.
4714 (getl_add_DO_REPEAT_file) New function.
4715 (handle_line_buffer) When the current line's length is negative,
4716 set the filename and line number. Increment line number after
4717 reading line. Pass the line to
4718 copy_with_DO_REPEAT_substitutions() for processing.
4719 (getl_close_file) Free DO REPEAT lines before freeing the
4720 filename, and just set the filename to NULL when doing this,
4721 because otherwise the filename gets freed twice.
4723 * glob.c: (glob var queuing) Removed. All references removed.
4725 * lexer.c: Comment fixes.
4726 (get_token_representation) New function.
4728 * repeat.c: Comment fixes.
4729 (struct repeat_entry) Replaced type and v union members with a
4731 (append_record) New function.
4732 (internal_cmd_do_repeat) Started reforming it for the new
4733 repeat_entry struct. Properly records filename changes in the
4734 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
4735 strncasecmp() result usage. Uses append_record() to simplify.
4736 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
4739 (copy_with_DO_REPEAT_substitutions) Started coding.
4741 [DEBUGGING] (debug_print_lines) New function.
4743 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
4745 * tokens.h: (macro is_id1, is_idn) New macros.
4747 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
4749 * cmdline.c: (static var pre_syntax_message) Changed `win'
4750 compatibility mode to `wnd'.
4752 * data-list.c: (fixed_parse_spss) Renamed
4753 fixed_parse_compatible().
4755 * glob.c: (init_glob) Excise unused code for
4756 program_invocation_short_name.
4758 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
4761 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
4763 * set.q: `win' compatibility renamed `wnd'.
4765 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
4767 * filename.c: [__WIN32__] Change the included Windows header files
4769 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
4770 second character is absolute.
4771 (dirname) Fix logic error. Don't printf() the results.
4772 (prepend_dir) Don't printf() the results.
4774 * getline.c: (handle_line_buffer) New function.
4775 (getl_read_line) Reads line with handle_line_buffer() when
4777 (getl_close_file) Discard line buffer data.
4779 * getline.h: Comment fixes.
4780 (struct getl_line_list) New struct.
4781 (getl_script_struct) Added line buffer members. These are hooks
4782 for use by DO REPEAT to allow it to insert virtual source code
4785 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
4786 Override Borland C++ stupidity that claims Windows has a console
4789 * repeat.c: This is in the process of being restructured from
4790 using a token-buffering approach to the DO REPEAT facility to
4791 using the more flexible approach of a line-buffering approach in
4792 conjunction with the getline module. Comment fixes.
4793 (struct tok_struct) Removed.
4794 (static vars queue_index, queue_head, queue) Removed.
4795 (static vars line_buf_head, line_buf_tail) New vars.
4796 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
4798 (pull_queue, destroy_queue) Removed.
4799 [DEBUGGING] (debug_print_tokens) Removed.
4801 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
4803 * file-handle.q: (prepend_current_directory) New function.
4804 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
4805 current directory before normalizing filename.
4807 * filename.c: (gnu_getcwd) New function.
4808 (absolute_filename_p) New function.
4809 (search_path) New argument, PREPEND. All references changed to
4810 pass NULL except those explicitly mentioned. Uses
4811 absolute_filename_p(). Prepends PREPEND before trying the
4813 (dirname, prepend_dir) New functions.
4815 * getline.c: (getl_get_current_directory) New function.
4816 (getl_include) Passes getl_get_current_directory() as PREPEND arg
4819 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
4821 * In several source files, the term `script' was replaced with
4822 `syntax file' inside error messages. Usage of the term `script'
4823 in the sense of a syntax file is now deprecated.
4825 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
4828 * dump-sysfile.c: (usage) Update message.
4830 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
4832 * getline.h: (glob var getl_include_path) Declare extern.
4834 * list.q: Define EXTERN as extern before #including somP.h.
4836 * var.h: Remove declaration of `disptype' variable.
4838 * vfm.c: (close_active_file) After switching the data sink to a
4839 data source, set vfm_sink to NULL, because it doesn't exist any
4842 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
4844 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
4845 _matherrl() to ignore all math errors.
4847 * sfm-read.c: (read_value_labels) When reading the labels from
4848 disk, read the little parts separately instead of as a struct;
4849 this avoids alignment problems.
4851 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
4852 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
4853 (write_header) Allocates and initializes elem_type.
4854 (sfm_write_case) Uses elem_type to determine how to handle each
4856 (sfm_close) Frees elem_type.
4858 * sfmP.h: Comment fix.
4859 [__BORLANDC__] Uses #pragma -a to adjust structure member
4862 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
4864 * Makefile.am: (fiasco_SOURCES) Remove display.c.
4866 * common.c: Fix typo.
4868 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
4869 sense of the condition.
4871 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
4872 line-continuation backslash.
4874 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
4876 * frequencies.q: (custom_grouped, add_percentile) Don't use a
4877 non-constant expression as an argument to sizeof.
4879 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
4880 undefine gettext macro because that's a conio function.
4882 * hash.h: (hsh_prime_tab declaration) Remove.
4884 * list.q: (write_fallback_headers) Move `leader' allocation out of
4885 main loop. Change to local_alloc() allocation.
4887 * output.h: Formatting fixes. Put __attribute__ in right place on
4888 function prototypes.
4890 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
4891 incorrect `SECOND_LOWEST_VALUE' references to proper
4892 `second_lowest_value'.
4894 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
4895 value. This way 2 out of 3 of the som files define the vars
4896 extern, the correct way, that actually works under BC++.
4897 (som_set_float) Don't use nonconstant initializers for a struct.
4899 * som-high.c: Add the standard alloca() header.
4900 (replicate_table) Add prototype.
4902 Merged DISPLAY routine.
4903 * sysfile-info.c: (AS_*) New enum series.
4904 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
4906 (cmd_display, display_macros, display_documents,
4907 display_variables) Stolen from defunct display.c.
4908 (describe_variable) New function.
4910 * temporary.c: [0] (display_tree) New debug function.
4911 (copy_variable) Performs shallow copy of value labels instead of
4912 deep copy; i.e., just copys the AVL tree and increments the
4915 * val-labs.c: Comment fixes.
4916 (do_value_labels) Optionally skip leading forward slash.
4917 (get_label) Creates only a single value label instead of many
4918 copies of one, and sets the reference count.
4920 * display.c: Removed.
4922 * dump-sysfile.c: New file, not yet complete.
4924 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
4926 For lots of source files I added more verbose_msg's. These aren't
4927 listed below as they have tested as being benign. In some cases
4928 these replaced debug_printf() calls.
4930 * output.c: (outp_read_devices) Message fix.
4932 * postscript.c: (output_encodings) Message fix. Reports errors on
4934 (postopen) Message fix.
4936 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
4938 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
4940 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
4943 * main.c: Remove <malloc.h> #include.
4945 * mis-val.c: (parse_numeric) Set .f member for each missing[]
4946 instead of trying to just set the missing[] itself, which is a
4949 * sfm-read.c: (read_variables) Same.
4951 * str.h: Add memmem() prototype.
4953 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
4955 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
4957 * Makefile.am: (q2c) Don't include any libraries in the link.
4959 * dfm.c: (force_line_buffer_extension) New macro.
4960 (count_tabs) New function.
4961 (tabs_To_spaces) New function.
4962 (read_record) Calls tabs_to_spaces() on the line being processed.
4964 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
4965 have to be compiled twice (once for CC, once for LOCAL_CC).
4967 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
4969 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
4970 (LDADD) Add @INTLLIBS@.
4971 (q2c) Add LIBS, @INTLLIBS@ to link step.
4973 * inpt-pgm.c: Turn off debugging.
4975 * postscript.c: (postopen) Format fix. local_free() blocks
4976 returned by local_alloc(); don't free() them.
4978 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
4980 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
4983 * data-list.c: (read_from_data_list_fixed) Pass proper value for
4984 LEN arg, not simply the full string length.
4986 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
4987 directories before generic temp file directories.
4989 * vfm.c: Disable debugging.
4991 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
4993 * get.c: Comment fix.
4994 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
4996 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
4998 * expr-prs.c: (debug_print_postfix) Conditionally included on
4999 GLOBAL_DEBUGGING. Removed out_header() reference.
5001 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
5003 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
5005 * ascii.c: Removed obsolete ascii_close_page() prototype.
5007 * command.c: (output_line) Comment fix.
5009 * data-in.c: Formatting fix.
5010 (parse_string_as_format) Now the `fc' argument is used only for
5011 the purpose of error messages; it is not an index into the string
5012 passed. All references changed.
5014 * data-list.c: Comment fix.
5015 (cut_field) Comment fix. Now returns the column number of the
5016 position of the field cut out on success.
5017 (parse_field) Added `column' argument. Puts the column numbers in
5019 (read_from_data_list_free, read_from_data_list_list) Record the
5020 column number returned by cut_field(), pass it to parse_field().
5022 * dfm.c: Comment fix.
5024 * do-ifP.h: Comment fix.
5026 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
5027 the SYSMIS function.
5029 * expr.h, exprP.h: Comment fix.
5031 * glob.c: (init_glob) Only calls setlocale() and family if
5034 * hash.h: Comment fix.
5036 * include.c: Comment fix.
5038 * output.c: Comment fix.
5040 * postscript.c: (ps_line_intersection) Simplified assertion.
5042 * repeat.c: Comment fix.
5044 * vars-atr.c: Comment fix.
5046 * vars-prs.c: Comment fix.
5048 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
5049 behavior with usage of postincrement.
5050 (memory_stream_read) Discards cases as it goes.
5052 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
5054 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
5057 * Most source files: Includes debug-print.h, related comment
5060 * cases.c: (alloc_val) Removed complex allocation code. Merely
5061 increments default_dict.nval and returns the former value.
5062 (envector, devector) Removed references to lv member of struct
5065 * common.h: (macro VME) Replaced complex definition with simple
5068 * data-list.c: (cmd_data_list) Sets vfm_source instead of
5069 read_active_file and cancel_input_pgm.
5070 (read_from_data_list, cancel_data_list) Removed.
5071 (data_list_source_read, data_list_source_destroy_source) New
5073 (glob var data_list_source) New var.
5075 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
5076 (cmd_begin_data) Improved criteria for an input program accessing
5077 the inline file. Still not perfect.
5079 * do-if.c: (do_if_trns_proc) Simplified debug output.
5081 * expr-prs.c: Comment fixes.
5082 [DEBUGGING] (debug_print_postfix) Simplified debug output.
5084 * file-handle.q: (fh_close_handle) Simplified debug output.
5086 * file-type.c: Comment fixes.
5087 (cmd_file_type) Sets vfm_source instead of read_active_file and
5089 (cmd_end_file_type) On failure, discards variables in place of
5090 just canceling the input program.
5091 (read_from_file_type) Renamed file_type_source_read.
5092 (cancel_file_type) Renamed file_type_source_destroy_source.
5093 (glob var file_type_source) New var.
5095 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
5096 (cmd_get) Initializes options to GTSV_NONE before passing to
5097 trim_dictionary(). Removed `lv' reference. Sets vfm_source
5098 instead of read_active_file and cancel_input_pgm.
5099 (cmd_save_internal) Initializes options before passing to
5100 trim_dictionary(). Local var `nval' removed.
5101 (dict_delete_run) Comment fixes.
5102 (trim_dictionary) Comment fixes. Disallows scratch variables if
5103 GTSV_OPT_SAVE set in options.
5104 (read_from_get) Renamed get_source_read.
5105 (cancel_get) Renamed get_source_destroy_source.
5106 (glob var get_source) New var.
5108 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
5109 read_active_file and cancel_input_pgm.
5110 (read_from_input_program) Renamed input_program_source_read.
5111 Simplified debug output.
5112 (cancel_input_program) Renamed
5113 input_program_source_destroy_source.
5114 (glob var input_program_source) New var.
5116 * loop.c: (loop_1_trns_proc) Simplified debug output.
5118 * main.c: (dump_token) Made eof output more explicit.
5120 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
5123 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
5124 code for always-memory or always-disk cases. malloc's case-list
5125 based on vfm_source_info.ncases. Explicit support for
5126 memory_stream via memory_source_cases.
5127 (do_external_sort) Sets vfm_source instead of read_active_file and
5129 (allocate_file_handles) The temporary directory permissions are
5130 set to 0700 instead of 0777.
5131 (allocate_cases) Formatting fixes. Simplified debug output.
5132 (output_record) Compacts the case if necessary before writing it
5134 (close_handle, open_handle_w) Simplified debug output.
5135 (write_initial_runs) Destroys vfm_sink, then sets it to
5136 sort_stream. Writes records to memory based on
5137 vfm_sink_info.case_size.
5138 (write_to_sort_cases) Renamed sort_stream_write().
5139 (merge) Simplified error handling. Simplified debug output.
5141 (read_from_external_sort) Renamed sort_stream_read().
5142 Reads records based on vfm_source_info.case_size.
5143 (sort_stream_write) Writes records to memory based on
5144 vfm_sink_info.case_size.
5145 (sort_stream_mode) New function.
5146 (glob var sort_stream) New variable.
5148 * temporary.c: (cmd_temporary) Simplified debug output.
5149 (copy_variable) Removed references to `lv'.
5151 * title.c: (get_title) Simplified debug output.
5153 * var.h: Comment fixes.
5154 (struct get_proc) Removed member `lv'.
5155 (struct variable) Removed member `lv'. Comment fixes.
5156 (glob vars read_active_file, write_active_file, cancel_input_pgm)
5158 (struct case_stream) New.
5160 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
5161 read_active_file references to use vfm_source.
5162 (init_variable, replace_variable) Removed references to `lv'.
5164 * vfm.c: Comment fixes.
5165 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
5167 (static var queue, qh, qt, n_lag) Removed. All references
5169 (glob var compaction_necessary, compaction_nval, compaction_case,
5170 paging) New variables.
5171 (record_case) Removed.
5172 (procedure) Comment fixes. Calls vfm_source->read() instead of
5175 (prepare_for_writing, arrange_compaction, make_temp_case,
5176 vector_initialization, setup_filter) New function.
5177 (open_active_file) Most of the code moved into the abovementioned
5178 new functions. Now sets temp_dict to &default_dict if there is no
5179 temporary dictionary, for convenience. New debug output.
5180 (close_active_file) Deals with changing the sink to the source.
5181 Calls finish_compaction(). Frees compaction_case. Mostly
5183 (glob vars disk_source_file, disk_sink_file) New vars.
5184 (destroy_active_file, read_from_memory) Removed.
5185 (disk_stream_init, disk_stream_read, disk_stream_write,
5186 disk_stream_mode, disk_stream_destroy_source,
5187 disk_stream_destroy_sink) New functions.
5188 (glob var vfm_disk_stream) New var.
5189 (glob vars memory_source_cases, memory_sink_cases,
5190 memory_sink_iter, memory_sink_max_cases) New vars.
5191 (memory_stream_init, memory_stream_read, memory_stream_write,
5192 memory_stream_mode, memory_stream_destroy_source,
5193 memory_stream_destroy_sink) New functions.
5194 (glob var vfm_memory_stream) New var.
5195 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
5196 named `more_cases'. Simplified debug output. Otherwise mostly
5198 (record_case) Moved into the stream drivers. Removed.
5199 (transform) Removed (was dead code).
5200 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
5201 common case that the splits don't change, we don't need to copy
5202 the case into prev_case again--pointless.
5203 (compact_case) New function.
5204 (finish_compaction) New function.
5206 * vfmP.h: Comment fixes.
5207 (DEV_* enum series) Removed.
5208 (struct storage) Renamed `stream_info'. Removed variant record.
5209 Removed `device' member.
5211 * debug-print.h: New file.
5213 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
5215 * autorecode.c: Turned off debugging.
5217 * data-list.c: (destroy_dls) Closes the associated file handle.
5219 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
5220 parse_variables() options.
5222 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
5224 * display.c: (display_variables) Really fixed null cell bug.
5226 * file-handle.q: (fh_close_handle) Changed debugging message.
5228 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
5229 parse_variables() options.
5231 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
5232 (cmd_list) Fails if no variables specified.
5233 (determine_layout) Writes blank lines manually.
5235 * loop.c: (loop_1_trns_proc) Made debugging code only print
5236 messages if debugging.
5238 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
5239 parse_variables() arguments.
5240 (main) Parses optional parenthesized options to varlist
5241 subcommands into sbc->message.
5243 * sfm-read.c: Format fix.
5245 * var.h: (FV_*) New enum series.
5246 (PV_*) New enum PV_NO_SCRATCH.
5248 * vars-prs.c: (find_var) Removed.
5249 (fill_all_vars) Takes FV_* enum instead of boolean third
5250 argument. Rewritten to deal with scratch as well as system
5252 (parse_variables) Error message on scratch variable if
5255 * vfm.c: (static var virt_begin_func) New var.
5256 (procedure) Sets up virt_begin_func.
5257 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
5258 after dump_splits(). For succeeding groups changes, calls
5259 virt_begin_func() instead of begin_func().
5261 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
5263 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
5266 * dfm.c: Added some debugging messages, disabled by default.
5267 (open_file_r) Fixed error message.
5268 (read_record) On eof on inline_file, instead of calling
5269 fh_close_handle(), simply jump to eof label like a normal file.
5272 * display.c: Thin lines between rows for certain kinds of
5273 listing. Fixed `null cell' bug.
5275 * error.c: (failure) Flush stdout, stderr before failing.
5277 * file-handle.q: (fh_close_handle) Added debugging message.
5279 * frequencies.q: (dump_full) Bottom line extends across entire
5280 table width. Changed title formatting.
5281 (dump_condensed) Changed title formatting.
5282 (dump_statistics) Fixed title formatting.
5284 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
5285 Sets default value of set_format.
5287 * list.q: (cmd_list) Calls blank_line() before determine_layout().
5288 Passes write_all_headers() to procedure() as pre-group func.
5289 (write_all_headers) New function.
5290 (determine_layout) Removed calls to write_header().
5291 Calls blank_line() before and after write_fallback_headers().
5293 * recode.c: (recode_trns_free) Only attempts to free head->map if
5296 * sfm-read.c: (read_variables) Allows `#' at beginning of system
5297 file variable names but gives a warning. Sets `left' based on
5298 first character being/not being `#'. On lossage frees dict->var.
5300 * som-high.c: (som_draw_title) Simplified title formatting.
5302 * vfm.c: (dump_splits) Fixed and changed splits formatting.
5304 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
5306 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
5307 beginning. Frees v_src, v_dest on successful exit. Frees
5308 h_trans[*], h_trans on lossage.
5309 (recode) Frees h_trans[*], h_trans.
5311 * dfm.c: (dfm_close) Formatting change.
5312 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
5313 longer allocates its own in inline_file.
5314 (open_file_r) Passes the local dfm_fhuser_ext to
5316 (open_file_w) Message fix.
5317 (read_record) Buffer reallocation strategy changed. Frees
5318 ext->line even in inline_file to prevent leaks.
5319 (dfm_put_record) Fixed bug where `ext' was cached before the file
5320 was opened and thus it would be NULL when the file really was
5322 (cmd_begin_data) Sets up inline_file basics itself, then calls
5323 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
5325 * list.q: (write_line) Formatting fix.
5326 (clean_up) Minor strategy change. Sets proportional font after
5328 (determine_layout) Sets fixed font before writing regular headers,
5329 or after writing fallback headers.
5331 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
5332 and KEEP vars after using them.
5334 * postscript.c: (ps_init_driver) Frees x->family.
5335 (postopen) When loading fonts, free the temporary font name buffer
5337 (ps_text_set_font_by_position) Free temporary font name buffer
5339 (text) Fixed code that calculated `lig' so that `lig' always gets
5340 initialized. Formatting fix.
5342 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
5344 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
5345 cells, not xmalloc(), so that the cells will get destroyed
5348 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
5351 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
5353 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
5356 * dfm.c: Comment fix.
5358 * list.q: Comment fixes. Include somP.h. Removed static vars
5359 table, n_columns, n_rows, part. New struct list_ext. New static
5361 (n_lines_remaining, n_chars_width, write_line) New functions.
5362 (cmd_list, list_cases) Rewritten.
5363 (begin_row, end_row, flush_table) Removed.
5364 (write_header, clean_up, write_varname, write_fallback_headers,
5365 determine_layout) New functions.
5367 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
5369 * output.h: Comment fix.
5371 * postscript.c: Comment fix.
5372 (struct ps_driver_ext) Removed prop_size, fixed_size members;
5373 added font_size. All references changed.
5374 (ps_init_driver) Initializes font_size. Simplified space checking
5376 (static var option_tab[]) Removed prop-size, fixed-size; added
5378 (ps_option) Handles font_size.
5380 * som-high.c: Moved prototypes into somP.h.
5381 (som_init_driver) New function.
5382 (som_submit_table) Moved some code into new function
5384 (build_target) Moved some code into new function
5385 som_internal_eject_page().
5386 (som_eject_page) Uses som_internal_eject_page().
5387 (som_internal_eject_page) New function.
5389 * som-low.c: Moved prototypes into somP.h.
5391 * som.h: Formatting fixes.
5393 * somP.h: (struct som_driver_ext) Removed em_width;
5394 added prop_em_width, fixed_width.
5396 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
5398 * Makefile.am: Added `localedir' definition. Added
5399 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
5401 * ascii.c: (macro draw_line) Fixed capitalization.
5403 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
5404 compute.c, count.c, data-in.c, data-list.c, data-out.c,
5405 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
5406 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
5407 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
5408 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
5409 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
5410 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
5411 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
5412 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
5413 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
5414 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
5415 for internationlization.
5417 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
5419 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
5421 * do-if.c, sort.c, val-labs.c: Comment fixes.
5423 * glob.c: (init_glob) Uncommented, updated i18n support.
5425 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
5426 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
5427 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
5428 the declarations of macros taking arguments a lot nicer.
5430 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
5432 * error.h: Removed CE, CW aliases for SE, SW.
5434 * q2c.c: Removed explicit streq() definition since it's duplicated
5437 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
5438 stats.h, str.h, tokens.h: Made the declarations of macros taking
5439 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
5442 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
5444 * cmdline.c: Comment fixes.
5445 (pick_compat) Changed return type to int. Now, instead of setting
5446 glob var `compat' to the emulation, returns the emulation. All
5448 (parse_command_line) Added terminating null to end of
5449 `long_options' array definition.
5450 (pre_syntax_message) Fixes.
5451 (usage) Shows the default emulation in the syntax message by
5452 calling pick_compat().
5454 * getline.c: (getl_add_include_dir) Separates paths with
5455 PATH_DELIMITER, not DIR_SEPARATOR.
5457 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
5458 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
5460 * output.c: (outp_configure_macro) Make earlier definitions for a
5461 particular key override later ones for the same key.
5463 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
5465 * ascii.c: Comment fixes.
5467 * output.c: (outp_get_paper_size)
5468 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
5470 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
5472 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
5473 <errno.h>. GNU libc 2 enforces this!
5475 * command.c: (parse_cmd) Fixed problem with `else' clause being
5476 paired with wrong `if'. Comment fix.
5478 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
5480 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
5481 blp_getline() to getline().
5483 * output.c: (outp_eval_dimension) Changed the fix from last time;
5484 there was no variable `a'.
5486 * q2c.c: (get_line) Fixed boundary condition overrun bug.
5488 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
5490 * output.c: (outp_evaluate_dimension) Fixed handling of negative
5491 numbers having fractional parts. Added case of a fraction without
5492 a whole-number part.
5494 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
5496 * ascii.c: (ascii_text_get_font_position) Removed.
5498 * expr.h, exprP.h: Disabled debugging.
5500 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
5503 * output.h: (struct outp_class_struct) Removed
5504 text_get_font_position method. All references deleted.
5506 * postscript.c: Big change here. Fontmaps were completely
5507 eliminated because of a change in philosophy. Comment fixes.
5508 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
5510 (struct ps_driver_ext) `position', `fontmap', `prop_name',
5511 `fixed_name' members removed. New members `prop_family',
5512 `fixed_family'. `family' member changed to type char *.
5513 (static var ps_fontmaps) Removed.
5515 (ps_init_driver) Removed obsolete references, updated.
5516 Initializes `translate_x', `translate_y', `scale'. Doesn't read
5517 fontmap, of course. Refers to font names through internal_name
5518 rather than subversive means. Frees proper items.
5519 (static var option_tab[]) Removed `fontmap-file' option; renamed
5520 `fixed-font', `prop-font'.
5521 (ps_option) Corresponds to option_tab[].
5522 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
5523 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
5524 hash_family) Removed.
5525 (postopen) Generates font names from family names. Gets
5526 PostScript font name properly. New prologue file comment `!!!'
5528 (ps_open_page) Adds translate_x, translate_y to BP prologue
5529 function; gives SF argument floating-point format.
5530 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
5531 font name. Doesn't change font family.
5532 (ps_text_set_font_by_position) Generates Groff font name from font
5533 family name instead of through table lookup.
5534 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
5535 all references changed. Reduced to simple string assignment.
5536 (ps_get_font_name) Removed.
5537 (ps_get_font_family) Reduced to string return.
5538 (text) Doesn't save `position' since it no longer exists. Ugly
5539 kluge to save font family--fix soon?
5540 (load_font) Removed PostScript name argument.
5542 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
5544 * postscript.c: Comment fix.
5545 (ps_open_page) Puts scale factor in PostScript output.
5547 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
5549 * Makefile.am: Distcleans q2c.
5551 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
5553 * ascii.c: (delineate) Sets text size even if width is zero.
5555 * command.c: Comment fix.
5556 (static var cmd_table[]) Re-enabled EVALUATE command.
5557 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
5558 of comments in script files. Now more liberal on criteria for
5559 performing a state transition--if *anything* happened correctly,
5560 not just if *everything* happened correctly.
5562 * data-out.c: (convert_F) Comment fix. Why in the fsck does
5563 Checker segfault on formatting large numbers and why in the fsck
5564 hadn't I noticed this before?
5566 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
5568 * list.q: (cmd_list) Commented out the actual output routine
5569 because of various problems. Probably will abandon the idea of
5570 using the general `crushed tables' for the LIST procedure.
5572 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
5573 clearing it. Allocates a new var_by_name dictionary before trying
5574 to add members to it.
5576 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
5577 `sib'. Changed type of `node' argument.
5578 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
5580 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
5581 [DEBUGGING] Only deletes the variable from var_by_name if that var
5584 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
5586 * Makefile.am: Added include files to SOURCES. Added
5587 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
5588 includes rules for q2c. Added `boast' target.
5590 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
5592 * Makefile.am: Maintainer-clean Makefile.in.
5594 * Makefile.am: Fixed redundant EXTRA_DIST line.
5596 * ascii.c: Comment fixes.
5597 (ascii_line_vert) Fixed overly aggressive range check.
5599 * display.c: Removed dead code.
5601 * list.q: Turn debugging on.
5602 (flush_table) New debug code.
5604 * sfm-read.c: (read_value_labels) malloc's the structure before
5605 trying to assign to its members.
5607 * sfm-write.c: Comment fix.
5609 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
5611 (output_table) No arguments anymore--gets them through `som'
5612 global. New debug code. In crushed tables, now sets `htv' as
5613 well as `hv' to avoid bad confusion later.
5614 (dump_crush_page) New debug code.
5616 * som-low.c: (som_dump_crush_page) New debug code.
5618 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
5620 All source files: Broke long lines into multiple lines.
5622 * ascii.c: (ascii_close_page) Uses host_system var in place of
5623 HOST_SYSTEM constant.
5625 * cmdline.c: (var syntax_message[]) Broke into
5626 pre_syntax_message[] and post_syntax_message[].
5627 (usage) Outputs both parts, separated by driver list.
5629 * error.h: Fixed broken formatting.
5631 * expr-opt.c: (str_search, str_rsearch) New functions.
5633 * misc.c: (blp_getdelim) Removed. All references changed to
5635 (str_search, str_rsearch) Removed.
5636 (memrmem) New function.
5638 * misc.h: (blp_getline) Removed. All reference changed to
5643 * filename.c: Includes "stat.h", not <sys/stat.h>.
5644 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
5646 * output.c: (outp_list_classes) Changed output formatting.
5648 * sfm-write.c: (write_header) Uses host_system var instead of
5649 HOST_SYSTEM constant.
5650 (write_rec_7_34) Extracts version numbers from the version string.
5653 * sort.c: Includes "stat.h", not <sys/stat.h>.
5655 * str.c: (strcasecmp) Removed.
5657 * title.c: (cmd_document) Uses host_system var instead of
5658 HOST_SYSTEM constant.
5660 * version.c: Generated on-the-fly by the Makefile instead of being
5663 * str.h: Comment fixes. Doesn't substitute for missing memmove or
5665 [!HAVE_STRNCASECMP] Declares strncasecmp().
5667 * version.h: Removed stray character. Comment fixes.
5668 (vars host_system, build_system) New vars.
5670 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
5672 * Most source files: Changed formatting of copyright notice; fixed
5673 FSF address; reformatted to better conform to GNU standards;
5674 comment fixes. Added markups to prevent GNU indent from messing
5675 up my beautiful formatting :-).
5677 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
5678 that GNU indent markups can be passed through without problems.
5680 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
5682 * get.c: Turned off debugging.
5684 * glob.c: (init_glob) Turned on save-file compression by default.
5686 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
5687 compression than was possible in save files.
5689 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
5691 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
5693 * frequencies.q: Removed Fiasco extensions. Updated calculation
5694 algorithms. Polished output format.
5695 (struct frq_info_struct) Removed members `max_degree', `min_n',
5696 all references removed.
5697 (macro frq_extensions) Removed.
5698 (static vars min_n, max_degree) Removed, all references removed.
5699 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
5700 calculate `min_n', `max_degree'.
5701 (postcalc) Passes new arg to dump_statistics().
5702 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
5704 (dump_condensed) Adds variable name title.
5705 (sum_freqs) Removed.
5706 (calc_stats) Updated calculation algorithm.
5707 (dump_statistics) Removed warning for too-few observations.
5708 Changed table formatting. Adds variable name title if passed new
5711 * output.h: Comment fix.
5713 * recode.c, sample.c, sort.c: Disabled debug code.
5715 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
5716 Improved debug code.
5718 * var.h: (enum series frq_*) Removed Fiasco extensions.
5720 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
5722 * command.c: Added PROCESS IF to command table.
5724 * Lots & lots of places, removed checks for NULLs preceding calls
5725 to free_expression(), which itself checks.
5727 * descript.q: Removed Fiasco extensions. Removed optimizations
5728 for non-weighted active files. Implemented some options.
5729 Finished polishing output format. Comment fixes. Merged
5731 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
5732 max_degree, min_n) Removed.
5733 (macro dsc_extensions) Removed.
5734 (struct dsc_info_struct) Removed `min_n' member, all references
5736 (internal_cmd_descriptives) Removed calculation of min_n,
5737 max_degree. Only deals with one `calc' routine instead of two
5739 (precalc) Eliminated redundancy. Updated for changes to
5740 descriptives_proc structure.
5741 (calc) Moved here from `descript.g'. Rewritten to calculate
5742 statistics via `moments about the mean' rather than by summing,
5743 summing squares, summing cubes, and so on.
5744 (postcalc) Rewritten for new-style statistical calculation.
5745 (display) Removed support for displaying variables across rows.
5746 No longer crushes the descriptives table. Removed ancient code.
5747 Added display of N, by variable and listwise.
5749 * descript.g: Removed; merged into `descript.q'.
5751 * expr-evl.c: (evaluate_expression) Now returns a double. For
5752 numeric results, it returns the result as well as storing it in
5753 the passed `value' structure if non-NULL. For string results it
5754 just returns 0.0 and it must be passed non-NULL. Many references
5755 to this function were optimized by use of this change, especially
5756 but not exclusively in `compute.c'.
5758 * frequencies.g: Comment fix.
5760 * glob.c: (glob var process_if_expr) New global var.
5762 * postscript.c: (static var option_tab[]) Corrected entry for
5764 (postopen) Sets x->size to x->prop_size.
5765 (ps_text_set_font_by_name) Sets font size as well as typeface for
5766 PROP and FIXED fonts.
5768 * sel-if.c: (cmd_process_if) New function.
5770 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
5771 (sfm_write_dictionary) Sets `n_cases' to 0.
5772 (sfm_write_case) Increments `n_cases'.
5773 (sfm_close) Attempts to seek the system file back to the header
5774 and write the number of cases in its proper slot.
5776 * som-frnt.c: (som_insert_table) Masks off expansion options since
5777 only SOPT_X_NORM seems to work sensibly.
5779 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
5780 with a `fixed' value of 2.
5782 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
5784 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
5785 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
5787 * var.h: (enum series dsc_*) Removed Fiasco extensions.
5788 (struct descriptives_proc) Removed `miss_noweight'; new members
5789 `X_bar', `M2', `M3', `M4', `min', `max'.
5791 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
5793 * vfm.c: (close_active_file) Cancels PROCESS IF.
5794 (write_case) Doesn't process cases unselected by PROCESS IF.
5796 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
5798 * glob.c: (glob var err) Removed.
5800 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
5801 doesn't have to take into account number of value labels since
5802 they're in a subtable anyway. Also, doesn't display more than 10
5803 value labels since we can't yet break pages in subtables.
5805 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
5807 * som-frnt.c: (som_change_table_size) Simple change for elegance
5808 that shouldn't change behavior.
5809 (som_set_value) Comment fix.
5811 * som-high.c: (som_submit_table) Message fix.
5813 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
5815 * command.c: Added SYSFILE INFO to command table.
5817 * file-handle.q: (fh_handle_filename) New function.
5819 * get.c: (save_trns_proc) Fixed a bug in padding of output data
5822 * main.c: (parse) New return value for command functions, -3.
5824 * misc.h: Comment fix.
5826 * output.h: Comment fixes.
5827 (macro COMPONENTS) Removed.
5829 * postscript.c: (write_text) Modified literal_chars[] so that `('
5830 and ')' are not written to the output in strings as literals.
5832 * sfm-read.c: (sfm_read_dictionary) New argument.
5833 (read_header) New argument. Sets the information structure's
5834 values from the header information.
5835 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
5836 bizarre Checker problem, I guess.
5837 (read_variables) Proper cleanup on lossage.
5839 * sfm.h: (struct sfm_read_info) New struct for use by
5840 sfm_read_dictionary().
5842 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
5843 currently used just for tables that can be dynamically resized and
5844 thus have to be allocated with arena_malloc() instead of
5845 arena_alloc(). All references changed.
5846 (som_change_table_size) New function.
5847 (som_insert_table) Bugfix: now inserts `cell', not `c'!
5849 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
5850 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
5853 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
5855 (draw_intersection) Now takes an argument specifying the table in
5856 question. All references changed.
5857 (draw_table_cell) New function.
5858 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
5859 (som_get_table_size) Many nice new explanatory comments.
5860 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
5862 * som.h: New enum series SOM_CREATE_* for use as create flags with
5865 * str.h: Moved a comment here from TODO.
5867 * sysfile-info.c: New file. Reference implementation.
5869 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
5871 * command.c: Added RENAME VARIABLES to table of commands.
5873 * data-in.c: (dls_error) Sets `cust_field'.
5874 (parse_N) Message fix.
5875 (parse_day_count) New function.
5876 (to_roman) Never outputs VX as a `short form' of V.
5877 (parse_month) Fixed parsing of Roman numerals.
5878 (parse_trailer) Message fix.
5879 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
5880 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
5881 the date is invalid.
5882 (parse_SDATE) Fixed swapped day, year.
5883 (parse_JDATE) Fixed bug for dates in 1582.
5884 (parse_DTIME) Allows days not between 1 and 31.
5885 (parse_numeric) Makes local copy of f.type for easier usage.
5888 * data-out.c: (convert_F) When outputting as scientific, properly
5889 sets f.type as fp->type.
5890 (insert_commas) Fixed operator precedence problem with setting of
5891 nitems. Changed strcpy to memcpy (no null terminator).
5892 (convert_date) Fixed FMT_JDATE: added 1900 to year.
5893 (convert_CCx) Essentially rewritten, but now it works.
5895 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
5897 (display_documents) Implemented.
5899 * error.c: (glob var cust_field) New var.
5900 (vmsg) Displays cust_field as part of message classes DE and DW.
5902 * formats.c: (debug_print) Fixed to compile under updated
5905 * get.c: (cmd_get, cmd_save_internal) Close file handle on
5908 * misc.c: (parse_format_specifier) Formatting fix.
5910 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
5911 `n_rename' for clarity.
5912 (cmd_modify_vars) Initializes `forward' and `positional' at
5913 appropriate times. Frees lists of vars to rename on failure.
5914 Comment fix. Frees memory on success.
5915 (rearrange_dict) Simplified `for' loop condition.
5917 * rename-vars.c: New file (reference implementation).
5919 * set.q: (internal_cmd_set) Fixed `emu' test condition.
5921 * sfm-read.c: (read_header) File label is created only if file
5922 label in file is not blank.
5923 (read_variables) Initializes `dict' local variable.
5924 (read_documents) Proper behavior on lossage.
5926 * sfm-write.c: (write_header) Doesn't blank out the file label
5927 (why was this here to begin with?!)
5929 * temporary.c: (save_dictionary) File label is copied only if
5930 non-NULL. Doesn't try to xstrdup() dictionary documents.
5931 Adapted so as to not irritate Checker.
5932 (free_dictionary) Only destroys var_by_name if non-NULL.
5934 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
5935 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
5936 lines to the document, indents the document. Also, it works now.
5937 (add_document_line) New function.
5939 * var.h: (struct dictionary) Reordering.
5941 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
5942 bits if it was allocated to begin with.
5944 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
5946 * command.c: Added MODIFY VARS to list of commands.
5948 * configure.in: Updated custom macros for autoconf 2.12. Removed
5949 mmap reference; fixed termcap library reference.
5951 * display.c: (display_variables) Fixed a few bugs although it's
5952 still not well written.
5954 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
5955 (induce_segfault) Calls chkr_disp_call_chain() instead of
5956 inducing an actual SIGSEGV.
5958 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
5959 str_search() and str_rsearch(). Fixed tests for matches on
5960 OP_INDEX and OP_RINDEX.
5962 * filename.c: (good_getcwd) Removed as the new libc for Checker
5963 doesn't contain this bug, apparently.
5965 * misc.c: (str_search, str_rsearch) Changed order of arguments for
5966 consistency with GNU memmem.
5967 (blp_getdelim) Changed `len' from `int' to `size_t'.
5969 * modify-vars.c: Reference implementation.
5971 * som-frnt.c: (zero_length) New global var.
5972 (som_create_table) Message fix.
5974 * som.h: Added gcc attributions to som_set_text(),
5975 som_output_text() prototypes. blank_line() refers to
5976 zero_length[] instead of a literal null string to suppress gcc
5979 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
5980 (allocate_cases) Decrements x_max so the last element of x[] can
5981 be used by the algorithm.
5983 * var.h: Changed minor details of `variable' declaration.
5984 (struct modify_vars_proc) New struct.
5985 (struct variable) Added field p.mfv.
5987 * vars-atr.c: Comment fix.
5989 * vars-prs.c: (fill_all_vars) More optimal implementation.
5991 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
5992 character, which it shouldn't have to do but printf() seems to
5993 read the null byte even though I supply a maximum length...
5995 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
5997 * command.c: Removed command alias X for QUIT.
5998 (parse_cmd) Fixed comment parsing.
6000 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
6002 (read_record) Fixed references to len, size.
6003 (dfm_get_record) Restructured.
6005 * file-handle.h: (struct file_handle) Field `lrecl' now of type
6008 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
6011 * modify-vars.c: New file. Not complete.
6013 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
6016 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
6017 problems caused by int/size_t differences.
6019 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
6022 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
6023 being compared were of equal length.
6025 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
6027 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
6029 * lexer.c: (get_dotted_rest_of_line) New function.
6031 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
6034 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
6035 type 6 records. Frees the dictionary properly.
6036 (read_header) Initializes the dictionary instead of letting
6037 read_variables() do it. Sets the dictionary file label from the
6039 (read_documents) New function.
6041 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
6042 write type 6 record if appropriate.
6043 (write_header) Writes file label from dictionary.
6044 (write_documents) New function.
6046 * temporary.c: (save_dictionary, restore_dictionary,
6047 free_dictionary) Properly handle new fields in dictionary struct.
6049 * title.c: (get_title) Returns after failure().
6050 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
6051 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
6053 * var.h: (struct dictionary) New fields `label', `n_documents',
6056 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
6058 * command.c: Added FILTER to list of commands.
6060 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
6063 * get.c: (cmd_save_internal) Removed weighting code since it's now
6064 handled by sfm-write.c. Properly commented out debug code.
6066 * glob.c: (glob var weighting) Removed.
6068 * sel-if.c: Comment fixes.
6069 (cmd_filter) New function.
6071 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
6072 (sfm_read_dictionary) Sets weighting variable direct in the
6073 created dictionary now. (Apparently we previously didn't support
6075 (read_header) Sets weight_index field in sfm_fhuser_ext from
6076 header read from disk.
6078 * sfm-write.c: (sfm_write_dictionary) Comment fix.
6079 (write_header) Now sets the weighting in the header from the
6080 passed primary dictionary instead of from the sfm_write_info.
6082 * sfm.h: (struct sfm_write_info) Removed field `weight'.
6084 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
6085 broke on boundary conditions.
6087 * var.h: (struct dictionary) New fields `weight_var',
6088 `weight_index', and `filter_var'.
6089 (glob var weighting) Removed. This is now part of struct
6090 dictionary. All references changed; the less mechanical changes
6091 are described above.
6093 * vars-atr.c: (find_dict_variable) New function.
6095 * vfm.c: (static var filter_index) New variable.
6096 (open_active_file) Initializes filter_index from default_dict.
6097 (write_case) Calls proc_func() only if the filter variable is
6098 nonzero; this implements FILTER behavior.
6100 * weight.c: (static var weight_varname) Removed.
6101 (cmd_weight) Modified default_dict instead of glob vars.
6102 (update_weighting) Changed the signature to modify a dictionary
6103 instead of glob vars. Now returns the weighting variable.
6104 (get_weighting_variable) Removed; its function is absorbed by
6106 (stop_weighting) Operates on a dictionary now.
6108 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
6110 * sort.c: Removed debugging info from messages.
6111 (do_external_sort) Cleans up after itself by deleting the
6112 temporary directory on failure. (On success it is deleted by the
6114 (allocate_cases) Removed debug code. Added clean up code.
6115 (output_record) Removed debug code.
6116 (merge) Added code to close all the input files that are currently
6117 open. This is a likely location for bugs, because I'm not sure
6118 about boundary conditions. Removed an unnecesary heap_delete().
6119 (merge_once) Removed input file "optimization" that in fact
6120 screwed up the rest of the code. Message and comment fixes.
6122 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
6124 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
6126 * heap.c: (heap_delete) New argument.
6128 * sort.c: Finished implementation of external sort.
6130 * vfm.c: (read_from_disk) Returns after a disk error.
6132 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
6134 * sort.c: (static var state) Removed.
6135 (static vars max_handles, tmp_basename, tmp_extname,
6136 huffman_queue) New variables.
6137 (do_external_sort) Moved most code to new functions.
6138 Creates huffman_queue.
6139 (allocate_file_handles, allocate_cases) New functions.
6140 (static vars run_no, run_length, file_index, case_count) New
6142 (output_record) Returns success. Now really writes to the output
6144 (begin_run, end_run) New functions.
6145 (write_initial_runs) Returns success. Initializes run_no to -1.
6146 Calls begin_run(), end_run() at appropriate times. Outputs debug
6148 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
6150 (merge) New function.
6152 * heap.c, heap.h: New files. Hopefully in near-final form.
6154 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
6156 * glob.c: Added write_active_file to global vars.
6158 * sort.c: Several new miscellaneous static variables.
6159 (cmd_sort_cases) Big comment fix.
6160 (perform_case_2) Renamed `do_external_sort' and completely
6162 (case_2_proc_func) Removed.
6163 (output_record, write_initial_runs, write_to_sort_cases,
6164 compare_record) New functions.
6166 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
6168 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
6170 * sort.c: (perform_case_2) Changed the method for allocation of
6171 lots of memory--now allocates one case at a time in hopes that
6172 more cases can be allocated with heavily fragmented memory.
6174 * var.h: (write_active_file) New global var.
6176 * vfm.c: (procedure, close_active_file, write_case,
6177 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
6178 arguments to procedure() to be NULL. All references to
6179 procedure() that made use of dummy functions were changed to NULL
6181 (open_active_file) If write_active_file is non-NULL, the output
6182 device becomes DEV_PGM (a new enum).
6183 (close_active_file) Sets write_active_file to NULL.
6184 (read_from_memory) Comment fix.
6185 (record_case) Calls write_active_file() when the output device is
6188 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
6192 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
6193 Fixed checking for duplicate varnames.
6194 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
6196 (autorecode_trns_free) Destroys hash tables for each recoding
6198 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
6200 * command.c: Added SORT CASES to cmd_table.
6201 (null_func, null_int_func) Prototyped.
6203 * descript.g: (calc_weight, calc_noweight) Computes own case
6206 * frequencies.q: (dump_statistics) Fixed problem with
6207 too-few-cases warning message.
6209 * get.c: (cmd_save_internal) Handles weighting properly.
6211 * hash.c: (hsh_dump) Output format changed.
6212 (force_hsh_insert) Actually works now, prototype changed.
6214 * list.q: (static var case_num) New variable.
6215 (cmd_list) Initializes case_num.
6216 (list_cases) Increments case_num.
6218 * var.h: Added definitions for SORT CASES. Comment fixes.
6220 * vfm.c: Some definitions moved to new file vfmP.h. Comment
6221 fixes. `active' renamed vfm_active, `rep' renamed
6222 vfm_replacement, all references changed.
6223 (procedure) The procfunc no longer receives a case number. All
6225 (write_case) Subtle reordering.
6226 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
6229 * weight.c: (get_weighting_variable) New function.
6231 * vfmP.h: New file with definitions from vfm.c.
6233 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
6235 * command.c: (FILE_TYPE_okay) Commented out some tests because
6236 they're clumsy and not yet needed.
6238 * var.h: Most *_trns structures moved to their respective source
6239 files. Some were moved into a new file, do-ifP.h. Comment fixes.
6240 (union any_trns) Changed to a typedef for trns_header.
6241 (struct input_program_pgm) Removed.
6243 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
6244 was allocated in the first place.
6246 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
6248 * autorecode.c: New file.
6250 * command.c: Added AUTORECODE to command table; re-enabled SET.
6252 * data-out.c: (convert_F) Handles infinities and NaNs properly.
6254 * error.c: (vmsg) Comment fixes.
6256 * hash.c: Comment fix.
6257 (hashpjw_d) New function.
6258 (hashpjw) Reimplemented as call to more general function
6260 (internal_comparison_fn) Initializes pointers properly.
6261 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
6262 (force_hsh_insert, force_hsh_find) New debugging wrapper
6265 * main.c: (main) Message fix.
6267 * output.c: (outp_read_devices) Message fix.
6269 * set.q: Comment fixes.
6270 (custom_results) Implemented Wnd/X form of subcommand.
6271 (set_routing) New function.
6272 (internal_cmd_set) Implemented ERRORS, MESSAGES.
6274 * settings.h: (SET_ROUTE_*) New enum series.
6275 (set_results) Renamed set_results_file, all references changed.
6276 (set_messages) Removed.
6277 (glob vars set_errors, set_messages, set_results) New vars.
6279 * title.c: (get_title) Remembers to xstrdup() the result of
6282 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
6284 (union any_trns) New element `arc'.
6286 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
6288 * command.c: (output_line) Removed references to set_screen.
6290 * error.c: (static var terminating) New var.
6291 (hcf) Sets terminating to 1.
6292 (vmsg) If terminating is nonzero, does not attempt to call hcf().
6293 This prevents an infinite loop if an error occurs within hcf().
6295 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
6296 statement circumlocution with `case 42000' trick.
6297 (evaluate_expression) New support for OP_STR_MIS.
6299 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
6300 statement circumlocution with `case 42000' trick.
6301 (dump_node) Handles OP_STR_MIS.
6303 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
6304 variables exceptions.
6305 (parse_function) Message fix.
6306 (ops[]) Added OP_STR_MIS.
6308 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
6310 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
6312 * glob.c: Removed set_scrnfile glob var.
6313 (init_glob) set_errorbreak set to 0 by default.
6315 * groff-font.c: Changed included files.
6316 (groff_read_font) Initializes font_arena local var correctly.
6317 (default_font) New function.
6319 * output.c: Comment fixes.
6320 (glob var disabled_devices) New variable.
6321 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
6323 [GLOBAL_DEBUGGING] (reentrancy) New function.
6324 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
6325 outp_iterate_enabled_drivers) Calls to reentrancy().
6326 (destroy_list) New function.
6327 (outp_done) Moved code to destroy_list().
6328 (parse_options) Parses `listing', `screen', `printer' options
6330 (configure_driver) Sets new `device' member of driver.
6331 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
6333 * output.h: Comment fixes. New enum series OUTP_DEV_*.
6334 (struct outp_driver_struct) New member `device'.
6336 * postscript.c: (find_encoding_file) Doesn't display its own error
6338 (default_encoding) New function.
6339 (switch_font) Calls default_encoding() if no encoding can be
6341 (text) Makes up a character metric if none exists for the desired
6343 (load_font) Properly copies a fallback filename. Calls
6344 default_font() for a font if none at all are known.
6346 * set.q: Comment fixes. Removed OUTPUT subcommand.
6347 (custom_listing) Calls outp_enable_device() to enable/disable
6349 (turn_screen_on) Removed.
6350 (internal_cmd_set) Calls outp_enable_device() to enable/disable
6351 screen, printer devices.
6353 * settings.h: Comment fixes.
6354 (glob vars set_output, set_printer, set_screen, set_scrnfile)
6357 * som-high.c: (som_submit_table, som_eject_page) Use
6358 outp_iterate_enabled_drivers() instead of iterating
6359 outp_driver_list directly.
6361 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
6363 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
6364 (parse_string_as_format) Handles new formats.
6365 (parse_numeric) Now handles DOT and PCT formats.
6367 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
6369 (convert_date) Handle EDATE and SDATE formats.
6370 (convert_CCx) Now if there's not room for the currency characters,
6371 converts it as F format if it's positive instead of giving up
6372 quickly. Also fixed save-and-restore bug with decimal point
6374 (convert_format_to_string) Handles new formats.
6376 * misc.c: (formats[]) Added new formats.
6377 (convert_fmt_ItoO) Supports new formats.
6379 * sfm-read.c: (parse_format_spec) Supports new formats. Better
6380 data checking. New argument, all references changed.
6382 * sfm-write.c: (write_format_spec) Supports new formats.
6384 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
6387 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
6389 * cmdline.c: Comment fixes.
6390 (parse_command_line) Changed return type to void.
6392 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
6394 (parse_numeric) Handles international numbers (comma as decimal
6395 point). Some reformatting.
6397 * data-list.c: (parse_free) Default output format is now
6398 set_format instead of hard-coded F8.2.
6399 (read_from_data_list_list) Emits error message on undefined data
6400 only if set_undefined is nonzero.
6402 * data-out.c: (convert_E) Changes decimal point from period to
6403 comma if appropriate. Restructured. Better comments.
6404 (convert_F) Changes decimal point from period to comma if
6406 (insert_commas) Major bug with handling of negative values fixed.
6407 Also, inserts periods instead of commas if appropriate.
6408 (convert_CCx) New function.
6409 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
6410 (num_to_string) Changed `.' to set_decimal.
6412 * dfm.c: Comment fixes.
6413 (dfm_close) Frees ext->line even in inline_file.
6414 (open_inline_file) New function.
6415 (open_file_r) When opening the inline file: now properly
6416 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
6418 (read_record) Calls fh_close_handle() instead of dfm_close() to
6419 close the inline file. Makes a copy of the line getl_buf to avoid
6421 (dfm_get_record) Restructured. Now checks the return value of
6423 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
6424 checking for use of inline file. No longer tries to close inline
6427 * error.c: (glob var error_already_flagged) New var.
6428 (vmsg) Message change. Now checks max number of errors/warnings,
6431 * file-handle.q: (fh_handle_name) Now allows closing of
6433 (fh_init_files) Reformatted.
6435 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
6437 * getline.c: (getl_include) Fixed bug that popped up when called
6438 when file queue was empty.
6439 (read_console) Resets error_count, warning_count,
6440 error_already_flagged to zero.
6442 * glob.c: Many changes to update list of variables.
6443 (init_compat_dependent) Now this function is called whenever
6444 `compat' changes. It now sets set_seed only if it hasn't
6445 previously been referenced. It now calls
6446 lex_init_compat_dependent().
6448 * include.c: (cmd_include_at) Frees temporary buffer instead of
6450 (cmd_include) Doesn't make copy of include file name.
6452 * lexer.c: Comment fixes.
6453 (init_lex) Moved some code into new function
6454 lex_init_compat_dependent().
6455 (lex_init_compat_dependent) New function.
6456 (hex_val) Simplified.
6457 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
6459 * main.c: Comment fixes.
6462 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
6463 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
6464 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
6465 (setup_randomize) Sets set_seed_used.
6467 * set.q: Comment fixes.
6468 (custom_results) Conditionalizes on `compat'.
6469 (custom_log) Calls custom_journal().
6470 (set_ccx) New function.
6471 (cmd_set) Calls init_compat_dependent() when `compat' changes.
6472 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
6473 when set_decimal changes. Range-checks values for MITERATE,
6474 MNEST. Message fixes.
6476 * settings.h: Comment fixes.
6477 (struct set_cust_currency) New struct.
6478 (set_cc[], set_grouping, set_seed_used) New global vars.
6480 * var.h: (FMT_CCA...FMT_CCE) New output formats.
6481 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
6483 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
6485 * glob.c: Revised variables to correspond to settings.h.
6486 (init_glob) Initializes variables from settings.h properly.
6488 * set.q: Began long-overdue major revision to correspond to new
6489 philosophy. Most code changed.
6491 * settings.h: Mostly changed; reorganized, reordered, large new
6494 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
6496 * get.c: (cmd_save_internal) No longer forces compression off.
6498 * sfm-read.c: (read_compressed_data) If eof is reached when
6499 reading a new instruction octet, only signal error if we're in the
6502 * sfm-write.c: (COMPRESSION_BIAS) New #define.
6503 (struct sfm_fhuser_ext) New member `end'.
6504 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
6505 (ensure_buf_space) New function.
6506 (sfm_write_case) Reimplemented in order to support compression.
6507 (sfm_close) Writes out the remaining contents of the compression
6510 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
6512 * command.c: Defined SAVE and XSAVE commands in command table.
6514 * common.h: second_lowest_value is of type flt64, not double.
6516 * file-handle.h: Comment fix.
6518 * get.c: Comment fixes.
6519 (static var `trns') New.
6520 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
6521 cmd_save_internal, cmd_save, cmd_xsave) New functions.
6522 (dict_delete_run) Clears the variables and frees them now.
6523 (trim_dictionary) Sets default for compression.
6524 On KEEP subcommand, frees deleted variables as well as clearing
6525 them. Finally got the sense of the test for deleting all
6527 [DEBUGGING] (dump_dict_variables) Message fix.
6529 * glob.c: (init_glob) set_compression set to 1 by default.
6531 * list.q: Properly #includes config.h.
6533 * misc.h: New macro REM_RND_UP.
6535 * settings.h: Comment fix.
6537 * sfm-read.c: (structs sysfile_header, sysfile_format,
6538 sysfile_variable; inline function bswap_int32) Moved to new file
6540 (corrupt_msg) [__CHECKER__] No longer induces segfault.
6541 (sfm_read_dictionary) Fixed bug caused by failing to initialize
6543 (read_machine_flt64_info) Fixed some problems caused by confusion
6544 between flt64 and double types.
6545 (read_header) Message fix.
6546 (read_variables) Fixed set of cases in which we byte-swap sv.print
6547 and sv.write. Fixed confusion of flt64 and double.
6549 * sfm.h: (struct sfm_write_info) New.
6551 * som-high.c: (som_draw_title) Properly frees `s'.
6553 * temporary.c: (save_dictionary) Comment fix.
6555 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
6556 (struct trns_header) Formatting fix.
6557 (struct save_trns) New.
6559 * vars-atr.c: (discard_variables) Comment fix.
6561 * sfm-write.c: New file, baseline release.
6563 * sfmP.h: New file, baseline release.
6565 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
6567 * cmdline.c: (parse_command_line) `--version' output updated.
6568 (glob var syntax_message[]) Added my e-mail address.
6570 * file-handle.q, lexer.c, vfm.c: Changed many instances of
6571 `illegal' to `invalid'.
6573 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
6574 uncompression buffer.
6575 (sfm_close) Frees decompression buffer.
6576 (sfm_read_dictionary) Initializes decompression buffer.
6577 (buffer_input, read_compressed_data) New functions.
6578 (sfm_read_case) Restructured; now calls read_compressed_data() to
6579 handle compressed system file data.
6581 * var.h: Comment fix.
6583 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
6585 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
6588 * get.c: New comments. New static var `get_file'.
6589 (cmd_get) Now fully implemented. Calls discard_variables();
6590 initializes fv and lv for all variables; new debug code; sets
6591 up the dictionary; sets up the input program.
6592 (read_from_get, cancel_get) New functions.
6594 * sfm-read.c: Comment fixes.
6595 (sfm_close) New static function.
6596 (sfm_read_dictionary) Properly sets up the class of the
6597 file_handle. No longer cares what size the data is in records of
6598 type 7. Also, on failure, properly cleans up the file_handle and
6600 (read_variables) No longer thinks it knows `nval' of the
6601 dictionary. Now sets p.get.fv, etc., instead of speculatively
6603 (read_value_labels) Fixed off-by-one error in indexing of
6605 (sfm_read_case) New function.
6606 (sfm_r_class) New static var.
6608 * var.h: (get_proc) New struct.
6609 (struct variable) New member p.get.
6611 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
6613 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
6614 the manual's meaning.
6615 (rename_variables) New function.
6616 (trim_variables) Doesn't try to parse MAP any more. Removed debug
6617 code. Now properly reorders the dictionary on the KEEP keyword.
6619 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
6622 * vars-atr.c: (clear_variable) New argument `dictionary *'.
6623 (rename_variable) New function.
6624 (free_val_lab) Reformatted.
6626 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
6628 * var.h: Reindented entire file. Comment fixes.
6629 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
6631 (glob var default_dict) New.
6632 (struct indirect_dictionary) Removed.
6634 * Many other source files were changed to add `default_dict.'
6635 before all references to the dictionary of the active file.
6637 * vars-atr.c: (make_indirect_dictionary) Removed.
6639 * glob.c: Reindented all variable declarations. Updated for
6640 changed var.h. Comment fixes.
6642 * temporary.c: (restore_dictionary, save_dictionary) Simplified
6643 because now we can mainly copy dictionary structs.
6645 * vars-prs.c: (is_dict_varname, parse_dict_variable,
6646 parse_variables) Takes dictionary instead of indirect_dictionary
6648 (parse_variables) Instead of calling make_indirect_dictionary,
6649 just sets DICT to &default_dict if DICT is NULL. Of course, lots
6650 of `*dict.' references had to be changed to `dict->'. Removed
6653 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
6655 * get.c: Added GTSV_OPT_* series of enums.
6656 (trim_dictionary, dict_delete_run) New functions.
6657 [DEBUGGING] (dump_dict_variables) New function.
6658 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
6659 [DEBUGGING] Calls dump_dict_variables() to display results.
6661 * glob.c: (cmp_variable) Now a public function declared in var.h.
6663 * sfm-read.c: Turned off debug code. Comment fixes.
6664 (read_machine_int32_info, read_machine_flt64_info) New functions
6665 to parse type 7 records.
6666 (sfm_read_dictionary) Properly byteswaps several fields now.
6667 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
6668 records. [DEBUGGING] Dumps dictionary.
6669 (read_variables) Sets `index' field of variables created properly.
6670 Constructs avl tree of variables in dictionary. [DEBUGGING] No
6671 longer dumps dictionary.
6672 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
6674 [DEBUGGING] (dump_dictionary) No longer stubbed out.
6676 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
6677 var before destroying any variables just to save a little time.
6679 * var.h: (struct variable) Reordered in order to make name[] the
6680 first member; this makes pointers to `variable' pointers to the
6681 variable name, simplifying avl trees, etc.
6682 (struct indirect_dictionary) New struct.
6684 * vars-atr.c: (find_variable) Rewritten for efficiency.
6685 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
6687 (is_varname) Rewritten for efficiency.
6688 (parse_variables) New argument, which is a `dictionary *'. All
6689 references changed. This function now reads variable names from
6690 the dictionary passed, or from the default dictionary if NULL.
6692 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
6694 * misc.h: Added new macro DIV_RND_UP to perform integer division,
6695 rounding up. Changed many references to ROUND_UP to use this
6698 * sfm-read.c: Includes avl.h.
6699 (corrupt_msg) Induces a segfault under Checker.
6700 (macro assertive_bufread) New. Many references to bufread() now
6702 (sfm_read_dictionary) Split up into several functions. Added code
6703 to read dictionary records following the the type 2 records. Not
6704 quite complete. New variable `var_by_index'.
6705 (read_header, read_variables) New functions extracted from
6706 sfm_read_dictionary().
6707 (read_value_labels) New function.
6708 (bufread) Checks ferror() if fread() doesn't return the expected
6709 value; if ferror() is zero it's just EOF.
6710 (dump_dictionary) Stubbed out.
6712 * BTW: The source code now exceeds 50000 lines!
6714 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
6716 * command.c: Added GET to cmd_table[].
6718 * list.q: Removed reference to alloca headers.
6719 (cmd_list) Gave prototype.
6721 * sfm-read.c: Added DEBUGGING comments.
6722 (sfm_read_dictionary) Checks bias correctly. Sets
6723 dict->var_by_name to NULL. Calculates long_string_count
6724 correctly. realloc's dict->var[] array to minimum size.
6725 [DEBUGGING] Calls dump_dictionary.
6726 [DEBUGGING] (dump_dictionary) New function.
6728 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
6729 (restore_dictionary) If the dictionary contains a non-NULL
6730 var_by_name, uses that instead of generating one.
6731 (free_dictionary) Destroys var_by_name.
6733 * var.h: (struct dictionary) Added field `var_by_name'.
6735 * get.c: New file, not complete.
6737 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
6739 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
6740 (parse_num_or_range) New function.
6741 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
6742 <n> THRU HIGH missing values.
6744 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
6745 __attribute__((const)).
6747 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
6749 * sfm-read.c: Finished reference implementation.
6751 * sfm.h: Includes var.h.
6753 * var.h: Comment fixes.
6754 (struct `variable') Reordered some fields.
6756 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
6757 constants added previously.
6759 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
6761 * common.h: Comment fixes. Added declaration of
6762 `second_lowest_value' as variable or macro. Made `compat_type',
6763 `pgm_state_type' into anonymous enums.
6765 * display.c: Comment fix.
6767 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
6769 [!defined SECOND_LOWEST_VALUE] Added definition for
6770 `second_lowest_value' global var.
6771 (compat, pgm_state global vars) Changed types to `int'.
6772 (init_glob) Initializes `second_lowest_value'.
6774 * sfm-read.c: Continued work, not complete.
6776 * var.h: Added new MISSING_* constants to handle LOWEST and
6779 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
6781 * sfm-read.c: New file, not complete.
6783 * cases.c: (vec_insert) Changed vector expansion algorithm.
6784 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
6785 mucking up the RECODE transformation in particular.
6786 (envector) Harmless change in notation.
6788 dfm is now fairly well tested again.
6789 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
6791 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
6793 * recode.c: Comment fix.
6795 * sfm.h: Interface should be fairly final now, or at least for a
6798 * vfm.c: [DEBUGGING] (index_to_varname) New function.
6799 (open_active_file) [DEBUGGING] Translates ccase indices into
6800 variable names now to make it easier to understand what's really
6803 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
6805 * data-in.c: Comment fix.
6807 * data-list.c: Includes dfm.h.
6808 (do_reading) Uses new function dfm_push_cust().
6810 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
6813 * file-handle.h: Completely changed. Some parts split off into
6814 new file dfm.h. Implemented in file-handle.q.
6815 (enum FH_*) Removed.
6816 (struct fh_ext_class) New struct.
6817 (struct file_handle) Retained only these fields: name, norm_fn,
6818 fn, recform, lrecl, mode. New fields class, ext.
6819 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
6820 close_handle, handle_name) Added `fh_' prefix to name, all
6823 * dfm.h: New file, implemented in dfm.c.
6824 (get_record, put_record, fwd_record, bkwd_record, set_record,
6825 get_cur_col) Functions moved from file-handle.h, now prefixed with
6827 (dfm_push_cust) New function.
6829 * sfm.h: New file. Incomplete.
6831 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
6832 interface. Functions reordered, comments changed. Not well
6833 tested, probably full of bugs.
6834 (struct dfm_fhuser_ext) New struct.
6835 (dfm_close) New function.
6836 (open_file_r) Pickier about finding `BEGIN DATA.' line.
6837 (open_file_w) User messages changed.
6838 (get_record) Comment fixed.
6839 (read_record) Increments ext->ln even for inline_file. Calls
6840 dfm_close() for inline_file when `END DATA.' encountered.
6841 (dfm_get_record) Experimental restructuring.
6842 (dfm_push_cust) New function.
6843 (cmd_begin_data) Detects whether the inline file was fully read by
6844 checking whether it is still open; detects whether it was read at
6845 all by checking whether the line number is greater than zero.
6847 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
6848 interface. Functions reordered, comments changed. Not well
6849 tested, probably full of bugs.
6850 (init_file_handle) Removed initializers for obsolete fields, added
6852 (fh_close_handle) Much simpler, now mainly calls the class
6854 (fh_init_files) Renamed inline file internal filename.
6856 * file-type.c: Includes dfm.h.
6857 (read_from_file_type) Doesn't use dfm internal state anymore.
6859 * inpt-pgm.c, print.c: Include dfm.h.
6861 * recode.c: (internal_cmd_recode) Casts strlen() return value to
6862 int in comparison with other int.
6864 * som-high.c: (build_target) Fixed operator precedence problem in
6865 if statement (& versus ==).
6867 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
6869 * dfm.c: (read_record) Can now read fixed-length records; not
6871 (put_record) Can now write fixed-length records; not tested.
6873 * file-handle.h: FH_* defines changed to enums. New enum series
6875 (struct file_handle) New members recform, lrecl, mode.
6877 * file-handle.q: Parser changed.
6878 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
6879 /LRECL subcommands. These are compatible with Windows.
6880 (init_file_handle) Initializes recform, mode fields.
6882 * q2c.c: (get_line) When outputting `!' comment lines, now
6883 increments the output file line number so that `#line' directives
6885 (make_identifier) New function that converts an arbitrary string
6886 into a valid C identifier.
6887 (dump_vars) Calls make_identifier() in two places in order to
6888 suppress some errors for bad identifiers.
6889 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
6890 for NO. Allows numbers to be prefixed by underscores to make them
6891 acceptable C identifiers but still to be parsed as numbers by the
6894 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
6896 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
6898 * dfm.c: Comment fixes. (get_record) Gives error if file handle
6899 was opened for writing.
6900 (open_file_w) New function.
6901 (read_record) Uses strncasecmp if available. Improved error
6903 (put_record) New function.
6905 * file-handle.h: Moved function comments into dfm.c and
6906 file-handle.q. Comment fixes. Removed declarations of
6907 tilde_expand() and normalize_filename().
6908 (struct file_handle) Changed `open' from boolean to enumerated
6909 field to allow for three states--closed, open for reading, open
6910 for writing--all references changed.
6912 * file-handle.q: Includes filename.h.
6914 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
6916 (alloc_line) Makes allowance for line terminator characters in
6918 (print_trns_proc) Now handles OUTFILE, WRITE differences.
6919 (print_space_trns_proc) Handles OUTFILE differences.
6921 * recode.c, sample.c: Comment fixes.
6923 * var.h: (struct print_trns) Changed boolean field `eject' to
6924 bitmapped field `options'; all references changed. New enums
6925 PRT_* for use with this field.
6927 * exception.h, test-exception.c: Removed.
6929 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
6931 * ascii.c: (delineate) Turned off debug output.
6933 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
6936 * data-in.c: (parse_string_as_format) Sets the entire string value
6937 to spaces, not just the short string part of it. Is this correct
6940 * data-out.c: (convert_date) Fixed DATETIME format problems with
6941 decimal places, removed debug code.
6943 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
6944 middle of parsing BEGIN DATA that would cause the lexer to read
6945 from a wild pointer `prog'; now calls new function
6946 preprocess_line() in lexer.c.
6948 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
6950 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
6951 Now call induce_segfault() to induce the segfault.
6952 (induce_segfault) New function.
6954 * expr-opt.c: Comment fix.
6955 (parse_sysvar) New function.
6956 (parse_primary) Added system variable support--calls
6958 (global var ops) Added OP_CASENUM operator.
6960 * expr.h: Comment fixes.
6961 (OP_* enum) added OP_CASENUM operator.
6962 (struct casenum_node) New struct.
6963 (union any_union_union) New member `cas' of type `casenum_node'.
6965 * glob.c: (global var last_vfm_invocation) New var.
6966 (init_glob) Initializes last_vfm_invocation.
6968 * lexer.c: (lookahead) Fixed reversed condition on if statement.
6970 * getline.c: (get_line) Split into get_line() and preprocess_line().
6971 (preprocess_line) New function.
6973 * var.h: Declares last_vfm_invocation.
6975 * vfm.c: (procedure) Sets last_vfm_invocation.
6977 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
6979 * command.c: (parse_cmd) Fixed bad assertion related to
6982 * data-in.c: (parse_month) Implemented to parse months according
6983 to full interpretation of standard.
6984 (to_roman) New function.
6985 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
6986 (parse_weekday) Bug fix (forgot to skip all the day name).
6988 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
6989 up parsing of multirecord data items. Also fixed user message.
6991 * data-out.c: Comment fix.
6992 (year2, year4, convert_date, convert_time, convert_WKDAY,
6993 convert_MONTH) New functions to support time & date output.
6994 (convert_format_to_string) Calls new time & date output routines.
6996 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
6998 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
7001 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
7003 * misc.c: (global var formats) Fixed declarations of DATETIME,
7006 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
7007 the output_char buffer.
7009 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
7010 memory bug. Fixed user messages.
7012 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
7014 * Removed #pragma argsused from lots of places.
7016 * data-in.c: Implemented zoned decimal and time-date formats.
7017 Untested. This is a huge chunk of code--maybe 1000 lines and 50
7020 * data-out.c: Implemented zoned decimal format.
7022 * expr.h: Moved yrmoda() declaration here from exprP.h.
7024 * misc.c: (global var formats) Minor fixes--added
7025 FCAT_SHIFT_DECIMAL to formats N and Z.
7026 (convert_fmt_ItoO) Added support for format Z.
7028 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
7030 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
7032 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
7033 som_check_workspace() that is activated between commands.
7035 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
7038 * list.q: (begin_row) Changed title expansion style from
7039 SOPT_X_VERT to SOPT_X_SHSP.
7041 * som-frnt.c: Now includes `somP.h'.
7042 (som_push_workspace, som_pop_workspace) New functions that, taken
7043 together, form a solution to the recursive table building problem
7044 mentioned yesterday. Surrounded every table output routine
7045 throughout the program with calls to these functions.
7046 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
7047 (som_create_table) Checks that there's an active workspace.
7048 (som_destroy_all_tables, som_crush) Removed.
7050 * som-high.c: (global var som_preserve_tables) Removed, all
7052 (som_submit_table) Checks that there's an active workspace.
7053 (dump_columnated_table) Doesn't columnate tables that would have
7054 just one row per column.
7055 (dump_crush_page, som_dump_crush_page) Removed debugging code.
7056 (som_dump_crush_page) Moved row number labels from left side of
7057 tables to right side.
7058 (som_get_table_size) Added support for SOPT_X_SHSP.
7060 * som.h: New cell expansion type SOPT_X_SHSP.
7062 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
7064 (global var curtab_arena) Moved from som-frnt.c.
7066 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
7068 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
7069 that causes bad location warnings to be suppressed.
7070 (delineate) Saves current font when calling draw_text(); fixed
7071 handling of NULLs when backing up. Also fixed line-wrapping bug.
7073 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
7074 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
7076 * common.c: Added code to cause assertion failure to dump core
7077 when run under Checker.
7079 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
7080 there are still bugs.
7082 * glob.c: (__eprintf) Removed.
7084 * list.q: Inserted som_preserve_tables kluge that prevents tables
7085 from being thrown away due to recursive table building through
7086 som_output_line being called from a transformation during the LIST
7087 procedure invocation. This is a general problem that must be
7088 solved in a better way since it applies to all procedures in
7090 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
7091 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
7093 * numeric.c: Fixed several errors in the form of msg() calls.
7095 * print.c: Updated for use of som.
7096 (dump_table) Reimplemented.
7097 (print_trns_proc) Calls som_eject_page() instead of eject_page().
7098 Calls som_output_text() instead of outs_line().
7100 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
7102 (som_output_text) Function moved from som-low.c. Interface
7105 * som-high.c: (som_preserve_tables) New global public variable
7107 (som_submit_table) Destroys the tables only if som_preserve_tables
7109 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
7110 one subrow per row. Now labels subrows if there's more than one
7112 (dump_crush_table) Added wishlist comment.
7113 (som_eject_page) New public function declared in som.h.
7115 * som-low.c: (som_dump_crush_page) Draws row labels if there's
7116 more than one subrow per row.
7117 (som_output_text) Moved to som-frnt.c.
7119 * som.h: (SOM_TOPT_PRESERVE) Removed.
7121 * title.c: (get_title) Changed interface.
7122 (cmd_title) Changed `title' to `outp_title'.
7123 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
7125 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
7127 * list.q: (flush_table) Conforms to new partial options in
7128 som_submission_form.
7130 * som-high.c: (paginate_horizontally) Changed form of subrow
7132 (build_target) Omits spacing before table if
7133 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
7134 (dump_crush_page) Changed interface. Only trims bottom rule if
7135 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
7136 (dump_crush_table) Handles partial tables.
7137 (output_row_label) New function.
7138 (som_dump_crush_page) Emits subrow number labels. Draws vertical
7139 rule on the right edge of narrow subrows.
7141 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
7142 constants to a series of SOM_TOPT_PARTIAL_* submission options.
7143 All references updated.
7145 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
7147 * misc.c: Comment fix.
7149 * som-high.c: (examine_table) Treats crushed tables separates for
7150 purpose of determining header size.
7151 (paginate_horizontally) Allots space for line numbers in crushed
7152 tables with lots of subrows per row. Calculates the `maximum page
7153 width', the width of the widest horizontal page.
7154 (build_target) Removed trim argument; all references changed.
7155 Stricter assertions. (dump_crush_page) New function.
7156 (dump_crush_table) Reimplemented.
7158 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
7159 (som_dump_crush_page) Reimplemented, interface changed.
7161 * somP.h: Many many new helper macros for use with crushed tables.
7162 (global var som) Removed `tv', `cum_y' members; all references
7163 removed. New members `mpw', `digit_space'.
7165 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
7167 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
7168 variable, changed to constant 1024.
7169 (arena_ca_strdup) Changed `sizeof(a_string)' to
7171 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
7172 `(c_string *)' to `(char *)'; this fixed some offset problems.
7174 * filename.c: (readlink_malloc) Changed initial allocation from
7176 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
7179 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
7180 &fm->owner in several places.
7182 * som-high.c: (output_table) Changed interface to rest of world.
7183 (examine_crush_table) Removed. Crushed tables are re-broken now,
7184 in preparation for rewrite.
7186 * som.h: Comment fix.
7188 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
7190 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
7191 itself in the cleanup stage.
7193 * descript.q: (display) At least temporarily, changed the table
7194 format to a crushed table.
7196 * list.q: (begin_row) At least temporarily, added horizontal lines
7199 * som-high.c: (examine_crush_table) Sets som.hh to the width of
7200 the horizontal "headers," that is, to the width of the far left
7201 and far right rules.
7202 (justify_pagination) Sets som.th to the width of the widest row
7203 in the crushed table. Fixed inner loop off-by-one error.
7205 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
7208 * somP.h: Comment fix.
7210 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
7212 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
7213 before closing it; also, opens the constructed filename `s'
7214 instead of f->filename.
7216 * postscript.c: Moved initialization of x->loaded, x->prop,
7217 x->fixed, x->current, also the add_encoding() calls, into
7219 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
7220 sets x->last_font to NULL; sets x->next_combo to zero.
7222 * som-high.c: (crushed_row_height) Moved definition farther up.
7223 (som_submit_table) Doesn't calculate line width, font size until
7224 after calling open_page(), to accomodate changes to PostScript
7226 (vert_headers) Removed; equivalent functionality moved to
7227 examine_table(), examine_crush_table().
7228 (justify_pagination) Replaced with different algorithm.
7229 (dump_crush_table) Bugfix that caused tables to fail to be clipped
7230 at the bottom of the page.
7232 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
7234 * command.c: Added cmd_list back into cmd_table.
7236 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
7237 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
7239 * list.q: (flush_table) Updated to new som_submission_form format.
7241 * som-frnt.c: Comment fix.
7243 * som-high.c: Changed `#endif' to `#undef EXTERN'.
7244 (output_table) Calls som_get_table_size() directly; handles
7246 (examine_crush_table) New function; calls vert_headers().
7247 (examine_table) Moved some code into new function, vert_headers().
7248 (justify_pagination) New function.
7249 (dump_plain_table) Removed `static' from `cy'.
7250 (dump_crush_table) New function.
7252 * som-low.c: (som_dump_crush_page) New function.
7254 * som.h: Comment fixes.
7255 (enum SOM_TOPT_CRUSH) New.
7256 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
7257 Temporarily set to zero to make do with LIST procedure.
7259 * somP.h: Re-ordering.
7261 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
7263 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
7265 * somP.h: New file for use by som-high.c, som-low.c.
7267 * q2c.c: Added definition for VME.
7268 (get_line) Now dumps `!' comment lines to the output file
7271 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
7272 set.q: Changed format of `!' comment lines.
7274 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
7276 * All source files: Added copyright notice.
7278 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
7279 longs in msg() calls.
7281 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
7283 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
7285 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
7287 * output.c: (outp_read_devices) Changed criteria for
7288 distinguishing different types of lines.
7290 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
7292 * cmdline.c: Changed syntax message.
7294 * filename.c: (good_getcwd) Bug fix (?).
7295 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
7297 (search_path) Appends DIR_SEPARATOR to directory name only if it
7298 does not already end with one.
7300 * glob.c: Checks STAT_PAGER envvar before PAGER.
7302 * output.c: Checks environment variables instead of just local
7305 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
7307 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
7308 when the pointer passed to the function was within the arena
7309 itself, so that it couldn't properly be set to NULL _after the
7312 * command.c: Re-enabled DISPLAY.
7314 * display.c: Rewritten to handle tables. Untested.
7316 * filename.c: (search_path) Fixed memory leak.
7318 * frequencies.q: (cmd_frequencies) Frees v_variables.
7319 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
7320 (cleanup_freq_tab) New function to garbage collect.
7321 (dump_full) Elegantized.
7323 * main.c: New comment.
7325 * output.h: New tag for tagged quotes: TAG_NEWLINE.
7327 * postscript.c: Comment fix.
7328 (release_fontmap, free_font_entry) New functions.
7329 (ps_init_driver) Sets free_font_entry() as the freefunc for
7330 hashtable `loaded'. Calls release_fontmap() when destroying a
7331 driver; also frees the output filename; also frees the
7332 ps_driver_ext block.
7333 (free_ps_encoding) Frees the filename as well as the encoding
7335 (output_encodings) Frees the line buffer and pops the msg-filename
7337 (read_fontmap) Frees the fontmap filename and the line buffer.
7338 (postopen, preclose) Misc. garbage collection fixes.
7339 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
7340 to NULL; this fixes some output problems.
7341 (text) Handles TAG_NEWLINE. Untested.
7343 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
7344 (som_set_string) Removed. All references changed to
7346 (som_set_text) Rewritten. New interface. More general.
7348 * som.h: Minor format changes.
7349 (struct som_value_cell) Removed; all references changed to
7351 (enums SOT_*) Changed.
7353 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
7355 * command.c: Re-enabled SPLIT FILE.
7357 * postscript.c: Comment fix.
7359 * som.h: Added `SOT_NONE'.
7361 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
7363 * vfm.c: (dump_splits) Reimplemented.
7365 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
7367 * Compiled the project under gcc 2.7.2, which gave some new
7368 warnings. This led to many additions of casts from unsigned to
7369 int sprinkled throughout the code.
7371 * arena.c: Many uses of `unsigned' changed to `size_t'.
7373 * command.c: Added END FILE, END REPEAT to command table.
7374 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
7375 (find_command, FILE_TYPE_okay) Not commented out anymore.
7376 (parse_cmd) Calls FILE_TYPE_okay again.
7377 (output_line) Added calls to som_output_text() to put the line
7378 in the output files.
7380 * common.c: (macro VME) Format changes.
7381 (xstrdup) Asserts that its argument is not NULL.
7383 * data-list.c: Implemented dump_fixed_table().
7385 * inpt-pgm.c: Formatting changes. Comment changes.
7386 (end_case_proc) Renamed end_case_trns_proc.
7387 (cmd_end_file, end_file_trns_proc) New functions.
7389 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
7391 * misc.h: (local_strdup) New macro corresponding to strdup() but
7392 allocating its data through local_alloc() if possible--that is, if
7395 * postscript.c: Comment changes.
7396 (quote_ps_name, quote_ps_string, output_encodings) New functions.
7397 (output_line, add_string) New macros supporting
7399 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
7400 substitution vars. Calls output_encodings() when a line
7401 consisting of `!encodings' is encountered.
7402 (preclose) Some code moved into quote_ps_string().
7403 (dump_line) Changed into macro supporting dump_fancy_line().
7404 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
7405 command when appropriate.
7406 (write_text) Fixed `literal_char' array (I think it's fixed, at
7408 (text) Fixed bug when width was zero. Now exits immediately on
7409 zero height_left. Now, when executing `goto restart;', checks
7410 that cp<end, so that we don't read beyond end-of-string. Also,
7411 outputs the correct code to the output file by outputting the code
7412 from the metric instead of the internal metric index.
7414 * repeat.c: (cmd_end_repeat) New function.
7416 * som.c: (var som) `headers' renamed `options' and semantics
7417 changed. All references changed.
7418 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
7419 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
7421 (som_text_table) Removed.
7422 (som_output_text) New function.
7424 * som.h: (struct som_submission_form) Removed `header', `reuse',
7425 replaced with bitmapped field `options'.
7426 (SOM_TOPT_*) New enum set for som_submission_form.options.
7427 (SOT_*) New enum set for som_output_text().
7429 * temporary.c: (copy_variable) When copying the var label, only
7430 calls xstrdup() if it's non-NULL.
7432 * var.h: (enum type `vartype') Removed; all references changed to
7435 * vars-atr.c: (init_variable) Changed local var `nbytes' from
7438 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
7440 * font.h: Comment changes.
7442 * groff-font.c: (groff_read_font) Initializes `name' field to
7443 NULL. Handles `encoding' field.
7445 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
7447 * postscript.c: (struct font_entry) Removed `position' field.
7448 (struct ps_font_combo) New struct.
7449 (struct ps_driver_ext) Removed field `next_position'. New fields
7450 `combos', `next_combo'. `last_font' field changed from
7451 `font_entry *' to `ps_font_combo *'.
7452 (ps_init_driver) Reformatted; handles new fields. When
7453 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
7455 (get_encoding, find_encoding_file) New functions.
7456 (add_encoding) Some code moved out into find_encoding_file().
7457 (postopen) Changed value for ${title}.
7458 (preclose) Sets `loaded' field to NULL after destroying the hash
7460 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
7462 (ps_text_set_font_by_position) Figures out the current family if
7464 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
7465 (switch_font) Implemented.
7466 (write_text) Calls switch_font() more often. Format changes.
7467 #undefs its macros after they're no longer useful.
7468 (text) Changed `continue' at one point to a jump to the top of the
7469 loop because we don't want `separate' reset to 0 at that point.
7470 (load_font) No longer sets `position' in the font_entry created.
7472 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
7474 * font.h: (struct font_desc) New member `encoding', which is not
7475 properly handled yet.
7477 * glob.c: (init_glob) Some new i18n code, which is probably
7480 * output.c: (outp_read_devices, outp_get_paper_size) Changed
7481 `size' local from `int' to `size_t'.
7483 * postscript.c: New driver configuration parameter `auto-encode'.
7484 New enums OPO_AUTO_ENCODE, ODA_COUNT.
7485 (struct font_entry) New member `position'.
7486 (struct ps_driver_ext) Reordered. New hash table member
7487 `encodings'; new members `next_position', `next_encoding',
7488 `last_font'. Members `current', `prop', `fixed' changed from type
7489 `font_desc *' to `font_entry *'; all references changed.
7490 (struct ps_encoding) New struct.
7491 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
7492 free_ps_encoding, add_encoding) New functions.
7493 (ps_init_driver) Added OPO_AUTO_ENCODE to default
7494 x->output_options. Initializes new members of ps_driver_ext.
7495 Changed default value for prologue_fn, encoding_fn. Calls
7496 read_ps_encodings after loading default fonts.
7497 (option_tab[], ps_option) Handle new configuration parameter.
7498 (switch_font) New function.
7499 (struct output_char) `font' member changed from `font_desc *' to
7500 `font_entry *'. New member `separate'.
7501 (read_fontmap) Changed `size' from `int' to `size_t'.
7502 (output_line, put_number) New macros for write_text().
7503 (write_text) Optimizes text output by consolidating multiple
7504 calls to PostScript `show' operator.
7505 (text) Keeps track of when text arguments can't be consolidated by
7506 write_text(), and marks those spots in the output stream.
7507 (load_font) Sets `position' of the allocated font_entry to -1, cuz
7508 the font hasn't been switched to by switch_font(), which is where
7509 the position is important--the PostScript is what cares about the
7512 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
7514 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
7515 call a NULL free_func.
7516 (hsh_rehash) Elegantized.
7517 (hsh_probe) Fix bug that manifested when the table was expanded
7518 and thus had to change location in memory. Good thing
7519 too--otherwise could have been much more subtle.
7520 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
7521 (hsh_foreach) New function for hash table iteration.
7523 * hash.h: (struct hsh_iterator) New.
7525 * lexer.c: (parse_tagged_quote) Font and family name strings in
7526 tags are now null-terminated.
7528 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
7530 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
7531 documented. (Never before tested?)
7533 * output.h: Comment changes.
7535 * postscript.c: New driver options `optimize-text-size',
7536 `optimize-line-size', `max-fonts-simult'. New enum set for
7537 specing cached line types. Comment fixes.
7538 (struct line_form) New struct.
7539 (struct ps_driver_struct) New members `text_opt', `line_opt',
7540 `max_fonts', `lines'.
7541 (ps_init_driver) Initializes new members of ps_driver_struct.
7542 (user option type enum set) New member `nonneg_int_arg'.
7543 (static var option_tab[]) Supports new options.
7544 (ps_option) Handles new options.
7545 (find_ps_file) Made static. No longer calls hsh_dump().
7546 (ps_get_var) Made static.
7547 (preclose) Dumps out proper DSC trailer.
7548 (ps_open_page) Elegantized.
7549 (ps_close_page) Calls dump_lines() if appropriate.
7550 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
7551 wrappers around line().
7552 (int_2_compare, compare_line, dump_line, dump_fancy_line,
7553 dump_lines, hash_line, free_line, line) New functions for support
7555 (write_text, text) Made static.
7556 (text) Added to font support, not finished.
7558 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
7560 * font.h: (struct font_desc) New members ascent, descent.
7562 * groff-font.c: (groff_read_font) Calculates font ascent and
7563 descent from the ascent and descent of the `d' and `p' characters,
7564 respectively, as per a suggestion on comp.fonts.
7566 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
7567 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
7569 (write_text) Handles text right-justification and centering (not
7570 full justification). Still very inefficient. (One output line
7572 (struct output_char) Added fields for font and font size.
7573 (text) Many bugfixes.
7575 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
7577 * cmdline.c: (usage) Calls outp_list_classes().
7579 * font.h: Comment fix.
7581 * groff-font.c: New exported global var `space_index'.
7582 (groff_init) New function to initialize `space_index'.
7583 (hash_kern) Casts result to unsigned.
7584 (font_name_to_index) Renamed font_char_name_to_index. All
7585 references changed. Also, now returns the value of `space_index'
7586 when passed an ASCII space character as an argument. Fixed
7588 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
7589 Handles passed NULL pointers properly.
7591 * lexer.c: (parse_tagged_quote) Comment fix. Better range
7594 * output.c: (outp_list_drivers) Removed. Removed all references.
7596 * output.h: Comment fixes.
7598 * postscript.c: (ps_open_global) Calls groff_init().
7599 (output_char) New structure.
7600 (write_text) New function.
7601 (text) No longer stubbed out! Now the output is correct--with a
7602 few exceptions, one of them being that the page has to be held
7603 upside down into a mirror.
7605 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
7607 * font.h: Comment fix.
7609 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
7610 All callers changed.
7611 (number_to_index) Renamed font_number_to_index, made extern. All
7613 (font_get_kern_adjust, font_get_char_metrics) New functions.
7615 * output.h: New constant OUTP_T_INTERNAL_DRAW.
7617 * postscript.c: Changed default line width back to 1/2 point.
7618 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
7619 in the center of the space allotted for them, not just a fixed
7620 offset from the edge of the space; this fixes some bugs.
7621 (ps_line_intersection) Now supports all command line styles.
7622 (ps_text_get_size) Bug fix in computation of em width.
7623 (text) New function, the meat behind ps_text_metrics and
7624 ps_text_draw. Not complete.
7625 (ps_text_metrics, ps_text_draw) Removed the stub taken from
7626 ascii.c; call text().
7628 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
7630 * arena.c: (arena_free) Assert that the argument is non-NULL.
7632 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
7633 only if old_kern is non-NULL.
7635 * postscript.c: (ps_init_driver) Changed default line width to 1
7637 (postopen) New prologue variables.
7638 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
7639 more of the common line styles properly, but not all.
7640 (ps_text_metrics) Fixed problem with this stubbed out version that
7641 kept it from taking font sizes into account.
7643 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
7645 * arena.c: (arena_malloc) Bug fix.
7646 (arena_dump) [GLOBAL_DEBUGGING] New function.
7648 * ascii.c: Comment fix.
7649 (count_fancy_chars, delineate) Now static functions.
7651 * filename.c: (interp_vars) Bug fixes.
7653 * font.h: Comment fixes.
7655 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
7656 beginning in case we have an error message to display before
7657 initializing the display.
7659 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
7661 (groff_read_font) Bug fixes.
7662 (name_to_index) Increments hash.used. Sets `name' field of hash
7664 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
7666 * hash.c: Return type changed.
7668 * postscript.c: Continued development. Now marks lines on the
7669 paper, but very buggy.
7671 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
7673 * Changed comments in many source files from `/* xxx /* yyy */' to
7674 `/* xxx */ /* yyy */' for cleanliness.
7676 * arena.c: (arena_sd_strdup) New function.
7678 * ascii.c: (struct ascii_driver_ext) New member `file'.
7679 (ascii_init_driver) Fills out member `file' for initing; uses
7680 close_file_ext for closing drivers.
7681 (ascii_option) Changed %.*s back to %s because the a_string's are
7682 always null-terminated.
7683 (postopen, preclose) New functions.
7684 (ascii_open_page) Uses new style of open_file_ext.
7685 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
7686 instead of this->output.
7687 (__assert_fail) Removed.
7689 * cmdline.c: Changed syntax_message[].
7691 * error.c: #include's <readline/history.h> only if the history
7692 library is available, not if just the readline library is
7695 * filename.c: (expand_line) Removed alloca() support.
7696 (interp_vars) No longer tilde-expands argument. Limit on output
7698 (tilde_expand) Now treats argument as path rather than filename.
7699 [!unix] Now is a no-op function.
7700 (search_path) Better verbose message formatting.
7701 (open_file, close_file) Comment fixes.
7702 (close_file) [!unix] Doesn't bother with pipes.
7703 (open_file_ext) Completely rewritten, interface revamped.
7704 (close_file_ext) New function.
7706 * font.h: Comment changes.
7708 * frequencies.q: Removed AIX alloca support since it doesn't use
7711 * hash.c: Comment changes & additions.
7712 (hsh_create) Initializes entire table instead of first M entries.
7713 (hsh_probe) Stupid bug fixed. Now it works.
7714 (hsh_dump) [GLOBAL_DEBUGGING] New function.
7716 * main.c: (parse) Detects EOF properly in token-eating loop.
7717 Should the STOP token have its value changed to 0?
7719 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
7720 (blp_getline) Now it's a macro.
7722 * output.h: (struct outp_driver) Removed members output, filename.
7724 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
7725 drivers in driver table.
7726 (outp_read_devices) Frees buf. Warns if there are no active
7728 (outp_configure_clear) Sets outp_configure_vec to NULL after
7729 deleting its elements.
7730 (configure_driver, destroy_driver) Removed references to output,
7731 filename members of outp_driver.
7732 (outp_evaluate_dimension, internal_get_paper_size,
7733 outp_get_paper_size) New functions.
7735 * postscript.c: Continued development. Now links but doesn't make
7736 any marks on the page. Lotsa bugs I suppose.
7738 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
7740 * str.h: Comment changes.
7742 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
7744 * Removed dependencies on non-nested comments in several files.
7745 Also removed references to (unix || __unix__) in #if's since
7746 prefh.orig makes those two equivalent.
7748 * ascii.c: (ascii_open_global) Creates ascii_arena.
7749 (ascii_close_global) Destroys ascii_arena.
7750 (ascii_init_driver) Doesn't create ascii_arena.
7751 (ascii_copy_driver) Removed.
7752 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
7753 (outp_class ascii_class) Removed ascii_copy_driver reference.
7755 * frequencies.q: Now can display all statistics except median.
7758 * output.c: Handles outp_class.ref_count so output class
7759 destructors are called properly.
7760 (add_class) Sets ref_count to 0.
7761 (configure_driver) Initializes class if ref_count++ is 0.
7762 (destroy_driver) Destructs class if --ref_count is 0. Frees the
7763 class output file name.
7765 * output.h: (struct outp_class) Removed copy_driver, inited.
7768 * postscript.c: Completely replaced but not finished.
7770 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
7772 * approx.h: #includes <float.h>.
7774 * arena.h, arena.c: Many functions changed to take an arena **
7775 instead of an arena *, for consistency. All callers changed.
7776 (arena_alloc) Now creates a new arena if passed *A that is NULL.
7777 (arena_destroy) Sets *A to NULL.
7779 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
7780 assertion that `width' be positive.
7782 * command.c: Removed #if's from cmd_table.
7783 (walk_cmdtable_func) [0] New function (debug code).
7784 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
7785 (parse_cmd) Doesn't return failure for unimplemented commands.
7787 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
7788 (SYSCODE) New constant macro.
7790 * descript.q: Checks for positive n_variables before performing
7793 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
7794 avl_find instead of &fp as arg 2.
7796 * frequencies.g, frequencies.q: Continued updating; now compiles &
7797 works again, but not complete.
7799 * main.c: Changes to user messages.
7801 * misc.c: (reverse) [0] New function.
7803 * settings.h: Comment removed. #includes "common.h".
7805 * som.c: (som_set_null) New function.
7806 (som_set_value, som_set_string, som_set_text) More detailing
7808 (som_set_float) Implemented function.
7809 (dump_columnated_table) Bug fix regarding page breaks.
7810 (draw_cell) Bug fix regarding text that spilled out of a cell.
7811 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
7813 (get_cell_size) Support SCON_EMPTY cells.
7814 (get_table_size) When calculating rules' widths and heights, mask
7815 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
7817 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
7819 (struct som_submission_form) New member `header'; all users
7822 * val-labs.c: (get_label) User messages changed.
7824 * var.h: Changed FREQUENCIES structures.
7826 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
7829 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
7831 * approx.h: Definition of EPSILON now depends on system's
7832 DBL_EPSILON. Removed GNU C specific code.
7833 (cmpapx) Renamed approx_compare.
7835 * frequencies.g, frequencies.q: Continued updating; still doesn't
7838 * groff-font.c: (name_to_index) Fix bug that kept it from
7841 * hash.c, hash.h: Completed work.
7843 * var.h: Changes to freq_tab, frequencies_proc.
7845 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
7848 * hash.c, hash.h: New files. Not completed.
7849 * Makefile.am: Added hash.c to source file list.
7850 * font.h: (struct font_desc) New member kern_size_p.
7851 * groff-font.c: Uses hash.h.
7852 (hashpjw) Moved to hash.c.
7853 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
7855 (static var hash) New member size_p.
7856 * var.h: Includes hash.h.
7857 (struct freq_tab) Changed AVL_TREE to hash_tab.
7859 * vars-prs.c: Comment, formatting fixes.
7861 * frequencies.g, frequencies.q: Continued updating. Not yet
7864 * formats.c: Bug fix.
7866 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
7868 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
7869 * descript.g: Comment fixes.
7870 * descript.q: Comment fixes. Moved some declarations into var.h.
7871 Made dsc_info a static table. Updated FIXMEs.
7872 (internal_cmd_descriptives) Beautified.
7874 * frequencies.q: Started updating into working order.
7875 * frequencies.g: New file analogous to descript.g.
7876 * var.h: Comment fixes. Added structures for FREQUENCIES.
7878 * som.c: Removed vestiges of crushing and partial table support.
7880 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
7882 * Many more changes to som.c especially, but these will not be
7883 documented as I have resolved to remove them. This patchlevel is
7884 being released solely so that I can fall back to it if I decide
7885 that removing the changes is not a good idea.
7887 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
7889 * som.c: (global var som) New member `cum_y'.
7890 (build_target) Properly handles titles for partial tables.
7891 (dump_partial_beg, dump_partial_mid, dump_partial_end)
7892 Merged into single new function dump_partial(). Fixed problem
7893 with titles on partial tables.
7894 (dump_table) Calls dump_partial() for all parts of partial tables.
7895 (dump_page) Criteria for drawing title changed.
7897 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
7899 * command.c: (cmd_table) Added LIST, WEIGHT.
7901 * command.c: (cmd_remark) No longer frees `s' since it's not
7902 dynamically allocated.
7904 * data-out.c: (convert_f) Now correctly handles the case where
7905 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
7907 (som_destroy_all_tables) Removed argument. All callers changed.
7908 (som_vline, som_hline) Argument validity checking corrected.
7909 (som_set_value) Implemented half-heartedly.
7910 (replicate_table) Copies tables piece-by-piece when using Checker.
7912 * som.h: New line style SLIN_1THIN, currently equivalent to
7913 SLIN_0. New enum set SOM_SUB_*.
7914 (struct som_submission_form) Removed `seq_no'. Added `type'.
7916 * list.q: Newly working file; uses partial tables.
7918 * som.c: (som_reduce_table) Renamed som_set_table_height().
7919 (som_crush) Removed argument `group'.
7920 (global var som) Removed `nt', `seq_no'. Added `type'.
7921 (som_submit_table) Arguments changed.
7922 (output_table) Removed partial table code.
7923 (build_target) New arg; partial table support added. All callers
7925 (dump_plain_table) Removed partial table code.
7926 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
7927 (dump_table) Supports partial tables.
7928 (dump_page) New argument to allow not drawing top and/or bottom
7929 headers. All callers changed. Supports partial tables.
7931 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
7933 * data-out.c: Changed `#include <approx.h>' to `#include
7935 (convert_F) Comment fix. Now won't print `-.000', etc.
7937 * descript.q: Now Z-scores work, although there appears to
7938 be a bug (which might actually be in data-out.c:convert_F()).
7939 (descriptives_trns_proc, descriptives_trns_free) New functions.
7940 (run_z_pass) Implemented.
7942 * var.h: Comment fixes.
7943 (dsc_z_score, descriptives_trns) New structs.
7944 (descriptives_trns) Added to any_trns as `dsc'.
7946 * error.c, error.h: New error class, IS (Installation Script
7947 error), used in those instances where the error is in the
7948 installation, but there is a script file or installation file that
7949 can be usefully referred to.
7951 * output.c: Change many IE classes to IS classes.
7953 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
7954 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
7955 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
7956 include the corresponding header?
7958 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
7959 Don't bail out if termcap can't be read.
7961 * som.c: (som_destroy_table) Removed.
7962 (som_reduce_table, som_destroy_all_tables) New functions.
7963 (som_crush) New function, not implemented.
7965 * som.h: New table option STAB_CRUSH. Comment fix. New struct
7966 som_submission_form. Function prototypes revised.
7968 Outputting huge tables (1000s of rows) a few rows at a time
7969 is supported, though untested. May even break everything.
7970 Actually, the code doesn't even compile right now.
7971 * som.c: (struct som) New fields htv, nt, seq_no.
7972 (som_submit_table) Multiple arguments changed to a single
7973 pointer to struct submission_form. Only increments subtable_num
7974 if seq_no is zero. Only destroys table if it's not going to
7976 (replicate_table) New function.
7977 (output_table) Comment fix.
7978 (examine_table) Changed inline code to code calling
7979 replicate_table(). Calculates htv. Supports partial tables.
7980 (draw_title) Removed comment.
7981 (build_target) Only allows for title on first part of partial
7983 (dump_plain_table) Only resets table chunk number on first part
7984 of partial tables; FIXME: doesn't work quite right. Supports
7986 (dump_page) Titles only on first part of partial tables.
7988 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
7990 * Thanks to an unreliable IDE hard drive, I have spent the last
7991 day reconstructing my Debian GNU/Linux installation and redoing
7992 the previous day's changes--somehow I managed to save every file
7993 except for output.c and output.h. So the following changes could
7994 really be considered independent of the output.c, output.h changes
7997 * output.h, output.c: Moved the outp_configure_vec global var,
7998 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
7999 outp_configure_vec is now static.
8001 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
8003 * The entire philosophy behind configuration of the output drivers
8004 changed. Now there is a termcap-type configuration where drivers
8005 to be read are determined beforehand, rather than parsing the
8006 entire output init file and storing it in memory & deciding what
8007 to actually use later. Faster & more memory-efficient at the same
8010 * output.c: Comment fix. Removed outp_init_drivers global var.
8011 Removed all references to synonyms. New structure outp_defn. New
8012 global vars outp_macros, outp_configure_vec.
8013 (search_name, delete_name, add_name, check_configure_vec,
8014 expand_name, find_defn_value) New static functions.
8015 (outp_configure_clear, outp_configure_add, outp_configure_macro,
8016 outp_read_devices) New extern functions.
8017 (outp_init) Much functionality moved into outp_read_devices.
8018 (outp_read_devices) Format of output init file changed; name of
8019 file is `devices' rather than `output' to avoid Makefile
8021 (outp_clear) Renamed outp_done.
8022 (outp_list_classes) Bug fix, cleaned up.
8023 (outp_list_drivers) Not implemented anymore.
8024 (outp_configure_driver) Now a static function; simplified; now
8025 interpolates macros; supports new structure.
8026 (outp_enable_driver, match_synonym) Removed; all references
8028 (find_driver) First argument removed.
8030 * output.h: Global var outp_init_drivers removed; new structure
8031 outp_names; new enum set OUTP_S_*; new global var
8032 outp_configure_vec; function prototypes for output.c exports
8035 * main.c: (main) Calls outp_read_devices() after parsing the
8038 * cmdline.c: (parse_command_line) New option -v --verbose;
8039 --version changed to -V. --device option changed syntax to just
8040 take a single device name. Accepts key=value declaration of
8041 output init file macros. Syntax message updated.
8043 * filename.c: (expand_line) New function.
8044 (interp_environ_vars) Renamed interp_vars; no longer uses
8046 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
8047 overridden by real environment vars.
8048 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
8049 * filename.h: interp_environ_vars() renamed interp_vars().
8051 * error.c, error.h: Added extern variable `verbosity', message
8054 * error.c: (vmsg) Support message class MM.
8055 (verbose_msg) New function.
8057 * descript.q: (generate_z_varname) Bug fix in generation of
8059 (dump_z_table) Bug fix in column headers.
8061 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
8062 page from 29 to 15. Don't set a default for ops[OPS_INIT,
8063 OPS_DONE]. Writes the uninit string when the driver is closed.
8064 (ascii_open_page) Write the init string before the first page.
8065 (output_shorts) Form of main loop changed from `while' to `for'.
8066 Bug fix with overstrikes: the character is printed *after* the
8067 backspace. Eliminated a lot of `& 0xff' modifiers.
8068 (advance_to_left_margin) New function.
8069 (return_carriage, output_lines) Handle left margin.
8071 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
8073 * ascii.c: New option `carriage-return-style'.
8075 * ascii.c: (count_fancy_chars) New function.
8076 (delineate, text_metrics) Use new function; bug fixes regarding
8078 (text_draw) Bug fix with rich text.
8079 (output_string, output_shorts) Reordered.
8080 (output_shorts) Now handles boxchars and some overstrike font
8082 (output_char, return_carriage) New functions.
8083 (output_lines) Now handles overstriking and font changes properly;
8084 some code moved to output_shorts.
8086 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
8089 * ascii.c: New member `debug' in ascii_driver_ext.
8090 (ascii_init_driver, delineate) Uses new member.
8092 Now you can set a vertical height on writing text.
8093 * ascii.c: (delineate) Keeps track of vertical position.
8094 (text_draw) No longer considers fully justified text an internal
8097 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
8099 Tables' titles are drawn; they can have variable height.
8100 * som.c: `som' struct has new member, title_height.
8101 (draw_title) New argument. Moved within file. All caller
8103 (build_target) New argument, amount of space needed for first row.
8104 Calculates height of title, takes that into account. All callers
8106 (dump_plain_table, dump_columnated_table) Took calculation of y1,
8108 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
8110 (dump_columnated_table) Organized for readability.
8111 (dump_page) Makes use of som.title_height.
8113 * som.c: Many comment bug fixes.
8115 * descript.q: (try_name, generate_z_name) Bug fix regarding
8116 generation of Z-score variable names.
8117 * var.h: Removed num from descriptives_proc; all referents removed.
8119 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
8121 * ascii.c: (ascii_line_horz, ascii_line_vert,
8122 ascii_line_intersection) Added debugging code.
8124 Added a descriptive line above each table to describe it.
8125 * command.c: (parse_cmd) Calls som_new_series.
8127 * som.c: New static vars table_num, subtable_num. New `som'
8129 (dump_page) New arguments.
8130 (som_submit_table) Handle new variables.
8132 * som.c, som.h: (som_submit_table) New arguments. All callers
8134 (som_new_series) New function.
8135 (build_target) Makes room for extra line.
8136 (draw_title) New function.
8137 (dump_page) Calls draw_title. Bug fix: doesn't always set
8140 Columnation of tables support.
8141 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
8143 * som.c: Deleted references to fr, lr, ri.
8144 (som_columnate) Bux fix: sets group member of table.
8145 (som_add_options) Function removed.
8146 (dump_table) Split into three functions; extensively reworked.
8148 * descript.q: (dump_z_table) Better output table formatting; added
8149 title support to correspond to som.h changes.
8150 (display) Title support.
8152 * output.h: Added OUTP_T_NONE.
8154 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
8156 * descript.q: Improved handling of Z scores; still not perfect.
8158 * output.h, ascii.c: Added hook for getting em width of current
8161 * som.c: Uses new em-width hook. Added debugging code to
8163 (som_columnate) New argument.
8164 (som_add_options) Removed.
8166 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
8168 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
8169 rules as a property of the table instead of as a property of the
8172 * ascii.c: Added `header' to table of options.
8174 * descript.q: Added even shorter statistic names; modified to work
8175 with new som interface.
8177 * misc.c (blp_getdelim): Bug fix.
8179 * version.c: includes 'conf.h'.
8181 ----------------------------------------------------------------------
8184 version-control: never