1 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3 * histogram.c chart.[ch] factor_stats.c frequencies.q
5 Added code to calculate sensible histogram ranges and limits.
7 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
9 * chart.h Updated to reflect many API changes.
11 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
12 cartesian.c and into chart.c
14 * factorstats.[ch] Added the histogram calculations
16 * casefile.c Removed an unused variable.
18 * frequencies.q examine.q histogram.c Reworked the API for
21 * piechart.c Revised the API for piecharts.
23 * var.h Moved the definitions of freq_tab and freq out of var.h
24 and into frequencies.q where they belong.
26 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
28 * flip.c: (flip_file) Check for off_t separately from fseeko(),
31 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
33 * flip.c: (flip_file) If fseeko() is not available, use long int
34 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
35 reporting the problem.
37 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
39 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
42 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
44 * var-labs.c (var_to_string) Now returns null if the variable is null
46 * value-labels.c (value_to_string) Made it return null if either the
47 value or the variable is null.
49 * hash.c (hsh_clear) Fixed a buglet.
51 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
54 * casefile.[ch] Added a function to return the casereader.case_idx
57 * examine.q Implemented the extreme values results.
59 John Darrington <john@darrington.wattle.id.au>
61 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
64 Plugged some memory leaks
66 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
68 Adopt GSL random number generators, paving the way for providing
69 the complete suite of random number generators on expressions.
71 * Makefile.am: Remove random.c, random.h.
77 * algorithm.c: (algo_default_random) Use GSL functions.
79 * casefile.c: (test_casefile) Use GSL RNG functions.
81 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
84 * sample.c: (cmd_sample) Use GSL RNG functions.
85 (sample_trns_proc) Ditto.
87 * set.q: (static var set_seed) Removed.
88 (static var seed_flag) Removed.
89 (static var rng) New variable.
90 (aux_stc_custom_seed) No seed value anymore, don't print anything.
91 (stc_custom_seed) Use new seed functions.
92 (seed_is_set) Removed.
93 (get_rng) New function that composes the entire external
95 (set_rng) New function.
96 (random_seed) New function.
98 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
100 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
101 John Darrington <john@darrington.wattle.id.au> for reporting this
104 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
106 * permissions.c command.def Added the PERMISSIONS command
109 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
111 * q2c.c: (dump_header) Don't try to emit #includes at very top of
112 output file because that will precede #include <config.h>, which
114 (main) Add needed headers to /* (header) */ code.
116 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
118 Instead of making system or portable file readers responsible for
119 dropping and reordering variables, make them read full cases and
120 let the caller take care of any changes.
122 * get.c: New "case map" structure to handle this. Use for GET,
123 IMPORT, MATCH FILES. Essentially rewrite the whole file.
125 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
126 changed appropriately.
128 * sfm-read.c: (sfm_read_case) Ditto.
130 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
132 Decided that case_serialize() and case_unserialize() were too
133 abstract. Also we need a couple more functions to avoid excessive
134 copying for data in/out fast paths.
136 * case.c: (case_serial_size) Removed.
137 (case_serialize) Rename case_to_values() and make its argument
138 explicitly an array of union values.
139 (case_unserialize) Rename case_from_values() and make its argument
140 explicitly an array of union values.
141 (case_data_all) New function.
142 (case_data_all_rw) New function.
144 * casefile.c: (struct casefile) Change buffer from array of
145 unsigned char to array of union value for better accuracy.
146 Redefine buffer_used and buffer_size in terms of values, not
147 bytes. Remove case_size because it is now redundant with
148 value_cnt. Fix up all references to these members.
150 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
152 * barchart.c: (struct subcat) Make `label' member const to silence
153 GCC warning with -Wwrite-strings.
155 * cartesian.c: (struct dataset) Ditto.
157 * case.c: Don't re-define NDEBUG if already defined.
158 Add lots of comments.
160 * str.c: Fix includes.
162 * crosstabs.q: Fix includes.
164 * examine.q: Fix includes. Fix GCC warning about unused
167 * frequencies.q: (stat macro) Removed and replaced where used by
170 * list.q: Fix includes.
172 * oneway.q: Fix includes.
174 * piechart.c: Fix includes. Only define M_PI if not already
177 * sfm-read.c: (bswap) New function.
178 (bswap_int32) Write in terms of bswap.
181 * str.c: (ds_data) Add external definition here, needed because
182 str.h has only an `extern inline' version.
184 * value-labels.c: Fix includes.
186 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
188 Instead of providing a system or portable file writer with a raw
189 case in the format needed for output, provide it with a regular
190 case. The writer takes care of any needed translation.
192 * aggregate.c: Adopt new scheme for AGGREGATE.
193 (struct agr_proc) sfm_agr_case member removed.
194 (write_case_to_sfm) Removed because the new interface is easier to
197 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
199 * pfm-write.c: Implement new scheme.
201 * sfm-write.c: Ditto.
203 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
205 Instead of treating `struct file_handle' as a class to subclass
206 into data files, system files, and portable files, instead use it
207 as a helper that coordinates access. Now it is opaque, too.
209 This means that most references to a struct file_handle are now
210 changed into references to one of struct dfm_reader, struct
211 dfm_writer, struct sfm_reader, struct sfm_writer, struct
212 pfm_reader, or struct pfm_writer, according to what's being read
215 Most related changes are only worth summarizing briefly.
217 * dictionary.c: (dict_clear) Destroy aux data in deleted
219 (dict_clear_aux) New function.
220 (dict_create_var) Initialize aux, aux_dtor.
221 (dict_delete_var) Destroy aux data in deleted variable.
223 * file-handle.h: (struct fh_ext_class) Removed.
224 (struct file_handle) Removed.
225 (fh_init_files) Removed.
227 * file-handle.q: Changed references to a handle's `private' member
228 to direct references.
229 (struct private_file_handle) Renamed file_handle.
230 Add next, open_cnt, type, open_mode, aux members.
231 (struct file_handle_list) Removed.
232 (extern var inline_file) Removed.
233 (static var file_handles) Changed from file_handle_list * to
235 (create_file_handle) Initialize new members.
236 (fh_close_handle) Removed.
237 (mode_name) New function.
238 (fh_open) New function.
239 (fh_close) New function.
240 (fh_parse_file_handle) Renamed fh_parse().
242 * glob.c: (init_glob) Remove fh_init_files() call.
244 * aggregate.c: use sfm_writer.
245 (create_sysfile) Removed because the new interface is simpler.
247 * apply-dict.c: Use sfm_reader.
249 * data-list.c: Use dfm_reader.
251 * file-type.c: Use dfm_reader.
253 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
255 * inpt-pgm.c: Use dfm_reader.
257 * print.c: Use dfm_writer.
259 * sysfile-info: Use sfm_reader.
261 * dfm-read.c: Adopt new file handle infrastructure.
263 * dfm-write.c: Ditto.
267 * pfm-write.c: Ditto.
271 * sfm-write.c: Ditto.
273 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
275 Break dictionary functions into separate header file.
277 * dictionary.h: New file.
279 * var.h: Moved dict_*() functions to dictionary.h.
281 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
283 Get rid of procedure-specific union in struct variable, using
284 instead a void * pointer and a destructor function.
286 Most related changes are only worth brief summaries.
288 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
289 old p.crs member in struct variable.
291 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
292 of old p.frq member in struct variable.
294 * histogram.c: (draw_histogram) Takes new freq_tab arg because
295 it's no longer possible to grab this from var->p.frq.
297 * piechart.c: (draw_piechart) Ditto.
299 * group.c: (group_proc_get) New function.
301 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
308 * main.c: (execute_command) Clear aux data in default_dict after
309 each command. (It's debatable whether this should be done.)
311 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
312 member in struct variable.
314 * means.q: Get rid of integer mode, which is not included in
315 recent SPSS and was the only code that wanted per-variable private
318 * var.h: (struct crosstab_proc) Removed.
319 (struct frequencies_proc) Removed.
320 (struct list_proc) Removed.
321 (struct get_proc) Removed.
322 (struct means_proc) Removed.
323 (struct matrix_data_proc) Removed.
324 (struct match_files_proc) Removed.
325 (lots of enums) Removed.
326 (struct variable) Removed members `p', `get'. Add member
329 * vars-atr.c: (var_attach_aux) New function.
330 (var_detach_aux) New function.
331 (var_clear_aux) New function.
332 (var_dtor_free) New function.
333 (discard_variables) Use NULL instead of inline_file.
336 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
338 * value-labs.c Fixed the implmentation of value_to_string, so
339 that it properly handles alpha values.
341 * oneway.q Changed instances where labels were being probed manually,
342 to use the canonical {var,value}_to_string functions
344 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
346 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
347 plots. Changed the API of the cartesian plot to be a much lower level
350 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
352 * examine.q Added some of the parametric calculations
354 * factor_stats.[ch] Created
356 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
358 * examine.q Changed the definition of factors to be a composite, and
359 dealt with the consequences.
361 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
363 * examine.q Fixed problem where examine wasn't dealing properly with
366 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
368 * oneway.q Fixed problem where oneway wasn't dealing properly with
371 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
373 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
374 command which had settings didn't get the appropriate code
377 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
378 to convert variables/values to strings.
380 * examine.q Added framework for the EXAMINE command.
382 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
384 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
385 subcommand types. Changed frequencies.q to use it rather then the
386 custom parser. Dealt with the consequences. Added a test for NTILES
387 subcommand of frequencies.
389 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
391 * oneway.q Fixed up the behaviour when given missing values
393 * levene.c oneway.q Fixed a buglet with the levene statistic and
394 incorporated the levene test into the oneway command.
396 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
397 global scope, since they're only relevant to T-TEST
399 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
401 * group.c group.h group_proc.h levene.c oneway.q t-test.q
403 Made the t-test more consistent
404 with the way it handles groups. That is, it now uses a hash instead
405 of an array of 2. Also, made the levene.c file independent of the
406 implementation of the t-test. So now levene should be fine for both
409 * Added an oneway.q file for one way anova
411 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
413 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
416 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
420 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
421 (data_list_trns_free) Free dls->delims.
423 * t-test.q: (tts_custom_pairs) Free vars.
424 (ssbox_one_sample_init) Fix tab_vline() argument.
425 (ssbox_independent_samples_init) Ditto.
426 (trbox_paired_init) Ditto.
427 (trbox_one_sample_init) Ditto.
429 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
431 Generalize casefiles to the extent that we can use them for
432 sorting and other kinds of data transformations. Change cases to
433 be copy-on-write to improve memory efficiency in common cases.
434 Every access to a member of a `struct ccase' was changed to be a
435 call to a case_*() function, especially case_data(), case_num(),
436 case_str(), or case_data_rw(). Many instances of a local variable
437 named "case_num" were changed to "case_idx" as a consequence.
438 Many `struct ccase *' were changed to actual `struct ccase'
439 because of copying semantics of cases. In several places there
440 was a choice between updating debug code to work with the new ADTs
441 or just deleting it because it was useless; I chose to delete it.
443 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
449 * aggregate.c: (struct agr_proc) Change type of `sort' to
450 sort_criteria *. Add `break_vars', `break_var_cnt' members.
451 Rename `vars' to `agr_vars', all references updated. Change
452 `agr_case' to type `struct ccase'.
453 (cmd_aggregate) Deal with new members. Use case_create(),
454 sort_active_file_in_place(), sort_active_file_to_casefile().
455 (agr_destroy) Deal with new members.
456 (aggregate_single_case) Ditto.
457 (dump_aggregate_info) Ditto.
458 (initialize_aggregate_info) Ditto.
459 (agr_to_active_file) Ditto.
460 (presorted_agr_to_sysfile) Ditto.
461 (sort_agr_to_sysfile) Removed.
463 * alloc.c: (out_of_memory) Make non-static.
465 * alloc.h: Prototype out_of_memory().
467 * casefile.c: Switched from a linked list in-memory representation
468 to a two-level array-style representation. The linked list was
469 appropriate when we could stick a header onto cases, but that's no
470 longer the case. Also, the two-level array will allow for random
471 in-memory access in case that's ever wanted. Also added the
472 concept of a `destructive casereader', one that destroys cases in
473 the underlying casefile as they are read out.
474 (macro CASES_PER_BLOCK) New macro.
475 (struct casefile) New members `value_cnt', `case_list_size',
476 `case_acct_size', `being_destroyed', `cases'. Removed `head',
478 (struct casereader) Removed `cur'. Added `destructive', `c'.
479 (global var casefiles) Made static.
480 (static var case_bytes) New var.
481 (casefile_create) Takes a value count, not a case size in bytes,
482 to conform to the case interface. All callers updated. Deal with
483 new and removed members.
484 (casefile_destroy) Deal with new and removed members.
485 (casefile_sleep) New function.
486 (casefile_get_case_size) Removed.
487 (casefile_get_value_cnt) New function.
488 (casefile_append) Rewritten to deal with new and removed members.
489 (casefile_append_xfer) New function.
490 (write_case_to_disk) Use case_serialize().
491 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
492 Couldn't figure out why.
493 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
494 deal with new and removed members.
496 (merge_sort) Removed.
497 (casefile_sort) Removed.
498 (casefile_get_reader) Deal with new and removed members.
499 (casefile_get_destructive_reader) New function.
500 (reader_open_file) Make code more readable. Create case for
502 (casereader_get_casefile) New function.
503 (casereader_read) Deal with new and removed members. Now returns
504 a copy of the case, so that the caller is responsible for
505 destroying the returned case.
506 (casereader_read_xfer) New function.
507 (casereader_destroy) Destroy reader's case.
508 (test_casefile) Second arg is now a value count, all callers
509 updated. Now tests destructive readers too.
510 (get_random_case) Deal with new case ADT.
511 (write_random_case) Ditto.
512 (read_and_verify_random_case) Ditto.
514 * crosstabs.q: Remove debug code.
516 * descript.q: (calc_descriptives) Deal with new case, casefile
519 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
521 * do-if.c: Remove unneeded header inclusion.
523 * expr-prs.c: Remove debug code.
525 * exprP.h: Remove debug code.
527 * flip.c: (flip_file) Use fseeko() if available.
529 * formats.c: Remove debug code.
531 * get.c: Remove debug code.
532 (struct mtf_file) Change `input' from `union value *' to `struct
533 ccase', all references updated.
535 * levene.c: (levene) Deal with new case, casefile ADTs.
537 * list.q: Remove debug code.
539 * loop.c: Remove debug code.
541 * matrix-data.c: Remove debug code.
543 * means.q: Remove debug code.
545 * mis-val.c: Remove debug code.
547 * pfm-read.c: Remove debug code.
548 (pfm_read_code) Change second arg from `union value *' to `struct
549 ccase *', all references updated.
551 * recode.c: (string_to_long) Make first arg const.
552 (convert_to_double) Ditto.
554 * repeat.c: Remove debug code.
556 * sample.c: Remove debug code.
558 * sfm-read.c: Remove debug code.
559 (sfm_read_case) Change second arg from `union value *' to `struct
562 * sort.c: Redone in terms of casefiles.
563 (enum sort_direction) Moved here from sort.h.
564 (struct sort_criterion) New structure.
565 (struct sort_criteria) New structure.
566 (cmd_sort_cases) Rewritten.
567 (prepare_to_sort_active_file) New function.
568 (sort_active_file_in_place) New function.
569 (sort_active_file_to_casefile) New function.
570 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
571 changed, all callers updated.
572 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
573 rewritten & interface changed, all callers updated.
574 (sort_cases) Renamed sort_execute(), rewritten & interface
575 changed, all callers updated.
576 (struct internal_sort) Removed.
577 (do_internal_sort) Rewritten, interface changed.
578 (destroy_internal_sort) Removed.
579 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
580 (struct initial_run) Removed; an initial run is now just a
582 (compare_initial_runs) Rewritten.
583 (struct external_sort) Changed almost completely.
584 (do_external_sort) Rewritten, interface changed.
585 (destroy_external_sort) Rewritten.
586 [HAVE_MKDTEMP] (make_temp_dir) Removed.
587 [!HAVE_MKDTEMP] (do_mkdir) Removed.
588 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
589 (init_external_sort) Removed.
590 (simulate_error) Removed.
591 (rmdir_temp_dir) Removed.
592 (get_temp_file_name) Removed.
593 (open_temp_file) Removed.
594 (close_temp_file) Removed.
595 (remove_temp_file) Removed.
596 (write_temp_file) Removed.
597 (read_temp_file) Removed.
598 (struct record_run) Change `record' from `struct case_lit *' to
600 (struct initial_run_state) Remove `idx_to_fv', `free_list',
601 `file_idx', `output_file'. Add `run', casefile'. Change
602 `last_output' from `struct case_list *' to `struct ccase'.
603 (write_initial_runs) Change interface, rewrite.
604 (sort_sink_write) Renamed process_case(), changed interfaced,
606 (destroy_initial_run_state) Rewritten.
607 (allocate_cases) Rewritten.
608 (compare_record) Interface changed, rewritten.
609 (start_run) Rewritten.
611 (output_record) Rewritten.
613 (release_case) Removed.
614 (struct merge_case) Change `cases' from double pointer to single
616 (merge) Deal with new case and casefile ADTs.
617 (struct run) Removed.
618 (merge_once) Rewritten, interface changed.
619 (fill_run_buffer) Removed.
620 (sort_sink_make_source) Removed.
621 (sort_sink_class) Removed.
622 (struct sort_source_aux) Removed.
623 (sort_source_read_helper) Removed.
624 (sort_source_read) Removed.
625 (read_sort_output) Removed.
626 (read_internal_sort_output) Removed.
627 (read_external_sort_output) Removed.
628 (sort_source_destroy) Removed.
629 (sort_source_class) Removed.
631 * sort.h: (struct sort_cases_pgm) Removed.
632 (enum sort_direction) Moved to sort.c.
634 * t-test.q: (calculate) Deal with new case, casefile ADTs.
636 * tab.c: Remove debug code.
638 * var-labs.c: Remove debug code.
640 * var.h: (struct ccase) Removed.
641 (struct case_list) Removed.
643 * vars-atr.c: (discard_variables) Use free_case_source().
645 * vars-prs.c: (parse_vs_variable) Make arg const.
646 (parse_dict_variable) Ditto.
647 (parse_variables) Make struct dictionary * arg const.
648 (parse_var_set_vars) Make struct var_set * arg const.
649 (struct var_set) Add const to some of the function pointers' args.
650 (var_set_get_cnt) Make arg const.
651 (var_set_get_var) Make first arg const.
652 (var_set_lookup_var) Make first arg const.
653 (dict_var_set_get_cnt) Make arg const.
654 (dict_var_set_get_var) Make first arg const.
655 (dict_var_set_lookup_var) Make first arg const.
656 (var_set_create_from_dict) Make arg const. Add cast to aux
658 (struct array_var_set) Add const to var member.
659 (array_var_set_get_cnt) Make arg const.
660 (array_var_set_get_var) Make first arg const.
661 (array_var_set_lookup_var) Make first arg const.
662 (var_set_create_from_array) Make first arg const. Insert cast.
664 * vfm.c: (struct write_case_data) Change trns_case, sink_case
665 members from `struct ccase *' to `struct ccase'.
666 (static var lag_queue) Change from double to single pointer.
667 (procedure) Optimize trivial case.
668 (internal_procedure) Deal with changed case, case_source ADTs.
669 (create_trns_case) Changed interface, rewrote.
670 (open_active_interface) Initialize modified lag queue.
671 (write_case) Deal with changed case ADT.
672 (lag_case) Deal with modified lag queue.
673 (close_active_file) Destroy modified lag queue.
674 Deal with changed case_source, case_sink ADTs.
675 (destroy_storage_stream_info) Make null arg into no-op.
676 (storage_sink_make_source) Set aux in created source.
677 (storage_source_read) Deal with changed case, casefile ADTs.
678 (storage_source_create) New function.
679 (lagged_case) Rewrite.
680 (free_case_source) New function.
681 (free_case_sink) Rewrite.
682 (struct split_aux_data) Changed prev_case from `struct ccase *' to
684 (procedure_with_splits) Deal with changed prev_case.
685 (procedure_with_splits_callback) Ditto.
686 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
688 (multipass_procedure_with_splits) Deal with changed prev_case.
689 (multipass_split_callback) Ditto.
692 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
694 The workspace idea didn't work out.
696 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
698 * workspace.c: Removed.
700 * workspace.h: Removed.
702 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
704 Fully implement arbitrary delimiters on DATA LIST, extending the
705 half implementation that was already there.
707 * data-list.c: (struct data_list_pgm) Remove `delim', add
708 `delims', `delim_cnt'.
709 (cmd_data_list) Initialize new members. Parse delimiters and
711 (cut_field) Extract fields with arbitrary delimiters. Also, fix
712 handling of leading commas.
713 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
715 (read_from_data_list_free) Adapt to new DFM interfaces.
716 (read_from_data_list_list) Ditto.
717 (repeating_data_trns_proc) Ditto.
719 * dfm.c: Split up reader and writer into separate code, because
720 they do different things. Use struct string instead of explicit
721 allocation code, for clarity.
722 (enum dfm_reader_flags) New enum.
723 (struct dfm_fhuser_ext) Removed.
724 (struct dfm_reader_ext) New.
725 (get_reader) New function, used by just about all the reader
728 (close_reader) New function.
729 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
730 (dfm_open_for_writing) Ditto.
731 (macro force_line_buffer_expansion) Removed.
732 (count_tabs) Removed.
733 (tabs_to_spaces) Removed.
734 (read_record) Deal with new dfm_reader_ext. Use struct string
735 functions. Don't convert tabs to spaces.
736 (dfm_eof) New function.
737 (dfm_get_record) Changed interface, rewrote.
738 (dfm_expand_tabs) New function.
739 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
740 dfm_reader_ext, rewritten.
741 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
742 dfm_reader_ext, rewritten.
743 (dfm_set_record) Removed in favor of dfm_forward_columns().
744 (dfm_forward_columns) New function.
745 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
746 dfm_reader_ext, rewritten.
747 (static var dfm_r_class) Use close_reader for the destructor.
748 (struct dfm_writer_ext) New.
749 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
750 bounce buffer now instead of local allocation.
751 (close_writer) New function.
752 (static var dfm_writer_ext) Use close_writer for destructor.
753 (cmd_begin_data) Adapt to new dfm_reader_ext.
755 * file-handle.q: Add support for per-file tab width.
756 (struct private_file_handle) Add tab_width member.
757 (q2c specifications) Add tabwidth subcommand.
758 (cmd_file_handle) Put parsed tab width into private_file_handle.
759 (create_file_handle) Set default tab width.
760 (handle_get_tab_width) New function.
762 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
764 * inpt-pgm.c: (reread_trns_proc) Ditto.
766 * matrix-data.c: (context) Ditto.
767 (another_token) Ditto.
771 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
773 * casefile.c: (casefile_destroy) Fix memory leak by freeing
775 (casereader_destroy) Don't close file descriptor -1.
777 * recode.c: (cmd_recode) Fix memory leak.
779 * set.q: (q2c specifications) Fix typo in user message.
781 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
782 undefined behavior for overlapping arguments.
784 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
786 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
787 don't call it when we're running under valgrind.
788 (call_posix_fadvise) New function.
789 (casefile_to_disk) Use call_posix_fadvise().
790 (reader_open_file) Ditto.
792 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
794 Update our string ADTs, struct string and struct len_string. Get
795 rid of pool support, which was largely unused. Rename lots of
796 functions to have more obvious or consistent names.
798 * ascii.c: Get rid of ascii_pool. It was only used for string
800 (ascii_open_global) Don't create ascii_pool.
801 (ascii_close_driver) Don't destroy ascii_pool.
802 (ascii_postopen_driver) Don't use pool.
803 (ascii_close_driver) Destroy strings manually.
805 * str.c: (ds_create) Remove pool argument, all references updated.
807 (ds_replace) Remove pool support, make more efficient when we
808 don't need to reallocate.
809 (ds_destroy) Remove pool support.
810 (ds_rpad) New function.
811 (ds_size) Renamed ds_capacity(), all references updated.
812 (ds_value) Renamed ds_c_str(), all references updated.
813 (ds_concat) Renamed ds_puts(), all references updated.
814 (ds_concat_buffer) Renamed ds_concat(), all references updated.
815 (ds_putchar) Renamed ds_putc(), all references updated.
816 (ds_getline) Renamed ds_gets(), all references updated.
817 (ls_create) Remove pool argument, all references updated.
818 (ls_create_buffer) Ditto.
819 (ls_destroy) Removed pool support.
820 (ls_value) Renamed ls_c_str(), all references updated.
822 * str.h: (ls_length) [__GNUC__] Add inline version.
823 (ls_c_str) [__GNUC__] Add inline version.
824 (ls_end) [__GNUC__] Add inline version.
825 (struct string) Remove pool member. Rename `size' to `capacity',
826 all references updated.
828 * tab.c: (text_format) Instead of using pool argument to
829 ls_create_buffer(), call pool_register() on allocated data.
831 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
833 We're abusing the current ASCII driver by telling it to allocate a
834 9999-line, 9999-character page in the tests. This causes some
835 systems to curl up and die because it allocates 20 MB of
836 contiguous RAM. This change alleviates at least part of the
837 problem. It is mostly a stop-gap until the new output system is
840 * ascii.c: (struct line) New structure.
841 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
842 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
843 (ascii_preopen_driver) Initialize new members, not old ones.
844 (ascii_close_driver) Destroy new members, not old ones.
845 (ascii_open_page) Allocate new members, not old ones.
846 (expand_line) Allocate room in line.
847 (draw_line) Use new members.
848 (ascii_line_horz) Ditto.
849 (ascii_line_vert) Ditto.
850 (ascii_line_intersection) Ditto.
852 (output_lines) Ditto.
853 (ascii_close_page) Ditto.
855 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
857 * matrix.c: Dead code. Removed.
859 * matrix.h: Dead code. Removed.
861 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
863 Contrary to what I'd always understood, there is an efficient
864 algorithm for deletion from a hash table populated via linear
865 probing. This change implements it.
867 * hash.c: (hsh_rehash) Probe in increasing order.
869 (locate_matching_entry) Ditto.
870 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
872 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
874 * moments.c (calc_moments): Adjust calculation of kurtosis to
875 avoid subtracting huge numbers from huge numbers, on Michael
878 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
880 Rework moments routines for improved numerical stability based on
881 Michael Kiefte's advice. Any bugs or remaining numerical problems
882 are still mine though.
884 There is now a struct moments1 for use with one-pass moments. It
885 uses a provisional means algorithm as an attempt to improve
886 accuracy of higher moments. The older struct moments now only
887 handles two-pass moments.
889 * aggregate.c: Use moments1 instead moments.
891 * descript.c: Revert previous change, which is no longer needed
892 due to the moments revision.
894 * moments.c: (calc_moments) New function for calculating variance,
896 (moments_pass_one) Only accumulate weights bigger than zero.
897 (moments_calculate) Allow calculating the mean on pass one, others
898 require pass two. Implement in terms of calc_moments().
899 (struct moments1) New structure.
900 (init_moments1) New function.
901 (moments1_clear) Ditto.
902 (moments1_create) Ditto.
903 (moments1_add) Ditto.
904 (moments1_calculate) Ditto.
905 (moments1_destroy) Ditto.
906 (cmd_debug_moments) Deal with `struct moments' or `struct
907 moments1' as requested by user.
909 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
911 * Makefile.am (pspp_SOURCES): Remove debug.c.
913 * debug.c: Removed. It was empty anyway.
915 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
917 * descript.c (calc_descriptives): Fix assert failure when only
918 MOMENT_MEAN is needed.
920 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
924 fixed problem with parsing in match_statistic() causing
925 "DESCRIPTIVE STAT=MEAN." to barf.
927 "MEAN" is now default if "SORT" given without specification.
929 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
930 generally less forgiving of syntax errors: better to have it do
931 nothing and type it in again then to not know what it actually did
934 z-score transformation now checks score for user-missing values
935 and checks std_dev for SYSMIS.
937 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
939 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
940 Changed dict_get_case_weight() to accept an additional int * flag
941 to complain about system-missing, user-missing, zero, or negative
942 weights and updated existing functions to pass int * to
943 dict_get_case_weight().
945 2004-04-05 jmd <jmd@gnu.org>
947 * main.c: Fixed configuration problems with gsl
949 * t-test.q: Fixed some problems encountered when compiling under Cygwin
951 2004-04-03 blp <blp@gnu.org>
953 * lexer.c, ChangeLog:
954 Fix infinite loop on comment at end of file, add test.
956 2004-04-03 jmd <jmd@gnu.org>
958 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
959 Fixed the calculation of percentiles and added --syntax and --algorithm options
961 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
963 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
966 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
968 * frequencies.q: Fixed the calculation of percentiles
970 * Makefile.am: Added the --ansi flag and dealt with the
971 consequences. Added some entries to PSPP_sources so that
972 make distcheck would pass
974 * cmdline.c: Added the --syntax and --algorithm options
976 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
978 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
980 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
981 use the new multipass_split_... mechanism.
983 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
985 * frequencies.q: (calc_stats) Use moments data structure and
986 calc_seskew(), calc_sekurt() functions.
988 * set.q main.c settings.h Added support for --syntax and --algorithm
991 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
993 * vfm.c: Had to get last call to multipass_split_output() inside
994 open_active_file()/close_active_file() pairing, so introduce new
996 (internal_procedure) Move procedure() code here, except for calls
997 to open_active_file() and close_active_file().
998 (procedure) Wrap open_active_file() and close_active_file() around
999 internal_procedure().
1000 (multipass_procedure_with_splits) Wrap open_active_file() and
1001 close_active_file() around internal_procedure().
1003 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
1005 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
1007 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
1009 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
1011 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
1013 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
1015 * algorithm.c: By default turn off some of the more expensive
1017 (expensive_assert) New macro which expands to assert if
1018 EXTRA_CHECKS is defined, to nothing otherwise.
1019 (unique) Use expensive_assert().
1020 (binary_search) Ditto.
1026 * command.c: (conflicting_3char_prefixes) Words that are the same
1027 don't cause conflicts when they are abbreviated to the first three
1030 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
1031 nonterm_node's n earlier.
1032 (generic_str_func) Ditto.
1034 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
1036 Add support for multipass procedures. Rewrite DESCRIPTIVES to
1037 test multipass support, take advantage of new moments
1038 calculation, and to not be such crappy code. Get rid of q2c
1039 processing for DESCRIPTIVES.
1041 * vfm.c: (struct multipass_split_aux_data) New structure.
1042 (multipass_procedure_with_splits) New function.
1043 (multipass_split_callback) New function.
1044 (multipass_split_output) New function.
1045 * descript.q: Removed.
1047 * descript.c: New file.
1049 * var.h: Removed descriptives enums.
1050 (struct descriptives_proc) Removed.
1051 (struct variable) Removed p.dsc.
1053 * Makefile.am: (q_sources_c) Remove descript.c.
1054 (q_sources_q) Removed descript.q.
1056 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
1058 New manager for keeping track of used workspace.
1060 * workspace.c: New file.
1062 * workspace.h: New file.
1064 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
1066 * sort.c: (do_internal_sort) Use workspace_malloc().
1067 (destroy_internal_sort) Use workspace_free().
1069 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
1071 New `struct casefile' for managing sets of cases.
1073 * casefile.c: New file.
1075 * casefile.h: New file.
1077 * command.def: Add DEBUG CASEFILE command.
1079 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
1081 * sort.c: (sort_cases) Move logic for sending storage file to disk
1082 into do_external_sort().
1083 (struct internal_sort) Use an array of ccase pointers instead of a
1085 (do_internal_sort) Rewrite to handle casefiles.
1086 (compare_case_list) Removed.
1087 (compare_cases) New function.
1088 (compare_case_dblptrs) New function.
1089 (read_internal_sort_output) Deal with new struct internal_sort.
1091 * vfm.c: (static var workspace_overflow) Removed.
1092 (struct storage_stream_info) Removed all the members. Added
1093 struct casefile * member.
1094 (storage_sink_open) Use casefile.
1095 (open_storage_file) Removed.
1096 (write_storage_file) Removed.
1097 (storage_to_disk) Removed.
1098 (destroy_storage_stream_info) Use casefile.
1099 (storage_sink_write) Use casefile.
1100 (storage_sink_make_source) Use casefile.
1101 (storage_source_count) Use casefile.
1102 (storage_source_read) Use casefile.
1103 (storage_source_on_disk) Removed.
1104 (storage_source_get_cases) Removed.
1105 (storage_source_set_cases) Removed.
1106 (storage_source_get_casefile) New function.
1108 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
1110 New `struct moments' for calculating moments.
1116 * moments.c: New file.
1118 * moments.h: New file.
1120 * command.def: Add DEBUG MOMENTS command.
1122 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
1125 * aggregate.c: Modify AGGREGATE to use the new moments
1126 calculation, even if not in such a great way.
1127 (struct agr_var) Add `moments' member.
1128 (parse_aggregate_functions) Set `moments' member to null.
1129 (agr_destroy) Destroy `moments' member.
1130 (accumulate_aggregate_info) Use `moments' for standard deviation.
1131 (dump_aggregate_info) Ditto.
1132 (initialize_aggregate_info) Create or clear `moments'.
1134 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
1135 cube(), pow4() that were in stats.h. All references updated.
1137 * crosstabs.q: stats.h had chi-square significance functions. Use
1139 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
1141 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
1142 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
1144 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
1146 * dictionary.c: (dict_compact_values) Compacted values need to
1149 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
1151 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
1152 `/' at start. Check return value of parse_variables() for error
1155 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
1157 Revamp expressions: make the code a little nicer, and fix bugs
1160 * expr-evl.c: (expr_evaluate) Make expression argument const.
1161 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1162 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
1163 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
1164 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
1165 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
1166 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
1167 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
1168 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
1169 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
1170 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
1171 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
1172 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
1173 Simplify OP_SYSMIS. Remove OP_STR_MIS.
1175 * expr-opt.c: (optimize_expression) Rewrite.
1180 (macro s0l) Removed.
1182 (macro s1l) Removed.
1184 (macro s2l) Removed.
1187 (eq_num_con) New function.
1188 (optimize_tree) New function.
1189 (macro rnc) Removed.
1190 (macro frnc) Removed.
1191 (str_search) Add const to string params.
1192 (str_rsearch) Ditto.
1193 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
1194 str[], str_len[] locals to substitute for most of removed macros.
1195 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1196 Removed support for missing values because we're never called with
1197 missing values. Use set_number() or set_number_errno() instead of
1198 rnc or frnc. Removed any stuff that caused trouble in testing.
1199 We can re-add it later if it really slows anything. Fix some
1201 (evaluate_tree_with_missing) Not yet supported. To be added later
1203 (repl_num_con) Removed.
1204 (collapse_node) New function.
1205 (force_repl_num_con) Removed.
1206 (set_number) New function.
1207 (set_number_errno) New function.
1208 (repl_str_con) Removed.
1209 (set_string) New function.
1210 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
1212 (dump_node) No special case for OP_AND, OP_OR.
1214 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
1215 (expr_get_type) New function.
1216 (type_check) Rewrite.
1217 (type_coercion) New function.
1218 (struct operator) New structure.
1219 (match_operator New function.
1220 (parse_binary_operators) New function.
1221 (parse_inverting_unary_operator) New function.
1222 (parse_or) Rewritten.
1223 (parse_and) Rewritten.
1224 (parse_not) Rewritten.
1225 (parse_rel) Rewritten.
1226 (parse_add) Rewritten.
1227 (parse_mul) Rewritten.
1228 (parse_neg) Rewritten.
1229 (parse_exp) Rewritten.
1230 (parse_sysvar) Add $TRUE, $FALSE system variables.
1231 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
1232 (parse_primary) Use allocate_var_node(), allocate_num_con(),
1234 (struct function) Remove desc, change `func' prototype.
1235 (unary_func) Remove special cases.
1236 (MISSING_func) Reduce to unary_func() that just returns a boolean.
1237 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
1238 (VALUE_func) Use allocate_var_node().
1239 (nary_num_func) Allow MIN and MAX for strings.
1240 Use allocate_var_node(). Properly clean up.
1242 (generic_str_func) Use local table instead of removed `desc'
1243 member. Mostly rewrite.
1244 (get_num_args) Revise error message.
1245 (parse_function) Return EXPR_ERROR, not 0 on error.
1247 (macro varies) Removed.
1248 (ops[]) Use expr.def.
1249 (free_node) Do nothing if node is null.
1250 (allocate_num_con) New function.
1251 (allocate_str_con) New function.
1252 (allocate_var_node) New function.
1253 (allocate_binary_nonterminal) New function.
1254 (append_nonterminal_arg) Removed.
1255 (static var func_tab[]) Revised.
1256 (expr_debug_print_postfix) Make parameter const.
1257 Use printf() instead of debug_printf().
1259 * expr.def: New file.
1261 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
1262 use named enum instead of unnamed, all references updated. Add
1263 EXPR_ANY, EXPR_NO_OPTIMIZE.
1265 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
1266 instead of defining OP_* directly.
1267 (macro IS_TERMINAL) New macro.
1268 (macro IS_NONTERMINAL) New macro.
1269 (enum OP_NO_FLAGS) New.
1271 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
1273 * error.c: (err_assert_fail) msg variable needs to be non-const.
1275 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
1277 * debug.c: (cmd_debug_evaluate) Rewrite.
1279 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
1281 Fix some CROSSTABS bit rot stupidity.
1283 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
1284 (internal_cmd_crosstabs) Initializes cells[] correctly.
1285 (float_M_suffix) Rename format_cell_entry(), change prototype,
1287 (display_crosstabulation) Fix cell formatting.
1289 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
1291 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
1292 to call lex_discard_line() to do that.
1294 * command.c: (run_command) Call lex_discard_line() after
1297 * lexer.c: (lex_entire_end) Change behavior.
1298 (lex_rest_of_line) Change behavior. Return const char *.
1299 (lex_discard_line) Don't clear getl_buf, don't emit message.
1301 * main.c: (handle_error) Emit message here.
1303 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
1304 instead of lex_entire_line().
1306 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
1308 * title.c: (get_title) Call lex_discard_line() after
1310 (cmd_file_label) Ditto.
1311 (cmd_document) Deal with const char * return value.
1313 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
1315 Removed REMARK command.
1317 * command.c: (extract_prefix) Removed.
1318 (output_line) Removed.
1319 (cmd_remark) Removed.
1321 * command.def: Remove REMARK.
1323 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
1325 Added abort() after lots of assert(0) invocations to avoid some
1326 compiler warnings. We really need a NOT_REACHED macro.
1328 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1330 * sort.c: Added missing call to temp_file_close. Changed error
1331 messages to warnings.
1333 * set.q: Improved setting of set_view{length,width} to be more tolerant
1336 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
1338 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
1339 used with incorrect syntax.
1341 * error.c, error.h et al: Overridden definition of assert for a
1344 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
1345 subcommand was given when it ought to have been.
1347 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
1349 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
1353 (tab_joint_text) Ditto.
1355 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
1357 * levene.c: Add #include.
1359 * set.q: (set_viewport) Add `int' argument to make its prototype
1360 correct for signal().
1362 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
1364 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
1367 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
1369 Changed DFM from open-at-first-access to explicit-open. Before,
1370 calling dfm_get_record() or dfm_put_record() would automatically
1371 open the file. Now, you have to call dfm_open_for_reading() or
1372 dfm_open_for_writing() explicitly. This makes it possible to
1373 check permissions, file existence, etc. earlier.
1375 Also made struct file_handle more opaque, and clean up in general.
1377 * data-list.c: (cmd_data_list) Open handle for reading.
1379 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
1381 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
1382 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
1383 (open_inline_file) Removed.
1384 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
1385 it. Deal with line_number in extension record instead of file
1387 (dfm_get_record) Rewrote.
1388 (dfm_put_record) Rewrote.
1389 (dfm_push) Assert file is open and one of ours. Deal with
1390 line_number in extension record instead of file handle.
1391 (dfm_pop) Assert file is open and one of ours. Deal with
1392 line_number in extension record instead of file handle.
1393 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
1396 * file-handle.h: (enum constants RH_RF_*) Removed.
1397 (enum constants FH_MD_*) Removed.
1398 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
1399 `recform', `lrecl', `mode' members. Public references to
1400 `recform' changed to use handle_get_mode(), references to `lrecl'
1401 changed to use handle_get_record_width(). Added `private' member.
1402 (enum file_handle_mode) New.
1404 * file-handle.q: (struct private_file_handle) New structure.
1405 (struct file_handle_list) New structure.
1406 (static var files) New.
1407 (static var file_handles) Removed.
1408 (init_file_handle) Removed.
1409 (create_file_handle) Removed.
1410 (get_handle_with_name) New function.
1411 (get_handle_for_filename) New function.
1412 (cmd_file_handle) Rewritten.
1413 (hash_file_handle) Removed.
1414 (cmp_file_handle) Removed.
1415 (fh_init_files) Rewritten.
1416 (fh_parse_file_handle) Rewritten. Allows identifiers as
1418 (fh_get_handle_by_name) Renamed handle_get_name(), all references
1420 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
1421 references updated. Rewritten.
1422 (fh_record_width) Renamed handle_get_record_width(), all
1423 references updated. Rewritten.
1424 (handle_get_mode) New function.
1426 * file-type.c: (cmd_file_type) Open handle for reading.
1428 * filename.c: [unix] (struct file_identity) New structure.
1429 [unix] (fn_get_identity) New function.
1430 [unix] (fn_free_identity) New function.
1431 [unix] (fn_compare_file_identities) New function.
1432 [!unix] (struct file_identity) New structure.
1433 [!unix] (fn_get_identity) New function.
1434 [!unix] (fn_free_identity) New function.
1435 [!unix] (fn_compare_file_identities) New function.
1437 * lexer.c: (static var put) Renamed put_token, all references
1439 (static var put_tokstr) New.
1440 (static var put_tokval) New.
1441 (lex_init) Initialize put_tokstr().
1442 (restore_token) New function.
1443 (save_token) New function.
1444 (lex_get) Use restore_token().
1445 (lex_put_back) Use save_token().
1446 (lex_put_back_id) New function.
1447 (lex_put_forward) Removed.
1448 (lex_preprocess_line) Set put_token instead of using
1450 (lex_negative_to_dash) Use save_token(), set put_token directly.
1451 (dump_token) Use stderr instead of stdout.
1453 * main.c: (main) Remove call to cmd_init().
1455 * matrix-data.c: (cmd_matrix_data) Open file for reading.
1457 * pfm-read.c: Use handle_get_filename() instead of trying to use
1458 h->fn directly, all over.
1460 * pfm-write.c: Ditto.
1462 * print.c: (internal_cmd_print) Open handle for writing.
1463 (dump_table) Use handle_get_filename().
1464 (print_trns_proc) Use handle_get_mode().
1465 (cmd_print_space) Use fh_parse_file_handle().
1466 Open handle for writing.
1467 [0] (debug_print) Removed.
1469 * sfm-read.c: Use handle_get_filename() instead of trying to use
1470 h->fn directly, all over.
1472 * sfm-write.c: Ditto.
1474 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
1478 * autorecode.c: (arc_free) Free arc->src_values.
1480 * error.c: (msg) Free buf.
1482 * val-labs.c: (do_value_labels) Always free vars.
1484 * vfm.c: (close_active_file) If sink has no make_source then call
1485 its destroy function.
1487 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
1489 Fixed cmd_parse() so that it always skips past a full command
1490 name. A few special commands for which this would be bad get
1491 special treatment. This lets us drop code for skipping past the
1492 end of a command name in most cmd_*() functions. It's not worth
1493 listing all the commands affected.
1495 * command.c: (struct command) Remove `cmd' member, replace by
1496 `name' member, all references updated. Remove `word', `next',
1497 `skip_entire_name' members.
1498 (macro DEFCMD) Deal with revised `struct command'.
1499 (macro UNIMPL) Ditto.
1500 (macro SPCCMD) New macro for commands whose last word shouldn't be
1502 (static array cmd_table[]) Make const, rename `commands', remove
1504 (macro COMMAND_CNT) New macro.
1505 (split_words) Removed.
1507 (FILE_TYPE_okay) Make parameter const.
1508 (cmd_parse) Improve error messages.
1509 (match_strings) New function.
1510 (next_word) New function.
1511 (enum command_match) New enum.
1512 (conflicting_3char_prefixes) New function.
1513 (conflicting_3char_prefix_command) New function.
1514 (cmd_match_words) New function.
1515 (count_matching_commands) New function.
1516 (get_command_name) New function.
1517 (free_words) New function.
1518 (unknown_command_error) New function.
1519 (figure_out_command) Renamed parse_command_name(), rewritten.
1521 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
1522 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
1523 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
1526 * command.h: (macro SPCCMD) New.
1528 * include.c: (cmd_include_at) Removed.
1529 (cmd_include) Allow identifier to be used as filename.
1531 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
1533 * t-test.q: (cmd_t_test) Command name is now parsed for us.
1536 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
1538 Start work on better test framework.
1540 * Makefile.am: (pspp_sources) Add debug.c.
1542 * debug.c: New file.
1544 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
1545 cmd_debug_evaluate().
1547 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
1549 * expr.h: (enum constant PXP_DUMP) Removed.
1551 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
1553 * set.q: Implemented the SHOW command, and synced it to the existing
1556 Added a handler for SIGWINCH so that viewlength and viewwidth follow
1557 changes as the window size is changed.
1559 Added fallback to set viewlength and viewwidth from LINES and COLUMS
1560 environment variables if other methods are not available.
1562 glob.c: Removed a lot of global variables from glob.c and encapsulated
1565 random.c: Tidied up the way the random seed is set.
1567 str.c: Added a ds_vprintf function.
1569 error.c: Extended dump_message so that messages are always broken at
1572 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
1574 * pfm-write.c: (bufwrite) Write out the correct element for string
1575 variables. From Andreas Streichardt <streichardt@globalpark.de>.
1577 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
1579 Get rid of static and global (!) vars in matrix-data.c.
1581 * matrix-data.c: (static var nr_data) Removed.
1582 (static var nr_factor_values) Removed.
1583 (static var max_cell_index) Removed.
1584 (static var split_values) Removed.
1585 (struct nr_aux_data) New structure.
1586 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
1587 place of static vars, pass to create_case_source() and procedure()
1589 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
1590 struct matrix_data_pgm *.
1591 (nr_read_splits) Ditto.
1592 (nr_read_factors) Ditto.
1593 (nr_output_data) Ditto.
1594 (static var wr_content) Removed.
1595 (global var wr_data) Removed.
1596 (global var wr_current) Removed.
1597 (struct wr_aux_data) New structure.
1598 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
1599 place of static vars, pass to create_case_source() and procedure()
1601 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
1602 instead of matrix_data_pgm *.
1603 (wr_read_splits) Ditto.
1604 (wr_output_data) Ditto.
1605 (wr_read_rowtype) Ditto.
1606 (wr_read_factors) Ditto.
1607 (wr_read_indeps) Ditto.
1609 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
1611 Get rid of static vars in autorecode.c.
1613 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
1614 `n_arc' to `spec_cnt'. All references updated.
1615 (static var v_src) Removed.
1616 (static var v_dest) Removed.
1617 (static var h_trns) Removed.
1618 (static var nv_src) Removed.
1619 (static var descend) Removed.
1620 (static var print) Removed.
1621 (enum direction) New enum.
1622 (struct autorecode_pgm) New structure.
1623 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
1624 Move n_dest local var into struct autorecode_pgm for ease of
1625 clean-up. Use arc_free().
1626 (arc_free) New function.
1627 (recode) Modify to take struct autorecode_pgm * parameter instead
1628 of using statics. Let the caller clean up.
1629 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
1630 instead of statics. Rearrange code a little.
1632 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
1634 Get rid of static, global vars in recode.c. Remove debug code.
1636 * recode.c: (static var head) Removed.
1637 (global var v) Removed.
1638 (global var nv) Removed.
1639 (cmd_recode) New local variables head, v, nv. Initialize and free
1640 v. Don't call debug_print().
1641 [DEBUGGING] (dump_dest) Removed.
1642 [DEBUGGING] (debug_print) Removed.
1644 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
1646 Get rid of static vars in expr-opt.c.
1648 * expr-opt.c: (static var e) Removed.
1649 (static var nop) Removed.
1650 (static var mop) Removed.
1651 (static var ndbl) Removed.
1652 (static var mdbl) Removed.
1653 (static var nstr) Removed.
1654 (static var mstr) Removed.
1655 (static var nvars) Removed.
1656 (static var mvars) Removed.
1657 (struct expr_dump_state) New structure.
1658 (dump_expression) Use new struct expr_dump_state instead of static
1659 vars and pass to functions we call.
1660 (dump_node) Use struct expr_dump_state * parameter.
1662 (emit_num_con) Ditto.
1663 (emit_str_con) Ditto.
1666 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
1668 Get rid of static var in COUNT.
1670 * count.c: (static var head) Move into cmd_count().
1671 (cmd_count) [DEBUGGING] Don't call debug_print.
1672 [DEBUGGING] (debug_print) Removed.
1674 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
1676 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
1678 * val-labs.c: (static var v) Removed.
1679 (static var nv) Removed.
1680 [DEBUGGING] (debug_print) Removed.
1681 (verify_val_labs) Add struct variable **, int parameters.
1682 (get_label) Ditto. Improve error messages, streamline.
1683 (erase_labels) New function for erasing value labels, taking over
1684 part of verify_val_labs()'s function.
1687 (cmd_value_labels) No need to call init() or done() anymore.
1688 (cmd_add_value_labels) Ditto.
1689 (do_value_labels) Add vars, var_cnt local variables. Clean up
1690 after them internally. Call erase_labels() if we should. Don't
1693 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
1695 Get rid of static vars in MATCH FILES.
1697 * get.c: (static var mtf_head) Removed.
1698 (static var mtf_tail) Removed.
1699 (static var mtf_by) Removed.
1700 (static var mtf_n_by) Removed.
1701 (static var mtf_master) Removed.
1702 (static var mtf_seq_num) Removed.
1703 (static var mtf_seq_nums) Removed.
1704 (static var mtf_sink) Removed.
1705 (static var mtf_case) Removed.
1706 (struct mtf_proc) New structure.
1707 (cmd_match_files) Use struct mtf_proc instead of static vars.
1708 (mtf_processing_finish) Ditto.
1710 (mtf_delete_file_in_place) Ditto.
1711 (mtf_read_nonactive_records) Ditto.
1712 (mtf_compare_BY_values) Ditto.
1713 (mtf_processing) Ditto.
1714 (mtf_merge_dictionary) Ditto.
1716 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
1718 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
1720 * dictionary.c: (dict_rename_var) Add assertion.
1721 (dict_contains_var) Check by index instead of name.
1723 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
1725 Get rid of compaction_necessary, compaction_nval, compaction_case.
1726 Redo VFM interface. Replace disk_sink and memory_sink by
1727 storage_sink, disk_source and memory_source by storage_source.
1729 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
1733 (struct write_case_data) Remove `begin_func', `end_func',
1734 `func_aux' members. Add `aux', `trns_case', `sink_case',
1735 `cases_written', `cases_analyzed' members.
1736 (global var compaction_necessary) Make static.
1737 (global var compaction_nval) Removed.
1738 (global var compaction_case) Removed.
1739 (static var case_count) Removed.
1740 (struct procedure_aux_data) Removed.
1741 (struct split_aux_data) Removed.
1742 (procedure) Remove begin_func, end_func parameters. Rewrite.
1743 (static var not_canceled) Removed.
1744 (process_active_file) Removed.
1745 (process_active_file_write_case) Removed.
1746 (process_active_file_output_case) Removed.
1747 (prepare_for_writing) Moved into open_active_file().
1748 (arrange_compaction) Ditto.
1750 (open_active_file) Rewrote.
1751 (write_case) New function.
1752 [DEBUGGING] (index_to_varname) Removed.
1753 (execute_transformations) New function.
1754 (exclude_this_case) Renamed filter_case(), changed interface.
1755 (clear_case) Added struct ccase * parameter to interface.
1756 (close_active_file) Added struct write_case_data * parameter,
1758 (disk_sink_create) Removed.
1759 (disk_sink_destroy) Removed.
1760 (disk_sink_make_source) Removed.
1761 (disk_sink_write) Removed.
1762 (disk_source_count) Removed.
1763 (disk_source_destroy) Removed.
1764 (disk_source_read) Removed.
1765 (global var disk_sink_class) Removed.
1766 (global var disk_source_class) Removed.
1767 (global var memory_sink_class) Removed.
1768 (global var memory_source_class) Removed.
1769 (memory_sink_create) Removed.
1770 (memory_sink_destroy) Removed.
1771 (memory_sink_make_source) Removed.
1772 (memory_sink_write) Removed.
1773 (memory_source_count) Removed.
1774 (memory_source_destroy) Removed.
1775 (memory_source_get_cases) Removed.
1776 (memory_source_read) Removed.
1777 (memory_source_set_cases) Removed.
1778 (struct disk_stream_info) Removed.
1779 (struct memory_sink_info) Removed.
1780 (struct memory_source_info) Removed.
1781 (write_active_file_to_disk) Removed.
1782 (destroy_storage_stream_info) New function.
1783 (global var null_sink_class) New var.
1784 (global var storage_sink_class) New var.
1785 (global var storage_source_class) New var.
1786 (open_storage_file) New function.
1787 (storage_sink_destroy) New function.
1788 (storage_sink_make_source) New function.
1789 (storage_sink_open) New function.
1790 (storage_sink_write) New function.
1791 (storage_source_count) New function.
1792 (storage_source_destroy) New function.
1793 (storage_source_get_cases) New function.
1794 (storage_source_on_disk) New function.
1795 (storage_source_read) New function.
1796 (storage_source_set_cases) New function.
1797 (storage_source_to_disk) New function.
1798 (storage_to_disk) New function.
1799 (struct storage_stream_info) New structure.
1800 (write_storage_file) New function.
1801 (procedure_write_case) Removed.
1802 (create_case_source) Add `struct dictionary *' parameter, all
1804 (create_case_sink) Ditto.
1805 (free_case_sink) New function.
1806 (struct split_aux_data) New structure.
1807 (procedure_with_splits) New function implementing what procedure()
1809 (SPLIT_FILE_proc_func) Removed.
1810 (procedure_with_splits_callback) New function.
1811 (equal_splits) New function.
1813 * aggregate.c: Pass around a struct instead of using statics.
1814 (static var outfile) Remove.
1815 (enum type) Give it tag `missing_treatment'.
1816 (static var missing) Remove.
1817 (static var sort) Remove.
1818 (static var agr_first) Remove.
1819 (static var agr_next) Remove.
1820 (static var case_count) Remove.
1821 (static var prev_case) Remove.
1822 (static var buf64_1xx) Remove.
1823 (static var buf_1xx) Remove.
1824 (struct agr_proc) New structure incorporating the above.
1825 (cmd_aggregate) Use new struct. Clean up error handling using
1826 agr_destroy(). Completely rewrite actual implementation of
1828 (create_sysfile) Add struct agr_proc * parameter, modify
1830 (parse_aggregate_functions) Ditto.
1831 (free_aggregate_functions) Ditto. Rename agr_destroy().
1832 (aggregate_single_case) Add struct agr_proc * parameter, modify
1834 (accumulate_aggregate_info) Ditto.
1835 (dump_aggregate_info) Ditto.
1836 (initialize_aggregate_info) Ditto.
1837 (agr_00x_trns_proc) Removed.
1838 (agr_00x_end_func) Removed.
1839 (agr_10x_trns_proc) Removed.
1840 (agr_10x_trns_free) Removed.
1841 (agr_10x_end_func) Removed.
1842 (agr_11x_read) Removed.
1843 (agr_11x_finish) Removed.
1844 [DEBUGGING] (debug_print) Removed.
1845 (write_case_to_sfm) Add struct agr_proc * parameter, modify
1847 (agr_to_active_file) New function.
1848 (presorted_agr_to_sysfile) New function.
1849 (sort_agr_to_sysfile) New function.
1851 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
1853 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
1855 * descript.q: (cmd_descriptives) Ditto.
1857 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
1858 to new procedure() interface.
1860 * command.c: (cmd_execute) Adapt to new procedure() interface.
1862 * dictionary.c: (dict_compact_values) Also delete scratch
1864 (dict_get_compacted_value_cnt) New function.
1865 (dict_get_compacted_idx_to_fv) New function.
1867 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
1868 (cmd_flip) Adapt to new procedure() interface.
1869 (flip_sink_write) Use sink->idx_to_fv.
1871 * frequencies.q: (internal_cmd_frequencies) Use
1872 procedure_with_splits().
1874 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
1875 (static var mtf_sink) New static var.
1876 (static var mtf_case) New static var.
1877 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
1878 we actually implement the matching.
1879 (mtf_delete_file_in_place) Use mtf_case.
1880 (mtf_processing) Use mtf_case and mtf_sink.
1881 (cmd_export) Adapt to new procedure() interface.
1883 * levene.c: (levene) Use procedure_with_splits().
1885 * list.q: (cmd_list) Use procedure_with_splits().
1887 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
1888 procedure() interface.
1889 (read_matrices_with_rowtype) Ditto.
1891 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
1892 TEMPORARY. Adapt to new procedure() interface.
1894 * rename-vars.c: Warn about and cancel TEMPORARY.
1896 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
1897 (sort_cases) Use dict_get_compacted_value_cnt() instead of
1898 compaction_nval. Adapt to new procedure() interface. Use
1899 storage_source_to_disk().
1900 (do_internal_sort) Don't try to dump the cases to memory.
1901 (compare_case_lists) Pass null idx_to_fv.
1902 (struct initial_run_state) Add `idx_to_fv' member. Remove
1904 (write_initial_runs) Don't initialize irs->case_size. Adapt to
1905 new procedure() interface. Reset irs->idx_to_fv after calling
1907 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
1908 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
1910 (destroy_initial_run_state) Don't dereference irs after freeing
1912 (allocate_cases) Don't calculate case_size locally.
1913 (compare_record) Add idx_to_fv parameter.
1914 (compare_record_run) Change parameter from struct sort_cases_pgm *
1915 to struct initial_run_state *. Pass irs->idx_to_fv to
1917 (compare_record_run) Third parameter now a struct
1918 initial_run_state *.
1919 (output_record) No need for out_case anymore. Pass irs, not
1920 struct sort_cases_pgm to pop_heap(). Use case_size from struct
1922 (merge) Use case_size from struct sort_cases_pgm.
1923 (merge_once) Use case_size from struct sort_cases_pgm.
1924 Pass null pointer to compare_record() as idx_to_fv.
1925 (global var sort_sink_class) Make static.
1927 * t-test.q: (cmd_t_test) Use procedure_with_splits().
1929 * temporary.c: Remove debugging crap.
1931 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
1933 * t-test.q, levene.c: Fixed up the handling of MISSING values
1936 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
1938 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
1941 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
1943 Change explicit variable name checks into use of
1944 dict_class_from_id().
1946 * dictionary.c: (dict_create_var) Change explicit variable name
1947 check into use of dict_class_from_id().
1949 * get.c: (trim_dictionary) Ditto.
1951 * sel-if.c: (cmd_filter) Ditto.
1953 * sysfile-info.c: (cmd_display) Ditto.
1955 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
1957 * vfm.c: (arrange_compaction) Ditto.
1959 * weight.c: (cmd_weight) Ditto.
1961 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
1963 * temporary.c: (cmd_temporary) When TEMPORARY was the first
1964 transformation following the input program, if any, for some
1965 reason we special-cased f_trns. That's just wrong. It should
1966 always be set to n_trns.
1968 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
1970 * format.c: (parse_format_specifier_name) Fix brown-bag bug
1971 introduced in last check-in.
1973 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
1975 * format.c: (global array translate_fmt[]) Removed.
1976 (translate_fmt) New function as replacement.
1977 (parse_format_specifier_name) Rewrite.
1979 * pfm-read.c: (convert_format) Use translate_fmt() instead of
1982 * sfm-read.c: (parse_format_spec) Ditto.
1984 * postscript.c: (text) Fix handling of fonts with missing
1987 * sort.c: (struct external_sort) Add temp_name member.
1988 (destroy_external_sort) Free temp_dir, temp_name members.
1989 (init_external_sort) Allocate temp_name.
1990 (get_temp_file_name) Change prototype.
1991 (open_temp_file) Deal with change to get_temp_file_name().
1992 (close_temp_file) Ditto.
1993 (remove_temp_file) Ditto.
1994 (write_temp_file) Ditto.
1995 (read_temp_file) Ditto.
1996 (sort_sink_destroy) Removed.
1997 (sort_sink_class) Change destroy member to null.
1999 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
2001 Eliminate temp_case.
2003 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
2004 anymore. Use agr_11x_finish().
2005 (aggregate_single_case) Make first param const.
2006 (accumulate_aggregate_info) Ditto.
2007 (agr_00x_end_func) Use compaction_case, not temp_case.
2008 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
2010 * data-list.c: (struct data_list_pgm) Add `case_size' member.
2011 (cmd_data_list) Initialize case_size.
2012 (read_from_data_list_fixed) Add struct ccase * param, use instead
2014 (read_from_data_list_free) Ditto.
2015 (read_from_data_list_list) Ditto.
2016 (read_one_case) Rename data_list_trns_proc(), all references
2017 updated. Add argument in calling above functions. Use c
2018 argument instead of temp_case.
2019 (destroy_dls) Rename data_list_trns_free(), all references
2022 * expr-evl.c: (expr_evaluate) Make second parameter const.
2024 * file-type.c: (struct file_type_pgm) Add `case_size' member.
2025 (cmd_end_file_type) Initialize `case_size'.
2026 (file_type_source_read) Add struct ccase * parameter. Use instead
2029 * flip.c: Rewritten.
2031 * get.c: (struct get_pgm) New structure to keep track of
2033 (cmd_get) Initialize case_size.
2035 (get_source) Deal with struct get_pgm.
2036 (get_source_read) Add struct ccase * parameter, use instead of
2038 (import_source_read) Ditto.
2040 * get.c: Use a null pointer instead of temp_case to represent the
2041 "current case" in a struct mtf_file's input member.
2042 (mtf_processing_finish) Pass null to mtf_processing(), not
2044 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
2045 (mtf_compare_BY_values) Add extra arg, use instead of null input
2047 (mtf_processing) Use c parameter instead of temp_case. Pass
2048 compaction_case to process_active_file_output_case().
2050 * glob.c: (global variable temp_case) Removed.
2052 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
2053 (cmd_input_program) Initialize case_size. Set
2054 vfm_source->value_cnt.
2055 (init_case) Add struct ccase * parameter, use instead of
2058 (input_program_source_read) Ditto.
2060 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
2061 (dump_cell_content) Ditto.
2062 (nr_output_data) Ditto.
2063 (read_matrices_without_rowtype) Ditto.
2064 (matrix_data_read_with_rowtype) Ditto.
2065 (wr_read_splits) Ditto.
2066 (wr_output_data) Ditto.
2068 * sort.h: (struct sort_cases_pgm) New member `case_size'.
2070 * sort.c: (sort_cases) Initialize scp->case_size.
2071 (struct external_sort) Remove `case_size' member.
2072 (write_initial_runs) Only call vfm_sink->class_destroy if
2074 (struct sort_source_aux) New structure.
2075 (sort_source_read_helper) New function.
2076 (sort_source_read) Use sort_source_read_helper().
2077 (read_sort_output) Change interface to be more reasonable.
2078 (read_internal_sort_output) Ditto.
2079 (read_external_sort_output) Ditto.
2081 * vars-prs.c: (dict_class_to_name) Pass return value through
2084 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
2085 (procedure) Initialize trns_case.
2086 (procedure) Pass trns_case to vfm_source->class->read().
2088 (process_active_file) Start using struct procedure_aux_data.
2089 (process_active_file_write_case) Pass trns_case to
2090 transformations, lag_case(), clear_case().
2091 (process_active_file_output_case) Add struct ccase * parameter.
2092 (create_trns_case) New function.
2093 (make_temp_case) Removed.
2094 (vector_initialization) Removed.
2095 (close_active_file) Only call make_source if non-null, otherwise
2096 set vfm_source to null pointer. Don't free temp_case.
2097 (disk_source_read) Add struct ccase * parameter, use instead of
2099 (memory_source_read) Ditto.
2100 (lag_case) Add const struct ccase * member.
2101 (procedure_write_case) Use trns_case instead of temp_case.
2102 (clear_case) Add struct ccase * member, use instead of temp_case.
2103 (exclude_this_case) Ditto.
2104 (create_case_source) Add struct dictionary * parameter, use to
2105 initialize source->value_cnt.
2107 * vfm.h: (struct case_source) Add `value_cnt' member.
2108 (struct case_source_class) Add struct ccase * parameter to `read'
2109 member function pointer.
2110 (struct case_sink_class) Make struct ccase * parameter const in
2111 `write' member function pointer.
2113 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
2115 Fix a lot of "possibly uninitialized variable" warnings. Some of
2116 them are even real bugs. A few of them make me wonder how the
2119 * aggregate.c: (parse_aggregate_functions) Initialize `function.
2121 * ascii.c: (output_lines) Add default case to switch.
2123 * crosstabs.q: Remove static variable `expected' and all
2125 (display_crosstabulation) Always calculate expected value.
2127 (output_pivot_table) Initialize `cmp'.
2128 (display_crosstabulation) New variable `last_row', which is
2131 * data-in.c: (parse_numeric) Always initialize sign. How did this
2134 * data-list.c: (repeating_data_trns_proc) Always initialize code.
2135 Always set info.ofs. (How did this work?!)
2137 * expr-opt.c: (optimize_tree) Always initialize `m'.
2138 (evaluate_tree) Always initialize `c'. (How did this work?)
2140 * frequencies.q: (frq_custom_variables) Always initialize min,
2142 (frq_custom_grouped) Always initialize `dl'.
2144 * groff-font.c: (groff_read_font) Always initialize char_set.
2146 * matrix-data.c: (nr_output_data) Initialize `split'.
2147 (wr_read_splits) Remove shadowing split_cnt declaration.
2148 (wr_output_data) Initialize `split'.
2150 * output.c: (tokener) Skip add character on syntax error.
2152 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
2154 * postscript.c: (read_ps_encodings) Use line.string instead of
2156 (write_text) Add default case to switch.
2157 (text) Always initialize multiple variables. Fix bug with
2160 * print.c: (fixed_parse_fortran) Initialize head.
2161 (alloc_line) Add default case to switch.
2163 * recode.c: (parse_dest_spec) Handle case where nothing matches.
2164 (recode_trns_proc) Move variable declaration inward. Add default
2167 * sfm-read.c: (read_header) Initialize skip_amt.
2169 * sysfile-info.c: (display_variables) Always initialize pc.
2171 * vars-prs.c: Initialized `included'.
2173 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
2175 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
2176 Just use signal() instead.
2178 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
2180 Get rid of vfm_sink_info and vfm_source_info.
2182 * aggregate.c: (agr_00x_end_func) Don't increment
2183 sfm_sink_info.ncases.
2185 * sort.c: (do_internal_sort) Get case count from
2186 vfm_source->class->count().
2187 (struct external_sort) Add `case_size' member.
2188 (do_external_sort) Initialize case_size.
2189 (struct initial_run_state) Add `case_size' member.
2190 (write_initial_runs) Initialize case_size.
2191 (sort_sink_write) Use case_size.
2192 (read_external_sort_output) Use case_size. Get case_cnt from
2195 * vfm.c: (struct write_case_data) Add underscores to existing arg
2196 names, all references updated. Renamed `aux' as `func_aux', all
2197 references updated. Added new `aux' member.
2198 (global var vfm_source_info) Removed.
2199 (global var vfm_sink_info) Removed.
2200 (struct procedure_aux_data) New.
2201 (struct split_aux_data) New.
2202 (procedure) Use `aux' fields for procedure_aux_data,
2204 (process_active_file_write_case) Pass case_count + 1 to
2205 transformation procedures, exclude_this_case().
2206 (process_active_file_output_case) Don't increment
2207 vfm_sink_info.ncases.
2208 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
2209 to send data to disk early.
2210 (make_temp_case) Don't use vfm_sink_info.case_size.
2211 (close_active_file) Don't initialize vfm_source_info.
2212 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
2213 (disk_sink_create) Initialize and/or update disk_stream_info.
2214 (disk_sink_write) Ditto.
2215 (disk_sink_destroy) Ditto.
2216 (disk_sink_make_source) Ditto.
2217 (disk_source_read) Ditto.
2218 (disk_source_destroy) Ditto.
2219 (global var disk_source_class) Add disk_source_count().
2220 (disk_source_count) New function.
2221 (struct memory_sink_info) Add `case_cnt', `case_size' members.
2222 (struct memory_source_info) Ditto.
2223 (memory_sink_create) Deal with case_cnt, case_size.
2224 (memory_sink_write) Ditto.
2225 (memory_sink_make_source) Ditto.
2226 (memory_source_read) Ditto.
2227 (memory_source_count) New function.
2228 (memory_source_class) Add memory_source_count().
2229 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
2230 proc_aux->cases_written, and pass it to transformation procedures
2231 and exclude_this_case ().
2232 (exclude_this_case) Add case_num parameter. Pass it to
2234 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
2237 * vfm.h: (struct case_source_class) Add `count' member.
2239 * vfmP.h: (struct stream_info) Removed.
2240 (global variable vfm_source_info) Removed.
2241 (global variable vfm_sink_info) Removed.
2243 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
2245 * var.h: (typedef trns_proc_func) New typedef.
2246 (trns_free_func) New typedef.
2247 (struct trns_header) Change `proc' to type trns_proc_func, `free'
2248 to type trns_free_func. This only changes the actual type of
2249 trns_proc_func, adding a `case_num' parameter. Updated all
2250 implementations to use the typedefs instead.
2252 * compute.c: (compute_num) Pass case_num to expr_evaluate().
2253 (compute_num_vec) Ditto.
2254 (compute_str) Ditto.
2255 (compute_str_vec) Ditto.
2257 * do-if.c: (do_if_trns_proc) Ditto.
2259 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
2262 * inpt-pgm.c: (input_program_source_read) Maintain case count,
2263 pass to transformation functions.
2264 (reread_trns_proc) Pass case_num arg to expr_evaluate().
2266 * loop.c: (loop_1_trns_proc) Ditto.
2267 (loop_2_trns_proc) Ditto.
2268 (loop_3_trns_proc) Ditto.
2270 * print.c: (print_space_trns_proc) Ditto.
2272 * sel-if.c: (select_if_proc) Ditto.
2274 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
2276 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
2277 destroying hash table.
2279 * glob.c: (read_active_file) Variable not referenced, removed.
2280 (cancel_input_pgm) Ditto.
2282 * levene.c: Add #include <stdlib.h> needed to call free().
2284 * aggregate.c: (parse_aggregate_functions) Make `function'
2287 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
2289 Start working to eliminate VFM dependence on static variables.
2291 * command.c: (cmd_parse) Use case_source_is_class().
2293 * data-list.c: Rewrite to eliminate use of static variables.
2295 * dfm.c: (cmd_begin_data) Use case_source_is_class().
2297 * file-handle.q: (fh_handle_name) Make parameter const.
2299 * file-type.c: Rewrite to eliminate use of static variables.
2301 * flip.c: Rewrite to eliminate use of static variables.
2303 * format.c: (get_format_var_width) New function.
2305 * get.c: Eliminate use of static variables.
2307 * inpt-pgm.c: Eliminate use of static variables.
2309 * matrix-data.c: Eliminate use of static variables.
2311 * set.q: (set_max_workspace) New variable.
2312 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
2314 * var.h: (struct case_list) Move here from vfmP.h.
2316 * vars-atr.c: (discard_variables) Handle new vfm_source type.
2318 * vfm.c: (vfm_source) Change type from struct case_stream to
2320 (vfm_sink) Change type from struct case_stream to struct
2322 (static var paging) Rename workspace_overflow, all references
2324 (procedure) Use new class structures.
2325 (process_active_file) Ditto.
2326 (process_active_file_write_case) Ditto.
2327 (prepare_for_writing) Use set_max_workspace. Use new class
2329 (close_active_file) Use new class structures. Free old sink.
2330 (global var disk_source_file) Removed.
2331 (global var disk_sink_file) Removed.
2332 (disk_stream_init) Removed.
2333 (disk_stream_read) Removed.
2334 (disk_stream_write) Removed.
2335 (disk_stream_mode) Removed.
2336 (disk_stream_destroy_source) Removed.
2337 (disk_stream_destroy_sink) Removed.
2338 (global var vfm_disk_stream) Removed.
2339 (disk_sink_create) New function.
2340 (disk_sink_write) New function.
2341 (disk_sink_destroy) New function.
2342 (disk_sink_make_source) New function.
2343 (disk_sink_class) New static var.
2344 (disk_source_read) New function.
2345 (disk_source_destroy) New function.
2346 (global var vfm_source_class) New var.
2347 (global var memory_source_cases) Removed.
2348 (global var memory_sink_cases) Removed.
2349 (global var memory_sink_max_cases) Removed.
2350 (struct memory_sink_info) New struct.
2351 (memory_stream_init) Removed.
2352 (memory_stream_read) Removed.
2353 (memory_stream_write) Removed.
2354 (memory_stream_mode) Removed.
2355 (memory_stream_destroy_source) Removed.
2356 (memory_stream_destroy_sink) Removed.
2357 (global var vfm_memory_stream) Removed.
2358 (page_to_disk) Renamed write_active_file_to_disk().
2359 (memory_sink_create) New function.
2360 (memory_sink_write) New function.
2361 (memory_sink_destroy) New function.
2362 (memory_sink_make_source) New function.
2363 (memory_sink_class) New static var.
2364 (memory_source_read) New function.
2365 (memory_source_destroy) New function.
2366 (memory_source_get_cases) New function.
2367 (memory_source_set_cases) New function.
2368 (global var vfm_source_class) New var.
2369 (procedure_write_case) Use new class structures.
2370 (create_case_source) New function.
2371 (case_source_is_complex) New function.
2372 (case_source_is_class) New function.
2373 (create_case_sink) New function.
2375 * vfm.h: (global variable reinit_sysmis) Not used, removed.
2376 (global variable reinit_blanks) Not used, removed.
2377 (global variable init_zero) Not used, removed.
2378 (global variable init_blanks) Not used, removed.
2379 (struct case_source) New struct.
2380 (struct case_source_class) New struct.
2381 (struct case_sink) New struct.
2382 (struct case_sink_class) New struct.
2383 (struct case_stream) Removed.
2385 * vfmP.h: (struct case_list) Moved to var.h.
2387 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
2389 * algorithm.c: (count_equal) New function.
2390 (count_if) New function.
2391 (unique) Add assertions.
2392 (partition) Add assertions.
2393 (is_partitioned) New function.
2394 (copy_if) Add assertions.
2395 (remove_equal) Add assertions.
2396 (lexicographical_compare) Rename lexicographical_compare_3way.
2397 (sort) Add assertions. Rephrase some code.
2398 (is_sorted) New function.
2400 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
2404 * sort.c: Completely rewrite.
2406 * sort.h: Expose interface via struct sort_cases_pgm, not via
2409 * aggregate.c: (sort) New static var.
2410 (cmd_aggregate) Use sort.
2411 (create_sysfile) Ditto.
2412 (aggregate_single_case) Ditto.
2413 (dump_aggregate_info) Ditto.
2414 (agr_00x_end_func) Ditto.
2415 (debug_print) Ditto.
2417 * var.h: (enum SRT_ASCEND) Removed.
2418 (enum SRT_DESCEND) Removed.
2419 (struct sort_cases_proc) Removed.
2420 (struct variable) Remove p.srt member.
2422 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
2424 Get rid of the old, crappy heap structure and replace it by a new,
2425 shiny, C++ STL-like heap structure.
2427 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
2429 * algorithm.c: (push_heap) New function.
2440 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
2442 Increase warning level.
2444 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
2446 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
2448 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
2450 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
2452 * dictionary.c: (dict_create_var) Fix root cause of bug worked
2453 around by previous change log entry.
2455 * compute.c: (lvalue_finalize) Remove workaround from previous
2458 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2460 * compute.c: Fixed a bug where the Format was not getting set for
2461 computed variables (thus causing a crash when SAVEing).
2463 * Added a test to stop this bug ever coming back
2465 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
2467 Got rid of approx.h. In general, replaced all references to
2468 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
2471 * Makefile.am: (pspp_SOURCES) Removed approx.h.
2473 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
2474 test for mag < EPSILON.
2476 * misc.h: Add definition of EPSILON.
2478 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
2480 * vfm.c: (procedure) Add check to prevent recursive call.
2482 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
2484 * Moved the declarations relating to values to their own header file
2487 * Added levene.c and levene.h
2489 * vars-atr.c: Changed the signature of compare_values to
2490 take const * arguments.
2492 * t-test.q: Changed the structure of struct t_test_proc
2493 variables now contain their own group statistics information.
2494 Eventually, t_test_proc might get renamed, because it'd be
2495 applicable to other commands too.
2497 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
2499 * data-out.c: Clean up. Changed interface of convert_*() to take
2500 either a `double' or a `const char *' instead of a `const union
2501 value *'. Update all implementations of those interfaces.
2502 (data_out) Use switch statements instead of a table.
2503 (convert_AHEX) Rewrite.
2505 * format.h: Update comment.
2507 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
2509 * q2c.c: (dump_header) Add an Emacs header line to output files
2510 that makes generated .c files read-only by default, to make it
2511 difficult to accidentally change generated files.
2513 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
2515 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
2516 not bogus a->v.c <=> b->v.c pointer compare.
2517 (compare_freq_alpha_a) Ditto.
2518 (compare_freq_numeric_d) Ditto.
2519 (compare_freq_alpha_d) Ditto.
2521 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
2523 Changed data_out() to store string data directly into a `union
2524 value''s s member, not indirectly into c.
2526 * crosstabs.q: (output_pivot_table) Use format_short() instead of
2528 (table_value_missing) Ditto.
2529 (float_M_suffix) Ditto.
2530 (format_short) New function.
2532 * data-in.h: (data_in_finite_line) Remove inline definition.
2534 * data-list.c: (destroy_dls_var_spec) New function.
2535 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
2536 (data_list_source_destroy_source) Avoid cast.
2537 (struct repeating_data_trns) New field `id_value'. Update
2539 (cmd_repeating_data) Initialize id_value. Use new
2540 repeating_data_trns_free() for freeing REPEATING DATA
2542 (rpd_parse_record) Rewrite support for record ID to be less bogus.
2543 (repeating_data_trns_free) New function.
2545 * data-out.c: (data_out) Change return type to `void' by replacing
2546 error returns by writing a message into the output buffer.
2547 (convert_A) Read from v->s instead of v->c.
2548 (convert_AHEX) Ditto.
2550 * expr-evl.c: Update comment.
2551 (expr_evaluate) Add assertion in OP_STRING case.
2553 * format.h: (macro MAX_FORMATTED_LEN) New macro.
2555 * list.q: (list_cases) Update for new data_out() semantics.
2557 * print.c: (print_trns_proc) Ditto.
2559 * tab.c: (tab_value) Ditto.
2560 (tab_float) Avoid stupid cast.
2562 * var.h: Update comments.
2563 (macro MAX_STRING) New macro.
2564 (macro MAX_ELEMS_PER_VALUE) New macro.
2566 * vars-atr.c: (compare_values) New function.
2568 * vfm.c: (dump_splits) Update for new data_out() semantics.
2570 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
2572 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
2574 (struct crosstab) Rename v[] to vars[]. All references updated.
2575 (hash_table_entry) Replace the hash algorithm and fix a bug at the
2576 same time, which caused the hash value to depend only on a single
2577 value, not all of the variables' values.
2579 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
2581 Clean up struct dictionary's value_cnt usage.
2583 * dictionary.c: Add a function comment to each function.
2584 (struct dictionary) Rename value_cnt to next_value_idx, which more
2585 accurately reflects its meaning. All references updated.
2586 (dict_rename_vars) Add assertion.
2587 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
2589 (dict_get_case_size) New function.
2591 * aggregate.c: (create_sysfile) Use dict_get_case_size().
2593 * get.c: (mtf_read_nonactive_records) Ditto.
2595 * sort.c: (allocate_cases) Ditto.
2596 (write_initial_runs) Ditto.
2600 * vfm.c: (prepare_for_writing) Ditto.
2604 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
2606 Make vfm.c slightly less grotesque.
2608 * vfm.c: (filter_var) Removed.
2609 (filter_index) Removed.
2610 (FILTERED macro) Removed.
2611 (exclude_this_case) New function.
2612 (process_active_file_write_case) Use exclude_this_case() instead
2613 of FILTERED and inline tests.
2614 (procedure_write_case) Ditto.
2615 (setup_filter) Removed.
2616 (open_active_file) Don't call setup_filter().
2617 (close_active_file) Call dict_get_filter() instead of checking
2620 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
2622 * var.h: (struct variable) Update comments.
2624 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
2626 New functions dict_create_var_assert(), dict_lookup_var_assert().
2627 Converted several dict_*_var()/assert pairs into a single
2628 dict_*_var_assert().
2630 * dictionary.c: (dict_create_var_assert) New function.
2631 (dict_lookup_var_assert) New function.
2633 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
2635 Got rid of "struct long_vec", envector(), devector(), etc. Added
2636 two members `init', `reinit' to struct variable as a substitute.
2638 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
2644 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
2647 * autorecode.c: (cmd_autorecode) destvars don't need init.
2649 * compute.c: (lvalue_finalize) Set reinit.
2651 * data-list.c: (fixed_parse_compatible) Don't need init usually.
2652 (dump_fmt_list) Ditto.
2655 * descript.q: (run_z_pass) Don't need init for z-scores.
2657 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
2659 (dict_clone_var) Copy `reinit' member, initialize `init' member.
2661 * glob.c: (init_glob) Remove vec_init() calls.
2663 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
2665 * loop.c: (internal_cmd_loop) Don't need to call envector().
2667 * numeric.c: (cmd_numeric) Ditto.
2669 (cmd_leave) Ditto. Set `init', `reinit' members.
2671 * recode.c: (cmd_recode) Don't need to call envector().
2673 * repeat.c: (internal_cmd_do_repeat) Ditto.
2675 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
2676 (force_create_variable) Removed prototype.
2677 (force_dup_variable) Ditto.
2679 * vector.c: (cmd_vector) Don't need to call envector().
2681 * vfm.c: (reinit_sysmis) Removed.
2682 (reinit_blanks) Removed.
2683 (init_zero) Removed.
2684 (init_blanks) Removed.
2685 (process_active_file_write_case) No need to deal with vectors.
2686 Call clear_temp_case().
2687 (vector_initialization) Rewrite to use `init', `reinit'.
2688 (close_active_file) No need to call vec_clear().
2689 (procedure_write_case) Call clear_temp_case().
2690 (clear_temp_case) New function.
2692 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
2694 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
2697 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
2699 Add auxiliary argument to procedure() interface. Associated small
2700 clean-ups of vfm interface.
2702 * Updated every caller of procedure() and process_active_file() to
2703 reflect modified interface. Simple, ordinary changes not listed
2706 * Updated every function that implements struct case_stream's
2707 `read' function to take a write_case_func and a write_case_data.
2708 Also updated every caller of write_case() to instead call them
2709 through these arguments. In some cases this meant that the extra
2710 args had to be threaded through a couple of extra levels. This
2711 wasn't difficult or interesting so the details won't be given.
2713 * data-list.c: (struct repeating_data_trns) Add members
2714 `write_case', `wc_data' as kluge.
2715 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
2717 (repeating_data_set_write_case) New function.
2719 * data-list.h: New file to declare repeating_data_trns_proc() and
2720 repeating_data_set_write_case().
2722 * inpt-pgm.c: (input_program_source_read) Call
2723 repeating_data_set_write_case() for all the REPEATING DATA
2724 transformations, so that they know where to send their cases.
2725 It's a big kluge. Also kluge in END CASE.
2726 (end_case_trns_proc) Never called anymore, but we still need it,
2729 * sort.c: (read_sort_output) Update to match struct case_stream
2732 * vfm.c: (struct write_case_data) New structure.
2733 (proc_func) Removed.
2734 (virt_proc_func) Removed.
2735 (begin_func) Removed.
2736 (virt_begin_func) Removed.
2738 (write_case) Removed.
2739 (procedure) Added an auxiliary parameter to each function pointer
2740 argument's prototype. Added an auxiliary data parameter.
2742 (process_active_file) Ditto.
2743 (process_active_file_write_case) Pass aux data along.
2744 (close_active_file) Ditto.
2745 (procedure_write_case) Ditto.
2746 (SPLIT_FILE_procfunc) Ditto.
2748 * vfm.h: (typedef write_case_data) New.
2749 (typedef write_case_func) New.
2750 (struct case_stream) Add parameters to `read' member prototype.
2752 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
2754 * t-test.q: Added calculations for independent samples. (But no Levene
2757 * Makefile.am: Moved q_sources_c into own variable
2759 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
2761 Miscellaneous cleanups.
2763 * Change unused to UNUSED in many source files to reflect modified
2764 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
2765 __CYGWIN32__, __unix__, and unix not to assume that they're
2766 defined to a nonzero value. Change use of __attribute__ to use
2767 NO_RETURN or PRINTF_FORMAT instead.
2769 * alloc.h: Move definitions for local_alloc(), local_free() here
2770 from ../pref.h.orig and simplify.
2772 * expr-evl.c: Instead of working differently based on PAGED_STACK,
2773 use a pool allocator unconditionally.
2774 (CHECK_STRING_SPACE) Removed.
2775 (ALLOC_STRING_SPACE) Removed.
2776 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
2779 * expr-opt.c: (dump_expression) Allocate string pool.
2781 * expr-prs.c: (expr_free) Free string pool.
2783 * pool.c: (pool_destroy) This pool must be removed from its
2784 parent's list of gizmos, not from its own. Use free_all_gizmos().
2785 (pool_clear) New function.
2786 (free_all_gizmos) New function.
2787 (pool_alloc) Use space in empty block after this one if any.
2788 (pool_release) Only empty out blocks, don't actually free() them.
2790 * print.c: Get rid of PAGED_STACK special case by always
2791 dynamically allocating line buffers.
2792 (struct print_trns) Always include the `line' member.
2793 (internal_cmd_print) Always initialize the `line' member.
2794 (alloc_line) Always allocate memory for `line'.
2795 (print_trns_proc) Always initialize buf from `line' member.
2796 (print_trns_free) Always free `line' memory.
2798 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
2801 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
2803 * flip.c: Fixed crash from FLIP when a numeric variable is
2804 specified on NEWNAMES and a large value is used, and a couple of
2805 other minor bugs besides.
2806 (struct varname) Make name a 9-character fixed-size array
2807 instead of a 1-character variable size array.
2808 (make_new_var) Allow digits in variable names.
2809 (flip_stream_write) Limit numeric values to 8 characters and
2810 format system missing and very large and small values more
2813 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2815 * command.c: Fixed test on command return status for the correct
2816 value, which had been causing a crash under certain invalid input.
2818 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2820 * t-test.q: Added calculations for the one sample variant of the T-TEST
2822 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
2824 * tab.c: (render_strip) Fix bug that sometimes caused joined text
2825 in joined cells to be rendered outside box boundaries.
2827 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2829 * random.c (rng_create): Fixed seeding so that it gets reseeded after
2830 SET seed=xx has been called.
2832 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
2834 * random.c (rng_get_double): Fix always-returning-zero bug in my
2835 preferred way, and at the same time make sure rounding doesn't
2838 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
2840 * html.c: (change_attributes) Dead code, removed.
2841 (escape_string) Eliminate code to call change_attributes() that
2842 never actually called it.
2843 (output_tab_table) Get rid of dependence on tab_hit
2844 and struct tab_joined_cell's hit member, which are abominations.
2846 * tab.c: (tab_output_text) Don't call
2847 d->class->text_set_font_by_name if it's a null pointer.
2848 (macro UNROLL_LOOP) Eliminate.
2849 (macro UNROLL_3_LOOPS) Eliminate.
2850 (tabi_render) Rewrite not to use the above macros.
2852 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
2854 Start working on a new output driver system, one that doesn't suck
2855 so much, by adding a "device-independent" output driver. The idea
2856 is to write out only a single output stream, then use separate
2857 processes to translate them into whatever formats we want. This
2858 is similar to how "groff" works with its various output drivers
2859 (grops, grotty, grodvi, ...).
2861 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
2863 * list.q: (write_all_headers) Stub out devind class.
2865 (determine_layout) Ditto.
2868 * output.c: (outp_init) Add devind class.
2870 * devind.c: New file.
2872 * devind.h: New file.
2874 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
2876 * frequencies.q: (hash_value_alpha) Fixed up the previous change
2877 to use the proper string length.
2879 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
2881 * Fixed bug where FREQ would crash on alpha values
2883 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
2885 * Removed bletcherous alloca() workarounds for AIX from top of
2886 many files. AIX can use the alternative alloca() implementation
2889 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
2891 * ascii.c: (ascii_option) Fix implementation of headers option.
2893 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
2895 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
2896 multiple blank lines into one.
2897 (struct ascii_driver_ext) Add squeeze_blank_lines option.
2898 (ascii_preopen_driver) Initialize squeeze_blank_lines.
2899 (static var option_tab) Add squeeze entry.
2900 (ascii_option) Set squeeze_blank_lines.
2901 (output_lines) Implement squeezing blank lines.
2903 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
2905 * Removed redundant code from output.h
2907 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
2909 Dictionary classes: each variable is "ordinary", "system", or
2912 * var.h: (enum dict_class) New enum.
2914 * vars-prs.c: (dict_class_from_id) New function.
2915 (dict_class_to_name) New function.
2917 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
2919 * var.h: (struct freq_tab_set) Removed (not used).
2921 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
2923 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
2925 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
2927 * stats.c: (hypercube) Rename pow4(). All references updated.
2929 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
2931 * rename-vars.c: (cmd_rename_variables) Rewritten.
2932 (compare_name) Removed.
2934 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
2936 var_set feature, and code taking advantage of it.
2938 * crosstabs.q: (static var var_dict) Removed.
2939 (static var variables) New variable.
2940 (static var variables_cnt) New variable.
2941 (cmd_crosstabs) Free variables instead of var_dict.
2942 (internal_cmd_crosstabs) Initialize and use variables,
2943 variables_cnt instead of var_dict.
2944 (free_var_dict) Removed.
2945 (crs_custom_tables) Use var_set instead of a copied dictionary.
2946 (crs_custom_variables) Set up variables, variables_cnt instead of
2948 [DEBUGGING] (debug_print) Ditto.
2950 * means.q: (mns_custom_tables) Use var_set instead of a copied
2953 * vars-prs.c: (parse_vs_variable) New function.
2954 (parse_dict_variable) Rewritten.
2955 (parse_variable) Rewritten.
2956 (parse_variables) Renamed parse_var_set_vars(), rewritten.
2957 (parse_variables) New function in terms of parse_var_set_vars().
2958 Now requires its first argument to be non-null. All references
2959 that passed a null pointer updated to pass default_dict instead.
2960 (macro id_dict) Removed.
2961 (parse_DATA_LIST_vars) Add assertions.
2962 (parse_mixed_vars) Ditto.
2963 (struct var_set) New structure.
2964 (var_set_get_cnt) New function.
2965 (var_set_get_var) New function.
2966 (var_set_lookup_var) New function.
2967 (var_set_destroy) New function.
2968 (dict_var_set_get_cnt) New function.
2969 (dict_var_set_get_var) New function.
2970 (dict_var_set_lookup_var) New function.
2971 (dict_var_set_destroy) New function.
2972 (var_set_create_from_dict) New function.
2973 (struct array_var_set) New structure.
2974 (array_var_set_get_cnt) New function.
2975 (array_var_set_get_var) New function.
2976 (array_var_set_lookup_var) New function.
2977 (array_var_set_destroy) New function.
2978 (var_set_create_from_array) New function.
2980 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
2981 instead of parse_variables(NULL, ...) in output code.
2983 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
2985 Change inp_init from a 2-bit vector to an ordinary array.
2986 Initialize it all in cmd_end_input_program() instead of in
2989 * inpt-pgm.c: (enum value_init_type) New enum.
2990 (global var inp_init) Change to `enum value_init_type *', make
2992 (inp_init_size) Removed.
2993 (inp_nval) Change to `size_t', make static.
2994 (cmd_input_program) Don't initialize inp_init or inp_init_size.
2995 (cmd_end_input_program) Initialize inp_init, inp_nval.
2996 (init_case) Rewrite.
2997 (clear_case) Rewrite.
2999 * inpt-pgm.h: Removed.
3001 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
3003 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
3004 Colin Plumb hash. It is simpler and should better resist
3006 (hsh_hash_string) Ditto.
3008 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
3010 * get.c: (export_write_case_func) Remove debug printing code.
3012 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
3014 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
3016 (save_write_case_func) Use &trns->h instead of cast.
3017 (cmd_export) Use &t->h instead of cast.
3019 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
3021 Moved vectors into the dictionary.
3023 * var.h: (struct vector) Moved here from vector.h. `index' member
3024 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
3027 * vector.h: Removed.
3029 * vector.c: (global var vec) Removed.
3030 (global var nvec) Removed.
3031 (cmd_vector) Rewritten.
3032 (find_vector) Removed.
3034 * dictionary.c: (dict_create_vector) New function.
3035 (dict_get_vector) New function, replaces reading global vec[]
3037 (dict_get_vector_cnt) New function, replaces reading global nvec
3039 (dict_lookup_vector) New function, replaces find_vector().
3040 (dict_clear_vectors) New function.
3042 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
3044 Start to move away from `struct variable' p `union' member to void
3047 * var.h: (struct variable) Add `aux' member.
3049 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
3051 Get rid of struct variable `foo' member.
3053 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
3055 (frq_custom_variables) Ditto.
3056 (frq_custom_grouped) Ditto.
3058 * get.c: (struct save_trns) Change `var' member from `int *' to
3059 `struct variable **'.
3060 (cmd_save_internal) Use aux instead of foo.
3061 (save_trns_proc) Use revised `var' member.
3062 (static var mtf_seq_no) Renamed mtf_seq_num.
3063 (static var mtf_seq_nums) New static var.
3064 (cmd_match_files) Initialize mtf_seq_nums.
3065 (mtf_free) Free mtf_seq_nums.
3066 (mtf_processing) Use mtf_seq_nums instead of foo.
3067 (mtf_merge_dictionary) No need to initialize mv->foo.
3068 (cmd_export) Use aux instead of foo. Use revised `var' member.
3069 (mns_custom_tables) Don't use foo to check for duplicates, that's
3070 what PV_NO_DUPLICATE is for.
3072 * var.h: (struct variable) Remove `foo' member.
3073 (struct frequencies_proc) New member.
3075 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
3077 Clean up COMPUTE and IF.
3079 * compute.c: More or less rewrite the darn thing.
3080 (struct compute_trns) Rename and reorder and add and delete
3082 (cmd_compute) Rewrite.
3083 (compute_num) Make conditional on test expression. Now used for
3084 both COMPUTE and IF.
3085 (compute_num_vec) Ditto.
3086 (compute_str) Ditto.
3087 (compute_str_vec) Ditto.
3090 (if_num_vec) Removed.
3092 (if_str_vec) Removed.
3093 (parse_target_expression) Renamed parse_rvalue_expression(),
3095 (new_trns) Renamed compute_trns_create(), rewritten.
3096 (delete_trns) Removed.
3097 (free_trns) Renamed compute_trns_free(), rewritten.
3098 (struct lvalue) New structure.
3099 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
3100 (lvalue_get_type) New function.
3101 (lvalue_is_vector) New function.
3102 (lvalue_finalize) New function.
3103 (lvalue_destroy) New function.
3105 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
3107 * command.def: Disallow MODIFY VARS in input mode, so that
3108 variables can't get dropped and confuse cmd_end_input_program()'s
3109 attempt to fill inp_init[].
3111 * modify-vars.c: (static var forward_positional_ordering) New
3113 (struct var_modification) Entirely changed.
3114 (rearrange_dict) Interface changed, rewritten.
3115 (cmd_modify_vars) Deal with modified struct var_modification, much
3117 (struct var_renaming) New structure.
3118 (compare_var_renaming_by_new_name) New function.
3119 (validate_var_modification) New function.
3121 * var.h: (struct modify_vars_proc) Removed.
3122 (struct variable) Removed member p.mfv.
3124 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
3126 Make EVALUATE a valid command whether we're debugging or not, so
3127 that `make check' can succeed regardless of whether debugging is
3130 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
3132 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
3134 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
3136 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
3137 statement by a simple if test.
3139 * dfm.c: (dfm_get_record) Add assertion.
3141 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
3143 For each file x.c, move #include "x.h" to the very top of the
3144 include list, to catch x.h failing to include the proper headers.
3146 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
3148 * algorithm.c: (find) New function.
3149 (remove_equal) New function.
3150 (set_difference) New function.
3151 (adjacent_find_equal) New function.
3152 [TEST_UNIQUE] Removed test case.
3153 (copy_if) Find end test.
3155 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
3157 * dictionary.c: (dict_get_case_weight) New convenience function.
3159 * aggregate.c: (accumulate_aggregate_info) Use
3160 dict_get_case_weight().
3162 * frequencies.q: (calc_general) Ditto.
3163 (calc_integer) Ditto.
3166 * t-test.q: (groups_calc) Ditto.
3169 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
3171 * glob.c: (global var default_dict) Change from `struct
3172 dictionary' to `struct dictionary *'. All references changed.
3173 (init_glob) Initialize default_dict with dict_create().
3175 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
3177 struct dictionary now made opaque. All related functions:
3179 * get.c: (rename_variables) Removed.
3180 (dict_delete_run) Removed.
3182 * temporary.c: (copy_variable) Removed.
3183 (new_dictionary) Removed.
3184 (save_dictionary) Removed.
3185 (restore_dictionary) Removed.
3186 (free_dictionary) Removed.
3188 * vars-atr.c: (clear_default_dict) Removed.
3189 (find_variable) Removed.
3190 (find_dict_variable) Removed.
3191 (create_variable) Removed.
3192 (delete_variable) Removed.
3193 (common_init_stuff) Removed.
3194 (init_variable) Removed. Updating of inp_init moved into
3195 cmd_end_input_program().
3196 (replace_variable) Removed.
3197 (rename_variable) Removed.
3198 (clear_variable) Removed.
3199 (dup_variable) Removed.
3201 * vars-prs.c: (is_varname) Removed.
3202 (is_dict_varname) Removed.
3203 (fill_all_vars) Removed.
3205 * vector.c: (find_vector) Removed.
3207 * weight.c: (stop_weighting) Removed.
3209 * dictionary.c: New file.
3210 (dict_create) New, replaces new_dictionary().
3211 (dict_clone) New, replaces save_dictionary() and
3212 restore_dictionary().
3213 (dict_clear) New, replaces clear_default_dict().
3214 (dict_destroy) New, replaces free_dictionary().
3215 (dict_get_var_cnt) New function, replaces references to
3217 (dict_get_var) New function, replaces references to dict->var[i].
3218 (dict_get_vars) New function, replaces fill_all_vars().
3219 (dict_create_var) New, replaces create_variable(). Interface
3220 drops `type' parameter, using a zero `width' to designate numeric.
3221 (dict_clone_var) New, replaces dup_variable().
3222 (dict_rename_var) New, replaces rename_variable().
3223 (dict_lookup_var) New, replaces find_variable(),
3224 find_dict_variable(), is_varname().
3225 (dict_contains_var) New function.
3226 (compare_variable_dblptrs) New function.
3227 (dict_delete_var) New function, replaces clear_variable().
3228 (dict_delete_vars) New function, replaces dict_delete_run().
3229 (dict_reorder_vars) New function.
3230 (dict_rename_vars) New function, replaces rename_variables().
3231 (dict_get_weight) New function, replaces reading dict->weight_var.
3232 (dict_set_weight) New function, replaces writing dict->weight_var
3233 or calling stop_weight(dict).
3234 (dict_get_filter) New function, replaces reading dict->filter_var.
3235 (dict_set_filter) New function, replaces writing dict->filter_var.
3236 (dict_get_case_limit) New function, replaces reading dict->N.
3237 (dict_set_case_limit) New function, replaces writing dict->N.
3238 (dict_get_value_cnt) New function, replaces reading dict->nval.
3239 (dict_compact_values) New function, replaces a loop that was
3240 replicated in several places.
3241 (dict_get_split_vars) New function, replaces reading dict->splits.
3242 (dict_get_split_cnt) New function, replaces reading
3244 (dict_set_split_vars) New function, replaces writing dict->splits.
3245 (dict_get_label) New function, replaces reading dict->label.
3246 (dict_set_label) New function, replaces writing dict->label.
3247 (dict_get_documents) New function, replaces reading
3249 (dict_set_documents) New function, replaces writing
3252 All references to above functions updated.
3254 * aggregate.c: (cmd_aggregate) Copy file label and documents from
3255 old dictionary to new by hand, because dict_create() can't do it
3256 itself. Use dict_set_documents(), dict_set_split_vars().
3258 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
3259 calling dict_destroy().
3261 * data-list.c: (dls_var_spec) Remove `type' member, replace by
3263 (fixed_parse_compatible) Some slightly nontrivial changes for
3265 (dump_fmt_list) Ditto.
3268 * file-type.c: (create_col_var) Ditto.
3270 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
3271 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
3272 (rename_variables) Use dict_rename_vars().
3273 (mtf_merge_dictionary) Use dict_get_documents(),
3274 dict_set_documents(), dict_compact_values().
3276 * pfm-read.c: (read_variables) Deal with changes to weighting.
3278 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
3279 is_varname() in output code.
3281 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
3282 other dictionary functions.
3284 * title.c: (add_document_line) Use dict_get_documents(),
3285 dict_set_documents().
3287 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
3288 reset default_handle by hand. dict_clear() will clear vectors so
3289 there's no need for that by hand.
3291 * vfm.c: (close_active_file) Move call to finish_compaction()
3292 earlier, so that we can do the compaction as a single step using
3293 dict_compact_values(). Use dict_clear_vectors().
3294 (finish_compaction) Use dict_delete_var(), dict_compact_values().
3296 Some functions don't have replacements:
3298 * vars-atr.c: (force_create_variable) Removed. All references
3299 updated to dict_create_var() followed by an assertion.
3300 (force_dup_variable) Removed. All references updated to
3301 dict_clone_var() followed by an assertion.
3303 * weight.c: (update_weighting) Removed. No longer necessary, so
3304 all references removed.
3306 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
3310 * aggregate.c: Eliminate separation of weighted and unweighted
3311 case. It made the code too obscure and I doubt it was actually
3312 faster. Instead, all code uses the "weighted" code, because
3313 that's a generalization of the "unweighted" code.
3316 (parse_aggregate_functions) No need to set FWEIGHT.
3317 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
3318 (dump_aggregate_info) Ditto.
3319 (initialize_aggregate_info) No need for special plain_function
3320 that gets rid of FWEIGHT option.
3322 * aggregate.c: Get rid of approximations.
3323 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
3325 (aggregate_single_case) Don't use approx_ne().
3327 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
3329 * ascii.c (ascii_line_width): Dead code, removed.
3331 * postscript.c (ps_line_width): Ditto.
3333 * q2c.c (xrealloc): Ditto.
3335 * count.c (internal_cmd_count): Ditto.
3337 * means.q (validate_dependent_endpoint): Ditto.
3339 * set.q: (cmd_gset) Ditto.
3341 * weight.c: [0] (weight_trns_proc) Ditto.
3343 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
3345 Make the code -Wmissing-prototypes clean.
3347 * Makefile.am (version.c): Add #include "version.h".
3349 * ascii.c: (ascii_open_global) Make static.
3350 (ascii_close_page) Ditto.
3351 (ascii_font_sizes) Ditto.
3352 (ascii_postopen_driver) Ditto.
3353 (ascii_close_driver) Ditto.
3354 (ascii_option) Ditto.
3355 (ascii_open_page) Ditto.
3356 (ascii_line_horz) Ditto.
3357 (ascii_line_vert) Ditto.
3358 (ascii_line_intersection) Ditto.
3360 (ascii_polyline_begin) Ditto.
3361 (ascii_polyline_point) Ditto.
3362 (ascii_polyline_end) Ditto.
3363 (ascii_text_set_font_by_name) Ditto.
3364 (ascii_text_set_font_by_position) Ditto.
3365 (ascii_text_set_font_by_family) Ditto.
3366 (ascii_text_get_font_name) Ditto.
3367 (ascii_text_get_font_family) Ditto.
3368 (ascii_text_set_size) Ditto.
3369 (ascii_text_get_size) Ditto.
3370 (ascii_text_metrics) Ditto.
3371 (ascii_text_draw) Ditto.
3372 (ascii_close_page) Ditto.
3374 * cmdline.h: New header for parse_command_line(). Used where
3377 * command.c: Move prototypes for cmd_*() functions to command.h.
3379 * command.h: Prototypes for cmd_*() functions moved here from
3382 * crosstabs.q: (gamma_int) Ditto.
3384 * file-handle.h: Add fh_init_files() prototype.
3386 * getline.c: (welcome) Ditto.
3388 * glob.h: New header for init_glob(). Used where appropriate.
3390 * hash.c: (comparison_helper) Ditto.
3392 * html.c: (html_open_global) Ditto.
3393 (html_close_global) Ditto.
3394 (html_preopen_driver) Ditto.
3395 (html_postopen_driver) Ditto.
3396 (html_close_driver) Ditto.
3397 (html_option) Ditto.
3398 (html_open_page) Ditto.
3399 (html_close_page) Ditto.
3400 (html_submit) Ditto.
3402 * inpt-pgm.c: (input_program_source_read) Ditto.
3404 * output.c: (find_defn_value) Ditto.
3405 (destroy_list) Ditto.
3407 * pfm-read.c: (read_int) Ditto.
3409 * postscript.c: (ps_open_global) Ditto.
3410 (ps_close_global) Ditto.
3411 (ps_font_sizes) Ditto.
3412 (ps_preopen_driver) Ditto.
3413 (ps_postopen_driver) Ditto.
3414 (ps_close_driver) Ditto.
3416 (ps_open_page) Ditto.
3417 (ps_close_page) Ditto.
3418 (ps_line_horz) Ditto.
3419 (ps_line_vert) Ditto.
3420 (ps_line_intersection) Ditto.
3422 (ps_polyline_begin) Ditto.
3423 (ps_polyline_point) Ditto.
3424 (ps_polyline_end) Ditto.
3425 (ps_text_set_font_by_name) Ditto.
3426 (ps_text_set_font_by_position) Ditto.
3427 (ps_text_set_font_family) Ditto.
3428 (ps_text_get_font_name) Ditto.
3429 (ps_text_get_font_family) Ditto.
3430 (ps_text_set_size) Ditto.
3431 (ps_text_get_size) Ditto.
3432 (ps_text_metrics) Ditto.
3433 (ps_text_draw) Ditto.
3435 * q2c.c: (finish_up) Ditto.
3444 (find_symbol) Ditto.
3447 (force_string) Ditto.
3449 (match_token) Ditto.
3452 (parse_setting) Ditto.
3453 (parse_specifier) Ditto.
3454 (parse_specifiers) Ditto.
3455 (parse_subcommand) Ditto.
3456 (dump_specifier_vars) Ditto.
3458 (make_identifier) Ditto.
3459 (dump_declarations) Ditto.
3460 (dump_specifier_init) Ditto.
3461 (dump_vars_init) Ditto.
3463 (dump_specifier_parse) Ditto.
3464 (dump_subcommand) Ditto.
3465 (dump_parser) Ditto.
3466 (dump_header) Ditto.
3468 (recognize_directive) Ditto.
3470 * recode.c: (string_to_long) Ditto.
3472 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
3474 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
3477 * sort.c: (sort_stream_read) Ditto.
3478 (sort_stream_mode) Ditto.
3480 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
3482 * algorithm.c (binary_search): Fix comparison.
3484 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
3486 * algorithm.c: (binary_search) Fix assertion.
3488 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
3490 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
3492 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
3494 * sort.c: (compare_case_lists) Rewrite.
3496 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
3498 * quicksort.c: Removed (not used).
3500 * quicksort.h: Removed (not used).
3502 * sort.c: Removed blp_quicksort() prototype.
3504 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
3506 * postscript.c: (int_2_compare) Rewrite.
3507 (compare_line) Rewrite.
3509 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
3511 * matrix-data.c (compare_factors) Use lexicographical_compare()
3513 (compare_doubles) New function.
3515 * algorithm.c: (lexicographical_compare) New algorithm.
3517 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
3519 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
3521 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
3523 * expr-prs.c: (cmp_func) Removed.
3524 (parse_function) Use binary_search() algorithm.
3525 (compare_functions) New function.
3526 (init_func_tab) Use sort() algorithm.
3528 * algorithm.c: (binary_search) New algorithm.
3530 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
3532 * descript.q: (display) Use sort() algorithm instead of qsort().
3533 (compare_func) Removed.
3534 (descriptives_compare_variables) New function.
3536 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
3538 Get rid of AVL trees. Hashes are more appropriate for everything
3541 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
3547 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
3549 Much code can be clarified by using C++ STL-like algorithms. Not
3550 all uses of these algorithms are listed below, only the ones where
3551 the change to an algorithm was the only change of interest.
3553 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
3555 * algorithm.c: New file.
3557 * algorithm.h: New file.
3559 * modify-vars.c: (static var forward) Removed.
3560 (static var positional) Removed.
3561 (compare_variables) Removed.
3562 (struct ordering) New.
3563 (cmd_modify_vars) Use sort() algorithm.
3564 (compare_variables_given_ordering) New function.
3565 (rearrange_dict) Use sort() algorithm.
3567 * sysfile-info.c: (cmd_display) Use sort() algorithm.
3568 (cmp_var_by_name) Removed.
3570 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
3572 Make file handles use a hash table.
3574 * file-handle.q: (files) Change to hash table, make static.
3575 (cmd_file_handle) Use hash table functions.
3576 (fh_get_handle_by_filename) Ditto.
3577 (fh_get_handle_by_name) Ditto.
3578 (hash_file_handle) New function.
3579 (cmp_file_handle) Rewrite.
3580 (fh_init_files) Use hash table functions.
3582 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
3584 Clean up FREQUENCIES.
3586 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
3588 * frequencies.q: Remove a lot of old #if'd out code at the end.
3589 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
3590 or calc_weight(). Initialize percentile_values.
3591 (calc) New function based on calc_weight() from frequencies.g.
3592 (precalc) Use hash functions.
3593 (static var comparison_func) Removed.
3594 (static var comparison_param) Removed.
3595 (comparison_helper) Removed.
3596 (get_freq_comparator) New function.
3597 (not_missing) New function.
3599 (postprocess_freq_tab) Use hash table functions, algorithms,
3600 get_freq_comparator(). Rewrite.
3601 (cleanup_freq_tab) Rephrase.
3602 (add_percentile) Clean up spacing.
3603 (hash_value_numeric) New function.
3604 (hash_value_alpha) New function.
3605 (compare_value_numeric_a) Rewrite.
3606 (compare_value_alpha_a) Rewrite.
3607 (compare_value_numeric_d) Rewrite.
3608 (compare_value_alpha_d) Rewrite.
3609 (compare_freq_numeric_a) Rewrite.
3610 (compare_freq_alpha_a) Rewrite.
3611 (compare_freq_numeric_d) Rewrite.
3612 (compare_freq_alpha_d) Rewrite.
3613 (calc_stats) Clean up mode, percentiles, max.
3614 (dump_statistics) Clean up spacing.
3616 * frequencies.g: Removed.
3618 * var.h: (struct freq_tab) Change `data' to hash table.
3620 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
3622 * file-handle.h: Remove declaration of global variable `files',
3623 which wasn't used anywhere.
3625 * postscript.c: (add_encoding) Remove superfluous cast.
3628 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
3631 * temporary.c: [0] (display_tree) Removed.
3633 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
3635 Implement a new random number generator based on the alleged RC4
3638 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
3641 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
3642 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
3644 (static var V[]) Removed.
3645 (static var Y) Removed.
3646 (static var X2) Removed.
3647 (setup_randomize) Removed.
3649 (rand_uniform) Removed.
3650 (rand_normal) Removed.
3651 (struct rng) New structure.
3652 (rng_create) New function.
3653 (rng_destroy) New function.
3654 (swap_byte) New static function.
3655 (rng_seed) New function.
3656 (rng_get_bytes) New function.
3657 (rng_get_int) New function.
3658 (rng_get_unsigned) New function.
3659 (rng_get_double) New function.
3660 (rng_get_double_normal) New function.
3661 (pspp_rng) New function.
3663 * random.h: Sync up to random.c.
3665 * sample.c: (struct sample_trns) Make `frac' unsigned and a
3666 fraction of UINT_MAX, not 65536.
3667 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
3670 * vfm.c: (open_active_file) No need to call setup_randomize() any
3673 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
3675 Change dictionary name indexes to use hash tables instead of AVL
3678 * crosstabs.q: (free_var_dict) Use hash tables.
3679 (crs_custom_tables) Ditto.
3680 (calc_general) Ditto.
3681 (compare_table_entry) Rewrite.
3682 (enum_var_values) Reorder parameters. All references updated.
3685 * get.c: (rename_variable) Use hash tables.
3686 (mtf_merge_dictionary) Ditto.
3688 * glob.c: (init_glob) Use hash tables.
3689 (cmp_variable) Removed.
3691 * means.q: (mns_custom_tables) Use hash tables.
3693 * modify-vars.c: (rearrange_dict) Use hash tables.
3695 * rename-vars.c: (cmd_rename_variables) Use hash tables.
3697 * sfm-read.c: (read_header) Use hash tables.
3698 (read_variables) Ditto.
3700 * temporary.c: (new_dictionary) Use hash tables.
3701 (save_dictionary) Ditto.
3702 (restore_dictionary) Ditto.
3704 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
3705 hash table `name_tab'.
3707 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
3708 [DEBUGGING] (dump_var_tree) Removed.
3709 (find_variable) Use hash tables.
3710 (find_dict_variable) Ditto.
3711 (common_init_stuff) Ditto.
3712 (rename_variable) Ditto.
3713 (clear_variable) Ditto. Also, remove debug code.
3714 (dup_variable) Use hash tables.
3716 * vars-prs.c: (fill_all_vars) Use hash tables.
3717 (is_dict_varname) Ditto.
3718 (parse_dict_variable) Ditto.
3720 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
3722 Change value labels to use hash tables instead of AVL trees, and
3723 change value labels into an ADT.
3725 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
3727 * value-labels.c: New file.
3729 * value-labels.h: New file.
3731 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
3732 Get rid of a stupid use of goto.
3734 * autorecode.c: (compare_alpha_value) Rewrite.
3735 (hash_alpha_value) Ditto.
3736 (compare_numeric_value) Rewrite.
3737 (hash_numeric_value) Ditto.
3739 * frequencies.q: (dump_full) Use value label ADT.
3741 * pfm-read.c: (read_value_label) Use value label ADT.
3743 * pfm-write.c: (write_value_labels) Use value label ADT.
3745 * sfm-read.c: (read_variables) Use value label ADT.
3746 (read_value_labels) Rewrite.
3748 * sfm-write.c: (write_value_labels) Rewrite.
3750 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
3751 (display_variables) Ditto.
3752 (describe_variable) Ditto.
3754 * t-test.q: (print_t_groups) Use value label ADT.
3756 * temporary.c: (copy_variable) Use value label ADT.
3757 (free_dictionary) Ditto.
3759 * val-labs.c: (verify_val_labs) Use value label ADT.
3761 (debug_print) Ditto.
3762 (val_lab_cmp) Removed.
3763 (inc_ref_count) Removed.
3764 (copy_value_labels) Removed.
3766 * var.h: (struct value_label) Removed.
3767 (struct variable) Change AVL tree `val_lab' into hash table
3770 * vars-atr.c: (init_variable) Use value label ADT.
3771 (clear_variable) Ditto.
3772 (free_value_label) Removed.
3773 (free_val_lab) Removed.
3774 (get_val_lab) Removed.
3775 (compare_variables) New function.
3776 (hash_variable) New function.
3778 * vfm.c: (dump_splits) Use value label ADT.
3780 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
3782 Add to the hash table interface.
3784 * hash.c: (hsh_hash_bytes) Add assertion.
3785 (hsh_hash_string) Ditto.
3789 (hsh_create) Ditto. Also make minimum `size'.
3790 (hsh_destroy) Rephrase.
3791 (sort_nulls_last) Removed.
3792 (not_null) New function.
3794 (comparison_helper) Ditto.
3795 (hsh_sort) Rewritten.
3796 (hsh_data_copy) New function.
3797 (hsh_sort_copy) Ditto.
3799 (hsh_replace) Ditto.
3800 (hsh_hash_double) Ditto.
3801 (hsh_delete) Fix stupid bug.
3803 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3804 * added a calculation of the mode to FREQUENCIES
3806 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3808 * moved (un)defs of DEBUGGING to config.h
3810 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
3812 * groff-font.c: (add_kern) Fix indentation.
3813 (add_kern) Use & instead of % to take power-of-2 modulus.
3814 (font_get_kern_adjust) Likewise.
3816 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
3818 * autorecode.c: (recode) Replace stupid use of memcpy() by
3820 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
3821 (hash_numeric_value) Ditto.
3822 (autorecode_proc_func) pool_strdup() was wrong here because the
3823 source string was not null-terminated. Use new pool_strndup()
3826 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
3827 use of hsh_iterator_init().
3829 * data-in.c: (parse_N) Initialize i->v->f.
3831 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
3834 * groff-font.c: Use power-of-2 hash table sizes, not prime.
3835 (groff_read_font) Don't call hsh_next_prime(). Don't call
3837 (static var hash) Remove `size_p', `max_used' members.
3838 (font_char_name_to_index) Don't call hsh_next_prime(). Use
3839 hsh_hash_string() instead of hashpjw(), & instead of %.
3840 (default_font) Don't call hsh_next_prime().
3842 * pool.c: (pool_strndup) New function.
3843 (pool_strdup) Reimplement in terms of pool_strndup.
3845 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
3847 (hash_ps_encoding) Use hsh_hash_string().
3848 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
3849 (hash_filename2font) Use hsh_hash_string().
3851 * som.c: Add #include <stdlib.h>.
3853 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
3854 (by destroying its pool).
3856 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
3858 Miscellaneous hash table code cleanup:
3860 * hash.h: (struct hsh_table) Moved into hash.c.
3861 (hsh_count) Ditto, and transformed into function.
3862 (hsh_compare_func) New typedef, used for defining otherwise-long
3863 function types here and in hash.c
3864 (hsh_hash_func) Ditto.
3865 (hsh_free_func) Ditto.
3867 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
3868 `table' to `entries'. Removed `mp'. All references updated.
3869 (hsh_clear) Don't shrink entries array; if the hash was this big
3870 once, it probably will be again.
3871 (hsh_rehash) Made static.
3872 (force_hsh_insert) Renamed hsh_force_insert.
3873 (force_hsh_find) Renamed hsh_force_find.
3875 Made hash table sizes powers of 2, because that's fine with any
3876 reasonable hash function and because taking a power-of-2 modulus
3877 is faster than any other:
3879 (hsh_prime_tab) Removed;
3880 (hsh_next_prime) Ditto.
3881 (next_power_of_2) New function.
3882 (hsh_create) Use next_power_of_2.
3883 (hsh_rehash) Use & instead of %.
3885 Cleaned up hsh_sort:
3887 (internal_comparison_fn) Removed.
3888 (sort_nulls_last) New function.
3889 (hsh_sort) Removed second parameter, switched to using the new
3890 quicksort() function from quicksort.h to avoid using nasty need
3891 for static variables with qsort(). All references updated.
3893 Changed the hash functions offered, because there are better hash
3894 functions than the ones we had, and cleaned up the names to boot:
3896 * hash.c: (hashpjw_d) Removed.
3898 (hsh_hash_bytes) New function.
3899 (hsh_hash_string) New function.
3900 (hsh_hash_int) New function.
3902 Improved the hash table iteration interface:
3904 * hash.h: (hsh_iterator_init) Removed.
3905 (struct hsh_iterator) Removed `init' member, change `next' to
3908 * hash.c: (hsh_foreach) Removed. All references updated to use
3909 hsh_first/hsh_next instead.
3910 (hsh_first) New function. Notably, unlike hsh_foreach() it does
3911 not treat a null pointer as an empty hash table.
3912 (hsh_next) New function.
3914 Made deletion possible, though slow:
3916 * hash.c: (locate_matching_entry) New function.
3917 (hsh_find) Use locate_matching_entry().
3918 (hsh_delete) New function also using locate_matching_entry().
3919 (hsh_force_delete) New function.
3921 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
3923 * quicksort.c: New file implementing a sort routine with a
3924 interface better than qsort() because it passes a user-provided
3925 parameter to the sort routine.
3927 * Makefile.am: Add quicksort.c, quicksort.h.
3929 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
3931 * All source files: Get rid of nasty special cases for Checker,
3932 which is pretty obsolete now.
3934 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
3936 * Fixed a bug apparent when using the FREQUENCIES command with the
3937 html driver. The html driver was incorrectly trying to display
3940 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
3942 * Makefile.am: Reorganized. Put locale dir in version.c instead
3943 of passing it to each compile command. Only put local gmp libs in
3944 LD_ADD if not installed on system. Remove `boast' target.
3946 * All source files: struct and union typedefs eliminated.
3947 `sizeof type' replaced by `sizeof object' where practical. Moved
3948 `unused' qualifiers from start to end of declarations for gcc
3949 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
3950 assertions on pointers strictly compliant. Removed _ prefixes on
3951 some function parameter names.
3953 * alloc.c: New source file, containing these external linkage
3954 functions removed from common.c: xmalloc, xcalloc, xrealloc,
3961 * ascii.c: Migrated from arenas to pools.
3962 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
3963 c_string to len_string. All references changed.
3964 (ascii_option) Signature changed to comply to new output.c
3966 (count_fancy_chars) Removed.
3967 (delineate) Removed support for rich text.
3968 (ascii_text_metrics) Ditto.
3970 (output_shorts) Change `box', `off', `on' from c_string to
3971 len_string. Change `remaining' from int to size_t.
3972 (ascii_close_page) Make page numbering less haphazard.
3974 * autorecode.c: Migrate from arenas to pools.
3976 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
3978 * bitvector.h: New file containing these macros from misc.h:
3979 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
3981 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
3982 word[3]. ncmd removed.
3983 (var empty_string) Removed.
3984 (var cmd_table) Declaration updated.
3985 (var cmdtab) Removed.
3986 (cmp_command) Removed.
3987 (split_words) Rewritten to use strtok_r().
3988 (init_cmd_parser) Renamed cmd_init(). Rewritten.
3989 (find_command) Removed.
3990 (FILE_TYPE_okay) Rewritten.
3991 (cmd_parse) Rewritten. Semantics of the return value of command
3992 handlers has changed: they must now return one of the new CMD_*
3993 enumerals, rather than a magic value. This meant that all
3994 commands had to be modified, and they were.
3995 (figure_out_command) New function.
3997 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
3998 #defines for INIT, INPU, etc.
4000 * command.h: New CMD_* enum series.
4001 (cur_proc) Make const char *, not char *.
4002 (cmd_init) Prototype.
4005 * common.c: Removed.
4007 * common.h: Removed.
4009 * correlations.q: New file.
4011 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
4013 (custom_tables) Renamed crs_custom_tables().
4014 (custom_variables) Renamed crs_custom_variables().
4015 (calc_integer) Add in some `const' qualifiers.
4016 (table_value_missing) Change from a_string to len_string.
4017 (float_M_suffix) Change from a_string to len_string.
4019 * data-in.c: Rewritten. All references to
4020 parse_string_as_format() changed to data_in().
4022 * data-in.h: New file.
4024 * data-list.c: Change DLS_* from #define's to enums. Move from
4025 rpd_msg() to tmsg().
4026 (RPD_ERR) New #define.
4027 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
4029 (read_from_data_list_fixed) Change from old
4030 parse_string_as_format() to new data_in().
4031 (read_from_data_list_free) Ditto.
4032 (read_from_data_list_list) Ditto.
4033 (cmd_repeating_data) Modify approach to checking for end of
4036 (rpd_parse_record) Change from old parse_string_as_format() to new
4037 data_in(). Change from old convert_format_to_string() to new
4039 (read_one_set_of_repetitions) Change dfm_push_cust() to
4040 dfm_push(), pop_cust() to dfm_pop().
4042 * data-out.c: Rewritten. All references to
4043 convert_format_to_string() changed to data_out().
4045 * descript.q: Migrate to new q2c.
4046 (cmd_descriptives) Removed.
4047 (internal_cmd_descriptives) Renamed cmd_descriptives ().
4048 (custom_variables) Renamed dsc_custom_variables().
4050 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
4052 (open_file_r) Initialize h->where.line_number. Migrate to new
4054 (open_file_w) Initialize h->where.line_number.
4055 (read_record) Change from ext->ln to h->where.line_number.
4056 Migrate to struct string.
4057 (dfm_put_record) Rephrased.
4058 (dfm_push_cust) Renamed dfm_push(), rewritten.
4059 (dfm_pop) New function.
4061 * error.c: All references updated.
4062 (glob var error_count) Renamed err_err_count.
4063 (glob var warning_count) Renamed err_warning_count.
4064 (glob var error_already_flagged) Renamed err_already_flagged.
4065 (glob var verbosity) Renamed err_verbosity.
4066 (glob var cust_fn) Removed.
4067 (glob var cust_ln) Removed.
4068 (static var file_loc) New.
4069 (static var nfile_loc) New.
4070 (static var mfile_loc) New.
4071 (tmsg) New function.
4072 (push_cust) Removed.
4075 (static var terminating) Removed.
4076 (failure) Renamed err_failure().
4077 (hcf) Renamed err_hcf().
4078 (err_push_file_locator) New function.
4079 (err_pop_file_locator) New function.
4080 (err_location) New function.
4081 (check_error_count) Renamed err_check_count().
4082 (vmsg) Renamed err_vmsg(). Interface changed.
4083 (verbose_msg) Removed.
4084 (err_cond_fail) New function.
4085 (error_break) Renamed err_break().
4087 * error.h: All references updated.
4088 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
4089 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
4091 (struct file_locator) New.
4093 (macro verbose_msg) Removed.
4094 (macro cond_fail) Removed.
4096 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
4098 * expr-prs.c: Reorganized. All references updated.
4099 (exprtypename) Renamed expr_type_name().
4100 (typename) Renamed type_name().
4101 (free_expression) Renamed expr_free().
4102 (parse_expression) Renamed expr_parse(). Uses new type_check()
4104 (init_functab) Renamed init_func_tab().
4105 (type_check) New function.
4106 (parse_or) Rewritten to use new allocate_nonterminal() and
4107 append_nonterminal_arg() functions.
4110 (parse_rel) Ditto. Also simplified logic.
4115 (SYSMIS_func) Ditto.
4116 (VALUE_func) Rephrased.
4117 (CONCAT_func) Fix memory leak by replacing free by free_node on
4119 (generic_str_func) Ditto.
4120 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
4122 (allocate_nonterminal) New function.
4123 (append_nonterminal_arg) New function.
4124 (static func_tab[]) Now at file level.
4126 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
4128 * expr.h: (enum series OP_*) Moved to exprP.h.
4129 (OP_* defines) Ditto.
4130 (struct op_desc) Ditto.
4131 (global ops[]) Ditto.
4132 (struct num_con_node) Ditto.
4133 (struct str_con_node) Ditto.
4134 (struct var_node) Ditto.
4135 (struct lag_node) Ditto.
4136 (struct casenum_node) Ditto.
4137 (struct nonterm_node) Ditto.
4138 (union any_node) Members renamed.
4139 (struct sys_node) Removed.
4140 (struct val_node) Removed.
4141 (operator typedef) Removed.
4142 (typedef exprtype) Removed.
4143 (enum series EX_*) Moved to exprP.h.
4144 (struct expression) Ditto. Also renamed a lot of the members.
4145 (PXP_* defines) Changed to enums.
4146 (free_node prototype) Moved to exprP.h.
4148 * file-handle.h: (struct file_handle) New member `where'.
4150 * file-handle.q: Migrated to new q2c format.
4151 (prepend_current_directory) Removed (dead code).
4152 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
4153 (fh_get_handle_by_filename) Removed dead code.
4154 Set new `where' member.
4156 * file-type.c: (file_type_source_read) References to
4157 parse_string_as_format() changed to data_in().
4158 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
4160 * filename.c: All references updated.
4161 (init_filename) Renamed fn_init().
4162 (expand_line) Removed.
4163 (macro EXPAND_LINE) Removed.
4164 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
4165 of custom functions.
4166 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
4167 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
4168 (normalize_filename) Renamed fn_normalize().
4169 (search_path) Renamed fn_search_path(), rewritten.
4170 (prepend_dir) Renamed fn_prepend_dir().
4171 (blp_getenv) Renamed fn_getenv().
4172 (blp_dirname) Renamed fn_dirname().
4173 (fn_basename) New function, not used.
4174 (absolute_filename_p) Renamed fn_absolute_p().
4175 (is_special_filename) Renamed fn_special_p().
4176 (file_exists) Renamed fn_exists_p().
4177 (readlink_malloc) Renamed fn_readlink().
4178 (getenv_default) Renamed fn_getenv_default().
4179 (open_file) Renamed fn_open().
4180 (close_file) Renamed fn_close().
4181 (open_file_ext) Renamed fn_open_ext().
4182 (close_file_ext) Renamed fn_close_ext().
4184 * font.h: Migrate from arenas to pools.
4186 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
4188 * frequencies.g: Migrate from arenas to pools.
4190 * frequencies.q: Migrate to new q2c version. Migrate from arenas
4193 * getline.c: All references updated.
4194 (global getl_buf) Changed from char * to struct string.
4195 (static getl_include_path) Ditto.
4196 (global getl_buf_len) Removed.
4197 (global getl_buf_size) Removed.
4198 (getl_include_path) Deal with new getl_buf, getl_include_path.
4199 (getl_uninitialize) New function.
4200 (getl_get_current_directory) Rewritten.
4201 (getl_clear_include_path) Rewritten.
4202 (getl_add_include_dir) Rewritten.
4203 (getl_add_file) Assertion fixed.
4204 (getl_add_virtual_file) Change initial value of `remaining_loops'
4206 (welcome) Rewritten.
4207 (handle_line_buffer) Make static. Change logic to make
4208 getl_add_virtual_file() change sensible. Use ds_*() strings.
4209 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
4210 (getl_close_file) Moved.
4211 (getl_location) New function.
4213 * getline.h: All references updated.
4214 (macro curln) Removed.
4215 (macro curfn) Removed.
4216 (macro am_interactive) Renamed getl_am_interactive.
4217 (macro am_reading_script) Renamed getl_reading_script.
4219 * glob.c: (global fmt_parse_ignore_error) Removed.
4220 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
4221 systems that support it (C99). Turn off SET ECHO by default. No
4222 necessary julcal initialization anymore.
4224 * groff-font.c: Migrate from arenas to pools.
4225 (groff_read_font) Use err_push_file_locator().
4226 (groff_read_DESC) Ditto.
4227 (font_msg) Use tmsg().
4229 * hash.c: (hsh_sort) Fix debug code.
4230 [GLOBAL_DEBUGGING] Include stdio.h.
4232 * hash.h: (macro force_hsh_insert) Rephrase.
4234 * heap.c: Rewritten.
4236 * heap.h: Rewritten.
4238 * html.c: (html_option) Change from outp_value to struct string.
4239 (postopen) Change from curfn to getl_location().
4240 (escape_string) Remove rich-text code. Signature changed.
4241 (output_tab_table) Switch from a_string to struct len_string.
4242 Remove rich text support.
4244 * lexer.c: All references updated. Largely rewritten. Major
4245 changes listed below. Removed tagged quote support. Adapted to
4246 struct string tokstr.
4247 (global tokstr) Changed to struct string.
4248 (global tokstr_size) Removed.
4249 (global tokstr_len) Removed.
4251 (global tokint) Removed.
4252 (global toklongstr) Removed.
4253 (C* defines) Removed.
4254 (static tbl[]) Removed.
4255 (static id[]) Removed.
4256 (static une[]) Removed.
4257 (discard_line) Renamed lex_discard_line().
4258 (get_entire_line) Renamed lex_entire_line().
4259 (get_rest_of_line) Renamed lex_rest_of_line().
4260 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
4261 (make_hexit) Removed.
4262 (syntax_error) Renamed lex_error(). Return value removed.
4263 (get_token_representation) Renamed lex_token_representation().
4264 (putback) Renamed lex_put_back().
4265 (putfwd) Renamed lex_put_forward().
4266 (convert_negative_to_dash) Renamed lex_negative_to_dash().
4267 (set_prog) Renamed lex_set_prog().
4268 (init_lex) Renamed lex_init().
4269 (reset_eof) Renamed lex_reset_eof().
4270 (lookahead) Renamed lex_look_ahead().
4271 (check_id) Rewritten.
4272 (yylex) Renamed lex_get(), rewritten.
4273 (lex_end_of_command) New function. Many commands were rephrased
4275 (lex_integer_p) New function. Replaces compare of tokint against
4277 (lex_integer) New function. Replaces tokint.
4278 (match_tok) Renamed lex_match().
4279 (match_id) Renamed lex_match_id().
4280 (match_int) Renamed lex_match_int().
4281 (force_match_id) Renamed lex_force_match_id(), added return value.
4282 (force_match) Renamed lex_force_match(), added return value.
4283 (force_string) Renamed lex_force_string(), added return value.
4284 (force_int) Renamed lex_force_int(), added return value.
4285 (lex_id_match_len) New function.
4286 (id_match) Renamed lex_id_match(), rewritten.
4287 (get_line) Renamed lex_get_line().
4288 (preprocess_line) Renamed lex_preprocess_line().
4289 (tokname) Renamed lex_token_name().
4290 (bin_value_func) Removed.
4291 (oct_value_func) Removed.
4292 (hex_value_func) Removed.
4293 (unexpected_eof) New function.
4294 (convert_numeric_string_to_char_string) New function.
4295 (parse_string) Rewritten, signature changed.
4296 (add_tokstr_char) Removed.
4297 (add_tokstr_unsigned) Removed.
4298 (add_tokstr_string) Removed.
4299 (parse_tagged_quote) Removed.
4300 (skip_comment) Renamed lex_skip_comment().
4302 * lexer.h: All references updated.
4303 (macro is_id1) Renamed CHAR_IS_ID1.
4304 (macro is_idn) Renamed CHAR_IS_IDN.
4305 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
4306 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
4307 (macro get_token) Removed.
4308 (macro id_match) Removed.
4309 (macro force_match_id) Removed.
4310 (macro force_match) Removed.
4311 (macro force_string) Removed.
4312 (macro force_int) Removed.
4313 (macro force_num) Removed.
4314 (macro force_id) Removed.
4316 * lexerP.h: Removed.
4318 * list.q: Migrated to new q2c format.
4319 (write_line) Deal with struct len_string.
4320 (write_varname) Ditto.
4321 (write_fallback_headers) Ditto.
4323 * magic.c: New file, incorporating the following global variables
4324 previously in other files: endian, second_lowest_value. And both
4325 of those are conditional on #define's.
4327 * magic.h: New file, incorporating the following global variable
4328 declarations: endian, second_lowest_value, and the following macro
4329 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
4331 * main.c: Added declarations of pgmname, finished, curdate,
4333 (main) Call new parse_script() function.
4334 (parse_script) New function.
4335 (execute_command) New function.
4336 (dump_token) Removed.
4337 (handle_error) New function.
4339 * matrix.c: New file.
4341 * matrix.h: New file.
4343 * matrix-data.c: Migrated from arenas to pools.
4344 (mget_token) Change from parse_string_as_format() to data_in().
4346 * means.q: Migrate to new q2c.
4347 (custom_tables) Renamed mns_custom_tables().
4348 (custom_crossbreak) Renamed mns_custom_crossbreak().
4349 (custom_variables) Renamed mns_custom_variables().
4351 * mis-val.c: (static var width) Changed from `int' to `size_t'.
4352 (parse_varnames) Prototype.
4353 (parse_numeric) Rephrasings.
4354 (parse_alpha) Adapt to new struct string tokstr.
4356 * misc.c: (intlog10) Rewritten.
4358 (ansi_rand) Renamed real_rand(), moved into random.c.
4359 (ansi_srand) Renamed real_srand(), moved into random.c.
4360 (setup_randomize) Moved to random.c.
4361 (rand_uniform) Ditto.
4362 (rand_normal) Ditto.
4363 (rand_simple) Ditto.
4364 (get_config_line) Removed.
4365 (reverse) Removed (dead code).
4367 * misc.h: (macro SET_BIT) Moved to bitvector.h.
4368 (macro CLEAR_BIT) Ditto.
4369 (macro TEST_BIT) Ditto.
4370 (macro SET_BIT_TO) Ditto.
4371 (macro BIT_INDEX) Ditto.
4373 * output.c: (outp_read_devices) Move to err_push_file_locator()
4374 from push_cust(). Use struct string.
4375 (expand_op_tokstr) Removed.
4376 (static var op_tokstr) Changed to struct string.
4377 (static var op_tokstr_size) Removed.
4378 (tokener) Rephrasings. Use struct string.
4379 (parse_options) Use struct string.
4380 (destroy_driver) Fix assertion.
4381 (outp_get_paper_size) Move to err_push_file_locator().
4382 [0] Removed dead code.
4383 (outp_string_width) Move to len_string.
4385 * output.h: Comment fixes.
4386 (TAG_* enum series) Removed.
4387 (struct outp_value) Removed.
4388 (enum OUTP_T_FANCY) Removed.
4389 (struct outp_text) `s' changed from a_string to len_string.
4390 (struct outp_class) `option' change arg 3 from outp_value to
4393 * pfm-read.c: (corrupt_msg) Rewritten.
4395 * pfm-write.c: (bufwrite) Fix assertion.
4397 * pool.c: New file, reference version.
4399 * pool.h: New file, reference version.
4401 * postscript.c: (ps_font_sizes) Fix assertion.
4402 (ps_option) Change arg 3 from outp_value to struct string.
4403 Adapt to struct string.
4404 (macro output_line) Removed.
4405 (macro add_string) Removed.
4406 (output_encodings) Adapted to struct string. Moved to
4407 err_push_file_locator().
4408 (find_encoding_file) Fix assertion.
4409 (read_ps_encodings) Move to err_push_file_locator().
4410 (postopen) Use getl_location() instead of curfn.
4411 (out_text_plain) Move to len_string.
4412 (text) Ditto. Remove rich text support.
4414 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
4415 (cmd_print_eject) Ditto.
4417 (internal_cmd_print) Now cleans up after itself. Uses
4418 fh_parse_file_handle() now.
4419 (cmd_print_space) Use PXP_NUMERIC to type-check.
4421 * q2c.c: Overhauled. Removed _("") i18n support. All references
4422 updated. All output functions updated to handle structures rather
4423 than local or static variables. Adapt to new PSPP lex_*()
4427 (macro MAX_N_SBC) Removed.
4428 (global bare) Removed.
4429 (enum STRING) Renamed T_STRING.
4430 (enum ID) Renamed T_ID.
4431 (get_buffer) Buffer size increased.
4432 (strlower) Renamed st_lower(), rephrased.
4433 (strupper) Renamed st_upper(), rephrased.
4434 (skip_ws) New function.
4435 (get_line) Don't special-case any types of lines (like those
4436 beginning with ! or $, for instance).
4437 (get_token) Renamed lex_get(). Rephrased.
4438 (static var `prefix') New.
4439 (parse) New function.
4440 (parse_setting) Minor rephrasing.
4441 (dump_specifier_vars) Ditto.
4442 (make_identifier) Put null terminator on identifier, duh.
4443 (dump_vars) Renamed dump_declarations(). Never indent. Never
4444 static. Output changed entirely.
4445 (dump_specifier_init) Rephrase.
4446 (dump_vars_init) No index variable needed. Other modifications.
4447 (dump_parser) Don't parse command name. Do dump functions instead
4448 of just code fragments.
4449 (dump_free) Dump function instead of code fragment.
4450 (recognize_directive) New function.
4451 (main) Use recognize_directive(). Don't rely on magic $ line
4452 beginning: instead, parse comments. Update list of headers.
4454 * random.c: New file, containing the following functions:
4455 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
4456 rand_normal, rand_simple.
4458 * random.h: New file.
4460 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
4461 function. `max_src_width', `max_dst_width' changed to size_t.
4462 (internal_cmd_recode) Removed.
4463 (parse_dest_spec) Merge similar cases.
4464 (parse_src_spec) Add assertion.
4466 * repeat.c: (recognize_keyword) New function.
4467 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
4468 REPEAT. Improve recognition of END REPEAT (use
4469 recognize_keyword()). Move from curfn to getl_location(). Use
4472 (perform_DO_REPEAT_substitutions) Adapt to struct string.
4474 * set.q: Adapt to new q2c.
4475 (cmd_set) Range-check some values better.
4476 (custom_blanks) Renamed stc_custom_blanks().
4477 (custom_length) Renamed stc_custom_length().
4478 (custom_results) Renamed stc_custom_results().
4479 (custom_seed) Renamed stc_custom_seed().
4480 (custom_width) Renamed stc_custom_width().
4481 (custom_format) Renamed stc_custom_format().
4482 (custom_journal) Renamed stc_custom_journal().
4483 (custom_color) Renamed stc_custom_color().
4484 (custom_listing) Renamed stc_custom_listing().
4485 (custom_disk) Renamed stc_custom_disk().
4486 (custom_log) Renamed stc_custom_log().
4487 (custom_rcolor) Renamed stc_custom_rcolor().
4488 (custom_viewlength) Renamed stc_custom_viewlength().
4489 (custom_workdev) Renamed stc_custom_workdev().
4491 * settings.h: Not necessary to include format.h any longer.
4493 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
4494 (corrupt_msg) Rewritten.
4496 * sort.c: Adapt to rewritten heap ADT.
4498 * str.c: (aa_strcpy) Removed.
4499 (ab_strcpy) Removed.
4500 (ac_strcpy) Removed.
4501 (ba_strcpy) Removed.
4502 (bb_strcpy) Removed.
4503 (ca_strcpy) Removed.
4504 (aa_strdup) Removed.
4505 (aa_strdupcpy) Removed.
4506 (ba_strdup) Removed.
4507 (sa_strdup) Removed.
4508 (memrev) Renamed mm_reverse().
4509 (memrmem) Renamed mm_find_reverse().
4510 (cmp_str) Renamed st_compare_pad().
4511 (strmaxcpy) Removed.
4512 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
4513 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
4515 (strpadcpy) Renamed st_pad_copy(), signature changed.
4516 (blpstrset) Removed.
4517 (ds_create) New function.
4518 (ds_init) New function.
4519 (ds_replace) New function.
4520 (ds_destroy) New function.
4521 (ds_clear) New function.
4522 (ds_extend) New function.
4523 (ds_shrink) New function.
4524 (ds_truncate) New function.
4525 (ds_length) New function.
4526 (ds_size) New function.
4527 (ds_value) New function.
4528 (ds_end) New function.
4529 (ds_concat) New function.
4530 (ds_concat_buffer) New function.
4531 (ds_printf) New function.
4532 (ds_putchar) New function.
4533 (ds_getline) New function.
4534 (ds_get_config_line) New function derived from the old
4535 misc.c:get_config_line().
4536 (ls_create) New function.
4537 (ls_create_buffer) New function.
4538 (ls_init) New function.
4539 (ls_shallow_copy) New function.
4540 (ls_destroy) New function.
4541 (ls_null) New function.
4542 (ls_null_p) New function.
4543 (ls_empty_p) New function.
4544 (ls_length) New function.
4545 (ls_value) New function.
4546 (ls_end) New function.
4548 * str.h: Reformatted.
4549 (struct a_string) Removed.
4550 (struct b_string) Removed.
4551 (struct c_string) Removed.
4552 (struct len_string) New.
4553 (struct string) New.
4554 (macro as_streq) Removed.
4555 (macro bs_streq) Removed.
4556 (macro cs_streq) Removed.
4557 (macro sa_streq) Removed.
4558 (macro sb_streq) Removed.
4559 [__GNUC__] (inline function ds_putchar) New function.
4560 [__GNUC__] (inline function ds_length) New function.
4561 [__GNUC__] (inline function ds_value) New function.
4562 [__GNUC__] (inline function ds_end) New function.
4564 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
4565 (display_vectors) Fix missing i18n.
4567 * t-test.q: Migrate to new q2c.
4569 * tab.c: Migrate from arenas to pools.
4570 (tab_create) Use struct len_string.
4571 (tab_realloc) Ditto.
4572 (text_format) Ditto.
4573 (tab_joint_text) Ditto.
4574 (tab_natural_width) Remove rich text support.
4575 (tab_natural_height) Ditto.
4576 (tab_output_text) Handle TAT_FIX.
4577 (tab_raw) Change arg from a_string to len_string.
4578 (tabi_driver) Fix assertion. Use struct len_string.
4579 (render_strip) Use struct len_string. Remove rich text support.
4580 Add `const' qualifiers.
4582 * tab.h: (enum TAB_RICH) Remove.
4583 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
4584 SOM_COL_* updated to read TAB_COL_*.
4585 (struct tab_table) Change arena to pool. Change a_string to
4588 * temporary.c: (restore_dictionary) Rewrite Checker code.
4590 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
4591 LOWEST, HIGHEST) Moved here from common.h.
4592 (typedef any_trns) Removed. All references changed to `struct
4595 * vars-atr.c: (force_create_variable) Fix assertion.
4596 (force_dup_variable) Fix assertion.
4598 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
4600 Using alphanumeric variables in functions under AGGREGATE
4601 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
4602 <BZN-mdksh@t-online.de> for reporting this bug.
4604 * aggregate.c: (parse_aggregate_functions) When setting the
4605 FSTRING bit, also allocate memory for the `string' member of
4607 (free_aggregate_functions) Free iter->string. Don't use the
4608 non-function bits when indexing the array of functions.
4609 [DEBUGGING] (debug_print) Don't use the non-function bits when
4610 indexing the array of functions.
4612 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
4614 Under certain circumstances, the final case would be omitted from
4615 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
4616 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4618 * aggregate.c (agr_00x_end_func): Increment number of cases in
4619 sink before writing case. For streams that keep track of how many
4620 cases there are based on this value, this means that the last case
4621 will be read in on the next stream read.
4623 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
4625 Undefined behavior was invoked by referencing a freed pointer.
4627 * vfm.c (memory_stream_write): Free pointer *after* checking for
4630 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
4632 A wrong record size was displayed when paging the active file to
4635 * vfm.c: (memory_stream_write) Fix off-by-one error.
4637 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
4639 Not having enough temporary space for sorting caused a core dump.
4642 * sort.c: (allocate_cases) Initialize i.
4644 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
4646 Syntax errors in function descriptions on AGGREGATE caused core
4649 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
4650 free_aggregate_functions(), since that function already frees
4653 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
4655 A null pointer was dereferenced, causing a core dump, when
4656 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
4657 but PSPP still doesn't calculate percentiles. Thanks to Regnor
4658 Jernsletten <rjernsle@eunet.no> for reporting this problem.
4660 * arena.c: (arena_malloc) If the arena hasn't been initialized
4661 already, initialize it.
4663 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
4665 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
4666 for compilation with Cygnus Windows B20. Not used by other
4669 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
4671 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
4672 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4674 * sort.c: (compare_case_lists) Reverse sense of comparison if
4675 sorting in descending order.
4676 (compare_record) Ditto.
4678 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
4680 SPLIT FILE with a string variable caused a core dump. Fixed.
4682 * vfm.c: If the variable is a string then make a temporary value
4683 struct pointing to it. The underlying problem is a lot bigger
4684 than this (see TODO) but this is a stopgap for the simple case at
4687 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
4689 Nested INCLUDEs didn't work. Fixed.
4691 * getline.c: (getl_include) Set first_line to NULL in allocated
4694 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
4696 The MATCH FILES procedure set the values of variables not present
4697 to 0. It should have been SYSMIS. This is now fixed.
4699 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
4701 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
4703 The REMARK command was too aggressive about skipping lines. It
4704 didn't like being the last command in a file.
4706 * command.c: (cmd_remark) Call get_entire_line() instead of
4709 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
4711 Comment parsing wasn't consistent with the rest of the code in its
4712 idea of where one command ends and another starts. This meant
4713 that sometimes commands would be mysteriously ignored. Thanks to
4714 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4716 * command.c: (parse_cmd) Hand off comment parsing to new function
4717 skip_comment() in lexer.c.
4718 * lexer.c: (skip_comment) New function.
4720 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
4722 The TABLE subcommand on MATCH FILES worked only erratically at
4723 best. This fixes it. Thanks to Dr. Dirk Melcher
4724 <BZN-mdksh@t-online.de> for reporting this bug.
4726 * get.c: (mtf_compare_BY_values) When comparing string values, a
4727 difference of 1 is still a difference :-)
4728 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
4729 advance TABLE files automatically when matched. Comment fixes.
4731 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
4733 VARIABLE LABELS rejected a slash before the first variable
4734 specification, contradicting the documentation. Thanks to Walter
4735 M. Gray <graywm@northernc.on.ca> for reporting this bug.
4737 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
4738 command specification.
4740 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
4742 Because of an incorrect optimization in memory allocation,
4743 CROSSTABS sometimes segfaulted when asked to output multiple
4744 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4747 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
4748 are passed to output_pivot_table() for its use.
4749 (output_pivot_table) Instead of assuming the number of columns is
4750 constant, keep track with maxcols. In general mode, use maxcells
4751 to determine whether more matrix cells need to be allocated.
4753 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
4755 CROSSTABS didn't display value labels for column and row
4756 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4759 * crosstabs.q: (table_value_missing) If the specified value has a
4760 value label for this variable, then show it instead of the raw
4762 (display_dimensions) Delegate display of value_labels to
4763 table_value_missing.
4765 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
4767 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
4768 <BZN-mdksh@t-online.de> for reporting this bug.
4770 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
4771 if the file isn't declared as binary.
4773 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
4775 MATCH FILES corrupted memory and dumped core on some syntax
4778 * get.c: (cmd_match_files) Set file->handle to NULL before
4780 (mtf_free_file) Don't free a null dictionary.
4782 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
4784 MATCH FILES should set numeric values not available to the
4785 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
4786 <BZN-mdksh@t-online.de> for reporting this bug.
4788 * get.c: (mtf_processing) Set unused records to system-missing,
4791 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
4793 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
4794 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
4796 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
4797 in newly created dictionary, and add each copied variable to the
4800 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
4804 * get.c: (trim_dictionary) Free variable list for KEEP after
4807 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
4809 Some systems didn't like the way open_file was coded. Thanks to
4810 Hankin <hankin@rogue.consultco.com> for pointing this out.
4812 * filename.c: (open_file) Don't try to store stdin, stdout,
4813 stderr as part of an array, because that doesn't always work.
4815 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
4817 The SAVE procedure didn't save long string variables properly.
4818 Fixed by this patch. Thanks to Hankin
4819 <hankin@rogue.consultco.com> for this patch.
4821 * sfm-write.c: (write_variable) Fix off-by-one error in writing
4822 out variable pad records.
4824 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
4826 Previously, if PRINT SPACE were given a negative argument, it
4827 would report an error, then spin in an (almost) infinite loop.
4828 This fixes that behavior.
4830 * print.c: (print_space_trns_proc) After reporting a negative
4831 argument, set number of lines to print to 1.
4833 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
4835 SPSS 8.0 outputs some new record types in its system files, and it
4836 allows longer value labels. Accept these system files.
4838 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
4839 11 emitted by SPSS 8.0.
4841 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
4843 The LIST procedure was too conservative in allocating space for
4844 buffers, which caused a bug that only showed up with very long
4845 output variables. Thanks to Hankin <hankin@dunno.com> for this
4848 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
4850 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
4852 Typo meant string format specifiers weren't checked properly. I
4853 think that Hankin <hankin@dunno.com> sent me this report, but I'm
4854 willing to be corrected on this point.
4856 * format.c: (check_string_specifier) Fix obvious typo.
4858 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
4860 Using $CASENUM in an expression didn't work. Here's a fix.
4861 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
4864 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
4866 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
4868 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
4870 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
4871 other behavior, *sigh*. This patch hopefully fixes that. This
4872 time I've actually tested it.
4874 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
4876 * data-list.c: (read_from_data_list_free,
4877 read_from_data_list_list) Call parse_string_as_format() directly
4878 without mucking around with the field width.
4880 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
4882 Occasionally, you may encounter a script that wants to be
4883 interpreted in interactive mode. Make -i emulate this behavior to
4884 allow such scripts to be executed with PSPP.
4886 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
4888 * cmdline.c: (pre_syntax_message[]) Update -i description.
4890 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
4891 when -i is given on the command line) don't treat unindented lines
4892 as starting a new command.
4894 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
4896 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
4897 mostly caused by local initialized aggregates. After egcs is
4898 fixed upstream these can be removed, but for now they're not a big
4901 * ascii.c: (ascii_postopen_driver) Checker chokes on local
4902 initialized arrays. Avoid this.
4904 * sfm-write.c: (sfm_write_dictionary) Don't use a local
4907 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
4909 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
4910 following changes avoid. Currently I compile sources with egcs
4911 1.1.1 and gcc 2.7.2.3 before sending them out.
4913 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
4915 * ascii.c: (option_tab[]) Initialize all struct members.
4917 * avl.h: (avl_traverser_init) New macro.
4919 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
4922 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
4925 * hash.c: Comment fix.
4927 * hash.h: (hsh_iterator_init) New macro.
4929 * html.c: (option_tab[]) Initialize all struct members.
4931 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
4934 * postscript.c: (option_tab[]) Initialize all struct members.
4935 (output_encodings, preclose, dump_lines) Use new
4936 hsh_iterator_init() macro.
4938 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
4941 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
4944 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
4946 * data-in.c: Examined each of the parsing functions to make sure
4947 that they wouldn't dump core if they were passed a string of the
4948 wrong length, since now the DATA LIST FREE/LIST routines don't
4949 check for field width before passing it to the data parser.
4950 (parse_RBHEX, parse_AHEX) Reject odd length input.
4951 (parse_string_as_format) Reject input that's too short or too
4954 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
4955 a field to its entire declared output width then pass it to the
4956 data-in parsing routines. This contradicted the documented
4957 behavior. This is fixed in these changes. Thanks to Mark H. Wood
4958 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
4959 free-format parsing that differed from SPSS.
4960 (cut_field) Commas and spaces are treated identically. Returns
4961 the proper column instead of a fixed 1 value.
4962 (parse_field) Removed.
4963 (read_from_data_list_free, read_from_data_list_list) Call
4964 parse_string_as_format directly instead of parse_field.
4966 * heap.c: (heap_delete) Stylistic fixes.
4968 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
4970 * loop.c: (loop_2_trns_proc) Formatting fix.
4972 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
4974 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
4976 * vfm.c: (macro FILTERED) New.
4977 (static var filter_var) New.
4978 (process_active_file_write_case) Use FILTERED.
4979 (setup_filter) Set filter_var.
4980 (close_active_file) Delete the filter if not
4981 FILTER_before_TEMPORARY.
4982 (procedure_write_case) Use FILTERED.
4984 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
4986 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
4988 * data-in.c: (parse_day_count) Message fix.
4989 (parse_month) Style fix.
4991 * data-list.c: (struct data_list_pgm) New member eof.
4992 (cmd_data_list) Init eof to 0.
4993 (do_reading) Implement the /END subcommand and read-past-eof
4996 * do-if.c: Include stdio.h when debugging.
4997 (cmd_else_if) Make sure the command is .-terminated.
4999 * glob.c: (init_glob) Capitalize the command prompt.
5001 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
5002 (end_file_trns_proc) Debugging message.
5004 * loop.c: (internal_cmd_loop) Make it work when there's no loop
5006 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
5008 * main.c: (dump_token) Make kwtab[] const.
5010 * set.q: Spelling, comment fixes.
5012 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
5015 * vars-prs.c: (fill_all_vars) Style fix.
5017 * vfm.c: (index_to_varname) Return const.
5019 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
5021 * Changes in many source files for partial -ansi -pedantic and
5022 no-debugging compliance: Remove trailing common in enum
5023 declarations; add `unused' attributes; insert some appropriate
5026 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
5028 * command.c: (shell) Make static.
5029 (run_command) Make static.
5031 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
5033 * dfm.c: (cmd_begin_data) I18n fix.
5035 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
5037 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
5039 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
5042 * file-handle.q: Don't prepend the source file directory name to
5043 the data file name. (Ongoing issue.)
5044 (prepend_current_directory) Comment out.
5045 (internal_cmd_file_handle) Don't call prepend_current_directory().
5046 (fh_get_handle_by_filename) Ditto.
5048 * filename.c: Append zero byte to readlink() return value.
5050 * getline.c: (getl_read_line) I18n fix.
5052 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
5054 * misc.h: Don't use gcc features if __STRICT_ANSI__.
5056 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
5059 * postscript.c: (output_encodings) Don't use local_strdup().
5062 * print.c: Don't use gcc features if __STRICT_ANSI__.
5064 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
5066 * recode.c: (parse_src_spec) Fully brace nested if's.
5068 * set.q: (global var set_testing_mode) New var.
5070 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
5072 * ascii.c: Add some more `unused' attributes that only come into
5073 play when NDEBUG is defined.
5074 (ascii_close_page) Set s_len when reallocating s.
5076 * crosstabs.q: (delete_missing) New function.
5077 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
5078 (make_summary_table) Create summary table reallocable.
5080 * postscript.c: Add more `unused' attributes as above.
5082 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
5083 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
5085 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
5088 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
5089 gratuitous space between parameter definition.
5091 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
5092 complaints about running off the end of functions with NDEBUG
5095 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
5097 * Several source files: Removed some PORTME notes when reflection
5098 revealed that ANSI forbids that sort of breakage. Also, added
5099 lots of `unused' qualifiers here and there.
5101 * aggregate.c: (accumulate_aggregate_info) Remove local var
5102 weighting that turned out not to be used.
5104 * avl.c: Update to version 1.1.0. Add unused specifier.
5105 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
5107 (avl_probe) Replace some instances of 1 with +1 where appropriate.
5108 (avl_find) Cast return value to void *.
5109 (avl_delete) q doesn't need to be initialized at the beginning of
5110 the function. Replace some instances of 1 with +1.
5111 (force_avl_delete) Renamed avl_force_delete, all references changed.
5112 (compare_ints) `param' marked unused.
5113 (print_int) `param' marked unused.
5114 (recurse_tree) Replace some instances of 1 with +1.
5116 * avl.h: Update to version 1.1.0. Only declares avl function
5117 types if not already declared.
5118 (AVL_MAX_HEIGHT) Only define if not already defined.
5119 (struct avl_node) New unused member char pad[2].
5120 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
5121 (force_avl_insert) Renamed avl_force_insert.
5122 (force_avl_delete) Renamed avl_force_delete.
5124 * crosstabs.q: (struct table_entry) Put `freq' into a union with
5126 (struct crosstab) Add new member `ofs'.
5127 (glob var int_tab) Removed.
5128 (custom_tables) In integer mode, assign v[i] properly through the
5130 (custom_variables) Now p.crs.max == max + 1.
5131 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
5132 (precalc) Implement integer mode.
5133 (calc_integer) Implement integer mode.
5134 (compare_table_entry) Remove unused local variable `comparing'.
5135 (make_summary_table) Implement integer mode.
5136 (macro ns_rows) Implemented as static variable now.
5137 (several variables) Made static, from global.
5138 (output_pivot_table) Use table_value_missing() for column heads.
5139 Remove several unused local variables. Implement integer mode
5140 table summing. Count up ns_rows.
5141 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
5142 (find_pivot_extent) Moved into find_pivot_extent_general; now just
5143 calls that function or find_pivot_extent_integer.
5144 (find_pivot_extent_integer) New function.
5145 (enum_var_values) Implemented for integer mode.
5146 (table_value_missing) New function.
5147 (display_dimensions) Call table_value_missing() for heads.
5148 (float_M_suffix) New function.
5149 (display_crosstabulation) Call table_value_missing() for row
5150 heads. Handle missing values in /MISSING=REPORT mode.
5151 (calc_fisher) Remove unused var N.
5152 (calc_r) Remove unused var fact.
5154 * data-list.c: (dump_fixed_table) Fix table dimensioning.
5155 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
5157 * data-out.c: (insert_commas) Remove unused var cp.
5158 (convert_CCx) Remove unused vars save_set_decimal,
5161 * descript.q: (dump_z_table) Fix table dimensioning.
5162 (pre_calc) Remove unused var j.
5163 (display) Remove unused vars title, s. Fix table dimensioning.
5165 * expr-evl.c: Comment fixes.
5167 * frequencies.q: (full_dim) New function.
5168 (dump_full) Fix table dimensioning.
5169 (condensed_dim) New function.
5170 (dump_condensed) Fix table dimensioning.
5172 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
5175 * html.c: (html_close_drive) Remove unused var i.
5176 (postopen) Remove unused vars title, curfn_len, cp.
5177 (preclose) Remove unused vars this, x.
5179 * lexer.c: Comment fixes.
5181 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
5183 * means.q: (custom_tables) Remove unused var m_dim.
5185 * mis-val.c: Format fix.
5187 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
5189 * output.c: (outp_get_paper_size) Remove unused var cp.
5191 * pfm-read.c: (read_float) Remove unused var save, unused label
5193 (read_variables) Remove unused vars cp, j.
5194 (read_value_label) Remove unused var j.
5196 * pfm-write.c: (bufwrite) Remove unused var i.
5198 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
5200 (output_encodings) Remove unused vars char_cp, n_output.
5201 (read_ps_encodings) Remove unused var ep.
5202 (postopen) Remove unused var title.
5203 (preclose) Remove unused var fp.
5204 (ps_open_page) Remove unused vars true, false, orientation,
5205 mirror_horz, mirror_vert, width, length.
5206 (ps_text_metrics) Remove unused var x.
5208 * q2c.c: (find_symbol) Remove unused var y.
5209 (parse_setting) Remove unused parameter sbc, all references
5211 (dump_parser) Remove unused var cp.
5212 (dump_free) Remove unused var i.
5214 * set.q: (static vars args, n) Removed.
5215 (internal_cmd_gset) Removed.
5217 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
5218 (read_machine_flt64_info) Removed unused var file_endian.
5219 (read_documents) Removed unused var i.
5220 (read_compressed_data) Removed unused parameter dict, all
5223 * sfm-write.c: (bufwrite) Removed unused var i.
5224 (sfm_write_case) Removed unused var i.
5226 * sort.c: (merge_once) Remove unused var t.
5227 (write_separate) #if 0 out as dead code.
5229 * split-file.c: (cmd_split_file) Remove unused var i.
5231 * sysfile-info.c: (sysfile_info_dim) New function.
5232 (cmd_sysfile_info) Fix table dimensioning.
5233 (variables_dim) New function.
5234 (display_variables) Fix table dimensioning.
5235 (describe_variable) Remove unused var prev_r.
5237 * t-test.q: (z_postcalc) Removed.
5238 (pairs_calc) Remove unused var bad_weight.
5239 (postcalc) Remove unused vars dfn, dfd.
5241 * tab.c: (tab_create) Set t->dim to NULL.
5242 (tab_dim) Make sure t->dim is NULL first.
5243 (tab_natural_width) Remove parameter `clamp'.
5244 (tab_value) Remove duplicate assertion for table.
5245 (tab_raw) New function.
5246 (nowrap_dim) New function.
5247 (wrap_dim) New function.
5248 (tab_output_text) Fix table dimensioning.
5250 * tab.h: (tab_raw) New macro.
5252 * val-labs.c: (get_label) Remove unused var type.
5253 (copy_value_labels) Remove unused var trav.
5255 * var.h: (struct crosstab_proc) Completely changed.
5257 * vars-prs.c: (parse_dict_variable) Remove unused var v.
5259 * vfm.c: (open_active_file) Remove unused vars i, lp.
5261 * weight.c: (weight_trns_proc) #if 0 out as dead code.
5263 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
5265 * Makefile.am: Add apply-dict.c, flip.c.
5267 * apply-dict.c: New file.
5269 * command.c: (struct command) Make cmd[] larger for CLEAR
5270 TRANSFORMATIONS command name.
5271 (parse_cmd) Make sure we're in a valid state before using it as an
5272 index. Discard variables and reset state on invalid transitions.
5273 (cmd_clear_transformations) New function.
5275 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
5276 Add unimplemented PRESERVE, RESTORE.
5278 * file-handle.h: Include stddef.h.
5282 * pfm-read.c: (parse_value) Pad value label values with spaces,
5285 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
5286 (sfm_close) Decrement reference count, make sure it's zero.
5287 (sfm_maybe_close) New function.
5288 (sfm_read_dictionary) Handle reference counts.
5290 * vars-atr.c: (clear_default_dict) New function.
5291 (discard_variables) Use clear_default_dict().
5293 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
5295 * Makefile.am: Add pfm-write.c.
5296 (LDADD) Add the libgmp2 libraries.
5298 * command.def: Define EXPORT.
5300 * get.c: (cmd_export) New function.
5301 (export_write_case_func) New function.
5303 * pfm-read.c: (static spss2ascii[]) Make it const.
5305 * pfm-write.c: New file.
5307 * sfm-write.c: Formatting, comment fixes.
5309 * var.h: Comment fix.
5311 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
5313 * Makefile.am: Add pfm.h, pfm-read.c.
5315 * command.def: IMPORT is now implemented.
5317 * format.c: (glob var translate_fmt[]) New var.
5319 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
5320 (cmd_import) New function.
5321 (import_source_read) New function.
5322 (glob var import_source) New var.
5324 * pfm-read.c: New file.
5328 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
5330 (dump_dictionary) Disabled printing a couple of items.
5332 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
5334 * crosstabs.q: (postcalc) Call make_summary_table().
5335 (make_summary_table) New function.
5336 (insert_summary) New function.
5337 (display_dimensions) Remove some unnecessary arguments, all
5339 (output_pivot_table) Fix lots of problems with the risk table
5341 (submit) Don't display an empty table.
5342 (display_risk) Fix order of arguments to calc_risk().
5344 * glob.c: Always include assert.h and stdlib.h.
5346 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
5349 * tab.c: (tab_create) Cosmetic changes.
5351 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
5353 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
5357 * crosstabs.q: (output_pivot_table) Headers drawing and submission
5358 code simplified, moved into new function submit().
5359 (submit) New function.
5360 (crosstabs_dim) New function.
5361 (display_directional) Substitute variable names for %s where
5363 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
5364 (calc_symmetric) Initialize parameters only if non-NULL.
5365 Calculate Somers' d.
5366 (calc_directional) Calculate Somers' d (or copy it, really).
5369 * output.c: (outp_string_width) New function.
5371 * postscript.c: (postopen) Calculate font widths based on the
5372 width of the zero '0' character, not the width of the space
5373 character. Set paper-width and paper-length based on points, not
5375 (ps_open_page) Fix page setup string for landscape mode.
5377 * som.h: (struct som_dimension) Removed.
5378 (struct som_table_class) height, width members take int * not
5381 * tab.c: Many functions now have added parameter validation.
5382 (tab_height, tab_width) These functions were removed and merged
5383 into a single function tab_resize(), and all references changed.
5384 (tab_dim) Rewritten since the interface changed; reduced from
5385 hundreds of lines to two. All callers were changed. Currently
5386 most of them just use tab_natural_dimensions as their callback and
5387 await detailed translation of functionality.
5388 (tab_natural_width) New function.
5389 (tab_natural_height) New function.
5390 (tab_natural_dimensions) New function. This is a callback
5391 function, not something that you'd want to call directly.
5392 (tab_nat_dim) Removed.
5393 (tabi_table) Allocates t->w and t->h.
5394 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
5395 dimensions callback.
5396 (evaluate_dimensions) Removed.
5397 (sum_columns) Removed.
5399 * tab.h: (enum TAL_1THIN) Removed.
5400 (enum series t_*) Removed.
5401 (struct tab_table) Members trh, trv changed to unsigned char *
5402 from int *. Member dim changed to a function pointer from a
5403 unsigned char *. Member max_stack_height removed. New members
5405 (macros tab_l, tab_r, tab_t, tab_b) New.
5407 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
5409 * ascii.c: (delineate) Assign last_space_nchars before skipping
5410 spaces, to fix right justification.
5412 * crosstabs.q: (static vars risk, direct) New vars.
5413 (static var pearson_r) Removed.
5414 (glob var chisq_fisher) Made static.
5415 (static vars row_tot[], col_tot[]) Don't include grand total
5417 (static var grand_total) Renamed W, all references changed.
5418 (output_pivot_table) Only make `table' if num_cells != 0. Make
5419 risk and directional tables. Deal with grand total no longer part
5420 of col_tot[]. Free rows and cols after we're done with them.
5421 (display_risk) New function.
5422 (display_directional) New function.
5423 (clac_r) Rewritten so that it stores all its results into its
5424 arguments, so it can be used for Spearman's correlation too.
5425 (calc_symmetric) Added a t[] argument, all references changed.
5426 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
5427 Pearson's r, Cohen's kappa.
5428 (calc_risk) New function.
5429 (calc_directional) New function.
5431 * som.c: (som_submit) Improved debugging code.
5433 * stats.c: (hypercube) New function.
5434 (cube) New function.
5436 (normal_sig) Went back to old implementation, which actually
5439 * stats.h: (macros square, cube, hypercube) Removed. The
5440 equivalent functions in stats.c are inlined here; all references
5441 to square changed to sqr.
5443 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
5445 * crosstabs.q: (N_SYMMETRIC) New define.
5446 (postcalc) Disable debug printing.
5447 (static vars chisq_fisher, pearson_r) New.
5448 (output_pivot_table) Add support for symmetric measures. Add
5449 chi-square output of exact sigs.
5450 (display_chisq) Rewritten.
5451 (display_symmetric) New function.
5452 (gamma_int) New function.
5454 (swap) New function.
5455 (calc_fisher) New function.
5456 (calc_chisq) Check boundary conditions better. Calculate Yates,
5457 Fisher, Mantel-Haenszel tests.
5458 (calc_r) New function.
5459 (calc_symmetric) New function.
5461 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
5463 (chisq_sig) Better boundary conditions. Renamed from
5466 * tab.h: (struct tab_table) New member cf.
5468 * tab.c: (tab_create) Set cf.
5469 (tab_width) New function.
5470 (tab_realloc) Handle cf.
5471 (tab_vline) Handle cf.
5472 (tab_hline) Handle cf.
5473 (tab_box) Handle cf.
5474 (tab_value) Handle cf.
5475 (tab_float) Handle cf.
5476 (tab_text) Handle cf.
5477 (tab_joint_text) Handle cf.
5478 (tab_offset) Handle cf.
5479 (tab_next_row) Handle cf.
5480 (evaluate_dimensions) Handle cf.
5481 (render_strip) Handle cf.
5483 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
5485 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
5486 output_pivot_table().
5487 (output_pivot_table) Moved lots of local variables outside and
5488 made them static. Add beginnings of chi-square statistic
5489 support. Now column and row totals aren't in the main matrix.
5490 Always zero out any leftover rows & columns after we're done with
5491 the table entries. Move all output stuff into
5492 display_dimensions(), display_crosstabs(), display_chisq().
5493 (display_dimensions) New function.
5494 (display_crosstabulation) New function.
5495 (display_chisq) New function.
5496 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
5498 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
5499 references, simplify logic.
5501 * postscript.c: Remove scale, translate-x, translate-y,
5502 mirror-horz, mirror-vert, rotate-180 options.
5503 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
5504 All references deleted.
5505 (macro YT) New macro.
5506 (array option_tab[]) Removed options.
5507 (ps_option) Removed options.
5508 (ps_open_page) Write page setup explicitly to output file, without
5509 using now-deleted BP function.
5510 (macro dump_line) Use YT().
5511 (macro dump_thick_line) Use YT().
5512 (draw_headers) Use YT().
5513 (switch_font) Reorder arguments to SF function.
5514 (write_text) Use YT().
5516 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
5519 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
5521 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
5522 null-debugging code.
5523 (tab_realloc) Remove null-debugging code. Initialize new regions
5525 (tab_vline) Support offsets.
5526 (tab_hline) Support offsets.
5527 (tab_box) Support offsets.
5529 (tab_nulls) Removed.
5532 (evaluate_dimensions) Remove null-debugging code. Understand
5533 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
5534 TAB_EMPTY not present.
5536 * tab.h: New cell attribute TAB_EMPTY.
5537 (macros tab_nr, tab_nc, tab_row, tab_col) New.
5539 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
5540 try to read them from system files.
5542 * vfm.c: (dump_splits) Don't call tab_null().
5544 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
5546 * crosstabs.q: (struct crosstab) Added `missing' member.
5547 (custom_tables) Init missing.
5548 (calc_general) Handle missing values.
5549 (calc_chisq) New function.
5550 (output_pivot_table) Start work on chi-square output. Update for
5551 new tab offset support functions. Shorten statistic names.
5553 * Several files: add in more `const's to placate gcc's warnings.
5555 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
5558 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
5559 tab_null, tab_nulls, tab_value, tab_float, tab_text,
5560 tab_joint_text) Add col_ofs and row_ofs support.
5561 (tab_offset) New function.
5562 (tab_next_row) New function.
5563 (tab_row) New function.
5564 (tab_col) New function.
5565 (tabi_table) Add col_ofs and row_ofs support.
5567 * vars-atr.c: (is_system_missing) New function.
5569 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
5571 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
5572 (static var no_cells) Removed.
5573 (static var num_cells) New.
5574 (static var expected) New.
5575 (static var cells[]) New.
5576 (internal_cmd_crosstabs) Deal with new variables.
5577 (postcalc) Removed most of the meat and put it in new function
5578 output_pivot_table().
5579 (output_pivot_table) Calculates and outputs an entire pivot table.
5581 * postscript.c: (postopen) Fix problems with free()ing addresses
5582 not obtained from malloc().
5584 * som.c: (som_submit) Add assertion.
5586 * sysfile-info.c: (describe_variable) Use new tab_nulls()
5589 * tab.c: (static var tab_names[]) New.
5590 (tab_realloc) -1 for nc or nr indicates no change.
5591 (tab_nulls) New function.
5592 (tab_dim) Use tab_names[].
5593 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
5594 (evaluate_dimensions) Don't terminate on uninited cells, just put
5595 an X in them and emit a notice. Use tab_names[].
5597 * tab.h: Move bits into tab.def.
5599 * tab.def: New. Don't try to declare tab_table_class because then
5600 som.h has to be included.
5602 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
5604 * command.def: New file, contains all the command definitions
5605 previously included bodily in command.c.
5607 * format.def: New file, contains all of the format definitions
5608 previously split across format.h, format.c, and sfm-write.c.
5610 * lexer.h: Renamed from tokens.h in order to match corresponding
5613 * lexerP.h: Moved some rarely used functions exported by lexer.c
5616 * Makefile.am: Commemorate renamed files.
5617 (EXTRA_DIST) Add command.def, format.def.
5619 * command.c: [0] (walk_cmdtable_func) Removed.
5621 * crosstabs.q: (postcalc) Made it work and print out matrices
5623 (enum_column_values) Renamed enum_var_values, generalized for any
5626 * format.h: (struct fmt_desc) New member `spss'.
5628 * q2c.c: (main) Generated code includes lexer.h instead of
5631 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
5632 instead of an independent translation table.
5634 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
5636 * Lots of source files: Added const to declarations.
5638 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
5640 * arena.c: (arena_clear) Set prev pointer to null when done.
5642 * ascii.c: (ascii_option) Rename index as indx.
5644 * avl.c: This is now a separate library called libavl.
5645 (xmalloc) Make static.
5646 (avl_probe) Step A7 can use the cache instead of an explicit
5648 (avl_delete) Don't maintain a q pointer because it's always
5649 available in the pointer stack. Comment fix.
5651 * avl.h: This is now a separate library called libavl.
5653 * command.c: (cmd_table[]) Remove spurious trailing "".
5655 * common.h: Only include random() fix if this system needs it.
5657 * crosstabs.q: Include alloca headers.
5658 (n_sorted_tab) New global var.
5659 (postcalc) Mostly rewritten.
5660 (find_pivot_extent) Rewritten.
5661 (enum_column_values) Rewritten.
5663 * data-out.c: (convert_F) Rename inner n as n_spaces.
5665 * error.c: (dump_message) Don't have an outer var i.
5667 * file-handle.q: (static var f) Removed. All references removed.
5668 (internal_cmd_file_handle) Uses a local variable instead of f.
5670 * get.c: (trim_dictionary) Change scope of i, i1, i2.
5671 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
5674 * getline.h: Declare getl_history as extern. Reported by
5675 palme@uni-wuppertal.de (Hubert Palme).
5677 * postscript.c: (postopen) Some large mods for constness.
5679 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
5682 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
5684 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
5685 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
5688 * avl.c, avl.h: New files. These form a clean-room
5689 reimplementation of avllib. Iterative algorithms are used in
5690 place of recursive ones, so there is no resemblance in the code.
5692 * Lots of headers: Don't include other headers by default.
5694 * Lots of source files: Explicitly include all needed headers.
5696 * arena.c: (arena_clear) New function.
5698 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
5699 (static var ar) Removed.
5700 (staitc vars ar_tc, ar_col) New.
5701 (cmd_crosstabs) Destroy the arenas.
5702 (internal_cmd_crosstabs) Create the arenas.
5703 (precalc) Don't need a free function for the hash.
5704 (calc_general) Make sure to zero out the trailer on the key data
5706 (print_table_entries) Updated.
5707 (postcalc) Worked on actually implementing.
5708 (find_pivot_extent) New function.
5709 (compare_value) New function.
5710 (enum_column_values) New function.
5712 * data-in.c: (parse_month) Make local array `static const'.
5714 * data-out.c: (convert_date) Make local array `static const'.
5715 (convert_WKDAY) Same.
5716 (convert_MONTH) Same.
5718 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
5719 been renamed to avl_walk().
5721 * hash.c: Rewritten more efficiently.
5723 * hash.h: Add attribute const to hsh_next_prime declaration.
5725 * lexer.c: (id_match) Make arguments const.
5727 * postscript.c: (ps_postopen_driver) Make default fonts the
5730 * q2c.c: (main) Generated code needs stdlib.h.
5732 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
5733 initialized to 0 now, not to NULL. All other references to
5734 avl_traverser were updated in the same way.
5736 * tokens.h: Macro version of id_match updated to use const
5739 * val-labs.c: (inc_ref_count) New function.
5740 (copy_value_labels) Simply through use of new avl_copy() function.
5742 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
5744 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
5745 (postcalc) Worked on this.
5747 * postscript.c: (OPO_DOUBLE_LINE) New enum.
5748 (struct ps_driver_ext) New line_width_thick member.
5749 (ps_preopen_drive) Init line_width_thick.
5750 (option_tab[]) Add line-* options.
5751 (ps_option) Parse line-* options.
5752 (postopen) Add line_width_thick support. Strip leading spaces on
5753 prologue output lines.
5754 (ps_open_page) Include line_width_thick in output.
5755 (macro dump_thick_line) New.
5756 (dump_fancy_line) Support thick lines as well as double lines.
5758 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
5760 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
5761 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
5763 * Many source files: Rename `options' to `pv_opts' as appropriate.
5765 * command.c: (static var cmd_table[]) Add CROSSTABS command.
5767 * common.c: (xcalloc) New function.
5769 * crosstabs.q: New file. Not finished yet, though.
5771 * data-list.c: Comment fix.
5773 * error.c: Remove some old Checker cruft.
5775 * frequencies.q: (dump_full) Cumulate valid percent instead of
5778 * getline.c: Comment fix.
5780 * hash.c: Comment fixes.
5782 * hash.h: (struct hsh_table) Make hash functions return unsigned
5783 instead of int to avoid problems with taking the modulo of
5784 negative return values. All references changed.
5786 * misc.c: (intlog10) Make its table static const instead of auto.
5788 * sfm-read.c: (read_header) Make `prefix' static const instead of
5791 * var.h: (union value) Add member `hash'.
5792 (struct variable) Rename prv_index as `foo'--all references
5794 (typedef pv_opts) Removed. All references changed.
5796 * vars-prs.c: (parse_variables) Message fixes.
5798 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
5800 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
5801 they are being inserted. Don't check for BY variables of
5802 different types. Discard variables if the active file isn't
5803 included in the merge.
5804 (mtf_processing) Essentially rewritten.
5805 (mtf_merge_dictionary) Check for master/slave variables of
5806 different types/widths.
5808 * vfm.c: (static var not_canceled) New var.
5809 (process_active_file) Don't call vfm_source->read() if
5810 there's no vfm-source. Initialize not_canceled.
5811 (process_active_file_write_case) Honor and update not_canceled.
5812 (prepare_for_writing) Rollback changes from yesterday, they were
5814 (close_active_file) Don't destroy vfm_source unless it exists.
5816 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
5818 * Lots of source files: Added { } around nested if/else constructs
5819 to avoid new gcc 2.8 warnings.
5821 * data-in.c: (parse_Z) Declare `int' type explicitly.
5824 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
5825 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
5826 prev members. Put TABLEs at the end of the chain and FILEs at the
5827 beginning. Don't allow the active file in STATE_INIT. Use proper
5828 `seen' value for the active file. Fill out the by members and
5829 make sure they're of consistent type. Do the actual merge
5831 (mtf_processing_finish) New function.
5832 (var_type_description) New function.
5833 (mtf_free_file) New function.
5834 (mtf_free) Rewritten.
5835 (mtf_delete_file_in_place) New function.
5836 (mtf_read_nonactive_records) New function.
5837 (mtf_compare_BY_values) New function.
5838 (static var mtf_seq_no) New var.
5839 (mtf_processing) New function.
5840 (mtf_merge_dictionary) Assign nval members for the system file
5841 dictionary. Assign fv values for its variables. Point each slave
5842 variable to the corresponding master variable.
5844 * hash.c: Include str.h.
5846 * mis-val.c: (copy_missing_values) src arg is const.
5848 * misc.c: (spacing) Make `max' var explicitly int.
5850 * sfm-read.c: (dump_dictionary) Message reformatting.
5851 (sfm_read_case) Add assertion.
5853 * sort.c: Esthetic fixes.
5855 * var.h: (struct match_files_proc) New struct.
5856 (struct variable) Add private data match_files_proc.
5858 * vars-atr.c: (delete_variable) Implement. Add argument for the
5859 dictionary that owning the variable.
5860 (dup_variable) Add assertion.
5862 * vfm.c: Comment fixes, hopefully the comments are correct now.
5863 (process_active_file) New function.
5864 (process_active_file_write_case) New function.
5865 (process_active_file_output_case) New function.
5866 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
5868 (write_case) Renamed procedure_write_case(). Now write_case is a
5869 pointer to a function. Style fixes.
5871 1998-03-05 Ben Pfaff <blp@gnu.org>
5873 * Makefile.am: (q2c) Link with libmisc.
5874 (version.c) Define default_config_path, include_path,
5877 * ascii.c: (ascii_postopen_driver) When the default newline string
5878 is requested, open file in text mode. Suggested by
5879 palme@uni-wuppertal.de (Hubert Palme).
5880 (static vars line_buf, line_p) Change from char * to unsigned char
5882 (ascii_close_page) char * to unsigned char *.
5884 * cmdline.c: (parse_command_line) Implement -r option by
5885 prepending ~/.pspp/rc to the list of files to process.
5887 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
5888 before pulling in a final line.
5889 (null_func, null_int_func) Removed (dead code).
5891 * descript.q: (display) Calculate width of variable name column
5892 properly. Calculate number of valid cases properly. Reported by
5893 palme@uni-wuppertal.de (Hubert Palme).
5895 * filename.c: (init_filename) Use default_config_path instead of
5896 now obsolete CONFIG_PATH.
5898 * getline.c: (getl_initialize) Use include_path instead of now
5899 obsolete INCLUDE_PATH.
5900 (getl_add_file) New argument `where'. All references changed.
5902 * groff.c: (find_font_file) Use groff_font_path instead of now
5903 obsolete GROFF_FONT_PATH.
5905 * postscript.c: (find_ps_file) Use groff_font_path instead of now
5906 obsolete GROFF_FONT_PATH. Copy through temporary variable to
5907 avoid problems with constness.
5909 * str.h: (macro cs_streq) New macro.
5911 * version.h: (glob var default_config_path, include_path,
5912 groff_font_path) New vars.
5914 1998-02-23 Ben Pfaff <blp@gnu.org>
5916 * Many source files: Change verbose_msg() priority levels and
5919 * aggregate.c: Include debug-print.h.
5921 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
5923 (static var pre_syntax_message) Document --safer/-s and
5926 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
5928 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
5929 because it's not used but it's still copied.
5930 (open_file_r) Remove gratuitous debug message.
5932 * filename.c: (safety_violation) New function.
5933 (open_file) Remove gratuitous debug messages. Don't allow pipe
5934 files if set_safer is set.
5936 * get.c: Turn off debugging.
5938 * getline.c: (getl_add_virtual_file) New function.
5939 (getl_read_line) Add verbose_msg() call for opening new syntax
5941 (getl_perform_delayed_reset) Add a return value describing whether
5942 any action was taken. Call reset_eof().
5944 * getline.h: Comment fix.
5946 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
5947 place of incorrect `continue'. Use strtok_r() instead of
5948 strtok(). Always check strtok_r() return value.
5949 (groff_read_DESC) Use strtok_r() instead of strtok().
5951 * lexer.c: (reset_eof) New function.
5953 * main.c: (parse) Get a token after performing a delayed reset
5954 action; allow empty syntax files.
5956 * postscript.c: (output_encodings) Use strtok_r() instead of
5959 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
5961 * set.q: Comment fixes.
5962 (glob var set_safer) New var.
5963 (internal_cmd_set) Support SAFER.
5965 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
5967 * temporary.c: (free_dictionary) Set d->splits to NULL after
5970 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
5971 variable deleted, not if it *isn't* deleted.
5973 1998-02-16 Ben Pfaff <blp@gnu.org>
5975 * command.c: (array cmd_table[]) Add MATCH FILES.
5977 * common.c: Comment fixes.
5979 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
5980 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
5981 Include alloca.h. Problem reported by palme@uni-wuppertal.de
5984 * expr-opt.c: Include str.h. Problem reported by
5985 palme@uni-wuppertal.de (Hubert Palme).
5987 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
5988 (static var mtf_by) Change from char ** to variable **.
5989 (static var mtf_master) New var.
5990 (mtf_merge_dictionary) New function.
5991 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
5992 var type. Reorder tests properly. Initialize file->dict. Detect
5993 TABLE= without BY=. Read file dictionaries and merge them. Give
5994 subcommand name with IN, LAST, FIRST error messages. Create IN,
5995 LAST, FIRST variables. Comment fixes.
5996 (mtf_free) Don't free default_dict. Free mtf_master.
5998 * getline.c: Define getl_mode. Change getl_buf_size to size_t
6000 (handle_line_buffer) Cast int to size_t in comparison to avoid
6003 * getline.h: Declare getl_mode extern.
6005 * groff-font.c: (groff_read_font) Type-fix calls to getline.
6006 (groff_read_DESC) Make line_size a size_t.
6007 (match_tok) Parenthesize name to avoid macro expansion.
6009 * mis-val.c: (copy_missing_values) New function.
6011 * postscript.c: (postopen) Make buf_size a size_t.
6013 * sfm-read.c: (dump_dictionary) Make global from static. Print
6014 variable info in parts for easier debugging with Checker.
6016 * temporary.c: (copy_variable) Use copy_value_labels().
6017 (new_dictionary) New arg: whether to copy file label, documents.
6019 * val-labs.c: (copy_value_labels) New function.
6021 * var.h: (enums MISSING_*) Add MISSING_COUNT.
6023 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
6025 (dup_variable) Set prv_index, get.fv, get.nv.
6027 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
6029 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
6031 * Many source files: For ANSI-compliance, add empty statement
6032 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
6033 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6035 * data-in.c: (parse_numeric) Some header files break on
6036 -DBL_MIN_10_EXP because they get a --; add () for safety.
6037 Reported by palme@uni-wuppertal.de (Hubert Palme).
6039 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
6040 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
6041 (dfm_close) Use close_file_ext.
6042 (open_inline_file) Set file.file to NULL, not file.
6043 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
6044 struct and use open_file_ext().
6045 (read_record) Use file.file.
6047 * file-handle.q: (prepend_current_directory) Pass through special
6050 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
6051 (normalize_filename) Pass through special filenames.
6052 (open_file, close_file) Accept pipe| and |pipe syntaxes as
6054 (dirname) Rename blp_dirname() because of name conflict on some
6055 OS. All references changed. Reported by palme@uni-wuppertal.de
6057 (is_special_filename) New function.
6059 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
6060 (trim_dictionary) Conditionalize some of the options on whether
6061 GTSV_OPT_MATCH_FILES is in *options.
6062 (rename_variables) Don't allow variables to be renamed as scratch
6064 (MTF_*) New enum series.
6065 (struct mtf_file) New struct.
6066 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
6068 (cmd_match_files, mtf_free) New functions.
6070 * lexer.c: (match_int) Needed parentheses around name to escape
6071 macro expansion. Reported by Micah Altman
6072 <maltman@www-vdc.fas.harvard.edu>.
6074 * print.c: Needed to include alloca.h. Reported by Micah Altman
6075 <maltman@www-vdc.fas.harvard.edu>.
6077 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
6078 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
6081 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
6082 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6084 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
6086 * html.c: (struct html_driver_ext) Move into htmlP.h.
6087 (html_preopen_driver) Initialize cp_x, cp_y.
6088 (html_submit) Implement as call to output_tab_table().
6089 (change_attributes) New function.
6090 (escape_string) New function.
6091 (output_tab_table) New function.
6093 * list.q: (write_all_headers) Add code for writing headers for the
6095 (clean_up) Write out the html close-table tag.
6096 (determine_layout) Ignore html driver.
6097 (list_cases) Write html data.
6099 * som.c: (som_submit) Move more of the code into output_table().
6101 * tab.c: (static var hit) Make a global var and rename tab_hit.
6102 (static var tab_table_class) Make a global var.
6104 * htmlP.h: New file.
6106 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
6108 * dump-sysfile.c: Removed.
6110 * html.c: (preclose) Change comment in emitted code.
6112 * matrix-data.c: Debugging off by default. Comment fixes.
6113 (static var container) New var.
6114 (cmd_matrix_data) Create and destroy container. Initialize
6115 is_per_factor[] to 0s. Move code into new function
6116 string_to_content_type(). Require split values to be present in
6117 the data when ROWTYPE_ is explicit. Call specific function, not
6118 general read_matrices().
6119 (string_to_content_type) New function.
6120 (context) Exclude all whitespace, not just spaces.
6121 (mget_token) A dot is a number. Add assertion.
6122 (static var data) Renamed nr_data.
6123 (static var factor_values) Renamed nr_factor_values.
6124 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
6125 only specific case. Close data_file before exit.
6126 (fill_matrix) New function.
6127 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
6128 printing. Style fixes. Message fixes. Move code into
6130 (read_matrices_without_rowtype) Rename
6131 matrix_data_read_without_rowtype(). Fix off-by-one error on
6132 loops. Allocate nr_data[] memory from arena.
6133 (read_matrices_with_rowtype) Removed.
6134 (read_splits) Renamed nr_read_splits(). Style fixes.
6135 (read_factors) Renamed nr_read_factors().
6136 (dump_cell_content) Comment fixes. Arguments changed. Change
6137 debug printing. All references changed.
6138 (output_data) Renamed nr_output_data().
6139 (static var wr_content) New var.
6140 (struct factor_data) New struct.
6141 (static var wr_data) New var.
6142 (static var wr_current) New var.
6143 (matrix_data_source_destroy_source) Removed.
6144 (read_matrices_with_rowtype) New function.
6145 (matrix_data_read_with_rowtype) New function.
6146 (wr_read_splits) New function.
6147 (compare_factors) New function.
6148 (wr_output_data) New function.
6149 (wr_read_rowtype) New function.
6150 (wr_read_factors) New function.
6151 (wr_read_indeps) New function.
6152 (glob var matrix_data_source) Make destroy_source member NULL as
6155 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
6157 * lexer.c: (syntax_error) Give better error message when at end of
6160 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
6161 N_SCALAR to output as plain N.
6162 (mdump_token) Change output format.
6163 (context) Fix message output interaction with spaces in input.
6164 (another_token) New function.
6165 (force_eol) Improved error message.
6166 (static var max_cell_index) New var.
6167 (read_matrices) Init `cells'. factor_values is now per-cell.
6168 Init max_cell_index.
6169 (read_data_lines) Replace `compare' local with new `compare' arg.
6170 Debugging messages changed. Only read factors if per_factor.
6171 Propagate error return from read_factors(), force_eol().
6172 Copy N_SCALAR values across the N vector.
6173 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
6174 check parentheses manually since we now have is_per_factor[].
6175 Call read_data_lines() with new args. Check for end of data after
6176 looping, using another_token().
6177 (read_factors) Arguments changed. Use max_cell_index to determine
6178 whether to read or compare factors. Message fixes.
6179 (dump_cell_content) New function.
6180 (output_data) Completely rewritten because content types were
6181 supported to be nested inside factor values, not vice versa.
6183 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
6185 * lexer.c: (syntax_error) Support formatted varargs messages.
6187 * matrix-data.c: Turn debugging on by default.
6188 (static content_type[]) New array.
6189 (static content_names[]) New array.
6190 (static rowtype_, varname_) New vars.
6191 (static is_per_factor[]) New array.
6192 (static split_values) Moved declaration.
6193 (static n_continuous, first_continuous) New var.
6194 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
6195 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
6196 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
6197 Check for continuous variables.
6198 [DEBUGGING] (debug_print) Remove content_names[].
6199 (mdump_token) New macro.
6200 (mget_token_dump) New function.
6201 (mdump_token) New function.
6202 (context) New function.
6203 (mget_token) Fix messages.
6204 (static var data, split_values, factor_values) New vars.
6205 (read_matrices) Manage split_values, factor_values.
6206 (read_data_lines) New function.
6207 (read_matrices_without_rowtype) Implemented.
6208 (read_splits) Message fixes. Uses `just_read'.
6209 (read_factors) New function.
6210 (output_data) New function.
6211 (matrix_data_source_destroy_source) Close the file handle.
6212 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
6215 * str.c: (strpadcmp) Removed.
6217 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
6219 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
6221 * Lots of source files: Add cast to unsigned character to calls to
6222 tolower() and toupper().
6224 * aggregate.c: Set default_dict.splits to NULL.
6226 * command.c: (static variable tab[]) Add MATRIX DATA.
6228 * data-in.c: Add debugging defines. Formatting fixes.
6230 * expr-opt.c: Formatting fixes.
6232 * lexer.c: (syntax_error) Message fixes.
6234 * matrix-data.c: New enum series.
6235 (static vars fmt, section, diag, explicit_rowtype, signle_split,
6236 split_values, n_factors, factors, cells, pop_n, contents,
6237 n_contents) New vars.
6238 (cmd_matrix_data) Finished implementation.
6239 (compare_variables_by_mxd_vartype) New function.
6240 [DEBUGGING] (debug_print) New function.
6241 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
6242 (read_matrices) New function.
6243 (read_matrices_without_rowtype) New function.
6244 (read_matrices_with_rowtype) New function.
6245 (read_splits) New function.
6246 (mget_token) New function.
6247 (force_eol) New function.
6248 [0] (test_tokenizer) New function.
6249 (matrix_data_source_destroy_source) New function.
6250 (glob var matrix_data_source) New var.
6252 * misc.h: Include ieeefp.h if present.
6254 * split-file.h: (cmd_split_file) Changes corresponding to struct
6257 * str.h: Fix memmem prototype.
6259 * temporary.c: (save_dictionary, restore_dictionary,
6260 free_dictionary) Changes corresponding to struct dictionary
6263 * var.h: (MXD_* enums) New enum series.
6264 (struct matrix_data_proc) New struct.
6265 (struct split) Removed.
6266 (struct dictionary) Changed `splits' member from `split *' to
6268 (macro force_create_variable) New macro. Replaced lots of
6269 create_variable()/assert() calls with calls to this macro.
6271 * vars-atr.c: (discard_variables) Changed assertion.
6272 [GLOBAL_DEBUGGING] (force_create_variable) New function
6273 called by the macro of the same name.
6274 (clear_variable) Changes to delete splits from the dictionary
6275 corresponding to struct dictionary changes.
6277 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
6278 corrupted variable `index' values in the dictionary passed in
6279 every time this function is called.
6281 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
6282 to struct dictionary changes.
6284 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
6286 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
6288 * command.c: New includes.
6289 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
6290 (cmd_erase) New function.
6291 [unix] (shell) New function.
6292 (run_command) New function.
6293 (cmd_host) New function.
6294 (cmd_new_file) New function.
6296 * expr-prs.c: (parse_primary) Message fix.
6298 * inpt-pgm.c: Formatting fix.
6299 (cmd_reread) Implement the FILE subcommand.
6301 * matrix-data.c: New file.
6303 * q2c.c: (dump_header) Change output commenting style.
6305 * weight.c: Comment fix.
6307 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
6309 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
6311 (buf_10x) Renamed buf_1xx, all references changed.
6312 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
6313 cases now implemented).
6314 (create_sysfile) New function.
6315 (agr_11x_func) New function.
6317 * data-in.c: (parse_numeric) Work properly if there's an
6318 explicitly coded decimal point in the data and decimal places are
6319 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
6320 <el@linux.lisse.na>.
6322 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
6323 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
6324 Eberhard W Lisse <el@linux.lisse.na>.
6326 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
6327 strerror.c. Bug reported by Alexandre Oliva
6328 <oliva@dcc.unicamp.br>.
6330 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
6331 (static var separate_case_tab) New var.
6332 (cmd_sort_cases) Cancel temporary transformations here. Free
6333 v_sort before return.
6334 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
6335 we're reading from a sort stream. Don't cancel temporary
6336 transformations. Offload internal sorting to do_internal_sort().
6337 (do_internal_sort) New function. Handles internal sorting even
6338 when SEPARATE is nonzero. Doesn't free v_sort.
6339 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
6341 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
6342 sink if SEPARATE is zero.
6343 (read_output_cases) Renamed read_sort_output(), all references
6344 changed. Now uses separate_case_tab when it exists.
6345 (write_separate) New function.
6347 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
6348 memory_sink_cases. Don't redundantly call
6349 vfm_source->destroy_source().
6350 (memory_stream_mode) After switching over, set memory_sink_cases
6353 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
6355 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
6357 (static var prev_case) New, moved out of aggregate_single_case()
6359 (static var buf64_10x, buf_10x) New.
6360 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
6361 the 000, 001, 100, and 101 cases. Free prev_case.
6362 (parse_aggregate_functions) Disallow scratch variables.
6363 (free_aggregate_functions) Only free agr_dict if non-null. Use
6364 iter->function to determine numeric/string type, not
6366 (aggregate_single_case) Don't manage prev_case. Initialize
6367 aggregate info after dumping it.
6368 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
6369 mean, stddev, weighted stddev definitions.
6370 (dump_aggregate_info) Implemented.
6371 (initialize_aggregate_info) Renamed from
6372 initialize_aggregate_functions(). Initializes dbl[2].
6373 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
6374 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
6376 * cases.c: (alloc_val) Removed.
6378 * get.c: (cmd_save_internal) Initialize new `dict' member.
6380 * sfm-write.c: (sfm_write_dictionary, write_header,
6381 write_variable, write_value_labels, write_documents) Reorganize,
6382 simplify for new parameter structure.
6383 (write_variable) Only one variable * argument now.
6385 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
6386 replaced by new `dict' member.
6388 * temporary.c: (new_dictionary) Initialize n_documents.
6390 * vars-atr.c: (dup_variable) Allocate `value's from dict into
6392 (init_variable, replace_variable) Eliminate usage of alloc_val().
6394 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
6396 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
6397 signal that AGGREGATE is to be used for forming final cases.
6398 (close_active_file) Call end_func before stopping lagging. Cancel
6399 temporary after finishing compaction.
6400 (write_case) Comment fixes. Cleaned up.
6401 (compact_case) Let AGGREGATE handle compaction when `temporary' is
6404 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
6406 * Makefile.am: (BUILT_SOURCES) Add means.c.
6407 (pspp_SOURCES) Add means.c.
6408 (EXTRA_DIST) Add means.q.
6410 * command.c: (array cmd_table[]) Add MEANS.
6412 * common.h: Esthetic fixes. Comment fixes. Test for
6413 MAX_SHORT_STRING greater than 8.
6414 (macros LOWEST, HIGHEST) New.
6416 * data-in.c, data-list.c, recode.c: Comment fixes.
6418 * means.q: New file, base version.
6420 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
6421 with LOWEST, DBL_MAX with HIGHEST.
6423 * q2c.c: (dump_vars) Add an enum to array types giving the number
6424 of values for the enum.
6426 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
6427 Replace second_lowest_value with second_lowest_flt64.
6429 * sfm-write.c: (write_variable, write_rec_7_34) Replace
6430 second_lowest_value with second_lowest_flt64.
6432 * t-test.q: Comment fix.
6434 * temporary.c: (restore_dictionary) Esthetic fix.
6436 * tokens.h: (force_match_id, force_match, force_string, force_int,
6437 force_num, force_id) Replace msg() with syntax_error().
6439 * var.h: (struct means_proc) New.
6440 (struct variable) Add mns member to `p' union.
6442 * vars-prs.c: (parse_variable, parse_dict_variable,
6443 parse_variables, parse_DATA_LIST_vars) Replace msg() with
6446 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
6448 * Makefile.am: (pspp_SOURCES) Add tab.h.
6450 * Most source files: Added a cast to unsigned char in usages of
6451 the ctype is*() functions. Replaced `end of command expected'
6452 calls to msg() with calls to syntax_error().
6454 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
6456 * lexer.c: (hex_val) Removed (was dead code).
6457 (idmatch) Parenthesize function name to avoid macro expansion.
6459 * postscript.c: Comment fixes.
6460 (ps_preopen_driver) Change default font size to 10pt.
6462 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
6464 (parse_format_spec) Change system-file format spec argument type
6465 to int32. Parse the format spec with bitwise operators.
6467 * sfmP.h: (struct sysfile_format) Removed.
6468 (struct sysfile_variable) Changed print, write members from
6469 sysfile_format to int32.
6471 * tokens.h: Esthetic fixes.
6472 [__GNUC__] (macro id_match) New macro to hopefully speed up
6473 identifier matching.
6474 (macros match_id, match_tok, match_int) Implemented in
6475 compiler-independent manner; no longer GNU C only.
6477 * vfm.h: Include time.h.
6479 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
6481 * data-list.c: (dump_fixed_table) Change tab_dim().
6483 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
6485 * error.c: Include command.h.
6487 * frequencies.g: Formatting fixes.
6489 * frequencies.q: Add tab_dim() calls. Make the total cell a
6492 * glob.c: Include command.h.
6494 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
6496 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
6497 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
6498 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
6499 the other elements (is this right?).
6500 (read_variables) Use lowest, highest members.
6501 (parse_format_spec) New arg `vv' for more stringent checking.
6502 (dump_dictionary) Byteswaps nonexplicit data.
6503 (sfm_read_case) Byteswap numeric data.
6505 * som.c: Initialize table_num to 1.
6506 (render_segments) Remember to increment y_index after each table
6509 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
6510 avl_count() on a NULL tree. No title for the second table.
6511 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
6512 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
6513 fix call to display_variables().
6514 (display_variables) Default to 4 columns, not 3. Set up headers.
6515 Column title is Variable, not Name. Fix index column.
6516 Add joint text. Add tab_dim(). Handle value labels properly.
6517 Handle DISPLAY LABELS properly. Draw boxes correctly.
6518 (describe_variable) Value labels don't need titles. Don't clear
6519 nonexistent index column.
6520 (compare_vectors_by_name) New function.
6521 (display_vectors) New function.
6523 * tab.c: (tab_height) Add assertion.
6524 (tab_null) Add debug code.
6525 (evaluate_dimensions) Add debug code.
6527 * var.h: (struct variable) get_proc data is sometimes used
6528 simultaneously with other per-procedure info, therefore it was
6529 removed from the union. All references changed.
6531 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
6533 * ascii.c: (ascii_close_page) Put title on second line of headers
6534 if there is no subtitle.
6536 * command.c: (glob var cur_proc) Move definition here, from
6538 (cmd_remark) Emit blank line before remarks.
6540 * command.h: (glob var cur_proc) Move declaration here, from
6543 * data-list.c: (dump_fixed_table) Fix messages.
6544 (dump_free_table) Call tab_nat_dim().
6546 * descript.q: (dump_z_table) Modify tab_dim() call.
6548 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
6550 (dump_statistics) Don't output header.
6552 * groff-font.c: Minor format fix.
6554 * html.c: Comment fix.
6556 * list.q: (write_varname) Indent after advancing page.
6558 * output.h: Minor reordering.
6560 * postscript.c: Comment fixes. Many places, '\n' was replaced by
6561 a reference to eol[].
6562 (struct ps_driver_ext) New member eol[].
6563 (ps_preopen_driver) Initialize eol[].
6564 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
6565 defaults. Handle headers. Fix test for minimum page length.
6566 (static var option_tab[]) Add `line-ends'.
6567 (ps_option) Handle line-ends to change eol[].
6568 (postopen) Scale prop_em_width and fixed_width properly. Set the
6569 prologue title to outp_title if applicable. Replace the prologue
6570 line ends with eol[]. Call draw_headers() if headers are enabled.
6571 (text_width) New function.
6572 (out_text_plain) New function.
6573 (draw_headers) New function.
6575 * print.c: (dump_table) Call tab_nat_dim().
6577 * som.c: (som_blank_line) Only advance a line if not at the top of
6579 (som_submit) Move several informational table calls here.
6580 Increment subtable_num if SOMF_NO_TITLE not set.
6581 (output_table) Advance a line if SOMF_NO_SPACING not set.
6582 (render_columns, render_segments, render_simple) Handle spacing
6583 between tables. Handle table titles. Remove debug output.
6585 * som.h: (SOMF_*) New enum series.
6586 (struct som_table_class) New member `flags'.
6588 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
6590 (display_variables) Calls tab_nat_dim().
6591 (describe_variable) Remove restriction on number of value labels.
6592 Make value labels separated by thin lines.
6594 * tab.c: (tab_create) Default `flags' to none.
6595 (tab_float) New arg `w'. All references changed.
6596 (tab_nat_dim) New function.
6597 (tab_output_text) No title or spacing.
6598 (tab_flags) New function.
6599 (tabi_flags) New function.
6600 (tabi_title) New function.
6601 (strip_height) Removed.
6602 (tabi_render) Skip title when necessary.
6603 (static var tab_tab_class) Add tabi_flags, tabi_title.
6604 (evaluate_dimensions) Disable display of column, row size.
6605 (sum_columns) Add title height to top header.
6606 (render_strip) Moved within file.
6608 * tab.h: (struct tab_table) New member `flags'.
6610 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
6612 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
6614 * Most source files: Add `const' attribute in all appropriate
6617 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
6618 column to the variables table for use by describe_variable().
6619 (cmd_display) Disable for the present.
6620 (display_documents) Don't wrap documents.
6621 (display_variables) Table has four columns now.
6622 (describe_variable) Table has four columns now. Don't use a
6623 subtable, use joined cells instead.
6625 * tab.c: (tab_create) Don't set `join'.
6626 (tab_realloc) ct array is not made up of a_string's.
6627 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
6628 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
6629 (text_format) New function.
6630 (tab_title) Rewritten, uses text_format().
6631 (tab_text) Rewritten, uses text_format().
6632 (tab_joint_text) New function.
6634 (static var hit) New variable.
6635 (render_strip) New args r1, r2. Implement joined cells that fit
6637 (tabi_render) Increment hit. Pass new args to render_strip().
6638 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
6639 cells. For t_naw and t_nah, ignore joined cells and null cells in
6642 * tab.h: (struct tab_join_rect) Removed.
6643 (struct tab_table) Removed `join'.
6644 (TAB_JOIN_MAIN) Removed.
6645 (struct tab_joined_cell) New struct.
6646 (TAT_NOWRAP) New enum.
6648 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
6650 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
6652 (ascii_postopen_driver) Fix initialization of *_spacing so that
6653 the TAL_0 bit doesn't count.
6655 * data-list.c: (dump_fixed_table) Use natural width for Format
6658 * glob.c: (rerange) Removed.
6659 (get_date) Formatting fixes. Internationalization fix.
6661 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
6664 * postscript.c: (ps_postopen_driver) Replace
6665 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
6667 * som.c: (som_submit) Don't eject page before every table.
6668 (output_table) Fix order of arguments on call to area().
6669 (render_columns) Fix calculation of max_len.
6671 * tab.c: (tabi_cumulate) Minor change to increase elegance.
6672 (render_strip) New function.
6673 (strip_height) New function.
6674 (tabi_render) Rewrite as calls to render_strip().
6676 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
6677 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
6678 with the TAB_* and OUTP_T_* constants.
6680 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
6682 * Makefile.am: Formatting fixes.
6684 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
6687 * data-list.c: (dump_fixed_table) Add tab_dim() call.
6689 * descript.q: (dump_z_table, display) Add tab_dim() calls.
6691 * dump-sysfile.c: (glob var length) Make type off_t.
6692 (usage) Fix arguments.
6695 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
6696 Now right-justification is the default so many references had to
6698 (struct outp_class) Removed line_width, all references changed.
6699 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
6700 (struct outp_driver) Add elements horiz_line_width,
6701 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
6704 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
6706 (postopen) Initialize all the informational members of
6709 * som.c: (som_blank_line) New function, renamed from blank_line(),
6710 all references changed.
6711 (som_submit) Disables drivers whose pages can't be opened.
6712 (render_columns, render_simple, render_segments) Add debug output.
6713 (render_columns) Fix loop range.
6714 (render_simple) Don't try to render the headers, they're taken
6715 care of automatically. Advance cp_y past the table when done.
6716 (render_segments) Fix loop ranges.
6718 * tab.c: Initialize new members of tab_table.
6719 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
6720 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
6721 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
6724 (tab_dim) New function.
6725 (tab_col_width) Removed.
6726 (tab_row_height) Removed.
6727 (tab_output_text) Call tab_dim().
6728 (tabi_driver) Call evaluate_dimensions(), sum_columns().
6729 (tabi_area) Implemented.
6730 (tabi_cumulate) Implemented.
6731 (tabi_render) Partially implemented, but broken.
6732 (var tab_table_class) Made static.
6733 (evaluate_dimensions) New function.
6734 (sum_columns) New function.
6736 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
6737 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
6738 t_scr, t_srr, t_sentinel. Removed: t_nat.
6739 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
6740 max_stack_height, w, h. Removed: ce, re.
6741 (macro blank_line) Removed.
6742 (glob var zero_length) Removed.
6744 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
6746 * Most source files: include some of the new include files broken
6749 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
6752 * aggregate.c: (glob var outfile) Make static.
6754 * command.c: (glob var pgm_state) Move here.
6756 * common.c: (glob vars endian, second_lowest_value, pgmname,
6757 finished, curdate, cur_proc, start_interactive, history_file) Move
6760 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
6762 * file-handle.q: (glob vars files, inline_file) Move here.
6764 * glob.c: Lost lots of glob vars, detailed in individual file
6766 (init_glob) set_printer, set_screen were obsolete, deleted.
6767 set_cprompt has fewer spaces because pspp has fewer letters than
6770 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
6771 (inp_nval) Made static.
6773 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
6774 tokstr_len, toklongstr, tokint) Move here.
6776 * misc.c: Lost several vars and functions.
6778 * set.q: (all the set_* variables) Move here.
6780 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
6781 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
6784 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
6786 * tab.h: (enum series t_*) New enums.
6787 (struct tab_table) Use arena struct tag. New members ce, re.
6789 * tokens.h: Comment fixes.
6791 * var.h: Move lots of enums and variables and functions and
6792 structures to other files. Use and declare a lot more union and
6793 struct tags. Comment fixes.
6795 * vector.c: (glob vars vec, nvec) Move here.
6797 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
6798 init_blanks, last_vfm_invocation) Move here.
6800 * cases.h: New file.
6801 (struct long_vec) Move here.
6802 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
6805 * command.h: New file.
6806 (STATE_* enums) Move here.
6807 (glob var pgm_state) Move here.
6809 * format.c: New file.
6810 (glob var formats) Move here.
6811 (parse_format_specifier_name, fmt_to_string,
6812 check_input_specifier, check_output_specifier,
6813 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
6816 * format.h: New file. Move functions now in format.c here.
6817 (FMT_* enums) Move here.
6818 (struct fmt_desc) Move here.
6819 (FCAT_* enums) Move here.
6820 (struct fmt_spec) Move here.
6821 (glob vars formats, fmt_parse_ignore_error) Move here.
6823 * inpt-pgm.h: New file.
6824 (INP_* enums) Move here, make #defines into enums.
6825 (glob vars inp_init, inp_init_size) Move here.
6828 (glob vars v_sort, nv_sort) Move here.
6829 (sort_cases, read_sort_output) Move here.
6831 * vector.h: New file.
6832 (struct vector) Move here, add struct tag.
6833 (glob vars vec, nvec) Move here.
6834 (find_vector) Move here.
6837 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
6838 reinit_blanks, init_zero, init_blanks) Move here.
6839 (struct case_stream) Move here.
6840 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
6841 vfm_disk_stream, sort_stream, data_list_source,
6842 input_program_source, file_type_source, get_source, n_lag) Move
6844 (procedure, write_case, lagged_case, compact_case, page_to_disk)
6847 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
6849 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
6850 (LDADD) Add libdcdflib.
6852 * ascii.c: Comment and formatting fixes. Almost every external
6853 function had an assert added, checking driver_open and page_open.
6854 (ascii_init_driver) Broken into ascii_preopen_driver,
6855 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
6856 (ascii_open_page) Sets page_open.
6857 (ascii_close_page) Clears page_open.
6859 * html.c: Comment and formatting fixes. Almost every external
6860 function had an assert added, checking driver_open and page_open.
6861 (html_init_driver) Broken into html_preopen_driver,
6862 html_postopen_driver, html_close_driver. Manages driver_open.
6863 (html_open_page) Sets page_open.
6864 (html_close_page) Clears page_open.
6865 (html_submit) Disabled.
6867 * lexer.c: (parse_string) Remove debugging printf.
6869 * list.q: (determine_layout) Open a page if one is not yet open.
6871 * output.c: Comment fixes.
6872 (add_class) Set the class member of the new list element.
6873 (parse_options) Don't handle device type.
6874 (colon_tokenize) New function.
6875 (configure_driver) New four-field format with a field for device
6876 type. Now initialize driver_open, page_open, next, and prev
6877 fields. Use new colon_tokenize() function. Don't do a memory
6878 copy to replace a driver, it doesn't work; instead delete the old
6879 driver and insert a new one.
6880 (destroy_driver) Don't call som_destroy_driver(). Close the page
6881 if it's open. Find the class in the list of classes and decrement
6882 that reference count. Remove the driver from the global driver
6884 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
6885 references changed. Rewritten. Don't return a driver that's not
6887 (outp_eject_page) All references to som_internal_eject_page()
6888 changed to use this. Sets cp_x to 0 as well as cp_y.
6890 * output.h: (OUTP_I_* enums) Removed.
6891 (struct som_submission_form) Removed.
6892 (struct outp_class) init_driver broken into preopen_driver,
6893 postopen_driver, and close_driver. submit changed to take a
6896 * postscript.c: Comment and formatting fixes. Almost every
6897 external function had an assert added, checking driver_open and
6899 (ps_init_driver) Broken into ps_preopen_driver,
6900 ps_postopen_driver, ps_close_driver. Manages driver_open.
6901 (ps_open_page) Sets page_open.
6902 (ps_close_page) Clears page_open.
6904 * som.c: New file, base implementation.
6906 * som.h: (struct som_table) Add struct tag.
6907 (enum SOM_COL_ACROSS) Removed.
6908 (SOM_ROWS, SOM_COLUMNS) New enums.
6909 (struct som_table_class) Add member `cumulate'. Remove `segment';
6910 change `render' arguments.
6911 (struct som_point, struct som_rect) Removed.
6912 (som_submit_table) Fixed typo, should have been som_submit.
6914 * sysfile-info: (describe_variable) Don't try to insert a
6915 subtable; just destroy it for now.
6917 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
6918 references to value labels.
6920 * tab.c: (tab_destroy) New function.
6921 (tab_columns) Change argument.
6922 [0] (tab_submit) Remove dead code.
6923 (tab_title) Allocate string from the table's arena.
6924 (tab_output_text) Only free the buffer if we allocated it.
6925 (tab_submit) New function.
6926 (static vars t, d) New static vars.
6927 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
6928 tabi_headers, tabi_cumulate, tabi_render) New functions.
6929 (glob var tab_table_class) New global var.
6931 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
6932 encapsulate the rectangle. All references changed.
6934 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
6936 * All header files updated to use struct tags in addition to
6937 typedefs for all structures. Don't use word `struct' in struct
6940 * Makefile.am: (pspp_SOURCES) Remove html.c.
6941 (INCLUDES) Replace the lib/* includes with a single lib/ include;
6942 all references updated.
6944 * command.c: (parse_cmd) Remove call to som_check_workspace.
6945 (output_line) Update to new som.
6947 * data-in.c: (parse_numeric) A single dot is not an error; it is
6948 the system-missing value.
6950 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
6953 * data-out.c: Added `const' as appropriate to many prototypes.
6954 (convert_E, convert_F, convert_CCx) Take double argument instead
6955 of value * argument.
6956 (convert_format_to_string) Call changed functions appropriately.
6957 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
6958 make a local copy of the value.
6960 * descript.q: Remove custom_variables() prototype now provided by
6962 (custom_variables) Don't increment sbc_variables, the caller does
6964 (dump_z_table, display) Update to new som.
6966 * error.c: (vmsg) Add const to prototype. Remove code to handle
6967 `too many errors' condition.
6968 (check_error_count) New function.
6969 (msg) Add const to prototype.
6971 * filename.c: (open_file) Rewrite for elegance.
6973 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
6974 (dump_full, dump_condensed, dump_statistics) Update for new som.
6976 * list.q: Don't include somP.h. Change all references to
6977 som_driver_ext to refer to the new members of som_driver. Change
6978 som_internal_eject_page() references to outp_eject_page().
6980 * main.c: (parse) Rewrite for elegance. Add call to
6981 check_error_count().
6983 * output.c: (add_class, outp_list_classes, outp_configure_driver)
6984 Rewrite or revise for new outp_driver_class_list structure.
6985 (outp_iterate_enabled_drivers) Fix comparison between disabled
6986 devices and current device type.
6987 (outp_eject_page) New function.
6989 * output.h: Comment fixes.
6990 (struct outp_driver) New members driver_open, page_open, cp_x,
6991 cp_y, font_height, prop_em_width, fixed_width. Deleted members
6993 (struct outp_driver_class_list) New struct.
6994 (outp_class_list) Changed to type outp_driver_class_list; all
6997 * print.c: (dump_table, print_trns_proc) Updated for new som.
6999 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
7000 prototypes for custom subcommands.
7001 (dump_subcommand) Always include the `else'.
7002 (dump_parser) Fix comments in output code.
7004 * set.q: Reordered functions.
7006 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
7008 * som.h: Rewritten from scratch.
7010 * str.h: Remove dead code.
7012 * tab.c, tab.h: New files, base implementation.
7014 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
7017 * t-test.q: New code from John Williams
7018 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
7019 Many many new static vars and defines.
7020 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
7021 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
7022 (struct value_list) New struct.
7023 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
7024 t_crt, t_sig, print_t_groups) New functions.
7025 (cmd_t_test) Implemented.
7027 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
7030 * vfm.c: (dump_splits) Update to new som.
7032 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
7034 * Makefile.am: (fiasco_SOURCES) Add html.c.
7036 * aggregate.c: Base source.
7038 * ascii.c: (postopen, preclose) Reformat.
7040 * data-out.c, expr-evl.c: Comment fixes.
7042 * filename.c: (open_file) When opening a file for writing, use
7043 line buffering instead of full buffering for better interactive
7044 performance. Suggested by Valerio Aimale
7045 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
7046 names `stdin', `stdout', `stderr'.
7048 * groff-font.c: Comment fixes.
7050 * html.c: New file; base version.
7052 * list.q: (write_all_headers, clean_up, determine_layout,
7053 list_cases) Ignore `special' devices for now. Needs to be fixed
7056 * output.c: (outp_init) Add html driver to list; reverse list
7059 * output.h: (struct outp_class_struct) New members `special',
7060 `submit'; comment fixes. All references changed.
7062 * postscript.c: (ps_init_driver) Make defaults for text_opt,
7063 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
7065 (postopen) Comment fix.
7066 (preclose) Comment fixes, formatting fixes. Change x->file.file
7067 references to more proper f->file.
7069 * som-high.c: (som_submit_table) Special classes use their own
7072 * som.h: Comment fixes.
7074 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
7077 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
7079 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
7081 * aggregate.c: Still working on this.
7083 * command.c: (cmd_table[]) Add AGGREGATE back in.
7084 (split_words) Make '-' a legal word separator as well as ' '.
7086 * main.c: Comment fixes.
7088 * q2c.c: (dump_parser) Don't require the procedure's full name to
7089 be present, in the generated source.
7091 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
7092 multiply specified and let it be default; let MISSING, CRITERIA,
7093 FORMAT be multiply specified.
7094 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
7095 (custom_groups) Fix defaults.
7096 (custom_pairs) Check whether this is a PAIRS subcommand before
7097 attempting to parse. Better garbage collection. Proper storage
7099 [DEBUGGING] (debug_print) New function.
7101 * temporary.c: Comment fixes.
7102 (copy_variable) Don't copy variable name and index.
7103 (save_dictionary) Copy variable name and index by hand.
7105 * vars-atr.c: Comment fixes.
7106 (create_variable) New dictionary argument. All references
7108 (common_init_stuff) New dictionary argument. All references
7110 (init_variable) New dictionary argument. All references changed.
7111 (dup_variable) New function.
7113 * vars-prs.c: (parse_variables) If there are any errors, we always
7114 return 0. Previously, it was possible for some types of errors to
7117 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
7119 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
7122 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
7124 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
7127 * q2c.c: Comment fixes.
7128 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
7130 * t-test.q: (cmd_list) Rename cmd_t_test.
7132 * temporary.c: (new_dictionary) Don't declare as static.
7134 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
7136 * aggregate.c: Changes, still not finished.
7138 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
7140 * q2c.c: Comment fixes. Now its output is internationalized.
7141 (get_token) Fix parsing of escapes within literal strings.
7142 (main) Fix bad #line directives in output.
7144 * t-test.q: Base implementation.
7146 * temporary.c: (new_dictionary) New function.
7147 (restore_dictionary) [__CHECKER__] Change fill character to *
7150 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
7152 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
7154 * aggregate.c: Changes, still not finished.
7156 * descript.q, list.q: Comment fixes.
7158 * q2c.c: Almost completely rewritten.
7160 * t-test.q: New file, not complete.
7162 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
7164 * aggregate.c: Changes, still not finished.
7166 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
7169 * temporary.c: (cancel_temporary) New function.
7171 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
7172 of doing it by hand.
7174 * vfm.c: (close_active_file) After restoring a TEMPORARY
7175 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
7177 (SPLIT_FILE_procfunc) Comment fix.
7179 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
7181 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
7183 * aggregate.c: New file, not finished yet.
7185 * command.c: (cmd_table) Add AGGREGATE.
7187 * common.h: (pgm_state) Move declaration to var.h.
7189 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
7191 (parse_string) Message fix.
7193 * recode.c: Comment fix.
7195 * sfm-read.c: (read_variables) Code esthetic fixes.
7196 (write_header) Default date is `Jan', not `JAN'.
7198 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
7200 * sort.c: (cmd_sort_cases) Farm the work out to new function
7201 parse_sort_variables().
7202 (parse_sort_variables) New function.
7203 (sort_cases) New function. Cancels temporary transformations,
7204 which sorting didn't do previously.
7205 (cmd_sort_cases) Better garbage collection on error. Uses
7207 (write_initial_runs, merge_once) Improved code esthetics.
7208 (sort_stream_read) Reduced to one call to read_output_cases().
7209 (read_output_cases) New function.
7211 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
7212 variable labels to 120 characters.
7214 * var.h: Comment fixes.
7215 (glob var pgm_state) From common.h.
7217 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
7219 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
7220 options. Set *names to NULL on error.
7222 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
7224 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
7226 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
7227 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
7229 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
7231 * vfm.c: (page_to_disk) Added missing local variables.
7233 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
7235 * get.c: Comment fix.
7237 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
7238 source is anything other than a disk stream, not just if it's in a
7239 memory stream. Call page_to_disk() before external sort.
7240 (allocate_cases) Message fix.
7242 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
7244 (page_to_disk) New function.
7246 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
7248 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
7250 * common.h: (macro strerror) Remove. From Alexandre Oliva
7251 <oliva@dcc.unicamp.br>.
7253 * get.c: (dict_delete_run) The number of variables to delete is
7254 not necessarily the number of variables that need to be shifted
7256 (trim_dictionary) Don't set *options to 0. Fix bug that caused
7257 too many variables to be deleted.
7259 * postscript.c: Comment fix.
7261 * q2c.c: Include strerror.c. From Alexandre Oliva
7262 <oliva@dcc.unicamp.br>.
7264 * set.q: #undef ON and OFF. From Alexandre Oliva
7265 <oliva@dcc.unicamp.br>.
7267 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
7268 early, otherwise errors cause a bad free().
7270 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
7271 Oliva <oliva@dcc.unicamp.br>.
7273 * temporary.c: (save_dictionary) Don't allocate memory if
7276 * vfm.c: (memory_stream_write) Message fix.
7278 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
7280 * command.c: (static var cmd_table[]) Define REPEATING DATA
7283 * common.h: Added support for broken systems that are missing
7284 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
7286 * Many source files: Replace syntax error messages via msg() with
7287 call to syntax_error().
7289 * data-list.c: (dump_fixed_table) Add support for dumping table
7290 for REPEATING DATA as well as DATA LIST FIXED.
7291 (cmd_repeating_data) Allows and requires `/' between subcommands.
7292 Does proper thing with allowing rpd.starts_end to stay 0. Allows
7293 CONTINUED specifications to be omitted. Forces CONTINUED to be
7294 specified if ID is. Calculates starts_end, cont_end from logical
7295 record length as reported by fhp. Calls dump_fixed_table() if
7296 requested. Fixed length of record copied by memcpy.
7297 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
7299 (realize_value) Returns sensible value for out-of-range variable
7301 (rpd_parse_record) New argument `ofs'. Fixed confusion between
7302 length of occurrences and length of line. Added warning for
7303 fields that exceed the line length. Fixed infinite loop.
7304 (read_one_set_of_repetitions) Numerous minor changes for more
7305 complete SPSS compliance. Message fixes.
7307 * dfm.c: (dfm_close) If the file being closed is the inline file,
7308 read all the remaining data before closing it.
7309 (dfm_get_record) Don't close the file on lossage, as either it
7310 has been closed already or it doesn't belong to us.
7312 * error.c: (puts_stdout) New function.
7313 (vmsg) Use puts_stdout instead of puts.
7315 * file-handle.q: (fh_record_width) New function.
7317 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
7320 (input_program_source_read) Made an old kluge an approved method.
7322 * lexer.c: (syntax_error) New function.
7324 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
7327 * output.c: (oupt_get_paper_size) Message fix.
7329 * q2c.c: Numerous fixes to formatting of generated code made to
7330 conform to GNU coding standards. Uses syntax_error() in generated
7331 code. Other miscellaneous generated message fixes. Added support
7332 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
7333 RAND_MAX, and/or strerror().
7335 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
7337 * data-in.c: Comment fixes.
7339 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
7340 (find_variable_input_spec) New function.
7341 (cmd_repeating_data) Initializes id_spec.
7342 (rpd_parse_record) Implemented.
7343 (read_one_set_of_repetitions) Returns -3 by default in order to
7344 kluge out some potential bugs.
7346 * data-out.c: Comment fixes.
7348 * file-type.c: (internal_cmd_record_type) Message fix.
7350 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
7351 for handling -3 return value.
7353 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
7355 * data-list.c: Comment fixes.
7356 (struct dls_var_spec) Reordered members.
7357 (read_from_data_list_fixed) Restructured.
7358 (struct repeating_data_trns) Reordered members. Renamed `starts'
7359 as `starts_beg', `ends' as `starts_end'.
7360 (cmd_repeating_data) Calculates length of repeated data if
7361 necessary and possible.
7362 (parse_num_or_var) Don't allow string variables.
7363 (realize_value) New function.
7364 (rpd_msg) New function.
7365 (rpd_parse_record) New function. Currently stubbed out.
7366 (read_one_set_of_repetitions) Implemented.
7368 * inpt-pgm.c: (input_program_source_read) Comment fix.
7370 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
7372 * command.c: (cmd_end_repeat_p) Removed.
7373 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
7374 (parse_cmd_name) Removed.
7376 * data-list.c: Comment fixes.
7377 (data_list_pgm) Removed `eof' member.
7378 (static var first) New var.
7379 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
7380 FILE TYPE file inside FILE TYPE structures.
7381 (append_var_spec) Appends to *first, not dls.spec.
7382 (parse_fixed) Message fixes.
7383 (struct rpd_num_or_var) New.
7384 (struct repeating_data_trns) New.
7385 (static var rpd) New.
7386 (cmd_repeating_data) New function.
7387 (parse_num_or_var) New function.
7388 (parse_repeating_data) New function.
7389 (read_one_set_of_repetitions) New function.
7391 * file-type.c: (cmd_file_type) Message fixes. Always
7392 default_handle to FILE TYPE file handle.
7393 (internal_cmd_record_type) Message fixes.
7395 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
7397 * repeat.c: Comment fix. Disable debugging.
7399 * temporary.c: (restore_dictionary) Sets splits to NULL and
7400 n_splits to 0 before destroying the variables because now doing
7401 this tries to remove split variables.
7403 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
7404 destroying the dictionary.
7405 (clear_variable) Removes a variable from splits after destroying
7408 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
7410 * cmdline.c: (set_compat) Removed.
7411 (pick_compat) Removed.
7412 (parse_command_line) Removed -c option.
7413 (pre_syntax_message) Removed -c option.
7414 (usage) Remove compatibility code.
7416 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
7417 (glob var compat) Removed.
7419 * compute.c: (type_check) Fixed messages about type mismatches.
7421 * data-list.c: (cmd_data_list) Removed compatibility code.
7422 (fixed_parse_compatible) Calls convert_negative_to_dash().
7423 Fixed bug where it only set the variable in fx.spec if it created
7424 the variable itself.
7425 (dump_fmt_list) Spelling fix.
7426 (cut_field) Removed compatibility code.
7428 * dfm.c: (cmd_begin_data) Don't require a command terminator on
7431 * expr-evl.c: (evaluate_expression) Implement LAG.
7433 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
7434 (parse_neg) Calls convert_negative_to_dash().
7435 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
7438 * expr.h: (struct expression_struct) Removed member max_lag.
7440 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
7441 (internal_cmd_record_type) Removed special handling to produce
7442 negative numbers from dash tokens.
7444 * getline.c: (static var DO_REPEAT_level) New var.
7445 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
7446 (handle_line_buffer) Copies the line into getl_buf; doesn't call
7447 copy_with_DO_REPEAT_substitutions().
7448 (getl_read_line) Maintains value of getl_mode. Calls
7449 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
7451 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
7453 * getline.h: (getl_mode) New glob var.
7455 * glob.c: Comment fixes.
7456 (init_glob) Restructured. Sets set_seed.
7457 (init_compat_dependent) Removed. All references removed.
7458 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
7459 (__htonl, __htons) Removed. (What were these for?)
7461 * lexer.c: (static var tbl) Dash set to class CNUM.
7462 (make_hexit) New function from data-out.c.
7463 (get_token_representation) Rewritten.
7464 (convert_negative_to_dash) New function.
7465 (lex_init_compat_dependent) Removed.
7466 (yylex) A dash is parsed as part of a number if it is followed by
7467 a digit. The ASCII representation of a number is copied to
7468 tokstr. String parsing farmed out to parse_string(). Comment
7470 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
7472 (preprocess_line) Line processing depends on interactive/batch
7473 mode, not on compatibility mode. Removed PC+ compatibility code.
7475 * loop.c: (loop_3_trns_proc) Comment fix.
7477 * main.c: Remove dead code.
7478 (main) Remove call to init_compat_dependent().
7480 * misc.c: (convert_fmt_ItoO) Make E format conversion more
7483 * print.c: (parse_string_argument) Calls
7484 convert_negative_to_dash().
7485 (fixed_parse_compatible) Calls convert_negative_to_dash().
7487 * repeat.c: (RPT_* defines) Removed.
7488 (struct rpt_numeric) Removed.
7489 (struct repeat_entry) New member type, changed `replacement' from
7491 (clean_up) Deallocation adapted to new repeat_entry.
7492 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
7493 usage. Creates vars for `type' of 1.
7494 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
7495 (store_numeric) Rewritten, new interface.
7496 (parse_numbers) Rewritten.
7497 (parse_strings) Rewritten.
7498 (find_DO_REPEAT_substitution) New function.
7499 (perform_DO_REPEAT_substitutions) New function.
7500 (copy_with_DO_REPEAT_substitutions) Removed.
7501 (debug_print) Rewritten.
7503 * set.q: Comment fix.
7504 (custom_results) Removed compatibility code.
7505 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
7508 * sysfile-info.c: (cmd_display) Removed compatibility code.
7510 * tokens.h: Comment fixes.
7511 (token types enum) Removed `toktype' typedef name for this int
7512 type. Removed SUBST. Restructured.
7514 * vars-atr.c: (discard_variables) Sets n_lag to 0.
7516 * vars-prs.c: Comment fix.
7518 * vfm.c: Comment fixes.
7519 (glob var n_lag) New var.
7520 (static vars lag_count, lag_head, lag_queue) New vars.
7521 (procedure) Removed argument nlag.
7522 (setup_lag) New function.
7523 (close_active_file) Discards lagging state.
7524 (lag_case) New function.
7525 (lagged_case) New function.
7526 (write_case) Lags a case if lagging.
7528 * weight.c: (cmd_weight) Removed compatibility code.
7530 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
7532 * getline.h: (struct getl_script) New members loop_index, macros.
7534 * getline.c: (getl_add_file) Sets first_line field to NULL.
7535 (getl_add_DO_REPEAT_file) New function.
7536 (handle_line_buffer) When the current line's length is negative,
7537 set the filename and line number. Increment line number after
7538 reading line. Pass the line to
7539 copy_with_DO_REPEAT_substitutions() for processing.
7540 (getl_close_file) Free DO REPEAT lines before freeing the
7541 filename, and just set the filename to NULL when doing this,
7542 because otherwise the filename gets freed twice.
7544 * glob.c: (glob var queuing) Removed. All references removed.
7546 * lexer.c: Comment fixes.
7547 (get_token_representation) New function.
7549 * repeat.c: Comment fixes.
7550 (struct repeat_entry) Replaced type and v union members with a
7552 (append_record) New function.
7553 (internal_cmd_do_repeat) Started reforming it for the new
7554 repeat_entry struct. Properly records filename changes in the
7555 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
7556 strncasecmp() result usage. Uses append_record() to simplify.
7557 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
7560 (copy_with_DO_REPEAT_substitutions) Started coding.
7562 [DEBUGGING] (debug_print_lines) New function.
7564 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
7566 * tokens.h: (macro is_id1, is_idn) New macros.
7568 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
7570 * cmdline.c: (static var pre_syntax_message) Changed `win'
7571 compatibility mode to `wnd'.
7573 * data-list.c: (fixed_parse_spss) Renamed
7574 fixed_parse_compatible().
7576 * glob.c: (init_glob) Excise unused code for
7577 program_invocation_short_name.
7579 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
7582 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
7584 * set.q: `win' compatibility renamed `wnd'.
7586 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
7588 * filename.c: [__WIN32__] Change the included Windows header files
7590 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
7591 second character is absolute.
7592 (dirname) Fix logic error. Don't printf() the results.
7593 (prepend_dir) Don't printf() the results.
7595 * getline.c: (handle_line_buffer) New function.
7596 (getl_read_line) Reads line with handle_line_buffer() when
7598 (getl_close_file) Discard line buffer data.
7600 * getline.h: Comment fixes.
7601 (struct getl_line_list) New struct.
7602 (getl_script_struct) Added line buffer members. These are hooks
7603 for use by DO REPEAT to allow it to insert virtual source code
7606 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
7607 Override Borland C++ stupidity that claims Windows has a console
7610 * repeat.c: This is in the process of being restructured from
7611 using a token-buffering approach to the DO REPEAT facility to
7612 using the more flexible approach of a line-buffering approach in
7613 conjunction with the getline module. Comment fixes.
7614 (struct tok_struct) Removed.
7615 (static vars queue_index, queue_head, queue) Removed.
7616 (static vars line_buf_head, line_buf_tail) New vars.
7617 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
7619 (pull_queue, destroy_queue) Removed.
7620 [DEBUGGING] (debug_print_tokens) Removed.
7622 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
7624 * file-handle.q: (prepend_current_directory) New function.
7625 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
7626 current directory before normalizing filename.
7628 * filename.c: (gnu_getcwd) New function.
7629 (absolute_filename_p) New function.
7630 (search_path) New argument, PREPEND. All references changed to
7631 pass NULL except those explicitly mentioned. Uses
7632 absolute_filename_p(). Prepends PREPEND before trying the
7634 (dirname, prepend_dir) New functions.
7636 * getline.c: (getl_get_current_directory) New function.
7637 (getl_include) Passes getl_get_current_directory() as PREPEND arg
7640 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
7642 * In several source files, the term `script' was replaced with
7643 `syntax file' inside error messages. Usage of the term `script'
7644 in the sense of a syntax file is now deprecated.
7646 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
7649 * dump-sysfile.c: (usage) Update message.
7651 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
7653 * getline.h: (glob var getl_include_path) Declare extern.
7655 * list.q: Define EXTERN as extern before #including somP.h.
7657 * var.h: Remove declaration of `disptype' variable.
7659 * vfm.c: (close_active_file) After switching the data sink to a
7660 data source, set vfm_sink to NULL, because it doesn't exist any
7663 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
7665 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
7666 _matherrl() to ignore all math errors.
7668 * sfm-read.c: (read_value_labels) When reading the labels from
7669 disk, read the little parts separately instead of as a struct;
7670 this avoids alignment problems.
7672 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
7673 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
7674 (write_header) Allocates and initializes elem_type.
7675 (sfm_write_case) Uses elem_type to determine how to handle each
7677 (sfm_close) Frees elem_type.
7679 * sfmP.h: Comment fix.
7680 [__BORLANDC__] Uses #pragma -a to adjust structure member
7683 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
7685 * Makefile.am: (fiasco_SOURCES) Remove display.c.
7687 * common.c: Fix typo.
7689 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
7690 sense of the condition.
7692 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
7693 line-continuation backslash.
7695 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
7697 * frequencies.q: (custom_grouped, add_percentile) Don't use a
7698 non-constant expression as an argument to sizeof.
7700 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
7701 undefine gettext macro because that's a conio function.
7703 * hash.h: (hsh_prime_tab declaration) Remove.
7705 * list.q: (write_fallback_headers) Move `leader' allocation out of
7706 main loop. Change to local_alloc() allocation.
7708 * output.h: Formatting fixes. Put __attribute__ in right place on
7709 function prototypes.
7711 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
7712 incorrect `SECOND_LOWEST_VALUE' references to proper
7713 `second_lowest_value'.
7715 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
7716 value. This way 2 out of 3 of the som files define the vars
7717 extern, the correct way, that actually works under BC++.
7718 (som_set_float) Don't use nonconstant initializers for a struct.
7720 * som-high.c: Add the standard alloca() header.
7721 (replicate_table) Add prototype.
7723 Merged DISPLAY routine.
7724 * sysfile-info.c: (AS_*) New enum series.
7725 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
7727 (cmd_display, display_macros, display_documents,
7728 display_variables) Stolen from defunct display.c.
7729 (describe_variable) New function.
7731 * temporary.c: [0] (display_tree) New debug function.
7732 (copy_variable) Performs shallow copy of value labels instead of
7733 deep copy; i.e., just copys the AVL tree and increments the
7736 * val-labs.c: Comment fixes.
7737 (do_value_labels) Optionally skip leading forward slash.
7738 (get_label) Creates only a single value label instead of many
7739 copies of one, and sets the reference count.
7741 * display.c: Removed.
7743 * dump-sysfile.c: New file, not yet complete.
7745 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
7747 For lots of source files I added more verbose_msg's. These aren't
7748 listed below as they have tested as being benign. In some cases
7749 these replaced debug_printf() calls.
7751 * output.c: (outp_read_devices) Message fix.
7753 * postscript.c: (output_encodings) Message fix. Reports errors on
7755 (postopen) Message fix.
7757 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
7759 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
7761 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
7764 * main.c: Remove <malloc.h> #include.
7766 * mis-val.c: (parse_numeric) Set .f member for each missing[]
7767 instead of trying to just set the missing[] itself, which is a
7770 * sfm-read.c: (read_variables) Same.
7772 * str.h: Add memmem() prototype.
7774 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
7776 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
7778 * Makefile.am: (q2c) Don't include any libraries in the link.
7780 * dfm.c: (force_line_buffer_extension) New macro.
7781 (count_tabs) New function.
7782 (tabs_To_spaces) New function.
7783 (read_record) Calls tabs_to_spaces() on the line being processed.
7785 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
7786 have to be compiled twice (once for CC, once for LOCAL_CC).
7788 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
7790 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
7791 (LDADD) Add @INTLLIBS@.
7792 (q2c) Add LIBS, @INTLLIBS@ to link step.
7794 * inpt-pgm.c: Turn off debugging.
7796 * postscript.c: (postopen) Format fix. local_free() blocks
7797 returned by local_alloc(); don't free() them.
7799 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
7801 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
7804 * data-list.c: (read_from_data_list_fixed) Pass proper value for
7805 LEN arg, not simply the full string length.
7807 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
7808 directories before generic temp file directories.
7810 * vfm.c: Disable debugging.
7812 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
7814 * get.c: Comment fix.
7815 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
7817 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
7819 * expr-prs.c: (debug_print_postfix) Conditionally included on
7820 GLOBAL_DEBUGGING. Removed out_header() reference.
7822 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
7824 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
7826 * ascii.c: Removed obsolete ascii_close_page() prototype.
7828 * command.c: (output_line) Comment fix.
7830 * data-in.c: Formatting fix.
7831 (parse_string_as_format) Now the `fc' argument is used only for
7832 the purpose of error messages; it is not an index into the string
7833 passed. All references changed.
7835 * data-list.c: Comment fix.
7836 (cut_field) Comment fix. Now returns the column number of the
7837 position of the field cut out on success.
7838 (parse_field) Added `column' argument. Puts the column numbers in
7840 (read_from_data_list_free, read_from_data_list_list) Record the
7841 column number returned by cut_field(), pass it to parse_field().
7843 * dfm.c: Comment fix.
7845 * do-ifP.h: Comment fix.
7847 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
7848 the SYSMIS function.
7850 * expr.h, exprP.h: Comment fix.
7852 * glob.c: (init_glob) Only calls setlocale() and family if
7855 * hash.h: Comment fix.
7857 * include.c: Comment fix.
7859 * output.c: Comment fix.
7861 * postscript.c: (ps_line_intersection) Simplified assertion.
7863 * repeat.c: Comment fix.
7865 * vars-atr.c: Comment fix.
7867 * vars-prs.c: Comment fix.
7869 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
7870 behavior with usage of postincrement.
7871 (memory_stream_read) Discards cases as it goes.
7873 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
7875 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
7878 * Most source files: Includes debug-print.h, related comment
7881 * cases.c: (alloc_val) Removed complex allocation code. Merely
7882 increments default_dict.nval and returns the former value.
7883 (envector, devector) Removed references to lv member of struct
7886 * common.h: (macro VME) Replaced complex definition with simple
7889 * data-list.c: (cmd_data_list) Sets vfm_source instead of
7890 read_active_file and cancel_input_pgm.
7891 (read_from_data_list, cancel_data_list) Removed.
7892 (data_list_source_read, data_list_source_destroy_source) New
7894 (glob var data_list_source) New var.
7896 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
7897 (cmd_begin_data) Improved criteria for an input program accessing
7898 the inline file. Still not perfect.
7900 * do-if.c: (do_if_trns_proc) Simplified debug output.
7902 * expr-prs.c: Comment fixes.
7903 [DEBUGGING] (debug_print_postfix) Simplified debug output.
7905 * file-handle.q: (fh_close_handle) Simplified debug output.
7907 * file-type.c: Comment fixes.
7908 (cmd_file_type) Sets vfm_source instead of read_active_file and
7910 (cmd_end_file_type) On failure, discards variables in place of
7911 just canceling the input program.
7912 (read_from_file_type) Renamed file_type_source_read.
7913 (cancel_file_type) Renamed file_type_source_destroy_source.
7914 (glob var file_type_source) New var.
7916 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
7917 (cmd_get) Initializes options to GTSV_NONE before passing to
7918 trim_dictionary(). Removed `lv' reference. Sets vfm_source
7919 instead of read_active_file and cancel_input_pgm.
7920 (cmd_save_internal) Initializes options before passing to
7921 trim_dictionary(). Local var `nval' removed.
7922 (dict_delete_run) Comment fixes.
7923 (trim_dictionary) Comment fixes. Disallows scratch variables if
7924 GTSV_OPT_SAVE set in options.
7925 (read_from_get) Renamed get_source_read.
7926 (cancel_get) Renamed get_source_destroy_source.
7927 (glob var get_source) New var.
7929 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
7930 read_active_file and cancel_input_pgm.
7931 (read_from_input_program) Renamed input_program_source_read.
7932 Simplified debug output.
7933 (cancel_input_program) Renamed
7934 input_program_source_destroy_source.
7935 (glob var input_program_source) New var.
7937 * loop.c: (loop_1_trns_proc) Simplified debug output.
7939 * main.c: (dump_token) Made eof output more explicit.
7941 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
7944 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
7945 code for always-memory or always-disk cases. malloc's case-list
7946 based on vfm_source_info.ncases. Explicit support for
7947 memory_stream via memory_source_cases.
7948 (do_external_sort) Sets vfm_source instead of read_active_file and
7950 (allocate_file_handles) The temporary directory permissions are
7951 set to 0700 instead of 0777.
7952 (allocate_cases) Formatting fixes. Simplified debug output.
7953 (output_record) Compacts the case if necessary before writing it
7955 (close_handle, open_handle_w) Simplified debug output.
7956 (write_initial_runs) Destroys vfm_sink, then sets it to
7957 sort_stream. Writes records to memory based on
7958 vfm_sink_info.case_size.
7959 (write_to_sort_cases) Renamed sort_stream_write().
7960 (merge) Simplified error handling. Simplified debug output.
7962 (read_from_external_sort) Renamed sort_stream_read().
7963 Reads records based on vfm_source_info.case_size.
7964 (sort_stream_write) Writes records to memory based on
7965 vfm_sink_info.case_size.
7966 (sort_stream_mode) New function.
7967 (glob var sort_stream) New variable.
7969 * temporary.c: (cmd_temporary) Simplified debug output.
7970 (copy_variable) Removed references to `lv'.
7972 * title.c: (get_title) Simplified debug output.
7974 * var.h: Comment fixes.
7975 (struct get_proc) Removed member `lv'.
7976 (struct variable) Removed member `lv'. Comment fixes.
7977 (glob vars read_active_file, write_active_file, cancel_input_pgm)
7979 (struct case_stream) New.
7981 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
7982 read_active_file references to use vfm_source.
7983 (init_variable, replace_variable) Removed references to `lv'.
7985 * vfm.c: Comment fixes.
7986 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
7988 (static var queue, qh, qt, n_lag) Removed. All references
7990 (glob var compaction_necessary, compaction_nval, compaction_case,
7991 paging) New variables.
7992 (record_case) Removed.
7993 (procedure) Comment fixes. Calls vfm_source->read() instead of
7996 (prepare_for_writing, arrange_compaction, make_temp_case,
7997 vector_initialization, setup_filter) New function.
7998 (open_active_file) Most of the code moved into the abovementioned
7999 new functions. Now sets temp_dict to &default_dict if there is no
8000 temporary dictionary, for convenience. New debug output.
8001 (close_active_file) Deals with changing the sink to the source.
8002 Calls finish_compaction(). Frees compaction_case. Mostly
8004 (glob vars disk_source_file, disk_sink_file) New vars.
8005 (destroy_active_file, read_from_memory) Removed.
8006 (disk_stream_init, disk_stream_read, disk_stream_write,
8007 disk_stream_mode, disk_stream_destroy_source,
8008 disk_stream_destroy_sink) New functions.
8009 (glob var vfm_disk_stream) New var.
8010 (glob vars memory_source_cases, memory_sink_cases,
8011 memory_sink_iter, memory_sink_max_cases) New vars.
8012 (memory_stream_init, memory_stream_read, memory_stream_write,
8013 memory_stream_mode, memory_stream_destroy_source,
8014 memory_stream_destroy_sink) New functions.
8015 (glob var vfm_memory_stream) New var.
8016 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
8017 named `more_cases'. Simplified debug output. Otherwise mostly
8019 (record_case) Moved into the stream drivers. Removed.
8020 (transform) Removed (was dead code).
8021 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
8022 common case that the splits don't change, we don't need to copy
8023 the case into prev_case again--pointless.
8024 (compact_case) New function.
8025 (finish_compaction) New function.
8027 * vfmP.h: Comment fixes.
8028 (DEV_* enum series) Removed.
8029 (struct storage) Renamed `stream_info'. Removed variant record.
8030 Removed `device' member.
8032 * debug-print.h: New file.
8034 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
8036 * autorecode.c: Turned off debugging.
8038 * data-list.c: (destroy_dls) Closes the associated file handle.
8040 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
8041 parse_variables() options.
8043 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
8045 * display.c: (display_variables) Really fixed null cell bug.
8047 * file-handle.q: (fh_close_handle) Changed debugging message.
8049 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
8050 parse_variables() options.
8052 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
8053 (cmd_list) Fails if no variables specified.
8054 (determine_layout) Writes blank lines manually.
8056 * loop.c: (loop_1_trns_proc) Made debugging code only print
8057 messages if debugging.
8059 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
8060 parse_variables() arguments.
8061 (main) Parses optional parenthesized options to varlist
8062 subcommands into sbc->message.
8064 * sfm-read.c: Format fix.
8066 * var.h: (FV_*) New enum series.
8067 (PV_*) New enum PV_NO_SCRATCH.
8069 * vars-prs.c: (find_var) Removed.
8070 (fill_all_vars) Takes FV_* enum instead of boolean third
8071 argument. Rewritten to deal with scratch as well as system
8073 (parse_variables) Error message on scratch variable if
8076 * vfm.c: (static var virt_begin_func) New var.
8077 (procedure) Sets up virt_begin_func.
8078 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
8079 after dump_splits(). For succeeding groups changes, calls
8080 virt_begin_func() instead of begin_func().
8082 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
8084 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
8087 * dfm.c: Added some debugging messages, disabled by default.
8088 (open_file_r) Fixed error message.
8089 (read_record) On eof on inline_file, instead of calling
8090 fh_close_handle(), simply jump to eof label like a normal file.
8093 * display.c: Thin lines between rows for certain kinds of
8094 listing. Fixed `null cell' bug.
8096 * error.c: (failure) Flush stdout, stderr before failing.
8098 * file-handle.q: (fh_close_handle) Added debugging message.
8100 * frequencies.q: (dump_full) Bottom line extends across entire
8101 table width. Changed title formatting.
8102 (dump_condensed) Changed title formatting.
8103 (dump_statistics) Fixed title formatting.
8105 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
8106 Sets default value of set_format.
8108 * list.q: (cmd_list) Calls blank_line() before determine_layout().
8109 Passes write_all_headers() to procedure() as pre-group func.
8110 (write_all_headers) New function.
8111 (determine_layout) Removed calls to write_header().
8112 Calls blank_line() before and after write_fallback_headers().
8114 * recode.c: (recode_trns_free) Only attempts to free head->map if
8117 * sfm-read.c: (read_variables) Allows `#' at beginning of system
8118 file variable names but gives a warning. Sets `left' based on
8119 first character being/not being `#'. On lossage frees dict->var.
8121 * som-high.c: (som_draw_title) Simplified title formatting.
8123 * vfm.c: (dump_splits) Fixed and changed splits formatting.
8125 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
8127 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
8128 beginning. Frees v_src, v_dest on successful exit. Frees
8129 h_trans[*], h_trans on lossage.
8130 (recode) Frees h_trans[*], h_trans.
8132 * dfm.c: (dfm_close) Formatting change.
8133 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
8134 longer allocates its own in inline_file.
8135 (open_file_r) Passes the local dfm_fhuser_ext to
8137 (open_file_w) Message fix.
8138 (read_record) Buffer reallocation strategy changed. Frees
8139 ext->line even in inline_file to prevent leaks.
8140 (dfm_put_record) Fixed bug where `ext' was cached before the file
8141 was opened and thus it would be NULL when the file really was
8143 (cmd_begin_data) Sets up inline_file basics itself, then calls
8144 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
8146 * list.q: (write_line) Formatting fix.
8147 (clean_up) Minor strategy change. Sets proportional font after
8149 (determine_layout) Sets fixed font before writing regular headers,
8150 or after writing fallback headers.
8152 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
8153 and KEEP vars after using them.
8155 * postscript.c: (ps_init_driver) Frees x->family.
8156 (postopen) When loading fonts, free the temporary font name buffer
8158 (ps_text_set_font_by_position) Free temporary font name buffer
8160 (text) Fixed code that calculated `lig' so that `lig' always gets
8161 initialized. Formatting fix.
8163 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
8165 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
8166 cells, not xmalloc(), so that the cells will get destroyed
8169 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
8172 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
8174 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
8177 * dfm.c: Comment fix.
8179 * list.q: Comment fixes. Include somP.h. Removed static vars
8180 table, n_columns, n_rows, part. New struct list_ext. New static
8182 (n_lines_remaining, n_chars_width, write_line) New functions.
8183 (cmd_list, list_cases) Rewritten.
8184 (begin_row, end_row, flush_table) Removed.
8185 (write_header, clean_up, write_varname, write_fallback_headers,
8186 determine_layout) New functions.
8188 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
8190 * output.h: Comment fix.
8192 * postscript.c: Comment fix.
8193 (struct ps_driver_ext) Removed prop_size, fixed_size members;
8194 added font_size. All references changed.
8195 (ps_init_driver) Initializes font_size. Simplified space checking
8197 (static var option_tab[]) Removed prop-size, fixed-size; added
8199 (ps_option) Handles font_size.
8201 * som-high.c: Moved prototypes into somP.h.
8202 (som_init_driver) New function.
8203 (som_submit_table) Moved some code into new function
8205 (build_target) Moved some code into new function
8206 som_internal_eject_page().
8207 (som_eject_page) Uses som_internal_eject_page().
8208 (som_internal_eject_page) New function.
8210 * som-low.c: Moved prototypes into somP.h.
8212 * som.h: Formatting fixes.
8214 * somP.h: (struct som_driver_ext) Removed em_width;
8215 added prop_em_width, fixed_width.
8217 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
8219 * Makefile.am: Added `localedir' definition. Added
8220 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
8222 * ascii.c: (macro draw_line) Fixed capitalization.
8224 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
8225 compute.c, count.c, data-in.c, data-list.c, data-out.c,
8226 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
8227 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
8228 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
8229 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
8230 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
8231 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
8232 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
8233 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
8234 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
8235 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
8236 for internationlization.
8238 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
8240 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
8242 * do-if.c, sort.c, val-labs.c: Comment fixes.
8244 * glob.c: (init_glob) Uncommented, updated i18n support.
8246 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
8247 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
8248 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
8249 the declarations of macros taking arguments a lot nicer.
8251 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
8253 * error.h: Removed CE, CW aliases for SE, SW.
8255 * q2c.c: Removed explicit streq() definition since it's duplicated
8258 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
8259 stats.h, str.h, tokens.h: Made the declarations of macros taking
8260 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
8263 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
8265 * cmdline.c: Comment fixes.
8266 (pick_compat) Changed return type to int. Now, instead of setting
8267 glob var `compat' to the emulation, returns the emulation. All
8269 (parse_command_line) Added terminating null to end of
8270 `long_options' array definition.
8271 (pre_syntax_message) Fixes.
8272 (usage) Shows the default emulation in the syntax message by
8273 calling pick_compat().
8275 * getline.c: (getl_add_include_dir) Separates paths with
8276 PATH_DELIMITER, not DIR_SEPARATOR.
8278 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
8279 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
8281 * output.c: (outp_configure_macro) Make earlier definitions for a
8282 particular key override later ones for the same key.
8284 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
8286 * ascii.c: Comment fixes.
8288 * output.c: (outp_get_paper_size)
8289 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
8291 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
8293 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
8294 <errno.h>. GNU libc 2 enforces this!
8296 * command.c: (parse_cmd) Fixed problem with `else' clause being
8297 paired with wrong `if'. Comment fix.
8299 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
8301 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
8302 blp_getline() to getline().
8304 * output.c: (outp_eval_dimension) Changed the fix from last time;
8305 there was no variable `a'.
8307 * q2c.c: (get_line) Fixed boundary condition overrun bug.
8309 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
8311 * output.c: (outp_evaluate_dimension) Fixed handling of negative
8312 numbers having fractional parts. Added case of a fraction without
8313 a whole-number part.
8315 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
8317 * ascii.c: (ascii_text_get_font_position) Removed.
8319 * expr.h, exprP.h: Disabled debugging.
8321 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
8324 * output.h: (struct outp_class_struct) Removed
8325 text_get_font_position method. All references deleted.
8327 * postscript.c: Big change here. Fontmaps were completely
8328 eliminated because of a change in philosophy. Comment fixes.
8329 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
8331 (struct ps_driver_ext) `position', `fontmap', `prop_name',
8332 `fixed_name' members removed. New members `prop_family',
8333 `fixed_family'. `family' member changed to type char *.
8334 (static var ps_fontmaps) Removed.
8336 (ps_init_driver) Removed obsolete references, updated.
8337 Initializes `translate_x', `translate_y', `scale'. Doesn't read
8338 fontmap, of course. Refers to font names through internal_name
8339 rather than subversive means. Frees proper items.
8340 (static var option_tab[]) Removed `fontmap-file' option; renamed
8341 `fixed-font', `prop-font'.
8342 (ps_option) Corresponds to option_tab[].
8343 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
8344 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
8345 hash_family) Removed.
8346 (postopen) Generates font names from family names. Gets
8347 PostScript font name properly. New prologue file comment `!!!'
8349 (ps_open_page) Adds translate_x, translate_y to BP prologue
8350 function; gives SF argument floating-point format.
8351 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
8352 font name. Doesn't change font family.
8353 (ps_text_set_font_by_position) Generates Groff font name from font
8354 family name instead of through table lookup.
8355 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
8356 all references changed. Reduced to simple string assignment.
8357 (ps_get_font_name) Removed.
8358 (ps_get_font_family) Reduced to string return.
8359 (text) Doesn't save `position' since it no longer exists. Ugly
8360 kluge to save font family--fix soon?
8361 (load_font) Removed PostScript name argument.
8363 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
8365 * postscript.c: Comment fix.
8366 (ps_open_page) Puts scale factor in PostScript output.
8368 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
8370 * Makefile.am: Distcleans q2c.
8372 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
8374 * ascii.c: (delineate) Sets text size even if width is zero.
8376 * command.c: Comment fix.
8377 (static var cmd_table[]) Re-enabled EVALUATE command.
8378 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
8379 of comments in script files. Now more liberal on criteria for
8380 performing a state transition--if *anything* happened correctly,
8381 not just if *everything* happened correctly.
8383 * data-out.c: (convert_F) Comment fix. Why in the fsck does
8384 Checker segfault on formatting large numbers and why in the fsck
8385 hadn't I noticed this before?
8387 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
8389 * list.q: (cmd_list) Commented out the actual output routine
8390 because of various problems. Probably will abandon the idea of
8391 using the general `crushed tables' for the LIST procedure.
8393 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
8394 clearing it. Allocates a new var_by_name dictionary before trying
8395 to add members to it.
8397 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
8398 `sib'. Changed type of `node' argument.
8399 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
8401 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
8402 [DEBUGGING] Only deletes the variable from var_by_name if that var
8405 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
8407 * Makefile.am: Added include files to SOURCES. Added
8408 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
8409 includes rules for q2c. Added `boast' target.
8411 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
8413 * Makefile.am: Maintainer-clean Makefile.in.
8415 * Makefile.am: Fixed redundant EXTRA_DIST line.
8417 * ascii.c: Comment fixes.
8418 (ascii_line_vert) Fixed overly aggressive range check.
8420 * display.c: Removed dead code.
8422 * list.q: Turn debugging on.
8423 (flush_table) New debug code.
8425 * sfm-read.c: (read_value_labels) malloc's the structure before
8426 trying to assign to its members.
8428 * sfm-write.c: Comment fix.
8430 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
8432 (output_table) No arguments anymore--gets them through `som'
8433 global. New debug code. In crushed tables, now sets `htv' as
8434 well as `hv' to avoid bad confusion later.
8435 (dump_crush_page) New debug code.
8437 * som-low.c: (som_dump_crush_page) New debug code.
8439 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
8441 All source files: Broke long lines into multiple lines.
8443 * ascii.c: (ascii_close_page) Uses host_system var in place of
8444 HOST_SYSTEM constant.
8446 * cmdline.c: (var syntax_message[]) Broke into
8447 pre_syntax_message[] and post_syntax_message[].
8448 (usage) Outputs both parts, separated by driver list.
8450 * error.h: Fixed broken formatting.
8452 * expr-opt.c: (str_search, str_rsearch) New functions.
8454 * misc.c: (blp_getdelim) Removed. All references changed to
8456 (str_search, str_rsearch) Removed.
8457 (memrmem) New function.
8459 * misc.h: (blp_getline) Removed. All reference changed to
8464 * filename.c: Includes "stat.h", not <sys/stat.h>.
8465 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
8467 * output.c: (outp_list_classes) Changed output formatting.
8469 * sfm-write.c: (write_header) Uses host_system var instead of
8470 HOST_SYSTEM constant.
8471 (write_rec_7_34) Extracts version numbers from the version string.
8474 * sort.c: Includes "stat.h", not <sys/stat.h>.
8476 * str.c: (strcasecmp) Removed.
8478 * title.c: (cmd_document) Uses host_system var instead of
8479 HOST_SYSTEM constant.
8481 * version.c: Generated on-the-fly by the Makefile instead of being
8484 * str.h: Comment fixes. Doesn't substitute for missing memmove or
8486 [!HAVE_STRNCASECMP] Declares strncasecmp().
8488 * version.h: Removed stray character. Comment fixes.
8489 (vars host_system, build_system) New vars.
8491 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
8493 * Most source files: Changed formatting of copyright notice; fixed
8494 FSF address; reformatted to better conform to GNU standards;
8495 comment fixes. Added markups to prevent GNU indent from messing
8496 up my beautiful formatting :-).
8498 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
8499 that GNU indent markups can be passed through without problems.
8501 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
8503 * get.c: Turned off debugging.
8505 * glob.c: (init_glob) Turned on save-file compression by default.
8507 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
8508 compression than was possible in save files.
8510 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
8512 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
8514 * frequencies.q: Removed Fiasco extensions. Updated calculation
8515 algorithms. Polished output format.
8516 (struct frq_info_struct) Removed members `max_degree', `min_n',
8517 all references removed.
8518 (macro frq_extensions) Removed.
8519 (static vars min_n, max_degree) Removed, all references removed.
8520 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
8521 calculate `min_n', `max_degree'.
8522 (postcalc) Passes new arg to dump_statistics().
8523 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
8525 (dump_condensed) Adds variable name title.
8526 (sum_freqs) Removed.
8527 (calc_stats) Updated calculation algorithm.
8528 (dump_statistics) Removed warning for too-few observations.
8529 Changed table formatting. Adds variable name title if passed new
8532 * output.h: Comment fix.
8534 * recode.c, sample.c, sort.c: Disabled debug code.
8536 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
8537 Improved debug code.
8539 * var.h: (enum series frq_*) Removed Fiasco extensions.
8541 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
8543 * command.c: Added PROCESS IF to command table.
8545 * Lots & lots of places, removed checks for NULLs preceding calls
8546 to free_expression(), which itself checks.
8548 * descript.q: Removed Fiasco extensions. Removed optimizations
8549 for non-weighted active files. Implemented some options.
8550 Finished polishing output format. Comment fixes. Merged
8552 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
8553 max_degree, min_n) Removed.
8554 (macro dsc_extensions) Removed.
8555 (struct dsc_info_struct) Removed `min_n' member, all references
8557 (internal_cmd_descriptives) Removed calculation of min_n,
8558 max_degree. Only deals with one `calc' routine instead of two
8560 (precalc) Eliminated redundancy. Updated for changes to
8561 descriptives_proc structure.
8562 (calc) Moved here from `descript.g'. Rewritten to calculate
8563 statistics via `moments about the mean' rather than by summing,
8564 summing squares, summing cubes, and so on.
8565 (postcalc) Rewritten for new-style statistical calculation.
8566 (display) Removed support for displaying variables across rows.
8567 No longer crushes the descriptives table. Removed ancient code.
8568 Added display of N, by variable and listwise.
8570 * descript.g: Removed; merged into `descript.q'.
8572 * expr-evl.c: (evaluate_expression) Now returns a double. For
8573 numeric results, it returns the result as well as storing it in
8574 the passed `value' structure if non-NULL. For string results it
8575 just returns 0.0 and it must be passed non-NULL. Many references
8576 to this function were optimized by use of this change, especially
8577 but not exclusively in `compute.c'.
8579 * frequencies.g: Comment fix.
8581 * glob.c: (glob var process_if_expr) New global var.
8583 * postscript.c: (static var option_tab[]) Corrected entry for
8585 (postopen) Sets x->size to x->prop_size.
8586 (ps_text_set_font_by_name) Sets font size as well as typeface for
8587 PROP and FIXED fonts.
8589 * sel-if.c: (cmd_process_if) New function.
8591 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
8592 (sfm_write_dictionary) Sets `n_cases' to 0.
8593 (sfm_write_case) Increments `n_cases'.
8594 (sfm_close) Attempts to seek the system file back to the header
8595 and write the number of cases in its proper slot.
8597 * som-frnt.c: (som_insert_table) Masks off expansion options since
8598 only SOPT_X_NORM seems to work sensibly.
8600 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
8601 with a `fixed' value of 2.
8603 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
8605 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
8606 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
8608 * var.h: (enum series dsc_*) Removed Fiasco extensions.
8609 (struct descriptives_proc) Removed `miss_noweight'; new members
8610 `X_bar', `M2', `M3', `M4', `min', `max'.
8612 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
8614 * vfm.c: (close_active_file) Cancels PROCESS IF.
8615 (write_case) Doesn't process cases unselected by PROCESS IF.
8617 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
8619 * glob.c: (glob var err) Removed.
8621 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
8622 doesn't have to take into account number of value labels since
8623 they're in a subtable anyway. Also, doesn't display more than 10
8624 value labels since we can't yet break pages in subtables.
8626 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
8628 * som-frnt.c: (som_change_table_size) Simple change for elegance
8629 that shouldn't change behavior.
8630 (som_set_value) Comment fix.
8632 * som-high.c: (som_submit_table) Message fix.
8634 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
8636 * command.c: Added SYSFILE INFO to command table.
8638 * file-handle.q: (fh_handle_filename) New function.
8640 * get.c: (save_trns_proc) Fixed a bug in padding of output data
8643 * main.c: (parse) New return value for command functions, -3.
8645 * misc.h: Comment fix.
8647 * output.h: Comment fixes.
8648 (macro COMPONENTS) Removed.
8650 * postscript.c: (write_text) Modified literal_chars[] so that `('
8651 and ')' are not written to the output in strings as literals.
8653 * sfm-read.c: (sfm_read_dictionary) New argument.
8654 (read_header) New argument. Sets the information structure's
8655 values from the header information.
8656 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
8657 bizarre Checker problem, I guess.
8658 (read_variables) Proper cleanup on lossage.
8660 * sfm.h: (struct sfm_read_info) New struct for use by
8661 sfm_read_dictionary().
8663 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
8664 currently used just for tables that can be dynamically resized and
8665 thus have to be allocated with arena_malloc() instead of
8666 arena_alloc(). All references changed.
8667 (som_change_table_size) New function.
8668 (som_insert_table) Bugfix: now inserts `cell', not `c'!
8670 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
8671 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
8674 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
8676 (draw_intersection) Now takes an argument specifying the table in
8677 question. All references changed.
8678 (draw_table_cell) New function.
8679 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
8680 (som_get_table_size) Many nice new explanatory comments.
8681 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
8683 * som.h: New enum series SOM_CREATE_* for use as create flags with
8686 * str.h: Moved a comment here from TODO.
8688 * sysfile-info.c: New file. Reference implementation.
8690 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
8692 * command.c: Added RENAME VARIABLES to table of commands.
8694 * data-in.c: (dls_error) Sets `cust_field'.
8695 (parse_N) Message fix.
8696 (parse_day_count) New function.
8697 (to_roman) Never outputs VX as a `short form' of V.
8698 (parse_month) Fixed parsing of Roman numerals.
8699 (parse_trailer) Message fix.
8700 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
8701 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
8702 the date is invalid.
8703 (parse_SDATE) Fixed swapped day, year.
8704 (parse_JDATE) Fixed bug for dates in 1582.
8705 (parse_DTIME) Allows days not between 1 and 31.
8706 (parse_numeric) Makes local copy of f.type for easier usage.
8709 * data-out.c: (convert_F) When outputting as scientific, properly
8710 sets f.type as fp->type.
8711 (insert_commas) Fixed operator precedence problem with setting of
8712 nitems. Changed strcpy to memcpy (no null terminator).
8713 (convert_date) Fixed FMT_JDATE: added 1900 to year.
8714 (convert_CCx) Essentially rewritten, but now it works.
8716 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
8718 (display_documents) Implemented.
8720 * error.c: (glob var cust_field) New var.
8721 (vmsg) Displays cust_field as part of message classes DE and DW.
8723 * formats.c: (debug_print) Fixed to compile under updated
8726 * get.c: (cmd_get, cmd_save_internal) Close file handle on
8729 * misc.c: (parse_format_specifier) Formatting fix.
8731 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
8732 `n_rename' for clarity.
8733 (cmd_modify_vars) Initializes `forward' and `positional' at
8734 appropriate times. Frees lists of vars to rename on failure.
8735 Comment fix. Frees memory on success.
8736 (rearrange_dict) Simplified `for' loop condition.
8738 * rename-vars.c: New file (reference implementation).
8740 * set.q: (internal_cmd_set) Fixed `emu' test condition.
8742 * sfm-read.c: (read_header) File label is created only if file
8743 label in file is not blank.
8744 (read_variables) Initializes `dict' local variable.
8745 (read_documents) Proper behavior on lossage.
8747 * sfm-write.c: (write_header) Doesn't blank out the file label
8748 (why was this here to begin with?!)
8750 * temporary.c: (save_dictionary) File label is copied only if
8751 non-NULL. Doesn't try to xstrdup() dictionary documents.
8752 Adapted so as to not irritate Checker.
8753 (free_dictionary) Only destroys var_by_name if non-NULL.
8755 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
8756 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
8757 lines to the document, indents the document. Also, it works now.
8758 (add_document_line) New function.
8760 * var.h: (struct dictionary) Reordering.
8762 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
8763 bits if it was allocated to begin with.
8765 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
8767 * command.c: Added MODIFY VARS to list of commands.
8769 * configure.in: Updated custom macros for autoconf 2.12. Removed
8770 mmap reference; fixed termcap library reference.
8772 * display.c: (display_variables) Fixed a few bugs although it's
8773 still not well written.
8775 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
8776 (induce_segfault) Calls chkr_disp_call_chain() instead of
8777 inducing an actual SIGSEGV.
8779 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
8780 str_search() and str_rsearch(). Fixed tests for matches on
8781 OP_INDEX and OP_RINDEX.
8783 * filename.c: (good_getcwd) Removed as the new libc for Checker
8784 doesn't contain this bug, apparently.
8786 * misc.c: (str_search, str_rsearch) Changed order of arguments for
8787 consistency with GNU memmem.
8788 (blp_getdelim) Changed `len' from `int' to `size_t'.
8790 * modify-vars.c: Reference implementation.
8792 * som-frnt.c: (zero_length) New global var.
8793 (som_create_table) Message fix.
8795 * som.h: Added gcc attributions to som_set_text(),
8796 som_output_text() prototypes. blank_line() refers to
8797 zero_length[] instead of a literal null string to suppress gcc
8800 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
8801 (allocate_cases) Decrements x_max so the last element of x[] can
8802 be used by the algorithm.
8804 * var.h: Changed minor details of `variable' declaration.
8805 (struct modify_vars_proc) New struct.
8806 (struct variable) Added field p.mfv.
8808 * vars-atr.c: Comment fix.
8810 * vars-prs.c: (fill_all_vars) More optimal implementation.
8812 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
8813 character, which it shouldn't have to do but printf() seems to
8814 read the null byte even though I supply a maximum length...
8816 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
8818 * command.c: Removed command alias X for QUIT.
8819 (parse_cmd) Fixed comment parsing.
8821 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
8823 (read_record) Fixed references to len, size.
8824 (dfm_get_record) Restructured.
8826 * file-handle.h: (struct file_handle) Field `lrecl' now of type
8829 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
8832 * modify-vars.c: New file. Not complete.
8834 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
8837 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
8838 problems caused by int/size_t differences.
8840 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
8843 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
8844 being compared were of equal length.
8846 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
8848 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
8850 * lexer.c: (get_dotted_rest_of_line) New function.
8852 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
8855 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
8856 type 6 records. Frees the dictionary properly.
8857 (read_header) Initializes the dictionary instead of letting
8858 read_variables() do it. Sets the dictionary file label from the
8860 (read_documents) New function.
8862 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
8863 write type 6 record if appropriate.
8864 (write_header) Writes file label from dictionary.
8865 (write_documents) New function.
8867 * temporary.c: (save_dictionary, restore_dictionary,
8868 free_dictionary) Properly handle new fields in dictionary struct.
8870 * title.c: (get_title) Returns after failure().
8871 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
8872 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
8874 * var.h: (struct dictionary) New fields `label', `n_documents',
8877 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
8879 * command.c: Added FILTER to list of commands.
8881 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
8884 * get.c: (cmd_save_internal) Removed weighting code since it's now
8885 handled by sfm-write.c. Properly commented out debug code.
8887 * glob.c: (glob var weighting) Removed.
8889 * sel-if.c: Comment fixes.
8890 (cmd_filter) New function.
8892 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
8893 (sfm_read_dictionary) Sets weighting variable direct in the
8894 created dictionary now. (Apparently we previously didn't support
8896 (read_header) Sets weight_index field in sfm_fhuser_ext from
8897 header read from disk.
8899 * sfm-write.c: (sfm_write_dictionary) Comment fix.
8900 (write_header) Now sets the weighting in the header from the
8901 passed primary dictionary instead of from the sfm_write_info.
8903 * sfm.h: (struct sfm_write_info) Removed field `weight'.
8905 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
8906 broke on boundary conditions.
8908 * var.h: (struct dictionary) New fields `weight_var',
8909 `weight_index', and `filter_var'.
8910 (glob var weighting) Removed. This is now part of struct
8911 dictionary. All references changed; the less mechanical changes
8912 are described above.
8914 * vars-atr.c: (find_dict_variable) New function.
8916 * vfm.c: (static var filter_index) New variable.
8917 (open_active_file) Initializes filter_index from default_dict.
8918 (write_case) Calls proc_func() only if the filter variable is
8919 nonzero; this implements FILTER behavior.
8921 * weight.c: (static var weight_varname) Removed.
8922 (cmd_weight) Modified default_dict instead of glob vars.
8923 (update_weighting) Changed the signature to modify a dictionary
8924 instead of glob vars. Now returns the weighting variable.
8925 (get_weighting_variable) Removed; its function is absorbed by
8927 (stop_weighting) Operates on a dictionary now.
8929 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
8931 * sort.c: Removed debugging info from messages.
8932 (do_external_sort) Cleans up after itself by deleting the
8933 temporary directory on failure. (On success it is deleted by the
8935 (allocate_cases) Removed debug code. Added clean up code.
8936 (output_record) Removed debug code.
8937 (merge) Added code to close all the input files that are currently
8938 open. This is a likely location for bugs, because I'm not sure
8939 about boundary conditions. Removed an unnecesary heap_delete().
8940 (merge_once) Removed input file "optimization" that in fact
8941 screwed up the rest of the code. Message and comment fixes.
8943 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
8945 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
8947 * heap.c: (heap_delete) New argument.
8949 * sort.c: Finished implementation of external sort.
8951 * vfm.c: (read_from_disk) Returns after a disk error.
8953 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
8955 * sort.c: (static var state) Removed.
8956 (static vars max_handles, tmp_basename, tmp_extname,
8957 huffman_queue) New variables.
8958 (do_external_sort) Moved most code to new functions.
8959 Creates huffman_queue.
8960 (allocate_file_handles, allocate_cases) New functions.
8961 (static vars run_no, run_length, file_index, case_count) New
8963 (output_record) Returns success. Now really writes to the output
8965 (begin_run, end_run) New functions.
8966 (write_initial_runs) Returns success. Initializes run_no to -1.
8967 Calls begin_run(), end_run() at appropriate times. Outputs debug
8969 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
8971 (merge) New function.
8973 * heap.c, heap.h: New files. Hopefully in near-final form.
8975 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
8977 * glob.c: Added write_active_file to global vars.
8979 * sort.c: Several new miscellaneous static variables.
8980 (cmd_sort_cases) Big comment fix.
8981 (perform_case_2) Renamed `do_external_sort' and completely
8983 (case_2_proc_func) Removed.
8984 (output_record, write_initial_runs, write_to_sort_cases,
8985 compare_record) New functions.
8987 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
8989 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
8991 * sort.c: (perform_case_2) Changed the method for allocation of
8992 lots of memory--now allocates one case at a time in hopes that
8993 more cases can be allocated with heavily fragmented memory.
8995 * var.h: (write_active_file) New global var.
8997 * vfm.c: (procedure, close_active_file, write_case,
8998 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
8999 arguments to procedure() to be NULL. All references to
9000 procedure() that made use of dummy functions were changed to NULL
9002 (open_active_file) If write_active_file is non-NULL, the output
9003 device becomes DEV_PGM (a new enum).
9004 (close_active_file) Sets write_active_file to NULL.
9005 (read_from_memory) Comment fix.
9006 (record_case) Calls write_active_file() when the output device is
9009 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
9013 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
9014 Fixed checking for duplicate varnames.
9015 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
9017 (autorecode_trns_free) Destroys hash tables for each recoding
9019 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
9021 * command.c: Added SORT CASES to cmd_table.
9022 (null_func, null_int_func) Prototyped.
9024 * descript.g: (calc_weight, calc_noweight) Computes own case
9027 * frequencies.q: (dump_statistics) Fixed problem with
9028 too-few-cases warning message.
9030 * get.c: (cmd_save_internal) Handles weighting properly.
9032 * hash.c: (hsh_dump) Output format changed.
9033 (force_hsh_insert) Actually works now, prototype changed.
9035 * list.q: (static var case_num) New variable.
9036 (cmd_list) Initializes case_num.
9037 (list_cases) Increments case_num.
9039 * var.h: Added definitions for SORT CASES. Comment fixes.
9041 * vfm.c: Some definitions moved to new file vfmP.h. Comment
9042 fixes. `active' renamed vfm_active, `rep' renamed
9043 vfm_replacement, all references changed.
9044 (procedure) The procfunc no longer receives a case number. All
9046 (write_case) Subtle reordering.
9047 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
9050 * weight.c: (get_weighting_variable) New function.
9052 * vfmP.h: New file with definitions from vfm.c.
9054 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
9056 * command.c: (FILE_TYPE_okay) Commented out some tests because
9057 they're clumsy and not yet needed.
9059 * var.h: Most *_trns structures moved to their respective source
9060 files. Some were moved into a new file, do-ifP.h. Comment fixes.
9061 (union any_trns) Changed to a typedef for trns_header.
9062 (struct input_program_pgm) Removed.
9064 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
9065 was allocated in the first place.
9067 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
9069 * autorecode.c: New file.
9071 * command.c: Added AUTORECODE to command table; re-enabled SET.
9073 * data-out.c: (convert_F) Handles infinities and NaNs properly.
9075 * error.c: (vmsg) Comment fixes.
9077 * hash.c: Comment fix.
9078 (hashpjw_d) New function.
9079 (hashpjw) Reimplemented as call to more general function
9081 (internal_comparison_fn) Initializes pointers properly.
9082 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
9083 (force_hsh_insert, force_hsh_find) New debugging wrapper
9086 * main.c: (main) Message fix.
9088 * output.c: (outp_read_devices) Message fix.
9090 * set.q: Comment fixes.
9091 (custom_results) Implemented Wnd/X form of subcommand.
9092 (set_routing) New function.
9093 (internal_cmd_set) Implemented ERRORS, MESSAGES.
9095 * settings.h: (SET_ROUTE_*) New enum series.
9096 (set_results) Renamed set_results_file, all references changed.
9097 (set_messages) Removed.
9098 (glob vars set_errors, set_messages, set_results) New vars.
9100 * title.c: (get_title) Remembers to xstrdup() the result of
9103 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
9105 (union any_trns) New element `arc'.
9107 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
9109 * command.c: (output_line) Removed references to set_screen.
9111 * error.c: (static var terminating) New var.
9112 (hcf) Sets terminating to 1.
9113 (vmsg) If terminating is nonzero, does not attempt to call hcf().
9114 This prevents an infinite loop if an error occurs within hcf().
9116 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
9117 statement circumlocution with `case 42000' trick.
9118 (evaluate_expression) New support for OP_STR_MIS.
9120 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
9121 statement circumlocution with `case 42000' trick.
9122 (dump_node) Handles OP_STR_MIS.
9124 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
9125 variables exceptions.
9126 (parse_function) Message fix.
9127 (ops[]) Added OP_STR_MIS.
9129 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
9131 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
9133 * glob.c: Removed set_scrnfile glob var.
9134 (init_glob) set_errorbreak set to 0 by default.
9136 * groff-font.c: Changed included files.
9137 (groff_read_font) Initializes font_arena local var correctly.
9138 (default_font) New function.
9140 * output.c: Comment fixes.
9141 (glob var disabled_devices) New variable.
9142 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
9144 [GLOBAL_DEBUGGING] (reentrancy) New function.
9145 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
9146 outp_iterate_enabled_drivers) Calls to reentrancy().
9147 (destroy_list) New function.
9148 (outp_done) Moved code to destroy_list().
9149 (parse_options) Parses `listing', `screen', `printer' options
9151 (configure_driver) Sets new `device' member of driver.
9152 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
9154 * output.h: Comment fixes. New enum series OUTP_DEV_*.
9155 (struct outp_driver_struct) New member `device'.
9157 * postscript.c: (find_encoding_file) Doesn't display its own error
9159 (default_encoding) New function.
9160 (switch_font) Calls default_encoding() if no encoding can be
9162 (text) Makes up a character metric if none exists for the desired
9164 (load_font) Properly copies a fallback filename. Calls
9165 default_font() for a font if none at all are known.
9167 * set.q: Comment fixes. Removed OUTPUT subcommand.
9168 (custom_listing) Calls outp_enable_device() to enable/disable
9170 (turn_screen_on) Removed.
9171 (internal_cmd_set) Calls outp_enable_device() to enable/disable
9172 screen, printer devices.
9174 * settings.h: Comment fixes.
9175 (glob vars set_output, set_printer, set_screen, set_scrnfile)
9178 * som-high.c: (som_submit_table, som_eject_page) Use
9179 outp_iterate_enabled_drivers() instead of iterating
9180 outp_driver_list directly.
9182 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
9184 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
9185 (parse_string_as_format) Handles new formats.
9186 (parse_numeric) Now handles DOT and PCT formats.
9188 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
9190 (convert_date) Handle EDATE and SDATE formats.
9191 (convert_CCx) Now if there's not room for the currency characters,
9192 converts it as F format if it's positive instead of giving up
9193 quickly. Also fixed save-and-restore bug with decimal point
9195 (convert_format_to_string) Handles new formats.
9197 * misc.c: (formats[]) Added new formats.
9198 (convert_fmt_ItoO) Supports new formats.
9200 * sfm-read.c: (parse_format_spec) Supports new formats. Better
9201 data checking. New argument, all references changed.
9203 * sfm-write.c: (write_format_spec) Supports new formats.
9205 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
9208 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
9210 * cmdline.c: Comment fixes.
9211 (parse_command_line) Changed return type to void.
9213 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
9215 (parse_numeric) Handles international numbers (comma as decimal
9216 point). Some reformatting.
9218 * data-list.c: (parse_free) Default output format is now
9219 set_format instead of hard-coded F8.2.
9220 (read_from_data_list_list) Emits error message on undefined data
9221 only if set_undefined is nonzero.
9223 * data-out.c: (convert_E) Changes decimal point from period to
9224 comma if appropriate. Restructured. Better comments.
9225 (convert_F) Changes decimal point from period to comma if
9227 (insert_commas) Major bug with handling of negative values fixed.
9228 Also, inserts periods instead of commas if appropriate.
9229 (convert_CCx) New function.
9230 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
9231 (num_to_string) Changed `.' to set_decimal.
9233 * dfm.c: Comment fixes.
9234 (dfm_close) Frees ext->line even in inline_file.
9235 (open_inline_file) New function.
9236 (open_file_r) When opening the inline file: now properly
9237 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
9239 (read_record) Calls fh_close_handle() instead of dfm_close() to
9240 close the inline file. Makes a copy of the line getl_buf to avoid
9242 (dfm_get_record) Restructured. Now checks the return value of
9244 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
9245 checking for use of inline file. No longer tries to close inline
9248 * error.c: (glob var error_already_flagged) New var.
9249 (vmsg) Message change. Now checks max number of errors/warnings,
9252 * file-handle.q: (fh_handle_name) Now allows closing of
9254 (fh_init_files) Reformatted.
9256 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
9258 * getline.c: (getl_include) Fixed bug that popped up when called
9259 when file queue was empty.
9260 (read_console) Resets error_count, warning_count,
9261 error_already_flagged to zero.
9263 * glob.c: Many changes to update list of variables.
9264 (init_compat_dependent) Now this function is called whenever
9265 `compat' changes. It now sets set_seed only if it hasn't
9266 previously been referenced. It now calls
9267 lex_init_compat_dependent().
9269 * include.c: (cmd_include_at) Frees temporary buffer instead of
9271 (cmd_include) Doesn't make copy of include file name.
9273 * lexer.c: Comment fixes.
9274 (init_lex) Moved some code into new function
9275 lex_init_compat_dependent().
9276 (lex_init_compat_dependent) New function.
9277 (hex_val) Simplified.
9278 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
9280 * main.c: Comment fixes.
9283 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
9284 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
9285 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
9286 (setup_randomize) Sets set_seed_used.
9288 * set.q: Comment fixes.
9289 (custom_results) Conditionalizes on `compat'.
9290 (custom_log) Calls custom_journal().
9291 (set_ccx) New function.
9292 (cmd_set) Calls init_compat_dependent() when `compat' changes.
9293 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
9294 when set_decimal changes. Range-checks values for MITERATE,
9295 MNEST. Message fixes.
9297 * settings.h: Comment fixes.
9298 (struct set_cust_currency) New struct.
9299 (set_cc[], set_grouping, set_seed_used) New global vars.
9301 * var.h: (FMT_CCA...FMT_CCE) New output formats.
9302 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
9304 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
9306 * glob.c: Revised variables to correspond to settings.h.
9307 (init_glob) Initializes variables from settings.h properly.
9309 * set.q: Began long-overdue major revision to correspond to new
9310 philosophy. Most code changed.
9312 * settings.h: Mostly changed; reorganized, reordered, large new
9315 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
9317 * get.c: (cmd_save_internal) No longer forces compression off.
9319 * sfm-read.c: (read_compressed_data) If eof is reached when
9320 reading a new instruction octet, only signal error if we're in the
9323 * sfm-write.c: (COMPRESSION_BIAS) New #define.
9324 (struct sfm_fhuser_ext) New member `end'.
9325 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
9326 (ensure_buf_space) New function.
9327 (sfm_write_case) Reimplemented in order to support compression.
9328 (sfm_close) Writes out the remaining contents of the compression
9331 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
9333 * command.c: Defined SAVE and XSAVE commands in command table.
9335 * common.h: second_lowest_value is of type flt64, not double.
9337 * file-handle.h: Comment fix.
9339 * get.c: Comment fixes.
9340 (static var `trns') New.
9341 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
9342 cmd_save_internal, cmd_save, cmd_xsave) New functions.
9343 (dict_delete_run) Clears the variables and frees them now.
9344 (trim_dictionary) Sets default for compression.
9345 On KEEP subcommand, frees deleted variables as well as clearing
9346 them. Finally got the sense of the test for deleting all
9348 [DEBUGGING] (dump_dict_variables) Message fix.
9350 * glob.c: (init_glob) set_compression set to 1 by default.
9352 * list.q: Properly #includes config.h.
9354 * misc.h: New macro REM_RND_UP.
9356 * settings.h: Comment fix.
9358 * sfm-read.c: (structs sysfile_header, sysfile_format,
9359 sysfile_variable; inline function bswap_int32) Moved to new file
9361 (corrupt_msg) [__CHECKER__] No longer induces segfault.
9362 (sfm_read_dictionary) Fixed bug caused by failing to initialize
9364 (read_machine_flt64_info) Fixed some problems caused by confusion
9365 between flt64 and double types.
9366 (read_header) Message fix.
9367 (read_variables) Fixed set of cases in which we byte-swap sv.print
9368 and sv.write. Fixed confusion of flt64 and double.
9370 * sfm.h: (struct sfm_write_info) New.
9372 * som-high.c: (som_draw_title) Properly frees `s'.
9374 * temporary.c: (save_dictionary) Comment fix.
9376 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
9377 (struct trns_header) Formatting fix.
9378 (struct save_trns) New.
9380 * vars-atr.c: (discard_variables) Comment fix.
9382 * sfm-write.c: New file, baseline release.
9384 * sfmP.h: New file, baseline release.
9386 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
9388 * cmdline.c: (parse_command_line) `--version' output updated.
9389 (glob var syntax_message[]) Added my e-mail address.
9391 * file-handle.q, lexer.c, vfm.c: Changed many instances of
9392 `illegal' to `invalid'.
9394 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
9395 uncompression buffer.
9396 (sfm_close) Frees decompression buffer.
9397 (sfm_read_dictionary) Initializes decompression buffer.
9398 (buffer_input, read_compressed_data) New functions.
9399 (sfm_read_case) Restructured; now calls read_compressed_data() to
9400 handle compressed system file data.
9402 * var.h: Comment fix.
9404 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
9406 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
9409 * get.c: New comments. New static var `get_file'.
9410 (cmd_get) Now fully implemented. Calls discard_variables();
9411 initializes fv and lv for all variables; new debug code; sets
9412 up the dictionary; sets up the input program.
9413 (read_from_get, cancel_get) New functions.
9415 * sfm-read.c: Comment fixes.
9416 (sfm_close) New static function.
9417 (sfm_read_dictionary) Properly sets up the class of the
9418 file_handle. No longer cares what size the data is in records of
9419 type 7. Also, on failure, properly cleans up the file_handle and
9421 (read_variables) No longer thinks it knows `nval' of the
9422 dictionary. Now sets p.get.fv, etc., instead of speculatively
9424 (read_value_labels) Fixed off-by-one error in indexing of
9426 (sfm_read_case) New function.
9427 (sfm_r_class) New static var.
9429 * var.h: (get_proc) New struct.
9430 (struct variable) New member p.get.
9432 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
9434 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
9435 the manual's meaning.
9436 (rename_variables) New function.
9437 (trim_variables) Doesn't try to parse MAP any more. Removed debug
9438 code. Now properly reorders the dictionary on the KEEP keyword.
9440 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
9443 * vars-atr.c: (clear_variable) New argument `dictionary *'.
9444 (rename_variable) New function.
9445 (free_val_lab) Reformatted.
9447 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
9449 * var.h: Reindented entire file. Comment fixes.
9450 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
9452 (glob var default_dict) New.
9453 (struct indirect_dictionary) Removed.
9455 * Many other source files were changed to add `default_dict.'
9456 before all references to the dictionary of the active file.
9458 * vars-atr.c: (make_indirect_dictionary) Removed.
9460 * glob.c: Reindented all variable declarations. Updated for
9461 changed var.h. Comment fixes.
9463 * temporary.c: (restore_dictionary, save_dictionary) Simplified
9464 because now we can mainly copy dictionary structs.
9466 * vars-prs.c: (is_dict_varname, parse_dict_variable,
9467 parse_variables) Takes dictionary instead of indirect_dictionary
9469 (parse_variables) Instead of calling make_indirect_dictionary,
9470 just sets DICT to &default_dict if DICT is NULL. Of course, lots
9471 of `*dict.' references had to be changed to `dict->'. Removed
9474 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
9476 * get.c: Added GTSV_OPT_* series of enums.
9477 (trim_dictionary, dict_delete_run) New functions.
9478 [DEBUGGING] (dump_dict_variables) New function.
9479 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
9480 [DEBUGGING] Calls dump_dict_variables() to display results.
9482 * glob.c: (cmp_variable) Now a public function declared in var.h.
9484 * sfm-read.c: Turned off debug code. Comment fixes.
9485 (read_machine_int32_info, read_machine_flt64_info) New functions
9486 to parse type 7 records.
9487 (sfm_read_dictionary) Properly byteswaps several fields now.
9488 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
9489 records. [DEBUGGING] Dumps dictionary.
9490 (read_variables) Sets `index' field of variables created properly.
9491 Constructs avl tree of variables in dictionary. [DEBUGGING] No
9492 longer dumps dictionary.
9493 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
9495 [DEBUGGING] (dump_dictionary) No longer stubbed out.
9497 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
9498 var before destroying any variables just to save a little time.
9500 * var.h: (struct variable) Reordered in order to make name[] the
9501 first member; this makes pointers to `variable' pointers to the
9502 variable name, simplifying avl trees, etc.
9503 (struct indirect_dictionary) New struct.
9505 * vars-atr.c: (find_variable) Rewritten for efficiency.
9506 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
9508 (is_varname) Rewritten for efficiency.
9509 (parse_variables) New argument, which is a `dictionary *'. All
9510 references changed. This function now reads variable names from
9511 the dictionary passed, or from the default dictionary if NULL.
9513 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
9515 * misc.h: Added new macro DIV_RND_UP to perform integer division,
9516 rounding up. Changed many references to ROUND_UP to use this
9519 * sfm-read.c: Includes avl.h.
9520 (corrupt_msg) Induces a segfault under Checker.
9521 (macro assertive_bufread) New. Many references to bufread() now
9523 (sfm_read_dictionary) Split up into several functions. Added code
9524 to read dictionary records following the the type 2 records. Not
9525 quite complete. New variable `var_by_index'.
9526 (read_header, read_variables) New functions extracted from
9527 sfm_read_dictionary().
9528 (read_value_labels) New function.
9529 (bufread) Checks ferror() if fread() doesn't return the expected
9530 value; if ferror() is zero it's just EOF.
9531 (dump_dictionary) Stubbed out.
9533 * BTW: The source code now exceeds 50000 lines!
9535 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
9537 * command.c: Added GET to cmd_table[].
9539 * list.q: Removed reference to alloca headers.
9540 (cmd_list) Gave prototype.
9542 * sfm-read.c: Added DEBUGGING comments.
9543 (sfm_read_dictionary) Checks bias correctly. Sets
9544 dict->var_by_name to NULL. Calculates long_string_count
9545 correctly. realloc's dict->var[] array to minimum size.
9546 [DEBUGGING] Calls dump_dictionary.
9547 [DEBUGGING] (dump_dictionary) New function.
9549 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
9550 (restore_dictionary) If the dictionary contains a non-NULL
9551 var_by_name, uses that instead of generating one.
9552 (free_dictionary) Destroys var_by_name.
9554 * var.h: (struct dictionary) Added field `var_by_name'.
9556 * get.c: New file, not complete.
9558 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
9560 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
9561 (parse_num_or_range) New function.
9562 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
9563 <n> THRU HIGH missing values.
9565 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
9566 __attribute__((const)).
9568 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
9570 * sfm-read.c: Finished reference implementation.
9572 * sfm.h: Includes var.h.
9574 * var.h: Comment fixes.
9575 (struct `variable') Reordered some fields.
9577 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
9578 constants added previously.
9580 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
9582 * common.h: Comment fixes. Added declaration of
9583 `second_lowest_value' as variable or macro. Made `compat_type',
9584 `pgm_state_type' into anonymous enums.
9586 * display.c: Comment fix.
9588 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
9590 [!defined SECOND_LOWEST_VALUE] Added definition for
9591 `second_lowest_value' global var.
9592 (compat, pgm_state global vars) Changed types to `int'.
9593 (init_glob) Initializes `second_lowest_value'.
9595 * sfm-read.c: Continued work, not complete.
9597 * var.h: Added new MISSING_* constants to handle LOWEST and
9600 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
9602 * sfm-read.c: New file, not complete.
9604 * cases.c: (vec_insert) Changed vector expansion algorithm.
9605 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
9606 mucking up the RECODE transformation in particular.
9607 (envector) Harmless change in notation.
9609 dfm is now fairly well tested again.
9610 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
9612 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
9614 * recode.c: Comment fix.
9616 * sfm.h: Interface should be fairly final now, or at least for a
9619 * vfm.c: [DEBUGGING] (index_to_varname) New function.
9620 (open_active_file) [DEBUGGING] Translates ccase indices into
9621 variable names now to make it easier to understand what's really
9624 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
9626 * data-in.c: Comment fix.
9628 * data-list.c: Includes dfm.h.
9629 (do_reading) Uses new function dfm_push_cust().
9631 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
9634 * file-handle.h: Completely changed. Some parts split off into
9635 new file dfm.h. Implemented in file-handle.q.
9636 (enum FH_*) Removed.
9637 (struct fh_ext_class) New struct.
9638 (struct file_handle) Retained only these fields: name, norm_fn,
9639 fn, recform, lrecl, mode. New fields class, ext.
9640 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
9641 close_handle, handle_name) Added `fh_' prefix to name, all
9644 * dfm.h: New file, implemented in dfm.c.
9645 (get_record, put_record, fwd_record, bkwd_record, set_record,
9646 get_cur_col) Functions moved from file-handle.h, now prefixed with
9648 (dfm_push_cust) New function.
9650 * sfm.h: New file. Incomplete.
9652 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
9653 interface. Functions reordered, comments changed. Not well
9654 tested, probably full of bugs.
9655 (struct dfm_fhuser_ext) New struct.
9656 (dfm_close) New function.
9657 (open_file_r) Pickier about finding `BEGIN DATA.' line.
9658 (open_file_w) User messages changed.
9659 (get_record) Comment fixed.
9660 (read_record) Increments ext->ln even for inline_file. Calls
9661 dfm_close() for inline_file when `END DATA.' encountered.
9662 (dfm_get_record) Experimental restructuring.
9663 (dfm_push_cust) New function.
9664 (cmd_begin_data) Detects whether the inline file was fully read by
9665 checking whether it is still open; detects whether it was read at
9666 all by checking whether the line number is greater than zero.
9668 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
9669 interface. Functions reordered, comments changed. Not well
9670 tested, probably full of bugs.
9671 (init_file_handle) Removed initializers for obsolete fields, added
9673 (fh_close_handle) Much simpler, now mainly calls the class
9675 (fh_init_files) Renamed inline file internal filename.
9677 * file-type.c: Includes dfm.h.
9678 (read_from_file_type) Doesn't use dfm internal state anymore.
9680 * inpt-pgm.c, print.c: Include dfm.h.
9682 * recode.c: (internal_cmd_recode) Casts strlen() return value to
9683 int in comparison with other int.
9685 * som-high.c: (build_target) Fixed operator precedence problem in
9686 if statement (& versus ==).
9688 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
9690 * dfm.c: (read_record) Can now read fixed-length records; not
9692 (put_record) Can now write fixed-length records; not tested.
9694 * file-handle.h: FH_* defines changed to enums. New enum series
9696 (struct file_handle) New members recform, lrecl, mode.
9698 * file-handle.q: Parser changed.
9699 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
9700 /LRECL subcommands. These are compatible with Windows.
9701 (init_file_handle) Initializes recform, mode fields.
9703 * q2c.c: (get_line) When outputting `!' comment lines, now
9704 increments the output file line number so that `#line' directives
9706 (make_identifier) New function that converts an arbitrary string
9707 into a valid C identifier.
9708 (dump_vars) Calls make_identifier() in two places in order to
9709 suppress some errors for bad identifiers.
9710 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
9711 for NO. Allows numbers to be prefixed by underscores to make them
9712 acceptable C identifiers but still to be parsed as numbers by the
9715 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
9717 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
9719 * dfm.c: Comment fixes. (get_record) Gives error if file handle
9720 was opened for writing.
9721 (open_file_w) New function.
9722 (read_record) Uses strncasecmp if available. Improved error
9724 (put_record) New function.
9726 * file-handle.h: Moved function comments into dfm.c and
9727 file-handle.q. Comment fixes. Removed declarations of
9728 tilde_expand() and normalize_filename().
9729 (struct file_handle) Changed `open' from boolean to enumerated
9730 field to allow for three states--closed, open for reading, open
9731 for writing--all references changed.
9733 * file-handle.q: Includes filename.h.
9735 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
9737 (alloc_line) Makes allowance for line terminator characters in
9739 (print_trns_proc) Now handles OUTFILE, WRITE differences.
9740 (print_space_trns_proc) Handles OUTFILE differences.
9742 * recode.c, sample.c: Comment fixes.
9744 * var.h: (struct print_trns) Changed boolean field `eject' to
9745 bitmapped field `options'; all references changed. New enums
9746 PRT_* for use with this field.
9748 * exception.h, test-exception.c: Removed.
9750 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
9752 * ascii.c: (delineate) Turned off debug output.
9754 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
9757 * data-in.c: (parse_string_as_format) Sets the entire string value
9758 to spaces, not just the short string part of it. Is this correct
9761 * data-out.c: (convert_date) Fixed DATETIME format problems with
9762 decimal places, removed debug code.
9764 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
9765 middle of parsing BEGIN DATA that would cause the lexer to read
9766 from a wild pointer `prog'; now calls new function
9767 preprocess_line() in lexer.c.
9769 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
9771 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
9772 Now call induce_segfault() to induce the segfault.
9773 (induce_segfault) New function.
9775 * expr-opt.c: Comment fix.
9776 (parse_sysvar) New function.
9777 (parse_primary) Added system variable support--calls
9779 (global var ops) Added OP_CASENUM operator.
9781 * expr.h: Comment fixes.
9782 (OP_* enum) added OP_CASENUM operator.
9783 (struct casenum_node) New struct.
9784 (union any_union_union) New member `cas' of type `casenum_node'.
9786 * glob.c: (global var last_vfm_invocation) New var.
9787 (init_glob) Initializes last_vfm_invocation.
9789 * lexer.c: (lookahead) Fixed reversed condition on if statement.
9791 * getline.c: (get_line) Split into get_line() and preprocess_line().
9792 (preprocess_line) New function.
9794 * var.h: Declares last_vfm_invocation.
9796 * vfm.c: (procedure) Sets last_vfm_invocation.
9798 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
9800 * command.c: (parse_cmd) Fixed bad assertion related to
9803 * data-in.c: (parse_month) Implemented to parse months according
9804 to full interpretation of standard.
9805 (to_roman) New function.
9806 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
9807 (parse_weekday) Bug fix (forgot to skip all the day name).
9809 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
9810 up parsing of multirecord data items. Also fixed user message.
9812 * data-out.c: Comment fix.
9813 (year2, year4, convert_date, convert_time, convert_WKDAY,
9814 convert_MONTH) New functions to support time & date output.
9815 (convert_format_to_string) Calls new time & date output routines.
9817 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
9819 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
9822 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
9824 * misc.c: (global var formats) Fixed declarations of DATETIME,
9827 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
9828 the output_char buffer.
9830 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
9831 memory bug. Fixed user messages.
9833 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
9835 * Removed #pragma argsused from lots of places.
9837 * data-in.c: Implemented zoned decimal and time-date formats.
9838 Untested. This is a huge chunk of code--maybe 1000 lines and 50
9841 * data-out.c: Implemented zoned decimal format.
9843 * expr.h: Moved yrmoda() declaration here from exprP.h.
9845 * misc.c: (global var formats) Minor fixes--added
9846 FCAT_SHIFT_DECIMAL to formats N and Z.
9847 (convert_fmt_ItoO) Added support for format Z.
9849 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
9851 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
9853 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
9854 som_check_workspace() that is activated between commands.
9856 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
9859 * list.q: (begin_row) Changed title expansion style from
9860 SOPT_X_VERT to SOPT_X_SHSP.
9862 * som-frnt.c: Now includes `somP.h'.
9863 (som_push_workspace, som_pop_workspace) New functions that, taken
9864 together, form a solution to the recursive table building problem
9865 mentioned yesterday. Surrounded every table output routine
9866 throughout the program with calls to these functions.
9867 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
9868 (som_create_table) Checks that there's an active workspace.
9869 (som_destroy_all_tables, som_crush) Removed.
9871 * som-high.c: (global var som_preserve_tables) Removed, all
9873 (som_submit_table) Checks that there's an active workspace.
9874 (dump_columnated_table) Doesn't columnate tables that would have
9875 just one row per column.
9876 (dump_crush_page, som_dump_crush_page) Removed debugging code.
9877 (som_dump_crush_page) Moved row number labels from left side of
9878 tables to right side.
9879 (som_get_table_size) Added support for SOPT_X_SHSP.
9881 * som.h: New cell expansion type SOPT_X_SHSP.
9883 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
9885 (global var curtab_arena) Moved from som-frnt.c.
9887 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
9889 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
9890 that causes bad location warnings to be suppressed.
9891 (delineate) Saves current font when calling draw_text(); fixed
9892 handling of NULLs when backing up. Also fixed line-wrapping bug.
9894 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
9895 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
9897 * common.c: Added code to cause assertion failure to dump core
9898 when run under Checker.
9900 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
9901 there are still bugs.
9903 * glob.c: (__eprintf) Removed.
9905 * list.q: Inserted som_preserve_tables kluge that prevents tables
9906 from being thrown away due to recursive table building through
9907 som_output_line being called from a transformation during the LIST
9908 procedure invocation. This is a general problem that must be
9909 solved in a better way since it applies to all procedures in
9911 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
9912 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
9914 * numeric.c: Fixed several errors in the form of msg() calls.
9916 * print.c: Updated for use of som.
9917 (dump_table) Reimplemented.
9918 (print_trns_proc) Calls som_eject_page() instead of eject_page().
9919 Calls som_output_text() instead of outs_line().
9921 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
9923 (som_output_text) Function moved from som-low.c. Interface
9926 * som-high.c: (som_preserve_tables) New global public variable
9928 (som_submit_table) Destroys the tables only if som_preserve_tables
9930 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
9931 one subrow per row. Now labels subrows if there's more than one
9933 (dump_crush_table) Added wishlist comment.
9934 (som_eject_page) New public function declared in som.h.
9936 * som-low.c: (som_dump_crush_page) Draws row labels if there's
9937 more than one subrow per row.
9938 (som_output_text) Moved to som-frnt.c.
9940 * som.h: (SOM_TOPT_PRESERVE) Removed.
9942 * title.c: (get_title) Changed interface.
9943 (cmd_title) Changed `title' to `outp_title'.
9944 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
9946 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
9948 * list.q: (flush_table) Conforms to new partial options in
9949 som_submission_form.
9951 * som-high.c: (paginate_horizontally) Changed form of subrow
9953 (build_target) Omits spacing before table if
9954 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
9955 (dump_crush_page) Changed interface. Only trims bottom rule if
9956 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
9957 (dump_crush_table) Handles partial tables.
9958 (output_row_label) New function.
9959 (som_dump_crush_page) Emits subrow number labels. Draws vertical
9960 rule on the right edge of narrow subrows.
9962 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
9963 constants to a series of SOM_TOPT_PARTIAL_* submission options.
9964 All references updated.
9966 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
9968 * misc.c: Comment fix.
9970 * som-high.c: (examine_table) Treats crushed tables separates for
9971 purpose of determining header size.
9972 (paginate_horizontally) Allots space for line numbers in crushed
9973 tables with lots of subrows per row. Calculates the `maximum page
9974 width', the width of the widest horizontal page.
9975 (build_target) Removed trim argument; all references changed.
9976 Stricter assertions. (dump_crush_page) New function.
9977 (dump_crush_table) Reimplemented.
9979 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
9980 (som_dump_crush_page) Reimplemented, interface changed.
9982 * somP.h: Many many new helper macros for use with crushed tables.
9983 (global var som) Removed `tv', `cum_y' members; all references
9984 removed. New members `mpw', `digit_space'.
9986 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
9988 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
9989 variable, changed to constant 1024.
9990 (arena_ca_strdup) Changed `sizeof(a_string)' to
9992 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
9993 `(c_string *)' to `(char *)'; this fixed some offset problems.
9995 * filename.c: (readlink_malloc) Changed initial allocation from
9997 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
10000 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
10001 &fm->owner in several places.
10003 * som-high.c: (output_table) Changed interface to rest of world.
10004 (examine_crush_table) Removed. Crushed tables are re-broken now,
10005 in preparation for rewrite.
10007 * som.h: Comment fix.
10009 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
10011 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
10012 itself in the cleanup stage.
10014 * descript.q: (display) At least temporarily, changed the table
10015 format to a crushed table.
10017 * list.q: (begin_row) At least temporarily, added horizontal lines
10020 * som-high.c: (examine_crush_table) Sets som.hh to the width of
10021 the horizontal "headers," that is, to the width of the far left
10022 and far right rules.
10023 (justify_pagination) Sets som.th to the width of the widest row
10024 in the crushed table. Fixed inner loop off-by-one error.
10026 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
10029 * somP.h: Comment fix.
10031 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
10033 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
10034 before closing it; also, opens the constructed filename `s'
10035 instead of f->filename.
10037 * postscript.c: Moved initialization of x->loaded, x->prop,
10038 x->fixed, x->current, also the add_encoding() calls, into
10040 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
10041 sets x->last_font to NULL; sets x->next_combo to zero.
10043 * som-high.c: (crushed_row_height) Moved definition farther up.
10044 (som_submit_table) Doesn't calculate line width, font size until
10045 after calling open_page(), to accomodate changes to PostScript
10047 (vert_headers) Removed; equivalent functionality moved to
10048 examine_table(), examine_crush_table().
10049 (justify_pagination) Replaced with different algorithm.
10050 (dump_crush_table) Bugfix that caused tables to fail to be clipped
10051 at the bottom of the page.
10053 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
10055 * command.c: Added cmd_list back into cmd_table.
10057 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
10058 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
10060 * list.q: (flush_table) Updated to new som_submission_form format.
10062 * som-frnt.c: Comment fix.
10064 * som-high.c: Changed `#endif' to `#undef EXTERN'.
10065 (output_table) Calls som_get_table_size() directly; handles
10067 (examine_crush_table) New function; calls vert_headers().
10068 (examine_table) Moved some code into new function, vert_headers().
10069 (justify_pagination) New function.
10070 (dump_plain_table) Removed `static' from `cy'.
10071 (dump_crush_table) New function.
10073 * som-low.c: (som_dump_crush_page) New function.
10075 * som.h: Comment fixes.
10076 (enum SOM_TOPT_CRUSH) New.
10077 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
10078 Temporarily set to zero to make do with LIST procedure.
10080 * somP.h: Re-ordering.
10082 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
10084 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
10086 * somP.h: New file for use by som-high.c, som-low.c.
10088 * q2c.c: Added definition for VME.
10089 (get_line) Now dumps `!' comment lines to the output file
10092 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
10093 set.q: Changed format of `!' comment lines.
10095 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
10097 * All source files: Added copyright notice.
10099 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
10100 longs in msg() calls.
10102 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
10104 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
10106 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
10108 * output.c: (outp_read_devices) Changed criteria for
10109 distinguishing different types of lines.
10111 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
10113 * cmdline.c: Changed syntax message.
10115 * filename.c: (good_getcwd) Bug fix (?).
10116 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
10118 (search_path) Appends DIR_SEPARATOR to directory name only if it
10119 does not already end with one.
10121 * glob.c: Checks STAT_PAGER envvar before PAGER.
10123 * output.c: Checks environment variables instead of just local
10126 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
10128 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
10129 when the pointer passed to the function was within the arena
10130 itself, so that it couldn't properly be set to NULL _after the
10133 * command.c: Re-enabled DISPLAY.
10135 * display.c: Rewritten to handle tables. Untested.
10137 * filename.c: (search_path) Fixed memory leak.
10139 * frequencies.q: (cmd_frequencies) Frees v_variables.
10140 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
10141 (cleanup_freq_tab) New function to garbage collect.
10142 (dump_full) Elegantized.
10144 * main.c: New comment.
10146 * output.h: New tag for tagged quotes: TAG_NEWLINE.
10148 * postscript.c: Comment fix.
10149 (release_fontmap, free_font_entry) New functions.
10150 (ps_init_driver) Sets free_font_entry() as the freefunc for
10151 hashtable `loaded'. Calls release_fontmap() when destroying a
10152 driver; also frees the output filename; also frees the
10153 ps_driver_ext block.
10154 (free_ps_encoding) Frees the filename as well as the encoding
10156 (output_encodings) Frees the line buffer and pops the msg-filename
10158 (read_fontmap) Frees the fontmap filename and the line buffer.
10159 (postopen, preclose) Misc. garbage collection fixes.
10160 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
10161 to NULL; this fixes some output problems.
10162 (text) Handles TAG_NEWLINE. Untested.
10164 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
10165 (som_set_string) Removed. All references changed to
10167 (som_set_text) Rewritten. New interface. More general.
10169 * som.h: Minor format changes.
10170 (struct som_value_cell) Removed; all references changed to
10172 (enums SOT_*) Changed.
10174 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
10176 * command.c: Re-enabled SPLIT FILE.
10178 * postscript.c: Comment fix.
10180 * som.h: Added `SOT_NONE'.
10182 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
10184 * vfm.c: (dump_splits) Reimplemented.
10186 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
10188 * Compiled the project under gcc 2.7.2, which gave some new
10189 warnings. This led to many additions of casts from unsigned to
10190 int sprinkled throughout the code.
10192 * arena.c: Many uses of `unsigned' changed to `size_t'.
10194 * command.c: Added END FILE, END REPEAT to command table.
10195 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
10196 (find_command, FILE_TYPE_okay) Not commented out anymore.
10197 (parse_cmd) Calls FILE_TYPE_okay again.
10198 (output_line) Added calls to som_output_text() to put the line
10199 in the output files.
10201 * common.c: (macro VME) Format changes.
10202 (xstrdup) Asserts that its argument is not NULL.
10204 * data-list.c: Implemented dump_fixed_table().
10206 * inpt-pgm.c: Formatting changes. Comment changes.
10207 (end_case_proc) Renamed end_case_trns_proc.
10208 (cmd_end_file, end_file_trns_proc) New functions.
10210 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
10212 * misc.h: (local_strdup) New macro corresponding to strdup() but
10213 allocating its data through local_alloc() if possible--that is, if
10216 * postscript.c: Comment changes.
10217 (quote_ps_name, quote_ps_string, output_encodings) New functions.
10218 (output_line, add_string) New macros supporting
10219 output_encodings().
10220 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
10221 substitution vars. Calls output_encodings() when a line
10222 consisting of `!encodings' is encountered.
10223 (preclose) Some code moved into quote_ps_string().
10224 (dump_line) Changed into macro supporting dump_fancy_line().
10225 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
10226 command when appropriate.
10227 (write_text) Fixed `literal_char' array (I think it's fixed, at
10229 (text) Fixed bug when width was zero. Now exits immediately on
10230 zero height_left. Now, when executing `goto restart;', checks
10231 that cp<end, so that we don't read beyond end-of-string. Also,
10232 outputs the correct code to the output file by outputting the code
10233 from the metric instead of the internal metric index.
10235 * repeat.c: (cmd_end_repeat) New function.
10237 * som.c: (var som) `headers' renamed `options' and semantics
10238 changed. All references changed.
10239 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
10240 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
10242 (som_text_table) Removed.
10243 (som_output_text) New function.
10245 * som.h: (struct som_submission_form) Removed `header', `reuse',
10246 replaced with bitmapped field `options'.
10247 (SOM_TOPT_*) New enum set for som_submission_form.options.
10248 (SOT_*) New enum set for som_output_text().
10250 * temporary.c: (copy_variable) When copying the var label, only
10251 calls xstrdup() if it's non-NULL.
10253 * var.h: (enum type `vartype') Removed; all references changed to
10256 * vars-atr.c: (init_variable) Changed local var `nbytes' from
10259 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
10261 * font.h: Comment changes.
10263 * groff-font.c: (groff_read_font) Initializes `name' field to
10264 NULL. Handles `encoding' field.
10266 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
10268 * postscript.c: (struct font_entry) Removed `position' field.
10269 (struct ps_font_combo) New struct.
10270 (struct ps_driver_ext) Removed field `next_position'. New fields
10271 `combos', `next_combo'. `last_font' field changed from
10272 `font_entry *' to `ps_font_combo *'.
10273 (ps_init_driver) Reformatted; handles new fields. When
10274 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
10276 (get_encoding, find_encoding_file) New functions.
10277 (add_encoding) Some code moved out into find_encoding_file().
10278 (postopen) Changed value for ${title}.
10279 (preclose) Sets `loaded' field to NULL after destroying the hash
10281 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
10283 (ps_text_set_font_by_position) Figures out the current family if
10285 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
10286 (switch_font) Implemented.
10287 (write_text) Calls switch_font() more often. Format changes.
10288 #undefs its macros after they're no longer useful.
10289 (text) Changed `continue' at one point to a jump to the top of the
10290 loop because we don't want `separate' reset to 0 at that point.
10291 (load_font) No longer sets `position' in the font_entry created.
10293 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
10295 * font.h: (struct font_desc) New member `encoding', which is not
10296 properly handled yet.
10298 * glob.c: (init_glob) Some new i18n code, which is probably
10301 * output.c: (outp_read_devices, outp_get_paper_size) Changed
10302 `size' local from `int' to `size_t'.
10304 * postscript.c: New driver configuration parameter `auto-encode'.
10305 New enums OPO_AUTO_ENCODE, ODA_COUNT.
10306 (struct font_entry) New member `position'.
10307 (struct ps_driver_ext) Reordered. New hash table member
10308 `encodings'; new members `next_position', `next_encoding',
10309 `last_font'. Members `current', `prop', `fixed' changed from type
10310 `font_desc *' to `font_entry *'; all references changed.
10311 (struct ps_encoding) New struct.
10312 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
10313 free_ps_encoding, add_encoding) New functions.
10314 (ps_init_driver) Added OPO_AUTO_ENCODE to default
10315 x->output_options. Initializes new members of ps_driver_ext.
10316 Changed default value for prologue_fn, encoding_fn. Calls
10317 read_ps_encodings after loading default fonts.
10318 (option_tab[], ps_option) Handle new configuration parameter.
10319 (switch_font) New function.
10320 (struct output_char) `font' member changed from `font_desc *' to
10321 `font_entry *'. New member `separate'.
10322 (read_fontmap) Changed `size' from `int' to `size_t'.
10323 (output_line, put_number) New macros for write_text().
10324 (write_text) Optimizes text output by consolidating multiple
10325 calls to PostScript `show' operator.
10326 (text) Keeps track of when text arguments can't be consolidated by
10327 write_text(), and marks those spots in the output stream.
10328 (load_font) Sets `position' of the allocated font_entry to -1, cuz
10329 the font hasn't been switched to by switch_font(), which is where
10330 the position is important--the PostScript is what cares about the
10333 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
10335 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
10336 call a NULL free_func.
10337 (hsh_rehash) Elegantized.
10338 (hsh_probe) Fix bug that manifested when the table was expanded
10339 and thus had to change location in memory. Good thing
10340 too--otherwise could have been much more subtle.
10341 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
10342 (hsh_foreach) New function for hash table iteration.
10344 * hash.h: (struct hsh_iterator) New.
10346 * lexer.c: (parse_tagged_quote) Font and family name strings in
10347 tags are now null-terminated.
10349 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
10351 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
10352 documented. (Never before tested?)
10354 * output.h: Comment changes.
10356 * postscript.c: New driver options `optimize-text-size',
10357 `optimize-line-size', `max-fonts-simult'. New enum set for
10358 specing cached line types. Comment fixes.
10359 (struct line_form) New struct.
10360 (struct ps_driver_struct) New members `text_opt', `line_opt',
10361 `max_fonts', `lines'.
10362 (ps_init_driver) Initializes new members of ps_driver_struct.
10363 (user option type enum set) New member `nonneg_int_arg'.
10364 (static var option_tab[]) Supports new options.
10365 (ps_option) Handles new options.
10366 (find_ps_file) Made static. No longer calls hsh_dump().
10367 (ps_get_var) Made static.
10368 (preclose) Dumps out proper DSC trailer.
10369 (ps_open_page) Elegantized.
10370 (ps_close_page) Calls dump_lines() if appropriate.
10371 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
10372 wrappers around line().
10373 (int_2_compare, compare_line, dump_line, dump_fancy_line,
10374 dump_lines, hash_line, free_line, line) New functions for support
10376 (write_text, text) Made static.
10377 (text) Added to font support, not finished.
10379 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
10381 * font.h: (struct font_desc) New members ascent, descent.
10383 * groff-font.c: (groff_read_font) Calculates font ascent and
10384 descent from the ascent and descent of the `d' and `p' characters,
10385 respectively, as per a suggestion on comp.fonts.
10387 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
10388 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
10390 (write_text) Handles text right-justification and centering (not
10391 full justification). Still very inefficient. (One output line
10393 (struct output_char) Added fields for font and font size.
10394 (text) Many bugfixes.
10396 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
10398 * cmdline.c: (usage) Calls outp_list_classes().
10400 * font.h: Comment fix.
10402 * groff-font.c: New exported global var `space_index'.
10403 (groff_init) New function to initialize `space_index'.
10404 (hash_kern) Casts result to unsigned.
10405 (font_name_to_index) Renamed font_char_name_to_index. All
10406 references changed. Also, now returns the value of `space_index'
10407 when passed an ASCII space character as an argument. Fixed
10409 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
10410 Handles passed NULL pointers properly.
10412 * lexer.c: (parse_tagged_quote) Comment fix. Better range
10415 * output.c: (outp_list_drivers) Removed. Removed all references.
10417 * output.h: Comment fixes.
10419 * postscript.c: (ps_open_global) Calls groff_init().
10420 (output_char) New structure.
10421 (write_text) New function.
10422 (text) No longer stubbed out! Now the output is correct--with a
10423 few exceptions, one of them being that the page has to be held
10424 upside down into a mirror.
10426 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
10428 * font.h: Comment fix.
10430 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
10431 All callers changed.
10432 (number_to_index) Renamed font_number_to_index, made extern. All
10434 (font_get_kern_adjust, font_get_char_metrics) New functions.
10436 * output.h: New constant OUTP_T_INTERNAL_DRAW.
10438 * postscript.c: Changed default line width back to 1/2 point.
10439 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
10440 in the center of the space allotted for them, not just a fixed
10441 offset from the edge of the space; this fixes some bugs.
10442 (ps_line_intersection) Now supports all command line styles.
10443 (ps_text_get_size) Bug fix in computation of em width.
10444 (text) New function, the meat behind ps_text_metrics and
10445 ps_text_draw. Not complete.
10446 (ps_text_metrics, ps_text_draw) Removed the stub taken from
10447 ascii.c; call text().
10449 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
10451 * arena.c: (arena_free) Assert that the argument is non-NULL.
10453 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
10454 only if old_kern is non-NULL.
10456 * postscript.c: (ps_init_driver) Changed default line width to 1
10458 (postopen) New prologue variables.
10459 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
10460 more of the common line styles properly, but not all.
10461 (ps_text_metrics) Fixed problem with this stubbed out version that
10462 kept it from taking font sizes into account.
10464 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
10466 * arena.c: (arena_malloc) Bug fix.
10467 (arena_dump) [GLOBAL_DEBUGGING] New function.
10469 * ascii.c: Comment fix.
10470 (count_fancy_chars, delineate) Now static functions.
10472 * filename.c: (interp_vars) Bug fixes.
10474 * font.h: Comment fixes.
10476 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
10477 beginning in case we have an error message to display before
10478 initializing the display.
10480 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
10482 (groff_read_font) Bug fixes.
10483 (name_to_index) Increments hash.used. Sets `name' field of hash
10485 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
10487 * hash.c: Return type changed.
10489 * postscript.c: Continued development. Now marks lines on the
10490 paper, but very buggy.
10492 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
10494 * Changed comments in many source files from `/* xxx /* yyy */' to
10495 `/* xxx */ /* yyy */' for cleanliness.
10497 * arena.c: (arena_sd_strdup) New function.
10499 * ascii.c: (struct ascii_driver_ext) New member `file'.
10500 (ascii_init_driver) Fills out member `file' for initing; uses
10501 close_file_ext for closing drivers.
10502 (ascii_option) Changed %.*s back to %s because the a_string's are
10503 always null-terminated.
10504 (postopen, preclose) New functions.
10505 (ascii_open_page) Uses new style of open_file_ext.
10506 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
10507 instead of this->output.
10508 (__assert_fail) Removed.
10510 * cmdline.c: Changed syntax_message[].
10512 * error.c: #include's <readline/history.h> only if the history
10513 library is available, not if just the readline library is
10516 * filename.c: (expand_line) Removed alloca() support.
10517 (interp_vars) No longer tilde-expands argument. Limit on output
10519 (tilde_expand) Now treats argument as path rather than filename.
10520 [!unix] Now is a no-op function.
10521 (search_path) Better verbose message formatting.
10522 (open_file, close_file) Comment fixes.
10523 (close_file) [!unix] Doesn't bother with pipes.
10524 (open_file_ext) Completely rewritten, interface revamped.
10525 (close_file_ext) New function.
10527 * font.h: Comment changes.
10529 * frequencies.q: Removed AIX alloca support since it doesn't use
10532 * hash.c: Comment changes & additions.
10533 (hsh_create) Initializes entire table instead of first M entries.
10534 (hsh_probe) Stupid bug fixed. Now it works.
10535 (hsh_dump) [GLOBAL_DEBUGGING] New function.
10537 * main.c: (parse) Detects EOF properly in token-eating loop.
10538 Should the STOP token have its value changed to 0?
10540 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
10541 (blp_getline) Now it's a macro.
10543 * output.h: (struct outp_driver) Removed members output, filename.
10545 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
10546 drivers in driver table.
10547 (outp_read_devices) Frees buf. Warns if there are no active
10549 (outp_configure_clear) Sets outp_configure_vec to NULL after
10550 deleting its elements.
10551 (configure_driver, destroy_driver) Removed references to output,
10552 filename members of outp_driver.
10553 (outp_evaluate_dimension, internal_get_paper_size,
10554 outp_get_paper_size) New functions.
10556 * postscript.c: Continued development. Now links but doesn't make
10557 any marks on the page. Lotsa bugs I suppose.
10559 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
10561 * str.h: Comment changes.
10563 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
10565 * Removed dependencies on non-nested comments in several files.
10566 Also removed references to (unix || __unix__) in #if's since
10567 prefh.orig makes those two equivalent.
10569 * ascii.c: (ascii_open_global) Creates ascii_arena.
10570 (ascii_close_global) Destroys ascii_arena.
10571 (ascii_init_driver) Doesn't create ascii_arena.
10572 (ascii_copy_driver) Removed.
10573 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
10574 (outp_class ascii_class) Removed ascii_copy_driver reference.
10576 * frequencies.q: Now can display all statistics except median.
10577 Still not finished.
10579 * output.c: Handles outp_class.ref_count so output class
10580 destructors are called properly.
10581 (add_class) Sets ref_count to 0.
10582 (configure_driver) Initializes class if ref_count++ is 0.
10583 (destroy_driver) Destructs class if --ref_count is 0. Frees the
10584 class output file name.
10586 * output.h: (struct outp_class) Removed copy_driver, inited.
10589 * postscript.c: Completely replaced but not finished.
10591 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
10593 * approx.h: #includes <float.h>.
10595 * arena.h, arena.c: Many functions changed to take an arena **
10596 instead of an arena *, for consistency. All callers changed.
10597 (arena_alloc) Now creates a new arena if passed *A that is NULL.
10598 (arena_destroy) Sets *A to NULL.
10600 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
10601 assertion that `width' be positive.
10603 * command.c: Removed #if's from cmd_table.
10604 (walk_cmdtable_func) [0] New function (debug code).
10605 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
10606 (parse_cmd) Doesn't return failure for unimplemented commands.
10608 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
10609 (SYSCODE) New constant macro.
10611 * descript.q: Checks for positive n_variables before performing
10614 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
10615 avl_find instead of &fp as arg 2.
10617 * frequencies.g, frequencies.q: Continued updating; now compiles &
10618 works again, but not complete.
10620 * main.c: Changes to user messages.
10622 * misc.c: (reverse) [0] New function.
10624 * settings.h: Comment removed. #includes "common.h".
10626 * som.c: (som_set_null) New function.
10627 (som_set_value, som_set_string, som_set_text) More detailing
10629 (som_set_float) Implemented function.
10630 (dump_columnated_table) Bug fix regarding page breaks.
10631 (draw_cell) Bug fix regarding text that spilled out of a cell.
10632 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
10634 (get_cell_size) Support SCON_EMPTY cells.
10635 (get_table_size) When calculating rules' widths and heights, mask
10636 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
10638 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
10640 (struct som_submission_form) New member `header'; all users
10643 * val-labs.c: (get_label) User messages changed.
10645 * var.h: Changed FREQUENCIES structures.
10647 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
10650 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
10652 * approx.h: Definition of EPSILON now depends on system's
10653 DBL_EPSILON. Removed GNU C specific code.
10654 (cmpapx) Renamed approx_compare.
10656 * frequencies.g, frequencies.q: Continued updating; still doesn't
10659 * groff-font.c: (name_to_index) Fix bug that kept it from
10662 * hash.c, hash.h: Completed work.
10664 * var.h: Changes to freq_tab, frequencies_proc.
10666 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
10669 * hash.c, hash.h: New files. Not completed.
10670 * Makefile.am: Added hash.c to source file list.
10671 * font.h: (struct font_desc) New member kern_size_p.
10672 * groff-font.c: Uses hash.h.
10673 (hashpjw) Moved to hash.c.
10674 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
10676 (static var hash) New member size_p.
10677 * var.h: Includes hash.h.
10678 (struct freq_tab) Changed AVL_TREE to hash_tab.
10680 * vars-prs.c: Comment, formatting fixes.
10682 * frequencies.g, frequencies.q: Continued updating. Not yet
10685 * formats.c: Bug fix.
10687 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
10689 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
10690 * descript.g: Comment fixes.
10691 * descript.q: Comment fixes. Moved some declarations into var.h.
10692 Made dsc_info a static table. Updated FIXMEs.
10693 (internal_cmd_descriptives) Beautified.
10695 * frequencies.q: Started updating into working order.
10696 * frequencies.g: New file analogous to descript.g.
10697 * var.h: Comment fixes. Added structures for FREQUENCIES.
10699 * som.c: Removed vestiges of crushing and partial table support.
10701 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
10703 * Many more changes to som.c especially, but these will not be
10704 documented as I have resolved to remove them. This patchlevel is
10705 being released solely so that I can fall back to it if I decide
10706 that removing the changes is not a good idea.
10708 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
10710 * som.c: (global var som) New member `cum_y'.
10711 (build_target) Properly handles titles for partial tables.
10712 (dump_partial_beg, dump_partial_mid, dump_partial_end)
10713 Merged into single new function dump_partial(). Fixed problem
10714 with titles on partial tables.
10715 (dump_table) Calls dump_partial() for all parts of partial tables.
10716 (dump_page) Criteria for drawing title changed.
10718 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
10720 * command.c: (cmd_table) Added LIST, WEIGHT.
10722 * command.c: (cmd_remark) No longer frees `s' since it's not
10723 dynamically allocated.
10725 * data-out.c: (convert_f) Now correctly handles the case where
10726 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
10727 number of decimals.
10728 (som_destroy_all_tables) Removed argument. All callers changed.
10729 (som_vline, som_hline) Argument validity checking corrected.
10730 (som_set_value) Implemented half-heartedly.
10731 (replicate_table) Copies tables piece-by-piece when using Checker.
10733 * som.h: New line style SLIN_1THIN, currently equivalent to
10734 SLIN_0. New enum set SOM_SUB_*.
10735 (struct som_submission_form) Removed `seq_no'. Added `type'.
10737 * list.q: Newly working file; uses partial tables.
10739 * som.c: (som_reduce_table) Renamed som_set_table_height().
10740 (som_crush) Removed argument `group'.
10741 (global var som) Removed `nt', `seq_no'. Added `type'.
10742 (som_submit_table) Arguments changed.
10743 (output_table) Removed partial table code.
10744 (build_target) New arg; partial table support added. All callers
10746 (dump_plain_table) Removed partial table code.
10747 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
10748 (dump_table) Supports partial tables.
10749 (dump_page) New argument to allow not drawing top and/or bottom
10750 headers. All callers changed. Supports partial tables.
10752 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
10754 * data-out.c: Changed `#include <approx.h>' to `#include
10756 (convert_F) Comment fix. Now won't print `-.000', etc.
10758 * descript.q: Now Z-scores work, although there appears to
10759 be a bug (which might actually be in data-out.c:convert_F()).
10760 (descriptives_trns_proc, descriptives_trns_free) New functions.
10761 (run_z_pass) Implemented.
10763 * var.h: Comment fixes.
10764 (dsc_z_score, descriptives_trns) New structs.
10765 (descriptives_trns) Added to any_trns as `dsc'.
10767 * error.c, error.h: New error class, IS (Installation Script
10768 error), used in those instances where the error is in the
10769 installation, but there is a script file or installation file that
10770 can be usefully referred to.
10772 * output.c: Change many IE classes to IS classes.
10774 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
10775 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
10776 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
10777 include the corresponding header?
10779 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
10780 Don't bail out if termcap can't be read.
10782 * som.c: (som_destroy_table) Removed.
10783 (som_reduce_table, som_destroy_all_tables) New functions.
10784 (som_crush) New function, not implemented.
10786 * som.h: New table option STAB_CRUSH. Comment fix. New struct
10787 som_submission_form. Function prototypes revised.
10789 Outputting huge tables (1000s of rows) a few rows at a time
10790 is supported, though untested. May even break everything.
10791 Actually, the code doesn't even compile right now.
10792 * som.c: (struct som) New fields htv, nt, seq_no.
10793 (som_submit_table) Multiple arguments changed to a single
10794 pointer to struct submission_form. Only increments subtable_num
10795 if seq_no is zero. Only destroys table if it's not going to
10797 (replicate_table) New function.
10798 (output_table) Comment fix.
10799 (examine_table) Changed inline code to code calling
10800 replicate_table(). Calculates htv. Supports partial tables.
10801 (draw_title) Removed comment.
10802 (build_target) Only allows for title on first part of partial
10804 (dump_plain_table) Only resets table chunk number on first part
10805 of partial tables; FIXME: doesn't work quite right. Supports
10807 (dump_page) Titles only on first part of partial tables.
10809 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
10811 * Thanks to an unreliable IDE hard drive, I have spent the last
10812 day reconstructing my Debian GNU/Linux installation and redoing
10813 the previous day's changes--somehow I managed to save every file
10814 except for output.c and output.h. So the following changes could
10815 really be considered independent of the output.c, output.h changes
10818 * output.h, output.c: Moved the outp_configure_vec global var,
10819 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
10820 outp_configure_vec is now static.
10822 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
10824 * The entire philosophy behind configuration of the output drivers
10825 changed. Now there is a termcap-type configuration where drivers
10826 to be read are determined beforehand, rather than parsing the
10827 entire output init file and storing it in memory & deciding what
10828 to actually use later. Faster & more memory-efficient at the same
10831 * output.c: Comment fix. Removed outp_init_drivers global var.
10832 Removed all references to synonyms. New structure outp_defn. New
10833 global vars outp_macros, outp_configure_vec.
10834 (search_name, delete_name, add_name, check_configure_vec,
10835 expand_name, find_defn_value) New static functions.
10836 (outp_configure_clear, outp_configure_add, outp_configure_macro,
10837 outp_read_devices) New extern functions.
10838 (outp_init) Much functionality moved into outp_read_devices.
10839 (outp_read_devices) Format of output init file changed; name of
10840 file is `devices' rather than `output' to avoid Makefile
10842 (outp_clear) Renamed outp_done.
10843 (outp_list_classes) Bug fix, cleaned up.
10844 (outp_list_drivers) Not implemented anymore.
10845 (outp_configure_driver) Now a static function; simplified; now
10846 interpolates macros; supports new structure.
10847 (outp_enable_driver, match_synonym) Removed; all references
10849 (find_driver) First argument removed.
10851 * output.h: Global var outp_init_drivers removed; new structure
10852 outp_names; new enum set OUTP_S_*; new global var
10853 outp_configure_vec; function prototypes for output.c exports
10856 * main.c: (main) Calls outp_read_devices() after parsing the
10859 * cmdline.c: (parse_command_line) New option -v --verbose;
10860 --version changed to -V. --device option changed syntax to just
10861 take a single device name. Accepts key=value declaration of
10862 output init file macros. Syntax message updated.
10864 * filename.c: (expand_line) New function.
10865 (interp_environ_vars) Renamed interp_vars; no longer uses
10867 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
10868 overridden by real environment vars.
10869 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
10870 * filename.h: interp_environ_vars() renamed interp_vars().
10872 * error.c, error.h: Added extern variable `verbosity', message
10875 * error.c: (vmsg) Support message class MM.
10876 (verbose_msg) New function.
10878 * descript.q: (generate_z_varname) Bug fix in generation of
10880 (dump_z_table) Bug fix in column headers.
10882 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
10883 page from 29 to 15. Don't set a default for ops[OPS_INIT,
10884 OPS_DONE]. Writes the uninit string when the driver is closed.
10885 (ascii_open_page) Write the init string before the first page.
10886 (output_shorts) Form of main loop changed from `while' to `for'.
10887 Bug fix with overstrikes: the character is printed *after* the
10888 backspace. Eliminated a lot of `& 0xff' modifiers.
10889 (advance_to_left_margin) New function.
10890 (return_carriage, output_lines) Handle left margin.
10892 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
10894 * ascii.c: New option `carriage-return-style'.
10896 * ascii.c: (count_fancy_chars) New function.
10897 (delineate, text_metrics) Use new function; bug fixes regarding
10899 (text_draw) Bug fix with rich text.
10900 (output_string, output_shorts) Reordered.
10901 (output_shorts) Now handles boxchars and some overstrike font
10903 (output_char, return_carriage) New functions.
10904 (output_lines) Now handles overstriking and font changes properly;
10905 some code moved to output_shorts.
10907 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
10910 * ascii.c: New member `debug' in ascii_driver_ext.
10911 (ascii_init_driver, delineate) Uses new member.
10913 Now you can set a vertical height on writing text.
10914 * ascii.c: (delineate) Keeps track of vertical position.
10915 (text_draw) No longer considers fully justified text an internal
10918 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
10920 Tables' titles are drawn; they can have variable height.
10921 * som.c: `som' struct has new member, title_height.
10922 (draw_title) New argument. Moved within file. All caller
10924 (build_target) New argument, amount of space needed for first row.
10925 Calculates height of title, takes that into account. All callers
10927 (dump_plain_table, dump_columnated_table) Took calculation of y1,
10929 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
10931 (dump_columnated_table) Organized for readability.
10932 (dump_page) Makes use of som.title_height.
10934 * som.c: Many comment bug fixes.
10936 * descript.q: (try_name, generate_z_name) Bug fix regarding
10937 generation of Z-score variable names.
10938 * var.h: Removed num from descriptives_proc; all referents removed.
10940 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
10942 * ascii.c: (ascii_line_horz, ascii_line_vert,
10943 ascii_line_intersection) Added debugging code.
10945 Added a descriptive line above each table to describe it.
10946 * command.c: (parse_cmd) Calls som_new_series.
10948 * som.c: New static vars table_num, subtable_num. New `som'
10950 (dump_page) New arguments.
10951 (som_submit_table) Handle new variables.
10953 * som.c, som.h: (som_submit_table) New arguments. All callers
10955 (som_new_series) New function.
10956 (build_target) Makes room for extra line.
10957 (draw_title) New function.
10958 (dump_page) Calls draw_title. Bug fix: doesn't always set
10961 Columnation of tables support.
10962 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
10964 * som.c: Deleted references to fr, lr, ri.
10965 (som_columnate) Bux fix: sets group member of table.
10966 (som_add_options) Function removed.
10967 (dump_table) Split into three functions; extensively reworked.
10969 * descript.q: (dump_z_table) Better output table formatting; added
10970 title support to correspond to som.h changes.
10971 (display) Title support.
10973 * output.h: Added OUTP_T_NONE.
10975 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
10977 * descript.q: Improved handling of Z scores; still not perfect.
10979 * output.h, ascii.c: Added hook for getting em width of current
10982 * som.c: Uses new em-width hook. Added debugging code to
10984 (som_columnate) New argument.
10985 (som_add_options) Removed.
10987 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
10989 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
10990 rules as a property of the table instead of as a property of the
10993 * ascii.c: Added `header' to table of options.
10995 * descript.q: Added even shorter statistic names; modified to work
10996 with new som interface.
10998 * misc.c (blp_getdelim): Bug fix.
11000 * version.c: includes 'conf.h'.
11002 ----------------------------------------------------------------------
11005 version-control: never
projects / pspp-builds.git / blob