1 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
3 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
4 main.c. Removed the handler for SIGQUIT.
6 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
8 * casefile.c: Added a signal handler to delete temp files on SIGINT and SIGQUIT
10 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
12 * command.def Added a lot more unimplemented commands.
14 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
16 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
18 * sort.c: (compare_initial_runs) Needed additional level of
20 (merge_once) Fix plenty of stupid mistakes.
22 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
24 * casefile.c: (casefile_sleep) Need to flush_buffer() after
25 calling casefile_to_disk() or we will lose the last block in the
26 file if the casefile started out as disk-based.
27 (casefile_get_reader) Initialize reader->destructive to 0.
28 (cmd_debug_casefile) Add new test pattern.
29 (test_casefile) Define new test pattern to make sure
30 casefile_sleep() works properly.
32 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
34 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
35 plot-hist.c plot-chart.c (Added) Reorganised these files in an
36 attempt to seperate the creation and processing of charts from their
39 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
42 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
44 * main.c Added a signal handler for SIGFPE
46 * sort.c Somewhat more robust fix to the previous entry.
48 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
50 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
51 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
52 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
55 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
57 * case.h Fixed bug # 11307
59 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
61 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
64 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
66 * pfm-read.c: (read_variables) Remove direct manipulation of
67 v->aux, which is no longer needed. Fixes Bug #11483.
69 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
71 * data-list.c Fixed a bug in parsing delimiters.
73 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
76 * percentiles.c Properly handled calculation of Tukey hinges where
77 the number of data is small.
79 * oneway.q Used the generic value_to_string function for independent
80 variable instead of trying to do it ourselves.
82 * box-whisker.c Fixed a buglet which caused a crash if the number of
86 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
88 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
90 * percentiles.c Fixed some bugs when calculating percentiles when
91 there's a small number of cases.
93 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
95 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
97 * examine.q factor_stats.[ch] Added calculation of percentiles
99 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
101 * t-test.q Fixed bug #11227 Made t-test work when the independent
104 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
106 * factor_stats.c Fixed calculation of trimmed mean under various
109 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
111 * histogram.c chart.[ch] factor_stats.c frequencies.q
113 Added code to calculate sensible histogram ranges and limits.
115 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
117 * chart.h Updated to reflect many API changes.
119 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
120 cartesian.c and into chart.c
122 * factorstats.[ch] Added the histogram calculations
124 * casefile.c Removed an unused variable.
126 * frequencies.q examine.q histogram.c Reworked the API for
129 * piechart.c Revised the API for piecharts.
131 * var.h Moved the definitions of freq_tab and freq out of var.h
132 and into frequencies.q where they belong.
134 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
136 * flip.c: (flip_file) Check for off_t separately from fseeko(),
139 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
141 * flip.c: (flip_file) If fseeko() is not available, use long int
142 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
143 reporting the problem.
145 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
147 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
150 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
152 * var-labs.c (var_to_string) Now returns null if the variable is null
154 * value-labels.c (value_to_string) Made it return null if either the
155 value or the variable is null.
157 * hash.c (hsh_clear) Fixed a buglet.
159 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
160 with the wrong model.
162 * casefile.[ch] Added a function to return the casereader.case_idx
165 * examine.q Implemented the extreme values results.
167 John Darrington <john@darrington.wattle.id.au>
169 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
170 output.[ch] getline.c
172 Plugged some memory leaks
174 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
176 Adopt GSL random number generators, paving the way for providing
177 the complete suite of random number generators on expressions.
179 * Makefile.am: Remove random.c, random.h.
185 * algorithm.c: (algo_default_random) Use GSL functions.
187 * casefile.c: (test_casefile) Use GSL RNG functions.
189 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
192 * sample.c: (cmd_sample) Use GSL RNG functions.
193 (sample_trns_proc) Ditto.
195 * set.q: (static var set_seed) Removed.
196 (static var seed_flag) Removed.
197 (static var rng) New variable.
198 (aux_stc_custom_seed) No seed value anymore, don't print anything.
199 (stc_custom_seed) Use new seed functions.
200 (seed_is_set) Removed.
201 (get_rng) New function that composes the entire external
203 (set_rng) New function.
204 (random_seed) New function.
206 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
208 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
209 John Darrington <john@darrington.wattle.id.au> for reporting this
212 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
214 * permissions.c command.def Added the PERMISSIONS command
216 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
218 * q2c.c: (dump_header) Don't try to emit #includes at very top of
219 output file because that will precede #include <config.h>, which
221 (main) Add needed headers to /* (header) */ code.
223 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
225 Instead of making system or portable file readers responsible for
226 dropping and reordering variables, make them read full cases and
227 let the caller take care of any changes.
229 * get.c: New "case map" structure to handle this. Use for GET,
230 IMPORT, MATCH FILES. Essentially rewrite the whole file.
232 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
233 changed appropriately.
235 * sfm-read.c: (sfm_read_case) Ditto.
237 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
239 Decided that case_serialize() and case_unserialize() were too
240 abstract. Also we need a couple more functions to avoid excessive
241 copying for data in/out fast paths.
243 * case.c: (case_serial_size) Removed.
244 (case_serialize) Rename case_to_values() and make its argument
245 explicitly an array of union values.
246 (case_unserialize) Rename case_from_values() and make its argument
247 explicitly an array of union values.
248 (case_data_all) New function.
249 (case_data_all_rw) New function.
251 * casefile.c: (struct casefile) Change buffer from array of
252 unsigned char to array of union value for better accuracy.
253 Redefine buffer_used and buffer_size in terms of values, not
254 bytes. Remove case_size because it is now redundant with
255 value_cnt. Fix up all references to these members.
257 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
259 * barchart.c: (struct subcat) Make `label' member const to silence
260 GCC warning with -Wwrite-strings.
262 * cartesian.c: (struct dataset) Ditto.
264 * case.c: Don't re-define NDEBUG if already defined.
265 Add lots of comments.
267 * str.c: Fix includes.
269 * crosstabs.q: Fix includes.
271 * examine.q: Fix includes. Fix GCC warning about unused
274 * frequencies.q: (stat macro) Removed and replaced where used by
277 * list.q: Fix includes.
279 * oneway.q: Fix includes.
281 * piechart.c: Fix includes. Only define M_PI if not already
284 * sfm-read.c: (bswap) New function.
285 (bswap_int32) Write in terms of bswap.
288 * str.c: (ds_data) Add external definition here, needed because
289 str.h has only an `extern inline' version.
291 * value-labels.c: Fix includes.
293 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
295 Instead of providing a system or portable file writer with a raw
296 case in the format needed for output, provide it with a regular
297 case. The writer takes care of any needed translation.
299 * aggregate.c: Adopt new scheme for AGGREGATE.
300 (struct agr_proc) sfm_agr_case member removed.
301 (write_case_to_sfm) Removed because the new interface is easier to
304 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
306 * pfm-write.c: Implement new scheme.
308 * sfm-write.c: Ditto.
310 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
312 Instead of treating `struct file_handle' as a class to subclass
313 into data files, system files, and portable files, instead use it
314 as a helper that coordinates access. Now it is opaque, too.
316 This means that most references to a struct file_handle are now
317 changed into references to one of struct dfm_reader, struct
318 dfm_writer, struct sfm_reader, struct sfm_writer, struct
319 pfm_reader, or struct pfm_writer, according to what's being read
322 Most related changes are only worth summarizing briefly.
324 * dictionary.c: (dict_clear) Destroy aux data in deleted
326 (dict_clear_aux) New function.
327 (dict_create_var) Initialize aux, aux_dtor.
328 (dict_delete_var) Destroy aux data in deleted variable.
330 * file-handle.h: (struct fh_ext_class) Removed.
331 (struct file_handle) Removed.
332 (fh_init_files) Removed.
334 * file-handle.q: Changed references to a handle's `private' member
335 to direct references.
336 (struct private_file_handle) Renamed file_handle.
337 Add next, open_cnt, type, open_mode, aux members.
338 (struct file_handle_list) Removed.
339 (extern var inline_file) Removed.
340 (static var file_handles) Changed from file_handle_list * to
342 (create_file_handle) Initialize new members.
343 (fh_close_handle) Removed.
344 (mode_name) New function.
345 (fh_open) New function.
346 (fh_close) New function.
347 (fh_parse_file_handle) Renamed fh_parse().
349 * glob.c: (init_glob) Remove fh_init_files() call.
351 * aggregate.c: use sfm_writer.
352 (create_sysfile) Removed because the new interface is simpler.
354 * apply-dict.c: Use sfm_reader.
356 * data-list.c: Use dfm_reader.
358 * file-type.c: Use dfm_reader.
360 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
362 * inpt-pgm.c: Use dfm_reader.
364 * print.c: Use dfm_writer.
366 * sysfile-info: Use sfm_reader.
368 * dfm-read.c: Adopt new file handle infrastructure.
370 * dfm-write.c: Ditto.
374 * pfm-write.c: Ditto.
378 * sfm-write.c: Ditto.
380 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
382 Break dictionary functions into separate header file.
384 * dictionary.h: New file.
386 * var.h: Moved dict_*() functions to dictionary.h.
388 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
390 Get rid of procedure-specific union in struct variable, using
391 instead a void * pointer and a destructor function.
393 Most related changes are only worth brief summaries.
395 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
396 old p.crs member in struct variable.
398 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
399 of old p.frq member in struct variable.
401 * histogram.c: (draw_histogram) Takes new freq_tab arg because
402 it's no longer possible to grab this from var->p.frq.
404 * piechart.c: (draw_piechart) Ditto.
406 * group.c: (group_proc_get) New function.
408 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
415 * main.c: (execute_command) Clear aux data in default_dict after
416 each command. (It's debatable whether this should be done.)
418 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
419 member in struct variable.
421 * means.q: Get rid of integer mode, which is not included in
422 recent SPSS and was the only code that wanted per-variable private
425 * var.h: (struct crosstab_proc) Removed.
426 (struct frequencies_proc) Removed.
427 (struct list_proc) Removed.
428 (struct get_proc) Removed.
429 (struct means_proc) Removed.
430 (struct matrix_data_proc) Removed.
431 (struct match_files_proc) Removed.
432 (lots of enums) Removed.
433 (struct variable) Removed members `p', `get'. Add member
436 * vars-atr.c: (var_attach_aux) New function.
437 (var_detach_aux) New function.
438 (var_clear_aux) New function.
439 (var_dtor_free) New function.
440 (discard_variables) Use NULL instead of inline_file.
442 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
444 * value-labs.c Fixed the implmentation of value_to_string, so
445 that it properly handles alpha values.
447 * oneway.q Changed instances where labels were being probed manually,
448 to use the canonical {var,value}_to_string functions
450 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
452 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
453 plots. Changed the API of the cartesian plot to be a much lower level
456 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
458 * examine.q Added some of the parametric calculations
460 * factor_stats.[ch] Created
462 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
464 * examine.q Changed the definition of factors to be a composite, and
465 dealt with the consequences.
467 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
469 * examine.q Fixed problem where examine wasn't dealing properly with
472 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
474 * oneway.q Fixed problem where oneway wasn't dealing properly with
477 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
479 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
480 command which had settings didn't get the appropriate code
483 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
484 to convert variables/values to strings.
486 * examine.q Added framework for the EXAMINE command.
488 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
490 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
491 subcommand types. Changed frequencies.q to use it rather then the
492 custom parser. Dealt with the consequences. Added a test for NTILES
493 subcommand of frequencies.
495 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
497 * oneway.q Fixed up the behaviour when given missing values
499 * levene.c oneway.q Fixed a buglet with the levene statistic and
500 incorporated the levene test into the oneway command.
502 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
503 global scope, since they're only relevant to T-TEST
505 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
507 * group.c group.h group_proc.h levene.c oneway.q t-test.q
509 Made the t-test more consistent
510 with the way it handles groups. That is, it now uses a hash instead
511 of an array of 2. Also, made the levene.c file independent of the
512 implementation of the t-test. So now levene should be fine for both
515 * Added an oneway.q file for one way anova
517 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
519 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
522 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
526 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
527 (data_list_trns_free) Free dls->delims.
529 * t-test.q: (tts_custom_pairs) Free vars.
530 (ssbox_one_sample_init) Fix tab_vline() argument.
531 (ssbox_independent_samples_init) Ditto.
532 (trbox_paired_init) Ditto.
533 (trbox_one_sample_init) Ditto.
535 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
537 Generalize casefiles to the extent that we can use them for
538 sorting and other kinds of data transformations. Change cases to
539 be copy-on-write to improve memory efficiency in common cases.
540 Every access to a member of a `struct ccase' was changed to be a
541 call to a case_*() function, especially case_data(), case_num(),
542 case_str(), or case_data_rw(). Many instances of a local variable
543 named "case_num" were changed to "case_idx" as a consequence.
544 Many `struct ccase *' were changed to actual `struct ccase'
545 because of copying semantics of cases. In several places there
546 was a choice between updating debug code to work with the new ADTs
547 or just deleting it because it was useless; I chose to delete it.
549 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
555 * aggregate.c: (struct agr_proc) Change type of `sort' to
556 sort_criteria *. Add `break_vars', `break_var_cnt' members.
557 Rename `vars' to `agr_vars', all references updated. Change
558 `agr_case' to type `struct ccase'.
559 (cmd_aggregate) Deal with new members. Use case_create(),
560 sort_active_file_in_place(), sort_active_file_to_casefile().
561 (agr_destroy) Deal with new members.
562 (aggregate_single_case) Ditto.
563 (dump_aggregate_info) Ditto.
564 (initialize_aggregate_info) Ditto.
565 (agr_to_active_file) Ditto.
566 (presorted_agr_to_sysfile) Ditto.
567 (sort_agr_to_sysfile) Removed.
569 * alloc.c: (out_of_memory) Make non-static.
571 * alloc.h: Prototype out_of_memory().
573 * casefile.c: Switched from a linked list in-memory representation
574 to a two-level array-style representation. The linked list was
575 appropriate when we could stick a header onto cases, but that's no
576 longer the case. Also, the two-level array will allow for random
577 in-memory access in case that's ever wanted. Also added the
578 concept of a `destructive casereader', one that destroys cases in
579 the underlying casefile as they are read out.
580 (macro CASES_PER_BLOCK) New macro.
581 (struct casefile) New members `value_cnt', `case_list_size',
582 `case_acct_size', `being_destroyed', `cases'. Removed `head',
584 (struct casereader) Removed `cur'. Added `destructive', `c'.
585 (global var casefiles) Made static.
586 (static var case_bytes) New var.
587 (casefile_create) Takes a value count, not a case size in bytes,
588 to conform to the case interface. All callers updated. Deal with
589 new and removed members.
590 (casefile_destroy) Deal with new and removed members.
591 (casefile_sleep) New function.
592 (casefile_get_case_size) Removed.
593 (casefile_get_value_cnt) New function.
594 (casefile_append) Rewritten to deal with new and removed members.
595 (casefile_append_xfer) New function.
596 (write_case_to_disk) Use case_serialize().
597 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
598 Couldn't figure out why.
599 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
600 deal with new and removed members.
602 (merge_sort) Removed.
603 (casefile_sort) Removed.
604 (casefile_get_reader) Deal with new and removed members.
605 (casefile_get_destructive_reader) New function.
606 (reader_open_file) Make code more readable. Create case for
608 (casereader_get_casefile) New function.
609 (casereader_read) Deal with new and removed members. Now returns
610 a copy of the case, so that the caller is responsible for
611 destroying the returned case.
612 (casereader_read_xfer) New function.
613 (casereader_destroy) Destroy reader's case.
614 (test_casefile) Second arg is now a value count, all callers
615 updated. Now tests destructive readers too.
616 (get_random_case) Deal with new case ADT.
617 (write_random_case) Ditto.
618 (read_and_verify_random_case) Ditto.
620 * crosstabs.q: Remove debug code.
622 * descript.q: (calc_descriptives) Deal with new case, casefile
625 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
627 * do-if.c: Remove unneeded header inclusion.
629 * expr-prs.c: Remove debug code.
631 * exprP.h: Remove debug code.
633 * flip.c: (flip_file) Use fseeko() if available.
635 * formats.c: Remove debug code.
637 * get.c: Remove debug code.
638 (struct mtf_file) Change `input' from `union value *' to `struct
639 ccase', all references updated.
641 * levene.c: (levene) Deal with new case, casefile ADTs.
643 * list.q: Remove debug code.
645 * loop.c: Remove debug code.
647 * matrix-data.c: Remove debug code.
649 * means.q: Remove debug code.
651 * mis-val.c: Remove debug code.
653 * pfm-read.c: Remove debug code.
654 (pfm_read_code) Change second arg from `union value *' to `struct
655 ccase *', all references updated.
657 * recode.c: (string_to_long) Make first arg const.
658 (convert_to_double) Ditto.
660 * repeat.c: Remove debug code.
662 * sample.c: Remove debug code.
664 * sfm-read.c: Remove debug code.
665 (sfm_read_case) Change second arg from `union value *' to `struct
668 * sort.c: Redone in terms of casefiles.
669 (enum sort_direction) Moved here from sort.h.
670 (struct sort_criterion) New structure.
671 (struct sort_criteria) New structure.
672 (cmd_sort_cases) Rewritten.
673 (prepare_to_sort_active_file) New function.
674 (sort_active_file_in_place) New function.
675 (sort_active_file_to_casefile) New function.
676 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
677 changed, all callers updated.
678 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
679 rewritten & interface changed, all callers updated.
680 (sort_cases) Renamed sort_execute(), rewritten & interface
681 changed, all callers updated.
682 (struct internal_sort) Removed.
683 (do_internal_sort) Rewritten, interface changed.
684 (destroy_internal_sort) Removed.
685 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
686 (struct initial_run) Removed; an initial run is now just a
688 (compare_initial_runs) Rewritten.
689 (struct external_sort) Changed almost completely.
690 (do_external_sort) Rewritten, interface changed.
691 (destroy_external_sort) Rewritten.
692 [HAVE_MKDTEMP] (make_temp_dir) Removed.
693 [!HAVE_MKDTEMP] (do_mkdir) Removed.
694 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
695 (init_external_sort) Removed.
696 (simulate_error) Removed.
697 (rmdir_temp_dir) Removed.
698 (get_temp_file_name) Removed.
699 (open_temp_file) Removed.
700 (close_temp_file) Removed.
701 (remove_temp_file) Removed.
702 (write_temp_file) Removed.
703 (read_temp_file) Removed.
704 (struct record_run) Change `record' from `struct case_lit *' to
706 (struct initial_run_state) Remove `idx_to_fv', `free_list',
707 `file_idx', `output_file'. Add `run', casefile'. Change
708 `last_output' from `struct case_list *' to `struct ccase'.
709 (write_initial_runs) Change interface, rewrite.
710 (sort_sink_write) Renamed process_case(), changed interfaced,
712 (destroy_initial_run_state) Rewritten.
713 (allocate_cases) Rewritten.
714 (compare_record) Interface changed, rewritten.
715 (start_run) Rewritten.
717 (output_record) Rewritten.
719 (release_case) Removed.
720 (struct merge_case) Change `cases' from double pointer to single
722 (merge) Deal with new case and casefile ADTs.
723 (struct run) Removed.
724 (merge_once) Rewritten, interface changed.
725 (fill_run_buffer) Removed.
726 (sort_sink_make_source) Removed.
727 (sort_sink_class) Removed.
728 (struct sort_source_aux) Removed.
729 (sort_source_read_helper) Removed.
730 (sort_source_read) Removed.
731 (read_sort_output) Removed.
732 (read_internal_sort_output) Removed.
733 (read_external_sort_output) Removed.
734 (sort_source_destroy) Removed.
735 (sort_source_class) Removed.
737 * sort.h: (struct sort_cases_pgm) Removed.
738 (enum sort_direction) Moved to sort.c.
740 * t-test.q: (calculate) Deal with new case, casefile ADTs.
742 * tab.c: Remove debug code.
744 * var-labs.c: Remove debug code.
746 * var.h: (struct ccase) Removed.
747 (struct case_list) Removed.
749 * vars-atr.c: (discard_variables) Use free_case_source().
751 * vars-prs.c: (parse_vs_variable) Make arg const.
752 (parse_dict_variable) Ditto.
753 (parse_variables) Make struct dictionary * arg const.
754 (parse_var_set_vars) Make struct var_set * arg const.
755 (struct var_set) Add const to some of the function pointers' args.
756 (var_set_get_cnt) Make arg const.
757 (var_set_get_var) Make first arg const.
758 (var_set_lookup_var) Make first arg const.
759 (dict_var_set_get_cnt) Make arg const.
760 (dict_var_set_get_var) Make first arg const.
761 (dict_var_set_lookup_var) Make first arg const.
762 (var_set_create_from_dict) Make arg const. Add cast to aux
764 (struct array_var_set) Add const to var member.
765 (array_var_set_get_cnt) Make arg const.
766 (array_var_set_get_var) Make first arg const.
767 (array_var_set_lookup_var) Make first arg const.
768 (var_set_create_from_array) Make first arg const. Insert cast.
770 * vfm.c: (struct write_case_data) Change trns_case, sink_case
771 members from `struct ccase *' to `struct ccase'.
772 (static var lag_queue) Change from double to single pointer.
773 (procedure) Optimize trivial case.
774 (internal_procedure) Deal with changed case, case_source ADTs.
775 (create_trns_case) Changed interface, rewrote.
776 (open_active_interface) Initialize modified lag queue.
777 (write_case) Deal with changed case ADT.
778 (lag_case) Deal with modified lag queue.
779 (close_active_file) Destroy modified lag queue.
780 Deal with changed case_source, case_sink ADTs.
781 (destroy_storage_stream_info) Make null arg into no-op.
782 (storage_sink_make_source) Set aux in created source.
783 (storage_source_read) Deal with changed case, casefile ADTs.
784 (storage_source_create) New function.
785 (lagged_case) Rewrite.
786 (free_case_source) New function.
787 (free_case_sink) Rewrite.
788 (struct split_aux_data) Changed prev_case from `struct ccase *' to
790 (procedure_with_splits) Deal with changed prev_case.
791 (procedure_with_splits_callback) Ditto.
792 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
794 (multipass_procedure_with_splits) Deal with changed prev_case.
795 (multipass_split_callback) Ditto.
798 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
800 The workspace idea didn't work out.
802 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
804 * workspace.c: Removed.
806 * workspace.h: Removed.
808 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
810 Fully implement arbitrary delimiters on DATA LIST, extending the
811 half implementation that was already there.
813 * data-list.c: (struct data_list_pgm) Remove `delim', add
814 `delims', `delim_cnt'.
815 (cmd_data_list) Initialize new members. Parse delimiters and
817 (cut_field) Extract fields with arbitrary delimiters. Also, fix
818 handling of leading commas.
819 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
821 (read_from_data_list_free) Adapt to new DFM interfaces.
822 (read_from_data_list_list) Ditto.
823 (repeating_data_trns_proc) Ditto.
825 * dfm.c: Split up reader and writer into separate code, because
826 they do different things. Use struct string instead of explicit
827 allocation code, for clarity.
828 (enum dfm_reader_flags) New enum.
829 (struct dfm_fhuser_ext) Removed.
830 (struct dfm_reader_ext) New.
831 (get_reader) New function, used by just about all the reader
834 (close_reader) New function.
835 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
836 (dfm_open_for_writing) Ditto.
837 (macro force_line_buffer_expansion) Removed.
838 (count_tabs) Removed.
839 (tabs_to_spaces) Removed.
840 (read_record) Deal with new dfm_reader_ext. Use struct string
841 functions. Don't convert tabs to spaces.
842 (dfm_eof) New function.
843 (dfm_get_record) Changed interface, rewrote.
844 (dfm_expand_tabs) New function.
845 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
846 dfm_reader_ext, rewritten.
847 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
848 dfm_reader_ext, rewritten.
849 (dfm_set_record) Removed in favor of dfm_forward_columns().
850 (dfm_forward_columns) New function.
851 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
852 dfm_reader_ext, rewritten.
853 (static var dfm_r_class) Use close_reader for the destructor.
854 (struct dfm_writer_ext) New.
855 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
856 bounce buffer now instead of local allocation.
857 (close_writer) New function.
858 (static var dfm_writer_ext) Use close_writer for destructor.
859 (cmd_begin_data) Adapt to new dfm_reader_ext.
861 * file-handle.q: Add support for per-file tab width.
862 (struct private_file_handle) Add tab_width member.
863 (q2c specifications) Add tabwidth subcommand.
864 (cmd_file_handle) Put parsed tab width into private_file_handle.
865 (create_file_handle) Set default tab width.
866 (handle_get_tab_width) New function.
868 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
870 * inpt-pgm.c: (reread_trns_proc) Ditto.
872 * matrix-data.c: (context) Ditto.
873 (another_token) Ditto.
877 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
879 * casefile.c: (casefile_destroy) Fix memory leak by freeing
881 (casereader_destroy) Don't close file descriptor -1.
883 * recode.c: (cmd_recode) Fix memory leak.
885 * set.q: (q2c specifications) Fix typo in user message.
887 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
888 undefined behavior for overlapping arguments.
890 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
892 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
893 don't call it when we're running under valgrind.
894 (call_posix_fadvise) New function.
895 (casefile_to_disk) Use call_posix_fadvise().
896 (reader_open_file) Ditto.
898 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
900 Update our string ADTs, struct string and struct len_string. Get
901 rid of pool support, which was largely unused. Rename lots of
902 functions to have more obvious or consistent names.
904 * ascii.c: Get rid of ascii_pool. It was only used for string
906 (ascii_open_global) Don't create ascii_pool.
907 (ascii_close_driver) Don't destroy ascii_pool.
908 (ascii_postopen_driver) Don't use pool.
909 (ascii_close_driver) Destroy strings manually.
911 * str.c: (ds_create) Remove pool argument, all references updated.
913 (ds_replace) Remove pool support, make more efficient when we
914 don't need to reallocate.
915 (ds_destroy) Remove pool support.
916 (ds_rpad) New function.
917 (ds_size) Renamed ds_capacity(), all references updated.
918 (ds_value) Renamed ds_c_str(), all references updated.
919 (ds_concat) Renamed ds_puts(), all references updated.
920 (ds_concat_buffer) Renamed ds_concat(), all references updated.
921 (ds_putchar) Renamed ds_putc(), all references updated.
922 (ds_getline) Renamed ds_gets(), all references updated.
923 (ls_create) Remove pool argument, all references updated.
924 (ls_create_buffer) Ditto.
925 (ls_destroy) Removed pool support.
926 (ls_value) Renamed ls_c_str(), all references updated.
928 * str.h: (ls_length) [__GNUC__] Add inline version.
929 (ls_c_str) [__GNUC__] Add inline version.
930 (ls_end) [__GNUC__] Add inline version.
931 (struct string) Remove pool member. Rename `size' to `capacity',
932 all references updated.
934 * tab.c: (text_format) Instead of using pool argument to
935 ls_create_buffer(), call pool_register() on allocated data.
937 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
939 We're abusing the current ASCII driver by telling it to allocate a
940 9999-line, 9999-character page in the tests. This causes some
941 systems to curl up and die because it allocates 20 MB of
942 contiguous RAM. This change alleviates at least part of the
943 problem. It is mostly a stop-gap until the new output system is
946 * ascii.c: (struct line) New structure.
947 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
948 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
949 (ascii_preopen_driver) Initialize new members, not old ones.
950 (ascii_close_driver) Destroy new members, not old ones.
951 (ascii_open_page) Allocate new members, not old ones.
952 (expand_line) Allocate room in line.
953 (draw_line) Use new members.
954 (ascii_line_horz) Ditto.
955 (ascii_line_vert) Ditto.
956 (ascii_line_intersection) Ditto.
958 (output_lines) Ditto.
959 (ascii_close_page) Ditto.
961 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
963 * matrix.c: Dead code. Removed.
965 * matrix.h: Dead code. Removed.
967 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
969 Contrary to what I'd always understood, there is an efficient
970 algorithm for deletion from a hash table populated via linear
971 probing. This change implements it.
973 * hash.c: (hsh_rehash) Probe in increasing order.
975 (locate_matching_entry) Ditto.
976 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
978 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
980 * moments.c (calc_moments): Adjust calculation of kurtosis to
981 avoid subtracting huge numbers from huge numbers, on Michael
984 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
986 Rework moments routines for improved numerical stability based on
987 Michael Kiefte's advice. Any bugs or remaining numerical problems
988 are still mine though.
990 There is now a struct moments1 for use with one-pass moments. It
991 uses a provisional means algorithm as an attempt to improve
992 accuracy of higher moments. The older struct moments now only
993 handles two-pass moments.
995 * aggregate.c: Use moments1 instead moments.
997 * descript.c: Revert previous change, which is no longer needed
998 due to the moments revision.
1000 * moments.c: (calc_moments) New function for calculating variance,
1002 (moments_pass_one) Only accumulate weights bigger than zero.
1003 (moments_calculate) Allow calculating the mean on pass one, others
1004 require pass two. Implement in terms of calc_moments().
1005 (struct moments1) New structure.
1006 (init_moments1) New function.
1007 (moments1_clear) Ditto.
1008 (moments1_create) Ditto.
1009 (moments1_add) Ditto.
1010 (moments1_calculate) Ditto.
1011 (moments1_destroy) Ditto.
1012 (cmd_debug_moments) Deal with `struct moments' or `struct
1013 moments1' as requested by user.
1015 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
1017 * Makefile.am (pspp_SOURCES): Remove debug.c.
1019 * debug.c: Removed. It was empty anyway.
1021 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
1023 * descript.c (calc_descriptives): Fix assert failure when only
1024 MOMENT_MEAN is needed.
1026 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
1030 fixed problem with parsing in match_statistic() causing
1031 "DESCRIPTIVE STAT=MEAN." to barf.
1033 "MEAN" is now default if "SORT" given without specification.
1035 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
1036 generally less forgiving of syntax errors: better to have it do
1037 nothing and type it in again then to not know what it actually did
1040 z-score transformation now checks score for user-missing values
1041 and checks std_dev for SYSMIS.
1043 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
1045 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
1046 Changed dict_get_case_weight() to accept an additional int * flag
1047 to complain about system-missing, user-missing, zero, or negative
1048 weights and updated existing functions to pass int * to
1049 dict_get_case_weight().
1051 2004-04-05 jmd <jmd@gnu.org>
1053 * main.c: Fixed configuration problems with gsl
1055 * t-test.q: Fixed some problems encountered when compiling under Cygwin
1057 2004-04-03 blp <blp@gnu.org>
1059 * lexer.c, ChangeLog:
1060 Fix infinite loop on comment at end of file, add test.
1062 2004-04-03 jmd <jmd@gnu.org>
1064 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
1065 Fixed the calculation of percentiles and added --syntax and --algorithm options
1067 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
1069 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
1072 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1074 * frequencies.q: Fixed the calculation of percentiles
1076 * Makefile.am: Added the --ansi flag and dealt with the
1077 consequences. Added some entries to PSPP_sources so that
1078 make distcheck would pass
1080 * cmdline.c: Added the --syntax and --algorithm options
1082 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
1084 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1086 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
1087 use the new multipass_split_... mechanism.
1089 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
1091 * frequencies.q: (calc_stats) Use moments data structure and
1092 calc_seskew(), calc_sekurt() functions.
1094 * set.q main.c settings.h Added support for --syntax and --algorithm
1097 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
1099 * vfm.c: Had to get last call to multipass_split_output() inside
1100 open_active_file()/close_active_file() pairing, so introduce new
1102 (internal_procedure) Move procedure() code here, except for calls
1103 to open_active_file() and close_active_file().
1104 (procedure) Wrap open_active_file() and close_active_file() around
1105 internal_procedure().
1106 (multipass_procedure_with_splits) Wrap open_active_file() and
1107 close_active_file() around internal_procedure().
1109 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
1111 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
1113 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
1115 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
1117 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
1119 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
1121 * algorithm.c: By default turn off some of the more expensive
1123 (expensive_assert) New macro which expands to assert if
1124 EXTRA_CHECKS is defined, to nothing otherwise.
1125 (unique) Use expensive_assert().
1126 (binary_search) Ditto.
1132 * command.c: (conflicting_3char_prefixes) Words that are the same
1133 don't cause conflicts when they are abbreviated to the first three
1136 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
1137 nonterm_node's n earlier.
1138 (generic_str_func) Ditto.
1140 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
1142 Add support for multipass procedures. Rewrite DESCRIPTIVES to
1143 test multipass support, take advantage of new moments
1144 calculation, and to not be such crappy code. Get rid of q2c
1145 processing for DESCRIPTIVES.
1147 * vfm.c: (struct multipass_split_aux_data) New structure.
1148 (multipass_procedure_with_splits) New function.
1149 (multipass_split_callback) New function.
1150 (multipass_split_output) New function.
1151 * descript.q: Removed.
1153 * descript.c: New file.
1155 * var.h: Removed descriptives enums.
1156 (struct descriptives_proc) Removed.
1157 (struct variable) Removed p.dsc.
1159 * Makefile.am: (q_sources_c) Remove descript.c.
1160 (q_sources_q) Removed descript.q.
1162 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
1164 New manager for keeping track of used workspace.
1166 * workspace.c: New file.
1168 * workspace.h: New file.
1170 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
1172 * sort.c: (do_internal_sort) Use workspace_malloc().
1173 (destroy_internal_sort) Use workspace_free().
1175 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
1177 New `struct casefile' for managing sets of cases.
1179 * casefile.c: New file.
1181 * casefile.h: New file.
1183 * command.def: Add DEBUG CASEFILE command.
1185 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
1187 * sort.c: (sort_cases) Move logic for sending storage file to disk
1188 into do_external_sort().
1189 (struct internal_sort) Use an array of ccase pointers instead of a
1191 (do_internal_sort) Rewrite to handle casefiles.
1192 (compare_case_list) Removed.
1193 (compare_cases) New function.
1194 (compare_case_dblptrs) New function.
1195 (read_internal_sort_output) Deal with new struct internal_sort.
1197 * vfm.c: (static var workspace_overflow) Removed.
1198 (struct storage_stream_info) Removed all the members. Added
1199 struct casefile * member.
1200 (storage_sink_open) Use casefile.
1201 (open_storage_file) Removed.
1202 (write_storage_file) Removed.
1203 (storage_to_disk) Removed.
1204 (destroy_storage_stream_info) Use casefile.
1205 (storage_sink_write) Use casefile.
1206 (storage_sink_make_source) Use casefile.
1207 (storage_source_count) Use casefile.
1208 (storage_source_read) Use casefile.
1209 (storage_source_on_disk) Removed.
1210 (storage_source_get_cases) Removed.
1211 (storage_source_set_cases) Removed.
1212 (storage_source_get_casefile) New function.
1214 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
1216 New `struct moments' for calculating moments.
1222 * moments.c: New file.
1224 * moments.h: New file.
1226 * command.def: Add DEBUG MOMENTS command.
1228 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
1231 * aggregate.c: Modify AGGREGATE to use the new moments
1232 calculation, even if not in such a great way.
1233 (struct agr_var) Add `moments' member.
1234 (parse_aggregate_functions) Set `moments' member to null.
1235 (agr_destroy) Destroy `moments' member.
1236 (accumulate_aggregate_info) Use `moments' for standard deviation.
1237 (dump_aggregate_info) Ditto.
1238 (initialize_aggregate_info) Create or clear `moments'.
1240 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
1241 cube(), pow4() that were in stats.h. All references updated.
1243 * crosstabs.q: stats.h had chi-square significance functions. Use
1245 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
1247 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
1248 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
1250 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
1252 * dictionary.c: (dict_compact_values) Compacted values need to
1255 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
1257 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
1258 `/' at start. Check return value of parse_variables() for error
1261 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
1263 Revamp expressions: make the code a little nicer, and fix bugs
1266 * expr-evl.c: (expr_evaluate) Make expression argument const.
1267 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1268 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
1269 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
1270 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
1271 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
1272 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
1273 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
1274 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
1275 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
1276 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
1277 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
1278 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
1279 Simplify OP_SYSMIS. Remove OP_STR_MIS.
1281 * expr-opt.c: (optimize_expression) Rewrite.
1286 (macro s0l) Removed.
1288 (macro s1l) Removed.
1290 (macro s2l) Removed.
1293 (eq_num_con) New function.
1294 (optimize_tree) New function.
1295 (macro rnc) Removed.
1296 (macro frnc) Removed.
1297 (str_search) Add const to string params.
1298 (str_rsearch) Ditto.
1299 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
1300 str[], str_len[] locals to substitute for most of removed macros.
1301 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1302 Removed support for missing values because we're never called with
1303 missing values. Use set_number() or set_number_errno() instead of
1304 rnc or frnc. Removed any stuff that caused trouble in testing.
1305 We can re-add it later if it really slows anything. Fix some
1307 (evaluate_tree_with_missing) Not yet supported. To be added later
1309 (repl_num_con) Removed.
1310 (collapse_node) New function.
1311 (force_repl_num_con) Removed.
1312 (set_number) New function.
1313 (set_number_errno) New function.
1314 (repl_str_con) Removed.
1315 (set_string) New function.
1316 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
1318 (dump_node) No special case for OP_AND, OP_OR.
1320 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
1321 (expr_get_type) New function.
1322 (type_check) Rewrite.
1323 (type_coercion) New function.
1324 (struct operator) New structure.
1325 (match_operator New function.
1326 (parse_binary_operators) New function.
1327 (parse_inverting_unary_operator) New function.
1328 (parse_or) Rewritten.
1329 (parse_and) Rewritten.
1330 (parse_not) Rewritten.
1331 (parse_rel) Rewritten.
1332 (parse_add) Rewritten.
1333 (parse_mul) Rewritten.
1334 (parse_neg) Rewritten.
1335 (parse_exp) Rewritten.
1336 (parse_sysvar) Add $TRUE, $FALSE system variables.
1337 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
1338 (parse_primary) Use allocate_var_node(), allocate_num_con(),
1340 (struct function) Remove desc, change `func' prototype.
1341 (unary_func) Remove special cases.
1342 (MISSING_func) Reduce to unary_func() that just returns a boolean.
1343 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
1344 (VALUE_func) Use allocate_var_node().
1345 (nary_num_func) Allow MIN and MAX for strings.
1346 Use allocate_var_node(). Properly clean up.
1348 (generic_str_func) Use local table instead of removed `desc'
1349 member. Mostly rewrite.
1350 (get_num_args) Revise error message.
1351 (parse_function) Return EXPR_ERROR, not 0 on error.
1353 (macro varies) Removed.
1354 (ops[]) Use expr.def.
1355 (free_node) Do nothing if node is null.
1356 (allocate_num_con) New function.
1357 (allocate_str_con) New function.
1358 (allocate_var_node) New function.
1359 (allocate_binary_nonterminal) New function.
1360 (append_nonterminal_arg) Removed.
1361 (static var func_tab[]) Revised.
1362 (expr_debug_print_postfix) Make parameter const.
1363 Use printf() instead of debug_printf().
1365 * expr.def: New file.
1367 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
1368 use named enum instead of unnamed, all references updated. Add
1369 EXPR_ANY, EXPR_NO_OPTIMIZE.
1371 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
1372 instead of defining OP_* directly.
1373 (macro IS_TERMINAL) New macro.
1374 (macro IS_NONTERMINAL) New macro.
1375 (enum OP_NO_FLAGS) New.
1377 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
1379 * error.c: (err_assert_fail) msg variable needs to be non-const.
1381 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
1383 * debug.c: (cmd_debug_evaluate) Rewrite.
1385 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
1387 Fix some CROSSTABS bit rot stupidity.
1389 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
1390 (internal_cmd_crosstabs) Initializes cells[] correctly.
1391 (float_M_suffix) Rename format_cell_entry(), change prototype,
1393 (display_crosstabulation) Fix cell formatting.
1395 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
1397 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
1398 to call lex_discard_line() to do that.
1400 * command.c: (run_command) Call lex_discard_line() after
1403 * lexer.c: (lex_entire_end) Change behavior.
1404 (lex_rest_of_line) Change behavior. Return const char *.
1405 (lex_discard_line) Don't clear getl_buf, don't emit message.
1407 * main.c: (handle_error) Emit message here.
1409 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
1410 instead of lex_entire_line().
1412 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
1414 * title.c: (get_title) Call lex_discard_line() after
1416 (cmd_file_label) Ditto.
1417 (cmd_document) Deal with const char * return value.
1419 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
1421 Removed REMARK command.
1423 * command.c: (extract_prefix) Removed.
1424 (output_line) Removed.
1425 (cmd_remark) Removed.
1427 * command.def: Remove REMARK.
1429 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
1431 Added abort() after lots of assert(0) invocations to avoid some
1432 compiler warnings. We really need a NOT_REACHED macro.
1434 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1436 * sort.c: Added missing call to temp_file_close. Changed error
1437 messages to warnings.
1439 * set.q: Improved setting of set_view{length,width} to be more tolerant
1442 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
1444 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
1445 used with incorrect syntax.
1447 * error.c, error.h et al: Overridden definition of assert for a
1450 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
1451 subcommand was given when it ought to have been.
1453 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
1455 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
1459 (tab_joint_text) Ditto.
1461 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
1463 * levene.c: Add #include.
1465 * set.q: (set_viewport) Add `int' argument to make its prototype
1466 correct for signal().
1468 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
1470 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
1473 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
1475 Changed DFM from open-at-first-access to explicit-open. Before,
1476 calling dfm_get_record() or dfm_put_record() would automatically
1477 open the file. Now, you have to call dfm_open_for_reading() or
1478 dfm_open_for_writing() explicitly. This makes it possible to
1479 check permissions, file existence, etc. earlier.
1481 Also made struct file_handle more opaque, and clean up in general.
1483 * data-list.c: (cmd_data_list) Open handle for reading.
1485 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
1487 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
1488 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
1489 (open_inline_file) Removed.
1490 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
1491 it. Deal with line_number in extension record instead of file
1493 (dfm_get_record) Rewrote.
1494 (dfm_put_record) Rewrote.
1495 (dfm_push) Assert file is open and one of ours. Deal with
1496 line_number in extension record instead of file handle.
1497 (dfm_pop) Assert file is open and one of ours. Deal with
1498 line_number in extension record instead of file handle.
1499 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
1502 * file-handle.h: (enum constants RH_RF_*) Removed.
1503 (enum constants FH_MD_*) Removed.
1504 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
1505 `recform', `lrecl', `mode' members. Public references to
1506 `recform' changed to use handle_get_mode(), references to `lrecl'
1507 changed to use handle_get_record_width(). Added `private' member.
1508 (enum file_handle_mode) New.
1510 * file-handle.q: (struct private_file_handle) New structure.
1511 (struct file_handle_list) New structure.
1512 (static var files) New.
1513 (static var file_handles) Removed.
1514 (init_file_handle) Removed.
1515 (create_file_handle) Removed.
1516 (get_handle_with_name) New function.
1517 (get_handle_for_filename) New function.
1518 (cmd_file_handle) Rewritten.
1519 (hash_file_handle) Removed.
1520 (cmp_file_handle) Removed.
1521 (fh_init_files) Rewritten.
1522 (fh_parse_file_handle) Rewritten. Allows identifiers as
1524 (fh_get_handle_by_name) Renamed handle_get_name(), all references
1526 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
1527 references updated. Rewritten.
1528 (fh_record_width) Renamed handle_get_record_width(), all
1529 references updated. Rewritten.
1530 (handle_get_mode) New function.
1532 * file-type.c: (cmd_file_type) Open handle for reading.
1534 * filename.c: [unix] (struct file_identity) New structure.
1535 [unix] (fn_get_identity) New function.
1536 [unix] (fn_free_identity) New function.
1537 [unix] (fn_compare_file_identities) New function.
1538 [!unix] (struct file_identity) New structure.
1539 [!unix] (fn_get_identity) New function.
1540 [!unix] (fn_free_identity) New function.
1541 [!unix] (fn_compare_file_identities) New function.
1543 * lexer.c: (static var put) Renamed put_token, all references
1545 (static var put_tokstr) New.
1546 (static var put_tokval) New.
1547 (lex_init) Initialize put_tokstr().
1548 (restore_token) New function.
1549 (save_token) New function.
1550 (lex_get) Use restore_token().
1551 (lex_put_back) Use save_token().
1552 (lex_put_back_id) New function.
1553 (lex_put_forward) Removed.
1554 (lex_preprocess_line) Set put_token instead of using
1556 (lex_negative_to_dash) Use save_token(), set put_token directly.
1557 (dump_token) Use stderr instead of stdout.
1559 * main.c: (main) Remove call to cmd_init().
1561 * matrix-data.c: (cmd_matrix_data) Open file for reading.
1563 * pfm-read.c: Use handle_get_filename() instead of trying to use
1564 h->fn directly, all over.
1566 * pfm-write.c: Ditto.
1568 * print.c: (internal_cmd_print) Open handle for writing.
1569 (dump_table) Use handle_get_filename().
1570 (print_trns_proc) Use handle_get_mode().
1571 (cmd_print_space) Use fh_parse_file_handle().
1572 Open handle for writing.
1573 [0] (debug_print) Removed.
1575 * sfm-read.c: Use handle_get_filename() instead of trying to use
1576 h->fn directly, all over.
1578 * sfm-write.c: Ditto.
1580 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
1584 * autorecode.c: (arc_free) Free arc->src_values.
1586 * error.c: (msg) Free buf.
1588 * val-labs.c: (do_value_labels) Always free vars.
1590 * vfm.c: (close_active_file) If sink has no make_source then call
1591 its destroy function.
1593 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
1595 Fixed cmd_parse() so that it always skips past a full command
1596 name. A few special commands for which this would be bad get
1597 special treatment. This lets us drop code for skipping past the
1598 end of a command name in most cmd_*() functions. It's not worth
1599 listing all the commands affected.
1601 * command.c: (struct command) Remove `cmd' member, replace by
1602 `name' member, all references updated. Remove `word', `next',
1603 `skip_entire_name' members.
1604 (macro DEFCMD) Deal with revised `struct command'.
1605 (macro UNIMPL) Ditto.
1606 (macro SPCCMD) New macro for commands whose last word shouldn't be
1608 (static array cmd_table[]) Make const, rename `commands', remove
1610 (macro COMMAND_CNT) New macro.
1611 (split_words) Removed.
1613 (FILE_TYPE_okay) Make parameter const.
1614 (cmd_parse) Improve error messages.
1615 (match_strings) New function.
1616 (next_word) New function.
1617 (enum command_match) New enum.
1618 (conflicting_3char_prefixes) New function.
1619 (conflicting_3char_prefix_command) New function.
1620 (cmd_match_words) New function.
1621 (count_matching_commands) New function.
1622 (get_command_name) New function.
1623 (free_words) New function.
1624 (unknown_command_error) New function.
1625 (figure_out_command) Renamed parse_command_name(), rewritten.
1627 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
1628 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
1629 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
1632 * command.h: (macro SPCCMD) New.
1634 * include.c: (cmd_include_at) Removed.
1635 (cmd_include) Allow identifier to be used as filename.
1637 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
1639 * t-test.q: (cmd_t_test) Command name is now parsed for us.
1642 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
1644 Start work on better test framework.
1646 * Makefile.am: (pspp_sources) Add debug.c.
1648 * debug.c: New file.
1650 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
1651 cmd_debug_evaluate().
1653 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
1655 * expr.h: (enum constant PXP_DUMP) Removed.
1657 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
1659 * set.q: Implemented the SHOW command, and synced it to the existing
1662 Added a handler for SIGWINCH so that viewlength and viewwidth follow
1663 changes as the window size is changed.
1665 Added fallback to set viewlength and viewwidth from LINES and COLUMS
1666 environment variables if other methods are not available.
1668 glob.c: Removed a lot of global variables from glob.c and encapsulated
1671 random.c: Tidied up the way the random seed is set.
1673 str.c: Added a ds_vprintf function.
1675 error.c: Extended dump_message so that messages are always broken at
1678 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
1680 * pfm-write.c: (bufwrite) Write out the correct element for string
1681 variables. From Andreas Streichardt <streichardt@globalpark.de>.
1683 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
1685 Get rid of static and global (!) vars in matrix-data.c.
1687 * matrix-data.c: (static var nr_data) Removed.
1688 (static var nr_factor_values) Removed.
1689 (static var max_cell_index) Removed.
1690 (static var split_values) Removed.
1691 (struct nr_aux_data) New structure.
1692 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
1693 place of static vars, pass to create_case_source() and procedure()
1695 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
1696 struct matrix_data_pgm *.
1697 (nr_read_splits) Ditto.
1698 (nr_read_factors) Ditto.
1699 (nr_output_data) Ditto.
1700 (static var wr_content) Removed.
1701 (global var wr_data) Removed.
1702 (global var wr_current) Removed.
1703 (struct wr_aux_data) New structure.
1704 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
1705 place of static vars, pass to create_case_source() and procedure()
1707 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
1708 instead of matrix_data_pgm *.
1709 (wr_read_splits) Ditto.
1710 (wr_output_data) Ditto.
1711 (wr_read_rowtype) Ditto.
1712 (wr_read_factors) Ditto.
1713 (wr_read_indeps) Ditto.
1715 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
1717 Get rid of static vars in autorecode.c.
1719 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
1720 `n_arc' to `spec_cnt'. All references updated.
1721 (static var v_src) Removed.
1722 (static var v_dest) Removed.
1723 (static var h_trns) Removed.
1724 (static var nv_src) Removed.
1725 (static var descend) Removed.
1726 (static var print) Removed.
1727 (enum direction) New enum.
1728 (struct autorecode_pgm) New structure.
1729 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
1730 Move n_dest local var into struct autorecode_pgm for ease of
1731 clean-up. Use arc_free().
1732 (arc_free) New function.
1733 (recode) Modify to take struct autorecode_pgm * parameter instead
1734 of using statics. Let the caller clean up.
1735 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
1736 instead of statics. Rearrange code a little.
1738 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
1740 Get rid of static, global vars in recode.c. Remove debug code.
1742 * recode.c: (static var head) Removed.
1743 (global var v) Removed.
1744 (global var nv) Removed.
1745 (cmd_recode) New local variables head, v, nv. Initialize and free
1746 v. Don't call debug_print().
1747 [DEBUGGING] (dump_dest) Removed.
1748 [DEBUGGING] (debug_print) Removed.
1750 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
1752 Get rid of static vars in expr-opt.c.
1754 * expr-opt.c: (static var e) Removed.
1755 (static var nop) Removed.
1756 (static var mop) Removed.
1757 (static var ndbl) Removed.
1758 (static var mdbl) Removed.
1759 (static var nstr) Removed.
1760 (static var mstr) Removed.
1761 (static var nvars) Removed.
1762 (static var mvars) Removed.
1763 (struct expr_dump_state) New structure.
1764 (dump_expression) Use new struct expr_dump_state instead of static
1765 vars and pass to functions we call.
1766 (dump_node) Use struct expr_dump_state * parameter.
1768 (emit_num_con) Ditto.
1769 (emit_str_con) Ditto.
1772 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
1774 Get rid of static var in COUNT.
1776 * count.c: (static var head) Move into cmd_count().
1777 (cmd_count) [DEBUGGING] Don't call debug_print.
1778 [DEBUGGING] (debug_print) Removed.
1780 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
1782 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
1784 * val-labs.c: (static var v) Removed.
1785 (static var nv) Removed.
1786 [DEBUGGING] (debug_print) Removed.
1787 (verify_val_labs) Add struct variable **, int parameters.
1788 (get_label) Ditto. Improve error messages, streamline.
1789 (erase_labels) New function for erasing value labels, taking over
1790 part of verify_val_labs()'s function.
1793 (cmd_value_labels) No need to call init() or done() anymore.
1794 (cmd_add_value_labels) Ditto.
1795 (do_value_labels) Add vars, var_cnt local variables. Clean up
1796 after them internally. Call erase_labels() if we should. Don't
1799 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
1801 Get rid of static vars in MATCH FILES.
1803 * get.c: (static var mtf_head) Removed.
1804 (static var mtf_tail) Removed.
1805 (static var mtf_by) Removed.
1806 (static var mtf_n_by) Removed.
1807 (static var mtf_master) Removed.
1808 (static var mtf_seq_num) Removed.
1809 (static var mtf_seq_nums) Removed.
1810 (static var mtf_sink) Removed.
1811 (static var mtf_case) Removed.
1812 (struct mtf_proc) New structure.
1813 (cmd_match_files) Use struct mtf_proc instead of static vars.
1814 (mtf_processing_finish) Ditto.
1816 (mtf_delete_file_in_place) Ditto.
1817 (mtf_read_nonactive_records) Ditto.
1818 (mtf_compare_BY_values) Ditto.
1819 (mtf_processing) Ditto.
1820 (mtf_merge_dictionary) Ditto.
1822 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
1824 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
1826 * dictionary.c: (dict_rename_var) Add assertion.
1827 (dict_contains_var) Check by index instead of name.
1829 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
1831 Get rid of compaction_necessary, compaction_nval, compaction_case.
1832 Redo VFM interface. Replace disk_sink and memory_sink by
1833 storage_sink, disk_source and memory_source by storage_source.
1835 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
1839 (struct write_case_data) Remove `begin_func', `end_func',
1840 `func_aux' members. Add `aux', `trns_case', `sink_case',
1841 `cases_written', `cases_analyzed' members.
1842 (global var compaction_necessary) Make static.
1843 (global var compaction_nval) Removed.
1844 (global var compaction_case) Removed.
1845 (static var case_count) Removed.
1846 (struct procedure_aux_data) Removed.
1847 (struct split_aux_data) Removed.
1848 (procedure) Remove begin_func, end_func parameters. Rewrite.
1849 (static var not_canceled) Removed.
1850 (process_active_file) Removed.
1851 (process_active_file_write_case) Removed.
1852 (process_active_file_output_case) Removed.
1853 (prepare_for_writing) Moved into open_active_file().
1854 (arrange_compaction) Ditto.
1856 (open_active_file) Rewrote.
1857 (write_case) New function.
1858 [DEBUGGING] (index_to_varname) Removed.
1859 (execute_transformations) New function.
1860 (exclude_this_case) Renamed filter_case(), changed interface.
1861 (clear_case) Added struct ccase * parameter to interface.
1862 (close_active_file) Added struct write_case_data * parameter,
1864 (disk_sink_create) Removed.
1865 (disk_sink_destroy) Removed.
1866 (disk_sink_make_source) Removed.
1867 (disk_sink_write) Removed.
1868 (disk_source_count) Removed.
1869 (disk_source_destroy) Removed.
1870 (disk_source_read) Removed.
1871 (global var disk_sink_class) Removed.
1872 (global var disk_source_class) Removed.
1873 (global var memory_sink_class) Removed.
1874 (global var memory_source_class) Removed.
1875 (memory_sink_create) Removed.
1876 (memory_sink_destroy) Removed.
1877 (memory_sink_make_source) Removed.
1878 (memory_sink_write) Removed.
1879 (memory_source_count) Removed.
1880 (memory_source_destroy) Removed.
1881 (memory_source_get_cases) Removed.
1882 (memory_source_read) Removed.
1883 (memory_source_set_cases) Removed.
1884 (struct disk_stream_info) Removed.
1885 (struct memory_sink_info) Removed.
1886 (struct memory_source_info) Removed.
1887 (write_active_file_to_disk) Removed.
1888 (destroy_storage_stream_info) New function.
1889 (global var null_sink_class) New var.
1890 (global var storage_sink_class) New var.
1891 (global var storage_source_class) New var.
1892 (open_storage_file) New function.
1893 (storage_sink_destroy) New function.
1894 (storage_sink_make_source) New function.
1895 (storage_sink_open) New function.
1896 (storage_sink_write) New function.
1897 (storage_source_count) New function.
1898 (storage_source_destroy) New function.
1899 (storage_source_get_cases) New function.
1900 (storage_source_on_disk) New function.
1901 (storage_source_read) New function.
1902 (storage_source_set_cases) New function.
1903 (storage_source_to_disk) New function.
1904 (storage_to_disk) New function.
1905 (struct storage_stream_info) New structure.
1906 (write_storage_file) New function.
1907 (procedure_write_case) Removed.
1908 (create_case_source) Add `struct dictionary *' parameter, all
1910 (create_case_sink) Ditto.
1911 (free_case_sink) New function.
1912 (struct split_aux_data) New structure.
1913 (procedure_with_splits) New function implementing what procedure()
1915 (SPLIT_FILE_proc_func) Removed.
1916 (procedure_with_splits_callback) New function.
1917 (equal_splits) New function.
1919 * aggregate.c: Pass around a struct instead of using statics.
1920 (static var outfile) Remove.
1921 (enum type) Give it tag `missing_treatment'.
1922 (static var missing) Remove.
1923 (static var sort) Remove.
1924 (static var agr_first) Remove.
1925 (static var agr_next) Remove.
1926 (static var case_count) Remove.
1927 (static var prev_case) Remove.
1928 (static var buf64_1xx) Remove.
1929 (static var buf_1xx) Remove.
1930 (struct agr_proc) New structure incorporating the above.
1931 (cmd_aggregate) Use new struct. Clean up error handling using
1932 agr_destroy(). Completely rewrite actual implementation of
1934 (create_sysfile) Add struct agr_proc * parameter, modify
1936 (parse_aggregate_functions) Ditto.
1937 (free_aggregate_functions) Ditto. Rename agr_destroy().
1938 (aggregate_single_case) Add struct agr_proc * parameter, modify
1940 (accumulate_aggregate_info) Ditto.
1941 (dump_aggregate_info) Ditto.
1942 (initialize_aggregate_info) Ditto.
1943 (agr_00x_trns_proc) Removed.
1944 (agr_00x_end_func) Removed.
1945 (agr_10x_trns_proc) Removed.
1946 (agr_10x_trns_free) Removed.
1947 (agr_10x_end_func) Removed.
1948 (agr_11x_read) Removed.
1949 (agr_11x_finish) Removed.
1950 [DEBUGGING] (debug_print) Removed.
1951 (write_case_to_sfm) Add struct agr_proc * parameter, modify
1953 (agr_to_active_file) New function.
1954 (presorted_agr_to_sysfile) New function.
1955 (sort_agr_to_sysfile) New function.
1957 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
1959 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
1961 * descript.q: (cmd_descriptives) Ditto.
1963 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
1964 to new procedure() interface.
1966 * command.c: (cmd_execute) Adapt to new procedure() interface.
1968 * dictionary.c: (dict_compact_values) Also delete scratch
1970 (dict_get_compacted_value_cnt) New function.
1971 (dict_get_compacted_idx_to_fv) New function.
1973 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
1974 (cmd_flip) Adapt to new procedure() interface.
1975 (flip_sink_write) Use sink->idx_to_fv.
1977 * frequencies.q: (internal_cmd_frequencies) Use
1978 procedure_with_splits().
1980 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
1981 (static var mtf_sink) New static var.
1982 (static var mtf_case) New static var.
1983 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
1984 we actually implement the matching.
1985 (mtf_delete_file_in_place) Use mtf_case.
1986 (mtf_processing) Use mtf_case and mtf_sink.
1987 (cmd_export) Adapt to new procedure() interface.
1989 * levene.c: (levene) Use procedure_with_splits().
1991 * list.q: (cmd_list) Use procedure_with_splits().
1993 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
1994 procedure() interface.
1995 (read_matrices_with_rowtype) Ditto.
1997 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
1998 TEMPORARY. Adapt to new procedure() interface.
2000 * rename-vars.c: Warn about and cancel TEMPORARY.
2002 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
2003 (sort_cases) Use dict_get_compacted_value_cnt() instead of
2004 compaction_nval. Adapt to new procedure() interface. Use
2005 storage_source_to_disk().
2006 (do_internal_sort) Don't try to dump the cases to memory.
2007 (compare_case_lists) Pass null idx_to_fv.
2008 (struct initial_run_state) Add `idx_to_fv' member. Remove
2010 (write_initial_runs) Don't initialize irs->case_size. Adapt to
2011 new procedure() interface. Reset irs->idx_to_fv after calling
2013 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
2014 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
2016 (destroy_initial_run_state) Don't dereference irs after freeing
2018 (allocate_cases) Don't calculate case_size locally.
2019 (compare_record) Add idx_to_fv parameter.
2020 (compare_record_run) Change parameter from struct sort_cases_pgm *
2021 to struct initial_run_state *. Pass irs->idx_to_fv to
2023 (compare_record_run) Third parameter now a struct
2024 initial_run_state *.
2025 (output_record) No need for out_case anymore. Pass irs, not
2026 struct sort_cases_pgm to pop_heap(). Use case_size from struct
2028 (merge) Use case_size from struct sort_cases_pgm.
2029 (merge_once) Use case_size from struct sort_cases_pgm.
2030 Pass null pointer to compare_record() as idx_to_fv.
2031 (global var sort_sink_class) Make static.
2033 * t-test.q: (cmd_t_test) Use procedure_with_splits().
2035 * temporary.c: Remove debugging crap.
2037 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
2039 * t-test.q, levene.c: Fixed up the handling of MISSING values
2042 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
2044 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
2047 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
2049 Change explicit variable name checks into use of
2050 dict_class_from_id().
2052 * dictionary.c: (dict_create_var) Change explicit variable name
2053 check into use of dict_class_from_id().
2055 * get.c: (trim_dictionary) Ditto.
2057 * sel-if.c: (cmd_filter) Ditto.
2059 * sysfile-info.c: (cmd_display) Ditto.
2061 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
2063 * vfm.c: (arrange_compaction) Ditto.
2065 * weight.c: (cmd_weight) Ditto.
2067 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
2069 * temporary.c: (cmd_temporary) When TEMPORARY was the first
2070 transformation following the input program, if any, for some
2071 reason we special-cased f_trns. That's just wrong. It should
2072 always be set to n_trns.
2074 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
2076 * format.c: (parse_format_specifier_name) Fix brown-bag bug
2077 introduced in last check-in.
2079 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
2081 * format.c: (global array translate_fmt[]) Removed.
2082 (translate_fmt) New function as replacement.
2083 (parse_format_specifier_name) Rewrite.
2085 * pfm-read.c: (convert_format) Use translate_fmt() instead of
2088 * sfm-read.c: (parse_format_spec) Ditto.
2090 * postscript.c: (text) Fix handling of fonts with missing
2093 * sort.c: (struct external_sort) Add temp_name member.
2094 (destroy_external_sort) Free temp_dir, temp_name members.
2095 (init_external_sort) Allocate temp_name.
2096 (get_temp_file_name) Change prototype.
2097 (open_temp_file) Deal with change to get_temp_file_name().
2098 (close_temp_file) Ditto.
2099 (remove_temp_file) Ditto.
2100 (write_temp_file) Ditto.
2101 (read_temp_file) Ditto.
2102 (sort_sink_destroy) Removed.
2103 (sort_sink_class) Change destroy member to null.
2105 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
2107 Eliminate temp_case.
2109 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
2110 anymore. Use agr_11x_finish().
2111 (aggregate_single_case) Make first param const.
2112 (accumulate_aggregate_info) Ditto.
2113 (agr_00x_end_func) Use compaction_case, not temp_case.
2114 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
2116 * data-list.c: (struct data_list_pgm) Add `case_size' member.
2117 (cmd_data_list) Initialize case_size.
2118 (read_from_data_list_fixed) Add struct ccase * param, use instead
2120 (read_from_data_list_free) Ditto.
2121 (read_from_data_list_list) Ditto.
2122 (read_one_case) Rename data_list_trns_proc(), all references
2123 updated. Add argument in calling above functions. Use c
2124 argument instead of temp_case.
2125 (destroy_dls) Rename data_list_trns_free(), all references
2128 * expr-evl.c: (expr_evaluate) Make second parameter const.
2130 * file-type.c: (struct file_type_pgm) Add `case_size' member.
2131 (cmd_end_file_type) Initialize `case_size'.
2132 (file_type_source_read) Add struct ccase * parameter. Use instead
2135 * flip.c: Rewritten.
2137 * get.c: (struct get_pgm) New structure to keep track of
2139 (cmd_get) Initialize case_size.
2141 (get_source) Deal with struct get_pgm.
2142 (get_source_read) Add struct ccase * parameter, use instead of
2144 (import_source_read) Ditto.
2146 * get.c: Use a null pointer instead of temp_case to represent the
2147 "current case" in a struct mtf_file's input member.
2148 (mtf_processing_finish) Pass null to mtf_processing(), not
2150 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
2151 (mtf_compare_BY_values) Add extra arg, use instead of null input
2153 (mtf_processing) Use c parameter instead of temp_case. Pass
2154 compaction_case to process_active_file_output_case().
2156 * glob.c: (global variable temp_case) Removed.
2158 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
2159 (cmd_input_program) Initialize case_size. Set
2160 vfm_source->value_cnt.
2161 (init_case) Add struct ccase * parameter, use instead of
2164 (input_program_source_read) Ditto.
2166 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
2167 (dump_cell_content) Ditto.
2168 (nr_output_data) Ditto.
2169 (read_matrices_without_rowtype) Ditto.
2170 (matrix_data_read_with_rowtype) Ditto.
2171 (wr_read_splits) Ditto.
2172 (wr_output_data) Ditto.
2174 * sort.h: (struct sort_cases_pgm) New member `case_size'.
2176 * sort.c: (sort_cases) Initialize scp->case_size.
2177 (struct external_sort) Remove `case_size' member.
2178 (write_initial_runs) Only call vfm_sink->class_destroy if
2180 (struct sort_source_aux) New structure.
2181 (sort_source_read_helper) New function.
2182 (sort_source_read) Use sort_source_read_helper().
2183 (read_sort_output) Change interface to be more reasonable.
2184 (read_internal_sort_output) Ditto.
2185 (read_external_sort_output) Ditto.
2187 * vars-prs.c: (dict_class_to_name) Pass return value through
2190 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
2191 (procedure) Initialize trns_case.
2192 (procedure) Pass trns_case to vfm_source->class->read().
2194 (process_active_file) Start using struct procedure_aux_data.
2195 (process_active_file_write_case) Pass trns_case to
2196 transformations, lag_case(), clear_case().
2197 (process_active_file_output_case) Add struct ccase * parameter.
2198 (create_trns_case) New function.
2199 (make_temp_case) Removed.
2200 (vector_initialization) Removed.
2201 (close_active_file) Only call make_source if non-null, otherwise
2202 set vfm_source to null pointer. Don't free temp_case.
2203 (disk_source_read) Add struct ccase * parameter, use instead of
2205 (memory_source_read) Ditto.
2206 (lag_case) Add const struct ccase * member.
2207 (procedure_write_case) Use trns_case instead of temp_case.
2208 (clear_case) Add struct ccase * member, use instead of temp_case.
2209 (exclude_this_case) Ditto.
2210 (create_case_source) Add struct dictionary * parameter, use to
2211 initialize source->value_cnt.
2213 * vfm.h: (struct case_source) Add `value_cnt' member.
2214 (struct case_source_class) Add struct ccase * parameter to `read'
2215 member function pointer.
2216 (struct case_sink_class) Make struct ccase * parameter const in
2217 `write' member function pointer.
2219 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
2221 Fix a lot of "possibly uninitialized variable" warnings. Some of
2222 them are even real bugs. A few of them make me wonder how the
2225 * aggregate.c: (parse_aggregate_functions) Initialize `function.
2227 * ascii.c: (output_lines) Add default case to switch.
2229 * crosstabs.q: Remove static variable `expected' and all
2231 (display_crosstabulation) Always calculate expected value.
2233 (output_pivot_table) Initialize `cmp'.
2234 (display_crosstabulation) New variable `last_row', which is
2237 * data-in.c: (parse_numeric) Always initialize sign. How did this
2240 * data-list.c: (repeating_data_trns_proc) Always initialize code.
2241 Always set info.ofs. (How did this work?!)
2243 * expr-opt.c: (optimize_tree) Always initialize `m'.
2244 (evaluate_tree) Always initialize `c'. (How did this work?)
2246 * frequencies.q: (frq_custom_variables) Always initialize min,
2248 (frq_custom_grouped) Always initialize `dl'.
2250 * groff-font.c: (groff_read_font) Always initialize char_set.
2252 * matrix-data.c: (nr_output_data) Initialize `split'.
2253 (wr_read_splits) Remove shadowing split_cnt declaration.
2254 (wr_output_data) Initialize `split'.
2256 * output.c: (tokener) Skip add character on syntax error.
2258 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
2260 * postscript.c: (read_ps_encodings) Use line.string instead of
2262 (write_text) Add default case to switch.
2263 (text) Always initialize multiple variables. Fix bug with
2266 * print.c: (fixed_parse_fortran) Initialize head.
2267 (alloc_line) Add default case to switch.
2269 * recode.c: (parse_dest_spec) Handle case where nothing matches.
2270 (recode_trns_proc) Move variable declaration inward. Add default
2273 * sfm-read.c: (read_header) Initialize skip_amt.
2275 * sysfile-info.c: (display_variables) Always initialize pc.
2277 * vars-prs.c: Initialized `included'.
2279 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
2281 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
2282 Just use signal() instead.
2284 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
2286 Get rid of vfm_sink_info and vfm_source_info.
2288 * aggregate.c: (agr_00x_end_func) Don't increment
2289 sfm_sink_info.ncases.
2291 * sort.c: (do_internal_sort) Get case count from
2292 vfm_source->class->count().
2293 (struct external_sort) Add `case_size' member.
2294 (do_external_sort) Initialize case_size.
2295 (struct initial_run_state) Add `case_size' member.
2296 (write_initial_runs) Initialize case_size.
2297 (sort_sink_write) Use case_size.
2298 (read_external_sort_output) Use case_size. Get case_cnt from
2301 * vfm.c: (struct write_case_data) Add underscores to existing arg
2302 names, all references updated. Renamed `aux' as `func_aux', all
2303 references updated. Added new `aux' member.
2304 (global var vfm_source_info) Removed.
2305 (global var vfm_sink_info) Removed.
2306 (struct procedure_aux_data) New.
2307 (struct split_aux_data) New.
2308 (procedure) Use `aux' fields for procedure_aux_data,
2310 (process_active_file_write_case) Pass case_count + 1 to
2311 transformation procedures, exclude_this_case().
2312 (process_active_file_output_case) Don't increment
2313 vfm_sink_info.ncases.
2314 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
2315 to send data to disk early.
2316 (make_temp_case) Don't use vfm_sink_info.case_size.
2317 (close_active_file) Don't initialize vfm_source_info.
2318 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
2319 (disk_sink_create) Initialize and/or update disk_stream_info.
2320 (disk_sink_write) Ditto.
2321 (disk_sink_destroy) Ditto.
2322 (disk_sink_make_source) Ditto.
2323 (disk_source_read) Ditto.
2324 (disk_source_destroy) Ditto.
2325 (global var disk_source_class) Add disk_source_count().
2326 (disk_source_count) New function.
2327 (struct memory_sink_info) Add `case_cnt', `case_size' members.
2328 (struct memory_source_info) Ditto.
2329 (memory_sink_create) Deal with case_cnt, case_size.
2330 (memory_sink_write) Ditto.
2331 (memory_sink_make_source) Ditto.
2332 (memory_source_read) Ditto.
2333 (memory_source_count) New function.
2334 (memory_source_class) Add memory_source_count().
2335 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
2336 proc_aux->cases_written, and pass it to transformation procedures
2337 and exclude_this_case ().
2338 (exclude_this_case) Add case_num parameter. Pass it to
2340 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
2343 * vfm.h: (struct case_source_class) Add `count' member.
2345 * vfmP.h: (struct stream_info) Removed.
2346 (global variable vfm_source_info) Removed.
2347 (global variable vfm_sink_info) Removed.
2349 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
2351 * var.h: (typedef trns_proc_func) New typedef.
2352 (trns_free_func) New typedef.
2353 (struct trns_header) Change `proc' to type trns_proc_func, `free'
2354 to type trns_free_func. This only changes the actual type of
2355 trns_proc_func, adding a `case_num' parameter. Updated all
2356 implementations to use the typedefs instead.
2358 * compute.c: (compute_num) Pass case_num to expr_evaluate().
2359 (compute_num_vec) Ditto.
2360 (compute_str) Ditto.
2361 (compute_str_vec) Ditto.
2363 * do-if.c: (do_if_trns_proc) Ditto.
2365 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
2368 * inpt-pgm.c: (input_program_source_read) Maintain case count,
2369 pass to transformation functions.
2370 (reread_trns_proc) Pass case_num arg to expr_evaluate().
2372 * loop.c: (loop_1_trns_proc) Ditto.
2373 (loop_2_trns_proc) Ditto.
2374 (loop_3_trns_proc) Ditto.
2376 * print.c: (print_space_trns_proc) Ditto.
2378 * sel-if.c: (select_if_proc) Ditto.
2380 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
2382 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
2383 destroying hash table.
2385 * glob.c: (read_active_file) Variable not referenced, removed.
2386 (cancel_input_pgm) Ditto.
2388 * levene.c: Add #include <stdlib.h> needed to call free().
2390 * aggregate.c: (parse_aggregate_functions) Make `function'
2393 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
2395 Start working to eliminate VFM dependence on static variables.
2397 * command.c: (cmd_parse) Use case_source_is_class().
2399 * data-list.c: Rewrite to eliminate use of static variables.
2401 * dfm.c: (cmd_begin_data) Use case_source_is_class().
2403 * file-handle.q: (fh_handle_name) Make parameter const.
2405 * file-type.c: Rewrite to eliminate use of static variables.
2407 * flip.c: Rewrite to eliminate use of static variables.
2409 * format.c: (get_format_var_width) New function.
2411 * get.c: Eliminate use of static variables.
2413 * inpt-pgm.c: Eliminate use of static variables.
2415 * matrix-data.c: Eliminate use of static variables.
2417 * set.q: (set_max_workspace) New variable.
2418 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
2420 * var.h: (struct case_list) Move here from vfmP.h.
2422 * vars-atr.c: (discard_variables) Handle new vfm_source type.
2424 * vfm.c: (vfm_source) Change type from struct case_stream to
2426 (vfm_sink) Change type from struct case_stream to struct
2428 (static var paging) Rename workspace_overflow, all references
2430 (procedure) Use new class structures.
2431 (process_active_file) Ditto.
2432 (process_active_file_write_case) Ditto.
2433 (prepare_for_writing) Use set_max_workspace. Use new class
2435 (close_active_file) Use new class structures. Free old sink.
2436 (global var disk_source_file) Removed.
2437 (global var disk_sink_file) Removed.
2438 (disk_stream_init) Removed.
2439 (disk_stream_read) Removed.
2440 (disk_stream_write) Removed.
2441 (disk_stream_mode) Removed.
2442 (disk_stream_destroy_source) Removed.
2443 (disk_stream_destroy_sink) Removed.
2444 (global var vfm_disk_stream) Removed.
2445 (disk_sink_create) New function.
2446 (disk_sink_write) New function.
2447 (disk_sink_destroy) New function.
2448 (disk_sink_make_source) New function.
2449 (disk_sink_class) New static var.
2450 (disk_source_read) New function.
2451 (disk_source_destroy) New function.
2452 (global var vfm_source_class) New var.
2453 (global var memory_source_cases) Removed.
2454 (global var memory_sink_cases) Removed.
2455 (global var memory_sink_max_cases) Removed.
2456 (struct memory_sink_info) New struct.
2457 (memory_stream_init) Removed.
2458 (memory_stream_read) Removed.
2459 (memory_stream_write) Removed.
2460 (memory_stream_mode) Removed.
2461 (memory_stream_destroy_source) Removed.
2462 (memory_stream_destroy_sink) Removed.
2463 (global var vfm_memory_stream) Removed.
2464 (page_to_disk) Renamed write_active_file_to_disk().
2465 (memory_sink_create) New function.
2466 (memory_sink_write) New function.
2467 (memory_sink_destroy) New function.
2468 (memory_sink_make_source) New function.
2469 (memory_sink_class) New static var.
2470 (memory_source_read) New function.
2471 (memory_source_destroy) New function.
2472 (memory_source_get_cases) New function.
2473 (memory_source_set_cases) New function.
2474 (global var vfm_source_class) New var.
2475 (procedure_write_case) Use new class structures.
2476 (create_case_source) New function.
2477 (case_source_is_complex) New function.
2478 (case_source_is_class) New function.
2479 (create_case_sink) New function.
2481 * vfm.h: (global variable reinit_sysmis) Not used, removed.
2482 (global variable reinit_blanks) Not used, removed.
2483 (global variable init_zero) Not used, removed.
2484 (global variable init_blanks) Not used, removed.
2485 (struct case_source) New struct.
2486 (struct case_source_class) New struct.
2487 (struct case_sink) New struct.
2488 (struct case_sink_class) New struct.
2489 (struct case_stream) Removed.
2491 * vfmP.h: (struct case_list) Moved to var.h.
2493 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
2495 * algorithm.c: (count_equal) New function.
2496 (count_if) New function.
2497 (unique) Add assertions.
2498 (partition) Add assertions.
2499 (is_partitioned) New function.
2500 (copy_if) Add assertions.
2501 (remove_equal) Add assertions.
2502 (lexicographical_compare) Rename lexicographical_compare_3way.
2503 (sort) Add assertions. Rephrase some code.
2504 (is_sorted) New function.
2506 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
2510 * sort.c: Completely rewrite.
2512 * sort.h: Expose interface via struct sort_cases_pgm, not via
2515 * aggregate.c: (sort) New static var.
2516 (cmd_aggregate) Use sort.
2517 (create_sysfile) Ditto.
2518 (aggregate_single_case) Ditto.
2519 (dump_aggregate_info) Ditto.
2520 (agr_00x_end_func) Ditto.
2521 (debug_print) Ditto.
2523 * var.h: (enum SRT_ASCEND) Removed.
2524 (enum SRT_DESCEND) Removed.
2525 (struct sort_cases_proc) Removed.
2526 (struct variable) Remove p.srt member.
2528 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
2530 Get rid of the old, crappy heap structure and replace it by a new,
2531 shiny, C++ STL-like heap structure.
2533 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
2535 * algorithm.c: (push_heap) New function.
2546 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
2548 Increase warning level.
2550 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
2552 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
2554 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
2556 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
2558 * dictionary.c: (dict_create_var) Fix root cause of bug worked
2559 around by previous change log entry.
2561 * compute.c: (lvalue_finalize) Remove workaround from previous
2564 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2566 * compute.c: Fixed a bug where the Format was not getting set for
2567 computed variables (thus causing a crash when SAVEing).
2569 * Added a test to stop this bug ever coming back
2571 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
2573 Got rid of approx.h. In general, replaced all references to
2574 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
2577 * Makefile.am: (pspp_SOURCES) Removed approx.h.
2579 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
2580 test for mag < EPSILON.
2582 * misc.h: Add definition of EPSILON.
2584 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
2586 * vfm.c: (procedure) Add check to prevent recursive call.
2588 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
2590 * Moved the declarations relating to values to their own header file
2593 * Added levene.c and levene.h
2595 * vars-atr.c: Changed the signature of compare_values to
2596 take const * arguments.
2598 * t-test.q: Changed the structure of struct t_test_proc
2599 variables now contain their own group statistics information.
2600 Eventually, t_test_proc might get renamed, because it'd be
2601 applicable to other commands too.
2603 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
2605 * data-out.c: Clean up. Changed interface of convert_*() to take
2606 either a `double' or a `const char *' instead of a `const union
2607 value *'. Update all implementations of those interfaces.
2608 (data_out) Use switch statements instead of a table.
2609 (convert_AHEX) Rewrite.
2611 * format.h: Update comment.
2613 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
2615 * q2c.c: (dump_header) Add an Emacs header line to output files
2616 that makes generated .c files read-only by default, to make it
2617 difficult to accidentally change generated files.
2619 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
2621 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
2622 not bogus a->v.c <=> b->v.c pointer compare.
2623 (compare_freq_alpha_a) Ditto.
2624 (compare_freq_numeric_d) Ditto.
2625 (compare_freq_alpha_d) Ditto.
2627 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
2629 Changed data_out() to store string data directly into a `union
2630 value''s s member, not indirectly into c.
2632 * crosstabs.q: (output_pivot_table) Use format_short() instead of
2634 (table_value_missing) Ditto.
2635 (float_M_suffix) Ditto.
2636 (format_short) New function.
2638 * data-in.h: (data_in_finite_line) Remove inline definition.
2640 * data-list.c: (destroy_dls_var_spec) New function.
2641 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
2642 (data_list_source_destroy_source) Avoid cast.
2643 (struct repeating_data_trns) New field `id_value'. Update
2645 (cmd_repeating_data) Initialize id_value. Use new
2646 repeating_data_trns_free() for freeing REPEATING DATA
2648 (rpd_parse_record) Rewrite support for record ID to be less bogus.
2649 (repeating_data_trns_free) New function.
2651 * data-out.c: (data_out) Change return type to `void' by replacing
2652 error returns by writing a message into the output buffer.
2653 (convert_A) Read from v->s instead of v->c.
2654 (convert_AHEX) Ditto.
2656 * expr-evl.c: Update comment.
2657 (expr_evaluate) Add assertion in OP_STRING case.
2659 * format.h: (macro MAX_FORMATTED_LEN) New macro.
2661 * list.q: (list_cases) Update for new data_out() semantics.
2663 * print.c: (print_trns_proc) Ditto.
2665 * tab.c: (tab_value) Ditto.
2666 (tab_float) Avoid stupid cast.
2668 * var.h: Update comments.
2669 (macro MAX_STRING) New macro.
2670 (macro MAX_ELEMS_PER_VALUE) New macro.
2672 * vars-atr.c: (compare_values) New function.
2674 * vfm.c: (dump_splits) Update for new data_out() semantics.
2676 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
2678 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
2680 (struct crosstab) Rename v[] to vars[]. All references updated.
2681 (hash_table_entry) Replace the hash algorithm and fix a bug at the
2682 same time, which caused the hash value to depend only on a single
2683 value, not all of the variables' values.
2685 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
2687 Clean up struct dictionary's value_cnt usage.
2689 * dictionary.c: Add a function comment to each function.
2690 (struct dictionary) Rename value_cnt to next_value_idx, which more
2691 accurately reflects its meaning. All references updated.
2692 (dict_rename_vars) Add assertion.
2693 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
2695 (dict_get_case_size) New function.
2697 * aggregate.c: (create_sysfile) Use dict_get_case_size().
2699 * get.c: (mtf_read_nonactive_records) Ditto.
2701 * sort.c: (allocate_cases) Ditto.
2702 (write_initial_runs) Ditto.
2706 * vfm.c: (prepare_for_writing) Ditto.
2710 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
2712 Make vfm.c slightly less grotesque.
2714 * vfm.c: (filter_var) Removed.
2715 (filter_index) Removed.
2716 (FILTERED macro) Removed.
2717 (exclude_this_case) New function.
2718 (process_active_file_write_case) Use exclude_this_case() instead
2719 of FILTERED and inline tests.
2720 (procedure_write_case) Ditto.
2721 (setup_filter) Removed.
2722 (open_active_file) Don't call setup_filter().
2723 (close_active_file) Call dict_get_filter() instead of checking
2726 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
2728 * var.h: (struct variable) Update comments.
2730 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
2732 New functions dict_create_var_assert(), dict_lookup_var_assert().
2733 Converted several dict_*_var()/assert pairs into a single
2734 dict_*_var_assert().
2736 * dictionary.c: (dict_create_var_assert) New function.
2737 (dict_lookup_var_assert) New function.
2739 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
2741 Got rid of "struct long_vec", envector(), devector(), etc. Added
2742 two members `init', `reinit' to struct variable as a substitute.
2744 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
2750 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
2753 * autorecode.c: (cmd_autorecode) destvars don't need init.
2755 * compute.c: (lvalue_finalize) Set reinit.
2757 * data-list.c: (fixed_parse_compatible) Don't need init usually.
2758 (dump_fmt_list) Ditto.
2761 * descript.q: (run_z_pass) Don't need init for z-scores.
2763 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
2765 (dict_clone_var) Copy `reinit' member, initialize `init' member.
2767 * glob.c: (init_glob) Remove vec_init() calls.
2769 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
2771 * loop.c: (internal_cmd_loop) Don't need to call envector().
2773 * numeric.c: (cmd_numeric) Ditto.
2775 (cmd_leave) Ditto. Set `init', `reinit' members.
2777 * recode.c: (cmd_recode) Don't need to call envector().
2779 * repeat.c: (internal_cmd_do_repeat) Ditto.
2781 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
2782 (force_create_variable) Removed prototype.
2783 (force_dup_variable) Ditto.
2785 * vector.c: (cmd_vector) Don't need to call envector().
2787 * vfm.c: (reinit_sysmis) Removed.
2788 (reinit_blanks) Removed.
2789 (init_zero) Removed.
2790 (init_blanks) Removed.
2791 (process_active_file_write_case) No need to deal with vectors.
2792 Call clear_temp_case().
2793 (vector_initialization) Rewrite to use `init', `reinit'.
2794 (close_active_file) No need to call vec_clear().
2795 (procedure_write_case) Call clear_temp_case().
2796 (clear_temp_case) New function.
2798 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
2800 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
2803 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
2805 Add auxiliary argument to procedure() interface. Associated small
2806 clean-ups of vfm interface.
2808 * Updated every caller of procedure() and process_active_file() to
2809 reflect modified interface. Simple, ordinary changes not listed
2812 * Updated every function that implements struct case_stream's
2813 `read' function to take a write_case_func and a write_case_data.
2814 Also updated every caller of write_case() to instead call them
2815 through these arguments. In some cases this meant that the extra
2816 args had to be threaded through a couple of extra levels. This
2817 wasn't difficult or interesting so the details won't be given.
2819 * data-list.c: (struct repeating_data_trns) Add members
2820 `write_case', `wc_data' as kluge.
2821 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
2823 (repeating_data_set_write_case) New function.
2825 * data-list.h: New file to declare repeating_data_trns_proc() and
2826 repeating_data_set_write_case().
2828 * inpt-pgm.c: (input_program_source_read) Call
2829 repeating_data_set_write_case() for all the REPEATING DATA
2830 transformations, so that they know where to send their cases.
2831 It's a big kluge. Also kluge in END CASE.
2832 (end_case_trns_proc) Never called anymore, but we still need it,
2835 * sort.c: (read_sort_output) Update to match struct case_stream
2838 * vfm.c: (struct write_case_data) New structure.
2839 (proc_func) Removed.
2840 (virt_proc_func) Removed.
2841 (begin_func) Removed.
2842 (virt_begin_func) Removed.
2844 (write_case) Removed.
2845 (procedure) Added an auxiliary parameter to each function pointer
2846 argument's prototype. Added an auxiliary data parameter.
2848 (process_active_file) Ditto.
2849 (process_active_file_write_case) Pass aux data along.
2850 (close_active_file) Ditto.
2851 (procedure_write_case) Ditto.
2852 (SPLIT_FILE_procfunc) Ditto.
2854 * vfm.h: (typedef write_case_data) New.
2855 (typedef write_case_func) New.
2856 (struct case_stream) Add parameters to `read' member prototype.
2858 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
2860 * t-test.q: Added calculations for independent samples. (But no Levene
2863 * Makefile.am: Moved q_sources_c into own variable
2865 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
2867 Miscellaneous cleanups.
2869 * Change unused to UNUSED in many source files to reflect modified
2870 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
2871 __CYGWIN32__, __unix__, and unix not to assume that they're
2872 defined to a nonzero value. Change use of __attribute__ to use
2873 NO_RETURN or PRINTF_FORMAT instead.
2875 * alloc.h: Move definitions for local_alloc(), local_free() here
2876 from ../pref.h.orig and simplify.
2878 * expr-evl.c: Instead of working differently based on PAGED_STACK,
2879 use a pool allocator unconditionally.
2880 (CHECK_STRING_SPACE) Removed.
2881 (ALLOC_STRING_SPACE) Removed.
2882 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
2885 * expr-opt.c: (dump_expression) Allocate string pool.
2887 * expr-prs.c: (expr_free) Free string pool.
2889 * pool.c: (pool_destroy) This pool must be removed from its
2890 parent's list of gizmos, not from its own. Use free_all_gizmos().
2891 (pool_clear) New function.
2892 (free_all_gizmos) New function.
2893 (pool_alloc) Use space in empty block after this one if any.
2894 (pool_release) Only empty out blocks, don't actually free() them.
2896 * print.c: Get rid of PAGED_STACK special case by always
2897 dynamically allocating line buffers.
2898 (struct print_trns) Always include the `line' member.
2899 (internal_cmd_print) Always initialize the `line' member.
2900 (alloc_line) Always allocate memory for `line'.
2901 (print_trns_proc) Always initialize buf from `line' member.
2902 (print_trns_free) Always free `line' memory.
2904 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
2907 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
2909 * flip.c: Fixed crash from FLIP when a numeric variable is
2910 specified on NEWNAMES and a large value is used, and a couple of
2911 other minor bugs besides.
2912 (struct varname) Make name a 9-character fixed-size array
2913 instead of a 1-character variable size array.
2914 (make_new_var) Allow digits in variable names.
2915 (flip_stream_write) Limit numeric values to 8 characters and
2916 format system missing and very large and small values more
2919 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2921 * command.c: Fixed test on command return status for the correct
2922 value, which had been causing a crash under certain invalid input.
2924 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2926 * t-test.q: Added calculations for the one sample variant of the T-TEST
2928 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
2930 * tab.c: (render_strip) Fix bug that sometimes caused joined text
2931 in joined cells to be rendered outside box boundaries.
2933 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2935 * random.c (rng_create): Fixed seeding so that it gets reseeded after
2936 SET seed=xx has been called.
2938 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
2940 * random.c (rng_get_double): Fix always-returning-zero bug in my
2941 preferred way, and at the same time make sure rounding doesn't
2944 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
2946 * html.c: (change_attributes) Dead code, removed.
2947 (escape_string) Eliminate code to call change_attributes() that
2948 never actually called it.
2949 (output_tab_table) Get rid of dependence on tab_hit
2950 and struct tab_joined_cell's hit member, which are abominations.
2952 * tab.c: (tab_output_text) Don't call
2953 d->class->text_set_font_by_name if it's a null pointer.
2954 (macro UNROLL_LOOP) Eliminate.
2955 (macro UNROLL_3_LOOPS) Eliminate.
2956 (tabi_render) Rewrite not to use the above macros.
2958 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
2960 Start working on a new output driver system, one that doesn't suck
2961 so much, by adding a "device-independent" output driver. The idea
2962 is to write out only a single output stream, then use separate
2963 processes to translate them into whatever formats we want. This
2964 is similar to how "groff" works with its various output drivers
2965 (grops, grotty, grodvi, ...).
2967 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
2969 * list.q: (write_all_headers) Stub out devind class.
2971 (determine_layout) Ditto.
2974 * output.c: (outp_init) Add devind class.
2976 * devind.c: New file.
2978 * devind.h: New file.
2980 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
2982 * frequencies.q: (hash_value_alpha) Fixed up the previous change
2983 to use the proper string length.
2985 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
2987 * Fixed bug where FREQ would crash on alpha values
2989 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
2991 * Removed bletcherous alloca() workarounds for AIX from top of
2992 many files. AIX can use the alternative alloca() implementation
2995 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
2997 * ascii.c: (ascii_option) Fix implementation of headers option.
2999 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
3001 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
3002 multiple blank lines into one.
3003 (struct ascii_driver_ext) Add squeeze_blank_lines option.
3004 (ascii_preopen_driver) Initialize squeeze_blank_lines.
3005 (static var option_tab) Add squeeze entry.
3006 (ascii_option) Set squeeze_blank_lines.
3007 (output_lines) Implement squeezing blank lines.
3009 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
3011 * Removed redundant code from output.h
3013 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
3015 Dictionary classes: each variable is "ordinary", "system", or
3018 * var.h: (enum dict_class) New enum.
3020 * vars-prs.c: (dict_class_from_id) New function.
3021 (dict_class_to_name) New function.
3023 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
3025 * var.h: (struct freq_tab_set) Removed (not used).
3027 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
3029 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
3031 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
3033 * stats.c: (hypercube) Rename pow4(). All references updated.
3035 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
3037 * rename-vars.c: (cmd_rename_variables) Rewritten.
3038 (compare_name) Removed.
3040 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
3042 var_set feature, and code taking advantage of it.
3044 * crosstabs.q: (static var var_dict) Removed.
3045 (static var variables) New variable.
3046 (static var variables_cnt) New variable.
3047 (cmd_crosstabs) Free variables instead of var_dict.
3048 (internal_cmd_crosstabs) Initialize and use variables,
3049 variables_cnt instead of var_dict.
3050 (free_var_dict) Removed.
3051 (crs_custom_tables) Use var_set instead of a copied dictionary.
3052 (crs_custom_variables) Set up variables, variables_cnt instead of
3054 [DEBUGGING] (debug_print) Ditto.
3056 * means.q: (mns_custom_tables) Use var_set instead of a copied
3059 * vars-prs.c: (parse_vs_variable) New function.
3060 (parse_dict_variable) Rewritten.
3061 (parse_variable) Rewritten.
3062 (parse_variables) Renamed parse_var_set_vars(), rewritten.
3063 (parse_variables) New function in terms of parse_var_set_vars().
3064 Now requires its first argument to be non-null. All references
3065 that passed a null pointer updated to pass default_dict instead.
3066 (macro id_dict) Removed.
3067 (parse_DATA_LIST_vars) Add assertions.
3068 (parse_mixed_vars) Ditto.
3069 (struct var_set) New structure.
3070 (var_set_get_cnt) New function.
3071 (var_set_get_var) New function.
3072 (var_set_lookup_var) New function.
3073 (var_set_destroy) New function.
3074 (dict_var_set_get_cnt) New function.
3075 (dict_var_set_get_var) New function.
3076 (dict_var_set_lookup_var) New function.
3077 (dict_var_set_destroy) New function.
3078 (var_set_create_from_dict) New function.
3079 (struct array_var_set) New structure.
3080 (array_var_set_get_cnt) New function.
3081 (array_var_set_get_var) New function.
3082 (array_var_set_lookup_var) New function.
3083 (array_var_set_destroy) New function.
3084 (var_set_create_from_array) New function.
3086 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
3087 instead of parse_variables(NULL, ...) in output code.
3089 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
3091 Change inp_init from a 2-bit vector to an ordinary array.
3092 Initialize it all in cmd_end_input_program() instead of in
3095 * inpt-pgm.c: (enum value_init_type) New enum.
3096 (global var inp_init) Change to `enum value_init_type *', make
3098 (inp_init_size) Removed.
3099 (inp_nval) Change to `size_t', make static.
3100 (cmd_input_program) Don't initialize inp_init or inp_init_size.
3101 (cmd_end_input_program) Initialize inp_init, inp_nval.
3102 (init_case) Rewrite.
3103 (clear_case) Rewrite.
3105 * inpt-pgm.h: Removed.
3107 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
3109 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
3110 Colin Plumb hash. It is simpler and should better resist
3112 (hsh_hash_string) Ditto.
3114 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
3116 * get.c: (export_write_case_func) Remove debug printing code.
3118 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
3120 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
3122 (save_write_case_func) Use &trns->h instead of cast.
3123 (cmd_export) Use &t->h instead of cast.
3125 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
3127 Moved vectors into the dictionary.
3129 * var.h: (struct vector) Moved here from vector.h. `index' member
3130 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
3133 * vector.h: Removed.
3135 * vector.c: (global var vec) Removed.
3136 (global var nvec) Removed.
3137 (cmd_vector) Rewritten.
3138 (find_vector) Removed.
3140 * dictionary.c: (dict_create_vector) New function.
3141 (dict_get_vector) New function, replaces reading global vec[]
3143 (dict_get_vector_cnt) New function, replaces reading global nvec
3145 (dict_lookup_vector) New function, replaces find_vector().
3146 (dict_clear_vectors) New function.
3148 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
3150 Start to move away from `struct variable' p `union' member to void
3153 * var.h: (struct variable) Add `aux' member.
3155 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
3157 Get rid of struct variable `foo' member.
3159 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
3161 (frq_custom_variables) Ditto.
3162 (frq_custom_grouped) Ditto.
3164 * get.c: (struct save_trns) Change `var' member from `int *' to
3165 `struct variable **'.
3166 (cmd_save_internal) Use aux instead of foo.
3167 (save_trns_proc) Use revised `var' member.
3168 (static var mtf_seq_no) Renamed mtf_seq_num.
3169 (static var mtf_seq_nums) New static var.
3170 (cmd_match_files) Initialize mtf_seq_nums.
3171 (mtf_free) Free mtf_seq_nums.
3172 (mtf_processing) Use mtf_seq_nums instead of foo.
3173 (mtf_merge_dictionary) No need to initialize mv->foo.
3174 (cmd_export) Use aux instead of foo. Use revised `var' member.
3175 (mns_custom_tables) Don't use foo to check for duplicates, that's
3176 what PV_NO_DUPLICATE is for.
3178 * var.h: (struct variable) Remove `foo' member.
3179 (struct frequencies_proc) New member.
3181 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
3183 Clean up COMPUTE and IF.
3185 * compute.c: More or less rewrite the darn thing.
3186 (struct compute_trns) Rename and reorder and add and delete
3188 (cmd_compute) Rewrite.
3189 (compute_num) Make conditional on test expression. Now used for
3190 both COMPUTE and IF.
3191 (compute_num_vec) Ditto.
3192 (compute_str) Ditto.
3193 (compute_str_vec) Ditto.
3196 (if_num_vec) Removed.
3198 (if_str_vec) Removed.
3199 (parse_target_expression) Renamed parse_rvalue_expression(),
3201 (new_trns) Renamed compute_trns_create(), rewritten.
3202 (delete_trns) Removed.
3203 (free_trns) Renamed compute_trns_free(), rewritten.
3204 (struct lvalue) New structure.
3205 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
3206 (lvalue_get_type) New function.
3207 (lvalue_is_vector) New function.
3208 (lvalue_finalize) New function.
3209 (lvalue_destroy) New function.
3211 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
3213 * command.def: Disallow MODIFY VARS in input mode, so that
3214 variables can't get dropped and confuse cmd_end_input_program()'s
3215 attempt to fill inp_init[].
3217 * modify-vars.c: (static var forward_positional_ordering) New
3219 (struct var_modification) Entirely changed.
3220 (rearrange_dict) Interface changed, rewritten.
3221 (cmd_modify_vars) Deal with modified struct var_modification, much
3223 (struct var_renaming) New structure.
3224 (compare_var_renaming_by_new_name) New function.
3225 (validate_var_modification) New function.
3227 * var.h: (struct modify_vars_proc) Removed.
3228 (struct variable) Removed member p.mfv.
3230 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
3232 Make EVALUATE a valid command whether we're debugging or not, so
3233 that `make check' can succeed regardless of whether debugging is
3236 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
3238 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
3240 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
3242 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
3243 statement by a simple if test.
3245 * dfm.c: (dfm_get_record) Add assertion.
3247 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
3249 For each file x.c, move #include "x.h" to the very top of the
3250 include list, to catch x.h failing to include the proper headers.
3252 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
3254 * algorithm.c: (find) New function.
3255 (remove_equal) New function.
3256 (set_difference) New function.
3257 (adjacent_find_equal) New function.
3258 [TEST_UNIQUE] Removed test case.
3259 (copy_if) Find end test.
3261 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
3263 * dictionary.c: (dict_get_case_weight) New convenience function.
3265 * aggregate.c: (accumulate_aggregate_info) Use
3266 dict_get_case_weight().
3268 * frequencies.q: (calc_general) Ditto.
3269 (calc_integer) Ditto.
3272 * t-test.q: (groups_calc) Ditto.
3275 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
3277 * glob.c: (global var default_dict) Change from `struct
3278 dictionary' to `struct dictionary *'. All references changed.
3279 (init_glob) Initialize default_dict with dict_create().
3281 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
3283 struct dictionary now made opaque. All related functions:
3285 * get.c: (rename_variables) Removed.
3286 (dict_delete_run) Removed.
3288 * temporary.c: (copy_variable) Removed.
3289 (new_dictionary) Removed.
3290 (save_dictionary) Removed.
3291 (restore_dictionary) Removed.
3292 (free_dictionary) Removed.
3294 * vars-atr.c: (clear_default_dict) Removed.
3295 (find_variable) Removed.
3296 (find_dict_variable) Removed.
3297 (create_variable) Removed.
3298 (delete_variable) Removed.
3299 (common_init_stuff) Removed.
3300 (init_variable) Removed. Updating of inp_init moved into
3301 cmd_end_input_program().
3302 (replace_variable) Removed.
3303 (rename_variable) Removed.
3304 (clear_variable) Removed.
3305 (dup_variable) Removed.
3307 * vars-prs.c: (is_varname) Removed.
3308 (is_dict_varname) Removed.
3309 (fill_all_vars) Removed.
3311 * vector.c: (find_vector) Removed.
3313 * weight.c: (stop_weighting) Removed.
3315 * dictionary.c: New file.
3316 (dict_create) New, replaces new_dictionary().
3317 (dict_clone) New, replaces save_dictionary() and
3318 restore_dictionary().
3319 (dict_clear) New, replaces clear_default_dict().
3320 (dict_destroy) New, replaces free_dictionary().
3321 (dict_get_var_cnt) New function, replaces references to
3323 (dict_get_var) New function, replaces references to dict->var[i].
3324 (dict_get_vars) New function, replaces fill_all_vars().
3325 (dict_create_var) New, replaces create_variable(). Interface
3326 drops `type' parameter, using a zero `width' to designate numeric.
3327 (dict_clone_var) New, replaces dup_variable().
3328 (dict_rename_var) New, replaces rename_variable().
3329 (dict_lookup_var) New, replaces find_variable(),
3330 find_dict_variable(), is_varname().
3331 (dict_contains_var) New function.
3332 (compare_variable_dblptrs) New function.
3333 (dict_delete_var) New function, replaces clear_variable().
3334 (dict_delete_vars) New function, replaces dict_delete_run().
3335 (dict_reorder_vars) New function.
3336 (dict_rename_vars) New function, replaces rename_variables().
3337 (dict_get_weight) New function, replaces reading dict->weight_var.
3338 (dict_set_weight) New function, replaces writing dict->weight_var
3339 or calling stop_weight(dict).
3340 (dict_get_filter) New function, replaces reading dict->filter_var.
3341 (dict_set_filter) New function, replaces writing dict->filter_var.
3342 (dict_get_case_limit) New function, replaces reading dict->N.
3343 (dict_set_case_limit) New function, replaces writing dict->N.
3344 (dict_get_value_cnt) New function, replaces reading dict->nval.
3345 (dict_compact_values) New function, replaces a loop that was
3346 replicated in several places.
3347 (dict_get_split_vars) New function, replaces reading dict->splits.
3348 (dict_get_split_cnt) New function, replaces reading
3350 (dict_set_split_vars) New function, replaces writing dict->splits.
3351 (dict_get_label) New function, replaces reading dict->label.
3352 (dict_set_label) New function, replaces writing dict->label.
3353 (dict_get_documents) New function, replaces reading
3355 (dict_set_documents) New function, replaces writing
3358 All references to above functions updated.
3360 * aggregate.c: (cmd_aggregate) Copy file label and documents from
3361 old dictionary to new by hand, because dict_create() can't do it
3362 itself. Use dict_set_documents(), dict_set_split_vars().
3364 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
3365 calling dict_destroy().
3367 * data-list.c: (dls_var_spec) Remove `type' member, replace by
3369 (fixed_parse_compatible) Some slightly nontrivial changes for
3371 (dump_fmt_list) Ditto.
3374 * file-type.c: (create_col_var) Ditto.
3376 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
3377 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
3378 (rename_variables) Use dict_rename_vars().
3379 (mtf_merge_dictionary) Use dict_get_documents(),
3380 dict_set_documents(), dict_compact_values().
3382 * pfm-read.c: (read_variables) Deal with changes to weighting.
3384 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
3385 is_varname() in output code.
3387 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
3388 other dictionary functions.
3390 * title.c: (add_document_line) Use dict_get_documents(),
3391 dict_set_documents().
3393 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
3394 reset default_handle by hand. dict_clear() will clear vectors so
3395 there's no need for that by hand.
3397 * vfm.c: (close_active_file) Move call to finish_compaction()
3398 earlier, so that we can do the compaction as a single step using
3399 dict_compact_values(). Use dict_clear_vectors().
3400 (finish_compaction) Use dict_delete_var(), dict_compact_values().
3402 Some functions don't have replacements:
3404 * vars-atr.c: (force_create_variable) Removed. All references
3405 updated to dict_create_var() followed by an assertion.
3406 (force_dup_variable) Removed. All references updated to
3407 dict_clone_var() followed by an assertion.
3409 * weight.c: (update_weighting) Removed. No longer necessary, so
3410 all references removed.
3412 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
3416 * aggregate.c: Eliminate separation of weighted and unweighted
3417 case. It made the code too obscure and I doubt it was actually
3418 faster. Instead, all code uses the "weighted" code, because
3419 that's a generalization of the "unweighted" code.
3422 (parse_aggregate_functions) No need to set FWEIGHT.
3423 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
3424 (dump_aggregate_info) Ditto.
3425 (initialize_aggregate_info) No need for special plain_function
3426 that gets rid of FWEIGHT option.
3428 * aggregate.c: Get rid of approximations.
3429 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
3431 (aggregate_single_case) Don't use approx_ne().
3433 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
3435 * ascii.c (ascii_line_width): Dead code, removed.
3437 * postscript.c (ps_line_width): Ditto.
3439 * q2c.c (xrealloc): Ditto.
3441 * count.c (internal_cmd_count): Ditto.
3443 * means.q (validate_dependent_endpoint): Ditto.
3445 * set.q: (cmd_gset) Ditto.
3447 * weight.c: [0] (weight_trns_proc) Ditto.
3449 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
3451 Make the code -Wmissing-prototypes clean.
3453 * Makefile.am (version.c): Add #include "version.h".
3455 * ascii.c: (ascii_open_global) Make static.
3456 (ascii_close_page) Ditto.
3457 (ascii_font_sizes) Ditto.
3458 (ascii_postopen_driver) Ditto.
3459 (ascii_close_driver) Ditto.
3460 (ascii_option) Ditto.
3461 (ascii_open_page) Ditto.
3462 (ascii_line_horz) Ditto.
3463 (ascii_line_vert) Ditto.
3464 (ascii_line_intersection) Ditto.
3466 (ascii_polyline_begin) Ditto.
3467 (ascii_polyline_point) Ditto.
3468 (ascii_polyline_end) Ditto.
3469 (ascii_text_set_font_by_name) Ditto.
3470 (ascii_text_set_font_by_position) Ditto.
3471 (ascii_text_set_font_by_family) Ditto.
3472 (ascii_text_get_font_name) Ditto.
3473 (ascii_text_get_font_family) Ditto.
3474 (ascii_text_set_size) Ditto.
3475 (ascii_text_get_size) Ditto.
3476 (ascii_text_metrics) Ditto.
3477 (ascii_text_draw) Ditto.
3478 (ascii_close_page) Ditto.
3480 * cmdline.h: New header for parse_command_line(). Used where
3483 * command.c: Move prototypes for cmd_*() functions to command.h.
3485 * command.h: Prototypes for cmd_*() functions moved here from
3488 * crosstabs.q: (gamma_int) Ditto.
3490 * file-handle.h: Add fh_init_files() prototype.
3492 * getline.c: (welcome) Ditto.
3494 * glob.h: New header for init_glob(). Used where appropriate.
3496 * hash.c: (comparison_helper) Ditto.
3498 * html.c: (html_open_global) Ditto.
3499 (html_close_global) Ditto.
3500 (html_preopen_driver) Ditto.
3501 (html_postopen_driver) Ditto.
3502 (html_close_driver) Ditto.
3503 (html_option) Ditto.
3504 (html_open_page) Ditto.
3505 (html_close_page) Ditto.
3506 (html_submit) Ditto.
3508 * inpt-pgm.c: (input_program_source_read) Ditto.
3510 * output.c: (find_defn_value) Ditto.
3511 (destroy_list) Ditto.
3513 * pfm-read.c: (read_int) Ditto.
3515 * postscript.c: (ps_open_global) Ditto.
3516 (ps_close_global) Ditto.
3517 (ps_font_sizes) Ditto.
3518 (ps_preopen_driver) Ditto.
3519 (ps_postopen_driver) Ditto.
3520 (ps_close_driver) Ditto.
3522 (ps_open_page) Ditto.
3523 (ps_close_page) Ditto.
3524 (ps_line_horz) Ditto.
3525 (ps_line_vert) Ditto.
3526 (ps_line_intersection) Ditto.
3528 (ps_polyline_begin) Ditto.
3529 (ps_polyline_point) Ditto.
3530 (ps_polyline_end) Ditto.
3531 (ps_text_set_font_by_name) Ditto.
3532 (ps_text_set_font_by_position) Ditto.
3533 (ps_text_set_font_family) Ditto.
3534 (ps_text_get_font_name) Ditto.
3535 (ps_text_get_font_family) Ditto.
3536 (ps_text_set_size) Ditto.
3537 (ps_text_get_size) Ditto.
3538 (ps_text_metrics) Ditto.
3539 (ps_text_draw) Ditto.
3541 * q2c.c: (finish_up) Ditto.
3550 (find_symbol) Ditto.
3553 (force_string) Ditto.
3555 (match_token) Ditto.
3558 (parse_setting) Ditto.
3559 (parse_specifier) Ditto.
3560 (parse_specifiers) Ditto.
3561 (parse_subcommand) Ditto.
3562 (dump_specifier_vars) Ditto.
3564 (make_identifier) Ditto.
3565 (dump_declarations) Ditto.
3566 (dump_specifier_init) Ditto.
3567 (dump_vars_init) Ditto.
3569 (dump_specifier_parse) Ditto.
3570 (dump_subcommand) Ditto.
3571 (dump_parser) Ditto.
3572 (dump_header) Ditto.
3574 (recognize_directive) Ditto.
3576 * recode.c: (string_to_long) Ditto.
3578 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
3580 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
3583 * sort.c: (sort_stream_read) Ditto.
3584 (sort_stream_mode) Ditto.
3586 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
3588 * algorithm.c (binary_search): Fix comparison.
3590 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
3592 * algorithm.c: (binary_search) Fix assertion.
3594 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
3596 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
3598 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
3600 * sort.c: (compare_case_lists) Rewrite.
3602 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
3604 * quicksort.c: Removed (not used).
3606 * quicksort.h: Removed (not used).
3608 * sort.c: Removed blp_quicksort() prototype.
3610 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
3612 * postscript.c: (int_2_compare) Rewrite.
3613 (compare_line) Rewrite.
3615 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
3617 * matrix-data.c (compare_factors) Use lexicographical_compare()
3619 (compare_doubles) New function.
3621 * algorithm.c: (lexicographical_compare) New algorithm.
3623 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
3625 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
3627 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
3629 * expr-prs.c: (cmp_func) Removed.
3630 (parse_function) Use binary_search() algorithm.
3631 (compare_functions) New function.
3632 (init_func_tab) Use sort() algorithm.
3634 * algorithm.c: (binary_search) New algorithm.
3636 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
3638 * descript.q: (display) Use sort() algorithm instead of qsort().
3639 (compare_func) Removed.
3640 (descriptives_compare_variables) New function.
3642 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
3644 Get rid of AVL trees. Hashes are more appropriate for everything
3647 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
3653 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
3655 Much code can be clarified by using C++ STL-like algorithms. Not
3656 all uses of these algorithms are listed below, only the ones where
3657 the change to an algorithm was the only change of interest.
3659 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
3661 * algorithm.c: New file.
3663 * algorithm.h: New file.
3665 * modify-vars.c: (static var forward) Removed.
3666 (static var positional) Removed.
3667 (compare_variables) Removed.
3668 (struct ordering) New.
3669 (cmd_modify_vars) Use sort() algorithm.
3670 (compare_variables_given_ordering) New function.
3671 (rearrange_dict) Use sort() algorithm.
3673 * sysfile-info.c: (cmd_display) Use sort() algorithm.
3674 (cmp_var_by_name) Removed.
3676 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
3678 Make file handles use a hash table.
3680 * file-handle.q: (files) Change to hash table, make static.
3681 (cmd_file_handle) Use hash table functions.
3682 (fh_get_handle_by_filename) Ditto.
3683 (fh_get_handle_by_name) Ditto.
3684 (hash_file_handle) New function.
3685 (cmp_file_handle) Rewrite.
3686 (fh_init_files) Use hash table functions.
3688 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
3690 Clean up FREQUENCIES.
3692 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
3694 * frequencies.q: Remove a lot of old #if'd out code at the end.
3695 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
3696 or calc_weight(). Initialize percentile_values.
3697 (calc) New function based on calc_weight() from frequencies.g.
3698 (precalc) Use hash functions.
3699 (static var comparison_func) Removed.
3700 (static var comparison_param) Removed.
3701 (comparison_helper) Removed.
3702 (get_freq_comparator) New function.
3703 (not_missing) New function.
3705 (postprocess_freq_tab) Use hash table functions, algorithms,
3706 get_freq_comparator(). Rewrite.
3707 (cleanup_freq_tab) Rephrase.
3708 (add_percentile) Clean up spacing.
3709 (hash_value_numeric) New function.
3710 (hash_value_alpha) New function.
3711 (compare_value_numeric_a) Rewrite.
3712 (compare_value_alpha_a) Rewrite.
3713 (compare_value_numeric_d) Rewrite.
3714 (compare_value_alpha_d) Rewrite.
3715 (compare_freq_numeric_a) Rewrite.
3716 (compare_freq_alpha_a) Rewrite.
3717 (compare_freq_numeric_d) Rewrite.
3718 (compare_freq_alpha_d) Rewrite.
3719 (calc_stats) Clean up mode, percentiles, max.
3720 (dump_statistics) Clean up spacing.
3722 * frequencies.g: Removed.
3724 * var.h: (struct freq_tab) Change `data' to hash table.
3726 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
3728 * file-handle.h: Remove declaration of global variable `files',
3729 which wasn't used anywhere.
3731 * postscript.c: (add_encoding) Remove superfluous cast.
3734 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
3737 * temporary.c: [0] (display_tree) Removed.
3739 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
3741 Implement a new random number generator based on the alleged RC4
3744 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
3747 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
3748 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
3750 (static var V[]) Removed.
3751 (static var Y) Removed.
3752 (static var X2) Removed.
3753 (setup_randomize) Removed.
3755 (rand_uniform) Removed.
3756 (rand_normal) Removed.
3757 (struct rng) New structure.
3758 (rng_create) New function.
3759 (rng_destroy) New function.
3760 (swap_byte) New static function.
3761 (rng_seed) New function.
3762 (rng_get_bytes) New function.
3763 (rng_get_int) New function.
3764 (rng_get_unsigned) New function.
3765 (rng_get_double) New function.
3766 (rng_get_double_normal) New function.
3767 (pspp_rng) New function.
3769 * random.h: Sync up to random.c.
3771 * sample.c: (struct sample_trns) Make `frac' unsigned and a
3772 fraction of UINT_MAX, not 65536.
3773 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
3776 * vfm.c: (open_active_file) No need to call setup_randomize() any
3779 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
3781 Change dictionary name indexes to use hash tables instead of AVL
3784 * crosstabs.q: (free_var_dict) Use hash tables.
3785 (crs_custom_tables) Ditto.
3786 (calc_general) Ditto.
3787 (compare_table_entry) Rewrite.
3788 (enum_var_values) Reorder parameters. All references updated.
3791 * get.c: (rename_variable) Use hash tables.
3792 (mtf_merge_dictionary) Ditto.
3794 * glob.c: (init_glob) Use hash tables.
3795 (cmp_variable) Removed.
3797 * means.q: (mns_custom_tables) Use hash tables.
3799 * modify-vars.c: (rearrange_dict) Use hash tables.
3801 * rename-vars.c: (cmd_rename_variables) Use hash tables.
3803 * sfm-read.c: (read_header) Use hash tables.
3804 (read_variables) Ditto.
3806 * temporary.c: (new_dictionary) Use hash tables.
3807 (save_dictionary) Ditto.
3808 (restore_dictionary) Ditto.
3810 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
3811 hash table `name_tab'.
3813 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
3814 [DEBUGGING] (dump_var_tree) Removed.
3815 (find_variable) Use hash tables.
3816 (find_dict_variable) Ditto.
3817 (common_init_stuff) Ditto.
3818 (rename_variable) Ditto.
3819 (clear_variable) Ditto. Also, remove debug code.
3820 (dup_variable) Use hash tables.
3822 * vars-prs.c: (fill_all_vars) Use hash tables.
3823 (is_dict_varname) Ditto.
3824 (parse_dict_variable) Ditto.
3826 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
3828 Change value labels to use hash tables instead of AVL trees, and
3829 change value labels into an ADT.
3831 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
3833 * value-labels.c: New file.
3835 * value-labels.h: New file.
3837 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
3838 Get rid of a stupid use of goto.
3840 * autorecode.c: (compare_alpha_value) Rewrite.
3841 (hash_alpha_value) Ditto.
3842 (compare_numeric_value) Rewrite.
3843 (hash_numeric_value) Ditto.
3845 * frequencies.q: (dump_full) Use value label ADT.
3847 * pfm-read.c: (read_value_label) Use value label ADT.
3849 * pfm-write.c: (write_value_labels) Use value label ADT.
3851 * sfm-read.c: (read_variables) Use value label ADT.
3852 (read_value_labels) Rewrite.
3854 * sfm-write.c: (write_value_labels) Rewrite.
3856 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
3857 (display_variables) Ditto.
3858 (describe_variable) Ditto.
3860 * t-test.q: (print_t_groups) Use value label ADT.
3862 * temporary.c: (copy_variable) Use value label ADT.
3863 (free_dictionary) Ditto.
3865 * val-labs.c: (verify_val_labs) Use value label ADT.
3867 (debug_print) Ditto.
3868 (val_lab_cmp) Removed.
3869 (inc_ref_count) Removed.
3870 (copy_value_labels) Removed.
3872 * var.h: (struct value_label) Removed.
3873 (struct variable) Change AVL tree `val_lab' into hash table
3876 * vars-atr.c: (init_variable) Use value label ADT.
3877 (clear_variable) Ditto.
3878 (free_value_label) Removed.
3879 (free_val_lab) Removed.
3880 (get_val_lab) Removed.
3881 (compare_variables) New function.
3882 (hash_variable) New function.
3884 * vfm.c: (dump_splits) Use value label ADT.
3886 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
3888 Add to the hash table interface.
3890 * hash.c: (hsh_hash_bytes) Add assertion.
3891 (hsh_hash_string) Ditto.
3895 (hsh_create) Ditto. Also make minimum `size'.
3896 (hsh_destroy) Rephrase.
3897 (sort_nulls_last) Removed.
3898 (not_null) New function.
3900 (comparison_helper) Ditto.
3901 (hsh_sort) Rewritten.
3902 (hsh_data_copy) New function.
3903 (hsh_sort_copy) Ditto.
3905 (hsh_replace) Ditto.
3906 (hsh_hash_double) Ditto.
3907 (hsh_delete) Fix stupid bug.
3909 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3910 * added a calculation of the mode to FREQUENCIES
3912 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3914 * moved (un)defs of DEBUGGING to config.h
3916 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
3918 * groff-font.c: (add_kern) Fix indentation.
3919 (add_kern) Use & instead of % to take power-of-2 modulus.
3920 (font_get_kern_adjust) Likewise.
3922 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
3924 * autorecode.c: (recode) Replace stupid use of memcpy() by
3926 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
3927 (hash_numeric_value) Ditto.
3928 (autorecode_proc_func) pool_strdup() was wrong here because the
3929 source string was not null-terminated. Use new pool_strndup()
3932 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
3933 use of hsh_iterator_init().
3935 * data-in.c: (parse_N) Initialize i->v->f.
3937 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
3940 * groff-font.c: Use power-of-2 hash table sizes, not prime.
3941 (groff_read_font) Don't call hsh_next_prime(). Don't call
3943 (static var hash) Remove `size_p', `max_used' members.
3944 (font_char_name_to_index) Don't call hsh_next_prime(). Use
3945 hsh_hash_string() instead of hashpjw(), & instead of %.
3946 (default_font) Don't call hsh_next_prime().
3948 * pool.c: (pool_strndup) New function.
3949 (pool_strdup) Reimplement in terms of pool_strndup.
3951 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
3953 (hash_ps_encoding) Use hsh_hash_string().
3954 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
3955 (hash_filename2font) Use hsh_hash_string().
3957 * som.c: Add #include <stdlib.h>.
3959 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
3960 (by destroying its pool).
3962 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
3964 Miscellaneous hash table code cleanup:
3966 * hash.h: (struct hsh_table) Moved into hash.c.
3967 (hsh_count) Ditto, and transformed into function.
3968 (hsh_compare_func) New typedef, used for defining otherwise-long
3969 function types here and in hash.c
3970 (hsh_hash_func) Ditto.
3971 (hsh_free_func) Ditto.
3973 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
3974 `table' to `entries'. Removed `mp'. All references updated.
3975 (hsh_clear) Don't shrink entries array; if the hash was this big
3976 once, it probably will be again.
3977 (hsh_rehash) Made static.
3978 (force_hsh_insert) Renamed hsh_force_insert.
3979 (force_hsh_find) Renamed hsh_force_find.
3981 Made hash table sizes powers of 2, because that's fine with any
3982 reasonable hash function and because taking a power-of-2 modulus
3983 is faster than any other:
3985 (hsh_prime_tab) Removed;
3986 (hsh_next_prime) Ditto.
3987 (next_power_of_2) New function.
3988 (hsh_create) Use next_power_of_2.
3989 (hsh_rehash) Use & instead of %.
3991 Cleaned up hsh_sort:
3993 (internal_comparison_fn) Removed.
3994 (sort_nulls_last) New function.
3995 (hsh_sort) Removed second parameter, switched to using the new
3996 quicksort() function from quicksort.h to avoid using nasty need
3997 for static variables with qsort(). All references updated.
3999 Changed the hash functions offered, because there are better hash
4000 functions than the ones we had, and cleaned up the names to boot:
4002 * hash.c: (hashpjw_d) Removed.
4004 (hsh_hash_bytes) New function.
4005 (hsh_hash_string) New function.
4006 (hsh_hash_int) New function.
4008 Improved the hash table iteration interface:
4010 * hash.h: (hsh_iterator_init) Removed.
4011 (struct hsh_iterator) Removed `init' member, change `next' to
4014 * hash.c: (hsh_foreach) Removed. All references updated to use
4015 hsh_first/hsh_next instead.
4016 (hsh_first) New function. Notably, unlike hsh_foreach() it does
4017 not treat a null pointer as an empty hash table.
4018 (hsh_next) New function.
4020 Made deletion possible, though slow:
4022 * hash.c: (locate_matching_entry) New function.
4023 (hsh_find) Use locate_matching_entry().
4024 (hsh_delete) New function also using locate_matching_entry().
4025 (hsh_force_delete) New function.
4027 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
4029 * quicksort.c: New file implementing a sort routine with a
4030 interface better than qsort() because it passes a user-provided
4031 parameter to the sort routine.
4033 * Makefile.am: Add quicksort.c, quicksort.h.
4035 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
4037 * All source files: Get rid of nasty special cases for Checker,
4038 which is pretty obsolete now.
4040 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
4042 * Fixed a bug apparent when using the FREQUENCIES command with the
4043 html driver. The html driver was incorrectly trying to display
4046 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
4048 * Makefile.am: Reorganized. Put locale dir in version.c instead
4049 of passing it to each compile command. Only put local gmp libs in
4050 LD_ADD if not installed on system. Remove `boast' target.
4052 * All source files: struct and union typedefs eliminated.
4053 `sizeof type' replaced by `sizeof object' where practical. Moved
4054 `unused' qualifiers from start to end of declarations for gcc
4055 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
4056 assertions on pointers strictly compliant. Removed _ prefixes on
4057 some function parameter names.
4059 * alloc.c: New source file, containing these external linkage
4060 functions removed from common.c: xmalloc, xcalloc, xrealloc,
4067 * ascii.c: Migrated from arenas to pools.
4068 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
4069 c_string to len_string. All references changed.
4070 (ascii_option) Signature changed to comply to new output.c
4072 (count_fancy_chars) Removed.
4073 (delineate) Removed support for rich text.
4074 (ascii_text_metrics) Ditto.
4076 (output_shorts) Change `box', `off', `on' from c_string to
4077 len_string. Change `remaining' from int to size_t.
4078 (ascii_close_page) Make page numbering less haphazard.
4080 * autorecode.c: Migrate from arenas to pools.
4082 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
4084 * bitvector.h: New file containing these macros from misc.h:
4085 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
4087 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
4088 word[3]. ncmd removed.
4089 (var empty_string) Removed.
4090 (var cmd_table) Declaration updated.
4091 (var cmdtab) Removed.
4092 (cmp_command) Removed.
4093 (split_words) Rewritten to use strtok_r().
4094 (init_cmd_parser) Renamed cmd_init(). Rewritten.
4095 (find_command) Removed.
4096 (FILE_TYPE_okay) Rewritten.
4097 (cmd_parse) Rewritten. Semantics of the return value of command
4098 handlers has changed: they must now return one of the new CMD_*
4099 enumerals, rather than a magic value. This meant that all
4100 commands had to be modified, and they were.
4101 (figure_out_command) New function.
4103 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
4104 #defines for INIT, INPU, etc.
4106 * command.h: New CMD_* enum series.
4107 (cur_proc) Make const char *, not char *.
4108 (cmd_init) Prototype.
4111 * common.c: Removed.
4113 * common.h: Removed.
4115 * correlations.q: New file.
4117 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
4119 (custom_tables) Renamed crs_custom_tables().
4120 (custom_variables) Renamed crs_custom_variables().
4121 (calc_integer) Add in some `const' qualifiers.
4122 (table_value_missing) Change from a_string to len_string.
4123 (float_M_suffix) Change from a_string to len_string.
4125 * data-in.c: Rewritten. All references to
4126 parse_string_as_format() changed to data_in().
4128 * data-in.h: New file.
4130 * data-list.c: Change DLS_* from #define's to enums. Move from
4131 rpd_msg() to tmsg().
4132 (RPD_ERR) New #define.
4133 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
4135 (read_from_data_list_fixed) Change from old
4136 parse_string_as_format() to new data_in().
4137 (read_from_data_list_free) Ditto.
4138 (read_from_data_list_list) Ditto.
4139 (cmd_repeating_data) Modify approach to checking for end of
4142 (rpd_parse_record) Change from old parse_string_as_format() to new
4143 data_in(). Change from old convert_format_to_string() to new
4145 (read_one_set_of_repetitions) Change dfm_push_cust() to
4146 dfm_push(), pop_cust() to dfm_pop().
4148 * data-out.c: Rewritten. All references to
4149 convert_format_to_string() changed to data_out().
4151 * descript.q: Migrate to new q2c.
4152 (cmd_descriptives) Removed.
4153 (internal_cmd_descriptives) Renamed cmd_descriptives ().
4154 (custom_variables) Renamed dsc_custom_variables().
4156 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
4158 (open_file_r) Initialize h->where.line_number. Migrate to new
4160 (open_file_w) Initialize h->where.line_number.
4161 (read_record) Change from ext->ln to h->where.line_number.
4162 Migrate to struct string.
4163 (dfm_put_record) Rephrased.
4164 (dfm_push_cust) Renamed dfm_push(), rewritten.
4165 (dfm_pop) New function.
4167 * error.c: All references updated.
4168 (glob var error_count) Renamed err_err_count.
4169 (glob var warning_count) Renamed err_warning_count.
4170 (glob var error_already_flagged) Renamed err_already_flagged.
4171 (glob var verbosity) Renamed err_verbosity.
4172 (glob var cust_fn) Removed.
4173 (glob var cust_ln) Removed.
4174 (static var file_loc) New.
4175 (static var nfile_loc) New.
4176 (static var mfile_loc) New.
4177 (tmsg) New function.
4178 (push_cust) Removed.
4181 (static var terminating) Removed.
4182 (failure) Renamed err_failure().
4183 (hcf) Renamed err_hcf().
4184 (err_push_file_locator) New function.
4185 (err_pop_file_locator) New function.
4186 (err_location) New function.
4187 (check_error_count) Renamed err_check_count().
4188 (vmsg) Renamed err_vmsg(). Interface changed.
4189 (verbose_msg) Removed.
4190 (err_cond_fail) New function.
4191 (error_break) Renamed err_break().
4193 * error.h: All references updated.
4194 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
4195 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
4197 (struct file_locator) New.
4199 (macro verbose_msg) Removed.
4200 (macro cond_fail) Removed.
4202 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
4204 * expr-prs.c: Reorganized. All references updated.
4205 (exprtypename) Renamed expr_type_name().
4206 (typename) Renamed type_name().
4207 (free_expression) Renamed expr_free().
4208 (parse_expression) Renamed expr_parse(). Uses new type_check()
4210 (init_functab) Renamed init_func_tab().
4211 (type_check) New function.
4212 (parse_or) Rewritten to use new allocate_nonterminal() and
4213 append_nonterminal_arg() functions.
4216 (parse_rel) Ditto. Also simplified logic.
4221 (SYSMIS_func) Ditto.
4222 (VALUE_func) Rephrased.
4223 (CONCAT_func) Fix memory leak by replacing free by free_node on
4225 (generic_str_func) Ditto.
4226 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
4228 (allocate_nonterminal) New function.
4229 (append_nonterminal_arg) New function.
4230 (static func_tab[]) Now at file level.
4232 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
4234 * expr.h: (enum series OP_*) Moved to exprP.h.
4235 (OP_* defines) Ditto.
4236 (struct op_desc) Ditto.
4237 (global ops[]) Ditto.
4238 (struct num_con_node) Ditto.
4239 (struct str_con_node) Ditto.
4240 (struct var_node) Ditto.
4241 (struct lag_node) Ditto.
4242 (struct casenum_node) Ditto.
4243 (struct nonterm_node) Ditto.
4244 (union any_node) Members renamed.
4245 (struct sys_node) Removed.
4246 (struct val_node) Removed.
4247 (operator typedef) Removed.
4248 (typedef exprtype) Removed.
4249 (enum series EX_*) Moved to exprP.h.
4250 (struct expression) Ditto. Also renamed a lot of the members.
4251 (PXP_* defines) Changed to enums.
4252 (free_node prototype) Moved to exprP.h.
4254 * file-handle.h: (struct file_handle) New member `where'.
4256 * file-handle.q: Migrated to new q2c format.
4257 (prepend_current_directory) Removed (dead code).
4258 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
4259 (fh_get_handle_by_filename) Removed dead code.
4260 Set new `where' member.
4262 * file-type.c: (file_type_source_read) References to
4263 parse_string_as_format() changed to data_in().
4264 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
4266 * filename.c: All references updated.
4267 (init_filename) Renamed fn_init().
4268 (expand_line) Removed.
4269 (macro EXPAND_LINE) Removed.
4270 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
4271 of custom functions.
4272 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
4273 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
4274 (normalize_filename) Renamed fn_normalize().
4275 (search_path) Renamed fn_search_path(), rewritten.
4276 (prepend_dir) Renamed fn_prepend_dir().
4277 (blp_getenv) Renamed fn_getenv().
4278 (blp_dirname) Renamed fn_dirname().
4279 (fn_basename) New function, not used.
4280 (absolute_filename_p) Renamed fn_absolute_p().
4281 (is_special_filename) Renamed fn_special_p().
4282 (file_exists) Renamed fn_exists_p().
4283 (readlink_malloc) Renamed fn_readlink().
4284 (getenv_default) Renamed fn_getenv_default().
4285 (open_file) Renamed fn_open().
4286 (close_file) Renamed fn_close().
4287 (open_file_ext) Renamed fn_open_ext().
4288 (close_file_ext) Renamed fn_close_ext().
4290 * font.h: Migrate from arenas to pools.
4292 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
4294 * frequencies.g: Migrate from arenas to pools.
4296 * frequencies.q: Migrate to new q2c version. Migrate from arenas
4299 * getline.c: All references updated.
4300 (global getl_buf) Changed from char * to struct string.
4301 (static getl_include_path) Ditto.
4302 (global getl_buf_len) Removed.
4303 (global getl_buf_size) Removed.
4304 (getl_include_path) Deal with new getl_buf, getl_include_path.
4305 (getl_uninitialize) New function.
4306 (getl_get_current_directory) Rewritten.
4307 (getl_clear_include_path) Rewritten.
4308 (getl_add_include_dir) Rewritten.
4309 (getl_add_file) Assertion fixed.
4310 (getl_add_virtual_file) Change initial value of `remaining_loops'
4312 (welcome) Rewritten.
4313 (handle_line_buffer) Make static. Change logic to make
4314 getl_add_virtual_file() change sensible. Use ds_*() strings.
4315 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
4316 (getl_close_file) Moved.
4317 (getl_location) New function.
4319 * getline.h: All references updated.
4320 (macro curln) Removed.
4321 (macro curfn) Removed.
4322 (macro am_interactive) Renamed getl_am_interactive.
4323 (macro am_reading_script) Renamed getl_reading_script.
4325 * glob.c: (global fmt_parse_ignore_error) Removed.
4326 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
4327 systems that support it (C99). Turn off SET ECHO by default. No
4328 necessary julcal initialization anymore.
4330 * groff-font.c: Migrate from arenas to pools.
4331 (groff_read_font) Use err_push_file_locator().
4332 (groff_read_DESC) Ditto.
4333 (font_msg) Use tmsg().
4335 * hash.c: (hsh_sort) Fix debug code.
4336 [GLOBAL_DEBUGGING] Include stdio.h.
4338 * hash.h: (macro force_hsh_insert) Rephrase.
4340 * heap.c: Rewritten.
4342 * heap.h: Rewritten.
4344 * html.c: (html_option) Change from outp_value to struct string.
4345 (postopen) Change from curfn to getl_location().
4346 (escape_string) Remove rich-text code. Signature changed.
4347 (output_tab_table) Switch from a_string to struct len_string.
4348 Remove rich text support.
4350 * lexer.c: All references updated. Largely rewritten. Major
4351 changes listed below. Removed tagged quote support. Adapted to
4352 struct string tokstr.
4353 (global tokstr) Changed to struct string.
4354 (global tokstr_size) Removed.
4355 (global tokstr_len) Removed.
4357 (global tokint) Removed.
4358 (global toklongstr) Removed.
4359 (C* defines) Removed.
4360 (static tbl[]) Removed.
4361 (static id[]) Removed.
4362 (static une[]) Removed.
4363 (discard_line) Renamed lex_discard_line().
4364 (get_entire_line) Renamed lex_entire_line().
4365 (get_rest_of_line) Renamed lex_rest_of_line().
4366 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
4367 (make_hexit) Removed.
4368 (syntax_error) Renamed lex_error(). Return value removed.
4369 (get_token_representation) Renamed lex_token_representation().
4370 (putback) Renamed lex_put_back().
4371 (putfwd) Renamed lex_put_forward().
4372 (convert_negative_to_dash) Renamed lex_negative_to_dash().
4373 (set_prog) Renamed lex_set_prog().
4374 (init_lex) Renamed lex_init().
4375 (reset_eof) Renamed lex_reset_eof().
4376 (lookahead) Renamed lex_look_ahead().
4377 (check_id) Rewritten.
4378 (yylex) Renamed lex_get(), rewritten.
4379 (lex_end_of_command) New function. Many commands were rephrased
4381 (lex_integer_p) New function. Replaces compare of tokint against
4383 (lex_integer) New function. Replaces tokint.
4384 (match_tok) Renamed lex_match().
4385 (match_id) Renamed lex_match_id().
4386 (match_int) Renamed lex_match_int().
4387 (force_match_id) Renamed lex_force_match_id(), added return value.
4388 (force_match) Renamed lex_force_match(), added return value.
4389 (force_string) Renamed lex_force_string(), added return value.
4390 (force_int) Renamed lex_force_int(), added return value.
4391 (lex_id_match_len) New function.
4392 (id_match) Renamed lex_id_match(), rewritten.
4393 (get_line) Renamed lex_get_line().
4394 (preprocess_line) Renamed lex_preprocess_line().
4395 (tokname) Renamed lex_token_name().
4396 (bin_value_func) Removed.
4397 (oct_value_func) Removed.
4398 (hex_value_func) Removed.
4399 (unexpected_eof) New function.
4400 (convert_numeric_string_to_char_string) New function.
4401 (parse_string) Rewritten, signature changed.
4402 (add_tokstr_char) Removed.
4403 (add_tokstr_unsigned) Removed.
4404 (add_tokstr_string) Removed.
4405 (parse_tagged_quote) Removed.
4406 (skip_comment) Renamed lex_skip_comment().
4408 * lexer.h: All references updated.
4409 (macro is_id1) Renamed CHAR_IS_ID1.
4410 (macro is_idn) Renamed CHAR_IS_IDN.
4411 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
4412 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
4413 (macro get_token) Removed.
4414 (macro id_match) Removed.
4415 (macro force_match_id) Removed.
4416 (macro force_match) Removed.
4417 (macro force_string) Removed.
4418 (macro force_int) Removed.
4419 (macro force_num) Removed.
4420 (macro force_id) Removed.
4422 * lexerP.h: Removed.
4424 * list.q: Migrated to new q2c format.
4425 (write_line) Deal with struct len_string.
4426 (write_varname) Ditto.
4427 (write_fallback_headers) Ditto.
4429 * magic.c: New file, incorporating the following global variables
4430 previously in other files: endian, second_lowest_value. And both
4431 of those are conditional on #define's.
4433 * magic.h: New file, incorporating the following global variable
4434 declarations: endian, second_lowest_value, and the following macro
4435 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
4437 * main.c: Added declarations of pgmname, finished, curdate,
4439 (main) Call new parse_script() function.
4440 (parse_script) New function.
4441 (execute_command) New function.
4442 (dump_token) Removed.
4443 (handle_error) New function.
4445 * matrix.c: New file.
4447 * matrix.h: New file.
4449 * matrix-data.c: Migrated from arenas to pools.
4450 (mget_token) Change from parse_string_as_format() to data_in().
4452 * means.q: Migrate to new q2c.
4453 (custom_tables) Renamed mns_custom_tables().
4454 (custom_crossbreak) Renamed mns_custom_crossbreak().
4455 (custom_variables) Renamed mns_custom_variables().
4457 * mis-val.c: (static var width) Changed from `int' to `size_t'.
4458 (parse_varnames) Prototype.
4459 (parse_numeric) Rephrasings.
4460 (parse_alpha) Adapt to new struct string tokstr.
4462 * misc.c: (intlog10) Rewritten.
4464 (ansi_rand) Renamed real_rand(), moved into random.c.
4465 (ansi_srand) Renamed real_srand(), moved into random.c.
4466 (setup_randomize) Moved to random.c.
4467 (rand_uniform) Ditto.
4468 (rand_normal) Ditto.
4469 (rand_simple) Ditto.
4470 (get_config_line) Removed.
4471 (reverse) Removed (dead code).
4473 * misc.h: (macro SET_BIT) Moved to bitvector.h.
4474 (macro CLEAR_BIT) Ditto.
4475 (macro TEST_BIT) Ditto.
4476 (macro SET_BIT_TO) Ditto.
4477 (macro BIT_INDEX) Ditto.
4479 * output.c: (outp_read_devices) Move to err_push_file_locator()
4480 from push_cust(). Use struct string.
4481 (expand_op_tokstr) Removed.
4482 (static var op_tokstr) Changed to struct string.
4483 (static var op_tokstr_size) Removed.
4484 (tokener) Rephrasings. Use struct string.
4485 (parse_options) Use struct string.
4486 (destroy_driver) Fix assertion.
4487 (outp_get_paper_size) Move to err_push_file_locator().
4488 [0] Removed dead code.
4489 (outp_string_width) Move to len_string.
4491 * output.h: Comment fixes.
4492 (TAG_* enum series) Removed.
4493 (struct outp_value) Removed.
4494 (enum OUTP_T_FANCY) Removed.
4495 (struct outp_text) `s' changed from a_string to len_string.
4496 (struct outp_class) `option' change arg 3 from outp_value to
4499 * pfm-read.c: (corrupt_msg) Rewritten.
4501 * pfm-write.c: (bufwrite) Fix assertion.
4503 * pool.c: New file, reference version.
4505 * pool.h: New file, reference version.
4507 * postscript.c: (ps_font_sizes) Fix assertion.
4508 (ps_option) Change arg 3 from outp_value to struct string.
4509 Adapt to struct string.
4510 (macro output_line) Removed.
4511 (macro add_string) Removed.
4512 (output_encodings) Adapted to struct string. Moved to
4513 err_push_file_locator().
4514 (find_encoding_file) Fix assertion.
4515 (read_ps_encodings) Move to err_push_file_locator().
4516 (postopen) Use getl_location() instead of curfn.
4517 (out_text_plain) Move to len_string.
4518 (text) Ditto. Remove rich text support.
4520 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
4521 (cmd_print_eject) Ditto.
4523 (internal_cmd_print) Now cleans up after itself. Uses
4524 fh_parse_file_handle() now.
4525 (cmd_print_space) Use PXP_NUMERIC to type-check.
4527 * q2c.c: Overhauled. Removed _("") i18n support. All references
4528 updated. All output functions updated to handle structures rather
4529 than local or static variables. Adapt to new PSPP lex_*()
4533 (macro MAX_N_SBC) Removed.
4534 (global bare) Removed.
4535 (enum STRING) Renamed T_STRING.
4536 (enum ID) Renamed T_ID.
4537 (get_buffer) Buffer size increased.
4538 (strlower) Renamed st_lower(), rephrased.
4539 (strupper) Renamed st_upper(), rephrased.
4540 (skip_ws) New function.
4541 (get_line) Don't special-case any types of lines (like those
4542 beginning with ! or $, for instance).
4543 (get_token) Renamed lex_get(). Rephrased.
4544 (static var `prefix') New.
4545 (parse) New function.
4546 (parse_setting) Minor rephrasing.
4547 (dump_specifier_vars) Ditto.
4548 (make_identifier) Put null terminator on identifier, duh.
4549 (dump_vars) Renamed dump_declarations(). Never indent. Never
4550 static. Output changed entirely.
4551 (dump_specifier_init) Rephrase.
4552 (dump_vars_init) No index variable needed. Other modifications.
4553 (dump_parser) Don't parse command name. Do dump functions instead
4554 of just code fragments.
4555 (dump_free) Dump function instead of code fragment.
4556 (recognize_directive) New function.
4557 (main) Use recognize_directive(). Don't rely on magic $ line
4558 beginning: instead, parse comments. Update list of headers.
4560 * random.c: New file, containing the following functions:
4561 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
4562 rand_normal, rand_simple.
4564 * random.h: New file.
4566 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
4567 function. `max_src_width', `max_dst_width' changed to size_t.
4568 (internal_cmd_recode) Removed.
4569 (parse_dest_spec) Merge similar cases.
4570 (parse_src_spec) Add assertion.
4572 * repeat.c: (recognize_keyword) New function.
4573 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
4574 REPEAT. Improve recognition of END REPEAT (use
4575 recognize_keyword()). Move from curfn to getl_location(). Use
4578 (perform_DO_REPEAT_substitutions) Adapt to struct string.
4580 * set.q: Adapt to new q2c.
4581 (cmd_set) Range-check some values better.
4582 (custom_blanks) Renamed stc_custom_blanks().
4583 (custom_length) Renamed stc_custom_length().
4584 (custom_results) Renamed stc_custom_results().
4585 (custom_seed) Renamed stc_custom_seed().
4586 (custom_width) Renamed stc_custom_width().
4587 (custom_format) Renamed stc_custom_format().
4588 (custom_journal) Renamed stc_custom_journal().
4589 (custom_color) Renamed stc_custom_color().
4590 (custom_listing) Renamed stc_custom_listing().
4591 (custom_disk) Renamed stc_custom_disk().
4592 (custom_log) Renamed stc_custom_log().
4593 (custom_rcolor) Renamed stc_custom_rcolor().
4594 (custom_viewlength) Renamed stc_custom_viewlength().
4595 (custom_workdev) Renamed stc_custom_workdev().
4597 * settings.h: Not necessary to include format.h any longer.
4599 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
4600 (corrupt_msg) Rewritten.
4602 * sort.c: Adapt to rewritten heap ADT.
4604 * str.c: (aa_strcpy) Removed.
4605 (ab_strcpy) Removed.
4606 (ac_strcpy) Removed.
4607 (ba_strcpy) Removed.
4608 (bb_strcpy) Removed.
4609 (ca_strcpy) Removed.
4610 (aa_strdup) Removed.
4611 (aa_strdupcpy) Removed.
4612 (ba_strdup) Removed.
4613 (sa_strdup) Removed.
4614 (memrev) Renamed mm_reverse().
4615 (memrmem) Renamed mm_find_reverse().
4616 (cmp_str) Renamed st_compare_pad().
4617 (strmaxcpy) Removed.
4618 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
4619 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
4621 (strpadcpy) Renamed st_pad_copy(), signature changed.
4622 (blpstrset) Removed.
4623 (ds_create) New function.
4624 (ds_init) New function.
4625 (ds_replace) New function.
4626 (ds_destroy) New function.
4627 (ds_clear) New function.
4628 (ds_extend) New function.
4629 (ds_shrink) New function.
4630 (ds_truncate) New function.
4631 (ds_length) New function.
4632 (ds_size) New function.
4633 (ds_value) New function.
4634 (ds_end) New function.
4635 (ds_concat) New function.
4636 (ds_concat_buffer) New function.
4637 (ds_printf) New function.
4638 (ds_putchar) New function.
4639 (ds_getline) New function.
4640 (ds_get_config_line) New function derived from the old
4641 misc.c:get_config_line().
4642 (ls_create) New function.
4643 (ls_create_buffer) New function.
4644 (ls_init) New function.
4645 (ls_shallow_copy) New function.
4646 (ls_destroy) New function.
4647 (ls_null) New function.
4648 (ls_null_p) New function.
4649 (ls_empty_p) New function.
4650 (ls_length) New function.
4651 (ls_value) New function.
4652 (ls_end) New function.
4654 * str.h: Reformatted.
4655 (struct a_string) Removed.
4656 (struct b_string) Removed.
4657 (struct c_string) Removed.
4658 (struct len_string) New.
4659 (struct string) New.
4660 (macro as_streq) Removed.
4661 (macro bs_streq) Removed.
4662 (macro cs_streq) Removed.
4663 (macro sa_streq) Removed.
4664 (macro sb_streq) Removed.
4665 [__GNUC__] (inline function ds_putchar) New function.
4666 [__GNUC__] (inline function ds_length) New function.
4667 [__GNUC__] (inline function ds_value) New function.
4668 [__GNUC__] (inline function ds_end) New function.
4670 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
4671 (display_vectors) Fix missing i18n.
4673 * t-test.q: Migrate to new q2c.
4675 * tab.c: Migrate from arenas to pools.
4676 (tab_create) Use struct len_string.
4677 (tab_realloc) Ditto.
4678 (text_format) Ditto.
4679 (tab_joint_text) Ditto.
4680 (tab_natural_width) Remove rich text support.
4681 (tab_natural_height) Ditto.
4682 (tab_output_text) Handle TAT_FIX.
4683 (tab_raw) Change arg from a_string to len_string.
4684 (tabi_driver) Fix assertion. Use struct len_string.
4685 (render_strip) Use struct len_string. Remove rich text support.
4686 Add `const' qualifiers.
4688 * tab.h: (enum TAB_RICH) Remove.
4689 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
4690 SOM_COL_* updated to read TAB_COL_*.
4691 (struct tab_table) Change arena to pool. Change a_string to
4694 * temporary.c: (restore_dictionary) Rewrite Checker code.
4696 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
4697 LOWEST, HIGHEST) Moved here from common.h.
4698 (typedef any_trns) Removed. All references changed to `struct
4701 * vars-atr.c: (force_create_variable) Fix assertion.
4702 (force_dup_variable) Fix assertion.
4704 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
4706 Using alphanumeric variables in functions under AGGREGATE
4707 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
4708 <BZN-mdksh@t-online.de> for reporting this bug.
4710 * aggregate.c: (parse_aggregate_functions) When setting the
4711 FSTRING bit, also allocate memory for the `string' member of
4713 (free_aggregate_functions) Free iter->string. Don't use the
4714 non-function bits when indexing the array of functions.
4715 [DEBUGGING] (debug_print) Don't use the non-function bits when
4716 indexing the array of functions.
4718 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
4720 Under certain circumstances, the final case would be omitted from
4721 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
4722 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4724 * aggregate.c (agr_00x_end_func): Increment number of cases in
4725 sink before writing case. For streams that keep track of how many
4726 cases there are based on this value, this means that the last case
4727 will be read in on the next stream read.
4729 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
4731 Undefined behavior was invoked by referencing a freed pointer.
4733 * vfm.c (memory_stream_write): Free pointer *after* checking for
4736 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
4738 A wrong record size was displayed when paging the active file to
4741 * vfm.c: (memory_stream_write) Fix off-by-one error.
4743 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
4745 Not having enough temporary space for sorting caused a core dump.
4748 * sort.c: (allocate_cases) Initialize i.
4750 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
4752 Syntax errors in function descriptions on AGGREGATE caused core
4755 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
4756 free_aggregate_functions(), since that function already frees
4759 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
4761 A null pointer was dereferenced, causing a core dump, when
4762 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
4763 but PSPP still doesn't calculate percentiles. Thanks to Regnor
4764 Jernsletten <rjernsle@eunet.no> for reporting this problem.
4766 * arena.c: (arena_malloc) If the arena hasn't been initialized
4767 already, initialize it.
4769 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
4771 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
4772 for compilation with Cygnus Windows B20. Not used by other
4775 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
4777 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
4778 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4780 * sort.c: (compare_case_lists) Reverse sense of comparison if
4781 sorting in descending order.
4782 (compare_record) Ditto.
4784 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
4786 SPLIT FILE with a string variable caused a core dump. Fixed.
4788 * vfm.c: If the variable is a string then make a temporary value
4789 struct pointing to it. The underlying problem is a lot bigger
4790 than this (see TODO) but this is a stopgap for the simple case at
4793 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
4795 Nested INCLUDEs didn't work. Fixed.
4797 * getline.c: (getl_include) Set first_line to NULL in allocated
4800 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
4802 The MATCH FILES procedure set the values of variables not present
4803 to 0. It should have been SYSMIS. This is now fixed.
4805 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
4807 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
4809 The REMARK command was too aggressive about skipping lines. It
4810 didn't like being the last command in a file.
4812 * command.c: (cmd_remark) Call get_entire_line() instead of
4815 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
4817 Comment parsing wasn't consistent with the rest of the code in its
4818 idea of where one command ends and another starts. This meant
4819 that sometimes commands would be mysteriously ignored. Thanks to
4820 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4822 * command.c: (parse_cmd) Hand off comment parsing to new function
4823 skip_comment() in lexer.c.
4824 * lexer.c: (skip_comment) New function.
4826 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
4828 The TABLE subcommand on MATCH FILES worked only erratically at
4829 best. This fixes it. Thanks to Dr. Dirk Melcher
4830 <BZN-mdksh@t-online.de> for reporting this bug.
4832 * get.c: (mtf_compare_BY_values) When comparing string values, a
4833 difference of 1 is still a difference :-)
4834 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
4835 advance TABLE files automatically when matched. Comment fixes.
4837 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
4839 VARIABLE LABELS rejected a slash before the first variable
4840 specification, contradicting the documentation. Thanks to Walter
4841 M. Gray <graywm@northernc.on.ca> for reporting this bug.
4843 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
4844 command specification.
4846 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
4848 Because of an incorrect optimization in memory allocation,
4849 CROSSTABS sometimes segfaulted when asked to output multiple
4850 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4853 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
4854 are passed to output_pivot_table() for its use.
4855 (output_pivot_table) Instead of assuming the number of columns is
4856 constant, keep track with maxcols. In general mode, use maxcells
4857 to determine whether more matrix cells need to be allocated.
4859 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
4861 CROSSTABS didn't display value labels for column and row
4862 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4865 * crosstabs.q: (table_value_missing) If the specified value has a
4866 value label for this variable, then show it instead of the raw
4868 (display_dimensions) Delegate display of value_labels to
4869 table_value_missing.
4871 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
4873 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
4874 <BZN-mdksh@t-online.de> for reporting this bug.
4876 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
4877 if the file isn't declared as binary.
4879 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
4881 MATCH FILES corrupted memory and dumped core on some syntax
4884 * get.c: (cmd_match_files) Set file->handle to NULL before
4886 (mtf_free_file) Don't free a null dictionary.
4888 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
4890 MATCH FILES should set numeric values not available to the
4891 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
4892 <BZN-mdksh@t-online.de> for reporting this bug.
4894 * get.c: (mtf_processing) Set unused records to system-missing,
4897 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
4899 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
4900 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
4902 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
4903 in newly created dictionary, and add each copied variable to the
4906 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
4910 * get.c: (trim_dictionary) Free variable list for KEEP after
4913 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
4915 Some systems didn't like the way open_file was coded. Thanks to
4916 Hankin <hankin@rogue.consultco.com> for pointing this out.
4918 * filename.c: (open_file) Don't try to store stdin, stdout,
4919 stderr as part of an array, because that doesn't always work.
4921 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
4923 The SAVE procedure didn't save long string variables properly.
4924 Fixed by this patch. Thanks to Hankin
4925 <hankin@rogue.consultco.com> for this patch.
4927 * sfm-write.c: (write_variable) Fix off-by-one error in writing
4928 out variable pad records.
4930 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
4932 Previously, if PRINT SPACE were given a negative argument, it
4933 would report an error, then spin in an (almost) infinite loop.
4934 This fixes that behavior.
4936 * print.c: (print_space_trns_proc) After reporting a negative
4937 argument, set number of lines to print to 1.
4939 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
4941 SPSS 8.0 outputs some new record types in its system files, and it
4942 allows longer value labels. Accept these system files.
4944 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
4945 11 emitted by SPSS 8.0.
4947 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
4949 The LIST procedure was too conservative in allocating space for
4950 buffers, which caused a bug that only showed up with very long
4951 output variables. Thanks to Hankin <hankin@dunno.com> for this
4954 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
4956 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
4958 Typo meant string format specifiers weren't checked properly. I
4959 think that Hankin <hankin@dunno.com> sent me this report, but I'm
4960 willing to be corrected on this point.
4962 * format.c: (check_string_specifier) Fix obvious typo.
4964 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
4966 Using $CASENUM in an expression didn't work. Here's a fix.
4967 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
4970 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
4972 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
4974 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
4976 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
4977 other behavior, *sigh*. This patch hopefully fixes that. This
4978 time I've actually tested it.
4980 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
4982 * data-list.c: (read_from_data_list_free,
4983 read_from_data_list_list) Call parse_string_as_format() directly
4984 without mucking around with the field width.
4986 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
4988 Occasionally, you may encounter a script that wants to be
4989 interpreted in interactive mode. Make -i emulate this behavior to
4990 allow such scripts to be executed with PSPP.
4992 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
4994 * cmdline.c: (pre_syntax_message[]) Update -i description.
4996 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
4997 when -i is given on the command line) don't treat unindented lines
4998 as starting a new command.
5000 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
5002 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
5003 mostly caused by local initialized aggregates. After egcs is
5004 fixed upstream these can be removed, but for now they're not a big
5007 * ascii.c: (ascii_postopen_driver) Checker chokes on local
5008 initialized arrays. Avoid this.
5010 * sfm-write.c: (sfm_write_dictionary) Don't use a local
5013 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
5015 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
5016 following changes avoid. Currently I compile sources with egcs
5017 1.1.1 and gcc 2.7.2.3 before sending them out.
5019 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
5021 * ascii.c: (option_tab[]) Initialize all struct members.
5023 * avl.h: (avl_traverser_init) New macro.
5025 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
5028 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
5031 * hash.c: Comment fix.
5033 * hash.h: (hsh_iterator_init) New macro.
5035 * html.c: (option_tab[]) Initialize all struct members.
5037 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
5040 * postscript.c: (option_tab[]) Initialize all struct members.
5041 (output_encodings, preclose, dump_lines) Use new
5042 hsh_iterator_init() macro.
5044 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
5047 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
5050 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
5052 * data-in.c: Examined each of the parsing functions to make sure
5053 that they wouldn't dump core if they were passed a string of the
5054 wrong length, since now the DATA LIST FREE/LIST routines don't
5055 check for field width before passing it to the data parser.
5056 (parse_RBHEX, parse_AHEX) Reject odd length input.
5057 (parse_string_as_format) Reject input that's too short or too
5060 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
5061 a field to its entire declared output width then pass it to the
5062 data-in parsing routines. This contradicted the documented
5063 behavior. This is fixed in these changes. Thanks to Mark H. Wood
5064 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
5065 free-format parsing that differed from SPSS.
5066 (cut_field) Commas and spaces are treated identically. Returns
5067 the proper column instead of a fixed 1 value.
5068 (parse_field) Removed.
5069 (read_from_data_list_free, read_from_data_list_list) Call
5070 parse_string_as_format directly instead of parse_field.
5072 * heap.c: (heap_delete) Stylistic fixes.
5074 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
5076 * loop.c: (loop_2_trns_proc) Formatting fix.
5078 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
5080 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
5082 * vfm.c: (macro FILTERED) New.
5083 (static var filter_var) New.
5084 (process_active_file_write_case) Use FILTERED.
5085 (setup_filter) Set filter_var.
5086 (close_active_file) Delete the filter if not
5087 FILTER_before_TEMPORARY.
5088 (procedure_write_case) Use FILTERED.
5090 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
5092 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
5094 * data-in.c: (parse_day_count) Message fix.
5095 (parse_month) Style fix.
5097 * data-list.c: (struct data_list_pgm) New member eof.
5098 (cmd_data_list) Init eof to 0.
5099 (do_reading) Implement the /END subcommand and read-past-eof
5102 * do-if.c: Include stdio.h when debugging.
5103 (cmd_else_if) Make sure the command is .-terminated.
5105 * glob.c: (init_glob) Capitalize the command prompt.
5107 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
5108 (end_file_trns_proc) Debugging message.
5110 * loop.c: (internal_cmd_loop) Make it work when there's no loop
5112 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
5114 * main.c: (dump_token) Make kwtab[] const.
5116 * set.q: Spelling, comment fixes.
5118 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
5121 * vars-prs.c: (fill_all_vars) Style fix.
5123 * vfm.c: (index_to_varname) Return const.
5125 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
5127 * Changes in many source files for partial -ansi -pedantic and
5128 no-debugging compliance: Remove trailing common in enum
5129 declarations; add `unused' attributes; insert some appropriate
5132 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
5134 * command.c: (shell) Make static.
5135 (run_command) Make static.
5137 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
5139 * dfm.c: (cmd_begin_data) I18n fix.
5141 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
5143 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
5145 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
5148 * file-handle.q: Don't prepend the source file directory name to
5149 the data file name. (Ongoing issue.)
5150 (prepend_current_directory) Comment out.
5151 (internal_cmd_file_handle) Don't call prepend_current_directory().
5152 (fh_get_handle_by_filename) Ditto.
5154 * filename.c: Append zero byte to readlink() return value.
5156 * getline.c: (getl_read_line) I18n fix.
5158 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
5160 * misc.h: Don't use gcc features if __STRICT_ANSI__.
5162 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
5165 * postscript.c: (output_encodings) Don't use local_strdup().
5168 * print.c: Don't use gcc features if __STRICT_ANSI__.
5170 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
5172 * recode.c: (parse_src_spec) Fully brace nested if's.
5174 * set.q: (global var set_testing_mode) New var.
5176 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
5178 * ascii.c: Add some more `unused' attributes that only come into
5179 play when NDEBUG is defined.
5180 (ascii_close_page) Set s_len when reallocating s.
5182 * crosstabs.q: (delete_missing) New function.
5183 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
5184 (make_summary_table) Create summary table reallocable.
5186 * postscript.c: Add more `unused' attributes as above.
5188 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
5189 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
5191 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
5194 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
5195 gratuitous space between parameter definition.
5197 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
5198 complaints about running off the end of functions with NDEBUG
5201 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
5203 * Several source files: Removed some PORTME notes when reflection
5204 revealed that ANSI forbids that sort of breakage. Also, added
5205 lots of `unused' qualifiers here and there.
5207 * aggregate.c: (accumulate_aggregate_info) Remove local var
5208 weighting that turned out not to be used.
5210 * avl.c: Update to version 1.1.0. Add unused specifier.
5211 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
5213 (avl_probe) Replace some instances of 1 with +1 where appropriate.
5214 (avl_find) Cast return value to void *.
5215 (avl_delete) q doesn't need to be initialized at the beginning of
5216 the function. Replace some instances of 1 with +1.
5217 (force_avl_delete) Renamed avl_force_delete, all references changed.
5218 (compare_ints) `param' marked unused.
5219 (print_int) `param' marked unused.
5220 (recurse_tree) Replace some instances of 1 with +1.
5222 * avl.h: Update to version 1.1.0. Only declares avl function
5223 types if not already declared.
5224 (AVL_MAX_HEIGHT) Only define if not already defined.
5225 (struct avl_node) New unused member char pad[2].
5226 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
5227 (force_avl_insert) Renamed avl_force_insert.
5228 (force_avl_delete) Renamed avl_force_delete.
5230 * crosstabs.q: (struct table_entry) Put `freq' into a union with
5232 (struct crosstab) Add new member `ofs'.
5233 (glob var int_tab) Removed.
5234 (custom_tables) In integer mode, assign v[i] properly through the
5236 (custom_variables) Now p.crs.max == max + 1.
5237 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
5238 (precalc) Implement integer mode.
5239 (calc_integer) Implement integer mode.
5240 (compare_table_entry) Remove unused local variable `comparing'.
5241 (make_summary_table) Implement integer mode.
5242 (macro ns_rows) Implemented as static variable now.
5243 (several variables) Made static, from global.
5244 (output_pivot_table) Use table_value_missing() for column heads.
5245 Remove several unused local variables. Implement integer mode
5246 table summing. Count up ns_rows.
5247 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
5248 (find_pivot_extent) Moved into find_pivot_extent_general; now just
5249 calls that function or find_pivot_extent_integer.
5250 (find_pivot_extent_integer) New function.
5251 (enum_var_values) Implemented for integer mode.
5252 (table_value_missing) New function.
5253 (display_dimensions) Call table_value_missing() for heads.
5254 (float_M_suffix) New function.
5255 (display_crosstabulation) Call table_value_missing() for row
5256 heads. Handle missing values in /MISSING=REPORT mode.
5257 (calc_fisher) Remove unused var N.
5258 (calc_r) Remove unused var fact.
5260 * data-list.c: (dump_fixed_table) Fix table dimensioning.
5261 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
5263 * data-out.c: (insert_commas) Remove unused var cp.
5264 (convert_CCx) Remove unused vars save_set_decimal,
5267 * descript.q: (dump_z_table) Fix table dimensioning.
5268 (pre_calc) Remove unused var j.
5269 (display) Remove unused vars title, s. Fix table dimensioning.
5271 * expr-evl.c: Comment fixes.
5273 * frequencies.q: (full_dim) New function.
5274 (dump_full) Fix table dimensioning.
5275 (condensed_dim) New function.
5276 (dump_condensed) Fix table dimensioning.
5278 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
5281 * html.c: (html_close_drive) Remove unused var i.
5282 (postopen) Remove unused vars title, curfn_len, cp.
5283 (preclose) Remove unused vars this, x.
5285 * lexer.c: Comment fixes.
5287 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
5289 * means.q: (custom_tables) Remove unused var m_dim.
5291 * mis-val.c: Format fix.
5293 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
5295 * output.c: (outp_get_paper_size) Remove unused var cp.
5297 * pfm-read.c: (read_float) Remove unused var save, unused label
5299 (read_variables) Remove unused vars cp, j.
5300 (read_value_label) Remove unused var j.
5302 * pfm-write.c: (bufwrite) Remove unused var i.
5304 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
5306 (output_encodings) Remove unused vars char_cp, n_output.
5307 (read_ps_encodings) Remove unused var ep.
5308 (postopen) Remove unused var title.
5309 (preclose) Remove unused var fp.
5310 (ps_open_page) Remove unused vars true, false, orientation,
5311 mirror_horz, mirror_vert, width, length.
5312 (ps_text_metrics) Remove unused var x.
5314 * q2c.c: (find_symbol) Remove unused var y.
5315 (parse_setting) Remove unused parameter sbc, all references
5317 (dump_parser) Remove unused var cp.
5318 (dump_free) Remove unused var i.
5320 * set.q: (static vars args, n) Removed.
5321 (internal_cmd_gset) Removed.
5323 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
5324 (read_machine_flt64_info) Removed unused var file_endian.
5325 (read_documents) Removed unused var i.
5326 (read_compressed_data) Removed unused parameter dict, all
5329 * sfm-write.c: (bufwrite) Removed unused var i.
5330 (sfm_write_case) Removed unused var i.
5332 * sort.c: (merge_once) Remove unused var t.
5333 (write_separate) #if 0 out as dead code.
5335 * split-file.c: (cmd_split_file) Remove unused var i.
5337 * sysfile-info.c: (sysfile_info_dim) New function.
5338 (cmd_sysfile_info) Fix table dimensioning.
5339 (variables_dim) New function.
5340 (display_variables) Fix table dimensioning.
5341 (describe_variable) Remove unused var prev_r.
5343 * t-test.q: (z_postcalc) Removed.
5344 (pairs_calc) Remove unused var bad_weight.
5345 (postcalc) Remove unused vars dfn, dfd.
5347 * tab.c: (tab_create) Set t->dim to NULL.
5348 (tab_dim) Make sure t->dim is NULL first.
5349 (tab_natural_width) Remove parameter `clamp'.
5350 (tab_value) Remove duplicate assertion for table.
5351 (tab_raw) New function.
5352 (nowrap_dim) New function.
5353 (wrap_dim) New function.
5354 (tab_output_text) Fix table dimensioning.
5356 * tab.h: (tab_raw) New macro.
5358 * val-labs.c: (get_label) Remove unused var type.
5359 (copy_value_labels) Remove unused var trav.
5361 * var.h: (struct crosstab_proc) Completely changed.
5363 * vars-prs.c: (parse_dict_variable) Remove unused var v.
5365 * vfm.c: (open_active_file) Remove unused vars i, lp.
5367 * weight.c: (weight_trns_proc) #if 0 out as dead code.
5369 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
5371 * Makefile.am: Add apply-dict.c, flip.c.
5373 * apply-dict.c: New file.
5375 * command.c: (struct command) Make cmd[] larger for CLEAR
5376 TRANSFORMATIONS command name.
5377 (parse_cmd) Make sure we're in a valid state before using it as an
5378 index. Discard variables and reset state on invalid transitions.
5379 (cmd_clear_transformations) New function.
5381 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
5382 Add unimplemented PRESERVE, RESTORE.
5384 * file-handle.h: Include stddef.h.
5388 * pfm-read.c: (parse_value) Pad value label values with spaces,
5391 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
5392 (sfm_close) Decrement reference count, make sure it's zero.
5393 (sfm_maybe_close) New function.
5394 (sfm_read_dictionary) Handle reference counts.
5396 * vars-atr.c: (clear_default_dict) New function.
5397 (discard_variables) Use clear_default_dict().
5399 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
5401 * Makefile.am: Add pfm-write.c.
5402 (LDADD) Add the libgmp2 libraries.
5404 * command.def: Define EXPORT.
5406 * get.c: (cmd_export) New function.
5407 (export_write_case_func) New function.
5409 * pfm-read.c: (static spss2ascii[]) Make it const.
5411 * pfm-write.c: New file.
5413 * sfm-write.c: Formatting, comment fixes.
5415 * var.h: Comment fix.
5417 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
5419 * Makefile.am: Add pfm.h, pfm-read.c.
5421 * command.def: IMPORT is now implemented.
5423 * format.c: (glob var translate_fmt[]) New var.
5425 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
5426 (cmd_import) New function.
5427 (import_source_read) New function.
5428 (glob var import_source) New var.
5430 * pfm-read.c: New file.
5434 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
5436 (dump_dictionary) Disabled printing a couple of items.
5438 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
5440 * crosstabs.q: (postcalc) Call make_summary_table().
5441 (make_summary_table) New function.
5442 (insert_summary) New function.
5443 (display_dimensions) Remove some unnecessary arguments, all
5445 (output_pivot_table) Fix lots of problems with the risk table
5447 (submit) Don't display an empty table.
5448 (display_risk) Fix order of arguments to calc_risk().
5450 * glob.c: Always include assert.h and stdlib.h.
5452 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
5455 * tab.c: (tab_create) Cosmetic changes.
5457 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
5459 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
5463 * crosstabs.q: (output_pivot_table) Headers drawing and submission
5464 code simplified, moved into new function submit().
5465 (submit) New function.
5466 (crosstabs_dim) New function.
5467 (display_directional) Substitute variable names for %s where
5469 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
5470 (calc_symmetric) Initialize parameters only if non-NULL.
5471 Calculate Somers' d.
5472 (calc_directional) Calculate Somers' d (or copy it, really).
5475 * output.c: (outp_string_width) New function.
5477 * postscript.c: (postopen) Calculate font widths based on the
5478 width of the zero '0' character, not the width of the space
5479 character. Set paper-width and paper-length based on points, not
5481 (ps_open_page) Fix page setup string for landscape mode.
5483 * som.h: (struct som_dimension) Removed.
5484 (struct som_table_class) height, width members take int * not
5487 * tab.c: Many functions now have added parameter validation.
5488 (tab_height, tab_width) These functions were removed and merged
5489 into a single function tab_resize(), and all references changed.
5490 (tab_dim) Rewritten since the interface changed; reduced from
5491 hundreds of lines to two. All callers were changed. Currently
5492 most of them just use tab_natural_dimensions as their callback and
5493 await detailed translation of functionality.
5494 (tab_natural_width) New function.
5495 (tab_natural_height) New function.
5496 (tab_natural_dimensions) New function. This is a callback
5497 function, not something that you'd want to call directly.
5498 (tab_nat_dim) Removed.
5499 (tabi_table) Allocates t->w and t->h.
5500 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
5501 dimensions callback.
5502 (evaluate_dimensions) Removed.
5503 (sum_columns) Removed.
5505 * tab.h: (enum TAL_1THIN) Removed.
5506 (enum series t_*) Removed.
5507 (struct tab_table) Members trh, trv changed to unsigned char *
5508 from int *. Member dim changed to a function pointer from a
5509 unsigned char *. Member max_stack_height removed. New members
5511 (macros tab_l, tab_r, tab_t, tab_b) New.
5513 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
5515 * ascii.c: (delineate) Assign last_space_nchars before skipping
5516 spaces, to fix right justification.
5518 * crosstabs.q: (static vars risk, direct) New vars.
5519 (static var pearson_r) Removed.
5520 (glob var chisq_fisher) Made static.
5521 (static vars row_tot[], col_tot[]) Don't include grand total
5523 (static var grand_total) Renamed W, all references changed.
5524 (output_pivot_table) Only make `table' if num_cells != 0. Make
5525 risk and directional tables. Deal with grand total no longer part
5526 of col_tot[]. Free rows and cols after we're done with them.
5527 (display_risk) New function.
5528 (display_directional) New function.
5529 (clac_r) Rewritten so that it stores all its results into its
5530 arguments, so it can be used for Spearman's correlation too.
5531 (calc_symmetric) Added a t[] argument, all references changed.
5532 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
5533 Pearson's r, Cohen's kappa.
5534 (calc_risk) New function.
5535 (calc_directional) New function.
5537 * som.c: (som_submit) Improved debugging code.
5539 * stats.c: (hypercube) New function.
5540 (cube) New function.
5542 (normal_sig) Went back to old implementation, which actually
5545 * stats.h: (macros square, cube, hypercube) Removed. The
5546 equivalent functions in stats.c are inlined here; all references
5547 to square changed to sqr.
5549 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
5551 * crosstabs.q: (N_SYMMETRIC) New define.
5552 (postcalc) Disable debug printing.
5553 (static vars chisq_fisher, pearson_r) New.
5554 (output_pivot_table) Add support for symmetric measures. Add
5555 chi-square output of exact sigs.
5556 (display_chisq) Rewritten.
5557 (display_symmetric) New function.
5558 (gamma_int) New function.
5560 (swap) New function.
5561 (calc_fisher) New function.
5562 (calc_chisq) Check boundary conditions better. Calculate Yates,
5563 Fisher, Mantel-Haenszel tests.
5564 (calc_r) New function.
5565 (calc_symmetric) New function.
5567 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
5569 (chisq_sig) Better boundary conditions. Renamed from
5572 * tab.h: (struct tab_table) New member cf.
5574 * tab.c: (tab_create) Set cf.
5575 (tab_width) New function.
5576 (tab_realloc) Handle cf.
5577 (tab_vline) Handle cf.
5578 (tab_hline) Handle cf.
5579 (tab_box) Handle cf.
5580 (tab_value) Handle cf.
5581 (tab_float) Handle cf.
5582 (tab_text) Handle cf.
5583 (tab_joint_text) Handle cf.
5584 (tab_offset) Handle cf.
5585 (tab_next_row) Handle cf.
5586 (evaluate_dimensions) Handle cf.
5587 (render_strip) Handle cf.
5589 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
5591 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
5592 output_pivot_table().
5593 (output_pivot_table) Moved lots of local variables outside and
5594 made them static. Add beginnings of chi-square statistic
5595 support. Now column and row totals aren't in the main matrix.
5596 Always zero out any leftover rows & columns after we're done with
5597 the table entries. Move all output stuff into
5598 display_dimensions(), display_crosstabs(), display_chisq().
5599 (display_dimensions) New function.
5600 (display_crosstabulation) New function.
5601 (display_chisq) New function.
5602 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
5604 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
5605 references, simplify logic.
5607 * postscript.c: Remove scale, translate-x, translate-y,
5608 mirror-horz, mirror-vert, rotate-180 options.
5609 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
5610 All references deleted.
5611 (macro YT) New macro.
5612 (array option_tab[]) Removed options.
5613 (ps_option) Removed options.
5614 (ps_open_page) Write page setup explicitly to output file, without
5615 using now-deleted BP function.
5616 (macro dump_line) Use YT().
5617 (macro dump_thick_line) Use YT().
5618 (draw_headers) Use YT().
5619 (switch_font) Reorder arguments to SF function.
5620 (write_text) Use YT().
5622 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
5625 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
5627 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
5628 null-debugging code.
5629 (tab_realloc) Remove null-debugging code. Initialize new regions
5631 (tab_vline) Support offsets.
5632 (tab_hline) Support offsets.
5633 (tab_box) Support offsets.
5635 (tab_nulls) Removed.
5638 (evaluate_dimensions) Remove null-debugging code. Understand
5639 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
5640 TAB_EMPTY not present.
5642 * tab.h: New cell attribute TAB_EMPTY.
5643 (macros tab_nr, tab_nc, tab_row, tab_col) New.
5645 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
5646 try to read them from system files.
5648 * vfm.c: (dump_splits) Don't call tab_null().
5650 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
5652 * crosstabs.q: (struct crosstab) Added `missing' member.
5653 (custom_tables) Init missing.
5654 (calc_general) Handle missing values.
5655 (calc_chisq) New function.
5656 (output_pivot_table) Start work on chi-square output. Update for
5657 new tab offset support functions. Shorten statistic names.
5659 * Several files: add in more `const's to placate gcc's warnings.
5661 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
5664 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
5665 tab_null, tab_nulls, tab_value, tab_float, tab_text,
5666 tab_joint_text) Add col_ofs and row_ofs support.
5667 (tab_offset) New function.
5668 (tab_next_row) New function.
5669 (tab_row) New function.
5670 (tab_col) New function.
5671 (tabi_table) Add col_ofs and row_ofs support.
5673 * vars-atr.c: (is_system_missing) New function.
5675 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
5677 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
5678 (static var no_cells) Removed.
5679 (static var num_cells) New.
5680 (static var expected) New.
5681 (static var cells[]) New.
5682 (internal_cmd_crosstabs) Deal with new variables.
5683 (postcalc) Removed most of the meat and put it in new function
5684 output_pivot_table().
5685 (output_pivot_table) Calculates and outputs an entire pivot table.
5687 * postscript.c: (postopen) Fix problems with free()ing addresses
5688 not obtained from malloc().
5690 * som.c: (som_submit) Add assertion.
5692 * sysfile-info.c: (describe_variable) Use new tab_nulls()
5695 * tab.c: (static var tab_names[]) New.
5696 (tab_realloc) -1 for nc or nr indicates no change.
5697 (tab_nulls) New function.
5698 (tab_dim) Use tab_names[].
5699 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
5700 (evaluate_dimensions) Don't terminate on uninited cells, just put
5701 an X in them and emit a notice. Use tab_names[].
5703 * tab.h: Move bits into tab.def.
5705 * tab.def: New. Don't try to declare tab_table_class because then
5706 som.h has to be included.
5708 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
5710 * command.def: New file, contains all the command definitions
5711 previously included bodily in command.c.
5713 * format.def: New file, contains all of the format definitions
5714 previously split across format.h, format.c, and sfm-write.c.
5716 * lexer.h: Renamed from tokens.h in order to match corresponding
5719 * lexerP.h: Moved some rarely used functions exported by lexer.c
5722 * Makefile.am: Commemorate renamed files.
5723 (EXTRA_DIST) Add command.def, format.def.
5725 * command.c: [0] (walk_cmdtable_func) Removed.
5727 * crosstabs.q: (postcalc) Made it work and print out matrices
5729 (enum_column_values) Renamed enum_var_values, generalized for any
5732 * format.h: (struct fmt_desc) New member `spss'.
5734 * q2c.c: (main) Generated code includes lexer.h instead of
5737 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
5738 instead of an independent translation table.
5740 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
5742 * Lots of source files: Added const to declarations.
5744 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
5746 * arena.c: (arena_clear) Set prev pointer to null when done.
5748 * ascii.c: (ascii_option) Rename index as indx.
5750 * avl.c: This is now a separate library called libavl.
5751 (xmalloc) Make static.
5752 (avl_probe) Step A7 can use the cache instead of an explicit
5754 (avl_delete) Don't maintain a q pointer because it's always
5755 available in the pointer stack. Comment fix.
5757 * avl.h: This is now a separate library called libavl.
5759 * command.c: (cmd_table[]) Remove spurious trailing "".
5761 * common.h: Only include random() fix if this system needs it.
5763 * crosstabs.q: Include alloca headers.
5764 (n_sorted_tab) New global var.
5765 (postcalc) Mostly rewritten.
5766 (find_pivot_extent) Rewritten.
5767 (enum_column_values) Rewritten.
5769 * data-out.c: (convert_F) Rename inner n as n_spaces.
5771 * error.c: (dump_message) Don't have an outer var i.
5773 * file-handle.q: (static var f) Removed. All references removed.
5774 (internal_cmd_file_handle) Uses a local variable instead of f.
5776 * get.c: (trim_dictionary) Change scope of i, i1, i2.
5777 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
5780 * getline.h: Declare getl_history as extern. Reported by
5781 palme@uni-wuppertal.de (Hubert Palme).
5783 * postscript.c: (postopen) Some large mods for constness.
5785 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
5788 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
5790 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
5791 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
5794 * avl.c, avl.h: New files. These form a clean-room
5795 reimplementation of avllib. Iterative algorithms are used in
5796 place of recursive ones, so there is no resemblance in the code.
5798 * Lots of headers: Don't include other headers by default.
5800 * Lots of source files: Explicitly include all needed headers.
5802 * arena.c: (arena_clear) New function.
5804 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
5805 (static var ar) Removed.
5806 (staitc vars ar_tc, ar_col) New.
5807 (cmd_crosstabs) Destroy the arenas.
5808 (internal_cmd_crosstabs) Create the arenas.
5809 (precalc) Don't need a free function for the hash.
5810 (calc_general) Make sure to zero out the trailer on the key data
5812 (print_table_entries) Updated.
5813 (postcalc) Worked on actually implementing.
5814 (find_pivot_extent) New function.
5815 (compare_value) New function.
5816 (enum_column_values) New function.
5818 * data-in.c: (parse_month) Make local array `static const'.
5820 * data-out.c: (convert_date) Make local array `static const'.
5821 (convert_WKDAY) Same.
5822 (convert_MONTH) Same.
5824 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
5825 been renamed to avl_walk().
5827 * hash.c: Rewritten more efficiently.
5829 * hash.h: Add attribute const to hsh_next_prime declaration.
5831 * lexer.c: (id_match) Make arguments const.
5833 * postscript.c: (ps_postopen_driver) Make default fonts the
5836 * q2c.c: (main) Generated code needs stdlib.h.
5838 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
5839 initialized to 0 now, not to NULL. All other references to
5840 avl_traverser were updated in the same way.
5842 * tokens.h: Macro version of id_match updated to use const
5845 * val-labs.c: (inc_ref_count) New function.
5846 (copy_value_labels) Simply through use of new avl_copy() function.
5848 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
5850 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
5851 (postcalc) Worked on this.
5853 * postscript.c: (OPO_DOUBLE_LINE) New enum.
5854 (struct ps_driver_ext) New line_width_thick member.
5855 (ps_preopen_drive) Init line_width_thick.
5856 (option_tab[]) Add line-* options.
5857 (ps_option) Parse line-* options.
5858 (postopen) Add line_width_thick support. Strip leading spaces on
5859 prologue output lines.
5860 (ps_open_page) Include line_width_thick in output.
5861 (macro dump_thick_line) New.
5862 (dump_fancy_line) Support thick lines as well as double lines.
5864 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
5866 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
5867 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
5869 * Many source files: Rename `options' to `pv_opts' as appropriate.
5871 * command.c: (static var cmd_table[]) Add CROSSTABS command.
5873 * common.c: (xcalloc) New function.
5875 * crosstabs.q: New file. Not finished yet, though.
5877 * data-list.c: Comment fix.
5879 * error.c: Remove some old Checker cruft.
5881 * frequencies.q: (dump_full) Cumulate valid percent instead of
5884 * getline.c: Comment fix.
5886 * hash.c: Comment fixes.
5888 * hash.h: (struct hsh_table) Make hash functions return unsigned
5889 instead of int to avoid problems with taking the modulo of
5890 negative return values. All references changed.
5892 * misc.c: (intlog10) Make its table static const instead of auto.
5894 * sfm-read.c: (read_header) Make `prefix' static const instead of
5897 * var.h: (union value) Add member `hash'.
5898 (struct variable) Rename prv_index as `foo'--all references
5900 (typedef pv_opts) Removed. All references changed.
5902 * vars-prs.c: (parse_variables) Message fixes.
5904 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
5906 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
5907 they are being inserted. Don't check for BY variables of
5908 different types. Discard variables if the active file isn't
5909 included in the merge.
5910 (mtf_processing) Essentially rewritten.
5911 (mtf_merge_dictionary) Check for master/slave variables of
5912 different types/widths.
5914 * vfm.c: (static var not_canceled) New var.
5915 (process_active_file) Don't call vfm_source->read() if
5916 there's no vfm-source. Initialize not_canceled.
5917 (process_active_file_write_case) Honor and update not_canceled.
5918 (prepare_for_writing) Rollback changes from yesterday, they were
5920 (close_active_file) Don't destroy vfm_source unless it exists.
5922 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
5924 * Lots of source files: Added { } around nested if/else constructs
5925 to avoid new gcc 2.8 warnings.
5927 * data-in.c: (parse_Z) Declare `int' type explicitly.
5930 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
5931 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
5932 prev members. Put TABLEs at the end of the chain and FILEs at the
5933 beginning. Don't allow the active file in STATE_INIT. Use proper
5934 `seen' value for the active file. Fill out the by members and
5935 make sure they're of consistent type. Do the actual merge
5937 (mtf_processing_finish) New function.
5938 (var_type_description) New function.
5939 (mtf_free_file) New function.
5940 (mtf_free) Rewritten.
5941 (mtf_delete_file_in_place) New function.
5942 (mtf_read_nonactive_records) New function.
5943 (mtf_compare_BY_values) New function.
5944 (static var mtf_seq_no) New var.
5945 (mtf_processing) New function.
5946 (mtf_merge_dictionary) Assign nval members for the system file
5947 dictionary. Assign fv values for its variables. Point each slave
5948 variable to the corresponding master variable.
5950 * hash.c: Include str.h.
5952 * mis-val.c: (copy_missing_values) src arg is const.
5954 * misc.c: (spacing) Make `max' var explicitly int.
5956 * sfm-read.c: (dump_dictionary) Message reformatting.
5957 (sfm_read_case) Add assertion.
5959 * sort.c: Esthetic fixes.
5961 * var.h: (struct match_files_proc) New struct.
5962 (struct variable) Add private data match_files_proc.
5964 * vars-atr.c: (delete_variable) Implement. Add argument for the
5965 dictionary that owning the variable.
5966 (dup_variable) Add assertion.
5968 * vfm.c: Comment fixes, hopefully the comments are correct now.
5969 (process_active_file) New function.
5970 (process_active_file_write_case) New function.
5971 (process_active_file_output_case) New function.
5972 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
5974 (write_case) Renamed procedure_write_case(). Now write_case is a
5975 pointer to a function. Style fixes.
5977 1998-03-05 Ben Pfaff <blp@gnu.org>
5979 * Makefile.am: (q2c) Link with libmisc.
5980 (version.c) Define default_config_path, include_path,
5983 * ascii.c: (ascii_postopen_driver) When the default newline string
5984 is requested, open file in text mode. Suggested by
5985 palme@uni-wuppertal.de (Hubert Palme).
5986 (static vars line_buf, line_p) Change from char * to unsigned char
5988 (ascii_close_page) char * to unsigned char *.
5990 * cmdline.c: (parse_command_line) Implement -r option by
5991 prepending ~/.pspp/rc to the list of files to process.
5993 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
5994 before pulling in a final line.
5995 (null_func, null_int_func) Removed (dead code).
5997 * descript.q: (display) Calculate width of variable name column
5998 properly. Calculate number of valid cases properly. Reported by
5999 palme@uni-wuppertal.de (Hubert Palme).
6001 * filename.c: (init_filename) Use default_config_path instead of
6002 now obsolete CONFIG_PATH.
6004 * getline.c: (getl_initialize) Use include_path instead of now
6005 obsolete INCLUDE_PATH.
6006 (getl_add_file) New argument `where'. All references changed.
6008 * groff.c: (find_font_file) Use groff_font_path instead of now
6009 obsolete GROFF_FONT_PATH.
6011 * postscript.c: (find_ps_file) Use groff_font_path instead of now
6012 obsolete GROFF_FONT_PATH. Copy through temporary variable to
6013 avoid problems with constness.
6015 * str.h: (macro cs_streq) New macro.
6017 * version.h: (glob var default_config_path, include_path,
6018 groff_font_path) New vars.
6020 1998-02-23 Ben Pfaff <blp@gnu.org>
6022 * Many source files: Change verbose_msg() priority levels and
6025 * aggregate.c: Include debug-print.h.
6027 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
6029 (static var pre_syntax_message) Document --safer/-s and
6032 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
6034 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
6035 because it's not used but it's still copied.
6036 (open_file_r) Remove gratuitous debug message.
6038 * filename.c: (safety_violation) New function.
6039 (open_file) Remove gratuitous debug messages. Don't allow pipe
6040 files if set_safer is set.
6042 * get.c: Turn off debugging.
6044 * getline.c: (getl_add_virtual_file) New function.
6045 (getl_read_line) Add verbose_msg() call for opening new syntax
6047 (getl_perform_delayed_reset) Add a return value describing whether
6048 any action was taken. Call reset_eof().
6050 * getline.h: Comment fix.
6052 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
6053 place of incorrect `continue'. Use strtok_r() instead of
6054 strtok(). Always check strtok_r() return value.
6055 (groff_read_DESC) Use strtok_r() instead of strtok().
6057 * lexer.c: (reset_eof) New function.
6059 * main.c: (parse) Get a token after performing a delayed reset
6060 action; allow empty syntax files.
6062 * postscript.c: (output_encodings) Use strtok_r() instead of
6065 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
6067 * set.q: Comment fixes.
6068 (glob var set_safer) New var.
6069 (internal_cmd_set) Support SAFER.
6071 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
6073 * temporary.c: (free_dictionary) Set d->splits to NULL after
6076 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
6077 variable deleted, not if it *isn't* deleted.
6079 1998-02-16 Ben Pfaff <blp@gnu.org>
6081 * command.c: (array cmd_table[]) Add MATCH FILES.
6083 * common.c: Comment fixes.
6085 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
6086 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
6087 Include alloca.h. Problem reported by palme@uni-wuppertal.de
6090 * expr-opt.c: Include str.h. Problem reported by
6091 palme@uni-wuppertal.de (Hubert Palme).
6093 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
6094 (static var mtf_by) Change from char ** to variable **.
6095 (static var mtf_master) New var.
6096 (mtf_merge_dictionary) New function.
6097 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
6098 var type. Reorder tests properly. Initialize file->dict. Detect
6099 TABLE= without BY=. Read file dictionaries and merge them. Give
6100 subcommand name with IN, LAST, FIRST error messages. Create IN,
6101 LAST, FIRST variables. Comment fixes.
6102 (mtf_free) Don't free default_dict. Free mtf_master.
6104 * getline.c: Define getl_mode. Change getl_buf_size to size_t
6106 (handle_line_buffer) Cast int to size_t in comparison to avoid
6109 * getline.h: Declare getl_mode extern.
6111 * groff-font.c: (groff_read_font) Type-fix calls to getline.
6112 (groff_read_DESC) Make line_size a size_t.
6113 (match_tok) Parenthesize name to avoid macro expansion.
6115 * mis-val.c: (copy_missing_values) New function.
6117 * postscript.c: (postopen) Make buf_size a size_t.
6119 * sfm-read.c: (dump_dictionary) Make global from static. Print
6120 variable info in parts for easier debugging with Checker.
6122 * temporary.c: (copy_variable) Use copy_value_labels().
6123 (new_dictionary) New arg: whether to copy file label, documents.
6125 * val-labs.c: (copy_value_labels) New function.
6127 * var.h: (enums MISSING_*) Add MISSING_COUNT.
6129 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
6131 (dup_variable) Set prv_index, get.fv, get.nv.
6133 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
6135 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
6137 * Many source files: For ANSI-compliance, add empty statement
6138 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
6139 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6141 * data-in.c: (parse_numeric) Some header files break on
6142 -DBL_MIN_10_EXP because they get a --; add () for safety.
6143 Reported by palme@uni-wuppertal.de (Hubert Palme).
6145 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
6146 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
6147 (dfm_close) Use close_file_ext.
6148 (open_inline_file) Set file.file to NULL, not file.
6149 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
6150 struct and use open_file_ext().
6151 (read_record) Use file.file.
6153 * file-handle.q: (prepend_current_directory) Pass through special
6156 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
6157 (normalize_filename) Pass through special filenames.
6158 (open_file, close_file) Accept pipe| and |pipe syntaxes as
6160 (dirname) Rename blp_dirname() because of name conflict on some
6161 OS. All references changed. Reported by palme@uni-wuppertal.de
6163 (is_special_filename) New function.
6165 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
6166 (trim_dictionary) Conditionalize some of the options on whether
6167 GTSV_OPT_MATCH_FILES is in *options.
6168 (rename_variables) Don't allow variables to be renamed as scratch
6170 (MTF_*) New enum series.
6171 (struct mtf_file) New struct.
6172 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
6174 (cmd_match_files, mtf_free) New functions.
6176 * lexer.c: (match_int) Needed parentheses around name to escape
6177 macro expansion. Reported by Micah Altman
6178 <maltman@www-vdc.fas.harvard.edu>.
6180 * print.c: Needed to include alloca.h. Reported by Micah Altman
6181 <maltman@www-vdc.fas.harvard.edu>.
6183 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
6184 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
6187 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
6188 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6190 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
6192 * html.c: (struct html_driver_ext) Move into htmlP.h.
6193 (html_preopen_driver) Initialize cp_x, cp_y.
6194 (html_submit) Implement as call to output_tab_table().
6195 (change_attributes) New function.
6196 (escape_string) New function.
6197 (output_tab_table) New function.
6199 * list.q: (write_all_headers) Add code for writing headers for the
6201 (clean_up) Write out the html close-table tag.
6202 (determine_layout) Ignore html driver.
6203 (list_cases) Write html data.
6205 * som.c: (som_submit) Move more of the code into output_table().
6207 * tab.c: (static var hit) Make a global var and rename tab_hit.
6208 (static var tab_table_class) Make a global var.
6210 * htmlP.h: New file.
6212 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
6214 * dump-sysfile.c: Removed.
6216 * html.c: (preclose) Change comment in emitted code.
6218 * matrix-data.c: Debugging off by default. Comment fixes.
6219 (static var container) New var.
6220 (cmd_matrix_data) Create and destroy container. Initialize
6221 is_per_factor[] to 0s. Move code into new function
6222 string_to_content_type(). Require split values to be present in
6223 the data when ROWTYPE_ is explicit. Call specific function, not
6224 general read_matrices().
6225 (string_to_content_type) New function.
6226 (context) Exclude all whitespace, not just spaces.
6227 (mget_token) A dot is a number. Add assertion.
6228 (static var data) Renamed nr_data.
6229 (static var factor_values) Renamed nr_factor_values.
6230 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
6231 only specific case. Close data_file before exit.
6232 (fill_matrix) New function.
6233 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
6234 printing. Style fixes. Message fixes. Move code into
6236 (read_matrices_without_rowtype) Rename
6237 matrix_data_read_without_rowtype(). Fix off-by-one error on
6238 loops. Allocate nr_data[] memory from arena.
6239 (read_matrices_with_rowtype) Removed.
6240 (read_splits) Renamed nr_read_splits(). Style fixes.
6241 (read_factors) Renamed nr_read_factors().
6242 (dump_cell_content) Comment fixes. Arguments changed. Change
6243 debug printing. All references changed.
6244 (output_data) Renamed nr_output_data().
6245 (static var wr_content) New var.
6246 (struct factor_data) New struct.
6247 (static var wr_data) New var.
6248 (static var wr_current) New var.
6249 (matrix_data_source_destroy_source) Removed.
6250 (read_matrices_with_rowtype) New function.
6251 (matrix_data_read_with_rowtype) New function.
6252 (wr_read_splits) New function.
6253 (compare_factors) New function.
6254 (wr_output_data) New function.
6255 (wr_read_rowtype) New function.
6256 (wr_read_factors) New function.
6257 (wr_read_indeps) New function.
6258 (glob var matrix_data_source) Make destroy_source member NULL as
6261 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
6263 * lexer.c: (syntax_error) Give better error message when at end of
6266 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
6267 N_SCALAR to output as plain N.
6268 (mdump_token) Change output format.
6269 (context) Fix message output interaction with spaces in input.
6270 (another_token) New function.
6271 (force_eol) Improved error message.
6272 (static var max_cell_index) New var.
6273 (read_matrices) Init `cells'. factor_values is now per-cell.
6274 Init max_cell_index.
6275 (read_data_lines) Replace `compare' local with new `compare' arg.
6276 Debugging messages changed. Only read factors if per_factor.
6277 Propagate error return from read_factors(), force_eol().
6278 Copy N_SCALAR values across the N vector.
6279 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
6280 check parentheses manually since we now have is_per_factor[].
6281 Call read_data_lines() with new args. Check for end of data after
6282 looping, using another_token().
6283 (read_factors) Arguments changed. Use max_cell_index to determine
6284 whether to read or compare factors. Message fixes.
6285 (dump_cell_content) New function.
6286 (output_data) Completely rewritten because content types were
6287 supported to be nested inside factor values, not vice versa.
6289 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
6291 * lexer.c: (syntax_error) Support formatted varargs messages.
6293 * matrix-data.c: Turn debugging on by default.
6294 (static content_type[]) New array.
6295 (static content_names[]) New array.
6296 (static rowtype_, varname_) New vars.
6297 (static is_per_factor[]) New array.
6298 (static split_values) Moved declaration.
6299 (static n_continuous, first_continuous) New var.
6300 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
6301 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
6302 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
6303 Check for continuous variables.
6304 [DEBUGGING] (debug_print) Remove content_names[].
6305 (mdump_token) New macro.
6306 (mget_token_dump) New function.
6307 (mdump_token) New function.
6308 (context) New function.
6309 (mget_token) Fix messages.
6310 (static var data, split_values, factor_values) New vars.
6311 (read_matrices) Manage split_values, factor_values.
6312 (read_data_lines) New function.
6313 (read_matrices_without_rowtype) Implemented.
6314 (read_splits) Message fixes. Uses `just_read'.
6315 (read_factors) New function.
6316 (output_data) New function.
6317 (matrix_data_source_destroy_source) Close the file handle.
6318 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
6321 * str.c: (strpadcmp) Removed.
6323 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
6325 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
6327 * Lots of source files: Add cast to unsigned character to calls to
6328 tolower() and toupper().
6330 * aggregate.c: Set default_dict.splits to NULL.
6332 * command.c: (static variable tab[]) Add MATRIX DATA.
6334 * data-in.c: Add debugging defines. Formatting fixes.
6336 * expr-opt.c: Formatting fixes.
6338 * lexer.c: (syntax_error) Message fixes.
6340 * matrix-data.c: New enum series.
6341 (static vars fmt, section, diag, explicit_rowtype, signle_split,
6342 split_values, n_factors, factors, cells, pop_n, contents,
6343 n_contents) New vars.
6344 (cmd_matrix_data) Finished implementation.
6345 (compare_variables_by_mxd_vartype) New function.
6346 [DEBUGGING] (debug_print) New function.
6347 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
6348 (read_matrices) New function.
6349 (read_matrices_without_rowtype) New function.
6350 (read_matrices_with_rowtype) New function.
6351 (read_splits) New function.
6352 (mget_token) New function.
6353 (force_eol) New function.
6354 [0] (test_tokenizer) New function.
6355 (matrix_data_source_destroy_source) New function.
6356 (glob var matrix_data_source) New var.
6358 * misc.h: Include ieeefp.h if present.
6360 * split-file.h: (cmd_split_file) Changes corresponding to struct
6363 * str.h: Fix memmem prototype.
6365 * temporary.c: (save_dictionary, restore_dictionary,
6366 free_dictionary) Changes corresponding to struct dictionary
6369 * var.h: (MXD_* enums) New enum series.
6370 (struct matrix_data_proc) New struct.
6371 (struct split) Removed.
6372 (struct dictionary) Changed `splits' member from `split *' to
6374 (macro force_create_variable) New macro. Replaced lots of
6375 create_variable()/assert() calls with calls to this macro.
6377 * vars-atr.c: (discard_variables) Changed assertion.
6378 [GLOBAL_DEBUGGING] (force_create_variable) New function
6379 called by the macro of the same name.
6380 (clear_variable) Changes to delete splits from the dictionary
6381 corresponding to struct dictionary changes.
6383 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
6384 corrupted variable `index' values in the dictionary passed in
6385 every time this function is called.
6387 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
6388 to struct dictionary changes.
6390 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
6392 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
6394 * command.c: New includes.
6395 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
6396 (cmd_erase) New function.
6397 [unix] (shell) New function.
6398 (run_command) New function.
6399 (cmd_host) New function.
6400 (cmd_new_file) New function.
6402 * expr-prs.c: (parse_primary) Message fix.
6404 * inpt-pgm.c: Formatting fix.
6405 (cmd_reread) Implement the FILE subcommand.
6407 * matrix-data.c: New file.
6409 * q2c.c: (dump_header) Change output commenting style.
6411 * weight.c: Comment fix.
6413 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
6415 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
6417 (buf_10x) Renamed buf_1xx, all references changed.
6418 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
6419 cases now implemented).
6420 (create_sysfile) New function.
6421 (agr_11x_func) New function.
6423 * data-in.c: (parse_numeric) Work properly if there's an
6424 explicitly coded decimal point in the data and decimal places are
6425 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
6426 <el@linux.lisse.na>.
6428 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
6429 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
6430 Eberhard W Lisse <el@linux.lisse.na>.
6432 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
6433 strerror.c. Bug reported by Alexandre Oliva
6434 <oliva@dcc.unicamp.br>.
6436 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
6437 (static var separate_case_tab) New var.
6438 (cmd_sort_cases) Cancel temporary transformations here. Free
6439 v_sort before return.
6440 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
6441 we're reading from a sort stream. Don't cancel temporary
6442 transformations. Offload internal sorting to do_internal_sort().
6443 (do_internal_sort) New function. Handles internal sorting even
6444 when SEPARATE is nonzero. Doesn't free v_sort.
6445 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
6447 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
6448 sink if SEPARATE is zero.
6449 (read_output_cases) Renamed read_sort_output(), all references
6450 changed. Now uses separate_case_tab when it exists.
6451 (write_separate) New function.
6453 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
6454 memory_sink_cases. Don't redundantly call
6455 vfm_source->destroy_source().
6456 (memory_stream_mode) After switching over, set memory_sink_cases
6459 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
6461 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
6463 (static var prev_case) New, moved out of aggregate_single_case()
6465 (static var buf64_10x, buf_10x) New.
6466 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
6467 the 000, 001, 100, and 101 cases. Free prev_case.
6468 (parse_aggregate_functions) Disallow scratch variables.
6469 (free_aggregate_functions) Only free agr_dict if non-null. Use
6470 iter->function to determine numeric/string type, not
6472 (aggregate_single_case) Don't manage prev_case. Initialize
6473 aggregate info after dumping it.
6474 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
6475 mean, stddev, weighted stddev definitions.
6476 (dump_aggregate_info) Implemented.
6477 (initialize_aggregate_info) Renamed from
6478 initialize_aggregate_functions(). Initializes dbl[2].
6479 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
6480 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
6482 * cases.c: (alloc_val) Removed.
6484 * get.c: (cmd_save_internal) Initialize new `dict' member.
6486 * sfm-write.c: (sfm_write_dictionary, write_header,
6487 write_variable, write_value_labels, write_documents) Reorganize,
6488 simplify for new parameter structure.
6489 (write_variable) Only one variable * argument now.
6491 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
6492 replaced by new `dict' member.
6494 * temporary.c: (new_dictionary) Initialize n_documents.
6496 * vars-atr.c: (dup_variable) Allocate `value's from dict into
6498 (init_variable, replace_variable) Eliminate usage of alloc_val().
6500 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
6502 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
6503 signal that AGGREGATE is to be used for forming final cases.
6504 (close_active_file) Call end_func before stopping lagging. Cancel
6505 temporary after finishing compaction.
6506 (write_case) Comment fixes. Cleaned up.
6507 (compact_case) Let AGGREGATE handle compaction when `temporary' is
6510 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
6512 * Makefile.am: (BUILT_SOURCES) Add means.c.
6513 (pspp_SOURCES) Add means.c.
6514 (EXTRA_DIST) Add means.q.
6516 * command.c: (array cmd_table[]) Add MEANS.
6518 * common.h: Esthetic fixes. Comment fixes. Test for
6519 MAX_SHORT_STRING greater than 8.
6520 (macros LOWEST, HIGHEST) New.
6522 * data-in.c, data-list.c, recode.c: Comment fixes.
6524 * means.q: New file, base version.
6526 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
6527 with LOWEST, DBL_MAX with HIGHEST.
6529 * q2c.c: (dump_vars) Add an enum to array types giving the number
6530 of values for the enum.
6532 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
6533 Replace second_lowest_value with second_lowest_flt64.
6535 * sfm-write.c: (write_variable, write_rec_7_34) Replace
6536 second_lowest_value with second_lowest_flt64.
6538 * t-test.q: Comment fix.
6540 * temporary.c: (restore_dictionary) Esthetic fix.
6542 * tokens.h: (force_match_id, force_match, force_string, force_int,
6543 force_num, force_id) Replace msg() with syntax_error().
6545 * var.h: (struct means_proc) New.
6546 (struct variable) Add mns member to `p' union.
6548 * vars-prs.c: (parse_variable, parse_dict_variable,
6549 parse_variables, parse_DATA_LIST_vars) Replace msg() with
6552 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
6554 * Makefile.am: (pspp_SOURCES) Add tab.h.
6556 * Most source files: Added a cast to unsigned char in usages of
6557 the ctype is*() functions. Replaced `end of command expected'
6558 calls to msg() with calls to syntax_error().
6560 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
6562 * lexer.c: (hex_val) Removed (was dead code).
6563 (idmatch) Parenthesize function name to avoid macro expansion.
6565 * postscript.c: Comment fixes.
6566 (ps_preopen_driver) Change default font size to 10pt.
6568 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
6570 (parse_format_spec) Change system-file format spec argument type
6571 to int32. Parse the format spec with bitwise operators.
6573 * sfmP.h: (struct sysfile_format) Removed.
6574 (struct sysfile_variable) Changed print, write members from
6575 sysfile_format to int32.
6577 * tokens.h: Esthetic fixes.
6578 [__GNUC__] (macro id_match) New macro to hopefully speed up
6579 identifier matching.
6580 (macros match_id, match_tok, match_int) Implemented in
6581 compiler-independent manner; no longer GNU C only.
6583 * vfm.h: Include time.h.
6585 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
6587 * data-list.c: (dump_fixed_table) Change tab_dim().
6589 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
6591 * error.c: Include command.h.
6593 * frequencies.g: Formatting fixes.
6595 * frequencies.q: Add tab_dim() calls. Make the total cell a
6598 * glob.c: Include command.h.
6600 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
6602 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
6603 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
6604 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
6605 the other elements (is this right?).
6606 (read_variables) Use lowest, highest members.
6607 (parse_format_spec) New arg `vv' for more stringent checking.
6608 (dump_dictionary) Byteswaps nonexplicit data.
6609 (sfm_read_case) Byteswap numeric data.
6611 * som.c: Initialize table_num to 1.
6612 (render_segments) Remember to increment y_index after each table
6615 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
6616 avl_count() on a NULL tree. No title for the second table.
6617 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
6618 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
6619 fix call to display_variables().
6620 (display_variables) Default to 4 columns, not 3. Set up headers.
6621 Column title is Variable, not Name. Fix index column.
6622 Add joint text. Add tab_dim(). Handle value labels properly.
6623 Handle DISPLAY LABELS properly. Draw boxes correctly.
6624 (describe_variable) Value labels don't need titles. Don't clear
6625 nonexistent index column.
6626 (compare_vectors_by_name) New function.
6627 (display_vectors) New function.
6629 * tab.c: (tab_height) Add assertion.
6630 (tab_null) Add debug code.
6631 (evaluate_dimensions) Add debug code.
6633 * var.h: (struct variable) get_proc data is sometimes used
6634 simultaneously with other per-procedure info, therefore it was
6635 removed from the union. All references changed.
6637 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
6639 * ascii.c: (ascii_close_page) Put title on second line of headers
6640 if there is no subtitle.
6642 * command.c: (glob var cur_proc) Move definition here, from
6644 (cmd_remark) Emit blank line before remarks.
6646 * command.h: (glob var cur_proc) Move declaration here, from
6649 * data-list.c: (dump_fixed_table) Fix messages.
6650 (dump_free_table) Call tab_nat_dim().
6652 * descript.q: (dump_z_table) Modify tab_dim() call.
6654 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
6656 (dump_statistics) Don't output header.
6658 * groff-font.c: Minor format fix.
6660 * html.c: Comment fix.
6662 * list.q: (write_varname) Indent after advancing page.
6664 * output.h: Minor reordering.
6666 * postscript.c: Comment fixes. Many places, '\n' was replaced by
6667 a reference to eol[].
6668 (struct ps_driver_ext) New member eol[].
6669 (ps_preopen_driver) Initialize eol[].
6670 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
6671 defaults. Handle headers. Fix test for minimum page length.
6672 (static var option_tab[]) Add `line-ends'.
6673 (ps_option) Handle line-ends to change eol[].
6674 (postopen) Scale prop_em_width and fixed_width properly. Set the
6675 prologue title to outp_title if applicable. Replace the prologue
6676 line ends with eol[]. Call draw_headers() if headers are enabled.
6677 (text_width) New function.
6678 (out_text_plain) New function.
6679 (draw_headers) New function.
6681 * print.c: (dump_table) Call tab_nat_dim().
6683 * som.c: (som_blank_line) Only advance a line if not at the top of
6685 (som_submit) Move several informational table calls here.
6686 Increment subtable_num if SOMF_NO_TITLE not set.
6687 (output_table) Advance a line if SOMF_NO_SPACING not set.
6688 (render_columns, render_segments, render_simple) Handle spacing
6689 between tables. Handle table titles. Remove debug output.
6691 * som.h: (SOMF_*) New enum series.
6692 (struct som_table_class) New member `flags'.
6694 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
6696 (display_variables) Calls tab_nat_dim().
6697 (describe_variable) Remove restriction on number of value labels.
6698 Make value labels separated by thin lines.
6700 * tab.c: (tab_create) Default `flags' to none.
6701 (tab_float) New arg `w'. All references changed.
6702 (tab_nat_dim) New function.
6703 (tab_output_text) No title or spacing.
6704 (tab_flags) New function.
6705 (tabi_flags) New function.
6706 (tabi_title) New function.
6707 (strip_height) Removed.
6708 (tabi_render) Skip title when necessary.
6709 (static var tab_tab_class) Add tabi_flags, tabi_title.
6710 (evaluate_dimensions) Disable display of column, row size.
6711 (sum_columns) Add title height to top header.
6712 (render_strip) Moved within file.
6714 * tab.h: (struct tab_table) New member `flags'.
6716 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
6718 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
6720 * Most source files: Add `const' attribute in all appropriate
6723 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
6724 column to the variables table for use by describe_variable().
6725 (cmd_display) Disable for the present.
6726 (display_documents) Don't wrap documents.
6727 (display_variables) Table has four columns now.
6728 (describe_variable) Table has four columns now. Don't use a
6729 subtable, use joined cells instead.
6731 * tab.c: (tab_create) Don't set `join'.
6732 (tab_realloc) ct array is not made up of a_string's.
6733 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
6734 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
6735 (text_format) New function.
6736 (tab_title) Rewritten, uses text_format().
6737 (tab_text) Rewritten, uses text_format().
6738 (tab_joint_text) New function.
6740 (static var hit) New variable.
6741 (render_strip) New args r1, r2. Implement joined cells that fit
6743 (tabi_render) Increment hit. Pass new args to render_strip().
6744 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
6745 cells. For t_naw and t_nah, ignore joined cells and null cells in
6748 * tab.h: (struct tab_join_rect) Removed.
6749 (struct tab_table) Removed `join'.
6750 (TAB_JOIN_MAIN) Removed.
6751 (struct tab_joined_cell) New struct.
6752 (TAT_NOWRAP) New enum.
6754 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
6756 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
6758 (ascii_postopen_driver) Fix initialization of *_spacing so that
6759 the TAL_0 bit doesn't count.
6761 * data-list.c: (dump_fixed_table) Use natural width for Format
6764 * glob.c: (rerange) Removed.
6765 (get_date) Formatting fixes. Internationalization fix.
6767 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
6770 * postscript.c: (ps_postopen_driver) Replace
6771 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
6773 * som.c: (som_submit) Don't eject page before every table.
6774 (output_table) Fix order of arguments on call to area().
6775 (render_columns) Fix calculation of max_len.
6777 * tab.c: (tabi_cumulate) Minor change to increase elegance.
6778 (render_strip) New function.
6779 (strip_height) New function.
6780 (tabi_render) Rewrite as calls to render_strip().
6782 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
6783 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
6784 with the TAB_* and OUTP_T_* constants.
6786 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
6788 * Makefile.am: Formatting fixes.
6790 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
6793 * data-list.c: (dump_fixed_table) Add tab_dim() call.
6795 * descript.q: (dump_z_table, display) Add tab_dim() calls.
6797 * dump-sysfile.c: (glob var length) Make type off_t.
6798 (usage) Fix arguments.
6801 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
6802 Now right-justification is the default so many references had to
6804 (struct outp_class) Removed line_width, all references changed.
6805 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
6806 (struct outp_driver) Add elements horiz_line_width,
6807 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
6810 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
6812 (postopen) Initialize all the informational members of
6815 * som.c: (som_blank_line) New function, renamed from blank_line(),
6816 all references changed.
6817 (som_submit) Disables drivers whose pages can't be opened.
6818 (render_columns, render_simple, render_segments) Add debug output.
6819 (render_columns) Fix loop range.
6820 (render_simple) Don't try to render the headers, they're taken
6821 care of automatically. Advance cp_y past the table when done.
6822 (render_segments) Fix loop ranges.
6824 * tab.c: Initialize new members of tab_table.
6825 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
6826 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
6827 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
6830 (tab_dim) New function.
6831 (tab_col_width) Removed.
6832 (tab_row_height) Removed.
6833 (tab_output_text) Call tab_dim().
6834 (tabi_driver) Call evaluate_dimensions(), sum_columns().
6835 (tabi_area) Implemented.
6836 (tabi_cumulate) Implemented.
6837 (tabi_render) Partially implemented, but broken.
6838 (var tab_table_class) Made static.
6839 (evaluate_dimensions) New function.
6840 (sum_columns) New function.
6842 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
6843 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
6844 t_scr, t_srr, t_sentinel. Removed: t_nat.
6845 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
6846 max_stack_height, w, h. Removed: ce, re.
6847 (macro blank_line) Removed.
6848 (glob var zero_length) Removed.
6850 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
6852 * Most source files: include some of the new include files broken
6855 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
6858 * aggregate.c: (glob var outfile) Make static.
6860 * command.c: (glob var pgm_state) Move here.
6862 * common.c: (glob vars endian, second_lowest_value, pgmname,
6863 finished, curdate, cur_proc, start_interactive, history_file) Move
6866 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
6868 * file-handle.q: (glob vars files, inline_file) Move here.
6870 * glob.c: Lost lots of glob vars, detailed in individual file
6872 (init_glob) set_printer, set_screen were obsolete, deleted.
6873 set_cprompt has fewer spaces because pspp has fewer letters than
6876 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
6877 (inp_nval) Made static.
6879 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
6880 tokstr_len, toklongstr, tokint) Move here.
6882 * misc.c: Lost several vars and functions.
6884 * set.q: (all the set_* variables) Move here.
6886 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
6887 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
6890 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
6892 * tab.h: (enum series t_*) New enums.
6893 (struct tab_table) Use arena struct tag. New members ce, re.
6895 * tokens.h: Comment fixes.
6897 * var.h: Move lots of enums and variables and functions and
6898 structures to other files. Use and declare a lot more union and
6899 struct tags. Comment fixes.
6901 * vector.c: (glob vars vec, nvec) Move here.
6903 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
6904 init_blanks, last_vfm_invocation) Move here.
6906 * cases.h: New file.
6907 (struct long_vec) Move here.
6908 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
6911 * command.h: New file.
6912 (STATE_* enums) Move here.
6913 (glob var pgm_state) Move here.
6915 * format.c: New file.
6916 (glob var formats) Move here.
6917 (parse_format_specifier_name, fmt_to_string,
6918 check_input_specifier, check_output_specifier,
6919 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
6922 * format.h: New file. Move functions now in format.c here.
6923 (FMT_* enums) Move here.
6924 (struct fmt_desc) Move here.
6925 (FCAT_* enums) Move here.
6926 (struct fmt_spec) Move here.
6927 (glob vars formats, fmt_parse_ignore_error) Move here.
6929 * inpt-pgm.h: New file.
6930 (INP_* enums) Move here, make #defines into enums.
6931 (glob vars inp_init, inp_init_size) Move here.
6934 (glob vars v_sort, nv_sort) Move here.
6935 (sort_cases, read_sort_output) Move here.
6937 * vector.h: New file.
6938 (struct vector) Move here, add struct tag.
6939 (glob vars vec, nvec) Move here.
6940 (find_vector) Move here.
6943 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
6944 reinit_blanks, init_zero, init_blanks) Move here.
6945 (struct case_stream) Move here.
6946 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
6947 vfm_disk_stream, sort_stream, data_list_source,
6948 input_program_source, file_type_source, get_source, n_lag) Move
6950 (procedure, write_case, lagged_case, compact_case, page_to_disk)
6953 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
6955 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
6956 (LDADD) Add libdcdflib.
6958 * ascii.c: Comment and formatting fixes. Almost every external
6959 function had an assert added, checking driver_open and page_open.
6960 (ascii_init_driver) Broken into ascii_preopen_driver,
6961 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
6962 (ascii_open_page) Sets page_open.
6963 (ascii_close_page) Clears page_open.
6965 * html.c: Comment and formatting fixes. Almost every external
6966 function had an assert added, checking driver_open and page_open.
6967 (html_init_driver) Broken into html_preopen_driver,
6968 html_postopen_driver, html_close_driver. Manages driver_open.
6969 (html_open_page) Sets page_open.
6970 (html_close_page) Clears page_open.
6971 (html_submit) Disabled.
6973 * lexer.c: (parse_string) Remove debugging printf.
6975 * list.q: (determine_layout) Open a page if one is not yet open.
6977 * output.c: Comment fixes.
6978 (add_class) Set the class member of the new list element.
6979 (parse_options) Don't handle device type.
6980 (colon_tokenize) New function.
6981 (configure_driver) New four-field format with a field for device
6982 type. Now initialize driver_open, page_open, next, and prev
6983 fields. Use new colon_tokenize() function. Don't do a memory
6984 copy to replace a driver, it doesn't work; instead delete the old
6985 driver and insert a new one.
6986 (destroy_driver) Don't call som_destroy_driver(). Close the page
6987 if it's open. Find the class in the list of classes and decrement
6988 that reference count. Remove the driver from the global driver
6990 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
6991 references changed. Rewritten. Don't return a driver that's not
6993 (outp_eject_page) All references to som_internal_eject_page()
6994 changed to use this. Sets cp_x to 0 as well as cp_y.
6996 * output.h: (OUTP_I_* enums) Removed.
6997 (struct som_submission_form) Removed.
6998 (struct outp_class) init_driver broken into preopen_driver,
6999 postopen_driver, and close_driver. submit changed to take a
7002 * postscript.c: Comment and formatting fixes. Almost every
7003 external function had an assert added, checking driver_open and
7005 (ps_init_driver) Broken into ps_preopen_driver,
7006 ps_postopen_driver, ps_close_driver. Manages driver_open.
7007 (ps_open_page) Sets page_open.
7008 (ps_close_page) Clears page_open.
7010 * som.c: New file, base implementation.
7012 * som.h: (struct som_table) Add struct tag.
7013 (enum SOM_COL_ACROSS) Removed.
7014 (SOM_ROWS, SOM_COLUMNS) New enums.
7015 (struct som_table_class) Add member `cumulate'. Remove `segment';
7016 change `render' arguments.
7017 (struct som_point, struct som_rect) Removed.
7018 (som_submit_table) Fixed typo, should have been som_submit.
7020 * sysfile-info: (describe_variable) Don't try to insert a
7021 subtable; just destroy it for now.
7023 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
7024 references to value labels.
7026 * tab.c: (tab_destroy) New function.
7027 (tab_columns) Change argument.
7028 [0] (tab_submit) Remove dead code.
7029 (tab_title) Allocate string from the table's arena.
7030 (tab_output_text) Only free the buffer if we allocated it.
7031 (tab_submit) New function.
7032 (static vars t, d) New static vars.
7033 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
7034 tabi_headers, tabi_cumulate, tabi_render) New functions.
7035 (glob var tab_table_class) New global var.
7037 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
7038 encapsulate the rectangle. All references changed.
7040 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
7042 * All header files updated to use struct tags in addition to
7043 typedefs for all structures. Don't use word `struct' in struct
7046 * Makefile.am: (pspp_SOURCES) Remove html.c.
7047 (INCLUDES) Replace the lib/* includes with a single lib/ include;
7048 all references updated.
7050 * command.c: (parse_cmd) Remove call to som_check_workspace.
7051 (output_line) Update to new som.
7053 * data-in.c: (parse_numeric) A single dot is not an error; it is
7054 the system-missing value.
7056 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
7059 * data-out.c: Added `const' as appropriate to many prototypes.
7060 (convert_E, convert_F, convert_CCx) Take double argument instead
7061 of value * argument.
7062 (convert_format_to_string) Call changed functions appropriately.
7063 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
7064 make a local copy of the value.
7066 * descript.q: Remove custom_variables() prototype now provided by
7068 (custom_variables) Don't increment sbc_variables, the caller does
7070 (dump_z_table, display) Update to new som.
7072 * error.c: (vmsg) Add const to prototype. Remove code to handle
7073 `too many errors' condition.
7074 (check_error_count) New function.
7075 (msg) Add const to prototype.
7077 * filename.c: (open_file) Rewrite for elegance.
7079 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
7080 (dump_full, dump_condensed, dump_statistics) Update for new som.
7082 * list.q: Don't include somP.h. Change all references to
7083 som_driver_ext to refer to the new members of som_driver. Change
7084 som_internal_eject_page() references to outp_eject_page().
7086 * main.c: (parse) Rewrite for elegance. Add call to
7087 check_error_count().
7089 * output.c: (add_class, outp_list_classes, outp_configure_driver)
7090 Rewrite or revise for new outp_driver_class_list structure.
7091 (outp_iterate_enabled_drivers) Fix comparison between disabled
7092 devices and current device type.
7093 (outp_eject_page) New function.
7095 * output.h: Comment fixes.
7096 (struct outp_driver) New members driver_open, page_open, cp_x,
7097 cp_y, font_height, prop_em_width, fixed_width. Deleted members
7099 (struct outp_driver_class_list) New struct.
7100 (outp_class_list) Changed to type outp_driver_class_list; all
7103 * print.c: (dump_table, print_trns_proc) Updated for new som.
7105 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
7106 prototypes for custom subcommands.
7107 (dump_subcommand) Always include the `else'.
7108 (dump_parser) Fix comments in output code.
7110 * set.q: Reordered functions.
7112 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
7114 * som.h: Rewritten from scratch.
7116 * str.h: Remove dead code.
7118 * tab.c, tab.h: New files, base implementation.
7120 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
7123 * t-test.q: New code from John Williams
7124 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
7125 Many many new static vars and defines.
7126 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
7127 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
7128 (struct value_list) New struct.
7129 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
7130 t_crt, t_sig, print_t_groups) New functions.
7131 (cmd_t_test) Implemented.
7133 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
7136 * vfm.c: (dump_splits) Update to new som.
7138 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
7140 * Makefile.am: (fiasco_SOURCES) Add html.c.
7142 * aggregate.c: Base source.
7144 * ascii.c: (postopen, preclose) Reformat.
7146 * data-out.c, expr-evl.c: Comment fixes.
7148 * filename.c: (open_file) When opening a file for writing, use
7149 line buffering instead of full buffering for better interactive
7150 performance. Suggested by Valerio Aimale
7151 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
7152 names `stdin', `stdout', `stderr'.
7154 * groff-font.c: Comment fixes.
7156 * html.c: New file; base version.
7158 * list.q: (write_all_headers, clean_up, determine_layout,
7159 list_cases) Ignore `special' devices for now. Needs to be fixed
7162 * output.c: (outp_init) Add html driver to list; reverse list
7165 * output.h: (struct outp_class_struct) New members `special',
7166 `submit'; comment fixes. All references changed.
7168 * postscript.c: (ps_init_driver) Make defaults for text_opt,
7169 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
7171 (postopen) Comment fix.
7172 (preclose) Comment fixes, formatting fixes. Change x->file.file
7173 references to more proper f->file.
7175 * som-high.c: (som_submit_table) Special classes use their own
7178 * som.h: Comment fixes.
7180 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
7183 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
7185 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
7187 * aggregate.c: Still working on this.
7189 * command.c: (cmd_table[]) Add AGGREGATE back in.
7190 (split_words) Make '-' a legal word separator as well as ' '.
7192 * main.c: Comment fixes.
7194 * q2c.c: (dump_parser) Don't require the procedure's full name to
7195 be present, in the generated source.
7197 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
7198 multiply specified and let it be default; let MISSING, CRITERIA,
7199 FORMAT be multiply specified.
7200 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
7201 (custom_groups) Fix defaults.
7202 (custom_pairs) Check whether this is a PAIRS subcommand before
7203 attempting to parse. Better garbage collection. Proper storage
7205 [DEBUGGING] (debug_print) New function.
7207 * temporary.c: Comment fixes.
7208 (copy_variable) Don't copy variable name and index.
7209 (save_dictionary) Copy variable name and index by hand.
7211 * vars-atr.c: Comment fixes.
7212 (create_variable) New dictionary argument. All references
7214 (common_init_stuff) New dictionary argument. All references
7216 (init_variable) New dictionary argument. All references changed.
7217 (dup_variable) New function.
7219 * vars-prs.c: (parse_variables) If there are any errors, we always
7220 return 0. Previously, it was possible for some types of errors to
7223 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
7225 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
7228 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
7230 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
7233 * q2c.c: Comment fixes.
7234 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
7236 * t-test.q: (cmd_list) Rename cmd_t_test.
7238 * temporary.c: (new_dictionary) Don't declare as static.
7240 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
7242 * aggregate.c: Changes, still not finished.
7244 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
7246 * q2c.c: Comment fixes. Now its output is internationalized.
7247 (get_token) Fix parsing of escapes within literal strings.
7248 (main) Fix bad #line directives in output.
7250 * t-test.q: Base implementation.
7252 * temporary.c: (new_dictionary) New function.
7253 (restore_dictionary) [__CHECKER__] Change fill character to *
7256 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
7258 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
7260 * aggregate.c: Changes, still not finished.
7262 * descript.q, list.q: Comment fixes.
7264 * q2c.c: Almost completely rewritten.
7266 * t-test.q: New file, not complete.
7268 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
7270 * aggregate.c: Changes, still not finished.
7272 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
7275 * temporary.c: (cancel_temporary) New function.
7277 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
7278 of doing it by hand.
7280 * vfm.c: (close_active_file) After restoring a TEMPORARY
7281 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
7283 (SPLIT_FILE_procfunc) Comment fix.
7285 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
7287 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
7289 * aggregate.c: New file, not finished yet.
7291 * command.c: (cmd_table) Add AGGREGATE.
7293 * common.h: (pgm_state) Move declaration to var.h.
7295 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
7297 (parse_string) Message fix.
7299 * recode.c: Comment fix.
7301 * sfm-read.c: (read_variables) Code esthetic fixes.
7302 (write_header) Default date is `Jan', not `JAN'.
7304 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
7306 * sort.c: (cmd_sort_cases) Farm the work out to new function
7307 parse_sort_variables().
7308 (parse_sort_variables) New function.
7309 (sort_cases) New function. Cancels temporary transformations,
7310 which sorting didn't do previously.
7311 (cmd_sort_cases) Better garbage collection on error. Uses
7313 (write_initial_runs, merge_once) Improved code esthetics.
7314 (sort_stream_read) Reduced to one call to read_output_cases().
7315 (read_output_cases) New function.
7317 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
7318 variable labels to 120 characters.
7320 * var.h: Comment fixes.
7321 (glob var pgm_state) From common.h.
7323 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
7325 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
7326 options. Set *names to NULL on error.
7328 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
7330 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
7332 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
7333 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
7335 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
7337 * vfm.c: (page_to_disk) Added missing local variables.
7339 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
7341 * get.c: Comment fix.
7343 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
7344 source is anything other than a disk stream, not just if it's in a
7345 memory stream. Call page_to_disk() before external sort.
7346 (allocate_cases) Message fix.
7348 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
7350 (page_to_disk) New function.
7352 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
7354 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
7356 * common.h: (macro strerror) Remove. From Alexandre Oliva
7357 <oliva@dcc.unicamp.br>.
7359 * get.c: (dict_delete_run) The number of variables to delete is
7360 not necessarily the number of variables that need to be shifted
7362 (trim_dictionary) Don't set *options to 0. Fix bug that caused
7363 too many variables to be deleted.
7365 * postscript.c: Comment fix.
7367 * q2c.c: Include strerror.c. From Alexandre Oliva
7368 <oliva@dcc.unicamp.br>.
7370 * set.q: #undef ON and OFF. From Alexandre Oliva
7371 <oliva@dcc.unicamp.br>.
7373 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
7374 early, otherwise errors cause a bad free().
7376 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
7377 Oliva <oliva@dcc.unicamp.br>.
7379 * temporary.c: (save_dictionary) Don't allocate memory if
7382 * vfm.c: (memory_stream_write) Message fix.
7384 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
7386 * command.c: (static var cmd_table[]) Define REPEATING DATA
7389 * common.h: Added support for broken systems that are missing
7390 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
7392 * Many source files: Replace syntax error messages via msg() with
7393 call to syntax_error().
7395 * data-list.c: (dump_fixed_table) Add support for dumping table
7396 for REPEATING DATA as well as DATA LIST FIXED.
7397 (cmd_repeating_data) Allows and requires `/' between subcommands.
7398 Does proper thing with allowing rpd.starts_end to stay 0. Allows
7399 CONTINUED specifications to be omitted. Forces CONTINUED to be
7400 specified if ID is. Calculates starts_end, cont_end from logical
7401 record length as reported by fhp. Calls dump_fixed_table() if
7402 requested. Fixed length of record copied by memcpy.
7403 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
7405 (realize_value) Returns sensible value for out-of-range variable
7407 (rpd_parse_record) New argument `ofs'. Fixed confusion between
7408 length of occurrences and length of line. Added warning for
7409 fields that exceed the line length. Fixed infinite loop.
7410 (read_one_set_of_repetitions) Numerous minor changes for more
7411 complete SPSS compliance. Message fixes.
7413 * dfm.c: (dfm_close) If the file being closed is the inline file,
7414 read all the remaining data before closing it.
7415 (dfm_get_record) Don't close the file on lossage, as either it
7416 has been closed already or it doesn't belong to us.
7418 * error.c: (puts_stdout) New function.
7419 (vmsg) Use puts_stdout instead of puts.
7421 * file-handle.q: (fh_record_width) New function.
7423 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
7426 (input_program_source_read) Made an old kluge an approved method.
7428 * lexer.c: (syntax_error) New function.
7430 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
7433 * output.c: (oupt_get_paper_size) Message fix.
7435 * q2c.c: Numerous fixes to formatting of generated code made to
7436 conform to GNU coding standards. Uses syntax_error() in generated
7437 code. Other miscellaneous generated message fixes. Added support
7438 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
7439 RAND_MAX, and/or strerror().
7441 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
7443 * data-in.c: Comment fixes.
7445 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
7446 (find_variable_input_spec) New function.
7447 (cmd_repeating_data) Initializes id_spec.
7448 (rpd_parse_record) Implemented.
7449 (read_one_set_of_repetitions) Returns -3 by default in order to
7450 kluge out some potential bugs.
7452 * data-out.c: Comment fixes.
7454 * file-type.c: (internal_cmd_record_type) Message fix.
7456 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
7457 for handling -3 return value.
7459 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
7461 * data-list.c: Comment fixes.
7462 (struct dls_var_spec) Reordered members.
7463 (read_from_data_list_fixed) Restructured.
7464 (struct repeating_data_trns) Reordered members. Renamed `starts'
7465 as `starts_beg', `ends' as `starts_end'.
7466 (cmd_repeating_data) Calculates length of repeated data if
7467 necessary and possible.
7468 (parse_num_or_var) Don't allow string variables.
7469 (realize_value) New function.
7470 (rpd_msg) New function.
7471 (rpd_parse_record) New function. Currently stubbed out.
7472 (read_one_set_of_repetitions) Implemented.
7474 * inpt-pgm.c: (input_program_source_read) Comment fix.
7476 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
7478 * command.c: (cmd_end_repeat_p) Removed.
7479 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
7480 (parse_cmd_name) Removed.
7482 * data-list.c: Comment fixes.
7483 (data_list_pgm) Removed `eof' member.
7484 (static var first) New var.
7485 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
7486 FILE TYPE file inside FILE TYPE structures.
7487 (append_var_spec) Appends to *first, not dls.spec.
7488 (parse_fixed) Message fixes.
7489 (struct rpd_num_or_var) New.
7490 (struct repeating_data_trns) New.
7491 (static var rpd) New.
7492 (cmd_repeating_data) New function.
7493 (parse_num_or_var) New function.
7494 (parse_repeating_data) New function.
7495 (read_one_set_of_repetitions) New function.
7497 * file-type.c: (cmd_file_type) Message fixes. Always
7498 default_handle to FILE TYPE file handle.
7499 (internal_cmd_record_type) Message fixes.
7501 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
7503 * repeat.c: Comment fix. Disable debugging.
7505 * temporary.c: (restore_dictionary) Sets splits to NULL and
7506 n_splits to 0 before destroying the variables because now doing
7507 this tries to remove split variables.
7509 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
7510 destroying the dictionary.
7511 (clear_variable) Removes a variable from splits after destroying
7514 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
7516 * cmdline.c: (set_compat) Removed.
7517 (pick_compat) Removed.
7518 (parse_command_line) Removed -c option.
7519 (pre_syntax_message) Removed -c option.
7520 (usage) Remove compatibility code.
7522 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
7523 (glob var compat) Removed.
7525 * compute.c: (type_check) Fixed messages about type mismatches.
7527 * data-list.c: (cmd_data_list) Removed compatibility code.
7528 (fixed_parse_compatible) Calls convert_negative_to_dash().
7529 Fixed bug where it only set the variable in fx.spec if it created
7530 the variable itself.
7531 (dump_fmt_list) Spelling fix.
7532 (cut_field) Removed compatibility code.
7534 * dfm.c: (cmd_begin_data) Don't require a command terminator on
7537 * expr-evl.c: (evaluate_expression) Implement LAG.
7539 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
7540 (parse_neg) Calls convert_negative_to_dash().
7541 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
7544 * expr.h: (struct expression_struct) Removed member max_lag.
7546 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
7547 (internal_cmd_record_type) Removed special handling to produce
7548 negative numbers from dash tokens.
7550 * getline.c: (static var DO_REPEAT_level) New var.
7551 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
7552 (handle_line_buffer) Copies the line into getl_buf; doesn't call
7553 copy_with_DO_REPEAT_substitutions().
7554 (getl_read_line) Maintains value of getl_mode. Calls
7555 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
7557 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
7559 * getline.h: (getl_mode) New glob var.
7561 * glob.c: Comment fixes.
7562 (init_glob) Restructured. Sets set_seed.
7563 (init_compat_dependent) Removed. All references removed.
7564 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
7565 (__htonl, __htons) Removed. (What were these for?)
7567 * lexer.c: (static var tbl) Dash set to class CNUM.
7568 (make_hexit) New function from data-out.c.
7569 (get_token_representation) Rewritten.
7570 (convert_negative_to_dash) New function.
7571 (lex_init_compat_dependent) Removed.
7572 (yylex) A dash is parsed as part of a number if it is followed by
7573 a digit. The ASCII representation of a number is copied to
7574 tokstr. String parsing farmed out to parse_string(). Comment
7576 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
7578 (preprocess_line) Line processing depends on interactive/batch
7579 mode, not on compatibility mode. Removed PC+ compatibility code.
7581 * loop.c: (loop_3_trns_proc) Comment fix.
7583 * main.c: Remove dead code.
7584 (main) Remove call to init_compat_dependent().
7586 * misc.c: (convert_fmt_ItoO) Make E format conversion more
7589 * print.c: (parse_string_argument) Calls
7590 convert_negative_to_dash().
7591 (fixed_parse_compatible) Calls convert_negative_to_dash().
7593 * repeat.c: (RPT_* defines) Removed.
7594 (struct rpt_numeric) Removed.
7595 (struct repeat_entry) New member type, changed `replacement' from
7597 (clean_up) Deallocation adapted to new repeat_entry.
7598 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
7599 usage. Creates vars for `type' of 1.
7600 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
7601 (store_numeric) Rewritten, new interface.
7602 (parse_numbers) Rewritten.
7603 (parse_strings) Rewritten.
7604 (find_DO_REPEAT_substitution) New function.
7605 (perform_DO_REPEAT_substitutions) New function.
7606 (copy_with_DO_REPEAT_substitutions) Removed.
7607 (debug_print) Rewritten.
7609 * set.q: Comment fix.
7610 (custom_results) Removed compatibility code.
7611 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
7614 * sysfile-info.c: (cmd_display) Removed compatibility code.
7616 * tokens.h: Comment fixes.
7617 (token types enum) Removed `toktype' typedef name for this int
7618 type. Removed SUBST. Restructured.
7620 * vars-atr.c: (discard_variables) Sets n_lag to 0.
7622 * vars-prs.c: Comment fix.
7624 * vfm.c: Comment fixes.
7625 (glob var n_lag) New var.
7626 (static vars lag_count, lag_head, lag_queue) New vars.
7627 (procedure) Removed argument nlag.
7628 (setup_lag) New function.
7629 (close_active_file) Discards lagging state.
7630 (lag_case) New function.
7631 (lagged_case) New function.
7632 (write_case) Lags a case if lagging.
7634 * weight.c: (cmd_weight) Removed compatibility code.
7636 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
7638 * getline.h: (struct getl_script) New members loop_index, macros.
7640 * getline.c: (getl_add_file) Sets first_line field to NULL.
7641 (getl_add_DO_REPEAT_file) New function.
7642 (handle_line_buffer) When the current line's length is negative,
7643 set the filename and line number. Increment line number after
7644 reading line. Pass the line to
7645 copy_with_DO_REPEAT_substitutions() for processing.
7646 (getl_close_file) Free DO REPEAT lines before freeing the
7647 filename, and just set the filename to NULL when doing this,
7648 because otherwise the filename gets freed twice.
7650 * glob.c: (glob var queuing) Removed. All references removed.
7652 * lexer.c: Comment fixes.
7653 (get_token_representation) New function.
7655 * repeat.c: Comment fixes.
7656 (struct repeat_entry) Replaced type and v union members with a
7658 (append_record) New function.
7659 (internal_cmd_do_repeat) Started reforming it for the new
7660 repeat_entry struct. Properly records filename changes in the
7661 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
7662 strncasecmp() result usage. Uses append_record() to simplify.
7663 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
7666 (copy_with_DO_REPEAT_substitutions) Started coding.
7668 [DEBUGGING] (debug_print_lines) New function.
7670 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
7672 * tokens.h: (macro is_id1, is_idn) New macros.
7674 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
7676 * cmdline.c: (static var pre_syntax_message) Changed `win'
7677 compatibility mode to `wnd'.
7679 * data-list.c: (fixed_parse_spss) Renamed
7680 fixed_parse_compatible().
7682 * glob.c: (init_glob) Excise unused code for
7683 program_invocation_short_name.
7685 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
7688 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
7690 * set.q: `win' compatibility renamed `wnd'.
7692 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
7694 * filename.c: [__WIN32__] Change the included Windows header files
7696 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
7697 second character is absolute.
7698 (dirname) Fix logic error. Don't printf() the results.
7699 (prepend_dir) Don't printf() the results.
7701 * getline.c: (handle_line_buffer) New function.
7702 (getl_read_line) Reads line with handle_line_buffer() when
7704 (getl_close_file) Discard line buffer data.
7706 * getline.h: Comment fixes.
7707 (struct getl_line_list) New struct.
7708 (getl_script_struct) Added line buffer members. These are hooks
7709 for use by DO REPEAT to allow it to insert virtual source code
7712 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
7713 Override Borland C++ stupidity that claims Windows has a console
7716 * repeat.c: This is in the process of being restructured from
7717 using a token-buffering approach to the DO REPEAT facility to
7718 using the more flexible approach of a line-buffering approach in
7719 conjunction with the getline module. Comment fixes.
7720 (struct tok_struct) Removed.
7721 (static vars queue_index, queue_head, queue) Removed.
7722 (static vars line_buf_head, line_buf_tail) New vars.
7723 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
7725 (pull_queue, destroy_queue) Removed.
7726 [DEBUGGING] (debug_print_tokens) Removed.
7728 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
7730 * file-handle.q: (prepend_current_directory) New function.
7731 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
7732 current directory before normalizing filename.
7734 * filename.c: (gnu_getcwd) New function.
7735 (absolute_filename_p) New function.
7736 (search_path) New argument, PREPEND. All references changed to
7737 pass NULL except those explicitly mentioned. Uses
7738 absolute_filename_p(). Prepends PREPEND before trying the
7740 (dirname, prepend_dir) New functions.
7742 * getline.c: (getl_get_current_directory) New function.
7743 (getl_include) Passes getl_get_current_directory() as PREPEND arg
7746 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
7748 * In several source files, the term `script' was replaced with
7749 `syntax file' inside error messages. Usage of the term `script'
7750 in the sense of a syntax file is now deprecated.
7752 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
7755 * dump-sysfile.c: (usage) Update message.
7757 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
7759 * getline.h: (glob var getl_include_path) Declare extern.
7761 * list.q: Define EXTERN as extern before #including somP.h.
7763 * var.h: Remove declaration of `disptype' variable.
7765 * vfm.c: (close_active_file) After switching the data sink to a
7766 data source, set vfm_sink to NULL, because it doesn't exist any
7769 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
7771 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
7772 _matherrl() to ignore all math errors.
7774 * sfm-read.c: (read_value_labels) When reading the labels from
7775 disk, read the little parts separately instead of as a struct;
7776 this avoids alignment problems.
7778 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
7779 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
7780 (write_header) Allocates and initializes elem_type.
7781 (sfm_write_case) Uses elem_type to determine how to handle each
7783 (sfm_close) Frees elem_type.
7785 * sfmP.h: Comment fix.
7786 [__BORLANDC__] Uses #pragma -a to adjust structure member
7789 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
7791 * Makefile.am: (fiasco_SOURCES) Remove display.c.
7793 * common.c: Fix typo.
7795 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
7796 sense of the condition.
7798 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
7799 line-continuation backslash.
7801 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
7803 * frequencies.q: (custom_grouped, add_percentile) Don't use a
7804 non-constant expression as an argument to sizeof.
7806 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
7807 undefine gettext macro because that's a conio function.
7809 * hash.h: (hsh_prime_tab declaration) Remove.
7811 * list.q: (write_fallback_headers) Move `leader' allocation out of
7812 main loop. Change to local_alloc() allocation.
7814 * output.h: Formatting fixes. Put __attribute__ in right place on
7815 function prototypes.
7817 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
7818 incorrect `SECOND_LOWEST_VALUE' references to proper
7819 `second_lowest_value'.
7821 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
7822 value. This way 2 out of 3 of the som files define the vars
7823 extern, the correct way, that actually works under BC++.
7824 (som_set_float) Don't use nonconstant initializers for a struct.
7826 * som-high.c: Add the standard alloca() header.
7827 (replicate_table) Add prototype.
7829 Merged DISPLAY routine.
7830 * sysfile-info.c: (AS_*) New enum series.
7831 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
7833 (cmd_display, display_macros, display_documents,
7834 display_variables) Stolen from defunct display.c.
7835 (describe_variable) New function.
7837 * temporary.c: [0] (display_tree) New debug function.
7838 (copy_variable) Performs shallow copy of value labels instead of
7839 deep copy; i.e., just copys the AVL tree and increments the
7842 * val-labs.c: Comment fixes.
7843 (do_value_labels) Optionally skip leading forward slash.
7844 (get_label) Creates only a single value label instead of many
7845 copies of one, and sets the reference count.
7847 * display.c: Removed.
7849 * dump-sysfile.c: New file, not yet complete.
7851 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
7853 For lots of source files I added more verbose_msg's. These aren't
7854 listed below as they have tested as being benign. In some cases
7855 these replaced debug_printf() calls.
7857 * output.c: (outp_read_devices) Message fix.
7859 * postscript.c: (output_encodings) Message fix. Reports errors on
7861 (postopen) Message fix.
7863 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
7865 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
7867 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
7870 * main.c: Remove <malloc.h> #include.
7872 * mis-val.c: (parse_numeric) Set .f member for each missing[]
7873 instead of trying to just set the missing[] itself, which is a
7876 * sfm-read.c: (read_variables) Same.
7878 * str.h: Add memmem() prototype.
7880 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
7882 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
7884 * Makefile.am: (q2c) Don't include any libraries in the link.
7886 * dfm.c: (force_line_buffer_extension) New macro.
7887 (count_tabs) New function.
7888 (tabs_To_spaces) New function.
7889 (read_record) Calls tabs_to_spaces() on the line being processed.
7891 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
7892 have to be compiled twice (once for CC, once for LOCAL_CC).
7894 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
7896 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
7897 (LDADD) Add @INTLLIBS@.
7898 (q2c) Add LIBS, @INTLLIBS@ to link step.
7900 * inpt-pgm.c: Turn off debugging.
7902 * postscript.c: (postopen) Format fix. local_free() blocks
7903 returned by local_alloc(); don't free() them.
7905 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
7907 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
7910 * data-list.c: (read_from_data_list_fixed) Pass proper value for
7911 LEN arg, not simply the full string length.
7913 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
7914 directories before generic temp file directories.
7916 * vfm.c: Disable debugging.
7918 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
7920 * get.c: Comment fix.
7921 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
7923 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
7925 * expr-prs.c: (debug_print_postfix) Conditionally included on
7926 GLOBAL_DEBUGGING. Removed out_header() reference.
7928 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
7930 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
7932 * ascii.c: Removed obsolete ascii_close_page() prototype.
7934 * command.c: (output_line) Comment fix.
7936 * data-in.c: Formatting fix.
7937 (parse_string_as_format) Now the `fc' argument is used only for
7938 the purpose of error messages; it is not an index into the string
7939 passed. All references changed.
7941 * data-list.c: Comment fix.
7942 (cut_field) Comment fix. Now returns the column number of the
7943 position of the field cut out on success.
7944 (parse_field) Added `column' argument. Puts the column numbers in
7946 (read_from_data_list_free, read_from_data_list_list) Record the
7947 column number returned by cut_field(), pass it to parse_field().
7949 * dfm.c: Comment fix.
7951 * do-ifP.h: Comment fix.
7953 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
7954 the SYSMIS function.
7956 * expr.h, exprP.h: Comment fix.
7958 * glob.c: (init_glob) Only calls setlocale() and family if
7961 * hash.h: Comment fix.
7963 * include.c: Comment fix.
7965 * output.c: Comment fix.
7967 * postscript.c: (ps_line_intersection) Simplified assertion.
7969 * repeat.c: Comment fix.
7971 * vars-atr.c: Comment fix.
7973 * vars-prs.c: Comment fix.
7975 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
7976 behavior with usage of postincrement.
7977 (memory_stream_read) Discards cases as it goes.
7979 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
7981 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
7984 * Most source files: Includes debug-print.h, related comment
7987 * cases.c: (alloc_val) Removed complex allocation code. Merely
7988 increments default_dict.nval and returns the former value.
7989 (envector, devector) Removed references to lv member of struct
7992 * common.h: (macro VME) Replaced complex definition with simple
7995 * data-list.c: (cmd_data_list) Sets vfm_source instead of
7996 read_active_file and cancel_input_pgm.
7997 (read_from_data_list, cancel_data_list) Removed.
7998 (data_list_source_read, data_list_source_destroy_source) New
8000 (glob var data_list_source) New var.
8002 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
8003 (cmd_begin_data) Improved criteria for an input program accessing
8004 the inline file. Still not perfect.
8006 * do-if.c: (do_if_trns_proc) Simplified debug output.
8008 * expr-prs.c: Comment fixes.
8009 [DEBUGGING] (debug_print_postfix) Simplified debug output.
8011 * file-handle.q: (fh_close_handle) Simplified debug output.
8013 * file-type.c: Comment fixes.
8014 (cmd_file_type) Sets vfm_source instead of read_active_file and
8016 (cmd_end_file_type) On failure, discards variables in place of
8017 just canceling the input program.
8018 (read_from_file_type) Renamed file_type_source_read.
8019 (cancel_file_type) Renamed file_type_source_destroy_source.
8020 (glob var file_type_source) New var.
8022 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
8023 (cmd_get) Initializes options to GTSV_NONE before passing to
8024 trim_dictionary(). Removed `lv' reference. Sets vfm_source
8025 instead of read_active_file and cancel_input_pgm.
8026 (cmd_save_internal) Initializes options before passing to
8027 trim_dictionary(). Local var `nval' removed.
8028 (dict_delete_run) Comment fixes.
8029 (trim_dictionary) Comment fixes. Disallows scratch variables if
8030 GTSV_OPT_SAVE set in options.
8031 (read_from_get) Renamed get_source_read.
8032 (cancel_get) Renamed get_source_destroy_source.
8033 (glob var get_source) New var.
8035 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
8036 read_active_file and cancel_input_pgm.
8037 (read_from_input_program) Renamed input_program_source_read.
8038 Simplified debug output.
8039 (cancel_input_program) Renamed
8040 input_program_source_destroy_source.
8041 (glob var input_program_source) New var.
8043 * loop.c: (loop_1_trns_proc) Simplified debug output.
8045 * main.c: (dump_token) Made eof output more explicit.
8047 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
8050 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
8051 code for always-memory or always-disk cases. malloc's case-list
8052 based on vfm_source_info.ncases. Explicit support for
8053 memory_stream via memory_source_cases.
8054 (do_external_sort) Sets vfm_source instead of read_active_file and
8056 (allocate_file_handles) The temporary directory permissions are
8057 set to 0700 instead of 0777.
8058 (allocate_cases) Formatting fixes. Simplified debug output.
8059 (output_record) Compacts the case if necessary before writing it
8061 (close_handle, open_handle_w) Simplified debug output.
8062 (write_initial_runs) Destroys vfm_sink, then sets it to
8063 sort_stream. Writes records to memory based on
8064 vfm_sink_info.case_size.
8065 (write_to_sort_cases) Renamed sort_stream_write().
8066 (merge) Simplified error handling. Simplified debug output.
8068 (read_from_external_sort) Renamed sort_stream_read().
8069 Reads records based on vfm_source_info.case_size.
8070 (sort_stream_write) Writes records to memory based on
8071 vfm_sink_info.case_size.
8072 (sort_stream_mode) New function.
8073 (glob var sort_stream) New variable.
8075 * temporary.c: (cmd_temporary) Simplified debug output.
8076 (copy_variable) Removed references to `lv'.
8078 * title.c: (get_title) Simplified debug output.
8080 * var.h: Comment fixes.
8081 (struct get_proc) Removed member `lv'.
8082 (struct variable) Removed member `lv'. Comment fixes.
8083 (glob vars read_active_file, write_active_file, cancel_input_pgm)
8085 (struct case_stream) New.
8087 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
8088 read_active_file references to use vfm_source.
8089 (init_variable, replace_variable) Removed references to `lv'.
8091 * vfm.c: Comment fixes.
8092 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
8094 (static var queue, qh, qt, n_lag) Removed. All references
8096 (glob var compaction_necessary, compaction_nval, compaction_case,
8097 paging) New variables.
8098 (record_case) Removed.
8099 (procedure) Comment fixes. Calls vfm_source->read() instead of
8102 (prepare_for_writing, arrange_compaction, make_temp_case,
8103 vector_initialization, setup_filter) New function.
8104 (open_active_file) Most of the code moved into the abovementioned
8105 new functions. Now sets temp_dict to &default_dict if there is no
8106 temporary dictionary, for convenience. New debug output.
8107 (close_active_file) Deals with changing the sink to the source.
8108 Calls finish_compaction(). Frees compaction_case. Mostly
8110 (glob vars disk_source_file, disk_sink_file) New vars.
8111 (destroy_active_file, read_from_memory) Removed.
8112 (disk_stream_init, disk_stream_read, disk_stream_write,
8113 disk_stream_mode, disk_stream_destroy_source,
8114 disk_stream_destroy_sink) New functions.
8115 (glob var vfm_disk_stream) New var.
8116 (glob vars memory_source_cases, memory_sink_cases,
8117 memory_sink_iter, memory_sink_max_cases) New vars.
8118 (memory_stream_init, memory_stream_read, memory_stream_write,
8119 memory_stream_mode, memory_stream_destroy_source,
8120 memory_stream_destroy_sink) New functions.
8121 (glob var vfm_memory_stream) New var.
8122 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
8123 named `more_cases'. Simplified debug output. Otherwise mostly
8125 (record_case) Moved into the stream drivers. Removed.
8126 (transform) Removed (was dead code).
8127 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
8128 common case that the splits don't change, we don't need to copy
8129 the case into prev_case again--pointless.
8130 (compact_case) New function.
8131 (finish_compaction) New function.
8133 * vfmP.h: Comment fixes.
8134 (DEV_* enum series) Removed.
8135 (struct storage) Renamed `stream_info'. Removed variant record.
8136 Removed `device' member.
8138 * debug-print.h: New file.
8140 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
8142 * autorecode.c: Turned off debugging.
8144 * data-list.c: (destroy_dls) Closes the associated file handle.
8146 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
8147 parse_variables() options.
8149 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
8151 * display.c: (display_variables) Really fixed null cell bug.
8153 * file-handle.q: (fh_close_handle) Changed debugging message.
8155 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
8156 parse_variables() options.
8158 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
8159 (cmd_list) Fails if no variables specified.
8160 (determine_layout) Writes blank lines manually.
8162 * loop.c: (loop_1_trns_proc) Made debugging code only print
8163 messages if debugging.
8165 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
8166 parse_variables() arguments.
8167 (main) Parses optional parenthesized options to varlist
8168 subcommands into sbc->message.
8170 * sfm-read.c: Format fix.
8172 * var.h: (FV_*) New enum series.
8173 (PV_*) New enum PV_NO_SCRATCH.
8175 * vars-prs.c: (find_var) Removed.
8176 (fill_all_vars) Takes FV_* enum instead of boolean third
8177 argument. Rewritten to deal with scratch as well as system
8179 (parse_variables) Error message on scratch variable if
8182 * vfm.c: (static var virt_begin_func) New var.
8183 (procedure) Sets up virt_begin_func.
8184 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
8185 after dump_splits(). For succeeding groups changes, calls
8186 virt_begin_func() instead of begin_func().
8188 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
8190 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
8193 * dfm.c: Added some debugging messages, disabled by default.
8194 (open_file_r) Fixed error message.
8195 (read_record) On eof on inline_file, instead of calling
8196 fh_close_handle(), simply jump to eof label like a normal file.
8199 * display.c: Thin lines between rows for certain kinds of
8200 listing. Fixed `null cell' bug.
8202 * error.c: (failure) Flush stdout, stderr before failing.
8204 * file-handle.q: (fh_close_handle) Added debugging message.
8206 * frequencies.q: (dump_full) Bottom line extends across entire
8207 table width. Changed title formatting.
8208 (dump_condensed) Changed title formatting.
8209 (dump_statistics) Fixed title formatting.
8211 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
8212 Sets default value of set_format.
8214 * list.q: (cmd_list) Calls blank_line() before determine_layout().
8215 Passes write_all_headers() to procedure() as pre-group func.
8216 (write_all_headers) New function.
8217 (determine_layout) Removed calls to write_header().
8218 Calls blank_line() before and after write_fallback_headers().
8220 * recode.c: (recode_trns_free) Only attempts to free head->map if
8223 * sfm-read.c: (read_variables) Allows `#' at beginning of system
8224 file variable names but gives a warning. Sets `left' based on
8225 first character being/not being `#'. On lossage frees dict->var.
8227 * som-high.c: (som_draw_title) Simplified title formatting.
8229 * vfm.c: (dump_splits) Fixed and changed splits formatting.
8231 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
8233 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
8234 beginning. Frees v_src, v_dest on successful exit. Frees
8235 h_trans[*], h_trans on lossage.
8236 (recode) Frees h_trans[*], h_trans.
8238 * dfm.c: (dfm_close) Formatting change.
8239 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
8240 longer allocates its own in inline_file.
8241 (open_file_r) Passes the local dfm_fhuser_ext to
8243 (open_file_w) Message fix.
8244 (read_record) Buffer reallocation strategy changed. Frees
8245 ext->line even in inline_file to prevent leaks.
8246 (dfm_put_record) Fixed bug where `ext' was cached before the file
8247 was opened and thus it would be NULL when the file really was
8249 (cmd_begin_data) Sets up inline_file basics itself, then calls
8250 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
8252 * list.q: (write_line) Formatting fix.
8253 (clean_up) Minor strategy change. Sets proportional font after
8255 (determine_layout) Sets fixed font before writing regular headers,
8256 or after writing fallback headers.
8258 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
8259 and KEEP vars after using them.
8261 * postscript.c: (ps_init_driver) Frees x->family.
8262 (postopen) When loading fonts, free the temporary font name buffer
8264 (ps_text_set_font_by_position) Free temporary font name buffer
8266 (text) Fixed code that calculated `lig' so that `lig' always gets
8267 initialized. Formatting fix.
8269 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
8271 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
8272 cells, not xmalloc(), so that the cells will get destroyed
8275 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
8278 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
8280 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
8283 * dfm.c: Comment fix.
8285 * list.q: Comment fixes. Include somP.h. Removed static vars
8286 table, n_columns, n_rows, part. New struct list_ext. New static
8288 (n_lines_remaining, n_chars_width, write_line) New functions.
8289 (cmd_list, list_cases) Rewritten.
8290 (begin_row, end_row, flush_table) Removed.
8291 (write_header, clean_up, write_varname, write_fallback_headers,
8292 determine_layout) New functions.
8294 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
8296 * output.h: Comment fix.
8298 * postscript.c: Comment fix.
8299 (struct ps_driver_ext) Removed prop_size, fixed_size members;
8300 added font_size. All references changed.
8301 (ps_init_driver) Initializes font_size. Simplified space checking
8303 (static var option_tab[]) Removed prop-size, fixed-size; added
8305 (ps_option) Handles font_size.
8307 * som-high.c: Moved prototypes into somP.h.
8308 (som_init_driver) New function.
8309 (som_submit_table) Moved some code into new function
8311 (build_target) Moved some code into new function
8312 som_internal_eject_page().
8313 (som_eject_page) Uses som_internal_eject_page().
8314 (som_internal_eject_page) New function.
8316 * som-low.c: Moved prototypes into somP.h.
8318 * som.h: Formatting fixes.
8320 * somP.h: (struct som_driver_ext) Removed em_width;
8321 added prop_em_width, fixed_width.
8323 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
8325 * Makefile.am: Added `localedir' definition. Added
8326 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
8328 * ascii.c: (macro draw_line) Fixed capitalization.
8330 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
8331 compute.c, count.c, data-in.c, data-list.c, data-out.c,
8332 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
8333 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
8334 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
8335 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
8336 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
8337 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
8338 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
8339 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
8340 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
8341 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
8342 for internationlization.
8344 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
8346 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
8348 * do-if.c, sort.c, val-labs.c: Comment fixes.
8350 * glob.c: (init_glob) Uncommented, updated i18n support.
8352 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
8353 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
8354 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
8355 the declarations of macros taking arguments a lot nicer.
8357 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
8359 * error.h: Removed CE, CW aliases for SE, SW.
8361 * q2c.c: Removed explicit streq() definition since it's duplicated
8364 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
8365 stats.h, str.h, tokens.h: Made the declarations of macros taking
8366 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
8369 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
8371 * cmdline.c: Comment fixes.
8372 (pick_compat) Changed return type to int. Now, instead of setting
8373 glob var `compat' to the emulation, returns the emulation. All
8375 (parse_command_line) Added terminating null to end of
8376 `long_options' array definition.
8377 (pre_syntax_message) Fixes.
8378 (usage) Shows the default emulation in the syntax message by
8379 calling pick_compat().
8381 * getline.c: (getl_add_include_dir) Separates paths with
8382 PATH_DELIMITER, not DIR_SEPARATOR.
8384 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
8385 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
8387 * output.c: (outp_configure_macro) Make earlier definitions for a
8388 particular key override later ones for the same key.
8390 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
8392 * ascii.c: Comment fixes.
8394 * output.c: (outp_get_paper_size)
8395 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
8397 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
8399 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
8400 <errno.h>. GNU libc 2 enforces this!
8402 * command.c: (parse_cmd) Fixed problem with `else' clause being
8403 paired with wrong `if'. Comment fix.
8405 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
8407 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
8408 blp_getline() to getline().
8410 * output.c: (outp_eval_dimension) Changed the fix from last time;
8411 there was no variable `a'.
8413 * q2c.c: (get_line) Fixed boundary condition overrun bug.
8415 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
8417 * output.c: (outp_evaluate_dimension) Fixed handling of negative
8418 numbers having fractional parts. Added case of a fraction without
8419 a whole-number part.
8421 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
8423 * ascii.c: (ascii_text_get_font_position) Removed.
8425 * expr.h, exprP.h: Disabled debugging.
8427 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
8430 * output.h: (struct outp_class_struct) Removed
8431 text_get_font_position method. All references deleted.
8433 * postscript.c: Big change here. Fontmaps were completely
8434 eliminated because of a change in philosophy. Comment fixes.
8435 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
8437 (struct ps_driver_ext) `position', `fontmap', `prop_name',
8438 `fixed_name' members removed. New members `prop_family',
8439 `fixed_family'. `family' member changed to type char *.
8440 (static var ps_fontmaps) Removed.
8442 (ps_init_driver) Removed obsolete references, updated.
8443 Initializes `translate_x', `translate_y', `scale'. Doesn't read
8444 fontmap, of course. Refers to font names through internal_name
8445 rather than subversive means. Frees proper items.
8446 (static var option_tab[]) Removed `fontmap-file' option; renamed
8447 `fixed-font', `prop-font'.
8448 (ps_option) Corresponds to option_tab[].
8449 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
8450 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
8451 hash_family) Removed.
8452 (postopen) Generates font names from family names. Gets
8453 PostScript font name properly. New prologue file comment `!!!'
8455 (ps_open_page) Adds translate_x, translate_y to BP prologue
8456 function; gives SF argument floating-point format.
8457 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
8458 font name. Doesn't change font family.
8459 (ps_text_set_font_by_position) Generates Groff font name from font
8460 family name instead of through table lookup.
8461 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
8462 all references changed. Reduced to simple string assignment.
8463 (ps_get_font_name) Removed.
8464 (ps_get_font_family) Reduced to string return.
8465 (text) Doesn't save `position' since it no longer exists. Ugly
8466 kluge to save font family--fix soon?
8467 (load_font) Removed PostScript name argument.
8469 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
8471 * postscript.c: Comment fix.
8472 (ps_open_page) Puts scale factor in PostScript output.
8474 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
8476 * Makefile.am: Distcleans q2c.
8478 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
8480 * ascii.c: (delineate) Sets text size even if width is zero.
8482 * command.c: Comment fix.
8483 (static var cmd_table[]) Re-enabled EVALUATE command.
8484 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
8485 of comments in script files. Now more liberal on criteria for
8486 performing a state transition--if *anything* happened correctly,
8487 not just if *everything* happened correctly.
8489 * data-out.c: (convert_F) Comment fix. Why in the fsck does
8490 Checker segfault on formatting large numbers and why in the fsck
8491 hadn't I noticed this before?
8493 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
8495 * list.q: (cmd_list) Commented out the actual output routine
8496 because of various problems. Probably will abandon the idea of
8497 using the general `crushed tables' for the LIST procedure.
8499 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
8500 clearing it. Allocates a new var_by_name dictionary before trying
8501 to add members to it.
8503 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
8504 `sib'. Changed type of `node' argument.
8505 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
8507 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
8508 [DEBUGGING] Only deletes the variable from var_by_name if that var
8511 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
8513 * Makefile.am: Added include files to SOURCES. Added
8514 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
8515 includes rules for q2c. Added `boast' target.
8517 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
8519 * Makefile.am: Maintainer-clean Makefile.in.
8521 * Makefile.am: Fixed redundant EXTRA_DIST line.
8523 * ascii.c: Comment fixes.
8524 (ascii_line_vert) Fixed overly aggressive range check.
8526 * display.c: Removed dead code.
8528 * list.q: Turn debugging on.
8529 (flush_table) New debug code.
8531 * sfm-read.c: (read_value_labels) malloc's the structure before
8532 trying to assign to its members.
8534 * sfm-write.c: Comment fix.
8536 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
8538 (output_table) No arguments anymore--gets them through `som'
8539 global. New debug code. In crushed tables, now sets `htv' as
8540 well as `hv' to avoid bad confusion later.
8541 (dump_crush_page) New debug code.
8543 * som-low.c: (som_dump_crush_page) New debug code.
8545 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
8547 All source files: Broke long lines into multiple lines.
8549 * ascii.c: (ascii_close_page) Uses host_system var in place of
8550 HOST_SYSTEM constant.
8552 * cmdline.c: (var syntax_message[]) Broke into
8553 pre_syntax_message[] and post_syntax_message[].
8554 (usage) Outputs both parts, separated by driver list.
8556 * error.h: Fixed broken formatting.
8558 * expr-opt.c: (str_search, str_rsearch) New functions.
8560 * misc.c: (blp_getdelim) Removed. All references changed to
8562 (str_search, str_rsearch) Removed.
8563 (memrmem) New function.
8565 * misc.h: (blp_getline) Removed. All reference changed to
8570 * filename.c: Includes "stat.h", not <sys/stat.h>.
8571 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
8573 * output.c: (outp_list_classes) Changed output formatting.
8575 * sfm-write.c: (write_header) Uses host_system var instead of
8576 HOST_SYSTEM constant.
8577 (write_rec_7_34) Extracts version numbers from the version string.
8580 * sort.c: Includes "stat.h", not <sys/stat.h>.
8582 * str.c: (strcasecmp) Removed.
8584 * title.c: (cmd_document) Uses host_system var instead of
8585 HOST_SYSTEM constant.
8587 * version.c: Generated on-the-fly by the Makefile instead of being
8590 * str.h: Comment fixes. Doesn't substitute for missing memmove or
8592 [!HAVE_STRNCASECMP] Declares strncasecmp().
8594 * version.h: Removed stray character. Comment fixes.
8595 (vars host_system, build_system) New vars.
8597 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
8599 * Most source files: Changed formatting of copyright notice; fixed
8600 FSF address; reformatted to better conform to GNU standards;
8601 comment fixes. Added markups to prevent GNU indent from messing
8602 up my beautiful formatting :-).
8604 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
8605 that GNU indent markups can be passed through without problems.
8607 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
8609 * get.c: Turned off debugging.
8611 * glob.c: (init_glob) Turned on save-file compression by default.
8613 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
8614 compression than was possible in save files.
8616 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
8618 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
8620 * frequencies.q: Removed Fiasco extensions. Updated calculation
8621 algorithms. Polished output format.
8622 (struct frq_info_struct) Removed members `max_degree', `min_n',
8623 all references removed.
8624 (macro frq_extensions) Removed.
8625 (static vars min_n, max_degree) Removed, all references removed.
8626 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
8627 calculate `min_n', `max_degree'.
8628 (postcalc) Passes new arg to dump_statistics().
8629 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
8631 (dump_condensed) Adds variable name title.
8632 (sum_freqs) Removed.
8633 (calc_stats) Updated calculation algorithm.
8634 (dump_statistics) Removed warning for too-few observations.
8635 Changed table formatting. Adds variable name title if passed new
8638 * output.h: Comment fix.
8640 * recode.c, sample.c, sort.c: Disabled debug code.
8642 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
8643 Improved debug code.
8645 * var.h: (enum series frq_*) Removed Fiasco extensions.
8647 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
8649 * command.c: Added PROCESS IF to command table.
8651 * Lots & lots of places, removed checks for NULLs preceding calls
8652 to free_expression(), which itself checks.
8654 * descript.q: Removed Fiasco extensions. Removed optimizations
8655 for non-weighted active files. Implemented some options.
8656 Finished polishing output format. Comment fixes. Merged
8658 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
8659 max_degree, min_n) Removed.
8660 (macro dsc_extensions) Removed.
8661 (struct dsc_info_struct) Removed `min_n' member, all references
8663 (internal_cmd_descriptives) Removed calculation of min_n,
8664 max_degree. Only deals with one `calc' routine instead of two
8666 (precalc) Eliminated redundancy. Updated for changes to
8667 descriptives_proc structure.
8668 (calc) Moved here from `descript.g'. Rewritten to calculate
8669 statistics via `moments about the mean' rather than by summing,
8670 summing squares, summing cubes, and so on.
8671 (postcalc) Rewritten for new-style statistical calculation.
8672 (display) Removed support for displaying variables across rows.
8673 No longer crushes the descriptives table. Removed ancient code.
8674 Added display of N, by variable and listwise.
8676 * descript.g: Removed; merged into `descript.q'.
8678 * expr-evl.c: (evaluate_expression) Now returns a double. For
8679 numeric results, it returns the result as well as storing it in
8680 the passed `value' structure if non-NULL. For string results it
8681 just returns 0.0 and it must be passed non-NULL. Many references
8682 to this function were optimized by use of this change, especially
8683 but not exclusively in `compute.c'.
8685 * frequencies.g: Comment fix.
8687 * glob.c: (glob var process_if_expr) New global var.
8689 * postscript.c: (static var option_tab[]) Corrected entry for
8691 (postopen) Sets x->size to x->prop_size.
8692 (ps_text_set_font_by_name) Sets font size as well as typeface for
8693 PROP and FIXED fonts.
8695 * sel-if.c: (cmd_process_if) New function.
8697 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
8698 (sfm_write_dictionary) Sets `n_cases' to 0.
8699 (sfm_write_case) Increments `n_cases'.
8700 (sfm_close) Attempts to seek the system file back to the header
8701 and write the number of cases in its proper slot.
8703 * som-frnt.c: (som_insert_table) Masks off expansion options since
8704 only SOPT_X_NORM seems to work sensibly.
8706 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
8707 with a `fixed' value of 2.
8709 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
8711 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
8712 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
8714 * var.h: (enum series dsc_*) Removed Fiasco extensions.
8715 (struct descriptives_proc) Removed `miss_noweight'; new members
8716 `X_bar', `M2', `M3', `M4', `min', `max'.
8718 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
8720 * vfm.c: (close_active_file) Cancels PROCESS IF.
8721 (write_case) Doesn't process cases unselected by PROCESS IF.
8723 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
8725 * glob.c: (glob var err) Removed.
8727 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
8728 doesn't have to take into account number of value labels since
8729 they're in a subtable anyway. Also, doesn't display more than 10
8730 value labels since we can't yet break pages in subtables.
8732 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
8734 * som-frnt.c: (som_change_table_size) Simple change for elegance
8735 that shouldn't change behavior.
8736 (som_set_value) Comment fix.
8738 * som-high.c: (som_submit_table) Message fix.
8740 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
8742 * command.c: Added SYSFILE INFO to command table.
8744 * file-handle.q: (fh_handle_filename) New function.
8746 * get.c: (save_trns_proc) Fixed a bug in padding of output data
8749 * main.c: (parse) New return value for command functions, -3.
8751 * misc.h: Comment fix.
8753 * output.h: Comment fixes.
8754 (macro COMPONENTS) Removed.
8756 * postscript.c: (write_text) Modified literal_chars[] so that `('
8757 and ')' are not written to the output in strings as literals.
8759 * sfm-read.c: (sfm_read_dictionary) New argument.
8760 (read_header) New argument. Sets the information structure's
8761 values from the header information.
8762 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
8763 bizarre Checker problem, I guess.
8764 (read_variables) Proper cleanup on lossage.
8766 * sfm.h: (struct sfm_read_info) New struct for use by
8767 sfm_read_dictionary().
8769 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
8770 currently used just for tables that can be dynamically resized and
8771 thus have to be allocated with arena_malloc() instead of
8772 arena_alloc(). All references changed.
8773 (som_change_table_size) New function.
8774 (som_insert_table) Bugfix: now inserts `cell', not `c'!
8776 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
8777 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
8780 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
8782 (draw_intersection) Now takes an argument specifying the table in
8783 question. All references changed.
8784 (draw_table_cell) New function.
8785 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
8786 (som_get_table_size) Many nice new explanatory comments.
8787 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
8789 * som.h: New enum series SOM_CREATE_* for use as create flags with
8792 * str.h: Moved a comment here from TODO.
8794 * sysfile-info.c: New file. Reference implementation.
8796 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
8798 * command.c: Added RENAME VARIABLES to table of commands.
8800 * data-in.c: (dls_error) Sets `cust_field'.
8801 (parse_N) Message fix.
8802 (parse_day_count) New function.
8803 (to_roman) Never outputs VX as a `short form' of V.
8804 (parse_month) Fixed parsing of Roman numerals.
8805 (parse_trailer) Message fix.
8806 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
8807 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
8808 the date is invalid.
8809 (parse_SDATE) Fixed swapped day, year.
8810 (parse_JDATE) Fixed bug for dates in 1582.
8811 (parse_DTIME) Allows days not between 1 and 31.
8812 (parse_numeric) Makes local copy of f.type for easier usage.
8815 * data-out.c: (convert_F) When outputting as scientific, properly
8816 sets f.type as fp->type.
8817 (insert_commas) Fixed operator precedence problem with setting of
8818 nitems. Changed strcpy to memcpy (no null terminator).
8819 (convert_date) Fixed FMT_JDATE: added 1900 to year.
8820 (convert_CCx) Essentially rewritten, but now it works.
8822 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
8824 (display_documents) Implemented.
8826 * error.c: (glob var cust_field) New var.
8827 (vmsg) Displays cust_field as part of message classes DE and DW.
8829 * formats.c: (debug_print) Fixed to compile under updated
8832 * get.c: (cmd_get, cmd_save_internal) Close file handle on
8835 * misc.c: (parse_format_specifier) Formatting fix.
8837 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
8838 `n_rename' for clarity.
8839 (cmd_modify_vars) Initializes `forward' and `positional' at
8840 appropriate times. Frees lists of vars to rename on failure.
8841 Comment fix. Frees memory on success.
8842 (rearrange_dict) Simplified `for' loop condition.
8844 * rename-vars.c: New file (reference implementation).
8846 * set.q: (internal_cmd_set) Fixed `emu' test condition.
8848 * sfm-read.c: (read_header) File label is created only if file
8849 label in file is not blank.
8850 (read_variables) Initializes `dict' local variable.
8851 (read_documents) Proper behavior on lossage.
8853 * sfm-write.c: (write_header) Doesn't blank out the file label
8854 (why was this here to begin with?!)
8856 * temporary.c: (save_dictionary) File label is copied only if
8857 non-NULL. Doesn't try to xstrdup() dictionary documents.
8858 Adapted so as to not irritate Checker.
8859 (free_dictionary) Only destroys var_by_name if non-NULL.
8861 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
8862 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
8863 lines to the document, indents the document. Also, it works now.
8864 (add_document_line) New function.
8866 * var.h: (struct dictionary) Reordering.
8868 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
8869 bits if it was allocated to begin with.
8871 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
8873 * command.c: Added MODIFY VARS to list of commands.
8875 * configure.in: Updated custom macros for autoconf 2.12. Removed
8876 mmap reference; fixed termcap library reference.
8878 * display.c: (display_variables) Fixed a few bugs although it's
8879 still not well written.
8881 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
8882 (induce_segfault) Calls chkr_disp_call_chain() instead of
8883 inducing an actual SIGSEGV.
8885 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
8886 str_search() and str_rsearch(). Fixed tests for matches on
8887 OP_INDEX and OP_RINDEX.
8889 * filename.c: (good_getcwd) Removed as the new libc for Checker
8890 doesn't contain this bug, apparently.
8892 * misc.c: (str_search, str_rsearch) Changed order of arguments for
8893 consistency with GNU memmem.
8894 (blp_getdelim) Changed `len' from `int' to `size_t'.
8896 * modify-vars.c: Reference implementation.
8898 * som-frnt.c: (zero_length) New global var.
8899 (som_create_table) Message fix.
8901 * som.h: Added gcc attributions to som_set_text(),
8902 som_output_text() prototypes. blank_line() refers to
8903 zero_length[] instead of a literal null string to suppress gcc
8906 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
8907 (allocate_cases) Decrements x_max so the last element of x[] can
8908 be used by the algorithm.
8910 * var.h: Changed minor details of `variable' declaration.
8911 (struct modify_vars_proc) New struct.
8912 (struct variable) Added field p.mfv.
8914 * vars-atr.c: Comment fix.
8916 * vars-prs.c: (fill_all_vars) More optimal implementation.
8918 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
8919 character, which it shouldn't have to do but printf() seems to
8920 read the null byte even though I supply a maximum length...
8922 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
8924 * command.c: Removed command alias X for QUIT.
8925 (parse_cmd) Fixed comment parsing.
8927 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
8929 (read_record) Fixed references to len, size.
8930 (dfm_get_record) Restructured.
8932 * file-handle.h: (struct file_handle) Field `lrecl' now of type
8935 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
8938 * modify-vars.c: New file. Not complete.
8940 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
8943 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
8944 problems caused by int/size_t differences.
8946 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
8949 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
8950 being compared were of equal length.
8952 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
8954 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
8956 * lexer.c: (get_dotted_rest_of_line) New function.
8958 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
8961 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
8962 type 6 records. Frees the dictionary properly.
8963 (read_header) Initializes the dictionary instead of letting
8964 read_variables() do it. Sets the dictionary file label from the
8966 (read_documents) New function.
8968 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
8969 write type 6 record if appropriate.
8970 (write_header) Writes file label from dictionary.
8971 (write_documents) New function.
8973 * temporary.c: (save_dictionary, restore_dictionary,
8974 free_dictionary) Properly handle new fields in dictionary struct.
8976 * title.c: (get_title) Returns after failure().
8977 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
8978 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
8980 * var.h: (struct dictionary) New fields `label', `n_documents',
8983 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
8985 * command.c: Added FILTER to list of commands.
8987 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
8990 * get.c: (cmd_save_internal) Removed weighting code since it's now
8991 handled by sfm-write.c. Properly commented out debug code.
8993 * glob.c: (glob var weighting) Removed.
8995 * sel-if.c: Comment fixes.
8996 (cmd_filter) New function.
8998 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
8999 (sfm_read_dictionary) Sets weighting variable direct in the
9000 created dictionary now. (Apparently we previously didn't support
9002 (read_header) Sets weight_index field in sfm_fhuser_ext from
9003 header read from disk.
9005 * sfm-write.c: (sfm_write_dictionary) Comment fix.
9006 (write_header) Now sets the weighting in the header from the
9007 passed primary dictionary instead of from the sfm_write_info.
9009 * sfm.h: (struct sfm_write_info) Removed field `weight'.
9011 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
9012 broke on boundary conditions.
9014 * var.h: (struct dictionary) New fields `weight_var',
9015 `weight_index', and `filter_var'.
9016 (glob var weighting) Removed. This is now part of struct
9017 dictionary. All references changed; the less mechanical changes
9018 are described above.
9020 * vars-atr.c: (find_dict_variable) New function.
9022 * vfm.c: (static var filter_index) New variable.
9023 (open_active_file) Initializes filter_index from default_dict.
9024 (write_case) Calls proc_func() only if the filter variable is
9025 nonzero; this implements FILTER behavior.
9027 * weight.c: (static var weight_varname) Removed.
9028 (cmd_weight) Modified default_dict instead of glob vars.
9029 (update_weighting) Changed the signature to modify a dictionary
9030 instead of glob vars. Now returns the weighting variable.
9031 (get_weighting_variable) Removed; its function is absorbed by
9033 (stop_weighting) Operates on a dictionary now.
9035 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
9037 * sort.c: Removed debugging info from messages.
9038 (do_external_sort) Cleans up after itself by deleting the
9039 temporary directory on failure. (On success it is deleted by the
9041 (allocate_cases) Removed debug code. Added clean up code.
9042 (output_record) Removed debug code.
9043 (merge) Added code to close all the input files that are currently
9044 open. This is a likely location for bugs, because I'm not sure
9045 about boundary conditions. Removed an unnecesary heap_delete().
9046 (merge_once) Removed input file "optimization" that in fact
9047 screwed up the rest of the code. Message and comment fixes.
9049 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
9051 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
9053 * heap.c: (heap_delete) New argument.
9055 * sort.c: Finished implementation of external sort.
9057 * vfm.c: (read_from_disk) Returns after a disk error.
9059 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
9061 * sort.c: (static var state) Removed.
9062 (static vars max_handles, tmp_basename, tmp_extname,
9063 huffman_queue) New variables.
9064 (do_external_sort) Moved most code to new functions.
9065 Creates huffman_queue.
9066 (allocate_file_handles, allocate_cases) New functions.
9067 (static vars run_no, run_length, file_index, case_count) New
9069 (output_record) Returns success. Now really writes to the output
9071 (begin_run, end_run) New functions.
9072 (write_initial_runs) Returns success. Initializes run_no to -1.
9073 Calls begin_run(), end_run() at appropriate times. Outputs debug
9075 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
9077 (merge) New function.
9079 * heap.c, heap.h: New files. Hopefully in near-final form.
9081 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
9083 * glob.c: Added write_active_file to global vars.
9085 * sort.c: Several new miscellaneous static variables.
9086 (cmd_sort_cases) Big comment fix.
9087 (perform_case_2) Renamed `do_external_sort' and completely
9089 (case_2_proc_func) Removed.
9090 (output_record, write_initial_runs, write_to_sort_cases,
9091 compare_record) New functions.
9093 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
9095 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
9097 * sort.c: (perform_case_2) Changed the method for allocation of
9098 lots of memory--now allocates one case at a time in hopes that
9099 more cases can be allocated with heavily fragmented memory.
9101 * var.h: (write_active_file) New global var.
9103 * vfm.c: (procedure, close_active_file, write_case,
9104 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
9105 arguments to procedure() to be NULL. All references to
9106 procedure() that made use of dummy functions were changed to NULL
9108 (open_active_file) If write_active_file is non-NULL, the output
9109 device becomes DEV_PGM (a new enum).
9110 (close_active_file) Sets write_active_file to NULL.
9111 (read_from_memory) Comment fix.
9112 (record_case) Calls write_active_file() when the output device is
9115 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
9119 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
9120 Fixed checking for duplicate varnames.
9121 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
9123 (autorecode_trns_free) Destroys hash tables for each recoding
9125 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
9127 * command.c: Added SORT CASES to cmd_table.
9128 (null_func, null_int_func) Prototyped.
9130 * descript.g: (calc_weight, calc_noweight) Computes own case
9133 * frequencies.q: (dump_statistics) Fixed problem with
9134 too-few-cases warning message.
9136 * get.c: (cmd_save_internal) Handles weighting properly.
9138 * hash.c: (hsh_dump) Output format changed.
9139 (force_hsh_insert) Actually works now, prototype changed.
9141 * list.q: (static var case_num) New variable.
9142 (cmd_list) Initializes case_num.
9143 (list_cases) Increments case_num.
9145 * var.h: Added definitions for SORT CASES. Comment fixes.
9147 * vfm.c: Some definitions moved to new file vfmP.h. Comment
9148 fixes. `active' renamed vfm_active, `rep' renamed
9149 vfm_replacement, all references changed.
9150 (procedure) The procfunc no longer receives a case number. All
9152 (write_case) Subtle reordering.
9153 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
9156 * weight.c: (get_weighting_variable) New function.
9158 * vfmP.h: New file with definitions from vfm.c.
9160 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
9162 * command.c: (FILE_TYPE_okay) Commented out some tests because
9163 they're clumsy and not yet needed.
9165 * var.h: Most *_trns structures moved to their respective source
9166 files. Some were moved into a new file, do-ifP.h. Comment fixes.
9167 (union any_trns) Changed to a typedef for trns_header.
9168 (struct input_program_pgm) Removed.
9170 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
9171 was allocated in the first place.
9173 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
9175 * autorecode.c: New file.
9177 * command.c: Added AUTORECODE to command table; re-enabled SET.
9179 * data-out.c: (convert_F) Handles infinities and NaNs properly.
9181 * error.c: (vmsg) Comment fixes.
9183 * hash.c: Comment fix.
9184 (hashpjw_d) New function.
9185 (hashpjw) Reimplemented as call to more general function
9187 (internal_comparison_fn) Initializes pointers properly.
9188 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
9189 (force_hsh_insert, force_hsh_find) New debugging wrapper
9192 * main.c: (main) Message fix.
9194 * output.c: (outp_read_devices) Message fix.
9196 * set.q: Comment fixes.
9197 (custom_results) Implemented Wnd/X form of subcommand.
9198 (set_routing) New function.
9199 (internal_cmd_set) Implemented ERRORS, MESSAGES.
9201 * settings.h: (SET_ROUTE_*) New enum series.
9202 (set_results) Renamed set_results_file, all references changed.
9203 (set_messages) Removed.
9204 (glob vars set_errors, set_messages, set_results) New vars.
9206 * title.c: (get_title) Remembers to xstrdup() the result of
9209 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
9211 (union any_trns) New element `arc'.
9213 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
9215 * command.c: (output_line) Removed references to set_screen.
9217 * error.c: (static var terminating) New var.
9218 (hcf) Sets terminating to 1.
9219 (vmsg) If terminating is nonzero, does not attempt to call hcf().
9220 This prevents an infinite loop if an error occurs within hcf().
9222 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
9223 statement circumlocution with `case 42000' trick.
9224 (evaluate_expression) New support for OP_STR_MIS.
9226 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
9227 statement circumlocution with `case 42000' trick.
9228 (dump_node) Handles OP_STR_MIS.
9230 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
9231 variables exceptions.
9232 (parse_function) Message fix.
9233 (ops[]) Added OP_STR_MIS.
9235 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
9237 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
9239 * glob.c: Removed set_scrnfile glob var.
9240 (init_glob) set_errorbreak set to 0 by default.
9242 * groff-font.c: Changed included files.
9243 (groff_read_font) Initializes font_arena local var correctly.
9244 (default_font) New function.
9246 * output.c: Comment fixes.
9247 (glob var disabled_devices) New variable.
9248 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
9250 [GLOBAL_DEBUGGING] (reentrancy) New function.
9251 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
9252 outp_iterate_enabled_drivers) Calls to reentrancy().
9253 (destroy_list) New function.
9254 (outp_done) Moved code to destroy_list().
9255 (parse_options) Parses `listing', `screen', `printer' options
9257 (configure_driver) Sets new `device' member of driver.
9258 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
9260 * output.h: Comment fixes. New enum series OUTP_DEV_*.
9261 (struct outp_driver_struct) New member `device'.
9263 * postscript.c: (find_encoding_file) Doesn't display its own error
9265 (default_encoding) New function.
9266 (switch_font) Calls default_encoding() if no encoding can be
9268 (text) Makes up a character metric if none exists for the desired
9270 (load_font) Properly copies a fallback filename. Calls
9271 default_font() for a font if none at all are known.
9273 * set.q: Comment fixes. Removed OUTPUT subcommand.
9274 (custom_listing) Calls outp_enable_device() to enable/disable
9276 (turn_screen_on) Removed.
9277 (internal_cmd_set) Calls outp_enable_device() to enable/disable
9278 screen, printer devices.
9280 * settings.h: Comment fixes.
9281 (glob vars set_output, set_printer, set_screen, set_scrnfile)
9284 * som-high.c: (som_submit_table, som_eject_page) Use
9285 outp_iterate_enabled_drivers() instead of iterating
9286 outp_driver_list directly.
9288 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
9290 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
9291 (parse_string_as_format) Handles new formats.
9292 (parse_numeric) Now handles DOT and PCT formats.
9294 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
9296 (convert_date) Handle EDATE and SDATE formats.
9297 (convert_CCx) Now if there's not room for the currency characters,
9298 converts it as F format if it's positive instead of giving up
9299 quickly. Also fixed save-and-restore bug with decimal point
9301 (convert_format_to_string) Handles new formats.
9303 * misc.c: (formats[]) Added new formats.
9304 (convert_fmt_ItoO) Supports new formats.
9306 * sfm-read.c: (parse_format_spec) Supports new formats. Better
9307 data checking. New argument, all references changed.
9309 * sfm-write.c: (write_format_spec) Supports new formats.
9311 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
9314 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
9316 * cmdline.c: Comment fixes.
9317 (parse_command_line) Changed return type to void.
9319 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
9321 (parse_numeric) Handles international numbers (comma as decimal
9322 point). Some reformatting.
9324 * data-list.c: (parse_free) Default output format is now
9325 set_format instead of hard-coded F8.2.
9326 (read_from_data_list_list) Emits error message on undefined data
9327 only if set_undefined is nonzero.
9329 * data-out.c: (convert_E) Changes decimal point from period to
9330 comma if appropriate. Restructured. Better comments.
9331 (convert_F) Changes decimal point from period to comma if
9333 (insert_commas) Major bug with handling of negative values fixed.
9334 Also, inserts periods instead of commas if appropriate.
9335 (convert_CCx) New function.
9336 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
9337 (num_to_string) Changed `.' to set_decimal.
9339 * dfm.c: Comment fixes.
9340 (dfm_close) Frees ext->line even in inline_file.
9341 (open_inline_file) New function.
9342 (open_file_r) When opening the inline file: now properly
9343 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
9345 (read_record) Calls fh_close_handle() instead of dfm_close() to
9346 close the inline file. Makes a copy of the line getl_buf to avoid
9348 (dfm_get_record) Restructured. Now checks the return value of
9350 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
9351 checking for use of inline file. No longer tries to close inline
9354 * error.c: (glob var error_already_flagged) New var.
9355 (vmsg) Message change. Now checks max number of errors/warnings,
9358 * file-handle.q: (fh_handle_name) Now allows closing of
9360 (fh_init_files) Reformatted.
9362 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
9364 * getline.c: (getl_include) Fixed bug that popped up when called
9365 when file queue was empty.
9366 (read_console) Resets error_count, warning_count,
9367 error_already_flagged to zero.
9369 * glob.c: Many changes to update list of variables.
9370 (init_compat_dependent) Now this function is called whenever
9371 `compat' changes. It now sets set_seed only if it hasn't
9372 previously been referenced. It now calls
9373 lex_init_compat_dependent().
9375 * include.c: (cmd_include_at) Frees temporary buffer instead of
9377 (cmd_include) Doesn't make copy of include file name.
9379 * lexer.c: Comment fixes.
9380 (init_lex) Moved some code into new function
9381 lex_init_compat_dependent().
9382 (lex_init_compat_dependent) New function.
9383 (hex_val) Simplified.
9384 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
9386 * main.c: Comment fixes.
9389 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
9390 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
9391 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
9392 (setup_randomize) Sets set_seed_used.
9394 * set.q: Comment fixes.
9395 (custom_results) Conditionalizes on `compat'.
9396 (custom_log) Calls custom_journal().
9397 (set_ccx) New function.
9398 (cmd_set) Calls init_compat_dependent() when `compat' changes.
9399 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
9400 when set_decimal changes. Range-checks values for MITERATE,
9401 MNEST. Message fixes.
9403 * settings.h: Comment fixes.
9404 (struct set_cust_currency) New struct.
9405 (set_cc[], set_grouping, set_seed_used) New global vars.
9407 * var.h: (FMT_CCA...FMT_CCE) New output formats.
9408 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
9410 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
9412 * glob.c: Revised variables to correspond to settings.h.
9413 (init_glob) Initializes variables from settings.h properly.
9415 * set.q: Began long-overdue major revision to correspond to new
9416 philosophy. Most code changed.
9418 * settings.h: Mostly changed; reorganized, reordered, large new
9421 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
9423 * get.c: (cmd_save_internal) No longer forces compression off.
9425 * sfm-read.c: (read_compressed_data) If eof is reached when
9426 reading a new instruction octet, only signal error if we're in the
9429 * sfm-write.c: (COMPRESSION_BIAS) New #define.
9430 (struct sfm_fhuser_ext) New member `end'.
9431 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
9432 (ensure_buf_space) New function.
9433 (sfm_write_case) Reimplemented in order to support compression.
9434 (sfm_close) Writes out the remaining contents of the compression
9437 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
9439 * command.c: Defined SAVE and XSAVE commands in command table.
9441 * common.h: second_lowest_value is of type flt64, not double.
9443 * file-handle.h: Comment fix.
9445 * get.c: Comment fixes.
9446 (static var `trns') New.
9447 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
9448 cmd_save_internal, cmd_save, cmd_xsave) New functions.
9449 (dict_delete_run) Clears the variables and frees them now.
9450 (trim_dictionary) Sets default for compression.
9451 On KEEP subcommand, frees deleted variables as well as clearing
9452 them. Finally got the sense of the test for deleting all
9454 [DEBUGGING] (dump_dict_variables) Message fix.
9456 * glob.c: (init_glob) set_compression set to 1 by default.
9458 * list.q: Properly #includes config.h.
9460 * misc.h: New macro REM_RND_UP.
9462 * settings.h: Comment fix.
9464 * sfm-read.c: (structs sysfile_header, sysfile_format,
9465 sysfile_variable; inline function bswap_int32) Moved to new file
9467 (corrupt_msg) [__CHECKER__] No longer induces segfault.
9468 (sfm_read_dictionary) Fixed bug caused by failing to initialize
9470 (read_machine_flt64_info) Fixed some problems caused by confusion
9471 between flt64 and double types.
9472 (read_header) Message fix.
9473 (read_variables) Fixed set of cases in which we byte-swap sv.print
9474 and sv.write. Fixed confusion of flt64 and double.
9476 * sfm.h: (struct sfm_write_info) New.
9478 * som-high.c: (som_draw_title) Properly frees `s'.
9480 * temporary.c: (save_dictionary) Comment fix.
9482 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
9483 (struct trns_header) Formatting fix.
9484 (struct save_trns) New.
9486 * vars-atr.c: (discard_variables) Comment fix.
9488 * sfm-write.c: New file, baseline release.
9490 * sfmP.h: New file, baseline release.
9492 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
9494 * cmdline.c: (parse_command_line) `--version' output updated.
9495 (glob var syntax_message[]) Added my e-mail address.
9497 * file-handle.q, lexer.c, vfm.c: Changed many instances of
9498 `illegal' to `invalid'.
9500 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
9501 uncompression buffer.
9502 (sfm_close) Frees decompression buffer.
9503 (sfm_read_dictionary) Initializes decompression buffer.
9504 (buffer_input, read_compressed_data) New functions.
9505 (sfm_read_case) Restructured; now calls read_compressed_data() to
9506 handle compressed system file data.
9508 * var.h: Comment fix.
9510 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
9512 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
9515 * get.c: New comments. New static var `get_file'.
9516 (cmd_get) Now fully implemented. Calls discard_variables();
9517 initializes fv and lv for all variables; new debug code; sets
9518 up the dictionary; sets up the input program.
9519 (read_from_get, cancel_get) New functions.
9521 * sfm-read.c: Comment fixes.
9522 (sfm_close) New static function.
9523 (sfm_read_dictionary) Properly sets up the class of the
9524 file_handle. No longer cares what size the data is in records of
9525 type 7. Also, on failure, properly cleans up the file_handle and
9527 (read_variables) No longer thinks it knows `nval' of the
9528 dictionary. Now sets p.get.fv, etc., instead of speculatively
9530 (read_value_labels) Fixed off-by-one error in indexing of
9532 (sfm_read_case) New function.
9533 (sfm_r_class) New static var.
9535 * var.h: (get_proc) New struct.
9536 (struct variable) New member p.get.
9538 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
9540 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
9541 the manual's meaning.
9542 (rename_variables) New function.
9543 (trim_variables) Doesn't try to parse MAP any more. Removed debug
9544 code. Now properly reorders the dictionary on the KEEP keyword.
9546 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
9549 * vars-atr.c: (clear_variable) New argument `dictionary *'.
9550 (rename_variable) New function.
9551 (free_val_lab) Reformatted.
9553 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
9555 * var.h: Reindented entire file. Comment fixes.
9556 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
9558 (glob var default_dict) New.
9559 (struct indirect_dictionary) Removed.
9561 * Many other source files were changed to add `default_dict.'
9562 before all references to the dictionary of the active file.
9564 * vars-atr.c: (make_indirect_dictionary) Removed.
9566 * glob.c: Reindented all variable declarations. Updated for
9567 changed var.h. Comment fixes.
9569 * temporary.c: (restore_dictionary, save_dictionary) Simplified
9570 because now we can mainly copy dictionary structs.
9572 * vars-prs.c: (is_dict_varname, parse_dict_variable,
9573 parse_variables) Takes dictionary instead of indirect_dictionary
9575 (parse_variables) Instead of calling make_indirect_dictionary,
9576 just sets DICT to &default_dict if DICT is NULL. Of course, lots
9577 of `*dict.' references had to be changed to `dict->'. Removed
9580 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
9582 * get.c: Added GTSV_OPT_* series of enums.
9583 (trim_dictionary, dict_delete_run) New functions.
9584 [DEBUGGING] (dump_dict_variables) New function.
9585 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
9586 [DEBUGGING] Calls dump_dict_variables() to display results.
9588 * glob.c: (cmp_variable) Now a public function declared in var.h.
9590 * sfm-read.c: Turned off debug code. Comment fixes.
9591 (read_machine_int32_info, read_machine_flt64_info) New functions
9592 to parse type 7 records.
9593 (sfm_read_dictionary) Properly byteswaps several fields now.
9594 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
9595 records. [DEBUGGING] Dumps dictionary.
9596 (read_variables) Sets `index' field of variables created properly.
9597 Constructs avl tree of variables in dictionary. [DEBUGGING] No
9598 longer dumps dictionary.
9599 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
9601 [DEBUGGING] (dump_dictionary) No longer stubbed out.
9603 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
9604 var before destroying any variables just to save a little time.
9606 * var.h: (struct variable) Reordered in order to make name[] the
9607 first member; this makes pointers to `variable' pointers to the
9608 variable name, simplifying avl trees, etc.
9609 (struct indirect_dictionary) New struct.
9611 * vars-atr.c: (find_variable) Rewritten for efficiency.
9612 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
9614 (is_varname) Rewritten for efficiency.
9615 (parse_variables) New argument, which is a `dictionary *'. All
9616 references changed. This function now reads variable names from
9617 the dictionary passed, or from the default dictionary if NULL.
9619 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
9621 * misc.h: Added new macro DIV_RND_UP to perform integer division,
9622 rounding up. Changed many references to ROUND_UP to use this
9625 * sfm-read.c: Includes avl.h.
9626 (corrupt_msg) Induces a segfault under Checker.
9627 (macro assertive_bufread) New. Many references to bufread() now
9629 (sfm_read_dictionary) Split up into several functions. Added code
9630 to read dictionary records following the the type 2 records. Not
9631 quite complete. New variable `var_by_index'.
9632 (read_header, read_variables) New functions extracted from
9633 sfm_read_dictionary().
9634 (read_value_labels) New function.
9635 (bufread) Checks ferror() if fread() doesn't return the expected
9636 value; if ferror() is zero it's just EOF.
9637 (dump_dictionary) Stubbed out.
9639 * BTW: The source code now exceeds 50000 lines!
9641 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
9643 * command.c: Added GET to cmd_table[].
9645 * list.q: Removed reference to alloca headers.
9646 (cmd_list) Gave prototype.
9648 * sfm-read.c: Added DEBUGGING comments.
9649 (sfm_read_dictionary) Checks bias correctly. Sets
9650 dict->var_by_name to NULL. Calculates long_string_count
9651 correctly. realloc's dict->var[] array to minimum size.
9652 [DEBUGGING] Calls dump_dictionary.
9653 [DEBUGGING] (dump_dictionary) New function.
9655 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
9656 (restore_dictionary) If the dictionary contains a non-NULL
9657 var_by_name, uses that instead of generating one.
9658 (free_dictionary) Destroys var_by_name.
9660 * var.h: (struct dictionary) Added field `var_by_name'.
9662 * get.c: New file, not complete.
9664 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
9666 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
9667 (parse_num_or_range) New function.
9668 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
9669 <n> THRU HIGH missing values.
9671 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
9672 __attribute__((const)).
9674 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
9676 * sfm-read.c: Finished reference implementation.
9678 * sfm.h: Includes var.h.
9680 * var.h: Comment fixes.
9681 (struct `variable') Reordered some fields.
9683 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
9684 constants added previously.
9686 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
9688 * common.h: Comment fixes. Added declaration of
9689 `second_lowest_value' as variable or macro. Made `compat_type',
9690 `pgm_state_type' into anonymous enums.
9692 * display.c: Comment fix.
9694 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
9696 [!defined SECOND_LOWEST_VALUE] Added definition for
9697 `second_lowest_value' global var.
9698 (compat, pgm_state global vars) Changed types to `int'.
9699 (init_glob) Initializes `second_lowest_value'.
9701 * sfm-read.c: Continued work, not complete.
9703 * var.h: Added new MISSING_* constants to handle LOWEST and
9706 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
9708 * sfm-read.c: New file, not complete.
9710 * cases.c: (vec_insert) Changed vector expansion algorithm.
9711 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
9712 mucking up the RECODE transformation in particular.
9713 (envector) Harmless change in notation.
9715 dfm is now fairly well tested again.
9716 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
9718 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
9720 * recode.c: Comment fix.
9722 * sfm.h: Interface should be fairly final now, or at least for a
9725 * vfm.c: [DEBUGGING] (index_to_varname) New function.
9726 (open_active_file) [DEBUGGING] Translates ccase indices into
9727 variable names now to make it easier to understand what's really
9730 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
9732 * data-in.c: Comment fix.
9734 * data-list.c: Includes dfm.h.
9735 (do_reading) Uses new function dfm_push_cust().
9737 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
9740 * file-handle.h: Completely changed. Some parts split off into
9741 new file dfm.h. Implemented in file-handle.q.
9742 (enum FH_*) Removed.
9743 (struct fh_ext_class) New struct.
9744 (struct file_handle) Retained only these fields: name, norm_fn,
9745 fn, recform, lrecl, mode. New fields class, ext.
9746 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
9747 close_handle, handle_name) Added `fh_' prefix to name, all
9750 * dfm.h: New file, implemented in dfm.c.
9751 (get_record, put_record, fwd_record, bkwd_record, set_record,
9752 get_cur_col) Functions moved from file-handle.h, now prefixed with
9754 (dfm_push_cust) New function.
9756 * sfm.h: New file. Incomplete.
9758 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
9759 interface. Functions reordered, comments changed. Not well
9760 tested, probably full of bugs.
9761 (struct dfm_fhuser_ext) New struct.
9762 (dfm_close) New function.
9763 (open_file_r) Pickier about finding `BEGIN DATA.' line.
9764 (open_file_w) User messages changed.
9765 (get_record) Comment fixed.
9766 (read_record) Increments ext->ln even for inline_file. Calls
9767 dfm_close() for inline_file when `END DATA.' encountered.
9768 (dfm_get_record) Experimental restructuring.
9769 (dfm_push_cust) New function.
9770 (cmd_begin_data) Detects whether the inline file was fully read by
9771 checking whether it is still open; detects whether it was read at
9772 all by checking whether the line number is greater than zero.
9774 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
9775 interface. Functions reordered, comments changed. Not well
9776 tested, probably full of bugs.
9777 (init_file_handle) Removed initializers for obsolete fields, added
9779 (fh_close_handle) Much simpler, now mainly calls the class
9781 (fh_init_files) Renamed inline file internal filename.
9783 * file-type.c: Includes dfm.h.
9784 (read_from_file_type) Doesn't use dfm internal state anymore.
9786 * inpt-pgm.c, print.c: Include dfm.h.
9788 * recode.c: (internal_cmd_recode) Casts strlen() return value to
9789 int in comparison with other int.
9791 * som-high.c: (build_target) Fixed operator precedence problem in
9792 if statement (& versus ==).
9794 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
9796 * dfm.c: (read_record) Can now read fixed-length records; not
9798 (put_record) Can now write fixed-length records; not tested.
9800 * file-handle.h: FH_* defines changed to enums. New enum series
9802 (struct file_handle) New members recform, lrecl, mode.
9804 * file-handle.q: Parser changed.
9805 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
9806 /LRECL subcommands. These are compatible with Windows.
9807 (init_file_handle) Initializes recform, mode fields.
9809 * q2c.c: (get_line) When outputting `!' comment lines, now
9810 increments the output file line number so that `#line' directives
9812 (make_identifier) New function that converts an arbitrary string
9813 into a valid C identifier.
9814 (dump_vars) Calls make_identifier() in two places in order to
9815 suppress some errors for bad identifiers.
9816 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
9817 for NO. Allows numbers to be prefixed by underscores to make them
9818 acceptable C identifiers but still to be parsed as numbers by the
9821 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
9823 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
9825 * dfm.c: Comment fixes. (get_record) Gives error if file handle
9826 was opened for writing.
9827 (open_file_w) New function.
9828 (read_record) Uses strncasecmp if available. Improved error
9830 (put_record) New function.
9832 * file-handle.h: Moved function comments into dfm.c and
9833 file-handle.q. Comment fixes. Removed declarations of
9834 tilde_expand() and normalize_filename().
9835 (struct file_handle) Changed `open' from boolean to enumerated
9836 field to allow for three states--closed, open for reading, open
9837 for writing--all references changed.
9839 * file-handle.q: Includes filename.h.
9841 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
9843 (alloc_line) Makes allowance for line terminator characters in
9845 (print_trns_proc) Now handles OUTFILE, WRITE differences.
9846 (print_space_trns_proc) Handles OUTFILE differences.
9848 * recode.c, sample.c: Comment fixes.
9850 * var.h: (struct print_trns) Changed boolean field `eject' to
9851 bitmapped field `options'; all references changed. New enums
9852 PRT_* for use with this field.
9854 * exception.h, test-exception.c: Removed.
9856 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
9858 * ascii.c: (delineate) Turned off debug output.
9860 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
9863 * data-in.c: (parse_string_as_format) Sets the entire string value
9864 to spaces, not just the short string part of it. Is this correct
9867 * data-out.c: (convert_date) Fixed DATETIME format problems with
9868 decimal places, removed debug code.
9870 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
9871 middle of parsing BEGIN DATA that would cause the lexer to read
9872 from a wild pointer `prog'; now calls new function
9873 preprocess_line() in lexer.c.
9875 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
9877 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
9878 Now call induce_segfault() to induce the segfault.
9879 (induce_segfault) New function.
9881 * expr-opt.c: Comment fix.
9882 (parse_sysvar) New function.
9883 (parse_primary) Added system variable support--calls
9885 (global var ops) Added OP_CASENUM operator.
9887 * expr.h: Comment fixes.
9888 (OP_* enum) added OP_CASENUM operator.
9889 (struct casenum_node) New struct.
9890 (union any_union_union) New member `cas' of type `casenum_node'.
9892 * glob.c: (global var last_vfm_invocation) New var.
9893 (init_glob) Initializes last_vfm_invocation.
9895 * lexer.c: (lookahead) Fixed reversed condition on if statement.
9897 * getline.c: (get_line) Split into get_line() and preprocess_line().
9898 (preprocess_line) New function.
9900 * var.h: Declares last_vfm_invocation.
9902 * vfm.c: (procedure) Sets last_vfm_invocation.
9904 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
9906 * command.c: (parse_cmd) Fixed bad assertion related to
9909 * data-in.c: (parse_month) Implemented to parse months according
9910 to full interpretation of standard.
9911 (to_roman) New function.
9912 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
9913 (parse_weekday) Bug fix (forgot to skip all the day name).
9915 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
9916 up parsing of multirecord data items. Also fixed user message.
9918 * data-out.c: Comment fix.
9919 (year2, year4, convert_date, convert_time, convert_WKDAY,
9920 convert_MONTH) New functions to support time & date output.
9921 (convert_format_to_string) Calls new time & date output routines.
9923 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
9925 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
9928 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
9930 * misc.c: (global var formats) Fixed declarations of DATETIME,
9933 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
9934 the output_char buffer.
9936 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
9937 memory bug. Fixed user messages.
9939 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
9941 * Removed #pragma argsused from lots of places.
9943 * data-in.c: Implemented zoned decimal and time-date formats.
9944 Untested. This is a huge chunk of code--maybe 1000 lines and 50
9947 * data-out.c: Implemented zoned decimal format.
9949 * expr.h: Moved yrmoda() declaration here from exprP.h.
9951 * misc.c: (global var formats) Minor fixes--added
9952 FCAT_SHIFT_DECIMAL to formats N and Z.
9953 (convert_fmt_ItoO) Added support for format Z.
9955 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
9957 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
9959 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
9960 som_check_workspace() that is activated between commands.
9962 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
9965 * list.q: (begin_row) Changed title expansion style from
9966 SOPT_X_VERT to SOPT_X_SHSP.
9968 * som-frnt.c: Now includes `somP.h'.
9969 (som_push_workspace, som_pop_workspace) New functions that, taken
9970 together, form a solution to the recursive table building problem
9971 mentioned yesterday. Surrounded every table output routine
9972 throughout the program with calls to these functions.
9973 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
9974 (som_create_table) Checks that there's an active workspace.
9975 (som_destroy_all_tables, som_crush) Removed.
9977 * som-high.c: (global var som_preserve_tables) Removed, all
9979 (som_submit_table) Checks that there's an active workspace.
9980 (dump_columnated_table) Doesn't columnate tables that would have
9981 just one row per column.
9982 (dump_crush_page, som_dump_crush_page) Removed debugging code.
9983 (som_dump_crush_page) Moved row number labels from left side of
9984 tables to right side.
9985 (som_get_table_size) Added support for SOPT_X_SHSP.
9987 * som.h: New cell expansion type SOPT_X_SHSP.
9989 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
9991 (global var curtab_arena) Moved from som-frnt.c.
9993 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
9995 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
9996 that causes bad location warnings to be suppressed.
9997 (delineate) Saves current font when calling draw_text(); fixed
9998 handling of NULLs when backing up. Also fixed line-wrapping bug.
10000 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
10001 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
10003 * common.c: Added code to cause assertion failure to dump core
10004 when run under Checker.
10006 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
10007 there are still bugs.
10009 * glob.c: (__eprintf) Removed.
10011 * list.q: Inserted som_preserve_tables kluge that prevents tables
10012 from being thrown away due to recursive table building through
10013 som_output_line being called from a transformation during the LIST
10014 procedure invocation. This is a general problem that must be
10015 solved in a better way since it applies to all procedures in
10017 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
10018 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
10020 * numeric.c: Fixed several errors in the form of msg() calls.
10022 * print.c: Updated for use of som.
10023 (dump_table) Reimplemented.
10024 (print_trns_proc) Calls som_eject_page() instead of eject_page().
10025 Calls som_output_text() instead of outs_line().
10027 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
10029 (som_output_text) Function moved from som-low.c. Interface
10032 * som-high.c: (som_preserve_tables) New global public variable
10034 (som_submit_table) Destroys the tables only if som_preserve_tables
10036 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
10037 one subrow per row. Now labels subrows if there's more than one
10039 (dump_crush_table) Added wishlist comment.
10040 (som_eject_page) New public function declared in som.h.
10042 * som-low.c: (som_dump_crush_page) Draws row labels if there's
10043 more than one subrow per row.
10044 (som_output_text) Moved to som-frnt.c.
10046 * som.h: (SOM_TOPT_PRESERVE) Removed.
10048 * title.c: (get_title) Changed interface.
10049 (cmd_title) Changed `title' to `outp_title'.
10050 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
10052 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
10054 * list.q: (flush_table) Conforms to new partial options in
10055 som_submission_form.
10057 * som-high.c: (paginate_horizontally) Changed form of subrow
10059 (build_target) Omits spacing before table if
10060 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
10061 (dump_crush_page) Changed interface. Only trims bottom rule if
10062 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
10063 (dump_crush_table) Handles partial tables.
10064 (output_row_label) New function.
10065 (som_dump_crush_page) Emits subrow number labels. Draws vertical
10066 rule on the right edge of narrow subrows.
10068 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
10069 constants to a series of SOM_TOPT_PARTIAL_* submission options.
10070 All references updated.
10072 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
10074 * misc.c: Comment fix.
10076 * som-high.c: (examine_table) Treats crushed tables separates for
10077 purpose of determining header size.
10078 (paginate_horizontally) Allots space for line numbers in crushed
10079 tables with lots of subrows per row. Calculates the `maximum page
10080 width', the width of the widest horizontal page.
10081 (build_target) Removed trim argument; all references changed.
10082 Stricter assertions. (dump_crush_page) New function.
10083 (dump_crush_table) Reimplemented.
10085 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
10086 (som_dump_crush_page) Reimplemented, interface changed.
10088 * somP.h: Many many new helper macros for use with crushed tables.
10089 (global var som) Removed `tv', `cum_y' members; all references
10090 removed. New members `mpw', `digit_space'.
10092 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
10094 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
10095 variable, changed to constant 1024.
10096 (arena_ca_strdup) Changed `sizeof(a_string)' to
10097 `sizeof(c_string)'.
10098 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
10099 `(c_string *)' to `(char *)'; this fixed some offset problems.
10101 * filename.c: (readlink_malloc) Changed initial allocation from
10103 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
10106 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
10107 &fm->owner in several places.
10109 * som-high.c: (output_table) Changed interface to rest of world.
10110 (examine_crush_table) Removed. Crushed tables are re-broken now,
10111 in preparation for rewrite.
10113 * som.h: Comment fix.
10115 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
10117 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
10118 itself in the cleanup stage.
10120 * descript.q: (display) At least temporarily, changed the table
10121 format to a crushed table.
10123 * list.q: (begin_row) At least temporarily, added horizontal lines
10126 * som-high.c: (examine_crush_table) Sets som.hh to the width of
10127 the horizontal "headers," that is, to the width of the far left
10128 and far right rules.
10129 (justify_pagination) Sets som.th to the width of the widest row
10130 in the crushed table. Fixed inner loop off-by-one error.
10132 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
10135 * somP.h: Comment fix.
10137 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
10139 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
10140 before closing it; also, opens the constructed filename `s'
10141 instead of f->filename.
10143 * postscript.c: Moved initialization of x->loaded, x->prop,
10144 x->fixed, x->current, also the add_encoding() calls, into
10146 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
10147 sets x->last_font to NULL; sets x->next_combo to zero.
10149 * som-high.c: (crushed_row_height) Moved definition farther up.
10150 (som_submit_table) Doesn't calculate line width, font size until
10151 after calling open_page(), to accomodate changes to PostScript
10153 (vert_headers) Removed; equivalent functionality moved to
10154 examine_table(), examine_crush_table().
10155 (justify_pagination) Replaced with different algorithm.
10156 (dump_crush_table) Bugfix that caused tables to fail to be clipped
10157 at the bottom of the page.
10159 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
10161 * command.c: Added cmd_list back into cmd_table.
10163 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
10164 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
10166 * list.q: (flush_table) Updated to new som_submission_form format.
10168 * som-frnt.c: Comment fix.
10170 * som-high.c: Changed `#endif' to `#undef EXTERN'.
10171 (output_table) Calls som_get_table_size() directly; handles
10173 (examine_crush_table) New function; calls vert_headers().
10174 (examine_table) Moved some code into new function, vert_headers().
10175 (justify_pagination) New function.
10176 (dump_plain_table) Removed `static' from `cy'.
10177 (dump_crush_table) New function.
10179 * som-low.c: (som_dump_crush_page) New function.
10181 * som.h: Comment fixes.
10182 (enum SOM_TOPT_CRUSH) New.
10183 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
10184 Temporarily set to zero to make do with LIST procedure.
10186 * somP.h: Re-ordering.
10188 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
10190 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
10192 * somP.h: New file for use by som-high.c, som-low.c.
10194 * q2c.c: Added definition for VME.
10195 (get_line) Now dumps `!' comment lines to the output file
10198 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
10199 set.q: Changed format of `!' comment lines.
10201 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
10203 * All source files: Added copyright notice.
10205 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
10206 longs in msg() calls.
10208 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
10210 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
10212 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
10214 * output.c: (outp_read_devices) Changed criteria for
10215 distinguishing different types of lines.
10217 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
10219 * cmdline.c: Changed syntax message.
10221 * filename.c: (good_getcwd) Bug fix (?).
10222 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
10224 (search_path) Appends DIR_SEPARATOR to directory name only if it
10225 does not already end with one.
10227 * glob.c: Checks STAT_PAGER envvar before PAGER.
10229 * output.c: Checks environment variables instead of just local
10232 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
10234 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
10235 when the pointer passed to the function was within the arena
10236 itself, so that it couldn't properly be set to NULL _after the
10239 * command.c: Re-enabled DISPLAY.
10241 * display.c: Rewritten to handle tables. Untested.
10243 * filename.c: (search_path) Fixed memory leak.
10245 * frequencies.q: (cmd_frequencies) Frees v_variables.
10246 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
10247 (cleanup_freq_tab) New function to garbage collect.
10248 (dump_full) Elegantized.
10250 * main.c: New comment.
10252 * output.h: New tag for tagged quotes: TAG_NEWLINE.
10254 * postscript.c: Comment fix.
10255 (release_fontmap, free_font_entry) New functions.
10256 (ps_init_driver) Sets free_font_entry() as the freefunc for
10257 hashtable `loaded'. Calls release_fontmap() when destroying a
10258 driver; also frees the output filename; also frees the
10259 ps_driver_ext block.
10260 (free_ps_encoding) Frees the filename as well as the encoding
10262 (output_encodings) Frees the line buffer and pops the msg-filename
10264 (read_fontmap) Frees the fontmap filename and the line buffer.
10265 (postopen, preclose) Misc. garbage collection fixes.
10266 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
10267 to NULL; this fixes some output problems.
10268 (text) Handles TAG_NEWLINE. Untested.
10270 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
10271 (som_set_string) Removed. All references changed to
10273 (som_set_text) Rewritten. New interface. More general.
10275 * som.h: Minor format changes.
10276 (struct som_value_cell) Removed; all references changed to
10278 (enums SOT_*) Changed.
10280 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
10282 * command.c: Re-enabled SPLIT FILE.
10284 * postscript.c: Comment fix.
10286 * som.h: Added `SOT_NONE'.
10288 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
10290 * vfm.c: (dump_splits) Reimplemented.
10292 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
10294 * Compiled the project under gcc 2.7.2, which gave some new
10295 warnings. This led to many additions of casts from unsigned to
10296 int sprinkled throughout the code.
10298 * arena.c: Many uses of `unsigned' changed to `size_t'.
10300 * command.c: Added END FILE, END REPEAT to command table.
10301 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
10302 (find_command, FILE_TYPE_okay) Not commented out anymore.
10303 (parse_cmd) Calls FILE_TYPE_okay again.
10304 (output_line) Added calls to som_output_text() to put the line
10305 in the output files.
10307 * common.c: (macro VME) Format changes.
10308 (xstrdup) Asserts that its argument is not NULL.
10310 * data-list.c: Implemented dump_fixed_table().
10312 * inpt-pgm.c: Formatting changes. Comment changes.
10313 (end_case_proc) Renamed end_case_trns_proc.
10314 (cmd_end_file, end_file_trns_proc) New functions.
10316 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
10318 * misc.h: (local_strdup) New macro corresponding to strdup() but
10319 allocating its data through local_alloc() if possible--that is, if
10322 * postscript.c: Comment changes.
10323 (quote_ps_name, quote_ps_string, output_encodings) New functions.
10324 (output_line, add_string) New macros supporting
10325 output_encodings().
10326 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
10327 substitution vars. Calls output_encodings() when a line
10328 consisting of `!encodings' is encountered.
10329 (preclose) Some code moved into quote_ps_string().
10330 (dump_line) Changed into macro supporting dump_fancy_line().
10331 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
10332 command when appropriate.
10333 (write_text) Fixed `literal_char' array (I think it's fixed, at
10335 (text) Fixed bug when width was zero. Now exits immediately on
10336 zero height_left. Now, when executing `goto restart;', checks
10337 that cp<end, so that we don't read beyond end-of-string. Also,
10338 outputs the correct code to the output file by outputting the code
10339 from the metric instead of the internal metric index.
10341 * repeat.c: (cmd_end_repeat) New function.
10343 * som.c: (var som) `headers' renamed `options' and semantics
10344 changed. All references changed.
10345 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
10346 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
10348 (som_text_table) Removed.
10349 (som_output_text) New function.
10351 * som.h: (struct som_submission_form) Removed `header', `reuse',
10352 replaced with bitmapped field `options'.
10353 (SOM_TOPT_*) New enum set for som_submission_form.options.
10354 (SOT_*) New enum set for som_output_text().
10356 * temporary.c: (copy_variable) When copying the var label, only
10357 calls xstrdup() if it's non-NULL.
10359 * var.h: (enum type `vartype') Removed; all references changed to
10362 * vars-atr.c: (init_variable) Changed local var `nbytes' from
10365 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
10367 * font.h: Comment changes.
10369 * groff-font.c: (groff_read_font) Initializes `name' field to
10370 NULL. Handles `encoding' field.
10372 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
10374 * postscript.c: (struct font_entry) Removed `position' field.
10375 (struct ps_font_combo) New struct.
10376 (struct ps_driver_ext) Removed field `next_position'. New fields
10377 `combos', `next_combo'. `last_font' field changed from
10378 `font_entry *' to `ps_font_combo *'.
10379 (ps_init_driver) Reformatted; handles new fields. When
10380 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
10382 (get_encoding, find_encoding_file) New functions.
10383 (add_encoding) Some code moved out into find_encoding_file().
10384 (postopen) Changed value for ${title}.
10385 (preclose) Sets `loaded' field to NULL after destroying the hash
10387 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
10389 (ps_text_set_font_by_position) Figures out the current family if
10391 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
10392 (switch_font) Implemented.
10393 (write_text) Calls switch_font() more often. Format changes.
10394 #undefs its macros after they're no longer useful.
10395 (text) Changed `continue' at one point to a jump to the top of the
10396 loop because we don't want `separate' reset to 0 at that point.
10397 (load_font) No longer sets `position' in the font_entry created.
10399 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
10401 * font.h: (struct font_desc) New member `encoding', which is not
10402 properly handled yet.
10404 * glob.c: (init_glob) Some new i18n code, which is probably
10407 * output.c: (outp_read_devices, outp_get_paper_size) Changed
10408 `size' local from `int' to `size_t'.
10410 * postscript.c: New driver configuration parameter `auto-encode'.
10411 New enums OPO_AUTO_ENCODE, ODA_COUNT.
10412 (struct font_entry) New member `position'.
10413 (struct ps_driver_ext) Reordered. New hash table member
10414 `encodings'; new members `next_position', `next_encoding',
10415 `last_font'. Members `current', `prop', `fixed' changed from type
10416 `font_desc *' to `font_entry *'; all references changed.
10417 (struct ps_encoding) New struct.
10418 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
10419 free_ps_encoding, add_encoding) New functions.
10420 (ps_init_driver) Added OPO_AUTO_ENCODE to default
10421 x->output_options. Initializes new members of ps_driver_ext.
10422 Changed default value for prologue_fn, encoding_fn. Calls
10423 read_ps_encodings after loading default fonts.
10424 (option_tab[], ps_option) Handle new configuration parameter.
10425 (switch_font) New function.
10426 (struct output_char) `font' member changed from `font_desc *' to
10427 `font_entry *'. New member `separate'.
10428 (read_fontmap) Changed `size' from `int' to `size_t'.
10429 (output_line, put_number) New macros for write_text().
10430 (write_text) Optimizes text output by consolidating multiple
10431 calls to PostScript `show' operator.
10432 (text) Keeps track of when text arguments can't be consolidated by
10433 write_text(), and marks those spots in the output stream.
10434 (load_font) Sets `position' of the allocated font_entry to -1, cuz
10435 the font hasn't been switched to by switch_font(), which is where
10436 the position is important--the PostScript is what cares about the
10439 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
10441 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
10442 call a NULL free_func.
10443 (hsh_rehash) Elegantized.
10444 (hsh_probe) Fix bug that manifested when the table was expanded
10445 and thus had to change location in memory. Good thing
10446 too--otherwise could have been much more subtle.
10447 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
10448 (hsh_foreach) New function for hash table iteration.
10450 * hash.h: (struct hsh_iterator) New.
10452 * lexer.c: (parse_tagged_quote) Font and family name strings in
10453 tags are now null-terminated.
10455 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
10457 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
10458 documented. (Never before tested?)
10460 * output.h: Comment changes.
10462 * postscript.c: New driver options `optimize-text-size',
10463 `optimize-line-size', `max-fonts-simult'. New enum set for
10464 specing cached line types. Comment fixes.
10465 (struct line_form) New struct.
10466 (struct ps_driver_struct) New members `text_opt', `line_opt',
10467 `max_fonts', `lines'.
10468 (ps_init_driver) Initializes new members of ps_driver_struct.
10469 (user option type enum set) New member `nonneg_int_arg'.
10470 (static var option_tab[]) Supports new options.
10471 (ps_option) Handles new options.
10472 (find_ps_file) Made static. No longer calls hsh_dump().
10473 (ps_get_var) Made static.
10474 (preclose) Dumps out proper DSC trailer.
10475 (ps_open_page) Elegantized.
10476 (ps_close_page) Calls dump_lines() if appropriate.
10477 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
10478 wrappers around line().
10479 (int_2_compare, compare_line, dump_line, dump_fancy_line,
10480 dump_lines, hash_line, free_line, line) New functions for support
10482 (write_text, text) Made static.
10483 (text) Added to font support, not finished.
10485 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
10487 * font.h: (struct font_desc) New members ascent, descent.
10489 * groff-font.c: (groff_read_font) Calculates font ascent and
10490 descent from the ascent and descent of the `d' and `p' characters,
10491 respectively, as per a suggestion on comp.fonts.
10493 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
10494 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
10496 (write_text) Handles text right-justification and centering (not
10497 full justification). Still very inefficient. (One output line
10499 (struct output_char) Added fields for font and font size.
10500 (text) Many bugfixes.
10502 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
10504 * cmdline.c: (usage) Calls outp_list_classes().
10506 * font.h: Comment fix.
10508 * groff-font.c: New exported global var `space_index'.
10509 (groff_init) New function to initialize `space_index'.
10510 (hash_kern) Casts result to unsigned.
10511 (font_name_to_index) Renamed font_char_name_to_index. All
10512 references changed. Also, now returns the value of `space_index'
10513 when passed an ASCII space character as an argument. Fixed
10515 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
10516 Handles passed NULL pointers properly.
10518 * lexer.c: (parse_tagged_quote) Comment fix. Better range
10521 * output.c: (outp_list_drivers) Removed. Removed all references.
10523 * output.h: Comment fixes.
10525 * postscript.c: (ps_open_global) Calls groff_init().
10526 (output_char) New structure.
10527 (write_text) New function.
10528 (text) No longer stubbed out! Now the output is correct--with a
10529 few exceptions, one of them being that the page has to be held
10530 upside down into a mirror.
10532 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
10534 * font.h: Comment fix.
10536 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
10537 All callers changed.
10538 (number_to_index) Renamed font_number_to_index, made extern. All
10540 (font_get_kern_adjust, font_get_char_metrics) New functions.
10542 * output.h: New constant OUTP_T_INTERNAL_DRAW.
10544 * postscript.c: Changed default line width back to 1/2 point.
10545 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
10546 in the center of the space allotted for them, not just a fixed
10547 offset from the edge of the space; this fixes some bugs.
10548 (ps_line_intersection) Now supports all command line styles.
10549 (ps_text_get_size) Bug fix in computation of em width.
10550 (text) New function, the meat behind ps_text_metrics and
10551 ps_text_draw. Not complete.
10552 (ps_text_metrics, ps_text_draw) Removed the stub taken from
10553 ascii.c; call text().
10555 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
10557 * arena.c: (arena_free) Assert that the argument is non-NULL.
10559 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
10560 only if old_kern is non-NULL.
10562 * postscript.c: (ps_init_driver) Changed default line width to 1
10564 (postopen) New prologue variables.
10565 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
10566 more of the common line styles properly, but not all.
10567 (ps_text_metrics) Fixed problem with this stubbed out version that
10568 kept it from taking font sizes into account.
10570 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
10572 * arena.c: (arena_malloc) Bug fix.
10573 (arena_dump) [GLOBAL_DEBUGGING] New function.
10575 * ascii.c: Comment fix.
10576 (count_fancy_chars, delineate) Now static functions.
10578 * filename.c: (interp_vars) Bug fixes.
10580 * font.h: Comment fixes.
10582 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
10583 beginning in case we have an error message to display before
10584 initializing the display.
10586 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
10588 (groff_read_font) Bug fixes.
10589 (name_to_index) Increments hash.used. Sets `name' field of hash
10591 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
10593 * hash.c: Return type changed.
10595 * postscript.c: Continued development. Now marks lines on the
10596 paper, but very buggy.
10598 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
10600 * Changed comments in many source files from `/* xxx /* yyy */' to
10601 `/* xxx */ /* yyy */' for cleanliness.
10603 * arena.c: (arena_sd_strdup) New function.
10605 * ascii.c: (struct ascii_driver_ext) New member `file'.
10606 (ascii_init_driver) Fills out member `file' for initing; uses
10607 close_file_ext for closing drivers.
10608 (ascii_option) Changed %.*s back to %s because the a_string's are
10609 always null-terminated.
10610 (postopen, preclose) New functions.
10611 (ascii_open_page) Uses new style of open_file_ext.
10612 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
10613 instead of this->output.
10614 (__assert_fail) Removed.
10616 * cmdline.c: Changed syntax_message[].
10618 * error.c: #include's <readline/history.h> only if the history
10619 library is available, not if just the readline library is
10622 * filename.c: (expand_line) Removed alloca() support.
10623 (interp_vars) No longer tilde-expands argument. Limit on output
10625 (tilde_expand) Now treats argument as path rather than filename.
10626 [!unix] Now is a no-op function.
10627 (search_path) Better verbose message formatting.
10628 (open_file, close_file) Comment fixes.
10629 (close_file) [!unix] Doesn't bother with pipes.
10630 (open_file_ext) Completely rewritten, interface revamped.
10631 (close_file_ext) New function.
10633 * font.h: Comment changes.
10635 * frequencies.q: Removed AIX alloca support since it doesn't use
10638 * hash.c: Comment changes & additions.
10639 (hsh_create) Initializes entire table instead of first M entries.
10640 (hsh_probe) Stupid bug fixed. Now it works.
10641 (hsh_dump) [GLOBAL_DEBUGGING] New function.
10643 * main.c: (parse) Detects EOF properly in token-eating loop.
10644 Should the STOP token have its value changed to 0?
10646 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
10647 (blp_getline) Now it's a macro.
10649 * output.h: (struct outp_driver) Removed members output, filename.
10651 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
10652 drivers in driver table.
10653 (outp_read_devices) Frees buf. Warns if there are no active
10655 (outp_configure_clear) Sets outp_configure_vec to NULL after
10656 deleting its elements.
10657 (configure_driver, destroy_driver) Removed references to output,
10658 filename members of outp_driver.
10659 (outp_evaluate_dimension, internal_get_paper_size,
10660 outp_get_paper_size) New functions.
10662 * postscript.c: Continued development. Now links but doesn't make
10663 any marks on the page. Lotsa bugs I suppose.
10665 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
10667 * str.h: Comment changes.
10669 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
10671 * Removed dependencies on non-nested comments in several files.
10672 Also removed references to (unix || __unix__) in #if's since
10673 prefh.orig makes those two equivalent.
10675 * ascii.c: (ascii_open_global) Creates ascii_arena.
10676 (ascii_close_global) Destroys ascii_arena.
10677 (ascii_init_driver) Doesn't create ascii_arena.
10678 (ascii_copy_driver) Removed.
10679 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
10680 (outp_class ascii_class) Removed ascii_copy_driver reference.
10682 * frequencies.q: Now can display all statistics except median.
10683 Still not finished.
10685 * output.c: Handles outp_class.ref_count so output class
10686 destructors are called properly.
10687 (add_class) Sets ref_count to 0.
10688 (configure_driver) Initializes class if ref_count++ is 0.
10689 (destroy_driver) Destructs class if --ref_count is 0. Frees the
10690 class output file name.
10692 * output.h: (struct outp_class) Removed copy_driver, inited.
10695 * postscript.c: Completely replaced but not finished.
10697 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
10699 * approx.h: #includes <float.h>.
10701 * arena.h, arena.c: Many functions changed to take an arena **
10702 instead of an arena *, for consistency. All callers changed.
10703 (arena_alloc) Now creates a new arena if passed *A that is NULL.
10704 (arena_destroy) Sets *A to NULL.
10706 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
10707 assertion that `width' be positive.
10709 * command.c: Removed #if's from cmd_table.
10710 (walk_cmdtable_func) [0] New function (debug code).
10711 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
10712 (parse_cmd) Doesn't return failure for unimplemented commands.
10714 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
10715 (SYSCODE) New constant macro.
10717 * descript.q: Checks for positive n_variables before performing
10720 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
10721 avl_find instead of &fp as arg 2.
10723 * frequencies.g, frequencies.q: Continued updating; now compiles &
10724 works again, but not complete.
10726 * main.c: Changes to user messages.
10728 * misc.c: (reverse) [0] New function.
10730 * settings.h: Comment removed. #includes "common.h".
10732 * som.c: (som_set_null) New function.
10733 (som_set_value, som_set_string, som_set_text) More detailing
10735 (som_set_float) Implemented function.
10736 (dump_columnated_table) Bug fix regarding page breaks.
10737 (draw_cell) Bug fix regarding text that spilled out of a cell.
10738 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
10740 (get_cell_size) Support SCON_EMPTY cells.
10741 (get_table_size) When calculating rules' widths and heights, mask
10742 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
10744 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
10746 (struct som_submission_form) New member `header'; all users
10749 * val-labs.c: (get_label) User messages changed.
10751 * var.h: Changed FREQUENCIES structures.
10753 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
10756 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
10758 * approx.h: Definition of EPSILON now depends on system's
10759 DBL_EPSILON. Removed GNU C specific code.
10760 (cmpapx) Renamed approx_compare.
10762 * frequencies.g, frequencies.q: Continued updating; still doesn't
10765 * groff-font.c: (name_to_index) Fix bug that kept it from
10768 * hash.c, hash.h: Completed work.
10770 * var.h: Changes to freq_tab, frequencies_proc.
10772 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
10775 * hash.c, hash.h: New files. Not completed.
10776 * Makefile.am: Added hash.c to source file list.
10777 * font.h: (struct font_desc) New member kern_size_p.
10778 * groff-font.c: Uses hash.h.
10779 (hashpjw) Moved to hash.c.
10780 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
10782 (static var hash) New member size_p.
10783 * var.h: Includes hash.h.
10784 (struct freq_tab) Changed AVL_TREE to hash_tab.
10786 * vars-prs.c: Comment, formatting fixes.
10788 * frequencies.g, frequencies.q: Continued updating. Not yet
10791 * formats.c: Bug fix.
10793 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
10795 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
10796 * descript.g: Comment fixes.
10797 * descript.q: Comment fixes. Moved some declarations into var.h.
10798 Made dsc_info a static table. Updated FIXMEs.
10799 (internal_cmd_descriptives) Beautified.
10801 * frequencies.q: Started updating into working order.
10802 * frequencies.g: New file analogous to descript.g.
10803 * var.h: Comment fixes. Added structures for FREQUENCIES.
10805 * som.c: Removed vestiges of crushing and partial table support.
10807 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
10809 * Many more changes to som.c especially, but these will not be
10810 documented as I have resolved to remove them. This patchlevel is
10811 being released solely so that I can fall back to it if I decide
10812 that removing the changes is not a good idea.
10814 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
10816 * som.c: (global var som) New member `cum_y'.
10817 (build_target) Properly handles titles for partial tables.
10818 (dump_partial_beg, dump_partial_mid, dump_partial_end)
10819 Merged into single new function dump_partial(). Fixed problem
10820 with titles on partial tables.
10821 (dump_table) Calls dump_partial() for all parts of partial tables.
10822 (dump_page) Criteria for drawing title changed.
10824 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
10826 * command.c: (cmd_table) Added LIST, WEIGHT.
10828 * command.c: (cmd_remark) No longer frees `s' since it's not
10829 dynamically allocated.
10831 * data-out.c: (convert_f) Now correctly handles the case where
10832 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
10833 number of decimals.
10834 (som_destroy_all_tables) Removed argument. All callers changed.
10835 (som_vline, som_hline) Argument validity checking corrected.
10836 (som_set_value) Implemented half-heartedly.
10837 (replicate_table) Copies tables piece-by-piece when using Checker.
10839 * som.h: New line style SLIN_1THIN, currently equivalent to
10840 SLIN_0. New enum set SOM_SUB_*.
10841 (struct som_submission_form) Removed `seq_no'. Added `type'.
10843 * list.q: Newly working file; uses partial tables.
10845 * som.c: (som_reduce_table) Renamed som_set_table_height().
10846 (som_crush) Removed argument `group'.
10847 (global var som) Removed `nt', `seq_no'. Added `type'.
10848 (som_submit_table) Arguments changed.
10849 (output_table) Removed partial table code.
10850 (build_target) New arg; partial table support added. All callers
10852 (dump_plain_table) Removed partial table code.
10853 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
10854 (dump_table) Supports partial tables.
10855 (dump_page) New argument to allow not drawing top and/or bottom
10856 headers. All callers changed. Supports partial tables.
10858 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
10860 * data-out.c: Changed `#include <approx.h>' to `#include
10862 (convert_F) Comment fix. Now won't print `-.000', etc.
10864 * descript.q: Now Z-scores work, although there appears to
10865 be a bug (which might actually be in data-out.c:convert_F()).
10866 (descriptives_trns_proc, descriptives_trns_free) New functions.
10867 (run_z_pass) Implemented.
10869 * var.h: Comment fixes.
10870 (dsc_z_score, descriptives_trns) New structs.
10871 (descriptives_trns) Added to any_trns as `dsc'.
10873 * error.c, error.h: New error class, IS (Installation Script
10874 error), used in those instances where the error is in the
10875 installation, but there is a script file or installation file that
10876 can be usefully referred to.
10878 * output.c: Change many IE classes to IS classes.
10880 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
10881 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
10882 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
10883 include the corresponding header?
10885 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
10886 Don't bail out if termcap can't be read.
10888 * som.c: (som_destroy_table) Removed.
10889 (som_reduce_table, som_destroy_all_tables) New functions.
10890 (som_crush) New function, not implemented.
10892 * som.h: New table option STAB_CRUSH. Comment fix. New struct
10893 som_submission_form. Function prototypes revised.
10895 Outputting huge tables (1000s of rows) a few rows at a time
10896 is supported, though untested. May even break everything.
10897 Actually, the code doesn't even compile right now.
10898 * som.c: (struct som) New fields htv, nt, seq_no.
10899 (som_submit_table) Multiple arguments changed to a single
10900 pointer to struct submission_form. Only increments subtable_num
10901 if seq_no is zero. Only destroys table if it's not going to
10903 (replicate_table) New function.
10904 (output_table) Comment fix.
10905 (examine_table) Changed inline code to code calling
10906 replicate_table(). Calculates htv. Supports partial tables.
10907 (draw_title) Removed comment.
10908 (build_target) Only allows for title on first part of partial
10910 (dump_plain_table) Only resets table chunk number on first part
10911 of partial tables; FIXME: doesn't work quite right. Supports
10913 (dump_page) Titles only on first part of partial tables.
10915 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
10917 * Thanks to an unreliable IDE hard drive, I have spent the last
10918 day reconstructing my Debian GNU/Linux installation and redoing
10919 the previous day's changes--somehow I managed to save every file
10920 except for output.c and output.h. So the following changes could
10921 really be considered independent of the output.c, output.h changes
10924 * output.h, output.c: Moved the outp_configure_vec global var,
10925 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
10926 outp_configure_vec is now static.
10928 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
10930 * The entire philosophy behind configuration of the output drivers
10931 changed. Now there is a termcap-type configuration where drivers
10932 to be read are determined beforehand, rather than parsing the
10933 entire output init file and storing it in memory & deciding what
10934 to actually use later. Faster & more memory-efficient at the same
10937 * output.c: Comment fix. Removed outp_init_drivers global var.
10938 Removed all references to synonyms. New structure outp_defn. New
10939 global vars outp_macros, outp_configure_vec.
10940 (search_name, delete_name, add_name, check_configure_vec,
10941 expand_name, find_defn_value) New static functions.
10942 (outp_configure_clear, outp_configure_add, outp_configure_macro,
10943 outp_read_devices) New extern functions.
10944 (outp_init) Much functionality moved into outp_read_devices.
10945 (outp_read_devices) Format of output init file changed; name of
10946 file is `devices' rather than `output' to avoid Makefile
10948 (outp_clear) Renamed outp_done.
10949 (outp_list_classes) Bug fix, cleaned up.
10950 (outp_list_drivers) Not implemented anymore.
10951 (outp_configure_driver) Now a static function; simplified; now
10952 interpolates macros; supports new structure.
10953 (outp_enable_driver, match_synonym) Removed; all references
10955 (find_driver) First argument removed.
10957 * output.h: Global var outp_init_drivers removed; new structure
10958 outp_names; new enum set OUTP_S_*; new global var
10959 outp_configure_vec; function prototypes for output.c exports
10962 * main.c: (main) Calls outp_read_devices() after parsing the
10965 * cmdline.c: (parse_command_line) New option -v --verbose;
10966 --version changed to -V. --device option changed syntax to just
10967 take a single device name. Accepts key=value declaration of
10968 output init file macros. Syntax message updated.
10970 * filename.c: (expand_line) New function.
10971 (interp_environ_vars) Renamed interp_vars; no longer uses
10973 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
10974 overridden by real environment vars.
10975 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
10976 * filename.h: interp_environ_vars() renamed interp_vars().
10978 * error.c, error.h: Added extern variable `verbosity', message
10981 * error.c: (vmsg) Support message class MM.
10982 (verbose_msg) New function.
10984 * descript.q: (generate_z_varname) Bug fix in generation of
10986 (dump_z_table) Bug fix in column headers.
10988 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
10989 page from 29 to 15. Don't set a default for ops[OPS_INIT,
10990 OPS_DONE]. Writes the uninit string when the driver is closed.
10991 (ascii_open_page) Write the init string before the first page.
10992 (output_shorts) Form of main loop changed from `while' to `for'.
10993 Bug fix with overstrikes: the character is printed *after* the
10994 backspace. Eliminated a lot of `& 0xff' modifiers.
10995 (advance_to_left_margin) New function.
10996 (return_carriage, output_lines) Handle left margin.
10998 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
11000 * ascii.c: New option `carriage-return-style'.
11002 * ascii.c: (count_fancy_chars) New function.
11003 (delineate, text_metrics) Use new function; bug fixes regarding
11005 (text_draw) Bug fix with rich text.
11006 (output_string, output_shorts) Reordered.
11007 (output_shorts) Now handles boxchars and some overstrike font
11009 (output_char, return_carriage) New functions.
11010 (output_lines) Now handles overstriking and font changes properly;
11011 some code moved to output_shorts.
11013 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
11016 * ascii.c: New member `debug' in ascii_driver_ext.
11017 (ascii_init_driver, delineate) Uses new member.
11019 Now you can set a vertical height on writing text.
11020 * ascii.c: (delineate) Keeps track of vertical position.
11021 (text_draw) No longer considers fully justified text an internal
11024 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
11026 Tables' titles are drawn; they can have variable height.
11027 * som.c: `som' struct has new member, title_height.
11028 (draw_title) New argument. Moved within file. All caller
11030 (build_target) New argument, amount of space needed for first row.
11031 Calculates height of title, takes that into account. All callers
11033 (dump_plain_table, dump_columnated_table) Took calculation of y1,
11035 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
11037 (dump_columnated_table) Organized for readability.
11038 (dump_page) Makes use of som.title_height.
11040 * som.c: Many comment bug fixes.
11042 * descript.q: (try_name, generate_z_name) Bug fix regarding
11043 generation of Z-score variable names.
11044 * var.h: Removed num from descriptives_proc; all referents removed.
11046 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
11048 * ascii.c: (ascii_line_horz, ascii_line_vert,
11049 ascii_line_intersection) Added debugging code.
11051 Added a descriptive line above each table to describe it.
11052 * command.c: (parse_cmd) Calls som_new_series.
11054 * som.c: New static vars table_num, subtable_num. New `som'
11056 (dump_page) New arguments.
11057 (som_submit_table) Handle new variables.
11059 * som.c, som.h: (som_submit_table) New arguments. All callers
11061 (som_new_series) New function.
11062 (build_target) Makes room for extra line.
11063 (draw_title) New function.
11064 (dump_page) Calls draw_title. Bug fix: doesn't always set
11067 Columnation of tables support.
11068 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
11070 * som.c: Deleted references to fr, lr, ri.
11071 (som_columnate) Bux fix: sets group member of table.
11072 (som_add_options) Function removed.
11073 (dump_table) Split into three functions; extensively reworked.
11075 * descript.q: (dump_z_table) Better output table formatting; added
11076 title support to correspond to som.h changes.
11077 (display) Title support.
11079 * output.h: Added OUTP_T_NONE.
11081 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
11083 * descript.q: Improved handling of Z scores; still not perfect.
11085 * output.h, ascii.c: Added hook for getting em width of current
11088 * som.c: Uses new em-width hook. Added debugging code to
11090 (som_columnate) New argument.
11091 (som_add_options) Removed.
11093 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
11095 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
11096 rules as a property of the table instead of as a property of the
11099 * ascii.c: Added `header' to table of options.
11101 * descript.q: Added even shorter statistic names; modified to work
11102 with new som interface.
11104 * misc.c (blp_getdelim): Bug fix.
11106 * version.c: includes 'conf.h'.
11108 ----------------------------------------------------------------------
11111 version-control: never
projects / pspp-builds.git / blob