1 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
3 * pfm-read.c: (read_version_data) Read and ignore author field.
5 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
7 * get.c: (mtf_processing) Don't assume that
8 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
9 returns a negative, zero, or positive result. Fixes MATCH FILES
10 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
12 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
14 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
15 preprocessor test for sys/types.h was accidentally inverted. This
18 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
20 * get.c: (cmd_match_files) Fix memory leak on `by' and on
23 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
26 * vfm.c: (close_active_file) Remove unnecessary test.
28 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
30 Fix NDEBUG compile errors.
32 * hash.h: Needed explicit #include <assert.h>.
34 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
37 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
39 Implement embedding for PostScript driver. Fixes bug 12970.
41 * ascii.c: Fix compiler warnings.
45 * chart.h: Add `file' member.
47 * output.h: (struct outp_class) initialise_chart, finalise_chart
48 should take outp_driver *, not outp_class *. Update all
51 * plot-chart.c: (chart_create) Fix segfault when there are no
52 output drivers at all.
53 (chart_submit) Call d->class->finalise_chart.
55 * postscript.c: (ps_open_page) Set cp_y to 0.
56 (ps_submit) New function.
57 (ps_chart_initialise) Implement.
58 (ps_chart_finalise) Implement.
59 (static var postscript_class) Add ps_submit.
60 (static var epsf_class) Add ps_submit.
63 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
65 Did some more work on bug 12859 and then realized that a *good*
66 solution would require some fundamental restructuring. For now,
67 I'm marking REPEATING DATA unimplemented, and then we can revisit
70 * command.def: Make REPEATING DATA unimplemented.
72 * data-list.c: (cmd_repeating_data) Assume inline file is 80
74 (realize_value) Revert previous changes; no longer needed.
77 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
78 file_loc, to avoid bad references later.
82 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
84 Make some code tolerant of reentry. Should not be needed if other
85 code is correct but it is good to be generally tolerant.
87 * error.c: (err_hcf) Set file_loc to null after free().
89 * output.c: (outp_done) Similar changes.
91 * str.c: (ds_destroy) Ditto.
93 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
95 Continue work on bug 12859, plus some code cleanup.
97 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
98 boolean variables. Don't try to compute starts_end, cont_end for
99 inline file. Calculate length only after parsing variable
100 specifications. Add proper transformation to list.
101 (realize_value) If the rpd_num_or_var has no value, return new
102 DEFAULT_MEMBER argument (for use with inline file).
103 (repeating_data_trns_proc) Pass default values.
105 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
106 open, and only if we actually started reading data.
108 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
112 * output.c: (outp_read_devices) Fix message.
114 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
116 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
117 of the sort algorithm from the parser for the SORT command.
119 * rank.q: Added the parser for the RANK command.
121 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
125 * sort.c: (sort_parse_criteria) Only set *saw_direction if
126 saw_direction is non-null. Thanks to John Darrington for
129 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
131 * get.c: (mtf_processing) Handle case of a lookup table as the
132 active file. Thanks to John Darrington for reporting this bug.
134 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
136 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
137 POSIX calloc function.
139 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
140 reflect new signature.
142 * sfm-read.c: Now much more robust in the face of badly formed
145 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
147 *sfm-read.c: Fixed some bugs regarding long string continuation
148 records, which the previous fix uncovered.
150 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
152 * sfm-read.c, sfmP.h: Allow reading of system files when the
153 case_size value in the header is -1. Also changed some Errors to
154 Warnings when reading system files.
156 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
158 * data-list.c: (data_list_trns_free) Don't free the argument
159 because cancel_transformations() will do that itself.
160 (data_list_source_destroy) Destroy the argument to
161 data_list_trns_free(), because it no longer does so itself.
163 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
165 * data-out.c: (format_and_round) Don't output leading `-' if value
168 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
172 * som.c: (output_encodings) If some cell in the table won't fit
173 with the horizontal or vertical headers, cancel those headers.
175 * som.h: (struct som_table_class) Add fits_width, fits_length,
178 * tab.c: (tabi_fits_width) New function.
179 (tabi_fits_length) New function.
180 (tabi_set_headers) New function.
181 (global var tab_table_class) Add the new functions as appropriate
184 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
186 Fix rest of bug 13054.
188 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
189 DATETIME, TIME system/portable file values.
191 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
193 * data-list.c: (parse_free) Use make_input_format().
195 * data-out.c: (num_to_string) Use make_output_format().
197 * dictionary.c: (dict_create_var) Ditto.
199 * format.c: (global var f8_2) New var.
200 (make_input_format) New function.
201 (make_output_format) New function.
203 * get.c: (cmd_match_files) Use make_output_format().
205 * list.q: (cmd_list) Ditto.
207 * matrix-data.c: Ditto.
209 * sfm-read.c: (parse_format_spec) Check output specifier
212 * tab.c: (tab_float) Use make_output_format().
214 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
216 Fix more of bug 13054.
218 * format.def: FMT_A should allow 255-character output. FMT_AHEX
219 should allow 510-character input and output.
221 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
222 (convert_E) Handle non-finite values.
224 (format_and_round) New function.
225 (convert_infinite) New function used by try_F() and convert_E().
227 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
229 Regularize string and buffer function names so that they make some
232 * str.c: (mm_reverse) Rename buf_reverse(). Update all
234 (mm_find_reverse) Rename buf_find_reverse(). Update all
236 (mm_case_compare) Rename buf_compare_case(). Update all
238 (st_compare_pad) Rename buf_compare_rpad(). Update all
240 (str_compare_rpad) New function.
241 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
243 (buf_copy_str_lpad) New function.
244 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
246 (st_pad_copy) Rename str_copy_rpad(). Update all references.
247 (st_trim_copy) Rename str_copy_trunc(). Update all references.
248 (st_uppercase) Renamed str_uppercase(). Update all references.
250 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
252 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
255 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
257 * data-in.c: (data_in) Add assertion to check input specifier.
259 * data-out.c: (data_out) Add assertion to check output specifier.
261 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
263 Start to fix bug 13054.
265 * format.c: (check_input_specifier) Improve error message.
266 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
267 valid decimal places.
268 (check_output_specifier) Ditto (but different criteria).
269 (convert_fmt_ItoO) Assert valid input and output specifiers.
270 Also, if input specifier has *any* decimal places, make the output
271 specifier 1 place wider.
273 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
275 * sysfile-info.c: Fixed bug [# 13024 ]
277 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
279 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
280 actually implement it.
282 * command.c: (FILE_TYPE_okay) Always return 1.
284 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
286 * file-type.c: Add prototypes to get rid of warnings.
288 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
290 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
291 more ISO/IEC 9899:1990 conformance issues.
293 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
295 Fix bug 12948. See also new test in
296 tests/bugs/match-file-scratch.sh.
298 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
299 that deletes scratch variables that someone else might be using,
300 and because we can't reassign our sources' value indexes.
301 Instead, simply don't copy scratch variables into the master
304 * dictionary.c: (dict_compact_values) Delete variables from the
305 dictionary passed in, not from default_dict (!).
307 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
309 Improve hash.c comments, error-checking.
311 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
312 (hsh_create) size == 0 should *not* return NULL! Set
314 (hsh_clear) Set hash_ordered.
315 (locate_matching_entry) Check hash_ordered.
316 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
317 (hsh_data) Set hash_ordered. Add const-ness to return value and
321 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
323 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
325 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
327 * copyleft.c: Updated copyright date.
329 * Makefile.am: Removed erroneous explicit "-lplot"
331 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
333 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
335 * command.c command.def: Added description string for unimplemented commands.
337 * oneway.q: Sorted the hash tables before shipping out the results. Closes
340 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
344 * data-list.c: (parse_fixed) Use lex_end_of_command().
346 (cmd_repeating_data) Set cont_end.num in right situations.
347 (parse_repeating_data) Remove redundant test.
349 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
351 Partial fix for bug 12859.
353 * data-list.c: (cmd_data_list) Add transformation properly in
354 vfm_source == NULL case.
356 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
358 * lexer.c: (lex_error) Improve error messages.
360 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
362 * get.c: (cmd_match_files) Check token type before trying to match
363 tokid. Fixes bug 12923.
365 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
367 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
370 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
372 * expressions/generate.pl: (get_token) Make use of /g
373 backward-compatible with Perl 5.6.1.
375 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
377 * var-display.c: (cmd_variable_alignment) Fix memory leak.
378 (cmd_variable_level) Ditto.
380 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
382 Hash table had buggy deletion function. The fix required changing
383 other functions to do probing in the required order.
385 * hash.c: (locate_matching_entry) Rewrite and change interface.
386 (hsh_rehash) Rewrite to use locate_matching_entry().
389 (hsh_delete) Ditto. Also, fix stupid bugs.
391 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
393 * dictionary.c: (dict_clone) Properly copy vectors.
395 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
397 New implementation of long variable names. Each variable has a
398 "normal" name, which may be up to 64 bytes long and which is used
399 for all normal operations. Variables may have a "short" name,
400 which is limited to 8 bytes and used only for system and portable
401 file input and output.
403 Make tokid case-preserving. Update most uses of tokid to treat it
406 Update many commands to deal with long variable names.
408 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
410 * command.c: (cmd_parse) Ditto.
411 (match_strings) Use toupper() before comparing characters.
412 (conflicting_3char_prefixes) Use mm_case_compare() instead of
414 (cmd_match_words) Ditto.
416 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
419 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
420 Use st_trim_copy() instead of strcpy().
422 * data-in.c: (parse_enum) Use mm_case_compare() instead of
425 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
427 (parse_free) Use st_trim_copy() instead of strcpy().
429 * descript.c: (struct dsc_var) Change z_name[] to fit long var
431 (try_name) Use strcasecmp() instead of strcmp().
432 (generate_z_varname) Use st_trim_copy() instead of strcpy().
433 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
436 * dictionary.c: (struct dictionary) Removed `long_name_tab'
438 (compare_long_names) Removed.
439 (hash_long_name) Removed.
440 (dict_create) Don't initialize `long_name_tab' member.
441 (dict_clone) Copy short names into new dictionary.
442 (dict_clear) Don't clear `long_name_tab' member.
443 (dict_get_varname_block) Removed.
444 (dict_add_longvar_entry) Removed.
446 (dict_destroy) Don't destroy `long_name_tab' member.
447 (dict_create_var_from_short) Removed.
448 (dict_create_var_x) Removed.
449 (dict_create_var) Get rid of longname handling.
451 (dict_clone_var) Get rid of longname parameter and longname
453 (dict_lookup_var) Get rid of longname handling.
454 (dict_reorder_var) New function.
455 (dict_rename_var) Clear short name.
456 (dict_rename_vars) Get rid of longname handling. Clear short
458 (dict_create_vector) Support long vector names.
459 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
460 (quasi_base27) Removed.
461 (make_short_name) Removed.
462 (compare_strings) New function.
463 (hash_string) New function.
464 (dict_assign_short_names) New function.
466 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
468 (get_handle_for_filename) Support long handle names.
470 * file-type.c: (struct col_spec) Make `name' fit long var names.
471 (cmd_file_type) Use strcasecmp() instead of strcmp().
473 * flip.c: (make_new_var) Rewrite.
474 (flip_sink_write) Use st_trim_copy() instead of strncpy().
476 * format.c: (parse_format_specifier_name) Use mm_case_compare()
479 * get.c: (cmd_save_internal) Rephrase.
480 (rename_variables) Drop test for identical variable name.
481 (struct mtf_proc) Change `first', `last' to fit long var name.
483 * hash.c: (hsh_hash_case_string) New function for case-insensitive
486 * lexer.c: (restore_token) Use st_trim_copy() instead of
488 (lex_get) Don't uppercase string when copying into tokid.
489 (lex_put_back_id) Use st_trim_copy() instead of
492 * list.q: (determine_layout) Consider length of variable names in
493 choosing vertical layout.
495 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
497 (string_to_content_type) Ditto.
499 * modify-vars.c: (compare_variables_given_ordering) Ditto.
500 (struct var_renaming) Change `new_name' to fit long var name.
501 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
504 * pfm-read.c: (read_variables) Disallow system variables in system
506 (write_variables) Call dict_assign_short_names() and use
507 short_name[] members.
509 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
512 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
513 map. Reorder variables into same order as long variable map.
514 (read_variables) Set short name.
516 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
517 (write_variable) Use st_bare_pad_copy().
518 (write_longvar_table) Rewrite.
520 * str.c: (mm_case_compare) New function.
522 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
525 * t-test.q: (tts_custom_groups) Remove redundant test.
526 (tts_custom_pairs) Ditto.
528 * var.h: (struct variable) Change `name' to fit long var names.
529 Remove `longname'. Add `short_name' member. Reorder some
531 (struct name_table_entry) Removed.
532 (struct vector) Change `name' to fit long vector names.
534 * vars-atr.c: (var_is_valid_name) Allow long var names.
535 (compare_var_names) Use strcasecmp() instead of strcmp().
536 (compare_var_ptr_names) Ditto.
537 (hash_var_name) Use hsh_hash_case_string().
538 (hash_var_ptr_name) Ditto.
539 (var_set_short_name) New function.
540 (var_clear_short_name) New function.
541 (var_set_short_name_suffix) New function.
543 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
544 Use strcasecmp() instead of strcmp().
545 (struct array_var_set) Removed `longname_tab'.
546 (array_var_set_lookup_var_idx) Drop longname_tab support.
547 (array_var_set_destroy) Don't destroy `longname_tab'.
548 (var_set_create_from_array) Don't create `longname_tab'.
550 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
553 * expressions/parse.c: (word_matches) Use mm_case_compare()
555 (compare_strings) New function.
556 (lookup_function) Use compare_strings() instead of strcmp().
558 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
560 * algorithm.c: (move_element) New function.
562 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
564 * aggregate.c: (parse_aggregate_functions) Always initialize
567 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
569 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
571 * dictionary.c: (dict_clone) Ditto.
572 (dict_clone_var_assert) New function.
574 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
576 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
578 * error.c: Added a string for the compiler version to the
579 request_bug_report_and_abort function.
581 * groff_font.c, font.c: Removed manpage(1) style references from
582 comments, because RMS frowns upon them.
584 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
586 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
588 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
590 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
593 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
595 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
596 which should be LONG_NAME_LEN
598 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
600 * command.def echo.c: Added the ECHO command.
602 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
604 Finish fixing MATCH FILES (bug 11677).
606 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
607 keep_variables(), rename_variables().
608 (drop_variables) New function.
609 (keep_variables) New function.
610 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
611 (cmd_match_files) Deal with in_var. Use drop_variables(),
612 keep_variables(). When IN is specified, require BY. Set master
613 variables after master dictionary is complete. Add IN variables
614 after master dictionary is complete.
615 (mtf_free_file) Free `in_name'.
616 (mtf_delete_file_in_place) Set in_var value to 0.
617 (mtf_read_nonactive_records) Rephrase.
618 (mtf_processing) Support IN. Rephrase. Fix bugs.
619 (mtf_merge_dictionary) Don't set master variables; we do that
621 (get_master) Don't insist that there's a master variable.
623 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
625 Kluge to make some variable renaming sort of work.
628 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
630 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
632 Add functions for comparing sets of variables between cases.
635 * case.c: (case_compare) New function.
636 (case_compare_2dict) New function.
638 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
640 (cmd_aggregate) Nullify break_case. Don't call
641 initialize_aggregate_info().
642 (agr_destroy) Destroy break_case.
643 (aggregate_single_case) Rewrite. Use case_compare().
644 (dump_aggregate_info) Copy from break_case into output.
645 (initialize_aggregate_info) Copy break_case from input.
647 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
649 * vfm.c: (equal_splits) Use case_compare().
651 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
653 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
655 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
657 Start work on fixing MATCH FILES.
659 * get.c: (enum operation) Remove OP_MATCH.
660 (trim_dictionary) Change return value to bool. Don't support
662 (struct mtf_file) Remove `first', `last' members.
663 (struct mtf_proc) Add `first', `last' members. Change mtf_case
664 from `struct ccase *' to `struct ccase'. Remove `by' member.
665 (cmd_match_files) Essentially rewrite.
666 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
667 (mtf_read_nonactive_records) mtf_ parameter is not unused.
668 (mtf_processing) Ditto. Also rephrase some code.
669 (mtf_merge_dictionary) Rewrite for easy comprehension.
671 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
673 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
676 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
678 Thu Apr 14 2005 John Darrington
680 * var-display.c: New file.
682 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
683 display_width, measure and alignment parameters to variables.
685 * aggregate.c command.def compute.c count.c data-list.c descript.c
686 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
687 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
688 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
689 vars-prs.c vector.c :
690 - Replaced literal constants representing maximum variable name
691 length with macro definitions.
692 - Added support for long variable names.
693 - Changed lexer such that it no longer makes tokens upper
694 case, but relies upon case insensitive behaviour of commands.
696 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
698 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
699 fails, don't dereference the resulting null pointer (bug 12427).
700 Also, fix double free error.
702 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
704 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
705 (accumulate_aggregate_info) Set int1 to 1 for SUM.
706 (dump_aggregate_info) Only make SUM non-missing if there was at
709 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
711 * aggregate.c: (dump_aggregate_info) Properly test whether the
712 destination variable is numeric, when making the result
713 system-missing for columnwise missing values.
715 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
717 * misc.h: Remove GCC specializations.
719 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
721 Make sort stable (bug 12313).
723 * sort.c: Don't need to include some headers anymore.
724 (static var min_buffers) New variable.
725 (static var max_buffers) New variable.
726 (static var allow_internal_sort) New variable.
727 (cmd_sort_cases) Add test mode.
728 (sort_execute) Rephrase.
729 (do_internal_sort) Don't try internal sorting if
730 allow_internal_sort is set.
731 (struct external_sort) Renamed `initial_runs' to `runs' and
732 updated all references.
733 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
734 (macro MIN_BUFFER_SIZE_BYTES) Removed.
735 (macro MIN_BUFFER_SIZE_RECS) Removed.
736 (compare_initial_runs) Removed.
737 (struct record_run) Add member `idx'.
738 (write_initial_runs) Pass increasing values to process_case() as
740 (process_case) Add `idx' parameter and use it to initialize new
742 (allocate_cases) Limit allocated buffers to max_buffers.
743 (compare_record_run) Use new `idx' member for last resort
744 comparison, for stability.
745 (end_run) Call casefile_sleep() on irs->casefile, to prevent
746 running out of file descriptors.
747 (struct merge_state) Removed.
748 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
749 unless we have fewer runs left. Always merge consecutive runs,
750 for stability. Return the final run.
752 (choose_merge) New function.
753 (merge_once) Rewritten.
755 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
757 * cmdline.c: (static var testing_mode) Move into
758 parse_command_line().
760 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
762 * algorithm.c: (remove_range) New function.
763 (remove_element) New function.
765 * dictionary.c: (dict_delete_var) Use remove_element().
767 * flip.c: (cmd_flip) Ditto.
769 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
771 * file-handle.q: (struct file_handle) `open_mode' should not be
774 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
776 First phase of making SORT CASES stable (bug 12313).
778 * sort.c: (struct indexed_case) New structure.
779 (do_internal_sort) Rewrite to make internal sorting stable.
780 (compare_case_dblptrs) Removed.
781 (compare_indexed_cases) New function.
783 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
787 * casefile.c: (casereader_read_xfer_assert) New function.
789 * dictionary.c: (dict_compact_case) New function.
791 * flip.c: (struct flip_pgm) New member idx_to_fv.
792 (cmd_flip) Initialize idx_to_fv member.
793 (destroy_flip_pgm) Free idx_to_fv member.
794 (flip_sink_write) Use struct flip_pgm member instead of case_sink
796 (flip_sink_write) Ditto.
798 * vfm.c: (write_case) Use dict_compact_case() instead of
800 (compact_case) Removed.
801 (storage_source_create) Removed `dict' parameter. All references
804 * vfm.h: (struct case_source) Removed `value_cnt' member. All
806 (struct case_sink) Removed `dict', `idx_to_fv' members. All
809 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
811 More AGGREGATE fixes.
813 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
814 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
816 (initialize_aggregate_info) Fix initialization for MIN, MAX for
819 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
821 Start work on testing and debugging AGGREGATE.
823 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
824 of a bit-map. Require proper subcommand ordering. Make OUTFILE
825 subcommand mandatory.
826 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
827 functions' arguments are in the correct order and swap them if
829 (accumulate_aggregate_info) Make SUM include weights. Add various
831 (dump_aggregate_info) Add various string functions.
832 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
834 * sort.c: (sort_parse_criteria) Add parameter for returning
835 whether any directions were specified. All callers updated.
837 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
839 * t-test.q: Fixed erroneous logic in compare_group_binary.
841 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
843 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
844 keywords (bug 11628).
846 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
848 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
849 called *before* close_active_file().
851 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
853 * file-handle.q: (struct file_handle) Change open_mode from
854 character pointer to 3-char array, for safety. Updated all
857 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
859 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
862 * pfm-read.c: (read_header) Improve error message for many cases
863 in which the input is not actually a portable file.
865 * file-handle.q: (fh_open) When we give an error message, actually
868 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
870 * format.c: (check_common_specifier) New function for checks
871 common to check_input_specifier() and check_output_specifier().
872 (check_input_specifier) Use check_common_specifier().
873 (check_output_specifier) Use check_common_specifier().
874 (check_string_specifier) Removed.
875 (check_specifier_type) New function.
876 (check_specifier_width) New function.
877 (get_format_var_width) Fix bug.
879 * formats.c: (internal_cmd_formats) Only accept numeric variables.
881 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
882 update all references. Make case-insensitive.
884 * pfm-read.c: Essentially rewrite the whole file. Now much
887 * print.c: (check_string_width) New function.
888 (fixed_parse_compatible) Use check_string_width(),
889 check_specifier_type().
890 (dump_fmt_list) Ditto.
892 * str.c: (st_trim_copy) New function.
893 (st_uppercase) New function.
895 * vars-atr.c: (var_is_valid_name) New function.
897 * expressions/parse.c: (type_coercion_core) Use
898 check_specifier_type().
900 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
902 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
904 * expressions/parse.c: (no_match) Ditto.
906 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
908 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
910 * expressions/helpers.c: (struct func_params) Removed.
911 (generalized_idf) Removed.
914 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
916 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
917 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
918 Implement SIG.F, which I had overlooked previously.
920 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
922 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
923 available only in testing mode.
925 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
927 * data-in.c: Use `bool' throughout, where relevant.
929 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
931 DATA LIST with free-field formats should not have implied decimal
932 places (bug 12035). Also clean up data-in.c a bit.
934 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
936 * data-in.c: (apply_implied_decimals) New function.
937 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
938 set. Also, get rid of gotos.
939 (parse_Z) Use apply_implied_decimals() if the field doesn't
940 contain a decimal point.
941 (parse_N) Use apply_implied_decimals().
947 (parse_enum) New function.
948 (macro CHAR_IS_ROMAN) Removed.
949 (macro ROMAN_VALUE) Removed.
950 (parse_month) Use parse_enum().
951 (parse_weekday) Use parse_enum().
952 (parse_DATETIME) Use long for weekday.
954 * data-list.c: (read_from_data_list_fixed) Use
957 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
959 When the lexer sees something like `-5' in the input, it has to
960 decide whether it's a negative numeric constant token or a '-'
961 token followed by a positive numeric constant token. It always
962 decides on the former, and then the parser can call
963 lex_negative_to_dash() if it wants the latter. However, this
964 doesn't work for the case of `-0', because negative zero is
965 (portably) indistinguishable from positive zero. So now we divide
966 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
967 distinction clear. This requires a little bit of extra effort,
968 because there were several references to T_NUM in the code base.
970 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
971 positive and negative numeric constants.
972 (lex_double_p) Renamed lex_is_number(). Changed return type to
973 bool. Updated all relevant references to T_NUM to instead use
975 (lex_double) Renamed lex_number(). All references updated.
976 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
977 bool. All references updated.
978 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
979 (lex_negative_to_dash) Ditto.
982 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
984 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
986 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
988 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
990 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
991 values as system-missing.
993 * expressions/parse.c: (parse_vector_element) Fix order of
994 arguments in call to expr_allocate_binary().
996 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
998 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1001 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1002 failure, as indicated by function comment.
1003 (parse_binary_operators) Always return NULL on type_coercion()
1004 failure. Should have been doing this anyway, but bug in
1005 type_coercion_core() filtered through.
1006 (parse_add) Fix typo in user message.
1007 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1009 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1011 * expressions/operations.def: Add VALUE function.
1013 * expressions/parse.c: (parse_function) Need an unary composite
1014 node for variables in A TO B, not a variable node. Use
1015 allocate_unary_variable().
1016 (parse_primary) Use allocate_unary_variable().
1017 (allocate_unary_variable) New function.
1019 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1021 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1022 but fixed the real problem that was preventing the build from a
1023 separate directory. I liked it my way better ;-)
1025 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1027 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1028 John Darrington <john@darrington.wattle.id.au> for reporting this
1031 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1033 * expressions/Makefile.am expressions/evaluate.h.pl
1034 expressions/evaluate.inc.pl expressions/operations.h.pl
1035 expressions/optimize.inc.pl expressions/parse.inc.p:
1037 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1040 Fixed everything so that it can be built from an arbitrary
1043 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1045 * Makefile.am : Fixed up CLEANFILES target.
1047 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1049 * str.h: Changed `struct len_string' to `struct fixed_string', a
1050 more accurate name. Updated all references.
1052 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1054 Redo calendar support. Should now be bug-for-bug compatible.
1056 * calendar.c: New file.
1058 * calendar.h: New file.
1060 * data-in.c: Use new calendar functions.
1061 (parse_sign) Change sense of return value.
1062 (calendar_error) New function.
1063 (ymd_to_ofs) New function.
1064 (ymd_to_date) New function.
1065 (parse_DATE) Use new function.
1066 (parse_ADATE) Ditto.
1067 (parse_EDATE) Ditto.
1068 (parse_SDATE) Ditto.
1069 (parse_JDATE) Ditto.
1074 (parse_DTIME) Ditto.
1075 (parse_DATETIME) Ditto.
1077 * data-out.c: (convert_date) Use new calendar functions.
1079 * error.c: (err_vmsg) Changed interface to be more sensible.
1080 Updated all callers.
1081 (dump_message) Don't double new-lines (why did we do this
1084 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1086 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1087 (macro FLT64_MAX) Moved here from pref.h.orig.
1089 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1091 * set.q: Support SET EPOCH.
1092 (static var set_epoch) New var.
1093 (aux_stc_custom_epoch) New function.
1094 (stc_custom_epoch) New function.
1095 (get_epoch) New function.
1096 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1098 * format.c: Make it possible just to check whether a specifier is
1099 valid without emitting an error message.
1100 (parse_format_specifier_name) Change interface, update all
1102 (check_input_specifier) Ditto.
1103 (check_output_specifier) Ditto.
1104 (parse_format_specifier) Ditto.
1106 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1108 * command.def: Add DEBUG POOL.
1110 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1112 (pool_clear) Properly account for size of pool gizmo.
1113 (pool_realloc) Ditto.
1114 (pool_clone) New function.
1116 * pool.h: Mark our allocation functions MALLOC_LIKE.
1118 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1120 * Makefile.am: Move many definitions into new top-level
1121 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1122 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1125 * case.c: (case_resize) New function.
1126 (case_swap) New function.
1128 * casefile.c: Include mkfile.h.
1130 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1132 * sfm-read.c: Fixed a buglet which caused a crash when trying
1133 to read a non-existent file.
1135 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1139 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1140 Important part: get rid of spurious copying of function->format to
1141 destvar->print and destvar->write.
1143 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1145 Fix bug 11916, which was confusing a variable's `index' member
1146 with the variable's position in a var_set. Although these are
1147 usually the same, they are not for array `var_set's.
1149 Took advantage of this bug as an opportunity to clean up and
1150 rewrite parse_var_set_vars().
1152 * vars-prs.c: (parse_vs_variable_idx) New function.
1153 (parse_vs_variable) Reimplement in terms of
1154 parse_vs_variable_idx().
1155 (parse_var_idx_class) New function.
1156 (add_variable) New function.
1157 (add_variables) New function.
1158 (parse_var_set_vars) Rewritten.
1159 (struct var_set) Change `lookup_var' member that returns a
1160 variable into `lookup_var_idx' member that returns an int.
1161 Updated the var set implementations in obvious corresponding ways.
1162 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1164 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1166 Use our global variable compare & hash functions and give them
1167 better names. Add similar functions for dealing with double
1168 pointers to variables.
1170 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1171 (hash_variable) Renamed hash_var_name().
1172 (compare_var_ptr_names) New function.
1173 (hash_var_ptr_name) New function.
1175 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1177 (compare_var_name) Removed.
1178 (hash_var_name) Removed.
1180 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1184 * dictionary.c: (compare_variable_dblptrs) Rename
1185 compare_var_ptrs() and fix it to properly dereference the double
1188 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1190 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1191 declare subcommands as mandatory. Closed bug #11843
1193 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1195 * getline.c command.[ch] command.def: Added (very rudimentary)
1196 support for line completion when in interactive mode. Partially
1197 addresses bug #11693
1199 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1201 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1202 problems revealed by valgrind.
1205 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1207 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1208 whether or not PAGER is set.
1210 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1212 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1213 "invalid free" errors. Hopefully fixes bug #11722
1215 * compute.c expr-prs.c: Check that lvalues are populated before
1216 attempting to destroy them. Closes bug #11676
1218 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1220 * aggregate.c: Initialised the complete agr_proc structure.
1224 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1226 * print.c: (print_trns_free) Close the dfm writer if there is one,
1227 fixing a memory leak.
1229 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1231 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1235 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1237 * linked-list.[ch] Added
1239 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1240 set.q: Yet more memory leaks
1242 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1244 * t-test.q examine.q : More memory leaks fixed.
1246 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1248 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1251 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1253 * ascii.c cartesian.c casefile.c chart.h devind.c
1254 examine.q frequencies.q
1255 html.c output.h piechart.c plot-chart.c plot-hist.c
1257 Integrated the chart rendering into the output stream
1258 (currently only works for html).
1260 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1261 dummy-chart.c for compiling without charts.
1263 * mkfile.[ch] Created.
1265 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1266 Added type element so we can tell if it's a chart or a table.
1268 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1269 API of charts to be more like that of tables.
1271 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1273 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1274 main.c. Removed the handler for SIGQUIT.
1276 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1278 * casefile.c: Added a signal handler to delete temp files on
1281 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1283 * command.def Added a lot more unimplemented commands.
1285 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1287 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1289 * sort.c: (compare_initial_runs) Needed additional level of
1291 (merge_once) Fix plenty of stupid mistakes.
1293 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1295 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1296 calling casefile_to_disk() or we will lose the last block in the
1297 file if the casefile started out as disk-based.
1298 (casefile_get_reader) Initialize reader->destructive to 0.
1299 (cmd_debug_casefile) Add new test pattern.
1300 (test_casefile) Define new test pattern to make sure
1301 casefile_sleep() works properly.
1303 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1305 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1306 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1307 attempt to seperate the creation and processing of charts from their
1310 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1313 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1315 * main.c Added a signal handler for SIGFPE
1317 * sort.c Somewhat more robust fix to the previous entry.
1319 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1321 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1322 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1323 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1326 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1328 * case.h Fixed bug # 11307
1330 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1332 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1335 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1337 * pfm-read.c: (read_variables) Remove direct manipulation of
1338 v->aux, which is no longer needed. Fixes bug 11483.
1340 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1342 * data-list.c Fixed a bug in parsing delimiters.
1344 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1347 * percentiles.c Properly handled calculation of Tukey hinges where
1348 the number of data is small.
1350 * oneway.q Used the generic value_to_string function for independent
1351 variable instead of trying to do it ourselves.
1353 * box-whisker.c Fixed a buglet which caused a crash if the number of
1357 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1359 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1361 * percentiles.c Fixed some bugs when calculating percentiles when
1362 there's a small number of cases.
1364 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1366 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1368 * examine.q factor_stats.[ch] Added calculation of percentiles
1370 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1372 * t-test.q Fixed bug #11227 Made t-test work when the independent
1375 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1377 * factor_stats.c Fixed calculation of trimmed mean under various
1380 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1382 * histogram.c chart.[ch] factor_stats.c frequencies.q
1384 Added code to calculate sensible histogram ranges and limits.
1386 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1388 * chart.h Updated to reflect many API changes.
1390 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1391 cartesian.c and into chart.c
1393 * factorstats.[ch] Added the histogram calculations
1395 * casefile.c Removed an unused variable.
1397 * frequencies.q examine.q histogram.c Reworked the API for
1400 * piechart.c Revised the API for piecharts.
1402 * var.h Moved the definitions of freq_tab and freq out of var.h
1403 and into frequencies.q where they belong.
1405 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1407 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1408 using AC_TYPE_OFF_T.
1410 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1412 * flip.c: (flip_file) If fseeko() is not available, use long int
1413 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1414 reporting the problem.
1416 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1418 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1419 conflict with stdio.
1421 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1423 * var-labs.c (var_to_string) Now returns null if the variable is null
1425 * value-labels.c (value_to_string) Made it return null if either the
1426 value or the variable is null.
1428 * hash.c (hsh_clear) Fixed a buglet.
1430 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1431 with the wrong model.
1433 * casefile.[ch] Added a function to return the casereader.case_idx
1436 * examine.q Implemented the extreme values results.
1438 John Darrington <john@darrington.wattle.id.au>
1440 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1441 output.[ch] getline.c
1443 Plugged some memory leaks
1445 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1447 Adopt GSL random number generators, paving the way for providing
1448 the complete suite of random number generators on expressions.
1450 * Makefile.am: Remove random.c, random.h.
1452 * random.c: Removed.
1454 * random.h: Removed.
1456 * algorithm.c: (algo_default_random) Use GSL functions.
1458 * casefile.c: (test_casefile) Use GSL RNG functions.
1460 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1463 * sample.c: (cmd_sample) Use GSL RNG functions.
1464 (sample_trns_proc) Ditto.
1466 * set.q: (static var set_seed) Removed.
1467 (static var seed_flag) Removed.
1468 (static var rng) New variable.
1469 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1470 (stc_custom_seed) Use new seed functions.
1471 (seed_is_set) Removed.
1472 (get_rng) New function that composes the entire external
1474 (set_rng) New function.
1475 (random_seed) New function.
1477 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1479 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1480 John Darrington <john@darrington.wattle.id.au> for reporting this
1483 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1485 * permissions.c command.def Added the PERMISSIONS command
1487 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1489 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1490 output file because that will precede #include <config.h>, which
1492 (main) Add needed headers to /* (header) */ code.
1494 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1496 Instead of making system or portable file readers responsible for
1497 dropping and reordering variables, make them read full cases and
1498 let the caller take care of any changes.
1500 * get.c: New "case map" structure to handle this. Use for GET,
1501 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1503 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1504 changed appropriately.
1506 * sfm-read.c: (sfm_read_case) Ditto.
1508 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1510 Decided that case_serialize() and case_unserialize() were too
1511 abstract. Also we need a couple more functions to avoid excessive
1512 copying for data in/out fast paths.
1514 * case.c: (case_serial_size) Removed.
1515 (case_serialize) Rename case_to_values() and make its argument
1516 explicitly an array of union values.
1517 (case_unserialize) Rename case_from_values() and make its argument
1518 explicitly an array of union values.
1519 (case_data_all) New function.
1520 (case_data_all_rw) New function.
1522 * casefile.c: (struct casefile) Change buffer from array of
1523 unsigned char to array of union value for better accuracy.
1524 Redefine buffer_used and buffer_size in terms of values, not
1525 bytes. Remove case_size because it is now redundant with
1526 value_cnt. Fix up all references to these members.
1528 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1530 * barchart.c: (struct subcat) Make `label' member const to silence
1531 GCC warning with -Wwrite-strings.
1533 * cartesian.c: (struct dataset) Ditto.
1535 * case.c: Don't re-define NDEBUG if already defined.
1536 Add lots of comments.
1538 * str.c: Fix includes.
1540 * crosstabs.q: Fix includes.
1542 * examine.q: Fix includes. Fix GCC warning about unused
1545 * frequencies.q: (stat macro) Removed and replaced where used by
1548 * list.q: Fix includes.
1550 * oneway.q: Fix includes.
1552 * piechart.c: Fix includes. Only define M_PI if not already
1555 * sfm-read.c: (bswap) New function.
1556 (bswap_int32) Write in terms of bswap.
1557 (bswap_flt64) Ditto.
1559 * str.c: (ds_data) Add external definition here, needed because
1560 str.h has only an `extern inline' version.
1562 * value-labels.c: Fix includes.
1564 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1566 Instead of providing a system or portable file writer with a raw
1567 case in the format needed for output, provide it with a regular
1568 case. The writer takes care of any needed translation.
1570 * aggregate.c: Adopt new scheme for AGGREGATE.
1571 (struct agr_proc) sfm_agr_case member removed.
1572 (write_case_to_sfm) Removed because the new interface is easier to
1575 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1577 * pfm-write.c: Implement new scheme.
1579 * sfm-write.c: Ditto.
1581 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1583 Instead of treating `struct file_handle' as a class to subclass
1584 into data files, system files, and portable files, instead use it
1585 as a helper that coordinates access. Now it is opaque, too.
1587 This means that most references to a struct file_handle are now
1588 changed into references to one of struct dfm_reader, struct
1589 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1590 pfm_reader, or struct pfm_writer, according to what's being read
1593 Most related changes are only worth summarizing briefly.
1595 * dictionary.c: (dict_clear) Destroy aux data in deleted
1597 (dict_clear_aux) New function.
1598 (dict_create_var) Initialize aux, aux_dtor.
1599 (dict_delete_var) Destroy aux data in deleted variable.
1601 * file-handle.h: (struct fh_ext_class) Removed.
1602 (struct file_handle) Removed.
1603 (fh_init_files) Removed.
1605 * file-handle.q: Changed references to a handle's `private' member
1606 to direct references.
1607 (struct private_file_handle) Renamed file_handle.
1608 Add next, open_cnt, type, open_mode, aux members.
1609 (struct file_handle_list) Removed.
1610 (extern var inline_file) Removed.
1611 (static var file_handles) Changed from file_handle_list * to
1613 (create_file_handle) Initialize new members.
1614 (fh_close_handle) Removed.
1615 (mode_name) New function.
1616 (fh_open) New function.
1617 (fh_close) New function.
1618 (fh_parse_file_handle) Renamed fh_parse().
1620 * glob.c: (init_glob) Remove fh_init_files() call.
1622 * aggregate.c: use sfm_writer.
1623 (create_sysfile) Removed because the new interface is simpler.
1625 * apply-dict.c: Use sfm_reader.
1627 * data-list.c: Use dfm_reader.
1629 * file-type.c: Use dfm_reader.
1631 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1633 * inpt-pgm.c: Use dfm_reader.
1635 * print.c: Use dfm_writer.
1637 * sysfile-info: Use sfm_reader.
1639 * dfm-read.c: Adopt new file handle infrastructure.
1641 * dfm-write.c: Ditto.
1643 * pfm-read.c: Ditto.
1645 * pfm-write.c: Ditto.
1647 * sfm-read.c: Ditto.
1649 * sfm-write.c: Ditto.
1651 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1653 Break dictionary functions into separate header file.
1655 * dictionary.h: New file.
1657 * var.h: Moved dict_*() functions to dictionary.h.
1659 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1661 Get rid of procedure-specific union in struct variable, using
1662 instead a void * pointer and a destructor function.
1664 Most related changes are only worth brief summaries.
1666 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1667 old p.crs member in struct variable.
1669 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1670 of old p.frq member in struct variable.
1672 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1673 it's no longer possible to grab this from var->p.frq.
1675 * piechart.c: (draw_piechart) Ditto.
1677 * group.c: (group_proc_get) New function.
1679 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1686 * main.c: (execute_command) Clear aux data in default_dict after
1687 each command. (It's debatable whether this should be done.)
1689 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1690 member in struct variable.
1692 * means.q: Get rid of integer mode, which is not included in
1693 recent SPSS and was the only code that wanted per-variable private
1696 * var.h: (struct crosstab_proc) Removed.
1697 (struct frequencies_proc) Removed.
1698 (struct list_proc) Removed.
1699 (struct get_proc) Removed.
1700 (struct means_proc) Removed.
1701 (struct matrix_data_proc) Removed.
1702 (struct match_files_proc) Removed.
1703 (lots of enums) Removed.
1704 (struct variable) Removed members `p', `get'. Add member
1707 * vars-atr.c: (var_attach_aux) New function.
1708 (var_detach_aux) New function.
1709 (var_clear_aux) New function.
1710 (var_dtor_free) New function.
1711 (discard_variables) Use NULL instead of inline_file.
1713 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1715 * value-labs.c Fixed the implmentation of value_to_string, so
1716 that it properly handles alpha values.
1718 * oneway.q Changed instances where labels were being probed manually,
1719 to use the canonical {var,value}_to_string functions
1721 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1723 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1724 plots. Changed the API of the cartesian plot to be a much lower level
1727 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1729 * examine.q Added some of the parametric calculations
1731 * factor_stats.[ch] Created
1733 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1735 * examine.q Changed the definition of factors to be a composite, and
1736 dealt with the consequences.
1738 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1740 * examine.q Fixed problem where examine wasn't dealing properly with
1743 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1745 * oneway.q Fixed problem where oneway wasn't dealing properly with
1748 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1750 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1751 command which had settings didn't get the appropriate code
1754 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1755 to convert variables/values to strings.
1757 * examine.q Added framework for the EXAMINE command.
1759 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1761 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1762 subcommand types. Changed frequencies.q to use it rather then the
1763 custom parser. Dealt with the consequences. Added a test for NTILES
1764 subcommand of frequencies.
1766 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1768 * oneway.q Fixed up the behaviour when given missing values
1770 * levene.c oneway.q Fixed a buglet with the levene statistic and
1771 incorporated the levene test into the oneway command.
1773 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1774 global scope, since they're only relevant to T-TEST
1776 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1778 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1780 Made the t-test more consistent
1781 with the way it handles groups. That is, it now uses a hash instead
1782 of an array of 2. Also, made the levene.c file independent of the
1783 implementation of the t-test. So now levene should be fine for both
1786 * Added an oneway.q file for one way anova
1788 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1790 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1793 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1797 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1798 (data_list_trns_free) Free dls->delims.
1800 * t-test.q: (tts_custom_pairs) Free vars.
1801 (ssbox_one_sample_init) Fix tab_vline() argument.
1802 (ssbox_independent_samples_init) Ditto.
1803 (trbox_paired_init) Ditto.
1804 (trbox_one_sample_init) Ditto.
1806 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1808 Generalize casefiles to the extent that we can use them for
1809 sorting and other kinds of data transformations. Change cases to
1810 be copy-on-write to improve memory efficiency in common cases.
1811 Every access to a member of a `struct ccase' was changed to be a
1812 call to a case_*() function, especially case_data(), case_num(),
1813 case_str(), or case_data_rw(). Many instances of a local variable
1814 named "case_num" were changed to "case_idx" as a consequence.
1815 Many `struct ccase *' were changed to actual `struct ccase'
1816 because of copying semantics of cases. In several places there
1817 was a choice between updating debug code to work with the new ADTs
1818 or just deleting it because it was useless; I chose to delete it.
1820 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1826 * aggregate.c: (struct agr_proc) Change type of `sort' to
1827 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1828 Rename `vars' to `agr_vars', all references updated. Change
1829 `agr_case' to type `struct ccase'.
1830 (cmd_aggregate) Deal with new members. Use case_create(),
1831 sort_active_file_in_place(), sort_active_file_to_casefile().
1832 (agr_destroy) Deal with new members.
1833 (aggregate_single_case) Ditto.
1834 (dump_aggregate_info) Ditto.
1835 (initialize_aggregate_info) Ditto.
1836 (agr_to_active_file) Ditto.
1837 (presorted_agr_to_sysfile) Ditto.
1838 (sort_agr_to_sysfile) Removed.
1840 * alloc.c: (out_of_memory) Make non-static.
1842 * alloc.h: Prototype out_of_memory().
1844 * casefile.c: Switched from a linked list in-memory representation
1845 to a two-level array-style representation. The linked list was
1846 appropriate when we could stick a header onto cases, but that's no
1847 longer the case. Also, the two-level array will allow for random
1848 in-memory access in case that's ever wanted. Also added the
1849 concept of a `destructive casereader', one that destroys cases in
1850 the underlying casefile as they are read out.
1851 (macro CASES_PER_BLOCK) New macro.
1852 (struct casefile) New members `value_cnt', `case_list_size',
1853 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1855 (struct casereader) Removed `cur'. Added `destructive', `c'.
1856 (global var casefiles) Made static.
1857 (static var case_bytes) New var.
1858 (casefile_create) Takes a value count, not a case size in bytes,
1859 to conform to the case interface. All callers updated. Deal with
1860 new and removed members.
1861 (casefile_destroy) Deal with new and removed members.
1862 (casefile_sleep) New function.
1863 (casefile_get_case_size) Removed.
1864 (casefile_get_value_cnt) New function.
1865 (casefile_append) Rewritten to deal with new and removed members.
1866 (casefile_append_xfer) New function.
1867 (write_case_to_disk) Use case_serialize().
1868 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1869 Couldn't figure out why.
1870 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1871 deal with new and removed members.
1873 (merge_sort) Removed.
1874 (casefile_sort) Removed.
1875 (casefile_get_reader) Deal with new and removed members.
1876 (casefile_get_destructive_reader) New function.
1877 (reader_open_file) Make code more readable. Create case for
1879 (casereader_get_casefile) New function.
1880 (casereader_read) Deal with new and removed members. Now returns
1881 a copy of the case, so that the caller is responsible for
1882 destroying the returned case.
1883 (casereader_read_xfer) New function.
1884 (casereader_destroy) Destroy reader's case.
1885 (test_casefile) Second arg is now a value count, all callers
1886 updated. Now tests destructive readers too.
1887 (get_random_case) Deal with new case ADT.
1888 (write_random_case) Ditto.
1889 (read_and_verify_random_case) Ditto.
1891 * crosstabs.q: Remove debug code.
1893 * descript.q: (calc_descriptives) Deal with new case, casefile
1896 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1898 * do-if.c: Remove unneeded header inclusion.
1900 * expr-prs.c: Remove debug code.
1902 * exprP.h: Remove debug code.
1904 * flip.c: (flip_file) Use fseeko() if available.
1906 * formats.c: Remove debug code.
1908 * get.c: Remove debug code.
1909 (struct mtf_file) Change `input' from `union value *' to `struct
1910 ccase', all references updated.
1912 * levene.c: (levene) Deal with new case, casefile ADTs.
1914 * list.q: Remove debug code.
1916 * loop.c: Remove debug code.
1918 * matrix-data.c: Remove debug code.
1920 * means.q: Remove debug code.
1922 * mis-val.c: Remove debug code.
1924 * pfm-read.c: Remove debug code.
1925 (pfm_read_code) Change second arg from `union value *' to `struct
1926 ccase *', all references updated.
1928 * recode.c: (string_to_long) Make first arg const.
1929 (convert_to_double) Ditto.
1931 * repeat.c: Remove debug code.
1933 * sample.c: Remove debug code.
1935 * sfm-read.c: Remove debug code.
1936 (sfm_read_case) Change second arg from `union value *' to `struct
1939 * sort.c: Redone in terms of casefiles.
1940 (enum sort_direction) Moved here from sort.h.
1941 (struct sort_criterion) New structure.
1942 (struct sort_criteria) New structure.
1943 (cmd_sort_cases) Rewritten.
1944 (prepare_to_sort_active_file) New function.
1945 (sort_active_file_in_place) New function.
1946 (sort_active_file_to_casefile) New function.
1947 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1948 changed, all callers updated.
1949 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1950 rewritten & interface changed, all callers updated.
1951 (sort_cases) Renamed sort_execute(), rewritten & interface
1952 changed, all callers updated.
1953 (struct internal_sort) Removed.
1954 (do_internal_sort) Rewritten, interface changed.
1955 (destroy_internal_sort) Removed.
1956 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1957 (struct initial_run) Removed; an initial run is now just a
1959 (compare_initial_runs) Rewritten.
1960 (struct external_sort) Changed almost completely.
1961 (do_external_sort) Rewritten, interface changed.
1962 (destroy_external_sort) Rewritten.
1963 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1964 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1965 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1966 (init_external_sort) Removed.
1967 (simulate_error) Removed.
1968 (rmdir_temp_dir) Removed.
1969 (get_temp_file_name) Removed.
1970 (open_temp_file) Removed.
1971 (close_temp_file) Removed.
1972 (remove_temp_file) Removed.
1973 (write_temp_file) Removed.
1974 (read_temp_file) Removed.
1975 (struct record_run) Change `record' from `struct case_lit *' to
1977 (struct initial_run_state) Remove `idx_to_fv', `free_list',
1978 `file_idx', `output_file'. Add `run', casefile'. Change
1979 `last_output' from `struct case_list *' to `struct ccase'.
1980 (write_initial_runs) Change interface, rewrite.
1981 (sort_sink_write) Renamed process_case(), changed interfaced,
1983 (destroy_initial_run_state) Rewritten.
1984 (allocate_cases) Rewritten.
1985 (compare_record) Interface changed, rewritten.
1986 (start_run) Rewritten.
1987 (end_run) Rewritten.
1988 (output_record) Rewritten.
1989 (grab_case) Removed.
1990 (release_case) Removed.
1991 (struct merge_case) Change `cases' from double pointer to single
1993 (merge) Deal with new case and casefile ADTs.
1994 (struct run) Removed.
1995 (merge_once) Rewritten, interface changed.
1996 (fill_run_buffer) Removed.
1997 (sort_sink_make_source) Removed.
1998 (sort_sink_class) Removed.
1999 (struct sort_source_aux) Removed.
2000 (sort_source_read_helper) Removed.
2001 (sort_source_read) Removed.
2002 (read_sort_output) Removed.
2003 (read_internal_sort_output) Removed.
2004 (read_external_sort_output) Removed.
2005 (sort_source_destroy) Removed.
2006 (sort_source_class) Removed.
2008 * sort.h: (struct sort_cases_pgm) Removed.
2009 (enum sort_direction) Moved to sort.c.
2011 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2013 * tab.c: Remove debug code.
2015 * var-labs.c: Remove debug code.
2017 * var.h: (struct ccase) Removed.
2018 (struct case_list) Removed.
2020 * vars-atr.c: (discard_variables) Use free_case_source().
2022 * vars-prs.c: (parse_vs_variable) Make arg const.
2023 (parse_dict_variable) Ditto.
2024 (parse_variables) Make struct dictionary * arg const.
2025 (parse_var_set_vars) Make struct var_set * arg const.
2026 (struct var_set) Add const to some of the function pointers' args.
2027 (var_set_get_cnt) Make arg const.
2028 (var_set_get_var) Make first arg const.
2029 (var_set_lookup_var) Make first arg const.
2030 (dict_var_set_get_cnt) Make arg const.
2031 (dict_var_set_get_var) Make first arg const.
2032 (dict_var_set_lookup_var) Make first arg const.
2033 (var_set_create_from_dict) Make arg const. Add cast to aux
2035 (struct array_var_set) Add const to var member.
2036 (array_var_set_get_cnt) Make arg const.
2037 (array_var_set_get_var) Make first arg const.
2038 (array_var_set_lookup_var) Make first arg const.
2039 (var_set_create_from_array) Make first arg const. Insert cast.
2041 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2042 members from `struct ccase *' to `struct ccase'.
2043 (static var lag_queue) Change from double to single pointer.
2044 (procedure) Optimize trivial case.
2045 (internal_procedure) Deal with changed case, case_source ADTs.
2046 (create_trns_case) Changed interface, rewrote.
2047 (open_active_interface) Initialize modified lag queue.
2048 (write_case) Deal with changed case ADT.
2049 (lag_case) Deal with modified lag queue.
2050 (close_active_file) Destroy modified lag queue.
2051 Deal with changed case_source, case_sink ADTs.
2052 (destroy_storage_stream_info) Make null arg into no-op.
2053 (storage_sink_make_source) Set aux in created source.
2054 (storage_source_read) Deal with changed case, casefile ADTs.
2055 (storage_source_create) New function.
2056 (lagged_case) Rewrite.
2057 (free_case_source) New function.
2058 (free_case_sink) Rewrite.
2059 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2061 (procedure_with_splits) Deal with changed prev_case.
2062 (procedure_with_splits_callback) Ditto.
2063 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2065 (multipass_procedure_with_splits) Deal with changed prev_case.
2066 (multipass_split_callback) Ditto.
2069 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2071 The workspace idea didn't work out.
2073 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2075 * workspace.c: Removed.
2077 * workspace.h: Removed.
2079 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2081 Fully implement arbitrary delimiters on DATA LIST, extending the
2082 half implementation that was already there.
2084 * data-list.c: (struct data_list_pgm) Remove `delim', add
2085 `delims', `delim_cnt'.
2086 (cmd_data_list) Initialize new members. Parse delimiters and
2087 clean up code a bit.
2088 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2089 handling of leading commas.
2090 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2092 (read_from_data_list_free) Adapt to new DFM interfaces.
2093 (read_from_data_list_list) Ditto.
2094 (repeating_data_trns_proc) Ditto.
2096 * dfm.c: Split up reader and writer into separate code, because
2097 they do different things. Use struct string instead of explicit
2098 allocation code, for clarity.
2099 (enum dfm_reader_flags) New enum.
2100 (struct dfm_fhuser_ext) Removed.
2101 (struct dfm_reader_ext) New.
2102 (get_reader) New function, used by just about all the reader
2104 (dfm_close) Removed.
2105 (close_reader) New function.
2106 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2107 (dfm_open_for_writing) Ditto.
2108 (macro force_line_buffer_expansion) Removed.
2109 (count_tabs) Removed.
2110 (tabs_to_spaces) Removed.
2111 (read_record) Deal with new dfm_reader_ext. Use struct string
2112 functions. Don't convert tabs to spaces.
2113 (dfm_eof) New function.
2114 (dfm_get_record) Changed interface, rewrote.
2115 (dfm_expand_tabs) New function.
2116 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2117 dfm_reader_ext, rewritten.
2118 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2119 dfm_reader_ext, rewritten.
2120 (dfm_set_record) Removed in favor of dfm_forward_columns().
2121 (dfm_forward_columns) New function.
2122 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2123 dfm_reader_ext, rewritten.
2124 (static var dfm_r_class) Use close_reader for the destructor.
2125 (struct dfm_writer_ext) New.
2126 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2127 bounce buffer now instead of local allocation.
2128 (close_writer) New function.
2129 (static var dfm_writer_ext) Use close_writer for destructor.
2130 (cmd_begin_data) Adapt to new dfm_reader_ext.
2132 * file-handle.q: Add support for per-file tab width.
2133 (struct private_file_handle) Add tab_width member.
2134 (q2c specifications) Add tabwidth subcommand.
2135 (cmd_file_handle) Put parsed tab width into private_file_handle.
2136 (create_file_handle) Set default tab width.
2137 (handle_get_tab_width) New function.
2139 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2141 * inpt-pgm.c: (reread_trns_proc) Ditto.
2143 * matrix-data.c: (context) Ditto.
2144 (another_token) Ditto.
2148 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2150 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2152 (casereader_destroy) Don't close file descriptor -1.
2154 * recode.c: (cmd_recode) Fix memory leak.
2156 * set.q: (q2c specifications) Fix typo in user message.
2158 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2159 undefined behavior for overlapping arguments.
2161 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2163 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2164 don't call it when we're running under valgrind.
2165 (call_posix_fadvise) New function.
2166 (casefile_to_disk) Use call_posix_fadvise().
2167 (reader_open_file) Ditto.
2169 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2171 Update our string ADTs, struct string and struct len_string. Get
2172 rid of pool support, which was largely unused. Rename lots of
2173 functions to have more obvious or consistent names.
2175 * ascii.c: Get rid of ascii_pool. It was only used for string
2177 (ascii_open_global) Don't create ascii_pool.
2178 (ascii_close_driver) Don't destroy ascii_pool.
2179 (ascii_postopen_driver) Don't use pool.
2180 (ascii_close_driver) Destroy strings manually.
2182 * str.c: (ds_create) Remove pool argument, all references updated.
2184 (ds_replace) Remove pool support, make more efficient when we
2185 don't need to reallocate.
2186 (ds_destroy) Remove pool support.
2187 (ds_rpad) New function.
2188 (ds_size) Renamed ds_capacity(), all references updated.
2189 (ds_value) Renamed ds_c_str(), all references updated.
2190 (ds_concat) Renamed ds_puts(), all references updated.
2191 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2192 (ds_putchar) Renamed ds_putc(), all references updated.
2193 (ds_getline) Renamed ds_gets(), all references updated.
2194 (ls_create) Remove pool argument, all references updated.
2195 (ls_create_buffer) Ditto.
2196 (ls_destroy) Removed pool support.
2197 (ls_value) Renamed ls_c_str(), all references updated.
2199 * str.h: (ls_length) [__GNUC__] Add inline version.
2200 (ls_c_str) [__GNUC__] Add inline version.
2201 (ls_end) [__GNUC__] Add inline version.
2202 (struct string) Remove pool member. Rename `size' to `capacity',
2203 all references updated.
2205 * tab.c: (text_format) Instead of using pool argument to
2206 ls_create_buffer(), call pool_register() on allocated data.
2208 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2210 We're abusing the current ASCII driver by telling it to allocate a
2211 9999-line, 9999-character page in the tests. This causes some
2212 systems to curl up and die because it allocates 20 MB of
2213 contiguous RAM. This change alleviates at least part of the
2214 problem. It is mostly a stop-gap until the new output system is
2217 * ascii.c: (struct line) New structure.
2218 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2219 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2220 (ascii_preopen_driver) Initialize new members, not old ones.
2221 (ascii_close_driver) Destroy new members, not old ones.
2222 (ascii_open_page) Allocate new members, not old ones.
2223 (expand_line) Allocate room in line.
2224 (draw_line) Use new members.
2225 (ascii_line_horz) Ditto.
2226 (ascii_line_vert) Ditto.
2227 (ascii_line_intersection) Ditto.
2229 (output_lines) Ditto.
2230 (ascii_close_page) Ditto.
2232 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2234 * matrix.c: Dead code. Removed.
2236 * matrix.h: Dead code. Removed.
2238 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2240 Contrary to what I'd always understood, there is an efficient
2241 algorithm for deletion from a hash table populated via linear
2242 probing. This change implements it.
2244 * hash.c: (hsh_rehash) Probe in increasing order.
2246 (locate_matching_entry) Ditto.
2247 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2249 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2251 * moments.c (calc_moments): Adjust calculation of kurtosis to
2252 avoid subtracting huge numbers from huge numbers, on Michael
2255 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2257 Rework moments routines for improved numerical stability based on
2258 Michael Kiefte's advice. Any bugs or remaining numerical problems
2259 are still mine though.
2261 There is now a struct moments1 for use with one-pass moments. It
2262 uses a provisional means algorithm as an attempt to improve
2263 accuracy of higher moments. The older struct moments now only
2264 handles two-pass moments.
2266 * aggregate.c: Use moments1 instead moments.
2268 * descript.c: Revert previous change, which is no longer needed
2269 due to the moments revision.
2271 * moments.c: (calc_moments) New function for calculating variance,
2273 (moments_pass_one) Only accumulate weights bigger than zero.
2274 (moments_calculate) Allow calculating the mean on pass one, others
2275 require pass two. Implement in terms of calc_moments().
2276 (struct moments1) New structure.
2277 (init_moments1) New function.
2278 (moments1_clear) Ditto.
2279 (moments1_create) Ditto.
2280 (moments1_add) Ditto.
2281 (moments1_calculate) Ditto.
2282 (moments1_destroy) Ditto.
2283 (cmd_debug_moments) Deal with `struct moments' or `struct
2284 moments1' as requested by user.
2286 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2288 * Makefile.am (pspp_SOURCES): Remove debug.c.
2290 * debug.c: Removed. It was empty anyway.
2292 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2294 * descript.c (calc_descriptives): Fix assert failure when only
2295 MOMENT_MEAN is needed.
2297 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2301 fixed problem with parsing in match_statistic() causing
2302 "DESCRIPTIVE STAT=MEAN." to barf.
2304 "MEAN" is now default if "SORT" given without specification.
2306 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2307 generally less forgiving of syntax errors: better to have it do
2308 nothing and type it in again then to not know what it actually did
2311 z-score transformation now checks score for user-missing values
2312 and checks std_dev for SYSMIS.
2314 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2316 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2317 Changed dict_get_case_weight() to accept an additional int * flag
2318 to complain about system-missing, user-missing, zero, or negative
2319 weights and updated existing functions to pass int * to
2320 dict_get_case_weight().
2322 2004-04-05 jmd <jmd@gnu.org>
2324 * main.c: Fixed configuration problems with gsl
2326 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2328 2004-04-03 blp <blp@gnu.org>
2330 * lexer.c, ChangeLog:
2331 Fix infinite loop on comment at end of file, add test.
2333 2004-04-03 jmd <jmd@gnu.org>
2335 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2336 Fixed the calculation of percentiles and added --syntax and --algorithm options
2338 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2340 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2343 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2345 * frequencies.q: Fixed the calculation of percentiles
2347 * Makefile.am: Added the --ansi flag and dealt with the
2348 consequences. Added some entries to PSPP_sources so that
2349 make distcheck would pass
2351 * cmdline.c: Added the --syntax and --algorithm options
2353 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2355 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2357 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2358 use the new multipass_split_... mechanism.
2360 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2362 * frequencies.q: (calc_stats) Use moments data structure and
2363 calc_seskew(), calc_sekurt() functions.
2365 * set.q main.c settings.h Added support for --syntax and --algorithm
2368 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2370 * vfm.c: Had to get last call to multipass_split_output() inside
2371 open_active_file()/close_active_file() pairing, so introduce new
2373 (internal_procedure) Move procedure() code here, except for calls
2374 to open_active_file() and close_active_file().
2375 (procedure) Wrap open_active_file() and close_active_file() around
2376 internal_procedure().
2377 (multipass_procedure_with_splits) Wrap open_active_file() and
2378 close_active_file() around internal_procedure().
2380 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2382 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2384 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2386 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2388 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2390 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2392 * algorithm.c: By default turn off some of the more expensive
2394 (expensive_assert) New macro which expands to assert if
2395 EXTRA_CHECKS is defined, to nothing otherwise.
2396 (unique) Use expensive_assert().
2397 (binary_search) Ditto.
2403 * command.c: (conflicting_3char_prefixes) Words that are the same
2404 don't cause conflicts when they are abbreviated to the first three
2407 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2408 nonterm_node's n earlier.
2409 (generic_str_func) Ditto.
2411 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2413 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2414 test multipass support, take advantage of new moments
2415 calculation, and to not be such crappy code. Get rid of q2c
2416 processing for DESCRIPTIVES.
2418 * vfm.c: (struct multipass_split_aux_data) New structure.
2419 (multipass_procedure_with_splits) New function.
2420 (multipass_split_callback) New function.
2421 (multipass_split_output) New function.
2422 * descript.q: Removed.
2424 * descript.c: New file.
2426 * var.h: Removed descriptives enums.
2427 (struct descriptives_proc) Removed.
2428 (struct variable) Removed p.dsc.
2430 * Makefile.am: (q_sources_c) Remove descript.c.
2431 (q_sources_q) Removed descript.q.
2433 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2435 New manager for keeping track of used workspace.
2437 * workspace.c: New file.
2439 * workspace.h: New file.
2441 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2443 * sort.c: (do_internal_sort) Use workspace_malloc().
2444 (destroy_internal_sort) Use workspace_free().
2446 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2448 New `struct casefile' for managing sets of cases.
2450 * casefile.c: New file.
2452 * casefile.h: New file.
2454 * command.def: Add DEBUG CASEFILE command.
2456 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2458 * sort.c: (sort_cases) Move logic for sending storage file to disk
2459 into do_external_sort().
2460 (struct internal_sort) Use an array of ccase pointers instead of a
2462 (do_internal_sort) Rewrite to handle casefiles.
2463 (compare_case_list) Removed.
2464 (compare_cases) New function.
2465 (compare_case_dblptrs) New function.
2466 (read_internal_sort_output) Deal with new struct internal_sort.
2468 * vfm.c: (static var workspace_overflow) Removed.
2469 (struct storage_stream_info) Removed all the members. Added
2470 struct casefile * member.
2471 (storage_sink_open) Use casefile.
2472 (open_storage_file) Removed.
2473 (write_storage_file) Removed.
2474 (storage_to_disk) Removed.
2475 (destroy_storage_stream_info) Use casefile.
2476 (storage_sink_write) Use casefile.
2477 (storage_sink_make_source) Use casefile.
2478 (storage_source_count) Use casefile.
2479 (storage_source_read) Use casefile.
2480 (storage_source_on_disk) Removed.
2481 (storage_source_get_cases) Removed.
2482 (storage_source_set_cases) Removed.
2483 (storage_source_get_casefile) New function.
2485 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2487 New `struct moments' for calculating moments.
2493 * moments.c: New file.
2495 * moments.h: New file.
2497 * command.def: Add DEBUG MOMENTS command.
2499 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2502 * aggregate.c: Modify AGGREGATE to use the new moments
2503 calculation, even if not in such a great way.
2504 (struct agr_var) Add `moments' member.
2505 (parse_aggregate_functions) Set `moments' member to null.
2506 (agr_destroy) Destroy `moments' member.
2507 (accumulate_aggregate_info) Use `moments' for standard deviation.
2508 (dump_aggregate_info) Ditto.
2509 (initialize_aggregate_info) Create or clear `moments'.
2511 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2512 cube(), pow4() that were in stats.h. All references updated.
2514 * crosstabs.q: stats.h had chi-square significance functions. Use
2516 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2518 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2519 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2521 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2523 * dictionary.c: (dict_compact_values) Compacted values need to
2526 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2528 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2529 `/' at start. Check return value of parse_variables() for error
2532 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2534 Revamp expressions: make the code a little nicer, and fix bugs
2537 * expr-evl.c: (expr_evaluate) Make expression argument const.
2538 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2539 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2540 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2541 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2542 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2543 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2544 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2545 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2546 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2547 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2548 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2549 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2550 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2552 * expr-opt.c: (optimize_expression) Rewrite.
2557 (macro s0l) Removed.
2559 (macro s1l) Removed.
2561 (macro s2l) Removed.
2564 (eq_num_con) New function.
2565 (optimize_tree) New function.
2566 (macro rnc) Removed.
2567 (macro frnc) Removed.
2568 (str_search) Add const to string params.
2569 (str_rsearch) Ditto.
2570 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2571 str[], str_len[] locals to substitute for most of removed macros.
2572 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2573 Removed support for missing values because we're never called with
2574 missing values. Use set_number() or set_number_errno() instead of
2575 rnc or frnc. Removed any stuff that caused trouble in testing.
2576 We can re-add it later if it really slows anything. Fix some
2578 (evaluate_tree_with_missing) Not yet supported. To be added later
2580 (repl_num_con) Removed.
2581 (collapse_node) New function.
2582 (force_repl_num_con) Removed.
2583 (set_number) New function.
2584 (set_number_errno) New function.
2585 (repl_str_con) Removed.
2586 (set_string) New function.
2587 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2589 (dump_node) No special case for OP_AND, OP_OR.
2591 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2592 (expr_get_type) New function.
2593 (type_check) Rewrite.
2594 (type_coercion) New function.
2595 (struct operator) New structure.
2596 (match_operator New function.
2597 (parse_binary_operators) New function.
2598 (parse_inverting_unary_operator) New function.
2599 (parse_or) Rewritten.
2600 (parse_and) Rewritten.
2601 (parse_not) Rewritten.
2602 (parse_rel) Rewritten.
2603 (parse_add) Rewritten.
2604 (parse_mul) Rewritten.
2605 (parse_neg) Rewritten.
2606 (parse_exp) Rewritten.
2607 (parse_sysvar) Add $TRUE, $FALSE system variables.
2608 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2609 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2611 (struct function) Remove desc, change `func' prototype.
2612 (unary_func) Remove special cases.
2613 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2614 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2615 (VALUE_func) Use allocate_var_node().
2616 (nary_num_func) Allow MIN and MAX for strings.
2617 Use allocate_var_node(). Properly clean up.
2619 (generic_str_func) Use local table instead of removed `desc'
2620 member. Mostly rewrite.
2621 (get_num_args) Revise error message.
2622 (parse_function) Return EXPR_ERROR, not 0 on error.
2624 (macro varies) Removed.
2625 (ops[]) Use expr.def.
2626 (free_node) Do nothing if node is null.
2627 (allocate_num_con) New function.
2628 (allocate_str_con) New function.
2629 (allocate_var_node) New function.
2630 (allocate_binary_nonterminal) New function.
2631 (append_nonterminal_arg) Removed.
2632 (static var func_tab[]) Revised.
2633 (expr_debug_print_postfix) Make parameter const.
2634 Use printf() instead of debug_printf().
2636 * expr.def: New file.
2638 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2639 use named enum instead of unnamed, all references updated. Add
2640 EXPR_ANY, EXPR_NO_OPTIMIZE.
2642 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2643 instead of defining OP_* directly.
2644 (macro IS_TERMINAL) New macro.
2645 (macro IS_NONTERMINAL) New macro.
2646 (enum OP_NO_FLAGS) New.
2648 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2650 * error.c: (err_assert_fail) msg variable needs to be non-const.
2652 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2654 * debug.c: (cmd_debug_evaluate) Rewrite.
2656 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2658 Fix some CROSSTABS bit rot stupidity.
2660 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2661 (internal_cmd_crosstabs) Initializes cells[] correctly.
2662 (float_M_suffix) Rename format_cell_entry(), change prototype,
2664 (display_crosstabulation) Fix cell formatting.
2666 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2668 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2669 to call lex_discard_line() to do that.
2671 * command.c: (run_command) Call lex_discard_line() after
2674 * lexer.c: (lex_entire_end) Change behavior.
2675 (lex_rest_of_line) Change behavior. Return const char *.
2676 (lex_discard_line) Don't clear getl_buf, don't emit message.
2678 * main.c: (handle_error) Emit message here.
2680 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2681 instead of lex_entire_line().
2683 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2685 * title.c: (get_title) Call lex_discard_line() after
2687 (cmd_file_label) Ditto.
2688 (cmd_document) Deal with const char * return value.
2690 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2692 Removed REMARK command.
2694 * command.c: (extract_prefix) Removed.
2695 (output_line) Removed.
2696 (cmd_remark) Removed.
2698 * command.def: Remove REMARK.
2700 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2702 Added abort() after lots of assert(0) invocations to avoid some
2703 compiler warnings. We really need a NOT_REACHED macro.
2705 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2707 * sort.c: Added missing call to temp_file_close. Changed error
2708 messages to warnings.
2710 * set.q: Improved setting of set_view{length,width} to be more tolerant
2713 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2715 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2716 used with incorrect syntax.
2718 * error.c, error.h et al: Overridden definition of assert for a
2721 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2722 subcommand was given when it ought to have been.
2724 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2726 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2730 (tab_joint_text) Ditto.
2732 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2734 * levene.c: Add #include.
2736 * set.q: (set_viewport) Add `int' argument to make its prototype
2737 correct for signal().
2739 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2741 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2744 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2746 Changed DFM from open-at-first-access to explicit-open. Before,
2747 calling dfm_get_record() or dfm_put_record() would automatically
2748 open the file. Now, you have to call dfm_open_for_reading() or
2749 dfm_open_for_writing() explicitly. This makes it possible to
2750 check permissions, file existence, etc. earlier.
2752 Also made struct file_handle more opaque, and clean up in general.
2754 * data-list.c: (cmd_data_list) Open handle for reading.
2756 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2758 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2759 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2760 (open_inline_file) Removed.
2761 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2762 it. Deal with line_number in extension record instead of file
2764 (dfm_get_record) Rewrote.
2765 (dfm_put_record) Rewrote.
2766 (dfm_push) Assert file is open and one of ours. Deal with
2767 line_number in extension record instead of file handle.
2768 (dfm_pop) Assert file is open and one of ours. Deal with
2769 line_number in extension record instead of file handle.
2770 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2773 * file-handle.h: (enum constants RH_RF_*) Removed.
2774 (enum constants FH_MD_*) Removed.
2775 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2776 `recform', `lrecl', `mode' members. Public references to
2777 `recform' changed to use handle_get_mode(), references to `lrecl'
2778 changed to use handle_get_record_width(). Added `private' member.
2779 (enum file_handle_mode) New.
2781 * file-handle.q: (struct private_file_handle) New structure.
2782 (struct file_handle_list) New structure.
2783 (static var files) New.
2784 (static var file_handles) Removed.
2785 (init_file_handle) Removed.
2786 (create_file_handle) Removed.
2787 (get_handle_with_name) New function.
2788 (get_handle_for_filename) New function.
2789 (cmd_file_handle) Rewritten.
2790 (hash_file_handle) Removed.
2791 (cmp_file_handle) Removed.
2792 (fh_init_files) Rewritten.
2793 (fh_parse_file_handle) Rewritten. Allows identifiers as
2795 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2797 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2798 references updated. Rewritten.
2799 (fh_record_width) Renamed handle_get_record_width(), all
2800 references updated. Rewritten.
2801 (handle_get_mode) New function.
2803 * file-type.c: (cmd_file_type) Open handle for reading.
2805 * filename.c: [unix] (struct file_identity) New structure.
2806 [unix] (fn_get_identity) New function.
2807 [unix] (fn_free_identity) New function.
2808 [unix] (fn_compare_file_identities) New function.
2809 [!unix] (struct file_identity) New structure.
2810 [!unix] (fn_get_identity) New function.
2811 [!unix] (fn_free_identity) New function.
2812 [!unix] (fn_compare_file_identities) New function.
2814 * lexer.c: (static var put) Renamed put_token, all references
2816 (static var put_tokstr) New.
2817 (static var put_tokval) New.
2818 (lex_init) Initialize put_tokstr().
2819 (restore_token) New function.
2820 (save_token) New function.
2821 (lex_get) Use restore_token().
2822 (lex_put_back) Use save_token().
2823 (lex_put_back_id) New function.
2824 (lex_put_forward) Removed.
2825 (lex_preprocess_line) Set put_token instead of using
2827 (lex_negative_to_dash) Use save_token(), set put_token directly.
2828 (dump_token) Use stderr instead of stdout.
2830 * main.c: (main) Remove call to cmd_init().
2832 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2834 * pfm-read.c: Use handle_get_filename() instead of trying to use
2835 h->fn directly, all over.
2837 * pfm-write.c: Ditto.
2839 * print.c: (internal_cmd_print) Open handle for writing.
2840 (dump_table) Use handle_get_filename().
2841 (print_trns_proc) Use handle_get_mode().
2842 (cmd_print_space) Use fh_parse_file_handle().
2843 Open handle for writing.
2844 [0] (debug_print) Removed.
2846 * sfm-read.c: Use handle_get_filename() instead of trying to use
2847 h->fn directly, all over.
2849 * sfm-write.c: Ditto.
2851 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2855 * autorecode.c: (arc_free) Free arc->src_values.
2857 * error.c: (msg) Free buf.
2859 * val-labs.c: (do_value_labels) Always free vars.
2861 * vfm.c: (close_active_file) If sink has no make_source then call
2862 its destroy function.
2864 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2866 Fixed cmd_parse() so that it always skips past a full command
2867 name. A few special commands for which this would be bad get
2868 special treatment. This lets us drop code for skipping past the
2869 end of a command name in most cmd_*() functions. It's not worth
2870 listing all the commands affected.
2872 * command.c: (struct command) Remove `cmd' member, replace by
2873 `name' member, all references updated. Remove `word', `next',
2874 `skip_entire_name' members.
2875 (macro DEFCMD) Deal with revised `struct command'.
2876 (macro UNIMPL) Ditto.
2877 (macro SPCCMD) New macro for commands whose last word shouldn't be
2879 (static array cmd_table[]) Make const, rename `commands', remove
2881 (macro COMMAND_CNT) New macro.
2882 (split_words) Removed.
2884 (FILE_TYPE_okay) Make parameter const.
2885 (cmd_parse) Improve error messages.
2886 (match_strings) New function.
2887 (next_word) New function.
2888 (enum command_match) New enum.
2889 (conflicting_3char_prefixes) New function.
2890 (conflicting_3char_prefix_command) New function.
2891 (cmd_match_words) New function.
2892 (count_matching_commands) New function.
2893 (get_command_name) New function.
2894 (free_words) New function.
2895 (unknown_command_error) New function.
2896 (figure_out_command) Renamed parse_command_name(), rewritten.
2898 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2899 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2900 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2903 * command.h: (macro SPCCMD) New.
2905 * include.c: (cmd_include_at) Removed.
2906 (cmd_include) Allow identifier to be used as filename.
2908 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2910 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2913 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2915 Start work on better test framework.
2917 * Makefile.am: (pspp_sources) Add debug.c.
2919 * debug.c: New file.
2921 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2922 cmd_debug_evaluate().
2924 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2926 * expr.h: (enum constant PXP_DUMP) Removed.
2928 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2930 * set.q: Implemented the SHOW command, and synced it to the existing
2933 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2934 changes as the window size is changed.
2936 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2937 environment variables if other methods are not available.
2939 glob.c: Removed a lot of global variables from glob.c and encapsulated
2942 random.c: Tidied up the way the random seed is set.
2944 str.c: Added a ds_vprintf function.
2946 error.c: Extended dump_message so that messages are always broken at
2949 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2951 * pfm-write.c: (bufwrite) Write out the correct element for string
2952 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2954 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2956 Get rid of static and global (!) vars in matrix-data.c.
2958 * matrix-data.c: (static var nr_data) Removed.
2959 (static var nr_factor_values) Removed.
2960 (static var max_cell_index) Removed.
2961 (static var split_values) Removed.
2962 (struct nr_aux_data) New structure.
2963 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2964 place of static vars, pass to create_case_source() and procedure()
2966 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2967 struct matrix_data_pgm *.
2968 (nr_read_splits) Ditto.
2969 (nr_read_factors) Ditto.
2970 (nr_output_data) Ditto.
2971 (static var wr_content) Removed.
2972 (global var wr_data) Removed.
2973 (global var wr_current) Removed.
2974 (struct wr_aux_data) New structure.
2975 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2976 place of static vars, pass to create_case_source() and procedure()
2978 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
2979 instead of matrix_data_pgm *.
2980 (wr_read_splits) Ditto.
2981 (wr_output_data) Ditto.
2982 (wr_read_rowtype) Ditto.
2983 (wr_read_factors) Ditto.
2984 (wr_read_indeps) Ditto.
2986 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
2988 Get rid of static vars in autorecode.c.
2990 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
2991 `n_arc' to `spec_cnt'. All references updated.
2992 (static var v_src) Removed.
2993 (static var v_dest) Removed.
2994 (static var h_trns) Removed.
2995 (static var nv_src) Removed.
2996 (static var descend) Removed.
2997 (static var print) Removed.
2998 (enum direction) New enum.
2999 (struct autorecode_pgm) New structure.
3000 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3001 Move n_dest local var into struct autorecode_pgm for ease of
3002 clean-up. Use arc_free().
3003 (arc_free) New function.
3004 (recode) Modify to take struct autorecode_pgm * parameter instead
3005 of using statics. Let the caller clean up.
3006 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3007 instead of statics. Rearrange code a little.
3009 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3011 Get rid of static, global vars in recode.c. Remove debug code.
3013 * recode.c: (static var head) Removed.
3014 (global var v) Removed.
3015 (global var nv) Removed.
3016 (cmd_recode) New local variables head, v, nv. Initialize and free
3017 v. Don't call debug_print().
3018 [DEBUGGING] (dump_dest) Removed.
3019 [DEBUGGING] (debug_print) Removed.
3021 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3023 Get rid of static vars in expr-opt.c.
3025 * expr-opt.c: (static var e) Removed.
3026 (static var nop) Removed.
3027 (static var mop) Removed.
3028 (static var ndbl) Removed.
3029 (static var mdbl) Removed.
3030 (static var nstr) Removed.
3031 (static var mstr) Removed.
3032 (static var nvars) Removed.
3033 (static var mvars) Removed.
3034 (struct expr_dump_state) New structure.
3035 (dump_expression) Use new struct expr_dump_state instead of static
3036 vars and pass to functions we call.
3037 (dump_node) Use struct expr_dump_state * parameter.
3039 (emit_num_con) Ditto.
3040 (emit_str_con) Ditto.
3043 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3045 Get rid of static var in COUNT.
3047 * count.c: (static var head) Move into cmd_count().
3048 (cmd_count) [DEBUGGING] Don't call debug_print.
3049 [DEBUGGING] (debug_print) Removed.
3051 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3053 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3055 * val-labs.c: (static var v) Removed.
3056 (static var nv) Removed.
3057 [DEBUGGING] (debug_print) Removed.
3058 (verify_val_labs) Add struct variable **, int parameters.
3059 (get_label) Ditto. Improve error messages, streamline.
3060 (erase_labels) New function for erasing value labels, taking over
3061 part of verify_val_labs()'s function.
3064 (cmd_value_labels) No need to call init() or done() anymore.
3065 (cmd_add_value_labels) Ditto.
3066 (do_value_labels) Add vars, var_cnt local variables. Clean up
3067 after them internally. Call erase_labels() if we should. Don't
3070 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3072 Get rid of static vars in MATCH FILES.
3074 * get.c: (static var mtf_head) Removed.
3075 (static var mtf_tail) Removed.
3076 (static var mtf_by) Removed.
3077 (static var mtf_n_by) Removed.
3078 (static var mtf_master) Removed.
3079 (static var mtf_seq_num) Removed.
3080 (static var mtf_seq_nums) Removed.
3081 (static var mtf_sink) Removed.
3082 (static var mtf_case) Removed.
3083 (struct mtf_proc) New structure.
3084 (cmd_match_files) Use struct mtf_proc instead of static vars.
3085 (mtf_processing_finish) Ditto.
3087 (mtf_delete_file_in_place) Ditto.
3088 (mtf_read_nonactive_records) Ditto.
3089 (mtf_compare_BY_values) Ditto.
3090 (mtf_processing) Ditto.
3091 (mtf_merge_dictionary) Ditto.
3093 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3095 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3097 * dictionary.c: (dict_rename_var) Add assertion.
3098 (dict_contains_var) Check by index instead of name.
3100 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3102 Get rid of compaction_necessary, compaction_nval, compaction_case.
3103 Redo VFM interface. Replace disk_sink and memory_sink by
3104 storage_sink, disk_source and memory_source by storage_source.
3106 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3110 (struct write_case_data) Remove `begin_func', `end_func',
3111 `func_aux' members. Add `aux', `trns_case', `sink_case',
3112 `cases_written', `cases_analyzed' members.
3113 (global var compaction_necessary) Make static.
3114 (global var compaction_nval) Removed.
3115 (global var compaction_case) Removed.
3116 (static var case_count) Removed.
3117 (struct procedure_aux_data) Removed.
3118 (struct split_aux_data) Removed.
3119 (procedure) Remove begin_func, end_func parameters. Rewrite.
3120 (static var not_canceled) Removed.
3121 (process_active_file) Removed.
3122 (process_active_file_write_case) Removed.
3123 (process_active_file_output_case) Removed.
3124 (prepare_for_writing) Moved into open_active_file().
3125 (arrange_compaction) Ditto.
3127 (open_active_file) Rewrote.
3128 (write_case) New function.
3129 [DEBUGGING] (index_to_varname) Removed.
3130 (execute_transformations) New function.
3131 (exclude_this_case) Renamed filter_case(), changed interface.
3132 (clear_case) Added struct ccase * parameter to interface.
3133 (close_active_file) Added struct write_case_data * parameter,
3135 (disk_sink_create) Removed.
3136 (disk_sink_destroy) Removed.
3137 (disk_sink_make_source) Removed.
3138 (disk_sink_write) Removed.
3139 (disk_source_count) Removed.
3140 (disk_source_destroy) Removed.
3141 (disk_source_read) Removed.
3142 (global var disk_sink_class) Removed.
3143 (global var disk_source_class) Removed.
3144 (global var memory_sink_class) Removed.
3145 (global var memory_source_class) Removed.
3146 (memory_sink_create) Removed.
3147 (memory_sink_destroy) Removed.
3148 (memory_sink_make_source) Removed.
3149 (memory_sink_write) Removed.
3150 (memory_source_count) Removed.
3151 (memory_source_destroy) Removed.
3152 (memory_source_get_cases) Removed.
3153 (memory_source_read) Removed.
3154 (memory_source_set_cases) Removed.
3155 (struct disk_stream_info) Removed.
3156 (struct memory_sink_info) Removed.
3157 (struct memory_source_info) Removed.
3158 (write_active_file_to_disk) Removed.
3159 (destroy_storage_stream_info) New function.
3160 (global var null_sink_class) New var.
3161 (global var storage_sink_class) New var.
3162 (global var storage_source_class) New var.
3163 (open_storage_file) New function.
3164 (storage_sink_destroy) New function.
3165 (storage_sink_make_source) New function.
3166 (storage_sink_open) New function.
3167 (storage_sink_write) New function.
3168 (storage_source_count) New function.
3169 (storage_source_destroy) New function.
3170 (storage_source_get_cases) New function.
3171 (storage_source_on_disk) New function.
3172 (storage_source_read) New function.
3173 (storage_source_set_cases) New function.
3174 (storage_source_to_disk) New function.
3175 (storage_to_disk) New function.
3176 (struct storage_stream_info) New structure.
3177 (write_storage_file) New function.
3178 (procedure_write_case) Removed.
3179 (create_case_source) Add `struct dictionary *' parameter, all
3181 (create_case_sink) Ditto.
3182 (free_case_sink) New function.
3183 (struct split_aux_data) New structure.
3184 (procedure_with_splits) New function implementing what procedure()
3186 (SPLIT_FILE_proc_func) Removed.
3187 (procedure_with_splits_callback) New function.
3188 (equal_splits) New function.
3190 * aggregate.c: Pass around a struct instead of using statics.
3191 (static var outfile) Remove.
3192 (enum type) Give it tag `missing_treatment'.
3193 (static var missing) Remove.
3194 (static var sort) Remove.
3195 (static var agr_first) Remove.
3196 (static var agr_next) Remove.
3197 (static var case_count) Remove.
3198 (static var prev_case) Remove.
3199 (static var buf64_1xx) Remove.
3200 (static var buf_1xx) Remove.
3201 (struct agr_proc) New structure incorporating the above.
3202 (cmd_aggregate) Use new struct. Clean up error handling using
3203 agr_destroy(). Completely rewrite actual implementation of
3205 (create_sysfile) Add struct agr_proc * parameter, modify
3207 (parse_aggregate_functions) Ditto.
3208 (free_aggregate_functions) Ditto. Rename agr_destroy().
3209 (aggregate_single_case) Add struct agr_proc * parameter, modify
3211 (accumulate_aggregate_info) Ditto.
3212 (dump_aggregate_info) Ditto.
3213 (initialize_aggregate_info) Ditto.
3214 (agr_00x_trns_proc) Removed.
3215 (agr_00x_end_func) Removed.
3216 (agr_10x_trns_proc) Removed.
3217 (agr_10x_trns_free) Removed.
3218 (agr_10x_end_func) Removed.
3219 (agr_11x_read) Removed.
3220 (agr_11x_finish) Removed.
3221 [DEBUGGING] (debug_print) Removed.
3222 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3224 (agr_to_active_file) New function.
3225 (presorted_agr_to_sysfile) New function.
3226 (sort_agr_to_sysfile) New function.
3228 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3230 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3232 * descript.q: (cmd_descriptives) Ditto.
3234 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3235 to new procedure() interface.
3237 * command.c: (cmd_execute) Adapt to new procedure() interface.
3239 * dictionary.c: (dict_compact_values) Also delete scratch
3241 (dict_get_compacted_value_cnt) New function.
3242 (dict_get_compacted_idx_to_fv) New function.
3244 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3245 (cmd_flip) Adapt to new procedure() interface.
3246 (flip_sink_write) Use sink->idx_to_fv.
3248 * frequencies.q: (internal_cmd_frequencies) Use
3249 procedure_with_splits().
3251 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3252 (static var mtf_sink) New static var.
3253 (static var mtf_case) New static var.
3254 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3255 we actually implement the matching.
3256 (mtf_delete_file_in_place) Use mtf_case.
3257 (mtf_processing) Use mtf_case and mtf_sink.
3258 (cmd_export) Adapt to new procedure() interface.
3260 * levene.c: (levene) Use procedure_with_splits().
3262 * list.q: (cmd_list) Use procedure_with_splits().
3264 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3265 procedure() interface.
3266 (read_matrices_with_rowtype) Ditto.
3268 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3269 TEMPORARY. Adapt to new procedure() interface.
3271 * rename-vars.c: Warn about and cancel TEMPORARY.
3273 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3274 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3275 compaction_nval. Adapt to new procedure() interface. Use
3276 storage_source_to_disk().
3277 (do_internal_sort) Don't try to dump the cases to memory.
3278 (compare_case_lists) Pass null idx_to_fv.
3279 (struct initial_run_state) Add `idx_to_fv' member. Remove
3281 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3282 new procedure() interface. Reset irs->idx_to_fv after calling
3284 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3285 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3287 (destroy_initial_run_state) Don't dereference irs after freeing
3289 (allocate_cases) Don't calculate case_size locally.
3290 (compare_record) Add idx_to_fv parameter.
3291 (compare_record_run) Change parameter from struct sort_cases_pgm *
3292 to struct initial_run_state *. Pass irs->idx_to_fv to
3294 (compare_record_run) Third parameter now a struct
3295 initial_run_state *.
3296 (output_record) No need for out_case anymore. Pass irs, not
3297 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3299 (merge) Use case_size from struct sort_cases_pgm.
3300 (merge_once) Use case_size from struct sort_cases_pgm.
3301 Pass null pointer to compare_record() as idx_to_fv.
3302 (global var sort_sink_class) Make static.
3304 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3306 * temporary.c: Remove debugging crap.
3308 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3310 * t-test.q, levene.c: Fixed up the handling of MISSING values
3313 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3315 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3318 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3320 Change explicit variable name checks into use of
3321 dict_class_from_id().
3323 * dictionary.c: (dict_create_var) Change explicit variable name
3324 check into use of dict_class_from_id().
3326 * get.c: (trim_dictionary) Ditto.
3328 * sel-if.c: (cmd_filter) Ditto.
3330 * sysfile-info.c: (cmd_display) Ditto.
3332 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3334 * vfm.c: (arrange_compaction) Ditto.
3336 * weight.c: (cmd_weight) Ditto.
3338 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3340 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3341 transformation following the input program, if any, for some
3342 reason we special-cased f_trns. That's just wrong. It should
3343 always be set to n_trns.
3345 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3347 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3348 introduced in last check-in.
3350 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3352 * format.c: (global array translate_fmt[]) Removed.
3353 (translate_fmt) New function as replacement.
3354 (parse_format_specifier_name) Rewrite.
3356 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3359 * sfm-read.c: (parse_format_spec) Ditto.
3361 * postscript.c: (text) Fix handling of fonts with missing
3364 * sort.c: (struct external_sort) Add temp_name member.
3365 (destroy_external_sort) Free temp_dir, temp_name members.
3366 (init_external_sort) Allocate temp_name.
3367 (get_temp_file_name) Change prototype.
3368 (open_temp_file) Deal with change to get_temp_file_name().
3369 (close_temp_file) Ditto.
3370 (remove_temp_file) Ditto.
3371 (write_temp_file) Ditto.
3372 (read_temp_file) Ditto.
3373 (sort_sink_destroy) Removed.
3374 (sort_sink_class) Change destroy member to null.
3376 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3378 Eliminate temp_case.
3380 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3381 anymore. Use agr_11x_finish().
3382 (aggregate_single_case) Make first param const.
3383 (accumulate_aggregate_info) Ditto.
3384 (agr_00x_end_func) Use compaction_case, not temp_case.
3385 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3387 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3388 (cmd_data_list) Initialize case_size.
3389 (read_from_data_list_fixed) Add struct ccase * param, use instead
3391 (read_from_data_list_free) Ditto.
3392 (read_from_data_list_list) Ditto.
3393 (read_one_case) Rename data_list_trns_proc(), all references
3394 updated. Add argument in calling above functions. Use c
3395 argument instead of temp_case.
3396 (destroy_dls) Rename data_list_trns_free(), all references
3399 * expr-evl.c: (expr_evaluate) Make second parameter const.
3401 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3402 (cmd_end_file_type) Initialize `case_size'.
3403 (file_type_source_read) Add struct ccase * parameter. Use instead
3406 * flip.c: Rewritten.
3408 * get.c: (struct get_pgm) New structure to keep track of
3410 (cmd_get) Initialize case_size.
3412 (get_source) Deal with struct get_pgm.
3413 (get_source_read) Add struct ccase * parameter, use instead of
3415 (import_source_read) Ditto.
3417 * get.c: Use a null pointer instead of temp_case to represent the
3418 "current case" in a struct mtf_file's input member.
3419 (mtf_processing_finish) Pass null to mtf_processing(), not
3421 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3422 (mtf_compare_BY_values) Add extra arg, use instead of null input
3424 (mtf_processing) Use c parameter instead of temp_case. Pass
3425 compaction_case to process_active_file_output_case().
3427 * glob.c: (global variable temp_case) Removed.
3429 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3430 (cmd_input_program) Initialize case_size. Set
3431 vfm_source->value_cnt.
3432 (init_case) Add struct ccase * parameter, use instead of
3435 (input_program_source_read) Ditto.
3437 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3438 (dump_cell_content) Ditto.
3439 (nr_output_data) Ditto.
3440 (read_matrices_without_rowtype) Ditto.
3441 (matrix_data_read_with_rowtype) Ditto.
3442 (wr_read_splits) Ditto.
3443 (wr_output_data) Ditto.
3445 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3447 * sort.c: (sort_cases) Initialize scp->case_size.
3448 (struct external_sort) Remove `case_size' member.
3449 (write_initial_runs) Only call vfm_sink->class_destroy if
3451 (struct sort_source_aux) New structure.
3452 (sort_source_read_helper) New function.
3453 (sort_source_read) Use sort_source_read_helper().
3454 (read_sort_output) Change interface to be more reasonable.
3455 (read_internal_sort_output) Ditto.
3456 (read_external_sort_output) Ditto.
3458 * vars-prs.c: (dict_class_to_name) Pass return value through
3461 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3462 (procedure) Initialize trns_case.
3463 (procedure) Pass trns_case to vfm_source->class->read().
3465 (process_active_file) Start using struct procedure_aux_data.
3466 (process_active_file_write_case) Pass trns_case to
3467 transformations, lag_case(), clear_case().
3468 (process_active_file_output_case) Add struct ccase * parameter.
3469 (create_trns_case) New function.
3470 (make_temp_case) Removed.
3471 (vector_initialization) Removed.
3472 (close_active_file) Only call make_source if non-null, otherwise
3473 set vfm_source to null pointer. Don't free temp_case.
3474 (disk_source_read) Add struct ccase * parameter, use instead of
3476 (memory_source_read) Ditto.
3477 (lag_case) Add const struct ccase * member.
3478 (procedure_write_case) Use trns_case instead of temp_case.
3479 (clear_case) Add struct ccase * member, use instead of temp_case.
3480 (exclude_this_case) Ditto.
3481 (create_case_source) Add struct dictionary * parameter, use to
3482 initialize source->value_cnt.
3484 * vfm.h: (struct case_source) Add `value_cnt' member.
3485 (struct case_source_class) Add struct ccase * parameter to `read'
3486 member function pointer.
3487 (struct case_sink_class) Make struct ccase * parameter const in
3488 `write' member function pointer.
3490 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3492 Fix a lot of "possibly uninitialized variable" warnings. Some of
3493 them are even real bugs. A few of them make me wonder how the
3496 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3498 * ascii.c: (output_lines) Add default case to switch.
3500 * crosstabs.q: Remove static variable `expected' and all
3502 (display_crosstabulation) Always calculate expected value.
3504 (output_pivot_table) Initialize `cmp'.
3505 (display_crosstabulation) New variable `last_row', which is
3508 * data-in.c: (parse_numeric) Always initialize sign. How did this
3511 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3512 Always set info.ofs. (How did this work?!)
3514 * expr-opt.c: (optimize_tree) Always initialize `m'.
3515 (evaluate_tree) Always initialize `c'. (How did this work?)
3517 * frequencies.q: (frq_custom_variables) Always initialize min,
3519 (frq_custom_grouped) Always initialize `dl'.
3521 * groff-font.c: (groff_read_font) Always initialize char_set.
3523 * matrix-data.c: (nr_output_data) Initialize `split'.
3524 (wr_read_splits) Remove shadowing split_cnt declaration.
3525 (wr_output_data) Initialize `split'.
3527 * output.c: (tokener) Skip add character on syntax error.
3529 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3531 * postscript.c: (read_ps_encodings) Use line.string instead of
3533 (write_text) Add default case to switch.
3534 (text) Always initialize multiple variables. Fix bug with
3537 * print.c: (fixed_parse_fortran) Initialize head.
3538 (alloc_line) Add default case to switch.
3540 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3541 (recode_trns_proc) Move variable declaration inward. Add default
3544 * sfm-read.c: (read_header) Initialize skip_amt.
3546 * sysfile-info.c: (display_variables) Always initialize pc.
3548 * vars-prs.c: Initialized `included'.
3550 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3552 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3553 Just use signal() instead.
3555 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3557 Get rid of vfm_sink_info and vfm_source_info.
3559 * aggregate.c: (agr_00x_end_func) Don't increment
3560 sfm_sink_info.ncases.
3562 * sort.c: (do_internal_sort) Get case count from
3563 vfm_source->class->count().
3564 (struct external_sort) Add `case_size' member.
3565 (do_external_sort) Initialize case_size.
3566 (struct initial_run_state) Add `case_size' member.
3567 (write_initial_runs) Initialize case_size.
3568 (sort_sink_write) Use case_size.
3569 (read_external_sort_output) Use case_size. Get case_cnt from
3572 * vfm.c: (struct write_case_data) Add underscores to existing arg
3573 names, all references updated. Renamed `aux' as `func_aux', all
3574 references updated. Added new `aux' member.
3575 (global var vfm_source_info) Removed.
3576 (global var vfm_sink_info) Removed.
3577 (struct procedure_aux_data) New.
3578 (struct split_aux_data) New.
3579 (procedure) Use `aux' fields for procedure_aux_data,
3581 (process_active_file_write_case) Pass case_count + 1 to
3582 transformation procedures, exclude_this_case().
3583 (process_active_file_output_case) Don't increment
3584 vfm_sink_info.ncases.
3585 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3586 to send data to disk early.
3587 (make_temp_case) Don't use vfm_sink_info.case_size.
3588 (close_active_file) Don't initialize vfm_source_info.
3589 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3590 (disk_sink_create) Initialize and/or update disk_stream_info.
3591 (disk_sink_write) Ditto.
3592 (disk_sink_destroy) Ditto.
3593 (disk_sink_make_source) Ditto.
3594 (disk_source_read) Ditto.
3595 (disk_source_destroy) Ditto.
3596 (global var disk_source_class) Add disk_source_count().
3597 (disk_source_count) New function.
3598 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3599 (struct memory_source_info) Ditto.
3600 (memory_sink_create) Deal with case_cnt, case_size.
3601 (memory_sink_write) Ditto.
3602 (memory_sink_make_source) Ditto.
3603 (memory_source_read) Ditto.
3604 (memory_source_count) New function.
3605 (memory_source_class) Add memory_source_count().
3606 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3607 proc_aux->cases_written, and pass it to transformation procedures
3608 and exclude_this_case ().
3609 (exclude_this_case) Add case_num parameter. Pass it to
3611 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3614 * vfm.h: (struct case_source_class) Add `count' member.
3616 * vfmP.h: (struct stream_info) Removed.
3617 (global variable vfm_source_info) Removed.
3618 (global variable vfm_sink_info) Removed.
3620 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3622 * var.h: (typedef trns_proc_func) New typedef.
3623 (trns_free_func) New typedef.
3624 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3625 to type trns_free_func. This only changes the actual type of
3626 trns_proc_func, adding a `case_num' parameter. Updated all
3627 implementations to use the typedefs instead.
3629 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3630 (compute_num_vec) Ditto.
3631 (compute_str) Ditto.
3632 (compute_str_vec) Ditto.
3634 * do-if.c: (do_if_trns_proc) Ditto.
3636 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3639 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3640 pass to transformation functions.
3641 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3643 * loop.c: (loop_1_trns_proc) Ditto.
3644 (loop_2_trns_proc) Ditto.
3645 (loop_3_trns_proc) Ditto.
3647 * print.c: (print_space_trns_proc) Ditto.
3649 * sel-if.c: (select_if_proc) Ditto.
3651 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3653 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3654 destroying hash table.
3656 * glob.c: (read_active_file) Variable not referenced, removed.
3657 (cancel_input_pgm) Ditto.
3659 * levene.c: Add #include <stdlib.h> needed to call free().
3661 * aggregate.c: (parse_aggregate_functions) Make `function'
3664 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3666 Start working to eliminate VFM dependence on static variables.
3668 * command.c: (cmd_parse) Use case_source_is_class().
3670 * data-list.c: Rewrite to eliminate use of static variables.
3672 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3674 * file-handle.q: (fh_handle_name) Make parameter const.
3676 * file-type.c: Rewrite to eliminate use of static variables.
3678 * flip.c: Rewrite to eliminate use of static variables.
3680 * format.c: (get_format_var_width) New function.
3682 * get.c: Eliminate use of static variables.
3684 * inpt-pgm.c: Eliminate use of static variables.
3686 * matrix-data.c: Eliminate use of static variables.
3688 * set.q: (set_max_workspace) New variable.
3689 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3691 * var.h: (struct case_list) Move here from vfmP.h.
3693 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3695 * vfm.c: (vfm_source) Change type from struct case_stream to
3697 (vfm_sink) Change type from struct case_stream to struct
3699 (static var paging) Rename workspace_overflow, all references
3701 (procedure) Use new class structures.
3702 (process_active_file) Ditto.
3703 (process_active_file_write_case) Ditto.
3704 (prepare_for_writing) Use set_max_workspace. Use new class
3706 (close_active_file) Use new class structures. Free old sink.
3707 (global var disk_source_file) Removed.
3708 (global var disk_sink_file) Removed.
3709 (disk_stream_init) Removed.
3710 (disk_stream_read) Removed.
3711 (disk_stream_write) Removed.
3712 (disk_stream_mode) Removed.
3713 (disk_stream_destroy_source) Removed.
3714 (disk_stream_destroy_sink) Removed.
3715 (global var vfm_disk_stream) Removed.
3716 (disk_sink_create) New function.
3717 (disk_sink_write) New function.
3718 (disk_sink_destroy) New function.
3719 (disk_sink_make_source) New function.
3720 (disk_sink_class) New static var.
3721 (disk_source_read) New function.
3722 (disk_source_destroy) New function.
3723 (global var vfm_source_class) New var.
3724 (global var memory_source_cases) Removed.
3725 (global var memory_sink_cases) Removed.
3726 (global var memory_sink_max_cases) Removed.
3727 (struct memory_sink_info) New struct.
3728 (memory_stream_init) Removed.
3729 (memory_stream_read) Removed.
3730 (memory_stream_write) Removed.
3731 (memory_stream_mode) Removed.
3732 (memory_stream_destroy_source) Removed.
3733 (memory_stream_destroy_sink) Removed.
3734 (global var vfm_memory_stream) Removed.
3735 (page_to_disk) Renamed write_active_file_to_disk().
3736 (memory_sink_create) New function.
3737 (memory_sink_write) New function.
3738 (memory_sink_destroy) New function.
3739 (memory_sink_make_source) New function.
3740 (memory_sink_class) New static var.
3741 (memory_source_read) New function.
3742 (memory_source_destroy) New function.
3743 (memory_source_get_cases) New function.
3744 (memory_source_set_cases) New function.
3745 (global var vfm_source_class) New var.
3746 (procedure_write_case) Use new class structures.
3747 (create_case_source) New function.
3748 (case_source_is_complex) New function.
3749 (case_source_is_class) New function.
3750 (create_case_sink) New function.
3752 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3753 (global variable reinit_blanks) Not used, removed.
3754 (global variable init_zero) Not used, removed.
3755 (global variable init_blanks) Not used, removed.
3756 (struct case_source) New struct.
3757 (struct case_source_class) New struct.
3758 (struct case_sink) New struct.
3759 (struct case_sink_class) New struct.
3760 (struct case_stream) Removed.
3762 * vfmP.h: (struct case_list) Moved to var.h.
3764 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3766 * algorithm.c: (count_equal) New function.
3767 (count_if) New function.
3768 (unique) Add assertions.
3769 (partition) Add assertions.
3770 (is_partitioned) New function.
3771 (copy_if) Add assertions.
3772 (remove_equal) Add assertions.
3773 (lexicographical_compare) Rename lexicographical_compare_3way.
3774 (sort) Add assertions. Rephrase some code.
3775 (is_sorted) New function.
3777 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3781 * sort.c: Completely rewrite.
3783 * sort.h: Expose interface via struct sort_cases_pgm, not via
3786 * aggregate.c: (sort) New static var.
3787 (cmd_aggregate) Use sort.
3788 (create_sysfile) Ditto.
3789 (aggregate_single_case) Ditto.
3790 (dump_aggregate_info) Ditto.
3791 (agr_00x_end_func) Ditto.
3792 (debug_print) Ditto.
3794 * var.h: (enum SRT_ASCEND) Removed.
3795 (enum SRT_DESCEND) Removed.
3796 (struct sort_cases_proc) Removed.
3797 (struct variable) Remove p.srt member.
3799 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3801 Get rid of the old, crappy heap structure and replace it by a new,
3802 shiny, C++ STL-like heap structure.
3804 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3806 * algorithm.c: (push_heap) New function.
3817 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3819 Increase warning level.
3821 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3823 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3825 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3827 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3829 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3830 around by previous change log entry.
3832 * compute.c: (lvalue_finalize) Remove workaround from previous
3835 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3837 * compute.c: Fixed a bug where the Format was not getting set for
3838 computed variables (thus causing a crash when SAVEing).
3840 * Added a test to stop this bug ever coming back
3842 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3844 Got rid of approx.h. In general, replaced all references to
3845 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3848 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3850 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3851 test for mag < EPSILON.
3853 * misc.h: Add definition of EPSILON.
3855 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3857 * vfm.c: (procedure) Add check to prevent recursive call.
3859 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3861 * Moved the declarations relating to values to their own header file
3864 * Added levene.c and levene.h
3866 * vars-atr.c: Changed the signature of compare_values to
3867 take const * arguments.
3869 * t-test.q: Changed the structure of struct t_test_proc
3870 variables now contain their own group statistics information.
3871 Eventually, t_test_proc might get renamed, because it'd be
3872 applicable to other commands too.
3874 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3876 * data-out.c: Clean up. Changed interface of convert_*() to take
3877 either a `double' or a `const char *' instead of a `const union
3878 value *'. Update all implementations of those interfaces.
3879 (data_out) Use switch statements instead of a table.
3880 (convert_AHEX) Rewrite.
3882 * format.h: Update comment.
3884 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3886 * q2c.c: (dump_header) Add an Emacs header line to output files
3887 that makes generated .c files read-only by default, to make it
3888 difficult to accidentally change generated files.
3890 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3892 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3893 not bogus a->v.c <=> b->v.c pointer compare.
3894 (compare_freq_alpha_a) Ditto.
3895 (compare_freq_numeric_d) Ditto.
3896 (compare_freq_alpha_d) Ditto.
3898 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3900 Changed data_out() to store string data directly into a `union
3901 value''s s member, not indirectly into c.
3903 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3905 (table_value_missing) Ditto.
3906 (float_M_suffix) Ditto.
3907 (format_short) New function.
3909 * data-in.h: (data_in_finite_line) Remove inline definition.
3911 * data-list.c: (destroy_dls_var_spec) New function.
3912 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3913 (data_list_source_destroy_source) Avoid cast.
3914 (struct repeating_data_trns) New field `id_value'. Update
3916 (cmd_repeating_data) Initialize id_value. Use new
3917 repeating_data_trns_free() for freeing REPEATING DATA
3919 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3920 (repeating_data_trns_free) New function.
3922 * data-out.c: (data_out) Change return type to `void' by replacing
3923 error returns by writing a message into the output buffer.
3924 (convert_A) Read from v->s instead of v->c.
3925 (convert_AHEX) Ditto.
3927 * expr-evl.c: Update comment.
3928 (expr_evaluate) Add assertion in OP_STRING case.
3930 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3932 * list.q: (list_cases) Update for new data_out() semantics.
3934 * print.c: (print_trns_proc) Ditto.
3936 * tab.c: (tab_value) Ditto.
3937 (tab_float) Avoid stupid cast.
3939 * var.h: Update comments.
3940 (macro MAX_STRING) New macro.
3941 (macro MAX_ELEMS_PER_VALUE) New macro.
3943 * vars-atr.c: (compare_values) New function.
3945 * vfm.c: (dump_splits) Update for new data_out() semantics.
3947 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3949 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3951 (struct crosstab) Rename v[] to vars[]. All references updated.
3952 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3953 same time, which caused the hash value to depend only on a single
3954 value, not all of the variables' values.
3956 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3958 Clean up struct dictionary's value_cnt usage.
3960 * dictionary.c: Add a function comment to each function.
3961 (struct dictionary) Rename value_cnt to next_value_idx, which more
3962 accurately reflects its meaning. All references updated.
3963 (dict_rename_vars) Add assertion.
3964 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3966 (dict_get_case_size) New function.
3968 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3970 * get.c: (mtf_read_nonactive_records) Ditto.
3972 * sort.c: (allocate_cases) Ditto.
3973 (write_initial_runs) Ditto.
3977 * vfm.c: (prepare_for_writing) Ditto.
3981 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
3983 Make vfm.c slightly less grotesque.
3985 * vfm.c: (filter_var) Removed.
3986 (filter_index) Removed.
3987 (FILTERED macro) Removed.
3988 (exclude_this_case) New function.
3989 (process_active_file_write_case) Use exclude_this_case() instead
3990 of FILTERED and inline tests.
3991 (procedure_write_case) Ditto.
3992 (setup_filter) Removed.
3993 (open_active_file) Don't call setup_filter().
3994 (close_active_file) Call dict_get_filter() instead of checking
3997 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
3999 * var.h: (struct variable) Update comments.
4001 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4003 New functions dict_create_var_assert(), dict_lookup_var_assert().
4004 Converted several dict_*_var()/assert pairs into a single
4005 dict_*_var_assert().
4007 * dictionary.c: (dict_create_var_assert) New function.
4008 (dict_lookup_var_assert) New function.
4010 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4012 Got rid of "struct long_vec", envector(), devector(), etc. Added
4013 two members `init', `reinit' to struct variable as a substitute.
4015 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4021 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4024 * autorecode.c: (cmd_autorecode) destvars don't need init.
4026 * compute.c: (lvalue_finalize) Set reinit.
4028 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4029 (dump_fmt_list) Ditto.
4032 * descript.q: (run_z_pass) Don't need init for z-scores.
4034 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4036 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4038 * glob.c: (init_glob) Remove vec_init() calls.
4040 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4042 * loop.c: (internal_cmd_loop) Don't need to call envector().
4044 * numeric.c: (cmd_numeric) Ditto.
4046 (cmd_leave) Ditto. Set `init', `reinit' members.
4048 * recode.c: (cmd_recode) Don't need to call envector().
4050 * repeat.c: (internal_cmd_do_repeat) Ditto.
4052 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4053 (force_create_variable) Removed prototype.
4054 (force_dup_variable) Ditto.
4056 * vector.c: (cmd_vector) Don't need to call envector().
4058 * vfm.c: (reinit_sysmis) Removed.
4059 (reinit_blanks) Removed.
4060 (init_zero) Removed.
4061 (init_blanks) Removed.
4062 (process_active_file_write_case) No need to deal with vectors.
4063 Call clear_temp_case().
4064 (vector_initialization) Rewrite to use `init', `reinit'.
4065 (close_active_file) No need to call vec_clear().
4066 (procedure_write_case) Call clear_temp_case().
4067 (clear_temp_case) New function.
4069 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4071 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4074 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4076 Add auxiliary argument to procedure() interface. Associated small
4077 clean-ups of vfm interface.
4079 * Updated every caller of procedure() and process_active_file() to
4080 reflect modified interface. Simple, ordinary changes not listed
4083 * Updated every function that implements struct case_stream's
4084 `read' function to take a write_case_func and a write_case_data.
4085 Also updated every caller of write_case() to instead call them
4086 through these arguments. In some cases this meant that the extra
4087 args had to be threaded through a couple of extra levels. This
4088 wasn't difficult or interesting so the details won't be given.
4090 * data-list.c: (struct repeating_data_trns) Add members
4091 `write_case', `wc_data' as kluge.
4092 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4094 (repeating_data_set_write_case) New function.
4096 * data-list.h: New file to declare repeating_data_trns_proc() and
4097 repeating_data_set_write_case().
4099 * inpt-pgm.c: (input_program_source_read) Call
4100 repeating_data_set_write_case() for all the REPEATING DATA
4101 transformations, so that they know where to send their cases.
4102 It's a big kluge. Also kluge in END CASE.
4103 (end_case_trns_proc) Never called anymore, but we still need it,
4106 * sort.c: (read_sort_output) Update to match struct case_stream
4109 * vfm.c: (struct write_case_data) New structure.
4110 (proc_func) Removed.
4111 (virt_proc_func) Removed.
4112 (begin_func) Removed.
4113 (virt_begin_func) Removed.
4115 (write_case) Removed.
4116 (procedure) Added an auxiliary parameter to each function pointer
4117 argument's prototype. Added an auxiliary data parameter.
4119 (process_active_file) Ditto.
4120 (process_active_file_write_case) Pass aux data along.
4121 (close_active_file) Ditto.
4122 (procedure_write_case) Ditto.
4123 (SPLIT_FILE_procfunc) Ditto.
4125 * vfm.h: (typedef write_case_data) New.
4126 (typedef write_case_func) New.
4127 (struct case_stream) Add parameters to `read' member prototype.
4129 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4131 * t-test.q: Added calculations for independent samples. (But no Levene
4134 * Makefile.am: Moved q_sources_c into own variable
4136 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4138 Miscellaneous cleanups.
4140 * Change unused to UNUSED in many source files to reflect modified
4141 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4142 __CYGWIN32__, __unix__, and unix not to assume that they're
4143 defined to a nonzero value. Change use of __attribute__ to use
4144 NO_RETURN or PRINTF_FORMAT instead.
4146 * alloc.h: Move definitions for local_alloc(), local_free() here
4147 from ../pref.h.orig and simplify.
4149 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4150 use a pool allocator unconditionally.
4151 (CHECK_STRING_SPACE) Removed.
4152 (ALLOC_STRING_SPACE) Removed.
4153 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4156 * expr-opt.c: (dump_expression) Allocate string pool.
4158 * expr-prs.c: (expr_free) Free string pool.
4160 * pool.c: (pool_destroy) This pool must be removed from its
4161 parent's list of gizmos, not from its own. Use free_all_gizmos().
4162 (pool_clear) New function.
4163 (free_all_gizmos) New function.
4164 (pool_alloc) Use space in empty block after this one if any.
4165 (pool_release) Only empty out blocks, don't actually free() them.
4167 * print.c: Get rid of PAGED_STACK special case by always
4168 dynamically allocating line buffers.
4169 (struct print_trns) Always include the `line' member.
4170 (internal_cmd_print) Always initialize the `line' member.
4171 (alloc_line) Always allocate memory for `line'.
4172 (print_trns_proc) Always initialize buf from `line' member.
4173 (print_trns_free) Always free `line' memory.
4175 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4178 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4180 * flip.c: Fixed crash from FLIP when a numeric variable is
4181 specified on NEWNAMES and a large value is used, and a couple of
4182 other minor bugs besides.
4183 (struct varname) Make name a 9-character fixed-size array
4184 instead of a 1-character variable size array.
4185 (make_new_var) Allow digits in variable names.
4186 (flip_stream_write) Limit numeric values to 8 characters and
4187 format system missing and very large and small values more
4190 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4192 * command.c: Fixed test on command return status for the correct
4193 value, which had been causing a crash under certain invalid input.
4195 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4197 * t-test.q: Added calculations for the one sample variant of the T-TEST
4199 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4201 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4202 in joined cells to be rendered outside box boundaries.
4204 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4206 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4207 SET seed=xx has been called.
4209 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4211 * random.c (rng_get_double): Fix always-returning-zero bug in my
4212 preferred way, and at the same time make sure rounding doesn't
4215 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4217 * html.c: (change_attributes) Dead code, removed.
4218 (escape_string) Eliminate code to call change_attributes() that
4219 never actually called it.
4220 (output_tab_table) Get rid of dependence on tab_hit
4221 and struct tab_joined_cell's hit member, which are abominations.
4223 * tab.c: (tab_output_text) Don't call
4224 d->class->text_set_font_by_name if it's a null pointer.
4225 (macro UNROLL_LOOP) Eliminate.
4226 (macro UNROLL_3_LOOPS) Eliminate.
4227 (tabi_render) Rewrite not to use the above macros.
4229 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4231 Start working on a new output driver system, one that doesn't suck
4232 so much, by adding a "device-independent" output driver. The idea
4233 is to write out only a single output stream, then use separate
4234 processes to translate them into whatever formats we want. This
4235 is similar to how "groff" works with its various output drivers
4236 (grops, grotty, grodvi, ...).
4238 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4240 * list.q: (write_all_headers) Stub out devind class.
4242 (determine_layout) Ditto.
4245 * output.c: (outp_init) Add devind class.
4247 * devind.c: New file.
4249 * devind.h: New file.
4251 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4253 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4254 to use the proper string length.
4256 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4258 * Fixed bug where FREQ would crash on alpha values
4260 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4262 * Removed bletcherous alloca() workarounds for AIX from top of
4263 many files. AIX can use the alternative alloca() implementation
4266 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4268 * ascii.c: (ascii_option) Fix implementation of headers option.
4270 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4272 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4273 multiple blank lines into one.
4274 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4275 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4276 (static var option_tab) Add squeeze entry.
4277 (ascii_option) Set squeeze_blank_lines.
4278 (output_lines) Implement squeezing blank lines.
4280 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4282 * Removed redundant code from output.h
4284 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4286 Dictionary classes: each variable is "ordinary", "system", or
4289 * var.h: (enum dict_class) New enum.
4291 * vars-prs.c: (dict_class_from_id) New function.
4292 (dict_class_to_name) New function.
4294 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4296 * var.h: (struct freq_tab_set) Removed (not used).
4298 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4300 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4302 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4304 * stats.c: (hypercube) Rename pow4(). All references updated.
4306 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4308 * rename-vars.c: (cmd_rename_variables) Rewritten.
4309 (compare_name) Removed.
4311 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4313 var_set feature, and code taking advantage of it.
4315 * crosstabs.q: (static var var_dict) Removed.
4316 (static var variables) New variable.
4317 (static var variables_cnt) New variable.
4318 (cmd_crosstabs) Free variables instead of var_dict.
4319 (internal_cmd_crosstabs) Initialize and use variables,
4320 variables_cnt instead of var_dict.
4321 (free_var_dict) Removed.
4322 (crs_custom_tables) Use var_set instead of a copied dictionary.
4323 (crs_custom_variables) Set up variables, variables_cnt instead of
4325 [DEBUGGING] (debug_print) Ditto.
4327 * means.q: (mns_custom_tables) Use var_set instead of a copied
4330 * vars-prs.c: (parse_vs_variable) New function.
4331 (parse_dict_variable) Rewritten.
4332 (parse_variable) Rewritten.
4333 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4334 (parse_variables) New function in terms of parse_var_set_vars().
4335 Now requires its first argument to be non-null. All references
4336 that passed a null pointer updated to pass default_dict instead.
4337 (macro id_dict) Removed.
4338 (parse_DATA_LIST_vars) Add assertions.
4339 (parse_mixed_vars) Ditto.
4340 (struct var_set) New structure.
4341 (var_set_get_cnt) New function.
4342 (var_set_get_var) New function.
4343 (var_set_lookup_var) New function.
4344 (var_set_destroy) New function.
4345 (dict_var_set_get_cnt) New function.
4346 (dict_var_set_get_var) New function.
4347 (dict_var_set_lookup_var) New function.
4348 (dict_var_set_destroy) New function.
4349 (var_set_create_from_dict) New function.
4350 (struct array_var_set) New structure.
4351 (array_var_set_get_cnt) New function.
4352 (array_var_set_get_var) New function.
4353 (array_var_set_lookup_var) New function.
4354 (array_var_set_destroy) New function.
4355 (var_set_create_from_array) New function.
4357 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4358 instead of parse_variables(NULL, ...) in output code.
4360 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4362 Change inp_init from a 2-bit vector to an ordinary array.
4363 Initialize it all in cmd_end_input_program() instead of in
4366 * inpt-pgm.c: (enum value_init_type) New enum.
4367 (global var inp_init) Change to `enum value_init_type *', make
4369 (inp_init_size) Removed.
4370 (inp_nval) Change to `size_t', make static.
4371 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4372 (cmd_end_input_program) Initialize inp_init, inp_nval.
4373 (init_case) Rewrite.
4374 (clear_case) Rewrite.
4376 * inpt-pgm.h: Removed.
4378 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4380 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4381 Colin Plumb hash. It is simpler and should better resist
4383 (hsh_hash_string) Ditto.
4385 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4387 * get.c: (export_write_case_func) Remove debug printing code.
4389 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4391 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4393 (save_write_case_func) Use &trns->h instead of cast.
4394 (cmd_export) Use &t->h instead of cast.
4396 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4398 Moved vectors into the dictionary.
4400 * var.h: (struct vector) Moved here from vector.h. `index' member
4401 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4404 * vector.h: Removed.
4406 * vector.c: (global var vec) Removed.
4407 (global var nvec) Removed.
4408 (cmd_vector) Rewritten.
4409 (find_vector) Removed.
4411 * dictionary.c: (dict_create_vector) New function.
4412 (dict_get_vector) New function, replaces reading global vec[]
4414 (dict_get_vector_cnt) New function, replaces reading global nvec
4416 (dict_lookup_vector) New function, replaces find_vector().
4417 (dict_clear_vectors) New function.
4419 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4421 Start to move away from `struct variable' p `union' member to void
4424 * var.h: (struct variable) Add `aux' member.
4426 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4428 Get rid of struct variable `foo' member.
4430 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4432 (frq_custom_variables) Ditto.
4433 (frq_custom_grouped) Ditto.
4435 * get.c: (struct save_trns) Change `var' member from `int *' to
4436 `struct variable **'.
4437 (cmd_save_internal) Use aux instead of foo.
4438 (save_trns_proc) Use revised `var' member.
4439 (static var mtf_seq_no) Renamed mtf_seq_num.
4440 (static var mtf_seq_nums) New static var.
4441 (cmd_match_files) Initialize mtf_seq_nums.
4442 (mtf_free) Free mtf_seq_nums.
4443 (mtf_processing) Use mtf_seq_nums instead of foo.
4444 (mtf_merge_dictionary) No need to initialize mv->foo.
4445 (cmd_export) Use aux instead of foo. Use revised `var' member.
4446 (mns_custom_tables) Don't use foo to check for duplicates, that's
4447 what PV_NO_DUPLICATE is for.
4449 * var.h: (struct variable) Remove `foo' member.
4450 (struct frequencies_proc) New member.
4452 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4454 Clean up COMPUTE and IF.
4456 * compute.c: More or less rewrite the darn thing.
4457 (struct compute_trns) Rename and reorder and add and delete
4459 (cmd_compute) Rewrite.
4460 (compute_num) Make conditional on test expression. Now used for
4461 both COMPUTE and IF.
4462 (compute_num_vec) Ditto.
4463 (compute_str) Ditto.
4464 (compute_str_vec) Ditto.
4467 (if_num_vec) Removed.
4469 (if_str_vec) Removed.
4470 (parse_target_expression) Renamed parse_rvalue_expression(),
4472 (new_trns) Renamed compute_trns_create(), rewritten.
4473 (delete_trns) Removed.
4474 (free_trns) Renamed compute_trns_free(), rewritten.
4475 (struct lvalue) New structure.
4476 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4477 (lvalue_get_type) New function.
4478 (lvalue_is_vector) New function.
4479 (lvalue_finalize) New function.
4480 (lvalue_destroy) New function.
4482 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4484 * command.def: Disallow MODIFY VARS in input mode, so that
4485 variables can't get dropped and confuse cmd_end_input_program()'s
4486 attempt to fill inp_init[].
4488 * modify-vars.c: (static var forward_positional_ordering) New
4490 (struct var_modification) Entirely changed.
4491 (rearrange_dict) Interface changed, rewritten.
4492 (cmd_modify_vars) Deal with modified struct var_modification, much
4494 (struct var_renaming) New structure.
4495 (compare_var_renaming_by_new_name) New function.
4496 (validate_var_modification) New function.
4498 * var.h: (struct modify_vars_proc) Removed.
4499 (struct variable) Removed member p.mfv.
4501 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4503 Make EVALUATE a valid command whether we're debugging or not, so
4504 that `make check' can succeed regardless of whether debugging is
4507 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4509 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4511 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4513 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4514 statement by a simple if test.
4516 * dfm.c: (dfm_get_record) Add assertion.
4518 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4520 For each file x.c, move #include "x.h" to the very top of the
4521 include list, to catch x.h failing to include the proper headers.
4523 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4525 * algorithm.c: (find) New function.
4526 (remove_equal) New function.
4527 (set_difference) New function.
4528 (adjacent_find_equal) New function.
4529 [TEST_UNIQUE] Removed test case.
4530 (copy_if) Find end test.
4532 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4534 * dictionary.c: (dict_get_case_weight) New convenience function.
4536 * aggregate.c: (accumulate_aggregate_info) Use
4537 dict_get_case_weight().
4539 * frequencies.q: (calc_general) Ditto.
4540 (calc_integer) Ditto.
4543 * t-test.q: (groups_calc) Ditto.
4546 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4548 * glob.c: (global var default_dict) Change from `struct
4549 dictionary' to `struct dictionary *'. All references changed.
4550 (init_glob) Initialize default_dict with dict_create().
4552 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4554 struct dictionary now made opaque. All related functions:
4556 * get.c: (rename_variables) Removed.
4557 (dict_delete_run) Removed.
4559 * temporary.c: (copy_variable) Removed.
4560 (new_dictionary) Removed.
4561 (save_dictionary) Removed.
4562 (restore_dictionary) Removed.
4563 (free_dictionary) Removed.
4565 * vars-atr.c: (clear_default_dict) Removed.
4566 (find_variable) Removed.
4567 (find_dict_variable) Removed.
4568 (create_variable) Removed.
4569 (delete_variable) Removed.
4570 (common_init_stuff) Removed.
4571 (init_variable) Removed. Updating of inp_init moved into
4572 cmd_end_input_program().
4573 (replace_variable) Removed.
4574 (rename_variable) Removed.
4575 (clear_variable) Removed.
4576 (dup_variable) Removed.
4578 * vars-prs.c: (is_varname) Removed.
4579 (is_dict_varname) Removed.
4580 (fill_all_vars) Removed.
4582 * vector.c: (find_vector) Removed.
4584 * weight.c: (stop_weighting) Removed.
4586 * dictionary.c: New file.
4587 (dict_create) New, replaces new_dictionary().
4588 (dict_clone) New, replaces save_dictionary() and
4589 restore_dictionary().
4590 (dict_clear) New, replaces clear_default_dict().
4591 (dict_destroy) New, replaces free_dictionary().
4592 (dict_get_var_cnt) New function, replaces references to
4594 (dict_get_var) New function, replaces references to dict->var[i].
4595 (dict_get_vars) New function, replaces fill_all_vars().
4596 (dict_create_var) New, replaces create_variable(). Interface
4597 drops `type' parameter, using a zero `width' to designate numeric.
4598 (dict_clone_var) New, replaces dup_variable().
4599 (dict_rename_var) New, replaces rename_variable().
4600 (dict_lookup_var) New, replaces find_variable(),
4601 find_dict_variable(), is_varname().
4602 (dict_contains_var) New function.
4603 (compare_variable_dblptrs) New function.
4604 (dict_delete_var) New function, replaces clear_variable().
4605 (dict_delete_vars) New function, replaces dict_delete_run().
4606 (dict_reorder_vars) New function.
4607 (dict_rename_vars) New function, replaces rename_variables().
4608 (dict_get_weight) New function, replaces reading dict->weight_var.
4609 (dict_set_weight) New function, replaces writing dict->weight_var
4610 or calling stop_weight(dict).
4611 (dict_get_filter) New function, replaces reading dict->filter_var.
4612 (dict_set_filter) New function, replaces writing dict->filter_var.
4613 (dict_get_case_limit) New function, replaces reading dict->N.
4614 (dict_set_case_limit) New function, replaces writing dict->N.
4615 (dict_get_value_cnt) New function, replaces reading dict->nval.
4616 (dict_compact_values) New function, replaces a loop that was
4617 replicated in several places.
4618 (dict_get_split_vars) New function, replaces reading dict->splits.
4619 (dict_get_split_cnt) New function, replaces reading
4621 (dict_set_split_vars) New function, replaces writing dict->splits.
4622 (dict_get_label) New function, replaces reading dict->label.
4623 (dict_set_label) New function, replaces writing dict->label.
4624 (dict_get_documents) New function, replaces reading
4626 (dict_set_documents) New function, replaces writing
4629 All references to above functions updated.
4631 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4632 old dictionary to new by hand, because dict_create() can't do it
4633 itself. Use dict_set_documents(), dict_set_split_vars().
4635 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4636 calling dict_destroy().
4638 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4640 (fixed_parse_compatible) Some slightly nontrivial changes for
4642 (dump_fmt_list) Ditto.
4645 * file-type.c: (create_col_var) Ditto.
4647 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4648 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4649 (rename_variables) Use dict_rename_vars().
4650 (mtf_merge_dictionary) Use dict_get_documents(),
4651 dict_set_documents(), dict_compact_values().
4653 * pfm-read.c: (read_variables) Deal with changes to weighting.
4655 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4656 is_varname() in output code.
4658 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4659 other dictionary functions.
4661 * title.c: (add_document_line) Use dict_get_documents(),
4662 dict_set_documents().
4664 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4665 reset default_handle by hand. dict_clear() will clear vectors so
4666 there's no need for that by hand.
4668 * vfm.c: (close_active_file) Move call to finish_compaction()
4669 earlier, so that we can do the compaction as a single step using
4670 dict_compact_values(). Use dict_clear_vectors().
4671 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4673 Some functions don't have replacements:
4675 * vars-atr.c: (force_create_variable) Removed. All references
4676 updated to dict_create_var() followed by an assertion.
4677 (force_dup_variable) Removed. All references updated to
4678 dict_clone_var() followed by an assertion.
4680 * weight.c: (update_weighting) Removed. No longer necessary, so
4681 all references removed.
4683 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4687 * aggregate.c: Eliminate separation of weighted and unweighted
4688 case. It made the code too obscure and I doubt it was actually
4689 faster. Instead, all code uses the "weighted" code, because
4690 that's a generalization of the "unweighted" code.
4693 (parse_aggregate_functions) No need to set FWEIGHT.
4694 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4695 (dump_aggregate_info) Ditto.
4696 (initialize_aggregate_info) No need for special plain_function
4697 that gets rid of FWEIGHT option.
4699 * aggregate.c: Get rid of approximations.
4700 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4702 (aggregate_single_case) Don't use approx_ne().
4704 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4706 * ascii.c (ascii_line_width): Dead code, removed.
4708 * postscript.c (ps_line_width): Ditto.
4710 * q2c.c (xrealloc): Ditto.
4712 * count.c (internal_cmd_count): Ditto.
4714 * means.q (validate_dependent_endpoint): Ditto.
4716 * set.q: (cmd_gset) Ditto.
4718 * weight.c: [0] (weight_trns_proc) Ditto.
4720 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4722 Make the code -Wmissing-prototypes clean.
4724 * Makefile.am (version.c): Add #include "version.h".
4726 * ascii.c: (ascii_open_global) Make static.
4727 (ascii_close_page) Ditto.
4728 (ascii_font_sizes) Ditto.
4729 (ascii_postopen_driver) Ditto.
4730 (ascii_close_driver) Ditto.
4731 (ascii_option) Ditto.
4732 (ascii_open_page) Ditto.
4733 (ascii_line_horz) Ditto.
4734 (ascii_line_vert) Ditto.
4735 (ascii_line_intersection) Ditto.
4737 (ascii_polyline_begin) Ditto.
4738 (ascii_polyline_point) Ditto.
4739 (ascii_polyline_end) Ditto.
4740 (ascii_text_set_font_by_name) Ditto.
4741 (ascii_text_set_font_by_position) Ditto.
4742 (ascii_text_set_font_by_family) Ditto.
4743 (ascii_text_get_font_name) Ditto.
4744 (ascii_text_get_font_family) Ditto.
4745 (ascii_text_set_size) Ditto.
4746 (ascii_text_get_size) Ditto.
4747 (ascii_text_metrics) Ditto.
4748 (ascii_text_draw) Ditto.
4749 (ascii_close_page) Ditto.
4751 * cmdline.h: New header for parse_command_line(). Used where
4754 * command.c: Move prototypes for cmd_*() functions to command.h.
4756 * command.h: Prototypes for cmd_*() functions moved here from
4759 * crosstabs.q: (gamma_int) Ditto.
4761 * file-handle.h: Add fh_init_files() prototype.
4763 * getline.c: (welcome) Ditto.
4765 * glob.h: New header for init_glob(). Used where appropriate.
4767 * hash.c: (comparison_helper) Ditto.
4769 * html.c: (html_open_global) Ditto.
4770 (html_close_global) Ditto.
4771 (html_preopen_driver) Ditto.
4772 (html_postopen_driver) Ditto.
4773 (html_close_driver) Ditto.
4774 (html_option) Ditto.
4775 (html_open_page) Ditto.
4776 (html_close_page) Ditto.
4777 (html_submit) Ditto.
4779 * inpt-pgm.c: (input_program_source_read) Ditto.
4781 * output.c: (find_defn_value) Ditto.
4782 (destroy_list) Ditto.
4784 * pfm-read.c: (read_int) Ditto.
4786 * postscript.c: (ps_open_global) Ditto.
4787 (ps_close_global) Ditto.
4788 (ps_font_sizes) Ditto.
4789 (ps_preopen_driver) Ditto.
4790 (ps_postopen_driver) Ditto.
4791 (ps_close_driver) Ditto.
4793 (ps_open_page) Ditto.
4794 (ps_close_page) Ditto.
4795 (ps_line_horz) Ditto.
4796 (ps_line_vert) Ditto.
4797 (ps_line_intersection) Ditto.
4799 (ps_polyline_begin) Ditto.
4800 (ps_polyline_point) Ditto.
4801 (ps_polyline_end) Ditto.
4802 (ps_text_set_font_by_name) Ditto.
4803 (ps_text_set_font_by_position) Ditto.
4804 (ps_text_set_font_family) Ditto.
4805 (ps_text_get_font_name) Ditto.
4806 (ps_text_get_font_family) Ditto.
4807 (ps_text_set_size) Ditto.
4808 (ps_text_get_size) Ditto.
4809 (ps_text_metrics) Ditto.
4810 (ps_text_draw) Ditto.
4812 * q2c.c: (finish_up) Ditto.
4821 (find_symbol) Ditto.
4824 (force_string) Ditto.
4826 (match_token) Ditto.
4829 (parse_setting) Ditto.
4830 (parse_specifier) Ditto.
4831 (parse_specifiers) Ditto.
4832 (parse_subcommand) Ditto.
4833 (dump_specifier_vars) Ditto.
4835 (make_identifier) Ditto.
4836 (dump_declarations) Ditto.
4837 (dump_specifier_init) Ditto.
4838 (dump_vars_init) Ditto.
4840 (dump_specifier_parse) Ditto.
4841 (dump_subcommand) Ditto.
4842 (dump_parser) Ditto.
4843 (dump_header) Ditto.
4845 (recognize_directive) Ditto.
4847 * recode.c: (string_to_long) Ditto.
4849 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4851 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4854 * sort.c: (sort_stream_read) Ditto.
4855 (sort_stream_mode) Ditto.
4857 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4859 * algorithm.c (binary_search): Fix comparison.
4861 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4863 * algorithm.c: (binary_search) Fix assertion.
4865 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4867 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4869 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4871 * sort.c: (compare_case_lists) Rewrite.
4873 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4875 * quicksort.c: Removed (not used).
4877 * quicksort.h: Removed (not used).
4879 * sort.c: Removed blp_quicksort() prototype.
4881 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4883 * postscript.c: (int_2_compare) Rewrite.
4884 (compare_line) Rewrite.
4886 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4888 * matrix-data.c (compare_factors) Use lexicographical_compare()
4890 (compare_doubles) New function.
4892 * algorithm.c: (lexicographical_compare) New algorithm.
4894 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4896 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4898 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4900 * expr-prs.c: (cmp_func) Removed.
4901 (parse_function) Use binary_search() algorithm.
4902 (compare_functions) New function.
4903 (init_func_tab) Use sort() algorithm.
4905 * algorithm.c: (binary_search) New algorithm.
4907 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4909 * descript.q: (display) Use sort() algorithm instead of qsort().
4910 (compare_func) Removed.
4911 (descriptives_compare_variables) New function.
4913 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4915 Get rid of AVL trees. Hashes are more appropriate for everything
4918 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4924 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4926 Much code can be clarified by using C++ STL-like algorithms. Not
4927 all uses of these algorithms are listed below, only the ones where
4928 the change to an algorithm was the only change of interest.
4930 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4932 * algorithm.c: New file.
4934 * algorithm.h: New file.
4936 * modify-vars.c: (static var forward) Removed.
4937 (static var positional) Removed.
4938 (compare_variables) Removed.
4939 (struct ordering) New.
4940 (cmd_modify_vars) Use sort() algorithm.
4941 (compare_variables_given_ordering) New function.
4942 (rearrange_dict) Use sort() algorithm.
4944 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4945 (cmp_var_by_name) Removed.
4947 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4949 Make file handles use a hash table.
4951 * file-handle.q: (files) Change to hash table, make static.
4952 (cmd_file_handle) Use hash table functions.
4953 (fh_get_handle_by_filename) Ditto.
4954 (fh_get_handle_by_name) Ditto.
4955 (hash_file_handle) New function.
4956 (cmp_file_handle) Rewrite.
4957 (fh_init_files) Use hash table functions.
4959 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4961 Clean up FREQUENCIES.
4963 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4965 * frequencies.q: Remove a lot of old #if'd out code at the end.
4966 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4967 or calc_weight(). Initialize percentile_values.
4968 (calc) New function based on calc_weight() from frequencies.g.
4969 (precalc) Use hash functions.
4970 (static var comparison_func) Removed.
4971 (static var comparison_param) Removed.
4972 (comparison_helper) Removed.
4973 (get_freq_comparator) New function.
4974 (not_missing) New function.
4976 (postprocess_freq_tab) Use hash table functions, algorithms,
4977 get_freq_comparator(). Rewrite.
4978 (cleanup_freq_tab) Rephrase.
4979 (add_percentile) Clean up spacing.
4980 (hash_value_numeric) New function.
4981 (hash_value_alpha) New function.
4982 (compare_value_numeric_a) Rewrite.
4983 (compare_value_alpha_a) Rewrite.
4984 (compare_value_numeric_d) Rewrite.
4985 (compare_value_alpha_d) Rewrite.
4986 (compare_freq_numeric_a) Rewrite.
4987 (compare_freq_alpha_a) Rewrite.
4988 (compare_freq_numeric_d) Rewrite.
4989 (compare_freq_alpha_d) Rewrite.
4990 (calc_stats) Clean up mode, percentiles, max.
4991 (dump_statistics) Clean up spacing.
4993 * frequencies.g: Removed.
4995 * var.h: (struct freq_tab) Change `data' to hash table.
4997 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
4999 * file-handle.h: Remove declaration of global variable `files',
5000 which wasn't used anywhere.
5002 * postscript.c: (add_encoding) Remove superfluous cast.
5005 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5008 * temporary.c: [0] (display_tree) Removed.
5010 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5012 Implement a new random number generator based on the alleged RC4
5015 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5018 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5019 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5021 (static var V[]) Removed.
5022 (static var Y) Removed.
5023 (static var X2) Removed.
5024 (setup_randomize) Removed.
5026 (rand_uniform) Removed.
5027 (rand_normal) Removed.
5028 (struct rng) New structure.
5029 (rng_create) New function.
5030 (rng_destroy) New function.
5031 (swap_byte) New static function.
5032 (rng_seed) New function.
5033 (rng_get_bytes) New function.
5034 (rng_get_int) New function.
5035 (rng_get_unsigned) New function.
5036 (rng_get_double) New function.
5037 (rng_get_double_normal) New function.
5038 (pspp_rng) New function.
5040 * random.h: Sync up to random.c.
5042 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5043 fraction of UINT_MAX, not 65536.
5044 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5047 * vfm.c: (open_active_file) No need to call setup_randomize() any
5050 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5052 Change dictionary name indexes to use hash tables instead of AVL
5055 * crosstabs.q: (free_var_dict) Use hash tables.
5056 (crs_custom_tables) Ditto.
5057 (calc_general) Ditto.
5058 (compare_table_entry) Rewrite.
5059 (enum_var_values) Reorder parameters. All references updated.
5062 * get.c: (rename_variable) Use hash tables.
5063 (mtf_merge_dictionary) Ditto.
5065 * glob.c: (init_glob) Use hash tables.
5066 (cmp_variable) Removed.
5068 * means.q: (mns_custom_tables) Use hash tables.
5070 * modify-vars.c: (rearrange_dict) Use hash tables.
5072 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5074 * sfm-read.c: (read_header) Use hash tables.
5075 (read_variables) Ditto.
5077 * temporary.c: (new_dictionary) Use hash tables.
5078 (save_dictionary) Ditto.
5079 (restore_dictionary) Ditto.
5081 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5082 hash table `name_tab'.
5084 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5085 [DEBUGGING] (dump_var_tree) Removed.
5086 (find_variable) Use hash tables.
5087 (find_dict_variable) Ditto.
5088 (common_init_stuff) Ditto.
5089 (rename_variable) Ditto.
5090 (clear_variable) Ditto. Also, remove debug code.
5091 (dup_variable) Use hash tables.
5093 * vars-prs.c: (fill_all_vars) Use hash tables.
5094 (is_dict_varname) Ditto.
5095 (parse_dict_variable) Ditto.
5097 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5099 Change value labels to use hash tables instead of AVL trees, and
5100 change value labels into an ADT.
5102 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5104 * value-labels.c: New file.
5106 * value-labels.h: New file.
5108 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5109 Get rid of a stupid use of goto.
5111 * autorecode.c: (compare_alpha_value) Rewrite.
5112 (hash_alpha_value) Ditto.
5113 (compare_numeric_value) Rewrite.
5114 (hash_numeric_value) Ditto.
5116 * frequencies.q: (dump_full) Use value label ADT.
5118 * pfm-read.c: (read_value_label) Use value label ADT.
5120 * pfm-write.c: (write_value_labels) Use value label ADT.
5122 * sfm-read.c: (read_variables) Use value label ADT.
5123 (read_value_labels) Rewrite.
5125 * sfm-write.c: (write_value_labels) Rewrite.
5127 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5128 (display_variables) Ditto.
5129 (describe_variable) Ditto.
5131 * t-test.q: (print_t_groups) Use value label ADT.
5133 * temporary.c: (copy_variable) Use value label ADT.
5134 (free_dictionary) Ditto.
5136 * val-labs.c: (verify_val_labs) Use value label ADT.
5138 (debug_print) Ditto.
5139 (val_lab_cmp) Removed.
5140 (inc_ref_count) Removed.
5141 (copy_value_labels) Removed.
5143 * var.h: (struct value_label) Removed.
5144 (struct variable) Change AVL tree `val_lab' into hash table
5147 * vars-atr.c: (init_variable) Use value label ADT.
5148 (clear_variable) Ditto.
5149 (free_value_label) Removed.
5150 (free_val_lab) Removed.
5151 (get_val_lab) Removed.
5152 (compare_variables) New function.
5153 (hash_variable) New function.
5155 * vfm.c: (dump_splits) Use value label ADT.
5157 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5159 Add to the hash table interface.
5161 * hash.c: (hsh_hash_bytes) Add assertion.
5162 (hsh_hash_string) Ditto.
5166 (hsh_create) Ditto. Also make minimum `size'.
5167 (hsh_destroy) Rephrase.
5168 (sort_nulls_last) Removed.
5169 (not_null) New function.
5171 (comparison_helper) Ditto.
5172 (hsh_sort) Rewritten.
5173 (hsh_data_copy) New function.
5174 (hsh_sort_copy) Ditto.
5176 (hsh_replace) Ditto.
5177 (hsh_hash_double) Ditto.
5178 (hsh_delete) Fix stupid bug.
5180 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5181 * added a calculation of the mode to FREQUENCIES
5183 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5185 * moved (un)defs of DEBUGGING to config.h
5187 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5189 * groff-font.c: (add_kern) Fix indentation.
5190 (add_kern) Use & instead of % to take power-of-2 modulus.
5191 (font_get_kern_adjust) Likewise.
5193 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5195 * autorecode.c: (recode) Replace stupid use of memcpy() by
5197 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5198 (hash_numeric_value) Ditto.
5199 (autorecode_proc_func) pool_strdup() was wrong here because the
5200 source string was not null-terminated. Use new pool_strndup()
5203 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5204 use of hsh_iterator_init().
5206 * data-in.c: (parse_N) Initialize i->v->f.
5208 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5211 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5212 (groff_read_font) Don't call hsh_next_prime(). Don't call
5214 (static var hash) Remove `size_p', `max_used' members.
5215 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5216 hsh_hash_string() instead of hashpjw(), & instead of %.
5217 (default_font) Don't call hsh_next_prime().
5219 * pool.c: (pool_strndup) New function.
5220 (pool_strdup) Reimplement in terms of pool_strndup.
5222 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5224 (hash_ps_encoding) Use hsh_hash_string().
5225 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5226 (hash_filename2font) Use hsh_hash_string().
5228 * som.c: Add #include <stdlib.h>.
5230 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5231 (by destroying its pool).
5233 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5235 Miscellaneous hash table code cleanup:
5237 * hash.h: (struct hsh_table) Moved into hash.c.
5238 (hsh_count) Ditto, and transformed into function.
5239 (hsh_compare_func) New typedef, used for defining otherwise-long
5240 function types here and in hash.c
5241 (hsh_hash_func) Ditto.
5242 (hsh_free_func) Ditto.
5244 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5245 `table' to `entries'. Removed `mp'. All references updated.
5246 (hsh_clear) Don't shrink entries array; if the hash was this big
5247 once, it probably will be again.
5248 (hsh_rehash) Made static.
5249 (force_hsh_insert) Renamed hsh_force_insert.
5250 (force_hsh_find) Renamed hsh_force_find.
5252 Made hash table sizes powers of 2, because that's fine with any
5253 reasonable hash function and because taking a power-of-2 modulus
5254 is faster than any other:
5256 (hsh_prime_tab) Removed;
5257 (hsh_next_prime) Ditto.
5258 (next_power_of_2) New function.
5259 (hsh_create) Use next_power_of_2.
5260 (hsh_rehash) Use & instead of %.
5262 Cleaned up hsh_sort:
5264 (internal_comparison_fn) Removed.
5265 (sort_nulls_last) New function.
5266 (hsh_sort) Removed second parameter, switched to using the new
5267 quicksort() function from quicksort.h to avoid using nasty need
5268 for static variables with qsort(). All references updated.
5270 Changed the hash functions offered, because there are better hash
5271 functions than the ones we had, and cleaned up the names to boot:
5273 * hash.c: (hashpjw_d) Removed.
5275 (hsh_hash_bytes) New function.
5276 (hsh_hash_string) New function.
5277 (hsh_hash_int) New function.
5279 Improved the hash table iteration interface:
5281 * hash.h: (hsh_iterator_init) Removed.
5282 (struct hsh_iterator) Removed `init' member, change `next' to
5285 * hash.c: (hsh_foreach) Removed. All references updated to use
5286 hsh_first/hsh_next instead.
5287 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5288 not treat a null pointer as an empty hash table.
5289 (hsh_next) New function.
5291 Made deletion possible, though slow:
5293 * hash.c: (locate_matching_entry) New function.
5294 (hsh_find) Use locate_matching_entry().
5295 (hsh_delete) New function also using locate_matching_entry().
5296 (hsh_force_delete) New function.
5298 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5300 * quicksort.c: New file implementing a sort routine with a
5301 interface better than qsort() because it passes a user-provided
5302 parameter to the sort routine.
5304 * Makefile.am: Add quicksort.c, quicksort.h.
5306 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5308 * All source files: Get rid of nasty special cases for Checker,
5309 which is pretty obsolete now.
5311 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5313 * Fixed a bug apparent when using the FREQUENCIES command with the
5314 html driver. The html driver was incorrectly trying to display
5317 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5319 * Makefile.am: Reorganized. Put locale dir in version.c instead
5320 of passing it to each compile command. Only put local gmp libs in
5321 LD_ADD if not installed on system. Remove `boast' target.
5323 * All source files: struct and union typedefs eliminated.
5324 `sizeof type' replaced by `sizeof object' where practical. Moved
5325 `unused' qualifiers from start to end of declarations for gcc
5326 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5327 assertions on pointers strictly compliant. Removed _ prefixes on
5328 some function parameter names.
5330 * alloc.c: New source file, containing these external linkage
5331 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5338 * ascii.c: Migrated from arenas to pools.
5339 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5340 c_string to len_string. All references changed.
5341 (ascii_option) Signature changed to comply to new output.c
5343 (count_fancy_chars) Removed.
5344 (delineate) Removed support for rich text.
5345 (ascii_text_metrics) Ditto.
5347 (output_shorts) Change `box', `off', `on' from c_string to
5348 len_string. Change `remaining' from int to size_t.
5349 (ascii_close_page) Make page numbering less haphazard.
5351 * autorecode.c: Migrate from arenas to pools.
5353 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5355 * bitvector.h: New file containing these macros from misc.h:
5356 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5358 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5359 word[3]. ncmd removed.
5360 (var empty_string) Removed.
5361 (var cmd_table) Declaration updated.
5362 (var cmdtab) Removed.
5363 (cmp_command) Removed.
5364 (split_words) Rewritten to use strtok_r().
5365 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5366 (find_command) Removed.
5367 (FILE_TYPE_okay) Rewritten.
5368 (cmd_parse) Rewritten. Semantics of the return value of command
5369 handlers has changed: they must now return one of the new CMD_*
5370 enumerals, rather than a magic value. This meant that all
5371 commands had to be modified, and they were.
5372 (figure_out_command) New function.
5374 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5375 #defines for INIT, INPU, etc.
5377 * command.h: New CMD_* enum series.
5378 (cur_proc) Make const char *, not char *.
5379 (cmd_init) Prototype.
5382 * common.c: Removed.
5384 * common.h: Removed.
5386 * correlations.q: New file.
5388 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5390 (custom_tables) Renamed crs_custom_tables().
5391 (custom_variables) Renamed crs_custom_variables().
5392 (calc_integer) Add in some `const' qualifiers.
5393 (table_value_missing) Change from a_string to len_string.
5394 (float_M_suffix) Change from a_string to len_string.
5396 * data-in.c: Rewritten. All references to
5397 parse_string_as_format() changed to data_in().
5399 * data-in.h: New file.
5401 * data-list.c: Change DLS_* from #define's to enums. Move from
5402 rpd_msg() to tmsg().
5403 (RPD_ERR) New #define.
5404 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5406 (read_from_data_list_fixed) Change from old
5407 parse_string_as_format() to new data_in().
5408 (read_from_data_list_free) Ditto.
5409 (read_from_data_list_list) Ditto.
5410 (cmd_repeating_data) Modify approach to checking for end of
5413 (rpd_parse_record) Change from old parse_string_as_format() to new
5414 data_in(). Change from old convert_format_to_string() to new
5416 (read_one_set_of_repetitions) Change dfm_push_cust() to
5417 dfm_push(), pop_cust() to dfm_pop().
5419 * data-out.c: Rewritten. All references to
5420 convert_format_to_string() changed to data_out().
5422 * descript.q: Migrate to new q2c.
5423 (cmd_descriptives) Removed.
5424 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5425 (custom_variables) Renamed dsc_custom_variables().
5427 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5429 (open_file_r) Initialize h->where.line_number. Migrate to new
5431 (open_file_w) Initialize h->where.line_number.
5432 (read_record) Change from ext->ln to h->where.line_number.
5433 Migrate to struct string.
5434 (dfm_put_record) Rephrased.
5435 (dfm_push_cust) Renamed dfm_push(), rewritten.
5436 (dfm_pop) New function.
5438 * error.c: All references updated.
5439 (glob var error_count) Renamed err_err_count.
5440 (glob var warning_count) Renamed err_warning_count.
5441 (glob var error_already_flagged) Renamed err_already_flagged.
5442 (glob var verbosity) Renamed err_verbosity.
5443 (glob var cust_fn) Removed.
5444 (glob var cust_ln) Removed.
5445 (static var file_loc) New.
5446 (static var nfile_loc) New.
5447 (static var mfile_loc) New.
5448 (tmsg) New function.
5449 (push_cust) Removed.
5452 (static var terminating) Removed.
5453 (failure) Renamed err_failure().
5454 (hcf) Renamed err_hcf().
5455 (err_push_file_locator) New function.
5456 (err_pop_file_locator) New function.
5457 (err_location) New function.
5458 (check_error_count) Renamed err_check_count().
5459 (vmsg) Renamed err_vmsg(). Interface changed.
5460 (verbose_msg) Removed.
5461 (err_cond_fail) New function.
5462 (error_break) Renamed err_break().
5464 * error.h: All references updated.
5465 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5466 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5468 (struct file_locator) New.
5470 (macro verbose_msg) Removed.
5471 (macro cond_fail) Removed.
5473 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5475 * expr-prs.c: Reorganized. All references updated.
5476 (exprtypename) Renamed expr_type_name().
5477 (typename) Renamed type_name().
5478 (free_expression) Renamed expr_free().
5479 (parse_expression) Renamed expr_parse(). Uses new type_check()
5481 (init_functab) Renamed init_func_tab().
5482 (type_check) New function.
5483 (parse_or) Rewritten to use new allocate_nonterminal() and
5484 append_nonterminal_arg() functions.
5487 (parse_rel) Ditto. Also simplified logic.
5492 (SYSMIS_func) Ditto.
5493 (VALUE_func) Rephrased.
5494 (CONCAT_func) Fix memory leak by replacing free by free_node on
5496 (generic_str_func) Ditto.
5497 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5499 (allocate_nonterminal) New function.
5500 (append_nonterminal_arg) New function.
5501 (static func_tab[]) Now at file level.
5503 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5505 * expr.h: (enum series OP_*) Moved to exprP.h.
5506 (OP_* defines) Ditto.
5507 (struct op_desc) Ditto.
5508 (global ops[]) Ditto.
5509 (struct num_con_node) Ditto.
5510 (struct str_con_node) Ditto.
5511 (struct var_node) Ditto.
5512 (struct lag_node) Ditto.
5513 (struct casenum_node) Ditto.
5514 (struct nonterm_node) Ditto.
5515 (union any_node) Members renamed.
5516 (struct sys_node) Removed.
5517 (struct val_node) Removed.
5518 (operator typedef) Removed.
5519 (typedef exprtype) Removed.
5520 (enum series EX_*) Moved to exprP.h.
5521 (struct expression) Ditto. Also renamed a lot of the members.
5522 (PXP_* defines) Changed to enums.
5523 (free_node prototype) Moved to exprP.h.
5525 * file-handle.h: (struct file_handle) New member `where'.
5527 * file-handle.q: Migrated to new q2c format.
5528 (prepend_current_directory) Removed (dead code).
5529 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5530 (fh_get_handle_by_filename) Removed dead code.
5531 Set new `where' member.
5533 * file-type.c: (file_type_source_read) References to
5534 parse_string_as_format() changed to data_in().
5535 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5537 * filename.c: All references updated.
5538 (init_filename) Renamed fn_init().
5539 (expand_line) Removed.
5540 (macro EXPAND_LINE) Removed.
5541 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5542 of custom functions.
5543 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5544 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5545 (normalize_filename) Renamed fn_normalize().
5546 (search_path) Renamed fn_search_path(), rewritten.
5547 (prepend_dir) Renamed fn_prepend_dir().
5548 (blp_getenv) Renamed fn_getenv().
5549 (blp_dirname) Renamed fn_dirname().
5550 (fn_basename) New function, not used.
5551 (absolute_filename_p) Renamed fn_absolute_p().
5552 (is_special_filename) Renamed fn_special_p().
5553 (file_exists) Renamed fn_exists_p().
5554 (readlink_malloc) Renamed fn_readlink().
5555 (getenv_default) Renamed fn_getenv_default().
5556 (open_file) Renamed fn_open().
5557 (close_file) Renamed fn_close().
5558 (open_file_ext) Renamed fn_open_ext().
5559 (close_file_ext) Renamed fn_close_ext().
5561 * font.h: Migrate from arenas to pools.
5563 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5565 * frequencies.g: Migrate from arenas to pools.
5567 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5570 * getline.c: All references updated.
5571 (global getl_buf) Changed from char * to struct string.
5572 (static getl_include_path) Ditto.
5573 (global getl_buf_len) Removed.
5574 (global getl_buf_size) Removed.
5575 (getl_include_path) Deal with new getl_buf, getl_include_path.
5576 (getl_uninitialize) New function.
5577 (getl_get_current_directory) Rewritten.
5578 (getl_clear_include_path) Rewritten.
5579 (getl_add_include_dir) Rewritten.
5580 (getl_add_file) Assertion fixed.
5581 (getl_add_virtual_file) Change initial value of `remaining_loops'
5583 (welcome) Rewritten.
5584 (handle_line_buffer) Make static. Change logic to make
5585 getl_add_virtual_file() change sensible. Use ds_*() strings.
5586 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5587 (getl_close_file) Moved.
5588 (getl_location) New function.
5590 * getline.h: All references updated.
5591 (macro curln) Removed.
5592 (macro curfn) Removed.
5593 (macro am_interactive) Renamed getl_am_interactive.
5594 (macro am_reading_script) Renamed getl_reading_script.
5596 * glob.c: (global fmt_parse_ignore_error) Removed.
5597 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5598 systems that support it (C99). Turn off SET ECHO by default. No
5599 necessary julcal initialization anymore.
5601 * groff-font.c: Migrate from arenas to pools.
5602 (groff_read_font) Use err_push_file_locator().
5603 (groff_read_DESC) Ditto.
5604 (font_msg) Use tmsg().
5606 * hash.c: (hsh_sort) Fix debug code.
5607 [GLOBAL_DEBUGGING] Include stdio.h.
5609 * hash.h: (macro force_hsh_insert) Rephrase.
5611 * heap.c: Rewritten.
5613 * heap.h: Rewritten.
5615 * html.c: (html_option) Change from outp_value to struct string.
5616 (postopen) Change from curfn to getl_location().
5617 (escape_string) Remove rich-text code. Signature changed.
5618 (output_tab_table) Switch from a_string to struct len_string.
5619 Remove rich text support.
5621 * lexer.c: All references updated. Largely rewritten. Major
5622 changes listed below. Removed tagged quote support. Adapted to
5623 struct string tokstr.
5624 (global tokstr) Changed to struct string.
5625 (global tokstr_size) Removed.
5626 (global tokstr_len) Removed.
5628 (global tokint) Removed.
5629 (global toklongstr) Removed.
5630 (C* defines) Removed.
5631 (static tbl[]) Removed.
5632 (static id[]) Removed.
5633 (static une[]) Removed.
5634 (discard_line) Renamed lex_discard_line().
5635 (get_entire_line) Renamed lex_entire_line().
5636 (get_rest_of_line) Renamed lex_rest_of_line().
5637 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5638 (make_hexit) Removed.
5639 (syntax_error) Renamed lex_error(). Return value removed.
5640 (get_token_representation) Renamed lex_token_representation().
5641 (putback) Renamed lex_put_back().
5642 (putfwd) Renamed lex_put_forward().
5643 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5644 (set_prog) Renamed lex_set_prog().
5645 (init_lex) Renamed lex_init().
5646 (reset_eof) Renamed lex_reset_eof().
5647 (lookahead) Renamed lex_look_ahead().
5648 (check_id) Rewritten.
5649 (yylex) Renamed lex_get(), rewritten.
5650 (lex_end_of_command) New function. Many commands were rephrased
5652 (lex_integer_p) New function. Replaces compare of tokint against
5654 (lex_integer) New function. Replaces tokint.
5655 (match_tok) Renamed lex_match().
5656 (match_id) Renamed lex_match_id().
5657 (match_int) Renamed lex_match_int().
5658 (force_match_id) Renamed lex_force_match_id(), added return value.
5659 (force_match) Renamed lex_force_match(), added return value.
5660 (force_string) Renamed lex_force_string(), added return value.
5661 (force_int) Renamed lex_force_int(), added return value.
5662 (lex_id_match_len) New function.
5663 (id_match) Renamed lex_id_match(), rewritten.
5664 (get_line) Renamed lex_get_line().
5665 (preprocess_line) Renamed lex_preprocess_line().
5666 (tokname) Renamed lex_token_name().
5667 (bin_value_func) Removed.
5668 (oct_value_func) Removed.
5669 (hex_value_func) Removed.
5670 (unexpected_eof) New function.
5671 (convert_numeric_string_to_char_string) New function.
5672 (parse_string) Rewritten, signature changed.
5673 (add_tokstr_char) Removed.
5674 (add_tokstr_unsigned) Removed.
5675 (add_tokstr_string) Removed.
5676 (parse_tagged_quote) Removed.
5677 (skip_comment) Renamed lex_skip_comment().
5679 * lexer.h: All references updated.
5680 (macro is_id1) Renamed CHAR_IS_ID1.
5681 (macro is_idn) Renamed CHAR_IS_IDN.
5682 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5683 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5684 (macro get_token) Removed.
5685 (macro id_match) Removed.
5686 (macro force_match_id) Removed.
5687 (macro force_match) Removed.
5688 (macro force_string) Removed.
5689 (macro force_int) Removed.
5690 (macro force_num) Removed.
5691 (macro force_id) Removed.
5693 * lexerP.h: Removed.
5695 * list.q: Migrated to new q2c format.
5696 (write_line) Deal with struct len_string.
5697 (write_varname) Ditto.
5698 (write_fallback_headers) Ditto.
5700 * magic.c: New file, incorporating the following global variables
5701 previously in other files: endian, second_lowest_value. And both
5702 of those are conditional on #define's.
5704 * magic.h: New file, incorporating the following global variable
5705 declarations: endian, second_lowest_value, and the following macro
5706 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5708 * main.c: Added declarations of pgmname, finished, curdate,
5710 (main) Call new parse_script() function.
5711 (parse_script) New function.
5712 (execute_command) New function.
5713 (dump_token) Removed.
5714 (handle_error) New function.
5716 * matrix.c: New file.
5718 * matrix.h: New file.
5720 * matrix-data.c: Migrated from arenas to pools.
5721 (mget_token) Change from parse_string_as_format() to data_in().
5723 * means.q: Migrate to new q2c.
5724 (custom_tables) Renamed mns_custom_tables().
5725 (custom_crossbreak) Renamed mns_custom_crossbreak().
5726 (custom_variables) Renamed mns_custom_variables().
5728 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5729 (parse_varnames) Prototype.
5730 (parse_numeric) Rephrasings.
5731 (parse_alpha) Adapt to new struct string tokstr.
5733 * misc.c: (intlog10) Rewritten.
5735 (ansi_rand) Renamed real_rand(), moved into random.c.
5736 (ansi_srand) Renamed real_srand(), moved into random.c.
5737 (setup_randomize) Moved to random.c.
5738 (rand_uniform) Ditto.
5739 (rand_normal) Ditto.
5740 (rand_simple) Ditto.
5741 (get_config_line) Removed.
5742 (reverse) Removed (dead code).
5744 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5745 (macro CLEAR_BIT) Ditto.
5746 (macro TEST_BIT) Ditto.
5747 (macro SET_BIT_TO) Ditto.
5748 (macro BIT_INDEX) Ditto.
5750 * output.c: (outp_read_devices) Move to err_push_file_locator()
5751 from push_cust(). Use struct string.
5752 (expand_op_tokstr) Removed.
5753 (static var op_tokstr) Changed to struct string.
5754 (static var op_tokstr_size) Removed.
5755 (tokener) Rephrasings. Use struct string.
5756 (parse_options) Use struct string.
5757 (destroy_driver) Fix assertion.
5758 (outp_get_paper_size) Move to err_push_file_locator().
5759 [0] Removed dead code.
5760 (outp_string_width) Move to len_string.
5762 * output.h: Comment fixes.
5763 (TAG_* enum series) Removed.
5764 (struct outp_value) Removed.
5765 (enum OUTP_T_FANCY) Removed.
5766 (struct outp_text) `s' changed from a_string to len_string.
5767 (struct outp_class) `option' change arg 3 from outp_value to
5770 * pfm-read.c: (corrupt_msg) Rewritten.
5772 * pfm-write.c: (bufwrite) Fix assertion.
5774 * pool.c: New file, reference version.
5776 * pool.h: New file, reference version.
5778 * postscript.c: (ps_font_sizes) Fix assertion.
5779 (ps_option) Change arg 3 from outp_value to struct string.
5780 Adapt to struct string.
5781 (macro output_line) Removed.
5782 (macro add_string) Removed.
5783 (output_encodings) Adapted to struct string. Moved to
5784 err_push_file_locator().
5785 (find_encoding_file) Fix assertion.
5786 (read_ps_encodings) Move to err_push_file_locator().
5787 (postopen) Use getl_location() instead of curfn.
5788 (out_text_plain) Move to len_string.
5789 (text) Ditto. Remove rich text support.
5791 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5792 (cmd_print_eject) Ditto.
5794 (internal_cmd_print) Now cleans up after itself. Uses
5795 fh_parse_file_handle() now.
5796 (cmd_print_space) Use PXP_NUMERIC to type-check.
5798 * q2c.c: Overhauled. Removed _("") i18n support. All references
5799 updated. All output functions updated to handle structures rather
5800 than local or static variables. Adapt to new PSPP lex_*()
5804 (macro MAX_N_SBC) Removed.
5805 (global bare) Removed.
5806 (enum STRING) Renamed T_STRING.
5807 (enum ID) Renamed T_ID.
5808 (get_buffer) Buffer size increased.
5809 (strlower) Renamed st_lower(), rephrased.
5810 (strupper) Renamed st_upper(), rephrased.
5811 (skip_ws) New function.
5812 (get_line) Don't special-case any types of lines (like those
5813 beginning with ! or $, for instance).
5814 (get_token) Renamed lex_get(). Rephrased.
5815 (static var `prefix') New.
5816 (parse) New function.
5817 (parse_setting) Minor rephrasing.
5818 (dump_specifier_vars) Ditto.
5819 (make_identifier) Put null terminator on identifier, duh.
5820 (dump_vars) Renamed dump_declarations(). Never indent. Never
5821 static. Output changed entirely.
5822 (dump_specifier_init) Rephrase.
5823 (dump_vars_init) No index variable needed. Other modifications.
5824 (dump_parser) Don't parse command name. Do dump functions instead
5825 of just code fragments.
5826 (dump_free) Dump function instead of code fragment.
5827 (recognize_directive) New function.
5828 (main) Use recognize_directive(). Don't rely on magic $ line
5829 beginning: instead, parse comments. Update list of headers.
5831 * random.c: New file, containing the following functions:
5832 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5833 rand_normal, rand_simple.
5835 * random.h: New file.
5837 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5838 function. `max_src_width', `max_dst_width' changed to size_t.
5839 (internal_cmd_recode) Removed.
5840 (parse_dest_spec) Merge similar cases.
5841 (parse_src_spec) Add assertion.
5843 * repeat.c: (recognize_keyword) New function.
5844 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5845 REPEAT. Improve recognition of END REPEAT (use
5846 recognize_keyword()). Move from curfn to getl_location(). Use
5849 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5851 * set.q: Adapt to new q2c.
5852 (cmd_set) Range-check some values better.
5853 (custom_blanks) Renamed stc_custom_blanks().
5854 (custom_length) Renamed stc_custom_length().
5855 (custom_results) Renamed stc_custom_results().
5856 (custom_seed) Renamed stc_custom_seed().
5857 (custom_width) Renamed stc_custom_width().
5858 (custom_format) Renamed stc_custom_format().
5859 (custom_journal) Renamed stc_custom_journal().
5860 (custom_color) Renamed stc_custom_color().
5861 (custom_listing) Renamed stc_custom_listing().
5862 (custom_disk) Renamed stc_custom_disk().
5863 (custom_log) Renamed stc_custom_log().
5864 (custom_rcolor) Renamed stc_custom_rcolor().
5865 (custom_viewlength) Renamed stc_custom_viewlength().
5866 (custom_workdev) Renamed stc_custom_workdev().
5868 * settings.h: Not necessary to include format.h any longer.
5870 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5871 (corrupt_msg) Rewritten.
5873 * sort.c: Adapt to rewritten heap ADT.
5875 * str.c: (aa_strcpy) Removed.
5876 (ab_strcpy) Removed.
5877 (ac_strcpy) Removed.
5878 (ba_strcpy) Removed.
5879 (bb_strcpy) Removed.
5880 (ca_strcpy) Removed.
5881 (aa_strdup) Removed.
5882 (aa_strdupcpy) Removed.
5883 (ba_strdup) Removed.
5884 (sa_strdup) Removed.
5885 (memrev) Renamed mm_reverse().
5886 (memrmem) Renamed mm_find_reverse().
5887 (cmp_str) Renamed st_compare_pad().
5888 (strmaxcpy) Removed.
5889 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5890 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5892 (strpadcpy) Renamed st_pad_copy(), signature changed.
5893 (blpstrset) Removed.
5894 (ds_create) New function.
5895 (ds_init) New function.
5896 (ds_replace) New function.
5897 (ds_destroy) New function.
5898 (ds_clear) New function.
5899 (ds_extend) New function.
5900 (ds_shrink) New function.
5901 (ds_truncate) New function.
5902 (ds_length) New function.
5903 (ds_size) New function.
5904 (ds_value) New function.
5905 (ds_end) New function.
5906 (ds_concat) New function.
5907 (ds_concat_buffer) New function.
5908 (ds_printf) New function.
5909 (ds_putchar) New function.
5910 (ds_getline) New function.
5911 (ds_get_config_line) New function derived from the old
5912 misc.c:get_config_line().
5913 (ls_create) New function.
5914 (ls_create_buffer) New function.
5915 (ls_init) New function.
5916 (ls_shallow_copy) New function.
5917 (ls_destroy) New function.
5918 (ls_null) New function.
5919 (ls_null_p) New function.
5920 (ls_empty_p) New function.
5921 (ls_length) New function.
5922 (ls_value) New function.
5923 (ls_end) New function.
5925 * str.h: Reformatted.
5926 (struct a_string) Removed.
5927 (struct b_string) Removed.
5928 (struct c_string) Removed.
5929 (struct len_string) New.
5930 (struct string) New.
5931 (macro as_streq) Removed.
5932 (macro bs_streq) Removed.
5933 (macro cs_streq) Removed.
5934 (macro sa_streq) Removed.
5935 (macro sb_streq) Removed.
5936 [__GNUC__] (inline function ds_putchar) New function.
5937 [__GNUC__] (inline function ds_length) New function.
5938 [__GNUC__] (inline function ds_value) New function.
5939 [__GNUC__] (inline function ds_end) New function.
5941 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5942 (display_vectors) Fix missing i18n.
5944 * t-test.q: Migrate to new q2c.
5946 * tab.c: Migrate from arenas to pools.
5947 (tab_create) Use struct len_string.
5948 (tab_realloc) Ditto.
5949 (text_format) Ditto.
5950 (tab_joint_text) Ditto.
5951 (tab_natural_width) Remove rich text support.
5952 (tab_natural_height) Ditto.
5953 (tab_output_text) Handle TAT_FIX.
5954 (tab_raw) Change arg from a_string to len_string.
5955 (tabi_driver) Fix assertion. Use struct len_string.
5956 (render_strip) Use struct len_string. Remove rich text support.
5957 Add `const' qualifiers.
5959 * tab.h: (enum TAB_RICH) Remove.
5960 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5961 SOM_COL_* updated to read TAB_COL_*.
5962 (struct tab_table) Change arena to pool. Change a_string to
5965 * temporary.c: (restore_dictionary) Rewrite Checker code.
5967 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5968 LOWEST, HIGHEST) Moved here from common.h.
5969 (typedef any_trns) Removed. All references changed to `struct
5972 * vars-atr.c: (force_create_variable) Fix assertion.
5973 (force_dup_variable) Fix assertion.
5975 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5977 Using alphanumeric variables in functions under AGGREGATE
5978 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
5979 <BZN-mdksh@t-online.de> for reporting this bug.
5981 * aggregate.c: (parse_aggregate_functions) When setting the
5982 FSTRING bit, also allocate memory for the `string' member of
5984 (free_aggregate_functions) Free iter->string. Don't use the
5985 non-function bits when indexing the array of functions.
5986 [DEBUGGING] (debug_print) Don't use the non-function bits when
5987 indexing the array of functions.
5989 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
5991 Under certain circumstances, the final case would be omitted from
5992 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
5993 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5995 * aggregate.c (agr_00x_end_func): Increment number of cases in
5996 sink before writing case. For streams that keep track of how many
5997 cases there are based on this value, this means that the last case
5998 will be read in on the next stream read.
6000 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6002 Undefined behavior was invoked by referencing a freed pointer.
6004 * vfm.c (memory_stream_write): Free pointer *after* checking for
6007 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6009 A wrong record size was displayed when paging the active file to
6012 * vfm.c: (memory_stream_write) Fix off-by-one error.
6014 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6016 Not having enough temporary space for sorting caused a core dump.
6019 * sort.c: (allocate_cases) Initialize i.
6021 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6023 Syntax errors in function descriptions on AGGREGATE caused core
6026 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6027 free_aggregate_functions(), since that function already frees
6030 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6032 A null pointer was dereferenced, causing a core dump, when
6033 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6034 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6035 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6037 * arena.c: (arena_malloc) If the arena hasn't been initialized
6038 already, initialize it.
6040 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6042 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6043 for compilation with Cygnus Windows B20. Not used by other
6046 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6048 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6049 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6051 * sort.c: (compare_case_lists) Reverse sense of comparison if
6052 sorting in descending order.
6053 (compare_record) Ditto.
6055 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6057 SPLIT FILE with a string variable caused a core dump. Fixed.
6059 * vfm.c: If the variable is a string then make a temporary value
6060 struct pointing to it. The underlying problem is a lot bigger
6061 than this (see TODO) but this is a stopgap for the simple case at
6064 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6066 Nested INCLUDEs didn't work. Fixed.
6068 * getline.c: (getl_include) Set first_line to NULL in allocated
6071 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6073 The MATCH FILES procedure set the values of variables not present
6074 to 0. It should have been SYSMIS. This is now fixed.
6076 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6078 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6080 The REMARK command was too aggressive about skipping lines. It
6081 didn't like being the last command in a file.
6083 * command.c: (cmd_remark) Call get_entire_line() instead of
6086 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6088 Comment parsing wasn't consistent with the rest of the code in its
6089 idea of where one command ends and another starts. This meant
6090 that sometimes commands would be mysteriously ignored. Thanks to
6091 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6093 * command.c: (parse_cmd) Hand off comment parsing to new function
6094 skip_comment() in lexer.c.
6095 * lexer.c: (skip_comment) New function.
6097 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6099 The TABLE subcommand on MATCH FILES worked only erratically at
6100 best. This fixes it. Thanks to Dr. Dirk Melcher
6101 <BZN-mdksh@t-online.de> for reporting this bug.
6103 * get.c: (mtf_compare_BY_values) When comparing string values, a
6104 difference of 1 is still a difference :-)
6105 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6106 advance TABLE files automatically when matched. Comment fixes.
6108 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6110 VARIABLE LABELS rejected a slash before the first variable
6111 specification, contradicting the documentation. Thanks to Walter
6112 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6114 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6115 command specification.
6117 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6119 Because of an incorrect optimization in memory allocation,
6120 CROSSTABS sometimes segfaulted when asked to output multiple
6121 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6124 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6125 are passed to output_pivot_table() for its use.
6126 (output_pivot_table) Instead of assuming the number of columns is
6127 constant, keep track with maxcols. In general mode, use maxcells
6128 to determine whether more matrix cells need to be allocated.
6130 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6132 CROSSTABS didn't display value labels for column and row
6133 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6136 * crosstabs.q: (table_value_missing) If the specified value has a
6137 value label for this variable, then show it instead of the raw
6139 (display_dimensions) Delegate display of value_labels to
6140 table_value_missing.
6142 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6144 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6145 <BZN-mdksh@t-online.de> for reporting this bug.
6147 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6148 if the file isn't declared as binary.
6150 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6152 MATCH FILES corrupted memory and dumped core on some syntax
6155 * get.c: (cmd_match_files) Set file->handle to NULL before
6157 (mtf_free_file) Don't free a null dictionary.
6159 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6161 MATCH FILES should set numeric values not available to the
6162 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6163 <BZN-mdksh@t-online.de> for reporting this bug.
6165 * get.c: (mtf_processing) Set unused records to system-missing,
6168 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6170 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6171 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6173 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6174 in newly created dictionary, and add each copied variable to the
6177 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6181 * get.c: (trim_dictionary) Free variable list for KEEP after
6184 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6186 Some systems didn't like the way open_file was coded. Thanks to
6187 Hankin <hankin@rogue.consultco.com> for pointing this out.
6189 * filename.c: (open_file) Don't try to store stdin, stdout,
6190 stderr as part of an array, because that doesn't always work.
6192 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6194 The SAVE procedure didn't save long string variables properly.
6195 Fixed by this patch. Thanks to Hankin
6196 <hankin@rogue.consultco.com> for this patch.
6198 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6199 out variable pad records.
6201 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6203 Previously, if PRINT SPACE were given a negative argument, it
6204 would report an error, then spin in an (almost) infinite loop.
6205 This fixes that behavior.
6207 * print.c: (print_space_trns_proc) After reporting a negative
6208 argument, set number of lines to print to 1.
6210 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6212 SPSS 8.0 outputs some new record types in its system files, and it
6213 allows longer value labels. Accept these system files.
6215 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6216 11 emitted by SPSS 8.0.
6218 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6220 The LIST procedure was too conservative in allocating space for
6221 buffers, which caused a bug that only showed up with very long
6222 output variables. Thanks to Hankin <hankin@dunno.com> for this
6225 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6227 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6229 Typo meant string format specifiers weren't checked properly. I
6230 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6231 willing to be corrected on this point.
6233 * format.c: (check_string_specifier) Fix obvious typo.
6235 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6237 Using $CASENUM in an expression didn't work. Here's a fix.
6238 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6241 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6243 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6245 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6247 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6248 other behavior, *sigh*. This patch hopefully fixes that. This
6249 time I've actually tested it.
6251 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6253 * data-list.c: (read_from_data_list_free,
6254 read_from_data_list_list) Call parse_string_as_format() directly
6255 without mucking around with the field width.
6257 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6259 Occasionally, you may encounter a script that wants to be
6260 interpreted in interactive mode. Make -i emulate this behavior to
6261 allow such scripts to be executed with PSPP.
6263 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6265 * cmdline.c: (pre_syntax_message[]) Update -i description.
6267 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6268 when -i is given on the command line) don't treat unindented lines
6269 as starting a new command.
6271 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6273 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6274 mostly caused by local initialized aggregates. After egcs is
6275 fixed upstream these can be removed, but for now they're not a big
6278 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6279 initialized arrays. Avoid this.
6281 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6284 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6286 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6287 following changes avoid. Currently I compile sources with egcs
6288 1.1.1 and gcc 2.7.2.3 before sending them out.
6290 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6292 * ascii.c: (option_tab[]) Initialize all struct members.
6294 * avl.h: (avl_traverser_init) New macro.
6296 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6299 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6302 * hash.c: Comment fix.
6304 * hash.h: (hsh_iterator_init) New macro.
6306 * html.c: (option_tab[]) Initialize all struct members.
6308 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6311 * postscript.c: (option_tab[]) Initialize all struct members.
6312 (output_encodings, preclose, dump_lines) Use new
6313 hsh_iterator_init() macro.
6315 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6318 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6321 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6323 * data-in.c: Examined each of the parsing functions to make sure
6324 that they wouldn't dump core if they were passed a string of the
6325 wrong length, since now the DATA LIST FREE/LIST routines don't
6326 check for field width before passing it to the data parser.
6327 (parse_RBHEX, parse_AHEX) Reject odd length input.
6328 (parse_string_as_format) Reject input that's too short or too
6331 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6332 a field to its entire declared output width then pass it to the
6333 data-in parsing routines. This contradicted the documented
6334 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6335 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6336 free-format parsing that differed from SPSS.
6337 (cut_field) Commas and spaces are treated identically. Returns
6338 the proper column instead of a fixed 1 value.
6339 (parse_field) Removed.
6340 (read_from_data_list_free, read_from_data_list_list) Call
6341 parse_string_as_format directly instead of parse_field.
6343 * heap.c: (heap_delete) Stylistic fixes.
6345 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6347 * loop.c: (loop_2_trns_proc) Formatting fix.
6349 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6351 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6353 * vfm.c: (macro FILTERED) New.
6354 (static var filter_var) New.
6355 (process_active_file_write_case) Use FILTERED.
6356 (setup_filter) Set filter_var.
6357 (close_active_file) Delete the filter if not
6358 FILTER_before_TEMPORARY.
6359 (procedure_write_case) Use FILTERED.
6361 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6363 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6365 * data-in.c: (parse_day_count) Message fix.
6366 (parse_month) Style fix.
6368 * data-list.c: (struct data_list_pgm) New member eof.
6369 (cmd_data_list) Init eof to 0.
6370 (do_reading) Implement the /END subcommand and read-past-eof
6373 * do-if.c: Include stdio.h when debugging.
6374 (cmd_else_if) Make sure the command is .-terminated.
6376 * glob.c: (init_glob) Capitalize the command prompt.
6378 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6379 (end_file_trns_proc) Debugging message.
6381 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6383 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6385 * main.c: (dump_token) Make kwtab[] const.
6387 * set.q: Spelling, comment fixes.
6389 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6392 * vars-prs.c: (fill_all_vars) Style fix.
6394 * vfm.c: (index_to_varname) Return const.
6396 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6398 * Changes in many source files for partial -ansi -pedantic and
6399 no-debugging compliance: Remove trailing common in enum
6400 declarations; add `unused' attributes; insert some appropriate
6403 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6405 * command.c: (shell) Make static.
6406 (run_command) Make static.
6408 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6410 * dfm.c: (cmd_begin_data) I18n fix.
6412 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6414 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6416 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6419 * file-handle.q: Don't prepend the source file directory name to
6420 the data file name. (Ongoing issue.)
6421 (prepend_current_directory) Comment out.
6422 (internal_cmd_file_handle) Don't call prepend_current_directory().
6423 (fh_get_handle_by_filename) Ditto.
6425 * filename.c: Append zero byte to readlink() return value.
6427 * getline.c: (getl_read_line) I18n fix.
6429 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6431 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6433 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6436 * postscript.c: (output_encodings) Don't use local_strdup().
6439 * print.c: Don't use gcc features if __STRICT_ANSI__.
6441 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6443 * recode.c: (parse_src_spec) Fully brace nested if's.
6445 * set.q: (global var set_testing_mode) New var.
6447 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6449 * ascii.c: Add some more `unused' attributes that only come into
6450 play when NDEBUG is defined.
6451 (ascii_close_page) Set s_len when reallocating s.
6453 * crosstabs.q: (delete_missing) New function.
6454 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6455 (make_summary_table) Create summary table reallocable.
6457 * postscript.c: Add more `unused' attributes as above.
6459 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6460 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6462 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6465 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6466 gratuitous space between parameter definition.
6468 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6469 complaints about running off the end of functions with NDEBUG
6472 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6474 * Several source files: Removed some PORTME notes when reflection
6475 revealed that ANSI forbids that sort of breakage. Also, added
6476 lots of `unused' qualifiers here and there.
6478 * aggregate.c: (accumulate_aggregate_info) Remove local var
6479 weighting that turned out not to be used.
6481 * avl.c: Update to version 1.1.0. Add unused specifier.
6482 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6484 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6485 (avl_find) Cast return value to void *.
6486 (avl_delete) q doesn't need to be initialized at the beginning of
6487 the function. Replace some instances of 1 with +1.
6488 (force_avl_delete) Renamed avl_force_delete, all references changed.
6489 (compare_ints) `param' marked unused.
6490 (print_int) `param' marked unused.
6491 (recurse_tree) Replace some instances of 1 with +1.
6493 * avl.h: Update to version 1.1.0. Only declares avl function
6494 types if not already declared.
6495 (AVL_MAX_HEIGHT) Only define if not already defined.
6496 (struct avl_node) New unused member char pad[2].
6497 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6498 (force_avl_insert) Renamed avl_force_insert.
6499 (force_avl_delete) Renamed avl_force_delete.
6501 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6503 (struct crosstab) Add new member `ofs'.
6504 (glob var int_tab) Removed.
6505 (custom_tables) In integer mode, assign v[i] properly through the
6507 (custom_variables) Now p.crs.max == max + 1.
6508 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6509 (precalc) Implement integer mode.
6510 (calc_integer) Implement integer mode.
6511 (compare_table_entry) Remove unused local variable `comparing'.
6512 (make_summary_table) Implement integer mode.
6513 (macro ns_rows) Implemented as static variable now.
6514 (several variables) Made static, from global.
6515 (output_pivot_table) Use table_value_missing() for column heads.
6516 Remove several unused local variables. Implement integer mode
6517 table summing. Count up ns_rows.
6518 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6519 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6520 calls that function or find_pivot_extent_integer.
6521 (find_pivot_extent_integer) New function.
6522 (enum_var_values) Implemented for integer mode.
6523 (table_value_missing) New function.
6524 (display_dimensions) Call table_value_missing() for heads.
6525 (float_M_suffix) New function.
6526 (display_crosstabulation) Call table_value_missing() for row
6527 heads. Handle missing values in /MISSING=REPORT mode.
6528 (calc_fisher) Remove unused var N.
6529 (calc_r) Remove unused var fact.
6531 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6532 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6534 * data-out.c: (insert_commas) Remove unused var cp.
6535 (convert_CCx) Remove unused vars save_set_decimal,
6538 * descript.q: (dump_z_table) Fix table dimensioning.
6539 (pre_calc) Remove unused var j.
6540 (display) Remove unused vars title, s. Fix table dimensioning.
6542 * expr-evl.c: Comment fixes.
6544 * frequencies.q: (full_dim) New function.
6545 (dump_full) Fix table dimensioning.
6546 (condensed_dim) New function.
6547 (dump_condensed) Fix table dimensioning.
6549 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6552 * html.c: (html_close_drive) Remove unused var i.
6553 (postopen) Remove unused vars title, curfn_len, cp.
6554 (preclose) Remove unused vars this, x.
6556 * lexer.c: Comment fixes.
6558 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6560 * means.q: (custom_tables) Remove unused var m_dim.
6562 * mis-val.c: Format fix.
6564 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6566 * output.c: (outp_get_paper_size) Remove unused var cp.
6568 * pfm-read.c: (read_float) Remove unused var save, unused label
6570 (read_variables) Remove unused vars cp, j.
6571 (read_value_label) Remove unused var j.
6573 * pfm-write.c: (bufwrite) Remove unused var i.
6575 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6577 (output_encodings) Remove unused vars char_cp, n_output.
6578 (read_ps_encodings) Remove unused var ep.
6579 (postopen) Remove unused var title.
6580 (preclose) Remove unused var fp.
6581 (ps_open_page) Remove unused vars true, false, orientation,
6582 mirror_horz, mirror_vert, width, length.
6583 (ps_text_metrics) Remove unused var x.
6585 * q2c.c: (find_symbol) Remove unused var y.
6586 (parse_setting) Remove unused parameter sbc, all references
6588 (dump_parser) Remove unused var cp.
6589 (dump_free) Remove unused var i.
6591 * set.q: (static vars args, n) Removed.
6592 (internal_cmd_gset) Removed.
6594 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6595 (read_machine_flt64_info) Removed unused var file_endian.
6596 (read_documents) Removed unused var i.
6597 (read_compressed_data) Removed unused parameter dict, all
6600 * sfm-write.c: (bufwrite) Removed unused var i.
6601 (sfm_write_case) Removed unused var i.
6603 * sort.c: (merge_once) Remove unused var t.
6604 (write_separate) #if 0 out as dead code.
6606 * split-file.c: (cmd_split_file) Remove unused var i.
6608 * sysfile-info.c: (sysfile_info_dim) New function.
6609 (cmd_sysfile_info) Fix table dimensioning.
6610 (variables_dim) New function.
6611 (display_variables) Fix table dimensioning.
6612 (describe_variable) Remove unused var prev_r.
6614 * t-test.q: (z_postcalc) Removed.
6615 (pairs_calc) Remove unused var bad_weight.
6616 (postcalc) Remove unused vars dfn, dfd.
6618 * tab.c: (tab_create) Set t->dim to NULL.
6619 (tab_dim) Make sure t->dim is NULL first.
6620 (tab_natural_width) Remove parameter `clamp'.
6621 (tab_value) Remove duplicate assertion for table.
6622 (tab_raw) New function.
6623 (nowrap_dim) New function.
6624 (wrap_dim) New function.
6625 (tab_output_text) Fix table dimensioning.
6627 * tab.h: (tab_raw) New macro.
6629 * val-labs.c: (get_label) Remove unused var type.
6630 (copy_value_labels) Remove unused var trav.
6632 * var.h: (struct crosstab_proc) Completely changed.
6634 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6636 * vfm.c: (open_active_file) Remove unused vars i, lp.
6638 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6640 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6642 * Makefile.am: Add apply-dict.c, flip.c.
6644 * apply-dict.c: New file.
6646 * command.c: (struct command) Make cmd[] larger for CLEAR
6647 TRANSFORMATIONS command name.
6648 (parse_cmd) Make sure we're in a valid state before using it as an
6649 index. Discard variables and reset state on invalid transitions.
6650 (cmd_clear_transformations) New function.
6652 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6653 Add unimplemented PRESERVE, RESTORE.
6655 * file-handle.h: Include stddef.h.
6659 * pfm-read.c: (parse_value) Pad value label values with spaces,
6662 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6663 (sfm_close) Decrement reference count, make sure it's zero.
6664 (sfm_maybe_close) New function.
6665 (sfm_read_dictionary) Handle reference counts.
6667 * vars-atr.c: (clear_default_dict) New function.
6668 (discard_variables) Use clear_default_dict().
6670 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6672 * Makefile.am: Add pfm-write.c.
6673 (LDADD) Add the libgmp2 libraries.
6675 * command.def: Define EXPORT.
6677 * get.c: (cmd_export) New function.
6678 (export_write_case_func) New function.
6680 * pfm-read.c: (static spss2ascii[]) Make it const.
6682 * pfm-write.c: New file.
6684 * sfm-write.c: Formatting, comment fixes.
6686 * var.h: Comment fix.
6688 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6690 * Makefile.am: Add pfm.h, pfm-read.c.
6692 * command.def: IMPORT is now implemented.
6694 * format.c: (glob var translate_fmt[]) New var.
6696 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6697 (cmd_import) New function.
6698 (import_source_read) New function.
6699 (glob var import_source) New var.
6701 * pfm-read.c: New file.
6705 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6707 (dump_dictionary) Disabled printing a couple of items.
6709 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6711 * crosstabs.q: (postcalc) Call make_summary_table().
6712 (make_summary_table) New function.
6713 (insert_summary) New function.
6714 (display_dimensions) Remove some unnecessary arguments, all
6716 (output_pivot_table) Fix lots of problems with the risk table
6718 (submit) Don't display an empty table.
6719 (display_risk) Fix order of arguments to calc_risk().
6721 * glob.c: Always include assert.h and stdlib.h.
6723 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6726 * tab.c: (tab_create) Cosmetic changes.
6728 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6730 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6734 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6735 code simplified, moved into new function submit().
6736 (submit) New function.
6737 (crosstabs_dim) New function.
6738 (display_directional) Substitute variable names for %s where
6740 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6741 (calc_symmetric) Initialize parameters only if non-NULL.
6742 Calculate Somers' d.
6743 (calc_directional) Calculate Somers' d (or copy it, really).
6746 * output.c: (outp_string_width) New function.
6748 * postscript.c: (postopen) Calculate font widths based on the
6749 width of the zero '0' character, not the width of the space
6750 character. Set paper-width and paper-length based on points, not
6752 (ps_open_page) Fix page setup string for landscape mode.
6754 * som.h: (struct som_dimension) Removed.
6755 (struct som_table_class) height, width members take int * not
6758 * tab.c: Many functions now have added parameter validation.
6759 (tab_height, tab_width) These functions were removed and merged
6760 into a single function tab_resize(), and all references changed.
6761 (tab_dim) Rewritten since the interface changed; reduced from
6762 hundreds of lines to two. All callers were changed. Currently
6763 most of them just use tab_natural_dimensions as their callback and
6764 await detailed translation of functionality.
6765 (tab_natural_width) New function.
6766 (tab_natural_height) New function.
6767 (tab_natural_dimensions) New function. This is a callback
6768 function, not something that you'd want to call directly.
6769 (tab_nat_dim) Removed.
6770 (tabi_table) Allocates t->w and t->h.
6771 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6772 dimensions callback.
6773 (evaluate_dimensions) Removed.
6774 (sum_columns) Removed.
6776 * tab.h: (enum TAL_1THIN) Removed.
6777 (enum series t_*) Removed.
6778 (struct tab_table) Members trh, trv changed to unsigned char *
6779 from int *. Member dim changed to a function pointer from a
6780 unsigned char *. Member max_stack_height removed. New members
6782 (macros tab_l, tab_r, tab_t, tab_b) New.
6784 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6786 * ascii.c: (delineate) Assign last_space_nchars before skipping
6787 spaces, to fix right justification.
6789 * crosstabs.q: (static vars risk, direct) New vars.
6790 (static var pearson_r) Removed.
6791 (glob var chisq_fisher) Made static.
6792 (static vars row_tot[], col_tot[]) Don't include grand total
6794 (static var grand_total) Renamed W, all references changed.
6795 (output_pivot_table) Only make `table' if num_cells != 0. Make
6796 risk and directional tables. Deal with grand total no longer part
6797 of col_tot[]. Free rows and cols after we're done with them.
6798 (display_risk) New function.
6799 (display_directional) New function.
6800 (clac_r) Rewritten so that it stores all its results into its
6801 arguments, so it can be used for Spearman's correlation too.
6802 (calc_symmetric) Added a t[] argument, all references changed.
6803 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6804 Pearson's r, Cohen's kappa.
6805 (calc_risk) New function.
6806 (calc_directional) New function.
6808 * som.c: (som_submit) Improved debugging code.
6810 * stats.c: (hypercube) New function.
6811 (cube) New function.
6813 (normal_sig) Went back to old implementation, which actually
6816 * stats.h: (macros square, cube, hypercube) Removed. The
6817 equivalent functions in stats.c are inlined here; all references
6818 to square changed to sqr.
6820 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6822 * crosstabs.q: (N_SYMMETRIC) New define.
6823 (postcalc) Disable debug printing.
6824 (static vars chisq_fisher, pearson_r) New.
6825 (output_pivot_table) Add support for symmetric measures. Add
6826 chi-square output of exact sigs.
6827 (display_chisq) Rewritten.
6828 (display_symmetric) New function.
6829 (gamma_int) New function.
6831 (swap) New function.
6832 (calc_fisher) New function.
6833 (calc_chisq) Check boundary conditions better. Calculate Yates,
6834 Fisher, Mantel-Haenszel tests.
6835 (calc_r) New function.
6836 (calc_symmetric) New function.
6838 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6840 (chisq_sig) Better boundary conditions. Renamed from
6843 * tab.h: (struct tab_table) New member cf.
6845 * tab.c: (tab_create) Set cf.
6846 (tab_width) New function.
6847 (tab_realloc) Handle cf.
6848 (tab_vline) Handle cf.
6849 (tab_hline) Handle cf.
6850 (tab_box) Handle cf.
6851 (tab_value) Handle cf.
6852 (tab_float) Handle cf.
6853 (tab_text) Handle cf.
6854 (tab_joint_text) Handle cf.
6855 (tab_offset) Handle cf.
6856 (tab_next_row) Handle cf.
6857 (evaluate_dimensions) Handle cf.
6858 (render_strip) Handle cf.
6860 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6862 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6863 output_pivot_table().
6864 (output_pivot_table) Moved lots of local variables outside and
6865 made them static. Add beginnings of chi-square statistic
6866 support. Now column and row totals aren't in the main matrix.
6867 Always zero out any leftover rows & columns after we're done with
6868 the table entries. Move all output stuff into
6869 display_dimensions(), display_crosstabs(), display_chisq().
6870 (display_dimensions) New function.
6871 (display_crosstabulation) New function.
6872 (display_chisq) New function.
6873 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6875 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6876 references, simplify logic.
6878 * postscript.c: Remove scale, translate-x, translate-y,
6879 mirror-horz, mirror-vert, rotate-180 options.
6880 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6881 All references deleted.
6882 (macro YT) New macro.
6883 (array option_tab[]) Removed options.
6884 (ps_option) Removed options.
6885 (ps_open_page) Write page setup explicitly to output file, without
6886 using now-deleted BP function.
6887 (macro dump_line) Use YT().
6888 (macro dump_thick_line) Use YT().
6889 (draw_headers) Use YT().
6890 (switch_font) Reorder arguments to SF function.
6891 (write_text) Use YT().
6893 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6896 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6898 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6899 null-debugging code.
6900 (tab_realloc) Remove null-debugging code. Initialize new regions
6902 (tab_vline) Support offsets.
6903 (tab_hline) Support offsets.
6904 (tab_box) Support offsets.
6906 (tab_nulls) Removed.
6909 (evaluate_dimensions) Remove null-debugging code. Understand
6910 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6911 TAB_EMPTY not present.
6913 * tab.h: New cell attribute TAB_EMPTY.
6914 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6916 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6917 try to read them from system files.
6919 * vfm.c: (dump_splits) Don't call tab_null().
6921 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6923 * crosstabs.q: (struct crosstab) Added `missing' member.
6924 (custom_tables) Init missing.
6925 (calc_general) Handle missing values.
6926 (calc_chisq) New function.
6927 (output_pivot_table) Start work on chi-square output. Update for
6928 new tab offset support functions. Shorten statistic names.
6930 * Several files: add in more `const's to placate gcc's warnings.
6932 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6935 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6936 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6937 tab_joint_text) Add col_ofs and row_ofs support.
6938 (tab_offset) New function.
6939 (tab_next_row) New function.
6940 (tab_row) New function.
6941 (tab_col) New function.
6942 (tabi_table) Add col_ofs and row_ofs support.
6944 * vars-atr.c: (is_system_missing) New function.
6946 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6948 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6949 (static var no_cells) Removed.
6950 (static var num_cells) New.
6951 (static var expected) New.
6952 (static var cells[]) New.
6953 (internal_cmd_crosstabs) Deal with new variables.
6954 (postcalc) Removed most of the meat and put it in new function
6955 output_pivot_table().
6956 (output_pivot_table) Calculates and outputs an entire pivot table.
6958 * postscript.c: (postopen) Fix problems with free()ing addresses
6959 not obtained from malloc().
6961 * som.c: (som_submit) Add assertion.
6963 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6966 * tab.c: (static var tab_names[]) New.
6967 (tab_realloc) -1 for nc or nr indicates no change.
6968 (tab_nulls) New function.
6969 (tab_dim) Use tab_names[].
6970 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6971 (evaluate_dimensions) Don't terminate on uninited cells, just put
6972 an X in them and emit a notice. Use tab_names[].
6974 * tab.h: Move bits into tab.def.
6976 * tab.def: New. Don't try to declare tab_table_class because then
6977 som.h has to be included.
6979 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
6981 * command.def: New file, contains all the command definitions
6982 previously included bodily in command.c.
6984 * format.def: New file, contains all of the format definitions
6985 previously split across format.h, format.c, and sfm-write.c.
6987 * lexer.h: Renamed from tokens.h in order to match corresponding
6990 * lexerP.h: Moved some rarely used functions exported by lexer.c
6993 * Makefile.am: Commemorate renamed files.
6994 (EXTRA_DIST) Add command.def, format.def.
6996 * command.c: [0] (walk_cmdtable_func) Removed.
6998 * crosstabs.q: (postcalc) Made it work and print out matrices
7000 (enum_column_values) Renamed enum_var_values, generalized for any
7003 * format.h: (struct fmt_desc) New member `spss'.
7005 * q2c.c: (main) Generated code includes lexer.h instead of
7008 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7009 instead of an independent translation table.
7011 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7013 * Lots of source files: Added const to declarations.
7015 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7017 * arena.c: (arena_clear) Set prev pointer to null when done.
7019 * ascii.c: (ascii_option) Rename index as indx.
7021 * avl.c: This is now a separate library called libavl.
7022 (xmalloc) Make static.
7023 (avl_probe) Step A7 can use the cache instead of an explicit
7025 (avl_delete) Don't maintain a q pointer because it's always
7026 available in the pointer stack. Comment fix.
7028 * avl.h: This is now a separate library called libavl.
7030 * command.c: (cmd_table[]) Remove spurious trailing "".
7032 * common.h: Only include random() fix if this system needs it.
7034 * crosstabs.q: Include alloca headers.
7035 (n_sorted_tab) New global var.
7036 (postcalc) Mostly rewritten.
7037 (find_pivot_extent) Rewritten.
7038 (enum_column_values) Rewritten.
7040 * data-out.c: (convert_F) Rename inner n as n_spaces.
7042 * error.c: (dump_message) Don't have an outer var i.
7044 * file-handle.q: (static var f) Removed. All references removed.
7045 (internal_cmd_file_handle) Uses a local variable instead of f.
7047 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7048 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7051 * getline.h: Declare getl_history as extern. Reported by
7052 palme@uni-wuppertal.de (Hubert Palme).
7054 * postscript.c: (postopen) Some large mods for constness.
7056 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7059 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7061 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7062 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7065 * avl.c, avl.h: New files. These form a clean-room
7066 reimplementation of avllib. Iterative algorithms are used in
7067 place of recursive ones, so there is no resemblance in the code.
7069 * Lots of headers: Don't include other headers by default.
7071 * Lots of source files: Explicitly include all needed headers.
7073 * arena.c: (arena_clear) New function.
7075 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7076 (static var ar) Removed.
7077 (staitc vars ar_tc, ar_col) New.
7078 (cmd_crosstabs) Destroy the arenas.
7079 (internal_cmd_crosstabs) Create the arenas.
7080 (precalc) Don't need a free function for the hash.
7081 (calc_general) Make sure to zero out the trailer on the key data
7083 (print_table_entries) Updated.
7084 (postcalc) Worked on actually implementing.
7085 (find_pivot_extent) New function.
7086 (compare_value) New function.
7087 (enum_column_values) New function.
7089 * data-in.c: (parse_month) Make local array `static const'.
7091 * data-out.c: (convert_date) Make local array `static const'.
7092 (convert_WKDAY) Same.
7093 (convert_MONTH) Same.
7095 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7096 been renamed to avl_walk().
7098 * hash.c: Rewritten more efficiently.
7100 * hash.h: Add attribute const to hsh_next_prime declaration.
7102 * lexer.c: (id_match) Make arguments const.
7104 * postscript.c: (ps_postopen_driver) Make default fonts the
7107 * q2c.c: (main) Generated code needs stdlib.h.
7109 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7110 initialized to 0 now, not to NULL. All other references to
7111 avl_traverser were updated in the same way.
7113 * tokens.h: Macro version of id_match updated to use const
7116 * val-labs.c: (inc_ref_count) New function.
7117 (copy_value_labels) Simply through use of new avl_copy() function.
7119 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7121 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7122 (postcalc) Worked on this.
7124 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7125 (struct ps_driver_ext) New line_width_thick member.
7126 (ps_preopen_drive) Init line_width_thick.
7127 (option_tab[]) Add line-* options.
7128 (ps_option) Parse line-* options.
7129 (postopen) Add line_width_thick support. Strip leading spaces on
7130 prologue output lines.
7131 (ps_open_page) Include line_width_thick in output.
7132 (macro dump_thick_line) New.
7133 (dump_fancy_line) Support thick lines as well as double lines.
7135 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7137 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7138 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7140 * Many source files: Rename `options' to `pv_opts' as appropriate.
7142 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7144 * common.c: (xcalloc) New function.
7146 * crosstabs.q: New file. Not finished yet, though.
7148 * data-list.c: Comment fix.
7150 * error.c: Remove some old Checker cruft.
7152 * frequencies.q: (dump_full) Cumulate valid percent instead of
7155 * getline.c: Comment fix.
7157 * hash.c: Comment fixes.
7159 * hash.h: (struct hsh_table) Make hash functions return unsigned
7160 instead of int to avoid problems with taking the modulo of
7161 negative return values. All references changed.
7163 * misc.c: (intlog10) Make its table static const instead of auto.
7165 * sfm-read.c: (read_header) Make `prefix' static const instead of
7168 * var.h: (union value) Add member `hash'.
7169 (struct variable) Rename prv_index as `foo'--all references
7171 (typedef pv_opts) Removed. All references changed.
7173 * vars-prs.c: (parse_variables) Message fixes.
7175 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7177 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7178 they are being inserted. Don't check for BY variables of
7179 different types. Discard variables if the active file isn't
7180 included in the merge.
7181 (mtf_processing) Essentially rewritten.
7182 (mtf_merge_dictionary) Check for master/slave variables of
7183 different types/widths.
7185 * vfm.c: (static var not_canceled) New var.
7186 (process_active_file) Don't call vfm_source->read() if
7187 there's no vfm-source. Initialize not_canceled.
7188 (process_active_file_write_case) Honor and update not_canceled.
7189 (prepare_for_writing) Rollback changes from yesterday, they were
7191 (close_active_file) Don't destroy vfm_source unless it exists.
7193 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7195 * Lots of source files: Added { } around nested if/else constructs
7196 to avoid new gcc 2.8 warnings.
7198 * data-in.c: (parse_Z) Declare `int' type explicitly.
7201 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7202 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7203 prev members. Put TABLEs at the end of the chain and FILEs at the
7204 beginning. Don't allow the active file in STATE_INIT. Use proper
7205 `seen' value for the active file. Fill out the by members and
7206 make sure they're of consistent type. Do the actual merge
7208 (mtf_processing_finish) New function.
7209 (var_type_description) New function.
7210 (mtf_free_file) New function.
7211 (mtf_free) Rewritten.
7212 (mtf_delete_file_in_place) New function.
7213 (mtf_read_nonactive_records) New function.
7214 (mtf_compare_BY_values) New function.
7215 (static var mtf_seq_no) New var.
7216 (mtf_processing) New function.
7217 (mtf_merge_dictionary) Assign nval members for the system file
7218 dictionary. Assign fv values for its variables. Point each slave
7219 variable to the corresponding master variable.
7221 * hash.c: Include str.h.
7223 * mis-val.c: (copy_missing_values) src arg is const.
7225 * misc.c: (spacing) Make `max' var explicitly int.
7227 * sfm-read.c: (dump_dictionary) Message reformatting.
7228 (sfm_read_case) Add assertion.
7230 * sort.c: Esthetic fixes.
7232 * var.h: (struct match_files_proc) New struct.
7233 (struct variable) Add private data match_files_proc.
7235 * vars-atr.c: (delete_variable) Implement. Add argument for the
7236 dictionary that owning the variable.
7237 (dup_variable) Add assertion.
7239 * vfm.c: Comment fixes, hopefully the comments are correct now.
7240 (process_active_file) New function.
7241 (process_active_file_write_case) New function.
7242 (process_active_file_output_case) New function.
7243 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7245 (write_case) Renamed procedure_write_case(). Now write_case is a
7246 pointer to a function. Style fixes.
7248 1998-03-05 Ben Pfaff <blp@gnu.org>
7250 * Makefile.am: (q2c) Link with libmisc.
7251 (version.c) Define default_config_path, include_path,
7254 * ascii.c: (ascii_postopen_driver) When the default newline string
7255 is requested, open file in text mode. Suggested by
7256 palme@uni-wuppertal.de (Hubert Palme).
7257 (static vars line_buf, line_p) Change from char * to unsigned char
7259 (ascii_close_page) char * to unsigned char *.
7261 * cmdline.c: (parse_command_line) Implement -r option by
7262 prepending ~/.pspp/rc to the list of files to process.
7264 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7265 before pulling in a final line.
7266 (null_func, null_int_func) Removed (dead code).
7268 * descript.q: (display) Calculate width of variable name column
7269 properly. Calculate number of valid cases properly. Reported by
7270 palme@uni-wuppertal.de (Hubert Palme).
7272 * filename.c: (init_filename) Use default_config_path instead of
7273 now obsolete CONFIG_PATH.
7275 * getline.c: (getl_initialize) Use include_path instead of now
7276 obsolete INCLUDE_PATH.
7277 (getl_add_file) New argument `where'. All references changed.
7279 * groff.c: (find_font_file) Use groff_font_path instead of now
7280 obsolete GROFF_FONT_PATH.
7282 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7283 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7284 avoid problems with constness.
7286 * str.h: (macro cs_streq) New macro.
7288 * version.h: (glob var default_config_path, include_path,
7289 groff_font_path) New vars.
7291 1998-02-23 Ben Pfaff <blp@gnu.org>
7293 * Many source files: Change verbose_msg() priority levels and
7296 * aggregate.c: Include debug-print.h.
7298 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7300 (static var pre_syntax_message) Document --safer/-s and
7303 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7305 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7306 because it's not used but it's still copied.
7307 (open_file_r) Remove gratuitous debug message.
7309 * filename.c: (safety_violation) New function.
7310 (open_file) Remove gratuitous debug messages. Don't allow pipe
7311 files if set_safer is set.
7313 * get.c: Turn off debugging.
7315 * getline.c: (getl_add_virtual_file) New function.
7316 (getl_read_line) Add verbose_msg() call for opening new syntax
7318 (getl_perform_delayed_reset) Add a return value describing whether
7319 any action was taken. Call reset_eof().
7321 * getline.h: Comment fix.
7323 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7324 place of incorrect `continue'. Use strtok_r() instead of
7325 strtok(). Always check strtok_r() return value.
7326 (groff_read_DESC) Use strtok_r() instead of strtok().
7328 * lexer.c: (reset_eof) New function.
7330 * main.c: (parse) Get a token after performing a delayed reset
7331 action; allow empty syntax files.
7333 * postscript.c: (output_encodings) Use strtok_r() instead of
7336 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7338 * set.q: Comment fixes.
7339 (glob var set_safer) New var.
7340 (internal_cmd_set) Support SAFER.
7342 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7344 * temporary.c: (free_dictionary) Set d->splits to NULL after
7347 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7348 variable deleted, not if it *isn't* deleted.
7350 1998-02-16 Ben Pfaff <blp@gnu.org>
7352 * command.c: (array cmd_table[]) Add MATCH FILES.
7354 * common.c: Comment fixes.
7356 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7357 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7358 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7361 * expr-opt.c: Include str.h. Problem reported by
7362 palme@uni-wuppertal.de (Hubert Palme).
7364 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7365 (static var mtf_by) Change from char ** to variable **.
7366 (static var mtf_master) New var.
7367 (mtf_merge_dictionary) New function.
7368 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7369 var type. Reorder tests properly. Initialize file->dict. Detect
7370 TABLE= without BY=. Read file dictionaries and merge them. Give
7371 subcommand name with IN, LAST, FIRST error messages. Create IN,
7372 LAST, FIRST variables. Comment fixes.
7373 (mtf_free) Don't free default_dict. Free mtf_master.
7375 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7377 (handle_line_buffer) Cast int to size_t in comparison to avoid
7380 * getline.h: Declare getl_mode extern.
7382 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7383 (groff_read_DESC) Make line_size a size_t.
7384 (match_tok) Parenthesize name to avoid macro expansion.
7386 * mis-val.c: (copy_missing_values) New function.
7388 * postscript.c: (postopen) Make buf_size a size_t.
7390 * sfm-read.c: (dump_dictionary) Make global from static. Print
7391 variable info in parts for easier debugging with Checker.
7393 * temporary.c: (copy_variable) Use copy_value_labels().
7394 (new_dictionary) New arg: whether to copy file label, documents.
7396 * val-labs.c: (copy_value_labels) New function.
7398 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7400 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7402 (dup_variable) Set prv_index, get.fv, get.nv.
7404 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7406 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7408 * Many source files: For ANSI-compliance, add empty statement
7409 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7410 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7412 * data-in.c: (parse_numeric) Some header files break on
7413 -DBL_MIN_10_EXP because they get a --; add () for safety.
7414 Reported by palme@uni-wuppertal.de (Hubert Palme).
7416 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7417 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7418 (dfm_close) Use close_file_ext.
7419 (open_inline_file) Set file.file to NULL, not file.
7420 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7421 struct and use open_file_ext().
7422 (read_record) Use file.file.
7424 * file-handle.q: (prepend_current_directory) Pass through special
7427 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7428 (normalize_filename) Pass through special filenames.
7429 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7431 (dirname) Rename blp_dirname() because of name conflict on some
7432 OS. All references changed. Reported by palme@uni-wuppertal.de
7434 (is_special_filename) New function.
7436 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7437 (trim_dictionary) Conditionalize some of the options on whether
7438 GTSV_OPT_MATCH_FILES is in *options.
7439 (rename_variables) Don't allow variables to be renamed as scratch
7441 (MTF_*) New enum series.
7442 (struct mtf_file) New struct.
7443 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7445 (cmd_match_files, mtf_free) New functions.
7447 * lexer.c: (match_int) Needed parentheses around name to escape
7448 macro expansion. Reported by Micah Altman
7449 <maltman@www-vdc.fas.harvard.edu>.
7451 * print.c: Needed to include alloca.h. Reported by Micah Altman
7452 <maltman@www-vdc.fas.harvard.edu>.
7454 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7455 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7458 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7459 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7461 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7463 * html.c: (struct html_driver_ext) Move into htmlP.h.
7464 (html_preopen_driver) Initialize cp_x, cp_y.
7465 (html_submit) Implement as call to output_tab_table().
7466 (change_attributes) New function.
7467 (escape_string) New function.
7468 (output_tab_table) New function.
7470 * list.q: (write_all_headers) Add code for writing headers for the
7472 (clean_up) Write out the html close-table tag.
7473 (determine_layout) Ignore html driver.
7474 (list_cases) Write html data.
7476 * som.c: (som_submit) Move more of the code into output_table().
7478 * tab.c: (static var hit) Make a global var and rename tab_hit.
7479 (static var tab_table_class) Make a global var.
7481 * htmlP.h: New file.
7483 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7485 * dump-sysfile.c: Removed.
7487 * html.c: (preclose) Change comment in emitted code.
7489 * matrix-data.c: Debugging off by default. Comment fixes.
7490 (static var container) New var.
7491 (cmd_matrix_data) Create and destroy container. Initialize
7492 is_per_factor[] to 0s. Move code into new function
7493 string_to_content_type(). Require split values to be present in
7494 the data when ROWTYPE_ is explicit. Call specific function, not
7495 general read_matrices().
7496 (string_to_content_type) New function.
7497 (context) Exclude all whitespace, not just spaces.
7498 (mget_token) A dot is a number. Add assertion.
7499 (static var data) Renamed nr_data.
7500 (static var factor_values) Renamed nr_factor_values.
7501 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7502 only specific case. Close data_file before exit.
7503 (fill_matrix) New function.
7504 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7505 printing. Style fixes. Message fixes. Move code into
7507 (read_matrices_without_rowtype) Rename
7508 matrix_data_read_without_rowtype(). Fix off-by-one error on
7509 loops. Allocate nr_data[] memory from arena.
7510 (read_matrices_with_rowtype) Removed.
7511 (read_splits) Renamed nr_read_splits(). Style fixes.
7512 (read_factors) Renamed nr_read_factors().
7513 (dump_cell_content) Comment fixes. Arguments changed. Change
7514 debug printing. All references changed.
7515 (output_data) Renamed nr_output_data().
7516 (static var wr_content) New var.
7517 (struct factor_data) New struct.
7518 (static var wr_data) New var.
7519 (static var wr_current) New var.
7520 (matrix_data_source_destroy_source) Removed.
7521 (read_matrices_with_rowtype) New function.
7522 (matrix_data_read_with_rowtype) New function.
7523 (wr_read_splits) New function.
7524 (compare_factors) New function.
7525 (wr_output_data) New function.
7526 (wr_read_rowtype) New function.
7527 (wr_read_factors) New function.
7528 (wr_read_indeps) New function.
7529 (glob var matrix_data_source) Make destroy_source member NULL as
7532 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7534 * lexer.c: (syntax_error) Give better error message when at end of
7537 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7538 N_SCALAR to output as plain N.
7539 (mdump_token) Change output format.
7540 (context) Fix message output interaction with spaces in input.
7541 (another_token) New function.
7542 (force_eol) Improved error message.
7543 (static var max_cell_index) New var.
7544 (read_matrices) Init `cells'. factor_values is now per-cell.
7545 Init max_cell_index.
7546 (read_data_lines) Replace `compare' local with new `compare' arg.
7547 Debugging messages changed. Only read factors if per_factor.
7548 Propagate error return from read_factors(), force_eol().
7549 Copy N_SCALAR values across the N vector.
7550 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7551 check parentheses manually since we now have is_per_factor[].
7552 Call read_data_lines() with new args. Check for end of data after
7553 looping, using another_token().
7554 (read_factors) Arguments changed. Use max_cell_index to determine
7555 whether to read or compare factors. Message fixes.
7556 (dump_cell_content) New function.
7557 (output_data) Completely rewritten because content types were
7558 supported to be nested inside factor values, not vice versa.
7560 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7562 * lexer.c: (syntax_error) Support formatted varargs messages.
7564 * matrix-data.c: Turn debugging on by default.
7565 (static content_type[]) New array.
7566 (static content_names[]) New array.
7567 (static rowtype_, varname_) New vars.
7568 (static is_per_factor[]) New array.
7569 (static split_values) Moved declaration.
7570 (static n_continuous, first_continuous) New var.
7571 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7572 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7573 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7574 Check for continuous variables.
7575 [DEBUGGING] (debug_print) Remove content_names[].
7576 (mdump_token) New macro.
7577 (mget_token_dump) New function.
7578 (mdump_token) New function.
7579 (context) New function.
7580 (mget_token) Fix messages.
7581 (static var data, split_values, factor_values) New vars.
7582 (read_matrices) Manage split_values, factor_values.
7583 (read_data_lines) New function.
7584 (read_matrices_without_rowtype) Implemented.
7585 (read_splits) Message fixes. Uses `just_read'.
7586 (read_factors) New function.
7587 (output_data) New function.
7588 (matrix_data_source_destroy_source) Close the file handle.
7589 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7592 * str.c: (strpadcmp) Removed.
7594 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7596 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7598 * Lots of source files: Add cast to unsigned character to calls to
7599 tolower() and toupper().
7601 * aggregate.c: Set default_dict.splits to NULL.
7603 * command.c: (static variable tab[]) Add MATRIX DATA.
7605 * data-in.c: Add debugging defines. Formatting fixes.
7607 * expr-opt.c: Formatting fixes.
7609 * lexer.c: (syntax_error) Message fixes.
7611 * matrix-data.c: New enum series.
7612 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7613 split_values, n_factors, factors, cells, pop_n, contents,
7614 n_contents) New vars.
7615 (cmd_matrix_data) Finished implementation.
7616 (compare_variables_by_mxd_vartype) New function.
7617 [DEBUGGING] (debug_print) New function.
7618 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7619 (read_matrices) New function.
7620 (read_matrices_without_rowtype) New function.
7621 (read_matrices_with_rowtype) New function.
7622 (read_splits) New function.
7623 (mget_token) New function.
7624 (force_eol) New function.
7625 [0] (test_tokenizer) New function.
7626 (matrix_data_source_destroy_source) New function.
7627 (glob var matrix_data_source) New var.
7629 * misc.h: Include ieeefp.h if present.
7631 * split-file.h: (cmd_split_file) Changes corresponding to struct
7634 * str.h: Fix memmem prototype.
7636 * temporary.c: (save_dictionary, restore_dictionary,
7637 free_dictionary) Changes corresponding to struct dictionary
7640 * var.h: (MXD_* enums) New enum series.
7641 (struct matrix_data_proc) New struct.
7642 (struct split) Removed.
7643 (struct dictionary) Changed `splits' member from `split *' to
7645 (macro force_create_variable) New macro. Replaced lots of
7646 create_variable()/assert() calls with calls to this macro.
7648 * vars-atr.c: (discard_variables) Changed assertion.
7649 [GLOBAL_DEBUGGING] (force_create_variable) New function
7650 called by the macro of the same name.
7651 (clear_variable) Changes to delete splits from the dictionary
7652 corresponding to struct dictionary changes.
7654 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7655 corrupted variable `index' values in the dictionary passed in
7656 every time this function is called.
7658 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7659 to struct dictionary changes.
7661 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7663 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7665 * command.c: New includes.
7666 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7667 (cmd_erase) New function.
7668 [unix] (shell) New function.
7669 (run_command) New function.
7670 (cmd_host) New function.
7671 (cmd_new_file) New function.
7673 * expr-prs.c: (parse_primary) Message fix.
7675 * inpt-pgm.c: Formatting fix.
7676 (cmd_reread) Implement the FILE subcommand.
7678 * matrix-data.c: New file.
7680 * q2c.c: (dump_header) Change output commenting style.
7682 * weight.c: Comment fix.
7684 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7686 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7688 (buf_10x) Renamed buf_1xx, all references changed.
7689 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7690 cases now implemented).
7691 (create_sysfile) New function.
7692 (agr_11x_func) New function.
7694 * data-in.c: (parse_numeric) Work properly if there's an
7695 explicitly coded decimal point in the data and decimal places are
7696 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7697 <el@linux.lisse.na>.
7699 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7700 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7701 Eberhard W Lisse <el@linux.lisse.na>.
7703 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7704 strerror.c. Bug reported by Alexandre Oliva
7705 <oliva@dcc.unicamp.br>.
7707 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7708 (static var separate_case_tab) New var.
7709 (cmd_sort_cases) Cancel temporary transformations here. Free
7710 v_sort before return.
7711 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7712 we're reading from a sort stream. Don't cancel temporary
7713 transformations. Offload internal sorting to do_internal_sort().
7714 (do_internal_sort) New function. Handles internal sorting even
7715 when SEPARATE is nonzero. Doesn't free v_sort.
7716 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7718 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7719 sink if SEPARATE is zero.
7720 (read_output_cases) Renamed read_sort_output(), all references
7721 changed. Now uses separate_case_tab when it exists.
7722 (write_separate) New function.
7724 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7725 memory_sink_cases. Don't redundantly call
7726 vfm_source->destroy_source().
7727 (memory_stream_mode) After switching over, set memory_sink_cases
7730 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7732 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7734 (static var prev_case) New, moved out of aggregate_single_case()
7736 (static var buf64_10x, buf_10x) New.
7737 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7738 the 000, 001, 100, and 101 cases. Free prev_case.
7739 (parse_aggregate_functions) Disallow scratch variables.
7740 (free_aggregate_functions) Only free agr_dict if non-null. Use
7741 iter->function to determine numeric/string type, not
7743 (aggregate_single_case) Don't manage prev_case. Initialize
7744 aggregate info after dumping it.
7745 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7746 mean, stddev, weighted stddev definitions.
7747 (dump_aggregate_info) Implemented.
7748 (initialize_aggregate_info) Renamed from
7749 initialize_aggregate_functions(). Initializes dbl[2].
7750 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7751 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7753 * cases.c: (alloc_val) Removed.
7755 * get.c: (cmd_save_internal) Initialize new `dict' member.
7757 * sfm-write.c: (sfm_write_dictionary, write_header,
7758 write_variable, write_value_labels, write_documents) Reorganize,
7759 simplify for new parameter structure.
7760 (write_variable) Only one variable * argument now.
7762 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7763 replaced by new `dict' member.
7765 * temporary.c: (new_dictionary) Initialize n_documents.
7767 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7769 (init_variable, replace_variable) Eliminate usage of alloc_val().
7771 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7773 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7774 signal that AGGREGATE is to be used for forming final cases.
7775 (close_active_file) Call end_func before stopping lagging. Cancel
7776 temporary after finishing compaction.
7777 (write_case) Comment fixes. Cleaned up.
7778 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7781 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7783 * Makefile.am: (BUILT_SOURCES) Add means.c.
7784 (pspp_SOURCES) Add means.c.
7785 (EXTRA_DIST) Add means.q.
7787 * command.c: (array cmd_table[]) Add MEANS.
7789 * common.h: Esthetic fixes. Comment fixes. Test for
7790 MAX_SHORT_STRING greater than 8.
7791 (macros LOWEST, HIGHEST) New.
7793 * data-in.c, data-list.c, recode.c: Comment fixes.
7795 * means.q: New file, base version.
7797 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7798 with LOWEST, DBL_MAX with HIGHEST.
7800 * q2c.c: (dump_vars) Add an enum to array types giving the number
7801 of values for the enum.
7803 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7804 Replace second_lowest_value with second_lowest_flt64.
7806 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7807 second_lowest_value with second_lowest_flt64.
7809 * t-test.q: Comment fix.
7811 * temporary.c: (restore_dictionary) Esthetic fix.
7813 * tokens.h: (force_match_id, force_match, force_string, force_int,
7814 force_num, force_id) Replace msg() with syntax_error().
7816 * var.h: (struct means_proc) New.
7817 (struct variable) Add mns member to `p' union.
7819 * vars-prs.c: (parse_variable, parse_dict_variable,
7820 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7823 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7825 * Makefile.am: (pspp_SOURCES) Add tab.h.
7827 * Most source files: Added a cast to unsigned char in usages of
7828 the ctype is*() functions. Replaced `end of command expected'
7829 calls to msg() with calls to syntax_error().
7831 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7833 * lexer.c: (hex_val) Removed (was dead code).
7834 (idmatch) Parenthesize function name to avoid macro expansion.
7836 * postscript.c: Comment fixes.
7837 (ps_preopen_driver) Change default font size to 10pt.
7839 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7841 (parse_format_spec) Change system-file format spec argument type
7842 to int32. Parse the format spec with bitwise operators.
7844 * sfmP.h: (struct sysfile_format) Removed.
7845 (struct sysfile_variable) Changed print, write members from
7846 sysfile_format to int32.
7848 * tokens.h: Esthetic fixes.
7849 [__GNUC__] (macro id_match) New macro to hopefully speed up
7850 identifier matching.
7851 (macros match_id, match_tok, match_int) Implemented in
7852 compiler-independent manner; no longer GNU C only.
7854 * vfm.h: Include time.h.
7856 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7858 * data-list.c: (dump_fixed_table) Change tab_dim().
7860 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7862 * error.c: Include command.h.
7864 * frequencies.g: Formatting fixes.
7866 * frequencies.q: Add tab_dim() calls. Make the total cell a
7869 * glob.c: Include command.h.
7871 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7873 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7874 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7875 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7876 the other elements (is this right?).
7877 (read_variables) Use lowest, highest members.
7878 (parse_format_spec) New arg `vv' for more stringent checking.
7879 (dump_dictionary) Byteswaps nonexplicit data.
7880 (sfm_read_case) Byteswap numeric data.
7882 * som.c: Initialize table_num to 1.
7883 (render_segments) Remember to increment y_index after each table
7886 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7887 avl_count() on a NULL tree. No title for the second table.
7888 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7889 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7890 fix call to display_variables().
7891 (display_variables) Default to 4 columns, not 3. Set up headers.
7892 Column title is Variable, not Name. Fix index column.
7893 Add joint text. Add tab_dim(). Handle value labels properly.
7894 Handle DISPLAY LABELS properly. Draw boxes correctly.
7895 (describe_variable) Value labels don't need titles. Don't clear
7896 nonexistent index column.
7897 (compare_vectors_by_name) New function.
7898 (display_vectors) New function.
7900 * tab.c: (tab_height) Add assertion.
7901 (tab_null) Add debug code.
7902 (evaluate_dimensions) Add debug code.
7904 * var.h: (struct variable) get_proc data is sometimes used
7905 simultaneously with other per-procedure info, therefore it was
7906 removed from the union. All references changed.
7908 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7910 * ascii.c: (ascii_close_page) Put title on second line of headers
7911 if there is no subtitle.
7913 * command.c: (glob var cur_proc) Move definition here, from
7915 (cmd_remark) Emit blank line before remarks.
7917 * command.h: (glob var cur_proc) Move declaration here, from
7920 * data-list.c: (dump_fixed_table) Fix messages.
7921 (dump_free_table) Call tab_nat_dim().
7923 * descript.q: (dump_z_table) Modify tab_dim() call.
7925 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7927 (dump_statistics) Don't output header.
7929 * groff-font.c: Minor format fix.
7931 * html.c: Comment fix.
7933 * list.q: (write_varname) Indent after advancing page.
7935 * output.h: Minor reordering.
7937 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7938 a reference to eol[].
7939 (struct ps_driver_ext) New member eol[].
7940 (ps_preopen_driver) Initialize eol[].
7941 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7942 defaults. Handle headers. Fix test for minimum page length.
7943 (static var option_tab[]) Add `line-ends'.
7944 (ps_option) Handle line-ends to change eol[].
7945 (postopen) Scale prop_em_width and fixed_width properly. Set the
7946 prologue title to outp_title if applicable. Replace the prologue
7947 line ends with eol[]. Call draw_headers() if headers are enabled.
7948 (text_width) New function.
7949 (out_text_plain) New function.
7950 (draw_headers) New function.
7952 * print.c: (dump_table) Call tab_nat_dim().
7954 * som.c: (som_blank_line) Only advance a line if not at the top of
7956 (som_submit) Move several informational table calls here.
7957 Increment subtable_num if SOMF_NO_TITLE not set.
7958 (output_table) Advance a line if SOMF_NO_SPACING not set.
7959 (render_columns, render_segments, render_simple) Handle spacing
7960 between tables. Handle table titles. Remove debug output.
7962 * som.h: (SOMF_*) New enum series.
7963 (struct som_table_class) New member `flags'.
7965 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7967 (display_variables) Calls tab_nat_dim().
7968 (describe_variable) Remove restriction on number of value labels.
7969 Make value labels separated by thin lines.
7971 * tab.c: (tab_create) Default `flags' to none.
7972 (tab_float) New arg `w'. All references changed.
7973 (tab_nat_dim) New function.
7974 (tab_output_text) No title or spacing.
7975 (tab_flags) New function.
7976 (tabi_flags) New function.
7977 (tabi_title) New function.
7978 (strip_height) Removed.
7979 (tabi_render) Skip title when necessary.
7980 (static var tab_tab_class) Add tabi_flags, tabi_title.
7981 (evaluate_dimensions) Disable display of column, row size.
7982 (sum_columns) Add title height to top header.
7983 (render_strip) Moved within file.
7985 * tab.h: (struct tab_table) New member `flags'.
7987 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
7989 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
7991 * Most source files: Add `const' attribute in all appropriate
7994 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
7995 column to the variables table for use by describe_variable().
7996 (cmd_display) Disable for the present.
7997 (display_documents) Don't wrap documents.
7998 (display_variables) Table has four columns now.
7999 (describe_variable) Table has four columns now. Don't use a
8000 subtable, use joined cells instead.
8002 * tab.c: (tab_create) Don't set `join'.
8003 (tab_realloc) ct array is not made up of a_string's.
8004 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8005 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8006 (text_format) New function.
8007 (tab_title) Rewritten, uses text_format().
8008 (tab_text) Rewritten, uses text_format().
8009 (tab_joint_text) New function.
8011 (static var hit) New variable.
8012 (render_strip) New args r1, r2. Implement joined cells that fit
8014 (tabi_render) Increment hit. Pass new args to render_strip().
8015 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8016 cells. For t_naw and t_nah, ignore joined cells and null cells in
8019 * tab.h: (struct tab_join_rect) Removed.
8020 (struct tab_table) Removed `join'.
8021 (TAB_JOIN_MAIN) Removed.
8022 (struct tab_joined_cell) New struct.
8023 (TAT_NOWRAP) New enum.
8025 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8027 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8029 (ascii_postopen_driver) Fix initialization of *_spacing so that
8030 the TAL_0 bit doesn't count.
8032 * data-list.c: (dump_fixed_table) Use natural width for Format
8035 * glob.c: (rerange) Removed.
8036 (get_date) Formatting fixes. Internationalization fix.
8038 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8041 * postscript.c: (ps_postopen_driver) Replace
8042 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8044 * som.c: (som_submit) Don't eject page before every table.
8045 (output_table) Fix order of arguments on call to area().
8046 (render_columns) Fix calculation of max_len.
8048 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8049 (render_strip) New function.
8050 (strip_height) New function.
8051 (tabi_render) Rewrite as calls to render_strip().
8053 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8054 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8055 with the TAB_* and OUTP_T_* constants.
8057 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8059 * Makefile.am: Formatting fixes.
8061 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8064 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8066 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8068 * dump-sysfile.c: (glob var length) Make type off_t.
8069 (usage) Fix arguments.
8072 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8073 Now right-justification is the default so many references had to
8075 (struct outp_class) Removed line_width, all references changed.
8076 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8077 (struct outp_driver) Add elements horiz_line_width,
8078 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8081 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8083 (postopen) Initialize all the informational members of
8086 * som.c: (som_blank_line) New function, renamed from blank_line(),
8087 all references changed.
8088 (som_submit) Disables drivers whose pages can't be opened.
8089 (render_columns, render_simple, render_segments) Add debug output.
8090 (render_columns) Fix loop range.
8091 (render_simple) Don't try to render the headers, they're taken
8092 care of automatically. Advance cp_y past the table when done.
8093 (render_segments) Fix loop ranges.
8095 * tab.c: Initialize new members of tab_table.
8096 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8097 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8098 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8101 (tab_dim) New function.
8102 (tab_col_width) Removed.
8103 (tab_row_height) Removed.
8104 (tab_output_text) Call tab_dim().
8105 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8106 (tabi_area) Implemented.
8107 (tabi_cumulate) Implemented.
8108 (tabi_render) Partially implemented, but broken.
8109 (var tab_table_class) Made static.
8110 (evaluate_dimensions) New function.
8111 (sum_columns) New function.
8113 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8114 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8115 t_scr, t_srr, t_sentinel. Removed: t_nat.
8116 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8117 max_stack_height, w, h. Removed: ce, re.
8118 (macro blank_line) Removed.
8119 (glob var zero_length) Removed.
8121 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8123 * Most source files: include some of the new include files broken
8126 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8129 * aggregate.c: (glob var outfile) Make static.
8131 * command.c: (glob var pgm_state) Move here.
8133 * common.c: (glob vars endian, second_lowest_value, pgmname,
8134 finished, curdate, cur_proc, start_interactive, history_file) Move
8137 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8139 * file-handle.q: (glob vars files, inline_file) Move here.
8141 * glob.c: Lost lots of glob vars, detailed in individual file
8143 (init_glob) set_printer, set_screen were obsolete, deleted.
8144 set_cprompt has fewer spaces because pspp has fewer letters than
8147 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8148 (inp_nval) Made static.
8150 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8151 tokstr_len, toklongstr, tokint) Move here.
8153 * misc.c: Lost several vars and functions.
8155 * set.q: (all the set_* variables) Move here.
8157 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8158 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8161 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8163 * tab.h: (enum series t_*) New enums.
8164 (struct tab_table) Use arena struct tag. New members ce, re.
8166 * tokens.h: Comment fixes.
8168 * var.h: Move lots of enums and variables and functions and
8169 structures to other files. Use and declare a lot more union and
8170 struct tags. Comment fixes.
8172 * vector.c: (glob vars vec, nvec) Move here.
8174 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8175 init_blanks, last_vfm_invocation) Move here.
8177 * cases.h: New file.
8178 (struct long_vec) Move here.
8179 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8182 * command.h: New file.
8183 (STATE_* enums) Move here.
8184 (glob var pgm_state) Move here.
8186 * format.c: New file.
8187 (glob var formats) Move here.
8188 (parse_format_specifier_name, fmt_to_string,
8189 check_input_specifier, check_output_specifier,
8190 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8193 * format.h: New file. Move functions now in format.c here.
8194 (FMT_* enums) Move here.
8195 (struct fmt_desc) Move here.
8196 (FCAT_* enums) Move here.
8197 (struct fmt_spec) Move here.
8198 (glob vars formats, fmt_parse_ignore_error) Move here.
8200 * inpt-pgm.h: New file.
8201 (INP_* enums) Move here, make #defines into enums.
8202 (glob vars inp_init, inp_init_size) Move here.
8205 (glob vars v_sort, nv_sort) Move here.
8206 (sort_cases, read_sort_output) Move here.
8208 * vector.h: New file.
8209 (struct vector) Move here, add struct tag.
8210 (glob vars vec, nvec) Move here.
8211 (find_vector) Move here.
8214 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8215 reinit_blanks, init_zero, init_blanks) Move here.
8216 (struct case_stream) Move here.
8217 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8218 vfm_disk_stream, sort_stream, data_list_source,
8219 input_program_source, file_type_source, get_source, n_lag) Move
8221 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8224 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8226 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8227 (LDADD) Add libdcdflib.
8229 * ascii.c: Comment and formatting fixes. Almost every external
8230 function had an assert added, checking driver_open and page_open.
8231 (ascii_init_driver) Broken into ascii_preopen_driver,
8232 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8233 (ascii_open_page) Sets page_open.
8234 (ascii_close_page) Clears page_open.
8236 * html.c: Comment and formatting fixes. Almost every external
8237 function had an assert added, checking driver_open and page_open.
8238 (html_init_driver) Broken into html_preopen_driver,
8239 html_postopen_driver, html_close_driver. Manages driver_open.
8240 (html_open_page) Sets page_open.
8241 (html_close_page) Clears page_open.
8242 (html_submit) Disabled.
8244 * lexer.c: (parse_string) Remove debugging printf.
8246 * list.q: (determine_layout) Open a page if one is not yet open.
8248 * output.c: Comment fixes.
8249 (add_class) Set the class member of the new list element.
8250 (parse_options) Don't handle device type.
8251 (colon_tokenize) New function.
8252 (configure_driver) New four-field format with a field for device
8253 type. Now initialize driver_open, page_open, next, and prev
8254 fields. Use new colon_tokenize() function. Don't do a memory
8255 copy to replace a driver, it doesn't work; instead delete the old
8256 driver and insert a new one.
8257 (destroy_driver) Don't call som_destroy_driver(). Close the page
8258 if it's open. Find the class in the list of classes and decrement
8259 that reference count. Remove the driver from the global driver
8261 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8262 references changed. Rewritten. Don't return a driver that's not
8264 (outp_eject_page) All references to som_internal_eject_page()
8265 changed to use this. Sets cp_x to 0 as well as cp_y.
8267 * output.h: (OUTP_I_* enums) Removed.
8268 (struct som_submission_form) Removed.
8269 (struct outp_class) init_driver broken into preopen_driver,
8270 postopen_driver, and close_driver. submit changed to take a
8273 * postscript.c: Comment and formatting fixes. Almost every
8274 external function had an assert added, checking driver_open and
8276 (ps_init_driver) Broken into ps_preopen_driver,
8277 ps_postopen_driver, ps_close_driver. Manages driver_open.
8278 (ps_open_page) Sets page_open.
8279 (ps_close_page) Clears page_open.
8281 * som.c: New file, base implementation.
8283 * som.h: (struct som_table) Add struct tag.
8284 (enum SOM_COL_ACROSS) Removed.
8285 (SOM_ROWS, SOM_COLUMNS) New enums.
8286 (struct som_table_class) Add member `cumulate'. Remove `segment';
8287 change `render' arguments.
8288 (struct som_point, struct som_rect) Removed.
8289 (som_submit_table) Fixed typo, should have been som_submit.
8291 * sysfile-info: (describe_variable) Don't try to insert a
8292 subtable; just destroy it for now.
8294 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8295 references to value labels.
8297 * tab.c: (tab_destroy) New function.
8298 (tab_columns) Change argument.
8299 [0] (tab_submit) Remove dead code.
8300 (tab_title) Allocate string from the table's arena.
8301 (tab_output_text) Only free the buffer if we allocated it.
8302 (tab_submit) New function.
8303 (static vars t, d) New static vars.
8304 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8305 tabi_headers, tabi_cumulate, tabi_render) New functions.
8306 (glob var tab_table_class) New global var.
8308 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8309 encapsulate the rectangle. All references changed.
8311 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8313 * All header files updated to use struct tags in addition to
8314 typedefs for all structures. Don't use word `struct' in struct
8317 * Makefile.am: (pspp_SOURCES) Remove html.c.
8318 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8319 all references updated.
8321 * command.c: (parse_cmd) Remove call to som_check_workspace.
8322 (output_line) Update to new som.
8324 * data-in.c: (parse_numeric) A single dot is not an error; it is
8325 the system-missing value.
8327 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8330 * data-out.c: Added `const' as appropriate to many prototypes.
8331 (convert_E, convert_F, convert_CCx) Take double argument instead
8332 of value * argument.
8333 (convert_format_to_string) Call changed functions appropriately.
8334 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8335 make a local copy of the value.
8337 * descript.q: Remove custom_variables() prototype now provided by
8339 (custom_variables) Don't increment sbc_variables, the caller does
8341 (dump_z_table, display) Update to new som.
8343 * error.c: (vmsg) Add const to prototype. Remove code to handle
8344 `too many errors' condition.
8345 (check_error_count) New function.
8346 (msg) Add const to prototype.
8348 * filename.c: (open_file) Rewrite for elegance.
8350 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8351 (dump_full, dump_condensed, dump_statistics) Update for new som.
8353 * list.q: Don't include somP.h. Change all references to
8354 som_driver_ext to refer to the new members of som_driver. Change
8355 som_internal_eject_page() references to outp_eject_page().
8357 * main.c: (parse) Rewrite for elegance. Add call to
8358 check_error_count().
8360 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8361 Rewrite or revise for new outp_driver_class_list structure.
8362 (outp_iterate_enabled_drivers) Fix comparison between disabled
8363 devices and current device type.
8364 (outp_eject_page) New function.
8366 * output.h: Comment fixes.
8367 (struct outp_driver) New members driver_open, page_open, cp_x,
8368 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8370 (struct outp_driver_class_list) New struct.
8371 (outp_class_list) Changed to type outp_driver_class_list; all
8374 * print.c: (dump_table, print_trns_proc) Updated for new som.
8376 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8377 prototypes for custom subcommands.
8378 (dump_subcommand) Always include the `else'.
8379 (dump_parser) Fix comments in output code.
8381 * set.q: Reordered functions.
8383 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8385 * som.h: Rewritten from scratch.
8387 * str.h: Remove dead code.
8389 * tab.c, tab.h: New files, base implementation.
8391 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8394 * t-test.q: New code from John Williams
8395 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8396 Many many new static vars and defines.
8397 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8398 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8399 (struct value_list) New struct.
8400 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8401 t_crt, t_sig, print_t_groups) New functions.
8402 (cmd_t_test) Implemented.
8404 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8407 * vfm.c: (dump_splits) Update to new som.
8409 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8411 * Makefile.am: (fiasco_SOURCES) Add html.c.
8413 * aggregate.c: Base source.
8415 * ascii.c: (postopen, preclose) Reformat.
8417 * data-out.c, expr-evl.c: Comment fixes.
8419 * filename.c: (open_file) When opening a file for writing, use
8420 line buffering instead of full buffering for better interactive
8421 performance. Suggested by Valerio Aimale
8422 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8423 names `stdin', `stdout', `stderr'.
8425 * groff-font.c: Comment fixes.
8427 * html.c: New file; base version.
8429 * list.q: (write_all_headers, clean_up, determine_layout,
8430 list_cases) Ignore `special' devices for now. Needs to be fixed
8433 * output.c: (outp_init) Add html driver to list; reverse list
8436 * output.h: (struct outp_class_struct) New members `special',
8437 `submit'; comment fixes. All references changed.
8439 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8440 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8442 (postopen) Comment fix.
8443 (preclose) Comment fixes, formatting fixes. Change x->file.file
8444 references to more proper f->file.
8446 * som-high.c: (som_submit_table) Special classes use their own
8449 * som.h: Comment fixes.
8451 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8454 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8456 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8458 * aggregate.c: Still working on this.
8460 * command.c: (cmd_table[]) Add AGGREGATE back in.
8461 (split_words) Make '-' a legal word separator as well as ' '.
8463 * main.c: Comment fixes.
8465 * q2c.c: (dump_parser) Don't require the procedure's full name to
8466 be present, in the generated source.
8468 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8469 multiply specified and let it be default; let MISSING, CRITERIA,
8470 FORMAT be multiply specified.
8471 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8472 (custom_groups) Fix defaults.
8473 (custom_pairs) Check whether this is a PAIRS subcommand before
8474 attempting to parse. Better garbage collection. Proper storage
8476 [DEBUGGING] (debug_print) New function.
8478 * temporary.c: Comment fixes.
8479 (copy_variable) Don't copy variable name and index.
8480 (save_dictionary) Copy variable name and index by hand.
8482 * vars-atr.c: Comment fixes.
8483 (create_variable) New dictionary argument. All references
8485 (common_init_stuff) New dictionary argument. All references
8487 (init_variable) New dictionary argument. All references changed.
8488 (dup_variable) New function.
8490 * vars-prs.c: (parse_variables) If there are any errors, we always
8491 return 0. Previously, it was possible for some types of errors to
8494 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8496 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8499 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8501 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8504 * q2c.c: Comment fixes.
8505 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8507 * t-test.q: (cmd_list) Rename cmd_t_test.
8509 * temporary.c: (new_dictionary) Don't declare as static.
8511 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8513 * aggregate.c: Changes, still not finished.
8515 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8517 * q2c.c: Comment fixes. Now its output is internationalized.
8518 (get_token) Fix parsing of escapes within literal strings.
8519 (main) Fix bad #line directives in output.
8521 * t-test.q: Base implementation.
8523 * temporary.c: (new_dictionary) New function.
8524 (restore_dictionary) [__CHECKER__] Change fill character to *
8527 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8529 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8531 * aggregate.c: Changes, still not finished.
8533 * descript.q, list.q: Comment fixes.
8535 * q2c.c: Almost completely rewritten.
8537 * t-test.q: New file, not complete.
8539 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8541 * aggregate.c: Changes, still not finished.
8543 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8546 * temporary.c: (cancel_temporary) New function.
8548 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8549 of doing it by hand.
8551 * vfm.c: (close_active_file) After restoring a TEMPORARY
8552 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8554 (SPLIT_FILE_procfunc) Comment fix.
8556 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8558 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8560 * aggregate.c: New file, not finished yet.
8562 * command.c: (cmd_table) Add AGGREGATE.
8564 * common.h: (pgm_state) Move declaration to var.h.
8566 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8568 (parse_string) Message fix.
8570 * recode.c: Comment fix.
8572 * sfm-read.c: (read_variables) Code esthetic fixes.
8573 (write_header) Default date is `Jan', not `JAN'.
8575 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8577 * sort.c: (cmd_sort_cases) Farm the work out to new function
8578 parse_sort_variables().
8579 (parse_sort_variables) New function.
8580 (sort_cases) New function. Cancels temporary transformations,
8581 which sorting didn't do previously.
8582 (cmd_sort_cases) Better garbage collection on error. Uses
8584 (write_initial_runs, merge_once) Improved code esthetics.
8585 (sort_stream_read) Reduced to one call to read_output_cases().
8586 (read_output_cases) New function.
8588 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8589 variable labels to 120 characters.
8591 * var.h: Comment fixes.
8592 (glob var pgm_state) From common.h.
8594 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8596 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8597 options. Set *names to NULL on error.
8599 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8601 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8603 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8604 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8606 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8608 * vfm.c: (page_to_disk) Added missing local variables.
8610 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8612 * get.c: Comment fix.
8614 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8615 source is anything other than a disk stream, not just if it's in a
8616 memory stream. Call page_to_disk() before external sort.
8617 (allocate_cases) Message fix.
8619 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8621 (page_to_disk) New function.
8623 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8625 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8627 * common.h: (macro strerror) Remove. From Alexandre Oliva
8628 <oliva@dcc.unicamp.br>.
8630 * get.c: (dict_delete_run) The number of variables to delete is
8631 not necessarily the number of variables that need to be shifted
8633 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8634 too many variables to be deleted.
8636 * postscript.c: Comment fix.
8638 * q2c.c: Include strerror.c. From Alexandre Oliva
8639 <oliva@dcc.unicamp.br>.
8641 * set.q: #undef ON and OFF. From Alexandre Oliva
8642 <oliva@dcc.unicamp.br>.
8644 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8645 early, otherwise errors cause a bad free().
8647 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8648 Oliva <oliva@dcc.unicamp.br>.
8650 * temporary.c: (save_dictionary) Don't allocate memory if
8653 * vfm.c: (memory_stream_write) Message fix.
8655 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8657 * command.c: (static var cmd_table[]) Define REPEATING DATA
8660 * common.h: Added support for broken systems that are missing
8661 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8663 * Many source files: Replace syntax error messages via msg() with
8664 call to syntax_error().
8666 * data-list.c: (dump_fixed_table) Add support for dumping table
8667 for REPEATING DATA as well as DATA LIST FIXED.
8668 (cmd_repeating_data) Allows and requires `/' between subcommands.
8669 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8670 CONTINUED specifications to be omitted. Forces CONTINUED to be
8671 specified if ID is. Calculates starts_end, cont_end from logical
8672 record length as reported by fhp. Calls dump_fixed_table() if
8673 requested. Fixed length of record copied by memcpy.
8674 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8676 (realize_value) Returns sensible value for out-of-range variable
8678 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8679 length of occurrences and length of line. Added warning for
8680 fields that exceed the line length. Fixed infinite loop.
8681 (read_one_set_of_repetitions) Numerous minor changes for more
8682 complete SPSS compliance. Message fixes.
8684 * dfm.c: (dfm_close) If the file being closed is the inline file,
8685 read all the remaining data before closing it.
8686 (dfm_get_record) Don't close the file on lossage, as either it
8687 has been closed already or it doesn't belong to us.
8689 * error.c: (puts_stdout) New function.
8690 (vmsg) Use puts_stdout instead of puts.
8692 * file-handle.q: (fh_record_width) New function.
8694 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8697 (input_program_source_read) Made an old kluge an approved method.
8699 * lexer.c: (syntax_error) New function.
8701 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8704 * output.c: (oupt_get_paper_size) Message fix.
8706 * q2c.c: Numerous fixes to formatting of generated code made to
8707 conform to GNU coding standards. Uses syntax_error() in generated
8708 code. Other miscellaneous generated message fixes. Added support
8709 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8710 RAND_MAX, and/or strerror().
8712 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8714 * data-in.c: Comment fixes.
8716 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8717 (find_variable_input_spec) New function.
8718 (cmd_repeating_data) Initializes id_spec.
8719 (rpd_parse_record) Implemented.
8720 (read_one_set_of_repetitions) Returns -3 by default in order to
8721 kluge out some potential bugs.
8723 * data-out.c: Comment fixes.
8725 * file-type.c: (internal_cmd_record_type) Message fix.
8727 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8728 for handling -3 return value.
8730 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8732 * data-list.c: Comment fixes.
8733 (struct dls_var_spec) Reordered members.
8734 (read_from_data_list_fixed) Restructured.
8735 (struct repeating_data_trns) Reordered members. Renamed `starts'
8736 as `starts_beg', `ends' as `starts_end'.
8737 (cmd_repeating_data) Calculates length of repeated data if
8738 necessary and possible.
8739 (parse_num_or_var) Don't allow string variables.
8740 (realize_value) New function.
8741 (rpd_msg) New function.
8742 (rpd_parse_record) New function. Currently stubbed out.
8743 (read_one_set_of_repetitions) Implemented.
8745 * inpt-pgm.c: (input_program_source_read) Comment fix.
8747 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8749 * command.c: (cmd_end_repeat_p) Removed.
8750 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8751 (parse_cmd_name) Removed.
8753 * data-list.c: Comment fixes.
8754 (data_list_pgm) Removed `eof' member.
8755 (static var first) New var.
8756 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8757 FILE TYPE file inside FILE TYPE structures.
8758 (append_var_spec) Appends to *first, not dls.spec.
8759 (parse_fixed) Message fixes.
8760 (struct rpd_num_or_var) New.
8761 (struct repeating_data_trns) New.
8762 (static var rpd) New.
8763 (cmd_repeating_data) New function.
8764 (parse_num_or_var) New function.
8765 (parse_repeating_data) New function.
8766 (read_one_set_of_repetitions) New function.
8768 * file-type.c: (cmd_file_type) Message fixes. Always
8769 default_handle to FILE TYPE file handle.
8770 (internal_cmd_record_type) Message fixes.
8772 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8774 * repeat.c: Comment fix. Disable debugging.
8776 * temporary.c: (restore_dictionary) Sets splits to NULL and
8777 n_splits to 0 before destroying the variables because now doing
8778 this tries to remove split variables.
8780 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8781 destroying the dictionary.
8782 (clear_variable) Removes a variable from splits after destroying
8785 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8787 * cmdline.c: (set_compat) Removed.
8788 (pick_compat) Removed.
8789 (parse_command_line) Removed -c option.
8790 (pre_syntax_message) Removed -c option.
8791 (usage) Remove compatibility code.
8793 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8794 (glob var compat) Removed.
8796 * compute.c: (type_check) Fixed messages about type mismatches.
8798 * data-list.c: (cmd_data_list) Removed compatibility code.
8799 (fixed_parse_compatible) Calls convert_negative_to_dash().
8800 Fixed bug where it only set the variable in fx.spec if it created
8801 the variable itself.
8802 (dump_fmt_list) Spelling fix.
8803 (cut_field) Removed compatibility code.
8805 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8808 * expr-evl.c: (evaluate_expression) Implement LAG.
8810 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8811 (parse_neg) Calls convert_negative_to_dash().
8812 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8815 * expr.h: (struct expression_struct) Removed member max_lag.
8817 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8818 (internal_cmd_record_type) Removed special handling to produce
8819 negative numbers from dash tokens.
8821 * getline.c: (static var DO_REPEAT_level) New var.
8822 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8823 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8824 copy_with_DO_REPEAT_substitutions().
8825 (getl_read_line) Maintains value of getl_mode. Calls
8826 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8828 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8830 * getline.h: (getl_mode) New glob var.
8832 * glob.c: Comment fixes.
8833 (init_glob) Restructured. Sets set_seed.
8834 (init_compat_dependent) Removed. All references removed.
8835 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8836 (__htonl, __htons) Removed. (What were these for?)
8838 * lexer.c: (static var tbl) Dash set to class CNUM.
8839 (make_hexit) New function from data-out.c.
8840 (get_token_representation) Rewritten.
8841 (convert_negative_to_dash) New function.
8842 (lex_init_compat_dependent) Removed.
8843 (yylex) A dash is parsed as part of a number if it is followed by
8844 a digit. The ASCII representation of a number is copied to
8845 tokstr. String parsing farmed out to parse_string(). Comment
8847 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8849 (preprocess_line) Line processing depends on interactive/batch
8850 mode, not on compatibility mode. Removed PC+ compatibility code.
8852 * loop.c: (loop_3_trns_proc) Comment fix.
8854 * main.c: Remove dead code.
8855 (main) Remove call to init_compat_dependent().
8857 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8860 * print.c: (parse_string_argument) Calls
8861 convert_negative_to_dash().
8862 (fixed_parse_compatible) Calls convert_negative_to_dash().
8864 * repeat.c: (RPT_* defines) Removed.
8865 (struct rpt_numeric) Removed.
8866 (struct repeat_entry) New member type, changed `replacement' from
8868 (clean_up) Deallocation adapted to new repeat_entry.
8869 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8870 usage. Creates vars for `type' of 1.
8871 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8872 (store_numeric) Rewritten, new interface.
8873 (parse_numbers) Rewritten.
8874 (parse_strings) Rewritten.
8875 (find_DO_REPEAT_substitution) New function.
8876 (perform_DO_REPEAT_substitutions) New function.
8877 (copy_with_DO_REPEAT_substitutions) Removed.
8878 (debug_print) Rewritten.
8880 * set.q: Comment fix.
8881 (custom_results) Removed compatibility code.
8882 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8885 * sysfile-info.c: (cmd_display) Removed compatibility code.
8887 * tokens.h: Comment fixes.
8888 (token types enum) Removed `toktype' typedef name for this int
8889 type. Removed SUBST. Restructured.
8891 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8893 * vars-prs.c: Comment fix.
8895 * vfm.c: Comment fixes.
8896 (glob var n_lag) New var.
8897 (static vars lag_count, lag_head, lag_queue) New vars.
8898 (procedure) Removed argument nlag.
8899 (setup_lag) New function.
8900 (close_active_file) Discards lagging state.
8901 (lag_case) New function.
8902 (lagged_case) New function.
8903 (write_case) Lags a case if lagging.
8905 * weight.c: (cmd_weight) Removed compatibility code.
8907 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8909 * getline.h: (struct getl_script) New members loop_index, macros.
8911 * getline.c: (getl_add_file) Sets first_line field to NULL.
8912 (getl_add_DO_REPEAT_file) New function.
8913 (handle_line_buffer) When the current line's length is negative,
8914 set the filename and line number. Increment line number after
8915 reading line. Pass the line to
8916 copy_with_DO_REPEAT_substitutions() for processing.
8917 (getl_close_file) Free DO REPEAT lines before freeing the
8918 filename, and just set the filename to NULL when doing this,
8919 because otherwise the filename gets freed twice.
8921 * glob.c: (glob var queuing) Removed. All references removed.
8923 * lexer.c: Comment fixes.
8924 (get_token_representation) New function.
8926 * repeat.c: Comment fixes.
8927 (struct repeat_entry) Replaced type and v union members with a
8929 (append_record) New function.
8930 (internal_cmd_do_repeat) Started reforming it for the new
8931 repeat_entry struct. Properly records filename changes in the
8932 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8933 strncasecmp() result usage. Uses append_record() to simplify.
8934 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8937 (copy_with_DO_REPEAT_substitutions) Started coding.
8939 [DEBUGGING] (debug_print_lines) New function.
8941 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8943 * tokens.h: (macro is_id1, is_idn) New macros.
8945 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8947 * cmdline.c: (static var pre_syntax_message) Changed `win'
8948 compatibility mode to `wnd'.
8950 * data-list.c: (fixed_parse_spss) Renamed
8951 fixed_parse_compatible().
8953 * glob.c: (init_glob) Excise unused code for
8954 program_invocation_short_name.
8956 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8959 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8961 * set.q: `win' compatibility renamed `wnd'.
8963 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8965 * filename.c: [__WIN32__] Change the included Windows header files
8967 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8968 second character is absolute.
8969 (dirname) Fix logic error. Don't printf() the results.
8970 (prepend_dir) Don't printf() the results.
8972 * getline.c: (handle_line_buffer) New function.
8973 (getl_read_line) Reads line with handle_line_buffer() when
8975 (getl_close_file) Discard line buffer data.
8977 * getline.h: Comment fixes.
8978 (struct getl_line_list) New struct.
8979 (getl_script_struct) Added line buffer members. These are hooks
8980 for use by DO REPEAT to allow it to insert virtual source code
8983 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
8984 Override Borland C++ stupidity that claims Windows has a console
8987 * repeat.c: This is in the process of being restructured from
8988 using a token-buffering approach to the DO REPEAT facility to
8989 using the more flexible approach of a line-buffering approach in
8990 conjunction with the getline module. Comment fixes.
8991 (struct tok_struct) Removed.
8992 (static vars queue_index, queue_head, queue) Removed.
8993 (static vars line_buf_head, line_buf_tail) New vars.
8994 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
8996 (pull_queue, destroy_queue) Removed.
8997 [DEBUGGING] (debug_print_tokens) Removed.
8999 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9001 * file-handle.q: (prepend_current_directory) New function.
9002 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9003 current directory before normalizing filename.
9005 * filename.c: (gnu_getcwd) New function.
9006 (absolute_filename_p) New function.
9007 (search_path) New argument, PREPEND. All references changed to
9008 pass NULL except those explicitly mentioned. Uses
9009 absolute_filename_p(). Prepends PREPEND before trying the
9011 (dirname, prepend_dir) New functions.
9013 * getline.c: (getl_get_current_directory) New function.
9014 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9017 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9019 * In several source files, the term `script' was replaced with
9020 `syntax file' inside error messages. Usage of the term `script'
9021 in the sense of a syntax file is now deprecated.
9023 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9026 * dump-sysfile.c: (usage) Update message.
9028 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9030 * getline.h: (glob var getl_include_path) Declare extern.
9032 * list.q: Define EXTERN as extern before #including somP.h.
9034 * var.h: Remove declaration of `disptype' variable.
9036 * vfm.c: (close_active_file) After switching the data sink to a
9037 data source, set vfm_sink to NULL, because it doesn't exist any
9040 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9042 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9043 _matherrl() to ignore all math errors.
9045 * sfm-read.c: (read_value_labels) When reading the labels from
9046 disk, read the little parts separately instead of as a struct;
9047 this avoids alignment problems.
9049 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9050 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9051 (write_header) Allocates and initializes elem_type.
9052 (sfm_write_case) Uses elem_type to determine how to handle each
9054 (sfm_close) Frees elem_type.
9056 * sfmP.h: Comment fix.
9057 [__BORLANDC__] Uses #pragma -a to adjust structure member
9060 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9062 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9064 * common.c: Fix typo.
9066 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9067 sense of the condition.
9069 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9070 line-continuation backslash.
9072 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9074 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9075 non-constant expression as an argument to sizeof.
9077 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9078 undefine gettext macro because that's a conio function.
9080 * hash.h: (hsh_prime_tab declaration) Remove.
9082 * list.q: (write_fallback_headers) Move `leader' allocation out of
9083 main loop. Change to local_alloc() allocation.
9085 * output.h: Formatting fixes. Put __attribute__ in right place on
9086 function prototypes.
9088 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9089 incorrect `SECOND_LOWEST_VALUE' references to proper
9090 `second_lowest_value'.
9092 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9093 value. This way 2 out of 3 of the som files define the vars
9094 extern, the correct way, that actually works under BC++.
9095 (som_set_float) Don't use nonconstant initializers for a struct.
9097 * som-high.c: Add the standard alloca() header.
9098 (replicate_table) Add prototype.
9100 Merged DISPLAY routine.
9101 * sysfile-info.c: (AS_*) New enum series.
9102 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9104 (cmd_display, display_macros, display_documents,
9105 display_variables) Stolen from defunct display.c.
9106 (describe_variable) New function.
9108 * temporary.c: [0] (display_tree) New debug function.
9109 (copy_variable) Performs shallow copy of value labels instead of
9110 deep copy; i.e., just copys the AVL tree and increments the
9113 * val-labs.c: Comment fixes.
9114 (do_value_labels) Optionally skip leading forward slash.
9115 (get_label) Creates only a single value label instead of many
9116 copies of one, and sets the reference count.
9118 * display.c: Removed.
9120 * dump-sysfile.c: New file, not yet complete.
9122 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9124 For lots of source files I added more verbose_msg's. These aren't
9125 listed below as they have tested as being benign. In some cases
9126 these replaced debug_printf() calls.
9128 * output.c: (outp_read_devices) Message fix.
9130 * postscript.c: (output_encodings) Message fix. Reports errors on
9132 (postopen) Message fix.
9134 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9136 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9138 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9141 * main.c: Remove <malloc.h> #include.
9143 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9144 instead of trying to just set the missing[] itself, which is a
9147 * sfm-read.c: (read_variables) Same.
9149 * str.h: Add memmem() prototype.
9151 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9153 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9155 * Makefile.am: (q2c) Don't include any libraries in the link.
9157 * dfm.c: (force_line_buffer_extension) New macro.
9158 (count_tabs) New function.
9159 (tabs_To_spaces) New function.
9160 (read_record) Calls tabs_to_spaces() on the line being processed.
9162 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9163 have to be compiled twice (once for CC, once for LOCAL_CC).
9165 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9167 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9168 (LDADD) Add @INTLLIBS@.
9169 (q2c) Add LIBS, @INTLLIBS@ to link step.
9171 * inpt-pgm.c: Turn off debugging.
9173 * postscript.c: (postopen) Format fix. local_free() blocks
9174 returned by local_alloc(); don't free() them.
9176 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9178 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9181 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9182 LEN arg, not simply the full string length.
9184 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9185 directories before generic temp file directories.
9187 * vfm.c: Disable debugging.
9189 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9191 * get.c: Comment fix.
9192 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9194 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9196 * expr-prs.c: (debug_print_postfix) Conditionally included on
9197 GLOBAL_DEBUGGING. Removed out_header() reference.
9199 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9201 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9203 * ascii.c: Removed obsolete ascii_close_page() prototype.
9205 * command.c: (output_line) Comment fix.
9207 * data-in.c: Formatting fix.
9208 (parse_string_as_format) Now the `fc' argument is used only for
9209 the purpose of error messages; it is not an index into the string
9210 passed. All references changed.
9212 * data-list.c: Comment fix.
9213 (cut_field) Comment fix. Now returns the column number of the
9214 position of the field cut out on success.
9215 (parse_field) Added `column' argument. Puts the column numbers in
9217 (read_from_data_list_free, read_from_data_list_list) Record the
9218 column number returned by cut_field(), pass it to parse_field().
9220 * dfm.c: Comment fix.
9222 * do-ifP.h: Comment fix.
9224 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9225 the SYSMIS function.
9227 * expr.h, exprP.h: Comment fix.
9229 * glob.c: (init_glob) Only calls setlocale() and family if
9232 * hash.h: Comment fix.
9234 * include.c: Comment fix.
9236 * output.c: Comment fix.
9238 * postscript.c: (ps_line_intersection) Simplified assertion.
9240 * repeat.c: Comment fix.
9242 * vars-atr.c: Comment fix.
9244 * vars-prs.c: Comment fix.
9246 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9247 behavior with usage of postincrement.
9248 (memory_stream_read) Discards cases as it goes.
9250 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9252 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9255 * Most source files: Includes debug-print.h, related comment
9258 * cases.c: (alloc_val) Removed complex allocation code. Merely
9259 increments default_dict.nval and returns the former value.
9260 (envector, devector) Removed references to lv member of struct
9263 * common.h: (macro VME) Replaced complex definition with simple
9266 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9267 read_active_file and cancel_input_pgm.
9268 (read_from_data_list, cancel_data_list) Removed.
9269 (data_list_source_read, data_list_source_destroy_source) New
9271 (glob var data_list_source) New var.
9273 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9274 (cmd_begin_data) Improved criteria for an input program accessing
9275 the inline file. Still not perfect.
9277 * do-if.c: (do_if_trns_proc) Simplified debug output.
9279 * expr-prs.c: Comment fixes.
9280 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9282 * file-handle.q: (fh_close_handle) Simplified debug output.
9284 * file-type.c: Comment fixes.
9285 (cmd_file_type) Sets vfm_source instead of read_active_file and
9287 (cmd_end_file_type) On failure, discards variables in place of
9288 just canceling the input program.
9289 (read_from_file_type) Renamed file_type_source_read.
9290 (cancel_file_type) Renamed file_type_source_destroy_source.
9291 (glob var file_type_source) New var.
9293 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9294 (cmd_get) Initializes options to GTSV_NONE before passing to
9295 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9296 instead of read_active_file and cancel_input_pgm.
9297 (cmd_save_internal) Initializes options before passing to
9298 trim_dictionary(). Local var `nval' removed.
9299 (dict_delete_run) Comment fixes.
9300 (trim_dictionary) Comment fixes. Disallows scratch variables if
9301 GTSV_OPT_SAVE set in options.
9302 (read_from_get) Renamed get_source_read.
9303 (cancel_get) Renamed get_source_destroy_source.
9304 (glob var get_source) New var.
9306 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9307 read_active_file and cancel_input_pgm.
9308 (read_from_input_program) Renamed input_program_source_read.
9309 Simplified debug output.
9310 (cancel_input_program) Renamed
9311 input_program_source_destroy_source.
9312 (glob var input_program_source) New var.
9314 * loop.c: (loop_1_trns_proc) Simplified debug output.
9316 * main.c: (dump_token) Made eof output more explicit.
9318 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9321 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9322 code for always-memory or always-disk cases. malloc's case-list
9323 based on vfm_source_info.ncases. Explicit support for
9324 memory_stream via memory_source_cases.
9325 (do_external_sort) Sets vfm_source instead of read_active_file and
9327 (allocate_file_handles) The temporary directory permissions are
9328 set to 0700 instead of 0777.
9329 (allocate_cases) Formatting fixes. Simplified debug output.
9330 (output_record) Compacts the case if necessary before writing it
9332 (close_handle, open_handle_w) Simplified debug output.
9333 (write_initial_runs) Destroys vfm_sink, then sets it to
9334 sort_stream. Writes records to memory based on
9335 vfm_sink_info.case_size.
9336 (write_to_sort_cases) Renamed sort_stream_write().
9337 (merge) Simplified error handling. Simplified debug output.
9339 (read_from_external_sort) Renamed sort_stream_read().
9340 Reads records based on vfm_source_info.case_size.
9341 (sort_stream_write) Writes records to memory based on
9342 vfm_sink_info.case_size.
9343 (sort_stream_mode) New function.
9344 (glob var sort_stream) New variable.
9346 * temporary.c: (cmd_temporary) Simplified debug output.
9347 (copy_variable) Removed references to `lv'.
9349 * title.c: (get_title) Simplified debug output.
9351 * var.h: Comment fixes.
9352 (struct get_proc) Removed member `lv'.
9353 (struct variable) Removed member `lv'. Comment fixes.
9354 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9356 (struct case_stream) New.
9358 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9359 read_active_file references to use vfm_source.
9360 (init_variable, replace_variable) Removed references to `lv'.
9362 * vfm.c: Comment fixes.
9363 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9365 (static var queue, qh, qt, n_lag) Removed. All references
9367 (glob var compaction_necessary, compaction_nval, compaction_case,
9368 paging) New variables.
9369 (record_case) Removed.
9370 (procedure) Comment fixes. Calls vfm_source->read() instead of
9373 (prepare_for_writing, arrange_compaction, make_temp_case,
9374 vector_initialization, setup_filter) New function.
9375 (open_active_file) Most of the code moved into the abovementioned
9376 new functions. Now sets temp_dict to &default_dict if there is no
9377 temporary dictionary, for convenience. New debug output.
9378 (close_active_file) Deals with changing the sink to the source.
9379 Calls finish_compaction(). Frees compaction_case. Mostly
9381 (glob vars disk_source_file, disk_sink_file) New vars.
9382 (destroy_active_file, read_from_memory) Removed.
9383 (disk_stream_init, disk_stream_read, disk_stream_write,
9384 disk_stream_mode, disk_stream_destroy_source,
9385 disk_stream_destroy_sink) New functions.
9386 (glob var vfm_disk_stream) New var.
9387 (glob vars memory_source_cases, memory_sink_cases,
9388 memory_sink_iter, memory_sink_max_cases) New vars.
9389 (memory_stream_init, memory_stream_read, memory_stream_write,
9390 memory_stream_mode, memory_stream_destroy_source,
9391 memory_stream_destroy_sink) New functions.
9392 (glob var vfm_memory_stream) New var.
9393 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9394 named `more_cases'. Simplified debug output. Otherwise mostly
9396 (record_case) Moved into the stream drivers. Removed.
9397 (transform) Removed (was dead code).
9398 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9399 common case that the splits don't change, we don't need to copy
9400 the case into prev_case again--pointless.
9401 (compact_case) New function.
9402 (finish_compaction) New function.
9404 * vfmP.h: Comment fixes.
9405 (DEV_* enum series) Removed.
9406 (struct storage) Renamed `stream_info'. Removed variant record.
9407 Removed `device' member.
9409 * debug-print.h: New file.
9411 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9413 * autorecode.c: Turned off debugging.
9415 * data-list.c: (destroy_dls) Closes the associated file handle.
9417 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9418 parse_variables() options.
9420 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9422 * display.c: (display_variables) Really fixed null cell bug.
9424 * file-handle.q: (fh_close_handle) Changed debugging message.
9426 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9427 parse_variables() options.
9429 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9430 (cmd_list) Fails if no variables specified.
9431 (determine_layout) Writes blank lines manually.
9433 * loop.c: (loop_1_trns_proc) Made debugging code only print
9434 messages if debugging.
9436 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9437 parse_variables() arguments.
9438 (main) Parses optional parenthesized options to varlist
9439 subcommands into sbc->message.
9441 * sfm-read.c: Format fix.
9443 * var.h: (FV_*) New enum series.
9444 (PV_*) New enum PV_NO_SCRATCH.
9446 * vars-prs.c: (find_var) Removed.
9447 (fill_all_vars) Takes FV_* enum instead of boolean third
9448 argument. Rewritten to deal with scratch as well as system
9450 (parse_variables) Error message on scratch variable if
9453 * vfm.c: (static var virt_begin_func) New var.
9454 (procedure) Sets up virt_begin_func.
9455 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9456 after dump_splits(). For succeeding groups changes, calls
9457 virt_begin_func() instead of begin_func().
9459 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9461 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9464 * dfm.c: Added some debugging messages, disabled by default.
9465 (open_file_r) Fixed error message.
9466 (read_record) On eof on inline_file, instead of calling
9467 fh_close_handle(), simply jump to eof label like a normal file.
9470 * display.c: Thin lines between rows for certain kinds of
9471 listing. Fixed `null cell' bug.
9473 * error.c: (failure) Flush stdout, stderr before failing.
9475 * file-handle.q: (fh_close_handle) Added debugging message.
9477 * frequencies.q: (dump_full) Bottom line extends across entire
9478 table width. Changed title formatting.
9479 (dump_condensed) Changed title formatting.
9480 (dump_statistics) Fixed title formatting.
9482 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9483 Sets default value of set_format.
9485 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9486 Passes write_all_headers() to procedure() as pre-group func.
9487 (write_all_headers) New function.
9488 (determine_layout) Removed calls to write_header().
9489 Calls blank_line() before and after write_fallback_headers().
9491 * recode.c: (recode_trns_free) Only attempts to free head->map if
9494 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9495 file variable names but gives a warning. Sets `left' based on
9496 first character being/not being `#'. On lossage frees dict->var.
9498 * som-high.c: (som_draw_title) Simplified title formatting.
9500 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9502 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9504 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9505 beginning. Frees v_src, v_dest on successful exit. Frees
9506 h_trans[*], h_trans on lossage.
9507 (recode) Frees h_trans[*], h_trans.
9509 * dfm.c: (dfm_close) Formatting change.
9510 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9511 longer allocates its own in inline_file.
9512 (open_file_r) Passes the local dfm_fhuser_ext to
9514 (open_file_w) Message fix.
9515 (read_record) Buffer reallocation strategy changed. Frees
9516 ext->line even in inline_file to prevent leaks.
9517 (dfm_put_record) Fixed bug where `ext' was cached before the file
9518 was opened and thus it would be NULL when the file really was
9520 (cmd_begin_data) Sets up inline_file basics itself, then calls
9521 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9523 * list.q: (write_line) Formatting fix.
9524 (clean_up) Minor strategy change. Sets proportional font after
9526 (determine_layout) Sets fixed font before writing regular headers,
9527 or after writing fallback headers.
9529 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9530 and KEEP vars after using them.
9532 * postscript.c: (ps_init_driver) Frees x->family.
9533 (postopen) When loading fonts, free the temporary font name buffer
9535 (ps_text_set_font_by_position) Free temporary font name buffer
9537 (text) Fixed code that calculated `lig' so that `lig' always gets
9538 initialized. Formatting fix.
9540 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9542 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9543 cells, not xmalloc(), so that the cells will get destroyed
9546 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9549 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9551 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9554 * dfm.c: Comment fix.
9556 * list.q: Comment fixes. Include somP.h. Removed static vars
9557 table, n_columns, n_rows, part. New struct list_ext. New static
9559 (n_lines_remaining, n_chars_width, write_line) New functions.
9560 (cmd_list, list_cases) Rewritten.
9561 (begin_row, end_row, flush_table) Removed.
9562 (write_header, clean_up, write_varname, write_fallback_headers,
9563 determine_layout) New functions.
9565 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9567 * output.h: Comment fix.
9569 * postscript.c: Comment fix.
9570 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9571 added font_size. All references changed.
9572 (ps_init_driver) Initializes font_size. Simplified space checking
9574 (static var option_tab[]) Removed prop-size, fixed-size; added
9576 (ps_option) Handles font_size.
9578 * som-high.c: Moved prototypes into somP.h.
9579 (som_init_driver) New function.
9580 (som_submit_table) Moved some code into new function
9582 (build_target) Moved some code into new function
9583 som_internal_eject_page().
9584 (som_eject_page) Uses som_internal_eject_page().
9585 (som_internal_eject_page) New function.
9587 * som-low.c: Moved prototypes into somP.h.
9589 * som.h: Formatting fixes.
9591 * somP.h: (struct som_driver_ext) Removed em_width;
9592 added prop_em_width, fixed_width.
9594 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9596 * Makefile.am: Added `localedir' definition. Added
9597 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9599 * ascii.c: (macro draw_line) Fixed capitalization.
9601 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9602 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9603 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9604 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9605 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9606 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9607 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9608 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9609 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9610 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9611 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9612 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9613 for internationlization.
9615 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9617 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9619 * do-if.c, sort.c, val-labs.c: Comment fixes.
9621 * glob.c: (init_glob) Uncommented, updated i18n support.
9623 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9624 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9625 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9626 the declarations of macros taking arguments a lot nicer.
9628 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9630 * error.h: Removed CE, CW aliases for SE, SW.
9632 * q2c.c: Removed explicit streq() definition since it's duplicated
9635 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9636 stats.h, str.h, tokens.h: Made the declarations of macros taking
9637 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9640 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9642 * cmdline.c: Comment fixes.
9643 (pick_compat) Changed return type to int. Now, instead of setting
9644 glob var `compat' to the emulation, returns the emulation. All
9646 (parse_command_line) Added terminating null to end of
9647 `long_options' array definition.
9648 (pre_syntax_message) Fixes.
9649 (usage) Shows the default emulation in the syntax message by
9650 calling pick_compat().
9652 * getline.c: (getl_add_include_dir) Separates paths with
9653 PATH_DELIMITER, not DIR_SEPARATOR.
9655 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9656 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9658 * output.c: (outp_configure_macro) Make earlier definitions for a
9659 particular key override later ones for the same key.
9661 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9663 * ascii.c: Comment fixes.
9665 * output.c: (outp_get_paper_size)
9666 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9668 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9670 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9671 <errno.h>. GNU libc 2 enforces this!
9673 * command.c: (parse_cmd) Fixed problem with `else' clause being
9674 paired with wrong `if'. Comment fix.
9676 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9678 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9679 blp_getline() to getline().
9681 * output.c: (outp_eval_dimension) Changed the fix from last time;
9682 there was no variable `a'.
9684 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9686 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9688 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9689 numbers having fractional parts. Added case of a fraction without
9690 a whole-number part.
9692 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9694 * ascii.c: (ascii_text_get_font_position) Removed.
9696 * expr.h, exprP.h: Disabled debugging.
9698 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9701 * output.h: (struct outp_class_struct) Removed
9702 text_get_font_position method. All references deleted.
9704 * postscript.c: Big change here. Fontmaps were completely
9705 eliminated because of a change in philosophy. Comment fixes.
9706 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9708 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9709 `fixed_name' members removed. New members `prop_family',
9710 `fixed_family'. `family' member changed to type char *.
9711 (static var ps_fontmaps) Removed.
9713 (ps_init_driver) Removed obsolete references, updated.
9714 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9715 fontmap, of course. Refers to font names through internal_name
9716 rather than subversive means. Frees proper items.
9717 (static var option_tab[]) Removed `fontmap-file' option; renamed
9718 `fixed-font', `prop-font'.
9719 (ps_option) Corresponds to option_tab[].
9720 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9721 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9722 hash_family) Removed.
9723 (postopen) Generates font names from family names. Gets
9724 PostScript font name properly. New prologue file comment `!!!'
9726 (ps_open_page) Adds translate_x, translate_y to BP prologue
9727 function; gives SF argument floating-point format.
9728 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9729 font name. Doesn't change font family.
9730 (ps_text_set_font_by_position) Generates Groff font name from font
9731 family name instead of through table lookup.
9732 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9733 all references changed. Reduced to simple string assignment.
9734 (ps_get_font_name) Removed.
9735 (ps_get_font_family) Reduced to string return.
9736 (text) Doesn't save `position' since it no longer exists. Ugly
9737 kluge to save font family--fix soon?
9738 (load_font) Removed PostScript name argument.
9740 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9742 * postscript.c: Comment fix.
9743 (ps_open_page) Puts scale factor in PostScript output.
9745 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9747 * Makefile.am: Distcleans q2c.
9749 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9751 * ascii.c: (delineate) Sets text size even if width is zero.
9753 * command.c: Comment fix.
9754 (static var cmd_table[]) Re-enabled EVALUATE command.
9755 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9756 of comments in script files. Now more liberal on criteria for
9757 performing a state transition--if *anything* happened correctly,
9758 not just if *everything* happened correctly.
9760 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9761 Checker segfault on formatting large numbers and why in the fsck
9762 hadn't I noticed this before?
9764 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9766 * list.q: (cmd_list) Commented out the actual output routine
9767 because of various problems. Probably will abandon the idea of
9768 using the general `crushed tables' for the LIST procedure.
9770 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9771 clearing it. Allocates a new var_by_name dictionary before trying
9772 to add members to it.
9774 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9775 `sib'. Changed type of `node' argument.
9776 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9778 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9779 [DEBUGGING] Only deletes the variable from var_by_name if that var
9782 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9784 * Makefile.am: Added include files to SOURCES. Added
9785 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9786 includes rules for q2c. Added `boast' target.
9788 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9790 * Makefile.am: Maintainer-clean Makefile.in.
9792 * Makefile.am: Fixed redundant EXTRA_DIST line.
9794 * ascii.c: Comment fixes.
9795 (ascii_line_vert) Fixed overly aggressive range check.
9797 * display.c: Removed dead code.
9799 * list.q: Turn debugging on.
9800 (flush_table) New debug code.
9802 * sfm-read.c: (read_value_labels) malloc's the structure before
9803 trying to assign to its members.
9805 * sfm-write.c: Comment fix.
9807 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9809 (output_table) No arguments anymore--gets them through `som'
9810 global. New debug code. In crushed tables, now sets `htv' as
9811 well as `hv' to avoid bad confusion later.
9812 (dump_crush_page) New debug code.
9814 * som-low.c: (som_dump_crush_page) New debug code.
9816 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9818 All source files: Broke long lines into multiple lines.
9820 * ascii.c: (ascii_close_page) Uses host_system var in place of
9821 HOST_SYSTEM constant.
9823 * cmdline.c: (var syntax_message[]) Broke into
9824 pre_syntax_message[] and post_syntax_message[].
9825 (usage) Outputs both parts, separated by driver list.
9827 * error.h: Fixed broken formatting.
9829 * expr-opt.c: (str_search, str_rsearch) New functions.
9831 * misc.c: (blp_getdelim) Removed. All references changed to
9833 (str_search, str_rsearch) Removed.
9834 (memrmem) New function.
9836 * misc.h: (blp_getline) Removed. All reference changed to
9841 * filename.c: Includes "stat.h", not <sys/stat.h>.
9842 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9844 * output.c: (outp_list_classes) Changed output formatting.
9846 * sfm-write.c: (write_header) Uses host_system var instead of
9847 HOST_SYSTEM constant.
9848 (write_rec_7_34) Extracts version numbers from the version string.
9851 * sort.c: Includes "stat.h", not <sys/stat.h>.
9853 * str.c: (strcasecmp) Removed.
9855 * title.c: (cmd_document) Uses host_system var instead of
9856 HOST_SYSTEM constant.
9858 * version.c: Generated on-the-fly by the Makefile instead of being
9861 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9863 [!HAVE_STRNCASECMP] Declares strncasecmp().
9865 * version.h: Removed stray character. Comment fixes.
9866 (vars host_system, build_system) New vars.
9868 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9870 * Most source files: Changed formatting of copyright notice; fixed
9871 FSF address; reformatted to better conform to GNU standards;
9872 comment fixes. Added markups to prevent GNU indent from messing
9873 up my beautiful formatting :-).
9875 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9876 that GNU indent markups can be passed through without problems.
9878 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9880 * get.c: Turned off debugging.
9882 * glob.c: (init_glob) Turned on save-file compression by default.
9884 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9885 compression than was possible in save files.
9887 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9889 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9891 * frequencies.q: Removed Fiasco extensions. Updated calculation
9892 algorithms. Polished output format.
9893 (struct frq_info_struct) Removed members `max_degree', `min_n',
9894 all references removed.
9895 (macro frq_extensions) Removed.
9896 (static vars min_n, max_degree) Removed, all references removed.
9897 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9898 calculate `min_n', `max_degree'.
9899 (postcalc) Passes new arg to dump_statistics().
9900 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9902 (dump_condensed) Adds variable name title.
9903 (sum_freqs) Removed.
9904 (calc_stats) Updated calculation algorithm.
9905 (dump_statistics) Removed warning for too-few observations.
9906 Changed table formatting. Adds variable name title if passed new
9909 * output.h: Comment fix.
9911 * recode.c, sample.c, sort.c: Disabled debug code.
9913 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9914 Improved debug code.
9916 * var.h: (enum series frq_*) Removed Fiasco extensions.
9918 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9920 * command.c: Added PROCESS IF to command table.
9922 * Lots & lots of places, removed checks for NULLs preceding calls
9923 to free_expression(), which itself checks.
9925 * descript.q: Removed Fiasco extensions. Removed optimizations
9926 for non-weighted active files. Implemented some options.
9927 Finished polishing output format. Comment fixes. Merged
9929 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9930 max_degree, min_n) Removed.
9931 (macro dsc_extensions) Removed.
9932 (struct dsc_info_struct) Removed `min_n' member, all references
9934 (internal_cmd_descriptives) Removed calculation of min_n,
9935 max_degree. Only deals with one `calc' routine instead of two
9937 (precalc) Eliminated redundancy. Updated for changes to
9938 descriptives_proc structure.
9939 (calc) Moved here from `descript.g'. Rewritten to calculate
9940 statistics via `moments about the mean' rather than by summing,
9941 summing squares, summing cubes, and so on.
9942 (postcalc) Rewritten for new-style statistical calculation.
9943 (display) Removed support for displaying variables across rows.
9944 No longer crushes the descriptives table. Removed ancient code.
9945 Added display of N, by variable and listwise.
9947 * descript.g: Removed; merged into `descript.q'.
9949 * expr-evl.c: (evaluate_expression) Now returns a double. For
9950 numeric results, it returns the result as well as storing it in
9951 the passed `value' structure if non-NULL. For string results it
9952 just returns 0.0 and it must be passed non-NULL. Many references
9953 to this function were optimized by use of this change, especially
9954 but not exclusively in `compute.c'.
9956 * frequencies.g: Comment fix.
9958 * glob.c: (glob var process_if_expr) New global var.
9960 * postscript.c: (static var option_tab[]) Corrected entry for
9962 (postopen) Sets x->size to x->prop_size.
9963 (ps_text_set_font_by_name) Sets font size as well as typeface for
9964 PROP and FIXED fonts.
9966 * sel-if.c: (cmd_process_if) New function.
9968 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9969 (sfm_write_dictionary) Sets `n_cases' to 0.
9970 (sfm_write_case) Increments `n_cases'.
9971 (sfm_close) Attempts to seek the system file back to the header
9972 and write the number of cases in its proper slot.
9974 * som-frnt.c: (som_insert_table) Masks off expansion options since
9975 only SOPT_X_NORM seems to work sensibly.
9977 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
9978 with a `fixed' value of 2.
9980 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
9982 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
9983 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
9985 * var.h: (enum series dsc_*) Removed Fiasco extensions.
9986 (struct descriptives_proc) Removed `miss_noweight'; new members
9987 `X_bar', `M2', `M3', `M4', `min', `max'.
9989 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
9991 * vfm.c: (close_active_file) Cancels PROCESS IF.
9992 (write_case) Doesn't process cases unselected by PROCESS IF.
9994 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
9996 * glob.c: (glob var err) Removed.
9998 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
9999 doesn't have to take into account number of value labels since
10000 they're in a subtable anyway. Also, doesn't display more than 10
10001 value labels since we can't yet break pages in subtables.
10003 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10005 * som-frnt.c: (som_change_table_size) Simple change for elegance
10006 that shouldn't change behavior.
10007 (som_set_value) Comment fix.
10009 * som-high.c: (som_submit_table) Message fix.
10011 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10013 * command.c: Added SYSFILE INFO to command table.
10015 * file-handle.q: (fh_handle_filename) New function.
10017 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10020 * main.c: (parse) New return value for command functions, -3.
10022 * misc.h: Comment fix.
10024 * output.h: Comment fixes.
10025 (macro COMPONENTS) Removed.
10027 * postscript.c: (write_text) Modified literal_chars[] so that `('
10028 and ')' are not written to the output in strings as literals.
10030 * sfm-read.c: (sfm_read_dictionary) New argument.
10031 (read_header) New argument. Sets the information structure's
10032 values from the header information.
10033 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10034 bizarre Checker problem, I guess.
10035 (read_variables) Proper cleanup on lossage.
10037 * sfm.h: (struct sfm_read_info) New struct for use by
10038 sfm_read_dictionary().
10040 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10041 currently used just for tables that can be dynamically resized and
10042 thus have to be allocated with arena_malloc() instead of
10043 arena_alloc(). All references changed.
10044 (som_change_table_size) New function.
10045 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10047 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10048 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10051 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10053 (draw_intersection) Now takes an argument specifying the table in
10054 question. All references changed.
10055 (draw_table_cell) New function.
10056 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10057 (som_get_table_size) Many nice new explanatory comments.
10058 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10060 * som.h: New enum series SOM_CREATE_* for use as create flags with
10061 som_create_table().
10063 * str.h: Moved a comment here from TODO.
10065 * sysfile-info.c: New file. Reference implementation.
10067 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10069 * command.c: Added RENAME VARIABLES to table of commands.
10071 * data-in.c: (dls_error) Sets `cust_field'.
10072 (parse_N) Message fix.
10073 (parse_day_count) New function.
10074 (to_roman) Never outputs VX as a `short form' of V.
10075 (parse_month) Fixed parsing of Roman numerals.
10076 (parse_trailer) Message fix.
10077 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10078 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10079 the date is invalid.
10080 (parse_SDATE) Fixed swapped day, year.
10081 (parse_JDATE) Fixed bug for dates in 1582.
10082 (parse_DTIME) Allows days not between 1 and 31.
10083 (parse_numeric) Makes local copy of f.type for easier usage.
10086 * data-out.c: (convert_F) When outputting as scientific, properly
10087 sets f.type as fp->type.
10088 (insert_commas) Fixed operator precedence problem with setting of
10089 nitems. Changed strcpy to memcpy (no null terminator).
10090 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10091 (convert_CCx) Essentially rewritten, but now it works.
10093 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10094 feature of Fiasco).
10095 (display_documents) Implemented.
10097 * error.c: (glob var cust_field) New var.
10098 (vmsg) Displays cust_field as part of message classes DE and DW.
10100 * formats.c: (debug_print) Fixed to compile under updated
10103 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10106 * misc.c: (parse_format_specifier) Formatting fix.
10108 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10109 `n_rename' for clarity.
10110 (cmd_modify_vars) Initializes `forward' and `positional' at
10111 appropriate times. Frees lists of vars to rename on failure.
10112 Comment fix. Frees memory on success.
10113 (rearrange_dict) Simplified `for' loop condition.
10115 * rename-vars.c: New file (reference implementation).
10117 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10119 * sfm-read.c: (read_header) File label is created only if file
10120 label in file is not blank.
10121 (read_variables) Initializes `dict' local variable.
10122 (read_documents) Proper behavior on lossage.
10124 * sfm-write.c: (write_header) Doesn't blank out the file label
10125 (why was this here to begin with?!)
10127 * temporary.c: (save_dictionary) File label is copied only if
10128 non-NULL. Doesn't try to xstrdup() dictionary documents.
10129 Adapted so as to not irritate Checker.
10130 (free_dictionary) Only destroys var_by_name if non-NULL.
10132 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10133 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10134 lines to the document, indents the document. Also, it works now.
10135 (add_document_line) New function.
10137 * var.h: (struct dictionary) Reordering.
10139 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10140 bits if it was allocated to begin with.
10142 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10144 * command.c: Added MODIFY VARS to list of commands.
10146 * configure.in: Updated custom macros for autoconf 2.12. Removed
10147 mmap reference; fixed termcap library reference.
10149 * display.c: (display_variables) Fixed a few bugs although it's
10150 still not well written.
10152 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10153 (induce_segfault) Calls chkr_disp_call_chain() instead of
10154 inducing an actual SIGSEGV.
10156 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10157 str_search() and str_rsearch(). Fixed tests for matches on
10158 OP_INDEX and OP_RINDEX.
10160 * filename.c: (good_getcwd) Removed as the new libc for Checker
10161 doesn't contain this bug, apparently.
10163 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10164 consistency with GNU memmem.
10165 (blp_getdelim) Changed `len' from `int' to `size_t'.
10167 * modify-vars.c: Reference implementation.
10169 * som-frnt.c: (zero_length) New global var.
10170 (som_create_table) Message fix.
10172 * som.h: Added gcc attributions to som_set_text(),
10173 som_output_text() prototypes. blank_line() refers to
10174 zero_length[] instead of a literal null string to suppress gcc
10177 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10178 (allocate_cases) Decrements x_max so the last element of x[] can
10179 be used by the algorithm.
10181 * var.h: Changed minor details of `variable' declaration.
10182 (struct modify_vars_proc) New struct.
10183 (struct variable) Added field p.mfv.
10185 * vars-atr.c: Comment fix.
10187 * vars-prs.c: (fill_all_vars) More optimal implementation.
10189 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10190 character, which it shouldn't have to do but printf() seems to
10191 read the null byte even though I supply a maximum length...
10193 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10195 * command.c: Removed command alias X for QUIT.
10196 (parse_cmd) Fixed comment parsing.
10198 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10200 (read_record) Fixed references to len, size.
10201 (dfm_get_record) Restructured.
10203 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10206 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10209 * modify-vars.c: New file. Not complete.
10211 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10214 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10215 problems caused by int/size_t differences.
10217 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10220 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10221 being compared were of equal length.
10223 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10225 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10227 * lexer.c: (get_dotted_rest_of_line) New function.
10229 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10232 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10233 type 6 records. Frees the dictionary properly.
10234 (read_header) Initializes the dictionary instead of letting
10235 read_variables() do it. Sets the dictionary file label from the
10237 (read_documents) New function.
10239 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10240 write type 6 record if appropriate.
10241 (write_header) Writes file label from dictionary.
10242 (write_documents) New function.
10244 * temporary.c: (save_dictionary, restore_dictionary,
10245 free_dictionary) Properly handle new fields in dictionary struct.
10247 * title.c: (get_title) Returns after failure().
10248 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10249 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10251 * var.h: (struct dictionary) New fields `label', `n_documents',
10254 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10256 * command.c: Added FILTER to list of commands.
10258 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10261 * get.c: (cmd_save_internal) Removed weighting code since it's now
10262 handled by sfm-write.c. Properly commented out debug code.
10264 * glob.c: (glob var weighting) Removed.
10266 * sel-if.c: Comment fixes.
10267 (cmd_filter) New function.
10269 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10270 (sfm_read_dictionary) Sets weighting variable direct in the
10271 created dictionary now. (Apparently we previously didn't support
10273 (read_header) Sets weight_index field in sfm_fhuser_ext from
10274 header read from disk.
10276 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10277 (write_header) Now sets the weighting in the header from the
10278 passed primary dictionary instead of from the sfm_write_info.
10280 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10282 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10283 broke on boundary conditions.
10285 * var.h: (struct dictionary) New fields `weight_var',
10286 `weight_index', and `filter_var'.
10287 (glob var weighting) Removed. This is now part of struct
10288 dictionary. All references changed; the less mechanical changes
10289 are described above.
10291 * vars-atr.c: (find_dict_variable) New function.
10293 * vfm.c: (static var filter_index) New variable.
10294 (open_active_file) Initializes filter_index from default_dict.
10295 (write_case) Calls proc_func() only if the filter variable is
10296 nonzero; this implements FILTER behavior.
10298 * weight.c: (static var weight_varname) Removed.
10299 (cmd_weight) Modified default_dict instead of glob vars.
10300 (update_weighting) Changed the signature to modify a dictionary
10301 instead of glob vars. Now returns the weighting variable.
10302 (get_weighting_variable) Removed; its function is absorbed by
10303 update_weighting().
10304 (stop_weighting) Operates on a dictionary now.
10306 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10308 * sort.c: Removed debugging info from messages.
10309 (do_external_sort) Cleans up after itself by deleting the
10310 temporary directory on failure. (On success it is deleted by the
10312 (allocate_cases) Removed debug code. Added clean up code.
10313 (output_record) Removed debug code.
10314 (merge) Added code to close all the input files that are currently
10315 open. This is a likely location for bugs, because I'm not sure
10316 about boundary conditions. Removed an unnecesary heap_delete().
10317 (merge_once) Removed input file "optimization" that in fact
10318 screwed up the rest of the code. Message and comment fixes.
10320 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10322 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10324 * heap.c: (heap_delete) New argument.
10326 * sort.c: Finished implementation of external sort.
10328 * vfm.c: (read_from_disk) Returns after a disk error.
10330 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10332 * sort.c: (static var state) Removed.
10333 (static vars max_handles, tmp_basename, tmp_extname,
10334 huffman_queue) New variables.
10335 (do_external_sort) Moved most code to new functions.
10336 Creates huffman_queue.
10337 (allocate_file_handles, allocate_cases) New functions.
10338 (static vars run_no, run_length, file_index, case_count) New
10340 (output_record) Returns success. Now really writes to the output
10342 (begin_run, end_run) New functions.
10343 (write_initial_runs) Returns success. Initializes run_no to -1.
10344 Calls begin_run(), end_run() at appropriate times. Outputs debug
10346 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10348 (merge) New function.
10350 * heap.c, heap.h: New files. Hopefully in near-final form.
10352 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10354 * glob.c: Added write_active_file to global vars.
10356 * sort.c: Several new miscellaneous static variables.
10357 (cmd_sort_cases) Big comment fix.
10358 (perform_case_2) Renamed `do_external_sort' and completely
10360 (case_2_proc_func) Removed.
10361 (output_record, write_initial_runs, write_to_sort_cases,
10362 compare_record) New functions.
10364 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10366 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10368 * sort.c: (perform_case_2) Changed the method for allocation of
10369 lots of memory--now allocates one case at a time in hopes that
10370 more cases can be allocated with heavily fragmented memory.
10372 * var.h: (write_active_file) New global var.
10374 * vfm.c: (procedure, close_active_file, write_case,
10375 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10376 arguments to procedure() to be NULL. All references to
10377 procedure() that made use of dummy functions were changed to NULL
10379 (open_active_file) If write_active_file is non-NULL, the output
10380 device becomes DEV_PGM (a new enum).
10381 (close_active_file) Sets write_active_file to NULL.
10382 (read_from_memory) Comment fix.
10383 (record_case) Calls write_active_file() when the output device is
10386 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10388 * sort.c: New file.
10390 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10391 Fixed checking for duplicate varnames.
10392 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10394 (autorecode_trns_free) Destroys hash tables for each recoding
10396 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10398 * command.c: Added SORT CASES to cmd_table.
10399 (null_func, null_int_func) Prototyped.
10401 * descript.g: (calc_weight, calc_noweight) Computes own case
10404 * frequencies.q: (dump_statistics) Fixed problem with
10405 too-few-cases warning message.
10407 * get.c: (cmd_save_internal) Handles weighting properly.
10409 * hash.c: (hsh_dump) Output format changed.
10410 (force_hsh_insert) Actually works now, prototype changed.
10412 * list.q: (static var case_num) New variable.
10413 (cmd_list) Initializes case_num.
10414 (list_cases) Increments case_num.
10416 * var.h: Added definitions for SORT CASES. Comment fixes.
10418 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10419 fixes. `active' renamed vfm_active, `rep' renamed
10420 vfm_replacement, all references changed.
10421 (procedure) The procfunc no longer receives a case number. All
10422 references changed.
10423 (write_case) Subtle reordering.
10424 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10427 * weight.c: (get_weighting_variable) New function.
10429 * vfmP.h: New file with definitions from vfm.c.
10431 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10433 * command.c: (FILE_TYPE_okay) Commented out some tests because
10434 they're clumsy and not yet needed.
10436 * var.h: Most *_trns structures moved to their respective source
10437 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10438 (union any_trns) Changed to a typedef for trns_header.
10439 (struct input_program_pgm) Removed.
10441 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10442 was allocated in the first place.
10444 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10446 * autorecode.c: New file.
10448 * command.c: Added AUTORECODE to command table; re-enabled SET.
10450 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10452 * error.c: (vmsg) Comment fixes.
10454 * hash.c: Comment fix.
10455 (hashpjw_d) New function.
10456 (hashpjw) Reimplemented as call to more general function
10458 (internal_comparison_fn) Initializes pointers properly.
10459 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10460 (force_hsh_insert, force_hsh_find) New debugging wrapper
10463 * main.c: (main) Message fix.
10465 * output.c: (outp_read_devices) Message fix.
10467 * set.q: Comment fixes.
10468 (custom_results) Implemented Wnd/X form of subcommand.
10469 (set_routing) New function.
10470 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10472 * settings.h: (SET_ROUTE_*) New enum series.
10473 (set_results) Renamed set_results_file, all references changed.
10474 (set_messages) Removed.
10475 (glob vars set_errors, set_messages, set_results) New vars.
10477 * title.c: (get_title) Remembers to xstrdup() the result of
10478 get_rest_of_line().
10480 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10482 (union any_trns) New element `arc'.
10484 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10486 * command.c: (output_line) Removed references to set_screen.
10488 * error.c: (static var terminating) New var.
10489 (hcf) Sets terminating to 1.
10490 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10491 This prevents an infinite loop if an error occurs within hcf().
10493 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10494 statement circumlocution with `case 42000' trick.
10495 (evaluate_expression) New support for OP_STR_MIS.
10497 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10498 statement circumlocution with `case 42000' trick.
10499 (dump_node) Handles OP_STR_MIS.
10501 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10502 variables exceptions.
10503 (parse_function) Message fix.
10504 (ops[]) Added OP_STR_MIS.
10506 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10508 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10510 * glob.c: Removed set_scrnfile glob var.
10511 (init_glob) set_errorbreak set to 0 by default.
10513 * groff-font.c: Changed included files.
10514 (groff_read_font) Initializes font_arena local var correctly.
10515 (default_font) New function.
10517 * output.c: Comment fixes.
10518 (glob var disabled_devices) New variable.
10519 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10521 [GLOBAL_DEBUGGING] (reentrancy) New function.
10522 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10523 outp_iterate_enabled_drivers) Calls to reentrancy().
10524 (destroy_list) New function.
10525 (outp_done) Moved code to destroy_list().
10526 (parse_options) Parses `listing', `screen', `printer' options
10528 (configure_driver) Sets new `device' member of driver.
10529 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10531 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10532 (struct outp_driver_struct) New member `device'.
10534 * postscript.c: (find_encoding_file) Doesn't display its own error
10536 (default_encoding) New function.
10537 (switch_font) Calls default_encoding() if no encoding can be
10539 (text) Makes up a character metric if none exists for the desired
10541 (load_font) Properly copies a fallback filename. Calls
10542 default_font() for a font if none at all are known.
10544 * set.q: Comment fixes. Removed OUTPUT subcommand.
10545 (custom_listing) Calls outp_enable_device() to enable/disable
10547 (turn_screen_on) Removed.
10548 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10549 screen, printer devices.
10551 * settings.h: Comment fixes.
10552 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10555 * som-high.c: (som_submit_table, som_eject_page) Use
10556 outp_iterate_enabled_drivers() instead of iterating
10557 outp_driver_list directly.
10559 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10561 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10562 (parse_string_as_format) Handles new formats.
10563 (parse_numeric) Now handles DOT and PCT formats.
10565 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10567 (convert_date) Handle EDATE and SDATE formats.
10568 (convert_CCx) Now if there's not room for the currency characters,
10569 converts it as F format if it's positive instead of giving up
10570 quickly. Also fixed save-and-restore bug with decimal point
10572 (convert_format_to_string) Handles new formats.
10574 * misc.c: (formats[]) Added new formats.
10575 (convert_fmt_ItoO) Supports new formats.
10577 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10578 data checking. New argument, all references changed.
10580 * sfm-write.c: (write_format_spec) Supports new formats.
10582 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10585 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10587 * cmdline.c: Comment fixes.
10588 (parse_command_line) Changed return type to void.
10590 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10592 (parse_numeric) Handles international numbers (comma as decimal
10593 point). Some reformatting.
10595 * data-list.c: (parse_free) Default output format is now
10596 set_format instead of hard-coded F8.2.
10597 (read_from_data_list_list) Emits error message on undefined data
10598 only if set_undefined is nonzero.
10600 * data-out.c: (convert_E) Changes decimal point from period to
10601 comma if appropriate. Restructured. Better comments.
10602 (convert_F) Changes decimal point from period to comma if
10604 (insert_commas) Major bug with handling of negative values fixed.
10605 Also, inserts periods instead of commas if appropriate.
10606 (convert_CCx) New function.
10607 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10608 (num_to_string) Changed `.' to set_decimal.
10610 * dfm.c: Comment fixes.
10611 (dfm_close) Frees ext->line even in inline_file.
10612 (open_inline_file) New function.
10613 (open_file_r) When opening the inline file: now properly
10614 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10616 (read_record) Calls fh_close_handle() instead of dfm_close() to
10617 close the inline file. Makes a copy of the line getl_buf to avoid
10618 interlock problems.
10619 (dfm_get_record) Restructured. Now checks the return value of
10621 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10622 checking for use of inline file. No longer tries to close inline
10625 * error.c: (glob var error_already_flagged) New var.
10626 (vmsg) Message change. Now checks max number of errors/warnings,
10629 * file-handle.q: (fh_handle_name) Now allows closing of
10631 (fh_init_files) Reformatted.
10633 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10635 * getline.c: (getl_include) Fixed bug that popped up when called
10636 when file queue was empty.
10637 (read_console) Resets error_count, warning_count,
10638 error_already_flagged to zero.
10640 * glob.c: Many changes to update list of variables.
10641 (init_compat_dependent) Now this function is called whenever
10642 `compat' changes. It now sets set_seed only if it hasn't
10643 previously been referenced. It now calls
10644 lex_init_compat_dependent().
10646 * include.c: (cmd_include_at) Frees temporary buffer instead of
10648 (cmd_include) Doesn't make copy of include file name.
10650 * lexer.c: Comment fixes.
10651 (init_lex) Moved some code into new function
10652 lex_init_compat_dependent().
10653 (lex_init_compat_dependent) New function.
10654 (hex_val) Simplified.
10655 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10657 * main.c: Comment fixes.
10658 (main) Reformatted.
10660 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10661 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10662 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10663 (setup_randomize) Sets set_seed_used.
10665 * set.q: Comment fixes.
10666 (custom_results) Conditionalizes on `compat'.
10667 (custom_log) Calls custom_journal().
10668 (set_ccx) New function.
10669 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10670 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10671 when set_decimal changes. Range-checks values for MITERATE,
10672 MNEST. Message fixes.
10674 * settings.h: Comment fixes.
10675 (struct set_cust_currency) New struct.
10676 (set_cc[], set_grouping, set_seed_used) New global vars.
10678 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10679 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10681 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10683 * glob.c: Revised variables to correspond to settings.h.
10684 (init_glob) Initializes variables from settings.h properly.
10686 * set.q: Began long-overdue major revision to correspond to new
10687 philosophy. Most code changed.
10689 * settings.h: Mostly changed; reorganized, reordered, large new
10692 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10694 * get.c: (cmd_save_internal) No longer forces compression off.
10696 * sfm-read.c: (read_compressed_data) If eof is reached when
10697 reading a new instruction octet, only signal error if we're in the
10700 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10701 (struct sfm_fhuser_ext) New member `end'.
10702 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10703 (ensure_buf_space) New function.
10704 (sfm_write_case) Reimplemented in order to support compression.
10705 (sfm_close) Writes out the remaining contents of the compression
10708 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10710 * command.c: Defined SAVE and XSAVE commands in command table.
10712 * common.h: second_lowest_value is of type flt64, not double.
10714 * file-handle.h: Comment fix.
10716 * get.c: Comment fixes.
10717 (static var `trns') New.
10718 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10719 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10720 (dict_delete_run) Clears the variables and frees them now.
10721 (trim_dictionary) Sets default for compression.
10722 On KEEP subcommand, frees deleted variables as well as clearing
10723 them. Finally got the sense of the test for deleting all
10725 [DEBUGGING] (dump_dict_variables) Message fix.
10727 * glob.c: (init_glob) set_compression set to 1 by default.
10729 * list.q: Properly #includes config.h.
10731 * misc.h: New macro REM_RND_UP.
10733 * settings.h: Comment fix.
10735 * sfm-read.c: (structs sysfile_header, sysfile_format,
10736 sysfile_variable; inline function bswap_int32) Moved to new file
10738 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10739 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10741 (read_machine_flt64_info) Fixed some problems caused by confusion
10742 between flt64 and double types.
10743 (read_header) Message fix.
10744 (read_variables) Fixed set of cases in which we byte-swap sv.print
10745 and sv.write. Fixed confusion of flt64 and double.
10747 * sfm.h: (struct sfm_write_info) New.
10749 * som-high.c: (som_draw_title) Properly frees `s'.
10751 * temporary.c: (save_dictionary) Comment fix.
10753 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10754 (struct trns_header) Formatting fix.
10755 (struct save_trns) New.
10757 * vars-atr.c: (discard_variables) Comment fix.
10759 * sfm-write.c: New file, baseline release.
10761 * sfmP.h: New file, baseline release.
10763 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10765 * cmdline.c: (parse_command_line) `--version' output updated.
10766 (glob var syntax_message[]) Added my e-mail address.
10768 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10769 `illegal' to `invalid'.
10771 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10772 uncompression buffer.
10773 (sfm_close) Frees decompression buffer.
10774 (sfm_read_dictionary) Initializes decompression buffer.
10775 (buffer_input, read_compressed_data) New functions.
10776 (sfm_read_case) Restructured; now calls read_compressed_data() to
10777 handle compressed system file data.
10779 * var.h: Comment fix.
10781 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10783 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10786 * get.c: New comments. New static var `get_file'.
10787 (cmd_get) Now fully implemented. Calls discard_variables();
10788 initializes fv and lv for all variables; new debug code; sets
10789 up the dictionary; sets up the input program.
10790 (read_from_get, cancel_get) New functions.
10792 * sfm-read.c: Comment fixes.
10793 (sfm_close) New static function.
10794 (sfm_read_dictionary) Properly sets up the class of the
10795 file_handle. No longer cares what size the data is in records of
10796 type 7. Also, on failure, properly cleans up the file_handle and
10797 free()s some stuff.
10798 (read_variables) No longer thinks it knows `nval' of the
10799 dictionary. Now sets p.get.fv, etc., instead of speculatively
10801 (read_value_labels) Fixed off-by-one error in indexing of
10803 (sfm_read_case) New function.
10804 (sfm_r_class) New static var.
10806 * var.h: (get_proc) New struct.
10807 (struct variable) New member p.get.
10809 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10811 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10812 the manual's meaning.
10813 (rename_variables) New function.
10814 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10815 code. Now properly reorders the dictionary on the KEEP keyword.
10817 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10818 garbage collection.
10820 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10821 (rename_variable) New function.
10822 (free_val_lab) Reformatted.
10824 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10826 * var.h: Reindented entire file. Comment fixes.
10827 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10829 (glob var default_dict) New.
10830 (struct indirect_dictionary) Removed.
10832 * Many other source files were changed to add `default_dict.'
10833 before all references to the dictionary of the active file.
10835 * vars-atr.c: (make_indirect_dictionary) Removed.
10837 * glob.c: Reindented all variable declarations. Updated for
10838 changed var.h. Comment fixes.
10840 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10841 because now we can mainly copy dictionary structs.
10843 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10844 parse_variables) Takes dictionary instead of indirect_dictionary
10846 (parse_variables) Instead of calling make_indirect_dictionary,
10847 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10848 of `*dict.' references had to be changed to `dict->'. Removed
10851 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10853 * get.c: Added GTSV_OPT_* series of enums.
10854 (trim_dictionary, dict_delete_run) New functions.
10855 [DEBUGGING] (dump_dict_variables) New function.
10856 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10857 [DEBUGGING] Calls dump_dict_variables() to display results.
10859 * glob.c: (cmp_variable) Now a public function declared in var.h.
10861 * sfm-read.c: Turned off debug code. Comment fixes.
10862 (read_machine_int32_info, read_machine_flt64_info) New functions
10863 to parse type 7 records.
10864 (sfm_read_dictionary) Properly byteswaps several fields now.
10865 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10866 records. [DEBUGGING] Dumps dictionary.
10867 (read_variables) Sets `index' field of variables created properly.
10868 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10869 longer dumps dictionary.
10870 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10872 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10874 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10875 var before destroying any variables just to save a little time.
10877 * var.h: (struct variable) Reordered in order to make name[] the
10878 first member; this makes pointers to `variable' pointers to the
10879 variable name, simplifying avl trees, etc.
10880 (struct indirect_dictionary) New struct.
10882 * vars-atr.c: (find_variable) Rewritten for efficiency.
10883 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10885 (is_varname) Rewritten for efficiency.
10886 (parse_variables) New argument, which is a `dictionary *'. All
10887 references changed. This function now reads variable names from
10888 the dictionary passed, or from the default dictionary if NULL.
10890 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10892 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10893 rounding up. Changed many references to ROUND_UP to use this
10896 * sfm-read.c: Includes avl.h.
10897 (corrupt_msg) Induces a segfault under Checker.
10898 (macro assertive_bufread) New. Many references to bufread() now
10900 (sfm_read_dictionary) Split up into several functions. Added code
10901 to read dictionary records following the the type 2 records. Not
10902 quite complete. New variable `var_by_index'.
10903 (read_header, read_variables) New functions extracted from
10904 sfm_read_dictionary().
10905 (read_value_labels) New function.
10906 (bufread) Checks ferror() if fread() doesn't return the expected
10907 value; if ferror() is zero it's just EOF.
10908 (dump_dictionary) Stubbed out.
10910 * BTW: The source code now exceeds 50000 lines!
10912 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10914 * command.c: Added GET to cmd_table[].
10916 * list.q: Removed reference to alloca headers.
10917 (cmd_list) Gave prototype.
10919 * sfm-read.c: Added DEBUGGING comments.
10920 (sfm_read_dictionary) Checks bias correctly. Sets
10921 dict->var_by_name to NULL. Calculates long_string_count
10922 correctly. realloc's dict->var[] array to minimum size.
10923 [DEBUGGING] Calls dump_dictionary.
10924 [DEBUGGING] (dump_dictionary) New function.
10926 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10927 (restore_dictionary) If the dictionary contains a non-NULL
10928 var_by_name, uses that instead of generating one.
10929 (free_dictionary) Destroys var_by_name.
10931 * var.h: (struct dictionary) Added field `var_by_name'.
10933 * get.c: New file, not complete.
10935 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10937 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10938 (parse_num_or_range) New function.
10939 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10940 <n> THRU HIGH missing values.
10942 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10943 __attribute__((const)).
10945 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10947 * sfm-read.c: Finished reference implementation.
10949 * sfm.h: Includes var.h.
10951 * var.h: Comment fixes.
10952 (struct `variable') Reordered some fields.
10954 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10955 constants added previously.
10957 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10959 * common.h: Comment fixes. Added declaration of
10960 `second_lowest_value' as variable or macro. Made `compat_type',
10961 `pgm_state_type' into anonymous enums.
10963 * display.c: Comment fix.
10965 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10967 [!defined SECOND_LOWEST_VALUE] Added definition for
10968 `second_lowest_value' global var.
10969 (compat, pgm_state global vars) Changed types to `int'.
10970 (init_glob) Initializes `second_lowest_value'.
10972 * sfm-read.c: Continued work, not complete.
10974 * var.h: Added new MISSING_* constants to handle LOWEST and
10977 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
10979 * sfm-read.c: New file, not complete.
10981 * cases.c: (vec_insert) Changed vector expansion algorithm.
10982 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
10983 mucking up the RECODE transformation in particular.
10984 (envector) Harmless change in notation.
10986 dfm is now fairly well tested again.
10987 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
10989 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
10991 * recode.c: Comment fix.
10993 * sfm.h: Interface should be fairly final now, or at least for a
10996 * vfm.c: [DEBUGGING] (index_to_varname) New function.
10997 (open_active_file) [DEBUGGING] Translates ccase indices into
10998 variable names now to make it easier to understand what's really
11001 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11003 * data-in.c: Comment fix.
11005 * data-list.c: Includes dfm.h.
11006 (do_reading) Uses new function dfm_push_cust().
11008 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11009 `return 1;' at end.
11011 * file-handle.h: Completely changed. Some parts split off into
11012 new file dfm.h. Implemented in file-handle.q.
11013 (enum FH_*) Removed.
11014 (struct fh_ext_class) New struct.
11015 (struct file_handle) Retained only these fields: name, norm_fn,
11016 fn, recform, lrecl, mode. New fields class, ext.
11017 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11018 close_handle, handle_name) Added `fh_' prefix to name, all
11019 references changed.
11021 * dfm.h: New file, implemented in dfm.c.
11022 (get_record, put_record, fwd_record, bkwd_record, set_record,
11023 get_cur_col) Functions moved from file-handle.h, now prefixed with
11025 (dfm_push_cust) New function.
11027 * sfm.h: New file. Incomplete.
11029 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11030 interface. Functions reordered, comments changed. Not well
11031 tested, probably full of bugs.
11032 (struct dfm_fhuser_ext) New struct.
11033 (dfm_close) New function.
11034 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11035 (open_file_w) User messages changed.
11036 (get_record) Comment fixed.
11037 (read_record) Increments ext->ln even for inline_file. Calls
11038 dfm_close() for inline_file when `END DATA.' encountered.
11039 (dfm_get_record) Experimental restructuring.
11040 (dfm_push_cust) New function.
11041 (cmd_begin_data) Detects whether the inline file was fully read by
11042 checking whether it is still open; detects whether it was read at
11043 all by checking whether the line number is greater than zero.
11045 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11046 interface. Functions reordered, comments changed. Not well
11047 tested, probably full of bugs.
11048 (init_file_handle) Removed initializers for obsolete fields, added
11050 (fh_close_handle) Much simpler, now mainly calls the class
11052 (fh_init_files) Renamed inline file internal filename.
11054 * file-type.c: Includes dfm.h.
11055 (read_from_file_type) Doesn't use dfm internal state anymore.
11057 * inpt-pgm.c, print.c: Include dfm.h.
11059 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11060 int in comparison with other int.
11062 * som-high.c: (build_target) Fixed operator precedence problem in
11063 if statement (& versus ==).
11065 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11067 * dfm.c: (read_record) Can now read fixed-length records; not
11069 (put_record) Can now write fixed-length records; not tested.
11071 * file-handle.h: FH_* defines changed to enums. New enum series
11073 (struct file_handle) New members recform, lrecl, mode.
11075 * file-handle.q: Parser changed.
11076 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11077 /LRECL subcommands. These are compatible with Windows.
11078 (init_file_handle) Initializes recform, mode fields.
11080 * q2c.c: (get_line) When outputting `!' comment lines, now
11081 increments the output file line number so that `#line' directives
11083 (make_identifier) New function that converts an arbitrary string
11084 into a valid C identifier.
11085 (dump_vars) Calls make_identifier() in two places in order to
11086 suppress some errors for bad identifiers.
11087 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11088 for NO. Allows numbers to be prefixed by underscores to make them
11089 acceptable C identifiers but still to be parsed as numbers by the
11092 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11094 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11096 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11097 was opened for writing.
11098 (open_file_w) New function.
11099 (read_record) Uses strncasecmp if available. Improved error
11100 messages, comments.
11101 (put_record) New function.
11103 * file-handle.h: Moved function comments into dfm.c and
11104 file-handle.q. Comment fixes. Removed declarations of
11105 tilde_expand() and normalize_filename().
11106 (struct file_handle) Changed `open' from boolean to enumerated
11107 field to allow for three states--closed, open for reading, open
11108 for writing--all references changed.
11110 * file-handle.q: Includes filename.h.
11112 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11113 references changed.
11114 (alloc_line) Makes allowance for line terminator characters in
11116 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11117 (print_space_trns_proc) Handles OUTFILE differences.
11119 * recode.c, sample.c: Comment fixes.
11121 * var.h: (struct print_trns) Changed boolean field `eject' to
11122 bitmapped field `options'; all references changed. New enums
11123 PRT_* for use with this field.
11125 * exception.h, test-exception.c: Removed.
11127 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11129 * ascii.c: (delineate) Turned off debug output.
11131 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11134 * data-in.c: (parse_string_as_format) Sets the entire string value
11135 to spaces, not just the short string part of it. Is this correct
11138 * data-out.c: (convert_date) Fixed DATETIME format problems with
11139 decimal places, removed debug code.
11141 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11142 middle of parsing BEGIN DATA that would cause the lexer to read
11143 from a wild pointer `prog'; now calls new function
11144 preprocess_line() in lexer.c.
11146 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11148 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11149 Now call induce_segfault() to induce the segfault.
11150 (induce_segfault) New function.
11152 * expr-opt.c: Comment fix.
11153 (parse_sysvar) New function.
11154 (parse_primary) Added system variable support--calls
11156 (global var ops) Added OP_CASENUM operator.
11158 * expr.h: Comment fixes.
11159 (OP_* enum) added OP_CASENUM operator.
11160 (struct casenum_node) New struct.
11161 (union any_union_union) New member `cas' of type `casenum_node'.
11163 * glob.c: (global var last_vfm_invocation) New var.
11164 (init_glob) Initializes last_vfm_invocation.
11166 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11168 * getline.c: (get_line) Split into get_line() and preprocess_line().
11169 (preprocess_line) New function.
11171 * var.h: Declares last_vfm_invocation.
11173 * vfm.c: (procedure) Sets last_vfm_invocation.
11175 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11177 * command.c: (parse_cmd) Fixed bad assertion related to
11180 * data-in.c: (parse_month) Implemented to parse months according
11181 to full interpretation of standard.
11182 (to_roman) New function.
11183 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11184 (parse_weekday) Bug fix (forgot to skip all the day name).
11186 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11187 up parsing of multirecord data items. Also fixed user message.
11189 * data-out.c: Comment fix.
11190 (year2, year4, convert_date, convert_time, convert_WKDAY,
11191 convert_MONTH) New functions to support time & date output.
11192 (convert_format_to_string) Calls new time & date output routines.
11194 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11196 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11199 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11201 * misc.c: (global var formats) Fixed declarations of DATETIME,
11204 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11205 the output_char buffer.
11207 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11208 memory bug. Fixed user messages.
11210 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11212 * Removed #pragma argsused from lots of places.
11214 * data-in.c: Implemented zoned decimal and time-date formats.
11215 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11218 * data-out.c: Implemented zoned decimal format.
11220 * expr.h: Moved yrmoda() declaration here from exprP.h.
11222 * misc.c: (global var formats) Minor fixes--added
11223 FCAT_SHIFT_DECIMAL to formats N and Z.
11224 (convert_fmt_ItoO) Added support for format Z.
11226 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11228 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11230 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11231 som_check_workspace() that is activated between commands.
11233 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11236 * list.q: (begin_row) Changed title expansion style from
11237 SOPT_X_VERT to SOPT_X_SHSP.
11239 * som-frnt.c: Now includes `somP.h'.
11240 (som_push_workspace, som_pop_workspace) New functions that, taken
11241 together, form a solution to the recursive table building problem
11242 mentioned yesterday. Surrounded every table output routine
11243 throughout the program with calls to these functions.
11244 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11245 (som_create_table) Checks that there's an active workspace.
11246 (som_destroy_all_tables, som_crush) Removed.
11248 * som-high.c: (global var som_preserve_tables) Removed, all
11249 references deleted.
11250 (som_submit_table) Checks that there's an active workspace.
11251 (dump_columnated_table) Doesn't columnate tables that would have
11252 just one row per column.
11253 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11254 (som_dump_crush_page) Moved row number labels from left side of
11255 tables to right side.
11256 (som_get_table_size) Added support for SOPT_X_SHSP.
11258 * som.h: New cell expansion type SOPT_X_SHSP.
11260 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11262 (global var curtab_arena) Moved from som-frnt.c.
11264 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11266 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11267 that causes bad location warnings to be suppressed.
11268 (delineate) Saves current font when calling draw_text(); fixed
11269 handling of NULLs when backing up. Also fixed line-wrapping bug.
11271 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11272 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11274 * common.c: Added code to cause assertion failure to dump core
11275 when run under Checker.
11277 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11278 there are still bugs.
11280 * glob.c: (__eprintf) Removed.
11282 * list.q: Inserted som_preserve_tables kluge that prevents tables
11283 from being thrown away due to recursive table building through
11284 som_output_line being called from a transformation during the LIST
11285 procedure invocation. This is a general problem that must be
11286 solved in a better way since it applies to all procedures in
11288 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11289 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11291 * numeric.c: Fixed several errors in the form of msg() calls.
11293 * print.c: Updated for use of som.
11294 (dump_table) Reimplemented.
11295 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11296 Calls som_output_text() instead of outs_line().
11298 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11300 (som_output_text) Function moved from som-low.c. Interface
11303 * som-high.c: (som_preserve_tables) New global public variable
11305 (som_submit_table) Destroys the tables only if som_preserve_tables
11307 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11308 one subrow per row. Now labels subrows if there's more than one
11310 (dump_crush_table) Added wishlist comment.
11311 (som_eject_page) New public function declared in som.h.
11313 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11314 more than one subrow per row.
11315 (som_output_text) Moved to som-frnt.c.
11317 * som.h: (SOM_TOPT_PRESERVE) Removed.
11319 * title.c: (get_title) Changed interface.
11320 (cmd_title) Changed `title' to `outp_title'.
11321 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11323 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11325 * list.q: (flush_table) Conforms to new partial options in
11326 som_submission_form.
11328 * som-high.c: (paginate_horizontally) Changed form of subrow
11330 (build_target) Omits spacing before table if
11331 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11332 (dump_crush_page) Changed interface. Only trims bottom rule if
11333 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11334 (dump_crush_table) Handles partial tables.
11335 (output_row_label) New function.
11336 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11337 rule on the right edge of narrow subrows.
11339 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11340 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11341 All references updated.
11343 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11345 * misc.c: Comment fix.
11347 * som-high.c: (examine_table) Treats crushed tables separates for
11348 purpose of determining header size.
11349 (paginate_horizontally) Allots space for line numbers in crushed
11350 tables with lots of subrows per row. Calculates the `maximum page
11351 width', the width of the widest horizontal page.
11352 (build_target) Removed trim argument; all references changed.
11353 Stricter assertions. (dump_crush_page) New function.
11354 (dump_crush_table) Reimplemented.
11356 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11357 (som_dump_crush_page) Reimplemented, interface changed.
11359 * somP.h: Many many new helper macros for use with crushed tables.
11360 (global var som) Removed `tv', `cum_y' members; all references
11361 removed. New members `mpw', `digit_space'.
11363 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11365 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11366 variable, changed to constant 1024.
11367 (arena_ca_strdup) Changed `sizeof(a_string)' to
11368 `sizeof(c_string)'.
11369 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11370 `(c_string *)' to `(char *)'; this fixed some offset problems.
11372 * filename.c: (readlink_malloc) Changed initial allocation from
11374 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11377 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11378 &fm->owner in several places.
11380 * som-high.c: (output_table) Changed interface to rest of world.
11381 (examine_crush_table) Removed. Crushed tables are re-broken now,
11382 in preparation for rewrite.
11384 * som.h: Comment fix.
11386 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11388 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11389 itself in the cleanup stage.
11391 * descript.q: (display) At least temporarily, changed the table
11392 format to a crushed table.
11394 * list.q: (begin_row) At least temporarily, added horizontal lines
11397 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11398 the horizontal "headers," that is, to the width of the far left
11399 and far right rules.
11400 (justify_pagination) Sets som.th to the width of the widest row
11401 in the crushed table. Fixed inner loop off-by-one error.
11403 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11406 * somP.h: Comment fix.
11408 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11410 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11411 before closing it; also, opens the constructed filename `s'
11412 instead of f->filename.
11414 * postscript.c: Moved initialization of x->loaded, x->prop,
11415 x->fixed, x->current, also the add_encoding() calls, into
11417 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11418 sets x->last_font to NULL; sets x->next_combo to zero.
11420 * som-high.c: (crushed_row_height) Moved definition farther up.
11421 (som_submit_table) Doesn't calculate line width, font size until
11422 after calling open_page(), to accomodate changes to PostScript
11424 (vert_headers) Removed; equivalent functionality moved to
11425 examine_table(), examine_crush_table().
11426 (justify_pagination) Replaced with different algorithm.
11427 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11428 at the bottom of the page.
11430 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11432 * command.c: Added cmd_list back into cmd_table.
11434 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11435 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11437 * list.q: (flush_table) Updated to new som_submission_form format.
11439 * som-frnt.c: Comment fix.
11441 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11442 (output_table) Calls som_get_table_size() directly; handles
11444 (examine_crush_table) New function; calls vert_headers().
11445 (examine_table) Moved some code into new function, vert_headers().
11446 (justify_pagination) New function.
11447 (dump_plain_table) Removed `static' from `cy'.
11448 (dump_crush_table) New function.
11450 * som-low.c: (som_dump_crush_page) New function.
11452 * som.h: Comment fixes.
11453 (enum SOM_TOPT_CRUSH) New.
11454 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11455 Temporarily set to zero to make do with LIST procedure.
11457 * somP.h: Re-ordering.
11459 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11461 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11463 * somP.h: New file for use by som-high.c, som-low.c.
11465 * q2c.c: Added definition for VME.
11466 (get_line) Now dumps `!' comment lines to the output file
11469 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11470 set.q: Changed format of `!' comment lines.
11472 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11474 * All source files: Added copyright notice.
11476 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11477 longs in msg() calls.
11479 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11481 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11483 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11485 * output.c: (outp_read_devices) Changed criteria for
11486 distinguishing different types of lines.
11488 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11490 * cmdline.c: Changed syntax message.
11492 * filename.c: (good_getcwd) Bug fix (?).
11493 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11495 (search_path) Appends DIR_SEPARATOR to directory name only if it
11496 does not already end with one.
11498 * glob.c: Checks STAT_PAGER envvar before PAGER.
11500 * output.c: Checks environment variables instead of just local
11503 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11505 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11506 when the pointer passed to the function was within the arena
11507 itself, so that it couldn't properly be set to NULL _after the
11510 * command.c: Re-enabled DISPLAY.
11512 * display.c: Rewritten to handle tables. Untested.
11514 * filename.c: (search_path) Fixed memory leak.
11516 * frequencies.q: (cmd_frequencies) Frees v_variables.
11517 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11518 (cleanup_freq_tab) New function to garbage collect.
11519 (dump_full) Elegantized.
11521 * main.c: New comment.
11523 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11525 * postscript.c: Comment fix.
11526 (release_fontmap, free_font_entry) New functions.
11527 (ps_init_driver) Sets free_font_entry() as the freefunc for
11528 hashtable `loaded'. Calls release_fontmap() when destroying a
11529 driver; also frees the output filename; also frees the
11530 ps_driver_ext block.
11531 (free_ps_encoding) Frees the filename as well as the encoding
11533 (output_encodings) Frees the line buffer and pops the msg-filename
11535 (read_fontmap) Frees the fontmap filename and the line buffer.
11536 (postopen, preclose) Misc. garbage collection fixes.
11537 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11538 to NULL; this fixes some output problems.
11539 (text) Handles TAG_NEWLINE. Untested.
11541 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11542 (som_set_string) Removed. All references changed to
11544 (som_set_text) Rewritten. New interface. More general.
11546 * som.h: Minor format changes.
11547 (struct som_value_cell) Removed; all references changed to
11549 (enums SOT_*) Changed.
11551 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11553 * command.c: Re-enabled SPLIT FILE.
11555 * postscript.c: Comment fix.
11557 * som.h: Added `SOT_NONE'.
11559 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11561 * vfm.c: (dump_splits) Reimplemented.
11563 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11565 * Compiled the project under gcc 2.7.2, which gave some new
11566 warnings. This led to many additions of casts from unsigned to
11567 int sprinkled throughout the code.
11569 * arena.c: Many uses of `unsigned' changed to `size_t'.
11571 * command.c: Added END FILE, END REPEAT to command table.
11572 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11573 (find_command, FILE_TYPE_okay) Not commented out anymore.
11574 (parse_cmd) Calls FILE_TYPE_okay again.
11575 (output_line) Added calls to som_output_text() to put the line
11576 in the output files.
11578 * common.c: (macro VME) Format changes.
11579 (xstrdup) Asserts that its argument is not NULL.
11581 * data-list.c: Implemented dump_fixed_table().
11583 * inpt-pgm.c: Formatting changes. Comment changes.
11584 (end_case_proc) Renamed end_case_trns_proc.
11585 (cmd_end_file, end_file_trns_proc) New functions.
11587 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11589 * misc.h: (local_strdup) New macro corresponding to strdup() but
11590 allocating its data through local_alloc() if possible--that is, if
11593 * postscript.c: Comment changes.
11594 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11595 (output_line, add_string) New macros supporting
11596 output_encodings().
11597 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11598 substitution vars. Calls output_encodings() when a line
11599 consisting of `!encodings' is encountered.
11600 (preclose) Some code moved into quote_ps_string().
11601 (dump_line) Changed into macro supporting dump_fancy_line().
11602 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11603 command when appropriate.
11604 (write_text) Fixed `literal_char' array (I think it's fixed, at
11606 (text) Fixed bug when width was zero. Now exits immediately on
11607 zero height_left. Now, when executing `goto restart;', checks
11608 that cp<end, so that we don't read beyond end-of-string. Also,
11609 outputs the correct code to the output file by outputting the code
11610 from the metric instead of the internal metric index.
11612 * repeat.c: (cmd_end_repeat) New function.
11614 * som.c: (var som) `headers' renamed `options' and semantics
11615 changed. All references changed.
11616 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11617 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11619 (som_text_table) Removed.
11620 (som_output_text) New function.
11622 * som.h: (struct som_submission_form) Removed `header', `reuse',
11623 replaced with bitmapped field `options'.
11624 (SOM_TOPT_*) New enum set for som_submission_form.options.
11625 (SOT_*) New enum set for som_output_text().
11627 * temporary.c: (copy_variable) When copying the var label, only
11628 calls xstrdup() if it's non-NULL.
11630 * var.h: (enum type `vartype') Removed; all references changed to
11633 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11636 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11638 * font.h: Comment changes.
11640 * groff-font.c: (groff_read_font) Initializes `name' field to
11641 NULL. Handles `encoding' field.
11643 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11645 * postscript.c: (struct font_entry) Removed `position' field.
11646 (struct ps_font_combo) New struct.
11647 (struct ps_driver_ext) Removed field `next_position'. New fields
11648 `combos', `next_combo'. `last_font' field changed from
11649 `font_entry *' to `ps_font_combo *'.
11650 (ps_init_driver) Reformatted; handles new fields. When
11651 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11653 (get_encoding, find_encoding_file) New functions.
11654 (add_encoding) Some code moved out into find_encoding_file().
11655 (postopen) Changed value for ${title}.
11656 (preclose) Sets `loaded' field to NULL after destroying the hash
11658 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11660 (ps_text_set_font_by_position) Figures out the current family if
11662 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11663 (switch_font) Implemented.
11664 (write_text) Calls switch_font() more often. Format changes.
11665 #undefs its macros after they're no longer useful.
11666 (text) Changed `continue' at one point to a jump to the top of the
11667 loop because we don't want `separate' reset to 0 at that point.
11668 (load_font) No longer sets `position' in the font_entry created.
11670 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11672 * font.h: (struct font_desc) New member `encoding', which is not
11673 properly handled yet.
11675 * glob.c: (init_glob) Some new i18n code, which is probably
11678 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11679 `size' local from `int' to `size_t'.
11681 * postscript.c: New driver configuration parameter `auto-encode'.
11682 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11683 (struct font_entry) New member `position'.
11684 (struct ps_driver_ext) Reordered. New hash table member
11685 `encodings'; new members `next_position', `next_encoding',
11686 `last_font'. Members `current', `prop', `fixed' changed from type
11687 `font_desc *' to `font_entry *'; all references changed.
11688 (struct ps_encoding) New struct.
11689 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11690 free_ps_encoding, add_encoding) New functions.
11691 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11692 x->output_options. Initializes new members of ps_driver_ext.
11693 Changed default value for prologue_fn, encoding_fn. Calls
11694 read_ps_encodings after loading default fonts.
11695 (option_tab[], ps_option) Handle new configuration parameter.
11696 (switch_font) New function.
11697 (struct output_char) `font' member changed from `font_desc *' to
11698 `font_entry *'. New member `separate'.
11699 (read_fontmap) Changed `size' from `int' to `size_t'.
11700 (output_line, put_number) New macros for write_text().
11701 (write_text) Optimizes text output by consolidating multiple
11702 calls to PostScript `show' operator.
11703 (text) Keeps track of when text arguments can't be consolidated by
11704 write_text(), and marks those spots in the output stream.
11705 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11706 the font hasn't been switched to by switch_font(), which is where
11707 the position is important--the PostScript is what cares about the
11710 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11712 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11713 call a NULL free_func.
11714 (hsh_rehash) Elegantized.
11715 (hsh_probe) Fix bug that manifested when the table was expanded
11716 and thus had to change location in memory. Good thing
11717 too--otherwise could have been much more subtle.
11718 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11719 (hsh_foreach) New function for hash table iteration.
11721 * hash.h: (struct hsh_iterator) New.
11723 * lexer.c: (parse_tagged_quote) Font and family name strings in
11724 tags are now null-terminated.
11726 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11728 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11729 documented. (Never before tested?)
11731 * output.h: Comment changes.
11733 * postscript.c: New driver options `optimize-text-size',
11734 `optimize-line-size', `max-fonts-simult'. New enum set for
11735 specing cached line types. Comment fixes.
11736 (struct line_form) New struct.
11737 (struct ps_driver_struct) New members `text_opt', `line_opt',
11738 `max_fonts', `lines'.
11739 (ps_init_driver) Initializes new members of ps_driver_struct.
11740 (user option type enum set) New member `nonneg_int_arg'.
11741 (static var option_tab[]) Supports new options.
11742 (ps_option) Handles new options.
11743 (find_ps_file) Made static. No longer calls hsh_dump().
11744 (ps_get_var) Made static.
11745 (preclose) Dumps out proper DSC trailer.
11746 (ps_open_page) Elegantized.
11747 (ps_close_page) Calls dump_lines() if appropriate.
11748 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11749 wrappers around line().
11750 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11751 dump_lines, hash_line, free_line, line) New functions for support
11753 (write_text, text) Made static.
11754 (text) Added to font support, not finished.
11756 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11758 * font.h: (struct font_desc) New members ascent, descent.
11760 * groff-font.c: (groff_read_font) Calculates font ascent and
11761 descent from the ascent and descent of the `d' and `p' characters,
11762 respectively, as per a suggestion on comp.fonts.
11764 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11765 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11767 (write_text) Handles text right-justification and centering (not
11768 full justification). Still very inefficient. (One output line
11770 (struct output_char) Added fields for font and font size.
11771 (text) Many bugfixes.
11773 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11775 * cmdline.c: (usage) Calls outp_list_classes().
11777 * font.h: Comment fix.
11779 * groff-font.c: New exported global var `space_index'.
11780 (groff_init) New function to initialize `space_index'.
11781 (hash_kern) Casts result to unsigned.
11782 (font_name_to_index) Renamed font_char_name_to_index. All
11783 references changed. Also, now returns the value of `space_index'
11784 when passed an ASCII space character as an argument. Fixed
11786 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11787 Handles passed NULL pointers properly.
11789 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11792 * output.c: (outp_list_drivers) Removed. Removed all references.
11794 * output.h: Comment fixes.
11796 * postscript.c: (ps_open_global) Calls groff_init().
11797 (output_char) New structure.
11798 (write_text) New function.
11799 (text) No longer stubbed out! Now the output is correct--with a
11800 few exceptions, one of them being that the page has to be held
11801 upside down into a mirror.
11803 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11805 * font.h: Comment fix.
11807 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11808 All callers changed.
11809 (number_to_index) Renamed font_number_to_index, made extern. All
11811 (font_get_kern_adjust, font_get_char_metrics) New functions.
11813 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11815 * postscript.c: Changed default line width back to 1/2 point.
11816 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11817 in the center of the space allotted for them, not just a fixed
11818 offset from the edge of the space; this fixes some bugs.
11819 (ps_line_intersection) Now supports all command line styles.
11820 (ps_text_get_size) Bug fix in computation of em width.
11821 (text) New function, the meat behind ps_text_metrics and
11822 ps_text_draw. Not complete.
11823 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11824 ascii.c; call text().
11826 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11828 * arena.c: (arena_free) Assert that the argument is non-NULL.
11830 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11831 only if old_kern is non-NULL.
11833 * postscript.c: (ps_init_driver) Changed default line width to 1
11835 (postopen) New prologue variables.
11836 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11837 more of the common line styles properly, but not all.
11838 (ps_text_metrics) Fixed problem with this stubbed out version that
11839 kept it from taking font sizes into account.
11841 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11843 * arena.c: (arena_malloc) Bug fix.
11844 (arena_dump) [GLOBAL_DEBUGGING] New function.
11846 * ascii.c: Comment fix.
11847 (count_fancy_chars, delineate) Now static functions.
11849 * filename.c: (interp_vars) Bug fixes.
11851 * font.h: Comment fixes.
11853 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11854 beginning in case we have an error message to display before
11855 initializing the display.
11857 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11859 (groff_read_font) Bug fixes.
11860 (name_to_index) Increments hash.used. Sets `name' field of hash
11862 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11864 * hash.c: Return type changed.
11866 * postscript.c: Continued development. Now marks lines on the
11867 paper, but very buggy.
11869 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11871 * Changed comments in many source files from `/* xxx /* yyy */' to
11872 `/* xxx */ /* yyy */' for cleanliness.
11874 * arena.c: (arena_sd_strdup) New function.
11876 * ascii.c: (struct ascii_driver_ext) New member `file'.
11877 (ascii_init_driver) Fills out member `file' for initing; uses
11878 close_file_ext for closing drivers.
11879 (ascii_option) Changed %.*s back to %s because the a_string's are
11880 always null-terminated.
11881 (postopen, preclose) New functions.
11882 (ascii_open_page) Uses new style of open_file_ext.
11883 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11884 instead of this->output.
11885 (__assert_fail) Removed.
11887 * cmdline.c: Changed syntax_message[].
11889 * error.c: #include's <readline/history.h> only if the history
11890 library is available, not if just the readline library is
11893 * filename.c: (expand_line) Removed alloca() support.
11894 (interp_vars) No longer tilde-expands argument. Limit on output
11896 (tilde_expand) Now treats argument as path rather than filename.
11897 [!unix] Now is a no-op function.
11898 (search_path) Better verbose message formatting.
11899 (open_file, close_file) Comment fixes.
11900 (close_file) [!unix] Doesn't bother with pipes.
11901 (open_file_ext) Completely rewritten, interface revamped.
11902 (close_file_ext) New function.
11904 * font.h: Comment changes.
11906 * frequencies.q: Removed AIX alloca support since it doesn't use
11909 * hash.c: Comment changes & additions.
11910 (hsh_create) Initializes entire table instead of first M entries.
11911 (hsh_probe) Stupid bug fixed. Now it works.
11912 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11914 * main.c: (parse) Detects EOF properly in token-eating loop.
11915 Should the STOP token have its value changed to 0?
11917 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11918 (blp_getline) Now it's a macro.
11920 * output.h: (struct outp_driver) Removed members output, filename.
11922 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11923 drivers in driver table.
11924 (outp_read_devices) Frees buf. Warns if there are no active
11926 (outp_configure_clear) Sets outp_configure_vec to NULL after
11927 deleting its elements.
11928 (configure_driver, destroy_driver) Removed references to output,
11929 filename members of outp_driver.
11930 (outp_evaluate_dimension, internal_get_paper_size,
11931 outp_get_paper_size) New functions.
11933 * postscript.c: Continued development. Now links but doesn't make
11934 any marks on the page. Lotsa bugs I suppose.
11936 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11938 * str.h: Comment changes.
11940 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11942 * Removed dependencies on non-nested comments in several files.
11943 Also removed references to (unix || __unix__) in #if's since
11944 prefh.orig makes those two equivalent.
11946 * ascii.c: (ascii_open_global) Creates ascii_arena.
11947 (ascii_close_global) Destroys ascii_arena.
11948 (ascii_init_driver) Doesn't create ascii_arena.
11949 (ascii_copy_driver) Removed.
11950 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11951 (outp_class ascii_class) Removed ascii_copy_driver reference.
11953 * frequencies.q: Now can display all statistics except median.
11954 Still not finished.
11956 * output.c: Handles outp_class.ref_count so output class
11957 destructors are called properly.
11958 (add_class) Sets ref_count to 0.
11959 (configure_driver) Initializes class if ref_count++ is 0.
11960 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11961 class output file name.
11963 * output.h: (struct outp_class) Removed copy_driver, inited.
11966 * postscript.c: Completely replaced but not finished.
11968 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11970 * approx.h: #includes <float.h>.
11972 * arena.h, arena.c: Many functions changed to take an arena **
11973 instead of an arena *, for consistency. All callers changed.
11974 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11975 (arena_destroy) Sets *A to NULL.
11977 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
11978 assertion that `width' be positive.
11980 * command.c: Removed #if's from cmd_table.
11981 (walk_cmdtable_func) [0] New function (debug code).
11982 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
11983 (parse_cmd) Doesn't return failure for unimplemented commands.
11985 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
11986 (SYSCODE) New constant macro.
11988 * descript.q: Checks for positive n_variables before performing
11991 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
11992 avl_find instead of &fp as arg 2.
11994 * frequencies.g, frequencies.q: Continued updating; now compiles &
11995 works again, but not complete.
11997 * main.c: Changes to user messages.
11999 * misc.c: (reverse) [0] New function.
12001 * settings.h: Comment removed. #includes "common.h".
12003 * som.c: (som_set_null) New function.
12004 (som_set_value, som_set_string, som_set_text) More detailing
12006 (som_set_float) Implemented function.
12007 (dump_columnated_table) Bug fix regarding page breaks.
12008 (draw_cell) Bug fix regarding text that spilled out of a cell.
12009 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12011 (get_cell_size) Support SCON_EMPTY cells.
12012 (get_table_size) When calculating rules' widths and heights, mask
12013 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12015 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12017 (struct som_submission_form) New member `header'; all users
12020 * val-labs.c: (get_label) User messages changed.
12022 * var.h: Changed FREQUENCIES structures.
12024 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12027 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12029 * approx.h: Definition of EPSILON now depends on system's
12030 DBL_EPSILON. Removed GNU C specific code.
12031 (cmpapx) Renamed approx_compare.
12033 * frequencies.g, frequencies.q: Continued updating; still doesn't
12036 * groff-font.c: (name_to_index) Fix bug that kept it from
12039 * hash.c, hash.h: Completed work.
12041 * var.h: Changes to freq_tab, frequencies_proc.
12043 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12046 * hash.c, hash.h: New files. Not completed.
12047 * Makefile.am: Added hash.c to source file list.
12048 * font.h: (struct font_desc) New member kern_size_p.
12049 * groff-font.c: Uses hash.h.
12050 (hashpjw) Moved to hash.c.
12051 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12053 (static var hash) New member size_p.
12054 * var.h: Includes hash.h.
12055 (struct freq_tab) Changed AVL_TREE to hash_tab.
12057 * vars-prs.c: Comment, formatting fixes.
12059 * frequencies.g, frequencies.q: Continued updating. Not yet
12062 * formats.c: Bug fix.
12064 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12066 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12067 * descript.g: Comment fixes.
12068 * descript.q: Comment fixes. Moved some declarations into var.h.
12069 Made dsc_info a static table. Updated FIXMEs.
12070 (internal_cmd_descriptives) Beautified.
12072 * frequencies.q: Started updating into working order.
12073 * frequencies.g: New file analogous to descript.g.
12074 * var.h: Comment fixes. Added structures for FREQUENCIES.
12076 * som.c: Removed vestiges of crushing and partial table support.
12078 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12080 * Many more changes to som.c especially, but these will not be
12081 documented as I have resolved to remove them. This patchlevel is
12082 being released solely so that I can fall back to it if I decide
12083 that removing the changes is not a good idea.
12085 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12087 * som.c: (global var som) New member `cum_y'.
12088 (build_target) Properly handles titles for partial tables.
12089 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12090 Merged into single new function dump_partial(). Fixed problem
12091 with titles on partial tables.
12092 (dump_table) Calls dump_partial() for all parts of partial tables.
12093 (dump_page) Criteria for drawing title changed.
12095 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12097 * command.c: (cmd_table) Added LIST, WEIGHT.
12099 * command.c: (cmd_remark) No longer frees `s' since it's not
12100 dynamically allocated.
12102 * data-out.c: (convert_f) Now correctly handles the case where
12103 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12104 number of decimals.
12105 (som_destroy_all_tables) Removed argument. All callers changed.
12106 (som_vline, som_hline) Argument validity checking corrected.
12107 (som_set_value) Implemented half-heartedly.
12108 (replicate_table) Copies tables piece-by-piece when using Checker.
12110 * som.h: New line style SLIN_1THIN, currently equivalent to
12111 SLIN_0. New enum set SOM_SUB_*.
12112 (struct som_submission_form) Removed `seq_no'. Added `type'.
12114 * list.q: Newly working file; uses partial tables.
12116 * som.c: (som_reduce_table) Renamed som_set_table_height().
12117 (som_crush) Removed argument `group'.
12118 (global var som) Removed `nt', `seq_no'. Added `type'.
12119 (som_submit_table) Arguments changed.
12120 (output_table) Removed partial table code.
12121 (build_target) New arg; partial table support added. All callers
12123 (dump_plain_table) Removed partial table code.
12124 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12125 (dump_table) Supports partial tables.
12126 (dump_page) New argument to allow not drawing top and/or bottom
12127 headers. All callers changed. Supports partial tables.
12129 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12131 * data-out.c: Changed `#include <approx.h>' to `#include
12133 (convert_F) Comment fix. Now won't print `-.000', etc.
12135 * descript.q: Now Z-scores work, although there appears to
12136 be a bug (which might actually be in data-out.c:convert_F()).
12137 (descriptives_trns_proc, descriptives_trns_free) New functions.
12138 (run_z_pass) Implemented.
12140 * var.h: Comment fixes.
12141 (dsc_z_score, descriptives_trns) New structs.
12142 (descriptives_trns) Added to any_trns as `dsc'.
12144 * error.c, error.h: New error class, IS (Installation Script
12145 error), used in those instances where the error is in the
12146 installation, but there is a script file or installation file that
12147 can be usefully referred to.
12149 * output.c: Change many IE classes to IS classes.
12151 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12152 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12153 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12154 include the corresponding header?
12156 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12157 Don't bail out if termcap can't be read.
12159 * som.c: (som_destroy_table) Removed.
12160 (som_reduce_table, som_destroy_all_tables) New functions.
12161 (som_crush) New function, not implemented.
12163 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12164 som_submission_form. Function prototypes revised.
12166 Outputting huge tables (1000s of rows) a few rows at a time
12167 is supported, though untested. May even break everything.
12168 Actually, the code doesn't even compile right now.
12169 * som.c: (struct som) New fields htv, nt, seq_no.
12170 (som_submit_table) Multiple arguments changed to a single
12171 pointer to struct submission_form. Only increments subtable_num
12172 if seq_no is zero. Only destroys table if it's not going to
12174 (replicate_table) New function.
12175 (output_table) Comment fix.
12176 (examine_table) Changed inline code to code calling
12177 replicate_table(). Calculates htv. Supports partial tables.
12178 (draw_title) Removed comment.
12179 (build_target) Only allows for title on first part of partial
12181 (dump_plain_table) Only resets table chunk number on first part
12182 of partial tables; FIXME: doesn't work quite right. Supports
12184 (dump_page) Titles only on first part of partial tables.
12186 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12188 * Thanks to an unreliable IDE hard drive, I have spent the last
12189 day reconstructing my Debian GNU/Linux installation and redoing
12190 the previous day's changes--somehow I managed to save every file
12191 except for output.c and output.h. So the following changes could
12192 really be considered independent of the output.c, output.h changes
12195 * output.h, output.c: Moved the outp_configure_vec global var,
12196 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12197 outp_configure_vec is now static.
12199 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12201 * The entire philosophy behind configuration of the output drivers
12202 changed. Now there is a termcap-type configuration where drivers
12203 to be read are determined beforehand, rather than parsing the
12204 entire output init file and storing it in memory & deciding what
12205 to actually use later. Faster & more memory-efficient at the same
12208 * output.c: Comment fix. Removed outp_init_drivers global var.
12209 Removed all references to synonyms. New structure outp_defn. New
12210 global vars outp_macros, outp_configure_vec.
12211 (search_name, delete_name, add_name, check_configure_vec,
12212 expand_name, find_defn_value) New static functions.
12213 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12214 outp_read_devices) New extern functions.
12215 (outp_init) Much functionality moved into outp_read_devices.
12216 (outp_read_devices) Format of output init file changed; name of
12217 file is `devices' rather than `output' to avoid Makefile
12219 (outp_clear) Renamed outp_done.
12220 (outp_list_classes) Bug fix, cleaned up.
12221 (outp_list_drivers) Not implemented anymore.
12222 (outp_configure_driver) Now a static function; simplified; now
12223 interpolates macros; supports new structure.
12224 (outp_enable_driver, match_synonym) Removed; all references
12226 (find_driver) First argument removed.
12228 * output.h: Global var outp_init_drivers removed; new structure
12229 outp_names; new enum set OUTP_S_*; new global var
12230 outp_configure_vec; function prototypes for output.c exports
12233 * main.c: (main) Calls outp_read_devices() after parsing the
12236 * cmdline.c: (parse_command_line) New option -v --verbose;
12237 --version changed to -V. --device option changed syntax to just
12238 take a single device name. Accepts key=value declaration of
12239 output init file macros. Syntax message updated.
12241 * filename.c: (expand_line) New function.
12242 (interp_environ_vars) Renamed interp_vars; no longer uses
12244 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12245 overridden by real environment vars.
12246 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12247 * filename.h: interp_environ_vars() renamed interp_vars().
12249 * error.c, error.h: Added extern variable `verbosity', message
12252 * error.c: (vmsg) Support message class MM.
12253 (verbose_msg) New function.
12255 * descript.q: (generate_z_varname) Bug fix in generation of
12257 (dump_z_table) Bug fix in column headers.
12259 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12260 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12261 OPS_DONE]. Writes the uninit string when the driver is closed.
12262 (ascii_open_page) Write the init string before the first page.
12263 (output_shorts) Form of main loop changed from `while' to `for'.
12264 Bug fix with overstrikes: the character is printed *after* the
12265 backspace. Eliminated a lot of `& 0xff' modifiers.
12266 (advance_to_left_margin) New function.
12267 (return_carriage, output_lines) Handle left margin.
12269 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12271 * ascii.c: New option `carriage-return-style'.
12273 * ascii.c: (count_fancy_chars) New function.
12274 (delineate, text_metrics) Use new function; bug fixes regarding
12276 (text_draw) Bug fix with rich text.
12277 (output_string, output_shorts) Reordered.
12278 (output_shorts) Now handles boxchars and some overstrike font
12280 (output_char, return_carriage) New functions.
12281 (output_lines) Now handles overstriking and font changes properly;
12282 some code moved to output_shorts.
12284 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12287 * ascii.c: New member `debug' in ascii_driver_ext.
12288 (ascii_init_driver, delineate) Uses new member.
12290 Now you can set a vertical height on writing text.
12291 * ascii.c: (delineate) Keeps track of vertical position.
12292 (text_draw) No longer considers fully justified text an internal
12295 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12297 Tables' titles are drawn; they can have variable height.
12298 * som.c: `som' struct has new member, title_height.
12299 (draw_title) New argument. Moved within file. All caller
12301 (build_target) New argument, amount of space needed for first row.
12302 Calculates height of title, takes that into account. All callers
12304 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12306 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12308 (dump_columnated_table) Organized for readability.
12309 (dump_page) Makes use of som.title_height.
12311 * som.c: Many comment bug fixes.
12313 * descript.q: (try_name, generate_z_name) Bug fix regarding
12314 generation of Z-score variable names.
12315 * var.h: Removed num from descriptives_proc; all referents removed.
12317 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12319 * ascii.c: (ascii_line_horz, ascii_line_vert,
12320 ascii_line_intersection) Added debugging code.
12322 Added a descriptive line above each table to describe it.
12323 * command.c: (parse_cmd) Calls som_new_series.
12325 * som.c: New static vars table_num, subtable_num. New `som'
12327 (dump_page) New arguments.
12328 (som_submit_table) Handle new variables.
12330 * som.c, som.h: (som_submit_table) New arguments. All callers
12332 (som_new_series) New function.
12333 (build_target) Makes room for extra line.
12334 (draw_title) New function.
12335 (dump_page) Calls draw_title. Bug fix: doesn't always set
12338 Columnation of tables support.
12339 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12341 * som.c: Deleted references to fr, lr, ri.
12342 (som_columnate) Bux fix: sets group member of table.
12343 (som_add_options) Function removed.
12344 (dump_table) Split into three functions; extensively reworked.
12346 * descript.q: (dump_z_table) Better output table formatting; added
12347 title support to correspond to som.h changes.
12348 (display) Title support.
12350 * output.h: Added OUTP_T_NONE.
12352 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12354 * descript.q: Improved handling of Z scores; still not perfect.
12356 * output.h, ascii.c: Added hook for getting em width of current
12359 * som.c: Uses new em-width hook. Added debugging code to
12361 (som_columnate) New argument.
12362 (som_add_options) Removed.
12364 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12366 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12367 rules as a property of the table instead of as a property of the
12370 * ascii.c: Added `header' to table of options.
12372 * descript.q: Added even shorter statistic names; modified to work
12373 with new som interface.
12375 * misc.c (blp_getdelim): Bug fix.
12377 * version.c: includes 'conf.h'.
12379 ----------------------------------------------------------------------
12382 version-control: never
projects / pspp-builds.git / blob