1 Sun Apr 16 20:41:10 2006 Ben Pfaff <blp@gnu.org>
3 Continue reforming error message support. In this phase, we
4 divide the classification of messages along "category" and
7 * message.c: (err_vmsg) Rewrite to deal with categories and
8 severities in a straightforward manner instead of mixing them into
10 [0] (puts_stderr) Removed (dead code).
11 (msg) Changed first argument from `int' to `enum msg_class'.
14 Sun Apr 16 18:53:12 2006 Ben Pfaff <blp@gnu.org>
16 GNU standards require "file name" instead of "filename" in
17 documentation. It's nice for our code to follow the convention
20 Basically did search and replace in the whole source tree. Major
21 changes in function names or struct member names have their own
24 Sun Apr 16 15:58:56 2006 Ben Pfaff <blp@gnu.org>
26 Continue reforming error message support. In this phase, we get
27 rid of VM() and the other msg() support for "verbosity", replacing
28 it by a new function verbose_msg().
30 * message.c: (verbose_msg) New function.
31 (err_vmsg) Remove support for verbosity levels.
33 Sun Apr 16 11:46:51 2006 Ben Pfaff <blp@gnu.org>
35 Start reforming error message support. In this phase, we get rid
36 of "installation errors" and change all uses of msg() in the
37 output drivers to uses of error() or error_at_line().
39 * message.c: (err_vmsg) Get rid of IE, IS support.
41 Sat Mar 11 14:17:47 WST 2006 John Darrington <john@darrington.wattle.id.au>
43 * automake.mk: Changed the pattern specific AM_CPPFLAGS to two target
44 specific ones. Eventually there will be none at all.
46 * automake.mk: Moved the pspp binary to ui/terminal
48 Sat Mar 4 12:59:08 2006 Ben Pfaff <blp@gnu.org>
50 * In many source files, #include "compiler.h" to get GCC attribute
53 Sat Mar 4 12:28:09 2006 Ben Pfaff <blp@gnu.org>
55 * In many source files, replace INT_DIGITS by
56 INT_STRLEN_BOUND(int) and include intprops.h.
60 * Replaced '_' with '-' in most filenames.
62 * Renamed files as follows:
63 vfm.[ch] to procedure.[ch]
64 error.[ch] to message.[ch]
65 getl.[ch] to line-buffer.[ch]
66 mkfile.[ch] to make-file.[ch]
67 pfm-write.h to por-file-writer.h
68 pfm-write.c to por-file-writer.c
69 sfmP.h to sfm-private.h
70 lex-def.c to identifier.c
71 lex-def.h to identifier.h
72 sfm-read.c to sys-file-reader.c
73 sfm-read.h to sys-file-reader.h
74 sfm-write.h to sys-file-writer.h
75 sfm-write.c to sys-file-writer.c
76 chart.[ch] to chart-geometry.[ch]
79 vars-atr.c to variable.c
80 ctl-stack.c to control-stack.c
81 ctl-stack.h to control-stack.h
82 dfm-read.c to data-reader.c
83 dfm-write.c to data-writer.c
84 dfm-write.h to data-writer.h
85 dfm-read.h to data-reader.h
86 apply-dict.c to apply-dictionary.c
87 mis-val.c to missing-values.c
88 sysfile-info.c to sys-file-info.c
89 modify-vars.c to modifiy-variables.c
90 rename-vars.c to rename-variables.c
91 val-labs.c to value-labels.c
92 var-display.c to variable-display.c
93 var-labs.c to variable-label.c
94 format-prs.c to format-parser.c
95 range-prs.c to range-parser.c
96 range-prs.h to range-parser.h
97 subclist.c to subcommand-list.c
98 subclist.h to subcommand-list.h
99 vars-prs.c to variable-parser.c
100 descript.c to descriptives.c
101 sort-prs.c to sort-criteria.c/sort-cases.c
102 sort-prs.h to sort-criteria.h
103 sel-if.c to select-if.c
104 algorithm.c to array.c
105 algorithm.h to array.h
106 bitvector.h to bit-vector.h
111 readln.c to read-line.c
112 readln.h to read-line.h
113 cmdline.c to command-line.c
114 cmdline.h to command-line.h
117 Sat Feb 11 22:35:20 2006 Ben Pfaff <blp@gnu.org>
119 General clean-ups and minor bug fixes.
121 * filename.h: Move DIR_SEPARATOR, PATH_SEPARATOR here from
124 * lex-def.h: (macro CHAR_IS_ID1) Removed. All references changed
126 (macro CHAR_IS_IDN) Removed. All references changed to
129 * lex-def.c: (lex_is_id1) New function.
130 (lex_is_idn) New function.
131 (lex_skip_identifier) New function.
132 (lex_id_match_len) Return bool instead of int.
133 (lex_id_match) Ditto.
135 * command.c: (parse_command_name) Convert parsed words to
136 uppercase to make error messages easier to read.
137 (cmd_host) Fix return value.
139 * dfm-read.c: (read_inline_record) Use tokens to check for BEGIN
140 DATA, not specialized lexical analysis.
142 * print.c: (print_space_trns_proc) Count of lines should be `int',
143 otherwise we might never finish.
144 (print_space_trns_free) Close writer.
146 * lexer.c: (enum string_type) New enum.
147 (lex_get) Remove essentially unused local variable `cp'.
148 Use enum string_type values. Use parse_id().
149 (parse_id) New function.
150 (lex_look_ahead) Recognize octal strings too.
151 (strip_comments) New function.
152 (lex_get_line) Rewrite.
153 (lex_preprocess_line) Removed.
154 (convert_numeric_string_to_char_string) Use enum string_type.
155 (parse_string) Ditto.
157 * autorecode.c: (recode) Clone correct number of bytes based on
160 Sat Feb 11 22:34:38 2006 Ben Pfaff <blp@gnu.org>
162 Reduce dependencies on getl, and of getl.
164 * data-in.c: (vdls_error) Don't output different message depending
165 on whether we're interactive.
167 * getl.h: (struct getl_line_list) Removed.
168 (struct getl_script) Removed.
169 (GETL_PRPT_*) Removed.
170 (GETL_MODE_*) Removed.
171 (GETL_PROMPT_FIRST, GETL_PROMPT_LATER, GETL_PROMPT_DATA,
172 GETL_PROMPT_CNT) New enums.
174 * settings.c: (static var prompt) Removed.
175 (static var cprompt) Removed.
176 (static var dprompt) Removed.
177 (settings_done) Don't initialize prompt, cprompt, dprompt.
178 (get_prompt) Removed.
179 (set_prompt) Removed.
180 (get_dprompt) Removed.
181 (set_dprompt) Removed.
182 (get_cprompt) Removed.
183 (set_cprompt) Removed.
185 * pfm-read.c: (corrupt_msg) Don't show filename and line number,
186 to get rid of getl_location().
188 * sfm-read.c: (corrupt_msg) Ditto.
190 * getl.c: (struct getl_source) New.
191 (static var cur_source) New.
192 (static var last_source) New.
193 (static var DO_REPEAT_level) Removed.
194 (global var getl_head) Removed.
195 (global var getl_tail) Removed.
196 (getl_initialize) Call init_prompts().
197 (getl_add_file) Removed.
198 (getl_include) Removed.
199 (getl_add_DO_REPEAT_file) Removed.
200 (getl_handle_line_buffer) Removed.
201 (getl_close_file) Removed.
202 (getl_close_all) Removed.
203 (getl_is_separate) Removed.
204 (getl_set_separate) Removed.
205 (getl_reading_script) Removed.
206 (append_source) New function.
207 (include_source) New function.
208 (create_source) New function.
209 (create_syntax_file_source) New function.
210 (create_filter_source) New function.
211 (create_function_source) New function.
212 (create_interactive_source) New function.
213 (getl_append_syntax_file) New function.
214 (getl_include_syntax_file) New function.
215 (getl_include_filter) New function.
216 (getl_include_function) New function.
217 (getl_append_interactive) New function.
218 (getl_abort_noninteractive) New function.
219 (getl_is_interactive) New function.
220 (close_source) New function.
221 (getl_location) Use new `cur_source' var.
222 (getl_uninitialize) Use close_source(). Call uninit_prompts().
223 (read_syntax_file) New function.
224 (read_line_from_source) New function.
225 (do_read_line) New function.
226 (getl_read_line) Rewrite.
227 (static var prompts) New.
228 (static var current_style) New.
229 (init_prompts) New function.
230 (uninit_prompts) New function.
231 (getl_get_prompt) New function.
232 (getl_set_prompt) New function.
233 (getl_set_prompt_style) New function.
234 (get_prompt) New function.
236 * command.c: Merge the EXIT (aka Q, aka QUIT) and FINISH commands,
237 and make EXIT undocumented. EXIT was a PSPP extension that never
238 really entirely made sense.
240 (cmd_finish) Return CMD_EOF unconditionally.
241 (cmd_clear_transformations) Drop requirement of interactivity.
243 * command.def: Merge the EXIT (aka Q, aka QUIT) and FINISH
246 * repeat.c: Major changes to match getl revision.
247 (struct line_list) New struct.
248 (enum repeat_entry_type) New.
249 (struct repeat_entry) Made `type' an enum repeat_entry_type.
250 (struct repeat_block) New.
251 (static var repeat_tab) Removed.
252 (static var count) Removed.
253 (static var line_buf_head) Removed.
254 (static var line_buf_tail) Removed.
255 (cmd_do_repeat) Rewritten.
257 (append_record) Removed.
258 (recognize_keyword) New function.
259 (internal_cmd_do_repeat) Removed.
260 (parse_specification) New function.
261 (skip_indentor) New function.
262 (recognize_do_repeat) New function.
263 (recognize_end_repeat) New function.
264 (parse_lines) New function.
265 (create_vars) New function.
266 (parse_ids) Use enum repeat_entry_type.
267 (parse_strings) Ditto.
268 (find_DO_REPEAT_substitution) Renamed find_substitution(),
270 (perform_DO_REPEAT_substitutions) Renamed do_repeat_filter(),
272 (do_repeat_read) New function.
273 (do_repeat_close) New function.
275 * data-list.c: Don't need to keep track of eof from getl anymore,
276 because getl can tell us now.
277 (struct data_list_pgm) Removed `eof' member.
278 (cmd_data_list) Don't assign to `eof'.
279 (get_data_list_read_func) Renamed read_from_data_list(), changed
281 (read_from_data_list_fixed) Changed interface.
282 (read_from_data_list_free) Changed interface.
283 (read_from_data_list_list) Changed interface.
284 (data_list_trns_proc) Rewrote based on dfm_eof() and
286 (data_list_source_read) Check for dfm reader errors.
288 * dfm-read.c: (enum dfm_reader_flags) Removed DFM_EOF in favor of
289 new `eof_cnt' member in struct dfm_reader.
290 (struct dfm_reader) New `eof_cnt' member.
291 (dfm_close_reader) Check `eof_cnt', not DFM_EOF.
292 (dfm_open_reader) Initialize `eof_cnt'.
293 (read_inline_record) Set prompt style with
294 getl_set_prompt_style().
295 (read_record) Rewrite.
296 (cmd_begin_data) Set prompt style with getl_set_prompt_style().
298 * include.c: (cmd_include) Use getl_include_syntax_file().
300 * set.q: (cmd_set) Use getl_set_prompt().
302 * html.c: (postopen) Remove "source-file" expansion variable, to
303 avoid use of getl_location().
305 * postscript.c: (postopen) Remove "source-file" expansion
306 variable, to avoid use of getl_location().
308 * cmdline.c: (parse_command_line) Drop -c command line option,
309 because it wasn't very useful. -i command line option now calls
310 getl_append_interactive(). Use new getl function interfaces.
311 Drop support for clearing dictionary between syntax files and thus
312 the "+" command line syntax.
313 (static var pre_syntax_message) Remove description of now-gone -c
314 option. Remove "+" command line syntax.
316 * main.c: (main) Only call handle_error() if the return value is
318 (execute_command) Use getl_set_prompt_style(). Drop support for
319 clearing dictionary between syntax files.
320 (handle_error) Handle CMD_CASCADING_FAILURE. Don't call err_break().
322 * readln.c: Drop lots of #ifdefs. Now that the Autoconf tests are
323 pickier, we can just use HAVE_READLINE.
324 (static var welcomed) Move into welcome().
325 (welcome) Make `welcomed' a local static var. Check for and read
327 (global var getl_mode) Removed.
328 (global var getl_interactive) Removed.
329 (global var getl_prompt) Removed.
330 (getl_read_line) removed.
331 (readln_read) New function.
332 (read_console) Removed.
335 Sat Feb 11 22:16:21 2006 Ben Pfaff <blp@gnu.org>
337 Try to reduce some of the nastier dependencies on the error
338 module, and at the same time make PSPP nicer to deal with, by
339 getting rid of fatal errors. All the existing calls to msg (FE,
340 ...) or err_cond_fail() or err_failure() have been replaced by
341 propagating an error upward to the command-dispatch layer.
342 Unfortunately this propagation took a fair bit of extra mechanism,
343 because now a lot of functions can fail that couldn't before.
345 New command return value CMD_CASCADING_FAILURE which indicates to
346 the command processor that syntax file processing should be
347 abandoned. Many commands were modified to return
348 CMD_CASCADING_FAILURE. When this modification was trivial it
349 isn't mentioned in detail below.
351 Transformation procedures (trns_proc_func) and free functions
352 (trns_free_func) now have a `bool' return type, which is normally
353 true, but false when an I/O or other serious error occurs. All
354 transformation functions were modified to have this return type.
355 When this modification was trivial it isn't mentioned in detail
358 * pspp-error.h: (FE) Removed this error class.
360 * error.c: (err_failure) Removed.
361 (err_cond_fail) Removed.
362 (err_break) Removed (it was unused).
363 (err_check_count) Don't cause a fatal error--instead, stop reading
365 (err_vmsg) Don't have FE anymore, so no need to call terminate().
367 * any-reader.c: (any_reader_error) New function.
369 * any-writer.c: (any_writer_write) Propagate
370 scratch_writer_write_case()'s new return value.
371 (any_writer_error) New function.
372 (any_writer_close) Propagate underlying function's new return
375 * casefile.c: Add an "error state" to a casefile. A casefile that
376 encounters an I/O error enters the error state, and afterward
377 reading and writing cases fails.
378 (struct casefile) Add `ok' member.
379 (casefile_create) Set `ok' to true.
380 (casefile_destroy) Use io_error().
381 (casefile_error) New function.
382 (casefile_sleep) Now returns bool to indicate success.
383 (casefile_append) Ditto.
384 (casefile_append_xfer) Ditto.
385 (casefile_to_disk) Ditto.
386 (write_case_to_disk) Don't do anything in error state.
387 (flush_buffer) Don't do anything in error state. Use io_error().
388 (reader_open_file) Ditto.
390 (casereader_read) Don't do anything in error state. Handle
392 (casereader_read_xfer_assert) Removed, because now an I/O error
393 can occur even if the caller knows a case exists.
394 (io_error) New function.
396 * mkfile.c: (make_temp_file) Make failure non-fatal.
397 (make_unique_file_stream) Ditto.
399 * pfm-read.c: Add an error state.
400 (struct pfm_reader) Add `ok' member to indicate error state.
401 (error) Set `ok' to false.
402 (pfm_open_reader) Set `ok' to true. Make failure non-fatal.
403 (pfm_read_case) Don't do anything in error state.
404 (pfm_read_error) New function.
406 * pfm-write.c: Postpone most error checking in favor of checking
408 (pfm_open_writer) Make failure non-fatal. Check for write error
409 after writing header.
410 (buf_write) Don't do anything if error has occurred. Postpone
411 error checking. Change return type to void.
412 (write_float) Postpone error checking. Change return type to
415 (write_string) Ditto.
416 (write_header) Ditto.
417 (write_version_data) Ditto.
418 (write_format) Ditto.
420 (write_variables) Ditto.
421 (write_value_labels) Ditto.
422 (pfm_write_case) Don't do anything if error has occurred.
423 (pfm_write_error) New function.
424 (pfm_close_writer) Change return type to bool. Return false if an
427 * scratch-reader.c: (scratch_reader_error) New function.
429 * scratch-writer.c: (scratch_writer_write_case) Change return type
430 to bool. Propagate casefile error return.
431 (scratch_writer_error) New function.
432 (scratch_writer_close) Change return type to bool. Propagate
433 casefile error return.
435 * sfm-read.c: Add an error state.
436 (struct sfm_reader) Add `ok' member.
437 (sfm_open_reader) Initialize `ok'. Make errors non-fatal.
438 (buf_read) Set `ok' to false on error.
439 (buffer_input) Do nothing in error state. Set `ok' to false on
441 (read_compressed_data) Set `ok' false on error.
442 (sfm_read_case) Return false in error state.
443 (fread_ok) Set `ok' false on error.
444 (sfm_read_error) New function.
446 * sfm-write.c: Postpone most error checking in favor of checking
448 (sfm_open_writer) Make failure non-fatal. Check for write error
449 after writing header.
450 (write_header) Postpone error checking. Change return type to
452 (write_variable) Ditto.
453 (write_value_labels) Ditto.
454 (write_documents) Ditto.
455 (write_variable_display_parameters) Ditto.
456 (write_longvar_table) Ditto.
457 (write_rec_7_34) Ditto.
459 (ensure_buf_space) Ditto.
460 (sfm_write_case) Do nothing if write error has occurred.
461 (sfm_write_error) New function.
462 (pfm_close_writer) Change return type to bool. Return false if an
465 * var.h: Introduced a new return value for trns_proc_func that
466 means "a serious error has occurred, so abort the procedure
467 entirely". Because the hard-coded values of -1, -2, etc. were
468 becoming even a worse idea now, also introduced some macros for
469 them: TRNS_CONTINUE, TRNS_DROP_CASE, TRNS_ERROR, TRNS_NEXT_CASE,
470 TRNS_END_FILE. Also replaced all references to the hard-coded
471 values by uses of the macros.
473 * command.h: New command return value CMD_CASCADING_FAILURE which
474 indicates to the command processor that syntax file processing
477 * dfm-read.c: (dfm_open_reader) Make failure non-fatal.
478 (dfm_reader_error) New function.
479 (read_inline_record) Make unexpected end of file nonfatal.
480 (read_file_record) Make read error nonfatal.
481 (dfm_eof) Make second unexpected end of file nonfatal.
482 (cmd_begin_data) Make errors nonfatal.
484 * dfm-write.c: (dfm_open_writer) Make failure non-fatal.
485 (dfm_write_error) New function.
486 (dfm_put_record) Do nothing in error state. Now return error
488 (dfm_close_reader) Now return `bool' indicating error state.
490 * file-type.c: (file_type_source_read) Now return `bool'
491 indicating error state.
493 * get.c: (case_reader_source_read) Now return `bool' indicating
495 (case_writer_destroy) Ditto.
496 (case_writer_write_case) Ditto.
497 (struct mtf_proc) New member `ok' indicating error state.
498 (cmd_match_files) Initialize and deal with `ok'.
499 (mtf_processing_finish) Now return `bool' indicating I/O error.
500 (mtf_free_file) Renamed mtf_close_file(). Now return `bool'
501 indicating I/O error.
502 (mtf_free) Now return `bool' indicating I/O error.
503 (mtf_delete_file_in_place) Ditto.
504 (mtf_read_nonactive_records) Ditto.
505 (mtf_processing) Ditto.
507 * inpt-pgm.c: (input_program_source_read) Now return `bool'
508 indicating I/O error. Handle new TRNS_ERROR transformation return
511 * matrix-data.c: Introduce error state.
512 (cmd_matrix_data) Check error return values.
513 (read_matrices_without_rowtype) Now return `bool' indicating I/O
515 (matrix_data_read_without_rowtype) Ditto.
516 (dump_cell_content) Ditto.
517 (nr_output_data) Ditto.
518 (read_matrices_with_rowtype) Ditto.
519 (matrix_data_read_with_rowtype) Ditto.
520 (wr_output_data) Ditto.
522 * lexer.c: (lex_init) Make unexpected eof non-fatal.
524 (lex_look_ahead) Ditto.
525 (unexpected_eof) Removed.
526 (convert_numeric_string_to_char_string) Make unexpected eof
528 (parse_string) Ditto.
530 * flip.c: Make I/O errors non-fatal.
531 (struct flip_pgm) Add `pool', `output_buf' members.
532 (cmd_flip) Create and use pool. Propagate errors.
533 (destroy_flip_pgm) Rewrite, using pool.
534 (struct flip_sink_info) Removed.
535 (flip_sink_create) Use pool. Make errors non-fatal.
536 (flip_sink_write) Make errors non-fatal.
537 (flip_file) Make errors non-fatal. Make `bool' return type to
539 (flip_sink_destroy) Remove.
540 (static var flip_sink_class) Use NULL as destroy func, not
543 * sort.c: Make I/O errors non-fatal. Propagate errors.
544 (sort_active_file_in_place) Propagate errors.
545 (sort_active_file_to_casefile) Ditto.
546 (do_internal_sort) Ditto.
547 (do_external_sort) Ditto.
549 (destroy_initial_run_state) Propagate errors via new `bool' return
551 (merge) Propagate errors.
554 * output.c: [GLOBAL_DEBUGGING] Remove reentrancy detection,
555 because it used msg (FE, ...) and wasn't very useful.
557 * main.c: (handle_error) Handle CMD_CASCADING_FAILURE.
559 * vfm.c: (struct write_case_data) Change `proc_func' return type
561 (procedure) Add `bool' return type to indicate I/O error.
563 (internal_procedure) Ditto.
565 (execute_transformations) If a transformation returns TRNS_ERROR,
567 (close_active_file) Add `bool' return type to indicate I/O error.
569 (cancel_transformations) Add `bool' return type to indicate I/O
570 error. Propagate errors.
571 (struct split_aux_data) Change `proc_func' return type to bool.
572 (procedure_with_splits) Change `proc_func' return type to bool.
573 Add `bool' return type to indicate I/O error.
574 (multipass_procedure_with_splits) Change `split_func' return type
575 to bool. Add `bool' return type to indicate I/O error.
576 (multipass_split_callback) Add `bool' return type to indicate I/O
577 error. Propagate errors.
579 * vfm.h: (struct case_source_class) Change `read' return type from
580 void to bool to allow reporting I/O errors. Updated all
581 implementations to do so.
582 (struct case_sink_class) Change `write' return type from void to
583 bool to allow reporting I/O errors. Updated all implementations
586 Sun Feb 12 18:12:56 2006 Ben Pfaff <blp@gnu.org>
588 * pool.c: Useful new functions.
589 (pool_tmpfile) New function.
590 (pool_attach_file) New function.
591 (pool_detach_file) New function.
592 (pool_fopen) Reimplement in terms of pool_attach_file().
593 (pool_fclose) Reimplement in terms of pool_detach_file(). Fix
596 * str.c: Useful new functions.
597 (ds_swap) New function.
598 (ds_rtrim_spaces) New function.
599 (ds_chomp) New function.
600 (ds_is_empty) New function.
601 (ds_first) New function.
602 (ds_last) New function.
604 Sat Feb 11 21:51:21 2006 Ben Pfaff <blp@gnu.org>
606 Get rid of finished, start_interactive globals.
608 * command.c: (cmd_exit) Instead of setting `finished', return
612 * command.h: New enum CMD_EOF.
614 * main.c: (global var finished) Removed.
615 (global var start_interactive) Removed.
616 (main) Execute commands until CMD_EOF is the return value.
617 If parse_command_line() returns false, don't execute any commands
620 * cmdline.c: (parse_command_line) If the command line indicates we
621 shouldn't execute syntax files, return false instead of
623 (usage) Don't terminate.
625 Sat Feb 11 21:48:31 2006 Ben Pfaff <blp@gnu.org>
627 Get rid of cur_proc global. Replace by functions in err and tab
628 modules, which were the users.
630 * error.c: (static var command_name) New static var.
631 (err_vmsg) Use command_name.
632 (err_set_command_name) New function.
634 * tab.c: (static var command_name) New static var.
635 (tabi_title) Use command_name.
636 (tab_set_command_name) New function.
638 * command.c: (global var cur_proc) Removed.
639 (cmd_parse) Call err_set_command_name(), tab_set_command_name()
640 around executing command to set and clear command name.
642 Sat Feb 11 21:44:50 2006 Ben Pfaff <blp@gnu.org>
644 Get rid of glob.c, glob.h.
646 * Makefile.am: (pspp_SOURCES) Remove glob.c, glob.h.
648 * dictionary.c: Move default_dict definition here.
651 (global var FILTER_before_TEMPORARY) Variable removed. All
652 references deleted. The info in this var was redundant with
653 temp_dict, so they were changed to use temp_dict where needed.
657 * start-date.c: New file. Moved get_start_date() here.
659 * start-date.h: New file.
661 Fri Feb 3 20:34:52 2006 Ben Pfaff <blp@gnu.org>
663 * font.h: (struct font_set) Removed, because unused.
665 Sat Jan 28 17:45:36 2006 Ben Pfaff <blp@gnu.org>
667 Cleaner (faster?) way to compact cases.
669 * dictionary.c: (dict_compact_case) Removed.
670 (dict_needs_compaction) New function.
671 (struct copy_map) New structure.
672 (struct dict_compactor) New structure.
673 (dict_make_compactor) New function.
674 (dict_compactor_compact) New function.
675 (dict_compactor_destroy) New function.
677 Sat Jan 28 17:24:22 2006 Ben Pfaff <blp@gnu.org>
681 * data-list.c: Make data_list_source_class static.
682 (dump_fixed_table) Use fh_get_name() to describe source of data.
683 (dump_free_table) Ditto.
684 (cmd_repeating_data) Eliminate special cases for inline file.
686 * dictionary.c: (dict_contains_var) Change return value from int to
688 (dict_rename_vars) Ditto.
689 (dict_create_vector) Ditto.
691 Sat Jan 28 17:20:50 2006 Ben Pfaff <blp@gnu.org>
693 Add scratch file handles.
695 Now a file handle can refer to a disk file, to an in-memory
696 structure, or to the "inline" file, instead of just to a disk
697 file. The introduction of new categories means that special cases
698 for the inline file in a few places could be eliminated, but it
699 also means that code that assumed that a handle refers to a file
700 has to check for that.
702 Also, now file handles can be freed, so code now must be sure not
703 to access a handle after closing it (with fh_close()).
705 * Makefile.am: Add any-reader.c, any-reader.h, any-writer.c,
706 any-writer.h, scratch-handle.c, scratch-handle.h,
707 scratch-reader.c, scratch-reader.h, scratch-writer.c,
708 scratch-writer.h to pspp_SOURCES.
710 * any-reader.c: New file.
712 * any-reader.h: New file.
714 * any-writer.c: New file.
716 * any-writer.h: New file.
718 * scratch-handle.c: New file.
720 * scratch-handle.h: New file.
722 * scratch-reader.c: New file.
724 * scratch-reader.h: New file.
726 * scratch-writer.c: New file.
728 * scratch-writer.h: New file.
730 * aggregate.c: Use an any_writer instead of an sfm_writer, to add
733 * apply-dict.c: Use an any_reader instead of an sfm_reader, to add
736 * command.def: Add CLOSE FILE HANDLE command.
738 * dfm-reader.c: Now fewer special cases for inline file.
739 (static var inline_open_cnt) Removed.
740 (static var inline_file) Removed.
741 (dfm_close_reader) Eliminate a special case for inline file.
742 Reorganize to avoid access-after-free.
743 (dfm_open_reader) Eliminate a special case for inline file.
744 (read_inline_record) Use bool instead of int. No need to
745 increment line number.
746 (read_file_record) Use bool instead of int.
747 (read_record) Check whether file handle is inline file, instead of
750 (dfm_expand_tabs) Ditto.
753 (cmd_begin_data) Fix inaccurate check for whether the inline file
754 is in use--now we can tell by checking whether the inline file's
755 open count is positive.
757 * file-handle-def.c: (struct file_handle) Reorder members. Add
758 `deleted' member. Add `referent' member. Add `sh' member.
759 (static var default_handle) New variable.
760 (static var inline_file) New variable.
761 (fh_init) Initialize inline file.
762 (free_handle) New function.
764 (fh_from_name) Don't return deleted handles.
765 (fh_from_filename) Ditto.
767 (create_handle) New function.
768 (fh_create_file) New function.
769 (fh_create_scratch) New function.
770 (fh_inline_file) New function.
772 (fh_open) Now requires a referent type mask and verifies it. All
774 (fh_close) If open_cnt goes to 0 on a deleted handle, free it.
775 (fh_is_open) New function.
776 (fh_get_referent) New function.
777 (fh_get_filename) Limit to handles that refer to files.
779 (fh_get_record_width) Limit to handles that refer to files or the
781 (fh_get_tab_width) Ditto.
782 (fh_get_scratch_handle) New function.
783 (fh_set_scratch_handle) New function.
784 (fh_get_default_handle) New function.
785 (fh_set_default_handle) New function.
787 * file-handle.h: (enum fh_referent) New type.
788 (enum fh_mode) Rename MODE_TEXT to FH_MODE_TEXT, MODE_BINARY to
789 FH_MODE_BINARY, and update all usages.
791 * file-handle.q: Add "scratch" as a possible mode.
792 (cmd_file_handle) Mention CLOSE FILE HANDLE in error message.
793 Use lex_end_of_command(), lex_sbc_missing(). Support creating
795 (cmd_close_file_handle) New function.
796 (referent_name) New function.
797 (fh_parse) Now takes a referent type mask to specify handles that
798 can be accepted. Updated all references.
800 * filename.c: (fn_extension) New function.
802 * get.c: Use any_reader and any_writer and thereby merge code that
803 has been duplicated for each kind of file. Also, we had something
804 here called `any_writer' before, so its name had to be changed to
806 (enum operation) Removed, because unused.
807 (struct get_pgm) Removed.
808 (get_pgm_free) Removed.
809 (get_source_destroy) Removed.
810 (get_source_read) Removed.
811 (global var get_source_class) Removed.
812 (static var case_reader_source_class) Removed.
813 (enum reader_command) New enum.
814 (struct case_reader_pgm) New struct.
815 (parse_read_command) New function.
816 (case_reader_pgm_free) New function.
817 (case_reader_source_destroy) New function.
818 (case_Reader_source_Read) New function.
819 (cmd_get) Rewrote as a call to parse_read_command().
821 (struct any_writer) Rename to case_writer. Drop `writer_type',
822 `writer' members in favor of an `any_writer' member named
824 (any_writer_destroy) Rename case_writer_destroy. Use
826 (parse_write_command) Allow scratch files. Use any_writer.
827 (any_writer_write_case) Rename case_writer_write_case(). Use
829 ` (struct mtf_file) Use any_reader.
830 (cmd_match_files) Allow scratch files. Use any_reader.
831 (mtf_free_file) Use any_reader_close().
832 (mtf_read_nonactive_records) Use any_reader_read().
833 (mtf_processing) Use any_reader_read().
834 (struct import_pgm) Removed.
835 (import_pgm_free) Removed.
836 (import_source_destroy) Removed.
837 (import_source_read) Removed.
838 (global var import_source_class) Removed.
840 * glob.c: (global var default_handle) Removed. Replaced all
841 references by fh_get_default_handle() or fh_set_default_handle().
843 * pfm-read.c: (static var portable_to_local) Moved from inside
844 read_header() to top level.
845 (pfm_detect) New function.
847 * pfm-write.c: (pfm_write_case) Make case argument const.
848 Reorganize to avoid access-after-free.
850 * print.c: (dump_table) Use fh_get_name() to describe source of
853 * sfm-read.c: (sfm_close_reader) Reorganize to avoid
855 (sfm_detect) New function.
857 * str.c: (str_lowercase) New function.
859 * vfm.c: Use new compaction interface.
860 (static var compaction_necessary) Removed.
861 (static var compactor) New variable.
862 (open_active_file) Initialize compactor.
863 (write_case) Use compactor.
864 (close_active_file) Free compactor.
866 Wed Jan 11 19:28:39 2006 Ben Pfaff <blp@gnu.org>
868 Clean up file handle code in preparation to add scratch file
871 * file-handle-def.c: Lots of formatting cleanup. Added function
873 (struct file_handle) Renamed `length' member
874 to `record_width'. All references updated.
875 (fh_init) New function. Moved here from file-handle.q.
876 (fh_done) New function. Moved here from file-handle.q and
878 (get_handle_with_name) Renamed fh_from_name().
879 (get_handle_for_filename) Renamed fh_from_filename().
880 (create_file_handle) Renamed fh_create(). Changed to take a
881 `struct fh_properties' instead of discrete values. Updated all
883 (create_file_handle_with_defaults) Removed. Updated all
884 references to use fh_create() with fh_default_properties().
885 (fh_default_properties) New function.
886 (destroy_file_handle) Removed. The code is now in fh_done().
887 (handle_get_name) Renamed fh_get_name().
888 (handle_get_filename) Renamed fh_get_filename().
889 (handle_get_record_width) Renamed fh_get_record_width().
890 (handle_get_tab_width) Renamed fh_get_tab_width().
892 * file-handle-def.h: Formatting, comment fixes.
893 (enum file_handle_mode) Renamed struct fh_mode.
894 (struct fh_properties) New structure.
895 (fh_init) Move prototype here from file-handle.h.
899 * file-handle.q: (static var handle_list) Removed.
900 (fh_parse) Don't add handle to handle_list, because
901 file-handle-def.c has its own list.
902 (fh_init) Moved to file-handle-def.c.
905 Sun Jan 9 01:09 Jason Stover <jason@sakla.net>
907 * regression.q: (run_regression) Moved coefficient initialization
908 to the linreg library. Altered other functions accordingly.
910 Sat Jan 7 13:30:54 WST 2006 John Darrington <john@darrington.wattle.id.au>
912 * command.c data-in.c main.c: Fixed bug which crept in when
913 separating getl from readline.
915 * vars-atr.c value-labels.h: Fixed constness of val_labs_count.
917 Fri Dec 23 20:59:01 WST 2005 John Darrington <john@darrington.wattle.id.au>
919 * getl.c error.c: Separated file_loc functionality from error.c
921 Mon Dec 19 14:01:56 WST 2005 John Darrington <john@darrington.wattle.id.au>
923 * format.c: Additional error checking.
924 * getl.[ch]: Separated into getl.c and readln.c
925 * settings.[ch]: Made CC_CNT public
927 Fri Dec 16 09:11:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
929 * examine.q: Fixed buglet when cleaning up at end of procedure.
931 Tue Dec 13 22:34:42 2005 Ben Pfaff <blp@gnu.org>
933 Move global initialization and cleanup code into main.c.
934 Remove vestigial log infrastructure.
935 Minor related cleanups.
937 * command.c: (shell) When execl() fails, use _exit(), not
940 * error.c: (err_hcf) Move into main.c, rename terminate(). All
942 (err_done) New function with just the error.c-specific code for
943 err_hcf(). Called by terminate().
945 * glob.c: Removed all Borland C, DJGPP cruft.
946 (init_glob) Merged into main().
947 (done_glob) Merged into terminate().
949 (get_start_date) New function. All users of curdate updated to call
950 this function instead.
952 * lexer.c: (lex_init) Moved initialization of tokstr here, from
954 (lex_done) Moved destruction of tokstr here, from done_glob().
956 * main.c: (global var pgmname) Removed. Changed all references to
957 program_name, which is defined by gnulib.
958 (global var curdate) Removed.
959 (main) Moved init_glob() code here. Merged parse_script() in
961 (parse_script) Removed.
962 (terminate) Moved err_hcf() here from error.c and renamed
963 terminate(). Merged done_glob() code in here. Call err_done().
965 (i18n_init) New function.
966 (fpu_init) New function.
968 * output.c: (outp_init) Make void.
969 (init_default_drivers) New function.
970 (outp_read_devices) If no drivers are initialized successfully,
971 call init_default_drivers() to initialize a default driver.
972 (outp_done) Make void.
973 (static var prog) Make const.
974 (parse_options) Make parameter const.
975 (colon_tokenize) Make return value const.
976 (configure_driver) Change prototype to take a broken-down driver
977 configuration instead of a line of text.
978 (configure_driver_line) New function that does what
979 configure_driver() did before.
981 * q2c.c: (global var pgmname) Rename program_name.
983 * settings.c: (settings_init) Renamed from init_settings().
984 (settings_done) Renamed from done_settings().
986 * vfm.c: (global var last_vfm_invocation) Make static.
987 (vfm_last_invocation) New function. All references to
988 last_vfm_invocation update to call this.
989 (procedure) Call update_last_vfm_invocation().
990 (internal_procedure) Ditto.
991 (update_last_vfm_invocation) New function.
993 Sat Dec 10 23:30:19 2005 Ben Pfaff <blp@gnu.org>
995 Separate random numbers from other settings because of GSL
998 * Makefile.am: Add random.c, random.h to sources.
1000 * glob.c: (init_glob) Call random_init().
1001 (done_glob) Call random_done().
1003 * settings.c: (static var rng) Move to random.c.
1004 (done_settings) Move freeing of RNG to random_done().
1005 (get_rng) Move to random.c
1008 * random.c: New file.
1010 * random.h: New file.
1012 Sat Dec 10 18:13:36 2005 Ben Pfaff <blp@gnu.org>
1014 Separate settings and the SET command, for modularity.
1016 * Makefile.am: Add settings.c to sources.
1018 * glob.c: (global variable test_mode) Removed.
1020 * set.q: Remove all the set_* variables. Remove a lot of obsolete
1021 SPSS/PC+ settings. Remove the aux_*() routines. Moved the
1022 get_*() functions into settings.c. Rewrite the settings code and
1023 functions to call the new set_*() functions. Rewrite custom
1024 currency parsing. Write new by-hand cmd_show().
1026 * esttings.c: New file. Moved the get_*() functions here from
1027 set.q. Created new set_*() functions to correspond with them.
1028 Regularized the names and types of some functions and updated
1029 their callers. Added static, file-scope variables to support the
1032 * q2c.c: Remove "aux" support, which was only needed by set.q.
1034 Sun Nov 27 06:43:46 WST 2005 John Darrington <john@darington.wattle.id.au>
1036 * data-out.c format.h: Added return value to data_out function.
1038 * value-labels.c: Fixed bug in val_labs_remove.
1040 Sat Nov 5 18:37:26 2005 Ben Pfaff <blp@gnu.org>
1042 * Makefile.am: Remove devind.c, devind.h from list of source
1045 * devind.c: Removed.
1047 * devind.h: Removed.
1049 * list.q: Removed "support" for devind.
1051 * output.c: Don't add devind class.
1053 Sat Nov 5 18:21:00 2005 Ben Pfaff <blp@gnu.org>
1055 * var.h: (struct variable) Make `init', `reinit' bool values.
1058 Fri Nov 4 19:43:01 2005 Ben Pfaff <blp@gnu.org>
1060 * recode.c: Rewrote whole file, as clean-up.
1062 Fri Nov 4 19:37:50 2005 Ben Pfaff <blp@gnu.org>
1064 * pool.c: Don't make alignment exception for x86.
1065 (pool_alloc) Return null for 0-size blocks.
1066 (pool_alloc_unaligned) New function.
1067 (pool_strndup) Removed. Changed callers to use pool_clone_unaligned().
1068 (pool_clone_unaligned) New function.
1069 (pool_strdup) Use pool_clone_unaligned().
1071 * var.h: (enum var_type) Give the NUMERIC, ALPHA enum this name.
1072 (struct variable) Use `enum var_type' for `type'.
1074 * vars-atr.c: (var_type_adj) New function.
1075 (var_type_noun) New function.
1077 * vars-prs: (parse_mixed_vars) Fix freeing code.
1078 (parse_mixed_vars_pool) New function.
1080 Wed Nov 2 21:24:48 2005 Ben Pfaff <blp@gnu.org>
1082 * file-handle-def.c: Needed another #include, to avoid missing
1085 * file-handle.q: (cmd_file_handle) Declarations must precede
1086 statements. Free parse data on success as well as on failure, to
1089 * get.c: (parse_write_command) Destroy dict on success, to avoid
1092 * data-list.c: (cmd_repeating_data) Fix usage of saw_occurs,
1093 saw_length, saw_continued, saw_id, which were boolean but
1094 incorrectly treated as bitmaps as result of a previous
1095 half-finished cleanup.
1097 * weight.c: (struct weight_trns) Unused, so removed.
1099 * Makefile.am: Add range-prs.h to sources.
1101 Wed Nov 2 21:24:15 2005 Ben Pfaff <blp@gnu.org>
1103 DO IF, LOOP cleanup.
1105 * Makefile.am: Add ctl-stack.c, ctl-stack.h to source files.
1106 Reformat source file list to list one file per file, so that
1107 patches for future changes will be easier to read.
1109 * ctl-stack.c, ctl-stack.h: New files.
1111 * do-if.c: Rewrote whole file.
1113 * do-ifP.h: Removed.
1115 * loop.c: Rewrote whole file.
1117 * glob.c: (global var ctl_stack) Move into ctl-stack.c.
1119 * temporary.c: (cmd_temporary) Use ctl_stack_is_empty().
1121 * vfm.c: (open_active_file) Use ctl_stack_clear().
1123 Wed Nov 2 21:18:13 2005 Ben Pfaff <blp@gnu.org>
1127 * pool.c: (pool_create_at_offset) New function.
1128 (pool_add_subpool) New function.
1130 * pool.h: (pool_create_container) New macro.
1132 * expressions/parse.c: (expr_parse_pool) New function.
1134 * autorecode.c: (recode) Use pool_create_container().
1136 * count.c: (cmd_count) Ditto.
1138 Wed Nov 2 19:59:32 2005 Ben Pfaff <blp@gnu.org>
1140 Clean up transformations, by getting rid of `struct trns_header',
1141 replacing it by `struct transformation' that has a void *
1142 `private' member. Updated all uses of transformations to match,
1143 which was a lot of code. Only major related changes listed below.
1145 * compute.c: (cmd_if) Use get_proc_func().
1146 (cmd_compute) Use get_proc_func().
1147 (get_proc_func) New function.
1149 * glob.c: (global var m_trns) Change type to size_t.
1150 (global var n_trns) Ditto.
1151 (global var f_trns) Ditto.
1152 (global var t_trns) Change type to struct transformation *.
1154 * var.h: (struct trns_header) Removed.
1155 (struct transformation) New.
1156 (typedef trns_proc_func) Takes a void * instead of a struct
1158 (typedef trns_free_func) Ditto.
1160 * vfm.c: (execute_transformations) Takes an array of
1161 transformations instead of trns_headers.
1162 (add_transformation) Change prototype from (trns_header *) to
1163 (trns_proc_func *, trns_free_func *, void *).
1164 (next_transformation) New function.
1166 Sat Oct 29 16:25:36 2005 Ben Pfaff <blp@gnu.org>
1168 * count.c: Major cleanups. Rename practically everything.
1169 Rewrite much of the code. Use pools for memory management. Use
1170 the new parse_num_range().
1172 * mis-val.c: (cmd_missing_values) Use the new parse_num_range().
1173 (parse_number) Removed.
1175 * missing-values.c: (mv_add_num_range) Don't add out-of-order
1176 ranges, e.g. where low > high.
1178 * pool.c: (pool_2nrealloc) New function.
1180 * range-prs.c: New file.
1181 (parse_num_range) New function.
1182 (parse_number) New function.
1184 Fri Oct 28 22:47:48 2005 Ben Pfaff <blp@gnu.org>
1186 Fix up potential overflows in size calculations by replacing
1187 instances of pool_alloc(p, x * sizeof *y) by pool_malloc(p, x,
1188 sizeof *y) everywhere I could find them. Similarly by
1189 pool_malloc(), pool_realloc().
1190 (Order is important: pool_alloc(p, sizeof *y, x) will divide by 0
1193 * pool.c: (pool_nalloc) New function.
1194 (pool_nmalloc) New function.
1195 (pool_nrealloc) New function.
1197 Thu Oct 27 11:16:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1199 Separated the definition of a file handle object from the stuff
1200 pertaining to the FILE HANDLE command.
1202 * file-handle-def.[ch]: New files.
1204 * dfm-read.c file-handle.h file-handle.q
1206 Tue Oct 25 21:56:23 2005 Ben Pfaff <blp@gnu.org>
1208 Fix up potential overflows in size calculations by replacing
1209 instances of xmalloc(x * sizeof *y) by xnmalloc(x, sizeof *y)
1210 everywhere I could find them. Similarly by xrealloc(), malloc().
1211 (Order is important: xnmalloc(sizeof *y, x) will divide by 0 if x
1214 * alloc.c: (nmalloc) New function.
1215 (out_of_memory) Removed. Replaced references by xalloc_die().
1217 * sort.c: (allocate_cases) Fix segfault if memory allocation
1220 * subclist.c: (subc_list_double_create) Use xnmalloc() instead of
1222 (subc_list_double_push) Use xnrealloc() instead of realloc().
1224 Wed Oct 26 08:43:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1226 Dictionary abstraction part #2
1228 * algorithm.c format.c str.c sysfile-info.c val.h var.h vars-atr.c:
1229 Removed unnecessary #include directives
1231 Mon Oct 24 21:35:08 2005 Ben Pfaff <blp@gnu.org>
1233 * groff-font.c (font_msg): Use err_vmsg() instead of incorrectly
1234 trying to pass a va_list to tmsg(). Thanks to Jason Stover for
1237 Mon Oct 24 21:24:15 2005 Ben Pfaff <blp@gnu.org>
1239 Work to get rid of GCC 4.0 warnings, part 2.
1241 In many files, change `unsigned char' to `char'. This often
1242 requires adding casts to <ctype.h> functions.
1244 * data-in.c: (parse_A) Use buf_copy_rpad().
1246 * str.c: (str_copy_buf_trunc) New function.
1248 * value-labels.c: (value_to_string) Fix mistaken use of strncpy(),
1251 Mon Oct 24 13:42:32 WST 2005 John Darrington <john@darrington.wattle.id.au>
1253 Moved some definitions to make it easier to abstract a dictionary
1254 from the rest of PSPP.
1256 * format-prs.c lex-def.[ch]: New files.
1258 * Makefile.am lexer.[ch] dictionary.c vars-atr.c vfm.c algorithm.c
1259 format.c: Moved some functions between modules.
1261 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
1263 Work to get rid of GCC 4.0 warnings, part 1.
1265 In many files, change count parameters to parse_variables(),
1266 etc. from `int' to `size_t'. Also change related variables and
1267 struct members. Also change messages as needed (e.g. %d to %u
1268 with cast to unsigned). Also change arithmetic as necessary
1269 (e.g. n >= m - 1 to n + 1 >= m).
1271 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
1274 * q2c.c: (dump_declarations) Generate code for size_t instead of
1277 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
1279 * output.c: (outp_read_devices) Fix message.
1281 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
1283 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
1284 address is passed to dict_get_vars() from size_t to int to match
1285 John's change below.
1287 * modify-vars.c: (validate_var_modification) Ditto.
1289 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
1291 * dictionary.[ch] Changed cnt from size_t* to int* since that's
1292 what it's called as, and on x86_64 machines they're different sizes.
1294 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
1296 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
1298 * lexer.c: (lex_sbc_only_once) New function.
1299 (lex_sbc_missing) New function.
1301 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
1303 * case.h: (case_str) Make it return `unsigned char'.
1305 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
1307 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
1308 subcommands that we didn't support. Fix bug 13911. Fix bug
1309 reported by Adam Pierson (COMPRESSED and other subcommands didn't
1310 work on SAVE). Refactor all related code.
1312 * command.def: Add XEXPORT command.
1314 * dictionary.c: (dict_delete_scratch_vars) New function.
1316 * get.c: (cmd_get) Fix parsing.
1317 (struct save_trns) Removed.
1318 (cmd_save_internal) Removed.
1320 (do_write_case) Removed.
1321 (save_write_case_func) Removed.
1322 (save_trns_proc) Removed.
1323 (save_trns_free) Removed.
1324 (trim_dictionary) Removed.
1325 (struct export_proc) Removed.
1326 (cmd_export) Rewrote.
1327 (export_write_case_func) Removed.
1328 (export_proc_free) Removed.
1329 (enum writer_type) New enum.
1330 (enum command_type) New enum.
1331 (struct any_writer) New struct.
1332 (any_writer_destroy) New function.
1333 (parse_write_command) New function.
1334 (any_writer_write_case) New function.
1335 (parse_output_proc) New function.
1336 (output_proc) New function.
1338 (cmd_xsave) Rewrote.
1339 (struct output_trns) New struct.
1340 (parse_output_trns) New function.
1341 (output_trns_proc) New function.
1342 (output_trns_free) New function.
1343 (cmd_xsave) Rewrote.
1344 (cmd_xexport) New function.
1345 (parse_dict_trim) New function.
1346 (struct mtf_proc) Change `by_cnt' member type to `int'.
1347 (cmd_import) Rewrote.
1349 * pfm-write.c: (struct pfm_writer) Add `digits' member.
1350 (pfm_writer_default_options) New function.
1351 (pfm_open_writer) Add `opts' argument and handle options.
1352 (write_float) Write only as many digits as `digits' member says.
1353 (format_trig_double) Limit base-10 precision to LDBL_DIG.
1355 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
1356 (struct pfm_write_options) New struct.
1358 * sfm-write.c: (sfm_writer_default_options) New function.
1359 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
1360 `opts' argument. Implement options.
1362 * sfm-write.h: (struct sfm_write_options) New struct.
1364 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
1365 char *' instead of `char *'.
1367 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
1369 * factor_stats.c: Needed <config.h> included earlier.
1371 * percentiles.c: Needed to include <config.h>.
1373 * val.h: Don't include "config.h".
1375 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
1377 Clean up treatment of missing values by moving all the code into
1378 one place. All references to the missing value function were
1379 updated, but only major changes are detailed below.
1381 * Makefile.am: Add missing-values.c, missing-values.h to sources.
1383 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
1385 * dictionary.c: (dict_create_var) Initialize `miss' member with
1387 (dict_clone_var) Copy `miss' member with mv_copy().
1389 * get.c: (mtf_merge_dictionary) Use mv_copy().
1391 * missing-values.c: New file.
1393 * missing-values.h: New file.
1395 * mis-val.c: Rewrite. New version implements updated semantics.
1397 * pfm-read.c: (read_variables) Rewrite missing value handling.
1399 * pfm-write.c: (write_variables) Rewrite missing value handling.
1401 * sfm-read.c: (read_variables) Rewrite missing value handling.
1403 * sfm-write.c: (write_variable) Rewrite missing value handling.
1405 * sfmP.h: Include "magic.h" to get definition of
1406 second_lowest_value.
1408 * sysfile-info.c: (describe_variable) Rewrite missing value
1411 * val.h: Include "magic.h" to get definition of
1412 second_lowest_value.
1414 * var.h: Include "missing-values.h". Drop MISSING_* enums.
1415 (struct variable) Remove `miss_type', `missing'. Add `miss'.
1417 * vars-atr.c: (is_num_user_missing) Removed--use
1418 mv_is_num_user_missing().
1419 (is_str_user_missing) Removed--use mv_is_str_user_missing().
1420 (is_system_missing) Removed--use mv_is_value_system_missing().
1421 (is_missing) Removed--use mv_is_value_missing().
1422 (is_user_missing) Removed--use mv_is_value_user_missing().
1424 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
1426 Adopt use of gnulib for portability.
1428 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
1431 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
1432 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
1435 * In many source files, added an explicit inclusion of gettext.h
1436 and definition of _ macro. These are no longer in pref.h because
1437 it interfered with definitions in a few gnulib source files.
1439 * In many source files, changed #include "bool.h" to #include
1440 <stdbool.h>, which is provided by gnulib.
1442 * alloc.c: Removed functions defined in gnulib:
1447 (out_of_memory) Redefined as wrapper for xalloc_die().
1449 * alloc.h: Replace prototypes by #include "xalloc.h".
1451 * casefile.c: Use full_read() and full_write() from gnulib instead
1452 of our home-grown versions.
1453 (full_read) Removed.
1454 (full_write) Removed.
1456 * getline.c: Renamed getl.c.
1458 * getline.h: Renamed getl.h, updated all references.
1460 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
1463 * glob.c: Just #include <time.h> instead of the crazy rigmarole
1465 (init_glob) Call set_program_name() to initial gnulib progname
1468 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
1470 * permissions.c: Use "stat-macros.h" from gnulib.
1472 * postscript.c: Just #include <time.h> instead of the crazy
1473 rigmarole here before.
1475 * q2c.c: (main) Make generated code #include "gettext.h".
1477 * str.h: Get rid of most explicit declarations of standard
1478 functions, in favor of including gnulib header files.
1480 * expressions/evaluate.c: Ditto.
1482 * expressions/operations.h.pl: Make generated code #include
1483 <stdbool.h>, not "bool.h".
1485 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
1487 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
1490 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
1492 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
1493 null pointer to printf for %.*s.
1495 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
1497 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
1500 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
1502 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
1504 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
1506 * postscript.c: (postopen) Cast `char' to `unsigned char' before
1507 passing to isspace().
1509 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
1511 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
1513 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
1515 * histogram.c: Include <config.h>.
1517 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
1519 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
1521 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
1523 * format.c: (check_common_specifier) Fix msg() bug found by
1525 (check_output_specifier) Ditto.
1527 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
1529 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
1532 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
1534 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
1535 avoid "unused variable" warning.
1537 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
1539 * command.c: (find_word) Cast `char' to `unsigned char' before
1540 passing to isspace().
1542 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
1544 * case.c: (case_compare) Implement as delegating to
1545 case_compare_2dict().
1547 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
1549 * algorithm.c: Inclusion of <alloca.h> is unneeded.
1551 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
1553 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
1554 -ansi changes the behavior of header files significantly. It
1555 causes __STRICT_ANSI__ to be defined, and some headers interpret
1556 that as cause to e.g. not use `long long' or __attribute__. The
1557 former example is bad when off_t is supposed to be `long long',
1558 and the latter prevents -Wformat from working.
1560 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
1562 Get rid of dependency on libgmp by writing our own routine for
1563 floating-point base conversion.
1565 * pfm-write.c: (write_float) Rewrote.
1566 (write_int) Rewrote.
1567 (pow30_nonnegative) New function.
1568 (pow30) New function.
1569 (trig_to_char) New function.
1570 (format_trig_digits) New function.
1571 (recurse_format_trig_int) New function.
1572 (format_trig_int) New function.
1573 (should_round_up) New function.
1574 (try_round_up) New function.
1575 (format_trig_double) New function.
1577 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
1579 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
1582 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
1584 * pfm-read.c: (read_version_data) Read and ignore author field.
1586 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
1588 * get.c: (mtf_processing) Don't assume that
1589 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
1590 returns a negative, zero, or positive result. Fixes MATCH FILES
1591 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
1593 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
1595 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
1596 preprocessor test for sys/types.h was accidentally inverted. This
1599 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
1601 * get.c: (cmd_match_files) Fix memory leak on `by' and on
1604 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
1607 * vfm.c: (close_active_file) Remove unnecessary test.
1609 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
1611 Fix NDEBUG compile errors.
1613 * hash.h: Needed explicit #include <assert.h>.
1615 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
1618 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
1620 Implement embedding for PostScript driver. Fixes bug 12970.
1622 * ascii.c: Fix compiler warnings.
1626 * chart.h: Add `file' member.
1628 * output.h: (struct outp_class) initialise_chart, finalise_chart
1629 should take outp_driver *, not outp_class *. Update all
1632 * plot-chart.c: (chart_create) Fix segfault when there are no
1633 output drivers at all.
1634 (chart_submit) Call d->class->finalise_chart.
1636 * postscript.c: (ps_open_page) Set cp_y to 0.
1637 (ps_submit) New function.
1638 (ps_chart_initialise) Implement.
1639 (ps_chart_finalise) Implement.
1640 (static var postscript_class) Add ps_submit.
1641 (static var epsf_class) Add ps_submit.
1644 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
1646 Did some more work on bug 12859 and then realized that a *good*
1647 solution would require some fundamental restructuring. For now,
1648 I'm marking REPEATING DATA unimplemented, and then we can revisit
1651 * command.def: Make REPEATING DATA unimplemented.
1653 * data-list.c: (cmd_repeating_data) Assume inline file is 80
1655 (realize_value) Revert previous changes; no longer needed.
1656 Updated all callers.
1658 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
1659 file_loc, to avoid bad references later.
1663 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
1665 Make some code tolerant of reentry. Should not be needed if other
1666 code is correct but it is good to be generally tolerant.
1668 * error.c: (err_hcf) Set file_loc to null after free().
1670 * output.c: (outp_done) Similar changes.
1672 * str.c: (ds_destroy) Ditto.
1674 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
1676 Continue work on bug 12859, plus some code cleanup.
1678 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
1679 boolean variables. Don't try to compute starts_end, cont_end for
1680 inline file. Calculate length only after parsing variable
1681 specifications. Add proper transformation to list.
1682 (realize_value) If the rpd_num_or_var has no value, return new
1683 DEFAULT_MEMBER argument (for use with inline file).
1684 (repeating_data_trns_proc) Pass default values.
1686 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
1687 open, and only if we actually started reading data.
1689 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
1693 * output.c: (outp_read_devices) Fix message.
1695 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1697 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
1698 of the sort algorithm from the parser for the SORT command.
1700 * rank.q: Added the parser for the RANK command.
1702 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
1706 * sort.c: (sort_parse_criteria) Only set *saw_direction if
1707 saw_direction is non-null. Thanks to John Darrington for
1710 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
1712 * get.c: (mtf_processing) Handle case of a lookup table as the
1713 active file. Thanks to John Darrington for reporting this bug.
1715 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1717 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
1718 POSIX calloc function.
1720 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
1721 reflect new signature.
1723 * sfm-read.c: Now much more robust in the face of badly formed
1726 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
1728 *sfm-read.c: Fixed some bugs regarding long string continuation
1729 records, which the previous fix uncovered.
1731 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
1733 * sfm-read.c, sfmP.h: Allow reading of system files when the
1734 case_size value in the header is -1. Also changed some Errors to
1735 Warnings when reading system files.
1737 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
1739 * data-list.c: (data_list_trns_free) Don't free the argument
1740 because cancel_transformations() will do that itself.
1741 (data_list_source_destroy) Destroy the argument to
1742 data_list_trns_free(), because it no longer does so itself.
1744 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
1746 * data-out.c: (format_and_round) Don't output leading `-' if value
1749 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
1753 * som.c: (output_encodings) If some cell in the table won't fit
1754 with the horizontal or vertical headers, cancel those headers.
1756 * som.h: (struct som_table_class) Add fits_width, fits_length,
1757 set_headers members.
1759 * tab.c: (tabi_fits_width) New function.
1760 (tabi_fits_length) New function.
1761 (tabi_set_headers) New function.
1762 (global var tab_table_class) Add the new functions as appropriate
1765 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
1767 Fix rest of bug 13054.
1769 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
1770 DATETIME, TIME system/portable file values.
1772 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
1774 * data-list.c: (parse_free) Use make_input_format().
1776 * data-out.c: (num_to_string) Use make_output_format().
1778 * dictionary.c: (dict_create_var) Ditto.
1780 * format.c: (global var f8_2) New var.
1781 (make_input_format) New function.
1782 (make_output_format) New function.
1784 * get.c: (cmd_match_files) Use make_output_format().
1786 * list.q: (cmd_list) Ditto.
1788 * matrix-data.c: Ditto.
1790 * sfm-read.c: (parse_format_spec) Check output specifier
1793 * tab.c: (tab_float) Use make_output_format().
1795 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
1797 Fix more of bug 13054.
1799 * format.def: FMT_A should allow 255-character output. FMT_AHEX
1800 should allow 510-character input and output.
1802 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
1803 (convert_E) Handle non-finite values.
1805 (format_and_round) New function.
1806 (convert_infinite) New function used by try_F() and convert_E().
1808 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
1810 Regularize string and buffer function names so that they make some
1813 * str.c: (mm_reverse) Rename buf_reverse(). Update all
1815 (mm_find_reverse) Rename buf_find_reverse(). Update all
1817 (mm_case_compare) Rename buf_compare_case(). Update all
1819 (st_compare_pad) Rename buf_compare_rpad(). Update all
1821 (str_compare_rpad) New function.
1822 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
1824 (buf_copy_str_lpad) New function.
1825 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
1827 (st_pad_copy) Rename str_copy_rpad(). Update all references.
1828 (st_trim_copy) Rename str_copy_trunc(). Update all references.
1829 (st_uppercase) Renamed str_uppercase(). Update all references.
1831 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1833 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
1836 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
1838 * data-in.c: (data_in) Add assertion to check input specifier.
1840 * data-out.c: (data_out) Add assertion to check output specifier.
1842 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
1844 Start to fix bug 13054.
1846 * format.c: (check_input_specifier) Improve error message.
1847 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
1848 valid decimal places.
1849 (check_output_specifier) Ditto (but different criteria).
1850 (convert_fmt_ItoO) Assert valid input and output specifiers.
1851 Also, if input specifier has *any* decimal places, make the output
1852 specifier 1 place wider.
1854 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
1856 * sysfile-info.c: Fixed bug [# 13024 ]
1858 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
1860 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
1861 actually implement it.
1863 * command.c: (FILE_TYPE_okay) Always return 1.
1865 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
1867 * file-type.c: Add prototypes to get rid of warnings.
1869 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
1871 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
1872 more ISO/IEC 9899:1990 conformance issues.
1874 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
1876 Fix bug 12948. See also new test in
1877 tests/bugs/match-file-scratch.sh.
1879 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
1880 that deletes scratch variables that someone else might be using,
1881 and because we can't reassign our sources' value indexes.
1882 Instead, simply don't copy scratch variables into the master
1885 * dictionary.c: (dict_compact_values) Delete variables from the
1886 dictionary passed in, not from default_dict (!).
1888 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
1890 Improve hash.c comments, error-checking.
1892 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
1893 (hsh_create) size == 0 should *not* return NULL! Set
1895 (hsh_clear) Set hash_ordered.
1896 (locate_matching_entry) Check hash_ordered.
1897 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
1898 (hsh_data) Set hash_ordered. Add const-ness to return value and
1902 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1904 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
1906 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1908 * copyleft.c: Updated copyright date.
1910 * Makefile.am: Removed erroneous explicit "-lplot"
1912 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
1914 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
1916 * command.c command.def: Added description string for unimplemented commands.
1918 * oneway.q: Sorted the hash tables before shipping out the results. Closes
1921 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
1925 * data-list.c: (parse_fixed) Use lex_end_of_command().
1927 (cmd_repeating_data) Set cont_end.num in right situations.
1928 (parse_repeating_data) Remove redundant test.
1930 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
1932 Partial fix for bug 12859.
1934 * data-list.c: (cmd_data_list) Add transformation properly in
1935 vfm_source == NULL case.
1937 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
1939 * lexer.c: (lex_error) Improve error messages.
1941 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
1943 * get.c: (cmd_match_files) Check token type before trying to match
1944 tokid. Fixes bug 12923.
1946 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
1948 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
1951 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
1953 * expressions/generate.pl: (get_token) Make use of /g
1954 backward-compatible with Perl 5.6.1.
1956 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
1958 * var-display.c: (cmd_variable_alignment) Fix memory leak.
1959 (cmd_variable_level) Ditto.
1961 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
1963 Hash table had buggy deletion function. The fix required changing
1964 other functions to do probing in the required order.
1966 * hash.c: (locate_matching_entry) Rewrite and change interface.
1967 (hsh_rehash) Rewrite to use locate_matching_entry().
1970 (hsh_delete) Ditto. Also, fix stupid bugs.
1972 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
1974 * dictionary.c: (dict_clone) Properly copy vectors.
1976 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
1978 New implementation of long variable names. Each variable has a
1979 "normal" name, which may be up to 64 bytes long and which is used
1980 for all normal operations. Variables may have a "short" name,
1981 which is limited to 8 bytes and used only for system and portable
1982 file input and output.
1984 Make tokid case-preserving. Update most uses of tokid to treat it
1987 Update many commands to deal with long variable names.
1989 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
1991 * command.c: (cmd_parse) Ditto.
1992 (match_strings) Use toupper() before comparing characters.
1993 (conflicting_3char_prefixes) Use mm_case_compare() instead of
1995 (cmd_match_words) Ditto.
1997 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
2000 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
2001 Use st_trim_copy() instead of strcpy().
2003 * data-in.c: (parse_enum) Use mm_case_compare() instead of
2006 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
2008 (parse_free) Use st_trim_copy() instead of strcpy().
2010 * descript.c: (struct dsc_var) Change z_name[] to fit long var
2012 (try_name) Use strcasecmp() instead of strcmp().
2013 (generate_z_varname) Use st_trim_copy() instead of strcpy().
2014 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
2017 * dictionary.c: (struct dictionary) Removed `long_name_tab'
2019 (compare_long_names) Removed.
2020 (hash_long_name) Removed.
2021 (dict_create) Don't initialize `long_name_tab' member.
2022 (dict_clone) Copy short names into new dictionary.
2023 (dict_clear) Don't clear `long_name_tab' member.
2024 (dict_get_varname_block) Removed.
2025 (dict_add_longvar_entry) Removed.
2027 (dict_destroy) Don't destroy `long_name_tab' member.
2028 (dict_create_var_from_short) Removed.
2029 (dict_create_var_x) Removed.
2030 (dict_create_var) Get rid of longname handling.
2032 (dict_clone_var) Get rid of longname parameter and longname
2034 (dict_lookup_var) Get rid of longname handling.
2035 (dict_reorder_var) New function.
2036 (dict_rename_var) Clear short name.
2037 (dict_rename_vars) Get rid of longname handling. Clear short
2039 (dict_create_vector) Support long vector names.
2040 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
2041 (quasi_base27) Removed.
2042 (make_short_name) Removed.
2043 (compare_strings) New function.
2044 (hash_string) New function.
2045 (dict_assign_short_names) New function.
2047 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
2049 (get_handle_for_filename) Support long handle names.
2051 * file-type.c: (struct col_spec) Make `name' fit long var names.
2052 (cmd_file_type) Use strcasecmp() instead of strcmp().
2054 * flip.c: (make_new_var) Rewrite.
2055 (flip_sink_write) Use st_trim_copy() instead of strncpy().
2057 * format.c: (parse_format_specifier_name) Use mm_case_compare()
2058 instead of memcmp().
2060 * get.c: (cmd_save_internal) Rephrase.
2061 (rename_variables) Drop test for identical variable name.
2062 (struct mtf_proc) Change `first', `last' to fit long var name.
2064 * hash.c: (hsh_hash_case_string) New function for case-insensitive
2067 * lexer.c: (restore_token) Use st_trim_copy() instead of
2069 (lex_get) Don't uppercase string when copying into tokid.
2070 (lex_put_back_id) Use st_trim_copy() instead of
2073 * list.q: (determine_layout) Consider length of variable names in
2074 choosing vertical layout.
2076 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
2078 (string_to_content_type) Ditto.
2080 * modify-vars.c: (compare_variables_given_ordering) Ditto.
2081 (struct var_renaming) Change `new_name' to fit long var name.
2082 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
2085 * pfm-read.c: (read_variables) Disallow system variables in system
2087 (write_variables) Call dict_assign_short_names() and use
2088 short_name[] members.
2090 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
2093 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
2094 map. Reorder variables into same order as long variable map.
2095 (read_variables) Set short name.
2097 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
2098 (write_variable) Use st_bare_pad_copy().
2099 (write_longvar_table) Rewrite.
2101 * str.c: (mm_case_compare) New function.
2103 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
2104 instead of strcmp().
2106 * t-test.q: (tts_custom_groups) Remove redundant test.
2107 (tts_custom_pairs) Ditto.
2109 * var.h: (struct variable) Change `name' to fit long var names.
2110 Remove `longname'. Add `short_name' member. Reorder some
2112 (struct name_table_entry) Removed.
2113 (struct vector) Change `name' to fit long vector names.
2115 * vars-atr.c: (var_is_valid_name) Allow long var names.
2116 (compare_var_names) Use strcasecmp() instead of strcmp().
2117 (compare_var_ptr_names) Ditto.
2118 (hash_var_name) Use hsh_hash_case_string().
2119 (hash_var_ptr_name) Ditto.
2120 (var_set_short_name) New function.
2121 (var_clear_short_name) New function.
2122 (var_set_short_name_suffix) New function.
2124 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
2125 Use strcasecmp() instead of strcmp().
2126 (struct array_var_set) Removed `longname_tab'.
2127 (array_var_set_lookup_var_idx) Drop longname_tab support.
2128 (array_var_set_destroy) Don't destroy `longname_tab'.
2129 (var_set_create_from_array) Don't create `longname_tab'.
2131 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
2134 * expressions/parse.c: (word_matches) Use mm_case_compare()
2135 instead of memcmp().
2136 (compare_strings) New function.
2137 (lookup_function) Use compare_strings() instead of strcmp().
2139 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
2141 * algorithm.c: (move_element) New function.
2143 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
2145 * aggregate.c: (parse_aggregate_functions) Always initialize
2148 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
2150 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
2152 * dictionary.c: (dict_clone) Ditto.
2153 (dict_clone_var_assert) New function.
2155 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
2157 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
2159 * error.c: Added a string for the compiler version to the
2160 request_bug_report_and_abort function.
2162 * groff_font.c, font.c: Removed manpage(1) style references from
2163 comments, because RMS frowns upon them.
2165 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
2167 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
2169 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
2171 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
2172 Fixed bug [#12858] .
2174 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
2176 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
2177 which should be LONG_NAME_LEN
2179 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
2181 * command.def echo.c: Added the ECHO command.
2183 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
2185 Finish fixing MATCH FILES (bug 11677).
2187 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
2188 keep_variables(), rename_variables().
2189 (drop_variables) New function.
2190 (keep_variables) New function.
2191 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
2192 (cmd_match_files) Deal with in_var. Use drop_variables(),
2193 keep_variables(). When IN is specified, require BY. Set master
2194 variables after master dictionary is complete. Add IN variables
2195 after master dictionary is complete.
2196 (mtf_free_file) Free `in_name'.
2197 (mtf_delete_file_in_place) Set in_var value to 0.
2198 (mtf_read_nonactive_records) Rephrase.
2199 (mtf_processing) Support IN. Rephrase. Fix bugs.
2200 (mtf_merge_dictionary) Don't set master variables; we do that
2202 (get_master) Don't insist that there's a master variable.
2204 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
2206 Kluge to make some variable renaming sort of work.
2209 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
2211 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
2213 Add functions for comparing sets of variables between cases.
2216 * case.c: (case_compare) New function.
2217 (case_compare_2dict) New function.
2219 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
2221 (cmd_aggregate) Nullify break_case. Don't call
2222 initialize_aggregate_info().
2223 (agr_destroy) Destroy break_case.
2224 (aggregate_single_case) Rewrite. Use case_compare().
2225 (dump_aggregate_info) Copy from break_case into output.
2226 (initialize_aggregate_info) Copy break_case from input.
2228 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
2230 * vfm.c: (equal_splits) Use case_compare().
2232 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
2234 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
2236 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
2238 Start work on fixing MATCH FILES.
2240 * get.c: (enum operation) Remove OP_MATCH.
2241 (trim_dictionary) Change return value to bool. Don't support
2243 (struct mtf_file) Remove `first', `last' members.
2244 (struct mtf_proc) Add `first', `last' members. Change mtf_case
2245 from `struct ccase *' to `struct ccase'. Remove `by' member.
2246 (cmd_match_files) Essentially rewrite.
2247 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
2248 (mtf_read_nonactive_records) mtf_ parameter is not unused.
2249 (mtf_processing) Ditto. Also rephrase some code.
2250 (mtf_merge_dictionary) Rewrite for easy comprehension.
2252 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
2254 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
2257 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
2259 Thu Apr 14 2005 John Darrington
2261 * var-display.c: New file.
2263 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
2264 display_width, measure and alignment parameters to variables.
2266 * aggregate.c command.def compute.c count.c data-list.c descript.c
2267 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
2268 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
2269 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
2270 vars-prs.c vector.c :
2271 - Replaced literal constants representing maximum variable name
2272 length with macro definitions.
2273 - Added support for long variable names.
2274 - Changed lexer such that it no longer makes tokens upper
2275 case, but relies upon case insensitive behaviour of commands.
2277 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
2279 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
2280 fails, don't dereference the resulting null pointer (bug 12427).
2281 Also, fix double free error.
2283 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
2285 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
2286 (accumulate_aggregate_info) Set int1 to 1 for SUM.
2287 (dump_aggregate_info) Only make SUM non-missing if there was at
2290 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
2292 * aggregate.c: (dump_aggregate_info) Properly test whether the
2293 destination variable is numeric, when making the result
2294 system-missing for columnwise missing values.
2296 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
2298 * misc.h: Remove GCC specializations.
2300 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
2302 Make sort stable (bug 12313).
2304 * sort.c: Don't need to include some headers anymore.
2305 (static var min_buffers) New variable.
2306 (static var max_buffers) New variable.
2307 (static var allow_internal_sort) New variable.
2308 (cmd_sort_cases) Add test mode.
2309 (sort_execute) Rephrase.
2310 (do_internal_sort) Don't try internal sorting if
2311 allow_internal_sort is set.
2312 (struct external_sort) Renamed `initial_runs' to `runs' and
2313 updated all references.
2314 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
2315 (macro MIN_BUFFER_SIZE_BYTES) Removed.
2316 (macro MIN_BUFFER_SIZE_RECS) Removed.
2317 (compare_initial_runs) Removed.
2318 (struct record_run) Add member `idx'.
2319 (write_initial_runs) Pass increasing values to process_case() as
2321 (process_case) Add `idx' parameter and use it to initialize new
2323 (allocate_cases) Limit allocated buffers to max_buffers.
2324 (compare_record_run) Use new `idx' member for last resort
2325 comparison, for stability.
2326 (end_run) Call casefile_sleep() on irs->casefile, to prevent
2327 running out of file descriptors.
2328 (struct merge_state) Removed.
2329 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
2330 unless we have fewer runs left. Always merge consecutive runs,
2331 for stability. Return the final run.
2333 (choose_merge) New function.
2334 (merge_once) Rewritten.
2336 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
2338 * cmdline.c: (static var testing_mode) Move into
2339 parse_command_line().
2341 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
2343 * algorithm.c: (remove_range) New function.
2344 (remove_element) New function.
2346 * dictionary.c: (dict_delete_var) Use remove_element().
2348 * flip.c: (cmd_flip) Ditto.
2350 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
2352 * file-handle.q: (struct file_handle) `open_mode' should not be
2355 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
2357 First phase of making SORT CASES stable (bug 12313).
2359 * sort.c: (struct indexed_case) New structure.
2360 (do_internal_sort) Rewrite to make internal sorting stable.
2361 (compare_case_dblptrs) Removed.
2362 (compare_indexed_cases) New function.
2364 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
2368 * casefile.c: (casereader_read_xfer_assert) New function.
2370 * dictionary.c: (dict_compact_case) New function.
2372 * flip.c: (struct flip_pgm) New member idx_to_fv.
2373 (cmd_flip) Initialize idx_to_fv member.
2374 (destroy_flip_pgm) Free idx_to_fv member.
2375 (flip_sink_write) Use struct flip_pgm member instead of case_sink
2377 (flip_sink_write) Ditto.
2379 * vfm.c: (write_case) Use dict_compact_case() instead of
2381 (compact_case) Removed.
2382 (storage_source_create) Removed `dict' parameter. All references
2385 * vfm.h: (struct case_source) Removed `value_cnt' member. All
2387 (struct case_sink) Removed `dict', `idx_to_fv' members. All
2390 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
2392 More AGGREGATE fixes.
2394 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
2395 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
2397 (initialize_aggregate_info) Fix initialization for MIN, MAX for
2400 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
2402 Start work on testing and debugging AGGREGATE.
2404 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
2405 of a bit-map. Require proper subcommand ordering. Make OUTFILE
2406 subcommand mandatory.
2407 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
2408 functions' arguments are in the correct order and swap them if
2410 (accumulate_aggregate_info) Make SUM include weights. Add various
2412 (dump_aggregate_info) Add various string functions.
2413 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
2415 * sort.c: (sort_parse_criteria) Add parameter for returning
2416 whether any directions were specified. All callers updated.
2418 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
2420 * t-test.q: Fixed erroneous logic in compare_group_binary.
2422 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
2424 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
2425 keywords (bug 11628).
2427 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
2429 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
2430 called *before* close_active_file().
2432 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
2434 * file-handle.q: (struct file_handle) Change open_mode from
2435 character pointer to 3-char array, for safety. Updated all
2438 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
2440 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
2443 * pfm-read.c: (read_header) Improve error message for many cases
2444 in which the input is not actually a portable file.
2446 * file-handle.q: (fh_open) When we give an error message, actually
2449 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
2451 * format.c: (check_common_specifier) New function for checks
2452 common to check_input_specifier() and check_output_specifier().
2453 (check_input_specifier) Use check_common_specifier().
2454 (check_output_specifier) Use check_common_specifier().
2455 (check_string_specifier) Removed.
2456 (check_specifier_type) New function.
2457 (check_specifier_width) New function.
2458 (get_format_var_width) Fix bug.
2460 * formats.c: (internal_cmd_formats) Only accept numeric variables.
2462 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
2463 update all references. Make case-insensitive.
2465 * pfm-read.c: Essentially rewrite the whole file. Now much
2468 * print.c: (check_string_width) New function.
2469 (fixed_parse_compatible) Use check_string_width(),
2470 check_specifier_type().
2471 (dump_fmt_list) Ditto.
2473 * str.c: (st_trim_copy) New function.
2474 (st_uppercase) New function.
2476 * vars-atr.c: (var_is_valid_name) New function.
2478 * expressions/parse.c: (type_coercion_core) Use
2479 check_specifier_type().
2481 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
2483 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
2485 * expressions/parse.c: (no_match) Ditto.
2487 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
2489 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
2491 * expressions/helpers.c: (struct func_params) Removed.
2492 (generalized_idf) Removed.
2495 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
2497 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
2498 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
2499 Implement SIG.F, which I had overlooked previously.
2501 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
2503 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
2504 available only in testing mode.
2506 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
2508 * data-in.c: Use `bool' throughout, where relevant.
2510 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
2512 DATA LIST with free-field formats should not have implied decimal
2513 places (bug 12035). Also clean up data-in.c a bit.
2515 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
2517 * data-in.c: (apply_implied_decimals) New function.
2518 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
2519 set. Also, get rid of gotos.
2520 (parse_Z) Use apply_implied_decimals() if the field doesn't
2521 contain a decimal point.
2522 (parse_N) Use apply_implied_decimals().
2528 (parse_enum) New function.
2529 (macro CHAR_IS_ROMAN) Removed.
2530 (macro ROMAN_VALUE) Removed.
2531 (parse_month) Use parse_enum().
2532 (parse_weekday) Use parse_enum().
2533 (parse_DATETIME) Use long for weekday.
2535 * data-list.c: (read_from_data_list_fixed) Use
2536 DI_IMPLIED_DECIMALS.
2538 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
2540 When the lexer sees something like `-5' in the input, it has to
2541 decide whether it's a negative numeric constant token or a '-'
2542 token followed by a positive numeric constant token. It always
2543 decides on the former, and then the parser can call
2544 lex_negative_to_dash() if it wants the latter. However, this
2545 doesn't work for the case of `-0', because negative zero is
2546 (portably) indistinguishable from positive zero. So now we divide
2547 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
2548 distinction clear. This requires a little bit of extra effort,
2549 because there were several references to T_NUM in the code base.
2551 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
2552 positive and negative numeric constants.
2553 (lex_double_p) Renamed lex_is_number(). Changed return type to
2554 bool. Updated all relevant references to T_NUM to instead use
2556 (lex_double) Renamed lex_number(). All references updated.
2557 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
2558 bool. All references updated.
2559 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
2560 (lex_negative_to_dash) Ditto.
2563 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
2565 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
2567 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
2569 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
2571 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
2572 values as system-missing.
2574 * expressions/parse.c: (parse_vector_element) Fix order of
2575 arguments in call to expr_allocate_binary().
2577 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
2579 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
2582 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
2583 failure, as indicated by function comment.
2584 (parse_binary_operators) Always return NULL on type_coercion()
2585 failure. Should have been doing this anyway, but bug in
2586 type_coercion_core() filtered through.
2587 (parse_add) Fix typo in user message.
2588 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
2590 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
2592 * expressions/operations.def: Add VALUE function.
2594 * expressions/parse.c: (parse_function) Need an unary composite
2595 node for variables in A TO B, not a variable node. Use
2596 allocate_unary_variable().
2597 (parse_primary) Use allocate_unary_variable().
2598 (allocate_unary_variable) New function.
2600 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
2602 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
2603 but fixed the real problem that was preventing the build from a
2604 separate directory. I liked it my way better ;-)
2606 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
2608 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
2609 John Darrington <john@darrington.wattle.id.au> for reporting this
2612 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
2614 * expressions/Makefile.am expressions/evaluate.h.pl
2615 expressions/evaluate.inc.pl expressions/operations.h.pl
2616 expressions/optimize.inc.pl expressions/parse.inc.p:
2618 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
2621 Fixed everything so that it can be built from an arbitrary
2624 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
2626 * Makefile.am : Fixed up CLEANFILES target.
2628 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
2630 * str.h: Changed `struct len_string' to `struct fixed_string', a
2631 more accurate name. Updated all references.
2633 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
2635 Redo calendar support. Should now be bug-for-bug compatible.
2637 * calendar.c: New file.
2639 * calendar.h: New file.
2641 * data-in.c: Use new calendar functions.
2642 (parse_sign) Change sense of return value.
2643 (calendar_error) New function.
2644 (ymd_to_ofs) New function.
2645 (ymd_to_date) New function.
2646 (parse_DATE) Use new function.
2647 (parse_ADATE) Ditto.
2648 (parse_EDATE) Ditto.
2649 (parse_SDATE) Ditto.
2650 (parse_JDATE) Ditto.
2655 (parse_DTIME) Ditto.
2656 (parse_DATETIME) Ditto.
2658 * data-out.c: (convert_date) Use new calendar functions.
2660 * error.c: (err_vmsg) Changed interface to be more sensible.
2661 Updated all callers.
2662 (dump_message) Don't double new-lines (why did we do this
2665 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
2667 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
2668 (macro FLT64_MAX) Moved here from pref.h.orig.
2670 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
2672 * set.q: Support SET EPOCH.
2673 (static var set_epoch) New var.
2674 (aux_stc_custom_epoch) New function.
2675 (stc_custom_epoch) New function.
2676 (get_epoch) New function.
2677 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
2679 * format.c: Make it possible just to check whether a specifier is
2680 valid without emitting an error message.
2681 (parse_format_specifier_name) Change interface, update all
2683 (check_input_specifier) Ditto.
2684 (check_output_specifier) Ditto.
2685 (parse_format_specifier) Ditto.
2687 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
2689 * command.def: Add DEBUG POOL.
2691 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
2693 (pool_clear) Properly account for size of pool gizmo.
2694 (pool_realloc) Ditto.
2695 (pool_clone) New function.
2697 * pool.h: Mark our allocation functions MALLOC_LIKE.
2699 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
2701 * Makefile.am: Move many definitions into new top-level
2702 Make.build. Add expressions to SUBDIRS. Add calendar.c,
2703 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
2706 * case.c: (case_resize) New function.
2707 (case_swap) New function.
2709 * casefile.c: Include mkfile.h.
2711 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
2713 * sfm-read.c: Fixed a buglet which caused a crash when trying
2714 to read a non-existent file.
2716 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
2720 * aggregate.c: (parse_aggregate_functions) Code cleanup.
2721 Important part: get rid of spurious copying of function->format to
2722 destvar->print and destvar->write.
2724 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
2726 Fix bug 11916, which was confusing a variable's `index' member
2727 with the variable's position in a var_set. Although these are
2728 usually the same, they are not for array `var_set's.
2730 Took advantage of this bug as an opportunity to clean up and
2731 rewrite parse_var_set_vars().
2733 * vars-prs.c: (parse_vs_variable_idx) New function.
2734 (parse_vs_variable) Reimplement in terms of
2735 parse_vs_variable_idx().
2736 (parse_var_idx_class) New function.
2737 (add_variable) New function.
2738 (add_variables) New function.
2739 (parse_var_set_vars) Rewritten.
2740 (struct var_set) Change `lookup_var' member that returns a
2741 variable into `lookup_var_idx' member that returns an int.
2742 Updated the var set implementations in obvious corresponding ways.
2743 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
2745 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
2747 Use our global variable compare & hash functions and give them
2748 better names. Add similar functions for dealing with double
2749 pointers to variables.
2751 * vars-atr.c: (compare_variables) Renamed compare_var_names().
2752 (hash_variable) Renamed hash_var_name().
2753 (compare_var_ptr_names) New function.
2754 (hash_var_ptr_name) New function.
2756 * t-test.q: (cmd_t_test) Use global compare_var_names(),
2758 (compare_var_name) Removed.
2759 (hash_var_name) Removed.
2761 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
2765 * dictionary.c: (compare_variable_dblptrs) Rename
2766 compare_var_ptrs() and fix it to properly dereference the double
2769 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
2771 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
2772 declare subcommands as mandatory. Closed bug #11843
2774 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
2776 * getline.c command.[ch] command.def: Added (very rudimentary)
2777 support for line completion when in interactive mode. Partially
2778 addresses bug #11693
2780 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
2782 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
2783 problems revealed by valgrind.
2786 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
2788 * set.q: Affixed a fix to the previous fix such that we'll be OK now
2789 whether or not PAGER is set.
2791 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
2793 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
2794 "invalid free" errors. Hopefully fixes bug #11722
2796 * compute.c expr-prs.c: Check that lvalues are populated before
2797 attempting to destroy them. Closes bug #11676
2799 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
2801 * aggregate.c: Initialised the complete agr_proc structure.
2805 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
2807 * print.c: (print_trns_free) Close the dfm writer if there is one,
2808 fixing a memory leak.
2810 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
2812 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
2816 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
2818 * linked-list.[ch] Added
2820 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
2821 set.q: Yet more memory leaks
2823 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
2825 * t-test.q examine.q : More memory leaks fixed.
2827 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
2829 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
2832 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
2834 * ascii.c cartesian.c casefile.c chart.h devind.c
2835 examine.q frequencies.q
2836 html.c output.h piechart.c plot-chart.c plot-hist.c
2838 Integrated the chart rendering into the output stream
2839 (currently only works for html).
2841 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
2842 dummy-chart.c for compiling without charts.
2844 * mkfile.[ch] Created.
2846 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
2847 Added type element so we can tell if it's a chart or a table.
2849 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
2850 API of charts to be more like that of tables.
2852 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
2854 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
2855 main.c. Removed the handler for SIGQUIT.
2857 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
2859 * casefile.c: Added a signal handler to delete temp files on
2862 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
2864 * command.def Added a lot more unimplemented commands.
2866 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
2868 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
2870 * sort.c: (compare_initial_runs) Needed additional level of
2872 (merge_once) Fix plenty of stupid mistakes.
2874 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
2876 * casefile.c: (casefile_sleep) Need to flush_buffer() after
2877 calling casefile_to_disk() or we will lose the last block in the
2878 file if the casefile started out as disk-based.
2879 (casefile_get_reader) Initialize reader->destructive to 0.
2880 (cmd_debug_casefile) Add new test pattern.
2881 (test_casefile) Define new test pattern to make sure
2882 casefile_sleep() works properly.
2884 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
2886 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
2887 plot-hist.c plot-chart.c (Added) Reorganised these files in an
2888 attempt to seperate the creation and processing of charts from their
2891 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
2894 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
2896 * main.c Added a signal handler for SIGFPE
2898 * sort.c Somewhat more robust fix to the previous entry.
2900 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
2902 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
2903 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
2904 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
2907 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
2909 * case.h Fixed bug # 11307
2911 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
2913 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
2916 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
2918 * pfm-read.c: (read_variables) Remove direct manipulation of
2919 v->aux, which is no longer needed. Fixes bug 11483.
2921 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
2923 * data-list.c Fixed a bug in parsing delimiters.
2925 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
2928 * percentiles.c Properly handled calculation of Tukey hinges where
2929 the number of data is small.
2931 * oneway.q Used the generic value_to_string function for independent
2932 variable instead of trying to do it ourselves.
2934 * box-whisker.c Fixed a buglet which caused a crash if the number of
2938 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2940 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
2942 * percentiles.c Fixed some bugs when calculating percentiles when
2943 there's a small number of cases.
2945 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
2947 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
2949 * examine.q factor_stats.[ch] Added calculation of percentiles
2951 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2953 * t-test.q Fixed bug #11227 Made t-test work when the independent
2956 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2958 * factor_stats.c Fixed calculation of trimmed mean under various
2961 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2963 * histogram.c chart.[ch] factor_stats.c frequencies.q
2965 Added code to calculate sensible histogram ranges and limits.
2967 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
2969 * chart.h Updated to reflect many API changes.
2971 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
2972 cartesian.c and into chart.c
2974 * factorstats.[ch] Added the histogram calculations
2976 * casefile.c Removed an unused variable.
2978 * frequencies.q examine.q histogram.c Reworked the API for
2981 * piechart.c Revised the API for piecharts.
2983 * var.h Moved the definitions of freq_tab and freq out of var.h
2984 and into frequencies.q where they belong.
2986 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
2988 * flip.c: (flip_file) Check for off_t separately from fseeko(),
2989 using AC_TYPE_OFF_T.
2991 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
2993 * flip.c: (flip_file) If fseeko() is not available, use long int
2994 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
2995 reporting the problem.
2997 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
2999 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
3000 conflict with stdio.
3002 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
3004 * var-labs.c (var_to_string) Now returns null if the variable is null
3006 * value-labels.c (value_to_string) Made it return null if either the
3007 value or the variable is null.
3009 * hash.c (hsh_clear) Fixed a buglet.
3011 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
3012 with the wrong model.
3014 * casefile.[ch] Added a function to return the casereader.case_idx
3017 * examine.q Implemented the extreme values results.
3019 John Darrington <john@darrington.wattle.id.au>
3021 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
3022 output.[ch] getline.c
3024 Plugged some memory leaks
3026 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
3028 Adopt GSL random number generators, paving the way for providing
3029 the complete suite of random number generators on expressions.
3031 * Makefile.am: Remove random.c, random.h.
3033 * random.c: Removed.
3035 * random.h: Removed.
3037 * algorithm.c: (algo_default_random) Use GSL functions.
3039 * casefile.c: (test_casefile) Use GSL RNG functions.
3041 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
3044 * sample.c: (cmd_sample) Use GSL RNG functions.
3045 (sample_trns_proc) Ditto.
3047 * set.q: (static var set_seed) Removed.
3048 (static var seed_flag) Removed.
3049 (static var rng) New variable.
3050 (aux_stc_custom_seed) No seed value anymore, don't print anything.
3051 (stc_custom_seed) Use new seed functions.
3052 (seed_is_set) Removed.
3053 (get_rng) New function that composes the entire external
3055 (set_rng) New function.
3056 (random_seed) New function.
3058 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
3060 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
3061 John Darrington <john@darrington.wattle.id.au> for reporting this
3064 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
3066 * permissions.c command.def Added the PERMISSIONS command
3068 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
3070 * q2c.c: (dump_header) Don't try to emit #includes at very top of
3071 output file because that will precede #include <config.h>, which
3073 (main) Add needed headers to /* (header) */ code.
3075 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
3077 Instead of making system or portable file readers responsible for
3078 dropping and reordering variables, make them read full cases and
3079 let the caller take care of any changes.
3081 * get.c: New "case map" structure to handle this. Use for GET,
3082 IMPORT, MATCH FILES. Essentially rewrite the whole file.
3084 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
3085 changed appropriately.
3087 * sfm-read.c: (sfm_read_case) Ditto.
3089 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
3091 Decided that case_serialize() and case_unserialize() were too
3092 abstract. Also we need a couple more functions to avoid excessive
3093 copying for data in/out fast paths.
3095 * case.c: (case_serial_size) Removed.
3096 (case_serialize) Rename case_to_values() and make its argument
3097 explicitly an array of union values.
3098 (case_unserialize) Rename case_from_values() and make its argument
3099 explicitly an array of union values.
3100 (case_data_all) New function.
3101 (case_data_all_rw) New function.
3103 * casefile.c: (struct casefile) Change buffer from array of
3104 unsigned char to array of union value for better accuracy.
3105 Redefine buffer_used and buffer_size in terms of values, not
3106 bytes. Remove case_size because it is now redundant with
3107 value_cnt. Fix up all references to these members.
3109 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
3111 * barchart.c: (struct subcat) Make `label' member const to silence
3112 GCC warning with -Wwrite-strings.
3114 * cartesian.c: (struct dataset) Ditto.
3116 * case.c: Don't re-define NDEBUG if already defined.
3117 Add lots of comments.
3119 * str.c: Fix includes.
3121 * crosstabs.q: Fix includes.
3123 * examine.q: Fix includes. Fix GCC warning about unused
3126 * frequencies.q: (stat macro) Removed and replaced where used by
3129 * list.q: Fix includes.
3131 * oneway.q: Fix includes.
3133 * piechart.c: Fix includes. Only define M_PI if not already
3136 * sfm-read.c: (bswap) New function.
3137 (bswap_int32) Write in terms of bswap.
3138 (bswap_flt64) Ditto.
3140 * str.c: (ds_data) Add external definition here, needed because
3141 str.h has only an `extern inline' version.
3143 * value-labels.c: Fix includes.
3145 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
3147 Instead of providing a system or portable file writer with a raw
3148 case in the format needed for output, provide it with a regular
3149 case. The writer takes care of any needed translation.
3151 * aggregate.c: Adopt new scheme for AGGREGATE.
3152 (struct agr_proc) sfm_agr_case member removed.
3153 (write_case_to_sfm) Removed because the new interface is easier to
3156 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
3158 * pfm-write.c: Implement new scheme.
3160 * sfm-write.c: Ditto.
3162 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
3164 Instead of treating `struct file_handle' as a class to subclass
3165 into data files, system files, and portable files, instead use it
3166 as a helper that coordinates access. Now it is opaque, too.
3168 This means that most references to a struct file_handle are now
3169 changed into references to one of struct dfm_reader, struct
3170 dfm_writer, struct sfm_reader, struct sfm_writer, struct
3171 pfm_reader, or struct pfm_writer, according to what's being read
3174 Most related changes are only worth summarizing briefly.
3176 * dictionary.c: (dict_clear) Destroy aux data in deleted
3178 (dict_clear_aux) New function.
3179 (dict_create_var) Initialize aux, aux_dtor.
3180 (dict_delete_var) Destroy aux data in deleted variable.
3182 * file-handle.h: (struct fh_ext_class) Removed.
3183 (struct file_handle) Removed.
3184 (fh_init_files) Removed.
3186 * file-handle.q: Changed references to a handle's `private' member
3187 to direct references.
3188 (struct private_file_handle) Renamed file_handle.
3189 Add next, open_cnt, type, open_mode, aux members.
3190 (struct file_handle_list) Removed.
3191 (extern var inline_file) Removed.
3192 (static var file_handles) Changed from file_handle_list * to
3194 (create_file_handle) Initialize new members.
3195 (fh_close_handle) Removed.
3196 (mode_name) New function.
3197 (fh_open) New function.
3198 (fh_close) New function.
3199 (fh_parse_file_handle) Renamed fh_parse().
3201 * glob.c: (init_glob) Remove fh_init_files() call.
3203 * aggregate.c: use sfm_writer.
3204 (create_sysfile) Removed because the new interface is simpler.
3206 * apply-dict.c: Use sfm_reader.
3208 * data-list.c: Use dfm_reader.
3210 * file-type.c: Use dfm_reader.
3212 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
3214 * inpt-pgm.c: Use dfm_reader.
3216 * print.c: Use dfm_writer.
3218 * sysfile-info: Use sfm_reader.
3220 * dfm-read.c: Adopt new file handle infrastructure.
3222 * dfm-write.c: Ditto.
3224 * pfm-read.c: Ditto.
3226 * pfm-write.c: Ditto.
3228 * sfm-read.c: Ditto.
3230 * sfm-write.c: Ditto.
3232 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
3234 Break dictionary functions into separate header file.
3236 * dictionary.h: New file.
3238 * var.h: Moved dict_*() functions to dictionary.h.
3240 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
3242 Get rid of procedure-specific union in struct variable, using
3243 instead a void * pointer and a destructor function.
3245 Most related changes are only worth brief summaries.
3247 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
3248 old p.crs member in struct variable.
3250 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
3251 of old p.frq member in struct variable.
3253 * histogram.c: (draw_histogram) Takes new freq_tab arg because
3254 it's no longer possible to grab this from var->p.frq.
3256 * piechart.c: (draw_piechart) Ditto.
3258 * group.c: (group_proc_get) New function.
3260 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
3267 * main.c: (execute_command) Clear aux data in default_dict after
3268 each command. (It's debatable whether this should be done.)
3270 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
3271 member in struct variable.
3273 * means.q: Get rid of integer mode, which is not included in
3274 recent SPSS and was the only code that wanted per-variable private
3277 * var.h: (struct crosstab_proc) Removed.
3278 (struct frequencies_proc) Removed.
3279 (struct list_proc) Removed.
3280 (struct get_proc) Removed.
3281 (struct means_proc) Removed.
3282 (struct matrix_data_proc) Removed.
3283 (struct match_files_proc) Removed.
3284 (lots of enums) Removed.
3285 (struct variable) Removed members `p', `get'. Add member
3288 * vars-atr.c: (var_attach_aux) New function.
3289 (var_detach_aux) New function.
3290 (var_clear_aux) New function.
3291 (var_dtor_free) New function.
3292 (discard_variables) Use NULL instead of inline_file.
3294 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3296 * value-labs.c Fixed the implmentation of value_to_string, so
3297 that it properly handles alpha values.
3299 * oneway.q Changed instances where labels were being probed manually,
3300 to use the canonical {var,value}_to_string functions
3302 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
3304 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
3305 plots. Changed the API of the cartesian plot to be a much lower level
3308 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
3310 * examine.q Added some of the parametric calculations
3312 * factor_stats.[ch] Created
3314 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
3316 * examine.q Changed the definition of factors to be a composite, and
3317 dealt with the consequences.
3319 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
3321 * examine.q Fixed problem where examine wasn't dealing properly with
3324 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
3326 * oneway.q Fixed problem where oneway wasn't dealing properly with
3329 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
3331 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
3332 command which had settings didn't get the appropriate code
3335 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
3336 to convert variables/values to strings.
3338 * examine.q Added framework for the EXAMINE command.
3340 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
3342 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
3343 subcommand types. Changed frequencies.q to use it rather then the
3344 custom parser. Dealt with the consequences. Added a test for NTILES
3345 subcommand of frequencies.
3347 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
3349 * oneway.q Fixed up the behaviour when given missing values
3351 * levene.c oneway.q Fixed a buglet with the levene statistic and
3352 incorporated the levene test into the oneway command.
3354 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
3355 global scope, since they're only relevant to T-TEST
3357 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
3359 * group.c group.h group_proc.h levene.c oneway.q t-test.q
3361 Made the t-test more consistent
3362 with the way it handles groups. That is, it now uses a hash instead
3363 of an array of 2. Also, made the levene.c file independent of the
3364 implementation of the t-test. So now levene should be fine for both
3367 * Added an oneway.q file for one way anova
3369 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
3371 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
3374 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
3378 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
3379 (data_list_trns_free) Free dls->delims.
3381 * t-test.q: (tts_custom_pairs) Free vars.
3382 (ssbox_one_sample_init) Fix tab_vline() argument.
3383 (ssbox_independent_samples_init) Ditto.
3384 (trbox_paired_init) Ditto.
3385 (trbox_one_sample_init) Ditto.
3387 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
3389 Generalize casefiles to the extent that we can use them for
3390 sorting and other kinds of data transformations. Change cases to
3391 be copy-on-write to improve memory efficiency in common cases.
3392 Every access to a member of a `struct ccase' was changed to be a
3393 call to a case_*() function, especially case_data(), case_num(),
3394 case_str(), or case_data_rw(). Many instances of a local variable
3395 named "case_num" were changed to "case_idx" as a consequence.
3396 Many `struct ccase *' were changed to actual `struct ccase'
3397 because of copying semantics of cases. In several places there
3398 was a choice between updating debug code to work with the new ADTs
3399 or just deleting it because it was useless; I chose to delete it.
3401 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
3407 * aggregate.c: (struct agr_proc) Change type of `sort' to
3408 sort_criteria *. Add `break_vars', `break_var_cnt' members.
3409 Rename `vars' to `agr_vars', all references updated. Change
3410 `agr_case' to type `struct ccase'.
3411 (cmd_aggregate) Deal with new members. Use case_create(),
3412 sort_active_file_in_place(), sort_active_file_to_casefile().
3413 (agr_destroy) Deal with new members.
3414 (aggregate_single_case) Ditto.
3415 (dump_aggregate_info) Ditto.
3416 (initialize_aggregate_info) Ditto.
3417 (agr_to_active_file) Ditto.
3418 (presorted_agr_to_sysfile) Ditto.
3419 (sort_agr_to_sysfile) Removed.
3421 * alloc.c: (out_of_memory) Make non-static.
3423 * alloc.h: Prototype out_of_memory().
3425 * casefile.c: Switched from a linked list in-memory representation
3426 to a two-level array-style representation. The linked list was
3427 appropriate when we could stick a header onto cases, but that's no
3428 longer the case. Also, the two-level array will allow for random
3429 in-memory access in case that's ever wanted. Also added the
3430 concept of a `destructive casereader', one that destroys cases in
3431 the underlying casefile as they are read out.
3432 (macro CASES_PER_BLOCK) New macro.
3433 (struct casefile) New members `value_cnt', `case_list_size',
3434 `case_acct_size', `being_destroyed', `cases'. Removed `head',
3436 (struct casereader) Removed `cur'. Added `destructive', `c'.
3437 (global var casefiles) Made static.
3438 (static var case_bytes) New var.
3439 (casefile_create) Takes a value count, not a case size in bytes,
3440 to conform to the case interface. All callers updated. Deal with
3441 new and removed members.
3442 (casefile_destroy) Deal with new and removed members.
3443 (casefile_sleep) New function.
3444 (casefile_get_case_size) Removed.
3445 (casefile_get_value_cnt) New function.
3446 (casefile_append) Rewritten to deal with new and removed members.
3447 (casefile_append_xfer) New function.
3448 (write_case_to_disk) Use case_serialize().
3449 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
3450 Couldn't figure out why.
3451 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
3452 deal with new and removed members.
3454 (merge_sort) Removed.
3455 (casefile_sort) Removed.
3456 (casefile_get_reader) Deal with new and removed members.
3457 (casefile_get_destructive_reader) New function.
3458 (reader_open_file) Make code more readable. Create case for
3460 (casereader_get_casefile) New function.
3461 (casereader_read) Deal with new and removed members. Now returns
3462 a copy of the case, so that the caller is responsible for
3463 destroying the returned case.
3464 (casereader_read_xfer) New function.
3465 (casereader_destroy) Destroy reader's case.
3466 (test_casefile) Second arg is now a value count, all callers
3467 updated. Now tests destructive readers too.
3468 (get_random_case) Deal with new case ADT.
3469 (write_random_case) Ditto.
3470 (read_and_verify_random_case) Ditto.
3472 * crosstabs.q: Remove debug code.
3474 * descript.q: (calc_descriptives) Deal with new case, casefile
3477 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
3479 * do-if.c: Remove unneeded header inclusion.
3481 * expr-prs.c: Remove debug code.
3483 * exprP.h: Remove debug code.
3485 * flip.c: (flip_file) Use fseeko() if available.
3487 * formats.c: Remove debug code.
3489 * get.c: Remove debug code.
3490 (struct mtf_file) Change `input' from `union value *' to `struct
3491 ccase', all references updated.
3493 * levene.c: (levene) Deal with new case, casefile ADTs.
3495 * list.q: Remove debug code.
3497 * loop.c: Remove debug code.
3499 * matrix-data.c: Remove debug code.
3501 * means.q: Remove debug code.
3503 * mis-val.c: Remove debug code.
3505 * pfm-read.c: Remove debug code.
3506 (pfm_read_code) Change second arg from `union value *' to `struct
3507 ccase *', all references updated.
3509 * recode.c: (string_to_long) Make first arg const.
3510 (convert_to_double) Ditto.
3512 * repeat.c: Remove debug code.
3514 * sample.c: Remove debug code.
3516 * sfm-read.c: Remove debug code.
3517 (sfm_read_case) Change second arg from `union value *' to `struct
3520 * sort.c: Redone in terms of casefiles.
3521 (enum sort_direction) Moved here from sort.h.
3522 (struct sort_criterion) New structure.
3523 (struct sort_criteria) New structure.
3524 (cmd_sort_cases) Rewritten.
3525 (prepare_to_sort_active_file) New function.
3526 (sort_active_file_in_place) New function.
3527 (sort_active_file_to_casefile) New function.
3528 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
3529 changed, all callers updated.
3530 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
3531 rewritten & interface changed, all callers updated.
3532 (sort_cases) Renamed sort_execute(), rewritten & interface
3533 changed, all callers updated.
3534 (struct internal_sort) Removed.
3535 (do_internal_sort) Rewritten, interface changed.
3536 (destroy_internal_sort) Removed.
3537 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
3538 (struct initial_run) Removed; an initial run is now just a
3540 (compare_initial_runs) Rewritten.
3541 (struct external_sort) Changed almost completely.
3542 (do_external_sort) Rewritten, interface changed.
3543 (destroy_external_sort) Rewritten.
3544 [HAVE_MKDTEMP] (make_temp_dir) Removed.
3545 [!HAVE_MKDTEMP] (do_mkdir) Removed.
3546 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
3547 (init_external_sort) Removed.
3548 (simulate_error) Removed.
3549 (rmdir_temp_dir) Removed.
3550 (get_temp_file_name) Removed.
3551 (open_temp_file) Removed.
3552 (close_temp_file) Removed.
3553 (remove_temp_file) Removed.
3554 (write_temp_file) Removed.
3555 (read_temp_file) Removed.
3556 (struct record_run) Change `record' from `struct case_lit *' to
3558 (struct initial_run_state) Remove `idx_to_fv', `free_list',
3559 `file_idx', `output_file'. Add `run', casefile'. Change
3560 `last_output' from `struct case_list *' to `struct ccase'.
3561 (write_initial_runs) Change interface, rewrite.
3562 (sort_sink_write) Renamed process_case(), changed interfaced,
3564 (destroy_initial_run_state) Rewritten.
3565 (allocate_cases) Rewritten.
3566 (compare_record) Interface changed, rewritten.
3567 (start_run) Rewritten.
3568 (end_run) Rewritten.
3569 (output_record) Rewritten.
3570 (grab_case) Removed.
3571 (release_case) Removed.
3572 (struct merge_case) Change `cases' from double pointer to single
3574 (merge) Deal with new case and casefile ADTs.
3575 (struct run) Removed.
3576 (merge_once) Rewritten, interface changed.
3577 (fill_run_buffer) Removed.
3578 (sort_sink_make_source) Removed.
3579 (sort_sink_class) Removed.
3580 (struct sort_source_aux) Removed.
3581 (sort_source_read_helper) Removed.
3582 (sort_source_read) Removed.
3583 (read_sort_output) Removed.
3584 (read_internal_sort_output) Removed.
3585 (read_external_sort_output) Removed.
3586 (sort_source_destroy) Removed.
3587 (sort_source_class) Removed.
3589 * sort.h: (struct sort_cases_pgm) Removed.
3590 (enum sort_direction) Moved to sort.c.
3592 * t-test.q: (calculate) Deal with new case, casefile ADTs.
3594 * tab.c: Remove debug code.
3596 * var-labs.c: Remove debug code.
3598 * var.h: (struct ccase) Removed.
3599 (struct case_list) Removed.
3601 * vars-atr.c: (discard_variables) Use free_case_source().
3603 * vars-prs.c: (parse_vs_variable) Make arg const.
3604 (parse_dict_variable) Ditto.
3605 (parse_variables) Make struct dictionary * arg const.
3606 (parse_var_set_vars) Make struct var_set * arg const.
3607 (struct var_set) Add const to some of the function pointers' args.
3608 (var_set_get_cnt) Make arg const.
3609 (var_set_get_var) Make first arg const.
3610 (var_set_lookup_var) Make first arg const.
3611 (dict_var_set_get_cnt) Make arg const.
3612 (dict_var_set_get_var) Make first arg const.
3613 (dict_var_set_lookup_var) Make first arg const.
3614 (var_set_create_from_dict) Make arg const. Add cast to aux
3616 (struct array_var_set) Add const to var member.
3617 (array_var_set_get_cnt) Make arg const.
3618 (array_var_set_get_var) Make first arg const.
3619 (array_var_set_lookup_var) Make first arg const.
3620 (var_set_create_from_array) Make first arg const. Insert cast.
3622 * vfm.c: (struct write_case_data) Change trns_case, sink_case
3623 members from `struct ccase *' to `struct ccase'.
3624 (static var lag_queue) Change from double to single pointer.
3625 (procedure) Optimize trivial case.
3626 (internal_procedure) Deal with changed case, case_source ADTs.
3627 (create_trns_case) Changed interface, rewrote.
3628 (open_active_interface) Initialize modified lag queue.
3629 (write_case) Deal with changed case ADT.
3630 (lag_case) Deal with modified lag queue.
3631 (close_active_file) Destroy modified lag queue.
3632 Deal with changed case_source, case_sink ADTs.
3633 (destroy_storage_stream_info) Make null arg into no-op.
3634 (storage_sink_make_source) Set aux in created source.
3635 (storage_source_read) Deal with changed case, casefile ADTs.
3636 (storage_source_create) New function.
3637 (lagged_case) Rewrite.
3638 (free_case_source) New function.
3639 (free_case_sink) Rewrite.
3640 (struct split_aux_data) Changed prev_case from `struct ccase *' to
3642 (procedure_with_splits) Deal with changed prev_case.
3643 (procedure_with_splits_callback) Ditto.
3644 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
3646 (multipass_procedure_with_splits) Deal with changed prev_case.
3647 (multipass_split_callback) Ditto.
3650 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
3652 The workspace idea didn't work out.
3654 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
3656 * workspace.c: Removed.
3658 * workspace.h: Removed.
3660 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
3662 Fully implement arbitrary delimiters on DATA LIST, extending the
3663 half implementation that was already there.
3665 * data-list.c: (struct data_list_pgm) Remove `delim', add
3666 `delims', `delim_cnt'.
3667 (cmd_data_list) Initialize new members. Parse delimiters and
3668 clean up code a bit.
3669 (cut_field) Extract fields with arbitrary delimiters. Also, fix
3670 handling of leading commas.
3671 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
3673 (read_from_data_list_free) Adapt to new DFM interfaces.
3674 (read_from_data_list_list) Ditto.
3675 (repeating_data_trns_proc) Ditto.
3677 * dfm.c: Split up reader and writer into separate code, because
3678 they do different things. Use struct string instead of explicit
3679 allocation code, for clarity.
3680 (enum dfm_reader_flags) New enum.
3681 (struct dfm_fhuser_ext) Removed.
3682 (struct dfm_reader_ext) New.
3683 (get_reader) New function, used by just about all the reader
3685 (dfm_close) Removed.
3686 (close_reader) New function.
3687 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
3688 (dfm_open_for_writing) Ditto.
3689 (macro force_line_buffer_expansion) Removed.
3690 (count_tabs) Removed.
3691 (tabs_to_spaces) Removed.
3692 (read_record) Deal with new dfm_reader_ext. Use struct string
3693 functions. Don't convert tabs to spaces.
3694 (dfm_eof) New function.
3695 (dfm_get_record) Changed interface, rewrote.
3696 (dfm_expand_tabs) New function.
3697 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
3698 dfm_reader_ext, rewritten.
3699 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
3700 dfm_reader_ext, rewritten.
3701 (dfm_set_record) Removed in favor of dfm_forward_columns().
3702 (dfm_forward_columns) New function.
3703 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
3704 dfm_reader_ext, rewritten.
3705 (static var dfm_r_class) Use close_reader for the destructor.
3706 (struct dfm_writer_ext) New.
3707 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
3708 bounce buffer now instead of local allocation.
3709 (close_writer) New function.
3710 (static var dfm_writer_ext) Use close_writer for destructor.
3711 (cmd_begin_data) Adapt to new dfm_reader_ext.
3713 * file-handle.q: Add support for per-file tab width.
3714 (struct private_file_handle) Add tab_width member.
3715 (q2c specifications) Add tabwidth subcommand.
3716 (cmd_file_handle) Put parsed tab width into private_file_handle.
3717 (create_file_handle) Set default tab width.
3718 (handle_get_tab_width) New function.
3720 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
3722 * inpt-pgm.c: (reread_trns_proc) Ditto.
3724 * matrix-data.c: (context) Ditto.
3725 (another_token) Ditto.
3729 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
3731 * casefile.c: (casefile_destroy) Fix memory leak by freeing
3733 (casereader_destroy) Don't close file descriptor -1.
3735 * recode.c: (cmd_recode) Fix memory leak.
3737 * set.q: (q2c specifications) Fix typo in user message.
3739 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
3740 undefined behavior for overlapping arguments.
3742 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
3744 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
3745 don't call it when we're running under valgrind.
3746 (call_posix_fadvise) New function.
3747 (casefile_to_disk) Use call_posix_fadvise().
3748 (reader_open_file) Ditto.
3750 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
3752 Update our string ADTs, struct string and struct len_string. Get
3753 rid of pool support, which was largely unused. Rename lots of
3754 functions to have more obvious or consistent names.
3756 * ascii.c: Get rid of ascii_pool. It was only used for string
3758 (ascii_open_global) Don't create ascii_pool.
3759 (ascii_close_driver) Don't destroy ascii_pool.
3760 (ascii_postopen_driver) Don't use pool.
3761 (ascii_close_driver) Destroy strings manually.
3763 * str.c: (ds_create) Remove pool argument, all references updated.
3765 (ds_replace) Remove pool support, make more efficient when we
3766 don't need to reallocate.
3767 (ds_destroy) Remove pool support.
3768 (ds_rpad) New function.
3769 (ds_size) Renamed ds_capacity(), all references updated.
3770 (ds_value) Renamed ds_c_str(), all references updated.
3771 (ds_concat) Renamed ds_puts(), all references updated.
3772 (ds_concat_buffer) Renamed ds_concat(), all references updated.
3773 (ds_putchar) Renamed ds_putc(), all references updated.
3774 (ds_getline) Renamed ds_gets(), all references updated.
3775 (ls_create) Remove pool argument, all references updated.
3776 (ls_create_buffer) Ditto.
3777 (ls_destroy) Removed pool support.
3778 (ls_value) Renamed ls_c_str(), all references updated.
3780 * str.h: (ls_length) [__GNUC__] Add inline version.
3781 (ls_c_str) [__GNUC__] Add inline version.
3782 (ls_end) [__GNUC__] Add inline version.
3783 (struct string) Remove pool member. Rename `size' to `capacity',
3784 all references updated.
3786 * tab.c: (text_format) Instead of using pool argument to
3787 ls_create_buffer(), call pool_register() on allocated data.
3789 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
3791 We're abusing the current ASCII driver by telling it to allocate a
3792 9999-line, 9999-character page in the tests. This causes some
3793 systems to curl up and die because it allocates 20 MB of
3794 contiguous RAM. This change alleviates at least part of the
3795 problem. It is mostly a stop-gap until the new output system is
3798 * ascii.c: (struct line) New structure.
3799 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
3800 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
3801 (ascii_preopen_driver) Initialize new members, not old ones.
3802 (ascii_close_driver) Destroy new members, not old ones.
3803 (ascii_open_page) Allocate new members, not old ones.
3804 (expand_line) Allocate room in line.
3805 (draw_line) Use new members.
3806 (ascii_line_horz) Ditto.
3807 (ascii_line_vert) Ditto.
3808 (ascii_line_intersection) Ditto.
3810 (output_lines) Ditto.
3811 (ascii_close_page) Ditto.
3813 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
3815 * matrix.c: Dead code. Removed.
3817 * matrix.h: Dead code. Removed.
3819 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
3821 Contrary to what I'd always understood, there is an efficient
3822 algorithm for deletion from a hash table populated via linear
3823 probing. This change implements it.
3825 * hash.c: (hsh_rehash) Probe in increasing order.
3827 (locate_matching_entry) Ditto.
3828 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
3830 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
3832 * moments.c (calc_moments): Adjust calculation of kurtosis to
3833 avoid subtracting huge numbers from huge numbers, on Michael
3836 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
3838 Rework moments routines for improved numerical stability based on
3839 Michael Kiefte's advice. Any bugs or remaining numerical problems
3840 are still mine though.
3842 There is now a struct moments1 for use with one-pass moments. It
3843 uses a provisional means algorithm as an attempt to improve
3844 accuracy of higher moments. The older struct moments now only
3845 handles two-pass moments.
3847 * aggregate.c: Use moments1 instead moments.
3849 * descript.c: Revert previous change, which is no longer needed
3850 due to the moments revision.
3852 * moments.c: (calc_moments) New function for calculating variance,
3854 (moments_pass_one) Only accumulate weights bigger than zero.
3855 (moments_calculate) Allow calculating the mean on pass one, others
3856 require pass two. Implement in terms of calc_moments().
3857 (struct moments1) New structure.
3858 (init_moments1) New function.
3859 (moments1_clear) Ditto.
3860 (moments1_create) Ditto.
3861 (moments1_add) Ditto.
3862 (moments1_calculate) Ditto.
3863 (moments1_destroy) Ditto.
3864 (cmd_debug_moments) Deal with `struct moments' or `struct
3865 moments1' as requested by user.
3867 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
3869 * Makefile.am (pspp_SOURCES): Remove debug.c.
3871 * debug.c: Removed. It was empty anyway.
3873 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
3875 * descript.c (calc_descriptives): Fix assert failure when only
3876 MOMENT_MEAN is needed.
3878 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
3882 fixed problem with parsing in match_statistic() causing
3883 "DESCRIPTIVE STAT=MEAN." to barf.
3885 "MEAN" is now default if "SORT" given without specification.
3887 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
3888 generally less forgiving of syntax errors: better to have it do
3889 nothing and type it in again then to not know what it actually did
3892 z-score transformation now checks score for user-missing values
3893 and checks std_dev for SYSMIS.
3895 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
3897 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
3898 Changed dict_get_case_weight() to accept an additional int * flag
3899 to complain about system-missing, user-missing, zero, or negative
3900 weights and updated existing functions to pass int * to
3901 dict_get_case_weight().
3903 2004-04-05 jmd <jmd@gnu.org>
3905 * main.c: Fixed configuration problems with gsl
3907 * t-test.q: Fixed some problems encountered when compiling under Cygwin
3909 2004-04-03 blp <blp@gnu.org>
3911 * lexer.c, ChangeLog:
3912 Fix infinite loop on comment at end of file, add test.
3914 2004-04-03 jmd <jmd@gnu.org>
3916 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
3917 Fixed the calculation of percentiles and added --syntax and --algorithm options
3919 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
3921 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
3924 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
3926 * frequencies.q: Fixed the calculation of percentiles
3928 * Makefile.am: Added the --ansi flag and dealt with the
3929 consequences. Added some entries to PSPP_sources so that
3930 make distcheck would pass
3932 * cmdline.c: Added the --syntax and --algorithm options
3934 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
3936 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3938 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
3939 use the new multipass_split_... mechanism.
3941 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
3943 * frequencies.q: (calc_stats) Use moments data structure and
3944 calc_seskew(), calc_sekurt() functions.
3946 * set.q main.c settings.h Added support for --syntax and --algorithm
3949 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
3951 * vfm.c: Had to get last call to multipass_split_output() inside
3952 open_active_file()/close_active_file() pairing, so introduce new
3954 (internal_procedure) Move procedure() code here, except for calls
3955 to open_active_file() and close_active_file().
3956 (procedure) Wrap open_active_file() and close_active_file() around
3957 internal_procedure().
3958 (multipass_procedure_with_splits) Wrap open_active_file() and
3959 close_active_file() around internal_procedure().
3961 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
3963 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
3965 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
3967 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
3969 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
3971 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
3973 * algorithm.c: By default turn off some of the more expensive
3975 (expensive_assert) New macro which expands to assert if
3976 EXTRA_CHECKS is defined, to nothing otherwise.
3977 (unique) Use expensive_assert().
3978 (binary_search) Ditto.
3984 * command.c: (conflicting_3char_prefixes) Words that are the same
3985 don't cause conflicts when they are abbreviated to the first three
3988 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
3989 nonterm_node's n earlier.
3990 (generic_str_func) Ditto.
3992 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
3994 Add support for multipass procedures. Rewrite DESCRIPTIVES to
3995 test multipass support, take advantage of new moments
3996 calculation, and to not be such crappy code. Get rid of q2c
3997 processing for DESCRIPTIVES.
3999 * vfm.c: (struct multipass_split_aux_data) New structure.
4000 (multipass_procedure_with_splits) New function.
4001 (multipass_split_callback) New function.
4002 (multipass_split_output) New function.
4003 * descript.q: Removed.
4005 * descript.c: New file.
4007 * var.h: Removed descriptives enums.
4008 (struct descriptives_proc) Removed.
4009 (struct variable) Removed p.dsc.
4011 * Makefile.am: (q_sources_c) Remove descript.c.
4012 (q_sources_q) Removed descript.q.
4014 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
4016 New manager for keeping track of used workspace.
4018 * workspace.c: New file.
4020 * workspace.h: New file.
4022 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
4024 * sort.c: (do_internal_sort) Use workspace_malloc().
4025 (destroy_internal_sort) Use workspace_free().
4027 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
4029 New `struct casefile' for managing sets of cases.
4031 * casefile.c: New file.
4033 * casefile.h: New file.
4035 * command.def: Add DEBUG CASEFILE command.
4037 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
4039 * sort.c: (sort_cases) Move logic for sending storage file to disk
4040 into do_external_sort().
4041 (struct internal_sort) Use an array of ccase pointers instead of a
4043 (do_internal_sort) Rewrite to handle casefiles.
4044 (compare_case_list) Removed.
4045 (compare_cases) New function.
4046 (compare_case_dblptrs) New function.
4047 (read_internal_sort_output) Deal with new struct internal_sort.
4049 * vfm.c: (static var workspace_overflow) Removed.
4050 (struct storage_stream_info) Removed all the members. Added
4051 struct casefile * member.
4052 (storage_sink_open) Use casefile.
4053 (open_storage_file) Removed.
4054 (write_storage_file) Removed.
4055 (storage_to_disk) Removed.
4056 (destroy_storage_stream_info) Use casefile.
4057 (storage_sink_write) Use casefile.
4058 (storage_sink_make_source) Use casefile.
4059 (storage_source_count) Use casefile.
4060 (storage_source_read) Use casefile.
4061 (storage_source_on_disk) Removed.
4062 (storage_source_get_cases) Removed.
4063 (storage_source_set_cases) Removed.
4064 (storage_source_get_casefile) New function.
4066 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
4068 New `struct moments' for calculating moments.
4074 * moments.c: New file.
4076 * moments.h: New file.
4078 * command.def: Add DEBUG MOMENTS command.
4080 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
4083 * aggregate.c: Modify AGGREGATE to use the new moments
4084 calculation, even if not in such a great way.
4085 (struct agr_var) Add `moments' member.
4086 (parse_aggregate_functions) Set `moments' member to null.
4087 (agr_destroy) Destroy `moments' member.
4088 (accumulate_aggregate_info) Use `moments' for standard deviation.
4089 (dump_aggregate_info) Ditto.
4090 (initialize_aggregate_info) Create or clear `moments'.
4092 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
4093 cube(), pow4() that were in stats.h. All references updated.
4095 * crosstabs.q: stats.h had chi-square significance functions. Use
4097 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
4099 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
4100 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
4102 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
4104 * dictionary.c: (dict_compact_values) Compacted values need to
4107 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
4109 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
4110 `/' at start. Check return value of parse_variables() for error
4113 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
4115 Revamp expressions: make the code a little nicer, and fix bugs
4118 * expr-evl.c: (expr_evaluate) Make expression argument const.
4119 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
4120 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
4121 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
4122 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
4123 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
4124 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
4125 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
4126 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
4127 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
4128 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
4129 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
4130 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
4131 Simplify OP_SYSMIS. Remove OP_STR_MIS.
4133 * expr-opt.c: (optimize_expression) Rewrite.
4138 (macro s0l) Removed.
4140 (macro s1l) Removed.
4142 (macro s2l) Removed.
4145 (eq_num_con) New function.
4146 (optimize_tree) New function.
4147 (macro rnc) Removed.
4148 (macro frnc) Removed.
4149 (str_search) Add const to string params.
4150 (str_rsearch) Ditto.
4151 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
4152 str[], str_len[] locals to substitute for most of removed macros.
4153 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
4154 Removed support for missing values because we're never called with
4155 missing values. Use set_number() or set_number_errno() instead of
4156 rnc or frnc. Removed any stuff that caused trouble in testing.
4157 We can re-add it later if it really slows anything. Fix some
4159 (evaluate_tree_with_missing) Not yet supported. To be added later
4161 (repl_num_con) Removed.
4162 (collapse_node) New function.
4163 (force_repl_num_con) Removed.
4164 (set_number) New function.
4165 (set_number_errno) New function.
4166 (repl_str_con) Removed.
4167 (set_string) New function.
4168 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
4170 (dump_node) No special case for OP_AND, OP_OR.
4172 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
4173 (expr_get_type) New function.
4174 (type_check) Rewrite.
4175 (type_coercion) New function.
4176 (struct operator) New structure.
4177 (match_operator New function.
4178 (parse_binary_operators) New function.
4179 (parse_inverting_unary_operator) New function.
4180 (parse_or) Rewritten.
4181 (parse_and) Rewritten.
4182 (parse_not) Rewritten.
4183 (parse_rel) Rewritten.
4184 (parse_add) Rewritten.
4185 (parse_mul) Rewritten.
4186 (parse_neg) Rewritten.
4187 (parse_exp) Rewritten.
4188 (parse_sysvar) Add $TRUE, $FALSE system variables.
4189 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
4190 (parse_primary) Use allocate_var_node(), allocate_num_con(),
4192 (struct function) Remove desc, change `func' prototype.
4193 (unary_func) Remove special cases.
4194 (MISSING_func) Reduce to unary_func() that just returns a boolean.
4195 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
4196 (VALUE_func) Use allocate_var_node().
4197 (nary_num_func) Allow MIN and MAX for strings.
4198 Use allocate_var_node(). Properly clean up.
4200 (generic_str_func) Use local table instead of removed `desc'
4201 member. Mostly rewrite.
4202 (get_num_args) Revise error message.
4203 (parse_function) Return EXPR_ERROR, not 0 on error.
4205 (macro varies) Removed.
4206 (ops[]) Use expr.def.
4207 (free_node) Do nothing if node is null.
4208 (allocate_num_con) New function.
4209 (allocate_str_con) New function.
4210 (allocate_var_node) New function.
4211 (allocate_binary_nonterminal) New function.
4212 (append_nonterminal_arg) Removed.
4213 (static var func_tab[]) Revised.
4214 (expr_debug_print_postfix) Make parameter const.
4215 Use printf() instead of debug_printf().
4217 * expr.def: New file.
4219 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
4220 use named enum instead of unnamed, all references updated. Add
4221 EXPR_ANY, EXPR_NO_OPTIMIZE.
4223 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
4224 instead of defining OP_* directly.
4225 (macro IS_TERMINAL) New macro.
4226 (macro IS_NONTERMINAL) New macro.
4227 (enum OP_NO_FLAGS) New.
4229 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
4231 * error.c: (err_assert_fail) msg variable needs to be non-const.
4233 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
4235 * debug.c: (cmd_debug_evaluate) Rewrite.
4237 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
4239 Fix some CROSSTABS bit rot stupidity.
4241 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
4242 (internal_cmd_crosstabs) Initializes cells[] correctly.
4243 (float_M_suffix) Rename format_cell_entry(), change prototype,
4245 (display_crosstabulation) Fix cell formatting.
4247 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
4249 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
4250 to call lex_discard_line() to do that.
4252 * command.c: (run_command) Call lex_discard_line() after
4255 * lexer.c: (lex_entire_end) Change behavior.
4256 (lex_rest_of_line) Change behavior. Return const char *.
4257 (lex_discard_line) Don't clear getl_buf, don't emit message.
4259 * main.c: (handle_error) Emit message here.
4261 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
4262 instead of lex_entire_line().
4264 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
4266 * title.c: (get_title) Call lex_discard_line() after
4268 (cmd_file_label) Ditto.
4269 (cmd_document) Deal with const char * return value.
4271 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
4273 Removed REMARK command.
4275 * command.c: (extract_prefix) Removed.
4276 (output_line) Removed.
4277 (cmd_remark) Removed.
4279 * command.def: Remove REMARK.
4281 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
4283 Added abort() after lots of assert(0) invocations to avoid some
4284 compiler warnings. We really need a NOT_REACHED macro.
4286 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4288 * sort.c: Added missing call to temp_file_close. Changed error
4289 messages to warnings.
4291 * set.q: Improved setting of set_view{length,width} to be more tolerant
4294 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
4296 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
4297 used with incorrect syntax.
4299 * error.c, error.h et al: Overridden definition of assert for a
4302 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
4303 subcommand was given when it ought to have been.
4305 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
4307 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
4311 (tab_joint_text) Ditto.
4313 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
4315 * levene.c: Add #include.
4317 * set.q: (set_viewport) Add `int' argument to make its prototype
4318 correct for signal().
4320 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
4322 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
4325 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
4327 Changed DFM from open-at-first-access to explicit-open. Before,
4328 calling dfm_get_record() or dfm_put_record() would automatically
4329 open the file. Now, you have to call dfm_open_for_reading() or
4330 dfm_open_for_writing() explicitly. This makes it possible to
4331 check permissions, file existence, etc. earlier.
4333 Also made struct file_handle more opaque, and clean up in general.
4335 * data-list.c: (cmd_data_list) Open handle for reading.
4337 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
4339 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
4340 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
4341 (open_inline_file) Removed.
4342 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
4343 it. Deal with line_number in extension record instead of file
4345 (dfm_get_record) Rewrote.
4346 (dfm_put_record) Rewrote.
4347 (dfm_push) Assert file is open and one of ours. Deal with
4348 line_number in extension record instead of file handle.
4349 (dfm_pop) Assert file is open and one of ours. Deal with
4350 line_number in extension record instead of file handle.
4351 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
4354 * file-handle.h: (enum constants RH_RF_*) Removed.
4355 (enum constants FH_MD_*) Removed.
4356 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
4357 `recform', `lrecl', `mode' members. Public references to
4358 `recform' changed to use handle_get_mode(), references to `lrecl'
4359 changed to use handle_get_record_width(). Added `private' member.
4360 (enum file_handle_mode) New.
4362 * file-handle.q: (struct private_file_handle) New structure.
4363 (struct file_handle_list) New structure.
4364 (static var files) New.
4365 (static var file_handles) Removed.
4366 (init_file_handle) Removed.
4367 (create_file_handle) Removed.
4368 (get_handle_with_name) New function.
4369 (get_handle_for_filename) New function.
4370 (cmd_file_handle) Rewritten.
4371 (hash_file_handle) Removed.
4372 (cmp_file_handle) Removed.
4373 (fh_init_files) Rewritten.
4374 (fh_parse_file_handle) Rewritten. Allows identifiers as
4376 (fh_get_handle_by_name) Renamed handle_get_name(), all references
4378 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
4379 references updated. Rewritten.
4380 (fh_record_width) Renamed handle_get_record_width(), all
4381 references updated. Rewritten.
4382 (handle_get_mode) New function.
4384 * file-type.c: (cmd_file_type) Open handle for reading.
4386 * filename.c: [unix] (struct file_identity) New structure.
4387 [unix] (fn_get_identity) New function.
4388 [unix] (fn_free_identity) New function.
4389 [unix] (fn_compare_file_identities) New function.
4390 [!unix] (struct file_identity) New structure.
4391 [!unix] (fn_get_identity) New function.
4392 [!unix] (fn_free_identity) New function.
4393 [!unix] (fn_compare_file_identities) New function.
4395 * lexer.c: (static var put) Renamed put_token, all references
4397 (static var put_tokstr) New.
4398 (static var put_tokval) New.
4399 (lex_init) Initialize put_tokstr().
4400 (restore_token) New function.
4401 (save_token) New function.
4402 (lex_get) Use restore_token().
4403 (lex_put_back) Use save_token().
4404 (lex_put_back_id) New function.
4405 (lex_put_forward) Removed.
4406 (lex_preprocess_line) Set put_token instead of using
4408 (lex_negative_to_dash) Use save_token(), set put_token directly.
4409 (dump_token) Use stderr instead of stdout.
4411 * main.c: (main) Remove call to cmd_init().
4413 * matrix-data.c: (cmd_matrix_data) Open file for reading.
4415 * pfm-read.c: Use handle_get_filename() instead of trying to use
4416 h->fn directly, all over.
4418 * pfm-write.c: Ditto.
4420 * print.c: (internal_cmd_print) Open handle for writing.
4421 (dump_table) Use handle_get_filename().
4422 (print_trns_proc) Use handle_get_mode().
4423 (cmd_print_space) Use fh_parse_file_handle().
4424 Open handle for writing.
4425 [0] (debug_print) Removed.
4427 * sfm-read.c: Use handle_get_filename() instead of trying to use
4428 h->fn directly, all over.
4430 * sfm-write.c: Ditto.
4432 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
4436 * autorecode.c: (arc_free) Free arc->src_values.
4438 * error.c: (msg) Free buf.
4440 * val-labs.c: (do_value_labels) Always free vars.
4442 * vfm.c: (close_active_file) If sink has no make_source then call
4443 its destroy function.
4445 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
4447 Fixed cmd_parse() so that it always skips past a full command
4448 name. A few special commands for which this would be bad get
4449 special treatment. This lets us drop code for skipping past the
4450 end of a command name in most cmd_*() functions. It's not worth
4451 listing all the commands affected.
4453 * command.c: (struct command) Remove `cmd' member, replace by
4454 `name' member, all references updated. Remove `word', `next',
4455 `skip_entire_name' members.
4456 (macro DEFCMD) Deal with revised `struct command'.
4457 (macro UNIMPL) Ditto.
4458 (macro SPCCMD) New macro for commands whose last word shouldn't be
4460 (static array cmd_table[]) Make const, rename `commands', remove
4462 (macro COMMAND_CNT) New macro.
4463 (split_words) Removed.
4465 (FILE_TYPE_okay) Make parameter const.
4466 (cmd_parse) Improve error messages.
4467 (match_strings) New function.
4468 (next_word) New function.
4469 (enum command_match) New enum.
4470 (conflicting_3char_prefixes) New function.
4471 (conflicting_3char_prefix_command) New function.
4472 (cmd_match_words) New function.
4473 (count_matching_commands) New function.
4474 (get_command_name) New function.
4475 (free_words) New function.
4476 (unknown_command_error) New function.
4477 (figure_out_command) Renamed parse_command_name(), rewritten.
4479 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
4480 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
4481 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
4484 * command.h: (macro SPCCMD) New.
4486 * include.c: (cmd_include_at) Removed.
4487 (cmd_include) Allow identifier to be used as filename.
4489 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
4491 * t-test.q: (cmd_t_test) Command name is now parsed for us.
4494 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
4496 Start work on better test framework.
4498 * Makefile.am: (pspp_sources) Add debug.c.
4500 * debug.c: New file.
4502 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
4503 cmd_debug_evaluate().
4505 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
4507 * expr.h: (enum constant PXP_DUMP) Removed.
4509 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
4511 * set.q: Implemented the SHOW command, and synced it to the existing
4514 Added a handler for SIGWINCH so that viewlength and viewwidth follow
4515 changes as the window size is changed.
4517 Added fallback to set viewlength and viewwidth from LINES and COLUMS
4518 environment variables if other methods are not available.
4520 glob.c: Removed a lot of global variables from glob.c and encapsulated
4523 random.c: Tidied up the way the random seed is set.
4525 str.c: Added a ds_vprintf function.
4527 error.c: Extended dump_message so that messages are always broken at
4530 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
4532 * pfm-write.c: (bufwrite) Write out the correct element for string
4533 variables. From Andreas Streichardt <streichardt@globalpark.de>.
4535 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
4537 Get rid of static and global (!) vars in matrix-data.c.
4539 * matrix-data.c: (static var nr_data) Removed.
4540 (static var nr_factor_values) Removed.
4541 (static var max_cell_index) Removed.
4542 (static var split_values) Removed.
4543 (struct nr_aux_data) New structure.
4544 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
4545 place of static vars, pass to create_case_source() and procedure()
4547 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
4548 struct matrix_data_pgm *.
4549 (nr_read_splits) Ditto.
4550 (nr_read_factors) Ditto.
4551 (nr_output_data) Ditto.
4552 (static var wr_content) Removed.
4553 (global var wr_data) Removed.
4554 (global var wr_current) Removed.
4555 (struct wr_aux_data) New structure.
4556 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
4557 place of static vars, pass to create_case_source() and procedure()
4559 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
4560 instead of matrix_data_pgm *.
4561 (wr_read_splits) Ditto.
4562 (wr_output_data) Ditto.
4563 (wr_read_rowtype) Ditto.
4564 (wr_read_factors) Ditto.
4565 (wr_read_indeps) Ditto.
4567 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
4569 Get rid of static vars in autorecode.c.
4571 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
4572 `n_arc' to `spec_cnt'. All references updated.
4573 (static var v_src) Removed.
4574 (static var v_dest) Removed.
4575 (static var h_trns) Removed.
4576 (static var nv_src) Removed.
4577 (static var descend) Removed.
4578 (static var print) Removed.
4579 (enum direction) New enum.
4580 (struct autorecode_pgm) New structure.
4581 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
4582 Move n_dest local var into struct autorecode_pgm for ease of
4583 clean-up. Use arc_free().
4584 (arc_free) New function.
4585 (recode) Modify to take struct autorecode_pgm * parameter instead
4586 of using statics. Let the caller clean up.
4587 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
4588 instead of statics. Rearrange code a little.
4590 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
4592 Get rid of static, global vars in recode.c. Remove debug code.
4594 * recode.c: (static var head) Removed.
4595 (global var v) Removed.
4596 (global var nv) Removed.
4597 (cmd_recode) New local variables head, v, nv. Initialize and free
4598 v. Don't call debug_print().
4599 [DEBUGGING] (dump_dest) Removed.
4600 [DEBUGGING] (debug_print) Removed.
4602 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
4604 Get rid of static vars in expr-opt.c.
4606 * expr-opt.c: (static var e) Removed.
4607 (static var nop) Removed.
4608 (static var mop) Removed.
4609 (static var ndbl) Removed.
4610 (static var mdbl) Removed.
4611 (static var nstr) Removed.
4612 (static var mstr) Removed.
4613 (static var nvars) Removed.
4614 (static var mvars) Removed.
4615 (struct expr_dump_state) New structure.
4616 (dump_expression) Use new struct expr_dump_state instead of static
4617 vars and pass to functions we call.
4618 (dump_node) Use struct expr_dump_state * parameter.
4620 (emit_num_con) Ditto.
4621 (emit_str_con) Ditto.
4624 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
4626 Get rid of static var in COUNT.
4628 * count.c: (static var head) Move into cmd_count().
4629 (cmd_count) [DEBUGGING] Don't call debug_print.
4630 [DEBUGGING] (debug_print) Removed.
4632 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
4634 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
4636 * val-labs.c: (static var v) Removed.
4637 (static var nv) Removed.
4638 [DEBUGGING] (debug_print) Removed.
4639 (verify_val_labs) Add struct variable **, int parameters.
4640 (get_label) Ditto. Improve error messages, streamline.
4641 (erase_labels) New function for erasing value labels, taking over
4642 part of verify_val_labs()'s function.
4645 (cmd_value_labels) No need to call init() or done() anymore.
4646 (cmd_add_value_labels) Ditto.
4647 (do_value_labels) Add vars, var_cnt local variables. Clean up
4648 after them internally. Call erase_labels() if we should. Don't
4651 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
4653 Get rid of static vars in MATCH FILES.
4655 * get.c: (static var mtf_head) Removed.
4656 (static var mtf_tail) Removed.
4657 (static var mtf_by) Removed.
4658 (static var mtf_n_by) Removed.
4659 (static var mtf_master) Removed.
4660 (static var mtf_seq_num) Removed.
4661 (static var mtf_seq_nums) Removed.
4662 (static var mtf_sink) Removed.
4663 (static var mtf_case) Removed.
4664 (struct mtf_proc) New structure.
4665 (cmd_match_files) Use struct mtf_proc instead of static vars.
4666 (mtf_processing_finish) Ditto.
4668 (mtf_delete_file_in_place) Ditto.
4669 (mtf_read_nonactive_records) Ditto.
4670 (mtf_compare_BY_values) Ditto.
4671 (mtf_processing) Ditto.
4672 (mtf_merge_dictionary) Ditto.
4674 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
4676 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
4678 * dictionary.c: (dict_rename_var) Add assertion.
4679 (dict_contains_var) Check by index instead of name.
4681 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
4683 Get rid of compaction_necessary, compaction_nval, compaction_case.
4684 Redo VFM interface. Replace disk_sink and memory_sink by
4685 storage_sink, disk_source and memory_source by storage_source.
4687 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
4691 (struct write_case_data) Remove `begin_func', `end_func',
4692 `func_aux' members. Add `aux', `trns_case', `sink_case',
4693 `cases_written', `cases_analyzed' members.
4694 (global var compaction_necessary) Make static.
4695 (global var compaction_nval) Removed.
4696 (global var compaction_case) Removed.
4697 (static var case_count) Removed.
4698 (struct procedure_aux_data) Removed.
4699 (struct split_aux_data) Removed.
4700 (procedure) Remove begin_func, end_func parameters. Rewrite.
4701 (static var not_canceled) Removed.
4702 (process_active_file) Removed.
4703 (process_active_file_write_case) Removed.
4704 (process_active_file_output_case) Removed.
4705 (prepare_for_writing) Moved into open_active_file().
4706 (arrange_compaction) Ditto.
4708 (open_active_file) Rewrote.
4709 (write_case) New function.
4710 [DEBUGGING] (index_to_varname) Removed.
4711 (execute_transformations) New function.
4712 (exclude_this_case) Renamed filter_case(), changed interface.
4713 (clear_case) Added struct ccase * parameter to interface.
4714 (close_active_file) Added struct write_case_data * parameter,
4716 (disk_sink_create) Removed.
4717 (disk_sink_destroy) Removed.
4718 (disk_sink_make_source) Removed.
4719 (disk_sink_write) Removed.
4720 (disk_source_count) Removed.
4721 (disk_source_destroy) Removed.
4722 (disk_source_read) Removed.
4723 (global var disk_sink_class) Removed.
4724 (global var disk_source_class) Removed.
4725 (global var memory_sink_class) Removed.
4726 (global var memory_source_class) Removed.
4727 (memory_sink_create) Removed.
4728 (memory_sink_destroy) Removed.
4729 (memory_sink_make_source) Removed.
4730 (memory_sink_write) Removed.
4731 (memory_source_count) Removed.
4732 (memory_source_destroy) Removed.
4733 (memory_source_get_cases) Removed.
4734 (memory_source_read) Removed.
4735 (memory_source_set_cases) Removed.
4736 (struct disk_stream_info) Removed.
4737 (struct memory_sink_info) Removed.
4738 (struct memory_source_info) Removed.
4739 (write_active_file_to_disk) Removed.
4740 (destroy_storage_stream_info) New function.
4741 (global var null_sink_class) New var.
4742 (global var storage_sink_class) New var.
4743 (global var storage_source_class) New var.
4744 (open_storage_file) New function.
4745 (storage_sink_destroy) New function.
4746 (storage_sink_make_source) New function.
4747 (storage_sink_open) New function.
4748 (storage_sink_write) New function.
4749 (storage_source_count) New function.
4750 (storage_source_destroy) New function.
4751 (storage_source_get_cases) New function.
4752 (storage_source_on_disk) New function.
4753 (storage_source_read) New function.
4754 (storage_source_set_cases) New function.
4755 (storage_source_to_disk) New function.
4756 (storage_to_disk) New function.
4757 (struct storage_stream_info) New structure.
4758 (write_storage_file) New function.
4759 (procedure_write_case) Removed.
4760 (create_case_source) Add `struct dictionary *' parameter, all
4762 (create_case_sink) Ditto.
4763 (free_case_sink) New function.
4764 (struct split_aux_data) New structure.
4765 (procedure_with_splits) New function implementing what procedure()
4767 (SPLIT_FILE_proc_func) Removed.
4768 (procedure_with_splits_callback) New function.
4769 (equal_splits) New function.
4771 * aggregate.c: Pass around a struct instead of using statics.
4772 (static var outfile) Remove.
4773 (enum type) Give it tag `missing_treatment'.
4774 (static var missing) Remove.
4775 (static var sort) Remove.
4776 (static var agr_first) Remove.
4777 (static var agr_next) Remove.
4778 (static var case_count) Remove.
4779 (static var prev_case) Remove.
4780 (static var buf64_1xx) Remove.
4781 (static var buf_1xx) Remove.
4782 (struct agr_proc) New structure incorporating the above.
4783 (cmd_aggregate) Use new struct. Clean up error handling using
4784 agr_destroy(). Completely rewrite actual implementation of
4786 (create_sysfile) Add struct agr_proc * parameter, modify
4788 (parse_aggregate_functions) Ditto.
4789 (free_aggregate_functions) Ditto. Rename agr_destroy().
4790 (aggregate_single_case) Add struct agr_proc * parameter, modify
4792 (accumulate_aggregate_info) Ditto.
4793 (dump_aggregate_info) Ditto.
4794 (initialize_aggregate_info) Ditto.
4795 (agr_00x_trns_proc) Removed.
4796 (agr_00x_end_func) Removed.
4797 (agr_10x_trns_proc) Removed.
4798 (agr_10x_trns_free) Removed.
4799 (agr_10x_end_func) Removed.
4800 (agr_11x_read) Removed.
4801 (agr_11x_finish) Removed.
4802 [DEBUGGING] (debug_print) Removed.
4803 (write_case_to_sfm) Add struct agr_proc * parameter, modify
4805 (agr_to_active_file) New function.
4806 (presorted_agr_to_sysfile) New function.
4807 (sort_agr_to_sysfile) New function.
4809 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
4811 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
4813 * descript.q: (cmd_descriptives) Ditto.
4815 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
4816 to new procedure() interface.
4818 * command.c: (cmd_execute) Adapt to new procedure() interface.
4820 * dictionary.c: (dict_compact_values) Also delete scratch
4822 (dict_get_compacted_value_cnt) New function.
4823 (dict_get_compacted_idx_to_fv) New function.
4825 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
4826 (cmd_flip) Adapt to new procedure() interface.
4827 (flip_sink_write) Use sink->idx_to_fv.
4829 * frequencies.q: (internal_cmd_frequencies) Use
4830 procedure_with_splits().
4832 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
4833 (static var mtf_sink) New static var.
4834 (static var mtf_case) New static var.
4835 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
4836 we actually implement the matching.
4837 (mtf_delete_file_in_place) Use mtf_case.
4838 (mtf_processing) Use mtf_case and mtf_sink.
4839 (cmd_export) Adapt to new procedure() interface.
4841 * levene.c: (levene) Use procedure_with_splits().
4843 * list.q: (cmd_list) Use procedure_with_splits().
4845 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
4846 procedure() interface.
4847 (read_matrices_with_rowtype) Ditto.
4849 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
4850 TEMPORARY. Adapt to new procedure() interface.
4852 * rename-vars.c: Warn about and cancel TEMPORARY.
4854 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
4855 (sort_cases) Use dict_get_compacted_value_cnt() instead of
4856 compaction_nval. Adapt to new procedure() interface. Use
4857 storage_source_to_disk().
4858 (do_internal_sort) Don't try to dump the cases to memory.
4859 (compare_case_lists) Pass null idx_to_fv.
4860 (struct initial_run_state) Add `idx_to_fv' member. Remove
4862 (write_initial_runs) Don't initialize irs->case_size. Adapt to
4863 new procedure() interface. Reset irs->idx_to_fv after calling
4865 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
4866 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
4868 (destroy_initial_run_state) Don't dereference irs after freeing
4870 (allocate_cases) Don't calculate case_size locally.
4871 (compare_record) Add idx_to_fv parameter.
4872 (compare_record_run) Change parameter from struct sort_cases_pgm *
4873 to struct initial_run_state *. Pass irs->idx_to_fv to
4875 (compare_record_run) Third parameter now a struct
4876 initial_run_state *.
4877 (output_record) No need for out_case anymore. Pass irs, not
4878 struct sort_cases_pgm to pop_heap(). Use case_size from struct
4880 (merge) Use case_size from struct sort_cases_pgm.
4881 (merge_once) Use case_size from struct sort_cases_pgm.
4882 Pass null pointer to compare_record() as idx_to_fv.
4883 (global var sort_sink_class) Make static.
4885 * t-test.q: (cmd_t_test) Use procedure_with_splits().
4887 * temporary.c: Remove debugging crap.
4889 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
4891 * t-test.q, levene.c: Fixed up the handling of MISSING values
4894 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
4896 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
4899 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
4901 Change explicit variable name checks into use of
4902 dict_class_from_id().
4904 * dictionary.c: (dict_create_var) Change explicit variable name
4905 check into use of dict_class_from_id().
4907 * get.c: (trim_dictionary) Ditto.
4909 * sel-if.c: (cmd_filter) Ditto.
4911 * sysfile-info.c: (cmd_display) Ditto.
4913 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
4915 * vfm.c: (arrange_compaction) Ditto.
4917 * weight.c: (cmd_weight) Ditto.
4919 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
4921 * temporary.c: (cmd_temporary) When TEMPORARY was the first
4922 transformation following the input program, if any, for some
4923 reason we special-cased f_trns. That's just wrong. It should
4924 always be set to n_trns.
4926 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
4928 * format.c: (parse_format_specifier_name) Fix brown-bag bug
4929 introduced in last check-in.
4931 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
4933 * format.c: (global array translate_fmt[]) Removed.
4934 (translate_fmt) New function as replacement.
4935 (parse_format_specifier_name) Rewrite.
4937 * pfm-read.c: (convert_format) Use translate_fmt() instead of
4940 * sfm-read.c: (parse_format_spec) Ditto.
4942 * postscript.c: (text) Fix handling of fonts with missing
4945 * sort.c: (struct external_sort) Add temp_name member.
4946 (destroy_external_sort) Free temp_dir, temp_name members.
4947 (init_external_sort) Allocate temp_name.
4948 (get_temp_file_name) Change prototype.
4949 (open_temp_file) Deal with change to get_temp_file_name().
4950 (close_temp_file) Ditto.
4951 (remove_temp_file) Ditto.
4952 (write_temp_file) Ditto.
4953 (read_temp_file) Ditto.
4954 (sort_sink_destroy) Removed.
4955 (sort_sink_class) Change destroy member to null.
4957 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
4959 Eliminate temp_case.
4961 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
4962 anymore. Use agr_11x_finish().
4963 (aggregate_single_case) Make first param const.
4964 (accumulate_aggregate_info) Ditto.
4965 (agr_00x_end_func) Use compaction_case, not temp_case.
4966 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
4968 * data-list.c: (struct data_list_pgm) Add `case_size' member.
4969 (cmd_data_list) Initialize case_size.
4970 (read_from_data_list_fixed) Add struct ccase * param, use instead
4972 (read_from_data_list_free) Ditto.
4973 (read_from_data_list_list) Ditto.
4974 (read_one_case) Rename data_list_trns_proc(), all references
4975 updated. Add argument in calling above functions. Use c
4976 argument instead of temp_case.
4977 (destroy_dls) Rename data_list_trns_free(), all references
4980 * expr-evl.c: (expr_evaluate) Make second parameter const.
4982 * file-type.c: (struct file_type_pgm) Add `case_size' member.
4983 (cmd_end_file_type) Initialize `case_size'.
4984 (file_type_source_read) Add struct ccase * parameter. Use instead
4987 * flip.c: Rewritten.
4989 * get.c: (struct get_pgm) New structure to keep track of
4991 (cmd_get) Initialize case_size.
4993 (get_source) Deal with struct get_pgm.
4994 (get_source_read) Add struct ccase * parameter, use instead of
4996 (import_source_read) Ditto.
4998 * get.c: Use a null pointer instead of temp_case to represent the
4999 "current case" in a struct mtf_file's input member.
5000 (mtf_processing_finish) Pass null to mtf_processing(), not
5002 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
5003 (mtf_compare_BY_values) Add extra arg, use instead of null input
5005 (mtf_processing) Use c parameter instead of temp_case. Pass
5006 compaction_case to process_active_file_output_case().
5008 * glob.c: (global variable temp_case) Removed.
5010 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
5011 (cmd_input_program) Initialize case_size. Set
5012 vfm_source->value_cnt.
5013 (init_case) Add struct ccase * parameter, use instead of
5016 (input_program_source_read) Ditto.
5018 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
5019 (dump_cell_content) Ditto.
5020 (nr_output_data) Ditto.
5021 (read_matrices_without_rowtype) Ditto.
5022 (matrix_data_read_with_rowtype) Ditto.
5023 (wr_read_splits) Ditto.
5024 (wr_output_data) Ditto.
5026 * sort.h: (struct sort_cases_pgm) New member `case_size'.
5028 * sort.c: (sort_cases) Initialize scp->case_size.
5029 (struct external_sort) Remove `case_size' member.
5030 (write_initial_runs) Only call vfm_sink->class_destroy if
5032 (struct sort_source_aux) New structure.
5033 (sort_source_read_helper) New function.
5034 (sort_source_read) Use sort_source_read_helper().
5035 (read_sort_output) Change interface to be more reasonable.
5036 (read_internal_sort_output) Ditto.
5037 (read_external_sort_output) Ditto.
5039 * vars-prs.c: (dict_class_to_name) Pass return value through
5042 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
5043 (procedure) Initialize trns_case.
5044 (procedure) Pass trns_case to vfm_source->class->read().
5046 (process_active_file) Start using struct procedure_aux_data.
5047 (process_active_file_write_case) Pass trns_case to
5048 transformations, lag_case(), clear_case().
5049 (process_active_file_output_case) Add struct ccase * parameter.
5050 (create_trns_case) New function.
5051 (make_temp_case) Removed.
5052 (vector_initialization) Removed.
5053 (close_active_file) Only call make_source if non-null, otherwise
5054 set vfm_source to null pointer. Don't free temp_case.
5055 (disk_source_read) Add struct ccase * parameter, use instead of
5057 (memory_source_read) Ditto.
5058 (lag_case) Add const struct ccase * member.
5059 (procedure_write_case) Use trns_case instead of temp_case.
5060 (clear_case) Add struct ccase * member, use instead of temp_case.
5061 (exclude_this_case) Ditto.
5062 (create_case_source) Add struct dictionary * parameter, use to
5063 initialize source->value_cnt.
5065 * vfm.h: (struct case_source) Add `value_cnt' member.
5066 (struct case_source_class) Add struct ccase * parameter to `read'
5067 member function pointer.
5068 (struct case_sink_class) Make struct ccase * parameter const in
5069 `write' member function pointer.
5071 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
5073 Fix a lot of "possibly uninitialized variable" warnings. Some of
5074 them are even real bugs. A few of them make me wonder how the
5077 * aggregate.c: (parse_aggregate_functions) Initialize `function.
5079 * ascii.c: (output_lines) Add default case to switch.
5081 * crosstabs.q: Remove static variable `expected' and all
5083 (display_crosstabulation) Always calculate expected value.
5085 (output_pivot_table) Initialize `cmp'.
5086 (display_crosstabulation) New variable `last_row', which is
5089 * data-in.c: (parse_numeric) Always initialize sign. How did this
5092 * data-list.c: (repeating_data_trns_proc) Always initialize code.
5093 Always set info.ofs. (How did this work?!)
5095 * expr-opt.c: (optimize_tree) Always initialize `m'.
5096 (evaluate_tree) Always initialize `c'. (How did this work?)
5098 * frequencies.q: (frq_custom_variables) Always initialize min,
5100 (frq_custom_grouped) Always initialize `dl'.
5102 * groff-font.c: (groff_read_font) Always initialize char_set.
5104 * matrix-data.c: (nr_output_data) Initialize `split'.
5105 (wr_read_splits) Remove shadowing split_cnt declaration.
5106 (wr_output_data) Initialize `split'.
5108 * output.c: (tokener) Skip add character on syntax error.
5110 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
5112 * postscript.c: (read_ps_encodings) Use line.string instead of
5114 (write_text) Add default case to switch.
5115 (text) Always initialize multiple variables. Fix bug with
5118 * print.c: (fixed_parse_fortran) Initialize head.
5119 (alloc_line) Add default case to switch.
5121 * recode.c: (parse_dest_spec) Handle case where nothing matches.
5122 (recode_trns_proc) Move variable declaration inward. Add default
5125 * sfm-read.c: (read_header) Initialize skip_amt.
5127 * sysfile-info.c: (display_variables) Always initialize pc.
5129 * vars-prs.c: Initialized `included'.
5131 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
5133 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
5134 Just use signal() instead.
5136 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
5138 Get rid of vfm_sink_info and vfm_source_info.
5140 * aggregate.c: (agr_00x_end_func) Don't increment
5141 sfm_sink_info.ncases.
5143 * sort.c: (do_internal_sort) Get case count from
5144 vfm_source->class->count().
5145 (struct external_sort) Add `case_size' member.
5146 (do_external_sort) Initialize case_size.
5147 (struct initial_run_state) Add `case_size' member.
5148 (write_initial_runs) Initialize case_size.
5149 (sort_sink_write) Use case_size.
5150 (read_external_sort_output) Use case_size. Get case_cnt from
5153 * vfm.c: (struct write_case_data) Add underscores to existing arg
5154 names, all references updated. Renamed `aux' as `func_aux', all
5155 references updated. Added new `aux' member.
5156 (global var vfm_source_info) Removed.
5157 (global var vfm_sink_info) Removed.
5158 (struct procedure_aux_data) New.
5159 (struct split_aux_data) New.
5160 (procedure) Use `aux' fields for procedure_aux_data,
5162 (process_active_file_write_case) Pass case_count + 1 to
5163 transformation procedures, exclude_this_case().
5164 (process_active_file_output_case) Don't increment
5165 vfm_sink_info.ncases.
5166 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
5167 to send data to disk early.
5168 (make_temp_case) Don't use vfm_sink_info.case_size.
5169 (close_active_file) Don't initialize vfm_source_info.
5170 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
5171 (disk_sink_create) Initialize and/or update disk_stream_info.
5172 (disk_sink_write) Ditto.
5173 (disk_sink_destroy) Ditto.
5174 (disk_sink_make_source) Ditto.
5175 (disk_source_read) Ditto.
5176 (disk_source_destroy) Ditto.
5177 (global var disk_source_class) Add disk_source_count().
5178 (disk_source_count) New function.
5179 (struct memory_sink_info) Add `case_cnt', `case_size' members.
5180 (struct memory_source_info) Ditto.
5181 (memory_sink_create) Deal with case_cnt, case_size.
5182 (memory_sink_write) Ditto.
5183 (memory_sink_make_source) Ditto.
5184 (memory_source_read) Ditto.
5185 (memory_source_count) New function.
5186 (memory_source_class) Add memory_source_count().
5187 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
5188 proc_aux->cases_written, and pass it to transformation procedures
5189 and exclude_this_case ().
5190 (exclude_this_case) Add case_num parameter. Pass it to
5192 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
5195 * vfm.h: (struct case_source_class) Add `count' member.
5197 * vfmP.h: (struct stream_info) Removed.
5198 (global variable vfm_source_info) Removed.
5199 (global variable vfm_sink_info) Removed.
5201 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
5203 * var.h: (typedef trns_proc_func) New typedef.
5204 (trns_free_func) New typedef.
5205 (struct trns_header) Change `proc' to type trns_proc_func, `free'
5206 to type trns_free_func. This only changes the actual type of
5207 trns_proc_func, adding a `case_num' parameter. Updated all
5208 implementations to use the typedefs instead.
5210 * compute.c: (compute_num) Pass case_num to expr_evaluate().
5211 (compute_num_vec) Ditto.
5212 (compute_str) Ditto.
5213 (compute_str_vec) Ditto.
5215 * do-if.c: (do_if_trns_proc) Ditto.
5217 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
5220 * inpt-pgm.c: (input_program_source_read) Maintain case count,
5221 pass to transformation functions.
5222 (reread_trns_proc) Pass case_num arg to expr_evaluate().
5224 * loop.c: (loop_1_trns_proc) Ditto.
5225 (loop_2_trns_proc) Ditto.
5226 (loop_3_trns_proc) Ditto.
5228 * print.c: (print_space_trns_proc) Ditto.
5230 * sel-if.c: (select_if_proc) Ditto.
5232 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
5234 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
5235 destroying hash table.
5237 * glob.c: (read_active_file) Variable not referenced, removed.
5238 (cancel_input_pgm) Ditto.
5240 * levene.c: Add #include <stdlib.h> needed to call free().
5242 * aggregate.c: (parse_aggregate_functions) Make `function'
5245 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
5247 Start working to eliminate VFM dependence on static variables.
5249 * command.c: (cmd_parse) Use case_source_is_class().
5251 * data-list.c: Rewrite to eliminate use of static variables.
5253 * dfm.c: (cmd_begin_data) Use case_source_is_class().
5255 * file-handle.q: (fh_handle_name) Make parameter const.
5257 * file-type.c: Rewrite to eliminate use of static variables.
5259 * flip.c: Rewrite to eliminate use of static variables.
5261 * format.c: (get_format_var_width) New function.
5263 * get.c: Eliminate use of static variables.
5265 * inpt-pgm.c: Eliminate use of static variables.
5267 * matrix-data.c: Eliminate use of static variables.
5269 * set.q: (set_max_workspace) New variable.
5270 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
5272 * var.h: (struct case_list) Move here from vfmP.h.
5274 * vars-atr.c: (discard_variables) Handle new vfm_source type.
5276 * vfm.c: (vfm_source) Change type from struct case_stream to
5278 (vfm_sink) Change type from struct case_stream to struct
5280 (static var paging) Rename workspace_overflow, all references
5282 (procedure) Use new class structures.
5283 (process_active_file) Ditto.
5284 (process_active_file_write_case) Ditto.
5285 (prepare_for_writing) Use set_max_workspace. Use new class
5287 (close_active_file) Use new class structures. Free old sink.
5288 (global var disk_source_file) Removed.
5289 (global var disk_sink_file) Removed.
5290 (disk_stream_init) Removed.
5291 (disk_stream_read) Removed.
5292 (disk_stream_write) Removed.
5293 (disk_stream_mode) Removed.
5294 (disk_stream_destroy_source) Removed.
5295 (disk_stream_destroy_sink) Removed.
5296 (global var vfm_disk_stream) Removed.
5297 (disk_sink_create) New function.
5298 (disk_sink_write) New function.
5299 (disk_sink_destroy) New function.
5300 (disk_sink_make_source) New function.
5301 (disk_sink_class) New static var.
5302 (disk_source_read) New function.
5303 (disk_source_destroy) New function.
5304 (global var vfm_source_class) New var.
5305 (global var memory_source_cases) Removed.
5306 (global var memory_sink_cases) Removed.
5307 (global var memory_sink_max_cases) Removed.
5308 (struct memory_sink_info) New struct.
5309 (memory_stream_init) Removed.
5310 (memory_stream_read) Removed.
5311 (memory_stream_write) Removed.
5312 (memory_stream_mode) Removed.
5313 (memory_stream_destroy_source) Removed.
5314 (memory_stream_destroy_sink) Removed.
5315 (global var vfm_memory_stream) Removed.
5316 (page_to_disk) Renamed write_active_file_to_disk().
5317 (memory_sink_create) New function.
5318 (memory_sink_write) New function.
5319 (memory_sink_destroy) New function.
5320 (memory_sink_make_source) New function.
5321 (memory_sink_class) New static var.
5322 (memory_source_read) New function.
5323 (memory_source_destroy) New function.
5324 (memory_source_get_cases) New function.
5325 (memory_source_set_cases) New function.
5326 (global var vfm_source_class) New var.
5327 (procedure_write_case) Use new class structures.
5328 (create_case_source) New function.
5329 (case_source_is_complex) New function.
5330 (case_source_is_class) New function.
5331 (create_case_sink) New function.
5333 * vfm.h: (global variable reinit_sysmis) Not used, removed.
5334 (global variable reinit_blanks) Not used, removed.
5335 (global variable init_zero) Not used, removed.
5336 (global variable init_blanks) Not used, removed.
5337 (struct case_source) New struct.
5338 (struct case_source_class) New struct.
5339 (struct case_sink) New struct.
5340 (struct case_sink_class) New struct.
5341 (struct case_stream) Removed.
5343 * vfmP.h: (struct case_list) Moved to var.h.
5345 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
5347 * algorithm.c: (count_equal) New function.
5348 (count_if) New function.
5349 (unique) Add assertions.
5350 (partition) Add assertions.
5351 (is_partitioned) New function.
5352 (copy_if) Add assertions.
5353 (remove_equal) Add assertions.
5354 (lexicographical_compare) Rename lexicographical_compare_3way.
5355 (sort) Add assertions. Rephrase some code.
5356 (is_sorted) New function.
5358 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
5362 * sort.c: Completely rewrite.
5364 * sort.h: Expose interface via struct sort_cases_pgm, not via
5367 * aggregate.c: (sort) New static var.
5368 (cmd_aggregate) Use sort.
5369 (create_sysfile) Ditto.
5370 (aggregate_single_case) Ditto.
5371 (dump_aggregate_info) Ditto.
5372 (agr_00x_end_func) Ditto.
5373 (debug_print) Ditto.
5375 * var.h: (enum SRT_ASCEND) Removed.
5376 (enum SRT_DESCEND) Removed.
5377 (struct sort_cases_proc) Removed.
5378 (struct variable) Remove p.srt member.
5380 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
5382 Get rid of the old, crappy heap structure and replace it by a new,
5383 shiny, C++ STL-like heap structure.
5385 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
5387 * algorithm.c: (push_heap) New function.
5398 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
5400 Increase warning level.
5402 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
5404 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
5406 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
5408 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
5410 * dictionary.c: (dict_create_var) Fix root cause of bug worked
5411 around by previous change log entry.
5413 * compute.c: (lvalue_finalize) Remove workaround from previous
5416 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
5418 * compute.c: Fixed a bug where the Format was not getting set for
5419 computed variables (thus causing a crash when SAVEing).
5421 * Added a test to stop this bug ever coming back
5423 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
5425 Got rid of approx.h. In general, replaced all references to
5426 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
5429 * Makefile.am: (pspp_SOURCES) Removed approx.h.
5431 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
5432 test for mag < EPSILON.
5434 * misc.h: Add definition of EPSILON.
5436 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
5438 * vfm.c: (procedure) Add check to prevent recursive call.
5440 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
5442 * Moved the declarations relating to values to their own header file
5445 * Added levene.c and levene.h
5447 * vars-atr.c: Changed the signature of compare_values to
5448 take const * arguments.
5450 * t-test.q: Changed the structure of struct t_test_proc
5451 variables now contain their own group statistics information.
5452 Eventually, t_test_proc might get renamed, because it'd be
5453 applicable to other commands too.
5455 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
5457 * data-out.c: Clean up. Changed interface of convert_*() to take
5458 either a `double' or a `const char *' instead of a `const union
5459 value *'. Update all implementations of those interfaces.
5460 (data_out) Use switch statements instead of a table.
5461 (convert_AHEX) Rewrite.
5463 * format.h: Update comment.
5465 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
5467 * q2c.c: (dump_header) Add an Emacs header line to output files
5468 that makes generated .c files read-only by default, to make it
5469 difficult to accidentally change generated files.
5471 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
5473 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
5474 not bogus a->v.c <=> b->v.c pointer compare.
5475 (compare_freq_alpha_a) Ditto.
5476 (compare_freq_numeric_d) Ditto.
5477 (compare_freq_alpha_d) Ditto.
5479 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
5481 Changed data_out() to store string data directly into a `union
5482 value''s s member, not indirectly into c.
5484 * crosstabs.q: (output_pivot_table) Use format_short() instead of
5486 (table_value_missing) Ditto.
5487 (float_M_suffix) Ditto.
5488 (format_short) New function.
5490 * data-in.h: (data_in_finite_line) Remove inline definition.
5492 * data-list.c: (destroy_dls_var_spec) New function.
5493 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
5494 (data_list_source_destroy_source) Avoid cast.
5495 (struct repeating_data_trns) New field `id_value'. Update
5497 (cmd_repeating_data) Initialize id_value. Use new
5498 repeating_data_trns_free() for freeing REPEATING DATA
5500 (rpd_parse_record) Rewrite support for record ID to be less bogus.
5501 (repeating_data_trns_free) New function.
5503 * data-out.c: (data_out) Change return type to `void' by replacing
5504 error returns by writing a message into the output buffer.
5505 (convert_A) Read from v->s instead of v->c.
5506 (convert_AHEX) Ditto.
5508 * expr-evl.c: Update comment.
5509 (expr_evaluate) Add assertion in OP_STRING case.
5511 * format.h: (macro MAX_FORMATTED_LEN) New macro.
5513 * list.q: (list_cases) Update for new data_out() semantics.
5515 * print.c: (print_trns_proc) Ditto.
5517 * tab.c: (tab_value) Ditto.
5518 (tab_float) Avoid stupid cast.
5520 * var.h: Update comments.
5521 (macro MAX_STRING) New macro.
5522 (macro MAX_ELEMS_PER_VALUE) New macro.
5524 * vars-atr.c: (compare_values) New function.
5526 * vfm.c: (dump_splits) Update for new data_out() semantics.
5528 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
5530 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
5532 (struct crosstab) Rename v[] to vars[]. All references updated.
5533 (hash_table_entry) Replace the hash algorithm and fix a bug at the
5534 same time, which caused the hash value to depend only on a single
5535 value, not all of the variables' values.
5537 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
5539 Clean up struct dictionary's value_cnt usage.
5541 * dictionary.c: Add a function comment to each function.
5542 (struct dictionary) Rename value_cnt to next_value_idx, which more
5543 accurately reflects its meaning. All references updated.
5544 (dict_rename_vars) Add assertion.
5545 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
5547 (dict_get_case_size) New function.
5549 * aggregate.c: (create_sysfile) Use dict_get_case_size().
5551 * get.c: (mtf_read_nonactive_records) Ditto.
5553 * sort.c: (allocate_cases) Ditto.
5554 (write_initial_runs) Ditto.
5558 * vfm.c: (prepare_for_writing) Ditto.
5562 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
5564 Make vfm.c slightly less grotesque.
5566 * vfm.c: (filter_var) Removed.
5567 (filter_index) Removed.
5568 (FILTERED macro) Removed.
5569 (exclude_this_case) New function.
5570 (process_active_file_write_case) Use exclude_this_case() instead
5571 of FILTERED and inline tests.
5572 (procedure_write_case) Ditto.
5573 (setup_filter) Removed.
5574 (open_active_file) Don't call setup_filter().
5575 (close_active_file) Call dict_get_filter() instead of checking
5578 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
5580 * var.h: (struct variable) Update comments.
5582 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
5584 New functions dict_create_var_assert(), dict_lookup_var_assert().
5585 Converted several dict_*_var()/assert pairs into a single
5586 dict_*_var_assert().
5588 * dictionary.c: (dict_create_var_assert) New function.
5589 (dict_lookup_var_assert) New function.
5591 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
5593 Got rid of "struct long_vec", envector(), devector(), etc. Added
5594 two members `init', `reinit' to struct variable as a substitute.
5596 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
5602 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
5605 * autorecode.c: (cmd_autorecode) destvars don't need init.
5607 * compute.c: (lvalue_finalize) Set reinit.
5609 * data-list.c: (fixed_parse_compatible) Don't need init usually.
5610 (dump_fmt_list) Ditto.
5613 * descript.q: (run_z_pass) Don't need init for z-scores.
5615 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
5617 (dict_clone_var) Copy `reinit' member, initialize `init' member.
5619 * glob.c: (init_glob) Remove vec_init() calls.
5621 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
5623 * loop.c: (internal_cmd_loop) Don't need to call envector().
5625 * numeric.c: (cmd_numeric) Ditto.
5627 (cmd_leave) Ditto. Set `init', `reinit' members.
5629 * recode.c: (cmd_recode) Don't need to call envector().
5631 * repeat.c: (internal_cmd_do_repeat) Ditto.
5633 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
5634 (force_create_variable) Removed prototype.
5635 (force_dup_variable) Ditto.
5637 * vector.c: (cmd_vector) Don't need to call envector().
5639 * vfm.c: (reinit_sysmis) Removed.
5640 (reinit_blanks) Removed.
5641 (init_zero) Removed.
5642 (init_blanks) Removed.
5643 (process_active_file_write_case) No need to deal with vectors.
5644 Call clear_temp_case().
5645 (vector_initialization) Rewrite to use `init', `reinit'.
5646 (close_active_file) No need to call vec_clear().
5647 (procedure_write_case) Call clear_temp_case().
5648 (clear_temp_case) New function.
5650 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
5652 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
5655 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
5657 Add auxiliary argument to procedure() interface. Associated small
5658 clean-ups of vfm interface.
5660 * Updated every caller of procedure() and process_active_file() to
5661 reflect modified interface. Simple, ordinary changes not listed
5664 * Updated every function that implements struct case_stream's
5665 `read' function to take a write_case_func and a write_case_data.
5666 Also updated every caller of write_case() to instead call them
5667 through these arguments. In some cases this meant that the extra
5668 args had to be threaded through a couple of extra levels. This
5669 wasn't difficult or interesting so the details won't be given.
5671 * data-list.c: (struct repeating_data_trns) Add members
5672 `write_case', `wc_data' as kluge.
5673 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
5675 (repeating_data_set_write_case) New function.
5677 * data-list.h: New file to declare repeating_data_trns_proc() and
5678 repeating_data_set_write_case().
5680 * inpt-pgm.c: (input_program_source_read) Call
5681 repeating_data_set_write_case() for all the REPEATING DATA
5682 transformations, so that they know where to send their cases.
5683 It's a big kluge. Also kluge in END CASE.
5684 (end_case_trns_proc) Never called anymore, but we still need it,
5687 * sort.c: (read_sort_output) Update to match struct case_stream
5690 * vfm.c: (struct write_case_data) New structure.
5691 (proc_func) Removed.
5692 (virt_proc_func) Removed.
5693 (begin_func) Removed.
5694 (virt_begin_func) Removed.
5696 (write_case) Removed.
5697 (procedure) Added an auxiliary parameter to each function pointer
5698 argument's prototype. Added an auxiliary data parameter.
5700 (process_active_file) Ditto.
5701 (process_active_file_write_case) Pass aux data along.
5702 (close_active_file) Ditto.
5703 (procedure_write_case) Ditto.
5704 (SPLIT_FILE_procfunc) Ditto.
5706 * vfm.h: (typedef write_case_data) New.
5707 (typedef write_case_func) New.
5708 (struct case_stream) Add parameters to `read' member prototype.
5710 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
5712 * t-test.q: Added calculations for independent samples. (But no Levene
5715 * Makefile.am: Moved q_sources_c into own variable
5717 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
5719 Miscellaneous cleanups.
5721 * Change unused to UNUSED in many source files to reflect modified
5722 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
5723 __CYGWIN32__, __unix__, and unix not to assume that they're
5724 defined to a nonzero value. Change use of __attribute__ to use
5725 NO_RETURN or PRINTF_FORMAT instead.
5727 * alloc.h: Move definitions for local_alloc(), local_free() here
5728 from ../pref.h.orig and simplify.
5730 * expr-evl.c: Instead of working differently based on PAGED_STACK,
5731 use a pool allocator unconditionally.
5732 (CHECK_STRING_SPACE) Removed.
5733 (ALLOC_STRING_SPACE) Removed.
5734 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
5737 * expr-opt.c: (dump_expression) Allocate string pool.
5739 * expr-prs.c: (expr_free) Free string pool.
5741 * pool.c: (pool_destroy) This pool must be removed from its
5742 parent's list of gizmos, not from its own. Use free_all_gizmos().
5743 (pool_clear) New function.
5744 (free_all_gizmos) New function.
5745 (pool_alloc) Use space in empty block after this one if any.
5746 (pool_release) Only empty out blocks, don't actually free() them.
5748 * print.c: Get rid of PAGED_STACK special case by always
5749 dynamically allocating line buffers.
5750 (struct print_trns) Always include the `line' member.
5751 (internal_cmd_print) Always initialize the `line' member.
5752 (alloc_line) Always allocate memory for `line'.
5753 (print_trns_proc) Always initialize buf from `line' member.
5754 (print_trns_free) Always free `line' memory.
5756 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
5759 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
5761 * flip.c: Fixed crash from FLIP when a numeric variable is
5762 specified on NEWNAMES and a large value is used, and a couple of
5763 other minor bugs besides.
5764 (struct varname) Make name a 9-character fixed-size array
5765 instead of a 1-character variable size array.
5766 (make_new_var) Allow digits in variable names.
5767 (flip_stream_write) Limit numeric values to 8 characters and
5768 format system missing and very large and small values more
5771 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
5773 * command.c: Fixed test on command return status for the correct
5774 value, which had been causing a crash under certain invalid input.
5776 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
5778 * t-test.q: Added calculations for the one sample variant of the T-TEST
5780 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
5782 * tab.c: (render_strip) Fix bug that sometimes caused joined text
5783 in joined cells to be rendered outside box boundaries.
5785 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
5787 * random.c (rng_create): Fixed seeding so that it gets reseeded after
5788 SET seed=xx has been called.
5790 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
5792 * random.c (rng_get_double): Fix always-returning-zero bug in my
5793 preferred way, and at the same time make sure rounding doesn't
5796 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
5798 * html.c: (change_attributes) Dead code, removed.
5799 (escape_string) Eliminate code to call change_attributes() that
5800 never actually called it.
5801 (output_tab_table) Get rid of dependence on tab_hit
5802 and struct tab_joined_cell's hit member, which are abominations.
5804 * tab.c: (tab_output_text) Don't call
5805 d->class->text_set_font_by_name if it's a null pointer.
5806 (macro UNROLL_LOOP) Eliminate.
5807 (macro UNROLL_3_LOOPS) Eliminate.
5808 (tabi_render) Rewrite not to use the above macros.
5810 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
5812 Start working on a new output driver system, one that doesn't suck
5813 so much, by adding a "device-independent" output driver. The idea
5814 is to write out only a single output stream, then use separate
5815 processes to translate them into whatever formats we want. This
5816 is similar to how "groff" works with its various output drivers
5817 (grops, grotty, grodvi, ...).
5819 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
5821 * list.q: (write_all_headers) Stub out devind class.
5823 (determine_layout) Ditto.
5826 * output.c: (outp_init) Add devind class.
5828 * devind.c: New file.
5830 * devind.h: New file.
5832 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
5834 * frequencies.q: (hash_value_alpha) Fixed up the previous change
5835 to use the proper string length.
5837 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5839 * Fixed bug where FREQ would crash on alpha values
5841 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
5843 * Removed bletcherous alloca() workarounds for AIX from top of
5844 many files. AIX can use the alternative alloca() implementation
5847 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
5849 * ascii.c: (ascii_option) Fix implementation of headers option.
5851 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
5853 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
5854 multiple blank lines into one.
5855 (struct ascii_driver_ext) Add squeeze_blank_lines option.
5856 (ascii_preopen_driver) Initialize squeeze_blank_lines.
5857 (static var option_tab) Add squeeze entry.
5858 (ascii_option) Set squeeze_blank_lines.
5859 (output_lines) Implement squeezing blank lines.
5861 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
5863 * Removed redundant code from output.h
5865 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
5867 Dictionary classes: each variable is "ordinary", "system", or
5870 * var.h: (enum dict_class) New enum.
5872 * vars-prs.c: (dict_class_from_id) New function.
5873 (dict_class_to_name) New function.
5875 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
5877 * var.h: (struct freq_tab_set) Removed (not used).
5879 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
5881 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
5883 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
5885 * stats.c: (hypercube) Rename pow4(). All references updated.
5887 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
5889 * rename-vars.c: (cmd_rename_variables) Rewritten.
5890 (compare_name) Removed.
5892 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
5894 var_set feature, and code taking advantage of it.
5896 * crosstabs.q: (static var var_dict) Removed.
5897 (static var variables) New variable.
5898 (static var variables_cnt) New variable.
5899 (cmd_crosstabs) Free variables instead of var_dict.
5900 (internal_cmd_crosstabs) Initialize and use variables,
5901 variables_cnt instead of var_dict.
5902 (free_var_dict) Removed.
5903 (crs_custom_tables) Use var_set instead of a copied dictionary.
5904 (crs_custom_variables) Set up variables, variables_cnt instead of
5906 [DEBUGGING] (debug_print) Ditto.
5908 * means.q: (mns_custom_tables) Use var_set instead of a copied
5911 * vars-prs.c: (parse_vs_variable) New function.
5912 (parse_dict_variable) Rewritten.
5913 (parse_variable) Rewritten.
5914 (parse_variables) Renamed parse_var_set_vars(), rewritten.
5915 (parse_variables) New function in terms of parse_var_set_vars().
5916 Now requires its first argument to be non-null. All references
5917 that passed a null pointer updated to pass default_dict instead.
5918 (macro id_dict) Removed.
5919 (parse_DATA_LIST_vars) Add assertions.
5920 (parse_mixed_vars) Ditto.
5921 (struct var_set) New structure.
5922 (var_set_get_cnt) New function.
5923 (var_set_get_var) New function.
5924 (var_set_lookup_var) New function.
5925 (var_set_destroy) New function.
5926 (dict_var_set_get_cnt) New function.
5927 (dict_var_set_get_var) New function.
5928 (dict_var_set_lookup_var) New function.
5929 (dict_var_set_destroy) New function.
5930 (var_set_create_from_dict) New function.
5931 (struct array_var_set) New structure.
5932 (array_var_set_get_cnt) New function.
5933 (array_var_set_get_var) New function.
5934 (array_var_set_lookup_var) New function.
5935 (array_var_set_destroy) New function.
5936 (var_set_create_from_array) New function.
5938 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
5939 instead of parse_variables(NULL, ...) in output code.
5941 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
5943 Change inp_init from a 2-bit vector to an ordinary array.
5944 Initialize it all in cmd_end_input_program() instead of in
5947 * inpt-pgm.c: (enum value_init_type) New enum.
5948 (global var inp_init) Change to `enum value_init_type *', make
5950 (inp_init_size) Removed.
5951 (inp_nval) Change to `size_t', make static.
5952 (cmd_input_program) Don't initialize inp_init or inp_init_size.
5953 (cmd_end_input_program) Initialize inp_init, inp_nval.
5954 (init_case) Rewrite.
5955 (clear_case) Rewrite.
5957 * inpt-pgm.h: Removed.
5959 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
5961 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
5962 Colin Plumb hash. It is simpler and should better resist
5964 (hsh_hash_string) Ditto.
5966 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
5968 * get.c: (export_write_case_func) Remove debug printing code.
5970 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
5972 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
5974 (save_write_case_func) Use &trns->h instead of cast.
5975 (cmd_export) Use &t->h instead of cast.
5977 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
5979 Moved vectors into the dictionary.
5981 * var.h: (struct vector) Moved here from vector.h. `index' member
5982 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
5985 * vector.h: Removed.
5987 * vector.c: (global var vec) Removed.
5988 (global var nvec) Removed.
5989 (cmd_vector) Rewritten.
5990 (find_vector) Removed.
5992 * dictionary.c: (dict_create_vector) New function.
5993 (dict_get_vector) New function, replaces reading global vec[]
5995 (dict_get_vector_cnt) New function, replaces reading global nvec
5997 (dict_lookup_vector) New function, replaces find_vector().
5998 (dict_clear_vectors) New function.
6000 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
6002 Start to move away from `struct variable' p `union' member to void
6005 * var.h: (struct variable) Add `aux' member.
6007 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
6009 Get rid of struct variable `foo' member.
6011 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
6013 (frq_custom_variables) Ditto.
6014 (frq_custom_grouped) Ditto.
6016 * get.c: (struct save_trns) Change `var' member from `int *' to
6017 `struct variable **'.
6018 (cmd_save_internal) Use aux instead of foo.
6019 (save_trns_proc) Use revised `var' member.
6020 (static var mtf_seq_no) Renamed mtf_seq_num.
6021 (static var mtf_seq_nums) New static var.
6022 (cmd_match_files) Initialize mtf_seq_nums.
6023 (mtf_free) Free mtf_seq_nums.
6024 (mtf_processing) Use mtf_seq_nums instead of foo.
6025 (mtf_merge_dictionary) No need to initialize mv->foo.
6026 (cmd_export) Use aux instead of foo. Use revised `var' member.
6027 (mns_custom_tables) Don't use foo to check for duplicates, that's
6028 what PV_NO_DUPLICATE is for.
6030 * var.h: (struct variable) Remove `foo' member.
6031 (struct frequencies_proc) New member.
6033 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
6035 Clean up COMPUTE and IF.
6037 * compute.c: More or less rewrite the darn thing.
6038 (struct compute_trns) Rename and reorder and add and delete
6040 (cmd_compute) Rewrite.
6041 (compute_num) Make conditional on test expression. Now used for
6042 both COMPUTE and IF.
6043 (compute_num_vec) Ditto.
6044 (compute_str) Ditto.
6045 (compute_str_vec) Ditto.
6048 (if_num_vec) Removed.
6050 (if_str_vec) Removed.
6051 (parse_target_expression) Renamed parse_rvalue_expression(),
6053 (new_trns) Renamed compute_trns_create(), rewritten.
6054 (delete_trns) Removed.
6055 (free_trns) Renamed compute_trns_free(), rewritten.
6056 (struct lvalue) New structure.
6057 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
6058 (lvalue_get_type) New function.
6059 (lvalue_is_vector) New function.
6060 (lvalue_finalize) New function.
6061 (lvalue_destroy) New function.
6063 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
6065 * command.def: Disallow MODIFY VARS in input mode, so that
6066 variables can't get dropped and confuse cmd_end_input_program()'s
6067 attempt to fill inp_init[].
6069 * modify-vars.c: (static var forward_positional_ordering) New
6071 (struct var_modification) Entirely changed.
6072 (rearrange_dict) Interface changed, rewritten.
6073 (cmd_modify_vars) Deal with modified struct var_modification, much
6075 (struct var_renaming) New structure.
6076 (compare_var_renaming_by_new_name) New function.
6077 (validate_var_modification) New function.
6079 * var.h: (struct modify_vars_proc) Removed.
6080 (struct variable) Removed member p.mfv.
6082 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
6084 Make EVALUATE a valid command whether we're debugging or not, so
6085 that `make check' can succeed regardless of whether debugging is
6088 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
6090 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
6092 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
6094 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
6095 statement by a simple if test.
6097 * dfm.c: (dfm_get_record) Add assertion.
6099 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
6101 For each file x.c, move #include "x.h" to the very top of the
6102 include list, to catch x.h failing to include the proper headers.
6104 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
6106 * algorithm.c: (find) New function.
6107 (remove_equal) New function.
6108 (set_difference) New function.
6109 (adjacent_find_equal) New function.
6110 [TEST_UNIQUE] Removed test case.
6111 (copy_if) Find end test.
6113 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
6115 * dictionary.c: (dict_get_case_weight) New convenience function.
6117 * aggregate.c: (accumulate_aggregate_info) Use
6118 dict_get_case_weight().
6120 * frequencies.q: (calc_general) Ditto.
6121 (calc_integer) Ditto.
6124 * t-test.q: (groups_calc) Ditto.
6127 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
6129 * glob.c: (global var default_dict) Change from `struct
6130 dictionary' to `struct dictionary *'. All references changed.
6131 (init_glob) Initialize default_dict with dict_create().
6133 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
6135 struct dictionary now made opaque. All related functions:
6137 * get.c: (rename_variables) Removed.
6138 (dict_delete_run) Removed.
6140 * temporary.c: (copy_variable) Removed.
6141 (new_dictionary) Removed.
6142 (save_dictionary) Removed.
6143 (restore_dictionary) Removed.
6144 (free_dictionary) Removed.
6146 * vars-atr.c: (clear_default_dict) Removed.
6147 (find_variable) Removed.
6148 (find_dict_variable) Removed.
6149 (create_variable) Removed.
6150 (delete_variable) Removed.
6151 (common_init_stuff) Removed.
6152 (init_variable) Removed. Updating of inp_init moved into
6153 cmd_end_input_program().
6154 (replace_variable) Removed.
6155 (rename_variable) Removed.
6156 (clear_variable) Removed.
6157 (dup_variable) Removed.
6159 * vars-prs.c: (is_varname) Removed.
6160 (is_dict_varname) Removed.
6161 (fill_all_vars) Removed.
6163 * vector.c: (find_vector) Removed.
6165 * weight.c: (stop_weighting) Removed.
6167 * dictionary.c: New file.
6168 (dict_create) New, replaces new_dictionary().
6169 (dict_clone) New, replaces save_dictionary() and
6170 restore_dictionary().
6171 (dict_clear) New, replaces clear_default_dict().
6172 (dict_destroy) New, replaces free_dictionary().
6173 (dict_get_var_cnt) New function, replaces references to
6175 (dict_get_var) New function, replaces references to dict->var[i].
6176 (dict_get_vars) New function, replaces fill_all_vars().
6177 (dict_create_var) New, replaces create_variable(). Interface
6178 drops `type' parameter, using a zero `width' to designate numeric.
6179 (dict_clone_var) New, replaces dup_variable().
6180 (dict_rename_var) New, replaces rename_variable().
6181 (dict_lookup_var) New, replaces find_variable(),
6182 find_dict_variable(), is_varname().
6183 (dict_contains_var) New function.
6184 (compare_variable_dblptrs) New function.
6185 (dict_delete_var) New function, replaces clear_variable().
6186 (dict_delete_vars) New function, replaces dict_delete_run().
6187 (dict_reorder_vars) New function.
6188 (dict_rename_vars) New function, replaces rename_variables().
6189 (dict_get_weight) New function, replaces reading dict->weight_var.
6190 (dict_set_weight) New function, replaces writing dict->weight_var
6191 or calling stop_weight(dict).
6192 (dict_get_filter) New function, replaces reading dict->filter_var.
6193 (dict_set_filter) New function, replaces writing dict->filter_var.
6194 (dict_get_case_limit) New function, replaces reading dict->N.
6195 (dict_set_case_limit) New function, replaces writing dict->N.
6196 (dict_get_value_cnt) New function, replaces reading dict->nval.
6197 (dict_compact_values) New function, replaces a loop that was
6198 replicated in several places.
6199 (dict_get_split_vars) New function, replaces reading dict->splits.
6200 (dict_get_split_cnt) New function, replaces reading
6202 (dict_set_split_vars) New function, replaces writing dict->splits.
6203 (dict_get_label) New function, replaces reading dict->label.
6204 (dict_set_label) New function, replaces writing dict->label.
6205 (dict_get_documents) New function, replaces reading
6207 (dict_set_documents) New function, replaces writing
6210 All references to above functions updated.
6212 * aggregate.c: (cmd_aggregate) Copy file label and documents from
6213 old dictionary to new by hand, because dict_create() can't do it
6214 itself. Use dict_set_documents(), dict_set_split_vars().
6216 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
6217 calling dict_destroy().
6219 * data-list.c: (dls_var_spec) Remove `type' member, replace by
6221 (fixed_parse_compatible) Some slightly nontrivial changes for
6223 (dump_fmt_list) Ditto.
6226 * file-type.c: (create_col_var) Ditto.
6228 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
6229 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
6230 (rename_variables) Use dict_rename_vars().
6231 (mtf_merge_dictionary) Use dict_get_documents(),
6232 dict_set_documents(), dict_compact_values().
6234 * pfm-read.c: (read_variables) Deal with changes to weighting.
6236 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
6237 is_varname() in output code.
6239 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
6240 other dictionary functions.
6242 * title.c: (add_document_line) Use dict_get_documents(),
6243 dict_set_documents().
6245 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
6246 reset default_handle by hand. dict_clear() will clear vectors so
6247 there's no need for that by hand.
6249 * vfm.c: (close_active_file) Move call to finish_compaction()
6250 earlier, so that we can do the compaction as a single step using
6251 dict_compact_values(). Use dict_clear_vectors().
6252 (finish_compaction) Use dict_delete_var(), dict_compact_values().
6254 Some functions don't have replacements:
6256 * vars-atr.c: (force_create_variable) Removed. All references
6257 updated to dict_create_var() followed by an assertion.
6258 (force_dup_variable) Removed. All references updated to
6259 dict_clone_var() followed by an assertion.
6261 * weight.c: (update_weighting) Removed. No longer necessary, so
6262 all references removed.
6264 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
6268 * aggregate.c: Eliminate separation of weighted and unweighted
6269 case. It made the code too obscure and I doubt it was actually
6270 faster. Instead, all code uses the "weighted" code, because
6271 that's a generalization of the "unweighted" code.
6274 (parse_aggregate_functions) No need to set FWEIGHT.
6275 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
6276 (dump_aggregate_info) Ditto.
6277 (initialize_aggregate_info) No need for special plain_function
6278 that gets rid of FWEIGHT option.
6280 * aggregate.c: Get rid of approximations.
6281 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
6283 (aggregate_single_case) Don't use approx_ne().
6285 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
6287 * ascii.c (ascii_line_width): Dead code, removed.
6289 * postscript.c (ps_line_width): Ditto.
6291 * q2c.c (xrealloc): Ditto.
6293 * count.c (internal_cmd_count): Ditto.
6295 * means.q (validate_dependent_endpoint): Ditto.
6297 * set.q: (cmd_gset) Ditto.
6299 * weight.c: [0] (weight_trns_proc) Ditto.
6301 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
6303 Make the code -Wmissing-prototypes clean.
6305 * Makefile.am (version.c): Add #include "version.h".
6307 * ascii.c: (ascii_open_global) Make static.
6308 (ascii_close_page) Ditto.
6309 (ascii_font_sizes) Ditto.
6310 (ascii_postopen_driver) Ditto.
6311 (ascii_close_driver) Ditto.
6312 (ascii_option) Ditto.
6313 (ascii_open_page) Ditto.
6314 (ascii_line_horz) Ditto.
6315 (ascii_line_vert) Ditto.
6316 (ascii_line_intersection) Ditto.
6318 (ascii_polyline_begin) Ditto.
6319 (ascii_polyline_point) Ditto.
6320 (ascii_polyline_end) Ditto.
6321 (ascii_text_set_font_by_name) Ditto.
6322 (ascii_text_set_font_by_position) Ditto.
6323 (ascii_text_set_font_by_family) Ditto.
6324 (ascii_text_get_font_name) Ditto.
6325 (ascii_text_get_font_family) Ditto.
6326 (ascii_text_set_size) Ditto.
6327 (ascii_text_get_size) Ditto.
6328 (ascii_text_metrics) Ditto.
6329 (ascii_text_draw) Ditto.
6330 (ascii_close_page) Ditto.
6332 * cmdline.h: New header for parse_command_line(). Used where
6335 * command.c: Move prototypes for cmd_*() functions to command.h.
6337 * command.h: Prototypes for cmd_*() functions moved here from
6340 * crosstabs.q: (gamma_int) Ditto.
6342 * file-handle.h: Add fh_init_files() prototype.
6344 * getline.c: (welcome) Ditto.
6346 * glob.h: New header for init_glob(). Used where appropriate.
6348 * hash.c: (comparison_helper) Ditto.
6350 * html.c: (html_open_global) Ditto.
6351 (html_close_global) Ditto.
6352 (html_preopen_driver) Ditto.
6353 (html_postopen_driver) Ditto.
6354 (html_close_driver) Ditto.
6355 (html_option) Ditto.
6356 (html_open_page) Ditto.
6357 (html_close_page) Ditto.
6358 (html_submit) Ditto.
6360 * inpt-pgm.c: (input_program_source_read) Ditto.
6362 * output.c: (find_defn_value) Ditto.
6363 (destroy_list) Ditto.
6365 * pfm-read.c: (read_int) Ditto.
6367 * postscript.c: (ps_open_global) Ditto.
6368 (ps_close_global) Ditto.
6369 (ps_font_sizes) Ditto.
6370 (ps_preopen_driver) Ditto.
6371 (ps_postopen_driver) Ditto.
6372 (ps_close_driver) Ditto.
6374 (ps_open_page) Ditto.
6375 (ps_close_page) Ditto.
6376 (ps_line_horz) Ditto.
6377 (ps_line_vert) Ditto.
6378 (ps_line_intersection) Ditto.
6380 (ps_polyline_begin) Ditto.
6381 (ps_polyline_point) Ditto.
6382 (ps_polyline_end) Ditto.
6383 (ps_text_set_font_by_name) Ditto.
6384 (ps_text_set_font_by_position) Ditto.
6385 (ps_text_set_font_family) Ditto.
6386 (ps_text_get_font_name) Ditto.
6387 (ps_text_get_font_family) Ditto.
6388 (ps_text_set_size) Ditto.
6389 (ps_text_get_size) Ditto.
6390 (ps_text_metrics) Ditto.
6391 (ps_text_draw) Ditto.
6393 * q2c.c: (finish_up) Ditto.
6402 (find_symbol) Ditto.
6405 (force_string) Ditto.
6407 (match_token) Ditto.
6410 (parse_setting) Ditto.
6411 (parse_specifier) Ditto.
6412 (parse_specifiers) Ditto.
6413 (parse_subcommand) Ditto.
6414 (dump_specifier_vars) Ditto.
6416 (make_identifier) Ditto.
6417 (dump_declarations) Ditto.
6418 (dump_specifier_init) Ditto.
6419 (dump_vars_init) Ditto.
6421 (dump_specifier_parse) Ditto.
6422 (dump_subcommand) Ditto.
6423 (dump_parser) Ditto.
6424 (dump_header) Ditto.
6426 (recognize_directive) Ditto.
6428 * recode.c: (string_to_long) Ditto.
6430 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
6432 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
6435 * sort.c: (sort_stream_read) Ditto.
6436 (sort_stream_mode) Ditto.
6438 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
6440 * algorithm.c (binary_search): Fix comparison.
6442 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
6444 * algorithm.c: (binary_search) Fix assertion.
6446 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
6448 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
6450 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
6452 * sort.c: (compare_case_lists) Rewrite.
6454 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
6456 * quicksort.c: Removed (not used).
6458 * quicksort.h: Removed (not used).
6460 * sort.c: Removed blp_quicksort() prototype.
6462 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
6464 * postscript.c: (int_2_compare) Rewrite.
6465 (compare_line) Rewrite.
6467 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
6469 * matrix-data.c (compare_factors) Use lexicographical_compare()
6471 (compare_doubles) New function.
6473 * algorithm.c: (lexicographical_compare) New algorithm.
6475 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
6477 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
6479 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
6481 * expr-prs.c: (cmp_func) Removed.
6482 (parse_function) Use binary_search() algorithm.
6483 (compare_functions) New function.
6484 (init_func_tab) Use sort() algorithm.
6486 * algorithm.c: (binary_search) New algorithm.
6488 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
6490 * descript.q: (display) Use sort() algorithm instead of qsort().
6491 (compare_func) Removed.
6492 (descriptives_compare_variables) New function.
6494 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
6496 Get rid of AVL trees. Hashes are more appropriate for everything
6499 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
6505 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
6507 Much code can be clarified by using C++ STL-like algorithms. Not
6508 all uses of these algorithms are listed below, only the ones where
6509 the change to an algorithm was the only change of interest.
6511 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
6513 * algorithm.c: New file.
6515 * algorithm.h: New file.
6517 * modify-vars.c: (static var forward) Removed.
6518 (static var positional) Removed.
6519 (compare_variables) Removed.
6520 (struct ordering) New.
6521 (cmd_modify_vars) Use sort() algorithm.
6522 (compare_variables_given_ordering) New function.
6523 (rearrange_dict) Use sort() algorithm.
6525 * sysfile-info.c: (cmd_display) Use sort() algorithm.
6526 (cmp_var_by_name) Removed.
6528 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
6530 Make file handles use a hash table.
6532 * file-handle.q: (files) Change to hash table, make static.
6533 (cmd_file_handle) Use hash table functions.
6534 (fh_get_handle_by_filename) Ditto.
6535 (fh_get_handle_by_name) Ditto.
6536 (hash_file_handle) New function.
6537 (cmp_file_handle) Rewrite.
6538 (fh_init_files) Use hash table functions.
6540 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
6542 Clean up FREQUENCIES.
6544 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
6546 * frequencies.q: Remove a lot of old #if'd out code at the end.
6547 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
6548 or calc_weight(). Initialize percentile_values.
6549 (calc) New function based on calc_weight() from frequencies.g.
6550 (precalc) Use hash functions.
6551 (static var comparison_func) Removed.
6552 (static var comparison_param) Removed.
6553 (comparison_helper) Removed.
6554 (get_freq_comparator) New function.
6555 (not_missing) New function.
6557 (postprocess_freq_tab) Use hash table functions, algorithms,
6558 get_freq_comparator(). Rewrite.
6559 (cleanup_freq_tab) Rephrase.
6560 (add_percentile) Clean up spacing.
6561 (hash_value_numeric) New function.
6562 (hash_value_alpha) New function.
6563 (compare_value_numeric_a) Rewrite.
6564 (compare_value_alpha_a) Rewrite.
6565 (compare_value_numeric_d) Rewrite.
6566 (compare_value_alpha_d) Rewrite.
6567 (compare_freq_numeric_a) Rewrite.
6568 (compare_freq_alpha_a) Rewrite.
6569 (compare_freq_numeric_d) Rewrite.
6570 (compare_freq_alpha_d) Rewrite.
6571 (calc_stats) Clean up mode, percentiles, max.
6572 (dump_statistics) Clean up spacing.
6574 * frequencies.g: Removed.
6576 * var.h: (struct freq_tab) Change `data' to hash table.
6578 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
6580 * file-handle.h: Remove declaration of global variable `files',
6581 which wasn't used anywhere.
6583 * postscript.c: (add_encoding) Remove superfluous cast.
6586 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
6589 * temporary.c: [0] (display_tree) Removed.
6591 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
6593 Implement a new random number generator based on the alleged RC4
6596 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
6599 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
6600 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
6602 (static var V[]) Removed.
6603 (static var Y) Removed.
6604 (static var X2) Removed.
6605 (setup_randomize) Removed.
6607 (rand_uniform) Removed.
6608 (rand_normal) Removed.
6609 (struct rng) New structure.
6610 (rng_create) New function.
6611 (rng_destroy) New function.
6612 (swap_byte) New static function.
6613 (rng_seed) New function.
6614 (rng_get_bytes) New function.
6615 (rng_get_int) New function.
6616 (rng_get_unsigned) New function.
6617 (rng_get_double) New function.
6618 (rng_get_double_normal) New function.
6619 (pspp_rng) New function.
6621 * random.h: Sync up to random.c.
6623 * sample.c: (struct sample_trns) Make `frac' unsigned and a
6624 fraction of UINT_MAX, not 65536.
6625 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
6628 * vfm.c: (open_active_file) No need to call setup_randomize() any
6631 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
6633 Change dictionary name indexes to use hash tables instead of AVL
6636 * crosstabs.q: (free_var_dict) Use hash tables.
6637 (crs_custom_tables) Ditto.
6638 (calc_general) Ditto.
6639 (compare_table_entry) Rewrite.
6640 (enum_var_values) Reorder parameters. All references updated.
6643 * get.c: (rename_variable) Use hash tables.
6644 (mtf_merge_dictionary) Ditto.
6646 * glob.c: (init_glob) Use hash tables.
6647 (cmp_variable) Removed.
6649 * means.q: (mns_custom_tables) Use hash tables.
6651 * modify-vars.c: (rearrange_dict) Use hash tables.
6653 * rename-vars.c: (cmd_rename_variables) Use hash tables.
6655 * sfm-read.c: (read_header) Use hash tables.
6656 (read_variables) Ditto.
6658 * temporary.c: (new_dictionary) Use hash tables.
6659 (save_dictionary) Ditto.
6660 (restore_dictionary) Ditto.
6662 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
6663 hash table `name_tab'.
6665 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
6666 [DEBUGGING] (dump_var_tree) Removed.
6667 (find_variable) Use hash tables.
6668 (find_dict_variable) Ditto.
6669 (common_init_stuff) Ditto.
6670 (rename_variable) Ditto.
6671 (clear_variable) Ditto. Also, remove debug code.
6672 (dup_variable) Use hash tables.
6674 * vars-prs.c: (fill_all_vars) Use hash tables.
6675 (is_dict_varname) Ditto.
6676 (parse_dict_variable) Ditto.
6678 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
6680 Change value labels to use hash tables instead of AVL trees, and
6681 change value labels into an ADT.
6683 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
6685 * value-labels.c: New file.
6687 * value-labels.h: New file.
6689 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
6690 Get rid of a stupid use of goto.
6692 * autorecode.c: (compare_alpha_value) Rewrite.
6693 (hash_alpha_value) Ditto.
6694 (compare_numeric_value) Rewrite.
6695 (hash_numeric_value) Ditto.
6697 * frequencies.q: (dump_full) Use value label ADT.
6699 * pfm-read.c: (read_value_label) Use value label ADT.
6701 * pfm-write.c: (write_value_labels) Use value label ADT.
6703 * sfm-read.c: (read_variables) Use value label ADT.
6704 (read_value_labels) Rewrite.
6706 * sfm-write.c: (write_value_labels) Rewrite.
6708 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
6709 (display_variables) Ditto.
6710 (describe_variable) Ditto.
6712 * t-test.q: (print_t_groups) Use value label ADT.
6714 * temporary.c: (copy_variable) Use value label ADT.
6715 (free_dictionary) Ditto.
6717 * val-labs.c: (verify_val_labs) Use value label ADT.
6719 (debug_print) Ditto.
6720 (val_lab_cmp) Removed.
6721 (inc_ref_count) Removed.
6722 (copy_value_labels) Removed.
6724 * var.h: (struct value_label) Removed.
6725 (struct variable) Change AVL tree `val_lab' into hash table
6728 * vars-atr.c: (init_variable) Use value label ADT.
6729 (clear_variable) Ditto.
6730 (free_value_label) Removed.
6731 (free_val_lab) Removed.
6732 (get_val_lab) Removed.
6733 (compare_variables) New function.
6734 (hash_variable) New function.
6736 * vfm.c: (dump_splits) Use value label ADT.
6738 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
6740 Add to the hash table interface.
6742 * hash.c: (hsh_hash_bytes) Add assertion.
6743 (hsh_hash_string) Ditto.
6747 (hsh_create) Ditto. Also make minimum `size'.
6748 (hsh_destroy) Rephrase.
6749 (sort_nulls_last) Removed.
6750 (not_null) New function.
6752 (comparison_helper) Ditto.
6753 (hsh_sort) Rewritten.
6754 (hsh_data_copy) New function.
6755 (hsh_sort_copy) Ditto.
6757 (hsh_replace) Ditto.
6758 (hsh_hash_double) Ditto.
6759 (hsh_delete) Fix stupid bug.
6761 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
6762 * added a calculation of the mode to FREQUENCIES
6764 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
6766 * moved (un)defs of DEBUGGING to config.h
6768 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
6770 * groff-font.c: (add_kern) Fix indentation.
6771 (add_kern) Use & instead of % to take power-of-2 modulus.
6772 (font_get_kern_adjust) Likewise.
6774 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
6776 * autorecode.c: (recode) Replace stupid use of memcpy() by
6778 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
6779 (hash_numeric_value) Ditto.
6780 (autorecode_proc_func) pool_strdup() was wrong here because the
6781 source string was not null-terminated. Use new pool_strndup()
6784 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
6785 use of hsh_iterator_init().
6787 * data-in.c: (parse_N) Initialize i->v->f.
6789 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
6792 * groff-font.c: Use power-of-2 hash table sizes, not prime.
6793 (groff_read_font) Don't call hsh_next_prime(). Don't call
6795 (static var hash) Remove `size_p', `max_used' members.
6796 (font_char_name_to_index) Don't call hsh_next_prime(). Use
6797 hsh_hash_string() instead of hashpjw(), & instead of %.
6798 (default_font) Don't call hsh_next_prime().
6800 * pool.c: (pool_strndup) New function.
6801 (pool_strdup) Reimplement in terms of pool_strndup.
6803 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
6805 (hash_ps_encoding) Use hsh_hash_string().
6806 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
6807 (hash_filename2font) Use hsh_hash_string().
6809 * som.c: Add #include <stdlib.h>.
6811 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
6812 (by destroying its pool).
6814 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
6816 Miscellaneous hash table code cleanup:
6818 * hash.h: (struct hsh_table) Moved into hash.c.
6819 (hsh_count) Ditto, and transformed into function.
6820 (hsh_compare_func) New typedef, used for defining otherwise-long
6821 function types here and in hash.c
6822 (hsh_hash_func) Ditto.
6823 (hsh_free_func) Ditto.
6825 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
6826 `table' to `entries'. Removed `mp'. All references updated.
6827 (hsh_clear) Don't shrink entries array; if the hash was this big
6828 once, it probably will be again.
6829 (hsh_rehash) Made static.
6830 (force_hsh_insert) Renamed hsh_force_insert.
6831 (force_hsh_find) Renamed hsh_force_find.
6833 Made hash table sizes powers of 2, because that's fine with any
6834 reasonable hash function and because taking a power-of-2 modulus
6835 is faster than any other:
6837 (hsh_prime_tab) Removed;
6838 (hsh_next_prime) Ditto.
6839 (next_power_of_2) New function.
6840 (hsh_create) Use next_power_of_2.
6841 (hsh_rehash) Use & instead of %.
6843 Cleaned up hsh_sort:
6845 (internal_comparison_fn) Removed.
6846 (sort_nulls_last) New function.
6847 (hsh_sort) Removed second parameter, switched to using the new
6848 quicksort() function from quicksort.h to avoid using nasty need
6849 for static variables with qsort(). All references updated.
6851 Changed the hash functions offered, because there are better hash
6852 functions than the ones we had, and cleaned up the names to boot:
6854 * hash.c: (hashpjw_d) Removed.
6856 (hsh_hash_bytes) New function.
6857 (hsh_hash_string) New function.
6858 (hsh_hash_int) New function.
6860 Improved the hash table iteration interface:
6862 * hash.h: (hsh_iterator_init) Removed.
6863 (struct hsh_iterator) Removed `init' member, change `next' to
6866 * hash.c: (hsh_foreach) Removed. All references updated to use
6867 hsh_first/hsh_next instead.
6868 (hsh_first) New function. Notably, unlike hsh_foreach() it does
6869 not treat a null pointer as an empty hash table.
6870 (hsh_next) New function.
6872 Made deletion possible, though slow:
6874 * hash.c: (locate_matching_entry) New function.
6875 (hsh_find) Use locate_matching_entry().
6876 (hsh_delete) New function also using locate_matching_entry().
6877 (hsh_force_delete) New function.
6879 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
6881 * quicksort.c: New file implementing a sort routine with a
6882 interface better than qsort() because it passes a user-provided
6883 parameter to the sort routine.
6885 * Makefile.am: Add quicksort.c, quicksort.h.
6887 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
6889 * All source files: Get rid of nasty special cases for Checker,
6890 which is pretty obsolete now.
6892 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
6894 * Fixed a bug apparent when using the FREQUENCIES command with the
6895 html driver. The html driver was incorrectly trying to display
6898 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
6900 * Makefile.am: Reorganized. Put locale dir in version.c instead
6901 of passing it to each compile command. Only put local gmp libs in
6902 LD_ADD if not installed on system. Remove `boast' target.
6904 * All source files: struct and union typedefs eliminated.
6905 `sizeof type' replaced by `sizeof object' where practical. Moved
6906 `unused' qualifiers from start to end of declarations for gcc
6907 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
6908 assertions on pointers strictly compliant. Removed _ prefixes on
6909 some function parameter names.
6911 * alloc.c: New source file, containing these external linkage
6912 functions removed from common.c: xmalloc, xcalloc, xrealloc,
6919 * ascii.c: Migrated from arenas to pools.
6920 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
6921 c_string to len_string. All references changed.
6922 (ascii_option) Signature changed to comply to new output.c
6924 (count_fancy_chars) Removed.
6925 (delineate) Removed support for rich text.
6926 (ascii_text_metrics) Ditto.
6928 (output_shorts) Change `box', `off', `on' from c_string to
6929 len_string. Change `remaining' from int to size_t.
6930 (ascii_close_page) Make page numbering less haphazard.
6932 * autorecode.c: Migrate from arenas to pools.
6934 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
6936 * bitvector.h: New file containing these macros from misc.h:
6937 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
6939 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
6940 word[3]. ncmd removed.
6941 (var empty_string) Removed.
6942 (var cmd_table) Declaration updated.
6943 (var cmdtab) Removed.
6944 (cmp_command) Removed.
6945 (split_words) Rewritten to use strtok_r().
6946 (init_cmd_parser) Renamed cmd_init(). Rewritten.
6947 (find_command) Removed.
6948 (FILE_TYPE_okay) Rewritten.
6949 (cmd_parse) Rewritten. Semantics of the return value of command
6950 handlers has changed: they must now return one of the new CMD_*
6951 enumerals, rather than a magic value. This meant that all
6952 commands had to be modified, and they were.
6953 (figure_out_command) New function.
6955 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
6956 #defines for INIT, INPU, etc.
6958 * command.h: New CMD_* enum series.
6959 (cur_proc) Make const char *, not char *.
6960 (cmd_init) Prototype.
6963 * common.c: Removed.
6965 * common.h: Removed.
6967 * correlations.q: New file.
6969 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
6971 (custom_tables) Renamed crs_custom_tables().
6972 (custom_variables) Renamed crs_custom_variables().
6973 (calc_integer) Add in some `const' qualifiers.
6974 (table_value_missing) Change from a_string to len_string.
6975 (float_M_suffix) Change from a_string to len_string.
6977 * data-in.c: Rewritten. All references to
6978 parse_string_as_format() changed to data_in().
6980 * data-in.h: New file.
6982 * data-list.c: Change DLS_* from #define's to enums. Move from
6983 rpd_msg() to tmsg().
6984 (RPD_ERR) New #define.
6985 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
6987 (read_from_data_list_fixed) Change from old
6988 parse_string_as_format() to new data_in().
6989 (read_from_data_list_free) Ditto.
6990 (read_from_data_list_list) Ditto.
6991 (cmd_repeating_data) Modify approach to checking for end of
6994 (rpd_parse_record) Change from old parse_string_as_format() to new
6995 data_in(). Change from old convert_format_to_string() to new
6997 (read_one_set_of_repetitions) Change dfm_push_cust() to
6998 dfm_push(), pop_cust() to dfm_pop().
7000 * data-out.c: Rewritten. All references to
7001 convert_format_to_string() changed to data_out().
7003 * descript.q: Migrate to new q2c.
7004 (cmd_descriptives) Removed.
7005 (internal_cmd_descriptives) Renamed cmd_descriptives ().
7006 (custom_variables) Renamed dsc_custom_variables().
7008 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
7010 (open_file_r) Initialize h->where.line_number. Migrate to new
7012 (open_file_w) Initialize h->where.line_number.
7013 (read_record) Change from ext->ln to h->where.line_number.
7014 Migrate to struct string.
7015 (dfm_put_record) Rephrased.
7016 (dfm_push_cust) Renamed dfm_push(), rewritten.
7017 (dfm_pop) New function.
7019 * error.c: All references updated.
7020 (glob var error_count) Renamed err_err_count.
7021 (glob var warning_count) Renamed err_warning_count.
7022 (glob var error_already_flagged) Renamed err_already_flagged.
7023 (glob var verbosity) Renamed err_verbosity.
7024 (glob var cust_fn) Removed.
7025 (glob var cust_ln) Removed.
7026 (static var file_loc) New.
7027 (static var nfile_loc) New.
7028 (static var mfile_loc) New.
7029 (tmsg) New function.
7030 (push_cust) Removed.
7033 (static var terminating) Removed.
7034 (failure) Renamed err_failure().
7035 (hcf) Renamed err_hcf().
7036 (err_push_file_locator) New function.
7037 (err_pop_file_locator) New function.
7038 (err_location) New function.
7039 (check_error_count) Renamed err_check_count().
7040 (vmsg) Renamed err_vmsg(). Interface changed.
7041 (verbose_msg) Removed.
7042 (err_cond_fail) New function.
7043 (error_break) Renamed err_break().
7045 * error.h: All references updated.
7046 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
7047 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
7049 (struct file_locator) New.
7051 (macro verbose_msg) Removed.
7052 (macro cond_fail) Removed.
7054 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
7056 * expr-prs.c: Reorganized. All references updated.
7057 (exprtypename) Renamed expr_type_name().
7058 (typename) Renamed type_name().
7059 (free_expression) Renamed expr_free().
7060 (parse_expression) Renamed expr_parse(). Uses new type_check()
7062 (init_functab) Renamed init_func_tab().
7063 (type_check) New function.
7064 (parse_or) Rewritten to use new allocate_nonterminal() and
7065 append_nonterminal_arg() functions.
7068 (parse_rel) Ditto. Also simplified logic.
7073 (SYSMIS_func) Ditto.
7074 (VALUE_func) Rephrased.
7075 (CONCAT_func) Fix memory leak by replacing free by free_node on
7077 (generic_str_func) Ditto.
7078 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
7080 (allocate_nonterminal) New function.
7081 (append_nonterminal_arg) New function.
7082 (static func_tab[]) Now at file level.
7084 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
7086 * expr.h: (enum series OP_*) Moved to exprP.h.
7087 (OP_* defines) Ditto.
7088 (struct op_desc) Ditto.
7089 (global ops[]) Ditto.
7090 (struct num_con_node) Ditto.
7091 (struct str_con_node) Ditto.
7092 (struct var_node) Ditto.
7093 (struct lag_node) Ditto.
7094 (struct casenum_node) Ditto.
7095 (struct nonterm_node) Ditto.
7096 (union any_node) Members renamed.
7097 (struct sys_node) Removed.
7098 (struct val_node) Removed.
7099 (operator typedef) Removed.
7100 (typedef exprtype) Removed.
7101 (enum series EX_*) Moved to exprP.h.
7102 (struct expression) Ditto. Also renamed a lot of the members.
7103 (PXP_* defines) Changed to enums.
7104 (free_node prototype) Moved to exprP.h.
7106 * file-handle.h: (struct file_handle) New member `where'.
7108 * file-handle.q: Migrated to new q2c format.
7109 (prepend_current_directory) Removed (dead code).
7110 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
7111 (fh_get_handle_by_filename) Removed dead code.
7112 Set new `where' member.
7114 * file-type.c: (file_type_source_read) References to
7115 parse_string_as_format() changed to data_in().
7116 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
7118 * filename.c: All references updated.
7119 (init_filename) Renamed fn_init().
7120 (expand_line) Removed.
7121 (macro EXPAND_LINE) Removed.
7122 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
7123 of custom functions.
7124 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
7125 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
7126 (normalize_filename) Renamed fn_normalize().
7127 (search_path) Renamed fn_search_path(), rewritten.
7128 (prepend_dir) Renamed fn_prepend_dir().
7129 (blp_getenv) Renamed fn_getenv().
7130 (blp_dirname) Renamed fn_dirname().
7131 (fn_basename) New function, not used.
7132 (absolute_filename_p) Renamed fn_absolute_p().
7133 (is_special_filename) Renamed fn_special_p().
7134 (file_exists) Renamed fn_exists_p().
7135 (readlink_malloc) Renamed fn_readlink().
7136 (getenv_default) Renamed fn_getenv_default().
7137 (open_file) Renamed fn_open().
7138 (close_file) Renamed fn_close().
7139 (open_file_ext) Renamed fn_open_ext().
7140 (close_file_ext) Renamed fn_close_ext().
7142 * font.h: Migrate from arenas to pools.
7144 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
7146 * frequencies.g: Migrate from arenas to pools.
7148 * frequencies.q: Migrate to new q2c version. Migrate from arenas
7151 * getline.c: All references updated.
7152 (global getl_buf) Changed from char * to struct string.
7153 (static getl_include_path) Ditto.
7154 (global getl_buf_len) Removed.
7155 (global getl_buf_size) Removed.
7156 (getl_include_path) Deal with new getl_buf, getl_include_path.
7157 (getl_uninitialize) New function.
7158 (getl_get_current_directory) Rewritten.
7159 (getl_clear_include_path) Rewritten.
7160 (getl_add_include_dir) Rewritten.
7161 (getl_add_file) Assertion fixed.
7162 (getl_add_virtual_file) Change initial value of `remaining_loops'
7164 (welcome) Rewritten.
7165 (handle_line_buffer) Make static. Change logic to make
7166 getl_add_virtual_file() change sensible. Use ds_*() strings.
7167 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
7168 (getl_close_file) Moved.
7169 (getl_location) New function.
7171 * getline.h: All references updated.
7172 (macro curln) Removed.
7173 (macro curfn) Removed.
7174 (macro am_interactive) Renamed getl_am_interactive.
7175 (macro am_reading_script) Renamed getl_reading_script.
7177 * glob.c: (global fmt_parse_ignore_error) Removed.
7178 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
7179 systems that support it (C99). Turn off SET ECHO by default. No
7180 necessary julcal initialization anymore.
7182 * groff-font.c: Migrate from arenas to pools.
7183 (groff_read_font) Use err_push_file_locator().
7184 (groff_read_DESC) Ditto.
7185 (font_msg) Use tmsg().
7187 * hash.c: (hsh_sort) Fix debug code.
7188 [GLOBAL_DEBUGGING] Include stdio.h.
7190 * hash.h: (macro force_hsh_insert) Rephrase.
7192 * heap.c: Rewritten.
7194 * heap.h: Rewritten.
7196 * html.c: (html_option) Change from outp_value to struct string.
7197 (postopen) Change from curfn to getl_location().
7198 (escape_string) Remove rich-text code. Signature changed.
7199 (output_tab_table) Switch from a_string to struct len_string.
7200 Remove rich text support.
7202 * lexer.c: All references updated. Largely rewritten. Major
7203 changes listed below. Removed tagged quote support. Adapted to
7204 struct string tokstr.
7205 (global tokstr) Changed to struct string.
7206 (global tokstr_size) Removed.
7207 (global tokstr_len) Removed.
7209 (global tokint) Removed.
7210 (global toklongstr) Removed.
7211 (C* defines) Removed.
7212 (static tbl[]) Removed.
7213 (static id[]) Removed.
7214 (static une[]) Removed.
7215 (discard_line) Renamed lex_discard_line().
7216 (get_entire_line) Renamed lex_entire_line().
7217 (get_rest_of_line) Renamed lex_rest_of_line().
7218 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
7219 (make_hexit) Removed.
7220 (syntax_error) Renamed lex_error(). Return value removed.
7221 (get_token_representation) Renamed lex_token_representation().
7222 (putback) Renamed lex_put_back().
7223 (putfwd) Renamed lex_put_forward().
7224 (convert_negative_to_dash) Renamed lex_negative_to_dash().
7225 (set_prog) Renamed lex_set_prog().
7226 (init_lex) Renamed lex_init().
7227 (reset_eof) Renamed lex_reset_eof().
7228 (lookahead) Renamed lex_look_ahead().
7229 (check_id) Rewritten.
7230 (yylex) Renamed lex_get(), rewritten.
7231 (lex_end_of_command) New function. Many commands were rephrased
7233 (lex_integer_p) New function. Replaces compare of tokint against
7235 (lex_integer) New function. Replaces tokint.
7236 (match_tok) Renamed lex_match().
7237 (match_id) Renamed lex_match_id().
7238 (match_int) Renamed lex_match_int().
7239 (force_match_id) Renamed lex_force_match_id(), added return value.
7240 (force_match) Renamed lex_force_match(), added return value.
7241 (force_string) Renamed lex_force_string(), added return value.
7242 (force_int) Renamed lex_force_int(), added return value.
7243 (lex_id_match_len) New function.
7244 (id_match) Renamed lex_id_match(), rewritten.
7245 (get_line) Renamed lex_get_line().
7246 (preprocess_line) Renamed lex_preprocess_line().
7247 (tokname) Renamed lex_token_name().
7248 (bin_value_func) Removed.
7249 (oct_value_func) Removed.
7250 (hex_value_func) Removed.
7251 (unexpected_eof) New function.
7252 (convert_numeric_string_to_char_string) New function.
7253 (parse_string) Rewritten, signature changed.
7254 (add_tokstr_char) Removed.
7255 (add_tokstr_unsigned) Removed.
7256 (add_tokstr_string) Removed.
7257 (parse_tagged_quote) Removed.
7258 (skip_comment) Renamed lex_skip_comment().
7260 * lexer.h: All references updated.
7261 (macro is_id1) Renamed CHAR_IS_ID1.
7262 (macro is_idn) Renamed CHAR_IS_IDN.
7263 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
7264 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
7265 (macro get_token) Removed.
7266 (macro id_match) Removed.
7267 (macro force_match_id) Removed.
7268 (macro force_match) Removed.
7269 (macro force_string) Removed.
7270 (macro force_int) Removed.
7271 (macro force_num) Removed.
7272 (macro force_id) Removed.
7274 * lexerP.h: Removed.
7276 * list.q: Migrated to new q2c format.
7277 (write_line) Deal with struct len_string.
7278 (write_varname) Ditto.
7279 (write_fallback_headers) Ditto.
7281 * magic.c: New file, incorporating the following global variables
7282 previously in other files: endian, second_lowest_value. And both
7283 of those are conditional on #define's.
7285 * magic.h: New file, incorporating the following global variable
7286 declarations: endian, second_lowest_value, and the following macro
7287 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
7289 * main.c: Added declarations of pgmname, finished, curdate,
7291 (main) Call new parse_script() function.
7292 (parse_script) New function.
7293 (execute_command) New function.
7294 (dump_token) Removed.
7295 (handle_error) New function.
7297 * matrix.c: New file.
7299 * matrix.h: New file.
7301 * matrix-data.c: Migrated from arenas to pools.
7302 (mget_token) Change from parse_string_as_format() to data_in().
7304 * means.q: Migrate to new q2c.
7305 (custom_tables) Renamed mns_custom_tables().
7306 (custom_crossbreak) Renamed mns_custom_crossbreak().
7307 (custom_variables) Renamed mns_custom_variables().
7309 * mis-val.c: (static var width) Changed from `int' to `size_t'.
7310 (parse_varnames) Prototype.
7311 (parse_numeric) Rephrasings.
7312 (parse_alpha) Adapt to new struct string tokstr.
7314 * misc.c: (intlog10) Rewritten.
7316 (ansi_rand) Renamed real_rand(), moved into random.c.
7317 (ansi_srand) Renamed real_srand(), moved into random.c.
7318 (setup_randomize) Moved to random.c.
7319 (rand_uniform) Ditto.
7320 (rand_normal) Ditto.
7321 (rand_simple) Ditto.
7322 (get_config_line) Removed.
7323 (reverse) Removed (dead code).
7325 * misc.h: (macro SET_BIT) Moved to bitvector.h.
7326 (macro CLEAR_BIT) Ditto.
7327 (macro TEST_BIT) Ditto.
7328 (macro SET_BIT_TO) Ditto.
7329 (macro BIT_INDEX) Ditto.
7331 * output.c: (outp_read_devices) Move to err_push_file_locator()
7332 from push_cust(). Use struct string.
7333 (expand_op_tokstr) Removed.
7334 (static var op_tokstr) Changed to struct string.
7335 (static var op_tokstr_size) Removed.
7336 (tokener) Rephrasings. Use struct string.
7337 (parse_options) Use struct string.
7338 (destroy_driver) Fix assertion.
7339 (outp_get_paper_size) Move to err_push_file_locator().
7340 [0] Removed dead code.
7341 (outp_string_width) Move to len_string.
7343 * output.h: Comment fixes.
7344 (TAG_* enum series) Removed.
7345 (struct outp_value) Removed.
7346 (enum OUTP_T_FANCY) Removed.
7347 (struct outp_text) `s' changed from a_string to len_string.
7348 (struct outp_class) `option' change arg 3 from outp_value to
7351 * pfm-read.c: (corrupt_msg) Rewritten.
7353 * pfm-write.c: (bufwrite) Fix assertion.
7355 * pool.c: New file, reference version.
7357 * pool.h: New file, reference version.
7359 * postscript.c: (ps_font_sizes) Fix assertion.
7360 (ps_option) Change arg 3 from outp_value to struct string.
7361 Adapt to struct string.
7362 (macro output_line) Removed.
7363 (macro add_string) Removed.
7364 (output_encodings) Adapted to struct string. Moved to
7365 err_push_file_locator().
7366 (find_encoding_file) Fix assertion.
7367 (read_ps_encodings) Move to err_push_file_locator().
7368 (postopen) Use getl_location() instead of curfn.
7369 (out_text_plain) Move to len_string.
7370 (text) Ditto. Remove rich text support.
7372 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
7373 (cmd_print_eject) Ditto.
7375 (internal_cmd_print) Now cleans up after itself. Uses
7376 fh_parse_file_handle() now.
7377 (cmd_print_space) Use PXP_NUMERIC to type-check.
7379 * q2c.c: Overhauled. Removed _("") i18n support. All references
7380 updated. All output functions updated to handle structures rather
7381 than local or static variables. Adapt to new PSPP lex_*()
7385 (macro MAX_N_SBC) Removed.
7386 (global bare) Removed.
7387 (enum STRING) Renamed T_STRING.
7388 (enum ID) Renamed T_ID.
7389 (get_buffer) Buffer size increased.
7390 (strlower) Renamed st_lower(), rephrased.
7391 (strupper) Renamed st_upper(), rephrased.
7392 (skip_ws) New function.
7393 (get_line) Don't special-case any types of lines (like those
7394 beginning with ! or $, for instance).
7395 (get_token) Renamed lex_get(). Rephrased.
7396 (static var `prefix') New.
7397 (parse) New function.
7398 (parse_setting) Minor rephrasing.
7399 (dump_specifier_vars) Ditto.
7400 (make_identifier) Put null terminator on identifier, duh.
7401 (dump_vars) Renamed dump_declarations(). Never indent. Never
7402 static. Output changed entirely.
7403 (dump_specifier_init) Rephrase.
7404 (dump_vars_init) No index variable needed. Other modifications.
7405 (dump_parser) Don't parse command name. Do dump functions instead
7406 of just code fragments.
7407 (dump_free) Dump function instead of code fragment.
7408 (recognize_directive) New function.
7409 (main) Use recognize_directive(). Don't rely on magic $ line
7410 beginning: instead, parse comments. Update list of headers.
7412 * random.c: New file, containing the following functions:
7413 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
7414 rand_normal, rand_simple.
7416 * random.h: New file.
7418 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
7419 function. `max_src_width', `max_dst_width' changed to size_t.
7420 (internal_cmd_recode) Removed.
7421 (parse_dest_spec) Merge similar cases.
7422 (parse_src_spec) Add assertion.
7424 * repeat.c: (recognize_keyword) New function.
7425 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
7426 REPEAT. Improve recognition of END REPEAT (use
7427 recognize_keyword()). Move from curfn to getl_location(). Use
7430 (perform_DO_REPEAT_substitutions) Adapt to struct string.
7432 * set.q: Adapt to new q2c.
7433 (cmd_set) Range-check some values better.
7434 (custom_blanks) Renamed stc_custom_blanks().
7435 (custom_length) Renamed stc_custom_length().
7436 (custom_results) Renamed stc_custom_results().
7437 (custom_seed) Renamed stc_custom_seed().
7438 (custom_width) Renamed stc_custom_width().
7439 (custom_format) Renamed stc_custom_format().
7440 (custom_journal) Renamed stc_custom_journal().
7441 (custom_color) Renamed stc_custom_color().
7442 (custom_listing) Renamed stc_custom_listing().
7443 (custom_disk) Renamed stc_custom_disk().
7444 (custom_log) Renamed stc_custom_log().
7445 (custom_rcolor) Renamed stc_custom_rcolor().
7446 (custom_viewlength) Renamed stc_custom_viewlength().
7447 (custom_workdev) Renamed stc_custom_workdev().
7449 * settings.h: Not necessary to include format.h any longer.
7451 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
7452 (corrupt_msg) Rewritten.
7454 * sort.c: Adapt to rewritten heap ADT.
7456 * str.c: (aa_strcpy) Removed.
7457 (ab_strcpy) Removed.
7458 (ac_strcpy) Removed.
7459 (ba_strcpy) Removed.
7460 (bb_strcpy) Removed.
7461 (ca_strcpy) Removed.
7462 (aa_strdup) Removed.
7463 (aa_strdupcpy) Removed.
7464 (ba_strdup) Removed.
7465 (sa_strdup) Removed.
7466 (memrev) Renamed mm_reverse().
7467 (memrmem) Renamed mm_find_reverse().
7468 (cmp_str) Renamed st_compare_pad().
7469 (strmaxcpy) Removed.
7470 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
7471 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
7473 (strpadcpy) Renamed st_pad_copy(), signature changed.
7474 (blpstrset) Removed.
7475 (ds_create) New function.
7476 (ds_init) New function.
7477 (ds_replace) New function.
7478 (ds_destroy) New function.
7479 (ds_clear) New function.
7480 (ds_extend) New function.
7481 (ds_shrink) New function.
7482 (ds_truncate) New function.
7483 (ds_length) New function.
7484 (ds_size) New function.
7485 (ds_value) New function.
7486 (ds_end) New function.
7487 (ds_concat) New function.
7488 (ds_concat_buffer) New function.
7489 (ds_printf) New function.
7490 (ds_putchar) New function.
7491 (ds_getline) New function.
7492 (ds_get_config_line) New function derived from the old
7493 misc.c:get_config_line().
7494 (ls_create) New function.
7495 (ls_create_buffer) New function.
7496 (ls_init) New function.
7497 (ls_shallow_copy) New function.
7498 (ls_destroy) New function.
7499 (ls_null) New function.
7500 (ls_null_p) New function.
7501 (ls_empty_p) New function.
7502 (ls_length) New function.
7503 (ls_value) New function.
7504 (ls_end) New function.
7506 * str.h: Reformatted.
7507 (struct a_string) Removed.
7508 (struct b_string) Removed.
7509 (struct c_string) Removed.
7510 (struct len_string) New.
7511 (struct string) New.
7512 (macro as_streq) Removed.
7513 (macro bs_streq) Removed.
7514 (macro cs_streq) Removed.
7515 (macro sa_streq) Removed.
7516 (macro sb_streq) Removed.
7517 [__GNUC__] (inline function ds_putchar) New function.
7518 [__GNUC__] (inline function ds_length) New function.
7519 [__GNUC__] (inline function ds_value) New function.
7520 [__GNUC__] (inline function ds_end) New function.
7522 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
7523 (display_vectors) Fix missing i18n.
7525 * t-test.q: Migrate to new q2c.
7527 * tab.c: Migrate from arenas to pools.
7528 (tab_create) Use struct len_string.
7529 (tab_realloc) Ditto.
7530 (text_format) Ditto.
7531 (tab_joint_text) Ditto.
7532 (tab_natural_width) Remove rich text support.
7533 (tab_natural_height) Ditto.
7534 (tab_output_text) Handle TAT_FIX.
7535 (tab_raw) Change arg from a_string to len_string.
7536 (tabi_driver) Fix assertion. Use struct len_string.
7537 (render_strip) Use struct len_string. Remove rich text support.
7538 Add `const' qualifiers.
7540 * tab.h: (enum TAB_RICH) Remove.
7541 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
7542 SOM_COL_* updated to read TAB_COL_*.
7543 (struct tab_table) Change arena to pool. Change a_string to
7546 * temporary.c: (restore_dictionary) Rewrite Checker code.
7548 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
7549 LOWEST, HIGHEST) Moved here from common.h.
7550 (typedef any_trns) Removed. All references changed to `struct
7553 * vars-atr.c: (force_create_variable) Fix assertion.
7554 (force_dup_variable) Fix assertion.
7556 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
7558 Using alphanumeric variables in functions under AGGREGATE
7559 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
7560 <BZN-mdksh@t-online.de> for reporting this bug.
7562 * aggregate.c: (parse_aggregate_functions) When setting the
7563 FSTRING bit, also allocate memory for the `string' member of
7565 (free_aggregate_functions) Free iter->string. Don't use the
7566 non-function bits when indexing the array of functions.
7567 [DEBUGGING] (debug_print) Don't use the non-function bits when
7568 indexing the array of functions.
7570 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
7572 Under certain circumstances, the final case would be omitted from
7573 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
7574 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7576 * aggregate.c (agr_00x_end_func): Increment number of cases in
7577 sink before writing case. For streams that keep track of how many
7578 cases there are based on this value, this means that the last case
7579 will be read in on the next stream read.
7581 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
7583 Undefined behavior was invoked by referencing a freed pointer.
7585 * vfm.c (memory_stream_write): Free pointer *after* checking for
7588 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
7590 A wrong record size was displayed when paging the active file to
7593 * vfm.c: (memory_stream_write) Fix off-by-one error.
7595 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
7597 Not having enough temporary space for sorting caused a core dump.
7600 * sort.c: (allocate_cases) Initialize i.
7602 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
7604 Syntax errors in function descriptions on AGGREGATE caused core
7607 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
7608 free_aggregate_functions(), since that function already frees
7611 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
7613 A null pointer was dereferenced, causing a core dump, when
7614 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
7615 but PSPP still doesn't calculate percentiles. Thanks to Regnor
7616 Jernsletten <rjernsle@eunet.no> for reporting this problem.
7618 * arena.c: (arena_malloc) If the arena hasn't been initialized
7619 already, initialize it.
7621 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
7623 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
7624 for compilation with Cygnus Windows B20. Not used by other
7627 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
7629 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
7630 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7632 * sort.c: (compare_case_lists) Reverse sense of comparison if
7633 sorting in descending order.
7634 (compare_record) Ditto.
7636 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
7638 SPLIT FILE with a string variable caused a core dump. Fixed.
7640 * vfm.c: If the variable is a string then make a temporary value
7641 struct pointing to it. The underlying problem is a lot bigger
7642 than this (see TODO) but this is a stopgap for the simple case at
7645 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
7647 Nested INCLUDEs didn't work. Fixed.
7649 * getline.c: (getl_include) Set first_line to NULL in allocated
7652 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
7654 The MATCH FILES procedure set the values of variables not present
7655 to 0. It should have been SYSMIS. This is now fixed.
7657 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
7659 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
7661 The REMARK command was too aggressive about skipping lines. It
7662 didn't like being the last command in a file.
7664 * command.c: (cmd_remark) Call get_entire_line() instead of
7667 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
7669 Comment parsing wasn't consistent with the rest of the code in its
7670 idea of where one command ends and another starts. This meant
7671 that sometimes commands would be mysteriously ignored. Thanks to
7672 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7674 * command.c: (parse_cmd) Hand off comment parsing to new function
7675 skip_comment() in lexer.c.
7676 * lexer.c: (skip_comment) New function.
7678 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
7680 The TABLE subcommand on MATCH FILES worked only erratically at
7681 best. This fixes it. Thanks to Dr. Dirk Melcher
7682 <BZN-mdksh@t-online.de> for reporting this bug.
7684 * get.c: (mtf_compare_BY_values) When comparing string values, a
7685 difference of 1 is still a difference :-)
7686 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
7687 advance TABLE files automatically when matched. Comment fixes.
7689 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
7691 VARIABLE LABELS rejected a slash before the first variable
7692 specification, contradicting the documentation. Thanks to Walter
7693 M. Gray <graywm@northernc.on.ca> for reporting this bug.
7695 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
7696 command specification.
7698 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
7700 Because of an incorrect optimization in memory allocation,
7701 CROSSTABS sometimes segfaulted when asked to output multiple
7702 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7705 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
7706 are passed to output_pivot_table() for its use.
7707 (output_pivot_table) Instead of assuming the number of columns is
7708 constant, keep track with maxcols. In general mode, use maxcells
7709 to determine whether more matrix cells need to be allocated.
7711 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
7713 CROSSTABS didn't display value labels for column and row
7714 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7717 * crosstabs.q: (table_value_missing) If the specified value has a
7718 value label for this variable, then show it instead of the raw
7720 (display_dimensions) Delegate display of value_labels to
7721 table_value_missing.
7723 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
7725 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
7726 <BZN-mdksh@t-online.de> for reporting this bug.
7728 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
7729 if the file isn't declared as binary.
7731 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
7733 MATCH FILES corrupted memory and dumped core on some syntax
7736 * get.c: (cmd_match_files) Set file->handle to NULL before
7738 (mtf_free_file) Don't free a null dictionary.
7740 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
7742 MATCH FILES should set numeric values not available to the
7743 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
7744 <BZN-mdksh@t-online.de> for reporting this bug.
7746 * get.c: (mtf_processing) Set unused records to system-missing,
7749 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
7751 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
7752 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
7754 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
7755 in newly created dictionary, and add each copied variable to the
7758 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
7762 * get.c: (trim_dictionary) Free variable list for KEEP after
7765 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
7767 Some systems didn't like the way open_file was coded. Thanks to
7768 Hankin <hankin@rogue.consultco.com> for pointing this out.
7770 * filename.c: (open_file) Don't try to store stdin, stdout,
7771 stderr as part of an array, because that doesn't always work.
7773 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
7775 The SAVE procedure didn't save long string variables properly.
7776 Fixed by this patch. Thanks to Hankin
7777 <hankin@rogue.consultco.com> for this patch.
7779 * sfm-write.c: (write_variable) Fix off-by-one error in writing
7780 out variable pad records.
7782 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
7784 Previously, if PRINT SPACE were given a negative argument, it
7785 would report an error, then spin in an (almost) infinite loop.
7786 This fixes that behavior.
7788 * print.c: (print_space_trns_proc) After reporting a negative
7789 argument, set number of lines to print to 1.
7791 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
7793 SPSS 8.0 outputs some new record types in its system files, and it
7794 allows longer value labels. Accept these system files.
7796 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
7797 11 emitted by SPSS 8.0.
7799 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
7801 The LIST procedure was too conservative in allocating space for
7802 buffers, which caused a bug that only showed up with very long
7803 output variables. Thanks to Hankin <hankin@dunno.com> for this
7806 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
7808 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
7810 Typo meant string format specifiers weren't checked properly. I
7811 think that Hankin <hankin@dunno.com> sent me this report, but I'm
7812 willing to be corrected on this point.
7814 * format.c: (check_string_specifier) Fix obvious typo.
7816 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
7818 Using $CASENUM in an expression didn't work. Here's a fix.
7819 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
7822 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
7824 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
7826 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
7828 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
7829 other behavior, *sigh*. This patch hopefully fixes that. This
7830 time I've actually tested it.
7832 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
7834 * data-list.c: (read_from_data_list_free,
7835 read_from_data_list_list) Call parse_string_as_format() directly
7836 without mucking around with the field width.
7838 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
7840 Occasionally, you may encounter a script that wants to be
7841 interpreted in interactive mode. Make -i emulate this behavior to
7842 allow such scripts to be executed with PSPP.
7844 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
7846 * cmdline.c: (pre_syntax_message[]) Update -i description.
7848 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
7849 when -i is given on the command line) don't treat unindented lines
7850 as starting a new command.
7852 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
7854 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
7855 mostly caused by local initialized aggregates. After egcs is
7856 fixed upstream these can be removed, but for now they're not a big
7859 * ascii.c: (ascii_postopen_driver) Checker chokes on local
7860 initialized arrays. Avoid this.
7862 * sfm-write.c: (sfm_write_dictionary) Don't use a local
7865 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
7867 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
7868 following changes avoid. Currently I compile sources with egcs
7869 1.1.1 and gcc 2.7.2.3 before sending them out.
7871 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
7873 * ascii.c: (option_tab[]) Initialize all struct members.
7875 * avl.h: (avl_traverser_init) New macro.
7877 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
7880 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
7883 * hash.c: Comment fix.
7885 * hash.h: (hsh_iterator_init) New macro.
7887 * html.c: (option_tab[]) Initialize all struct members.
7889 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
7892 * postscript.c: (option_tab[]) Initialize all struct members.
7893 (output_encodings, preclose, dump_lines) Use new
7894 hsh_iterator_init() macro.
7896 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
7899 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
7902 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
7904 * data-in.c: Examined each of the parsing functions to make sure
7905 that they wouldn't dump core if they were passed a string of the
7906 wrong length, since now the DATA LIST FREE/LIST routines don't
7907 check for field width before passing it to the data parser.
7908 (parse_RBHEX, parse_AHEX) Reject odd length input.
7909 (parse_string_as_format) Reject input that's too short or too
7912 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
7913 a field to its entire declared output width then pass it to the
7914 data-in parsing routines. This contradicted the documented
7915 behavior. This is fixed in these changes. Thanks to Mark H. Wood
7916 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
7917 free-format parsing that differed from SPSS.
7918 (cut_field) Commas and spaces are treated identically. Returns
7919 the proper column instead of a fixed 1 value.
7920 (parse_field) Removed.
7921 (read_from_data_list_free, read_from_data_list_list) Call
7922 parse_string_as_format directly instead of parse_field.
7924 * heap.c: (heap_delete) Stylistic fixes.
7926 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
7928 * loop.c: (loop_2_trns_proc) Formatting fix.
7930 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
7932 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
7934 * vfm.c: (macro FILTERED) New.
7935 (static var filter_var) New.
7936 (process_active_file_write_case) Use FILTERED.
7937 (setup_filter) Set filter_var.
7938 (close_active_file) Delete the filter if not
7939 FILTER_before_TEMPORARY.
7940 (procedure_write_case) Use FILTERED.
7942 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
7944 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
7946 * data-in.c: (parse_day_count) Message fix.
7947 (parse_month) Style fix.
7949 * data-list.c: (struct data_list_pgm) New member eof.
7950 (cmd_data_list) Init eof to 0.
7951 (do_reading) Implement the /END subcommand and read-past-eof
7954 * do-if.c: Include stdio.h when debugging.
7955 (cmd_else_if) Make sure the command is .-terminated.
7957 * glob.c: (init_glob) Capitalize the command prompt.
7959 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
7960 (end_file_trns_proc) Debugging message.
7962 * loop.c: (internal_cmd_loop) Make it work when there's no loop
7964 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
7966 * main.c: (dump_token) Make kwtab[] const.
7968 * set.q: Spelling, comment fixes.
7970 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
7973 * vars-prs.c: (fill_all_vars) Style fix.
7975 * vfm.c: (index_to_varname) Return const.
7977 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
7979 * Changes in many source files for partial -ansi -pedantic and
7980 no-debugging compliance: Remove trailing common in enum
7981 declarations; add `unused' attributes; insert some appropriate
7984 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
7986 * command.c: (shell) Make static.
7987 (run_command) Make static.
7989 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
7991 * dfm.c: (cmd_begin_data) I18n fix.
7993 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
7995 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
7997 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
8000 * file-handle.q: Don't prepend the source file directory name to
8001 the data file name. (Ongoing issue.)
8002 (prepend_current_directory) Comment out.
8003 (internal_cmd_file_handle) Don't call prepend_current_directory().
8004 (fh_get_handle_by_filename) Ditto.
8006 * filename.c: Append zero byte to readlink() return value.
8008 * getline.c: (getl_read_line) I18n fix.
8010 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
8012 * misc.h: Don't use gcc features if __STRICT_ANSI__.
8014 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
8017 * postscript.c: (output_encodings) Don't use local_strdup().
8020 * print.c: Don't use gcc features if __STRICT_ANSI__.
8022 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
8024 * recode.c: (parse_src_spec) Fully brace nested if's.
8026 * set.q: (global var set_testing_mode) New var.
8028 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
8030 * ascii.c: Add some more `unused' attributes that only come into
8031 play when NDEBUG is defined.
8032 (ascii_close_page) Set s_len when reallocating s.
8034 * crosstabs.q: (delete_missing) New function.
8035 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
8036 (make_summary_table) Create summary table reallocable.
8038 * postscript.c: Add more `unused' attributes as above.
8040 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
8041 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
8043 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
8046 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
8047 gratuitous space between parameter definition.
8049 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
8050 complaints about running off the end of functions with NDEBUG
8053 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
8055 * Several source files: Removed some PORTME notes when reflection
8056 revealed that ANSI forbids that sort of breakage. Also, added
8057 lots of `unused' qualifiers here and there.
8059 * aggregate.c: (accumulate_aggregate_info) Remove local var
8060 weighting that turned out not to be used.
8062 * avl.c: Update to version 1.1.0. Add unused specifier.
8063 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
8065 (avl_probe) Replace some instances of 1 with +1 where appropriate.
8066 (avl_find) Cast return value to void *.
8067 (avl_delete) q doesn't need to be initialized at the beginning of
8068 the function. Replace some instances of 1 with +1.
8069 (force_avl_delete) Renamed avl_force_delete, all references changed.
8070 (compare_ints) `param' marked unused.
8071 (print_int) `param' marked unused.
8072 (recurse_tree) Replace some instances of 1 with +1.
8074 * avl.h: Update to version 1.1.0. Only declares avl function
8075 types if not already declared.
8076 (AVL_MAX_HEIGHT) Only define if not already defined.
8077 (struct avl_node) New unused member char pad[2].
8078 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
8079 (force_avl_insert) Renamed avl_force_insert.
8080 (force_avl_delete) Renamed avl_force_delete.
8082 * crosstabs.q: (struct table_entry) Put `freq' into a union with
8084 (struct crosstab) Add new member `ofs'.
8085 (glob var int_tab) Removed.
8086 (custom_tables) In integer mode, assign v[i] properly through the
8088 (custom_variables) Now p.crs.max == max + 1.
8089 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
8090 (precalc) Implement integer mode.
8091 (calc_integer) Implement integer mode.
8092 (compare_table_entry) Remove unused local variable `comparing'.
8093 (make_summary_table) Implement integer mode.
8094 (macro ns_rows) Implemented as static variable now.
8095 (several variables) Made static, from global.
8096 (output_pivot_table) Use table_value_missing() for column heads.
8097 Remove several unused local variables. Implement integer mode
8098 table summing. Count up ns_rows.
8099 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
8100 (find_pivot_extent) Moved into find_pivot_extent_general; now just
8101 calls that function or find_pivot_extent_integer.
8102 (find_pivot_extent_integer) New function.
8103 (enum_var_values) Implemented for integer mode.
8104 (table_value_missing) New function.
8105 (display_dimensions) Call table_value_missing() for heads.
8106 (float_M_suffix) New function.
8107 (display_crosstabulation) Call table_value_missing() for row
8108 heads. Handle missing values in /MISSING=REPORT mode.
8109 (calc_fisher) Remove unused var N.
8110 (calc_r) Remove unused var fact.
8112 * data-list.c: (dump_fixed_table) Fix table dimensioning.
8113 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
8115 * data-out.c: (insert_commas) Remove unused var cp.
8116 (convert_CCx) Remove unused vars save_set_decimal,
8119 * descript.q: (dump_z_table) Fix table dimensioning.
8120 (pre_calc) Remove unused var j.
8121 (display) Remove unused vars title, s. Fix table dimensioning.
8123 * expr-evl.c: Comment fixes.
8125 * frequencies.q: (full_dim) New function.
8126 (dump_full) Fix table dimensioning.
8127 (condensed_dim) New function.
8128 (dump_condensed) Fix table dimensioning.
8130 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
8133 * html.c: (html_close_drive) Remove unused var i.
8134 (postopen) Remove unused vars title, curfn_len, cp.
8135 (preclose) Remove unused vars this, x.
8137 * lexer.c: Comment fixes.
8139 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
8141 * means.q: (custom_tables) Remove unused var m_dim.
8143 * mis-val.c: Format fix.
8145 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
8147 * output.c: (outp_get_paper_size) Remove unused var cp.
8149 * pfm-read.c: (read_float) Remove unused var save, unused label
8151 (read_variables) Remove unused vars cp, j.
8152 (read_value_label) Remove unused var j.
8154 * pfm-write.c: (bufwrite) Remove unused var i.
8156 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
8158 (output_encodings) Remove unused vars char_cp, n_output.
8159 (read_ps_encodings) Remove unused var ep.
8160 (postopen) Remove unused var title.
8161 (preclose) Remove unused var fp.
8162 (ps_open_page) Remove unused vars true, false, orientation,
8163 mirror_horz, mirror_vert, width, length.
8164 (ps_text_metrics) Remove unused var x.
8166 * q2c.c: (find_symbol) Remove unused var y.
8167 (parse_setting) Remove unused parameter sbc, all references
8169 (dump_parser) Remove unused var cp.
8170 (dump_free) Remove unused var i.
8172 * set.q: (static vars args, n) Removed.
8173 (internal_cmd_gset) Removed.
8175 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
8176 (read_machine_flt64_info) Removed unused var file_endian.
8177 (read_documents) Removed unused var i.
8178 (read_compressed_data) Removed unused parameter dict, all
8181 * sfm-write.c: (bufwrite) Removed unused var i.
8182 (sfm_write_case) Removed unused var i.
8184 * sort.c: (merge_once) Remove unused var t.
8185 (write_separate) #if 0 out as dead code.
8187 * split-file.c: (cmd_split_file) Remove unused var i.
8189 * sysfile-info.c: (sysfile_info_dim) New function.
8190 (cmd_sysfile_info) Fix table dimensioning.
8191 (variables_dim) New function.
8192 (display_variables) Fix table dimensioning.
8193 (describe_variable) Remove unused var prev_r.
8195 * t-test.q: (z_postcalc) Removed.
8196 (pairs_calc) Remove unused var bad_weight.
8197 (postcalc) Remove unused vars dfn, dfd.
8199 * tab.c: (tab_create) Set t->dim to NULL.
8200 (tab_dim) Make sure t->dim is NULL first.
8201 (tab_natural_width) Remove parameter `clamp'.
8202 (tab_value) Remove duplicate assertion for table.
8203 (tab_raw) New function.
8204 (nowrap_dim) New function.
8205 (wrap_dim) New function.
8206 (tab_output_text) Fix table dimensioning.
8208 * tab.h: (tab_raw) New macro.
8210 * val-labs.c: (get_label) Remove unused var type.
8211 (copy_value_labels) Remove unused var trav.
8213 * var.h: (struct crosstab_proc) Completely changed.
8215 * vars-prs.c: (parse_dict_variable) Remove unused var v.
8217 * vfm.c: (open_active_file) Remove unused vars i, lp.
8219 * weight.c: (weight_trns_proc) #if 0 out as dead code.
8221 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
8223 * Makefile.am: Add apply-dict.c, flip.c.
8225 * apply-dict.c: New file.
8227 * command.c: (struct command) Make cmd[] larger for CLEAR
8228 TRANSFORMATIONS command name.
8229 (parse_cmd) Make sure we're in a valid state before using it as an
8230 index. Discard variables and reset state on invalid transitions.
8231 (cmd_clear_transformations) New function.
8233 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
8234 Add unimplemented PRESERVE, RESTORE.
8236 * file-handle.h: Include stddef.h.
8240 * pfm-read.c: (parse_value) Pad value label values with spaces,
8243 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
8244 (sfm_close) Decrement reference count, make sure it's zero.
8245 (sfm_maybe_close) New function.
8246 (sfm_read_dictionary) Handle reference counts.
8248 * vars-atr.c: (clear_default_dict) New function.
8249 (discard_variables) Use clear_default_dict().
8251 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
8253 * Makefile.am: Add pfm-write.c.
8254 (LDADD) Add the libgmp2 libraries.
8256 * command.def: Define EXPORT.
8258 * get.c: (cmd_export) New function.
8259 (export_write_case_func) New function.
8261 * pfm-read.c: (static spss2ascii[]) Make it const.
8263 * pfm-write.c: New file.
8265 * sfm-write.c: Formatting, comment fixes.
8267 * var.h: Comment fix.
8269 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
8271 * Makefile.am: Add pfm.h, pfm-read.c.
8273 * command.def: IMPORT is now implemented.
8275 * format.c: (glob var translate_fmt[]) New var.
8277 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
8278 (cmd_import) New function.
8279 (import_source_read) New function.
8280 (glob var import_source) New var.
8282 * pfm-read.c: New file.
8286 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
8288 (dump_dictionary) Disabled printing a couple of items.
8290 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
8292 * crosstabs.q: (postcalc) Call make_summary_table().
8293 (make_summary_table) New function.
8294 (insert_summary) New function.
8295 (display_dimensions) Remove some unnecessary arguments, all
8297 (output_pivot_table) Fix lots of problems with the risk table
8299 (submit) Don't display an empty table.
8300 (display_risk) Fix order of arguments to calc_risk().
8302 * glob.c: Always include assert.h and stdlib.h.
8304 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
8307 * tab.c: (tab_create) Cosmetic changes.
8309 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
8311 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
8315 * crosstabs.q: (output_pivot_table) Headers drawing and submission
8316 code simplified, moved into new function submit().
8317 (submit) New function.
8318 (crosstabs_dim) New function.
8319 (display_directional) Substitute variable names for %s where
8321 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
8322 (calc_symmetric) Initialize parameters only if non-NULL.
8323 Calculate Somers' d.
8324 (calc_directional) Calculate Somers' d (or copy it, really).
8327 * output.c: (outp_string_width) New function.
8329 * postscript.c: (postopen) Calculate font widths based on the
8330 width of the zero '0' character, not the width of the space
8331 character. Set paper-width and paper-length based on points, not
8333 (ps_open_page) Fix page setup string for landscape mode.
8335 * som.h: (struct som_dimension) Removed.
8336 (struct som_table_class) height, width members take int * not
8339 * tab.c: Many functions now have added parameter validation.
8340 (tab_height, tab_width) These functions were removed and merged
8341 into a single function tab_resize(), and all references changed.
8342 (tab_dim) Rewritten since the interface changed; reduced from
8343 hundreds of lines to two. All callers were changed. Currently
8344 most of them just use tab_natural_dimensions as their callback and
8345 await detailed translation of functionality.
8346 (tab_natural_width) New function.
8347 (tab_natural_height) New function.
8348 (tab_natural_dimensions) New function. This is a callback
8349 function, not something that you'd want to call directly.
8350 (tab_nat_dim) Removed.
8351 (tabi_table) Allocates t->w and t->h.
8352 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
8353 dimensions callback.
8354 (evaluate_dimensions) Removed.
8355 (sum_columns) Removed.
8357 * tab.h: (enum TAL_1THIN) Removed.
8358 (enum series t_*) Removed.
8359 (struct tab_table) Members trh, trv changed to unsigned char *
8360 from int *. Member dim changed to a function pointer from a
8361 unsigned char *. Member max_stack_height removed. New members
8363 (macros tab_l, tab_r, tab_t, tab_b) New.
8365 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
8367 * ascii.c: (delineate) Assign last_space_nchars before skipping
8368 spaces, to fix right justification.
8370 * crosstabs.q: (static vars risk, direct) New vars.
8371 (static var pearson_r) Removed.
8372 (glob var chisq_fisher) Made static.
8373 (static vars row_tot[], col_tot[]) Don't include grand total
8375 (static var grand_total) Renamed W, all references changed.
8376 (output_pivot_table) Only make `table' if num_cells != 0. Make
8377 risk and directional tables. Deal with grand total no longer part
8378 of col_tot[]. Free rows and cols after we're done with them.
8379 (display_risk) New function.
8380 (display_directional) New function.
8381 (clac_r) Rewritten so that it stores all its results into its
8382 arguments, so it can be used for Spearman's correlation too.
8383 (calc_symmetric) Added a t[] argument, all references changed.
8384 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
8385 Pearson's r, Cohen's kappa.
8386 (calc_risk) New function.
8387 (calc_directional) New function.
8389 * som.c: (som_submit) Improved debugging code.
8391 * stats.c: (hypercube) New function.
8392 (cube) New function.
8394 (normal_sig) Went back to old implementation, which actually
8397 * stats.h: (macros square, cube, hypercube) Removed. The
8398 equivalent functions in stats.c are inlined here; all references
8399 to square changed to sqr.
8401 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
8403 * crosstabs.q: (N_SYMMETRIC) New define.
8404 (postcalc) Disable debug printing.
8405 (static vars chisq_fisher, pearson_r) New.
8406 (output_pivot_table) Add support for symmetric measures. Add
8407 chi-square output of exact sigs.
8408 (display_chisq) Rewritten.
8409 (display_symmetric) New function.
8410 (gamma_int) New function.
8412 (swap) New function.
8413 (calc_fisher) New function.
8414 (calc_chisq) Check boundary conditions better. Calculate Yates,
8415 Fisher, Mantel-Haenszel tests.
8416 (calc_r) New function.
8417 (calc_symmetric) New function.
8419 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
8421 (chisq_sig) Better boundary conditions. Renamed from
8424 * tab.h: (struct tab_table) New member cf.
8426 * tab.c: (tab_create) Set cf.
8427 (tab_width) New function.
8428 (tab_realloc) Handle cf.
8429 (tab_vline) Handle cf.
8430 (tab_hline) Handle cf.
8431 (tab_box) Handle cf.
8432 (tab_value) Handle cf.
8433 (tab_float) Handle cf.
8434 (tab_text) Handle cf.
8435 (tab_joint_text) Handle cf.
8436 (tab_offset) Handle cf.
8437 (tab_next_row) Handle cf.
8438 (evaluate_dimensions) Handle cf.
8439 (render_strip) Handle cf.
8441 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
8443 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
8444 output_pivot_table().
8445 (output_pivot_table) Moved lots of local variables outside and
8446 made them static. Add beginnings of chi-square statistic
8447 support. Now column and row totals aren't in the main matrix.
8448 Always zero out any leftover rows & columns after we're done with
8449 the table entries. Move all output stuff into
8450 display_dimensions(), display_crosstabs(), display_chisq().
8451 (display_dimensions) New function.
8452 (display_crosstabulation) New function.
8453 (display_chisq) New function.
8454 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
8456 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
8457 references, simplify logic.
8459 * postscript.c: Remove scale, translate-x, translate-y,
8460 mirror-horz, mirror-vert, rotate-180 options.
8461 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
8462 All references deleted.
8463 (macro YT) New macro.
8464 (array option_tab[]) Removed options.
8465 (ps_option) Removed options.
8466 (ps_open_page) Write page setup explicitly to output file, without
8467 using now-deleted BP function.
8468 (macro dump_line) Use YT().
8469 (macro dump_thick_line) Use YT().
8470 (draw_headers) Use YT().
8471 (switch_font) Reorder arguments to SF function.
8472 (write_text) Use YT().
8474 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
8477 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
8479 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
8480 null-debugging code.
8481 (tab_realloc) Remove null-debugging code. Initialize new regions
8483 (tab_vline) Support offsets.
8484 (tab_hline) Support offsets.
8485 (tab_box) Support offsets.
8487 (tab_nulls) Removed.
8490 (evaluate_dimensions) Remove null-debugging code. Understand
8491 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
8492 TAB_EMPTY not present.
8494 * tab.h: New cell attribute TAB_EMPTY.
8495 (macros tab_nr, tab_nc, tab_row, tab_col) New.
8497 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
8498 try to read them from system files.
8500 * vfm.c: (dump_splits) Don't call tab_null().
8502 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
8504 * crosstabs.q: (struct crosstab) Added `missing' member.
8505 (custom_tables) Init missing.
8506 (calc_general) Handle missing values.
8507 (calc_chisq) New function.
8508 (output_pivot_table) Start work on chi-square output. Update for
8509 new tab offset support functions. Shorten statistic names.
8511 * Several files: add in more `const's to placate gcc's warnings.
8513 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
8516 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
8517 tab_null, tab_nulls, tab_value, tab_float, tab_text,
8518 tab_joint_text) Add col_ofs and row_ofs support.
8519 (tab_offset) New function.
8520 (tab_next_row) New function.
8521 (tab_row) New function.
8522 (tab_col) New function.
8523 (tabi_table) Add col_ofs and row_ofs support.
8525 * vars-atr.c: (is_system_missing) New function.
8527 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
8529 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
8530 (static var no_cells) Removed.
8531 (static var num_cells) New.
8532 (static var expected) New.
8533 (static var cells[]) New.
8534 (internal_cmd_crosstabs) Deal with new variables.
8535 (postcalc) Removed most of the meat and put it in new function
8536 output_pivot_table().
8537 (output_pivot_table) Calculates and outputs an entire pivot table.
8539 * postscript.c: (postopen) Fix problems with free()ing addresses
8540 not obtained from malloc().
8542 * som.c: (som_submit) Add assertion.
8544 * sysfile-info.c: (describe_variable) Use new tab_nulls()
8547 * tab.c: (static var tab_names[]) New.
8548 (tab_realloc) -1 for nc or nr indicates no change.
8549 (tab_nulls) New function.
8550 (tab_dim) Use tab_names[].
8551 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
8552 (evaluate_dimensions) Don't terminate on uninited cells, just put
8553 an X in them and emit a notice. Use tab_names[].
8555 * tab.h: Move bits into tab.def.
8557 * tab.def: New. Don't try to declare tab_table_class because then
8558 som.h has to be included.
8560 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
8562 * command.def: New file, contains all the command definitions
8563 previously included bodily in command.c.
8565 * format.def: New file, contains all of the format definitions
8566 previously split across format.h, format.c, and sfm-write.c.
8568 * lexer.h: Renamed from tokens.h in order to match corresponding
8571 * lexerP.h: Moved some rarely used functions exported by lexer.c
8574 * Makefile.am: Commemorate renamed files.
8575 (EXTRA_DIST) Add command.def, format.def.
8577 * command.c: [0] (walk_cmdtable_func) Removed.
8579 * crosstabs.q: (postcalc) Made it work and print out matrices
8581 (enum_column_values) Renamed enum_var_values, generalized for any
8584 * format.h: (struct fmt_desc) New member `spss'.
8586 * q2c.c: (main) Generated code includes lexer.h instead of
8589 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
8590 instead of an independent translation table.
8592 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
8594 * Lots of source files: Added const to declarations.
8596 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
8598 * arena.c: (arena_clear) Set prev pointer to null when done.
8600 * ascii.c: (ascii_option) Rename index as indx.
8602 * avl.c: This is now a separate library called libavl.
8603 (xmalloc) Make static.
8604 (avl_probe) Step A7 can use the cache instead of an explicit
8606 (avl_delete) Don't maintain a q pointer because it's always
8607 available in the pointer stack. Comment fix.
8609 * avl.h: This is now a separate library called libavl.
8611 * command.c: (cmd_table[]) Remove spurious trailing "".
8613 * common.h: Only include random() fix if this system needs it.
8615 * crosstabs.q: Include alloca headers.
8616 (n_sorted_tab) New global var.
8617 (postcalc) Mostly rewritten.
8618 (find_pivot_extent) Rewritten.
8619 (enum_column_values) Rewritten.
8621 * data-out.c: (convert_F) Rename inner n as n_spaces.
8623 * error.c: (dump_message) Don't have an outer var i.
8625 * file-handle.q: (static var f) Removed. All references removed.
8626 (internal_cmd_file_handle) Uses a local variable instead of f.
8628 * get.c: (trim_dictionary) Change scope of i, i1, i2.
8629 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
8632 * getline.h: Declare getl_history as extern. Reported by
8633 palme@uni-wuppertal.de (Hubert Palme).
8635 * postscript.c: (postopen) Some large mods for constness.
8637 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
8640 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
8642 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
8643 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
8646 * avl.c, avl.h: New files. These form a clean-room
8647 reimplementation of avllib. Iterative algorithms are used in
8648 place of recursive ones, so there is no resemblance in the code.
8650 * Lots of headers: Don't include other headers by default.
8652 * Lots of source files: Explicitly include all needed headers.
8654 * arena.c: (arena_clear) New function.
8656 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
8657 (static var ar) Removed.
8658 (staitc vars ar_tc, ar_col) New.
8659 (cmd_crosstabs) Destroy the arenas.
8660 (internal_cmd_crosstabs) Create the arenas.
8661 (precalc) Don't need a free function for the hash.
8662 (calc_general) Make sure to zero out the trailer on the key data
8664 (print_table_entries) Updated.
8665 (postcalc) Worked on actually implementing.
8666 (find_pivot_extent) New function.
8667 (compare_value) New function.
8668 (enum_column_values) New function.
8670 * data-in.c: (parse_month) Make local array `static const'.
8672 * data-out.c: (convert_date) Make local array `static const'.
8673 (convert_WKDAY) Same.
8674 (convert_MONTH) Same.
8676 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
8677 been renamed to avl_walk().
8679 * hash.c: Rewritten more efficiently.
8681 * hash.h: Add attribute const to hsh_next_prime declaration.
8683 * lexer.c: (id_match) Make arguments const.
8685 * postscript.c: (ps_postopen_driver) Make default fonts the
8688 * q2c.c: (main) Generated code needs stdlib.h.
8690 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
8691 initialized to 0 now, not to NULL. All other references to
8692 avl_traverser were updated in the same way.
8694 * tokens.h: Macro version of id_match updated to use const
8697 * val-labs.c: (inc_ref_count) New function.
8698 (copy_value_labels) Simply through use of new avl_copy() function.
8700 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
8702 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
8703 (postcalc) Worked on this.
8705 * postscript.c: (OPO_DOUBLE_LINE) New enum.
8706 (struct ps_driver_ext) New line_width_thick member.
8707 (ps_preopen_drive) Init line_width_thick.
8708 (option_tab[]) Add line-* options.
8709 (ps_option) Parse line-* options.
8710 (postopen) Add line_width_thick support. Strip leading spaces on
8711 prologue output lines.
8712 (ps_open_page) Include line_width_thick in output.
8713 (macro dump_thick_line) New.
8714 (dump_fancy_line) Support thick lines as well as double lines.
8716 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
8718 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
8719 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
8721 * Many source files: Rename `options' to `pv_opts' as appropriate.
8723 * command.c: (static var cmd_table[]) Add CROSSTABS command.
8725 * common.c: (xcalloc) New function.
8727 * crosstabs.q: New file. Not finished yet, though.
8729 * data-list.c: Comment fix.
8731 * error.c: Remove some old Checker cruft.
8733 * frequencies.q: (dump_full) Cumulate valid percent instead of
8736 * getline.c: Comment fix.
8738 * hash.c: Comment fixes.
8740 * hash.h: (struct hsh_table) Make hash functions return unsigned
8741 instead of int to avoid problems with taking the modulo of
8742 negative return values. All references changed.
8744 * misc.c: (intlog10) Make its table static const instead of auto.
8746 * sfm-read.c: (read_header) Make `prefix' static const instead of
8749 * var.h: (union value) Add member `hash'.
8750 (struct variable) Rename prv_index as `foo'--all references
8752 (typedef pv_opts) Removed. All references changed.
8754 * vars-prs.c: (parse_variables) Message fixes.
8756 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
8758 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
8759 they are being inserted. Don't check for BY variables of
8760 different types. Discard variables if the active file isn't
8761 included in the merge.
8762 (mtf_processing) Essentially rewritten.
8763 (mtf_merge_dictionary) Check for master/slave variables of
8764 different types/widths.
8766 * vfm.c: (static var not_canceled) New var.
8767 (process_active_file) Don't call vfm_source->read() if
8768 there's no vfm-source. Initialize not_canceled.
8769 (process_active_file_write_case) Honor and update not_canceled.
8770 (prepare_for_writing) Rollback changes from yesterday, they were
8772 (close_active_file) Don't destroy vfm_source unless it exists.
8774 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
8776 * Lots of source files: Added { } around nested if/else constructs
8777 to avoid new gcc 2.8 warnings.
8779 * data-in.c: (parse_Z) Declare `int' type explicitly.
8782 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
8783 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
8784 prev members. Put TABLEs at the end of the chain and FILEs at the
8785 beginning. Don't allow the active file in STATE_INIT. Use proper
8786 `seen' value for the active file. Fill out the by members and
8787 make sure they're of consistent type. Do the actual merge
8789 (mtf_processing_finish) New function.
8790 (var_type_description) New function.
8791 (mtf_free_file) New function.
8792 (mtf_free) Rewritten.
8793 (mtf_delete_file_in_place) New function.
8794 (mtf_read_nonactive_records) New function.
8795 (mtf_compare_BY_values) New function.
8796 (static var mtf_seq_no) New var.
8797 (mtf_processing) New function.
8798 (mtf_merge_dictionary) Assign nval members for the system file
8799 dictionary. Assign fv values for its variables. Point each slave
8800 variable to the corresponding master variable.
8802 * hash.c: Include str.h.
8804 * mis-val.c: (copy_missing_values) src arg is const.
8806 * misc.c: (spacing) Make `max' var explicitly int.
8808 * sfm-read.c: (dump_dictionary) Message reformatting.
8809 (sfm_read_case) Add assertion.
8811 * sort.c: Esthetic fixes.
8813 * var.h: (struct match_files_proc) New struct.
8814 (struct variable) Add private data match_files_proc.
8816 * vars-atr.c: (delete_variable) Implement. Add argument for the
8817 dictionary that owning the variable.
8818 (dup_variable) Add assertion.
8820 * vfm.c: Comment fixes, hopefully the comments are correct now.
8821 (process_active_file) New function.
8822 (process_active_file_write_case) New function.
8823 (process_active_file_output_case) New function.
8824 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
8826 (write_case) Renamed procedure_write_case(). Now write_case is a
8827 pointer to a function. Style fixes.
8829 1998-03-05 Ben Pfaff <blp@gnu.org>
8831 * Makefile.am: (q2c) Link with libmisc.
8832 (version.c) Define default_config_path, include_path,
8835 * ascii.c: (ascii_postopen_driver) When the default newline string
8836 is requested, open file in text mode. Suggested by
8837 palme@uni-wuppertal.de (Hubert Palme).
8838 (static vars line_buf, line_p) Change from char * to unsigned char
8840 (ascii_close_page) char * to unsigned char *.
8842 * cmdline.c: (parse_command_line) Implement -r option by
8843 prepending ~/.pspp/rc to the list of files to process.
8845 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
8846 before pulling in a final line.
8847 (null_func, null_int_func) Removed (dead code).
8849 * descript.q: (display) Calculate width of variable name column
8850 properly. Calculate number of valid cases properly. Reported by
8851 palme@uni-wuppertal.de (Hubert Palme).
8853 * filename.c: (init_filename) Use default_config_path instead of
8854 now obsolete CONFIG_PATH.
8856 * getline.c: (getl_initialize) Use include_path instead of now
8857 obsolete INCLUDE_PATH.
8858 (getl_add_file) New argument `where'. All references changed.
8860 * groff.c: (find_font_file) Use groff_font_path instead of now
8861 obsolete GROFF_FONT_PATH.
8863 * postscript.c: (find_ps_file) Use groff_font_path instead of now
8864 obsolete GROFF_FONT_PATH. Copy through temporary variable to
8865 avoid problems with constness.
8867 * str.h: (macro cs_streq) New macro.
8869 * version.h: (glob var default_config_path, include_path,
8870 groff_font_path) New vars.
8872 1998-02-23 Ben Pfaff <blp@gnu.org>
8874 * Many source files: Change verbose_msg() priority levels and
8877 * aggregate.c: Include debug-print.h.
8879 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
8881 (static var pre_syntax_message) Document --safer/-s and
8884 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
8886 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
8887 because it's not used but it's still copied.
8888 (open_file_r) Remove gratuitous debug message.
8890 * filename.c: (safety_violation) New function.
8891 (open_file) Remove gratuitous debug messages. Don't allow pipe
8892 files if set_safer is set.
8894 * get.c: Turn off debugging.
8896 * getline.c: (getl_add_virtual_file) New function.
8897 (getl_read_line) Add verbose_msg() call for opening new syntax
8899 (getl_perform_delayed_reset) Add a return value describing whether
8900 any action was taken. Call reset_eof().
8902 * getline.h: Comment fix.
8904 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
8905 place of incorrect `continue'. Use strtok_r() instead of
8906 strtok(). Always check strtok_r() return value.
8907 (groff_read_DESC) Use strtok_r() instead of strtok().
8909 * lexer.c: (reset_eof) New function.
8911 * main.c: (parse) Get a token after performing a delayed reset
8912 action; allow empty syntax files.
8914 * postscript.c: (output_encodings) Use strtok_r() instead of
8917 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
8919 * set.q: Comment fixes.
8920 (glob var set_safer) New var.
8921 (internal_cmd_set) Support SAFER.
8923 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
8925 * temporary.c: (free_dictionary) Set d->splits to NULL after
8928 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
8929 variable deleted, not if it *isn't* deleted.
8931 1998-02-16 Ben Pfaff <blp@gnu.org>
8933 * command.c: (array cmd_table[]) Add MATCH FILES.
8935 * common.c: Comment fixes.
8937 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
8938 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
8939 Include alloca.h. Problem reported by palme@uni-wuppertal.de
8942 * expr-opt.c: Include str.h. Problem reported by
8943 palme@uni-wuppertal.de (Hubert Palme).
8945 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
8946 (static var mtf_by) Change from char ** to variable **.
8947 (static var mtf_master) New var.
8948 (mtf_merge_dictionary) New function.
8949 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
8950 var type. Reorder tests properly. Initialize file->dict. Detect
8951 TABLE= without BY=. Read file dictionaries and merge them. Give
8952 subcommand name with IN, LAST, FIRST error messages. Create IN,
8953 LAST, FIRST variables. Comment fixes.
8954 (mtf_free) Don't free default_dict. Free mtf_master.
8956 * getline.c: Define getl_mode. Change getl_buf_size to size_t
8958 (handle_line_buffer) Cast int to size_t in comparison to avoid
8961 * getline.h: Declare getl_mode extern.
8963 * groff-font.c: (groff_read_font) Type-fix calls to getline.
8964 (groff_read_DESC) Make line_size a size_t.
8965 (match_tok) Parenthesize name to avoid macro expansion.
8967 * mis-val.c: (copy_missing_values) New function.
8969 * postscript.c: (postopen) Make buf_size a size_t.
8971 * sfm-read.c: (dump_dictionary) Make global from static. Print
8972 variable info in parts for easier debugging with Checker.
8974 * temporary.c: (copy_variable) Use copy_value_labels().
8975 (new_dictionary) New arg: whether to copy file label, documents.
8977 * val-labs.c: (copy_value_labels) New function.
8979 * var.h: (enums MISSING_*) Add MISSING_COUNT.
8981 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
8983 (dup_variable) Set prv_index, get.fv, get.nv.
8985 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
8987 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
8989 * Many source files: For ANSI-compliance, add empty statement
8990 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
8991 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
8993 * data-in.c: (parse_numeric) Some header files break on
8994 -DBL_MIN_10_EXP because they get a --; add () for safety.
8995 Reported by palme@uni-wuppertal.de (Hubert Palme).
8997 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
8998 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
8999 (dfm_close) Use close_file_ext.
9000 (open_inline_file) Set file.file to NULL, not file.
9001 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
9002 struct and use open_file_ext().
9003 (read_record) Use file.file.
9005 * file-handle.q: (prepend_current_directory) Pass through special
9008 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
9009 (normalize_filename) Pass through special filenames.
9010 (open_file, close_file) Accept pipe| and |pipe syntaxes as
9012 (dirname) Rename blp_dirname() because of name conflict on some
9013 OS. All references changed. Reported by palme@uni-wuppertal.de
9015 (is_special_filename) New function.
9017 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
9018 (trim_dictionary) Conditionalize some of the options on whether
9019 GTSV_OPT_MATCH_FILES is in *options.
9020 (rename_variables) Don't allow variables to be renamed as scratch
9022 (MTF_*) New enum series.
9023 (struct mtf_file) New struct.
9024 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
9026 (cmd_match_files, mtf_free) New functions.
9028 * lexer.c: (match_int) Needed parentheses around name to escape
9029 macro expansion. Reported by Micah Altman
9030 <maltman@www-vdc.fas.harvard.edu>.
9032 * print.c: Needed to include alloca.h. Reported by Micah Altman
9033 <maltman@www-vdc.fas.harvard.edu>.
9035 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
9036 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
9039 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
9040 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
9042 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
9044 * html.c: (struct html_driver_ext) Move into htmlP.h.
9045 (html_preopen_driver) Initialize cp_x, cp_y.
9046 (html_submit) Implement as call to output_tab_table().
9047 (change_attributes) New function.
9048 (escape_string) New function.
9049 (output_tab_table) New function.
9051 * list.q: (write_all_headers) Add code for writing headers for the
9053 (clean_up) Write out the html close-table tag.
9054 (determine_layout) Ignore html driver.
9055 (list_cases) Write html data.
9057 * som.c: (som_submit) Move more of the code into output_table().
9059 * tab.c: (static var hit) Make a global var and rename tab_hit.
9060 (static var tab_table_class) Make a global var.
9062 * htmlP.h: New file.
9064 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
9066 * dump-sysfile.c: Removed.
9068 * html.c: (preclose) Change comment in emitted code.
9070 * matrix-data.c: Debugging off by default. Comment fixes.
9071 (static var container) New var.
9072 (cmd_matrix_data) Create and destroy container. Initialize
9073 is_per_factor[] to 0s. Move code into new function
9074 string_to_content_type(). Require split values to be present in
9075 the data when ROWTYPE_ is explicit. Call specific function, not
9076 general read_matrices().
9077 (string_to_content_type) New function.
9078 (context) Exclude all whitespace, not just spaces.
9079 (mget_token) A dot is a number. Add assertion.
9080 (static var data) Renamed nr_data.
9081 (static var factor_values) Renamed nr_factor_values.
9082 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
9083 only specific case. Close data_file before exit.
9084 (fill_matrix) New function.
9085 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
9086 printing. Style fixes. Message fixes. Move code into
9088 (read_matrices_without_rowtype) Rename
9089 matrix_data_read_without_rowtype(). Fix off-by-one error on
9090 loops. Allocate nr_data[] memory from arena.
9091 (read_matrices_with_rowtype) Removed.
9092 (read_splits) Renamed nr_read_splits(). Style fixes.
9093 (read_factors) Renamed nr_read_factors().
9094 (dump_cell_content) Comment fixes. Arguments changed. Change
9095 debug printing. All references changed.
9096 (output_data) Renamed nr_output_data().
9097 (static var wr_content) New var.
9098 (struct factor_data) New struct.
9099 (static var wr_data) New var.
9100 (static var wr_current) New var.
9101 (matrix_data_source_destroy_source) Removed.
9102 (read_matrices_with_rowtype) New function.
9103 (matrix_data_read_with_rowtype) New function.
9104 (wr_read_splits) New function.
9105 (compare_factors) New function.
9106 (wr_output_data) New function.
9107 (wr_read_rowtype) New function.
9108 (wr_read_factors) New function.
9109 (wr_read_indeps) New function.
9110 (glob var matrix_data_source) Make destroy_source member NULL as
9113 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
9115 * lexer.c: (syntax_error) Give better error message when at end of
9118 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
9119 N_SCALAR to output as plain N.
9120 (mdump_token) Change output format.
9121 (context) Fix message output interaction with spaces in input.
9122 (another_token) New function.
9123 (force_eol) Improved error message.
9124 (static var max_cell_index) New var.
9125 (read_matrices) Init `cells'. factor_values is now per-cell.
9126 Init max_cell_index.
9127 (read_data_lines) Replace `compare' local with new `compare' arg.
9128 Debugging messages changed. Only read factors if per_factor.
9129 Propagate error return from read_factors(), force_eol().
9130 Copy N_SCALAR values across the N vector.
9131 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
9132 check parentheses manually since we now have is_per_factor[].
9133 Call read_data_lines() with new args. Check for end of data after
9134 looping, using another_token().
9135 (read_factors) Arguments changed. Use max_cell_index to determine
9136 whether to read or compare factors. Message fixes.
9137 (dump_cell_content) New function.
9138 (output_data) Completely rewritten because content types were
9139 supported to be nested inside factor values, not vice versa.
9141 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
9143 * lexer.c: (syntax_error) Support formatted varargs messages.
9145 * matrix-data.c: Turn debugging on by default.
9146 (static content_type[]) New array.
9147 (static content_names[]) New array.
9148 (static rowtype_, varname_) New vars.
9149 (static is_per_factor[]) New array.
9150 (static split_values) Moved declaration.
9151 (static n_continuous, first_continuous) New var.
9152 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
9153 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
9154 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
9155 Check for continuous variables.
9156 [DEBUGGING] (debug_print) Remove content_names[].
9157 (mdump_token) New macro.
9158 (mget_token_dump) New function.
9159 (mdump_token) New function.
9160 (context) New function.
9161 (mget_token) Fix messages.
9162 (static var data, split_values, factor_values) New vars.
9163 (read_matrices) Manage split_values, factor_values.
9164 (read_data_lines) New function.
9165 (read_matrices_without_rowtype) Implemented.
9166 (read_splits) Message fixes. Uses `just_read'.
9167 (read_factors) New function.
9168 (output_data) New function.
9169 (matrix_data_source_destroy_source) Close the file handle.
9170 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
9173 * str.c: (strpadcmp) Removed.
9175 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
9177 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
9179 * Lots of source files: Add cast to unsigned character to calls to
9180 tolower() and toupper().
9182 * aggregate.c: Set default_dict.splits to NULL.
9184 * command.c: (static variable tab[]) Add MATRIX DATA.
9186 * data-in.c: Add debugging defines. Formatting fixes.
9188 * expr-opt.c: Formatting fixes.
9190 * lexer.c: (syntax_error) Message fixes.
9192 * matrix-data.c: New enum series.
9193 (static vars fmt, section, diag, explicit_rowtype, signle_split,
9194 split_values, n_factors, factors, cells, pop_n, contents,
9195 n_contents) New vars.
9196 (cmd_matrix_data) Finished implementation.
9197 (compare_variables_by_mxd_vartype) New function.
9198 [DEBUGGING] (debug_print) New function.
9199 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
9200 (read_matrices) New function.
9201 (read_matrices_without_rowtype) New function.
9202 (read_matrices_with_rowtype) New function.
9203 (read_splits) New function.
9204 (mget_token) New function.
9205 (force_eol) New function.
9206 [0] (test_tokenizer) New function.
9207 (matrix_data_source_destroy_source) New function.
9208 (glob var matrix_data_source) New var.
9210 * misc.h: Include ieeefp.h if present.
9212 * split-file.h: (cmd_split_file) Changes corresponding to struct
9215 * str.h: Fix memmem prototype.
9217 * temporary.c: (save_dictionary, restore_dictionary,
9218 free_dictionary) Changes corresponding to struct dictionary
9221 * var.h: (MXD_* enums) New enum series.
9222 (struct matrix_data_proc) New struct.
9223 (struct split) Removed.
9224 (struct dictionary) Changed `splits' member from `split *' to
9226 (macro force_create_variable) New macro. Replaced lots of
9227 create_variable()/assert() calls with calls to this macro.
9229 * vars-atr.c: (discard_variables) Changed assertion.
9230 [GLOBAL_DEBUGGING] (force_create_variable) New function
9231 called by the macro of the same name.
9232 (clear_variable) Changes to delete splits from the dictionary
9233 corresponding to struct dictionary changes.
9235 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
9236 corrupted variable `index' values in the dictionary passed in
9237 every time this function is called.
9239 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
9240 to struct dictionary changes.
9242 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
9244 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
9246 * command.c: New includes.
9247 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
9248 (cmd_erase) New function.
9249 [unix] (shell) New function.
9250 (run_command) New function.
9251 (cmd_host) New function.
9252 (cmd_new_file) New function.
9254 * expr-prs.c: (parse_primary) Message fix.
9256 * inpt-pgm.c: Formatting fix.
9257 (cmd_reread) Implement the FILE subcommand.
9259 * matrix-data.c: New file.
9261 * q2c.c: (dump_header) Change output commenting style.
9263 * weight.c: Comment fix.
9265 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
9267 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
9269 (buf_10x) Renamed buf_1xx, all references changed.
9270 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
9271 cases now implemented).
9272 (create_sysfile) New function.
9273 (agr_11x_func) New function.
9275 * data-in.c: (parse_numeric) Work properly if there's an
9276 explicitly coded decimal point in the data and decimal places are
9277 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
9278 <el@linux.lisse.na>.
9280 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
9281 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
9282 Eberhard W Lisse <el@linux.lisse.na>.
9284 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
9285 strerror.c. Bug reported by Alexandre Oliva
9286 <oliva@dcc.unicamp.br>.
9288 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
9289 (static var separate_case_tab) New var.
9290 (cmd_sort_cases) Cancel temporary transformations here. Free
9291 v_sort before return.
9292 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
9293 we're reading from a sort stream. Don't cancel temporary
9294 transformations. Offload internal sorting to do_internal_sort().
9295 (do_internal_sort) New function. Handles internal sorting even
9296 when SEPARATE is nonzero. Doesn't free v_sort.
9297 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
9299 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
9300 sink if SEPARATE is zero.
9301 (read_output_cases) Renamed read_sort_output(), all references
9302 changed. Now uses separate_case_tab when it exists.
9303 (write_separate) New function.
9305 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
9306 memory_sink_cases. Don't redundantly call
9307 vfm_source->destroy_source().
9308 (memory_stream_mode) After switching over, set memory_sink_cases
9311 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
9313 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
9315 (static var prev_case) New, moved out of aggregate_single_case()
9317 (static var buf64_10x, buf_10x) New.
9318 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
9319 the 000, 001, 100, and 101 cases. Free prev_case.
9320 (parse_aggregate_functions) Disallow scratch variables.
9321 (free_aggregate_functions) Only free agr_dict if non-null. Use
9322 iter->function to determine numeric/string type, not
9324 (aggregate_single_case) Don't manage prev_case. Initialize
9325 aggregate info after dumping it.
9326 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
9327 mean, stddev, weighted stddev definitions.
9328 (dump_aggregate_info) Implemented.
9329 (initialize_aggregate_info) Renamed from
9330 initialize_aggregate_functions(). Initializes dbl[2].
9331 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
9332 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
9334 * cases.c: (alloc_val) Removed.
9336 * get.c: (cmd_save_internal) Initialize new `dict' member.
9338 * sfm-write.c: (sfm_write_dictionary, write_header,
9339 write_variable, write_value_labels, write_documents) Reorganize,
9340 simplify for new parameter structure.
9341 (write_variable) Only one variable * argument now.
9343 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
9344 replaced by new `dict' member.
9346 * temporary.c: (new_dictionary) Initialize n_documents.
9348 * vars-atr.c: (dup_variable) Allocate `value's from dict into
9350 (init_variable, replace_variable) Eliminate usage of alloc_val().
9352 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
9354 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
9355 signal that AGGREGATE is to be used for forming final cases.
9356 (close_active_file) Call end_func before stopping lagging. Cancel
9357 temporary after finishing compaction.
9358 (write_case) Comment fixes. Cleaned up.
9359 (compact_case) Let AGGREGATE handle compaction when `temporary' is
9362 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
9364 * Makefile.am: (BUILT_SOURCES) Add means.c.
9365 (pspp_SOURCES) Add means.c.
9366 (EXTRA_DIST) Add means.q.
9368 * command.c: (array cmd_table[]) Add MEANS.
9370 * common.h: Esthetic fixes. Comment fixes. Test for
9371 MAX_SHORT_STRING greater than 8.
9372 (macros LOWEST, HIGHEST) New.
9374 * data-in.c, data-list.c, recode.c: Comment fixes.
9376 * means.q: New file, base version.
9378 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
9379 with LOWEST, DBL_MAX with HIGHEST.
9381 * q2c.c: (dump_vars) Add an enum to array types giving the number
9382 of values for the enum.
9384 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
9385 Replace second_lowest_value with second_lowest_flt64.
9387 * sfm-write.c: (write_variable, write_rec_7_34) Replace
9388 second_lowest_value with second_lowest_flt64.
9390 * t-test.q: Comment fix.
9392 * temporary.c: (restore_dictionary) Esthetic fix.
9394 * tokens.h: (force_match_id, force_match, force_string, force_int,
9395 force_num, force_id) Replace msg() with syntax_error().
9397 * var.h: (struct means_proc) New.
9398 (struct variable) Add mns member to `p' union.
9400 * vars-prs.c: (parse_variable, parse_dict_variable,
9401 parse_variables, parse_DATA_LIST_vars) Replace msg() with
9404 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
9406 * Makefile.am: (pspp_SOURCES) Add tab.h.
9408 * Most source files: Added a cast to unsigned char in usages of
9409 the ctype is*() functions. Replaced `end of command expected'
9410 calls to msg() with calls to syntax_error().
9412 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
9414 * lexer.c: (hex_val) Removed (was dead code).
9415 (idmatch) Parenthesize function name to avoid macro expansion.
9417 * postscript.c: Comment fixes.
9418 (ps_preopen_driver) Change default font size to 10pt.
9420 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
9422 (parse_format_spec) Change system-file format spec argument type
9423 to int32. Parse the format spec with bitwise operators.
9425 * sfmP.h: (struct sysfile_format) Removed.
9426 (struct sysfile_variable) Changed print, write members from
9427 sysfile_format to int32.
9429 * tokens.h: Esthetic fixes.
9430 [__GNUC__] (macro id_match) New macro to hopefully speed up
9431 identifier matching.
9432 (macros match_id, match_tok, match_int) Implemented in
9433 compiler-independent manner; no longer GNU C only.
9435 * vfm.h: Include time.h.
9437 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
9439 * data-list.c: (dump_fixed_table) Change tab_dim().
9441 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
9443 * error.c: Include command.h.
9445 * frequencies.g: Formatting fixes.
9447 * frequencies.q: Add tab_dim() calls. Make the total cell a
9450 * glob.c: Include command.h.
9452 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
9454 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
9455 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
9456 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
9457 the other elements (is this right?).
9458 (read_variables) Use lowest, highest members.
9459 (parse_format_spec) New arg `vv' for more stringent checking.
9460 (dump_dictionary) Byteswaps nonexplicit data.
9461 (sfm_read_case) Byteswap numeric data.
9463 * som.c: Initialize table_num to 1.
9464 (render_segments) Remember to increment y_index after each table
9467 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
9468 avl_count() on a NULL tree. No title for the second table.
9469 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
9470 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
9471 fix call to display_variables().
9472 (display_variables) Default to 4 columns, not 3. Set up headers.
9473 Column title is Variable, not Name. Fix index column.
9474 Add joint text. Add tab_dim(). Handle value labels properly.
9475 Handle DISPLAY LABELS properly. Draw boxes correctly.
9476 (describe_variable) Value labels don't need titles. Don't clear
9477 nonexistent index column.
9478 (compare_vectors_by_name) New function.
9479 (display_vectors) New function.
9481 * tab.c: (tab_height) Add assertion.
9482 (tab_null) Add debug code.
9483 (evaluate_dimensions) Add debug code.
9485 * var.h: (struct variable) get_proc data is sometimes used
9486 simultaneously with other per-procedure info, therefore it was
9487 removed from the union. All references changed.
9489 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
9491 * ascii.c: (ascii_close_page) Put title on second line of headers
9492 if there is no subtitle.
9494 * command.c: (glob var cur_proc) Move definition here, from
9496 (cmd_remark) Emit blank line before remarks.
9498 * command.h: (glob var cur_proc) Move declaration here, from
9501 * data-list.c: (dump_fixed_table) Fix messages.
9502 (dump_free_table) Call tab_nat_dim().
9504 * descript.q: (dump_z_table) Modify tab_dim() call.
9506 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
9508 (dump_statistics) Don't output header.
9510 * groff-font.c: Minor format fix.
9512 * html.c: Comment fix.
9514 * list.q: (write_varname) Indent after advancing page.
9516 * output.h: Minor reordering.
9518 * postscript.c: Comment fixes. Many places, '\n' was replaced by
9519 a reference to eol[].
9520 (struct ps_driver_ext) New member eol[].
9521 (ps_preopen_driver) Initialize eol[].
9522 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
9523 defaults. Handle headers. Fix test for minimum page length.
9524 (static var option_tab[]) Add `line-ends'.
9525 (ps_option) Handle line-ends to change eol[].
9526 (postopen) Scale prop_em_width and fixed_width properly. Set the
9527 prologue title to outp_title if applicable. Replace the prologue
9528 line ends with eol[]. Call draw_headers() if headers are enabled.
9529 (text_width) New function.
9530 (out_text_plain) New function.
9531 (draw_headers) New function.
9533 * print.c: (dump_table) Call tab_nat_dim().
9535 * som.c: (som_blank_line) Only advance a line if not at the top of
9537 (som_submit) Move several informational table calls here.
9538 Increment subtable_num if SOMF_NO_TITLE not set.
9539 (output_table) Advance a line if SOMF_NO_SPACING not set.
9540 (render_columns, render_segments, render_simple) Handle spacing
9541 between tables. Handle table titles. Remove debug output.
9543 * som.h: (SOMF_*) New enum series.
9544 (struct som_table_class) New member `flags'.
9546 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
9548 (display_variables) Calls tab_nat_dim().
9549 (describe_variable) Remove restriction on number of value labels.
9550 Make value labels separated by thin lines.
9552 * tab.c: (tab_create) Default `flags' to none.
9553 (tab_float) New arg `w'. All references changed.
9554 (tab_nat_dim) New function.
9555 (tab_output_text) No title or spacing.
9556 (tab_flags) New function.
9557 (tabi_flags) New function.
9558 (tabi_title) New function.
9559 (strip_height) Removed.
9560 (tabi_render) Skip title when necessary.
9561 (static var tab_tab_class) Add tabi_flags, tabi_title.
9562 (evaluate_dimensions) Disable display of column, row size.
9563 (sum_columns) Add title height to top header.
9564 (render_strip) Moved within file.
9566 * tab.h: (struct tab_table) New member `flags'.
9568 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
9570 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
9572 * Most source files: Add `const' attribute in all appropriate
9575 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
9576 column to the variables table for use by describe_variable().
9577 (cmd_display) Disable for the present.
9578 (display_documents) Don't wrap documents.
9579 (display_variables) Table has four columns now.
9580 (describe_variable) Table has four columns now. Don't use a
9581 subtable, use joined cells instead.
9583 * tab.c: (tab_create) Don't set `join'.
9584 (tab_realloc) ct array is not made up of a_string's.
9585 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
9586 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
9587 (text_format) New function.
9588 (tab_title) Rewritten, uses text_format().
9589 (tab_text) Rewritten, uses text_format().
9590 (tab_joint_text) New function.
9592 (static var hit) New variable.
9593 (render_strip) New args r1, r2. Implement joined cells that fit
9595 (tabi_render) Increment hit. Pass new args to render_strip().
9596 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
9597 cells. For t_naw and t_nah, ignore joined cells and null cells in
9600 * tab.h: (struct tab_join_rect) Removed.
9601 (struct tab_table) Removed `join'.
9602 (TAB_JOIN_MAIN) Removed.
9603 (struct tab_joined_cell) New struct.
9604 (TAT_NOWRAP) New enum.
9606 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
9608 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
9610 (ascii_postopen_driver) Fix initialization of *_spacing so that
9611 the TAL_0 bit doesn't count.
9613 * data-list.c: (dump_fixed_table) Use natural width for Format
9616 * glob.c: (rerange) Removed.
9617 (get_date) Formatting fixes. Internationalization fix.
9619 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
9622 * postscript.c: (ps_postopen_driver) Replace
9623 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
9625 * som.c: (som_submit) Don't eject page before every table.
9626 (output_table) Fix order of arguments on call to area().
9627 (render_columns) Fix calculation of max_len.
9629 * tab.c: (tabi_cumulate) Minor change to increase elegance.
9630 (render_strip) New function.
9631 (strip_height) New function.
9632 (tabi_render) Rewrite as calls to render_strip().
9634 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
9635 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
9636 with the TAB_* and OUTP_T_* constants.
9638 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
9640 * Makefile.am: Formatting fixes.
9642 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
9645 * data-list.c: (dump_fixed_table) Add tab_dim() call.
9647 * descript.q: (dump_z_table, display) Add tab_dim() calls.
9649 * dump-sysfile.c: (glob var length) Make type off_t.
9650 (usage) Fix arguments.
9653 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
9654 Now right-justification is the default so many references had to
9656 (struct outp_class) Removed line_width, all references changed.
9657 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
9658 (struct outp_driver) Add elements horiz_line_width,
9659 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
9662 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
9664 (postopen) Initialize all the informational members of
9667 * som.c: (som_blank_line) New function, renamed from blank_line(),
9668 all references changed.
9669 (som_submit) Disables drivers whose pages can't be opened.
9670 (render_columns, render_simple, render_segments) Add debug output.
9671 (render_columns) Fix loop range.
9672 (render_simple) Don't try to render the headers, they're taken
9673 care of automatically. Advance cp_y past the table when done.
9674 (render_segments) Fix loop ranges.
9676 * tab.c: Initialize new members of tab_table.
9677 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
9678 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
9679 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
9682 (tab_dim) New function.
9683 (tab_col_width) Removed.
9684 (tab_row_height) Removed.
9685 (tab_output_text) Call tab_dim().
9686 (tabi_driver) Call evaluate_dimensions(), sum_columns().
9687 (tabi_area) Implemented.
9688 (tabi_cumulate) Implemented.
9689 (tabi_render) Partially implemented, but broken.
9690 (var tab_table_class) Made static.
9691 (evaluate_dimensions) New function.
9692 (sum_columns) New function.
9694 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
9695 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
9696 t_scr, t_srr, t_sentinel. Removed: t_nat.
9697 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
9698 max_stack_height, w, h. Removed: ce, re.
9699 (macro blank_line) Removed.
9700 (glob var zero_length) Removed.
9702 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
9704 * Most source files: include some of the new include files broken
9707 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
9710 * aggregate.c: (glob var outfile) Make static.
9712 * command.c: (glob var pgm_state) Move here.
9714 * common.c: (glob vars endian, second_lowest_value, pgmname,
9715 finished, curdate, cur_proc, start_interactive, history_file) Move
9718 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
9720 * file-handle.q: (glob vars files, inline_file) Move here.
9722 * glob.c: Lost lots of glob vars, detailed in individual file
9724 (init_glob) set_printer, set_screen were obsolete, deleted.
9725 set_cprompt has fewer spaces because pspp has fewer letters than
9728 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
9729 (inp_nval) Made static.
9731 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
9732 tokstr_len, toklongstr, tokint) Move here.
9734 * misc.c: Lost several vars and functions.
9736 * set.q: (all the set_* variables) Move here.
9738 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
9739 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
9742 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
9744 * tab.h: (enum series t_*) New enums.
9745 (struct tab_table) Use arena struct tag. New members ce, re.
9747 * tokens.h: Comment fixes.
9749 * var.h: Move lots of enums and variables and functions and
9750 structures to other files. Use and declare a lot more union and
9751 struct tags. Comment fixes.
9753 * vector.c: (glob vars vec, nvec) Move here.
9755 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
9756 init_blanks, last_vfm_invocation) Move here.
9758 * cases.h: New file.
9759 (struct long_vec) Move here.
9760 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
9763 * command.h: New file.
9764 (STATE_* enums) Move here.
9765 (glob var pgm_state) Move here.
9767 * format.c: New file.
9768 (glob var formats) Move here.
9769 (parse_format_specifier_name, fmt_to_string,
9770 check_input_specifier, check_output_specifier,
9771 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
9774 * format.h: New file. Move functions now in format.c here.
9775 (FMT_* enums) Move here.
9776 (struct fmt_desc) Move here.
9777 (FCAT_* enums) Move here.
9778 (struct fmt_spec) Move here.
9779 (glob vars formats, fmt_parse_ignore_error) Move here.
9781 * inpt-pgm.h: New file.
9782 (INP_* enums) Move here, make #defines into enums.
9783 (glob vars inp_init, inp_init_size) Move here.
9786 (glob vars v_sort, nv_sort) Move here.
9787 (sort_cases, read_sort_output) Move here.
9789 * vector.h: New file.
9790 (struct vector) Move here, add struct tag.
9791 (glob vars vec, nvec) Move here.
9792 (find_vector) Move here.
9795 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
9796 reinit_blanks, init_zero, init_blanks) Move here.
9797 (struct case_stream) Move here.
9798 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
9799 vfm_disk_stream, sort_stream, data_list_source,
9800 input_program_source, file_type_source, get_source, n_lag) Move
9802 (procedure, write_case, lagged_case, compact_case, page_to_disk)
9805 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
9807 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
9808 (LDADD) Add libdcdflib.
9810 * ascii.c: Comment and formatting fixes. Almost every external
9811 function had an assert added, checking driver_open and page_open.
9812 (ascii_init_driver) Broken into ascii_preopen_driver,
9813 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
9814 (ascii_open_page) Sets page_open.
9815 (ascii_close_page) Clears page_open.
9817 * html.c: Comment and formatting fixes. Almost every external
9818 function had an assert added, checking driver_open and page_open.
9819 (html_init_driver) Broken into html_preopen_driver,
9820 html_postopen_driver, html_close_driver. Manages driver_open.
9821 (html_open_page) Sets page_open.
9822 (html_close_page) Clears page_open.
9823 (html_submit) Disabled.
9825 * lexer.c: (parse_string) Remove debugging printf.
9827 * list.q: (determine_layout) Open a page if one is not yet open.
9829 * output.c: Comment fixes.
9830 (add_class) Set the class member of the new list element.
9831 (parse_options) Don't handle device type.
9832 (colon_tokenize) New function.
9833 (configure_driver) New four-field format with a field for device
9834 type. Now initialize driver_open, page_open, next, and prev
9835 fields. Use new colon_tokenize() function. Don't do a memory
9836 copy to replace a driver, it doesn't work; instead delete the old
9837 driver and insert a new one.
9838 (destroy_driver) Don't call som_destroy_driver(). Close the page
9839 if it's open. Find the class in the list of classes and decrement
9840 that reference count. Remove the driver from the global driver
9842 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
9843 references changed. Rewritten. Don't return a driver that's not
9845 (outp_eject_page) All references to som_internal_eject_page()
9846 changed to use this. Sets cp_x to 0 as well as cp_y.
9848 * output.h: (OUTP_I_* enums) Removed.
9849 (struct som_submission_form) Removed.
9850 (struct outp_class) init_driver broken into preopen_driver,
9851 postopen_driver, and close_driver. submit changed to take a
9854 * postscript.c: Comment and formatting fixes. Almost every
9855 external function had an assert added, checking driver_open and
9857 (ps_init_driver) Broken into ps_preopen_driver,
9858 ps_postopen_driver, ps_close_driver. Manages driver_open.
9859 (ps_open_page) Sets page_open.
9860 (ps_close_page) Clears page_open.
9862 * som.c: New file, base implementation.
9864 * som.h: (struct som_table) Add struct tag.
9865 (enum SOM_COL_ACROSS) Removed.
9866 (SOM_ROWS, SOM_COLUMNS) New enums.
9867 (struct som_table_class) Add member `cumulate'. Remove `segment';
9868 change `render' arguments.
9869 (struct som_point, struct som_rect) Removed.
9870 (som_submit_table) Fixed typo, should have been som_submit.
9872 * sysfile-info: (describe_variable) Don't try to insert a
9873 subtable; just destroy it for now.
9875 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
9876 references to value labels.
9878 * tab.c: (tab_destroy) New function.
9879 (tab_columns) Change argument.
9880 [0] (tab_submit) Remove dead code.
9881 (tab_title) Allocate string from the table's arena.
9882 (tab_output_text) Only free the buffer if we allocated it.
9883 (tab_submit) New function.
9884 (static vars t, d) New static vars.
9885 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
9886 tabi_headers, tabi_cumulate, tabi_render) New functions.
9887 (glob var tab_table_class) New global var.
9889 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
9890 encapsulate the rectangle. All references changed.
9892 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
9894 * All header files updated to use struct tags in addition to
9895 typedefs for all structures. Don't use word `struct' in struct
9898 * Makefile.am: (pspp_SOURCES) Remove html.c.
9899 (INCLUDES) Replace the lib/* includes with a single lib/ include;
9900 all references updated.
9902 * command.c: (parse_cmd) Remove call to som_check_workspace.
9903 (output_line) Update to new som.
9905 * data-in.c: (parse_numeric) A single dot is not an error; it is
9906 the system-missing value.
9908 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
9911 * data-out.c: Added `const' as appropriate to many prototypes.
9912 (convert_E, convert_F, convert_CCx) Take double argument instead
9913 of value * argument.
9914 (convert_format_to_string) Call changed functions appropriately.
9915 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
9916 make a local copy of the value.
9918 * descript.q: Remove custom_variables() prototype now provided by
9920 (custom_variables) Don't increment sbc_variables, the caller does
9922 (dump_z_table, display) Update to new som.
9924 * error.c: (vmsg) Add const to prototype. Remove code to handle
9925 `too many errors' condition.
9926 (check_error_count) New function.
9927 (msg) Add const to prototype.
9929 * filename.c: (open_file) Rewrite for elegance.
9931 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
9932 (dump_full, dump_condensed, dump_statistics) Update for new som.
9934 * list.q: Don't include somP.h. Change all references to
9935 som_driver_ext to refer to the new members of som_driver. Change
9936 som_internal_eject_page() references to outp_eject_page().
9938 * main.c: (parse) Rewrite for elegance. Add call to
9939 check_error_count().
9941 * output.c: (add_class, outp_list_classes, outp_configure_driver)
9942 Rewrite or revise for new outp_driver_class_list structure.
9943 (outp_iterate_enabled_drivers) Fix comparison between disabled
9944 devices and current device type.
9945 (outp_eject_page) New function.
9947 * output.h: Comment fixes.
9948 (struct outp_driver) New members driver_open, page_open, cp_x,
9949 cp_y, font_height, prop_em_width, fixed_width. Deleted members
9951 (struct outp_driver_class_list) New struct.
9952 (outp_class_list) Changed to type outp_driver_class_list; all
9955 * print.c: (dump_table, print_trns_proc) Updated for new som.
9957 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
9958 prototypes for custom subcommands.
9959 (dump_subcommand) Always include the `else'.
9960 (dump_parser) Fix comments in output code.
9962 * set.q: Reordered functions.
9964 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
9966 * som.h: Rewritten from scratch.
9968 * str.h: Remove dead code.
9970 * tab.c, tab.h: New files, base implementation.
9972 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
9975 * t-test.q: New code from John Williams
9976 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
9977 Many many new static vars and defines.
9978 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
9979 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
9980 (struct value_list) New struct.
9981 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
9982 t_crt, t_sig, print_t_groups) New functions.
9983 (cmd_t_test) Implemented.
9985 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
9988 * vfm.c: (dump_splits) Update to new som.
9990 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
9992 * Makefile.am: (fiasco_SOURCES) Add html.c.
9994 * aggregate.c: Base source.
9996 * ascii.c: (postopen, preclose) Reformat.
9998 * data-out.c, expr-evl.c: Comment fixes.
10000 * filename.c: (open_file) When opening a file for writing, use
10001 line buffering instead of full buffering for better interactive
10002 performance. Suggested by Valerio Aimale
10003 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
10004 names `stdin', `stdout', `stderr'.
10006 * groff-font.c: Comment fixes.
10008 * html.c: New file; base version.
10010 * list.q: (write_all_headers, clean_up, determine_layout,
10011 list_cases) Ignore `special' devices for now. Needs to be fixed
10014 * output.c: (outp_init) Add html driver to list; reverse list
10017 * output.h: (struct outp_class_struct) New members `special',
10018 `submit'; comment fixes. All references changed.
10020 * postscript.c: (ps_init_driver) Make defaults for text_opt,
10021 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
10023 (postopen) Comment fix.
10024 (preclose) Comment fixes, formatting fixes. Change x->file.file
10025 references to more proper f->file.
10027 * som-high.c: (som_submit_table) Special classes use their own
10030 * som.h: Comment fixes.
10032 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
10035 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
10037 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
10039 * aggregate.c: Still working on this.
10041 * command.c: (cmd_table[]) Add AGGREGATE back in.
10042 (split_words) Make '-' a legal word separator as well as ' '.
10044 * main.c: Comment fixes.
10046 * q2c.c: (dump_parser) Don't require the procedure's full name to
10047 be present, in the generated source.
10049 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
10050 multiply specified and let it be default; let MISSING, CRITERIA,
10051 FORMAT be multiply specified.
10052 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
10053 (custom_groups) Fix defaults.
10054 (custom_pairs) Check whether this is a PAIRS subcommand before
10055 attempting to parse. Better garbage collection. Proper storage
10057 [DEBUGGING] (debug_print) New function.
10059 * temporary.c: Comment fixes.
10060 (copy_variable) Don't copy variable name and index.
10061 (save_dictionary) Copy variable name and index by hand.
10063 * vars-atr.c: Comment fixes.
10064 (create_variable) New dictionary argument. All references
10066 (common_init_stuff) New dictionary argument. All references
10068 (init_variable) New dictionary argument. All references changed.
10069 (dup_variable) New function.
10071 * vars-prs.c: (parse_variables) If there are any errors, we always
10072 return 0. Previously, it was possible for some types of errors to
10075 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
10077 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
10080 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
10082 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
10085 * q2c.c: Comment fixes.
10086 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
10088 * t-test.q: (cmd_list) Rename cmd_t_test.
10090 * temporary.c: (new_dictionary) Don't declare as static.
10092 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
10094 * aggregate.c: Changes, still not finished.
10096 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
10098 * q2c.c: Comment fixes. Now its output is internationalized.
10099 (get_token) Fix parsing of escapes within literal strings.
10100 (main) Fix bad #line directives in output.
10102 * t-test.q: Base implementation.
10104 * temporary.c: (new_dictionary) New function.
10105 (restore_dictionary) [__CHECKER__] Change fill character to *
10108 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
10110 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
10112 * aggregate.c: Changes, still not finished.
10114 * descript.q, list.q: Comment fixes.
10116 * q2c.c: Almost completely rewritten.
10118 * t-test.q: New file, not complete.
10120 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
10122 * aggregate.c: Changes, still not finished.
10124 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
10127 * temporary.c: (cancel_temporary) New function.
10129 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
10130 of doing it by hand.
10132 * vfm.c: (close_active_file) After restoring a TEMPORARY
10133 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
10134 cancel_temporary().
10135 (SPLIT_FILE_procfunc) Comment fix.
10137 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
10139 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
10141 * aggregate.c: New file, not finished yet.
10143 * command.c: (cmd_table) Add AGGREGATE.
10145 * common.h: (pgm_state) Move declaration to var.h.
10147 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
10149 (parse_string) Message fix.
10151 * recode.c: Comment fix.
10153 * sfm-read.c: (read_variables) Code esthetic fixes.
10154 (write_header) Default date is `Jan', not `JAN'.
10156 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
10158 * sort.c: (cmd_sort_cases) Farm the work out to new function
10159 parse_sort_variables().
10160 (parse_sort_variables) New function.
10161 (sort_cases) New function. Cancels temporary transformations,
10162 which sorting didn't do previously.
10163 (cmd_sort_cases) Better garbage collection on error. Uses
10164 do_external_sort().
10165 (write_initial_runs, merge_once) Improved code esthetics.
10166 (sort_stream_read) Reduced to one call to read_output_cases().
10167 (read_output_cases) New function.
10169 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
10170 variable labels to 120 characters.
10172 * var.h: Comment fixes.
10173 (glob var pgm_state) From common.h.
10175 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
10177 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
10178 options. Set *names to NULL on error.
10180 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
10182 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
10184 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
10185 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
10187 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
10189 * vfm.c: (page_to_disk) Added missing local variables.
10191 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
10193 * get.c: Comment fix.
10195 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
10196 source is anything other than a disk stream, not just if it's in a
10197 memory stream. Call page_to_disk() before external sort.
10198 (allocate_cases) Message fix.
10200 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
10202 (page_to_disk) New function.
10204 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
10206 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
10208 * common.h: (macro strerror) Remove. From Alexandre Oliva
10209 <oliva@dcc.unicamp.br>.
10211 * get.c: (dict_delete_run) The number of variables to delete is
10212 not necessarily the number of variables that need to be shifted
10214 (trim_dictionary) Don't set *options to 0. Fix bug that caused
10215 too many variables to be deleted.
10217 * postscript.c: Comment fix.
10219 * q2c.c: Include strerror.c. From Alexandre Oliva
10220 <oliva@dcc.unicamp.br>.
10222 * set.q: #undef ON and OFF. From Alexandre Oliva
10223 <oliva@dcc.unicamp.br>.
10225 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
10226 early, otherwise errors cause a bad free().
10228 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
10229 Oliva <oliva@dcc.unicamp.br>.
10231 * temporary.c: (save_dictionary) Don't allocate memory if
10234 * vfm.c: (memory_stream_write) Message fix.
10236 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
10238 * command.c: (static var cmd_table[]) Define REPEATING DATA
10241 * common.h: Added support for broken systems that are missing
10242 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
10244 * Many source files: Replace syntax error messages via msg() with
10245 call to syntax_error().
10247 * data-list.c: (dump_fixed_table) Add support for dumping table
10248 for REPEATING DATA as well as DATA LIST FIXED.
10249 (cmd_repeating_data) Allows and requires `/' between subcommands.
10250 Does proper thing with allowing rpd.starts_end to stay 0. Allows
10251 CONTINUED specifications to be omitted. Forces CONTINUED to be
10252 specified if ID is. Calculates starts_end, cont_end from logical
10253 record length as reported by fhp. Calls dump_fixed_table() if
10254 requested. Fixed length of record copied by memcpy.
10255 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
10257 (realize_value) Returns sensible value for out-of-range variable
10259 (rpd_parse_record) New argument `ofs'. Fixed confusion between
10260 length of occurrences and length of line. Added warning for
10261 fields that exceed the line length. Fixed infinite loop.
10262 (read_one_set_of_repetitions) Numerous minor changes for more
10263 complete SPSS compliance. Message fixes.
10265 * dfm.c: (dfm_close) If the file being closed is the inline file,
10266 read all the remaining data before closing it.
10267 (dfm_get_record) Don't close the file on lossage, as either it
10268 has been closed already or it doesn't belong to us.
10270 * error.c: (puts_stdout) New function.
10271 (vmsg) Use puts_stdout instead of puts.
10273 * file-handle.q: (fh_record_width) New function.
10275 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
10277 (clear_case) Ditto.
10278 (input_program_source_read) Made an old kluge an approved method.
10280 * lexer.c: (syntax_error) New function.
10282 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
10285 * output.c: (oupt_get_paper_size) Message fix.
10287 * q2c.c: Numerous fixes to formatting of generated code made to
10288 conform to GNU coding standards. Uses syntax_error() in generated
10289 code. Other miscellaneous generated message fixes. Added support
10290 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
10291 RAND_MAX, and/or strerror().
10293 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
10295 * data-in.c: Comment fixes.
10297 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
10298 (find_variable_input_spec) New function.
10299 (cmd_repeating_data) Initializes id_spec.
10300 (rpd_parse_record) Implemented.
10301 (read_one_set_of_repetitions) Returns -3 by default in order to
10302 kluge out some potential bugs.
10304 * data-out.c: Comment fixes.
10306 * file-type.c: (internal_cmd_record_type) Message fix.
10308 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
10309 for handling -3 return value.
10311 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
10313 * data-list.c: Comment fixes.
10314 (struct dls_var_spec) Reordered members.
10315 (read_from_data_list_fixed) Restructured.
10316 (struct repeating_data_trns) Reordered members. Renamed `starts'
10317 as `starts_beg', `ends' as `starts_end'.
10318 (cmd_repeating_data) Calculates length of repeated data if
10319 necessary and possible.
10320 (parse_num_or_var) Don't allow string variables.
10321 (realize_value) New function.
10322 (rpd_msg) New function.
10323 (rpd_parse_record) New function. Currently stubbed out.
10324 (read_one_set_of_repetitions) Implemented.
10326 * inpt-pgm.c: (input_program_source_read) Comment fix.
10328 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
10330 * command.c: (cmd_end_repeat_p) Removed.
10331 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
10332 (parse_cmd_name) Removed.
10334 * data-list.c: Comment fixes.
10335 (data_list_pgm) Removed `eof' member.
10336 (static var first) New var.
10337 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
10338 FILE TYPE file inside FILE TYPE structures.
10339 (append_var_spec) Appends to *first, not dls.spec.
10340 (parse_fixed) Message fixes.
10341 (struct rpd_num_or_var) New.
10342 (struct repeating_data_trns) New.
10343 (static var rpd) New.
10344 (cmd_repeating_data) New function.
10345 (parse_num_or_var) New function.
10346 (parse_repeating_data) New function.
10347 (read_one_set_of_repetitions) New function.
10349 * file-type.c: (cmd_file_type) Message fixes. Always
10350 default_handle to FILE TYPE file handle.
10351 (internal_cmd_record_type) Message fixes.
10353 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
10355 * repeat.c: Comment fix. Disable debugging.
10357 * temporary.c: (restore_dictionary) Sets splits to NULL and
10358 n_splits to 0 before destroying the variables because now doing
10359 this tries to remove split variables.
10361 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
10362 destroying the dictionary.
10363 (clear_variable) Removes a variable from splits after destroying
10366 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
10368 * cmdline.c: (set_compat) Removed.
10369 (pick_compat) Removed.
10370 (parse_command_line) Removed -c option.
10371 (pre_syntax_message) Removed -c option.
10372 (usage) Remove compatibility code.
10374 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
10375 (glob var compat) Removed.
10377 * compute.c: (type_check) Fixed messages about type mismatches.
10379 * data-list.c: (cmd_data_list) Removed compatibility code.
10380 (fixed_parse_compatible) Calls convert_negative_to_dash().
10381 Fixed bug where it only set the variable in fx.spec if it created
10382 the variable itself.
10383 (dump_fmt_list) Spelling fix.
10384 (cut_field) Removed compatibility code.
10386 * dfm.c: (cmd_begin_data) Don't require a command terminator on
10387 BEGIN DATA command.
10389 * expr-evl.c: (evaluate_expression) Implement LAG.
10391 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
10392 (parse_neg) Calls convert_negative_to_dash().
10393 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
10396 * expr.h: (struct expression_struct) Removed member max_lag.
10398 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
10399 (internal_cmd_record_type) Removed special handling to produce
10400 negative numbers from dash tokens.
10402 * getline.c: (static var DO_REPEAT_level) New var.
10403 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
10404 (handle_line_buffer) Copies the line into getl_buf; doesn't call
10405 copy_with_DO_REPEAT_substitutions().
10406 (getl_read_line) Maintains value of getl_mode. Calls
10407 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
10409 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
10411 * getline.h: (getl_mode) New glob var.
10413 * glob.c: Comment fixes.
10414 (init_glob) Restructured. Sets set_seed.
10415 (init_compat_dependent) Removed. All references removed.
10416 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
10417 (__htonl, __htons) Removed. (What were these for?)
10419 * lexer.c: (static var tbl) Dash set to class CNUM.
10420 (make_hexit) New function from data-out.c.
10421 (get_token_representation) Rewritten.
10422 (convert_negative_to_dash) New function.
10423 (lex_init_compat_dependent) Removed.
10424 (yylex) A dash is parsed as part of a number if it is followed by
10425 a digit. The ASCII representation of a number is copied to
10426 tokstr. String parsing farmed out to parse_string(). Comment
10428 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
10430 (preprocess_line) Line processing depends on interactive/batch
10431 mode, not on compatibility mode. Removed PC+ compatibility code.
10433 * loop.c: (loop_3_trns_proc) Comment fix.
10435 * main.c: Remove dead code.
10436 (main) Remove call to init_compat_dependent().
10438 * misc.c: (convert_fmt_ItoO) Make E format conversion more
10441 * print.c: (parse_string_argument) Calls
10442 convert_negative_to_dash().
10443 (fixed_parse_compatible) Calls convert_negative_to_dash().
10445 * repeat.c: (RPT_* defines) Removed.
10446 (struct rpt_numeric) Removed.
10447 (struct repeat_entry) New member type, changed `replacement' from
10449 (clean_up) Deallocation adapted to new repeat_entry.
10450 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
10451 usage. Creates vars for `type' of 1.
10452 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
10453 (store_numeric) Rewritten, new interface.
10454 (parse_numbers) Rewritten.
10455 (parse_strings) Rewritten.
10456 (find_DO_REPEAT_substitution) New function.
10457 (perform_DO_REPEAT_substitutions) New function.
10458 (copy_with_DO_REPEAT_substitutions) Removed.
10459 (debug_print) Rewritten.
10461 * set.q: Comment fix.
10462 (custom_results) Removed compatibility code.
10463 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
10464 compatibility code.
10466 * sysfile-info.c: (cmd_display) Removed compatibility code.
10468 * tokens.h: Comment fixes.
10469 (token types enum) Removed `toktype' typedef name for this int
10470 type. Removed SUBST. Restructured.
10472 * vars-atr.c: (discard_variables) Sets n_lag to 0.
10474 * vars-prs.c: Comment fix.
10476 * vfm.c: Comment fixes.
10477 (glob var n_lag) New var.
10478 (static vars lag_count, lag_head, lag_queue) New vars.
10479 (procedure) Removed argument nlag.
10480 (setup_lag) New function.
10481 (close_active_file) Discards lagging state.
10482 (lag_case) New function.
10483 (lagged_case) New function.
10484 (write_case) Lags a case if lagging.
10486 * weight.c: (cmd_weight) Removed compatibility code.
10488 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
10490 * getline.h: (struct getl_script) New members loop_index, macros.
10492 * getline.c: (getl_add_file) Sets first_line field to NULL.
10493 (getl_add_DO_REPEAT_file) New function.
10494 (handle_line_buffer) When the current line's length is negative,
10495 set the filename and line number. Increment line number after
10496 reading line. Pass the line to
10497 copy_with_DO_REPEAT_substitutions() for processing.
10498 (getl_close_file) Free DO REPEAT lines before freeing the
10499 filename, and just set the filename to NULL when doing this,
10500 because otherwise the filename gets freed twice.
10502 * glob.c: (glob var queuing) Removed. All references removed.
10504 * lexer.c: Comment fixes.
10505 (get_token_representation) New function.
10507 * repeat.c: Comment fixes.
10508 (struct repeat_entry) Replaced type and v union members with a
10510 (append_record) New function.
10511 (internal_cmd_do_repeat) Started reforming it for the new
10512 repeat_entry struct. Properly records filename changes in the
10513 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
10514 strncasecmp() result usage. Uses append_record() to simplify.
10515 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
10516 to add in the file.
10518 (copy_with_DO_REPEAT_substitutions) Started coding.
10520 [DEBUGGING] (debug_print_lines) New function.
10522 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
10524 * tokens.h: (macro is_id1, is_idn) New macros.
10526 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
10528 * cmdline.c: (static var pre_syntax_message) Changed `win'
10529 compatibility mode to `wnd'.
10531 * data-list.c: (fixed_parse_spss) Renamed
10532 fixed_parse_compatible().
10534 * glob.c: (init_glob) Excise unused code for
10535 program_invocation_short_name.
10537 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
10540 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
10542 * set.q: `win' compatibility renamed `wnd'.
10544 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
10546 * filename.c: [__WIN32__] Change the included Windows header files
10548 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
10549 second character is absolute.
10550 (dirname) Fix logic error. Don't printf() the results.
10551 (prepend_dir) Don't printf() the results.
10553 * getline.c: (handle_line_buffer) New function.
10554 (getl_read_line) Reads line with handle_line_buffer() when
10556 (getl_close_file) Discard line buffer data.
10558 * getline.h: Comment fixes.
10559 (struct getl_line_list) New struct.
10560 (getl_script_struct) Added line buffer members. These are hooks
10561 for use by DO REPEAT to allow it to insert virtual source code
10564 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
10565 Override Borland C++ stupidity that claims Windows has a console
10566 window size of 0x3.
10568 * repeat.c: This is in the process of being restructured from
10569 using a token-buffering approach to the DO REPEAT facility to
10570 using the more flexible approach of a line-buffering approach in
10571 conjunction with the getline module. Comment fixes.
10572 (struct tok_struct) Removed.
10573 (static vars queue_index, queue_head, queue) Removed.
10574 (static vars line_buf_head, line_buf_tail) New vars.
10575 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
10577 (pull_queue, destroy_queue) Removed.
10578 [DEBUGGING] (debug_print_tokens) Removed.
10580 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
10582 * file-handle.q: (prepend_current_directory) New function.
10583 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
10584 current directory before normalizing filename.
10586 * filename.c: (gnu_getcwd) New function.
10587 (absolute_filename_p) New function.
10588 (search_path) New argument, PREPEND. All references changed to
10589 pass NULL except those explicitly mentioned. Uses
10590 absolute_filename_p(). Prepends PREPEND before trying the
10592 (dirname, prepend_dir) New functions.
10594 * getline.c: (getl_get_current_directory) New function.
10595 (getl_include) Passes getl_get_current_directory() as PREPEND arg
10598 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
10600 * In several source files, the term `script' was replaced with
10601 `syntax file' inside error messages. Usage of the term `script'
10602 in the sense of a syntax file is now deprecated.
10604 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
10607 * dump-sysfile.c: (usage) Update message.
10609 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
10611 * getline.h: (glob var getl_include_path) Declare extern.
10613 * list.q: Define EXTERN as extern before #including somP.h.
10615 * var.h: Remove declaration of `disptype' variable.
10617 * vfm.c: (close_active_file) After switching the data sink to a
10618 data source, set vfm_sink to NULL, because it doesn't exist any
10621 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
10623 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
10624 _matherrl() to ignore all math errors.
10626 * sfm-read.c: (read_value_labels) When reading the labels from
10627 disk, read the little parts separately instead of as a struct;
10628 this avoids alignment problems.
10630 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
10631 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
10632 (write_header) Allocates and initializes elem_type.
10633 (sfm_write_case) Uses elem_type to determine how to handle each
10635 (sfm_close) Frees elem_type.
10637 * sfmP.h: Comment fix.
10638 [__BORLANDC__] Uses #pragma -a to adjust structure member
10641 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
10643 * Makefile.am: (fiasco_SOURCES) Remove display.c.
10645 * common.c: Fix typo.
10647 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
10648 sense of the condition.
10650 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
10651 line-continuation backslash.
10653 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
10655 * frequencies.q: (custom_grouped, add_percentile) Don't use a
10656 non-constant expression as an argument to sizeof.
10658 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
10659 undefine gettext macro because that's a conio function.
10661 * hash.h: (hsh_prime_tab declaration) Remove.
10663 * list.q: (write_fallback_headers) Move `leader' allocation out of
10664 main loop. Change to local_alloc() allocation.
10666 * output.h: Formatting fixes. Put __attribute__ in right place on
10667 function prototypes.
10669 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
10670 incorrect `SECOND_LOWEST_VALUE' references to proper
10671 `second_lowest_value'.
10673 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
10674 value. This way 2 out of 3 of the som files define the vars
10675 extern, the correct way, that actually works under BC++.
10676 (som_set_float) Don't use nonconstant initializers for a struct.
10678 * som-high.c: Add the standard alloca() header.
10679 (replicate_table) Add prototype.
10681 Merged DISPLAY routine.
10682 * sysfile-info.c: (AS_*) New enum series.
10683 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
10685 (cmd_display, display_macros, display_documents,
10686 display_variables) Stolen from defunct display.c.
10687 (describe_variable) New function.
10689 * temporary.c: [0] (display_tree) New debug function.
10690 (copy_variable) Performs shallow copy of value labels instead of
10691 deep copy; i.e., just copys the AVL tree and increments the
10694 * val-labs.c: Comment fixes.
10695 (do_value_labels) Optionally skip leading forward slash.
10696 (get_label) Creates only a single value label instead of many
10697 copies of one, and sets the reference count.
10699 * display.c: Removed.
10701 * dump-sysfile.c: New file, not yet complete.
10703 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
10705 For lots of source files I added more verbose_msg's. These aren't
10706 listed below as they have tested as being benign. In some cases
10707 these replaced debug_printf() calls.
10709 * output.c: (outp_read_devices) Message fix.
10711 * postscript.c: (output_encodings) Message fix. Reports errors on
10713 (postopen) Message fix.
10715 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
10717 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
10719 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
10722 * main.c: Remove <malloc.h> #include.
10724 * mis-val.c: (parse_numeric) Set .f member for each missing[]
10725 instead of trying to just set the missing[] itself, which is a
10726 gcc-specific idiom.
10728 * sfm-read.c: (read_variables) Same.
10730 * str.h: Add memmem() prototype.
10732 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
10734 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
10736 * Makefile.am: (q2c) Don't include any libraries in the link.
10738 * dfm.c: (force_line_buffer_extension) New macro.
10739 (count_tabs) New function.
10740 (tabs_To_spaces) New function.
10741 (read_record) Calls tabs_to_spaces() on the line being processed.
10743 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
10744 have to be compiled twice (once for CC, once for LOCAL_CC).
10746 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
10748 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
10749 (LDADD) Add @INTLLIBS@.
10750 (q2c) Add LIBS, @INTLLIBS@ to link step.
10752 * inpt-pgm.c: Turn off debugging.
10754 * postscript.c: (postopen) Format fix. local_free() blocks
10755 returned by local_alloc(); don't free() them.
10757 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
10759 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
10762 * data-list.c: (read_from_data_list_fixed) Pass proper value for
10763 LEN arg, not simply the full string length.
10765 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
10766 directories before generic temp file directories.
10768 * vfm.c: Disable debugging.
10770 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
10772 * get.c: Comment fix.
10773 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
10775 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
10777 * expr-prs.c: (debug_print_postfix) Conditionally included on
10778 GLOBAL_DEBUGGING. Removed out_header() reference.
10780 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
10782 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
10784 * ascii.c: Removed obsolete ascii_close_page() prototype.
10786 * command.c: (output_line) Comment fix.
10788 * data-in.c: Formatting fix.
10789 (parse_string_as_format) Now the `fc' argument is used only for
10790 the purpose of error messages; it is not an index into the string
10791 passed. All references changed.
10793 * data-list.c: Comment fix.
10794 (cut_field) Comment fix. Now returns the column number of the
10795 position of the field cut out on success.
10796 (parse_field) Added `column' argument. Puts the column numbers in
10798 (read_from_data_list_free, read_from_data_list_list) Record the
10799 column number returned by cut_field(), pass it to parse_field().
10801 * dfm.c: Comment fix.
10803 * do-ifP.h: Comment fix.
10805 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
10806 the SYSMIS function.
10808 * expr.h, exprP.h: Comment fix.
10810 * glob.c: (init_glob) Only calls setlocale() and family if
10813 * hash.h: Comment fix.
10815 * include.c: Comment fix.
10817 * output.c: Comment fix.
10819 * postscript.c: (ps_line_intersection) Simplified assertion.
10821 * repeat.c: Comment fix.
10823 * vars-atr.c: Comment fix.
10825 * vars-prs.c: Comment fix.
10827 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
10828 behavior with usage of postincrement.
10829 (memory_stream_read) Discards cases as it goes.
10831 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
10833 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
10836 * Most source files: Includes debug-print.h, related comment
10839 * cases.c: (alloc_val) Removed complex allocation code. Merely
10840 increments default_dict.nval and returns the former value.
10841 (envector, devector) Removed references to lv member of struct
10844 * common.h: (macro VME) Replaced complex definition with simple
10847 * data-list.c: (cmd_data_list) Sets vfm_source instead of
10848 read_active_file and cancel_input_pgm.
10849 (read_from_data_list, cancel_data_list) Removed.
10850 (data_list_source_read, data_list_source_destroy_source) New
10852 (glob var data_list_source) New var.
10854 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
10855 (cmd_begin_data) Improved criteria for an input program accessing
10856 the inline file. Still not perfect.
10858 * do-if.c: (do_if_trns_proc) Simplified debug output.
10860 * expr-prs.c: Comment fixes.
10861 [DEBUGGING] (debug_print_postfix) Simplified debug output.
10863 * file-handle.q: (fh_close_handle) Simplified debug output.
10865 * file-type.c: Comment fixes.
10866 (cmd_file_type) Sets vfm_source instead of read_active_file and
10868 (cmd_end_file_type) On failure, discards variables in place of
10869 just canceling the input program.
10870 (read_from_file_type) Renamed file_type_source_read.
10871 (cancel_file_type) Renamed file_type_source_destroy_source.
10872 (glob var file_type_source) New var.
10874 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
10875 (cmd_get) Initializes options to GTSV_NONE before passing to
10876 trim_dictionary(). Removed `lv' reference. Sets vfm_source
10877 instead of read_active_file and cancel_input_pgm.
10878 (cmd_save_internal) Initializes options before passing to
10879 trim_dictionary(). Local var `nval' removed.
10880 (dict_delete_run) Comment fixes.
10881 (trim_dictionary) Comment fixes. Disallows scratch variables if
10882 GTSV_OPT_SAVE set in options.
10883 (read_from_get) Renamed get_source_read.
10884 (cancel_get) Renamed get_source_destroy_source.
10885 (glob var get_source) New var.
10887 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
10888 read_active_file and cancel_input_pgm.
10889 (read_from_input_program) Renamed input_program_source_read.
10890 Simplified debug output.
10891 (cancel_input_program) Renamed
10892 input_program_source_destroy_source.
10893 (glob var input_program_source) New var.
10895 * loop.c: (loop_1_trns_proc) Simplified debug output.
10897 * main.c: (dump_token) Made eof output more explicit.
10899 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
10902 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
10903 code for always-memory or always-disk cases. malloc's case-list
10904 based on vfm_source_info.ncases. Explicit support for
10905 memory_stream via memory_source_cases.
10906 (do_external_sort) Sets vfm_source instead of read_active_file and
10908 (allocate_file_handles) The temporary directory permissions are
10909 set to 0700 instead of 0777.
10910 (allocate_cases) Formatting fixes. Simplified debug output.
10911 (output_record) Compacts the case if necessary before writing it
10913 (close_handle, open_handle_w) Simplified debug output.
10914 (write_initial_runs) Destroys vfm_sink, then sets it to
10915 sort_stream. Writes records to memory based on
10916 vfm_sink_info.case_size.
10917 (write_to_sort_cases) Renamed sort_stream_write().
10918 (merge) Simplified error handling. Simplified debug output.
10920 (read_from_external_sort) Renamed sort_stream_read().
10921 Reads records based on vfm_source_info.case_size.
10922 (sort_stream_write) Writes records to memory based on
10923 vfm_sink_info.case_size.
10924 (sort_stream_mode) New function.
10925 (glob var sort_stream) New variable.
10927 * temporary.c: (cmd_temporary) Simplified debug output.
10928 (copy_variable) Removed references to `lv'.
10930 * title.c: (get_title) Simplified debug output.
10932 * var.h: Comment fixes.
10933 (struct get_proc) Removed member `lv'.
10934 (struct variable) Removed member `lv'. Comment fixes.
10935 (glob vars read_active_file, write_active_file, cancel_input_pgm)
10937 (struct case_stream) New.
10939 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
10940 read_active_file references to use vfm_source.
10941 (init_variable, replace_variable) Removed references to `lv'.
10943 * vfm.c: Comment fixes.
10944 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
10946 (static var queue, qh, qt, n_lag) Removed. All references
10948 (glob var compaction_necessary, compaction_nval, compaction_case,
10949 paging) New variables.
10950 (record_case) Removed.
10951 (procedure) Comment fixes. Calls vfm_source->read() instead of
10952 read_active_file().
10954 (prepare_for_writing, arrange_compaction, make_temp_case,
10955 vector_initialization, setup_filter) New function.
10956 (open_active_file) Most of the code moved into the abovementioned
10957 new functions. Now sets temp_dict to &default_dict if there is no
10958 temporary dictionary, for convenience. New debug output.
10959 (close_active_file) Deals with changing the sink to the source.
10960 Calls finish_compaction(). Frees compaction_case. Mostly
10962 (glob vars disk_source_file, disk_sink_file) New vars.
10963 (destroy_active_file, read_from_memory) Removed.
10964 (disk_stream_init, disk_stream_read, disk_stream_write,
10965 disk_stream_mode, disk_stream_destroy_source,
10966 disk_stream_destroy_sink) New functions.
10967 (glob var vfm_disk_stream) New var.
10968 (glob vars memory_source_cases, memory_sink_cases,
10969 memory_sink_iter, memory_sink_max_cases) New vars.
10970 (memory_stream_init, memory_stream_read, memory_stream_write,
10971 memory_stream_mode, memory_stream_destroy_source,
10972 memory_stream_destroy_sink) New functions.
10973 (glob var vfm_memory_stream) New var.
10974 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
10975 named `more_cases'. Simplified debug output. Otherwise mostly
10977 (record_case) Moved into the stream drivers. Removed.
10978 (transform) Removed (was dead code).
10979 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
10980 common case that the splits don't change, we don't need to copy
10981 the case into prev_case again--pointless.
10982 (compact_case) New function.
10983 (finish_compaction) New function.
10985 * vfmP.h: Comment fixes.
10986 (DEV_* enum series) Removed.
10987 (struct storage) Renamed `stream_info'. Removed variant record.
10988 Removed `device' member.
10990 * debug-print.h: New file.
10992 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
10994 * autorecode.c: Turned off debugging.
10996 * data-list.c: (destroy_dls) Closes the associated file handle.
10998 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
10999 parse_variables() options.
11001 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
11003 * display.c: (display_variables) Really fixed null cell bug.
11005 * file-handle.q: (fh_close_handle) Changed debugging message.
11007 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
11008 parse_variables() options.
11010 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
11011 (cmd_list) Fails if no variables specified.
11012 (determine_layout) Writes blank lines manually.
11014 * loop.c: (loop_1_trns_proc) Made debugging code only print
11015 messages if debugging.
11017 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
11018 parse_variables() arguments.
11019 (main) Parses optional parenthesized options to varlist
11020 subcommands into sbc->message.
11022 * sfm-read.c: Format fix.
11024 * var.h: (FV_*) New enum series.
11025 (PV_*) New enum PV_NO_SCRATCH.
11027 * vars-prs.c: (find_var) Removed.
11028 (fill_all_vars) Takes FV_* enum instead of boolean third
11029 argument. Rewritten to deal with scratch as well as system
11031 (parse_variables) Error message on scratch variable if
11034 * vfm.c: (static var virt_begin_func) New var.
11035 (procedure) Sets up virt_begin_func.
11036 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
11037 after dump_splits(). For succeeding groups changes, calls
11038 virt_begin_func() instead of begin_func().
11040 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
11042 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
11045 * dfm.c: Added some debugging messages, disabled by default.
11046 (open_file_r) Fixed error message.
11047 (read_record) On eof on inline_file, instead of calling
11048 fh_close_handle(), simply jump to eof label like a normal file.
11051 * display.c: Thin lines between rows for certain kinds of
11052 listing. Fixed `null cell' bug.
11054 * error.c: (failure) Flush stdout, stderr before failing.
11056 * file-handle.q: (fh_close_handle) Added debugging message.
11058 * frequencies.q: (dump_full) Bottom line extends across entire
11059 table width. Changed title formatting.
11060 (dump_condensed) Changed title formatting.
11061 (dump_statistics) Fixed title formatting.
11063 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
11064 Sets default value of set_format.
11066 * list.q: (cmd_list) Calls blank_line() before determine_layout().
11067 Passes write_all_headers() to procedure() as pre-group func.
11068 (write_all_headers) New function.
11069 (determine_layout) Removed calls to write_header().
11070 Calls blank_line() before and after write_fallback_headers().
11072 * recode.c: (recode_trns_free) Only attempts to free head->map if
11075 * sfm-read.c: (read_variables) Allows `#' at beginning of system
11076 file variable names but gives a warning. Sets `left' based on
11077 first character being/not being `#'. On lossage frees dict->var.
11079 * som-high.c: (som_draw_title) Simplified title formatting.
11081 * vfm.c: (dump_splits) Fixed and changed splits formatting.
11083 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
11085 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
11086 beginning. Frees v_src, v_dest on successful exit. Frees
11087 h_trans[*], h_trans on lossage.
11088 (recode) Frees h_trans[*], h_trans.
11090 * dfm.c: (dfm_close) Formatting change.
11091 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
11092 longer allocates its own in inline_file.
11093 (open_file_r) Passes the local dfm_fhuser_ext to
11094 open_inline_file().
11095 (open_file_w) Message fix.
11096 (read_record) Buffer reallocation strategy changed. Frees
11097 ext->line even in inline_file to prevent leaks.
11098 (dfm_put_record) Fixed bug where `ext' was cached before the file
11099 was opened and thus it would be NULL when the file really was
11101 (cmd_begin_data) Sets up inline_file basics itself, then calls
11102 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
11104 * list.q: (write_line) Formatting fix.
11105 (clean_up) Minor strategy change. Sets proportional font after
11107 (determine_layout) Sets fixed font before writing regular headers,
11108 or after writing fallback headers.
11110 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
11111 and KEEP vars after using them.
11113 * postscript.c: (ps_init_driver) Frees x->family.
11114 (postopen) When loading fonts, free the temporary font name buffer
11116 (ps_text_set_font_by_position) Free temporary font name buffer
11118 (text) Fixed code that calculated `lig' so that `lig' always gets
11119 initialized. Formatting fix.
11121 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
11123 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
11124 cells, not xmalloc(), so that the cells will get destroyed
11127 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
11130 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
11132 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
11135 * dfm.c: Comment fix.
11137 * list.q: Comment fixes. Include somP.h. Removed static vars
11138 table, n_columns, n_rows, part. New struct list_ext. New static
11140 (n_lines_remaining, n_chars_width, write_line) New functions.
11141 (cmd_list, list_cases) Rewritten.
11142 (begin_row, end_row, flush_table) Removed.
11143 (write_header, clean_up, write_varname, write_fallback_headers,
11144 determine_layout) New functions.
11146 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
11148 * output.h: Comment fix.
11150 * postscript.c: Comment fix.
11151 (struct ps_driver_ext) Removed prop_size, fixed_size members;
11152 added font_size. All references changed.
11153 (ps_init_driver) Initializes font_size. Simplified space checking
11155 (static var option_tab[]) Removed prop-size, fixed-size; added
11157 (ps_option) Handles font_size.
11159 * som-high.c: Moved prototypes into somP.h.
11160 (som_init_driver) New function.
11161 (som_submit_table) Moved some code into new function
11163 (build_target) Moved some code into new function
11164 som_internal_eject_page().
11165 (som_eject_page) Uses som_internal_eject_page().
11166 (som_internal_eject_page) New function.
11168 * som-low.c: Moved prototypes into somP.h.
11170 * som.h: Formatting fixes.
11172 * somP.h: (struct som_driver_ext) Removed em_width;
11173 added prop_em_width, fixed_width.
11175 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
11177 * Makefile.am: Added `localedir' definition. Added
11178 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
11180 * ascii.c: (macro draw_line) Fixed capitalization.
11182 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
11183 compute.c, count.c, data-in.c, data-list.c, data-out.c,
11184 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
11185 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
11186 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
11187 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
11188 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
11189 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
11190 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
11191 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
11192 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
11193 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
11194 for internationlization.
11196 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
11198 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
11200 * do-if.c, sort.c, val-labs.c: Comment fixes.
11202 * glob.c: (init_glob) Uncommented, updated i18n support.
11204 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
11205 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
11206 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
11207 the declarations of macros taking arguments a lot nicer.
11209 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
11211 * error.h: Removed CE, CW aliases for SE, SW.
11213 * q2c.c: Removed explicit streq() definition since it's duplicated
11216 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
11217 stats.h, str.h, tokens.h: Made the declarations of macros taking
11218 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
11221 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
11223 * cmdline.c: Comment fixes.
11224 (pick_compat) Changed return type to int. Now, instead of setting
11225 glob var `compat' to the emulation, returns the emulation. All
11226 references changed.
11227 (parse_command_line) Added terminating null to end of
11228 `long_options' array definition.
11229 (pre_syntax_message) Fixes.
11230 (usage) Shows the default emulation in the syntax message by
11231 calling pick_compat().
11233 * getline.c: (getl_add_include_dir) Separates paths with
11234 PATH_DELIMITER, not DIR_SEPARATOR.
11236 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
11237 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
11239 * output.c: (outp_configure_macro) Make earlier definitions for a
11240 particular key override later ones for the same key.
11242 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
11244 * ascii.c: Comment fixes.
11246 * output.c: (outp_get_paper_size)
11247 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
11249 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
11251 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
11252 <errno.h>. GNU libc 2 enforces this!
11254 * command.c: (parse_cmd) Fixed problem with `else' clause being
11255 paired with wrong `if'. Comment fix.
11257 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
11259 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
11260 blp_getline() to getline().
11262 * output.c: (outp_eval_dimension) Changed the fix from last time;
11263 there was no variable `a'.
11265 * q2c.c: (get_line) Fixed boundary condition overrun bug.
11267 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
11269 * output.c: (outp_evaluate_dimension) Fixed handling of negative
11270 numbers having fractional parts. Added case of a fraction without
11271 a whole-number part.
11273 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
11275 * ascii.c: (ascii_text_get_font_position) Removed.
11277 * expr.h, exprP.h: Disabled debugging.
11279 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
11282 * output.h: (struct outp_class_struct) Removed
11283 text_get_font_position method. All references deleted.
11285 * postscript.c: Big change here. Fontmaps were completely
11286 eliminated because of a change in philosophy. Comment fixes.
11287 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
11289 (struct ps_driver_ext) `position', `fontmap', `prop_name',
11290 `fixed_name' members removed. New members `prop_family',
11291 `fixed_family'. `family' member changed to type char *.
11292 (static var ps_fontmaps) Removed.
11294 (ps_init_driver) Removed obsolete references, updated.
11295 Initializes `translate_x', `translate_y', `scale'. Doesn't read
11296 fontmap, of course. Refers to font names through internal_name
11297 rather than subversive means. Frees proper items.
11298 (static var option_tab[]) Removed `fontmap-file' option; renamed
11299 `fixed-font', `prop-font'.
11300 (ps_option) Corresponds to option_tab[].
11301 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
11302 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
11303 hash_family) Removed.
11304 (postopen) Generates font names from family names. Gets
11305 PostScript font name properly. New prologue file comment `!!!'
11307 (ps_open_page) Adds translate_x, translate_y to BP prologue
11308 function; gives SF argument floating-point format.
11309 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
11310 font name. Doesn't change font family.
11311 (ps_text_set_font_by_position) Generates Groff font name from font
11312 family name instead of through table lookup.
11313 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
11314 all references changed. Reduced to simple string assignment.
11315 (ps_get_font_name) Removed.
11316 (ps_get_font_family) Reduced to string return.
11317 (text) Doesn't save `position' since it no longer exists. Ugly
11318 kluge to save font family--fix soon?
11319 (load_font) Removed PostScript name argument.
11321 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
11323 * postscript.c: Comment fix.
11324 (ps_open_page) Puts scale factor in PostScript output.
11326 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
11328 * Makefile.am: Distcleans q2c.
11330 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
11332 * ascii.c: (delineate) Sets text size even if width is zero.
11334 * command.c: Comment fix.
11335 (static var cmd_table[]) Re-enabled EVALUATE command.
11336 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
11337 of comments in script files. Now more liberal on criteria for
11338 performing a state transition--if *anything* happened correctly,
11339 not just if *everything* happened correctly.
11341 * data-out.c: (convert_F) Comment fix. Why in the fsck does
11342 Checker segfault on formatting large numbers and why in the fsck
11343 hadn't I noticed this before?
11345 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
11347 * list.q: (cmd_list) Commented out the actual output routine
11348 because of various problems. Probably will abandon the idea of
11349 using the general `crushed tables' for the LIST procedure.
11351 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
11352 clearing it. Allocates a new var_by_name dictionary before trying
11353 to add members to it.
11355 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
11356 `sib'. Changed type of `node' argument.
11357 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
11358 avl_walk_inorder().
11359 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
11360 [DEBUGGING] Only deletes the variable from var_by_name if that var
11363 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
11365 * Makefile.am: Added include files to SOURCES. Added
11366 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
11367 includes rules for q2c. Added `boast' target.
11369 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
11371 * Makefile.am: Maintainer-clean Makefile.in.
11373 * Makefile.am: Fixed redundant EXTRA_DIST line.
11375 * ascii.c: Comment fixes.
11376 (ascii_line_vert) Fixed overly aggressive range check.
11378 * display.c: Removed dead code.
11380 * list.q: Turn debugging on.
11381 (flush_table) New debug code.
11383 * sfm-read.c: (read_value_labels) malloc's the structure before
11384 trying to assign to its members.
11386 * sfm-write.c: Comment fix.
11388 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
11390 (output_table) No arguments anymore--gets them through `som'
11391 global. New debug code. In crushed tables, now sets `htv' as
11392 well as `hv' to avoid bad confusion later.
11393 (dump_crush_page) New debug code.
11395 * som-low.c: (som_dump_crush_page) New debug code.
11397 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
11399 All source files: Broke long lines into multiple lines.
11401 * ascii.c: (ascii_close_page) Uses host_system var in place of
11402 HOST_SYSTEM constant.
11404 * cmdline.c: (var syntax_message[]) Broke into
11405 pre_syntax_message[] and post_syntax_message[].
11406 (usage) Outputs both parts, separated by driver list.
11408 * error.h: Fixed broken formatting.
11410 * expr-opt.c: (str_search, str_rsearch) New functions.
11412 * misc.c: (blp_getdelim) Removed. All references changed to
11414 (str_search, str_rsearch) Removed.
11415 (memrmem) New function.
11417 * misc.h: (blp_getline) Removed. All reference changed to
11420 * stat.h: New file.
11422 * filename.c: Includes "stat.h", not <sys/stat.h>.
11423 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
11425 * output.c: (outp_list_classes) Changed output formatting.
11427 * sfm-write.c: (write_header) Uses host_system var instead of
11428 HOST_SYSTEM constant.
11429 (write_rec_7_34) Extracts version numbers from the version string.
11432 * sort.c: Includes "stat.h", not <sys/stat.h>.
11434 * str.c: (strcasecmp) Removed.
11436 * title.c: (cmd_document) Uses host_system var instead of
11437 HOST_SYSTEM constant.
11439 * version.c: Generated on-the-fly by the Makefile instead of being
11442 * str.h: Comment fixes. Doesn't substitute for missing memmove or
11444 [!HAVE_STRNCASECMP] Declares strncasecmp().
11446 * version.h: Removed stray character. Comment fixes.
11447 (vars host_system, build_system) New vars.
11449 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
11451 * Most source files: Changed formatting of copyright notice; fixed
11452 FSF address; reformatted to better conform to GNU standards;
11453 comment fixes. Added markups to prevent GNU indent from messing
11454 up my beautiful formatting :-).
11456 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
11457 that GNU indent markups can be passed through without problems.
11459 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
11461 * get.c: Turned off debugging.
11463 * glob.c: (init_glob) Turned on save-file compression by default.
11465 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
11466 compression than was possible in save files.
11468 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
11470 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
11472 * frequencies.q: Removed Fiasco extensions. Updated calculation
11473 algorithms. Polished output format.
11474 (struct frq_info_struct) Removed members `max_degree', `min_n',
11475 all references removed.
11476 (macro frq_extensions) Removed.
11477 (static vars min_n, max_degree) Removed, all references removed.
11478 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
11479 calculate `min_n', `max_degree'.
11480 (postcalc) Passes new arg to dump_statistics().
11481 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
11483 (dump_condensed) Adds variable name title.
11484 (sum_freqs) Removed.
11485 (calc_stats) Updated calculation algorithm.
11486 (dump_statistics) Removed warning for too-few observations.
11487 Changed table formatting. Adds variable name title if passed new
11490 * output.h: Comment fix.
11492 * recode.c, sample.c, sort.c: Disabled debug code.
11494 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
11495 Improved debug code.
11497 * var.h: (enum series frq_*) Removed Fiasco extensions.
11499 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
11501 * command.c: Added PROCESS IF to command table.
11503 * Lots & lots of places, removed checks for NULLs preceding calls
11504 to free_expression(), which itself checks.
11506 * descript.q: Removed Fiasco extensions. Removed optimizations
11507 for non-weighted active files. Implemented some options.
11508 Finished polishing output format. Comment fixes. Merged
11510 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
11511 max_degree, min_n) Removed.
11512 (macro dsc_extensions) Removed.
11513 (struct dsc_info_struct) Removed `min_n' member, all references
11515 (internal_cmd_descriptives) Removed calculation of min_n,
11516 max_degree. Only deals with one `calc' routine instead of two
11518 (precalc) Eliminated redundancy. Updated for changes to
11519 descriptives_proc structure.
11520 (calc) Moved here from `descript.g'. Rewritten to calculate
11521 statistics via `moments about the mean' rather than by summing,
11522 summing squares, summing cubes, and so on.
11523 (postcalc) Rewritten for new-style statistical calculation.
11524 (display) Removed support for displaying variables across rows.
11525 No longer crushes the descriptives table. Removed ancient code.
11526 Added display of N, by variable and listwise.
11528 * descript.g: Removed; merged into `descript.q'.
11530 * expr-evl.c: (evaluate_expression) Now returns a double. For
11531 numeric results, it returns the result as well as storing it in
11532 the passed `value' structure if non-NULL. For string results it
11533 just returns 0.0 and it must be passed non-NULL. Many references
11534 to this function were optimized by use of this change, especially
11535 but not exclusively in `compute.c'.
11537 * frequencies.g: Comment fix.
11539 * glob.c: (glob var process_if_expr) New global var.
11541 * postscript.c: (static var option_tab[]) Corrected entry for
11543 (postopen) Sets x->size to x->prop_size.
11544 (ps_text_set_font_by_name) Sets font size as well as typeface for
11545 PROP and FIXED fonts.
11547 * sel-if.c: (cmd_process_if) New function.
11549 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
11550 (sfm_write_dictionary) Sets `n_cases' to 0.
11551 (sfm_write_case) Increments `n_cases'.
11552 (sfm_close) Attempts to seek the system file back to the header
11553 and write the number of cases in its proper slot.
11555 * som-frnt.c: (som_insert_table) Masks off expansion options since
11556 only SOPT_X_NORM seems to work sensibly.
11558 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
11559 with a `fixed' value of 2.
11561 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
11563 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
11564 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
11566 * var.h: (enum series dsc_*) Removed Fiasco extensions.
11567 (struct descriptives_proc) Removed `miss_noweight'; new members
11568 `X_bar', `M2', `M3', `M4', `min', `max'.
11570 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
11572 * vfm.c: (close_active_file) Cancels PROCESS IF.
11573 (write_case) Doesn't process cases unselected by PROCESS IF.
11575 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
11577 * glob.c: (glob var err) Removed.
11579 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
11580 doesn't have to take into account number of value labels since
11581 they're in a subtable anyway. Also, doesn't display more than 10
11582 value labels since we can't yet break pages in subtables.
11584 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
11586 * som-frnt.c: (som_change_table_size) Simple change for elegance
11587 that shouldn't change behavior.
11588 (som_set_value) Comment fix.
11590 * som-high.c: (som_submit_table) Message fix.
11592 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
11594 * command.c: Added SYSFILE INFO to command table.
11596 * file-handle.q: (fh_handle_filename) New function.
11598 * get.c: (save_trns_proc) Fixed a bug in padding of output data
11601 * main.c: (parse) New return value for command functions, -3.
11603 * misc.h: Comment fix.
11605 * output.h: Comment fixes.
11606 (macro COMPONENTS) Removed.
11608 * postscript.c: (write_text) Modified literal_chars[] so that `('
11609 and ')' are not written to the output in strings as literals.
11611 * sfm-read.c: (sfm_read_dictionary) New argument.
11612 (read_header) New argument. Sets the information structure's
11613 values from the header information.
11614 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
11615 bizarre Checker problem, I guess.
11616 (read_variables) Proper cleanup on lossage.
11618 * sfm.h: (struct sfm_read_info) New struct for use by
11619 sfm_read_dictionary().
11621 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
11622 currently used just for tables that can be dynamically resized and
11623 thus have to be allocated with arena_malloc() instead of
11624 arena_alloc(). All references changed.
11625 (som_change_table_size) New function.
11626 (som_insert_table) Bugfix: now inserts `cell', not `c'!
11628 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
11629 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
11632 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
11634 (draw_intersection) Now takes an argument specifying the table in
11635 question. All references changed.
11636 (draw_table_cell) New function.
11637 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
11638 (som_get_table_size) Many nice new explanatory comments.
11639 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
11641 * som.h: New enum series SOM_CREATE_* for use as create flags with
11642 som_create_table().
11644 * str.h: Moved a comment here from TODO.
11646 * sysfile-info.c: New file. Reference implementation.
11648 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
11650 * command.c: Added RENAME VARIABLES to table of commands.
11652 * data-in.c: (dls_error) Sets `cust_field'.
11653 (parse_N) Message fix.
11654 (parse_day_count) New function.
11655 (to_roman) Never outputs VX as a `short form' of V.
11656 (parse_month) Fixed parsing of Roman numerals.
11657 (parse_trailer) Message fix.
11658 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
11659 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
11660 the date is invalid.
11661 (parse_SDATE) Fixed swapped day, year.
11662 (parse_JDATE) Fixed bug for dates in 1582.
11663 (parse_DTIME) Allows days not between 1 and 31.
11664 (parse_numeric) Makes local copy of f.type for easier usage.
11667 * data-out.c: (convert_F) When outputting as scientific, properly
11668 sets f.type as fp->type.
11669 (insert_commas) Fixed operator precedence problem with setting of
11670 nitems. Changed strcpy to memcpy (no null terminator).
11671 (convert_date) Fixed FMT_JDATE: added 1900 to year.
11672 (convert_CCx) Essentially rewritten, but now it works.
11674 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
11675 feature of Fiasco).
11676 (display_documents) Implemented.
11678 * error.c: (glob var cust_field) New var.
11679 (vmsg) Displays cust_field as part of message classes DE and DW.
11681 * formats.c: (debug_print) Fixed to compile under updated
11684 * get.c: (cmd_get, cmd_save_internal) Close file handle on
11687 * misc.c: (parse_format_specifier) Formatting fix.
11689 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
11690 `n_rename' for clarity.
11691 (cmd_modify_vars) Initializes `forward' and `positional' at
11692 appropriate times. Frees lists of vars to rename on failure.
11693 Comment fix. Frees memory on success.
11694 (rearrange_dict) Simplified `for' loop condition.
11696 * rename-vars.c: New file (reference implementation).
11698 * set.q: (internal_cmd_set) Fixed `emu' test condition.
11700 * sfm-read.c: (read_header) File label is created only if file
11701 label in file is not blank.
11702 (read_variables) Initializes `dict' local variable.
11703 (read_documents) Proper behavior on lossage.
11705 * sfm-write.c: (write_header) Doesn't blank out the file label
11706 (why was this here to begin with?!)
11708 * temporary.c: (save_dictionary) File label is copied only if
11709 non-NULL. Doesn't try to xstrdup() dictionary documents.
11710 Adapted so as to not irritate Checker.
11711 (free_dictionary) Only destroys var_by_name if non-NULL.
11713 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
11714 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
11715 lines to the document, indents the document. Also, it works now.
11716 (add_document_line) New function.
11718 * var.h: (struct dictionary) Reordering.
11720 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
11721 bits if it was allocated to begin with.
11723 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
11725 * command.c: Added MODIFY VARS to list of commands.
11727 * configure.in: Updated custom macros for autoconf 2.12. Removed
11728 mmap reference; fixed termcap library reference.
11730 * display.c: (display_variables) Fixed a few bugs although it's
11731 still not well written.
11733 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
11734 (induce_segfault) Calls chkr_disp_call_chain() instead of
11735 inducing an actual SIGSEGV.
11737 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
11738 str_search() and str_rsearch(). Fixed tests for matches on
11739 OP_INDEX and OP_RINDEX.
11741 * filename.c: (good_getcwd) Removed as the new libc for Checker
11742 doesn't contain this bug, apparently.
11744 * misc.c: (str_search, str_rsearch) Changed order of arguments for
11745 consistency with GNU memmem.
11746 (blp_getdelim) Changed `len' from `int' to `size_t'.
11748 * modify-vars.c: Reference implementation.
11750 * som-frnt.c: (zero_length) New global var.
11751 (som_create_table) Message fix.
11753 * som.h: Added gcc attributions to som_set_text(),
11754 som_output_text() prototypes. blank_line() refers to
11755 zero_length[] instead of a literal null string to suppress gcc
11758 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
11759 (allocate_cases) Decrements x_max so the last element of x[] can
11760 be used by the algorithm.
11762 * var.h: Changed minor details of `variable' declaration.
11763 (struct modify_vars_proc) New struct.
11764 (struct variable) Added field p.mfv.
11766 * vars-atr.c: Comment fix.
11768 * vars-prs.c: (fill_all_vars) More optimal implementation.
11770 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
11771 character, which it shouldn't have to do but printf() seems to
11772 read the null byte even though I supply a maximum length...
11774 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
11776 * command.c: Removed command alias X for QUIT.
11777 (parse_cmd) Fixed comment parsing.
11779 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
11781 (read_record) Fixed references to len, size.
11782 (dfm_get_record) Restructured.
11784 * file-handle.h: (struct file_handle) Field `lrecl' now of type
11787 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
11790 * modify-vars.c: New file. Not complete.
11792 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
11795 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
11796 problems caused by int/size_t differences.
11798 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
11801 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
11802 being compared were of equal length.
11804 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
11806 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
11808 * lexer.c: (get_dotted_rest_of_line) New function.
11810 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
11813 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
11814 type 6 records. Frees the dictionary properly.
11815 (read_header) Initializes the dictionary instead of letting
11816 read_variables() do it. Sets the dictionary file label from the
11818 (read_documents) New function.
11820 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
11821 write type 6 record if appropriate.
11822 (write_header) Writes file label from dictionary.
11823 (write_documents) New function.
11825 * temporary.c: (save_dictionary, restore_dictionary,
11826 free_dictionary) Properly handle new fields in dictionary struct.
11828 * title.c: (get_title) Returns after failure().
11829 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
11830 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
11832 * var.h: (struct dictionary) New fields `label', `n_documents',
11835 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
11837 * command.c: Added FILTER to list of commands.
11839 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
11842 * get.c: (cmd_save_internal) Removed weighting code since it's now
11843 handled by sfm-write.c. Properly commented out debug code.
11845 * glob.c: (glob var weighting) Removed.
11847 * sel-if.c: Comment fixes.
11848 (cmd_filter) New function.
11850 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
11851 (sfm_read_dictionary) Sets weighting variable direct in the
11852 created dictionary now. (Apparently we previously didn't support
11854 (read_header) Sets weight_index field in sfm_fhuser_ext from
11855 header read from disk.
11857 * sfm-write.c: (sfm_write_dictionary) Comment fix.
11858 (write_header) Now sets the weighting in the header from the
11859 passed primary dictionary instead of from the sfm_write_info.
11861 * sfm.h: (struct sfm_write_info) Removed field `weight'.
11863 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
11864 broke on boundary conditions.
11866 * var.h: (struct dictionary) New fields `weight_var',
11867 `weight_index', and `filter_var'.
11868 (glob var weighting) Removed. This is now part of struct
11869 dictionary. All references changed; the less mechanical changes
11870 are described above.
11872 * vars-atr.c: (find_dict_variable) New function.
11874 * vfm.c: (static var filter_index) New variable.
11875 (open_active_file) Initializes filter_index from default_dict.
11876 (write_case) Calls proc_func() only if the filter variable is
11877 nonzero; this implements FILTER behavior.
11879 * weight.c: (static var weight_varname) Removed.
11880 (cmd_weight) Modified default_dict instead of glob vars.
11881 (update_weighting) Changed the signature to modify a dictionary
11882 instead of glob vars. Now returns the weighting variable.
11883 (get_weighting_variable) Removed; its function is absorbed by
11884 update_weighting().
11885 (stop_weighting) Operates on a dictionary now.
11887 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
11889 * sort.c: Removed debugging info from messages.
11890 (do_external_sort) Cleans up after itself by deleting the
11891 temporary directory on failure. (On success it is deleted by the
11893 (allocate_cases) Removed debug code. Added clean up code.
11894 (output_record) Removed debug code.
11895 (merge) Added code to close all the input files that are currently
11896 open. This is a likely location for bugs, because I'm not sure
11897 about boundary conditions. Removed an unnecesary heap_delete().
11898 (merge_once) Removed input file "optimization" that in fact
11899 screwed up the rest of the code. Message and comment fixes.
11901 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
11903 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
11905 * heap.c: (heap_delete) New argument.
11907 * sort.c: Finished implementation of external sort.
11909 * vfm.c: (read_from_disk) Returns after a disk error.
11911 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
11913 * sort.c: (static var state) Removed.
11914 (static vars max_handles, tmp_basename, tmp_extname,
11915 huffman_queue) New variables.
11916 (do_external_sort) Moved most code to new functions.
11917 Creates huffman_queue.
11918 (allocate_file_handles, allocate_cases) New functions.
11919 (static vars run_no, run_length, file_index, case_count) New
11921 (output_record) Returns success. Now really writes to the output
11923 (begin_run, end_run) New functions.
11924 (write_initial_runs) Returns success. Initializes run_no to -1.
11925 Calls begin_run(), end_run() at appropriate times. Outputs debug
11927 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
11929 (merge) New function.
11931 * heap.c, heap.h: New files. Hopefully in near-final form.
11933 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
11935 * glob.c: Added write_active_file to global vars.
11937 * sort.c: Several new miscellaneous static variables.
11938 (cmd_sort_cases) Big comment fix.
11939 (perform_case_2) Renamed `do_external_sort' and completely
11941 (case_2_proc_func) Removed.
11942 (output_record, write_initial_runs, write_to_sort_cases,
11943 compare_record) New functions.
11945 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
11947 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
11949 * sort.c: (perform_case_2) Changed the method for allocation of
11950 lots of memory--now allocates one case at a time in hopes that
11951 more cases can be allocated with heavily fragmented memory.
11953 * var.h: (write_active_file) New global var.
11955 * vfm.c: (procedure, close_active_file, write_case,
11956 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
11957 arguments to procedure() to be NULL. All references to
11958 procedure() that made use of dummy functions were changed to NULL
11960 (open_active_file) If write_active_file is non-NULL, the output
11961 device becomes DEV_PGM (a new enum).
11962 (close_active_file) Sets write_active_file to NULL.
11963 (read_from_memory) Comment fix.
11964 (record_case) Calls write_active_file() when the output device is
11967 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
11969 * sort.c: New file.
11971 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
11972 Fixed checking for duplicate varnames.
11973 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
11975 (autorecode_trns_free) Destroys hash tables for each recoding
11977 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
11979 * command.c: Added SORT CASES to cmd_table.
11980 (null_func, null_int_func) Prototyped.
11982 * descript.g: (calc_weight, calc_noweight) Computes own case
11985 * frequencies.q: (dump_statistics) Fixed problem with
11986 too-few-cases warning message.
11988 * get.c: (cmd_save_internal) Handles weighting properly.
11990 * hash.c: (hsh_dump) Output format changed.
11991 (force_hsh_insert) Actually works now, prototype changed.
11993 * list.q: (static var case_num) New variable.
11994 (cmd_list) Initializes case_num.
11995 (list_cases) Increments case_num.
11997 * var.h: Added definitions for SORT CASES. Comment fixes.
11999 * vfm.c: Some definitions moved to new file vfmP.h. Comment
12000 fixes. `active' renamed vfm_active, `rep' renamed
12001 vfm_replacement, all references changed.
12002 (procedure) The procfunc no longer receives a case number. All
12003 references changed.
12004 (write_case) Subtle reordering.
12005 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
12008 * weight.c: (get_weighting_variable) New function.
12010 * vfmP.h: New file with definitions from vfm.c.
12012 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
12014 * command.c: (FILE_TYPE_okay) Commented out some tests because
12015 they're clumsy and not yet needed.
12017 * var.h: Most *_trns structures moved to their respective source
12018 files. Some were moved into a new file, do-ifP.h. Comment fixes.
12019 (union any_trns) Changed to a typedef for trns_header.
12020 (struct input_program_pgm) Removed.
12022 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
12023 was allocated in the first place.
12025 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
12027 * autorecode.c: New file.
12029 * command.c: Added AUTORECODE to command table; re-enabled SET.
12031 * data-out.c: (convert_F) Handles infinities and NaNs properly.
12033 * error.c: (vmsg) Comment fixes.
12035 * hash.c: Comment fix.
12036 (hashpjw_d) New function.
12037 (hashpjw) Reimplemented as call to more general function
12039 (internal_comparison_fn) Initializes pointers properly.
12040 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
12041 (force_hsh_insert, force_hsh_find) New debugging wrapper
12044 * main.c: (main) Message fix.
12046 * output.c: (outp_read_devices) Message fix.
12048 * set.q: Comment fixes.
12049 (custom_results) Implemented Wnd/X form of subcommand.
12050 (set_routing) New function.
12051 (internal_cmd_set) Implemented ERRORS, MESSAGES.
12053 * settings.h: (SET_ROUTE_*) New enum series.
12054 (set_results) Renamed set_results_file, all references changed.
12055 (set_messages) Removed.
12056 (glob vars set_errors, set_messages, set_results) New vars.
12058 * title.c: (get_title) Remembers to xstrdup() the result of
12059 get_rest_of_line().
12061 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
12063 (union any_trns) New element `arc'.
12065 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
12067 * command.c: (output_line) Removed references to set_screen.
12069 * error.c: (static var terminating) New var.
12070 (hcf) Sets terminating to 1.
12071 (vmsg) If terminating is nonzero, does not attempt to call hcf().
12072 This prevents an infinite loop if an error occurs within hcf().
12074 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
12075 statement circumlocution with `case 42000' trick.
12076 (evaluate_expression) New support for OP_STR_MIS.
12078 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
12079 statement circumlocution with `case 42000' trick.
12080 (dump_node) Handles OP_STR_MIS.
12082 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
12083 variables exceptions.
12084 (parse_function) Message fix.
12085 (ops[]) Added OP_STR_MIS.
12087 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
12089 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
12091 * glob.c: Removed set_scrnfile glob var.
12092 (init_glob) set_errorbreak set to 0 by default.
12094 * groff-font.c: Changed included files.
12095 (groff_read_font) Initializes font_arena local var correctly.
12096 (default_font) New function.
12098 * output.c: Comment fixes.
12099 (glob var disabled_devices) New variable.
12100 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
12102 [GLOBAL_DEBUGGING] (reentrancy) New function.
12103 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
12104 outp_iterate_enabled_drivers) Calls to reentrancy().
12105 (destroy_list) New function.
12106 (outp_done) Moved code to destroy_list().
12107 (parse_options) Parses `listing', `screen', `printer' options
12109 (configure_driver) Sets new `device' member of driver.
12110 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
12112 * output.h: Comment fixes. New enum series OUTP_DEV_*.
12113 (struct outp_driver_struct) New member `device'.
12115 * postscript.c: (find_encoding_file) Doesn't display its own error
12117 (default_encoding) New function.
12118 (switch_font) Calls default_encoding() if no encoding can be
12120 (text) Makes up a character metric if none exists for the desired
12122 (load_font) Properly copies a fallback filename. Calls
12123 default_font() for a font if none at all are known.
12125 * set.q: Comment fixes. Removed OUTPUT subcommand.
12126 (custom_listing) Calls outp_enable_device() to enable/disable
12128 (turn_screen_on) Removed.
12129 (internal_cmd_set) Calls outp_enable_device() to enable/disable
12130 screen, printer devices.
12132 * settings.h: Comment fixes.
12133 (glob vars set_output, set_printer, set_screen, set_scrnfile)
12136 * som-high.c: (som_submit_table, som_eject_page) Use
12137 outp_iterate_enabled_drivers() instead of iterating
12138 outp_driver_list directly.
12140 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
12142 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
12143 (parse_string_as_format) Handles new formats.
12144 (parse_numeric) Now handles DOT and PCT formats.
12146 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
12148 (convert_date) Handle EDATE and SDATE formats.
12149 (convert_CCx) Now if there's not room for the currency characters,
12150 converts it as F format if it's positive instead of giving up
12151 quickly. Also fixed save-and-restore bug with decimal point
12153 (convert_format_to_string) Handles new formats.
12155 * misc.c: (formats[]) Added new formats.
12156 (convert_fmt_ItoO) Supports new formats.
12158 * sfm-read.c: (parse_format_spec) Supports new formats. Better
12159 data checking. New argument, all references changed.
12161 * sfm-write.c: (write_format_spec) Supports new formats.
12163 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
12166 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
12168 * cmdline.c: Comment fixes.
12169 (parse_command_line) Changed return type to void.
12171 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
12173 (parse_numeric) Handles international numbers (comma as decimal
12174 point). Some reformatting.
12176 * data-list.c: (parse_free) Default output format is now
12177 set_format instead of hard-coded F8.2.
12178 (read_from_data_list_list) Emits error message on undefined data
12179 only if set_undefined is nonzero.
12181 * data-out.c: (convert_E) Changes decimal point from period to
12182 comma if appropriate. Restructured. Better comments.
12183 (convert_F) Changes decimal point from period to comma if
12185 (insert_commas) Major bug with handling of negative values fixed.
12186 Also, inserts periods instead of commas if appropriate.
12187 (convert_CCx) New function.
12188 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
12189 (num_to_string) Changed `.' to set_decimal.
12191 * dfm.c: Comment fixes.
12192 (dfm_close) Frees ext->line even in inline_file.
12193 (open_inline_file) New function.
12194 (open_file_r) When opening the inline file: now properly
12195 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
12197 (read_record) Calls fh_close_handle() instead of dfm_close() to
12198 close the inline file. Makes a copy of the line getl_buf to avoid
12199 interlock problems.
12200 (dfm_get_record) Restructured. Now checks the return value of
12202 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
12203 checking for use of inline file. No longer tries to close inline
12206 * error.c: (glob var error_already_flagged) New var.
12207 (vmsg) Message change. Now checks max number of errors/warnings,
12210 * file-handle.q: (fh_handle_name) Now allows closing of
12212 (fh_init_files) Reformatted.
12214 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
12216 * getline.c: (getl_include) Fixed bug that popped up when called
12217 when file queue was empty.
12218 (read_console) Resets error_count, warning_count,
12219 error_already_flagged to zero.
12221 * glob.c: Many changes to update list of variables.
12222 (init_compat_dependent) Now this function is called whenever
12223 `compat' changes. It now sets set_seed only if it hasn't
12224 previously been referenced. It now calls
12225 lex_init_compat_dependent().
12227 * include.c: (cmd_include_at) Frees temporary buffer instead of
12229 (cmd_include) Doesn't make copy of include file name.
12231 * lexer.c: Comment fixes.
12232 (init_lex) Moved some code into new function
12233 lex_init_compat_dependent().
12234 (lex_init_compat_dependent) New function.
12235 (hex_val) Simplified.
12236 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
12238 * main.c: Comment fixes.
12239 (main) Reformatted.
12241 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
12242 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
12243 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
12244 (setup_randomize) Sets set_seed_used.
12246 * set.q: Comment fixes.
12247 (custom_results) Conditionalizes on `compat'.
12248 (custom_log) Calls custom_journal().
12249 (set_ccx) New function.
12250 (cmd_set) Calls init_compat_dependent() when `compat' changes.
12251 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
12252 when set_decimal changes. Range-checks values for MITERATE,
12253 MNEST. Message fixes.
12255 * settings.h: Comment fixes.
12256 (struct set_cust_currency) New struct.
12257 (set_cc[], set_grouping, set_seed_used) New global vars.
12259 * var.h: (FMT_CCA...FMT_CCE) New output formats.
12260 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
12262 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
12264 * glob.c: Revised variables to correspond to settings.h.
12265 (init_glob) Initializes variables from settings.h properly.
12267 * set.q: Began long-overdue major revision to correspond to new
12268 philosophy. Most code changed.
12270 * settings.h: Mostly changed; reorganized, reordered, large new
12273 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
12275 * get.c: (cmd_save_internal) No longer forces compression off.
12277 * sfm-read.c: (read_compressed_data) If eof is reached when
12278 reading a new instruction octet, only signal error if we're in the
12281 * sfm-write.c: (COMPRESSION_BIAS) New #define.
12282 (struct sfm_fhuser_ext) New member `end'.
12283 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
12284 (ensure_buf_space) New function.
12285 (sfm_write_case) Reimplemented in order to support compression.
12286 (sfm_close) Writes out the remaining contents of the compression
12289 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
12291 * command.c: Defined SAVE and XSAVE commands in command table.
12293 * common.h: second_lowest_value is of type flt64, not double.
12295 * file-handle.h: Comment fix.
12297 * get.c: Comment fixes.
12298 (static var `trns') New.
12299 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
12300 cmd_save_internal, cmd_save, cmd_xsave) New functions.
12301 (dict_delete_run) Clears the variables and frees them now.
12302 (trim_dictionary) Sets default for compression.
12303 On KEEP subcommand, frees deleted variables as well as clearing
12304 them. Finally got the sense of the test for deleting all
12306 [DEBUGGING] (dump_dict_variables) Message fix.
12308 * glob.c: (init_glob) set_compression set to 1 by default.
12310 * list.q: Properly #includes config.h.
12312 * misc.h: New macro REM_RND_UP.
12314 * settings.h: Comment fix.
12316 * sfm-read.c: (structs sysfile_header, sysfile_format,
12317 sysfile_variable; inline function bswap_int32) Moved to new file
12319 (corrupt_msg) [__CHECKER__] No longer induces segfault.
12320 (sfm_read_dictionary) Fixed bug caused by failing to initialize
12322 (read_machine_flt64_info) Fixed some problems caused by confusion
12323 between flt64 and double types.
12324 (read_header) Message fix.
12325 (read_variables) Fixed set of cases in which we byte-swap sv.print
12326 and sv.write. Fixed confusion of flt64 and double.
12328 * sfm.h: (struct sfm_write_info) New.
12330 * som-high.c: (som_draw_title) Properly frees `s'.
12332 * temporary.c: (save_dictionary) Comment fix.
12334 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
12335 (struct trns_header) Formatting fix.
12336 (struct save_trns) New.
12338 * vars-atr.c: (discard_variables) Comment fix.
12340 * sfm-write.c: New file, baseline release.
12342 * sfmP.h: New file, baseline release.
12344 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
12346 * cmdline.c: (parse_command_line) `--version' output updated.
12347 (glob var syntax_message[]) Added my e-mail address.
12349 * file-handle.q, lexer.c, vfm.c: Changed many instances of
12350 `illegal' to `invalid'.
12352 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
12353 uncompression buffer.
12354 (sfm_close) Frees decompression buffer.
12355 (sfm_read_dictionary) Initializes decompression buffer.
12356 (buffer_input, read_compressed_data) New functions.
12357 (sfm_read_case) Restructured; now calls read_compressed_data() to
12358 handle compressed system file data.
12360 * var.h: Comment fix.
12362 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
12364 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
12367 * get.c: New comments. New static var `get_file'.
12368 (cmd_get) Now fully implemented. Calls discard_variables();
12369 initializes fv and lv for all variables; new debug code; sets
12370 up the dictionary; sets up the input program.
12371 (read_from_get, cancel_get) New functions.
12373 * sfm-read.c: Comment fixes.
12374 (sfm_close) New static function.
12375 (sfm_read_dictionary) Properly sets up the class of the
12376 file_handle. No longer cares what size the data is in records of
12377 type 7. Also, on failure, properly cleans up the file_handle and
12378 free()s some stuff.
12379 (read_variables) No longer thinks it knows `nval' of the
12380 dictionary. Now sets p.get.fv, etc., instead of speculatively
12382 (read_value_labels) Fixed off-by-one error in indexing of
12384 (sfm_read_case) New function.
12385 (sfm_r_class) New static var.
12387 * var.h: (get_proc) New struct.
12388 (struct variable) New member p.get.
12390 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
12392 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
12393 the manual's meaning.
12394 (rename_variables) New function.
12395 (trim_variables) Doesn't try to parse MAP any more. Removed debug
12396 code. Now properly reorders the dictionary on the KEEP keyword.
12398 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
12399 garbage collection.
12401 * vars-atr.c: (clear_variable) New argument `dictionary *'.
12402 (rename_variable) New function.
12403 (free_val_lab) Reformatted.
12405 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
12407 * var.h: Reindented entire file. Comment fixes.
12408 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
12410 (glob var default_dict) New.
12411 (struct indirect_dictionary) Removed.
12413 * Many other source files were changed to add `default_dict.'
12414 before all references to the dictionary of the active file.
12416 * vars-atr.c: (make_indirect_dictionary) Removed.
12418 * glob.c: Reindented all variable declarations. Updated for
12419 changed var.h. Comment fixes.
12421 * temporary.c: (restore_dictionary, save_dictionary) Simplified
12422 because now we can mainly copy dictionary structs.
12424 * vars-prs.c: (is_dict_varname, parse_dict_variable,
12425 parse_variables) Takes dictionary instead of indirect_dictionary
12427 (parse_variables) Instead of calling make_indirect_dictionary,
12428 just sets DICT to &default_dict if DICT is NULL. Of course, lots
12429 of `*dict.' references had to be changed to `dict->'. Removed
12432 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
12434 * get.c: Added GTSV_OPT_* series of enums.
12435 (trim_dictionary, dict_delete_run) New functions.
12436 [DEBUGGING] (dump_dict_variables) New function.
12437 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
12438 [DEBUGGING] Calls dump_dict_variables() to display results.
12440 * glob.c: (cmp_variable) Now a public function declared in var.h.
12442 * sfm-read.c: Turned off debug code. Comment fixes.
12443 (read_machine_int32_info, read_machine_flt64_info) New functions
12444 to parse type 7 records.
12445 (sfm_read_dictionary) Properly byteswaps several fields now.
12446 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
12447 records. [DEBUGGING] Dumps dictionary.
12448 (read_variables) Sets `index' field of variables created properly.
12449 Constructs avl tree of variables in dictionary. [DEBUGGING] No
12450 longer dumps dictionary.
12451 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
12453 [DEBUGGING] (dump_dictionary) No longer stubbed out.
12455 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
12456 var before destroying any variables just to save a little time.
12458 * var.h: (struct variable) Reordered in order to make name[] the
12459 first member; this makes pointers to `variable' pointers to the
12460 variable name, simplifying avl trees, etc.
12461 (struct indirect_dictionary) New struct.
12463 * vars-atr.c: (find_variable) Rewritten for efficiency.
12464 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
12466 (is_varname) Rewritten for efficiency.
12467 (parse_variables) New argument, which is a `dictionary *'. All
12468 references changed. This function now reads variable names from
12469 the dictionary passed, or from the default dictionary if NULL.
12471 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
12473 * misc.h: Added new macro DIV_RND_UP to perform integer division,
12474 rounding up. Changed many references to ROUND_UP to use this
12477 * sfm-read.c: Includes avl.h.
12478 (corrupt_msg) Induces a segfault under Checker.
12479 (macro assertive_bufread) New. Many references to bufread() now
12481 (sfm_read_dictionary) Split up into several functions. Added code
12482 to read dictionary records following the the type 2 records. Not
12483 quite complete. New variable `var_by_index'.
12484 (read_header, read_variables) New functions extracted from
12485 sfm_read_dictionary().
12486 (read_value_labels) New function.
12487 (bufread) Checks ferror() if fread() doesn't return the expected
12488 value; if ferror() is zero it's just EOF.
12489 (dump_dictionary) Stubbed out.
12491 * BTW: The source code now exceeds 50000 lines!
12493 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
12495 * command.c: Added GET to cmd_table[].
12497 * list.q: Removed reference to alloca headers.
12498 (cmd_list) Gave prototype.
12500 * sfm-read.c: Added DEBUGGING comments.
12501 (sfm_read_dictionary) Checks bias correctly. Sets
12502 dict->var_by_name to NULL. Calculates long_string_count
12503 correctly. realloc's dict->var[] array to minimum size.
12504 [DEBUGGING] Calls dump_dictionary.
12505 [DEBUGGING] (dump_dictionary) New function.
12507 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
12508 (restore_dictionary) If the dictionary contains a non-NULL
12509 var_by_name, uses that instead of generating one.
12510 (free_dictionary) Destroys var_by_name.
12512 * var.h: (struct dictionary) Added field `var_by_name'.
12514 * get.c: New file, not complete.
12516 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
12518 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
12519 (parse_num_or_range) New function.
12520 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
12521 <n> THRU HIGH missing values.
12523 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
12524 __attribute__((const)).
12526 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
12528 * sfm-read.c: Finished reference implementation.
12530 * sfm.h: Includes var.h.
12532 * var.h: Comment fixes.
12533 (struct `variable') Reordered some fields.
12535 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
12536 constants added previously.
12538 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
12540 * common.h: Comment fixes. Added declaration of
12541 `second_lowest_value' as variable or macro. Made `compat_type',
12542 `pgm_state_type' into anonymous enums.
12544 * display.c: Comment fix.
12546 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
12548 [!defined SECOND_LOWEST_VALUE] Added definition for
12549 `second_lowest_value' global var.
12550 (compat, pgm_state global vars) Changed types to `int'.
12551 (init_glob) Initializes `second_lowest_value'.
12553 * sfm-read.c: Continued work, not complete.
12555 * var.h: Added new MISSING_* constants to handle LOWEST and
12558 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
12560 * sfm-read.c: New file, not complete.
12562 * cases.c: (vec_insert) Changed vector expansion algorithm.
12563 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
12564 mucking up the RECODE transformation in particular.
12565 (envector) Harmless change in notation.
12567 dfm is now fairly well tested again.
12568 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
12570 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
12572 * recode.c: Comment fix.
12574 * sfm.h: Interface should be fairly final now, or at least for a
12577 * vfm.c: [DEBUGGING] (index_to_varname) New function.
12578 (open_active_file) [DEBUGGING] Translates ccase indices into
12579 variable names now to make it easier to understand what's really
12582 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
12584 * data-in.c: Comment fix.
12586 * data-list.c: Includes dfm.h.
12587 (do_reading) Uses new function dfm_push_cust().
12589 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
12590 `return 1;' at end.
12592 * file-handle.h: Completely changed. Some parts split off into
12593 new file dfm.h. Implemented in file-handle.q.
12594 (enum FH_*) Removed.
12595 (struct fh_ext_class) New struct.
12596 (struct file_handle) Retained only these fields: name, norm_fn,
12597 fn, recform, lrecl, mode. New fields class, ext.
12598 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
12599 close_handle, handle_name) Added `fh_' prefix to name, all
12600 references changed.
12602 * dfm.h: New file, implemented in dfm.c.
12603 (get_record, put_record, fwd_record, bkwd_record, set_record,
12604 get_cur_col) Functions moved from file-handle.h, now prefixed with
12606 (dfm_push_cust) New function.
12608 * sfm.h: New file. Incomplete.
12610 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
12611 interface. Functions reordered, comments changed. Not well
12612 tested, probably full of bugs.
12613 (struct dfm_fhuser_ext) New struct.
12614 (dfm_close) New function.
12615 (open_file_r) Pickier about finding `BEGIN DATA.' line.
12616 (open_file_w) User messages changed.
12617 (get_record) Comment fixed.
12618 (read_record) Increments ext->ln even for inline_file. Calls
12619 dfm_close() for inline_file when `END DATA.' encountered.
12620 (dfm_get_record) Experimental restructuring.
12621 (dfm_push_cust) New function.
12622 (cmd_begin_data) Detects whether the inline file was fully read by
12623 checking whether it is still open; detects whether it was read at
12624 all by checking whether the line number is greater than zero.
12626 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
12627 interface. Functions reordered, comments changed. Not well
12628 tested, probably full of bugs.
12629 (init_file_handle) Removed initializers for obsolete fields, added
12631 (fh_close_handle) Much simpler, now mainly calls the class
12633 (fh_init_files) Renamed inline file internal filename.
12635 * file-type.c: Includes dfm.h.
12636 (read_from_file_type) Doesn't use dfm internal state anymore.
12638 * inpt-pgm.c, print.c: Include dfm.h.
12640 * recode.c: (internal_cmd_recode) Casts strlen() return value to
12641 int in comparison with other int.
12643 * som-high.c: (build_target) Fixed operator precedence problem in
12644 if statement (& versus ==).
12646 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
12648 * dfm.c: (read_record) Can now read fixed-length records; not
12650 (put_record) Can now write fixed-length records; not tested.
12652 * file-handle.h: FH_* defines changed to enums. New enum series
12654 (struct file_handle) New members recform, lrecl, mode.
12656 * file-handle.q: Parser changed.
12657 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
12658 /LRECL subcommands. These are compatible with Windows.
12659 (init_file_handle) Initializes recform, mode fields.
12661 * q2c.c: (get_line) When outputting `!' comment lines, now
12662 increments the output file line number so that `#line' directives
12664 (make_identifier) New function that converts an arbitrary string
12665 into a valid C identifier.
12666 (dump_vars) Calls make_identifier() in two places in order to
12667 suppress some errors for bad identifiers.
12668 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
12669 for NO. Allows numbers to be prefixed by underscores to make them
12670 acceptable C identifiers but still to be parsed as numbers by the
12673 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
12675 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
12677 * dfm.c: Comment fixes. (get_record) Gives error if file handle
12678 was opened for writing.
12679 (open_file_w) New function.
12680 (read_record) Uses strncasecmp if available. Improved error
12681 messages, comments.
12682 (put_record) New function.
12684 * file-handle.h: Moved function comments into dfm.c and
12685 file-handle.q. Comment fixes. Removed declarations of
12686 tilde_expand() and normalize_filename().
12687 (struct file_handle) Changed `open' from boolean to enumerated
12688 field to allow for three states--closed, open for reading, open
12689 for writing--all references changed.
12691 * file-handle.q: Includes filename.h.
12693 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
12694 references changed.
12695 (alloc_line) Makes allowance for line terminator characters in
12697 (print_trns_proc) Now handles OUTFILE, WRITE differences.
12698 (print_space_trns_proc) Handles OUTFILE differences.
12700 * recode.c, sample.c: Comment fixes.
12702 * var.h: (struct print_trns) Changed boolean field `eject' to
12703 bitmapped field `options'; all references changed. New enums
12704 PRT_* for use with this field.
12706 * exception.h, test-exception.c: Removed.
12708 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
12710 * ascii.c: (delineate) Turned off debug output.
12712 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
12715 * data-in.c: (parse_string_as_format) Sets the entire string value
12716 to spaces, not just the short string part of it. Is this correct
12719 * data-out.c: (convert_date) Fixed DATETIME format problems with
12720 decimal places, removed debug code.
12722 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
12723 middle of parsing BEGIN DATA that would cause the lexer to read
12724 from a wild pointer `prog'; now calls new function
12725 preprocess_line() in lexer.c.
12727 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
12729 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
12730 Now call induce_segfault() to induce the segfault.
12731 (induce_segfault) New function.
12733 * expr-opt.c: Comment fix.
12734 (parse_sysvar) New function.
12735 (parse_primary) Added system variable support--calls
12737 (global var ops) Added OP_CASENUM operator.
12739 * expr.h: Comment fixes.
12740 (OP_* enum) added OP_CASENUM operator.
12741 (struct casenum_node) New struct.
12742 (union any_union_union) New member `cas' of type `casenum_node'.
12744 * glob.c: (global var last_vfm_invocation) New var.
12745 (init_glob) Initializes last_vfm_invocation.
12747 * lexer.c: (lookahead) Fixed reversed condition on if statement.
12749 * getline.c: (get_line) Split into get_line() and preprocess_line().
12750 (preprocess_line) New function.
12752 * var.h: Declares last_vfm_invocation.
12754 * vfm.c: (procedure) Sets last_vfm_invocation.
12756 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
12758 * command.c: (parse_cmd) Fixed bad assertion related to
12761 * data-in.c: (parse_month) Implemented to parse months according
12762 to full interpretation of standard.
12763 (to_roman) New function.
12764 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
12765 (parse_weekday) Bug fix (forgot to skip all the day name).
12767 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
12768 up parsing of multirecord data items. Also fixed user message.
12770 * data-out.c: Comment fix.
12771 (year2, year4, convert_date, convert_time, convert_WKDAY,
12772 convert_MONTH) New functions to support time & date output.
12773 (convert_format_to_string) Calls new time & date output routines.
12775 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
12777 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
12780 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
12782 * misc.c: (global var formats) Fixed declarations of DATETIME,
12785 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
12786 the output_char buffer.
12788 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
12789 memory bug. Fixed user messages.
12791 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
12793 * Removed #pragma argsused from lots of places.
12795 * data-in.c: Implemented zoned decimal and time-date formats.
12796 Untested. This is a huge chunk of code--maybe 1000 lines and 50
12799 * data-out.c: Implemented zoned decimal format.
12801 * expr.h: Moved yrmoda() declaration here from exprP.h.
12803 * misc.c: (global var formats) Minor fixes--added
12804 FCAT_SHIFT_DECIMAL to formats N and Z.
12805 (convert_fmt_ItoO) Added support for format Z.
12807 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
12809 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
12811 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
12812 som_check_workspace() that is activated between commands.
12814 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
12817 * list.q: (begin_row) Changed title expansion style from
12818 SOPT_X_VERT to SOPT_X_SHSP.
12820 * som-frnt.c: Now includes `somP.h'.
12821 (som_push_workspace, som_pop_workspace) New functions that, taken
12822 together, form a solution to the recursive table building problem
12823 mentioned yesterday. Surrounded every table output routine
12824 throughout the program with calls to these functions.
12825 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
12826 (som_create_table) Checks that there's an active workspace.
12827 (som_destroy_all_tables, som_crush) Removed.
12829 * som-high.c: (global var som_preserve_tables) Removed, all
12830 references deleted.
12831 (som_submit_table) Checks that there's an active workspace.
12832 (dump_columnated_table) Doesn't columnate tables that would have
12833 just one row per column.
12834 (dump_crush_page, som_dump_crush_page) Removed debugging code.
12835 (som_dump_crush_page) Moved row number labels from left side of
12836 tables to right side.
12837 (som_get_table_size) Added support for SOPT_X_SHSP.
12839 * som.h: New cell expansion type SOPT_X_SHSP.
12841 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
12843 (global var curtab_arena) Moved from som-frnt.c.
12845 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
12847 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
12848 that causes bad location warnings to be suppressed.
12849 (delineate) Saves current font when calling draw_text(); fixed
12850 handling of NULLs when backing up. Also fixed line-wrapping bug.
12852 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
12853 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
12855 * common.c: Added code to cause assertion failure to dump core
12856 when run under Checker.
12858 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
12859 there are still bugs.
12861 * glob.c: (__eprintf) Removed.
12863 * list.q: Inserted som_preserve_tables kluge that prevents tables
12864 from being thrown away due to recursive table building through
12865 som_output_line being called from a transformation during the LIST
12866 procedure invocation. This is a general problem that must be
12867 solved in a better way since it applies to all procedures in
12869 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
12870 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
12872 * numeric.c: Fixed several errors in the form of msg() calls.
12874 * print.c: Updated for use of som.
12875 (dump_table) Reimplemented.
12876 (print_trns_proc) Calls som_eject_page() instead of eject_page().
12877 Calls som_output_text() instead of outs_line().
12879 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
12881 (som_output_text) Function moved from som-low.c. Interface
12884 * som-high.c: (som_preserve_tables) New global public variable
12886 (som_submit_table) Destroys the tables only if som_preserve_tables
12888 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
12889 one subrow per row. Now labels subrows if there's more than one
12891 (dump_crush_table) Added wishlist comment.
12892 (som_eject_page) New public function declared in som.h.
12894 * som-low.c: (som_dump_crush_page) Draws row labels if there's
12895 more than one subrow per row.
12896 (som_output_text) Moved to som-frnt.c.
12898 * som.h: (SOM_TOPT_PRESERVE) Removed.
12900 * title.c: (get_title) Changed interface.
12901 (cmd_title) Changed `title' to `outp_title'.
12902 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
12904 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
12906 * list.q: (flush_table) Conforms to new partial options in
12907 som_submission_form.
12909 * som-high.c: (paginate_horizontally) Changed form of subrow
12911 (build_target) Omits spacing before table if
12912 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
12913 (dump_crush_page) Changed interface. Only trims bottom rule if
12914 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
12915 (dump_crush_table) Handles partial tables.
12916 (output_row_label) New function.
12917 (som_dump_crush_page) Emits subrow number labels. Draws vertical
12918 rule on the right edge of narrow subrows.
12920 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
12921 constants to a series of SOM_TOPT_PARTIAL_* submission options.
12922 All references updated.
12924 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
12926 * misc.c: Comment fix.
12928 * som-high.c: (examine_table) Treats crushed tables separates for
12929 purpose of determining header size.
12930 (paginate_horizontally) Allots space for line numbers in crushed
12931 tables with lots of subrows per row. Calculates the `maximum page
12932 width', the width of the widest horizontal page.
12933 (build_target) Removed trim argument; all references changed.
12934 Stricter assertions. (dump_crush_page) New function.
12935 (dump_crush_table) Reimplemented.
12937 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
12938 (som_dump_crush_page) Reimplemented, interface changed.
12940 * somP.h: Many many new helper macros for use with crushed tables.
12941 (global var som) Removed `tv', `cum_y' members; all references
12942 removed. New members `mpw', `digit_space'.
12944 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
12946 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
12947 variable, changed to constant 1024.
12948 (arena_ca_strdup) Changed `sizeof(a_string)' to
12949 `sizeof(c_string)'.
12950 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
12951 `(c_string *)' to `(char *)'; this fixed some offset problems.
12953 * filename.c: (readlink_malloc) Changed initial allocation from
12955 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
12958 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
12959 &fm->owner in several places.
12961 * som-high.c: (output_table) Changed interface to rest of world.
12962 (examine_crush_table) Removed. Crushed tables are re-broken now,
12963 in preparation for rewrite.
12965 * som.h: Comment fix.
12967 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
12969 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
12970 itself in the cleanup stage.
12972 * descript.q: (display) At least temporarily, changed the table
12973 format to a crushed table.
12975 * list.q: (begin_row) At least temporarily, added horizontal lines
12978 * som-high.c: (examine_crush_table) Sets som.hh to the width of
12979 the horizontal "headers," that is, to the width of the far left
12980 and far right rules.
12981 (justify_pagination) Sets som.th to the width of the widest row
12982 in the crushed table. Fixed inner loop off-by-one error.
12984 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
12987 * somP.h: Comment fix.
12989 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
12991 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
12992 before closing it; also, opens the constructed filename `s'
12993 instead of f->filename.
12995 * postscript.c: Moved initialization of x->loaded, x->prop,
12996 x->fixed, x->current, also the add_encoding() calls, into
12998 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
12999 sets x->last_font to NULL; sets x->next_combo to zero.
13001 * som-high.c: (crushed_row_height) Moved definition farther up.
13002 (som_submit_table) Doesn't calculate line width, font size until
13003 after calling open_page(), to accomodate changes to PostScript
13005 (vert_headers) Removed; equivalent functionality moved to
13006 examine_table(), examine_crush_table().
13007 (justify_pagination) Replaced with different algorithm.
13008 (dump_crush_table) Bugfix that caused tables to fail to be clipped
13009 at the bottom of the page.
13011 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
13013 * command.c: Added cmd_list back into cmd_table.
13015 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
13016 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
13018 * list.q: (flush_table) Updated to new som_submission_form format.
13020 * som-frnt.c: Comment fix.
13022 * som-high.c: Changed `#endif' to `#undef EXTERN'.
13023 (output_table) Calls som_get_table_size() directly; handles
13025 (examine_crush_table) New function; calls vert_headers().
13026 (examine_table) Moved some code into new function, vert_headers().
13027 (justify_pagination) New function.
13028 (dump_plain_table) Removed `static' from `cy'.
13029 (dump_crush_table) New function.
13031 * som-low.c: (som_dump_crush_page) New function.
13033 * som.h: Comment fixes.
13034 (enum SOM_TOPT_CRUSH) New.
13035 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
13036 Temporarily set to zero to make do with LIST procedure.
13038 * somP.h: Re-ordering.
13040 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
13042 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
13044 * somP.h: New file for use by som-high.c, som-low.c.
13046 * q2c.c: Added definition for VME.
13047 (get_line) Now dumps `!' comment lines to the output file
13050 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
13051 set.q: Changed format of `!' comment lines.
13053 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
13055 * All source files: Added copyright notice.
13057 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
13058 longs in msg() calls.
13060 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
13062 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
13064 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
13066 * output.c: (outp_read_devices) Changed criteria for
13067 distinguishing different types of lines.
13069 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
13071 * cmdline.c: Changed syntax message.
13073 * filename.c: (good_getcwd) Bug fix (?).
13074 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
13076 (search_path) Appends DIR_SEPARATOR to directory name only if it
13077 does not already end with one.
13079 * glob.c: Checks STAT_PAGER envvar before PAGER.
13081 * output.c: Checks environment variables instead of just local
13084 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
13086 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
13087 when the pointer passed to the function was within the arena
13088 itself, so that it couldn't properly be set to NULL _after the
13091 * command.c: Re-enabled DISPLAY.
13093 * display.c: Rewritten to handle tables. Untested.
13095 * filename.c: (search_path) Fixed memory leak.
13097 * frequencies.q: (cmd_frequencies) Frees v_variables.
13098 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
13099 (cleanup_freq_tab) New function to garbage collect.
13100 (dump_full) Elegantized.
13102 * main.c: New comment.
13104 * output.h: New tag for tagged quotes: TAG_NEWLINE.
13106 * postscript.c: Comment fix.
13107 (release_fontmap, free_font_entry) New functions.
13108 (ps_init_driver) Sets free_font_entry() as the freefunc for
13109 hashtable `loaded'. Calls release_fontmap() when destroying a
13110 driver; also frees the output filename; also frees the
13111 ps_driver_ext block.
13112 (free_ps_encoding) Frees the filename as well as the encoding
13114 (output_encodings) Frees the line buffer and pops the msg-filename
13116 (read_fontmap) Frees the fontmap filename and the line buffer.
13117 (postopen, preclose) Misc. garbage collection fixes.
13118 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
13119 to NULL; this fixes some output problems.
13120 (text) Handles TAG_NEWLINE. Untested.
13122 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
13123 (som_set_string) Removed. All references changed to
13125 (som_set_text) Rewritten. New interface. More general.
13127 * som.h: Minor format changes.
13128 (struct som_value_cell) Removed; all references changed to
13130 (enums SOT_*) Changed.
13132 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
13134 * command.c: Re-enabled SPLIT FILE.
13136 * postscript.c: Comment fix.
13138 * som.h: Added `SOT_NONE'.
13140 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
13142 * vfm.c: (dump_splits) Reimplemented.
13144 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
13146 * Compiled the project under gcc 2.7.2, which gave some new
13147 warnings. This led to many additions of casts from unsigned to
13148 int sprinkled throughout the code.
13150 * arena.c: Many uses of `unsigned' changed to `size_t'.
13152 * command.c: Added END FILE, END REPEAT to command table.
13153 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
13154 (find_command, FILE_TYPE_okay) Not commented out anymore.
13155 (parse_cmd) Calls FILE_TYPE_okay again.
13156 (output_line) Added calls to som_output_text() to put the line
13157 in the output files.
13159 * common.c: (macro VME) Format changes.
13160 (xstrdup) Asserts that its argument is not NULL.
13162 * data-list.c: Implemented dump_fixed_table().
13164 * inpt-pgm.c: Formatting changes. Comment changes.
13165 (end_case_proc) Renamed end_case_trns_proc.
13166 (cmd_end_file, end_file_trns_proc) New functions.
13168 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
13170 * misc.h: (local_strdup) New macro corresponding to strdup() but
13171 allocating its data through local_alloc() if possible--that is, if
13174 * postscript.c: Comment changes.
13175 (quote_ps_name, quote_ps_string, output_encodings) New functions.
13176 (output_line, add_string) New macros supporting
13177 output_encodings().
13178 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
13179 substitution vars. Calls output_encodings() when a line
13180 consisting of `!encodings' is encountered.
13181 (preclose) Some code moved into quote_ps_string().
13182 (dump_line) Changed into macro supporting dump_fancy_line().
13183 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
13184 command when appropriate.
13185 (write_text) Fixed `literal_char' array (I think it's fixed, at
13187 (text) Fixed bug when width was zero. Now exits immediately on
13188 zero height_left. Now, when executing `goto restart;', checks
13189 that cp<end, so that we don't read beyond end-of-string. Also,
13190 outputs the correct code to the output file by outputting the code
13191 from the metric instead of the internal metric index.
13193 * repeat.c: (cmd_end_repeat) New function.
13195 * som.c: (var som) `headers' renamed `options' and semantics
13196 changed. All references changed.
13197 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
13198 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
13200 (som_text_table) Removed.
13201 (som_output_text) New function.
13203 * som.h: (struct som_submission_form) Removed `header', `reuse',
13204 replaced with bitmapped field `options'.
13205 (SOM_TOPT_*) New enum set for som_submission_form.options.
13206 (SOT_*) New enum set for som_output_text().
13208 * temporary.c: (copy_variable) When copying the var label, only
13209 calls xstrdup() if it's non-NULL.
13211 * var.h: (enum type `vartype') Removed; all references changed to
13214 * vars-atr.c: (init_variable) Changed local var `nbytes' from
13217 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
13219 * font.h: Comment changes.
13221 * groff-font.c: (groff_read_font) Initializes `name' field to
13222 NULL. Handles `encoding' field.
13224 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
13226 * postscript.c: (struct font_entry) Removed `position' field.
13227 (struct ps_font_combo) New struct.
13228 (struct ps_driver_ext) Removed field `next_position'. New fields
13229 `combos', `next_combo'. `last_font' field changed from
13230 `font_entry *' to `ps_font_combo *'.
13231 (ps_init_driver) Reformatted; handles new fields. When
13232 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
13234 (get_encoding, find_encoding_file) New functions.
13235 (add_encoding) Some code moved out into find_encoding_file().
13236 (postopen) Changed value for ${title}.
13237 (preclose) Sets `loaded' field to NULL after destroying the hash
13239 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
13241 (ps_text_set_font_by_position) Figures out the current family if
13243 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
13244 (switch_font) Implemented.
13245 (write_text) Calls switch_font() more often. Format changes.
13246 #undefs its macros after they're no longer useful.
13247 (text) Changed `continue' at one point to a jump to the top of the
13248 loop because we don't want `separate' reset to 0 at that point.
13249 (load_font) No longer sets `position' in the font_entry created.
13251 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
13253 * font.h: (struct font_desc) New member `encoding', which is not
13254 properly handled yet.
13256 * glob.c: (init_glob) Some new i18n code, which is probably
13259 * output.c: (outp_read_devices, outp_get_paper_size) Changed
13260 `size' local from `int' to `size_t'.
13262 * postscript.c: New driver configuration parameter `auto-encode'.
13263 New enums OPO_AUTO_ENCODE, ODA_COUNT.
13264 (struct font_entry) New member `position'.
13265 (struct ps_driver_ext) Reordered. New hash table member
13266 `encodings'; new members `next_position', `next_encoding',
13267 `last_font'. Members `current', `prop', `fixed' changed from type
13268 `font_desc *' to `font_entry *'; all references changed.
13269 (struct ps_encoding) New struct.
13270 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
13271 free_ps_encoding, add_encoding) New functions.
13272 (ps_init_driver) Added OPO_AUTO_ENCODE to default
13273 x->output_options. Initializes new members of ps_driver_ext.
13274 Changed default value for prologue_fn, encoding_fn. Calls
13275 read_ps_encodings after loading default fonts.
13276 (option_tab[], ps_option) Handle new configuration parameter.
13277 (switch_font) New function.
13278 (struct output_char) `font' member changed from `font_desc *' to
13279 `font_entry *'. New member `separate'.
13280 (read_fontmap) Changed `size' from `int' to `size_t'.
13281 (output_line, put_number) New macros for write_text().
13282 (write_text) Optimizes text output by consolidating multiple
13283 calls to PostScript `show' operator.
13284 (text) Keeps track of when text arguments can't be consolidated by
13285 write_text(), and marks those spots in the output stream.
13286 (load_font) Sets `position' of the allocated font_entry to -1, cuz
13287 the font hasn't been switched to by switch_font(), which is where
13288 the position is important--the PostScript is what cares about the
13291 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
13293 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
13294 call a NULL free_func.
13295 (hsh_rehash) Elegantized.
13296 (hsh_probe) Fix bug that manifested when the table was expanded
13297 and thus had to change location in memory. Good thing
13298 too--otherwise could have been much more subtle.
13299 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
13300 (hsh_foreach) New function for hash table iteration.
13302 * hash.h: (struct hsh_iterator) New.
13304 * lexer.c: (parse_tagged_quote) Font and family name strings in
13305 tags are now null-terminated.
13307 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
13309 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
13310 documented. (Never before tested?)
13312 * output.h: Comment changes.
13314 * postscript.c: New driver options `optimize-text-size',
13315 `optimize-line-size', `max-fonts-simult'. New enum set for
13316 specing cached line types. Comment fixes.
13317 (struct line_form) New struct.
13318 (struct ps_driver_struct) New members `text_opt', `line_opt',
13319 `max_fonts', `lines'.
13320 (ps_init_driver) Initializes new members of ps_driver_struct.
13321 (user option type enum set) New member `nonneg_int_arg'.
13322 (static var option_tab[]) Supports new options.
13323 (ps_option) Handles new options.
13324 (find_ps_file) Made static. No longer calls hsh_dump().
13325 (ps_get_var) Made static.
13326 (preclose) Dumps out proper DSC trailer.
13327 (ps_open_page) Elegantized.
13328 (ps_close_page) Calls dump_lines() if appropriate.
13329 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
13330 wrappers around line().
13331 (int_2_compare, compare_line, dump_line, dump_fancy_line,
13332 dump_lines, hash_line, free_line, line) New functions for support
13334 (write_text, text) Made static.
13335 (text) Added to font support, not finished.
13337 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
13339 * font.h: (struct font_desc) New members ascent, descent.
13341 * groff-font.c: (groff_read_font) Calculates font ascent and
13342 descent from the ascent and descent of the `d' and `p' characters,
13343 respectively, as per a suggestion on comp.fonts.
13345 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
13346 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
13348 (write_text) Handles text right-justification and centering (not
13349 full justification). Still very inefficient. (One output line
13351 (struct output_char) Added fields for font and font size.
13352 (text) Many bugfixes.
13354 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
13356 * cmdline.c: (usage) Calls outp_list_classes().
13358 * font.h: Comment fix.
13360 * groff-font.c: New exported global var `space_index'.
13361 (groff_init) New function to initialize `space_index'.
13362 (hash_kern) Casts result to unsigned.
13363 (font_name_to_index) Renamed font_char_name_to_index. All
13364 references changed. Also, now returns the value of `space_index'
13365 when passed an ASCII space character as an argument. Fixed
13367 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
13368 Handles passed NULL pointers properly.
13370 * lexer.c: (parse_tagged_quote) Comment fix. Better range
13373 * output.c: (outp_list_drivers) Removed. Removed all references.
13375 * output.h: Comment fixes.
13377 * postscript.c: (ps_open_global) Calls groff_init().
13378 (output_char) New structure.
13379 (write_text) New function.
13380 (text) No longer stubbed out! Now the output is correct--with a
13381 few exceptions, one of them being that the page has to be held
13382 upside down into a mirror.
13384 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
13386 * font.h: Comment fix.
13388 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
13389 All callers changed.
13390 (number_to_index) Renamed font_number_to_index, made extern. All
13392 (font_get_kern_adjust, font_get_char_metrics) New functions.
13394 * output.h: New constant OUTP_T_INTERNAL_DRAW.
13396 * postscript.c: Changed default line width back to 1/2 point.
13397 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
13398 in the center of the space allotted for them, not just a fixed
13399 offset from the edge of the space; this fixes some bugs.
13400 (ps_line_intersection) Now supports all command line styles.
13401 (ps_text_get_size) Bug fix in computation of em width.
13402 (text) New function, the meat behind ps_text_metrics and
13403 ps_text_draw. Not complete.
13404 (ps_text_metrics, ps_text_draw) Removed the stub taken from
13405 ascii.c; call text().
13407 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
13409 * arena.c: (arena_free) Assert that the argument is non-NULL.
13411 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
13412 only if old_kern is non-NULL.
13414 * postscript.c: (ps_init_driver) Changed default line width to 1
13416 (postopen) New prologue variables.
13417 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
13418 more of the common line styles properly, but not all.
13419 (ps_text_metrics) Fixed problem with this stubbed out version that
13420 kept it from taking font sizes into account.
13422 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
13424 * arena.c: (arena_malloc) Bug fix.
13425 (arena_dump) [GLOBAL_DEBUGGING] New function.
13427 * ascii.c: Comment fix.
13428 (count_fancy_chars, delineate) Now static functions.
13430 * filename.c: (interp_vars) Bug fixes.
13432 * font.h: Comment fixes.
13434 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
13435 beginning in case we have an error message to display before
13436 initializing the display.
13438 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
13440 (groff_read_font) Bug fixes.
13441 (name_to_index) Increments hash.used. Sets `name' field of hash
13443 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
13445 * hash.c: Return type changed.
13447 * postscript.c: Continued development. Now marks lines on the
13448 paper, but very buggy.
13450 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
13452 * Changed comments in many source files from `/* xxx /* yyy */' to
13453 `/* xxx */ /* yyy */' for cleanliness.
13455 * arena.c: (arena_sd_strdup) New function.
13457 * ascii.c: (struct ascii_driver_ext) New member `file'.
13458 (ascii_init_driver) Fills out member `file' for initing; uses
13459 close_file_ext for closing drivers.
13460 (ascii_option) Changed %.*s back to %s because the a_string's are
13461 always null-terminated.
13462 (postopen, preclose) New functions.
13463 (ascii_open_page) Uses new style of open_file_ext.
13464 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
13465 instead of this->output.
13466 (__assert_fail) Removed.
13468 * cmdline.c: Changed syntax_message[].
13470 * error.c: #include's <readline/history.h> only if the history
13471 library is available, not if just the readline library is
13474 * filename.c: (expand_line) Removed alloca() support.
13475 (interp_vars) No longer tilde-expands argument. Limit on output
13477 (tilde_expand) Now treats argument as path rather than filename.
13478 [!unix] Now is a no-op function.
13479 (search_path) Better verbose message formatting.
13480 (open_file, close_file) Comment fixes.
13481 (close_file) [!unix] Doesn't bother with pipes.
13482 (open_file_ext) Completely rewritten, interface revamped.
13483 (close_file_ext) New function.
13485 * font.h: Comment changes.
13487 * frequencies.q: Removed AIX alloca support since it doesn't use
13490 * hash.c: Comment changes & additions.
13491 (hsh_create) Initializes entire table instead of first M entries.
13492 (hsh_probe) Stupid bug fixed. Now it works.
13493 (hsh_dump) [GLOBAL_DEBUGGING] New function.
13495 * main.c: (parse) Detects EOF properly in token-eating loop.
13496 Should the STOP token have its value changed to 0?
13498 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
13499 (blp_getline) Now it's a macro.
13501 * output.h: (struct outp_driver) Removed members output, filename.
13503 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
13504 drivers in driver table.
13505 (outp_read_devices) Frees buf. Warns if there are no active
13507 (outp_configure_clear) Sets outp_configure_vec to NULL after
13508 deleting its elements.
13509 (configure_driver, destroy_driver) Removed references to output,
13510 filename members of outp_driver.
13511 (outp_evaluate_dimension, internal_get_paper_size,
13512 outp_get_paper_size) New functions.
13514 * postscript.c: Continued development. Now links but doesn't make
13515 any marks on the page. Lotsa bugs I suppose.
13517 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
13519 * str.h: Comment changes.
13521 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
13523 * Removed dependencies on non-nested comments in several files.
13524 Also removed references to (unix || __unix__) in #if's since
13525 prefh.orig makes those two equivalent.
13527 * ascii.c: (ascii_open_global) Creates ascii_arena.
13528 (ascii_close_global) Destroys ascii_arena.
13529 (ascii_init_driver) Doesn't create ascii_arena.
13530 (ascii_copy_driver) Removed.
13531 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
13532 (outp_class ascii_class) Removed ascii_copy_driver reference.
13534 * frequencies.q: Now can display all statistics except median.
13535 Still not finished.
13537 * output.c: Handles outp_class.ref_count so output class
13538 destructors are called properly.
13539 (add_class) Sets ref_count to 0.
13540 (configure_driver) Initializes class if ref_count++ is 0.
13541 (destroy_driver) Destructs class if --ref_count is 0. Frees the
13542 class output file name.
13544 * output.h: (struct outp_class) Removed copy_driver, inited.
13547 * postscript.c: Completely replaced but not finished.
13549 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
13551 * approx.h: #includes <float.h>.
13553 * arena.h, arena.c: Many functions changed to take an arena **
13554 instead of an arena *, for consistency. All callers changed.
13555 (arena_alloc) Now creates a new arena if passed *A that is NULL.
13556 (arena_destroy) Sets *A to NULL.
13558 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
13559 assertion that `width' be positive.
13561 * command.c: Removed #if's from cmd_table.
13562 (walk_cmdtable_func) [0] New function (debug code).
13563 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
13564 (parse_cmd) Doesn't return failure for unimplemented commands.
13566 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
13567 (SYSCODE) New constant macro.
13569 * descript.q: Checks for positive n_variables before performing
13572 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
13573 avl_find instead of &fp as arg 2.
13575 * frequencies.g, frequencies.q: Continued updating; now compiles &
13576 works again, but not complete.
13578 * main.c: Changes to user messages.
13580 * misc.c: (reverse) [0] New function.
13582 * settings.h: Comment removed. #includes "common.h".
13584 * som.c: (som_set_null) New function.
13585 (som_set_value, som_set_string, som_set_text) More detailing
13587 (som_set_float) Implemented function.
13588 (dump_columnated_table) Bug fix regarding page breaks.
13589 (draw_cell) Bug fix regarding text that spilled out of a cell.
13590 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
13592 (get_cell_size) Support SCON_EMPTY cells.
13593 (get_table_size) When calculating rules' widths and heights, mask
13594 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
13596 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
13598 (struct som_submission_form) New member `header'; all users
13601 * val-labs.c: (get_label) User messages changed.
13603 * var.h: Changed FREQUENCIES structures.
13605 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
13608 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
13610 * approx.h: Definition of EPSILON now depends on system's
13611 DBL_EPSILON. Removed GNU C specific code.
13612 (cmpapx) Renamed approx_compare.
13614 * frequencies.g, frequencies.q: Continued updating; still doesn't
13617 * groff-font.c: (name_to_index) Fix bug that kept it from
13620 * hash.c, hash.h: Completed work.
13622 * var.h: Changes to freq_tab, frequencies_proc.
13624 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
13627 * hash.c, hash.h: New files. Not completed.
13628 * Makefile.am: Added hash.c to source file list.
13629 * font.h: (struct font_desc) New member kern_size_p.
13630 * groff-font.c: Uses hash.h.
13631 (hashpjw) Moved to hash.c.
13632 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
13634 (static var hash) New member size_p.
13635 * var.h: Includes hash.h.
13636 (struct freq_tab) Changed AVL_TREE to hash_tab.
13638 * vars-prs.c: Comment, formatting fixes.
13640 * frequencies.g, frequencies.q: Continued updating. Not yet
13643 * formats.c: Bug fix.
13645 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
13647 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
13648 * descript.g: Comment fixes.
13649 * descript.q: Comment fixes. Moved some declarations into var.h.
13650 Made dsc_info a static table. Updated FIXMEs.
13651 (internal_cmd_descriptives) Beautified.
13653 * frequencies.q: Started updating into working order.
13654 * frequencies.g: New file analogous to descript.g.
13655 * var.h: Comment fixes. Added structures for FREQUENCIES.
13657 * som.c: Removed vestiges of crushing and partial table support.
13659 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
13661 * Many more changes to som.c especially, but these will not be
13662 documented as I have resolved to remove them. This patchlevel is
13663 being released solely so that I can fall back to it if I decide
13664 that removing the changes is not a good idea.
13666 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
13668 * som.c: (global var som) New member `cum_y'.
13669 (build_target) Properly handles titles for partial tables.
13670 (dump_partial_beg, dump_partial_mid, dump_partial_end)
13671 Merged into single new function dump_partial(). Fixed problem
13672 with titles on partial tables.
13673 (dump_table) Calls dump_partial() for all parts of partial tables.
13674 (dump_page) Criteria for drawing title changed.
13676 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
13678 * command.c: (cmd_table) Added LIST, WEIGHT.
13680 * command.c: (cmd_remark) No longer frees `s' since it's not
13681 dynamically allocated.
13683 * data-out.c: (convert_f) Now correctly handles the case where
13684 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
13685 number of decimals.
13686 (som_destroy_all_tables) Removed argument. All callers changed.
13687 (som_vline, som_hline) Argument validity checking corrected.
13688 (som_set_value) Implemented half-heartedly.
13689 (replicate_table) Copies tables piece-by-piece when using Checker.
13691 * som.h: New line style SLIN_1THIN, currently equivalent to
13692 SLIN_0. New enum set SOM_SUB_*.
13693 (struct som_submission_form) Removed `seq_no'. Added `type'.
13695 * list.q: Newly working file; uses partial tables.
13697 * som.c: (som_reduce_table) Renamed som_set_table_height().
13698 (som_crush) Removed argument `group'.
13699 (global var som) Removed `nt', `seq_no'. Added `type'.
13700 (som_submit_table) Arguments changed.
13701 (output_table) Removed partial table code.
13702 (build_target) New arg; partial table support added. All callers
13704 (dump_plain_table) Removed partial table code.
13705 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
13706 (dump_table) Supports partial tables.
13707 (dump_page) New argument to allow not drawing top and/or bottom
13708 headers. All callers changed. Supports partial tables.
13710 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
13712 * data-out.c: Changed `#include <approx.h>' to `#include
13714 (convert_F) Comment fix. Now won't print `-.000', etc.
13716 * descript.q: Now Z-scores work, although there appears to
13717 be a bug (which might actually be in data-out.c:convert_F()).
13718 (descriptives_trns_proc, descriptives_trns_free) New functions.
13719 (run_z_pass) Implemented.
13721 * var.h: Comment fixes.
13722 (dsc_z_score, descriptives_trns) New structs.
13723 (descriptives_trns) Added to any_trns as `dsc'.
13725 * error.c, error.h: New error class, IS (Installation Script
13726 error), used in those instances where the error is in the
13727 installation, but there is a script file or installation file that
13728 can be usefully referred to.
13730 * output.c: Change many IE classes to IS classes.
13732 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
13733 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
13734 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
13735 include the corresponding header?
13737 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
13738 Don't bail out if termcap can't be read.
13740 * som.c: (som_destroy_table) Removed.
13741 (som_reduce_table, som_destroy_all_tables) New functions.
13742 (som_crush) New function, not implemented.
13744 * som.h: New table option STAB_CRUSH. Comment fix. New struct
13745 som_submission_form. Function prototypes revised.
13747 Outputting huge tables (1000s of rows) a few rows at a time
13748 is supported, though untested. May even break everything.
13749 Actually, the code doesn't even compile right now.
13750 * som.c: (struct som) New fields htv, nt, seq_no.
13751 (som_submit_table) Multiple arguments changed to a single
13752 pointer to struct submission_form. Only increments subtable_num
13753 if seq_no is zero. Only destroys table if it's not going to
13755 (replicate_table) New function.
13756 (output_table) Comment fix.
13757 (examine_table) Changed inline code to code calling
13758 replicate_table(). Calculates htv. Supports partial tables.
13759 (draw_title) Removed comment.
13760 (build_target) Only allows for title on first part of partial
13762 (dump_plain_table) Only resets table chunk number on first part
13763 of partial tables; FIXME: doesn't work quite right. Supports
13765 (dump_page) Titles only on first part of partial tables.
13767 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
13769 * Thanks to an unreliable IDE hard drive, I have spent the last
13770 day reconstructing my Debian GNU/Linux installation and redoing
13771 the previous day's changes--somehow I managed to save every file
13772 except for output.c and output.h. So the following changes could
13773 really be considered independent of the output.c, output.h changes
13776 * output.h, output.c: Moved the outp_configure_vec global var,
13777 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
13778 outp_configure_vec is now static.
13780 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
13782 * The entire philosophy behind configuration of the output drivers
13783 changed. Now there is a termcap-type configuration where drivers
13784 to be read are determined beforehand, rather than parsing the
13785 entire output init file and storing it in memory & deciding what
13786 to actually use later. Faster & more memory-efficient at the same
13789 * output.c: Comment fix. Removed outp_init_drivers global var.
13790 Removed all references to synonyms. New structure outp_defn. New
13791 global vars outp_macros, outp_configure_vec.
13792 (search_name, delete_name, add_name, check_configure_vec,
13793 expand_name, find_defn_value) New static functions.
13794 (outp_configure_clear, outp_configure_add, outp_configure_macro,
13795 outp_read_devices) New extern functions.
13796 (outp_init) Much functionality moved into outp_read_devices.
13797 (outp_read_devices) Format of output init file changed; name of
13798 file is `devices' rather than `output' to avoid Makefile
13800 (outp_clear) Renamed outp_done.
13801 (outp_list_classes) Bug fix, cleaned up.
13802 (outp_list_drivers) Not implemented anymore.
13803 (outp_configure_driver) Now a static function; simplified; now
13804 interpolates macros; supports new structure.
13805 (outp_enable_driver, match_synonym) Removed; all references
13807 (find_driver) First argument removed.
13809 * output.h: Global var outp_init_drivers removed; new structure
13810 outp_names; new enum set OUTP_S_*; new global var
13811 outp_configure_vec; function prototypes for output.c exports
13814 * main.c: (main) Calls outp_read_devices() after parsing the
13817 * cmdline.c: (parse_command_line) New option -v --verbose;
13818 --version changed to -V. --device option changed syntax to just
13819 take a single device name. Accepts key=value declaration of
13820 output init file macros. Syntax message updated.
13822 * filename.c: (expand_line) New function.
13823 (interp_environ_vars) Renamed interp_vars; no longer uses
13825 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
13826 overridden by real environment vars.
13827 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
13828 * filename.h: interp_environ_vars() renamed interp_vars().
13830 * error.c, error.h: Added extern variable `verbosity', message
13833 * error.c: (vmsg) Support message class MM.
13834 (verbose_msg) New function.
13836 * descript.q: (generate_z_varname) Bug fix in generation of
13838 (dump_z_table) Bug fix in column headers.
13840 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
13841 page from 29 to 15. Don't set a default for ops[OPS_INIT,
13842 OPS_DONE]. Writes the uninit string when the driver is closed.
13843 (ascii_open_page) Write the init string before the first page.
13844 (output_shorts) Form of main loop changed from `while' to `for'.
13845 Bug fix with overstrikes: the character is printed *after* the
13846 backspace. Eliminated a lot of `& 0xff' modifiers.
13847 (advance_to_left_margin) New function.
13848 (return_carriage, output_lines) Handle left margin.
13850 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
13852 * ascii.c: New option `carriage-return-style'.
13854 * ascii.c: (count_fancy_chars) New function.
13855 (delineate, text_metrics) Use new function; bug fixes regarding
13857 (text_draw) Bug fix with rich text.
13858 (output_string, output_shorts) Reordered.
13859 (output_shorts) Now handles boxchars and some overstrike font
13861 (output_char, return_carriage) New functions.
13862 (output_lines) Now handles overstriking and font changes properly;
13863 some code moved to output_shorts.
13865 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
13868 * ascii.c: New member `debug' in ascii_driver_ext.
13869 (ascii_init_driver, delineate) Uses new member.
13871 Now you can set a vertical height on writing text.
13872 * ascii.c: (delineate) Keeps track of vertical position.
13873 (text_draw) No longer considers fully justified text an internal
13876 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
13878 Tables' titles are drawn; they can have variable height.
13879 * som.c: `som' struct has new member, title_height.
13880 (draw_title) New argument. Moved within file. All caller
13882 (build_target) New argument, amount of space needed for first row.
13883 Calculates height of title, takes that into account. All callers
13885 (dump_plain_table, dump_columnated_table) Took calculation of y1,
13887 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
13889 (dump_columnated_table) Organized for readability.
13890 (dump_page) Makes use of som.title_height.
13892 * som.c: Many comment bug fixes.
13894 * descript.q: (try_name, generate_z_name) Bug fix regarding
13895 generation of Z-score variable names.
13896 * var.h: Removed num from descriptives_proc; all referents removed.
13898 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
13900 * ascii.c: (ascii_line_horz, ascii_line_vert,
13901 ascii_line_intersection) Added debugging code.
13903 Added a descriptive line above each table to describe it.
13904 * command.c: (parse_cmd) Calls som_new_series.
13906 * som.c: New static vars table_num, subtable_num. New `som'
13908 (dump_page) New arguments.
13909 (som_submit_table) Handle new variables.
13911 * som.c, som.h: (som_submit_table) New arguments. All callers
13913 (som_new_series) New function.
13914 (build_target) Makes room for extra line.
13915 (draw_title) New function.
13916 (dump_page) Calls draw_title. Bug fix: doesn't always set
13919 Columnation of tables support.
13920 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
13922 * som.c: Deleted references to fr, lr, ri.
13923 (som_columnate) Bux fix: sets group member of table.
13924 (som_add_options) Function removed.
13925 (dump_table) Split into three functions; extensively reworked.
13927 * descript.q: (dump_z_table) Better output table formatting; added
13928 title support to correspond to som.h changes.
13929 (display) Title support.
13931 * output.h: Added OUTP_T_NONE.
13933 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
13935 * descript.q: Improved handling of Z scores; still not perfect.
13937 * output.h, ascii.c: Added hook for getting em width of current
13940 * som.c: Uses new em-width hook. Added debugging code to
13942 (som_columnate) New argument.
13943 (som_add_options) Removed.
13945 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
13947 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
13948 rules as a property of the table instead of as a property of the
13951 * ascii.c: Added `header' to table of options.
13953 * descript.q: Added even shorter statistic names; modified to work
13954 with new som interface.
13956 * misc.c (blp_getdelim): Bug fix.
13958 * version.c: includes 'conf.h'.
13960 ----------------------------------------------------------------------
13963 version-control: never