1 Sun Nov 27 06:43:46 WST 2005 John Darrington <john@darington.wattle.id.au>
3 * data-out.c format.h: Added return value to data_out function.
5 * value-labels.c: Fixed bug in val_labs_remove.
7 Sat Nov 5 18:37:26 2005 Ben Pfaff <blp@gnu.org>
9 * Makefile.am: Remove devind.c, devind.h from list of source
16 * list.q: Removed "support" for devind.
18 * output.c: Don't add devind class.
20 Sat Nov 5 18:21:00 2005 Ben Pfaff <blp@gnu.org>
22 * var.h: (struct variable) Make `init', `reinit' bool values.
25 Fri Nov 4 19:43:01 2005 Ben Pfaff <blp@gnu.org>
27 * recode.c: Rewrote whole file, as clean-up.
29 Fri Nov 4 19:37:50 2005 Ben Pfaff <blp@gnu.org>
31 * pool.c: Don't make alignment exception for x86.
32 (pool_alloc) Return null for 0-size blocks.
33 (pool_alloc_unaligned) New function.
34 (pool_strndup) Removed. Changed callers to use pool_clone_unaligned().
35 (pool_clone_unaligned) New function.
36 (pool_strdup) Use pool_clone_unaligned().
38 * var.h: (enum var_type) Give the NUMERIC, ALPHA enum this name.
39 (struct variable) Use `enum var_type' for `type'.
41 * vars-atr.c: (var_type_adj) New function.
42 (var_type_noun) New function.
44 * vars-prs: (parse_mixed_vars) Fix freeing code.
45 (parse_mixed_vars_pool) New function.
47 Wed Nov 2 21:24:48 2005 Ben Pfaff <blp@gnu.org>
49 * file-handle-def.c: Needed another #include, to avoid missing
52 * file-handle.q: (cmd_file_handle) Declarations must precede
53 statements. Free parse data on success as well as on failure, to
56 * get.c: (parse_write_command) Destroy dict on success, to avoid
59 * data-list.c: (cmd_repeating_data) Fix usage of saw_occurs,
60 saw_length, saw_continued, saw_id, which were boolean but
61 incorrectly treated as bitmaps as result of a previous
62 half-finished cleanup.
64 * weight.c: (struct weight_trns) Unused, so removed.
66 * Makefile.am: Add range-prs.h to sources.
68 Wed Nov 2 21:24:15 2005 Ben Pfaff <blp@gnu.org>
72 * Makefile.am: Add ctl-stack.c, ctl-stack.h to source files.
73 Reformat source file list to list one file per file, so that
74 patches for future changes will be easier to read.
76 * ctl-stack.c, ctl-stack.h: New files.
78 * do-if.c: Rewrote whole file.
82 * loop.c: Rewrote whole file.
84 * glob.c: (global var ctl_stack) Move into ctl-stack.c.
86 * temporary.c: (cmd_temporary) Use ctl_stack_is_empty().
88 * vfm.c: (open_active_file) Use ctl_stack_clear().
90 Wed Nov 2 21:18:13 2005 Ben Pfaff <blp@gnu.org>
94 * pool.c: (pool_create_at_offset) New function.
95 (pool_add_subpool) New function.
97 * pool.h: (pool_create_container) New macro.
99 * expressions/parse.c: (expr_parse_pool) New function.
101 * autorecode.c: (recode) Use pool_create_container().
103 * count.c: (cmd_count) Ditto.
105 Wed Nov 2 19:59:32 2005 Ben Pfaff <blp@gnu.org>
107 Clean up transformations, by getting rid of `struct trns_header',
108 replacing it by `struct transformation' that has a void *
109 `private' member. Updated all uses of transformations to match,
110 which was a lot of code. Only major related changes listed below.
112 * compute.c: (cmd_if) Use get_proc_func().
113 (cmd_compute) Use get_proc_func().
114 (get_proc_func) New function.
116 * glob.c: (global var m_trns) Change type to size_t.
117 (global var n_trns) Ditto.
118 (global var f_trns) Ditto.
119 (global var t_trns) Change type to struct transformation *.
121 * var.h: (struct trns_header) Removed.
122 (struct transformation) New.
123 (typedef trns_proc_func) Takes a void * instead of a struct
125 (typedef trns_free_func) Ditto.
127 * vfm.c: (execute_transformations) Takes an array of
128 transformations instead of trns_headers.
129 (add_transformation) Change prototype from (trns_header *) to
130 (trns_proc_func *, trns_free_func *, void *).
131 (next_transformation) New function.
133 Sat Oct 29 16:25:36 2005 Ben Pfaff <blp@gnu.org>
135 * count.c: Major cleanups. Rename practically everything.
136 Rewrite much of the code. Use pools for memory management. Use
137 the new parse_num_range().
139 * mis-val.c: (cmd_missing_values) Use the new parse_num_range().
140 (parse_number) Removed.
142 * missing-values.c: (mv_add_num_range) Don't add out-of-order
143 ranges, e.g. where low > high.
145 * pool.c: (pool_2nrealloc) New function.
147 * range-prs.c: New file.
148 (parse_num_range) New function.
149 (parse_number) New function.
151 Fri Oct 28 22:47:48 2005 Ben Pfaff <blp@gnu.org>
153 Fix up potential overflows in size calculations by replacing
154 instances of pool_alloc(p, x * sizeof *y) by pool_malloc(p, x,
155 sizeof *y) everywhere I could find them. Similarly by
156 pool_malloc(), pool_realloc().
157 (Order is important: pool_alloc(p, sizeof *y, x) will divide by 0
160 * pool.c: (pool_nalloc) New function.
161 (pool_nmalloc) New function.
162 (pool_nrealloc) New function.
164 Thu Oct 27 11:16:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
166 Separated the definition of a file handle object from the stuff
167 pertaining to the FILE HANDLE command.
169 * file-handle-def.[ch]: New files.
171 * dfm-read.c file-handle.h file-handle.q
173 Tue Oct 25 21:56:23 2005 Ben Pfaff <blp@gnu.org>
175 Fix up potential overflows in size calculations by replacing
176 instances of xmalloc(x * sizeof *y) by xnmalloc(x, sizeof *y)
177 everywhere I could find them. Similarly by xrealloc(), malloc().
178 (Order is important: xnmalloc(sizeof *y, x) will divide by 0 if x
181 * alloc.c: (nmalloc) New function.
182 (out_of_memory) Removed. Replaced references by xalloc_die().
184 * sort.c: (allocate_cases) Fix segfault if memory allocation
187 * subclist.c: (subc_list_double_create) Use xnmalloc() instead of
189 (subc_list_double_push) Use xnrealloc() instead of realloc().
191 Wed Oct 26 08:43:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
193 Dictionary abstraction part #2
195 * algorithm.c format.c str.c sysfile-info.c val.h var.h vars-atr.c:
196 Removed unnecessary #include directives
198 Mon Oct 24 21:35:08 2005 Ben Pfaff <blp@gnu.org>
200 * groff-font.c (font_msg): Use err_vmsg() instead of incorrectly
201 trying to pass a va_list to tmsg(). Thanks to Jason Stover for
204 Mon Oct 24 21:24:15 2005 Ben Pfaff <blp@gnu.org>
206 Work to get rid of GCC 4.0 warnings, part 2.
208 In many files, change `unsigned char' to `char'. This often
209 requires adding casts to <ctype.h> functions.
211 * data-in.c: (parse_A) Use buf_copy_rpad().
213 * str.c: (str_copy_buf_trunc) New function.
215 * value-labels.c: (value_to_string) Fix mistaken use of strncpy(),
218 Mon Oct 24 13:42:32 WST 2005 John Darrington <john@darrington.wattle.id.au>
220 Moved some definitions to make it easier to abstract a dictionary
221 from the rest of PSPP.
223 * format-prs.c lex-def.[ch]: New files.
225 * Makefile.am lexer.[ch] dictionary.c vars-atr.c vfm.c algorithm.c
226 format.c: Moved some functions between modules.
228 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
230 Work to get rid of GCC 4.0 warnings, part 1.
232 In many files, change count parameters to parse_variables(),
233 etc. from `int' to `size_t'. Also change related variables and
234 struct members. Also change messages as needed (e.g. %d to %u
235 with cast to unsigned). Also change arithmetic as necessary
236 (e.g. n >= m - 1 to n + 1 >= m).
238 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
241 * q2c.c: (dump_declarations) Generate code for size_t instead of
244 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
246 * output.c: (outp_read_devices) Fix message.
248 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
250 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
251 address is passed to dict_get_vars() from size_t to int to match
254 * modify-vars.c: (validate_var_modification) Ditto.
256 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
258 * dictionary.[ch] Changed cnt from size_t* to int* since that's
259 what it's called as, and on x86_64 machines they're different sizes.
261 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
263 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
265 * lexer.c: (lex_sbc_only_once) New function.
266 (lex_sbc_missing) New function.
268 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
270 * case.h: (case_str) Make it return `unsigned char'.
272 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
274 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
275 subcommands that we didn't support. Fix bug 13911. Fix bug
276 reported by Adam Pierson (COMPRESSED and other subcommands didn't
277 work on SAVE). Refactor all related code.
279 * command.def: Add XEXPORT command.
281 * dictionary.c: (dict_delete_scratch_vars) New function.
283 * get.c: (cmd_get) Fix parsing.
284 (struct save_trns) Removed.
285 (cmd_save_internal) Removed.
287 (do_write_case) Removed.
288 (save_write_case_func) Removed.
289 (save_trns_proc) Removed.
290 (save_trns_free) Removed.
291 (trim_dictionary) Removed.
292 (struct export_proc) Removed.
293 (cmd_export) Rewrote.
294 (export_write_case_func) Removed.
295 (export_proc_free) Removed.
296 (enum writer_type) New enum.
297 (enum command_type) New enum.
298 (struct any_writer) New struct.
299 (any_writer_destroy) New function.
300 (parse_write_command) New function.
301 (any_writer_write_case) New function.
302 (parse_output_proc) New function.
303 (output_proc) New function.
306 (struct output_trns) New struct.
307 (parse_output_trns) New function.
308 (output_trns_proc) New function.
309 (output_trns_free) New function.
311 (cmd_xexport) New function.
312 (parse_dict_trim) New function.
313 (struct mtf_proc) Change `by_cnt' member type to `int'.
314 (cmd_import) Rewrote.
316 * pfm-write.c: (struct pfm_writer) Add `digits' member.
317 (pfm_writer_default_options) New function.
318 (pfm_open_writer) Add `opts' argument and handle options.
319 (write_float) Write only as many digits as `digits' member says.
320 (format_trig_double) Limit base-10 precision to LDBL_DIG.
322 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
323 (struct pfm_write_options) New struct.
325 * sfm-write.c: (sfm_writer_default_options) New function.
326 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
327 `opts' argument. Implement options.
329 * sfm-write.h: (struct sfm_write_options) New struct.
331 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
332 char *' instead of `char *'.
334 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
336 * factor_stats.c: Needed <config.h> included earlier.
338 * percentiles.c: Needed to include <config.h>.
340 * val.h: Don't include "config.h".
342 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
344 Clean up treatment of missing values by moving all the code into
345 one place. All references to the missing value function were
346 updated, but only major changes are detailed below.
348 * Makefile.am: Add missing-values.c, missing-values.h to sources.
350 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
352 * dictionary.c: (dict_create_var) Initialize `miss' member with
354 (dict_clone_var) Copy `miss' member with mv_copy().
356 * get.c: (mtf_merge_dictionary) Use mv_copy().
358 * missing-values.c: New file.
360 * missing-values.h: New file.
362 * mis-val.c: Rewrite. New version implements updated semantics.
364 * pfm-read.c: (read_variables) Rewrite missing value handling.
366 * pfm-write.c: (write_variables) Rewrite missing value handling.
368 * sfm-read.c: (read_variables) Rewrite missing value handling.
370 * sfm-write.c: (write_variable) Rewrite missing value handling.
372 * sfmP.h: Include "magic.h" to get definition of
375 * sysfile-info.c: (describe_variable) Rewrite missing value
378 * val.h: Include "magic.h" to get definition of
381 * var.h: Include "missing-values.h". Drop MISSING_* enums.
382 (struct variable) Remove `miss_type', `missing'. Add `miss'.
384 * vars-atr.c: (is_num_user_missing) Removed--use
385 mv_is_num_user_missing().
386 (is_str_user_missing) Removed--use mv_is_str_user_missing().
387 (is_system_missing) Removed--use mv_is_value_system_missing().
388 (is_missing) Removed--use mv_is_value_missing().
389 (is_user_missing) Removed--use mv_is_value_user_missing().
391 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
393 Adopt use of gnulib for portability.
395 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
398 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
399 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
402 * In many source files, added an explicit inclusion of gettext.h
403 and definition of _ macro. These are no longer in pref.h because
404 it interfered with definitions in a few gnulib source files.
406 * In many source files, changed #include "bool.h" to #include
407 <stdbool.h>, which is provided by gnulib.
409 * alloc.c: Removed functions defined in gnulib:
414 (out_of_memory) Redefined as wrapper for xalloc_die().
416 * alloc.h: Replace prototypes by #include "xalloc.h".
418 * casefile.c: Use full_read() and full_write() from gnulib instead
419 of our home-grown versions.
421 (full_write) Removed.
423 * getline.c: Renamed getl.c.
425 * getline.h: Renamed getl.h, updated all references.
427 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
430 * glob.c: Just #include <time.h> instead of the crazy rigmarole
432 (init_glob) Call set_program_name() to initial gnulib progname
435 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
437 * permissions.c: Use "stat-macros.h" from gnulib.
439 * postscript.c: Just #include <time.h> instead of the crazy
440 rigmarole here before.
442 * q2c.c: (main) Make generated code #include "gettext.h".
444 * str.h: Get rid of most explicit declarations of standard
445 functions, in favor of including gnulib header files.
447 * expressions/evaluate.c: Ditto.
449 * expressions/operations.h.pl: Make generated code #include
450 <stdbool.h>, not "bool.h".
452 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
454 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
457 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
459 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
460 null pointer to printf for %.*s.
462 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
464 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
467 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
469 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
471 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
473 * postscript.c: (postopen) Cast `char' to `unsigned char' before
474 passing to isspace().
476 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
478 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
480 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
482 * histogram.c: Include <config.h>.
484 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
486 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
488 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
490 * format.c: (check_common_specifier) Fix msg() bug found by
492 (check_output_specifier) Ditto.
494 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
496 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
499 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
501 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
502 avoid "unused variable" warning.
504 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
506 * command.c: (find_word) Cast `char' to `unsigned char' before
507 passing to isspace().
509 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
511 * case.c: (case_compare) Implement as delegating to
512 case_compare_2dict().
514 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
516 * algorithm.c: Inclusion of <alloca.h> is unneeded.
518 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
520 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
521 -ansi changes the behavior of header files significantly. It
522 causes __STRICT_ANSI__ to be defined, and some headers interpret
523 that as cause to e.g. not use `long long' or __attribute__. The
524 former example is bad when off_t is supposed to be `long long',
525 and the latter prevents -Wformat from working.
527 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
529 Get rid of dependency on libgmp by writing our own routine for
530 floating-point base conversion.
532 * pfm-write.c: (write_float) Rewrote.
534 (pow30_nonnegative) New function.
535 (pow30) New function.
536 (trig_to_char) New function.
537 (format_trig_digits) New function.
538 (recurse_format_trig_int) New function.
539 (format_trig_int) New function.
540 (should_round_up) New function.
541 (try_round_up) New function.
542 (format_trig_double) New function.
544 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
546 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
549 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
551 * pfm-read.c: (read_version_data) Read and ignore author field.
553 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
555 * get.c: (mtf_processing) Don't assume that
556 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
557 returns a negative, zero, or positive result. Fixes MATCH FILES
558 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
560 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
562 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
563 preprocessor test for sys/types.h was accidentally inverted. This
566 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
568 * get.c: (cmd_match_files) Fix memory leak on `by' and on
571 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
574 * vfm.c: (close_active_file) Remove unnecessary test.
576 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
578 Fix NDEBUG compile errors.
580 * hash.h: Needed explicit #include <assert.h>.
582 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
585 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
587 Implement embedding for PostScript driver. Fixes bug 12970.
589 * ascii.c: Fix compiler warnings.
593 * chart.h: Add `file' member.
595 * output.h: (struct outp_class) initialise_chart, finalise_chart
596 should take outp_driver *, not outp_class *. Update all
599 * plot-chart.c: (chart_create) Fix segfault when there are no
600 output drivers at all.
601 (chart_submit) Call d->class->finalise_chart.
603 * postscript.c: (ps_open_page) Set cp_y to 0.
604 (ps_submit) New function.
605 (ps_chart_initialise) Implement.
606 (ps_chart_finalise) Implement.
607 (static var postscript_class) Add ps_submit.
608 (static var epsf_class) Add ps_submit.
611 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
613 Did some more work on bug 12859 and then realized that a *good*
614 solution would require some fundamental restructuring. For now,
615 I'm marking REPEATING DATA unimplemented, and then we can revisit
618 * command.def: Make REPEATING DATA unimplemented.
620 * data-list.c: (cmd_repeating_data) Assume inline file is 80
622 (realize_value) Revert previous changes; no longer needed.
625 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
626 file_loc, to avoid bad references later.
630 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
632 Make some code tolerant of reentry. Should not be needed if other
633 code is correct but it is good to be generally tolerant.
635 * error.c: (err_hcf) Set file_loc to null after free().
637 * output.c: (outp_done) Similar changes.
639 * str.c: (ds_destroy) Ditto.
641 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
643 Continue work on bug 12859, plus some code cleanup.
645 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
646 boolean variables. Don't try to compute starts_end, cont_end for
647 inline file. Calculate length only after parsing variable
648 specifications. Add proper transformation to list.
649 (realize_value) If the rpd_num_or_var has no value, return new
650 DEFAULT_MEMBER argument (for use with inline file).
651 (repeating_data_trns_proc) Pass default values.
653 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
654 open, and only if we actually started reading data.
656 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
660 * output.c: (outp_read_devices) Fix message.
662 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
664 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
665 of the sort algorithm from the parser for the SORT command.
667 * rank.q: Added the parser for the RANK command.
669 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
673 * sort.c: (sort_parse_criteria) Only set *saw_direction if
674 saw_direction is non-null. Thanks to John Darrington for
677 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
679 * get.c: (mtf_processing) Handle case of a lookup table as the
680 active file. Thanks to John Darrington for reporting this bug.
682 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
684 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
685 POSIX calloc function.
687 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
688 reflect new signature.
690 * sfm-read.c: Now much more robust in the face of badly formed
693 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
695 *sfm-read.c: Fixed some bugs regarding long string continuation
696 records, which the previous fix uncovered.
698 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
700 * sfm-read.c, sfmP.h: Allow reading of system files when the
701 case_size value in the header is -1. Also changed some Errors to
702 Warnings when reading system files.
704 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
706 * data-list.c: (data_list_trns_free) Don't free the argument
707 because cancel_transformations() will do that itself.
708 (data_list_source_destroy) Destroy the argument to
709 data_list_trns_free(), because it no longer does so itself.
711 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
713 * data-out.c: (format_and_round) Don't output leading `-' if value
716 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
720 * som.c: (output_encodings) If some cell in the table won't fit
721 with the horizontal or vertical headers, cancel those headers.
723 * som.h: (struct som_table_class) Add fits_width, fits_length,
726 * tab.c: (tabi_fits_width) New function.
727 (tabi_fits_length) New function.
728 (tabi_set_headers) New function.
729 (global var tab_table_class) Add the new functions as appropriate
732 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
734 Fix rest of bug 13054.
736 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
737 DATETIME, TIME system/portable file values.
739 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
741 * data-list.c: (parse_free) Use make_input_format().
743 * data-out.c: (num_to_string) Use make_output_format().
745 * dictionary.c: (dict_create_var) Ditto.
747 * format.c: (global var f8_2) New var.
748 (make_input_format) New function.
749 (make_output_format) New function.
751 * get.c: (cmd_match_files) Use make_output_format().
753 * list.q: (cmd_list) Ditto.
755 * matrix-data.c: Ditto.
757 * sfm-read.c: (parse_format_spec) Check output specifier
760 * tab.c: (tab_float) Use make_output_format().
762 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
764 Fix more of bug 13054.
766 * format.def: FMT_A should allow 255-character output. FMT_AHEX
767 should allow 510-character input and output.
769 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
770 (convert_E) Handle non-finite values.
772 (format_and_round) New function.
773 (convert_infinite) New function used by try_F() and convert_E().
775 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
777 Regularize string and buffer function names so that they make some
780 * str.c: (mm_reverse) Rename buf_reverse(). Update all
782 (mm_find_reverse) Rename buf_find_reverse(). Update all
784 (mm_case_compare) Rename buf_compare_case(). Update all
786 (st_compare_pad) Rename buf_compare_rpad(). Update all
788 (str_compare_rpad) New function.
789 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
791 (buf_copy_str_lpad) New function.
792 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
794 (st_pad_copy) Rename str_copy_rpad(). Update all references.
795 (st_trim_copy) Rename str_copy_trunc(). Update all references.
796 (st_uppercase) Renamed str_uppercase(). Update all references.
798 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
800 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
803 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
805 * data-in.c: (data_in) Add assertion to check input specifier.
807 * data-out.c: (data_out) Add assertion to check output specifier.
809 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
811 Start to fix bug 13054.
813 * format.c: (check_input_specifier) Improve error message.
814 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
815 valid decimal places.
816 (check_output_specifier) Ditto (but different criteria).
817 (convert_fmt_ItoO) Assert valid input and output specifiers.
818 Also, if input specifier has *any* decimal places, make the output
819 specifier 1 place wider.
821 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
823 * sysfile-info.c: Fixed bug [# 13024 ]
825 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
827 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
828 actually implement it.
830 * command.c: (FILE_TYPE_okay) Always return 1.
832 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
834 * file-type.c: Add prototypes to get rid of warnings.
836 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
838 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
839 more ISO/IEC 9899:1990 conformance issues.
841 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
843 Fix bug 12948. See also new test in
844 tests/bugs/match-file-scratch.sh.
846 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
847 that deletes scratch variables that someone else might be using,
848 and because we can't reassign our sources' value indexes.
849 Instead, simply don't copy scratch variables into the master
852 * dictionary.c: (dict_compact_values) Delete variables from the
853 dictionary passed in, not from default_dict (!).
855 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
857 Improve hash.c comments, error-checking.
859 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
860 (hsh_create) size == 0 should *not* return NULL! Set
862 (hsh_clear) Set hash_ordered.
863 (locate_matching_entry) Check hash_ordered.
864 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
865 (hsh_data) Set hash_ordered. Add const-ness to return value and
869 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
871 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
873 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
875 * copyleft.c: Updated copyright date.
877 * Makefile.am: Removed erroneous explicit "-lplot"
879 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
881 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
883 * command.c command.def: Added description string for unimplemented commands.
885 * oneway.q: Sorted the hash tables before shipping out the results. Closes
888 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
892 * data-list.c: (parse_fixed) Use lex_end_of_command().
894 (cmd_repeating_data) Set cont_end.num in right situations.
895 (parse_repeating_data) Remove redundant test.
897 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
899 Partial fix for bug 12859.
901 * data-list.c: (cmd_data_list) Add transformation properly in
902 vfm_source == NULL case.
904 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
906 * lexer.c: (lex_error) Improve error messages.
908 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
910 * get.c: (cmd_match_files) Check token type before trying to match
911 tokid. Fixes bug 12923.
913 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
915 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
918 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
920 * expressions/generate.pl: (get_token) Make use of /g
921 backward-compatible with Perl 5.6.1.
923 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
925 * var-display.c: (cmd_variable_alignment) Fix memory leak.
926 (cmd_variable_level) Ditto.
928 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
930 Hash table had buggy deletion function. The fix required changing
931 other functions to do probing in the required order.
933 * hash.c: (locate_matching_entry) Rewrite and change interface.
934 (hsh_rehash) Rewrite to use locate_matching_entry().
937 (hsh_delete) Ditto. Also, fix stupid bugs.
939 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
941 * dictionary.c: (dict_clone) Properly copy vectors.
943 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
945 New implementation of long variable names. Each variable has a
946 "normal" name, which may be up to 64 bytes long and which is used
947 for all normal operations. Variables may have a "short" name,
948 which is limited to 8 bytes and used only for system and portable
949 file input and output.
951 Make tokid case-preserving. Update most uses of tokid to treat it
954 Update many commands to deal with long variable names.
956 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
958 * command.c: (cmd_parse) Ditto.
959 (match_strings) Use toupper() before comparing characters.
960 (conflicting_3char_prefixes) Use mm_case_compare() instead of
962 (cmd_match_words) Ditto.
964 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
967 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
968 Use st_trim_copy() instead of strcpy().
970 * data-in.c: (parse_enum) Use mm_case_compare() instead of
973 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
975 (parse_free) Use st_trim_copy() instead of strcpy().
977 * descript.c: (struct dsc_var) Change z_name[] to fit long var
979 (try_name) Use strcasecmp() instead of strcmp().
980 (generate_z_varname) Use st_trim_copy() instead of strcpy().
981 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
984 * dictionary.c: (struct dictionary) Removed `long_name_tab'
986 (compare_long_names) Removed.
987 (hash_long_name) Removed.
988 (dict_create) Don't initialize `long_name_tab' member.
989 (dict_clone) Copy short names into new dictionary.
990 (dict_clear) Don't clear `long_name_tab' member.
991 (dict_get_varname_block) Removed.
992 (dict_add_longvar_entry) Removed.
994 (dict_destroy) Don't destroy `long_name_tab' member.
995 (dict_create_var_from_short) Removed.
996 (dict_create_var_x) Removed.
997 (dict_create_var) Get rid of longname handling.
999 (dict_clone_var) Get rid of longname parameter and longname
1001 (dict_lookup_var) Get rid of longname handling.
1002 (dict_reorder_var) New function.
1003 (dict_rename_var) Clear short name.
1004 (dict_rename_vars) Get rid of longname handling. Clear short
1006 (dict_create_vector) Support long vector names.
1007 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
1008 (quasi_base27) Removed.
1009 (make_short_name) Removed.
1010 (compare_strings) New function.
1011 (hash_string) New function.
1012 (dict_assign_short_names) New function.
1014 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
1016 (get_handle_for_filename) Support long handle names.
1018 * file-type.c: (struct col_spec) Make `name' fit long var names.
1019 (cmd_file_type) Use strcasecmp() instead of strcmp().
1021 * flip.c: (make_new_var) Rewrite.
1022 (flip_sink_write) Use st_trim_copy() instead of strncpy().
1024 * format.c: (parse_format_specifier_name) Use mm_case_compare()
1025 instead of memcmp().
1027 * get.c: (cmd_save_internal) Rephrase.
1028 (rename_variables) Drop test for identical variable name.
1029 (struct mtf_proc) Change `first', `last' to fit long var name.
1031 * hash.c: (hsh_hash_case_string) New function for case-insensitive
1034 * lexer.c: (restore_token) Use st_trim_copy() instead of
1036 (lex_get) Don't uppercase string when copying into tokid.
1037 (lex_put_back_id) Use st_trim_copy() instead of
1040 * list.q: (determine_layout) Consider length of variable names in
1041 choosing vertical layout.
1043 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
1045 (string_to_content_type) Ditto.
1047 * modify-vars.c: (compare_variables_given_ordering) Ditto.
1048 (struct var_renaming) Change `new_name' to fit long var name.
1049 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
1052 * pfm-read.c: (read_variables) Disallow system variables in system
1054 (write_variables) Call dict_assign_short_names() and use
1055 short_name[] members.
1057 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
1060 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
1061 map. Reorder variables into same order as long variable map.
1062 (read_variables) Set short name.
1064 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
1065 (write_variable) Use st_bare_pad_copy().
1066 (write_longvar_table) Rewrite.
1068 * str.c: (mm_case_compare) New function.
1070 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
1071 instead of strcmp().
1073 * t-test.q: (tts_custom_groups) Remove redundant test.
1074 (tts_custom_pairs) Ditto.
1076 * var.h: (struct variable) Change `name' to fit long var names.
1077 Remove `longname'. Add `short_name' member. Reorder some
1079 (struct name_table_entry) Removed.
1080 (struct vector) Change `name' to fit long vector names.
1082 * vars-atr.c: (var_is_valid_name) Allow long var names.
1083 (compare_var_names) Use strcasecmp() instead of strcmp().
1084 (compare_var_ptr_names) Ditto.
1085 (hash_var_name) Use hsh_hash_case_string().
1086 (hash_var_ptr_name) Ditto.
1087 (var_set_short_name) New function.
1088 (var_clear_short_name) New function.
1089 (var_set_short_name_suffix) New function.
1091 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
1092 Use strcasecmp() instead of strcmp().
1093 (struct array_var_set) Removed `longname_tab'.
1094 (array_var_set_lookup_var_idx) Drop longname_tab support.
1095 (array_var_set_destroy) Don't destroy `longname_tab'.
1096 (var_set_create_from_array) Don't create `longname_tab'.
1098 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
1101 * expressions/parse.c: (word_matches) Use mm_case_compare()
1102 instead of memcmp().
1103 (compare_strings) New function.
1104 (lookup_function) Use compare_strings() instead of strcmp().
1106 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
1108 * algorithm.c: (move_element) New function.
1110 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
1112 * aggregate.c: (parse_aggregate_functions) Always initialize
1115 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
1117 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
1119 * dictionary.c: (dict_clone) Ditto.
1120 (dict_clone_var_assert) New function.
1122 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
1124 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1126 * error.c: Added a string for the compiler version to the
1127 request_bug_report_and_abort function.
1129 * groff_font.c, font.c: Removed manpage(1) style references from
1130 comments, because RMS frowns upon them.
1132 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
1134 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
1136 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
1138 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
1139 Fixed bug [#12858] .
1141 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
1143 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
1144 which should be LONG_NAME_LEN
1146 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
1148 * command.def echo.c: Added the ECHO command.
1150 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
1152 Finish fixing MATCH FILES (bug 11677).
1154 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
1155 keep_variables(), rename_variables().
1156 (drop_variables) New function.
1157 (keep_variables) New function.
1158 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
1159 (cmd_match_files) Deal with in_var. Use drop_variables(),
1160 keep_variables(). When IN is specified, require BY. Set master
1161 variables after master dictionary is complete. Add IN variables
1162 after master dictionary is complete.
1163 (mtf_free_file) Free `in_name'.
1164 (mtf_delete_file_in_place) Set in_var value to 0.
1165 (mtf_read_nonactive_records) Rephrase.
1166 (mtf_processing) Support IN. Rephrase. Fix bugs.
1167 (mtf_merge_dictionary) Don't set master variables; we do that
1169 (get_master) Don't insist that there's a master variable.
1171 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
1173 Kluge to make some variable renaming sort of work.
1176 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
1178 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
1180 Add functions for comparing sets of variables between cases.
1183 * case.c: (case_compare) New function.
1184 (case_compare_2dict) New function.
1186 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
1188 (cmd_aggregate) Nullify break_case. Don't call
1189 initialize_aggregate_info().
1190 (agr_destroy) Destroy break_case.
1191 (aggregate_single_case) Rewrite. Use case_compare().
1192 (dump_aggregate_info) Copy from break_case into output.
1193 (initialize_aggregate_info) Copy break_case from input.
1195 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
1197 * vfm.c: (equal_splits) Use case_compare().
1199 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
1201 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
1203 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
1205 Start work on fixing MATCH FILES.
1207 * get.c: (enum operation) Remove OP_MATCH.
1208 (trim_dictionary) Change return value to bool. Don't support
1210 (struct mtf_file) Remove `first', `last' members.
1211 (struct mtf_proc) Add `first', `last' members. Change mtf_case
1212 from `struct ccase *' to `struct ccase'. Remove `by' member.
1213 (cmd_match_files) Essentially rewrite.
1214 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
1215 (mtf_read_nonactive_records) mtf_ parameter is not unused.
1216 (mtf_processing) Ditto. Also rephrase some code.
1217 (mtf_merge_dictionary) Rewrite for easy comprehension.
1219 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
1221 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
1224 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
1226 Thu Apr 14 2005 John Darrington
1228 * var-display.c: New file.
1230 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
1231 display_width, measure and alignment parameters to variables.
1233 * aggregate.c command.def compute.c count.c data-list.c descript.c
1234 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
1235 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
1236 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
1237 vars-prs.c vector.c :
1238 - Replaced literal constants representing maximum variable name
1239 length with macro definitions.
1240 - Added support for long variable names.
1241 - Changed lexer such that it no longer makes tokens upper
1242 case, but relies upon case insensitive behaviour of commands.
1244 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
1246 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
1247 fails, don't dereference the resulting null pointer (bug 12427).
1248 Also, fix double free error.
1250 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
1252 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
1253 (accumulate_aggregate_info) Set int1 to 1 for SUM.
1254 (dump_aggregate_info) Only make SUM non-missing if there was at
1257 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
1259 * aggregate.c: (dump_aggregate_info) Properly test whether the
1260 destination variable is numeric, when making the result
1261 system-missing for columnwise missing values.
1263 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
1265 * misc.h: Remove GCC specializations.
1267 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
1269 Make sort stable (bug 12313).
1271 * sort.c: Don't need to include some headers anymore.
1272 (static var min_buffers) New variable.
1273 (static var max_buffers) New variable.
1274 (static var allow_internal_sort) New variable.
1275 (cmd_sort_cases) Add test mode.
1276 (sort_execute) Rephrase.
1277 (do_internal_sort) Don't try internal sorting if
1278 allow_internal_sort is set.
1279 (struct external_sort) Renamed `initial_runs' to `runs' and
1280 updated all references.
1281 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
1282 (macro MIN_BUFFER_SIZE_BYTES) Removed.
1283 (macro MIN_BUFFER_SIZE_RECS) Removed.
1284 (compare_initial_runs) Removed.
1285 (struct record_run) Add member `idx'.
1286 (write_initial_runs) Pass increasing values to process_case() as
1288 (process_case) Add `idx' parameter and use it to initialize new
1290 (allocate_cases) Limit allocated buffers to max_buffers.
1291 (compare_record_run) Use new `idx' member for last resort
1292 comparison, for stability.
1293 (end_run) Call casefile_sleep() on irs->casefile, to prevent
1294 running out of file descriptors.
1295 (struct merge_state) Removed.
1296 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
1297 unless we have fewer runs left. Always merge consecutive runs,
1298 for stability. Return the final run.
1300 (choose_merge) New function.
1301 (merge_once) Rewritten.
1303 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
1305 * cmdline.c: (static var testing_mode) Move into
1306 parse_command_line().
1308 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
1310 * algorithm.c: (remove_range) New function.
1311 (remove_element) New function.
1313 * dictionary.c: (dict_delete_var) Use remove_element().
1315 * flip.c: (cmd_flip) Ditto.
1317 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
1319 * file-handle.q: (struct file_handle) `open_mode' should not be
1322 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
1324 First phase of making SORT CASES stable (bug 12313).
1326 * sort.c: (struct indexed_case) New structure.
1327 (do_internal_sort) Rewrite to make internal sorting stable.
1328 (compare_case_dblptrs) Removed.
1329 (compare_indexed_cases) New function.
1331 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
1335 * casefile.c: (casereader_read_xfer_assert) New function.
1337 * dictionary.c: (dict_compact_case) New function.
1339 * flip.c: (struct flip_pgm) New member idx_to_fv.
1340 (cmd_flip) Initialize idx_to_fv member.
1341 (destroy_flip_pgm) Free idx_to_fv member.
1342 (flip_sink_write) Use struct flip_pgm member instead of case_sink
1344 (flip_sink_write) Ditto.
1346 * vfm.c: (write_case) Use dict_compact_case() instead of
1348 (compact_case) Removed.
1349 (storage_source_create) Removed `dict' parameter. All references
1352 * vfm.h: (struct case_source) Removed `value_cnt' member. All
1354 (struct case_sink) Removed `dict', `idx_to_fv' members. All
1357 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
1359 More AGGREGATE fixes.
1361 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
1362 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
1364 (initialize_aggregate_info) Fix initialization for MIN, MAX for
1367 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
1369 Start work on testing and debugging AGGREGATE.
1371 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
1372 of a bit-map. Require proper subcommand ordering. Make OUTFILE
1373 subcommand mandatory.
1374 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
1375 functions' arguments are in the correct order and swap them if
1377 (accumulate_aggregate_info) Make SUM include weights. Add various
1379 (dump_aggregate_info) Add various string functions.
1380 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
1382 * sort.c: (sort_parse_criteria) Add parameter for returning
1383 whether any directions were specified. All callers updated.
1385 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
1387 * t-test.q: Fixed erroneous logic in compare_group_binary.
1389 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
1391 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
1392 keywords (bug 11628).
1394 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
1396 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
1397 called *before* close_active_file().
1399 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
1401 * file-handle.q: (struct file_handle) Change open_mode from
1402 character pointer to 3-char array, for safety. Updated all
1405 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
1407 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
1410 * pfm-read.c: (read_header) Improve error message for many cases
1411 in which the input is not actually a portable file.
1413 * file-handle.q: (fh_open) When we give an error message, actually
1416 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
1418 * format.c: (check_common_specifier) New function for checks
1419 common to check_input_specifier() and check_output_specifier().
1420 (check_input_specifier) Use check_common_specifier().
1421 (check_output_specifier) Use check_common_specifier().
1422 (check_string_specifier) Removed.
1423 (check_specifier_type) New function.
1424 (check_specifier_width) New function.
1425 (get_format_var_width) Fix bug.
1427 * formats.c: (internal_cmd_formats) Only accept numeric variables.
1429 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
1430 update all references. Make case-insensitive.
1432 * pfm-read.c: Essentially rewrite the whole file. Now much
1435 * print.c: (check_string_width) New function.
1436 (fixed_parse_compatible) Use check_string_width(),
1437 check_specifier_type().
1438 (dump_fmt_list) Ditto.
1440 * str.c: (st_trim_copy) New function.
1441 (st_uppercase) New function.
1443 * vars-atr.c: (var_is_valid_name) New function.
1445 * expressions/parse.c: (type_coercion_core) Use
1446 check_specifier_type().
1448 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
1450 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
1452 * expressions/parse.c: (no_match) Ditto.
1454 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
1456 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
1458 * expressions/helpers.c: (struct func_params) Removed.
1459 (generalized_idf) Removed.
1462 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
1464 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
1465 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1466 Implement SIG.F, which I had overlooked previously.
1468 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1470 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1471 available only in testing mode.
1473 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1475 * data-in.c: Use `bool' throughout, where relevant.
1477 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1479 DATA LIST with free-field formats should not have implied decimal
1480 places (bug 12035). Also clean up data-in.c a bit.
1482 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1484 * data-in.c: (apply_implied_decimals) New function.
1485 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1486 set. Also, get rid of gotos.
1487 (parse_Z) Use apply_implied_decimals() if the field doesn't
1488 contain a decimal point.
1489 (parse_N) Use apply_implied_decimals().
1495 (parse_enum) New function.
1496 (macro CHAR_IS_ROMAN) Removed.
1497 (macro ROMAN_VALUE) Removed.
1498 (parse_month) Use parse_enum().
1499 (parse_weekday) Use parse_enum().
1500 (parse_DATETIME) Use long for weekday.
1502 * data-list.c: (read_from_data_list_fixed) Use
1503 DI_IMPLIED_DECIMALS.
1505 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1507 When the lexer sees something like `-5' in the input, it has to
1508 decide whether it's a negative numeric constant token or a '-'
1509 token followed by a positive numeric constant token. It always
1510 decides on the former, and then the parser can call
1511 lex_negative_to_dash() if it wants the latter. However, this
1512 doesn't work for the case of `-0', because negative zero is
1513 (portably) indistinguishable from positive zero. So now we divide
1514 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1515 distinction clear. This requires a little bit of extra effort,
1516 because there were several references to T_NUM in the code base.
1518 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1519 positive and negative numeric constants.
1520 (lex_double_p) Renamed lex_is_number(). Changed return type to
1521 bool. Updated all relevant references to T_NUM to instead use
1523 (lex_double) Renamed lex_number(). All references updated.
1524 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1525 bool. All references updated.
1526 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1527 (lex_negative_to_dash) Ditto.
1530 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1532 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1534 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1536 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1538 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1539 values as system-missing.
1541 * expressions/parse.c: (parse_vector_element) Fix order of
1542 arguments in call to expr_allocate_binary().
1544 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1546 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1549 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1550 failure, as indicated by function comment.
1551 (parse_binary_operators) Always return NULL on type_coercion()
1552 failure. Should have been doing this anyway, but bug in
1553 type_coercion_core() filtered through.
1554 (parse_add) Fix typo in user message.
1555 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1557 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1559 * expressions/operations.def: Add VALUE function.
1561 * expressions/parse.c: (parse_function) Need an unary composite
1562 node for variables in A TO B, not a variable node. Use
1563 allocate_unary_variable().
1564 (parse_primary) Use allocate_unary_variable().
1565 (allocate_unary_variable) New function.
1567 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1569 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1570 but fixed the real problem that was preventing the build from a
1571 separate directory. I liked it my way better ;-)
1573 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1575 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1576 John Darrington <john@darrington.wattle.id.au> for reporting this
1579 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1581 * expressions/Makefile.am expressions/evaluate.h.pl
1582 expressions/evaluate.inc.pl expressions/operations.h.pl
1583 expressions/optimize.inc.pl expressions/parse.inc.p:
1585 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1588 Fixed everything so that it can be built from an arbitrary
1591 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1593 * Makefile.am : Fixed up CLEANFILES target.
1595 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1597 * str.h: Changed `struct len_string' to `struct fixed_string', a
1598 more accurate name. Updated all references.
1600 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1602 Redo calendar support. Should now be bug-for-bug compatible.
1604 * calendar.c: New file.
1606 * calendar.h: New file.
1608 * data-in.c: Use new calendar functions.
1609 (parse_sign) Change sense of return value.
1610 (calendar_error) New function.
1611 (ymd_to_ofs) New function.
1612 (ymd_to_date) New function.
1613 (parse_DATE) Use new function.
1614 (parse_ADATE) Ditto.
1615 (parse_EDATE) Ditto.
1616 (parse_SDATE) Ditto.
1617 (parse_JDATE) Ditto.
1622 (parse_DTIME) Ditto.
1623 (parse_DATETIME) Ditto.
1625 * data-out.c: (convert_date) Use new calendar functions.
1627 * error.c: (err_vmsg) Changed interface to be more sensible.
1628 Updated all callers.
1629 (dump_message) Don't double new-lines (why did we do this
1632 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1634 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1635 (macro FLT64_MAX) Moved here from pref.h.orig.
1637 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1639 * set.q: Support SET EPOCH.
1640 (static var set_epoch) New var.
1641 (aux_stc_custom_epoch) New function.
1642 (stc_custom_epoch) New function.
1643 (get_epoch) New function.
1644 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1646 * format.c: Make it possible just to check whether a specifier is
1647 valid without emitting an error message.
1648 (parse_format_specifier_name) Change interface, update all
1650 (check_input_specifier) Ditto.
1651 (check_output_specifier) Ditto.
1652 (parse_format_specifier) Ditto.
1654 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1656 * command.def: Add DEBUG POOL.
1658 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1660 (pool_clear) Properly account for size of pool gizmo.
1661 (pool_realloc) Ditto.
1662 (pool_clone) New function.
1664 * pool.h: Mark our allocation functions MALLOC_LIKE.
1666 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1668 * Makefile.am: Move many definitions into new top-level
1669 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1670 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1673 * case.c: (case_resize) New function.
1674 (case_swap) New function.
1676 * casefile.c: Include mkfile.h.
1678 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1680 * sfm-read.c: Fixed a buglet which caused a crash when trying
1681 to read a non-existent file.
1683 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1687 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1688 Important part: get rid of spurious copying of function->format to
1689 destvar->print and destvar->write.
1691 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1693 Fix bug 11916, which was confusing a variable's `index' member
1694 with the variable's position in a var_set. Although these are
1695 usually the same, they are not for array `var_set's.
1697 Took advantage of this bug as an opportunity to clean up and
1698 rewrite parse_var_set_vars().
1700 * vars-prs.c: (parse_vs_variable_idx) New function.
1701 (parse_vs_variable) Reimplement in terms of
1702 parse_vs_variable_idx().
1703 (parse_var_idx_class) New function.
1704 (add_variable) New function.
1705 (add_variables) New function.
1706 (parse_var_set_vars) Rewritten.
1707 (struct var_set) Change `lookup_var' member that returns a
1708 variable into `lookup_var_idx' member that returns an int.
1709 Updated the var set implementations in obvious corresponding ways.
1710 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1712 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1714 Use our global variable compare & hash functions and give them
1715 better names. Add similar functions for dealing with double
1716 pointers to variables.
1718 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1719 (hash_variable) Renamed hash_var_name().
1720 (compare_var_ptr_names) New function.
1721 (hash_var_ptr_name) New function.
1723 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1725 (compare_var_name) Removed.
1726 (hash_var_name) Removed.
1728 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1732 * dictionary.c: (compare_variable_dblptrs) Rename
1733 compare_var_ptrs() and fix it to properly dereference the double
1736 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1738 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1739 declare subcommands as mandatory. Closed bug #11843
1741 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1743 * getline.c command.[ch] command.def: Added (very rudimentary)
1744 support for line completion when in interactive mode. Partially
1745 addresses bug #11693
1747 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1749 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1750 problems revealed by valgrind.
1753 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1755 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1756 whether or not PAGER is set.
1758 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1760 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1761 "invalid free" errors. Hopefully fixes bug #11722
1763 * compute.c expr-prs.c: Check that lvalues are populated before
1764 attempting to destroy them. Closes bug #11676
1766 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1768 * aggregate.c: Initialised the complete agr_proc structure.
1772 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1774 * print.c: (print_trns_free) Close the dfm writer if there is one,
1775 fixing a memory leak.
1777 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1779 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1783 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1785 * linked-list.[ch] Added
1787 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1788 set.q: Yet more memory leaks
1790 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1792 * t-test.q examine.q : More memory leaks fixed.
1794 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1796 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1799 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1801 * ascii.c cartesian.c casefile.c chart.h devind.c
1802 examine.q frequencies.q
1803 html.c output.h piechart.c plot-chart.c plot-hist.c
1805 Integrated the chart rendering into the output stream
1806 (currently only works for html).
1808 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1809 dummy-chart.c for compiling without charts.
1811 * mkfile.[ch] Created.
1813 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1814 Added type element so we can tell if it's a chart or a table.
1816 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1817 API of charts to be more like that of tables.
1819 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1821 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1822 main.c. Removed the handler for SIGQUIT.
1824 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1826 * casefile.c: Added a signal handler to delete temp files on
1829 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1831 * command.def Added a lot more unimplemented commands.
1833 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1835 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1837 * sort.c: (compare_initial_runs) Needed additional level of
1839 (merge_once) Fix plenty of stupid mistakes.
1841 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1843 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1844 calling casefile_to_disk() or we will lose the last block in the
1845 file if the casefile started out as disk-based.
1846 (casefile_get_reader) Initialize reader->destructive to 0.
1847 (cmd_debug_casefile) Add new test pattern.
1848 (test_casefile) Define new test pattern to make sure
1849 casefile_sleep() works properly.
1851 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1853 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1854 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1855 attempt to seperate the creation and processing of charts from their
1858 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1861 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1863 * main.c Added a signal handler for SIGFPE
1865 * sort.c Somewhat more robust fix to the previous entry.
1867 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1869 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1870 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1871 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1874 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1876 * case.h Fixed bug # 11307
1878 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1880 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1883 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1885 * pfm-read.c: (read_variables) Remove direct manipulation of
1886 v->aux, which is no longer needed. Fixes bug 11483.
1888 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1890 * data-list.c Fixed a bug in parsing delimiters.
1892 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1895 * percentiles.c Properly handled calculation of Tukey hinges where
1896 the number of data is small.
1898 * oneway.q Used the generic value_to_string function for independent
1899 variable instead of trying to do it ourselves.
1901 * box-whisker.c Fixed a buglet which caused a crash if the number of
1905 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1907 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1909 * percentiles.c Fixed some bugs when calculating percentiles when
1910 there's a small number of cases.
1912 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1914 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1916 * examine.q factor_stats.[ch] Added calculation of percentiles
1918 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1920 * t-test.q Fixed bug #11227 Made t-test work when the independent
1923 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1925 * factor_stats.c Fixed calculation of trimmed mean under various
1928 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1930 * histogram.c chart.[ch] factor_stats.c frequencies.q
1932 Added code to calculate sensible histogram ranges and limits.
1934 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1936 * chart.h Updated to reflect many API changes.
1938 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1939 cartesian.c and into chart.c
1941 * factorstats.[ch] Added the histogram calculations
1943 * casefile.c Removed an unused variable.
1945 * frequencies.q examine.q histogram.c Reworked the API for
1948 * piechart.c Revised the API for piecharts.
1950 * var.h Moved the definitions of freq_tab and freq out of var.h
1951 and into frequencies.q where they belong.
1953 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1955 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1956 using AC_TYPE_OFF_T.
1958 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1960 * flip.c: (flip_file) If fseeko() is not available, use long int
1961 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1962 reporting the problem.
1964 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1966 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1967 conflict with stdio.
1969 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1971 * var-labs.c (var_to_string) Now returns null if the variable is null
1973 * value-labels.c (value_to_string) Made it return null if either the
1974 value or the variable is null.
1976 * hash.c (hsh_clear) Fixed a buglet.
1978 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1979 with the wrong model.
1981 * casefile.[ch] Added a function to return the casereader.case_idx
1984 * examine.q Implemented the extreme values results.
1986 John Darrington <john@darrington.wattle.id.au>
1988 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1989 output.[ch] getline.c
1991 Plugged some memory leaks
1993 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1995 Adopt GSL random number generators, paving the way for providing
1996 the complete suite of random number generators on expressions.
1998 * Makefile.am: Remove random.c, random.h.
2000 * random.c: Removed.
2002 * random.h: Removed.
2004 * algorithm.c: (algo_default_random) Use GSL functions.
2006 * casefile.c: (test_casefile) Use GSL RNG functions.
2008 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
2011 * sample.c: (cmd_sample) Use GSL RNG functions.
2012 (sample_trns_proc) Ditto.
2014 * set.q: (static var set_seed) Removed.
2015 (static var seed_flag) Removed.
2016 (static var rng) New variable.
2017 (aux_stc_custom_seed) No seed value anymore, don't print anything.
2018 (stc_custom_seed) Use new seed functions.
2019 (seed_is_set) Removed.
2020 (get_rng) New function that composes the entire external
2022 (set_rng) New function.
2023 (random_seed) New function.
2025 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
2027 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
2028 John Darrington <john@darrington.wattle.id.au> for reporting this
2031 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2033 * permissions.c command.def Added the PERMISSIONS command
2035 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
2037 * q2c.c: (dump_header) Don't try to emit #includes at very top of
2038 output file because that will precede #include <config.h>, which
2040 (main) Add needed headers to /* (header) */ code.
2042 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
2044 Instead of making system or portable file readers responsible for
2045 dropping and reordering variables, make them read full cases and
2046 let the caller take care of any changes.
2048 * get.c: New "case map" structure to handle this. Use for GET,
2049 IMPORT, MATCH FILES. Essentially rewrite the whole file.
2051 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
2052 changed appropriately.
2054 * sfm-read.c: (sfm_read_case) Ditto.
2056 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
2058 Decided that case_serialize() and case_unserialize() were too
2059 abstract. Also we need a couple more functions to avoid excessive
2060 copying for data in/out fast paths.
2062 * case.c: (case_serial_size) Removed.
2063 (case_serialize) Rename case_to_values() and make its argument
2064 explicitly an array of union values.
2065 (case_unserialize) Rename case_from_values() and make its argument
2066 explicitly an array of union values.
2067 (case_data_all) New function.
2068 (case_data_all_rw) New function.
2070 * casefile.c: (struct casefile) Change buffer from array of
2071 unsigned char to array of union value for better accuracy.
2072 Redefine buffer_used and buffer_size in terms of values, not
2073 bytes. Remove case_size because it is now redundant with
2074 value_cnt. Fix up all references to these members.
2076 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
2078 * barchart.c: (struct subcat) Make `label' member const to silence
2079 GCC warning with -Wwrite-strings.
2081 * cartesian.c: (struct dataset) Ditto.
2083 * case.c: Don't re-define NDEBUG if already defined.
2084 Add lots of comments.
2086 * str.c: Fix includes.
2088 * crosstabs.q: Fix includes.
2090 * examine.q: Fix includes. Fix GCC warning about unused
2093 * frequencies.q: (stat macro) Removed and replaced where used by
2096 * list.q: Fix includes.
2098 * oneway.q: Fix includes.
2100 * piechart.c: Fix includes. Only define M_PI if not already
2103 * sfm-read.c: (bswap) New function.
2104 (bswap_int32) Write in terms of bswap.
2105 (bswap_flt64) Ditto.
2107 * str.c: (ds_data) Add external definition here, needed because
2108 str.h has only an `extern inline' version.
2110 * value-labels.c: Fix includes.
2112 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
2114 Instead of providing a system or portable file writer with a raw
2115 case in the format needed for output, provide it with a regular
2116 case. The writer takes care of any needed translation.
2118 * aggregate.c: Adopt new scheme for AGGREGATE.
2119 (struct agr_proc) sfm_agr_case member removed.
2120 (write_case_to_sfm) Removed because the new interface is easier to
2123 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
2125 * pfm-write.c: Implement new scheme.
2127 * sfm-write.c: Ditto.
2129 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
2131 Instead of treating `struct file_handle' as a class to subclass
2132 into data files, system files, and portable files, instead use it
2133 as a helper that coordinates access. Now it is opaque, too.
2135 This means that most references to a struct file_handle are now
2136 changed into references to one of struct dfm_reader, struct
2137 dfm_writer, struct sfm_reader, struct sfm_writer, struct
2138 pfm_reader, or struct pfm_writer, according to what's being read
2141 Most related changes are only worth summarizing briefly.
2143 * dictionary.c: (dict_clear) Destroy aux data in deleted
2145 (dict_clear_aux) New function.
2146 (dict_create_var) Initialize aux, aux_dtor.
2147 (dict_delete_var) Destroy aux data in deleted variable.
2149 * file-handle.h: (struct fh_ext_class) Removed.
2150 (struct file_handle) Removed.
2151 (fh_init_files) Removed.
2153 * file-handle.q: Changed references to a handle's `private' member
2154 to direct references.
2155 (struct private_file_handle) Renamed file_handle.
2156 Add next, open_cnt, type, open_mode, aux members.
2157 (struct file_handle_list) Removed.
2158 (extern var inline_file) Removed.
2159 (static var file_handles) Changed from file_handle_list * to
2161 (create_file_handle) Initialize new members.
2162 (fh_close_handle) Removed.
2163 (mode_name) New function.
2164 (fh_open) New function.
2165 (fh_close) New function.
2166 (fh_parse_file_handle) Renamed fh_parse().
2168 * glob.c: (init_glob) Remove fh_init_files() call.
2170 * aggregate.c: use sfm_writer.
2171 (create_sysfile) Removed because the new interface is simpler.
2173 * apply-dict.c: Use sfm_reader.
2175 * data-list.c: Use dfm_reader.
2177 * file-type.c: Use dfm_reader.
2179 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
2181 * inpt-pgm.c: Use dfm_reader.
2183 * print.c: Use dfm_writer.
2185 * sysfile-info: Use sfm_reader.
2187 * dfm-read.c: Adopt new file handle infrastructure.
2189 * dfm-write.c: Ditto.
2191 * pfm-read.c: Ditto.
2193 * pfm-write.c: Ditto.
2195 * sfm-read.c: Ditto.
2197 * sfm-write.c: Ditto.
2199 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
2201 Break dictionary functions into separate header file.
2203 * dictionary.h: New file.
2205 * var.h: Moved dict_*() functions to dictionary.h.
2207 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
2209 Get rid of procedure-specific union in struct variable, using
2210 instead a void * pointer and a destructor function.
2212 Most related changes are only worth brief summaries.
2214 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
2215 old p.crs member in struct variable.
2217 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
2218 of old p.frq member in struct variable.
2220 * histogram.c: (draw_histogram) Takes new freq_tab arg because
2221 it's no longer possible to grab this from var->p.frq.
2223 * piechart.c: (draw_piechart) Ditto.
2225 * group.c: (group_proc_get) New function.
2227 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
2234 * main.c: (execute_command) Clear aux data in default_dict after
2235 each command. (It's debatable whether this should be done.)
2237 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
2238 member in struct variable.
2240 * means.q: Get rid of integer mode, which is not included in
2241 recent SPSS and was the only code that wanted per-variable private
2244 * var.h: (struct crosstab_proc) Removed.
2245 (struct frequencies_proc) Removed.
2246 (struct list_proc) Removed.
2247 (struct get_proc) Removed.
2248 (struct means_proc) Removed.
2249 (struct matrix_data_proc) Removed.
2250 (struct match_files_proc) Removed.
2251 (lots of enums) Removed.
2252 (struct variable) Removed members `p', `get'. Add member
2255 * vars-atr.c: (var_attach_aux) New function.
2256 (var_detach_aux) New function.
2257 (var_clear_aux) New function.
2258 (var_dtor_free) New function.
2259 (discard_variables) Use NULL instead of inline_file.
2261 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2263 * value-labs.c Fixed the implmentation of value_to_string, so
2264 that it properly handles alpha values.
2266 * oneway.q Changed instances where labels were being probed manually,
2267 to use the canonical {var,value}_to_string functions
2269 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2271 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
2272 plots. Changed the API of the cartesian plot to be a much lower level
2275 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
2277 * examine.q Added some of the parametric calculations
2279 * factor_stats.[ch] Created
2281 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2283 * examine.q Changed the definition of factors to be a composite, and
2284 dealt with the consequences.
2286 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
2288 * examine.q Fixed problem where examine wasn't dealing properly with
2291 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
2293 * oneway.q Fixed problem where oneway wasn't dealing properly with
2296 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
2298 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
2299 command which had settings didn't get the appropriate code
2302 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
2303 to convert variables/values to strings.
2305 * examine.q Added framework for the EXAMINE command.
2307 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
2309 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
2310 subcommand types. Changed frequencies.q to use it rather then the
2311 custom parser. Dealt with the consequences. Added a test for NTILES
2312 subcommand of frequencies.
2314 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
2316 * oneway.q Fixed up the behaviour when given missing values
2318 * levene.c oneway.q Fixed a buglet with the levene statistic and
2319 incorporated the levene test into the oneway command.
2321 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
2322 global scope, since they're only relevant to T-TEST
2324 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
2326 * group.c group.h group_proc.h levene.c oneway.q t-test.q
2328 Made the t-test more consistent
2329 with the way it handles groups. That is, it now uses a hash instead
2330 of an array of 2. Also, made the levene.c file independent of the
2331 implementation of the t-test. So now levene should be fine for both
2334 * Added an oneway.q file for one way anova
2336 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
2338 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
2341 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
2345 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
2346 (data_list_trns_free) Free dls->delims.
2348 * t-test.q: (tts_custom_pairs) Free vars.
2349 (ssbox_one_sample_init) Fix tab_vline() argument.
2350 (ssbox_independent_samples_init) Ditto.
2351 (trbox_paired_init) Ditto.
2352 (trbox_one_sample_init) Ditto.
2354 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
2356 Generalize casefiles to the extent that we can use them for
2357 sorting and other kinds of data transformations. Change cases to
2358 be copy-on-write to improve memory efficiency in common cases.
2359 Every access to a member of a `struct ccase' was changed to be a
2360 call to a case_*() function, especially case_data(), case_num(),
2361 case_str(), or case_data_rw(). Many instances of a local variable
2362 named "case_num" were changed to "case_idx" as a consequence.
2363 Many `struct ccase *' were changed to actual `struct ccase'
2364 because of copying semantics of cases. In several places there
2365 was a choice between updating debug code to work with the new ADTs
2366 or just deleting it because it was useless; I chose to delete it.
2368 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
2374 * aggregate.c: (struct agr_proc) Change type of `sort' to
2375 sort_criteria *. Add `break_vars', `break_var_cnt' members.
2376 Rename `vars' to `agr_vars', all references updated. Change
2377 `agr_case' to type `struct ccase'.
2378 (cmd_aggregate) Deal with new members. Use case_create(),
2379 sort_active_file_in_place(), sort_active_file_to_casefile().
2380 (agr_destroy) Deal with new members.
2381 (aggregate_single_case) Ditto.
2382 (dump_aggregate_info) Ditto.
2383 (initialize_aggregate_info) Ditto.
2384 (agr_to_active_file) Ditto.
2385 (presorted_agr_to_sysfile) Ditto.
2386 (sort_agr_to_sysfile) Removed.
2388 * alloc.c: (out_of_memory) Make non-static.
2390 * alloc.h: Prototype out_of_memory().
2392 * casefile.c: Switched from a linked list in-memory representation
2393 to a two-level array-style representation. The linked list was
2394 appropriate when we could stick a header onto cases, but that's no
2395 longer the case. Also, the two-level array will allow for random
2396 in-memory access in case that's ever wanted. Also added the
2397 concept of a `destructive casereader', one that destroys cases in
2398 the underlying casefile as they are read out.
2399 (macro CASES_PER_BLOCK) New macro.
2400 (struct casefile) New members `value_cnt', `case_list_size',
2401 `case_acct_size', `being_destroyed', `cases'. Removed `head',
2403 (struct casereader) Removed `cur'. Added `destructive', `c'.
2404 (global var casefiles) Made static.
2405 (static var case_bytes) New var.
2406 (casefile_create) Takes a value count, not a case size in bytes,
2407 to conform to the case interface. All callers updated. Deal with
2408 new and removed members.
2409 (casefile_destroy) Deal with new and removed members.
2410 (casefile_sleep) New function.
2411 (casefile_get_case_size) Removed.
2412 (casefile_get_value_cnt) New function.
2413 (casefile_append) Rewritten to deal with new and removed members.
2414 (casefile_append_xfer) New function.
2415 (write_case_to_disk) Use case_serialize().
2416 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
2417 Couldn't figure out why.
2418 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
2419 deal with new and removed members.
2421 (merge_sort) Removed.
2422 (casefile_sort) Removed.
2423 (casefile_get_reader) Deal with new and removed members.
2424 (casefile_get_destructive_reader) New function.
2425 (reader_open_file) Make code more readable. Create case for
2427 (casereader_get_casefile) New function.
2428 (casereader_read) Deal with new and removed members. Now returns
2429 a copy of the case, so that the caller is responsible for
2430 destroying the returned case.
2431 (casereader_read_xfer) New function.
2432 (casereader_destroy) Destroy reader's case.
2433 (test_casefile) Second arg is now a value count, all callers
2434 updated. Now tests destructive readers too.
2435 (get_random_case) Deal with new case ADT.
2436 (write_random_case) Ditto.
2437 (read_and_verify_random_case) Ditto.
2439 * crosstabs.q: Remove debug code.
2441 * descript.q: (calc_descriptives) Deal with new case, casefile
2444 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
2446 * do-if.c: Remove unneeded header inclusion.
2448 * expr-prs.c: Remove debug code.
2450 * exprP.h: Remove debug code.
2452 * flip.c: (flip_file) Use fseeko() if available.
2454 * formats.c: Remove debug code.
2456 * get.c: Remove debug code.
2457 (struct mtf_file) Change `input' from `union value *' to `struct
2458 ccase', all references updated.
2460 * levene.c: (levene) Deal with new case, casefile ADTs.
2462 * list.q: Remove debug code.
2464 * loop.c: Remove debug code.
2466 * matrix-data.c: Remove debug code.
2468 * means.q: Remove debug code.
2470 * mis-val.c: Remove debug code.
2472 * pfm-read.c: Remove debug code.
2473 (pfm_read_code) Change second arg from `union value *' to `struct
2474 ccase *', all references updated.
2476 * recode.c: (string_to_long) Make first arg const.
2477 (convert_to_double) Ditto.
2479 * repeat.c: Remove debug code.
2481 * sample.c: Remove debug code.
2483 * sfm-read.c: Remove debug code.
2484 (sfm_read_case) Change second arg from `union value *' to `struct
2487 * sort.c: Redone in terms of casefiles.
2488 (enum sort_direction) Moved here from sort.h.
2489 (struct sort_criterion) New structure.
2490 (struct sort_criteria) New structure.
2491 (cmd_sort_cases) Rewritten.
2492 (prepare_to_sort_active_file) New function.
2493 (sort_active_file_in_place) New function.
2494 (sort_active_file_to_casefile) New function.
2495 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2496 changed, all callers updated.
2497 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2498 rewritten & interface changed, all callers updated.
2499 (sort_cases) Renamed sort_execute(), rewritten & interface
2500 changed, all callers updated.
2501 (struct internal_sort) Removed.
2502 (do_internal_sort) Rewritten, interface changed.
2503 (destroy_internal_sort) Removed.
2504 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2505 (struct initial_run) Removed; an initial run is now just a
2507 (compare_initial_runs) Rewritten.
2508 (struct external_sort) Changed almost completely.
2509 (do_external_sort) Rewritten, interface changed.
2510 (destroy_external_sort) Rewritten.
2511 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2512 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2513 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2514 (init_external_sort) Removed.
2515 (simulate_error) Removed.
2516 (rmdir_temp_dir) Removed.
2517 (get_temp_file_name) Removed.
2518 (open_temp_file) Removed.
2519 (close_temp_file) Removed.
2520 (remove_temp_file) Removed.
2521 (write_temp_file) Removed.
2522 (read_temp_file) Removed.
2523 (struct record_run) Change `record' from `struct case_lit *' to
2525 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2526 `file_idx', `output_file'. Add `run', casefile'. Change
2527 `last_output' from `struct case_list *' to `struct ccase'.
2528 (write_initial_runs) Change interface, rewrite.
2529 (sort_sink_write) Renamed process_case(), changed interfaced,
2531 (destroy_initial_run_state) Rewritten.
2532 (allocate_cases) Rewritten.
2533 (compare_record) Interface changed, rewritten.
2534 (start_run) Rewritten.
2535 (end_run) Rewritten.
2536 (output_record) Rewritten.
2537 (grab_case) Removed.
2538 (release_case) Removed.
2539 (struct merge_case) Change `cases' from double pointer to single
2541 (merge) Deal with new case and casefile ADTs.
2542 (struct run) Removed.
2543 (merge_once) Rewritten, interface changed.
2544 (fill_run_buffer) Removed.
2545 (sort_sink_make_source) Removed.
2546 (sort_sink_class) Removed.
2547 (struct sort_source_aux) Removed.
2548 (sort_source_read_helper) Removed.
2549 (sort_source_read) Removed.
2550 (read_sort_output) Removed.
2551 (read_internal_sort_output) Removed.
2552 (read_external_sort_output) Removed.
2553 (sort_source_destroy) Removed.
2554 (sort_source_class) Removed.
2556 * sort.h: (struct sort_cases_pgm) Removed.
2557 (enum sort_direction) Moved to sort.c.
2559 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2561 * tab.c: Remove debug code.
2563 * var-labs.c: Remove debug code.
2565 * var.h: (struct ccase) Removed.
2566 (struct case_list) Removed.
2568 * vars-atr.c: (discard_variables) Use free_case_source().
2570 * vars-prs.c: (parse_vs_variable) Make arg const.
2571 (parse_dict_variable) Ditto.
2572 (parse_variables) Make struct dictionary * arg const.
2573 (parse_var_set_vars) Make struct var_set * arg const.
2574 (struct var_set) Add const to some of the function pointers' args.
2575 (var_set_get_cnt) Make arg const.
2576 (var_set_get_var) Make first arg const.
2577 (var_set_lookup_var) Make first arg const.
2578 (dict_var_set_get_cnt) Make arg const.
2579 (dict_var_set_get_var) Make first arg const.
2580 (dict_var_set_lookup_var) Make first arg const.
2581 (var_set_create_from_dict) Make arg const. Add cast to aux
2583 (struct array_var_set) Add const to var member.
2584 (array_var_set_get_cnt) Make arg const.
2585 (array_var_set_get_var) Make first arg const.
2586 (array_var_set_lookup_var) Make first arg const.
2587 (var_set_create_from_array) Make first arg const. Insert cast.
2589 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2590 members from `struct ccase *' to `struct ccase'.
2591 (static var lag_queue) Change from double to single pointer.
2592 (procedure) Optimize trivial case.
2593 (internal_procedure) Deal with changed case, case_source ADTs.
2594 (create_trns_case) Changed interface, rewrote.
2595 (open_active_interface) Initialize modified lag queue.
2596 (write_case) Deal with changed case ADT.
2597 (lag_case) Deal with modified lag queue.
2598 (close_active_file) Destroy modified lag queue.
2599 Deal with changed case_source, case_sink ADTs.
2600 (destroy_storage_stream_info) Make null arg into no-op.
2601 (storage_sink_make_source) Set aux in created source.
2602 (storage_source_read) Deal with changed case, casefile ADTs.
2603 (storage_source_create) New function.
2604 (lagged_case) Rewrite.
2605 (free_case_source) New function.
2606 (free_case_sink) Rewrite.
2607 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2609 (procedure_with_splits) Deal with changed prev_case.
2610 (procedure_with_splits_callback) Ditto.
2611 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2613 (multipass_procedure_with_splits) Deal with changed prev_case.
2614 (multipass_split_callback) Ditto.
2617 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2619 The workspace idea didn't work out.
2621 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2623 * workspace.c: Removed.
2625 * workspace.h: Removed.
2627 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2629 Fully implement arbitrary delimiters on DATA LIST, extending the
2630 half implementation that was already there.
2632 * data-list.c: (struct data_list_pgm) Remove `delim', add
2633 `delims', `delim_cnt'.
2634 (cmd_data_list) Initialize new members. Parse delimiters and
2635 clean up code a bit.
2636 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2637 handling of leading commas.
2638 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2640 (read_from_data_list_free) Adapt to new DFM interfaces.
2641 (read_from_data_list_list) Ditto.
2642 (repeating_data_trns_proc) Ditto.
2644 * dfm.c: Split up reader and writer into separate code, because
2645 they do different things. Use struct string instead of explicit
2646 allocation code, for clarity.
2647 (enum dfm_reader_flags) New enum.
2648 (struct dfm_fhuser_ext) Removed.
2649 (struct dfm_reader_ext) New.
2650 (get_reader) New function, used by just about all the reader
2652 (dfm_close) Removed.
2653 (close_reader) New function.
2654 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2655 (dfm_open_for_writing) Ditto.
2656 (macro force_line_buffer_expansion) Removed.
2657 (count_tabs) Removed.
2658 (tabs_to_spaces) Removed.
2659 (read_record) Deal with new dfm_reader_ext. Use struct string
2660 functions. Don't convert tabs to spaces.
2661 (dfm_eof) New function.
2662 (dfm_get_record) Changed interface, rewrote.
2663 (dfm_expand_tabs) New function.
2664 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2665 dfm_reader_ext, rewritten.
2666 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2667 dfm_reader_ext, rewritten.
2668 (dfm_set_record) Removed in favor of dfm_forward_columns().
2669 (dfm_forward_columns) New function.
2670 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2671 dfm_reader_ext, rewritten.
2672 (static var dfm_r_class) Use close_reader for the destructor.
2673 (struct dfm_writer_ext) New.
2674 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2675 bounce buffer now instead of local allocation.
2676 (close_writer) New function.
2677 (static var dfm_writer_ext) Use close_writer for destructor.
2678 (cmd_begin_data) Adapt to new dfm_reader_ext.
2680 * file-handle.q: Add support for per-file tab width.
2681 (struct private_file_handle) Add tab_width member.
2682 (q2c specifications) Add tabwidth subcommand.
2683 (cmd_file_handle) Put parsed tab width into private_file_handle.
2684 (create_file_handle) Set default tab width.
2685 (handle_get_tab_width) New function.
2687 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2689 * inpt-pgm.c: (reread_trns_proc) Ditto.
2691 * matrix-data.c: (context) Ditto.
2692 (another_token) Ditto.
2696 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2698 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2700 (casereader_destroy) Don't close file descriptor -1.
2702 * recode.c: (cmd_recode) Fix memory leak.
2704 * set.q: (q2c specifications) Fix typo in user message.
2706 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2707 undefined behavior for overlapping arguments.
2709 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2711 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2712 don't call it when we're running under valgrind.
2713 (call_posix_fadvise) New function.
2714 (casefile_to_disk) Use call_posix_fadvise().
2715 (reader_open_file) Ditto.
2717 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2719 Update our string ADTs, struct string and struct len_string. Get
2720 rid of pool support, which was largely unused. Rename lots of
2721 functions to have more obvious or consistent names.
2723 * ascii.c: Get rid of ascii_pool. It was only used for string
2725 (ascii_open_global) Don't create ascii_pool.
2726 (ascii_close_driver) Don't destroy ascii_pool.
2727 (ascii_postopen_driver) Don't use pool.
2728 (ascii_close_driver) Destroy strings manually.
2730 * str.c: (ds_create) Remove pool argument, all references updated.
2732 (ds_replace) Remove pool support, make more efficient when we
2733 don't need to reallocate.
2734 (ds_destroy) Remove pool support.
2735 (ds_rpad) New function.
2736 (ds_size) Renamed ds_capacity(), all references updated.
2737 (ds_value) Renamed ds_c_str(), all references updated.
2738 (ds_concat) Renamed ds_puts(), all references updated.
2739 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2740 (ds_putchar) Renamed ds_putc(), all references updated.
2741 (ds_getline) Renamed ds_gets(), all references updated.
2742 (ls_create) Remove pool argument, all references updated.
2743 (ls_create_buffer) Ditto.
2744 (ls_destroy) Removed pool support.
2745 (ls_value) Renamed ls_c_str(), all references updated.
2747 * str.h: (ls_length) [__GNUC__] Add inline version.
2748 (ls_c_str) [__GNUC__] Add inline version.
2749 (ls_end) [__GNUC__] Add inline version.
2750 (struct string) Remove pool member. Rename `size' to `capacity',
2751 all references updated.
2753 * tab.c: (text_format) Instead of using pool argument to
2754 ls_create_buffer(), call pool_register() on allocated data.
2756 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2758 We're abusing the current ASCII driver by telling it to allocate a
2759 9999-line, 9999-character page in the tests. This causes some
2760 systems to curl up and die because it allocates 20 MB of
2761 contiguous RAM. This change alleviates at least part of the
2762 problem. It is mostly a stop-gap until the new output system is
2765 * ascii.c: (struct line) New structure.
2766 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2767 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2768 (ascii_preopen_driver) Initialize new members, not old ones.
2769 (ascii_close_driver) Destroy new members, not old ones.
2770 (ascii_open_page) Allocate new members, not old ones.
2771 (expand_line) Allocate room in line.
2772 (draw_line) Use new members.
2773 (ascii_line_horz) Ditto.
2774 (ascii_line_vert) Ditto.
2775 (ascii_line_intersection) Ditto.
2777 (output_lines) Ditto.
2778 (ascii_close_page) Ditto.
2780 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2782 * matrix.c: Dead code. Removed.
2784 * matrix.h: Dead code. Removed.
2786 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2788 Contrary to what I'd always understood, there is an efficient
2789 algorithm for deletion from a hash table populated via linear
2790 probing. This change implements it.
2792 * hash.c: (hsh_rehash) Probe in increasing order.
2794 (locate_matching_entry) Ditto.
2795 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2797 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2799 * moments.c (calc_moments): Adjust calculation of kurtosis to
2800 avoid subtracting huge numbers from huge numbers, on Michael
2803 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2805 Rework moments routines for improved numerical stability based on
2806 Michael Kiefte's advice. Any bugs or remaining numerical problems
2807 are still mine though.
2809 There is now a struct moments1 for use with one-pass moments. It
2810 uses a provisional means algorithm as an attempt to improve
2811 accuracy of higher moments. The older struct moments now only
2812 handles two-pass moments.
2814 * aggregate.c: Use moments1 instead moments.
2816 * descript.c: Revert previous change, which is no longer needed
2817 due to the moments revision.
2819 * moments.c: (calc_moments) New function for calculating variance,
2821 (moments_pass_one) Only accumulate weights bigger than zero.
2822 (moments_calculate) Allow calculating the mean on pass one, others
2823 require pass two. Implement in terms of calc_moments().
2824 (struct moments1) New structure.
2825 (init_moments1) New function.
2826 (moments1_clear) Ditto.
2827 (moments1_create) Ditto.
2828 (moments1_add) Ditto.
2829 (moments1_calculate) Ditto.
2830 (moments1_destroy) Ditto.
2831 (cmd_debug_moments) Deal with `struct moments' or `struct
2832 moments1' as requested by user.
2834 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2836 * Makefile.am (pspp_SOURCES): Remove debug.c.
2838 * debug.c: Removed. It was empty anyway.
2840 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2842 * descript.c (calc_descriptives): Fix assert failure when only
2843 MOMENT_MEAN is needed.
2845 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2849 fixed problem with parsing in match_statistic() causing
2850 "DESCRIPTIVE STAT=MEAN." to barf.
2852 "MEAN" is now default if "SORT" given without specification.
2854 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2855 generally less forgiving of syntax errors: better to have it do
2856 nothing and type it in again then to not know what it actually did
2859 z-score transformation now checks score for user-missing values
2860 and checks std_dev for SYSMIS.
2862 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2864 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2865 Changed dict_get_case_weight() to accept an additional int * flag
2866 to complain about system-missing, user-missing, zero, or negative
2867 weights and updated existing functions to pass int * to
2868 dict_get_case_weight().
2870 2004-04-05 jmd <jmd@gnu.org>
2872 * main.c: Fixed configuration problems with gsl
2874 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2876 2004-04-03 blp <blp@gnu.org>
2878 * lexer.c, ChangeLog:
2879 Fix infinite loop on comment at end of file, add test.
2881 2004-04-03 jmd <jmd@gnu.org>
2883 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2884 Fixed the calculation of percentiles and added --syntax and --algorithm options
2886 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2888 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2891 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2893 * frequencies.q: Fixed the calculation of percentiles
2895 * Makefile.am: Added the --ansi flag and dealt with the
2896 consequences. Added some entries to PSPP_sources so that
2897 make distcheck would pass
2899 * cmdline.c: Added the --syntax and --algorithm options
2901 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2903 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2905 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2906 use the new multipass_split_... mechanism.
2908 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2910 * frequencies.q: (calc_stats) Use moments data structure and
2911 calc_seskew(), calc_sekurt() functions.
2913 * set.q main.c settings.h Added support for --syntax and --algorithm
2916 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2918 * vfm.c: Had to get last call to multipass_split_output() inside
2919 open_active_file()/close_active_file() pairing, so introduce new
2921 (internal_procedure) Move procedure() code here, except for calls
2922 to open_active_file() and close_active_file().
2923 (procedure) Wrap open_active_file() and close_active_file() around
2924 internal_procedure().
2925 (multipass_procedure_with_splits) Wrap open_active_file() and
2926 close_active_file() around internal_procedure().
2928 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2930 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2932 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2934 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2936 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2938 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2940 * algorithm.c: By default turn off some of the more expensive
2942 (expensive_assert) New macro which expands to assert if
2943 EXTRA_CHECKS is defined, to nothing otherwise.
2944 (unique) Use expensive_assert().
2945 (binary_search) Ditto.
2951 * command.c: (conflicting_3char_prefixes) Words that are the same
2952 don't cause conflicts when they are abbreviated to the first three
2955 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2956 nonterm_node's n earlier.
2957 (generic_str_func) Ditto.
2959 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2961 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2962 test multipass support, take advantage of new moments
2963 calculation, and to not be such crappy code. Get rid of q2c
2964 processing for DESCRIPTIVES.
2966 * vfm.c: (struct multipass_split_aux_data) New structure.
2967 (multipass_procedure_with_splits) New function.
2968 (multipass_split_callback) New function.
2969 (multipass_split_output) New function.
2970 * descript.q: Removed.
2972 * descript.c: New file.
2974 * var.h: Removed descriptives enums.
2975 (struct descriptives_proc) Removed.
2976 (struct variable) Removed p.dsc.
2978 * Makefile.am: (q_sources_c) Remove descript.c.
2979 (q_sources_q) Removed descript.q.
2981 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2983 New manager for keeping track of used workspace.
2985 * workspace.c: New file.
2987 * workspace.h: New file.
2989 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2991 * sort.c: (do_internal_sort) Use workspace_malloc().
2992 (destroy_internal_sort) Use workspace_free().
2994 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2996 New `struct casefile' for managing sets of cases.
2998 * casefile.c: New file.
3000 * casefile.h: New file.
3002 * command.def: Add DEBUG CASEFILE command.
3004 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
3006 * sort.c: (sort_cases) Move logic for sending storage file to disk
3007 into do_external_sort().
3008 (struct internal_sort) Use an array of ccase pointers instead of a
3010 (do_internal_sort) Rewrite to handle casefiles.
3011 (compare_case_list) Removed.
3012 (compare_cases) New function.
3013 (compare_case_dblptrs) New function.
3014 (read_internal_sort_output) Deal with new struct internal_sort.
3016 * vfm.c: (static var workspace_overflow) Removed.
3017 (struct storage_stream_info) Removed all the members. Added
3018 struct casefile * member.
3019 (storage_sink_open) Use casefile.
3020 (open_storage_file) Removed.
3021 (write_storage_file) Removed.
3022 (storage_to_disk) Removed.
3023 (destroy_storage_stream_info) Use casefile.
3024 (storage_sink_write) Use casefile.
3025 (storage_sink_make_source) Use casefile.
3026 (storage_source_count) Use casefile.
3027 (storage_source_read) Use casefile.
3028 (storage_source_on_disk) Removed.
3029 (storage_source_get_cases) Removed.
3030 (storage_source_set_cases) Removed.
3031 (storage_source_get_casefile) New function.
3033 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
3035 New `struct moments' for calculating moments.
3041 * moments.c: New file.
3043 * moments.h: New file.
3045 * command.def: Add DEBUG MOMENTS command.
3047 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
3050 * aggregate.c: Modify AGGREGATE to use the new moments
3051 calculation, even if not in such a great way.
3052 (struct agr_var) Add `moments' member.
3053 (parse_aggregate_functions) Set `moments' member to null.
3054 (agr_destroy) Destroy `moments' member.
3055 (accumulate_aggregate_info) Use `moments' for standard deviation.
3056 (dump_aggregate_info) Ditto.
3057 (initialize_aggregate_info) Create or clear `moments'.
3059 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
3060 cube(), pow4() that were in stats.h. All references updated.
3062 * crosstabs.q: stats.h had chi-square significance functions. Use
3064 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
3066 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
3067 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
3069 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
3071 * dictionary.c: (dict_compact_values) Compacted values need to
3074 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
3076 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
3077 `/' at start. Check return value of parse_variables() for error
3080 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
3082 Revamp expressions: make the code a little nicer, and fix bugs
3085 * expr-evl.c: (expr_evaluate) Make expression argument const.
3086 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
3087 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
3088 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
3089 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
3090 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
3091 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
3092 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
3093 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
3094 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
3095 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
3096 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
3097 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
3098 Simplify OP_SYSMIS. Remove OP_STR_MIS.
3100 * expr-opt.c: (optimize_expression) Rewrite.
3105 (macro s0l) Removed.
3107 (macro s1l) Removed.
3109 (macro s2l) Removed.
3112 (eq_num_con) New function.
3113 (optimize_tree) New function.
3114 (macro rnc) Removed.
3115 (macro frnc) Removed.
3116 (str_search) Add const to string params.
3117 (str_rsearch) Ditto.
3118 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
3119 str[], str_len[] locals to substitute for most of removed macros.
3120 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
3121 Removed support for missing values because we're never called with
3122 missing values. Use set_number() or set_number_errno() instead of
3123 rnc or frnc. Removed any stuff that caused trouble in testing.
3124 We can re-add it later if it really slows anything. Fix some
3126 (evaluate_tree_with_missing) Not yet supported. To be added later
3128 (repl_num_con) Removed.
3129 (collapse_node) New function.
3130 (force_repl_num_con) Removed.
3131 (set_number) New function.
3132 (set_number_errno) New function.
3133 (repl_str_con) Removed.
3134 (set_string) New function.
3135 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
3137 (dump_node) No special case for OP_AND, OP_OR.
3139 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
3140 (expr_get_type) New function.
3141 (type_check) Rewrite.
3142 (type_coercion) New function.
3143 (struct operator) New structure.
3144 (match_operator New function.
3145 (parse_binary_operators) New function.
3146 (parse_inverting_unary_operator) New function.
3147 (parse_or) Rewritten.
3148 (parse_and) Rewritten.
3149 (parse_not) Rewritten.
3150 (parse_rel) Rewritten.
3151 (parse_add) Rewritten.
3152 (parse_mul) Rewritten.
3153 (parse_neg) Rewritten.
3154 (parse_exp) Rewritten.
3155 (parse_sysvar) Add $TRUE, $FALSE system variables.
3156 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
3157 (parse_primary) Use allocate_var_node(), allocate_num_con(),
3159 (struct function) Remove desc, change `func' prototype.
3160 (unary_func) Remove special cases.
3161 (MISSING_func) Reduce to unary_func() that just returns a boolean.
3162 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
3163 (VALUE_func) Use allocate_var_node().
3164 (nary_num_func) Allow MIN and MAX for strings.
3165 Use allocate_var_node(). Properly clean up.
3167 (generic_str_func) Use local table instead of removed `desc'
3168 member. Mostly rewrite.
3169 (get_num_args) Revise error message.
3170 (parse_function) Return EXPR_ERROR, not 0 on error.
3172 (macro varies) Removed.
3173 (ops[]) Use expr.def.
3174 (free_node) Do nothing if node is null.
3175 (allocate_num_con) New function.
3176 (allocate_str_con) New function.
3177 (allocate_var_node) New function.
3178 (allocate_binary_nonterminal) New function.
3179 (append_nonterminal_arg) Removed.
3180 (static var func_tab[]) Revised.
3181 (expr_debug_print_postfix) Make parameter const.
3182 Use printf() instead of debug_printf().
3184 * expr.def: New file.
3186 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
3187 use named enum instead of unnamed, all references updated. Add
3188 EXPR_ANY, EXPR_NO_OPTIMIZE.
3190 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
3191 instead of defining OP_* directly.
3192 (macro IS_TERMINAL) New macro.
3193 (macro IS_NONTERMINAL) New macro.
3194 (enum OP_NO_FLAGS) New.
3196 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
3198 * error.c: (err_assert_fail) msg variable needs to be non-const.
3200 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
3202 * debug.c: (cmd_debug_evaluate) Rewrite.
3204 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
3206 Fix some CROSSTABS bit rot stupidity.
3208 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
3209 (internal_cmd_crosstabs) Initializes cells[] correctly.
3210 (float_M_suffix) Rename format_cell_entry(), change prototype,
3212 (display_crosstabulation) Fix cell formatting.
3214 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
3216 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
3217 to call lex_discard_line() to do that.
3219 * command.c: (run_command) Call lex_discard_line() after
3222 * lexer.c: (lex_entire_end) Change behavior.
3223 (lex_rest_of_line) Change behavior. Return const char *.
3224 (lex_discard_line) Don't clear getl_buf, don't emit message.
3226 * main.c: (handle_error) Emit message here.
3228 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
3229 instead of lex_entire_line().
3231 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
3233 * title.c: (get_title) Call lex_discard_line() after
3235 (cmd_file_label) Ditto.
3236 (cmd_document) Deal with const char * return value.
3238 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
3240 Removed REMARK command.
3242 * command.c: (extract_prefix) Removed.
3243 (output_line) Removed.
3244 (cmd_remark) Removed.
3246 * command.def: Remove REMARK.
3248 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
3250 Added abort() after lots of assert(0) invocations to avoid some
3251 compiler warnings. We really need a NOT_REACHED macro.
3253 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3255 * sort.c: Added missing call to temp_file_close. Changed error
3256 messages to warnings.
3258 * set.q: Improved setting of set_view{length,width} to be more tolerant
3261 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
3263 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
3264 used with incorrect syntax.
3266 * error.c, error.h et al: Overridden definition of assert for a
3269 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
3270 subcommand was given when it ought to have been.
3272 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
3274 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
3278 (tab_joint_text) Ditto.
3280 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
3282 * levene.c: Add #include.
3284 * set.q: (set_viewport) Add `int' argument to make its prototype
3285 correct for signal().
3287 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
3289 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
3292 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
3294 Changed DFM from open-at-first-access to explicit-open. Before,
3295 calling dfm_get_record() or dfm_put_record() would automatically
3296 open the file. Now, you have to call dfm_open_for_reading() or
3297 dfm_open_for_writing() explicitly. This makes it possible to
3298 check permissions, file existence, etc. earlier.
3300 Also made struct file_handle more opaque, and clean up in general.
3302 * data-list.c: (cmd_data_list) Open handle for reading.
3304 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
3306 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
3307 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
3308 (open_inline_file) Removed.
3309 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
3310 it. Deal with line_number in extension record instead of file
3312 (dfm_get_record) Rewrote.
3313 (dfm_put_record) Rewrote.
3314 (dfm_push) Assert file is open and one of ours. Deal with
3315 line_number in extension record instead of file handle.
3316 (dfm_pop) Assert file is open and one of ours. Deal with
3317 line_number in extension record instead of file handle.
3318 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
3321 * file-handle.h: (enum constants RH_RF_*) Removed.
3322 (enum constants FH_MD_*) Removed.
3323 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
3324 `recform', `lrecl', `mode' members. Public references to
3325 `recform' changed to use handle_get_mode(), references to `lrecl'
3326 changed to use handle_get_record_width(). Added `private' member.
3327 (enum file_handle_mode) New.
3329 * file-handle.q: (struct private_file_handle) New structure.
3330 (struct file_handle_list) New structure.
3331 (static var files) New.
3332 (static var file_handles) Removed.
3333 (init_file_handle) Removed.
3334 (create_file_handle) Removed.
3335 (get_handle_with_name) New function.
3336 (get_handle_for_filename) New function.
3337 (cmd_file_handle) Rewritten.
3338 (hash_file_handle) Removed.
3339 (cmp_file_handle) Removed.
3340 (fh_init_files) Rewritten.
3341 (fh_parse_file_handle) Rewritten. Allows identifiers as
3343 (fh_get_handle_by_name) Renamed handle_get_name(), all references
3345 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
3346 references updated. Rewritten.
3347 (fh_record_width) Renamed handle_get_record_width(), all
3348 references updated. Rewritten.
3349 (handle_get_mode) New function.
3351 * file-type.c: (cmd_file_type) Open handle for reading.
3353 * filename.c: [unix] (struct file_identity) New structure.
3354 [unix] (fn_get_identity) New function.
3355 [unix] (fn_free_identity) New function.
3356 [unix] (fn_compare_file_identities) New function.
3357 [!unix] (struct file_identity) New structure.
3358 [!unix] (fn_get_identity) New function.
3359 [!unix] (fn_free_identity) New function.
3360 [!unix] (fn_compare_file_identities) New function.
3362 * lexer.c: (static var put) Renamed put_token, all references
3364 (static var put_tokstr) New.
3365 (static var put_tokval) New.
3366 (lex_init) Initialize put_tokstr().
3367 (restore_token) New function.
3368 (save_token) New function.
3369 (lex_get) Use restore_token().
3370 (lex_put_back) Use save_token().
3371 (lex_put_back_id) New function.
3372 (lex_put_forward) Removed.
3373 (lex_preprocess_line) Set put_token instead of using
3375 (lex_negative_to_dash) Use save_token(), set put_token directly.
3376 (dump_token) Use stderr instead of stdout.
3378 * main.c: (main) Remove call to cmd_init().
3380 * matrix-data.c: (cmd_matrix_data) Open file for reading.
3382 * pfm-read.c: Use handle_get_filename() instead of trying to use
3383 h->fn directly, all over.
3385 * pfm-write.c: Ditto.
3387 * print.c: (internal_cmd_print) Open handle for writing.
3388 (dump_table) Use handle_get_filename().
3389 (print_trns_proc) Use handle_get_mode().
3390 (cmd_print_space) Use fh_parse_file_handle().
3391 Open handle for writing.
3392 [0] (debug_print) Removed.
3394 * sfm-read.c: Use handle_get_filename() instead of trying to use
3395 h->fn directly, all over.
3397 * sfm-write.c: Ditto.
3399 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
3403 * autorecode.c: (arc_free) Free arc->src_values.
3405 * error.c: (msg) Free buf.
3407 * val-labs.c: (do_value_labels) Always free vars.
3409 * vfm.c: (close_active_file) If sink has no make_source then call
3410 its destroy function.
3412 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
3414 Fixed cmd_parse() so that it always skips past a full command
3415 name. A few special commands for which this would be bad get
3416 special treatment. This lets us drop code for skipping past the
3417 end of a command name in most cmd_*() functions. It's not worth
3418 listing all the commands affected.
3420 * command.c: (struct command) Remove `cmd' member, replace by
3421 `name' member, all references updated. Remove `word', `next',
3422 `skip_entire_name' members.
3423 (macro DEFCMD) Deal with revised `struct command'.
3424 (macro UNIMPL) Ditto.
3425 (macro SPCCMD) New macro for commands whose last word shouldn't be
3427 (static array cmd_table[]) Make const, rename `commands', remove
3429 (macro COMMAND_CNT) New macro.
3430 (split_words) Removed.
3432 (FILE_TYPE_okay) Make parameter const.
3433 (cmd_parse) Improve error messages.
3434 (match_strings) New function.
3435 (next_word) New function.
3436 (enum command_match) New enum.
3437 (conflicting_3char_prefixes) New function.
3438 (conflicting_3char_prefix_command) New function.
3439 (cmd_match_words) New function.
3440 (count_matching_commands) New function.
3441 (get_command_name) New function.
3442 (free_words) New function.
3443 (unknown_command_error) New function.
3444 (figure_out_command) Renamed parse_command_name(), rewritten.
3446 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
3447 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
3448 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
3451 * command.h: (macro SPCCMD) New.
3453 * include.c: (cmd_include_at) Removed.
3454 (cmd_include) Allow identifier to be used as filename.
3456 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
3458 * t-test.q: (cmd_t_test) Command name is now parsed for us.
3461 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
3463 Start work on better test framework.
3465 * Makefile.am: (pspp_sources) Add debug.c.
3467 * debug.c: New file.
3469 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3470 cmd_debug_evaluate().
3472 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3474 * expr.h: (enum constant PXP_DUMP) Removed.
3476 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3478 * set.q: Implemented the SHOW command, and synced it to the existing
3481 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3482 changes as the window size is changed.
3484 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3485 environment variables if other methods are not available.
3487 glob.c: Removed a lot of global variables from glob.c and encapsulated
3490 random.c: Tidied up the way the random seed is set.
3492 str.c: Added a ds_vprintf function.
3494 error.c: Extended dump_message so that messages are always broken at
3497 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3499 * pfm-write.c: (bufwrite) Write out the correct element for string
3500 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3502 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3504 Get rid of static and global (!) vars in matrix-data.c.
3506 * matrix-data.c: (static var nr_data) Removed.
3507 (static var nr_factor_values) Removed.
3508 (static var max_cell_index) Removed.
3509 (static var split_values) Removed.
3510 (struct nr_aux_data) New structure.
3511 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3512 place of static vars, pass to create_case_source() and procedure()
3514 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3515 struct matrix_data_pgm *.
3516 (nr_read_splits) Ditto.
3517 (nr_read_factors) Ditto.
3518 (nr_output_data) Ditto.
3519 (static var wr_content) Removed.
3520 (global var wr_data) Removed.
3521 (global var wr_current) Removed.
3522 (struct wr_aux_data) New structure.
3523 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3524 place of static vars, pass to create_case_source() and procedure()
3526 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3527 instead of matrix_data_pgm *.
3528 (wr_read_splits) Ditto.
3529 (wr_output_data) Ditto.
3530 (wr_read_rowtype) Ditto.
3531 (wr_read_factors) Ditto.
3532 (wr_read_indeps) Ditto.
3534 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3536 Get rid of static vars in autorecode.c.
3538 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3539 `n_arc' to `spec_cnt'. All references updated.
3540 (static var v_src) Removed.
3541 (static var v_dest) Removed.
3542 (static var h_trns) Removed.
3543 (static var nv_src) Removed.
3544 (static var descend) Removed.
3545 (static var print) Removed.
3546 (enum direction) New enum.
3547 (struct autorecode_pgm) New structure.
3548 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3549 Move n_dest local var into struct autorecode_pgm for ease of
3550 clean-up. Use arc_free().
3551 (arc_free) New function.
3552 (recode) Modify to take struct autorecode_pgm * parameter instead
3553 of using statics. Let the caller clean up.
3554 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3555 instead of statics. Rearrange code a little.
3557 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3559 Get rid of static, global vars in recode.c. Remove debug code.
3561 * recode.c: (static var head) Removed.
3562 (global var v) Removed.
3563 (global var nv) Removed.
3564 (cmd_recode) New local variables head, v, nv. Initialize and free
3565 v. Don't call debug_print().
3566 [DEBUGGING] (dump_dest) Removed.
3567 [DEBUGGING] (debug_print) Removed.
3569 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3571 Get rid of static vars in expr-opt.c.
3573 * expr-opt.c: (static var e) Removed.
3574 (static var nop) Removed.
3575 (static var mop) Removed.
3576 (static var ndbl) Removed.
3577 (static var mdbl) Removed.
3578 (static var nstr) Removed.
3579 (static var mstr) Removed.
3580 (static var nvars) Removed.
3581 (static var mvars) Removed.
3582 (struct expr_dump_state) New structure.
3583 (dump_expression) Use new struct expr_dump_state instead of static
3584 vars and pass to functions we call.
3585 (dump_node) Use struct expr_dump_state * parameter.
3587 (emit_num_con) Ditto.
3588 (emit_str_con) Ditto.
3591 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3593 Get rid of static var in COUNT.
3595 * count.c: (static var head) Move into cmd_count().
3596 (cmd_count) [DEBUGGING] Don't call debug_print.
3597 [DEBUGGING] (debug_print) Removed.
3599 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3601 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3603 * val-labs.c: (static var v) Removed.
3604 (static var nv) Removed.
3605 [DEBUGGING] (debug_print) Removed.
3606 (verify_val_labs) Add struct variable **, int parameters.
3607 (get_label) Ditto. Improve error messages, streamline.
3608 (erase_labels) New function for erasing value labels, taking over
3609 part of verify_val_labs()'s function.
3612 (cmd_value_labels) No need to call init() or done() anymore.
3613 (cmd_add_value_labels) Ditto.
3614 (do_value_labels) Add vars, var_cnt local variables. Clean up
3615 after them internally. Call erase_labels() if we should. Don't
3618 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3620 Get rid of static vars in MATCH FILES.
3622 * get.c: (static var mtf_head) Removed.
3623 (static var mtf_tail) Removed.
3624 (static var mtf_by) Removed.
3625 (static var mtf_n_by) Removed.
3626 (static var mtf_master) Removed.
3627 (static var mtf_seq_num) Removed.
3628 (static var mtf_seq_nums) Removed.
3629 (static var mtf_sink) Removed.
3630 (static var mtf_case) Removed.
3631 (struct mtf_proc) New structure.
3632 (cmd_match_files) Use struct mtf_proc instead of static vars.
3633 (mtf_processing_finish) Ditto.
3635 (mtf_delete_file_in_place) Ditto.
3636 (mtf_read_nonactive_records) Ditto.
3637 (mtf_compare_BY_values) Ditto.
3638 (mtf_processing) Ditto.
3639 (mtf_merge_dictionary) Ditto.
3641 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3643 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3645 * dictionary.c: (dict_rename_var) Add assertion.
3646 (dict_contains_var) Check by index instead of name.
3648 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3650 Get rid of compaction_necessary, compaction_nval, compaction_case.
3651 Redo VFM interface. Replace disk_sink and memory_sink by
3652 storage_sink, disk_source and memory_source by storage_source.
3654 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3658 (struct write_case_data) Remove `begin_func', `end_func',
3659 `func_aux' members. Add `aux', `trns_case', `sink_case',
3660 `cases_written', `cases_analyzed' members.
3661 (global var compaction_necessary) Make static.
3662 (global var compaction_nval) Removed.
3663 (global var compaction_case) Removed.
3664 (static var case_count) Removed.
3665 (struct procedure_aux_data) Removed.
3666 (struct split_aux_data) Removed.
3667 (procedure) Remove begin_func, end_func parameters. Rewrite.
3668 (static var not_canceled) Removed.
3669 (process_active_file) Removed.
3670 (process_active_file_write_case) Removed.
3671 (process_active_file_output_case) Removed.
3672 (prepare_for_writing) Moved into open_active_file().
3673 (arrange_compaction) Ditto.
3675 (open_active_file) Rewrote.
3676 (write_case) New function.
3677 [DEBUGGING] (index_to_varname) Removed.
3678 (execute_transformations) New function.
3679 (exclude_this_case) Renamed filter_case(), changed interface.
3680 (clear_case) Added struct ccase * parameter to interface.
3681 (close_active_file) Added struct write_case_data * parameter,
3683 (disk_sink_create) Removed.
3684 (disk_sink_destroy) Removed.
3685 (disk_sink_make_source) Removed.
3686 (disk_sink_write) Removed.
3687 (disk_source_count) Removed.
3688 (disk_source_destroy) Removed.
3689 (disk_source_read) Removed.
3690 (global var disk_sink_class) Removed.
3691 (global var disk_source_class) Removed.
3692 (global var memory_sink_class) Removed.
3693 (global var memory_source_class) Removed.
3694 (memory_sink_create) Removed.
3695 (memory_sink_destroy) Removed.
3696 (memory_sink_make_source) Removed.
3697 (memory_sink_write) Removed.
3698 (memory_source_count) Removed.
3699 (memory_source_destroy) Removed.
3700 (memory_source_get_cases) Removed.
3701 (memory_source_read) Removed.
3702 (memory_source_set_cases) Removed.
3703 (struct disk_stream_info) Removed.
3704 (struct memory_sink_info) Removed.
3705 (struct memory_source_info) Removed.
3706 (write_active_file_to_disk) Removed.
3707 (destroy_storage_stream_info) New function.
3708 (global var null_sink_class) New var.
3709 (global var storage_sink_class) New var.
3710 (global var storage_source_class) New var.
3711 (open_storage_file) New function.
3712 (storage_sink_destroy) New function.
3713 (storage_sink_make_source) New function.
3714 (storage_sink_open) New function.
3715 (storage_sink_write) New function.
3716 (storage_source_count) New function.
3717 (storage_source_destroy) New function.
3718 (storage_source_get_cases) New function.
3719 (storage_source_on_disk) New function.
3720 (storage_source_read) New function.
3721 (storage_source_set_cases) New function.
3722 (storage_source_to_disk) New function.
3723 (storage_to_disk) New function.
3724 (struct storage_stream_info) New structure.
3725 (write_storage_file) New function.
3726 (procedure_write_case) Removed.
3727 (create_case_source) Add `struct dictionary *' parameter, all
3729 (create_case_sink) Ditto.
3730 (free_case_sink) New function.
3731 (struct split_aux_data) New structure.
3732 (procedure_with_splits) New function implementing what procedure()
3734 (SPLIT_FILE_proc_func) Removed.
3735 (procedure_with_splits_callback) New function.
3736 (equal_splits) New function.
3738 * aggregate.c: Pass around a struct instead of using statics.
3739 (static var outfile) Remove.
3740 (enum type) Give it tag `missing_treatment'.
3741 (static var missing) Remove.
3742 (static var sort) Remove.
3743 (static var agr_first) Remove.
3744 (static var agr_next) Remove.
3745 (static var case_count) Remove.
3746 (static var prev_case) Remove.
3747 (static var buf64_1xx) Remove.
3748 (static var buf_1xx) Remove.
3749 (struct agr_proc) New structure incorporating the above.
3750 (cmd_aggregate) Use new struct. Clean up error handling using
3751 agr_destroy(). Completely rewrite actual implementation of
3753 (create_sysfile) Add struct agr_proc * parameter, modify
3755 (parse_aggregate_functions) Ditto.
3756 (free_aggregate_functions) Ditto. Rename agr_destroy().
3757 (aggregate_single_case) Add struct agr_proc * parameter, modify
3759 (accumulate_aggregate_info) Ditto.
3760 (dump_aggregate_info) Ditto.
3761 (initialize_aggregate_info) Ditto.
3762 (agr_00x_trns_proc) Removed.
3763 (agr_00x_end_func) Removed.
3764 (agr_10x_trns_proc) Removed.
3765 (agr_10x_trns_free) Removed.
3766 (agr_10x_end_func) Removed.
3767 (agr_11x_read) Removed.
3768 (agr_11x_finish) Removed.
3769 [DEBUGGING] (debug_print) Removed.
3770 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3772 (agr_to_active_file) New function.
3773 (presorted_agr_to_sysfile) New function.
3774 (sort_agr_to_sysfile) New function.
3776 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3778 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3780 * descript.q: (cmd_descriptives) Ditto.
3782 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3783 to new procedure() interface.
3785 * command.c: (cmd_execute) Adapt to new procedure() interface.
3787 * dictionary.c: (dict_compact_values) Also delete scratch
3789 (dict_get_compacted_value_cnt) New function.
3790 (dict_get_compacted_idx_to_fv) New function.
3792 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3793 (cmd_flip) Adapt to new procedure() interface.
3794 (flip_sink_write) Use sink->idx_to_fv.
3796 * frequencies.q: (internal_cmd_frequencies) Use
3797 procedure_with_splits().
3799 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3800 (static var mtf_sink) New static var.
3801 (static var mtf_case) New static var.
3802 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3803 we actually implement the matching.
3804 (mtf_delete_file_in_place) Use mtf_case.
3805 (mtf_processing) Use mtf_case and mtf_sink.
3806 (cmd_export) Adapt to new procedure() interface.
3808 * levene.c: (levene) Use procedure_with_splits().
3810 * list.q: (cmd_list) Use procedure_with_splits().
3812 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3813 procedure() interface.
3814 (read_matrices_with_rowtype) Ditto.
3816 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3817 TEMPORARY. Adapt to new procedure() interface.
3819 * rename-vars.c: Warn about and cancel TEMPORARY.
3821 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3822 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3823 compaction_nval. Adapt to new procedure() interface. Use
3824 storage_source_to_disk().
3825 (do_internal_sort) Don't try to dump the cases to memory.
3826 (compare_case_lists) Pass null idx_to_fv.
3827 (struct initial_run_state) Add `idx_to_fv' member. Remove
3829 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3830 new procedure() interface. Reset irs->idx_to_fv after calling
3832 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3833 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3835 (destroy_initial_run_state) Don't dereference irs after freeing
3837 (allocate_cases) Don't calculate case_size locally.
3838 (compare_record) Add idx_to_fv parameter.
3839 (compare_record_run) Change parameter from struct sort_cases_pgm *
3840 to struct initial_run_state *. Pass irs->idx_to_fv to
3842 (compare_record_run) Third parameter now a struct
3843 initial_run_state *.
3844 (output_record) No need for out_case anymore. Pass irs, not
3845 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3847 (merge) Use case_size from struct sort_cases_pgm.
3848 (merge_once) Use case_size from struct sort_cases_pgm.
3849 Pass null pointer to compare_record() as idx_to_fv.
3850 (global var sort_sink_class) Make static.
3852 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3854 * temporary.c: Remove debugging crap.
3856 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3858 * t-test.q, levene.c: Fixed up the handling of MISSING values
3861 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3863 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3866 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3868 Change explicit variable name checks into use of
3869 dict_class_from_id().
3871 * dictionary.c: (dict_create_var) Change explicit variable name
3872 check into use of dict_class_from_id().
3874 * get.c: (trim_dictionary) Ditto.
3876 * sel-if.c: (cmd_filter) Ditto.
3878 * sysfile-info.c: (cmd_display) Ditto.
3880 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3882 * vfm.c: (arrange_compaction) Ditto.
3884 * weight.c: (cmd_weight) Ditto.
3886 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3888 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3889 transformation following the input program, if any, for some
3890 reason we special-cased f_trns. That's just wrong. It should
3891 always be set to n_trns.
3893 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3895 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3896 introduced in last check-in.
3898 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3900 * format.c: (global array translate_fmt[]) Removed.
3901 (translate_fmt) New function as replacement.
3902 (parse_format_specifier_name) Rewrite.
3904 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3907 * sfm-read.c: (parse_format_spec) Ditto.
3909 * postscript.c: (text) Fix handling of fonts with missing
3912 * sort.c: (struct external_sort) Add temp_name member.
3913 (destroy_external_sort) Free temp_dir, temp_name members.
3914 (init_external_sort) Allocate temp_name.
3915 (get_temp_file_name) Change prototype.
3916 (open_temp_file) Deal with change to get_temp_file_name().
3917 (close_temp_file) Ditto.
3918 (remove_temp_file) Ditto.
3919 (write_temp_file) Ditto.
3920 (read_temp_file) Ditto.
3921 (sort_sink_destroy) Removed.
3922 (sort_sink_class) Change destroy member to null.
3924 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3926 Eliminate temp_case.
3928 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3929 anymore. Use agr_11x_finish().
3930 (aggregate_single_case) Make first param const.
3931 (accumulate_aggregate_info) Ditto.
3932 (agr_00x_end_func) Use compaction_case, not temp_case.
3933 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3935 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3936 (cmd_data_list) Initialize case_size.
3937 (read_from_data_list_fixed) Add struct ccase * param, use instead
3939 (read_from_data_list_free) Ditto.
3940 (read_from_data_list_list) Ditto.
3941 (read_one_case) Rename data_list_trns_proc(), all references
3942 updated. Add argument in calling above functions. Use c
3943 argument instead of temp_case.
3944 (destroy_dls) Rename data_list_trns_free(), all references
3947 * expr-evl.c: (expr_evaluate) Make second parameter const.
3949 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3950 (cmd_end_file_type) Initialize `case_size'.
3951 (file_type_source_read) Add struct ccase * parameter. Use instead
3954 * flip.c: Rewritten.
3956 * get.c: (struct get_pgm) New structure to keep track of
3958 (cmd_get) Initialize case_size.
3960 (get_source) Deal with struct get_pgm.
3961 (get_source_read) Add struct ccase * parameter, use instead of
3963 (import_source_read) Ditto.
3965 * get.c: Use a null pointer instead of temp_case to represent the
3966 "current case" in a struct mtf_file's input member.
3967 (mtf_processing_finish) Pass null to mtf_processing(), not
3969 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3970 (mtf_compare_BY_values) Add extra arg, use instead of null input
3972 (mtf_processing) Use c parameter instead of temp_case. Pass
3973 compaction_case to process_active_file_output_case().
3975 * glob.c: (global variable temp_case) Removed.
3977 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3978 (cmd_input_program) Initialize case_size. Set
3979 vfm_source->value_cnt.
3980 (init_case) Add struct ccase * parameter, use instead of
3983 (input_program_source_read) Ditto.
3985 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3986 (dump_cell_content) Ditto.
3987 (nr_output_data) Ditto.
3988 (read_matrices_without_rowtype) Ditto.
3989 (matrix_data_read_with_rowtype) Ditto.
3990 (wr_read_splits) Ditto.
3991 (wr_output_data) Ditto.
3993 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3995 * sort.c: (sort_cases) Initialize scp->case_size.
3996 (struct external_sort) Remove `case_size' member.
3997 (write_initial_runs) Only call vfm_sink->class_destroy if
3999 (struct sort_source_aux) New structure.
4000 (sort_source_read_helper) New function.
4001 (sort_source_read) Use sort_source_read_helper().
4002 (read_sort_output) Change interface to be more reasonable.
4003 (read_internal_sort_output) Ditto.
4004 (read_external_sort_output) Ditto.
4006 * vars-prs.c: (dict_class_to_name) Pass return value through
4009 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
4010 (procedure) Initialize trns_case.
4011 (procedure) Pass trns_case to vfm_source->class->read().
4013 (process_active_file) Start using struct procedure_aux_data.
4014 (process_active_file_write_case) Pass trns_case to
4015 transformations, lag_case(), clear_case().
4016 (process_active_file_output_case) Add struct ccase * parameter.
4017 (create_trns_case) New function.
4018 (make_temp_case) Removed.
4019 (vector_initialization) Removed.
4020 (close_active_file) Only call make_source if non-null, otherwise
4021 set vfm_source to null pointer. Don't free temp_case.
4022 (disk_source_read) Add struct ccase * parameter, use instead of
4024 (memory_source_read) Ditto.
4025 (lag_case) Add const struct ccase * member.
4026 (procedure_write_case) Use trns_case instead of temp_case.
4027 (clear_case) Add struct ccase * member, use instead of temp_case.
4028 (exclude_this_case) Ditto.
4029 (create_case_source) Add struct dictionary * parameter, use to
4030 initialize source->value_cnt.
4032 * vfm.h: (struct case_source) Add `value_cnt' member.
4033 (struct case_source_class) Add struct ccase * parameter to `read'
4034 member function pointer.
4035 (struct case_sink_class) Make struct ccase * parameter const in
4036 `write' member function pointer.
4038 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
4040 Fix a lot of "possibly uninitialized variable" warnings. Some of
4041 them are even real bugs. A few of them make me wonder how the
4044 * aggregate.c: (parse_aggregate_functions) Initialize `function.
4046 * ascii.c: (output_lines) Add default case to switch.
4048 * crosstabs.q: Remove static variable `expected' and all
4050 (display_crosstabulation) Always calculate expected value.
4052 (output_pivot_table) Initialize `cmp'.
4053 (display_crosstabulation) New variable `last_row', which is
4056 * data-in.c: (parse_numeric) Always initialize sign. How did this
4059 * data-list.c: (repeating_data_trns_proc) Always initialize code.
4060 Always set info.ofs. (How did this work?!)
4062 * expr-opt.c: (optimize_tree) Always initialize `m'.
4063 (evaluate_tree) Always initialize `c'. (How did this work?)
4065 * frequencies.q: (frq_custom_variables) Always initialize min,
4067 (frq_custom_grouped) Always initialize `dl'.
4069 * groff-font.c: (groff_read_font) Always initialize char_set.
4071 * matrix-data.c: (nr_output_data) Initialize `split'.
4072 (wr_read_splits) Remove shadowing split_cnt declaration.
4073 (wr_output_data) Initialize `split'.
4075 * output.c: (tokener) Skip add character on syntax error.
4077 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
4079 * postscript.c: (read_ps_encodings) Use line.string instead of
4081 (write_text) Add default case to switch.
4082 (text) Always initialize multiple variables. Fix bug with
4085 * print.c: (fixed_parse_fortran) Initialize head.
4086 (alloc_line) Add default case to switch.
4088 * recode.c: (parse_dest_spec) Handle case where nothing matches.
4089 (recode_trns_proc) Move variable declaration inward. Add default
4092 * sfm-read.c: (read_header) Initialize skip_amt.
4094 * sysfile-info.c: (display_variables) Always initialize pc.
4096 * vars-prs.c: Initialized `included'.
4098 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
4100 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
4101 Just use signal() instead.
4103 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
4105 Get rid of vfm_sink_info and vfm_source_info.
4107 * aggregate.c: (agr_00x_end_func) Don't increment
4108 sfm_sink_info.ncases.
4110 * sort.c: (do_internal_sort) Get case count from
4111 vfm_source->class->count().
4112 (struct external_sort) Add `case_size' member.
4113 (do_external_sort) Initialize case_size.
4114 (struct initial_run_state) Add `case_size' member.
4115 (write_initial_runs) Initialize case_size.
4116 (sort_sink_write) Use case_size.
4117 (read_external_sort_output) Use case_size. Get case_cnt from
4120 * vfm.c: (struct write_case_data) Add underscores to existing arg
4121 names, all references updated. Renamed `aux' as `func_aux', all
4122 references updated. Added new `aux' member.
4123 (global var vfm_source_info) Removed.
4124 (global var vfm_sink_info) Removed.
4125 (struct procedure_aux_data) New.
4126 (struct split_aux_data) New.
4127 (procedure) Use `aux' fields for procedure_aux_data,
4129 (process_active_file_write_case) Pass case_count + 1 to
4130 transformation procedures, exclude_this_case().
4131 (process_active_file_output_case) Don't increment
4132 vfm_sink_info.ncases.
4133 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
4134 to send data to disk early.
4135 (make_temp_case) Don't use vfm_sink_info.case_size.
4136 (close_active_file) Don't initialize vfm_source_info.
4137 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
4138 (disk_sink_create) Initialize and/or update disk_stream_info.
4139 (disk_sink_write) Ditto.
4140 (disk_sink_destroy) Ditto.
4141 (disk_sink_make_source) Ditto.
4142 (disk_source_read) Ditto.
4143 (disk_source_destroy) Ditto.
4144 (global var disk_source_class) Add disk_source_count().
4145 (disk_source_count) New function.
4146 (struct memory_sink_info) Add `case_cnt', `case_size' members.
4147 (struct memory_source_info) Ditto.
4148 (memory_sink_create) Deal with case_cnt, case_size.
4149 (memory_sink_write) Ditto.
4150 (memory_sink_make_source) Ditto.
4151 (memory_source_read) Ditto.
4152 (memory_source_count) New function.
4153 (memory_source_class) Add memory_source_count().
4154 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
4155 proc_aux->cases_written, and pass it to transformation procedures
4156 and exclude_this_case ().
4157 (exclude_this_case) Add case_num parameter. Pass it to
4159 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
4162 * vfm.h: (struct case_source_class) Add `count' member.
4164 * vfmP.h: (struct stream_info) Removed.
4165 (global variable vfm_source_info) Removed.
4166 (global variable vfm_sink_info) Removed.
4168 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
4170 * var.h: (typedef trns_proc_func) New typedef.
4171 (trns_free_func) New typedef.
4172 (struct trns_header) Change `proc' to type trns_proc_func, `free'
4173 to type trns_free_func. This only changes the actual type of
4174 trns_proc_func, adding a `case_num' parameter. Updated all
4175 implementations to use the typedefs instead.
4177 * compute.c: (compute_num) Pass case_num to expr_evaluate().
4178 (compute_num_vec) Ditto.
4179 (compute_str) Ditto.
4180 (compute_str_vec) Ditto.
4182 * do-if.c: (do_if_trns_proc) Ditto.
4184 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
4187 * inpt-pgm.c: (input_program_source_read) Maintain case count,
4188 pass to transformation functions.
4189 (reread_trns_proc) Pass case_num arg to expr_evaluate().
4191 * loop.c: (loop_1_trns_proc) Ditto.
4192 (loop_2_trns_proc) Ditto.
4193 (loop_3_trns_proc) Ditto.
4195 * print.c: (print_space_trns_proc) Ditto.
4197 * sel-if.c: (select_if_proc) Ditto.
4199 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
4201 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
4202 destroying hash table.
4204 * glob.c: (read_active_file) Variable not referenced, removed.
4205 (cancel_input_pgm) Ditto.
4207 * levene.c: Add #include <stdlib.h> needed to call free().
4209 * aggregate.c: (parse_aggregate_functions) Make `function'
4212 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
4214 Start working to eliminate VFM dependence on static variables.
4216 * command.c: (cmd_parse) Use case_source_is_class().
4218 * data-list.c: Rewrite to eliminate use of static variables.
4220 * dfm.c: (cmd_begin_data) Use case_source_is_class().
4222 * file-handle.q: (fh_handle_name) Make parameter const.
4224 * file-type.c: Rewrite to eliminate use of static variables.
4226 * flip.c: Rewrite to eliminate use of static variables.
4228 * format.c: (get_format_var_width) New function.
4230 * get.c: Eliminate use of static variables.
4232 * inpt-pgm.c: Eliminate use of static variables.
4234 * matrix-data.c: Eliminate use of static variables.
4236 * set.q: (set_max_workspace) New variable.
4237 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
4239 * var.h: (struct case_list) Move here from vfmP.h.
4241 * vars-atr.c: (discard_variables) Handle new vfm_source type.
4243 * vfm.c: (vfm_source) Change type from struct case_stream to
4245 (vfm_sink) Change type from struct case_stream to struct
4247 (static var paging) Rename workspace_overflow, all references
4249 (procedure) Use new class structures.
4250 (process_active_file) Ditto.
4251 (process_active_file_write_case) Ditto.
4252 (prepare_for_writing) Use set_max_workspace. Use new class
4254 (close_active_file) Use new class structures. Free old sink.
4255 (global var disk_source_file) Removed.
4256 (global var disk_sink_file) Removed.
4257 (disk_stream_init) Removed.
4258 (disk_stream_read) Removed.
4259 (disk_stream_write) Removed.
4260 (disk_stream_mode) Removed.
4261 (disk_stream_destroy_source) Removed.
4262 (disk_stream_destroy_sink) Removed.
4263 (global var vfm_disk_stream) Removed.
4264 (disk_sink_create) New function.
4265 (disk_sink_write) New function.
4266 (disk_sink_destroy) New function.
4267 (disk_sink_make_source) New function.
4268 (disk_sink_class) New static var.
4269 (disk_source_read) New function.
4270 (disk_source_destroy) New function.
4271 (global var vfm_source_class) New var.
4272 (global var memory_source_cases) Removed.
4273 (global var memory_sink_cases) Removed.
4274 (global var memory_sink_max_cases) Removed.
4275 (struct memory_sink_info) New struct.
4276 (memory_stream_init) Removed.
4277 (memory_stream_read) Removed.
4278 (memory_stream_write) Removed.
4279 (memory_stream_mode) Removed.
4280 (memory_stream_destroy_source) Removed.
4281 (memory_stream_destroy_sink) Removed.
4282 (global var vfm_memory_stream) Removed.
4283 (page_to_disk) Renamed write_active_file_to_disk().
4284 (memory_sink_create) New function.
4285 (memory_sink_write) New function.
4286 (memory_sink_destroy) New function.
4287 (memory_sink_make_source) New function.
4288 (memory_sink_class) New static var.
4289 (memory_source_read) New function.
4290 (memory_source_destroy) New function.
4291 (memory_source_get_cases) New function.
4292 (memory_source_set_cases) New function.
4293 (global var vfm_source_class) New var.
4294 (procedure_write_case) Use new class structures.
4295 (create_case_source) New function.
4296 (case_source_is_complex) New function.
4297 (case_source_is_class) New function.
4298 (create_case_sink) New function.
4300 * vfm.h: (global variable reinit_sysmis) Not used, removed.
4301 (global variable reinit_blanks) Not used, removed.
4302 (global variable init_zero) Not used, removed.
4303 (global variable init_blanks) Not used, removed.
4304 (struct case_source) New struct.
4305 (struct case_source_class) New struct.
4306 (struct case_sink) New struct.
4307 (struct case_sink_class) New struct.
4308 (struct case_stream) Removed.
4310 * vfmP.h: (struct case_list) Moved to var.h.
4312 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
4314 * algorithm.c: (count_equal) New function.
4315 (count_if) New function.
4316 (unique) Add assertions.
4317 (partition) Add assertions.
4318 (is_partitioned) New function.
4319 (copy_if) Add assertions.
4320 (remove_equal) Add assertions.
4321 (lexicographical_compare) Rename lexicographical_compare_3way.
4322 (sort) Add assertions. Rephrase some code.
4323 (is_sorted) New function.
4325 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
4329 * sort.c: Completely rewrite.
4331 * sort.h: Expose interface via struct sort_cases_pgm, not via
4334 * aggregate.c: (sort) New static var.
4335 (cmd_aggregate) Use sort.
4336 (create_sysfile) Ditto.
4337 (aggregate_single_case) Ditto.
4338 (dump_aggregate_info) Ditto.
4339 (agr_00x_end_func) Ditto.
4340 (debug_print) Ditto.
4342 * var.h: (enum SRT_ASCEND) Removed.
4343 (enum SRT_DESCEND) Removed.
4344 (struct sort_cases_proc) Removed.
4345 (struct variable) Remove p.srt member.
4347 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
4349 Get rid of the old, crappy heap structure and replace it by a new,
4350 shiny, C++ STL-like heap structure.
4352 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
4354 * algorithm.c: (push_heap) New function.
4365 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
4367 Increase warning level.
4369 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
4371 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
4373 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
4375 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
4377 * dictionary.c: (dict_create_var) Fix root cause of bug worked
4378 around by previous change log entry.
4380 * compute.c: (lvalue_finalize) Remove workaround from previous
4383 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4385 * compute.c: Fixed a bug where the Format was not getting set for
4386 computed variables (thus causing a crash when SAVEing).
4388 * Added a test to stop this bug ever coming back
4390 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
4392 Got rid of approx.h. In general, replaced all references to
4393 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
4396 * Makefile.am: (pspp_SOURCES) Removed approx.h.
4398 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
4399 test for mag < EPSILON.
4401 * misc.h: Add definition of EPSILON.
4403 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
4405 * vfm.c: (procedure) Add check to prevent recursive call.
4407 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
4409 * Moved the declarations relating to values to their own header file
4412 * Added levene.c and levene.h
4414 * vars-atr.c: Changed the signature of compare_values to
4415 take const * arguments.
4417 * t-test.q: Changed the structure of struct t_test_proc
4418 variables now contain their own group statistics information.
4419 Eventually, t_test_proc might get renamed, because it'd be
4420 applicable to other commands too.
4422 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
4424 * data-out.c: Clean up. Changed interface of convert_*() to take
4425 either a `double' or a `const char *' instead of a `const union
4426 value *'. Update all implementations of those interfaces.
4427 (data_out) Use switch statements instead of a table.
4428 (convert_AHEX) Rewrite.
4430 * format.h: Update comment.
4432 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
4434 * q2c.c: (dump_header) Add an Emacs header line to output files
4435 that makes generated .c files read-only by default, to make it
4436 difficult to accidentally change generated files.
4438 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
4440 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
4441 not bogus a->v.c <=> b->v.c pointer compare.
4442 (compare_freq_alpha_a) Ditto.
4443 (compare_freq_numeric_d) Ditto.
4444 (compare_freq_alpha_d) Ditto.
4446 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
4448 Changed data_out() to store string data directly into a `union
4449 value''s s member, not indirectly into c.
4451 * crosstabs.q: (output_pivot_table) Use format_short() instead of
4453 (table_value_missing) Ditto.
4454 (float_M_suffix) Ditto.
4455 (format_short) New function.
4457 * data-in.h: (data_in_finite_line) Remove inline definition.
4459 * data-list.c: (destroy_dls_var_spec) New function.
4460 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
4461 (data_list_source_destroy_source) Avoid cast.
4462 (struct repeating_data_trns) New field `id_value'. Update
4464 (cmd_repeating_data) Initialize id_value. Use new
4465 repeating_data_trns_free() for freeing REPEATING DATA
4467 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4468 (repeating_data_trns_free) New function.
4470 * data-out.c: (data_out) Change return type to `void' by replacing
4471 error returns by writing a message into the output buffer.
4472 (convert_A) Read from v->s instead of v->c.
4473 (convert_AHEX) Ditto.
4475 * expr-evl.c: Update comment.
4476 (expr_evaluate) Add assertion in OP_STRING case.
4478 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4480 * list.q: (list_cases) Update for new data_out() semantics.
4482 * print.c: (print_trns_proc) Ditto.
4484 * tab.c: (tab_value) Ditto.
4485 (tab_float) Avoid stupid cast.
4487 * var.h: Update comments.
4488 (macro MAX_STRING) New macro.
4489 (macro MAX_ELEMS_PER_VALUE) New macro.
4491 * vars-atr.c: (compare_values) New function.
4493 * vfm.c: (dump_splits) Update for new data_out() semantics.
4495 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4497 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4499 (struct crosstab) Rename v[] to vars[]. All references updated.
4500 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4501 same time, which caused the hash value to depend only on a single
4502 value, not all of the variables' values.
4504 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4506 Clean up struct dictionary's value_cnt usage.
4508 * dictionary.c: Add a function comment to each function.
4509 (struct dictionary) Rename value_cnt to next_value_idx, which more
4510 accurately reflects its meaning. All references updated.
4511 (dict_rename_vars) Add assertion.
4512 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4514 (dict_get_case_size) New function.
4516 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4518 * get.c: (mtf_read_nonactive_records) Ditto.
4520 * sort.c: (allocate_cases) Ditto.
4521 (write_initial_runs) Ditto.
4525 * vfm.c: (prepare_for_writing) Ditto.
4529 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4531 Make vfm.c slightly less grotesque.
4533 * vfm.c: (filter_var) Removed.
4534 (filter_index) Removed.
4535 (FILTERED macro) Removed.
4536 (exclude_this_case) New function.
4537 (process_active_file_write_case) Use exclude_this_case() instead
4538 of FILTERED and inline tests.
4539 (procedure_write_case) Ditto.
4540 (setup_filter) Removed.
4541 (open_active_file) Don't call setup_filter().
4542 (close_active_file) Call dict_get_filter() instead of checking
4545 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4547 * var.h: (struct variable) Update comments.
4549 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4551 New functions dict_create_var_assert(), dict_lookup_var_assert().
4552 Converted several dict_*_var()/assert pairs into a single
4553 dict_*_var_assert().
4555 * dictionary.c: (dict_create_var_assert) New function.
4556 (dict_lookup_var_assert) New function.
4558 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4560 Got rid of "struct long_vec", envector(), devector(), etc. Added
4561 two members `init', `reinit' to struct variable as a substitute.
4563 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4569 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4572 * autorecode.c: (cmd_autorecode) destvars don't need init.
4574 * compute.c: (lvalue_finalize) Set reinit.
4576 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4577 (dump_fmt_list) Ditto.
4580 * descript.q: (run_z_pass) Don't need init for z-scores.
4582 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4584 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4586 * glob.c: (init_glob) Remove vec_init() calls.
4588 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4590 * loop.c: (internal_cmd_loop) Don't need to call envector().
4592 * numeric.c: (cmd_numeric) Ditto.
4594 (cmd_leave) Ditto. Set `init', `reinit' members.
4596 * recode.c: (cmd_recode) Don't need to call envector().
4598 * repeat.c: (internal_cmd_do_repeat) Ditto.
4600 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4601 (force_create_variable) Removed prototype.
4602 (force_dup_variable) Ditto.
4604 * vector.c: (cmd_vector) Don't need to call envector().
4606 * vfm.c: (reinit_sysmis) Removed.
4607 (reinit_blanks) Removed.
4608 (init_zero) Removed.
4609 (init_blanks) Removed.
4610 (process_active_file_write_case) No need to deal with vectors.
4611 Call clear_temp_case().
4612 (vector_initialization) Rewrite to use `init', `reinit'.
4613 (close_active_file) No need to call vec_clear().
4614 (procedure_write_case) Call clear_temp_case().
4615 (clear_temp_case) New function.
4617 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4619 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4622 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4624 Add auxiliary argument to procedure() interface. Associated small
4625 clean-ups of vfm interface.
4627 * Updated every caller of procedure() and process_active_file() to
4628 reflect modified interface. Simple, ordinary changes not listed
4631 * Updated every function that implements struct case_stream's
4632 `read' function to take a write_case_func and a write_case_data.
4633 Also updated every caller of write_case() to instead call them
4634 through these arguments. In some cases this meant that the extra
4635 args had to be threaded through a couple of extra levels. This
4636 wasn't difficult or interesting so the details won't be given.
4638 * data-list.c: (struct repeating_data_trns) Add members
4639 `write_case', `wc_data' as kluge.
4640 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4642 (repeating_data_set_write_case) New function.
4644 * data-list.h: New file to declare repeating_data_trns_proc() and
4645 repeating_data_set_write_case().
4647 * inpt-pgm.c: (input_program_source_read) Call
4648 repeating_data_set_write_case() for all the REPEATING DATA
4649 transformations, so that they know where to send their cases.
4650 It's a big kluge. Also kluge in END CASE.
4651 (end_case_trns_proc) Never called anymore, but we still need it,
4654 * sort.c: (read_sort_output) Update to match struct case_stream
4657 * vfm.c: (struct write_case_data) New structure.
4658 (proc_func) Removed.
4659 (virt_proc_func) Removed.
4660 (begin_func) Removed.
4661 (virt_begin_func) Removed.
4663 (write_case) Removed.
4664 (procedure) Added an auxiliary parameter to each function pointer
4665 argument's prototype. Added an auxiliary data parameter.
4667 (process_active_file) Ditto.
4668 (process_active_file_write_case) Pass aux data along.
4669 (close_active_file) Ditto.
4670 (procedure_write_case) Ditto.
4671 (SPLIT_FILE_procfunc) Ditto.
4673 * vfm.h: (typedef write_case_data) New.
4674 (typedef write_case_func) New.
4675 (struct case_stream) Add parameters to `read' member prototype.
4677 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4679 * t-test.q: Added calculations for independent samples. (But no Levene
4682 * Makefile.am: Moved q_sources_c into own variable
4684 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4686 Miscellaneous cleanups.
4688 * Change unused to UNUSED in many source files to reflect modified
4689 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4690 __CYGWIN32__, __unix__, and unix not to assume that they're
4691 defined to a nonzero value. Change use of __attribute__ to use
4692 NO_RETURN or PRINTF_FORMAT instead.
4694 * alloc.h: Move definitions for local_alloc(), local_free() here
4695 from ../pref.h.orig and simplify.
4697 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4698 use a pool allocator unconditionally.
4699 (CHECK_STRING_SPACE) Removed.
4700 (ALLOC_STRING_SPACE) Removed.
4701 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4704 * expr-opt.c: (dump_expression) Allocate string pool.
4706 * expr-prs.c: (expr_free) Free string pool.
4708 * pool.c: (pool_destroy) This pool must be removed from its
4709 parent's list of gizmos, not from its own. Use free_all_gizmos().
4710 (pool_clear) New function.
4711 (free_all_gizmos) New function.
4712 (pool_alloc) Use space in empty block after this one if any.
4713 (pool_release) Only empty out blocks, don't actually free() them.
4715 * print.c: Get rid of PAGED_STACK special case by always
4716 dynamically allocating line buffers.
4717 (struct print_trns) Always include the `line' member.
4718 (internal_cmd_print) Always initialize the `line' member.
4719 (alloc_line) Always allocate memory for `line'.
4720 (print_trns_proc) Always initialize buf from `line' member.
4721 (print_trns_free) Always free `line' memory.
4723 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4726 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4728 * flip.c: Fixed crash from FLIP when a numeric variable is
4729 specified on NEWNAMES and a large value is used, and a couple of
4730 other minor bugs besides.
4731 (struct varname) Make name a 9-character fixed-size array
4732 instead of a 1-character variable size array.
4733 (make_new_var) Allow digits in variable names.
4734 (flip_stream_write) Limit numeric values to 8 characters and
4735 format system missing and very large and small values more
4738 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4740 * command.c: Fixed test on command return status for the correct
4741 value, which had been causing a crash under certain invalid input.
4743 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4745 * t-test.q: Added calculations for the one sample variant of the T-TEST
4747 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4749 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4750 in joined cells to be rendered outside box boundaries.
4752 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4754 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4755 SET seed=xx has been called.
4757 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4759 * random.c (rng_get_double): Fix always-returning-zero bug in my
4760 preferred way, and at the same time make sure rounding doesn't
4763 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4765 * html.c: (change_attributes) Dead code, removed.
4766 (escape_string) Eliminate code to call change_attributes() that
4767 never actually called it.
4768 (output_tab_table) Get rid of dependence on tab_hit
4769 and struct tab_joined_cell's hit member, which are abominations.
4771 * tab.c: (tab_output_text) Don't call
4772 d->class->text_set_font_by_name if it's a null pointer.
4773 (macro UNROLL_LOOP) Eliminate.
4774 (macro UNROLL_3_LOOPS) Eliminate.
4775 (tabi_render) Rewrite not to use the above macros.
4777 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4779 Start working on a new output driver system, one that doesn't suck
4780 so much, by adding a "device-independent" output driver. The idea
4781 is to write out only a single output stream, then use separate
4782 processes to translate them into whatever formats we want. This
4783 is similar to how "groff" works with its various output drivers
4784 (grops, grotty, grodvi, ...).
4786 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4788 * list.q: (write_all_headers) Stub out devind class.
4790 (determine_layout) Ditto.
4793 * output.c: (outp_init) Add devind class.
4795 * devind.c: New file.
4797 * devind.h: New file.
4799 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4801 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4802 to use the proper string length.
4804 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4806 * Fixed bug where FREQ would crash on alpha values
4808 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4810 * Removed bletcherous alloca() workarounds for AIX from top of
4811 many files. AIX can use the alternative alloca() implementation
4814 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4816 * ascii.c: (ascii_option) Fix implementation of headers option.
4818 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4820 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4821 multiple blank lines into one.
4822 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4823 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4824 (static var option_tab) Add squeeze entry.
4825 (ascii_option) Set squeeze_blank_lines.
4826 (output_lines) Implement squeezing blank lines.
4828 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4830 * Removed redundant code from output.h
4832 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4834 Dictionary classes: each variable is "ordinary", "system", or
4837 * var.h: (enum dict_class) New enum.
4839 * vars-prs.c: (dict_class_from_id) New function.
4840 (dict_class_to_name) New function.
4842 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4844 * var.h: (struct freq_tab_set) Removed (not used).
4846 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4848 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4850 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4852 * stats.c: (hypercube) Rename pow4(). All references updated.
4854 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4856 * rename-vars.c: (cmd_rename_variables) Rewritten.
4857 (compare_name) Removed.
4859 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4861 var_set feature, and code taking advantage of it.
4863 * crosstabs.q: (static var var_dict) Removed.
4864 (static var variables) New variable.
4865 (static var variables_cnt) New variable.
4866 (cmd_crosstabs) Free variables instead of var_dict.
4867 (internal_cmd_crosstabs) Initialize and use variables,
4868 variables_cnt instead of var_dict.
4869 (free_var_dict) Removed.
4870 (crs_custom_tables) Use var_set instead of a copied dictionary.
4871 (crs_custom_variables) Set up variables, variables_cnt instead of
4873 [DEBUGGING] (debug_print) Ditto.
4875 * means.q: (mns_custom_tables) Use var_set instead of a copied
4878 * vars-prs.c: (parse_vs_variable) New function.
4879 (parse_dict_variable) Rewritten.
4880 (parse_variable) Rewritten.
4881 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4882 (parse_variables) New function in terms of parse_var_set_vars().
4883 Now requires its first argument to be non-null. All references
4884 that passed a null pointer updated to pass default_dict instead.
4885 (macro id_dict) Removed.
4886 (parse_DATA_LIST_vars) Add assertions.
4887 (parse_mixed_vars) Ditto.
4888 (struct var_set) New structure.
4889 (var_set_get_cnt) New function.
4890 (var_set_get_var) New function.
4891 (var_set_lookup_var) New function.
4892 (var_set_destroy) New function.
4893 (dict_var_set_get_cnt) New function.
4894 (dict_var_set_get_var) New function.
4895 (dict_var_set_lookup_var) New function.
4896 (dict_var_set_destroy) New function.
4897 (var_set_create_from_dict) New function.
4898 (struct array_var_set) New structure.
4899 (array_var_set_get_cnt) New function.
4900 (array_var_set_get_var) New function.
4901 (array_var_set_lookup_var) New function.
4902 (array_var_set_destroy) New function.
4903 (var_set_create_from_array) New function.
4905 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4906 instead of parse_variables(NULL, ...) in output code.
4908 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4910 Change inp_init from a 2-bit vector to an ordinary array.
4911 Initialize it all in cmd_end_input_program() instead of in
4914 * inpt-pgm.c: (enum value_init_type) New enum.
4915 (global var inp_init) Change to `enum value_init_type *', make
4917 (inp_init_size) Removed.
4918 (inp_nval) Change to `size_t', make static.
4919 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4920 (cmd_end_input_program) Initialize inp_init, inp_nval.
4921 (init_case) Rewrite.
4922 (clear_case) Rewrite.
4924 * inpt-pgm.h: Removed.
4926 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4928 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4929 Colin Plumb hash. It is simpler and should better resist
4931 (hsh_hash_string) Ditto.
4933 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4935 * get.c: (export_write_case_func) Remove debug printing code.
4937 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4939 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4941 (save_write_case_func) Use &trns->h instead of cast.
4942 (cmd_export) Use &t->h instead of cast.
4944 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4946 Moved vectors into the dictionary.
4948 * var.h: (struct vector) Moved here from vector.h. `index' member
4949 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4952 * vector.h: Removed.
4954 * vector.c: (global var vec) Removed.
4955 (global var nvec) Removed.
4956 (cmd_vector) Rewritten.
4957 (find_vector) Removed.
4959 * dictionary.c: (dict_create_vector) New function.
4960 (dict_get_vector) New function, replaces reading global vec[]
4962 (dict_get_vector_cnt) New function, replaces reading global nvec
4964 (dict_lookup_vector) New function, replaces find_vector().
4965 (dict_clear_vectors) New function.
4967 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4969 Start to move away from `struct variable' p `union' member to void
4972 * var.h: (struct variable) Add `aux' member.
4974 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4976 Get rid of struct variable `foo' member.
4978 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4980 (frq_custom_variables) Ditto.
4981 (frq_custom_grouped) Ditto.
4983 * get.c: (struct save_trns) Change `var' member from `int *' to
4984 `struct variable **'.
4985 (cmd_save_internal) Use aux instead of foo.
4986 (save_trns_proc) Use revised `var' member.
4987 (static var mtf_seq_no) Renamed mtf_seq_num.
4988 (static var mtf_seq_nums) New static var.
4989 (cmd_match_files) Initialize mtf_seq_nums.
4990 (mtf_free) Free mtf_seq_nums.
4991 (mtf_processing) Use mtf_seq_nums instead of foo.
4992 (mtf_merge_dictionary) No need to initialize mv->foo.
4993 (cmd_export) Use aux instead of foo. Use revised `var' member.
4994 (mns_custom_tables) Don't use foo to check for duplicates, that's
4995 what PV_NO_DUPLICATE is for.
4997 * var.h: (struct variable) Remove `foo' member.
4998 (struct frequencies_proc) New member.
5000 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
5002 Clean up COMPUTE and IF.
5004 * compute.c: More or less rewrite the darn thing.
5005 (struct compute_trns) Rename and reorder and add and delete
5007 (cmd_compute) Rewrite.
5008 (compute_num) Make conditional on test expression. Now used for
5009 both COMPUTE and IF.
5010 (compute_num_vec) Ditto.
5011 (compute_str) Ditto.
5012 (compute_str_vec) Ditto.
5015 (if_num_vec) Removed.
5017 (if_str_vec) Removed.
5018 (parse_target_expression) Renamed parse_rvalue_expression(),
5020 (new_trns) Renamed compute_trns_create(), rewritten.
5021 (delete_trns) Removed.
5022 (free_trns) Renamed compute_trns_free(), rewritten.
5023 (struct lvalue) New structure.
5024 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
5025 (lvalue_get_type) New function.
5026 (lvalue_is_vector) New function.
5027 (lvalue_finalize) New function.
5028 (lvalue_destroy) New function.
5030 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
5032 * command.def: Disallow MODIFY VARS in input mode, so that
5033 variables can't get dropped and confuse cmd_end_input_program()'s
5034 attempt to fill inp_init[].
5036 * modify-vars.c: (static var forward_positional_ordering) New
5038 (struct var_modification) Entirely changed.
5039 (rearrange_dict) Interface changed, rewritten.
5040 (cmd_modify_vars) Deal with modified struct var_modification, much
5042 (struct var_renaming) New structure.
5043 (compare_var_renaming_by_new_name) New function.
5044 (validate_var_modification) New function.
5046 * var.h: (struct modify_vars_proc) Removed.
5047 (struct variable) Removed member p.mfv.
5049 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
5051 Make EVALUATE a valid command whether we're debugging or not, so
5052 that `make check' can succeed regardless of whether debugging is
5055 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
5057 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
5059 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
5061 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
5062 statement by a simple if test.
5064 * dfm.c: (dfm_get_record) Add assertion.
5066 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
5068 For each file x.c, move #include "x.h" to the very top of the
5069 include list, to catch x.h failing to include the proper headers.
5071 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
5073 * algorithm.c: (find) New function.
5074 (remove_equal) New function.
5075 (set_difference) New function.
5076 (adjacent_find_equal) New function.
5077 [TEST_UNIQUE] Removed test case.
5078 (copy_if) Find end test.
5080 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
5082 * dictionary.c: (dict_get_case_weight) New convenience function.
5084 * aggregate.c: (accumulate_aggregate_info) Use
5085 dict_get_case_weight().
5087 * frequencies.q: (calc_general) Ditto.
5088 (calc_integer) Ditto.
5091 * t-test.q: (groups_calc) Ditto.
5094 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
5096 * glob.c: (global var default_dict) Change from `struct
5097 dictionary' to `struct dictionary *'. All references changed.
5098 (init_glob) Initialize default_dict with dict_create().
5100 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
5102 struct dictionary now made opaque. All related functions:
5104 * get.c: (rename_variables) Removed.
5105 (dict_delete_run) Removed.
5107 * temporary.c: (copy_variable) Removed.
5108 (new_dictionary) Removed.
5109 (save_dictionary) Removed.
5110 (restore_dictionary) Removed.
5111 (free_dictionary) Removed.
5113 * vars-atr.c: (clear_default_dict) Removed.
5114 (find_variable) Removed.
5115 (find_dict_variable) Removed.
5116 (create_variable) Removed.
5117 (delete_variable) Removed.
5118 (common_init_stuff) Removed.
5119 (init_variable) Removed. Updating of inp_init moved into
5120 cmd_end_input_program().
5121 (replace_variable) Removed.
5122 (rename_variable) Removed.
5123 (clear_variable) Removed.
5124 (dup_variable) Removed.
5126 * vars-prs.c: (is_varname) Removed.
5127 (is_dict_varname) Removed.
5128 (fill_all_vars) Removed.
5130 * vector.c: (find_vector) Removed.
5132 * weight.c: (stop_weighting) Removed.
5134 * dictionary.c: New file.
5135 (dict_create) New, replaces new_dictionary().
5136 (dict_clone) New, replaces save_dictionary() and
5137 restore_dictionary().
5138 (dict_clear) New, replaces clear_default_dict().
5139 (dict_destroy) New, replaces free_dictionary().
5140 (dict_get_var_cnt) New function, replaces references to
5142 (dict_get_var) New function, replaces references to dict->var[i].
5143 (dict_get_vars) New function, replaces fill_all_vars().
5144 (dict_create_var) New, replaces create_variable(). Interface
5145 drops `type' parameter, using a zero `width' to designate numeric.
5146 (dict_clone_var) New, replaces dup_variable().
5147 (dict_rename_var) New, replaces rename_variable().
5148 (dict_lookup_var) New, replaces find_variable(),
5149 find_dict_variable(), is_varname().
5150 (dict_contains_var) New function.
5151 (compare_variable_dblptrs) New function.
5152 (dict_delete_var) New function, replaces clear_variable().
5153 (dict_delete_vars) New function, replaces dict_delete_run().
5154 (dict_reorder_vars) New function.
5155 (dict_rename_vars) New function, replaces rename_variables().
5156 (dict_get_weight) New function, replaces reading dict->weight_var.
5157 (dict_set_weight) New function, replaces writing dict->weight_var
5158 or calling stop_weight(dict).
5159 (dict_get_filter) New function, replaces reading dict->filter_var.
5160 (dict_set_filter) New function, replaces writing dict->filter_var.
5161 (dict_get_case_limit) New function, replaces reading dict->N.
5162 (dict_set_case_limit) New function, replaces writing dict->N.
5163 (dict_get_value_cnt) New function, replaces reading dict->nval.
5164 (dict_compact_values) New function, replaces a loop that was
5165 replicated in several places.
5166 (dict_get_split_vars) New function, replaces reading dict->splits.
5167 (dict_get_split_cnt) New function, replaces reading
5169 (dict_set_split_vars) New function, replaces writing dict->splits.
5170 (dict_get_label) New function, replaces reading dict->label.
5171 (dict_set_label) New function, replaces writing dict->label.
5172 (dict_get_documents) New function, replaces reading
5174 (dict_set_documents) New function, replaces writing
5177 All references to above functions updated.
5179 * aggregate.c: (cmd_aggregate) Copy file label and documents from
5180 old dictionary to new by hand, because dict_create() can't do it
5181 itself. Use dict_set_documents(), dict_set_split_vars().
5183 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
5184 calling dict_destroy().
5186 * data-list.c: (dls_var_spec) Remove `type' member, replace by
5188 (fixed_parse_compatible) Some slightly nontrivial changes for
5190 (dump_fmt_list) Ditto.
5193 * file-type.c: (create_col_var) Ditto.
5195 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
5196 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
5197 (rename_variables) Use dict_rename_vars().
5198 (mtf_merge_dictionary) Use dict_get_documents(),
5199 dict_set_documents(), dict_compact_values().
5201 * pfm-read.c: (read_variables) Deal with changes to weighting.
5203 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
5204 is_varname() in output code.
5206 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
5207 other dictionary functions.
5209 * title.c: (add_document_line) Use dict_get_documents(),
5210 dict_set_documents().
5212 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
5213 reset default_handle by hand. dict_clear() will clear vectors so
5214 there's no need for that by hand.
5216 * vfm.c: (close_active_file) Move call to finish_compaction()
5217 earlier, so that we can do the compaction as a single step using
5218 dict_compact_values(). Use dict_clear_vectors().
5219 (finish_compaction) Use dict_delete_var(), dict_compact_values().
5221 Some functions don't have replacements:
5223 * vars-atr.c: (force_create_variable) Removed. All references
5224 updated to dict_create_var() followed by an assertion.
5225 (force_dup_variable) Removed. All references updated to
5226 dict_clone_var() followed by an assertion.
5228 * weight.c: (update_weighting) Removed. No longer necessary, so
5229 all references removed.
5231 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
5235 * aggregate.c: Eliminate separation of weighted and unweighted
5236 case. It made the code too obscure and I doubt it was actually
5237 faster. Instead, all code uses the "weighted" code, because
5238 that's a generalization of the "unweighted" code.
5241 (parse_aggregate_functions) No need to set FWEIGHT.
5242 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
5243 (dump_aggregate_info) Ditto.
5244 (initialize_aggregate_info) No need for special plain_function
5245 that gets rid of FWEIGHT option.
5247 * aggregate.c: Get rid of approximations.
5248 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
5250 (aggregate_single_case) Don't use approx_ne().
5252 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
5254 * ascii.c (ascii_line_width): Dead code, removed.
5256 * postscript.c (ps_line_width): Ditto.
5258 * q2c.c (xrealloc): Ditto.
5260 * count.c (internal_cmd_count): Ditto.
5262 * means.q (validate_dependent_endpoint): Ditto.
5264 * set.q: (cmd_gset) Ditto.
5266 * weight.c: [0] (weight_trns_proc) Ditto.
5268 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
5270 Make the code -Wmissing-prototypes clean.
5272 * Makefile.am (version.c): Add #include "version.h".
5274 * ascii.c: (ascii_open_global) Make static.
5275 (ascii_close_page) Ditto.
5276 (ascii_font_sizes) Ditto.
5277 (ascii_postopen_driver) Ditto.
5278 (ascii_close_driver) Ditto.
5279 (ascii_option) Ditto.
5280 (ascii_open_page) Ditto.
5281 (ascii_line_horz) Ditto.
5282 (ascii_line_vert) Ditto.
5283 (ascii_line_intersection) Ditto.
5285 (ascii_polyline_begin) Ditto.
5286 (ascii_polyline_point) Ditto.
5287 (ascii_polyline_end) Ditto.
5288 (ascii_text_set_font_by_name) Ditto.
5289 (ascii_text_set_font_by_position) Ditto.
5290 (ascii_text_set_font_by_family) Ditto.
5291 (ascii_text_get_font_name) Ditto.
5292 (ascii_text_get_font_family) Ditto.
5293 (ascii_text_set_size) Ditto.
5294 (ascii_text_get_size) Ditto.
5295 (ascii_text_metrics) Ditto.
5296 (ascii_text_draw) Ditto.
5297 (ascii_close_page) Ditto.
5299 * cmdline.h: New header for parse_command_line(). Used where
5302 * command.c: Move prototypes for cmd_*() functions to command.h.
5304 * command.h: Prototypes for cmd_*() functions moved here from
5307 * crosstabs.q: (gamma_int) Ditto.
5309 * file-handle.h: Add fh_init_files() prototype.
5311 * getline.c: (welcome) Ditto.
5313 * glob.h: New header for init_glob(). Used where appropriate.
5315 * hash.c: (comparison_helper) Ditto.
5317 * html.c: (html_open_global) Ditto.
5318 (html_close_global) Ditto.
5319 (html_preopen_driver) Ditto.
5320 (html_postopen_driver) Ditto.
5321 (html_close_driver) Ditto.
5322 (html_option) Ditto.
5323 (html_open_page) Ditto.
5324 (html_close_page) Ditto.
5325 (html_submit) Ditto.
5327 * inpt-pgm.c: (input_program_source_read) Ditto.
5329 * output.c: (find_defn_value) Ditto.
5330 (destroy_list) Ditto.
5332 * pfm-read.c: (read_int) Ditto.
5334 * postscript.c: (ps_open_global) Ditto.
5335 (ps_close_global) Ditto.
5336 (ps_font_sizes) Ditto.
5337 (ps_preopen_driver) Ditto.
5338 (ps_postopen_driver) Ditto.
5339 (ps_close_driver) Ditto.
5341 (ps_open_page) Ditto.
5342 (ps_close_page) Ditto.
5343 (ps_line_horz) Ditto.
5344 (ps_line_vert) Ditto.
5345 (ps_line_intersection) Ditto.
5347 (ps_polyline_begin) Ditto.
5348 (ps_polyline_point) Ditto.
5349 (ps_polyline_end) Ditto.
5350 (ps_text_set_font_by_name) Ditto.
5351 (ps_text_set_font_by_position) Ditto.
5352 (ps_text_set_font_family) Ditto.
5353 (ps_text_get_font_name) Ditto.
5354 (ps_text_get_font_family) Ditto.
5355 (ps_text_set_size) Ditto.
5356 (ps_text_get_size) Ditto.
5357 (ps_text_metrics) Ditto.
5358 (ps_text_draw) Ditto.
5360 * q2c.c: (finish_up) Ditto.
5369 (find_symbol) Ditto.
5372 (force_string) Ditto.
5374 (match_token) Ditto.
5377 (parse_setting) Ditto.
5378 (parse_specifier) Ditto.
5379 (parse_specifiers) Ditto.
5380 (parse_subcommand) Ditto.
5381 (dump_specifier_vars) Ditto.
5383 (make_identifier) Ditto.
5384 (dump_declarations) Ditto.
5385 (dump_specifier_init) Ditto.
5386 (dump_vars_init) Ditto.
5388 (dump_specifier_parse) Ditto.
5389 (dump_subcommand) Ditto.
5390 (dump_parser) Ditto.
5391 (dump_header) Ditto.
5393 (recognize_directive) Ditto.
5395 * recode.c: (string_to_long) Ditto.
5397 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
5399 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
5402 * sort.c: (sort_stream_read) Ditto.
5403 (sort_stream_mode) Ditto.
5405 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
5407 * algorithm.c (binary_search): Fix comparison.
5409 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
5411 * algorithm.c: (binary_search) Fix assertion.
5413 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
5415 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
5417 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
5419 * sort.c: (compare_case_lists) Rewrite.
5421 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
5423 * quicksort.c: Removed (not used).
5425 * quicksort.h: Removed (not used).
5427 * sort.c: Removed blp_quicksort() prototype.
5429 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
5431 * postscript.c: (int_2_compare) Rewrite.
5432 (compare_line) Rewrite.
5434 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
5436 * matrix-data.c (compare_factors) Use lexicographical_compare()
5438 (compare_doubles) New function.
5440 * algorithm.c: (lexicographical_compare) New algorithm.
5442 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
5444 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
5446 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
5448 * expr-prs.c: (cmp_func) Removed.
5449 (parse_function) Use binary_search() algorithm.
5450 (compare_functions) New function.
5451 (init_func_tab) Use sort() algorithm.
5453 * algorithm.c: (binary_search) New algorithm.
5455 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
5457 * descript.q: (display) Use sort() algorithm instead of qsort().
5458 (compare_func) Removed.
5459 (descriptives_compare_variables) New function.
5461 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
5463 Get rid of AVL trees. Hashes are more appropriate for everything
5466 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5472 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5474 Much code can be clarified by using C++ STL-like algorithms. Not
5475 all uses of these algorithms are listed below, only the ones where
5476 the change to an algorithm was the only change of interest.
5478 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5480 * algorithm.c: New file.
5482 * algorithm.h: New file.
5484 * modify-vars.c: (static var forward) Removed.
5485 (static var positional) Removed.
5486 (compare_variables) Removed.
5487 (struct ordering) New.
5488 (cmd_modify_vars) Use sort() algorithm.
5489 (compare_variables_given_ordering) New function.
5490 (rearrange_dict) Use sort() algorithm.
5492 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5493 (cmp_var_by_name) Removed.
5495 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5497 Make file handles use a hash table.
5499 * file-handle.q: (files) Change to hash table, make static.
5500 (cmd_file_handle) Use hash table functions.
5501 (fh_get_handle_by_filename) Ditto.
5502 (fh_get_handle_by_name) Ditto.
5503 (hash_file_handle) New function.
5504 (cmp_file_handle) Rewrite.
5505 (fh_init_files) Use hash table functions.
5507 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5509 Clean up FREQUENCIES.
5511 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5513 * frequencies.q: Remove a lot of old #if'd out code at the end.
5514 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5515 or calc_weight(). Initialize percentile_values.
5516 (calc) New function based on calc_weight() from frequencies.g.
5517 (precalc) Use hash functions.
5518 (static var comparison_func) Removed.
5519 (static var comparison_param) Removed.
5520 (comparison_helper) Removed.
5521 (get_freq_comparator) New function.
5522 (not_missing) New function.
5524 (postprocess_freq_tab) Use hash table functions, algorithms,
5525 get_freq_comparator(). Rewrite.
5526 (cleanup_freq_tab) Rephrase.
5527 (add_percentile) Clean up spacing.
5528 (hash_value_numeric) New function.
5529 (hash_value_alpha) New function.
5530 (compare_value_numeric_a) Rewrite.
5531 (compare_value_alpha_a) Rewrite.
5532 (compare_value_numeric_d) Rewrite.
5533 (compare_value_alpha_d) Rewrite.
5534 (compare_freq_numeric_a) Rewrite.
5535 (compare_freq_alpha_a) Rewrite.
5536 (compare_freq_numeric_d) Rewrite.
5537 (compare_freq_alpha_d) Rewrite.
5538 (calc_stats) Clean up mode, percentiles, max.
5539 (dump_statistics) Clean up spacing.
5541 * frequencies.g: Removed.
5543 * var.h: (struct freq_tab) Change `data' to hash table.
5545 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5547 * file-handle.h: Remove declaration of global variable `files',
5548 which wasn't used anywhere.
5550 * postscript.c: (add_encoding) Remove superfluous cast.
5553 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5556 * temporary.c: [0] (display_tree) Removed.
5558 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5560 Implement a new random number generator based on the alleged RC4
5563 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5566 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5567 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5569 (static var V[]) Removed.
5570 (static var Y) Removed.
5571 (static var X2) Removed.
5572 (setup_randomize) Removed.
5574 (rand_uniform) Removed.
5575 (rand_normal) Removed.
5576 (struct rng) New structure.
5577 (rng_create) New function.
5578 (rng_destroy) New function.
5579 (swap_byte) New static function.
5580 (rng_seed) New function.
5581 (rng_get_bytes) New function.
5582 (rng_get_int) New function.
5583 (rng_get_unsigned) New function.
5584 (rng_get_double) New function.
5585 (rng_get_double_normal) New function.
5586 (pspp_rng) New function.
5588 * random.h: Sync up to random.c.
5590 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5591 fraction of UINT_MAX, not 65536.
5592 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5595 * vfm.c: (open_active_file) No need to call setup_randomize() any
5598 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5600 Change dictionary name indexes to use hash tables instead of AVL
5603 * crosstabs.q: (free_var_dict) Use hash tables.
5604 (crs_custom_tables) Ditto.
5605 (calc_general) Ditto.
5606 (compare_table_entry) Rewrite.
5607 (enum_var_values) Reorder parameters. All references updated.
5610 * get.c: (rename_variable) Use hash tables.
5611 (mtf_merge_dictionary) Ditto.
5613 * glob.c: (init_glob) Use hash tables.
5614 (cmp_variable) Removed.
5616 * means.q: (mns_custom_tables) Use hash tables.
5618 * modify-vars.c: (rearrange_dict) Use hash tables.
5620 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5622 * sfm-read.c: (read_header) Use hash tables.
5623 (read_variables) Ditto.
5625 * temporary.c: (new_dictionary) Use hash tables.
5626 (save_dictionary) Ditto.
5627 (restore_dictionary) Ditto.
5629 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5630 hash table `name_tab'.
5632 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5633 [DEBUGGING] (dump_var_tree) Removed.
5634 (find_variable) Use hash tables.
5635 (find_dict_variable) Ditto.
5636 (common_init_stuff) Ditto.
5637 (rename_variable) Ditto.
5638 (clear_variable) Ditto. Also, remove debug code.
5639 (dup_variable) Use hash tables.
5641 * vars-prs.c: (fill_all_vars) Use hash tables.
5642 (is_dict_varname) Ditto.
5643 (parse_dict_variable) Ditto.
5645 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5647 Change value labels to use hash tables instead of AVL trees, and
5648 change value labels into an ADT.
5650 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5652 * value-labels.c: New file.
5654 * value-labels.h: New file.
5656 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5657 Get rid of a stupid use of goto.
5659 * autorecode.c: (compare_alpha_value) Rewrite.
5660 (hash_alpha_value) Ditto.
5661 (compare_numeric_value) Rewrite.
5662 (hash_numeric_value) Ditto.
5664 * frequencies.q: (dump_full) Use value label ADT.
5666 * pfm-read.c: (read_value_label) Use value label ADT.
5668 * pfm-write.c: (write_value_labels) Use value label ADT.
5670 * sfm-read.c: (read_variables) Use value label ADT.
5671 (read_value_labels) Rewrite.
5673 * sfm-write.c: (write_value_labels) Rewrite.
5675 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5676 (display_variables) Ditto.
5677 (describe_variable) Ditto.
5679 * t-test.q: (print_t_groups) Use value label ADT.
5681 * temporary.c: (copy_variable) Use value label ADT.
5682 (free_dictionary) Ditto.
5684 * val-labs.c: (verify_val_labs) Use value label ADT.
5686 (debug_print) Ditto.
5687 (val_lab_cmp) Removed.
5688 (inc_ref_count) Removed.
5689 (copy_value_labels) Removed.
5691 * var.h: (struct value_label) Removed.
5692 (struct variable) Change AVL tree `val_lab' into hash table
5695 * vars-atr.c: (init_variable) Use value label ADT.
5696 (clear_variable) Ditto.
5697 (free_value_label) Removed.
5698 (free_val_lab) Removed.
5699 (get_val_lab) Removed.
5700 (compare_variables) New function.
5701 (hash_variable) New function.
5703 * vfm.c: (dump_splits) Use value label ADT.
5705 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5707 Add to the hash table interface.
5709 * hash.c: (hsh_hash_bytes) Add assertion.
5710 (hsh_hash_string) Ditto.
5714 (hsh_create) Ditto. Also make minimum `size'.
5715 (hsh_destroy) Rephrase.
5716 (sort_nulls_last) Removed.
5717 (not_null) New function.
5719 (comparison_helper) Ditto.
5720 (hsh_sort) Rewritten.
5721 (hsh_data_copy) New function.
5722 (hsh_sort_copy) Ditto.
5724 (hsh_replace) Ditto.
5725 (hsh_hash_double) Ditto.
5726 (hsh_delete) Fix stupid bug.
5728 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5729 * added a calculation of the mode to FREQUENCIES
5731 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5733 * moved (un)defs of DEBUGGING to config.h
5735 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5737 * groff-font.c: (add_kern) Fix indentation.
5738 (add_kern) Use & instead of % to take power-of-2 modulus.
5739 (font_get_kern_adjust) Likewise.
5741 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5743 * autorecode.c: (recode) Replace stupid use of memcpy() by
5745 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5746 (hash_numeric_value) Ditto.
5747 (autorecode_proc_func) pool_strdup() was wrong here because the
5748 source string was not null-terminated. Use new pool_strndup()
5751 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5752 use of hsh_iterator_init().
5754 * data-in.c: (parse_N) Initialize i->v->f.
5756 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5759 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5760 (groff_read_font) Don't call hsh_next_prime(). Don't call
5762 (static var hash) Remove `size_p', `max_used' members.
5763 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5764 hsh_hash_string() instead of hashpjw(), & instead of %.
5765 (default_font) Don't call hsh_next_prime().
5767 * pool.c: (pool_strndup) New function.
5768 (pool_strdup) Reimplement in terms of pool_strndup.
5770 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5772 (hash_ps_encoding) Use hsh_hash_string().
5773 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5774 (hash_filename2font) Use hsh_hash_string().
5776 * som.c: Add #include <stdlib.h>.
5778 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5779 (by destroying its pool).
5781 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5783 Miscellaneous hash table code cleanup:
5785 * hash.h: (struct hsh_table) Moved into hash.c.
5786 (hsh_count) Ditto, and transformed into function.
5787 (hsh_compare_func) New typedef, used for defining otherwise-long
5788 function types here and in hash.c
5789 (hsh_hash_func) Ditto.
5790 (hsh_free_func) Ditto.
5792 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5793 `table' to `entries'. Removed `mp'. All references updated.
5794 (hsh_clear) Don't shrink entries array; if the hash was this big
5795 once, it probably will be again.
5796 (hsh_rehash) Made static.
5797 (force_hsh_insert) Renamed hsh_force_insert.
5798 (force_hsh_find) Renamed hsh_force_find.
5800 Made hash table sizes powers of 2, because that's fine with any
5801 reasonable hash function and because taking a power-of-2 modulus
5802 is faster than any other:
5804 (hsh_prime_tab) Removed;
5805 (hsh_next_prime) Ditto.
5806 (next_power_of_2) New function.
5807 (hsh_create) Use next_power_of_2.
5808 (hsh_rehash) Use & instead of %.
5810 Cleaned up hsh_sort:
5812 (internal_comparison_fn) Removed.
5813 (sort_nulls_last) New function.
5814 (hsh_sort) Removed second parameter, switched to using the new
5815 quicksort() function from quicksort.h to avoid using nasty need
5816 for static variables with qsort(). All references updated.
5818 Changed the hash functions offered, because there are better hash
5819 functions than the ones we had, and cleaned up the names to boot:
5821 * hash.c: (hashpjw_d) Removed.
5823 (hsh_hash_bytes) New function.
5824 (hsh_hash_string) New function.
5825 (hsh_hash_int) New function.
5827 Improved the hash table iteration interface:
5829 * hash.h: (hsh_iterator_init) Removed.
5830 (struct hsh_iterator) Removed `init' member, change `next' to
5833 * hash.c: (hsh_foreach) Removed. All references updated to use
5834 hsh_first/hsh_next instead.
5835 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5836 not treat a null pointer as an empty hash table.
5837 (hsh_next) New function.
5839 Made deletion possible, though slow:
5841 * hash.c: (locate_matching_entry) New function.
5842 (hsh_find) Use locate_matching_entry().
5843 (hsh_delete) New function also using locate_matching_entry().
5844 (hsh_force_delete) New function.
5846 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5848 * quicksort.c: New file implementing a sort routine with a
5849 interface better than qsort() because it passes a user-provided
5850 parameter to the sort routine.
5852 * Makefile.am: Add quicksort.c, quicksort.h.
5854 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5856 * All source files: Get rid of nasty special cases for Checker,
5857 which is pretty obsolete now.
5859 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5861 * Fixed a bug apparent when using the FREQUENCIES command with the
5862 html driver. The html driver was incorrectly trying to display
5865 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5867 * Makefile.am: Reorganized. Put locale dir in version.c instead
5868 of passing it to each compile command. Only put local gmp libs in
5869 LD_ADD if not installed on system. Remove `boast' target.
5871 * All source files: struct and union typedefs eliminated.
5872 `sizeof type' replaced by `sizeof object' where practical. Moved
5873 `unused' qualifiers from start to end of declarations for gcc
5874 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5875 assertions on pointers strictly compliant. Removed _ prefixes on
5876 some function parameter names.
5878 * alloc.c: New source file, containing these external linkage
5879 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5886 * ascii.c: Migrated from arenas to pools.
5887 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5888 c_string to len_string. All references changed.
5889 (ascii_option) Signature changed to comply to new output.c
5891 (count_fancy_chars) Removed.
5892 (delineate) Removed support for rich text.
5893 (ascii_text_metrics) Ditto.
5895 (output_shorts) Change `box', `off', `on' from c_string to
5896 len_string. Change `remaining' from int to size_t.
5897 (ascii_close_page) Make page numbering less haphazard.
5899 * autorecode.c: Migrate from arenas to pools.
5901 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5903 * bitvector.h: New file containing these macros from misc.h:
5904 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5906 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5907 word[3]. ncmd removed.
5908 (var empty_string) Removed.
5909 (var cmd_table) Declaration updated.
5910 (var cmdtab) Removed.
5911 (cmp_command) Removed.
5912 (split_words) Rewritten to use strtok_r().
5913 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5914 (find_command) Removed.
5915 (FILE_TYPE_okay) Rewritten.
5916 (cmd_parse) Rewritten. Semantics of the return value of command
5917 handlers has changed: they must now return one of the new CMD_*
5918 enumerals, rather than a magic value. This meant that all
5919 commands had to be modified, and they were.
5920 (figure_out_command) New function.
5922 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5923 #defines for INIT, INPU, etc.
5925 * command.h: New CMD_* enum series.
5926 (cur_proc) Make const char *, not char *.
5927 (cmd_init) Prototype.
5930 * common.c: Removed.
5932 * common.h: Removed.
5934 * correlations.q: New file.
5936 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5938 (custom_tables) Renamed crs_custom_tables().
5939 (custom_variables) Renamed crs_custom_variables().
5940 (calc_integer) Add in some `const' qualifiers.
5941 (table_value_missing) Change from a_string to len_string.
5942 (float_M_suffix) Change from a_string to len_string.
5944 * data-in.c: Rewritten. All references to
5945 parse_string_as_format() changed to data_in().
5947 * data-in.h: New file.
5949 * data-list.c: Change DLS_* from #define's to enums. Move from
5950 rpd_msg() to tmsg().
5951 (RPD_ERR) New #define.
5952 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5954 (read_from_data_list_fixed) Change from old
5955 parse_string_as_format() to new data_in().
5956 (read_from_data_list_free) Ditto.
5957 (read_from_data_list_list) Ditto.
5958 (cmd_repeating_data) Modify approach to checking for end of
5961 (rpd_parse_record) Change from old parse_string_as_format() to new
5962 data_in(). Change from old convert_format_to_string() to new
5964 (read_one_set_of_repetitions) Change dfm_push_cust() to
5965 dfm_push(), pop_cust() to dfm_pop().
5967 * data-out.c: Rewritten. All references to
5968 convert_format_to_string() changed to data_out().
5970 * descript.q: Migrate to new q2c.
5971 (cmd_descriptives) Removed.
5972 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5973 (custom_variables) Renamed dsc_custom_variables().
5975 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5977 (open_file_r) Initialize h->where.line_number. Migrate to new
5979 (open_file_w) Initialize h->where.line_number.
5980 (read_record) Change from ext->ln to h->where.line_number.
5981 Migrate to struct string.
5982 (dfm_put_record) Rephrased.
5983 (dfm_push_cust) Renamed dfm_push(), rewritten.
5984 (dfm_pop) New function.
5986 * error.c: All references updated.
5987 (glob var error_count) Renamed err_err_count.
5988 (glob var warning_count) Renamed err_warning_count.
5989 (glob var error_already_flagged) Renamed err_already_flagged.
5990 (glob var verbosity) Renamed err_verbosity.
5991 (glob var cust_fn) Removed.
5992 (glob var cust_ln) Removed.
5993 (static var file_loc) New.
5994 (static var nfile_loc) New.
5995 (static var mfile_loc) New.
5996 (tmsg) New function.
5997 (push_cust) Removed.
6000 (static var terminating) Removed.
6001 (failure) Renamed err_failure().
6002 (hcf) Renamed err_hcf().
6003 (err_push_file_locator) New function.
6004 (err_pop_file_locator) New function.
6005 (err_location) New function.
6006 (check_error_count) Renamed err_check_count().
6007 (vmsg) Renamed err_vmsg(). Interface changed.
6008 (verbose_msg) Removed.
6009 (err_cond_fail) New function.
6010 (error_break) Renamed err_break().
6012 * error.h: All references updated.
6013 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
6014 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
6016 (struct file_locator) New.
6018 (macro verbose_msg) Removed.
6019 (macro cond_fail) Removed.
6021 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
6023 * expr-prs.c: Reorganized. All references updated.
6024 (exprtypename) Renamed expr_type_name().
6025 (typename) Renamed type_name().
6026 (free_expression) Renamed expr_free().
6027 (parse_expression) Renamed expr_parse(). Uses new type_check()
6029 (init_functab) Renamed init_func_tab().
6030 (type_check) New function.
6031 (parse_or) Rewritten to use new allocate_nonterminal() and
6032 append_nonterminal_arg() functions.
6035 (parse_rel) Ditto. Also simplified logic.
6040 (SYSMIS_func) Ditto.
6041 (VALUE_func) Rephrased.
6042 (CONCAT_func) Fix memory leak by replacing free by free_node on
6044 (generic_str_func) Ditto.
6045 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
6047 (allocate_nonterminal) New function.
6048 (append_nonterminal_arg) New function.
6049 (static func_tab[]) Now at file level.
6051 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
6053 * expr.h: (enum series OP_*) Moved to exprP.h.
6054 (OP_* defines) Ditto.
6055 (struct op_desc) Ditto.
6056 (global ops[]) Ditto.
6057 (struct num_con_node) Ditto.
6058 (struct str_con_node) Ditto.
6059 (struct var_node) Ditto.
6060 (struct lag_node) Ditto.
6061 (struct casenum_node) Ditto.
6062 (struct nonterm_node) Ditto.
6063 (union any_node) Members renamed.
6064 (struct sys_node) Removed.
6065 (struct val_node) Removed.
6066 (operator typedef) Removed.
6067 (typedef exprtype) Removed.
6068 (enum series EX_*) Moved to exprP.h.
6069 (struct expression) Ditto. Also renamed a lot of the members.
6070 (PXP_* defines) Changed to enums.
6071 (free_node prototype) Moved to exprP.h.
6073 * file-handle.h: (struct file_handle) New member `where'.
6075 * file-handle.q: Migrated to new q2c format.
6076 (prepend_current_directory) Removed (dead code).
6077 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
6078 (fh_get_handle_by_filename) Removed dead code.
6079 Set new `where' member.
6081 * file-type.c: (file_type_source_read) References to
6082 parse_string_as_format() changed to data_in().
6083 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
6085 * filename.c: All references updated.
6086 (init_filename) Renamed fn_init().
6087 (expand_line) Removed.
6088 (macro EXPAND_LINE) Removed.
6089 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
6090 of custom functions.
6091 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
6092 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
6093 (normalize_filename) Renamed fn_normalize().
6094 (search_path) Renamed fn_search_path(), rewritten.
6095 (prepend_dir) Renamed fn_prepend_dir().
6096 (blp_getenv) Renamed fn_getenv().
6097 (blp_dirname) Renamed fn_dirname().
6098 (fn_basename) New function, not used.
6099 (absolute_filename_p) Renamed fn_absolute_p().
6100 (is_special_filename) Renamed fn_special_p().
6101 (file_exists) Renamed fn_exists_p().
6102 (readlink_malloc) Renamed fn_readlink().
6103 (getenv_default) Renamed fn_getenv_default().
6104 (open_file) Renamed fn_open().
6105 (close_file) Renamed fn_close().
6106 (open_file_ext) Renamed fn_open_ext().
6107 (close_file_ext) Renamed fn_close_ext().
6109 * font.h: Migrate from arenas to pools.
6111 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
6113 * frequencies.g: Migrate from arenas to pools.
6115 * frequencies.q: Migrate to new q2c version. Migrate from arenas
6118 * getline.c: All references updated.
6119 (global getl_buf) Changed from char * to struct string.
6120 (static getl_include_path) Ditto.
6121 (global getl_buf_len) Removed.
6122 (global getl_buf_size) Removed.
6123 (getl_include_path) Deal with new getl_buf, getl_include_path.
6124 (getl_uninitialize) New function.
6125 (getl_get_current_directory) Rewritten.
6126 (getl_clear_include_path) Rewritten.
6127 (getl_add_include_dir) Rewritten.
6128 (getl_add_file) Assertion fixed.
6129 (getl_add_virtual_file) Change initial value of `remaining_loops'
6131 (welcome) Rewritten.
6132 (handle_line_buffer) Make static. Change logic to make
6133 getl_add_virtual_file() change sensible. Use ds_*() strings.
6134 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
6135 (getl_close_file) Moved.
6136 (getl_location) New function.
6138 * getline.h: All references updated.
6139 (macro curln) Removed.
6140 (macro curfn) Removed.
6141 (macro am_interactive) Renamed getl_am_interactive.
6142 (macro am_reading_script) Renamed getl_reading_script.
6144 * glob.c: (global fmt_parse_ignore_error) Removed.
6145 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
6146 systems that support it (C99). Turn off SET ECHO by default. No
6147 necessary julcal initialization anymore.
6149 * groff-font.c: Migrate from arenas to pools.
6150 (groff_read_font) Use err_push_file_locator().
6151 (groff_read_DESC) Ditto.
6152 (font_msg) Use tmsg().
6154 * hash.c: (hsh_sort) Fix debug code.
6155 [GLOBAL_DEBUGGING] Include stdio.h.
6157 * hash.h: (macro force_hsh_insert) Rephrase.
6159 * heap.c: Rewritten.
6161 * heap.h: Rewritten.
6163 * html.c: (html_option) Change from outp_value to struct string.
6164 (postopen) Change from curfn to getl_location().
6165 (escape_string) Remove rich-text code. Signature changed.
6166 (output_tab_table) Switch from a_string to struct len_string.
6167 Remove rich text support.
6169 * lexer.c: All references updated. Largely rewritten. Major
6170 changes listed below. Removed tagged quote support. Adapted to
6171 struct string tokstr.
6172 (global tokstr) Changed to struct string.
6173 (global tokstr_size) Removed.
6174 (global tokstr_len) Removed.
6176 (global tokint) Removed.
6177 (global toklongstr) Removed.
6178 (C* defines) Removed.
6179 (static tbl[]) Removed.
6180 (static id[]) Removed.
6181 (static une[]) Removed.
6182 (discard_line) Renamed lex_discard_line().
6183 (get_entire_line) Renamed lex_entire_line().
6184 (get_rest_of_line) Renamed lex_rest_of_line().
6185 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
6186 (make_hexit) Removed.
6187 (syntax_error) Renamed lex_error(). Return value removed.
6188 (get_token_representation) Renamed lex_token_representation().
6189 (putback) Renamed lex_put_back().
6190 (putfwd) Renamed lex_put_forward().
6191 (convert_negative_to_dash) Renamed lex_negative_to_dash().
6192 (set_prog) Renamed lex_set_prog().
6193 (init_lex) Renamed lex_init().
6194 (reset_eof) Renamed lex_reset_eof().
6195 (lookahead) Renamed lex_look_ahead().
6196 (check_id) Rewritten.
6197 (yylex) Renamed lex_get(), rewritten.
6198 (lex_end_of_command) New function. Many commands were rephrased
6200 (lex_integer_p) New function. Replaces compare of tokint against
6202 (lex_integer) New function. Replaces tokint.
6203 (match_tok) Renamed lex_match().
6204 (match_id) Renamed lex_match_id().
6205 (match_int) Renamed lex_match_int().
6206 (force_match_id) Renamed lex_force_match_id(), added return value.
6207 (force_match) Renamed lex_force_match(), added return value.
6208 (force_string) Renamed lex_force_string(), added return value.
6209 (force_int) Renamed lex_force_int(), added return value.
6210 (lex_id_match_len) New function.
6211 (id_match) Renamed lex_id_match(), rewritten.
6212 (get_line) Renamed lex_get_line().
6213 (preprocess_line) Renamed lex_preprocess_line().
6214 (tokname) Renamed lex_token_name().
6215 (bin_value_func) Removed.
6216 (oct_value_func) Removed.
6217 (hex_value_func) Removed.
6218 (unexpected_eof) New function.
6219 (convert_numeric_string_to_char_string) New function.
6220 (parse_string) Rewritten, signature changed.
6221 (add_tokstr_char) Removed.
6222 (add_tokstr_unsigned) Removed.
6223 (add_tokstr_string) Removed.
6224 (parse_tagged_quote) Removed.
6225 (skip_comment) Renamed lex_skip_comment().
6227 * lexer.h: All references updated.
6228 (macro is_id1) Renamed CHAR_IS_ID1.
6229 (macro is_idn) Renamed CHAR_IS_IDN.
6230 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
6231 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
6232 (macro get_token) Removed.
6233 (macro id_match) Removed.
6234 (macro force_match_id) Removed.
6235 (macro force_match) Removed.
6236 (macro force_string) Removed.
6237 (macro force_int) Removed.
6238 (macro force_num) Removed.
6239 (macro force_id) Removed.
6241 * lexerP.h: Removed.
6243 * list.q: Migrated to new q2c format.
6244 (write_line) Deal with struct len_string.
6245 (write_varname) Ditto.
6246 (write_fallback_headers) Ditto.
6248 * magic.c: New file, incorporating the following global variables
6249 previously in other files: endian, second_lowest_value. And both
6250 of those are conditional on #define's.
6252 * magic.h: New file, incorporating the following global variable
6253 declarations: endian, second_lowest_value, and the following macro
6254 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
6256 * main.c: Added declarations of pgmname, finished, curdate,
6258 (main) Call new parse_script() function.
6259 (parse_script) New function.
6260 (execute_command) New function.
6261 (dump_token) Removed.
6262 (handle_error) New function.
6264 * matrix.c: New file.
6266 * matrix.h: New file.
6268 * matrix-data.c: Migrated from arenas to pools.
6269 (mget_token) Change from parse_string_as_format() to data_in().
6271 * means.q: Migrate to new q2c.
6272 (custom_tables) Renamed mns_custom_tables().
6273 (custom_crossbreak) Renamed mns_custom_crossbreak().
6274 (custom_variables) Renamed mns_custom_variables().
6276 * mis-val.c: (static var width) Changed from `int' to `size_t'.
6277 (parse_varnames) Prototype.
6278 (parse_numeric) Rephrasings.
6279 (parse_alpha) Adapt to new struct string tokstr.
6281 * misc.c: (intlog10) Rewritten.
6283 (ansi_rand) Renamed real_rand(), moved into random.c.
6284 (ansi_srand) Renamed real_srand(), moved into random.c.
6285 (setup_randomize) Moved to random.c.
6286 (rand_uniform) Ditto.
6287 (rand_normal) Ditto.
6288 (rand_simple) Ditto.
6289 (get_config_line) Removed.
6290 (reverse) Removed (dead code).
6292 * misc.h: (macro SET_BIT) Moved to bitvector.h.
6293 (macro CLEAR_BIT) Ditto.
6294 (macro TEST_BIT) Ditto.
6295 (macro SET_BIT_TO) Ditto.
6296 (macro BIT_INDEX) Ditto.
6298 * output.c: (outp_read_devices) Move to err_push_file_locator()
6299 from push_cust(). Use struct string.
6300 (expand_op_tokstr) Removed.
6301 (static var op_tokstr) Changed to struct string.
6302 (static var op_tokstr_size) Removed.
6303 (tokener) Rephrasings. Use struct string.
6304 (parse_options) Use struct string.
6305 (destroy_driver) Fix assertion.
6306 (outp_get_paper_size) Move to err_push_file_locator().
6307 [0] Removed dead code.
6308 (outp_string_width) Move to len_string.
6310 * output.h: Comment fixes.
6311 (TAG_* enum series) Removed.
6312 (struct outp_value) Removed.
6313 (enum OUTP_T_FANCY) Removed.
6314 (struct outp_text) `s' changed from a_string to len_string.
6315 (struct outp_class) `option' change arg 3 from outp_value to
6318 * pfm-read.c: (corrupt_msg) Rewritten.
6320 * pfm-write.c: (bufwrite) Fix assertion.
6322 * pool.c: New file, reference version.
6324 * pool.h: New file, reference version.
6326 * postscript.c: (ps_font_sizes) Fix assertion.
6327 (ps_option) Change arg 3 from outp_value to struct string.
6328 Adapt to struct string.
6329 (macro output_line) Removed.
6330 (macro add_string) Removed.
6331 (output_encodings) Adapted to struct string. Moved to
6332 err_push_file_locator().
6333 (find_encoding_file) Fix assertion.
6334 (read_ps_encodings) Move to err_push_file_locator().
6335 (postopen) Use getl_location() instead of curfn.
6336 (out_text_plain) Move to len_string.
6337 (text) Ditto. Remove rich text support.
6339 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
6340 (cmd_print_eject) Ditto.
6342 (internal_cmd_print) Now cleans up after itself. Uses
6343 fh_parse_file_handle() now.
6344 (cmd_print_space) Use PXP_NUMERIC to type-check.
6346 * q2c.c: Overhauled. Removed _("") i18n support. All references
6347 updated. All output functions updated to handle structures rather
6348 than local or static variables. Adapt to new PSPP lex_*()
6352 (macro MAX_N_SBC) Removed.
6353 (global bare) Removed.
6354 (enum STRING) Renamed T_STRING.
6355 (enum ID) Renamed T_ID.
6356 (get_buffer) Buffer size increased.
6357 (strlower) Renamed st_lower(), rephrased.
6358 (strupper) Renamed st_upper(), rephrased.
6359 (skip_ws) New function.
6360 (get_line) Don't special-case any types of lines (like those
6361 beginning with ! or $, for instance).
6362 (get_token) Renamed lex_get(). Rephrased.
6363 (static var `prefix') New.
6364 (parse) New function.
6365 (parse_setting) Minor rephrasing.
6366 (dump_specifier_vars) Ditto.
6367 (make_identifier) Put null terminator on identifier, duh.
6368 (dump_vars) Renamed dump_declarations(). Never indent. Never
6369 static. Output changed entirely.
6370 (dump_specifier_init) Rephrase.
6371 (dump_vars_init) No index variable needed. Other modifications.
6372 (dump_parser) Don't parse command name. Do dump functions instead
6373 of just code fragments.
6374 (dump_free) Dump function instead of code fragment.
6375 (recognize_directive) New function.
6376 (main) Use recognize_directive(). Don't rely on magic $ line
6377 beginning: instead, parse comments. Update list of headers.
6379 * random.c: New file, containing the following functions:
6380 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
6381 rand_normal, rand_simple.
6383 * random.h: New file.
6385 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
6386 function. `max_src_width', `max_dst_width' changed to size_t.
6387 (internal_cmd_recode) Removed.
6388 (parse_dest_spec) Merge similar cases.
6389 (parse_src_spec) Add assertion.
6391 * repeat.c: (recognize_keyword) New function.
6392 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
6393 REPEAT. Improve recognition of END REPEAT (use
6394 recognize_keyword()). Move from curfn to getl_location(). Use
6397 (perform_DO_REPEAT_substitutions) Adapt to struct string.
6399 * set.q: Adapt to new q2c.
6400 (cmd_set) Range-check some values better.
6401 (custom_blanks) Renamed stc_custom_blanks().
6402 (custom_length) Renamed stc_custom_length().
6403 (custom_results) Renamed stc_custom_results().
6404 (custom_seed) Renamed stc_custom_seed().
6405 (custom_width) Renamed stc_custom_width().
6406 (custom_format) Renamed stc_custom_format().
6407 (custom_journal) Renamed stc_custom_journal().
6408 (custom_color) Renamed stc_custom_color().
6409 (custom_listing) Renamed stc_custom_listing().
6410 (custom_disk) Renamed stc_custom_disk().
6411 (custom_log) Renamed stc_custom_log().
6412 (custom_rcolor) Renamed stc_custom_rcolor().
6413 (custom_viewlength) Renamed stc_custom_viewlength().
6414 (custom_workdev) Renamed stc_custom_workdev().
6416 * settings.h: Not necessary to include format.h any longer.
6418 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
6419 (corrupt_msg) Rewritten.
6421 * sort.c: Adapt to rewritten heap ADT.
6423 * str.c: (aa_strcpy) Removed.
6424 (ab_strcpy) Removed.
6425 (ac_strcpy) Removed.
6426 (ba_strcpy) Removed.
6427 (bb_strcpy) Removed.
6428 (ca_strcpy) Removed.
6429 (aa_strdup) Removed.
6430 (aa_strdupcpy) Removed.
6431 (ba_strdup) Removed.
6432 (sa_strdup) Removed.
6433 (memrev) Renamed mm_reverse().
6434 (memrmem) Renamed mm_find_reverse().
6435 (cmp_str) Renamed st_compare_pad().
6436 (strmaxcpy) Removed.
6437 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
6438 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
6440 (strpadcpy) Renamed st_pad_copy(), signature changed.
6441 (blpstrset) Removed.
6442 (ds_create) New function.
6443 (ds_init) New function.
6444 (ds_replace) New function.
6445 (ds_destroy) New function.
6446 (ds_clear) New function.
6447 (ds_extend) New function.
6448 (ds_shrink) New function.
6449 (ds_truncate) New function.
6450 (ds_length) New function.
6451 (ds_size) New function.
6452 (ds_value) New function.
6453 (ds_end) New function.
6454 (ds_concat) New function.
6455 (ds_concat_buffer) New function.
6456 (ds_printf) New function.
6457 (ds_putchar) New function.
6458 (ds_getline) New function.
6459 (ds_get_config_line) New function derived from the old
6460 misc.c:get_config_line().
6461 (ls_create) New function.
6462 (ls_create_buffer) New function.
6463 (ls_init) New function.
6464 (ls_shallow_copy) New function.
6465 (ls_destroy) New function.
6466 (ls_null) New function.
6467 (ls_null_p) New function.
6468 (ls_empty_p) New function.
6469 (ls_length) New function.
6470 (ls_value) New function.
6471 (ls_end) New function.
6473 * str.h: Reformatted.
6474 (struct a_string) Removed.
6475 (struct b_string) Removed.
6476 (struct c_string) Removed.
6477 (struct len_string) New.
6478 (struct string) New.
6479 (macro as_streq) Removed.
6480 (macro bs_streq) Removed.
6481 (macro cs_streq) Removed.
6482 (macro sa_streq) Removed.
6483 (macro sb_streq) Removed.
6484 [__GNUC__] (inline function ds_putchar) New function.
6485 [__GNUC__] (inline function ds_length) New function.
6486 [__GNUC__] (inline function ds_value) New function.
6487 [__GNUC__] (inline function ds_end) New function.
6489 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6490 (display_vectors) Fix missing i18n.
6492 * t-test.q: Migrate to new q2c.
6494 * tab.c: Migrate from arenas to pools.
6495 (tab_create) Use struct len_string.
6496 (tab_realloc) Ditto.
6497 (text_format) Ditto.
6498 (tab_joint_text) Ditto.
6499 (tab_natural_width) Remove rich text support.
6500 (tab_natural_height) Ditto.
6501 (tab_output_text) Handle TAT_FIX.
6502 (tab_raw) Change arg from a_string to len_string.
6503 (tabi_driver) Fix assertion. Use struct len_string.
6504 (render_strip) Use struct len_string. Remove rich text support.
6505 Add `const' qualifiers.
6507 * tab.h: (enum TAB_RICH) Remove.
6508 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6509 SOM_COL_* updated to read TAB_COL_*.
6510 (struct tab_table) Change arena to pool. Change a_string to
6513 * temporary.c: (restore_dictionary) Rewrite Checker code.
6515 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6516 LOWEST, HIGHEST) Moved here from common.h.
6517 (typedef any_trns) Removed. All references changed to `struct
6520 * vars-atr.c: (force_create_variable) Fix assertion.
6521 (force_dup_variable) Fix assertion.
6523 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6525 Using alphanumeric variables in functions under AGGREGATE
6526 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6527 <BZN-mdksh@t-online.de> for reporting this bug.
6529 * aggregate.c: (parse_aggregate_functions) When setting the
6530 FSTRING bit, also allocate memory for the `string' member of
6532 (free_aggregate_functions) Free iter->string. Don't use the
6533 non-function bits when indexing the array of functions.
6534 [DEBUGGING] (debug_print) Don't use the non-function bits when
6535 indexing the array of functions.
6537 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6539 Under certain circumstances, the final case would be omitted from
6540 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6541 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6543 * aggregate.c (agr_00x_end_func): Increment number of cases in
6544 sink before writing case. For streams that keep track of how many
6545 cases there are based on this value, this means that the last case
6546 will be read in on the next stream read.
6548 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6550 Undefined behavior was invoked by referencing a freed pointer.
6552 * vfm.c (memory_stream_write): Free pointer *after* checking for
6555 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6557 A wrong record size was displayed when paging the active file to
6560 * vfm.c: (memory_stream_write) Fix off-by-one error.
6562 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6564 Not having enough temporary space for sorting caused a core dump.
6567 * sort.c: (allocate_cases) Initialize i.
6569 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6571 Syntax errors in function descriptions on AGGREGATE caused core
6574 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6575 free_aggregate_functions(), since that function already frees
6578 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6580 A null pointer was dereferenced, causing a core dump, when
6581 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6582 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6583 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6585 * arena.c: (arena_malloc) If the arena hasn't been initialized
6586 already, initialize it.
6588 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6590 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6591 for compilation with Cygnus Windows B20. Not used by other
6594 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6596 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6597 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6599 * sort.c: (compare_case_lists) Reverse sense of comparison if
6600 sorting in descending order.
6601 (compare_record) Ditto.
6603 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6605 SPLIT FILE with a string variable caused a core dump. Fixed.
6607 * vfm.c: If the variable is a string then make a temporary value
6608 struct pointing to it. The underlying problem is a lot bigger
6609 than this (see TODO) but this is a stopgap for the simple case at
6612 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6614 Nested INCLUDEs didn't work. Fixed.
6616 * getline.c: (getl_include) Set first_line to NULL in allocated
6619 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6621 The MATCH FILES procedure set the values of variables not present
6622 to 0. It should have been SYSMIS. This is now fixed.
6624 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6626 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6628 The REMARK command was too aggressive about skipping lines. It
6629 didn't like being the last command in a file.
6631 * command.c: (cmd_remark) Call get_entire_line() instead of
6634 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6636 Comment parsing wasn't consistent with the rest of the code in its
6637 idea of where one command ends and another starts. This meant
6638 that sometimes commands would be mysteriously ignored. Thanks to
6639 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6641 * command.c: (parse_cmd) Hand off comment parsing to new function
6642 skip_comment() in lexer.c.
6643 * lexer.c: (skip_comment) New function.
6645 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6647 The TABLE subcommand on MATCH FILES worked only erratically at
6648 best. This fixes it. Thanks to Dr. Dirk Melcher
6649 <BZN-mdksh@t-online.de> for reporting this bug.
6651 * get.c: (mtf_compare_BY_values) When comparing string values, a
6652 difference of 1 is still a difference :-)
6653 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6654 advance TABLE files automatically when matched. Comment fixes.
6656 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6658 VARIABLE LABELS rejected a slash before the first variable
6659 specification, contradicting the documentation. Thanks to Walter
6660 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6662 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6663 command specification.
6665 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6667 Because of an incorrect optimization in memory allocation,
6668 CROSSTABS sometimes segfaulted when asked to output multiple
6669 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6672 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6673 are passed to output_pivot_table() for its use.
6674 (output_pivot_table) Instead of assuming the number of columns is
6675 constant, keep track with maxcols. In general mode, use maxcells
6676 to determine whether more matrix cells need to be allocated.
6678 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6680 CROSSTABS didn't display value labels for column and row
6681 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6684 * crosstabs.q: (table_value_missing) If the specified value has a
6685 value label for this variable, then show it instead of the raw
6687 (display_dimensions) Delegate display of value_labels to
6688 table_value_missing.
6690 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6692 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6693 <BZN-mdksh@t-online.de> for reporting this bug.
6695 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6696 if the file isn't declared as binary.
6698 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6700 MATCH FILES corrupted memory and dumped core on some syntax
6703 * get.c: (cmd_match_files) Set file->handle to NULL before
6705 (mtf_free_file) Don't free a null dictionary.
6707 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6709 MATCH FILES should set numeric values not available to the
6710 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6711 <BZN-mdksh@t-online.de> for reporting this bug.
6713 * get.c: (mtf_processing) Set unused records to system-missing,
6716 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6718 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6719 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6721 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6722 in newly created dictionary, and add each copied variable to the
6725 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6729 * get.c: (trim_dictionary) Free variable list for KEEP after
6732 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6734 Some systems didn't like the way open_file was coded. Thanks to
6735 Hankin <hankin@rogue.consultco.com> for pointing this out.
6737 * filename.c: (open_file) Don't try to store stdin, stdout,
6738 stderr as part of an array, because that doesn't always work.
6740 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6742 The SAVE procedure didn't save long string variables properly.
6743 Fixed by this patch. Thanks to Hankin
6744 <hankin@rogue.consultco.com> for this patch.
6746 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6747 out variable pad records.
6749 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6751 Previously, if PRINT SPACE were given a negative argument, it
6752 would report an error, then spin in an (almost) infinite loop.
6753 This fixes that behavior.
6755 * print.c: (print_space_trns_proc) After reporting a negative
6756 argument, set number of lines to print to 1.
6758 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6760 SPSS 8.0 outputs some new record types in its system files, and it
6761 allows longer value labels. Accept these system files.
6763 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6764 11 emitted by SPSS 8.0.
6766 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6768 The LIST procedure was too conservative in allocating space for
6769 buffers, which caused a bug that only showed up with very long
6770 output variables. Thanks to Hankin <hankin@dunno.com> for this
6773 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6775 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6777 Typo meant string format specifiers weren't checked properly. I
6778 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6779 willing to be corrected on this point.
6781 * format.c: (check_string_specifier) Fix obvious typo.
6783 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6785 Using $CASENUM in an expression didn't work. Here's a fix.
6786 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6789 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6791 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6793 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6795 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6796 other behavior, *sigh*. This patch hopefully fixes that. This
6797 time I've actually tested it.
6799 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6801 * data-list.c: (read_from_data_list_free,
6802 read_from_data_list_list) Call parse_string_as_format() directly
6803 without mucking around with the field width.
6805 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6807 Occasionally, you may encounter a script that wants to be
6808 interpreted in interactive mode. Make -i emulate this behavior to
6809 allow such scripts to be executed with PSPP.
6811 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6813 * cmdline.c: (pre_syntax_message[]) Update -i description.
6815 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6816 when -i is given on the command line) don't treat unindented lines
6817 as starting a new command.
6819 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6821 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6822 mostly caused by local initialized aggregates. After egcs is
6823 fixed upstream these can be removed, but for now they're not a big
6826 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6827 initialized arrays. Avoid this.
6829 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6832 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6834 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6835 following changes avoid. Currently I compile sources with egcs
6836 1.1.1 and gcc 2.7.2.3 before sending them out.
6838 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6840 * ascii.c: (option_tab[]) Initialize all struct members.
6842 * avl.h: (avl_traverser_init) New macro.
6844 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6847 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6850 * hash.c: Comment fix.
6852 * hash.h: (hsh_iterator_init) New macro.
6854 * html.c: (option_tab[]) Initialize all struct members.
6856 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6859 * postscript.c: (option_tab[]) Initialize all struct members.
6860 (output_encodings, preclose, dump_lines) Use new
6861 hsh_iterator_init() macro.
6863 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6866 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6869 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6871 * data-in.c: Examined each of the parsing functions to make sure
6872 that they wouldn't dump core if they were passed a string of the
6873 wrong length, since now the DATA LIST FREE/LIST routines don't
6874 check for field width before passing it to the data parser.
6875 (parse_RBHEX, parse_AHEX) Reject odd length input.
6876 (parse_string_as_format) Reject input that's too short or too
6879 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6880 a field to its entire declared output width then pass it to the
6881 data-in parsing routines. This contradicted the documented
6882 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6883 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6884 free-format parsing that differed from SPSS.
6885 (cut_field) Commas and spaces are treated identically. Returns
6886 the proper column instead of a fixed 1 value.
6887 (parse_field) Removed.
6888 (read_from_data_list_free, read_from_data_list_list) Call
6889 parse_string_as_format directly instead of parse_field.
6891 * heap.c: (heap_delete) Stylistic fixes.
6893 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6895 * loop.c: (loop_2_trns_proc) Formatting fix.
6897 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6899 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6901 * vfm.c: (macro FILTERED) New.
6902 (static var filter_var) New.
6903 (process_active_file_write_case) Use FILTERED.
6904 (setup_filter) Set filter_var.
6905 (close_active_file) Delete the filter if not
6906 FILTER_before_TEMPORARY.
6907 (procedure_write_case) Use FILTERED.
6909 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6911 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6913 * data-in.c: (parse_day_count) Message fix.
6914 (parse_month) Style fix.
6916 * data-list.c: (struct data_list_pgm) New member eof.
6917 (cmd_data_list) Init eof to 0.
6918 (do_reading) Implement the /END subcommand and read-past-eof
6921 * do-if.c: Include stdio.h when debugging.
6922 (cmd_else_if) Make sure the command is .-terminated.
6924 * glob.c: (init_glob) Capitalize the command prompt.
6926 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6927 (end_file_trns_proc) Debugging message.
6929 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6931 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6933 * main.c: (dump_token) Make kwtab[] const.
6935 * set.q: Spelling, comment fixes.
6937 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6940 * vars-prs.c: (fill_all_vars) Style fix.
6942 * vfm.c: (index_to_varname) Return const.
6944 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6946 * Changes in many source files for partial -ansi -pedantic and
6947 no-debugging compliance: Remove trailing common in enum
6948 declarations; add `unused' attributes; insert some appropriate
6951 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6953 * command.c: (shell) Make static.
6954 (run_command) Make static.
6956 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6958 * dfm.c: (cmd_begin_data) I18n fix.
6960 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6962 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6964 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6967 * file-handle.q: Don't prepend the source file directory name to
6968 the data file name. (Ongoing issue.)
6969 (prepend_current_directory) Comment out.
6970 (internal_cmd_file_handle) Don't call prepend_current_directory().
6971 (fh_get_handle_by_filename) Ditto.
6973 * filename.c: Append zero byte to readlink() return value.
6975 * getline.c: (getl_read_line) I18n fix.
6977 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6979 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6981 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6984 * postscript.c: (output_encodings) Don't use local_strdup().
6987 * print.c: Don't use gcc features if __STRICT_ANSI__.
6989 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6991 * recode.c: (parse_src_spec) Fully brace nested if's.
6993 * set.q: (global var set_testing_mode) New var.
6995 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6997 * ascii.c: Add some more `unused' attributes that only come into
6998 play when NDEBUG is defined.
6999 (ascii_close_page) Set s_len when reallocating s.
7001 * crosstabs.q: (delete_missing) New function.
7002 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
7003 (make_summary_table) Create summary table reallocable.
7005 * postscript.c: Add more `unused' attributes as above.
7007 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
7008 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
7010 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
7013 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
7014 gratuitous space between parameter definition.
7016 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
7017 complaints about running off the end of functions with NDEBUG
7020 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
7022 * Several source files: Removed some PORTME notes when reflection
7023 revealed that ANSI forbids that sort of breakage. Also, added
7024 lots of `unused' qualifiers here and there.
7026 * aggregate.c: (accumulate_aggregate_info) Remove local var
7027 weighting that turned out not to be used.
7029 * avl.c: Update to version 1.1.0. Add unused specifier.
7030 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
7032 (avl_probe) Replace some instances of 1 with +1 where appropriate.
7033 (avl_find) Cast return value to void *.
7034 (avl_delete) q doesn't need to be initialized at the beginning of
7035 the function. Replace some instances of 1 with +1.
7036 (force_avl_delete) Renamed avl_force_delete, all references changed.
7037 (compare_ints) `param' marked unused.
7038 (print_int) `param' marked unused.
7039 (recurse_tree) Replace some instances of 1 with +1.
7041 * avl.h: Update to version 1.1.0. Only declares avl function
7042 types if not already declared.
7043 (AVL_MAX_HEIGHT) Only define if not already defined.
7044 (struct avl_node) New unused member char pad[2].
7045 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
7046 (force_avl_insert) Renamed avl_force_insert.
7047 (force_avl_delete) Renamed avl_force_delete.
7049 * crosstabs.q: (struct table_entry) Put `freq' into a union with
7051 (struct crosstab) Add new member `ofs'.
7052 (glob var int_tab) Removed.
7053 (custom_tables) In integer mode, assign v[i] properly through the
7055 (custom_variables) Now p.crs.max == max + 1.
7056 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
7057 (precalc) Implement integer mode.
7058 (calc_integer) Implement integer mode.
7059 (compare_table_entry) Remove unused local variable `comparing'.
7060 (make_summary_table) Implement integer mode.
7061 (macro ns_rows) Implemented as static variable now.
7062 (several variables) Made static, from global.
7063 (output_pivot_table) Use table_value_missing() for column heads.
7064 Remove several unused local variables. Implement integer mode
7065 table summing. Count up ns_rows.
7066 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
7067 (find_pivot_extent) Moved into find_pivot_extent_general; now just
7068 calls that function or find_pivot_extent_integer.
7069 (find_pivot_extent_integer) New function.
7070 (enum_var_values) Implemented for integer mode.
7071 (table_value_missing) New function.
7072 (display_dimensions) Call table_value_missing() for heads.
7073 (float_M_suffix) New function.
7074 (display_crosstabulation) Call table_value_missing() for row
7075 heads. Handle missing values in /MISSING=REPORT mode.
7076 (calc_fisher) Remove unused var N.
7077 (calc_r) Remove unused var fact.
7079 * data-list.c: (dump_fixed_table) Fix table dimensioning.
7080 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
7082 * data-out.c: (insert_commas) Remove unused var cp.
7083 (convert_CCx) Remove unused vars save_set_decimal,
7086 * descript.q: (dump_z_table) Fix table dimensioning.
7087 (pre_calc) Remove unused var j.
7088 (display) Remove unused vars title, s. Fix table dimensioning.
7090 * expr-evl.c: Comment fixes.
7092 * frequencies.q: (full_dim) New function.
7093 (dump_full) Fix table dimensioning.
7094 (condensed_dim) New function.
7095 (dump_condensed) Fix table dimensioning.
7097 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
7100 * html.c: (html_close_drive) Remove unused var i.
7101 (postopen) Remove unused vars title, curfn_len, cp.
7102 (preclose) Remove unused vars this, x.
7104 * lexer.c: Comment fixes.
7106 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
7108 * means.q: (custom_tables) Remove unused var m_dim.
7110 * mis-val.c: Format fix.
7112 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
7114 * output.c: (outp_get_paper_size) Remove unused var cp.
7116 * pfm-read.c: (read_float) Remove unused var save, unused label
7118 (read_variables) Remove unused vars cp, j.
7119 (read_value_label) Remove unused var j.
7121 * pfm-write.c: (bufwrite) Remove unused var i.
7123 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
7125 (output_encodings) Remove unused vars char_cp, n_output.
7126 (read_ps_encodings) Remove unused var ep.
7127 (postopen) Remove unused var title.
7128 (preclose) Remove unused var fp.
7129 (ps_open_page) Remove unused vars true, false, orientation,
7130 mirror_horz, mirror_vert, width, length.
7131 (ps_text_metrics) Remove unused var x.
7133 * q2c.c: (find_symbol) Remove unused var y.
7134 (parse_setting) Remove unused parameter sbc, all references
7136 (dump_parser) Remove unused var cp.
7137 (dump_free) Remove unused var i.
7139 * set.q: (static vars args, n) Removed.
7140 (internal_cmd_gset) Removed.
7142 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
7143 (read_machine_flt64_info) Removed unused var file_endian.
7144 (read_documents) Removed unused var i.
7145 (read_compressed_data) Removed unused parameter dict, all
7148 * sfm-write.c: (bufwrite) Removed unused var i.
7149 (sfm_write_case) Removed unused var i.
7151 * sort.c: (merge_once) Remove unused var t.
7152 (write_separate) #if 0 out as dead code.
7154 * split-file.c: (cmd_split_file) Remove unused var i.
7156 * sysfile-info.c: (sysfile_info_dim) New function.
7157 (cmd_sysfile_info) Fix table dimensioning.
7158 (variables_dim) New function.
7159 (display_variables) Fix table dimensioning.
7160 (describe_variable) Remove unused var prev_r.
7162 * t-test.q: (z_postcalc) Removed.
7163 (pairs_calc) Remove unused var bad_weight.
7164 (postcalc) Remove unused vars dfn, dfd.
7166 * tab.c: (tab_create) Set t->dim to NULL.
7167 (tab_dim) Make sure t->dim is NULL first.
7168 (tab_natural_width) Remove parameter `clamp'.
7169 (tab_value) Remove duplicate assertion for table.
7170 (tab_raw) New function.
7171 (nowrap_dim) New function.
7172 (wrap_dim) New function.
7173 (tab_output_text) Fix table dimensioning.
7175 * tab.h: (tab_raw) New macro.
7177 * val-labs.c: (get_label) Remove unused var type.
7178 (copy_value_labels) Remove unused var trav.
7180 * var.h: (struct crosstab_proc) Completely changed.
7182 * vars-prs.c: (parse_dict_variable) Remove unused var v.
7184 * vfm.c: (open_active_file) Remove unused vars i, lp.
7186 * weight.c: (weight_trns_proc) #if 0 out as dead code.
7188 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
7190 * Makefile.am: Add apply-dict.c, flip.c.
7192 * apply-dict.c: New file.
7194 * command.c: (struct command) Make cmd[] larger for CLEAR
7195 TRANSFORMATIONS command name.
7196 (parse_cmd) Make sure we're in a valid state before using it as an
7197 index. Discard variables and reset state on invalid transitions.
7198 (cmd_clear_transformations) New function.
7200 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
7201 Add unimplemented PRESERVE, RESTORE.
7203 * file-handle.h: Include stddef.h.
7207 * pfm-read.c: (parse_value) Pad value label values with spaces,
7210 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
7211 (sfm_close) Decrement reference count, make sure it's zero.
7212 (sfm_maybe_close) New function.
7213 (sfm_read_dictionary) Handle reference counts.
7215 * vars-atr.c: (clear_default_dict) New function.
7216 (discard_variables) Use clear_default_dict().
7218 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
7220 * Makefile.am: Add pfm-write.c.
7221 (LDADD) Add the libgmp2 libraries.
7223 * command.def: Define EXPORT.
7225 * get.c: (cmd_export) New function.
7226 (export_write_case_func) New function.
7228 * pfm-read.c: (static spss2ascii[]) Make it const.
7230 * pfm-write.c: New file.
7232 * sfm-write.c: Formatting, comment fixes.
7234 * var.h: Comment fix.
7236 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
7238 * Makefile.am: Add pfm.h, pfm-read.c.
7240 * command.def: IMPORT is now implemented.
7242 * format.c: (glob var translate_fmt[]) New var.
7244 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
7245 (cmd_import) New function.
7246 (import_source_read) New function.
7247 (glob var import_source) New var.
7249 * pfm-read.c: New file.
7253 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
7255 (dump_dictionary) Disabled printing a couple of items.
7257 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
7259 * crosstabs.q: (postcalc) Call make_summary_table().
7260 (make_summary_table) New function.
7261 (insert_summary) New function.
7262 (display_dimensions) Remove some unnecessary arguments, all
7264 (output_pivot_table) Fix lots of problems with the risk table
7266 (submit) Don't display an empty table.
7267 (display_risk) Fix order of arguments to calc_risk().
7269 * glob.c: Always include assert.h and stdlib.h.
7271 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
7274 * tab.c: (tab_create) Cosmetic changes.
7276 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
7278 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
7282 * crosstabs.q: (output_pivot_table) Headers drawing and submission
7283 code simplified, moved into new function submit().
7284 (submit) New function.
7285 (crosstabs_dim) New function.
7286 (display_directional) Substitute variable names for %s where
7288 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
7289 (calc_symmetric) Initialize parameters only if non-NULL.
7290 Calculate Somers' d.
7291 (calc_directional) Calculate Somers' d (or copy it, really).
7294 * output.c: (outp_string_width) New function.
7296 * postscript.c: (postopen) Calculate font widths based on the
7297 width of the zero '0' character, not the width of the space
7298 character. Set paper-width and paper-length based on points, not
7300 (ps_open_page) Fix page setup string for landscape mode.
7302 * som.h: (struct som_dimension) Removed.
7303 (struct som_table_class) height, width members take int * not
7306 * tab.c: Many functions now have added parameter validation.
7307 (tab_height, tab_width) These functions were removed and merged
7308 into a single function tab_resize(), and all references changed.
7309 (tab_dim) Rewritten since the interface changed; reduced from
7310 hundreds of lines to two. All callers were changed. Currently
7311 most of them just use tab_natural_dimensions as their callback and
7312 await detailed translation of functionality.
7313 (tab_natural_width) New function.
7314 (tab_natural_height) New function.
7315 (tab_natural_dimensions) New function. This is a callback
7316 function, not something that you'd want to call directly.
7317 (tab_nat_dim) Removed.
7318 (tabi_table) Allocates t->w and t->h.
7319 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
7320 dimensions callback.
7321 (evaluate_dimensions) Removed.
7322 (sum_columns) Removed.
7324 * tab.h: (enum TAL_1THIN) Removed.
7325 (enum series t_*) Removed.
7326 (struct tab_table) Members trh, trv changed to unsigned char *
7327 from int *. Member dim changed to a function pointer from a
7328 unsigned char *. Member max_stack_height removed. New members
7330 (macros tab_l, tab_r, tab_t, tab_b) New.
7332 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
7334 * ascii.c: (delineate) Assign last_space_nchars before skipping
7335 spaces, to fix right justification.
7337 * crosstabs.q: (static vars risk, direct) New vars.
7338 (static var pearson_r) Removed.
7339 (glob var chisq_fisher) Made static.
7340 (static vars row_tot[], col_tot[]) Don't include grand total
7342 (static var grand_total) Renamed W, all references changed.
7343 (output_pivot_table) Only make `table' if num_cells != 0. Make
7344 risk and directional tables. Deal with grand total no longer part
7345 of col_tot[]. Free rows and cols after we're done with them.
7346 (display_risk) New function.
7347 (display_directional) New function.
7348 (clac_r) Rewritten so that it stores all its results into its
7349 arguments, so it can be used for Spearman's correlation too.
7350 (calc_symmetric) Added a t[] argument, all references changed.
7351 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
7352 Pearson's r, Cohen's kappa.
7353 (calc_risk) New function.
7354 (calc_directional) New function.
7356 * som.c: (som_submit) Improved debugging code.
7358 * stats.c: (hypercube) New function.
7359 (cube) New function.
7361 (normal_sig) Went back to old implementation, which actually
7364 * stats.h: (macros square, cube, hypercube) Removed. The
7365 equivalent functions in stats.c are inlined here; all references
7366 to square changed to sqr.
7368 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
7370 * crosstabs.q: (N_SYMMETRIC) New define.
7371 (postcalc) Disable debug printing.
7372 (static vars chisq_fisher, pearson_r) New.
7373 (output_pivot_table) Add support for symmetric measures. Add
7374 chi-square output of exact sigs.
7375 (display_chisq) Rewritten.
7376 (display_symmetric) New function.
7377 (gamma_int) New function.
7379 (swap) New function.
7380 (calc_fisher) New function.
7381 (calc_chisq) Check boundary conditions better. Calculate Yates,
7382 Fisher, Mantel-Haenszel tests.
7383 (calc_r) New function.
7384 (calc_symmetric) New function.
7386 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
7388 (chisq_sig) Better boundary conditions. Renamed from
7391 * tab.h: (struct tab_table) New member cf.
7393 * tab.c: (tab_create) Set cf.
7394 (tab_width) New function.
7395 (tab_realloc) Handle cf.
7396 (tab_vline) Handle cf.
7397 (tab_hline) Handle cf.
7398 (tab_box) Handle cf.
7399 (tab_value) Handle cf.
7400 (tab_float) Handle cf.
7401 (tab_text) Handle cf.
7402 (tab_joint_text) Handle cf.
7403 (tab_offset) Handle cf.
7404 (tab_next_row) Handle cf.
7405 (evaluate_dimensions) Handle cf.
7406 (render_strip) Handle cf.
7408 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
7410 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
7411 output_pivot_table().
7412 (output_pivot_table) Moved lots of local variables outside and
7413 made them static. Add beginnings of chi-square statistic
7414 support. Now column and row totals aren't in the main matrix.
7415 Always zero out any leftover rows & columns after we're done with
7416 the table entries. Move all output stuff into
7417 display_dimensions(), display_crosstabs(), display_chisq().
7418 (display_dimensions) New function.
7419 (display_crosstabulation) New function.
7420 (display_chisq) New function.
7421 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
7423 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
7424 references, simplify logic.
7426 * postscript.c: Remove scale, translate-x, translate-y,
7427 mirror-horz, mirror-vert, rotate-180 options.
7428 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
7429 All references deleted.
7430 (macro YT) New macro.
7431 (array option_tab[]) Removed options.
7432 (ps_option) Removed options.
7433 (ps_open_page) Write page setup explicitly to output file, without
7434 using now-deleted BP function.
7435 (macro dump_line) Use YT().
7436 (macro dump_thick_line) Use YT().
7437 (draw_headers) Use YT().
7438 (switch_font) Reorder arguments to SF function.
7439 (write_text) Use YT().
7441 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
7444 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
7446 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
7447 null-debugging code.
7448 (tab_realloc) Remove null-debugging code. Initialize new regions
7450 (tab_vline) Support offsets.
7451 (tab_hline) Support offsets.
7452 (tab_box) Support offsets.
7454 (tab_nulls) Removed.
7457 (evaluate_dimensions) Remove null-debugging code. Understand
7458 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
7459 TAB_EMPTY not present.
7461 * tab.h: New cell attribute TAB_EMPTY.
7462 (macros tab_nr, tab_nc, tab_row, tab_col) New.
7464 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
7465 try to read them from system files.
7467 * vfm.c: (dump_splits) Don't call tab_null().
7469 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7471 * crosstabs.q: (struct crosstab) Added `missing' member.
7472 (custom_tables) Init missing.
7473 (calc_general) Handle missing values.
7474 (calc_chisq) New function.
7475 (output_pivot_table) Start work on chi-square output. Update for
7476 new tab offset support functions. Shorten statistic names.
7478 * Several files: add in more `const's to placate gcc's warnings.
7480 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7483 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7484 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7485 tab_joint_text) Add col_ofs and row_ofs support.
7486 (tab_offset) New function.
7487 (tab_next_row) New function.
7488 (tab_row) New function.
7489 (tab_col) New function.
7490 (tabi_table) Add col_ofs and row_ofs support.
7492 * vars-atr.c: (is_system_missing) New function.
7494 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7496 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7497 (static var no_cells) Removed.
7498 (static var num_cells) New.
7499 (static var expected) New.
7500 (static var cells[]) New.
7501 (internal_cmd_crosstabs) Deal with new variables.
7502 (postcalc) Removed most of the meat and put it in new function
7503 output_pivot_table().
7504 (output_pivot_table) Calculates and outputs an entire pivot table.
7506 * postscript.c: (postopen) Fix problems with free()ing addresses
7507 not obtained from malloc().
7509 * som.c: (som_submit) Add assertion.
7511 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7514 * tab.c: (static var tab_names[]) New.
7515 (tab_realloc) -1 for nc or nr indicates no change.
7516 (tab_nulls) New function.
7517 (tab_dim) Use tab_names[].
7518 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7519 (evaluate_dimensions) Don't terminate on uninited cells, just put
7520 an X in them and emit a notice. Use tab_names[].
7522 * tab.h: Move bits into tab.def.
7524 * tab.def: New. Don't try to declare tab_table_class because then
7525 som.h has to be included.
7527 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7529 * command.def: New file, contains all the command definitions
7530 previously included bodily in command.c.
7532 * format.def: New file, contains all of the format definitions
7533 previously split across format.h, format.c, and sfm-write.c.
7535 * lexer.h: Renamed from tokens.h in order to match corresponding
7538 * lexerP.h: Moved some rarely used functions exported by lexer.c
7541 * Makefile.am: Commemorate renamed files.
7542 (EXTRA_DIST) Add command.def, format.def.
7544 * command.c: [0] (walk_cmdtable_func) Removed.
7546 * crosstabs.q: (postcalc) Made it work and print out matrices
7548 (enum_column_values) Renamed enum_var_values, generalized for any
7551 * format.h: (struct fmt_desc) New member `spss'.
7553 * q2c.c: (main) Generated code includes lexer.h instead of
7556 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7557 instead of an independent translation table.
7559 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7561 * Lots of source files: Added const to declarations.
7563 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7565 * arena.c: (arena_clear) Set prev pointer to null when done.
7567 * ascii.c: (ascii_option) Rename index as indx.
7569 * avl.c: This is now a separate library called libavl.
7570 (xmalloc) Make static.
7571 (avl_probe) Step A7 can use the cache instead of an explicit
7573 (avl_delete) Don't maintain a q pointer because it's always
7574 available in the pointer stack. Comment fix.
7576 * avl.h: This is now a separate library called libavl.
7578 * command.c: (cmd_table[]) Remove spurious trailing "".
7580 * common.h: Only include random() fix if this system needs it.
7582 * crosstabs.q: Include alloca headers.
7583 (n_sorted_tab) New global var.
7584 (postcalc) Mostly rewritten.
7585 (find_pivot_extent) Rewritten.
7586 (enum_column_values) Rewritten.
7588 * data-out.c: (convert_F) Rename inner n as n_spaces.
7590 * error.c: (dump_message) Don't have an outer var i.
7592 * file-handle.q: (static var f) Removed. All references removed.
7593 (internal_cmd_file_handle) Uses a local variable instead of f.
7595 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7596 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7599 * getline.h: Declare getl_history as extern. Reported by
7600 palme@uni-wuppertal.de (Hubert Palme).
7602 * postscript.c: (postopen) Some large mods for constness.
7604 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7607 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7609 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7610 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7613 * avl.c, avl.h: New files. These form a clean-room
7614 reimplementation of avllib. Iterative algorithms are used in
7615 place of recursive ones, so there is no resemblance in the code.
7617 * Lots of headers: Don't include other headers by default.
7619 * Lots of source files: Explicitly include all needed headers.
7621 * arena.c: (arena_clear) New function.
7623 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7624 (static var ar) Removed.
7625 (staitc vars ar_tc, ar_col) New.
7626 (cmd_crosstabs) Destroy the arenas.
7627 (internal_cmd_crosstabs) Create the arenas.
7628 (precalc) Don't need a free function for the hash.
7629 (calc_general) Make sure to zero out the trailer on the key data
7631 (print_table_entries) Updated.
7632 (postcalc) Worked on actually implementing.
7633 (find_pivot_extent) New function.
7634 (compare_value) New function.
7635 (enum_column_values) New function.
7637 * data-in.c: (parse_month) Make local array `static const'.
7639 * data-out.c: (convert_date) Make local array `static const'.
7640 (convert_WKDAY) Same.
7641 (convert_MONTH) Same.
7643 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7644 been renamed to avl_walk().
7646 * hash.c: Rewritten more efficiently.
7648 * hash.h: Add attribute const to hsh_next_prime declaration.
7650 * lexer.c: (id_match) Make arguments const.
7652 * postscript.c: (ps_postopen_driver) Make default fonts the
7655 * q2c.c: (main) Generated code needs stdlib.h.
7657 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7658 initialized to 0 now, not to NULL. All other references to
7659 avl_traverser were updated in the same way.
7661 * tokens.h: Macro version of id_match updated to use const
7664 * val-labs.c: (inc_ref_count) New function.
7665 (copy_value_labels) Simply through use of new avl_copy() function.
7667 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7669 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7670 (postcalc) Worked on this.
7672 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7673 (struct ps_driver_ext) New line_width_thick member.
7674 (ps_preopen_drive) Init line_width_thick.
7675 (option_tab[]) Add line-* options.
7676 (ps_option) Parse line-* options.
7677 (postopen) Add line_width_thick support. Strip leading spaces on
7678 prologue output lines.
7679 (ps_open_page) Include line_width_thick in output.
7680 (macro dump_thick_line) New.
7681 (dump_fancy_line) Support thick lines as well as double lines.
7683 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7685 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7686 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7688 * Many source files: Rename `options' to `pv_opts' as appropriate.
7690 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7692 * common.c: (xcalloc) New function.
7694 * crosstabs.q: New file. Not finished yet, though.
7696 * data-list.c: Comment fix.
7698 * error.c: Remove some old Checker cruft.
7700 * frequencies.q: (dump_full) Cumulate valid percent instead of
7703 * getline.c: Comment fix.
7705 * hash.c: Comment fixes.
7707 * hash.h: (struct hsh_table) Make hash functions return unsigned
7708 instead of int to avoid problems with taking the modulo of
7709 negative return values. All references changed.
7711 * misc.c: (intlog10) Make its table static const instead of auto.
7713 * sfm-read.c: (read_header) Make `prefix' static const instead of
7716 * var.h: (union value) Add member `hash'.
7717 (struct variable) Rename prv_index as `foo'--all references
7719 (typedef pv_opts) Removed. All references changed.
7721 * vars-prs.c: (parse_variables) Message fixes.
7723 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7725 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7726 they are being inserted. Don't check for BY variables of
7727 different types. Discard variables if the active file isn't
7728 included in the merge.
7729 (mtf_processing) Essentially rewritten.
7730 (mtf_merge_dictionary) Check for master/slave variables of
7731 different types/widths.
7733 * vfm.c: (static var not_canceled) New var.
7734 (process_active_file) Don't call vfm_source->read() if
7735 there's no vfm-source. Initialize not_canceled.
7736 (process_active_file_write_case) Honor and update not_canceled.
7737 (prepare_for_writing) Rollback changes from yesterday, they were
7739 (close_active_file) Don't destroy vfm_source unless it exists.
7741 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7743 * Lots of source files: Added { } around nested if/else constructs
7744 to avoid new gcc 2.8 warnings.
7746 * data-in.c: (parse_Z) Declare `int' type explicitly.
7749 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7750 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7751 prev members. Put TABLEs at the end of the chain and FILEs at the
7752 beginning. Don't allow the active file in STATE_INIT. Use proper
7753 `seen' value for the active file. Fill out the by members and
7754 make sure they're of consistent type. Do the actual merge
7756 (mtf_processing_finish) New function.
7757 (var_type_description) New function.
7758 (mtf_free_file) New function.
7759 (mtf_free) Rewritten.
7760 (mtf_delete_file_in_place) New function.
7761 (mtf_read_nonactive_records) New function.
7762 (mtf_compare_BY_values) New function.
7763 (static var mtf_seq_no) New var.
7764 (mtf_processing) New function.
7765 (mtf_merge_dictionary) Assign nval members for the system file
7766 dictionary. Assign fv values for its variables. Point each slave
7767 variable to the corresponding master variable.
7769 * hash.c: Include str.h.
7771 * mis-val.c: (copy_missing_values) src arg is const.
7773 * misc.c: (spacing) Make `max' var explicitly int.
7775 * sfm-read.c: (dump_dictionary) Message reformatting.
7776 (sfm_read_case) Add assertion.
7778 * sort.c: Esthetic fixes.
7780 * var.h: (struct match_files_proc) New struct.
7781 (struct variable) Add private data match_files_proc.
7783 * vars-atr.c: (delete_variable) Implement. Add argument for the
7784 dictionary that owning the variable.
7785 (dup_variable) Add assertion.
7787 * vfm.c: Comment fixes, hopefully the comments are correct now.
7788 (process_active_file) New function.
7789 (process_active_file_write_case) New function.
7790 (process_active_file_output_case) New function.
7791 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7793 (write_case) Renamed procedure_write_case(). Now write_case is a
7794 pointer to a function. Style fixes.
7796 1998-03-05 Ben Pfaff <blp@gnu.org>
7798 * Makefile.am: (q2c) Link with libmisc.
7799 (version.c) Define default_config_path, include_path,
7802 * ascii.c: (ascii_postopen_driver) When the default newline string
7803 is requested, open file in text mode. Suggested by
7804 palme@uni-wuppertal.de (Hubert Palme).
7805 (static vars line_buf, line_p) Change from char * to unsigned char
7807 (ascii_close_page) char * to unsigned char *.
7809 * cmdline.c: (parse_command_line) Implement -r option by
7810 prepending ~/.pspp/rc to the list of files to process.
7812 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7813 before pulling in a final line.
7814 (null_func, null_int_func) Removed (dead code).
7816 * descript.q: (display) Calculate width of variable name column
7817 properly. Calculate number of valid cases properly. Reported by
7818 palme@uni-wuppertal.de (Hubert Palme).
7820 * filename.c: (init_filename) Use default_config_path instead of
7821 now obsolete CONFIG_PATH.
7823 * getline.c: (getl_initialize) Use include_path instead of now
7824 obsolete INCLUDE_PATH.
7825 (getl_add_file) New argument `where'. All references changed.
7827 * groff.c: (find_font_file) Use groff_font_path instead of now
7828 obsolete GROFF_FONT_PATH.
7830 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7831 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7832 avoid problems with constness.
7834 * str.h: (macro cs_streq) New macro.
7836 * version.h: (glob var default_config_path, include_path,
7837 groff_font_path) New vars.
7839 1998-02-23 Ben Pfaff <blp@gnu.org>
7841 * Many source files: Change verbose_msg() priority levels and
7844 * aggregate.c: Include debug-print.h.
7846 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7848 (static var pre_syntax_message) Document --safer/-s and
7851 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7853 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7854 because it's not used but it's still copied.
7855 (open_file_r) Remove gratuitous debug message.
7857 * filename.c: (safety_violation) New function.
7858 (open_file) Remove gratuitous debug messages. Don't allow pipe
7859 files if set_safer is set.
7861 * get.c: Turn off debugging.
7863 * getline.c: (getl_add_virtual_file) New function.
7864 (getl_read_line) Add verbose_msg() call for opening new syntax
7866 (getl_perform_delayed_reset) Add a return value describing whether
7867 any action was taken. Call reset_eof().
7869 * getline.h: Comment fix.
7871 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7872 place of incorrect `continue'. Use strtok_r() instead of
7873 strtok(). Always check strtok_r() return value.
7874 (groff_read_DESC) Use strtok_r() instead of strtok().
7876 * lexer.c: (reset_eof) New function.
7878 * main.c: (parse) Get a token after performing a delayed reset
7879 action; allow empty syntax files.
7881 * postscript.c: (output_encodings) Use strtok_r() instead of
7884 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7886 * set.q: Comment fixes.
7887 (glob var set_safer) New var.
7888 (internal_cmd_set) Support SAFER.
7890 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7892 * temporary.c: (free_dictionary) Set d->splits to NULL after
7895 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7896 variable deleted, not if it *isn't* deleted.
7898 1998-02-16 Ben Pfaff <blp@gnu.org>
7900 * command.c: (array cmd_table[]) Add MATCH FILES.
7902 * common.c: Comment fixes.
7904 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7905 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7906 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7909 * expr-opt.c: Include str.h. Problem reported by
7910 palme@uni-wuppertal.de (Hubert Palme).
7912 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7913 (static var mtf_by) Change from char ** to variable **.
7914 (static var mtf_master) New var.
7915 (mtf_merge_dictionary) New function.
7916 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7917 var type. Reorder tests properly. Initialize file->dict. Detect
7918 TABLE= without BY=. Read file dictionaries and merge them. Give
7919 subcommand name with IN, LAST, FIRST error messages. Create IN,
7920 LAST, FIRST variables. Comment fixes.
7921 (mtf_free) Don't free default_dict. Free mtf_master.
7923 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7925 (handle_line_buffer) Cast int to size_t in comparison to avoid
7928 * getline.h: Declare getl_mode extern.
7930 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7931 (groff_read_DESC) Make line_size a size_t.
7932 (match_tok) Parenthesize name to avoid macro expansion.
7934 * mis-val.c: (copy_missing_values) New function.
7936 * postscript.c: (postopen) Make buf_size a size_t.
7938 * sfm-read.c: (dump_dictionary) Make global from static. Print
7939 variable info in parts for easier debugging with Checker.
7941 * temporary.c: (copy_variable) Use copy_value_labels().
7942 (new_dictionary) New arg: whether to copy file label, documents.
7944 * val-labs.c: (copy_value_labels) New function.
7946 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7948 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7950 (dup_variable) Set prv_index, get.fv, get.nv.
7952 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7954 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7956 * Many source files: For ANSI-compliance, add empty statement
7957 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7958 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7960 * data-in.c: (parse_numeric) Some header files break on
7961 -DBL_MIN_10_EXP because they get a --; add () for safety.
7962 Reported by palme@uni-wuppertal.de (Hubert Palme).
7964 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7965 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7966 (dfm_close) Use close_file_ext.
7967 (open_inline_file) Set file.file to NULL, not file.
7968 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7969 struct and use open_file_ext().
7970 (read_record) Use file.file.
7972 * file-handle.q: (prepend_current_directory) Pass through special
7975 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7976 (normalize_filename) Pass through special filenames.
7977 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7979 (dirname) Rename blp_dirname() because of name conflict on some
7980 OS. All references changed. Reported by palme@uni-wuppertal.de
7982 (is_special_filename) New function.
7984 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7985 (trim_dictionary) Conditionalize some of the options on whether
7986 GTSV_OPT_MATCH_FILES is in *options.
7987 (rename_variables) Don't allow variables to be renamed as scratch
7989 (MTF_*) New enum series.
7990 (struct mtf_file) New struct.
7991 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7993 (cmd_match_files, mtf_free) New functions.
7995 * lexer.c: (match_int) Needed parentheses around name to escape
7996 macro expansion. Reported by Micah Altman
7997 <maltman@www-vdc.fas.harvard.edu>.
7999 * print.c: Needed to include alloca.h. Reported by Micah Altman
8000 <maltman@www-vdc.fas.harvard.edu>.
8002 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
8003 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
8006 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
8007 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
8009 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
8011 * html.c: (struct html_driver_ext) Move into htmlP.h.
8012 (html_preopen_driver) Initialize cp_x, cp_y.
8013 (html_submit) Implement as call to output_tab_table().
8014 (change_attributes) New function.
8015 (escape_string) New function.
8016 (output_tab_table) New function.
8018 * list.q: (write_all_headers) Add code for writing headers for the
8020 (clean_up) Write out the html close-table tag.
8021 (determine_layout) Ignore html driver.
8022 (list_cases) Write html data.
8024 * som.c: (som_submit) Move more of the code into output_table().
8026 * tab.c: (static var hit) Make a global var and rename tab_hit.
8027 (static var tab_table_class) Make a global var.
8029 * htmlP.h: New file.
8031 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
8033 * dump-sysfile.c: Removed.
8035 * html.c: (preclose) Change comment in emitted code.
8037 * matrix-data.c: Debugging off by default. Comment fixes.
8038 (static var container) New var.
8039 (cmd_matrix_data) Create and destroy container. Initialize
8040 is_per_factor[] to 0s. Move code into new function
8041 string_to_content_type(). Require split values to be present in
8042 the data when ROWTYPE_ is explicit. Call specific function, not
8043 general read_matrices().
8044 (string_to_content_type) New function.
8045 (context) Exclude all whitespace, not just spaces.
8046 (mget_token) A dot is a number. Add assertion.
8047 (static var data) Renamed nr_data.
8048 (static var factor_values) Renamed nr_factor_values.
8049 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
8050 only specific case. Close data_file before exit.
8051 (fill_matrix) New function.
8052 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
8053 printing. Style fixes. Message fixes. Move code into
8055 (read_matrices_without_rowtype) Rename
8056 matrix_data_read_without_rowtype(). Fix off-by-one error on
8057 loops. Allocate nr_data[] memory from arena.
8058 (read_matrices_with_rowtype) Removed.
8059 (read_splits) Renamed nr_read_splits(). Style fixes.
8060 (read_factors) Renamed nr_read_factors().
8061 (dump_cell_content) Comment fixes. Arguments changed. Change
8062 debug printing. All references changed.
8063 (output_data) Renamed nr_output_data().
8064 (static var wr_content) New var.
8065 (struct factor_data) New struct.
8066 (static var wr_data) New var.
8067 (static var wr_current) New var.
8068 (matrix_data_source_destroy_source) Removed.
8069 (read_matrices_with_rowtype) New function.
8070 (matrix_data_read_with_rowtype) New function.
8071 (wr_read_splits) New function.
8072 (compare_factors) New function.
8073 (wr_output_data) New function.
8074 (wr_read_rowtype) New function.
8075 (wr_read_factors) New function.
8076 (wr_read_indeps) New function.
8077 (glob var matrix_data_source) Make destroy_source member NULL as
8080 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
8082 * lexer.c: (syntax_error) Give better error message when at end of
8085 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
8086 N_SCALAR to output as plain N.
8087 (mdump_token) Change output format.
8088 (context) Fix message output interaction with spaces in input.
8089 (another_token) New function.
8090 (force_eol) Improved error message.
8091 (static var max_cell_index) New var.
8092 (read_matrices) Init `cells'. factor_values is now per-cell.
8093 Init max_cell_index.
8094 (read_data_lines) Replace `compare' local with new `compare' arg.
8095 Debugging messages changed. Only read factors if per_factor.
8096 Propagate error return from read_factors(), force_eol().
8097 Copy N_SCALAR values across the N vector.
8098 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
8099 check parentheses manually since we now have is_per_factor[].
8100 Call read_data_lines() with new args. Check for end of data after
8101 looping, using another_token().
8102 (read_factors) Arguments changed. Use max_cell_index to determine
8103 whether to read or compare factors. Message fixes.
8104 (dump_cell_content) New function.
8105 (output_data) Completely rewritten because content types were
8106 supported to be nested inside factor values, not vice versa.
8108 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
8110 * lexer.c: (syntax_error) Support formatted varargs messages.
8112 * matrix-data.c: Turn debugging on by default.
8113 (static content_type[]) New array.
8114 (static content_names[]) New array.
8115 (static rowtype_, varname_) New vars.
8116 (static is_per_factor[]) New array.
8117 (static split_values) Moved declaration.
8118 (static n_continuous, first_continuous) New var.
8119 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
8120 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
8121 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
8122 Check for continuous variables.
8123 [DEBUGGING] (debug_print) Remove content_names[].
8124 (mdump_token) New macro.
8125 (mget_token_dump) New function.
8126 (mdump_token) New function.
8127 (context) New function.
8128 (mget_token) Fix messages.
8129 (static var data, split_values, factor_values) New vars.
8130 (read_matrices) Manage split_values, factor_values.
8131 (read_data_lines) New function.
8132 (read_matrices_without_rowtype) Implemented.
8133 (read_splits) Message fixes. Uses `just_read'.
8134 (read_factors) New function.
8135 (output_data) New function.
8136 (matrix_data_source_destroy_source) Close the file handle.
8137 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
8140 * str.c: (strpadcmp) Removed.
8142 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
8144 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
8146 * Lots of source files: Add cast to unsigned character to calls to
8147 tolower() and toupper().
8149 * aggregate.c: Set default_dict.splits to NULL.
8151 * command.c: (static variable tab[]) Add MATRIX DATA.
8153 * data-in.c: Add debugging defines. Formatting fixes.
8155 * expr-opt.c: Formatting fixes.
8157 * lexer.c: (syntax_error) Message fixes.
8159 * matrix-data.c: New enum series.
8160 (static vars fmt, section, diag, explicit_rowtype, signle_split,
8161 split_values, n_factors, factors, cells, pop_n, contents,
8162 n_contents) New vars.
8163 (cmd_matrix_data) Finished implementation.
8164 (compare_variables_by_mxd_vartype) New function.
8165 [DEBUGGING] (debug_print) New function.
8166 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
8167 (read_matrices) New function.
8168 (read_matrices_without_rowtype) New function.
8169 (read_matrices_with_rowtype) New function.
8170 (read_splits) New function.
8171 (mget_token) New function.
8172 (force_eol) New function.
8173 [0] (test_tokenizer) New function.
8174 (matrix_data_source_destroy_source) New function.
8175 (glob var matrix_data_source) New var.
8177 * misc.h: Include ieeefp.h if present.
8179 * split-file.h: (cmd_split_file) Changes corresponding to struct
8182 * str.h: Fix memmem prototype.
8184 * temporary.c: (save_dictionary, restore_dictionary,
8185 free_dictionary) Changes corresponding to struct dictionary
8188 * var.h: (MXD_* enums) New enum series.
8189 (struct matrix_data_proc) New struct.
8190 (struct split) Removed.
8191 (struct dictionary) Changed `splits' member from `split *' to
8193 (macro force_create_variable) New macro. Replaced lots of
8194 create_variable()/assert() calls with calls to this macro.
8196 * vars-atr.c: (discard_variables) Changed assertion.
8197 [GLOBAL_DEBUGGING] (force_create_variable) New function
8198 called by the macro of the same name.
8199 (clear_variable) Changes to delete splits from the dictionary
8200 corresponding to struct dictionary changes.
8202 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
8203 corrupted variable `index' values in the dictionary passed in
8204 every time this function is called.
8206 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
8207 to struct dictionary changes.
8209 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
8211 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
8213 * command.c: New includes.
8214 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
8215 (cmd_erase) New function.
8216 [unix] (shell) New function.
8217 (run_command) New function.
8218 (cmd_host) New function.
8219 (cmd_new_file) New function.
8221 * expr-prs.c: (parse_primary) Message fix.
8223 * inpt-pgm.c: Formatting fix.
8224 (cmd_reread) Implement the FILE subcommand.
8226 * matrix-data.c: New file.
8228 * q2c.c: (dump_header) Change output commenting style.
8230 * weight.c: Comment fix.
8232 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
8234 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
8236 (buf_10x) Renamed buf_1xx, all references changed.
8237 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
8238 cases now implemented).
8239 (create_sysfile) New function.
8240 (agr_11x_func) New function.
8242 * data-in.c: (parse_numeric) Work properly if there's an
8243 explicitly coded decimal point in the data and decimal places are
8244 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
8245 <el@linux.lisse.na>.
8247 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
8248 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
8249 Eberhard W Lisse <el@linux.lisse.na>.
8251 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
8252 strerror.c. Bug reported by Alexandre Oliva
8253 <oliva@dcc.unicamp.br>.
8255 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
8256 (static var separate_case_tab) New var.
8257 (cmd_sort_cases) Cancel temporary transformations here. Free
8258 v_sort before return.
8259 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
8260 we're reading from a sort stream. Don't cancel temporary
8261 transformations. Offload internal sorting to do_internal_sort().
8262 (do_internal_sort) New function. Handles internal sorting even
8263 when SEPARATE is nonzero. Doesn't free v_sort.
8264 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
8266 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
8267 sink if SEPARATE is zero.
8268 (read_output_cases) Renamed read_sort_output(), all references
8269 changed. Now uses separate_case_tab when it exists.
8270 (write_separate) New function.
8272 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
8273 memory_sink_cases. Don't redundantly call
8274 vfm_source->destroy_source().
8275 (memory_stream_mode) After switching over, set memory_sink_cases
8278 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
8280 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
8282 (static var prev_case) New, moved out of aggregate_single_case()
8284 (static var buf64_10x, buf_10x) New.
8285 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
8286 the 000, 001, 100, and 101 cases. Free prev_case.
8287 (parse_aggregate_functions) Disallow scratch variables.
8288 (free_aggregate_functions) Only free agr_dict if non-null. Use
8289 iter->function to determine numeric/string type, not
8291 (aggregate_single_case) Don't manage prev_case. Initialize
8292 aggregate info after dumping it.
8293 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
8294 mean, stddev, weighted stddev definitions.
8295 (dump_aggregate_info) Implemented.
8296 (initialize_aggregate_info) Renamed from
8297 initialize_aggregate_functions(). Initializes dbl[2].
8298 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
8299 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
8301 * cases.c: (alloc_val) Removed.
8303 * get.c: (cmd_save_internal) Initialize new `dict' member.
8305 * sfm-write.c: (sfm_write_dictionary, write_header,
8306 write_variable, write_value_labels, write_documents) Reorganize,
8307 simplify for new parameter structure.
8308 (write_variable) Only one variable * argument now.
8310 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
8311 replaced by new `dict' member.
8313 * temporary.c: (new_dictionary) Initialize n_documents.
8315 * vars-atr.c: (dup_variable) Allocate `value's from dict into
8317 (init_variable, replace_variable) Eliminate usage of alloc_val().
8319 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
8321 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
8322 signal that AGGREGATE is to be used for forming final cases.
8323 (close_active_file) Call end_func before stopping lagging. Cancel
8324 temporary after finishing compaction.
8325 (write_case) Comment fixes. Cleaned up.
8326 (compact_case) Let AGGREGATE handle compaction when `temporary' is
8329 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
8331 * Makefile.am: (BUILT_SOURCES) Add means.c.
8332 (pspp_SOURCES) Add means.c.
8333 (EXTRA_DIST) Add means.q.
8335 * command.c: (array cmd_table[]) Add MEANS.
8337 * common.h: Esthetic fixes. Comment fixes. Test for
8338 MAX_SHORT_STRING greater than 8.
8339 (macros LOWEST, HIGHEST) New.
8341 * data-in.c, data-list.c, recode.c: Comment fixes.
8343 * means.q: New file, base version.
8345 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
8346 with LOWEST, DBL_MAX with HIGHEST.
8348 * q2c.c: (dump_vars) Add an enum to array types giving the number
8349 of values for the enum.
8351 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
8352 Replace second_lowest_value with second_lowest_flt64.
8354 * sfm-write.c: (write_variable, write_rec_7_34) Replace
8355 second_lowest_value with second_lowest_flt64.
8357 * t-test.q: Comment fix.
8359 * temporary.c: (restore_dictionary) Esthetic fix.
8361 * tokens.h: (force_match_id, force_match, force_string, force_int,
8362 force_num, force_id) Replace msg() with syntax_error().
8364 * var.h: (struct means_proc) New.
8365 (struct variable) Add mns member to `p' union.
8367 * vars-prs.c: (parse_variable, parse_dict_variable,
8368 parse_variables, parse_DATA_LIST_vars) Replace msg() with
8371 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
8373 * Makefile.am: (pspp_SOURCES) Add tab.h.
8375 * Most source files: Added a cast to unsigned char in usages of
8376 the ctype is*() functions. Replaced `end of command expected'
8377 calls to msg() with calls to syntax_error().
8379 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
8381 * lexer.c: (hex_val) Removed (was dead code).
8382 (idmatch) Parenthesize function name to avoid macro expansion.
8384 * postscript.c: Comment fixes.
8385 (ps_preopen_driver) Change default font size to 10pt.
8387 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
8389 (parse_format_spec) Change system-file format spec argument type
8390 to int32. Parse the format spec with bitwise operators.
8392 * sfmP.h: (struct sysfile_format) Removed.
8393 (struct sysfile_variable) Changed print, write members from
8394 sysfile_format to int32.
8396 * tokens.h: Esthetic fixes.
8397 [__GNUC__] (macro id_match) New macro to hopefully speed up
8398 identifier matching.
8399 (macros match_id, match_tok, match_int) Implemented in
8400 compiler-independent manner; no longer GNU C only.
8402 * vfm.h: Include time.h.
8404 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
8406 * data-list.c: (dump_fixed_table) Change tab_dim().
8408 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
8410 * error.c: Include command.h.
8412 * frequencies.g: Formatting fixes.
8414 * frequencies.q: Add tab_dim() calls. Make the total cell a
8417 * glob.c: Include command.h.
8419 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
8421 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
8422 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
8423 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
8424 the other elements (is this right?).
8425 (read_variables) Use lowest, highest members.
8426 (parse_format_spec) New arg `vv' for more stringent checking.
8427 (dump_dictionary) Byteswaps nonexplicit data.
8428 (sfm_read_case) Byteswap numeric data.
8430 * som.c: Initialize table_num to 1.
8431 (render_segments) Remember to increment y_index after each table
8434 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
8435 avl_count() on a NULL tree. No title for the second table.
8436 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
8437 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
8438 fix call to display_variables().
8439 (display_variables) Default to 4 columns, not 3. Set up headers.
8440 Column title is Variable, not Name. Fix index column.
8441 Add joint text. Add tab_dim(). Handle value labels properly.
8442 Handle DISPLAY LABELS properly. Draw boxes correctly.
8443 (describe_variable) Value labels don't need titles. Don't clear
8444 nonexistent index column.
8445 (compare_vectors_by_name) New function.
8446 (display_vectors) New function.
8448 * tab.c: (tab_height) Add assertion.
8449 (tab_null) Add debug code.
8450 (evaluate_dimensions) Add debug code.
8452 * var.h: (struct variable) get_proc data is sometimes used
8453 simultaneously with other per-procedure info, therefore it was
8454 removed from the union. All references changed.
8456 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
8458 * ascii.c: (ascii_close_page) Put title on second line of headers
8459 if there is no subtitle.
8461 * command.c: (glob var cur_proc) Move definition here, from
8463 (cmd_remark) Emit blank line before remarks.
8465 * command.h: (glob var cur_proc) Move declaration here, from
8468 * data-list.c: (dump_fixed_table) Fix messages.
8469 (dump_free_table) Call tab_nat_dim().
8471 * descript.q: (dump_z_table) Modify tab_dim() call.
8473 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8475 (dump_statistics) Don't output header.
8477 * groff-font.c: Minor format fix.
8479 * html.c: Comment fix.
8481 * list.q: (write_varname) Indent after advancing page.
8483 * output.h: Minor reordering.
8485 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8486 a reference to eol[].
8487 (struct ps_driver_ext) New member eol[].
8488 (ps_preopen_driver) Initialize eol[].
8489 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8490 defaults. Handle headers. Fix test for minimum page length.
8491 (static var option_tab[]) Add `line-ends'.
8492 (ps_option) Handle line-ends to change eol[].
8493 (postopen) Scale prop_em_width and fixed_width properly. Set the
8494 prologue title to outp_title if applicable. Replace the prologue
8495 line ends with eol[]. Call draw_headers() if headers are enabled.
8496 (text_width) New function.
8497 (out_text_plain) New function.
8498 (draw_headers) New function.
8500 * print.c: (dump_table) Call tab_nat_dim().
8502 * som.c: (som_blank_line) Only advance a line if not at the top of
8504 (som_submit) Move several informational table calls here.
8505 Increment subtable_num if SOMF_NO_TITLE not set.
8506 (output_table) Advance a line if SOMF_NO_SPACING not set.
8507 (render_columns, render_segments, render_simple) Handle spacing
8508 between tables. Handle table titles. Remove debug output.
8510 * som.h: (SOMF_*) New enum series.
8511 (struct som_table_class) New member `flags'.
8513 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8515 (display_variables) Calls tab_nat_dim().
8516 (describe_variable) Remove restriction on number of value labels.
8517 Make value labels separated by thin lines.
8519 * tab.c: (tab_create) Default `flags' to none.
8520 (tab_float) New arg `w'. All references changed.
8521 (tab_nat_dim) New function.
8522 (tab_output_text) No title or spacing.
8523 (tab_flags) New function.
8524 (tabi_flags) New function.
8525 (tabi_title) New function.
8526 (strip_height) Removed.
8527 (tabi_render) Skip title when necessary.
8528 (static var tab_tab_class) Add tabi_flags, tabi_title.
8529 (evaluate_dimensions) Disable display of column, row size.
8530 (sum_columns) Add title height to top header.
8531 (render_strip) Moved within file.
8533 * tab.h: (struct tab_table) New member `flags'.
8535 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8537 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8539 * Most source files: Add `const' attribute in all appropriate
8542 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8543 column to the variables table for use by describe_variable().
8544 (cmd_display) Disable for the present.
8545 (display_documents) Don't wrap documents.
8546 (display_variables) Table has four columns now.
8547 (describe_variable) Table has four columns now. Don't use a
8548 subtable, use joined cells instead.
8550 * tab.c: (tab_create) Don't set `join'.
8551 (tab_realloc) ct array is not made up of a_string's.
8552 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8553 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8554 (text_format) New function.
8555 (tab_title) Rewritten, uses text_format().
8556 (tab_text) Rewritten, uses text_format().
8557 (tab_joint_text) New function.
8559 (static var hit) New variable.
8560 (render_strip) New args r1, r2. Implement joined cells that fit
8562 (tabi_render) Increment hit. Pass new args to render_strip().
8563 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8564 cells. For t_naw and t_nah, ignore joined cells and null cells in
8567 * tab.h: (struct tab_join_rect) Removed.
8568 (struct tab_table) Removed `join'.
8569 (TAB_JOIN_MAIN) Removed.
8570 (struct tab_joined_cell) New struct.
8571 (TAT_NOWRAP) New enum.
8573 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8575 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8577 (ascii_postopen_driver) Fix initialization of *_spacing so that
8578 the TAL_0 bit doesn't count.
8580 * data-list.c: (dump_fixed_table) Use natural width for Format
8583 * glob.c: (rerange) Removed.
8584 (get_date) Formatting fixes. Internationalization fix.
8586 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8589 * postscript.c: (ps_postopen_driver) Replace
8590 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8592 * som.c: (som_submit) Don't eject page before every table.
8593 (output_table) Fix order of arguments on call to area().
8594 (render_columns) Fix calculation of max_len.
8596 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8597 (render_strip) New function.
8598 (strip_height) New function.
8599 (tabi_render) Rewrite as calls to render_strip().
8601 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8602 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8603 with the TAB_* and OUTP_T_* constants.
8605 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8607 * Makefile.am: Formatting fixes.
8609 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8612 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8614 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8616 * dump-sysfile.c: (glob var length) Make type off_t.
8617 (usage) Fix arguments.
8620 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8621 Now right-justification is the default so many references had to
8623 (struct outp_class) Removed line_width, all references changed.
8624 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8625 (struct outp_driver) Add elements horiz_line_width,
8626 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8629 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8631 (postopen) Initialize all the informational members of
8634 * som.c: (som_blank_line) New function, renamed from blank_line(),
8635 all references changed.
8636 (som_submit) Disables drivers whose pages can't be opened.
8637 (render_columns, render_simple, render_segments) Add debug output.
8638 (render_columns) Fix loop range.
8639 (render_simple) Don't try to render the headers, they're taken
8640 care of automatically. Advance cp_y past the table when done.
8641 (render_segments) Fix loop ranges.
8643 * tab.c: Initialize new members of tab_table.
8644 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8645 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8646 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8649 (tab_dim) New function.
8650 (tab_col_width) Removed.
8651 (tab_row_height) Removed.
8652 (tab_output_text) Call tab_dim().
8653 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8654 (tabi_area) Implemented.
8655 (tabi_cumulate) Implemented.
8656 (tabi_render) Partially implemented, but broken.
8657 (var tab_table_class) Made static.
8658 (evaluate_dimensions) New function.
8659 (sum_columns) New function.
8661 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8662 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8663 t_scr, t_srr, t_sentinel. Removed: t_nat.
8664 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8665 max_stack_height, w, h. Removed: ce, re.
8666 (macro blank_line) Removed.
8667 (glob var zero_length) Removed.
8669 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8671 * Most source files: include some of the new include files broken
8674 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8677 * aggregate.c: (glob var outfile) Make static.
8679 * command.c: (glob var pgm_state) Move here.
8681 * common.c: (glob vars endian, second_lowest_value, pgmname,
8682 finished, curdate, cur_proc, start_interactive, history_file) Move
8685 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8687 * file-handle.q: (glob vars files, inline_file) Move here.
8689 * glob.c: Lost lots of glob vars, detailed in individual file
8691 (init_glob) set_printer, set_screen were obsolete, deleted.
8692 set_cprompt has fewer spaces because pspp has fewer letters than
8695 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8696 (inp_nval) Made static.
8698 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8699 tokstr_len, toklongstr, tokint) Move here.
8701 * misc.c: Lost several vars and functions.
8703 * set.q: (all the set_* variables) Move here.
8705 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8706 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8709 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8711 * tab.h: (enum series t_*) New enums.
8712 (struct tab_table) Use arena struct tag. New members ce, re.
8714 * tokens.h: Comment fixes.
8716 * var.h: Move lots of enums and variables and functions and
8717 structures to other files. Use and declare a lot more union and
8718 struct tags. Comment fixes.
8720 * vector.c: (glob vars vec, nvec) Move here.
8722 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8723 init_blanks, last_vfm_invocation) Move here.
8725 * cases.h: New file.
8726 (struct long_vec) Move here.
8727 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8730 * command.h: New file.
8731 (STATE_* enums) Move here.
8732 (glob var pgm_state) Move here.
8734 * format.c: New file.
8735 (glob var formats) Move here.
8736 (parse_format_specifier_name, fmt_to_string,
8737 check_input_specifier, check_output_specifier,
8738 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8741 * format.h: New file. Move functions now in format.c here.
8742 (FMT_* enums) Move here.
8743 (struct fmt_desc) Move here.
8744 (FCAT_* enums) Move here.
8745 (struct fmt_spec) Move here.
8746 (glob vars formats, fmt_parse_ignore_error) Move here.
8748 * inpt-pgm.h: New file.
8749 (INP_* enums) Move here, make #defines into enums.
8750 (glob vars inp_init, inp_init_size) Move here.
8753 (glob vars v_sort, nv_sort) Move here.
8754 (sort_cases, read_sort_output) Move here.
8756 * vector.h: New file.
8757 (struct vector) Move here, add struct tag.
8758 (glob vars vec, nvec) Move here.
8759 (find_vector) Move here.
8762 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8763 reinit_blanks, init_zero, init_blanks) Move here.
8764 (struct case_stream) Move here.
8765 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8766 vfm_disk_stream, sort_stream, data_list_source,
8767 input_program_source, file_type_source, get_source, n_lag) Move
8769 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8772 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8774 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8775 (LDADD) Add libdcdflib.
8777 * ascii.c: Comment and formatting fixes. Almost every external
8778 function had an assert added, checking driver_open and page_open.
8779 (ascii_init_driver) Broken into ascii_preopen_driver,
8780 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8781 (ascii_open_page) Sets page_open.
8782 (ascii_close_page) Clears page_open.
8784 * html.c: Comment and formatting fixes. Almost every external
8785 function had an assert added, checking driver_open and page_open.
8786 (html_init_driver) Broken into html_preopen_driver,
8787 html_postopen_driver, html_close_driver. Manages driver_open.
8788 (html_open_page) Sets page_open.
8789 (html_close_page) Clears page_open.
8790 (html_submit) Disabled.
8792 * lexer.c: (parse_string) Remove debugging printf.
8794 * list.q: (determine_layout) Open a page if one is not yet open.
8796 * output.c: Comment fixes.
8797 (add_class) Set the class member of the new list element.
8798 (parse_options) Don't handle device type.
8799 (colon_tokenize) New function.
8800 (configure_driver) New four-field format with a field for device
8801 type. Now initialize driver_open, page_open, next, and prev
8802 fields. Use new colon_tokenize() function. Don't do a memory
8803 copy to replace a driver, it doesn't work; instead delete the old
8804 driver and insert a new one.
8805 (destroy_driver) Don't call som_destroy_driver(). Close the page
8806 if it's open. Find the class in the list of classes and decrement
8807 that reference count. Remove the driver from the global driver
8809 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8810 references changed. Rewritten. Don't return a driver that's not
8812 (outp_eject_page) All references to som_internal_eject_page()
8813 changed to use this. Sets cp_x to 0 as well as cp_y.
8815 * output.h: (OUTP_I_* enums) Removed.
8816 (struct som_submission_form) Removed.
8817 (struct outp_class) init_driver broken into preopen_driver,
8818 postopen_driver, and close_driver. submit changed to take a
8821 * postscript.c: Comment and formatting fixes. Almost every
8822 external function had an assert added, checking driver_open and
8824 (ps_init_driver) Broken into ps_preopen_driver,
8825 ps_postopen_driver, ps_close_driver. Manages driver_open.
8826 (ps_open_page) Sets page_open.
8827 (ps_close_page) Clears page_open.
8829 * som.c: New file, base implementation.
8831 * som.h: (struct som_table) Add struct tag.
8832 (enum SOM_COL_ACROSS) Removed.
8833 (SOM_ROWS, SOM_COLUMNS) New enums.
8834 (struct som_table_class) Add member `cumulate'. Remove `segment';
8835 change `render' arguments.
8836 (struct som_point, struct som_rect) Removed.
8837 (som_submit_table) Fixed typo, should have been som_submit.
8839 * sysfile-info: (describe_variable) Don't try to insert a
8840 subtable; just destroy it for now.
8842 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8843 references to value labels.
8845 * tab.c: (tab_destroy) New function.
8846 (tab_columns) Change argument.
8847 [0] (tab_submit) Remove dead code.
8848 (tab_title) Allocate string from the table's arena.
8849 (tab_output_text) Only free the buffer if we allocated it.
8850 (tab_submit) New function.
8851 (static vars t, d) New static vars.
8852 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8853 tabi_headers, tabi_cumulate, tabi_render) New functions.
8854 (glob var tab_table_class) New global var.
8856 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8857 encapsulate the rectangle. All references changed.
8859 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8861 * All header files updated to use struct tags in addition to
8862 typedefs for all structures. Don't use word `struct' in struct
8865 * Makefile.am: (pspp_SOURCES) Remove html.c.
8866 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8867 all references updated.
8869 * command.c: (parse_cmd) Remove call to som_check_workspace.
8870 (output_line) Update to new som.
8872 * data-in.c: (parse_numeric) A single dot is not an error; it is
8873 the system-missing value.
8875 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8878 * data-out.c: Added `const' as appropriate to many prototypes.
8879 (convert_E, convert_F, convert_CCx) Take double argument instead
8880 of value * argument.
8881 (convert_format_to_string) Call changed functions appropriately.
8882 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8883 make a local copy of the value.
8885 * descript.q: Remove custom_variables() prototype now provided by
8887 (custom_variables) Don't increment sbc_variables, the caller does
8889 (dump_z_table, display) Update to new som.
8891 * error.c: (vmsg) Add const to prototype. Remove code to handle
8892 `too many errors' condition.
8893 (check_error_count) New function.
8894 (msg) Add const to prototype.
8896 * filename.c: (open_file) Rewrite for elegance.
8898 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8899 (dump_full, dump_condensed, dump_statistics) Update for new som.
8901 * list.q: Don't include somP.h. Change all references to
8902 som_driver_ext to refer to the new members of som_driver. Change
8903 som_internal_eject_page() references to outp_eject_page().
8905 * main.c: (parse) Rewrite for elegance. Add call to
8906 check_error_count().
8908 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8909 Rewrite or revise for new outp_driver_class_list structure.
8910 (outp_iterate_enabled_drivers) Fix comparison between disabled
8911 devices and current device type.
8912 (outp_eject_page) New function.
8914 * output.h: Comment fixes.
8915 (struct outp_driver) New members driver_open, page_open, cp_x,
8916 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8918 (struct outp_driver_class_list) New struct.
8919 (outp_class_list) Changed to type outp_driver_class_list; all
8922 * print.c: (dump_table, print_trns_proc) Updated for new som.
8924 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8925 prototypes for custom subcommands.
8926 (dump_subcommand) Always include the `else'.
8927 (dump_parser) Fix comments in output code.
8929 * set.q: Reordered functions.
8931 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8933 * som.h: Rewritten from scratch.
8935 * str.h: Remove dead code.
8937 * tab.c, tab.h: New files, base implementation.
8939 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8942 * t-test.q: New code from John Williams
8943 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8944 Many many new static vars and defines.
8945 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8946 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8947 (struct value_list) New struct.
8948 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8949 t_crt, t_sig, print_t_groups) New functions.
8950 (cmd_t_test) Implemented.
8952 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8955 * vfm.c: (dump_splits) Update to new som.
8957 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8959 * Makefile.am: (fiasco_SOURCES) Add html.c.
8961 * aggregate.c: Base source.
8963 * ascii.c: (postopen, preclose) Reformat.
8965 * data-out.c, expr-evl.c: Comment fixes.
8967 * filename.c: (open_file) When opening a file for writing, use
8968 line buffering instead of full buffering for better interactive
8969 performance. Suggested by Valerio Aimale
8970 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8971 names `stdin', `stdout', `stderr'.
8973 * groff-font.c: Comment fixes.
8975 * html.c: New file; base version.
8977 * list.q: (write_all_headers, clean_up, determine_layout,
8978 list_cases) Ignore `special' devices for now. Needs to be fixed
8981 * output.c: (outp_init) Add html driver to list; reverse list
8984 * output.h: (struct outp_class_struct) New members `special',
8985 `submit'; comment fixes. All references changed.
8987 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8988 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8990 (postopen) Comment fix.
8991 (preclose) Comment fixes, formatting fixes. Change x->file.file
8992 references to more proper f->file.
8994 * som-high.c: (som_submit_table) Special classes use their own
8997 * som.h: Comment fixes.
8999 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
9002 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
9004 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
9006 * aggregate.c: Still working on this.
9008 * command.c: (cmd_table[]) Add AGGREGATE back in.
9009 (split_words) Make '-' a legal word separator as well as ' '.
9011 * main.c: Comment fixes.
9013 * q2c.c: (dump_parser) Don't require the procedure's full name to
9014 be present, in the generated source.
9016 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
9017 multiply specified and let it be default; let MISSING, CRITERIA,
9018 FORMAT be multiply specified.
9019 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
9020 (custom_groups) Fix defaults.
9021 (custom_pairs) Check whether this is a PAIRS subcommand before
9022 attempting to parse. Better garbage collection. Proper storage
9024 [DEBUGGING] (debug_print) New function.
9026 * temporary.c: Comment fixes.
9027 (copy_variable) Don't copy variable name and index.
9028 (save_dictionary) Copy variable name and index by hand.
9030 * vars-atr.c: Comment fixes.
9031 (create_variable) New dictionary argument. All references
9033 (common_init_stuff) New dictionary argument. All references
9035 (init_variable) New dictionary argument. All references changed.
9036 (dup_variable) New function.
9038 * vars-prs.c: (parse_variables) If there are any errors, we always
9039 return 0. Previously, it was possible for some types of errors to
9042 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
9044 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
9047 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
9049 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
9052 * q2c.c: Comment fixes.
9053 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
9055 * t-test.q: (cmd_list) Rename cmd_t_test.
9057 * temporary.c: (new_dictionary) Don't declare as static.
9059 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
9061 * aggregate.c: Changes, still not finished.
9063 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
9065 * q2c.c: Comment fixes. Now its output is internationalized.
9066 (get_token) Fix parsing of escapes within literal strings.
9067 (main) Fix bad #line directives in output.
9069 * t-test.q: Base implementation.
9071 * temporary.c: (new_dictionary) New function.
9072 (restore_dictionary) [__CHECKER__] Change fill character to *
9075 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
9077 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
9079 * aggregate.c: Changes, still not finished.
9081 * descript.q, list.q: Comment fixes.
9083 * q2c.c: Almost completely rewritten.
9085 * t-test.q: New file, not complete.
9087 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
9089 * aggregate.c: Changes, still not finished.
9091 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
9094 * temporary.c: (cancel_temporary) New function.
9096 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
9097 of doing it by hand.
9099 * vfm.c: (close_active_file) After restoring a TEMPORARY
9100 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
9102 (SPLIT_FILE_procfunc) Comment fix.
9104 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
9106 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
9108 * aggregate.c: New file, not finished yet.
9110 * command.c: (cmd_table) Add AGGREGATE.
9112 * common.h: (pgm_state) Move declaration to var.h.
9114 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
9116 (parse_string) Message fix.
9118 * recode.c: Comment fix.
9120 * sfm-read.c: (read_variables) Code esthetic fixes.
9121 (write_header) Default date is `Jan', not `JAN'.
9123 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
9125 * sort.c: (cmd_sort_cases) Farm the work out to new function
9126 parse_sort_variables().
9127 (parse_sort_variables) New function.
9128 (sort_cases) New function. Cancels temporary transformations,
9129 which sorting didn't do previously.
9130 (cmd_sort_cases) Better garbage collection on error. Uses
9132 (write_initial_runs, merge_once) Improved code esthetics.
9133 (sort_stream_read) Reduced to one call to read_output_cases().
9134 (read_output_cases) New function.
9136 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
9137 variable labels to 120 characters.
9139 * var.h: Comment fixes.
9140 (glob var pgm_state) From common.h.
9142 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
9144 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
9145 options. Set *names to NULL on error.
9147 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
9149 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
9151 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
9152 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
9154 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
9156 * vfm.c: (page_to_disk) Added missing local variables.
9158 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
9160 * get.c: Comment fix.
9162 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
9163 source is anything other than a disk stream, not just if it's in a
9164 memory stream. Call page_to_disk() before external sort.
9165 (allocate_cases) Message fix.
9167 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
9169 (page_to_disk) New function.
9171 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
9173 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
9175 * common.h: (macro strerror) Remove. From Alexandre Oliva
9176 <oliva@dcc.unicamp.br>.
9178 * get.c: (dict_delete_run) The number of variables to delete is
9179 not necessarily the number of variables that need to be shifted
9181 (trim_dictionary) Don't set *options to 0. Fix bug that caused
9182 too many variables to be deleted.
9184 * postscript.c: Comment fix.
9186 * q2c.c: Include strerror.c. From Alexandre Oliva
9187 <oliva@dcc.unicamp.br>.
9189 * set.q: #undef ON and OFF. From Alexandre Oliva
9190 <oliva@dcc.unicamp.br>.
9192 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
9193 early, otherwise errors cause a bad free().
9195 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
9196 Oliva <oliva@dcc.unicamp.br>.
9198 * temporary.c: (save_dictionary) Don't allocate memory if
9201 * vfm.c: (memory_stream_write) Message fix.
9203 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
9205 * command.c: (static var cmd_table[]) Define REPEATING DATA
9208 * common.h: Added support for broken systems that are missing
9209 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
9211 * Many source files: Replace syntax error messages via msg() with
9212 call to syntax_error().
9214 * data-list.c: (dump_fixed_table) Add support for dumping table
9215 for REPEATING DATA as well as DATA LIST FIXED.
9216 (cmd_repeating_data) Allows and requires `/' between subcommands.
9217 Does proper thing with allowing rpd.starts_end to stay 0. Allows
9218 CONTINUED specifications to be omitted. Forces CONTINUED to be
9219 specified if ID is. Calculates starts_end, cont_end from logical
9220 record length as reported by fhp. Calls dump_fixed_table() if
9221 requested. Fixed length of record copied by memcpy.
9222 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
9224 (realize_value) Returns sensible value for out-of-range variable
9226 (rpd_parse_record) New argument `ofs'. Fixed confusion between
9227 length of occurrences and length of line. Added warning for
9228 fields that exceed the line length. Fixed infinite loop.
9229 (read_one_set_of_repetitions) Numerous minor changes for more
9230 complete SPSS compliance. Message fixes.
9232 * dfm.c: (dfm_close) If the file being closed is the inline file,
9233 read all the remaining data before closing it.
9234 (dfm_get_record) Don't close the file on lossage, as either it
9235 has been closed already or it doesn't belong to us.
9237 * error.c: (puts_stdout) New function.
9238 (vmsg) Use puts_stdout instead of puts.
9240 * file-handle.q: (fh_record_width) New function.
9242 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
9245 (input_program_source_read) Made an old kluge an approved method.
9247 * lexer.c: (syntax_error) New function.
9249 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
9252 * output.c: (oupt_get_paper_size) Message fix.
9254 * q2c.c: Numerous fixes to formatting of generated code made to
9255 conform to GNU coding standards. Uses syntax_error() in generated
9256 code. Other miscellaneous generated message fixes. Added support
9257 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
9258 RAND_MAX, and/or strerror().
9260 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
9262 * data-in.c: Comment fixes.
9264 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
9265 (find_variable_input_spec) New function.
9266 (cmd_repeating_data) Initializes id_spec.
9267 (rpd_parse_record) Implemented.
9268 (read_one_set_of_repetitions) Returns -3 by default in order to
9269 kluge out some potential bugs.
9271 * data-out.c: Comment fixes.
9273 * file-type.c: (internal_cmd_record_type) Message fix.
9275 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
9276 for handling -3 return value.
9278 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
9280 * data-list.c: Comment fixes.
9281 (struct dls_var_spec) Reordered members.
9282 (read_from_data_list_fixed) Restructured.
9283 (struct repeating_data_trns) Reordered members. Renamed `starts'
9284 as `starts_beg', `ends' as `starts_end'.
9285 (cmd_repeating_data) Calculates length of repeated data if
9286 necessary and possible.
9287 (parse_num_or_var) Don't allow string variables.
9288 (realize_value) New function.
9289 (rpd_msg) New function.
9290 (rpd_parse_record) New function. Currently stubbed out.
9291 (read_one_set_of_repetitions) Implemented.
9293 * inpt-pgm.c: (input_program_source_read) Comment fix.
9295 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
9297 * command.c: (cmd_end_repeat_p) Removed.
9298 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
9299 (parse_cmd_name) Removed.
9301 * data-list.c: Comment fixes.
9302 (data_list_pgm) Removed `eof' member.
9303 (static var first) New var.
9304 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
9305 FILE TYPE file inside FILE TYPE structures.
9306 (append_var_spec) Appends to *first, not dls.spec.
9307 (parse_fixed) Message fixes.
9308 (struct rpd_num_or_var) New.
9309 (struct repeating_data_trns) New.
9310 (static var rpd) New.
9311 (cmd_repeating_data) New function.
9312 (parse_num_or_var) New function.
9313 (parse_repeating_data) New function.
9314 (read_one_set_of_repetitions) New function.
9316 * file-type.c: (cmd_file_type) Message fixes. Always
9317 default_handle to FILE TYPE file handle.
9318 (internal_cmd_record_type) Message fixes.
9320 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
9322 * repeat.c: Comment fix. Disable debugging.
9324 * temporary.c: (restore_dictionary) Sets splits to NULL and
9325 n_splits to 0 before destroying the variables because now doing
9326 this tries to remove split variables.
9328 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
9329 destroying the dictionary.
9330 (clear_variable) Removes a variable from splits after destroying
9333 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
9335 * cmdline.c: (set_compat) Removed.
9336 (pick_compat) Removed.
9337 (parse_command_line) Removed -c option.
9338 (pre_syntax_message) Removed -c option.
9339 (usage) Remove compatibility code.
9341 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
9342 (glob var compat) Removed.
9344 * compute.c: (type_check) Fixed messages about type mismatches.
9346 * data-list.c: (cmd_data_list) Removed compatibility code.
9347 (fixed_parse_compatible) Calls convert_negative_to_dash().
9348 Fixed bug where it only set the variable in fx.spec if it created
9349 the variable itself.
9350 (dump_fmt_list) Spelling fix.
9351 (cut_field) Removed compatibility code.
9353 * dfm.c: (cmd_begin_data) Don't require a command terminator on
9356 * expr-evl.c: (evaluate_expression) Implement LAG.
9358 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
9359 (parse_neg) Calls convert_negative_to_dash().
9360 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
9363 * expr.h: (struct expression_struct) Removed member max_lag.
9365 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
9366 (internal_cmd_record_type) Removed special handling to produce
9367 negative numbers from dash tokens.
9369 * getline.c: (static var DO_REPEAT_level) New var.
9370 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
9371 (handle_line_buffer) Copies the line into getl_buf; doesn't call
9372 copy_with_DO_REPEAT_substitutions().
9373 (getl_read_line) Maintains value of getl_mode. Calls
9374 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
9376 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
9378 * getline.h: (getl_mode) New glob var.
9380 * glob.c: Comment fixes.
9381 (init_glob) Restructured. Sets set_seed.
9382 (init_compat_dependent) Removed. All references removed.
9383 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
9384 (__htonl, __htons) Removed. (What were these for?)
9386 * lexer.c: (static var tbl) Dash set to class CNUM.
9387 (make_hexit) New function from data-out.c.
9388 (get_token_representation) Rewritten.
9389 (convert_negative_to_dash) New function.
9390 (lex_init_compat_dependent) Removed.
9391 (yylex) A dash is parsed as part of a number if it is followed by
9392 a digit. The ASCII representation of a number is copied to
9393 tokstr. String parsing farmed out to parse_string(). Comment
9395 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
9397 (preprocess_line) Line processing depends on interactive/batch
9398 mode, not on compatibility mode. Removed PC+ compatibility code.
9400 * loop.c: (loop_3_trns_proc) Comment fix.
9402 * main.c: Remove dead code.
9403 (main) Remove call to init_compat_dependent().
9405 * misc.c: (convert_fmt_ItoO) Make E format conversion more
9408 * print.c: (parse_string_argument) Calls
9409 convert_negative_to_dash().
9410 (fixed_parse_compatible) Calls convert_negative_to_dash().
9412 * repeat.c: (RPT_* defines) Removed.
9413 (struct rpt_numeric) Removed.
9414 (struct repeat_entry) New member type, changed `replacement' from
9416 (clean_up) Deallocation adapted to new repeat_entry.
9417 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
9418 usage. Creates vars for `type' of 1.
9419 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
9420 (store_numeric) Rewritten, new interface.
9421 (parse_numbers) Rewritten.
9422 (parse_strings) Rewritten.
9423 (find_DO_REPEAT_substitution) New function.
9424 (perform_DO_REPEAT_substitutions) New function.
9425 (copy_with_DO_REPEAT_substitutions) Removed.
9426 (debug_print) Rewritten.
9428 * set.q: Comment fix.
9429 (custom_results) Removed compatibility code.
9430 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
9433 * sysfile-info.c: (cmd_display) Removed compatibility code.
9435 * tokens.h: Comment fixes.
9436 (token types enum) Removed `toktype' typedef name for this int
9437 type. Removed SUBST. Restructured.
9439 * vars-atr.c: (discard_variables) Sets n_lag to 0.
9441 * vars-prs.c: Comment fix.
9443 * vfm.c: Comment fixes.
9444 (glob var n_lag) New var.
9445 (static vars lag_count, lag_head, lag_queue) New vars.
9446 (procedure) Removed argument nlag.
9447 (setup_lag) New function.
9448 (close_active_file) Discards lagging state.
9449 (lag_case) New function.
9450 (lagged_case) New function.
9451 (write_case) Lags a case if lagging.
9453 * weight.c: (cmd_weight) Removed compatibility code.
9455 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
9457 * getline.h: (struct getl_script) New members loop_index, macros.
9459 * getline.c: (getl_add_file) Sets first_line field to NULL.
9460 (getl_add_DO_REPEAT_file) New function.
9461 (handle_line_buffer) When the current line's length is negative,
9462 set the filename and line number. Increment line number after
9463 reading line. Pass the line to
9464 copy_with_DO_REPEAT_substitutions() for processing.
9465 (getl_close_file) Free DO REPEAT lines before freeing the
9466 filename, and just set the filename to NULL when doing this,
9467 because otherwise the filename gets freed twice.
9469 * glob.c: (glob var queuing) Removed. All references removed.
9471 * lexer.c: Comment fixes.
9472 (get_token_representation) New function.
9474 * repeat.c: Comment fixes.
9475 (struct repeat_entry) Replaced type and v union members with a
9477 (append_record) New function.
9478 (internal_cmd_do_repeat) Started reforming it for the new
9479 repeat_entry struct. Properly records filename changes in the
9480 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9481 strncasecmp() result usage. Uses append_record() to simplify.
9482 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9485 (copy_with_DO_REPEAT_substitutions) Started coding.
9487 [DEBUGGING] (debug_print_lines) New function.
9489 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9491 * tokens.h: (macro is_id1, is_idn) New macros.
9493 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9495 * cmdline.c: (static var pre_syntax_message) Changed `win'
9496 compatibility mode to `wnd'.
9498 * data-list.c: (fixed_parse_spss) Renamed
9499 fixed_parse_compatible().
9501 * glob.c: (init_glob) Excise unused code for
9502 program_invocation_short_name.
9504 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9507 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9509 * set.q: `win' compatibility renamed `wnd'.
9511 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9513 * filename.c: [__WIN32__] Change the included Windows header files
9515 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9516 second character is absolute.
9517 (dirname) Fix logic error. Don't printf() the results.
9518 (prepend_dir) Don't printf() the results.
9520 * getline.c: (handle_line_buffer) New function.
9521 (getl_read_line) Reads line with handle_line_buffer() when
9523 (getl_close_file) Discard line buffer data.
9525 * getline.h: Comment fixes.
9526 (struct getl_line_list) New struct.
9527 (getl_script_struct) Added line buffer members. These are hooks
9528 for use by DO REPEAT to allow it to insert virtual source code
9531 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9532 Override Borland C++ stupidity that claims Windows has a console
9535 * repeat.c: This is in the process of being restructured from
9536 using a token-buffering approach to the DO REPEAT facility to
9537 using the more flexible approach of a line-buffering approach in
9538 conjunction with the getline module. Comment fixes.
9539 (struct tok_struct) Removed.
9540 (static vars queue_index, queue_head, queue) Removed.
9541 (static vars line_buf_head, line_buf_tail) New vars.
9542 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9544 (pull_queue, destroy_queue) Removed.
9545 [DEBUGGING] (debug_print_tokens) Removed.
9547 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9549 * file-handle.q: (prepend_current_directory) New function.
9550 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9551 current directory before normalizing filename.
9553 * filename.c: (gnu_getcwd) New function.
9554 (absolute_filename_p) New function.
9555 (search_path) New argument, PREPEND. All references changed to
9556 pass NULL except those explicitly mentioned. Uses
9557 absolute_filename_p(). Prepends PREPEND before trying the
9559 (dirname, prepend_dir) New functions.
9561 * getline.c: (getl_get_current_directory) New function.
9562 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9565 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9567 * In several source files, the term `script' was replaced with
9568 `syntax file' inside error messages. Usage of the term `script'
9569 in the sense of a syntax file is now deprecated.
9571 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9574 * dump-sysfile.c: (usage) Update message.
9576 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9578 * getline.h: (glob var getl_include_path) Declare extern.
9580 * list.q: Define EXTERN as extern before #including somP.h.
9582 * var.h: Remove declaration of `disptype' variable.
9584 * vfm.c: (close_active_file) After switching the data sink to a
9585 data source, set vfm_sink to NULL, because it doesn't exist any
9588 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9590 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9591 _matherrl() to ignore all math errors.
9593 * sfm-read.c: (read_value_labels) When reading the labels from
9594 disk, read the little parts separately instead of as a struct;
9595 this avoids alignment problems.
9597 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9598 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9599 (write_header) Allocates and initializes elem_type.
9600 (sfm_write_case) Uses elem_type to determine how to handle each
9602 (sfm_close) Frees elem_type.
9604 * sfmP.h: Comment fix.
9605 [__BORLANDC__] Uses #pragma -a to adjust structure member
9608 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9610 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9612 * common.c: Fix typo.
9614 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9615 sense of the condition.
9617 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9618 line-continuation backslash.
9620 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9622 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9623 non-constant expression as an argument to sizeof.
9625 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9626 undefine gettext macro because that's a conio function.
9628 * hash.h: (hsh_prime_tab declaration) Remove.
9630 * list.q: (write_fallback_headers) Move `leader' allocation out of
9631 main loop. Change to local_alloc() allocation.
9633 * output.h: Formatting fixes. Put __attribute__ in right place on
9634 function prototypes.
9636 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9637 incorrect `SECOND_LOWEST_VALUE' references to proper
9638 `second_lowest_value'.
9640 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9641 value. This way 2 out of 3 of the som files define the vars
9642 extern, the correct way, that actually works under BC++.
9643 (som_set_float) Don't use nonconstant initializers for a struct.
9645 * som-high.c: Add the standard alloca() header.
9646 (replicate_table) Add prototype.
9648 Merged DISPLAY routine.
9649 * sysfile-info.c: (AS_*) New enum series.
9650 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9652 (cmd_display, display_macros, display_documents,
9653 display_variables) Stolen from defunct display.c.
9654 (describe_variable) New function.
9656 * temporary.c: [0] (display_tree) New debug function.
9657 (copy_variable) Performs shallow copy of value labels instead of
9658 deep copy; i.e., just copys the AVL tree and increments the
9661 * val-labs.c: Comment fixes.
9662 (do_value_labels) Optionally skip leading forward slash.
9663 (get_label) Creates only a single value label instead of many
9664 copies of one, and sets the reference count.
9666 * display.c: Removed.
9668 * dump-sysfile.c: New file, not yet complete.
9670 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9672 For lots of source files I added more verbose_msg's. These aren't
9673 listed below as they have tested as being benign. In some cases
9674 these replaced debug_printf() calls.
9676 * output.c: (outp_read_devices) Message fix.
9678 * postscript.c: (output_encodings) Message fix. Reports errors on
9680 (postopen) Message fix.
9682 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9684 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9686 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9689 * main.c: Remove <malloc.h> #include.
9691 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9692 instead of trying to just set the missing[] itself, which is a
9695 * sfm-read.c: (read_variables) Same.
9697 * str.h: Add memmem() prototype.
9699 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9701 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9703 * Makefile.am: (q2c) Don't include any libraries in the link.
9705 * dfm.c: (force_line_buffer_extension) New macro.
9706 (count_tabs) New function.
9707 (tabs_To_spaces) New function.
9708 (read_record) Calls tabs_to_spaces() on the line being processed.
9710 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9711 have to be compiled twice (once for CC, once for LOCAL_CC).
9713 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9715 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9716 (LDADD) Add @INTLLIBS@.
9717 (q2c) Add LIBS, @INTLLIBS@ to link step.
9719 * inpt-pgm.c: Turn off debugging.
9721 * postscript.c: (postopen) Format fix. local_free() blocks
9722 returned by local_alloc(); don't free() them.
9724 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9726 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9729 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9730 LEN arg, not simply the full string length.
9732 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9733 directories before generic temp file directories.
9735 * vfm.c: Disable debugging.
9737 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9739 * get.c: Comment fix.
9740 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9742 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9744 * expr-prs.c: (debug_print_postfix) Conditionally included on
9745 GLOBAL_DEBUGGING. Removed out_header() reference.
9747 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9749 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9751 * ascii.c: Removed obsolete ascii_close_page() prototype.
9753 * command.c: (output_line) Comment fix.
9755 * data-in.c: Formatting fix.
9756 (parse_string_as_format) Now the `fc' argument is used only for
9757 the purpose of error messages; it is not an index into the string
9758 passed. All references changed.
9760 * data-list.c: Comment fix.
9761 (cut_field) Comment fix. Now returns the column number of the
9762 position of the field cut out on success.
9763 (parse_field) Added `column' argument. Puts the column numbers in
9765 (read_from_data_list_free, read_from_data_list_list) Record the
9766 column number returned by cut_field(), pass it to parse_field().
9768 * dfm.c: Comment fix.
9770 * do-ifP.h: Comment fix.
9772 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9773 the SYSMIS function.
9775 * expr.h, exprP.h: Comment fix.
9777 * glob.c: (init_glob) Only calls setlocale() and family if
9780 * hash.h: Comment fix.
9782 * include.c: Comment fix.
9784 * output.c: Comment fix.
9786 * postscript.c: (ps_line_intersection) Simplified assertion.
9788 * repeat.c: Comment fix.
9790 * vars-atr.c: Comment fix.
9792 * vars-prs.c: Comment fix.
9794 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9795 behavior with usage of postincrement.
9796 (memory_stream_read) Discards cases as it goes.
9798 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9800 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9803 * Most source files: Includes debug-print.h, related comment
9806 * cases.c: (alloc_val) Removed complex allocation code. Merely
9807 increments default_dict.nval and returns the former value.
9808 (envector, devector) Removed references to lv member of struct
9811 * common.h: (macro VME) Replaced complex definition with simple
9814 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9815 read_active_file and cancel_input_pgm.
9816 (read_from_data_list, cancel_data_list) Removed.
9817 (data_list_source_read, data_list_source_destroy_source) New
9819 (glob var data_list_source) New var.
9821 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9822 (cmd_begin_data) Improved criteria for an input program accessing
9823 the inline file. Still not perfect.
9825 * do-if.c: (do_if_trns_proc) Simplified debug output.
9827 * expr-prs.c: Comment fixes.
9828 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9830 * file-handle.q: (fh_close_handle) Simplified debug output.
9832 * file-type.c: Comment fixes.
9833 (cmd_file_type) Sets vfm_source instead of read_active_file and
9835 (cmd_end_file_type) On failure, discards variables in place of
9836 just canceling the input program.
9837 (read_from_file_type) Renamed file_type_source_read.
9838 (cancel_file_type) Renamed file_type_source_destroy_source.
9839 (glob var file_type_source) New var.
9841 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9842 (cmd_get) Initializes options to GTSV_NONE before passing to
9843 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9844 instead of read_active_file and cancel_input_pgm.
9845 (cmd_save_internal) Initializes options before passing to
9846 trim_dictionary(). Local var `nval' removed.
9847 (dict_delete_run) Comment fixes.
9848 (trim_dictionary) Comment fixes. Disallows scratch variables if
9849 GTSV_OPT_SAVE set in options.
9850 (read_from_get) Renamed get_source_read.
9851 (cancel_get) Renamed get_source_destroy_source.
9852 (glob var get_source) New var.
9854 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9855 read_active_file and cancel_input_pgm.
9856 (read_from_input_program) Renamed input_program_source_read.
9857 Simplified debug output.
9858 (cancel_input_program) Renamed
9859 input_program_source_destroy_source.
9860 (glob var input_program_source) New var.
9862 * loop.c: (loop_1_trns_proc) Simplified debug output.
9864 * main.c: (dump_token) Made eof output more explicit.
9866 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9869 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9870 code for always-memory or always-disk cases. malloc's case-list
9871 based on vfm_source_info.ncases. Explicit support for
9872 memory_stream via memory_source_cases.
9873 (do_external_sort) Sets vfm_source instead of read_active_file and
9875 (allocate_file_handles) The temporary directory permissions are
9876 set to 0700 instead of 0777.
9877 (allocate_cases) Formatting fixes. Simplified debug output.
9878 (output_record) Compacts the case if necessary before writing it
9880 (close_handle, open_handle_w) Simplified debug output.
9881 (write_initial_runs) Destroys vfm_sink, then sets it to
9882 sort_stream. Writes records to memory based on
9883 vfm_sink_info.case_size.
9884 (write_to_sort_cases) Renamed sort_stream_write().
9885 (merge) Simplified error handling. Simplified debug output.
9887 (read_from_external_sort) Renamed sort_stream_read().
9888 Reads records based on vfm_source_info.case_size.
9889 (sort_stream_write) Writes records to memory based on
9890 vfm_sink_info.case_size.
9891 (sort_stream_mode) New function.
9892 (glob var sort_stream) New variable.
9894 * temporary.c: (cmd_temporary) Simplified debug output.
9895 (copy_variable) Removed references to `lv'.
9897 * title.c: (get_title) Simplified debug output.
9899 * var.h: Comment fixes.
9900 (struct get_proc) Removed member `lv'.
9901 (struct variable) Removed member `lv'. Comment fixes.
9902 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9904 (struct case_stream) New.
9906 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9907 read_active_file references to use vfm_source.
9908 (init_variable, replace_variable) Removed references to `lv'.
9910 * vfm.c: Comment fixes.
9911 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9913 (static var queue, qh, qt, n_lag) Removed. All references
9915 (glob var compaction_necessary, compaction_nval, compaction_case,
9916 paging) New variables.
9917 (record_case) Removed.
9918 (procedure) Comment fixes. Calls vfm_source->read() instead of
9921 (prepare_for_writing, arrange_compaction, make_temp_case,
9922 vector_initialization, setup_filter) New function.
9923 (open_active_file) Most of the code moved into the abovementioned
9924 new functions. Now sets temp_dict to &default_dict if there is no
9925 temporary dictionary, for convenience. New debug output.
9926 (close_active_file) Deals with changing the sink to the source.
9927 Calls finish_compaction(). Frees compaction_case. Mostly
9929 (glob vars disk_source_file, disk_sink_file) New vars.
9930 (destroy_active_file, read_from_memory) Removed.
9931 (disk_stream_init, disk_stream_read, disk_stream_write,
9932 disk_stream_mode, disk_stream_destroy_source,
9933 disk_stream_destroy_sink) New functions.
9934 (glob var vfm_disk_stream) New var.
9935 (glob vars memory_source_cases, memory_sink_cases,
9936 memory_sink_iter, memory_sink_max_cases) New vars.
9937 (memory_stream_init, memory_stream_read, memory_stream_write,
9938 memory_stream_mode, memory_stream_destroy_source,
9939 memory_stream_destroy_sink) New functions.
9940 (glob var vfm_memory_stream) New var.
9941 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9942 named `more_cases'. Simplified debug output. Otherwise mostly
9944 (record_case) Moved into the stream drivers. Removed.
9945 (transform) Removed (was dead code).
9946 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9947 common case that the splits don't change, we don't need to copy
9948 the case into prev_case again--pointless.
9949 (compact_case) New function.
9950 (finish_compaction) New function.
9952 * vfmP.h: Comment fixes.
9953 (DEV_* enum series) Removed.
9954 (struct storage) Renamed `stream_info'. Removed variant record.
9955 Removed `device' member.
9957 * debug-print.h: New file.
9959 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9961 * autorecode.c: Turned off debugging.
9963 * data-list.c: (destroy_dls) Closes the associated file handle.
9965 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9966 parse_variables() options.
9968 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9970 * display.c: (display_variables) Really fixed null cell bug.
9972 * file-handle.q: (fh_close_handle) Changed debugging message.
9974 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9975 parse_variables() options.
9977 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9978 (cmd_list) Fails if no variables specified.
9979 (determine_layout) Writes blank lines manually.
9981 * loop.c: (loop_1_trns_proc) Made debugging code only print
9982 messages if debugging.
9984 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9985 parse_variables() arguments.
9986 (main) Parses optional parenthesized options to varlist
9987 subcommands into sbc->message.
9989 * sfm-read.c: Format fix.
9991 * var.h: (FV_*) New enum series.
9992 (PV_*) New enum PV_NO_SCRATCH.
9994 * vars-prs.c: (find_var) Removed.
9995 (fill_all_vars) Takes FV_* enum instead of boolean third
9996 argument. Rewritten to deal with scratch as well as system
9998 (parse_variables) Error message on scratch variable if
10001 * vfm.c: (static var virt_begin_func) New var.
10002 (procedure) Sets up virt_begin_func.
10003 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
10004 after dump_splits(). For succeeding groups changes, calls
10005 virt_begin_func() instead of begin_func().
10007 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
10009 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
10012 * dfm.c: Added some debugging messages, disabled by default.
10013 (open_file_r) Fixed error message.
10014 (read_record) On eof on inline_file, instead of calling
10015 fh_close_handle(), simply jump to eof label like a normal file.
10018 * display.c: Thin lines between rows for certain kinds of
10019 listing. Fixed `null cell' bug.
10021 * error.c: (failure) Flush stdout, stderr before failing.
10023 * file-handle.q: (fh_close_handle) Added debugging message.
10025 * frequencies.q: (dump_full) Bottom line extends across entire
10026 table width. Changed title formatting.
10027 (dump_condensed) Changed title formatting.
10028 (dump_statistics) Fixed title formatting.
10030 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
10031 Sets default value of set_format.
10033 * list.q: (cmd_list) Calls blank_line() before determine_layout().
10034 Passes write_all_headers() to procedure() as pre-group func.
10035 (write_all_headers) New function.
10036 (determine_layout) Removed calls to write_header().
10037 Calls blank_line() before and after write_fallback_headers().
10039 * recode.c: (recode_trns_free) Only attempts to free head->map if
10042 * sfm-read.c: (read_variables) Allows `#' at beginning of system
10043 file variable names but gives a warning. Sets `left' based on
10044 first character being/not being `#'. On lossage frees dict->var.
10046 * som-high.c: (som_draw_title) Simplified title formatting.
10048 * vfm.c: (dump_splits) Fixed and changed splits formatting.
10050 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
10052 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
10053 beginning. Frees v_src, v_dest on successful exit. Frees
10054 h_trans[*], h_trans on lossage.
10055 (recode) Frees h_trans[*], h_trans.
10057 * dfm.c: (dfm_close) Formatting change.
10058 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
10059 longer allocates its own in inline_file.
10060 (open_file_r) Passes the local dfm_fhuser_ext to
10061 open_inline_file().
10062 (open_file_w) Message fix.
10063 (read_record) Buffer reallocation strategy changed. Frees
10064 ext->line even in inline_file to prevent leaks.
10065 (dfm_put_record) Fixed bug where `ext' was cached before the file
10066 was opened and thus it would be NULL when the file really was
10068 (cmd_begin_data) Sets up inline_file basics itself, then calls
10069 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
10071 * list.q: (write_line) Formatting fix.
10072 (clean_up) Minor strategy change. Sets proportional font after
10074 (determine_layout) Sets fixed font before writing regular headers,
10075 or after writing fallback headers.
10077 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
10078 and KEEP vars after using them.
10080 * postscript.c: (ps_init_driver) Frees x->family.
10081 (postopen) When loading fonts, free the temporary font name buffer
10083 (ps_text_set_font_by_position) Free temporary font name buffer
10085 (text) Fixed code that calculated `lig' so that `lig' always gets
10086 initialized. Formatting fix.
10088 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
10090 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
10091 cells, not xmalloc(), so that the cells will get destroyed
10094 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
10097 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
10099 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
10102 * dfm.c: Comment fix.
10104 * list.q: Comment fixes. Include somP.h. Removed static vars
10105 table, n_columns, n_rows, part. New struct list_ext. New static
10107 (n_lines_remaining, n_chars_width, write_line) New functions.
10108 (cmd_list, list_cases) Rewritten.
10109 (begin_row, end_row, flush_table) Removed.
10110 (write_header, clean_up, write_varname, write_fallback_headers,
10111 determine_layout) New functions.
10113 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
10115 * output.h: Comment fix.
10117 * postscript.c: Comment fix.
10118 (struct ps_driver_ext) Removed prop_size, fixed_size members;
10119 added font_size. All references changed.
10120 (ps_init_driver) Initializes font_size. Simplified space checking
10122 (static var option_tab[]) Removed prop-size, fixed-size; added
10124 (ps_option) Handles font_size.
10126 * som-high.c: Moved prototypes into somP.h.
10127 (som_init_driver) New function.
10128 (som_submit_table) Moved some code into new function
10130 (build_target) Moved some code into new function
10131 som_internal_eject_page().
10132 (som_eject_page) Uses som_internal_eject_page().
10133 (som_internal_eject_page) New function.
10135 * som-low.c: Moved prototypes into somP.h.
10137 * som.h: Formatting fixes.
10139 * somP.h: (struct som_driver_ext) Removed em_width;
10140 added prop_em_width, fixed_width.
10142 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
10144 * Makefile.am: Added `localedir' definition. Added
10145 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
10147 * ascii.c: (macro draw_line) Fixed capitalization.
10149 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
10150 compute.c, count.c, data-in.c, data-list.c, data-out.c,
10151 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
10152 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
10153 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
10154 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
10155 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
10156 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
10157 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
10158 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
10159 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
10160 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
10161 for internationlization.
10163 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
10165 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
10167 * do-if.c, sort.c, val-labs.c: Comment fixes.
10169 * glob.c: (init_glob) Uncommented, updated i18n support.
10171 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
10172 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
10173 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
10174 the declarations of macros taking arguments a lot nicer.
10176 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
10178 * error.h: Removed CE, CW aliases for SE, SW.
10180 * q2c.c: Removed explicit streq() definition since it's duplicated
10183 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
10184 stats.h, str.h, tokens.h: Made the declarations of macros taking
10185 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
10188 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
10190 * cmdline.c: Comment fixes.
10191 (pick_compat) Changed return type to int. Now, instead of setting
10192 glob var `compat' to the emulation, returns the emulation. All
10193 references changed.
10194 (parse_command_line) Added terminating null to end of
10195 `long_options' array definition.
10196 (pre_syntax_message) Fixes.
10197 (usage) Shows the default emulation in the syntax message by
10198 calling pick_compat().
10200 * getline.c: (getl_add_include_dir) Separates paths with
10201 PATH_DELIMITER, not DIR_SEPARATOR.
10203 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
10204 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
10206 * output.c: (outp_configure_macro) Make earlier definitions for a
10207 particular key override later ones for the same key.
10209 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
10211 * ascii.c: Comment fixes.
10213 * output.c: (outp_get_paper_size)
10214 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
10216 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
10218 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
10219 <errno.h>. GNU libc 2 enforces this!
10221 * command.c: (parse_cmd) Fixed problem with `else' clause being
10222 paired with wrong `if'. Comment fix.
10224 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
10226 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
10227 blp_getline() to getline().
10229 * output.c: (outp_eval_dimension) Changed the fix from last time;
10230 there was no variable `a'.
10232 * q2c.c: (get_line) Fixed boundary condition overrun bug.
10234 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
10236 * output.c: (outp_evaluate_dimension) Fixed handling of negative
10237 numbers having fractional parts. Added case of a fraction without
10238 a whole-number part.
10240 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
10242 * ascii.c: (ascii_text_get_font_position) Removed.
10244 * expr.h, exprP.h: Disabled debugging.
10246 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
10249 * output.h: (struct outp_class_struct) Removed
10250 text_get_font_position method. All references deleted.
10252 * postscript.c: Big change here. Fontmaps were completely
10253 eliminated because of a change in philosophy. Comment fixes.
10254 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
10256 (struct ps_driver_ext) `position', `fontmap', `prop_name',
10257 `fixed_name' members removed. New members `prop_family',
10258 `fixed_family'. `family' member changed to type char *.
10259 (static var ps_fontmaps) Removed.
10261 (ps_init_driver) Removed obsolete references, updated.
10262 Initializes `translate_x', `translate_y', `scale'. Doesn't read
10263 fontmap, of course. Refers to font names through internal_name
10264 rather than subversive means. Frees proper items.
10265 (static var option_tab[]) Removed `fontmap-file' option; renamed
10266 `fixed-font', `prop-font'.
10267 (ps_option) Corresponds to option_tab[].
10268 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
10269 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
10270 hash_family) Removed.
10271 (postopen) Generates font names from family names. Gets
10272 PostScript font name properly. New prologue file comment `!!!'
10274 (ps_open_page) Adds translate_x, translate_y to BP prologue
10275 function; gives SF argument floating-point format.
10276 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
10277 font name. Doesn't change font family.
10278 (ps_text_set_font_by_position) Generates Groff font name from font
10279 family name instead of through table lookup.
10280 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
10281 all references changed. Reduced to simple string assignment.
10282 (ps_get_font_name) Removed.
10283 (ps_get_font_family) Reduced to string return.
10284 (text) Doesn't save `position' since it no longer exists. Ugly
10285 kluge to save font family--fix soon?
10286 (load_font) Removed PostScript name argument.
10288 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
10290 * postscript.c: Comment fix.
10291 (ps_open_page) Puts scale factor in PostScript output.
10293 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
10295 * Makefile.am: Distcleans q2c.
10297 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
10299 * ascii.c: (delineate) Sets text size even if width is zero.
10301 * command.c: Comment fix.
10302 (static var cmd_table[]) Re-enabled EVALUATE command.
10303 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
10304 of comments in script files. Now more liberal on criteria for
10305 performing a state transition--if *anything* happened correctly,
10306 not just if *everything* happened correctly.
10308 * data-out.c: (convert_F) Comment fix. Why in the fsck does
10309 Checker segfault on formatting large numbers and why in the fsck
10310 hadn't I noticed this before?
10312 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
10314 * list.q: (cmd_list) Commented out the actual output routine
10315 because of various problems. Probably will abandon the idea of
10316 using the general `crushed tables' for the LIST procedure.
10318 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
10319 clearing it. Allocates a new var_by_name dictionary before trying
10320 to add members to it.
10322 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
10323 `sib'. Changed type of `node' argument.
10324 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
10325 avl_walk_inorder().
10326 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
10327 [DEBUGGING] Only deletes the variable from var_by_name if that var
10330 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
10332 * Makefile.am: Added include files to SOURCES. Added
10333 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
10334 includes rules for q2c. Added `boast' target.
10336 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
10338 * Makefile.am: Maintainer-clean Makefile.in.
10340 * Makefile.am: Fixed redundant EXTRA_DIST line.
10342 * ascii.c: Comment fixes.
10343 (ascii_line_vert) Fixed overly aggressive range check.
10345 * display.c: Removed dead code.
10347 * list.q: Turn debugging on.
10348 (flush_table) New debug code.
10350 * sfm-read.c: (read_value_labels) malloc's the structure before
10351 trying to assign to its members.
10353 * sfm-write.c: Comment fix.
10355 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
10357 (output_table) No arguments anymore--gets them through `som'
10358 global. New debug code. In crushed tables, now sets `htv' as
10359 well as `hv' to avoid bad confusion later.
10360 (dump_crush_page) New debug code.
10362 * som-low.c: (som_dump_crush_page) New debug code.
10364 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
10366 All source files: Broke long lines into multiple lines.
10368 * ascii.c: (ascii_close_page) Uses host_system var in place of
10369 HOST_SYSTEM constant.
10371 * cmdline.c: (var syntax_message[]) Broke into
10372 pre_syntax_message[] and post_syntax_message[].
10373 (usage) Outputs both parts, separated by driver list.
10375 * error.h: Fixed broken formatting.
10377 * expr-opt.c: (str_search, str_rsearch) New functions.
10379 * misc.c: (blp_getdelim) Removed. All references changed to
10381 (str_search, str_rsearch) Removed.
10382 (memrmem) New function.
10384 * misc.h: (blp_getline) Removed. All reference changed to
10387 * stat.h: New file.
10389 * filename.c: Includes "stat.h", not <sys/stat.h>.
10390 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
10392 * output.c: (outp_list_classes) Changed output formatting.
10394 * sfm-write.c: (write_header) Uses host_system var instead of
10395 HOST_SYSTEM constant.
10396 (write_rec_7_34) Extracts version numbers from the version string.
10399 * sort.c: Includes "stat.h", not <sys/stat.h>.
10401 * str.c: (strcasecmp) Removed.
10403 * title.c: (cmd_document) Uses host_system var instead of
10404 HOST_SYSTEM constant.
10406 * version.c: Generated on-the-fly by the Makefile instead of being
10409 * str.h: Comment fixes. Doesn't substitute for missing memmove or
10411 [!HAVE_STRNCASECMP] Declares strncasecmp().
10413 * version.h: Removed stray character. Comment fixes.
10414 (vars host_system, build_system) New vars.
10416 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
10418 * Most source files: Changed formatting of copyright notice; fixed
10419 FSF address; reformatted to better conform to GNU standards;
10420 comment fixes. Added markups to prevent GNU indent from messing
10421 up my beautiful formatting :-).
10423 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
10424 that GNU indent markups can be passed through without problems.
10426 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
10428 * get.c: Turned off debugging.
10430 * glob.c: (init_glob) Turned on save-file compression by default.
10432 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
10433 compression than was possible in save files.
10435 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
10437 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
10439 * frequencies.q: Removed Fiasco extensions. Updated calculation
10440 algorithms. Polished output format.
10441 (struct frq_info_struct) Removed members `max_degree', `min_n',
10442 all references removed.
10443 (macro frq_extensions) Removed.
10444 (static vars min_n, max_degree) Removed, all references removed.
10445 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
10446 calculate `min_n', `max_degree'.
10447 (postcalc) Passes new arg to dump_statistics().
10448 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
10450 (dump_condensed) Adds variable name title.
10451 (sum_freqs) Removed.
10452 (calc_stats) Updated calculation algorithm.
10453 (dump_statistics) Removed warning for too-few observations.
10454 Changed table formatting. Adds variable name title if passed new
10457 * output.h: Comment fix.
10459 * recode.c, sample.c, sort.c: Disabled debug code.
10461 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
10462 Improved debug code.
10464 * var.h: (enum series frq_*) Removed Fiasco extensions.
10466 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10468 * command.c: Added PROCESS IF to command table.
10470 * Lots & lots of places, removed checks for NULLs preceding calls
10471 to free_expression(), which itself checks.
10473 * descript.q: Removed Fiasco extensions. Removed optimizations
10474 for non-weighted active files. Implemented some options.
10475 Finished polishing output format. Comment fixes. Merged
10477 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10478 max_degree, min_n) Removed.
10479 (macro dsc_extensions) Removed.
10480 (struct dsc_info_struct) Removed `min_n' member, all references
10482 (internal_cmd_descriptives) Removed calculation of min_n,
10483 max_degree. Only deals with one `calc' routine instead of two
10485 (precalc) Eliminated redundancy. Updated for changes to
10486 descriptives_proc structure.
10487 (calc) Moved here from `descript.g'. Rewritten to calculate
10488 statistics via `moments about the mean' rather than by summing,
10489 summing squares, summing cubes, and so on.
10490 (postcalc) Rewritten for new-style statistical calculation.
10491 (display) Removed support for displaying variables across rows.
10492 No longer crushes the descriptives table. Removed ancient code.
10493 Added display of N, by variable and listwise.
10495 * descript.g: Removed; merged into `descript.q'.
10497 * expr-evl.c: (evaluate_expression) Now returns a double. For
10498 numeric results, it returns the result as well as storing it in
10499 the passed `value' structure if non-NULL. For string results it
10500 just returns 0.0 and it must be passed non-NULL. Many references
10501 to this function were optimized by use of this change, especially
10502 but not exclusively in `compute.c'.
10504 * frequencies.g: Comment fix.
10506 * glob.c: (glob var process_if_expr) New global var.
10508 * postscript.c: (static var option_tab[]) Corrected entry for
10510 (postopen) Sets x->size to x->prop_size.
10511 (ps_text_set_font_by_name) Sets font size as well as typeface for
10512 PROP and FIXED fonts.
10514 * sel-if.c: (cmd_process_if) New function.
10516 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10517 (sfm_write_dictionary) Sets `n_cases' to 0.
10518 (sfm_write_case) Increments `n_cases'.
10519 (sfm_close) Attempts to seek the system file back to the header
10520 and write the number of cases in its proper slot.
10522 * som-frnt.c: (som_insert_table) Masks off expansion options since
10523 only SOPT_X_NORM seems to work sensibly.
10525 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10526 with a `fixed' value of 2.
10528 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10530 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10531 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10533 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10534 (struct descriptives_proc) Removed `miss_noweight'; new members
10535 `X_bar', `M2', `M3', `M4', `min', `max'.
10537 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10539 * vfm.c: (close_active_file) Cancels PROCESS IF.
10540 (write_case) Doesn't process cases unselected by PROCESS IF.
10542 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10544 * glob.c: (glob var err) Removed.
10546 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10547 doesn't have to take into account number of value labels since
10548 they're in a subtable anyway. Also, doesn't display more than 10
10549 value labels since we can't yet break pages in subtables.
10551 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10553 * som-frnt.c: (som_change_table_size) Simple change for elegance
10554 that shouldn't change behavior.
10555 (som_set_value) Comment fix.
10557 * som-high.c: (som_submit_table) Message fix.
10559 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10561 * command.c: Added SYSFILE INFO to command table.
10563 * file-handle.q: (fh_handle_filename) New function.
10565 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10568 * main.c: (parse) New return value for command functions, -3.
10570 * misc.h: Comment fix.
10572 * output.h: Comment fixes.
10573 (macro COMPONENTS) Removed.
10575 * postscript.c: (write_text) Modified literal_chars[] so that `('
10576 and ')' are not written to the output in strings as literals.
10578 * sfm-read.c: (sfm_read_dictionary) New argument.
10579 (read_header) New argument. Sets the information structure's
10580 values from the header information.
10581 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10582 bizarre Checker problem, I guess.
10583 (read_variables) Proper cleanup on lossage.
10585 * sfm.h: (struct sfm_read_info) New struct for use by
10586 sfm_read_dictionary().
10588 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10589 currently used just for tables that can be dynamically resized and
10590 thus have to be allocated with arena_malloc() instead of
10591 arena_alloc(). All references changed.
10592 (som_change_table_size) New function.
10593 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10595 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10596 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10599 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10601 (draw_intersection) Now takes an argument specifying the table in
10602 question. All references changed.
10603 (draw_table_cell) New function.
10604 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10605 (som_get_table_size) Many nice new explanatory comments.
10606 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10608 * som.h: New enum series SOM_CREATE_* for use as create flags with
10609 som_create_table().
10611 * str.h: Moved a comment here from TODO.
10613 * sysfile-info.c: New file. Reference implementation.
10615 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10617 * command.c: Added RENAME VARIABLES to table of commands.
10619 * data-in.c: (dls_error) Sets `cust_field'.
10620 (parse_N) Message fix.
10621 (parse_day_count) New function.
10622 (to_roman) Never outputs VX as a `short form' of V.
10623 (parse_month) Fixed parsing of Roman numerals.
10624 (parse_trailer) Message fix.
10625 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10626 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10627 the date is invalid.
10628 (parse_SDATE) Fixed swapped day, year.
10629 (parse_JDATE) Fixed bug for dates in 1582.
10630 (parse_DTIME) Allows days not between 1 and 31.
10631 (parse_numeric) Makes local copy of f.type for easier usage.
10634 * data-out.c: (convert_F) When outputting as scientific, properly
10635 sets f.type as fp->type.
10636 (insert_commas) Fixed operator precedence problem with setting of
10637 nitems. Changed strcpy to memcpy (no null terminator).
10638 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10639 (convert_CCx) Essentially rewritten, but now it works.
10641 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10642 feature of Fiasco).
10643 (display_documents) Implemented.
10645 * error.c: (glob var cust_field) New var.
10646 (vmsg) Displays cust_field as part of message classes DE and DW.
10648 * formats.c: (debug_print) Fixed to compile under updated
10651 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10654 * misc.c: (parse_format_specifier) Formatting fix.
10656 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10657 `n_rename' for clarity.
10658 (cmd_modify_vars) Initializes `forward' and `positional' at
10659 appropriate times. Frees lists of vars to rename on failure.
10660 Comment fix. Frees memory on success.
10661 (rearrange_dict) Simplified `for' loop condition.
10663 * rename-vars.c: New file (reference implementation).
10665 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10667 * sfm-read.c: (read_header) File label is created only if file
10668 label in file is not blank.
10669 (read_variables) Initializes `dict' local variable.
10670 (read_documents) Proper behavior on lossage.
10672 * sfm-write.c: (write_header) Doesn't blank out the file label
10673 (why was this here to begin with?!)
10675 * temporary.c: (save_dictionary) File label is copied only if
10676 non-NULL. Doesn't try to xstrdup() dictionary documents.
10677 Adapted so as to not irritate Checker.
10678 (free_dictionary) Only destroys var_by_name if non-NULL.
10680 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10681 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10682 lines to the document, indents the document. Also, it works now.
10683 (add_document_line) New function.
10685 * var.h: (struct dictionary) Reordering.
10687 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10688 bits if it was allocated to begin with.
10690 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10692 * command.c: Added MODIFY VARS to list of commands.
10694 * configure.in: Updated custom macros for autoconf 2.12. Removed
10695 mmap reference; fixed termcap library reference.
10697 * display.c: (display_variables) Fixed a few bugs although it's
10698 still not well written.
10700 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10701 (induce_segfault) Calls chkr_disp_call_chain() instead of
10702 inducing an actual SIGSEGV.
10704 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10705 str_search() and str_rsearch(). Fixed tests for matches on
10706 OP_INDEX and OP_RINDEX.
10708 * filename.c: (good_getcwd) Removed as the new libc for Checker
10709 doesn't contain this bug, apparently.
10711 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10712 consistency with GNU memmem.
10713 (blp_getdelim) Changed `len' from `int' to `size_t'.
10715 * modify-vars.c: Reference implementation.
10717 * som-frnt.c: (zero_length) New global var.
10718 (som_create_table) Message fix.
10720 * som.h: Added gcc attributions to som_set_text(),
10721 som_output_text() prototypes. blank_line() refers to
10722 zero_length[] instead of a literal null string to suppress gcc
10725 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10726 (allocate_cases) Decrements x_max so the last element of x[] can
10727 be used by the algorithm.
10729 * var.h: Changed minor details of `variable' declaration.
10730 (struct modify_vars_proc) New struct.
10731 (struct variable) Added field p.mfv.
10733 * vars-atr.c: Comment fix.
10735 * vars-prs.c: (fill_all_vars) More optimal implementation.
10737 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10738 character, which it shouldn't have to do but printf() seems to
10739 read the null byte even though I supply a maximum length...
10741 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10743 * command.c: Removed command alias X for QUIT.
10744 (parse_cmd) Fixed comment parsing.
10746 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10748 (read_record) Fixed references to len, size.
10749 (dfm_get_record) Restructured.
10751 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10754 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10757 * modify-vars.c: New file. Not complete.
10759 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10762 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10763 problems caused by int/size_t differences.
10765 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10768 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10769 being compared were of equal length.
10771 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10773 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10775 * lexer.c: (get_dotted_rest_of_line) New function.
10777 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10780 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10781 type 6 records. Frees the dictionary properly.
10782 (read_header) Initializes the dictionary instead of letting
10783 read_variables() do it. Sets the dictionary file label from the
10785 (read_documents) New function.
10787 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10788 write type 6 record if appropriate.
10789 (write_header) Writes file label from dictionary.
10790 (write_documents) New function.
10792 * temporary.c: (save_dictionary, restore_dictionary,
10793 free_dictionary) Properly handle new fields in dictionary struct.
10795 * title.c: (get_title) Returns after failure().
10796 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10797 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10799 * var.h: (struct dictionary) New fields `label', `n_documents',
10802 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10804 * command.c: Added FILTER to list of commands.
10806 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10809 * get.c: (cmd_save_internal) Removed weighting code since it's now
10810 handled by sfm-write.c. Properly commented out debug code.
10812 * glob.c: (glob var weighting) Removed.
10814 * sel-if.c: Comment fixes.
10815 (cmd_filter) New function.
10817 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10818 (sfm_read_dictionary) Sets weighting variable direct in the
10819 created dictionary now. (Apparently we previously didn't support
10821 (read_header) Sets weight_index field in sfm_fhuser_ext from
10822 header read from disk.
10824 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10825 (write_header) Now sets the weighting in the header from the
10826 passed primary dictionary instead of from the sfm_write_info.
10828 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10830 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10831 broke on boundary conditions.
10833 * var.h: (struct dictionary) New fields `weight_var',
10834 `weight_index', and `filter_var'.
10835 (glob var weighting) Removed. This is now part of struct
10836 dictionary. All references changed; the less mechanical changes
10837 are described above.
10839 * vars-atr.c: (find_dict_variable) New function.
10841 * vfm.c: (static var filter_index) New variable.
10842 (open_active_file) Initializes filter_index from default_dict.
10843 (write_case) Calls proc_func() only if the filter variable is
10844 nonzero; this implements FILTER behavior.
10846 * weight.c: (static var weight_varname) Removed.
10847 (cmd_weight) Modified default_dict instead of glob vars.
10848 (update_weighting) Changed the signature to modify a dictionary
10849 instead of glob vars. Now returns the weighting variable.
10850 (get_weighting_variable) Removed; its function is absorbed by
10851 update_weighting().
10852 (stop_weighting) Operates on a dictionary now.
10854 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10856 * sort.c: Removed debugging info from messages.
10857 (do_external_sort) Cleans up after itself by deleting the
10858 temporary directory on failure. (On success it is deleted by the
10860 (allocate_cases) Removed debug code. Added clean up code.
10861 (output_record) Removed debug code.
10862 (merge) Added code to close all the input files that are currently
10863 open. This is a likely location for bugs, because I'm not sure
10864 about boundary conditions. Removed an unnecesary heap_delete().
10865 (merge_once) Removed input file "optimization" that in fact
10866 screwed up the rest of the code. Message and comment fixes.
10868 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10870 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10872 * heap.c: (heap_delete) New argument.
10874 * sort.c: Finished implementation of external sort.
10876 * vfm.c: (read_from_disk) Returns after a disk error.
10878 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10880 * sort.c: (static var state) Removed.
10881 (static vars max_handles, tmp_basename, tmp_extname,
10882 huffman_queue) New variables.
10883 (do_external_sort) Moved most code to new functions.
10884 Creates huffman_queue.
10885 (allocate_file_handles, allocate_cases) New functions.
10886 (static vars run_no, run_length, file_index, case_count) New
10888 (output_record) Returns success. Now really writes to the output
10890 (begin_run, end_run) New functions.
10891 (write_initial_runs) Returns success. Initializes run_no to -1.
10892 Calls begin_run(), end_run() at appropriate times. Outputs debug
10894 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10896 (merge) New function.
10898 * heap.c, heap.h: New files. Hopefully in near-final form.
10900 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10902 * glob.c: Added write_active_file to global vars.
10904 * sort.c: Several new miscellaneous static variables.
10905 (cmd_sort_cases) Big comment fix.
10906 (perform_case_2) Renamed `do_external_sort' and completely
10908 (case_2_proc_func) Removed.
10909 (output_record, write_initial_runs, write_to_sort_cases,
10910 compare_record) New functions.
10912 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10914 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10916 * sort.c: (perform_case_2) Changed the method for allocation of
10917 lots of memory--now allocates one case at a time in hopes that
10918 more cases can be allocated with heavily fragmented memory.
10920 * var.h: (write_active_file) New global var.
10922 * vfm.c: (procedure, close_active_file, write_case,
10923 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10924 arguments to procedure() to be NULL. All references to
10925 procedure() that made use of dummy functions were changed to NULL
10927 (open_active_file) If write_active_file is non-NULL, the output
10928 device becomes DEV_PGM (a new enum).
10929 (close_active_file) Sets write_active_file to NULL.
10930 (read_from_memory) Comment fix.
10931 (record_case) Calls write_active_file() when the output device is
10934 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10936 * sort.c: New file.
10938 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10939 Fixed checking for duplicate varnames.
10940 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10942 (autorecode_trns_free) Destroys hash tables for each recoding
10944 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10946 * command.c: Added SORT CASES to cmd_table.
10947 (null_func, null_int_func) Prototyped.
10949 * descript.g: (calc_weight, calc_noweight) Computes own case
10952 * frequencies.q: (dump_statistics) Fixed problem with
10953 too-few-cases warning message.
10955 * get.c: (cmd_save_internal) Handles weighting properly.
10957 * hash.c: (hsh_dump) Output format changed.
10958 (force_hsh_insert) Actually works now, prototype changed.
10960 * list.q: (static var case_num) New variable.
10961 (cmd_list) Initializes case_num.
10962 (list_cases) Increments case_num.
10964 * var.h: Added definitions for SORT CASES. Comment fixes.
10966 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10967 fixes. `active' renamed vfm_active, `rep' renamed
10968 vfm_replacement, all references changed.
10969 (procedure) The procfunc no longer receives a case number. All
10970 references changed.
10971 (write_case) Subtle reordering.
10972 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10975 * weight.c: (get_weighting_variable) New function.
10977 * vfmP.h: New file with definitions from vfm.c.
10979 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10981 * command.c: (FILE_TYPE_okay) Commented out some tests because
10982 they're clumsy and not yet needed.
10984 * var.h: Most *_trns structures moved to their respective source
10985 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10986 (union any_trns) Changed to a typedef for trns_header.
10987 (struct input_program_pgm) Removed.
10989 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10990 was allocated in the first place.
10992 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10994 * autorecode.c: New file.
10996 * command.c: Added AUTORECODE to command table; re-enabled SET.
10998 * data-out.c: (convert_F) Handles infinities and NaNs properly.
11000 * error.c: (vmsg) Comment fixes.
11002 * hash.c: Comment fix.
11003 (hashpjw_d) New function.
11004 (hashpjw) Reimplemented as call to more general function
11006 (internal_comparison_fn) Initializes pointers properly.
11007 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
11008 (force_hsh_insert, force_hsh_find) New debugging wrapper
11011 * main.c: (main) Message fix.
11013 * output.c: (outp_read_devices) Message fix.
11015 * set.q: Comment fixes.
11016 (custom_results) Implemented Wnd/X form of subcommand.
11017 (set_routing) New function.
11018 (internal_cmd_set) Implemented ERRORS, MESSAGES.
11020 * settings.h: (SET_ROUTE_*) New enum series.
11021 (set_results) Renamed set_results_file, all references changed.
11022 (set_messages) Removed.
11023 (glob vars set_errors, set_messages, set_results) New vars.
11025 * title.c: (get_title) Remembers to xstrdup() the result of
11026 get_rest_of_line().
11028 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
11030 (union any_trns) New element `arc'.
11032 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
11034 * command.c: (output_line) Removed references to set_screen.
11036 * error.c: (static var terminating) New var.
11037 (hcf) Sets terminating to 1.
11038 (vmsg) If terminating is nonzero, does not attempt to call hcf().
11039 This prevents an infinite loop if an error occurs within hcf().
11041 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
11042 statement circumlocution with `case 42000' trick.
11043 (evaluate_expression) New support for OP_STR_MIS.
11045 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
11046 statement circumlocution with `case 42000' trick.
11047 (dump_node) Handles OP_STR_MIS.
11049 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
11050 variables exceptions.
11051 (parse_function) Message fix.
11052 (ops[]) Added OP_STR_MIS.
11054 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
11056 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
11058 * glob.c: Removed set_scrnfile glob var.
11059 (init_glob) set_errorbreak set to 0 by default.
11061 * groff-font.c: Changed included files.
11062 (groff_read_font) Initializes font_arena local var correctly.
11063 (default_font) New function.
11065 * output.c: Comment fixes.
11066 (glob var disabled_devices) New variable.
11067 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
11069 [GLOBAL_DEBUGGING] (reentrancy) New function.
11070 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
11071 outp_iterate_enabled_drivers) Calls to reentrancy().
11072 (destroy_list) New function.
11073 (outp_done) Moved code to destroy_list().
11074 (parse_options) Parses `listing', `screen', `printer' options
11076 (configure_driver) Sets new `device' member of driver.
11077 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
11079 * output.h: Comment fixes. New enum series OUTP_DEV_*.
11080 (struct outp_driver_struct) New member `device'.
11082 * postscript.c: (find_encoding_file) Doesn't display its own error
11084 (default_encoding) New function.
11085 (switch_font) Calls default_encoding() if no encoding can be
11087 (text) Makes up a character metric if none exists for the desired
11089 (load_font) Properly copies a fallback filename. Calls
11090 default_font() for a font if none at all are known.
11092 * set.q: Comment fixes. Removed OUTPUT subcommand.
11093 (custom_listing) Calls outp_enable_device() to enable/disable
11095 (turn_screen_on) Removed.
11096 (internal_cmd_set) Calls outp_enable_device() to enable/disable
11097 screen, printer devices.
11099 * settings.h: Comment fixes.
11100 (glob vars set_output, set_printer, set_screen, set_scrnfile)
11103 * som-high.c: (som_submit_table, som_eject_page) Use
11104 outp_iterate_enabled_drivers() instead of iterating
11105 outp_driver_list directly.
11107 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
11109 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
11110 (parse_string_as_format) Handles new formats.
11111 (parse_numeric) Now handles DOT and PCT formats.
11113 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
11115 (convert_date) Handle EDATE and SDATE formats.
11116 (convert_CCx) Now if there's not room for the currency characters,
11117 converts it as F format if it's positive instead of giving up
11118 quickly. Also fixed save-and-restore bug with decimal point
11120 (convert_format_to_string) Handles new formats.
11122 * misc.c: (formats[]) Added new formats.
11123 (convert_fmt_ItoO) Supports new formats.
11125 * sfm-read.c: (parse_format_spec) Supports new formats. Better
11126 data checking. New argument, all references changed.
11128 * sfm-write.c: (write_format_spec) Supports new formats.
11130 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
11133 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
11135 * cmdline.c: Comment fixes.
11136 (parse_command_line) Changed return type to void.
11138 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
11140 (parse_numeric) Handles international numbers (comma as decimal
11141 point). Some reformatting.
11143 * data-list.c: (parse_free) Default output format is now
11144 set_format instead of hard-coded F8.2.
11145 (read_from_data_list_list) Emits error message on undefined data
11146 only if set_undefined is nonzero.
11148 * data-out.c: (convert_E) Changes decimal point from period to
11149 comma if appropriate. Restructured. Better comments.
11150 (convert_F) Changes decimal point from period to comma if
11152 (insert_commas) Major bug with handling of negative values fixed.
11153 Also, inserts periods instead of commas if appropriate.
11154 (convert_CCx) New function.
11155 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
11156 (num_to_string) Changed `.' to set_decimal.
11158 * dfm.c: Comment fixes.
11159 (dfm_close) Frees ext->line even in inline_file.
11160 (open_inline_file) New function.
11161 (open_file_r) When opening the inline file: now properly
11162 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
11164 (read_record) Calls fh_close_handle() instead of dfm_close() to
11165 close the inline file. Makes a copy of the line getl_buf to avoid
11166 interlock problems.
11167 (dfm_get_record) Restructured. Now checks the return value of
11169 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
11170 checking for use of inline file. No longer tries to close inline
11173 * error.c: (glob var error_already_flagged) New var.
11174 (vmsg) Message change. Now checks max number of errors/warnings,
11177 * file-handle.q: (fh_handle_name) Now allows closing of
11179 (fh_init_files) Reformatted.
11181 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
11183 * getline.c: (getl_include) Fixed bug that popped up when called
11184 when file queue was empty.
11185 (read_console) Resets error_count, warning_count,
11186 error_already_flagged to zero.
11188 * glob.c: Many changes to update list of variables.
11189 (init_compat_dependent) Now this function is called whenever
11190 `compat' changes. It now sets set_seed only if it hasn't
11191 previously been referenced. It now calls
11192 lex_init_compat_dependent().
11194 * include.c: (cmd_include_at) Frees temporary buffer instead of
11196 (cmd_include) Doesn't make copy of include file name.
11198 * lexer.c: Comment fixes.
11199 (init_lex) Moved some code into new function
11200 lex_init_compat_dependent().
11201 (lex_init_compat_dependent) New function.
11202 (hex_val) Simplified.
11203 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
11205 * main.c: Comment fixes.
11206 (main) Reformatted.
11208 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
11209 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
11210 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
11211 (setup_randomize) Sets set_seed_used.
11213 * set.q: Comment fixes.
11214 (custom_results) Conditionalizes on `compat'.
11215 (custom_log) Calls custom_journal().
11216 (set_ccx) New function.
11217 (cmd_set) Calls init_compat_dependent() when `compat' changes.
11218 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
11219 when set_decimal changes. Range-checks values for MITERATE,
11220 MNEST. Message fixes.
11222 * settings.h: Comment fixes.
11223 (struct set_cust_currency) New struct.
11224 (set_cc[], set_grouping, set_seed_used) New global vars.
11226 * var.h: (FMT_CCA...FMT_CCE) New output formats.
11227 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
11229 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
11231 * glob.c: Revised variables to correspond to settings.h.
11232 (init_glob) Initializes variables from settings.h properly.
11234 * set.q: Began long-overdue major revision to correspond to new
11235 philosophy. Most code changed.
11237 * settings.h: Mostly changed; reorganized, reordered, large new
11240 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
11242 * get.c: (cmd_save_internal) No longer forces compression off.
11244 * sfm-read.c: (read_compressed_data) If eof is reached when
11245 reading a new instruction octet, only signal error if we're in the
11248 * sfm-write.c: (COMPRESSION_BIAS) New #define.
11249 (struct sfm_fhuser_ext) New member `end'.
11250 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
11251 (ensure_buf_space) New function.
11252 (sfm_write_case) Reimplemented in order to support compression.
11253 (sfm_close) Writes out the remaining contents of the compression
11256 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
11258 * command.c: Defined SAVE and XSAVE commands in command table.
11260 * common.h: second_lowest_value is of type flt64, not double.
11262 * file-handle.h: Comment fix.
11264 * get.c: Comment fixes.
11265 (static var `trns') New.
11266 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
11267 cmd_save_internal, cmd_save, cmd_xsave) New functions.
11268 (dict_delete_run) Clears the variables and frees them now.
11269 (trim_dictionary) Sets default for compression.
11270 On KEEP subcommand, frees deleted variables as well as clearing
11271 them. Finally got the sense of the test for deleting all
11273 [DEBUGGING] (dump_dict_variables) Message fix.
11275 * glob.c: (init_glob) set_compression set to 1 by default.
11277 * list.q: Properly #includes config.h.
11279 * misc.h: New macro REM_RND_UP.
11281 * settings.h: Comment fix.
11283 * sfm-read.c: (structs sysfile_header, sysfile_format,
11284 sysfile_variable; inline function bswap_int32) Moved to new file
11286 (corrupt_msg) [__CHECKER__] No longer induces segfault.
11287 (sfm_read_dictionary) Fixed bug caused by failing to initialize
11289 (read_machine_flt64_info) Fixed some problems caused by confusion
11290 between flt64 and double types.
11291 (read_header) Message fix.
11292 (read_variables) Fixed set of cases in which we byte-swap sv.print
11293 and sv.write. Fixed confusion of flt64 and double.
11295 * sfm.h: (struct sfm_write_info) New.
11297 * som-high.c: (som_draw_title) Properly frees `s'.
11299 * temporary.c: (save_dictionary) Comment fix.
11301 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
11302 (struct trns_header) Formatting fix.
11303 (struct save_trns) New.
11305 * vars-atr.c: (discard_variables) Comment fix.
11307 * sfm-write.c: New file, baseline release.
11309 * sfmP.h: New file, baseline release.
11311 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
11313 * cmdline.c: (parse_command_line) `--version' output updated.
11314 (glob var syntax_message[]) Added my e-mail address.
11316 * file-handle.q, lexer.c, vfm.c: Changed many instances of
11317 `illegal' to `invalid'.
11319 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
11320 uncompression buffer.
11321 (sfm_close) Frees decompression buffer.
11322 (sfm_read_dictionary) Initializes decompression buffer.
11323 (buffer_input, read_compressed_data) New functions.
11324 (sfm_read_case) Restructured; now calls read_compressed_data() to
11325 handle compressed system file data.
11327 * var.h: Comment fix.
11329 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
11331 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
11334 * get.c: New comments. New static var `get_file'.
11335 (cmd_get) Now fully implemented. Calls discard_variables();
11336 initializes fv and lv for all variables; new debug code; sets
11337 up the dictionary; sets up the input program.
11338 (read_from_get, cancel_get) New functions.
11340 * sfm-read.c: Comment fixes.
11341 (sfm_close) New static function.
11342 (sfm_read_dictionary) Properly sets up the class of the
11343 file_handle. No longer cares what size the data is in records of
11344 type 7. Also, on failure, properly cleans up the file_handle and
11345 free()s some stuff.
11346 (read_variables) No longer thinks it knows `nval' of the
11347 dictionary. Now sets p.get.fv, etc., instead of speculatively
11349 (read_value_labels) Fixed off-by-one error in indexing of
11351 (sfm_read_case) New function.
11352 (sfm_r_class) New static var.
11354 * var.h: (get_proc) New struct.
11355 (struct variable) New member p.get.
11357 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
11359 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
11360 the manual's meaning.
11361 (rename_variables) New function.
11362 (trim_variables) Doesn't try to parse MAP any more. Removed debug
11363 code. Now properly reorders the dictionary on the KEEP keyword.
11365 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
11366 garbage collection.
11368 * vars-atr.c: (clear_variable) New argument `dictionary *'.
11369 (rename_variable) New function.
11370 (free_val_lab) Reformatted.
11372 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
11374 * var.h: Reindented entire file. Comment fixes.
11375 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
11377 (glob var default_dict) New.
11378 (struct indirect_dictionary) Removed.
11380 * Many other source files were changed to add `default_dict.'
11381 before all references to the dictionary of the active file.
11383 * vars-atr.c: (make_indirect_dictionary) Removed.
11385 * glob.c: Reindented all variable declarations. Updated for
11386 changed var.h. Comment fixes.
11388 * temporary.c: (restore_dictionary, save_dictionary) Simplified
11389 because now we can mainly copy dictionary structs.
11391 * vars-prs.c: (is_dict_varname, parse_dict_variable,
11392 parse_variables) Takes dictionary instead of indirect_dictionary
11394 (parse_variables) Instead of calling make_indirect_dictionary,
11395 just sets DICT to &default_dict if DICT is NULL. Of course, lots
11396 of `*dict.' references had to be changed to `dict->'. Removed
11399 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
11401 * get.c: Added GTSV_OPT_* series of enums.
11402 (trim_dictionary, dict_delete_run) New functions.
11403 [DEBUGGING] (dump_dict_variables) New function.
11404 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
11405 [DEBUGGING] Calls dump_dict_variables() to display results.
11407 * glob.c: (cmp_variable) Now a public function declared in var.h.
11409 * sfm-read.c: Turned off debug code. Comment fixes.
11410 (read_machine_int32_info, read_machine_flt64_info) New functions
11411 to parse type 7 records.
11412 (sfm_read_dictionary) Properly byteswaps several fields now.
11413 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
11414 records. [DEBUGGING] Dumps dictionary.
11415 (read_variables) Sets `index' field of variables created properly.
11416 Constructs avl tree of variables in dictionary. [DEBUGGING] No
11417 longer dumps dictionary.
11418 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
11420 [DEBUGGING] (dump_dictionary) No longer stubbed out.
11422 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
11423 var before destroying any variables just to save a little time.
11425 * var.h: (struct variable) Reordered in order to make name[] the
11426 first member; this makes pointers to `variable' pointers to the
11427 variable name, simplifying avl trees, etc.
11428 (struct indirect_dictionary) New struct.
11430 * vars-atr.c: (find_variable) Rewritten for efficiency.
11431 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
11433 (is_varname) Rewritten for efficiency.
11434 (parse_variables) New argument, which is a `dictionary *'. All
11435 references changed. This function now reads variable names from
11436 the dictionary passed, or from the default dictionary if NULL.
11438 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
11440 * misc.h: Added new macro DIV_RND_UP to perform integer division,
11441 rounding up. Changed many references to ROUND_UP to use this
11444 * sfm-read.c: Includes avl.h.
11445 (corrupt_msg) Induces a segfault under Checker.
11446 (macro assertive_bufread) New. Many references to bufread() now
11448 (sfm_read_dictionary) Split up into several functions. Added code
11449 to read dictionary records following the the type 2 records. Not
11450 quite complete. New variable `var_by_index'.
11451 (read_header, read_variables) New functions extracted from
11452 sfm_read_dictionary().
11453 (read_value_labels) New function.
11454 (bufread) Checks ferror() if fread() doesn't return the expected
11455 value; if ferror() is zero it's just EOF.
11456 (dump_dictionary) Stubbed out.
11458 * BTW: The source code now exceeds 50000 lines!
11460 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
11462 * command.c: Added GET to cmd_table[].
11464 * list.q: Removed reference to alloca headers.
11465 (cmd_list) Gave prototype.
11467 * sfm-read.c: Added DEBUGGING comments.
11468 (sfm_read_dictionary) Checks bias correctly. Sets
11469 dict->var_by_name to NULL. Calculates long_string_count
11470 correctly. realloc's dict->var[] array to minimum size.
11471 [DEBUGGING] Calls dump_dictionary.
11472 [DEBUGGING] (dump_dictionary) New function.
11474 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11475 (restore_dictionary) If the dictionary contains a non-NULL
11476 var_by_name, uses that instead of generating one.
11477 (free_dictionary) Destroys var_by_name.
11479 * var.h: (struct dictionary) Added field `var_by_name'.
11481 * get.c: New file, not complete.
11483 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11485 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11486 (parse_num_or_range) New function.
11487 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11488 <n> THRU HIGH missing values.
11490 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11491 __attribute__((const)).
11493 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11495 * sfm-read.c: Finished reference implementation.
11497 * sfm.h: Includes var.h.
11499 * var.h: Comment fixes.
11500 (struct `variable') Reordered some fields.
11502 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11503 constants added previously.
11505 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11507 * common.h: Comment fixes. Added declaration of
11508 `second_lowest_value' as variable or macro. Made `compat_type',
11509 `pgm_state_type' into anonymous enums.
11511 * display.c: Comment fix.
11513 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11515 [!defined SECOND_LOWEST_VALUE] Added definition for
11516 `second_lowest_value' global var.
11517 (compat, pgm_state global vars) Changed types to `int'.
11518 (init_glob) Initializes `second_lowest_value'.
11520 * sfm-read.c: Continued work, not complete.
11522 * var.h: Added new MISSING_* constants to handle LOWEST and
11525 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11527 * sfm-read.c: New file, not complete.
11529 * cases.c: (vec_insert) Changed vector expansion algorithm.
11530 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11531 mucking up the RECODE transformation in particular.
11532 (envector) Harmless change in notation.
11534 dfm is now fairly well tested again.
11535 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11537 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11539 * recode.c: Comment fix.
11541 * sfm.h: Interface should be fairly final now, or at least for a
11544 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11545 (open_active_file) [DEBUGGING] Translates ccase indices into
11546 variable names now to make it easier to understand what's really
11549 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11551 * data-in.c: Comment fix.
11553 * data-list.c: Includes dfm.h.
11554 (do_reading) Uses new function dfm_push_cust().
11556 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11557 `return 1;' at end.
11559 * file-handle.h: Completely changed. Some parts split off into
11560 new file dfm.h. Implemented in file-handle.q.
11561 (enum FH_*) Removed.
11562 (struct fh_ext_class) New struct.
11563 (struct file_handle) Retained only these fields: name, norm_fn,
11564 fn, recform, lrecl, mode. New fields class, ext.
11565 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11566 close_handle, handle_name) Added `fh_' prefix to name, all
11567 references changed.
11569 * dfm.h: New file, implemented in dfm.c.
11570 (get_record, put_record, fwd_record, bkwd_record, set_record,
11571 get_cur_col) Functions moved from file-handle.h, now prefixed with
11573 (dfm_push_cust) New function.
11575 * sfm.h: New file. Incomplete.
11577 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11578 interface. Functions reordered, comments changed. Not well
11579 tested, probably full of bugs.
11580 (struct dfm_fhuser_ext) New struct.
11581 (dfm_close) New function.
11582 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11583 (open_file_w) User messages changed.
11584 (get_record) Comment fixed.
11585 (read_record) Increments ext->ln even for inline_file. Calls
11586 dfm_close() for inline_file when `END DATA.' encountered.
11587 (dfm_get_record) Experimental restructuring.
11588 (dfm_push_cust) New function.
11589 (cmd_begin_data) Detects whether the inline file was fully read by
11590 checking whether it is still open; detects whether it was read at
11591 all by checking whether the line number is greater than zero.
11593 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11594 interface. Functions reordered, comments changed. Not well
11595 tested, probably full of bugs.
11596 (init_file_handle) Removed initializers for obsolete fields, added
11598 (fh_close_handle) Much simpler, now mainly calls the class
11600 (fh_init_files) Renamed inline file internal filename.
11602 * file-type.c: Includes dfm.h.
11603 (read_from_file_type) Doesn't use dfm internal state anymore.
11605 * inpt-pgm.c, print.c: Include dfm.h.
11607 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11608 int in comparison with other int.
11610 * som-high.c: (build_target) Fixed operator precedence problem in
11611 if statement (& versus ==).
11613 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11615 * dfm.c: (read_record) Can now read fixed-length records; not
11617 (put_record) Can now write fixed-length records; not tested.
11619 * file-handle.h: FH_* defines changed to enums. New enum series
11621 (struct file_handle) New members recform, lrecl, mode.
11623 * file-handle.q: Parser changed.
11624 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11625 /LRECL subcommands. These are compatible with Windows.
11626 (init_file_handle) Initializes recform, mode fields.
11628 * q2c.c: (get_line) When outputting `!' comment lines, now
11629 increments the output file line number so that `#line' directives
11631 (make_identifier) New function that converts an arbitrary string
11632 into a valid C identifier.
11633 (dump_vars) Calls make_identifier() in two places in order to
11634 suppress some errors for bad identifiers.
11635 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11636 for NO. Allows numbers to be prefixed by underscores to make them
11637 acceptable C identifiers but still to be parsed as numbers by the
11640 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11642 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11644 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11645 was opened for writing.
11646 (open_file_w) New function.
11647 (read_record) Uses strncasecmp if available. Improved error
11648 messages, comments.
11649 (put_record) New function.
11651 * file-handle.h: Moved function comments into dfm.c and
11652 file-handle.q. Comment fixes. Removed declarations of
11653 tilde_expand() and normalize_filename().
11654 (struct file_handle) Changed `open' from boolean to enumerated
11655 field to allow for three states--closed, open for reading, open
11656 for writing--all references changed.
11658 * file-handle.q: Includes filename.h.
11660 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11661 references changed.
11662 (alloc_line) Makes allowance for line terminator characters in
11664 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11665 (print_space_trns_proc) Handles OUTFILE differences.
11667 * recode.c, sample.c: Comment fixes.
11669 * var.h: (struct print_trns) Changed boolean field `eject' to
11670 bitmapped field `options'; all references changed. New enums
11671 PRT_* for use with this field.
11673 * exception.h, test-exception.c: Removed.
11675 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11677 * ascii.c: (delineate) Turned off debug output.
11679 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11682 * data-in.c: (parse_string_as_format) Sets the entire string value
11683 to spaces, not just the short string part of it. Is this correct
11686 * data-out.c: (convert_date) Fixed DATETIME format problems with
11687 decimal places, removed debug code.
11689 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11690 middle of parsing BEGIN DATA that would cause the lexer to read
11691 from a wild pointer `prog'; now calls new function
11692 preprocess_line() in lexer.c.
11694 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11696 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11697 Now call induce_segfault() to induce the segfault.
11698 (induce_segfault) New function.
11700 * expr-opt.c: Comment fix.
11701 (parse_sysvar) New function.
11702 (parse_primary) Added system variable support--calls
11704 (global var ops) Added OP_CASENUM operator.
11706 * expr.h: Comment fixes.
11707 (OP_* enum) added OP_CASENUM operator.
11708 (struct casenum_node) New struct.
11709 (union any_union_union) New member `cas' of type `casenum_node'.
11711 * glob.c: (global var last_vfm_invocation) New var.
11712 (init_glob) Initializes last_vfm_invocation.
11714 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11716 * getline.c: (get_line) Split into get_line() and preprocess_line().
11717 (preprocess_line) New function.
11719 * var.h: Declares last_vfm_invocation.
11721 * vfm.c: (procedure) Sets last_vfm_invocation.
11723 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11725 * command.c: (parse_cmd) Fixed bad assertion related to
11728 * data-in.c: (parse_month) Implemented to parse months according
11729 to full interpretation of standard.
11730 (to_roman) New function.
11731 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11732 (parse_weekday) Bug fix (forgot to skip all the day name).
11734 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11735 up parsing of multirecord data items. Also fixed user message.
11737 * data-out.c: Comment fix.
11738 (year2, year4, convert_date, convert_time, convert_WKDAY,
11739 convert_MONTH) New functions to support time & date output.
11740 (convert_format_to_string) Calls new time & date output routines.
11742 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11744 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11747 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11749 * misc.c: (global var formats) Fixed declarations of DATETIME,
11752 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11753 the output_char buffer.
11755 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11756 memory bug. Fixed user messages.
11758 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11760 * Removed #pragma argsused from lots of places.
11762 * data-in.c: Implemented zoned decimal and time-date formats.
11763 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11766 * data-out.c: Implemented zoned decimal format.
11768 * expr.h: Moved yrmoda() declaration here from exprP.h.
11770 * misc.c: (global var formats) Minor fixes--added
11771 FCAT_SHIFT_DECIMAL to formats N and Z.
11772 (convert_fmt_ItoO) Added support for format Z.
11774 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11776 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11778 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11779 som_check_workspace() that is activated between commands.
11781 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11784 * list.q: (begin_row) Changed title expansion style from
11785 SOPT_X_VERT to SOPT_X_SHSP.
11787 * som-frnt.c: Now includes `somP.h'.
11788 (som_push_workspace, som_pop_workspace) New functions that, taken
11789 together, form a solution to the recursive table building problem
11790 mentioned yesterday. Surrounded every table output routine
11791 throughout the program with calls to these functions.
11792 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11793 (som_create_table) Checks that there's an active workspace.
11794 (som_destroy_all_tables, som_crush) Removed.
11796 * som-high.c: (global var som_preserve_tables) Removed, all
11797 references deleted.
11798 (som_submit_table) Checks that there's an active workspace.
11799 (dump_columnated_table) Doesn't columnate tables that would have
11800 just one row per column.
11801 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11802 (som_dump_crush_page) Moved row number labels from left side of
11803 tables to right side.
11804 (som_get_table_size) Added support for SOPT_X_SHSP.
11806 * som.h: New cell expansion type SOPT_X_SHSP.
11808 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11810 (global var curtab_arena) Moved from som-frnt.c.
11812 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11814 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11815 that causes bad location warnings to be suppressed.
11816 (delineate) Saves current font when calling draw_text(); fixed
11817 handling of NULLs when backing up. Also fixed line-wrapping bug.
11819 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11820 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11822 * common.c: Added code to cause assertion failure to dump core
11823 when run under Checker.
11825 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11826 there are still bugs.
11828 * glob.c: (__eprintf) Removed.
11830 * list.q: Inserted som_preserve_tables kluge that prevents tables
11831 from being thrown away due to recursive table building through
11832 som_output_line being called from a transformation during the LIST
11833 procedure invocation. This is a general problem that must be
11834 solved in a better way since it applies to all procedures in
11836 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11837 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11839 * numeric.c: Fixed several errors in the form of msg() calls.
11841 * print.c: Updated for use of som.
11842 (dump_table) Reimplemented.
11843 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11844 Calls som_output_text() instead of outs_line().
11846 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11848 (som_output_text) Function moved from som-low.c. Interface
11851 * som-high.c: (som_preserve_tables) New global public variable
11853 (som_submit_table) Destroys the tables only if som_preserve_tables
11855 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11856 one subrow per row. Now labels subrows if there's more than one
11858 (dump_crush_table) Added wishlist comment.
11859 (som_eject_page) New public function declared in som.h.
11861 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11862 more than one subrow per row.
11863 (som_output_text) Moved to som-frnt.c.
11865 * som.h: (SOM_TOPT_PRESERVE) Removed.
11867 * title.c: (get_title) Changed interface.
11868 (cmd_title) Changed `title' to `outp_title'.
11869 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11871 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11873 * list.q: (flush_table) Conforms to new partial options in
11874 som_submission_form.
11876 * som-high.c: (paginate_horizontally) Changed form of subrow
11878 (build_target) Omits spacing before table if
11879 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11880 (dump_crush_page) Changed interface. Only trims bottom rule if
11881 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11882 (dump_crush_table) Handles partial tables.
11883 (output_row_label) New function.
11884 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11885 rule on the right edge of narrow subrows.
11887 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11888 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11889 All references updated.
11891 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11893 * misc.c: Comment fix.
11895 * som-high.c: (examine_table) Treats crushed tables separates for
11896 purpose of determining header size.
11897 (paginate_horizontally) Allots space for line numbers in crushed
11898 tables with lots of subrows per row. Calculates the `maximum page
11899 width', the width of the widest horizontal page.
11900 (build_target) Removed trim argument; all references changed.
11901 Stricter assertions. (dump_crush_page) New function.
11902 (dump_crush_table) Reimplemented.
11904 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11905 (som_dump_crush_page) Reimplemented, interface changed.
11907 * somP.h: Many many new helper macros for use with crushed tables.
11908 (global var som) Removed `tv', `cum_y' members; all references
11909 removed. New members `mpw', `digit_space'.
11911 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11913 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11914 variable, changed to constant 1024.
11915 (arena_ca_strdup) Changed `sizeof(a_string)' to
11916 `sizeof(c_string)'.
11917 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11918 `(c_string *)' to `(char *)'; this fixed some offset problems.
11920 * filename.c: (readlink_malloc) Changed initial allocation from
11922 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11925 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11926 &fm->owner in several places.
11928 * som-high.c: (output_table) Changed interface to rest of world.
11929 (examine_crush_table) Removed. Crushed tables are re-broken now,
11930 in preparation for rewrite.
11932 * som.h: Comment fix.
11934 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11936 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11937 itself in the cleanup stage.
11939 * descript.q: (display) At least temporarily, changed the table
11940 format to a crushed table.
11942 * list.q: (begin_row) At least temporarily, added horizontal lines
11945 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11946 the horizontal "headers," that is, to the width of the far left
11947 and far right rules.
11948 (justify_pagination) Sets som.th to the width of the widest row
11949 in the crushed table. Fixed inner loop off-by-one error.
11951 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11954 * somP.h: Comment fix.
11956 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11958 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11959 before closing it; also, opens the constructed filename `s'
11960 instead of f->filename.
11962 * postscript.c: Moved initialization of x->loaded, x->prop,
11963 x->fixed, x->current, also the add_encoding() calls, into
11965 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11966 sets x->last_font to NULL; sets x->next_combo to zero.
11968 * som-high.c: (crushed_row_height) Moved definition farther up.
11969 (som_submit_table) Doesn't calculate line width, font size until
11970 after calling open_page(), to accomodate changes to PostScript
11972 (vert_headers) Removed; equivalent functionality moved to
11973 examine_table(), examine_crush_table().
11974 (justify_pagination) Replaced with different algorithm.
11975 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11976 at the bottom of the page.
11978 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11980 * command.c: Added cmd_list back into cmd_table.
11982 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11983 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11985 * list.q: (flush_table) Updated to new som_submission_form format.
11987 * som-frnt.c: Comment fix.
11989 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11990 (output_table) Calls som_get_table_size() directly; handles
11992 (examine_crush_table) New function; calls vert_headers().
11993 (examine_table) Moved some code into new function, vert_headers().
11994 (justify_pagination) New function.
11995 (dump_plain_table) Removed `static' from `cy'.
11996 (dump_crush_table) New function.
11998 * som-low.c: (som_dump_crush_page) New function.
12000 * som.h: Comment fixes.
12001 (enum SOM_TOPT_CRUSH) New.
12002 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
12003 Temporarily set to zero to make do with LIST procedure.
12005 * somP.h: Re-ordering.
12007 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
12009 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
12011 * somP.h: New file for use by som-high.c, som-low.c.
12013 * q2c.c: Added definition for VME.
12014 (get_line) Now dumps `!' comment lines to the output file
12017 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
12018 set.q: Changed format of `!' comment lines.
12020 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
12022 * All source files: Added copyright notice.
12024 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
12025 longs in msg() calls.
12027 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
12029 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
12031 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
12033 * output.c: (outp_read_devices) Changed criteria for
12034 distinguishing different types of lines.
12036 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
12038 * cmdline.c: Changed syntax message.
12040 * filename.c: (good_getcwd) Bug fix (?).
12041 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
12043 (search_path) Appends DIR_SEPARATOR to directory name only if it
12044 does not already end with one.
12046 * glob.c: Checks STAT_PAGER envvar before PAGER.
12048 * output.c: Checks environment variables instead of just local
12051 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
12053 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
12054 when the pointer passed to the function was within the arena
12055 itself, so that it couldn't properly be set to NULL _after the
12058 * command.c: Re-enabled DISPLAY.
12060 * display.c: Rewritten to handle tables. Untested.
12062 * filename.c: (search_path) Fixed memory leak.
12064 * frequencies.q: (cmd_frequencies) Frees v_variables.
12065 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
12066 (cleanup_freq_tab) New function to garbage collect.
12067 (dump_full) Elegantized.
12069 * main.c: New comment.
12071 * output.h: New tag for tagged quotes: TAG_NEWLINE.
12073 * postscript.c: Comment fix.
12074 (release_fontmap, free_font_entry) New functions.
12075 (ps_init_driver) Sets free_font_entry() as the freefunc for
12076 hashtable `loaded'. Calls release_fontmap() when destroying a
12077 driver; also frees the output filename; also frees the
12078 ps_driver_ext block.
12079 (free_ps_encoding) Frees the filename as well as the encoding
12081 (output_encodings) Frees the line buffer and pops the msg-filename
12083 (read_fontmap) Frees the fontmap filename and the line buffer.
12084 (postopen, preclose) Misc. garbage collection fixes.
12085 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
12086 to NULL; this fixes some output problems.
12087 (text) Handles TAG_NEWLINE. Untested.
12089 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
12090 (som_set_string) Removed. All references changed to
12092 (som_set_text) Rewritten. New interface. More general.
12094 * som.h: Minor format changes.
12095 (struct som_value_cell) Removed; all references changed to
12097 (enums SOT_*) Changed.
12099 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
12101 * command.c: Re-enabled SPLIT FILE.
12103 * postscript.c: Comment fix.
12105 * som.h: Added `SOT_NONE'.
12107 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
12109 * vfm.c: (dump_splits) Reimplemented.
12111 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
12113 * Compiled the project under gcc 2.7.2, which gave some new
12114 warnings. This led to many additions of casts from unsigned to
12115 int sprinkled throughout the code.
12117 * arena.c: Many uses of `unsigned' changed to `size_t'.
12119 * command.c: Added END FILE, END REPEAT to command table.
12120 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
12121 (find_command, FILE_TYPE_okay) Not commented out anymore.
12122 (parse_cmd) Calls FILE_TYPE_okay again.
12123 (output_line) Added calls to som_output_text() to put the line
12124 in the output files.
12126 * common.c: (macro VME) Format changes.
12127 (xstrdup) Asserts that its argument is not NULL.
12129 * data-list.c: Implemented dump_fixed_table().
12131 * inpt-pgm.c: Formatting changes. Comment changes.
12132 (end_case_proc) Renamed end_case_trns_proc.
12133 (cmd_end_file, end_file_trns_proc) New functions.
12135 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
12137 * misc.h: (local_strdup) New macro corresponding to strdup() but
12138 allocating its data through local_alloc() if possible--that is, if
12141 * postscript.c: Comment changes.
12142 (quote_ps_name, quote_ps_string, output_encodings) New functions.
12143 (output_line, add_string) New macros supporting
12144 output_encodings().
12145 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
12146 substitution vars. Calls output_encodings() when a line
12147 consisting of `!encodings' is encountered.
12148 (preclose) Some code moved into quote_ps_string().
12149 (dump_line) Changed into macro supporting dump_fancy_line().
12150 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
12151 command when appropriate.
12152 (write_text) Fixed `literal_char' array (I think it's fixed, at
12154 (text) Fixed bug when width was zero. Now exits immediately on
12155 zero height_left. Now, when executing `goto restart;', checks
12156 that cp<end, so that we don't read beyond end-of-string. Also,
12157 outputs the correct code to the output file by outputting the code
12158 from the metric instead of the internal metric index.
12160 * repeat.c: (cmd_end_repeat) New function.
12162 * som.c: (var som) `headers' renamed `options' and semantics
12163 changed. All references changed.
12164 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
12165 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
12167 (som_text_table) Removed.
12168 (som_output_text) New function.
12170 * som.h: (struct som_submission_form) Removed `header', `reuse',
12171 replaced with bitmapped field `options'.
12172 (SOM_TOPT_*) New enum set for som_submission_form.options.
12173 (SOT_*) New enum set for som_output_text().
12175 * temporary.c: (copy_variable) When copying the var label, only
12176 calls xstrdup() if it's non-NULL.
12178 * var.h: (enum type `vartype') Removed; all references changed to
12181 * vars-atr.c: (init_variable) Changed local var `nbytes' from
12184 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
12186 * font.h: Comment changes.
12188 * groff-font.c: (groff_read_font) Initializes `name' field to
12189 NULL. Handles `encoding' field.
12191 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
12193 * postscript.c: (struct font_entry) Removed `position' field.
12194 (struct ps_font_combo) New struct.
12195 (struct ps_driver_ext) Removed field `next_position'. New fields
12196 `combos', `next_combo'. `last_font' field changed from
12197 `font_entry *' to `ps_font_combo *'.
12198 (ps_init_driver) Reformatted; handles new fields. When
12199 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
12201 (get_encoding, find_encoding_file) New functions.
12202 (add_encoding) Some code moved out into find_encoding_file().
12203 (postopen) Changed value for ${title}.
12204 (preclose) Sets `loaded' field to NULL after destroying the hash
12206 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
12208 (ps_text_set_font_by_position) Figures out the current family if
12210 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
12211 (switch_font) Implemented.
12212 (write_text) Calls switch_font() more often. Format changes.
12213 #undefs its macros after they're no longer useful.
12214 (text) Changed `continue' at one point to a jump to the top of the
12215 loop because we don't want `separate' reset to 0 at that point.
12216 (load_font) No longer sets `position' in the font_entry created.
12218 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
12220 * font.h: (struct font_desc) New member `encoding', which is not
12221 properly handled yet.
12223 * glob.c: (init_glob) Some new i18n code, which is probably
12226 * output.c: (outp_read_devices, outp_get_paper_size) Changed
12227 `size' local from `int' to `size_t'.
12229 * postscript.c: New driver configuration parameter `auto-encode'.
12230 New enums OPO_AUTO_ENCODE, ODA_COUNT.
12231 (struct font_entry) New member `position'.
12232 (struct ps_driver_ext) Reordered. New hash table member
12233 `encodings'; new members `next_position', `next_encoding',
12234 `last_font'. Members `current', `prop', `fixed' changed from type
12235 `font_desc *' to `font_entry *'; all references changed.
12236 (struct ps_encoding) New struct.
12237 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
12238 free_ps_encoding, add_encoding) New functions.
12239 (ps_init_driver) Added OPO_AUTO_ENCODE to default
12240 x->output_options. Initializes new members of ps_driver_ext.
12241 Changed default value for prologue_fn, encoding_fn. Calls
12242 read_ps_encodings after loading default fonts.
12243 (option_tab[], ps_option) Handle new configuration parameter.
12244 (switch_font) New function.
12245 (struct output_char) `font' member changed from `font_desc *' to
12246 `font_entry *'. New member `separate'.
12247 (read_fontmap) Changed `size' from `int' to `size_t'.
12248 (output_line, put_number) New macros for write_text().
12249 (write_text) Optimizes text output by consolidating multiple
12250 calls to PostScript `show' operator.
12251 (text) Keeps track of when text arguments can't be consolidated by
12252 write_text(), and marks those spots in the output stream.
12253 (load_font) Sets `position' of the allocated font_entry to -1, cuz
12254 the font hasn't been switched to by switch_font(), which is where
12255 the position is important--the PostScript is what cares about the
12258 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
12260 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
12261 call a NULL free_func.
12262 (hsh_rehash) Elegantized.
12263 (hsh_probe) Fix bug that manifested when the table was expanded
12264 and thus had to change location in memory. Good thing
12265 too--otherwise could have been much more subtle.
12266 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
12267 (hsh_foreach) New function for hash table iteration.
12269 * hash.h: (struct hsh_iterator) New.
12271 * lexer.c: (parse_tagged_quote) Font and family name strings in
12272 tags are now null-terminated.
12274 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
12276 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
12277 documented. (Never before tested?)
12279 * output.h: Comment changes.
12281 * postscript.c: New driver options `optimize-text-size',
12282 `optimize-line-size', `max-fonts-simult'. New enum set for
12283 specing cached line types. Comment fixes.
12284 (struct line_form) New struct.
12285 (struct ps_driver_struct) New members `text_opt', `line_opt',
12286 `max_fonts', `lines'.
12287 (ps_init_driver) Initializes new members of ps_driver_struct.
12288 (user option type enum set) New member `nonneg_int_arg'.
12289 (static var option_tab[]) Supports new options.
12290 (ps_option) Handles new options.
12291 (find_ps_file) Made static. No longer calls hsh_dump().
12292 (ps_get_var) Made static.
12293 (preclose) Dumps out proper DSC trailer.
12294 (ps_open_page) Elegantized.
12295 (ps_close_page) Calls dump_lines() if appropriate.
12296 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
12297 wrappers around line().
12298 (int_2_compare, compare_line, dump_line, dump_fancy_line,
12299 dump_lines, hash_line, free_line, line) New functions for support
12301 (write_text, text) Made static.
12302 (text) Added to font support, not finished.
12304 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
12306 * font.h: (struct font_desc) New members ascent, descent.
12308 * groff-font.c: (groff_read_font) Calculates font ascent and
12309 descent from the ascent and descent of the `d' and `p' characters,
12310 respectively, as per a suggestion on comp.fonts.
12312 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
12313 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
12315 (write_text) Handles text right-justification and centering (not
12316 full justification). Still very inefficient. (One output line
12318 (struct output_char) Added fields for font and font size.
12319 (text) Many bugfixes.
12321 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
12323 * cmdline.c: (usage) Calls outp_list_classes().
12325 * font.h: Comment fix.
12327 * groff-font.c: New exported global var `space_index'.
12328 (groff_init) New function to initialize `space_index'.
12329 (hash_kern) Casts result to unsigned.
12330 (font_name_to_index) Renamed font_char_name_to_index. All
12331 references changed. Also, now returns the value of `space_index'
12332 when passed an ASCII space character as an argument. Fixed
12334 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
12335 Handles passed NULL pointers properly.
12337 * lexer.c: (parse_tagged_quote) Comment fix. Better range
12340 * output.c: (outp_list_drivers) Removed. Removed all references.
12342 * output.h: Comment fixes.
12344 * postscript.c: (ps_open_global) Calls groff_init().
12345 (output_char) New structure.
12346 (write_text) New function.
12347 (text) No longer stubbed out! Now the output is correct--with a
12348 few exceptions, one of them being that the page has to be held
12349 upside down into a mirror.
12351 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
12353 * font.h: Comment fix.
12355 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
12356 All callers changed.
12357 (number_to_index) Renamed font_number_to_index, made extern. All
12359 (font_get_kern_adjust, font_get_char_metrics) New functions.
12361 * output.h: New constant OUTP_T_INTERNAL_DRAW.
12363 * postscript.c: Changed default line width back to 1/2 point.
12364 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
12365 in the center of the space allotted for them, not just a fixed
12366 offset from the edge of the space; this fixes some bugs.
12367 (ps_line_intersection) Now supports all command line styles.
12368 (ps_text_get_size) Bug fix in computation of em width.
12369 (text) New function, the meat behind ps_text_metrics and
12370 ps_text_draw. Not complete.
12371 (ps_text_metrics, ps_text_draw) Removed the stub taken from
12372 ascii.c; call text().
12374 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
12376 * arena.c: (arena_free) Assert that the argument is non-NULL.
12378 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
12379 only if old_kern is non-NULL.
12381 * postscript.c: (ps_init_driver) Changed default line width to 1
12383 (postopen) New prologue variables.
12384 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
12385 more of the common line styles properly, but not all.
12386 (ps_text_metrics) Fixed problem with this stubbed out version that
12387 kept it from taking font sizes into account.
12389 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
12391 * arena.c: (arena_malloc) Bug fix.
12392 (arena_dump) [GLOBAL_DEBUGGING] New function.
12394 * ascii.c: Comment fix.
12395 (count_fancy_chars, delineate) Now static functions.
12397 * filename.c: (interp_vars) Bug fixes.
12399 * font.h: Comment fixes.
12401 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
12402 beginning in case we have an error message to display before
12403 initializing the display.
12405 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
12407 (groff_read_font) Bug fixes.
12408 (name_to_index) Increments hash.used. Sets `name' field of hash
12410 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
12412 * hash.c: Return type changed.
12414 * postscript.c: Continued development. Now marks lines on the
12415 paper, but very buggy.
12417 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
12419 * Changed comments in many source files from `/* xxx /* yyy */' to
12420 `/* xxx */ /* yyy */' for cleanliness.
12422 * arena.c: (arena_sd_strdup) New function.
12424 * ascii.c: (struct ascii_driver_ext) New member `file'.
12425 (ascii_init_driver) Fills out member `file' for initing; uses
12426 close_file_ext for closing drivers.
12427 (ascii_option) Changed %.*s back to %s because the a_string's are
12428 always null-terminated.
12429 (postopen, preclose) New functions.
12430 (ascii_open_page) Uses new style of open_file_ext.
12431 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
12432 instead of this->output.
12433 (__assert_fail) Removed.
12435 * cmdline.c: Changed syntax_message[].
12437 * error.c: #include's <readline/history.h> only if the history
12438 library is available, not if just the readline library is
12441 * filename.c: (expand_line) Removed alloca() support.
12442 (interp_vars) No longer tilde-expands argument. Limit on output
12444 (tilde_expand) Now treats argument as path rather than filename.
12445 [!unix] Now is a no-op function.
12446 (search_path) Better verbose message formatting.
12447 (open_file, close_file) Comment fixes.
12448 (close_file) [!unix] Doesn't bother with pipes.
12449 (open_file_ext) Completely rewritten, interface revamped.
12450 (close_file_ext) New function.
12452 * font.h: Comment changes.
12454 * frequencies.q: Removed AIX alloca support since it doesn't use
12457 * hash.c: Comment changes & additions.
12458 (hsh_create) Initializes entire table instead of first M entries.
12459 (hsh_probe) Stupid bug fixed. Now it works.
12460 (hsh_dump) [GLOBAL_DEBUGGING] New function.
12462 * main.c: (parse) Detects EOF properly in token-eating loop.
12463 Should the STOP token have its value changed to 0?
12465 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12466 (blp_getline) Now it's a macro.
12468 * output.h: (struct outp_driver) Removed members output, filename.
12470 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12471 drivers in driver table.
12472 (outp_read_devices) Frees buf. Warns if there are no active
12474 (outp_configure_clear) Sets outp_configure_vec to NULL after
12475 deleting its elements.
12476 (configure_driver, destroy_driver) Removed references to output,
12477 filename members of outp_driver.
12478 (outp_evaluate_dimension, internal_get_paper_size,
12479 outp_get_paper_size) New functions.
12481 * postscript.c: Continued development. Now links but doesn't make
12482 any marks on the page. Lotsa bugs I suppose.
12484 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12486 * str.h: Comment changes.
12488 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12490 * Removed dependencies on non-nested comments in several files.
12491 Also removed references to (unix || __unix__) in #if's since
12492 prefh.orig makes those two equivalent.
12494 * ascii.c: (ascii_open_global) Creates ascii_arena.
12495 (ascii_close_global) Destroys ascii_arena.
12496 (ascii_init_driver) Doesn't create ascii_arena.
12497 (ascii_copy_driver) Removed.
12498 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12499 (outp_class ascii_class) Removed ascii_copy_driver reference.
12501 * frequencies.q: Now can display all statistics except median.
12502 Still not finished.
12504 * output.c: Handles outp_class.ref_count so output class
12505 destructors are called properly.
12506 (add_class) Sets ref_count to 0.
12507 (configure_driver) Initializes class if ref_count++ is 0.
12508 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12509 class output file name.
12511 * output.h: (struct outp_class) Removed copy_driver, inited.
12514 * postscript.c: Completely replaced but not finished.
12516 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12518 * approx.h: #includes <float.h>.
12520 * arena.h, arena.c: Many functions changed to take an arena **
12521 instead of an arena *, for consistency. All callers changed.
12522 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12523 (arena_destroy) Sets *A to NULL.
12525 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12526 assertion that `width' be positive.
12528 * command.c: Removed #if's from cmd_table.
12529 (walk_cmdtable_func) [0] New function (debug code).
12530 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12531 (parse_cmd) Doesn't return failure for unimplemented commands.
12533 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12534 (SYSCODE) New constant macro.
12536 * descript.q: Checks for positive n_variables before performing
12539 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12540 avl_find instead of &fp as arg 2.
12542 * frequencies.g, frequencies.q: Continued updating; now compiles &
12543 works again, but not complete.
12545 * main.c: Changes to user messages.
12547 * misc.c: (reverse) [0] New function.
12549 * settings.h: Comment removed. #includes "common.h".
12551 * som.c: (som_set_null) New function.
12552 (som_set_value, som_set_string, som_set_text) More detailing
12554 (som_set_float) Implemented function.
12555 (dump_columnated_table) Bug fix regarding page breaks.
12556 (draw_cell) Bug fix regarding text that spilled out of a cell.
12557 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12559 (get_cell_size) Support SCON_EMPTY cells.
12560 (get_table_size) When calculating rules' widths and heights, mask
12561 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12563 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12565 (struct som_submission_form) New member `header'; all users
12568 * val-labs.c: (get_label) User messages changed.
12570 * var.h: Changed FREQUENCIES structures.
12572 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12575 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12577 * approx.h: Definition of EPSILON now depends on system's
12578 DBL_EPSILON. Removed GNU C specific code.
12579 (cmpapx) Renamed approx_compare.
12581 * frequencies.g, frequencies.q: Continued updating; still doesn't
12584 * groff-font.c: (name_to_index) Fix bug that kept it from
12587 * hash.c, hash.h: Completed work.
12589 * var.h: Changes to freq_tab, frequencies_proc.
12591 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12594 * hash.c, hash.h: New files. Not completed.
12595 * Makefile.am: Added hash.c to source file list.
12596 * font.h: (struct font_desc) New member kern_size_p.
12597 * groff-font.c: Uses hash.h.
12598 (hashpjw) Moved to hash.c.
12599 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12601 (static var hash) New member size_p.
12602 * var.h: Includes hash.h.
12603 (struct freq_tab) Changed AVL_TREE to hash_tab.
12605 * vars-prs.c: Comment, formatting fixes.
12607 * frequencies.g, frequencies.q: Continued updating. Not yet
12610 * formats.c: Bug fix.
12612 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12614 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12615 * descript.g: Comment fixes.
12616 * descript.q: Comment fixes. Moved some declarations into var.h.
12617 Made dsc_info a static table. Updated FIXMEs.
12618 (internal_cmd_descriptives) Beautified.
12620 * frequencies.q: Started updating into working order.
12621 * frequencies.g: New file analogous to descript.g.
12622 * var.h: Comment fixes. Added structures for FREQUENCIES.
12624 * som.c: Removed vestiges of crushing and partial table support.
12626 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12628 * Many more changes to som.c especially, but these will not be
12629 documented as I have resolved to remove them. This patchlevel is
12630 being released solely so that I can fall back to it if I decide
12631 that removing the changes is not a good idea.
12633 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12635 * som.c: (global var som) New member `cum_y'.
12636 (build_target) Properly handles titles for partial tables.
12637 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12638 Merged into single new function dump_partial(). Fixed problem
12639 with titles on partial tables.
12640 (dump_table) Calls dump_partial() for all parts of partial tables.
12641 (dump_page) Criteria for drawing title changed.
12643 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12645 * command.c: (cmd_table) Added LIST, WEIGHT.
12647 * command.c: (cmd_remark) No longer frees `s' since it's not
12648 dynamically allocated.
12650 * data-out.c: (convert_f) Now correctly handles the case where
12651 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12652 number of decimals.
12653 (som_destroy_all_tables) Removed argument. All callers changed.
12654 (som_vline, som_hline) Argument validity checking corrected.
12655 (som_set_value) Implemented half-heartedly.
12656 (replicate_table) Copies tables piece-by-piece when using Checker.
12658 * som.h: New line style SLIN_1THIN, currently equivalent to
12659 SLIN_0. New enum set SOM_SUB_*.
12660 (struct som_submission_form) Removed `seq_no'. Added `type'.
12662 * list.q: Newly working file; uses partial tables.
12664 * som.c: (som_reduce_table) Renamed som_set_table_height().
12665 (som_crush) Removed argument `group'.
12666 (global var som) Removed `nt', `seq_no'. Added `type'.
12667 (som_submit_table) Arguments changed.
12668 (output_table) Removed partial table code.
12669 (build_target) New arg; partial table support added. All callers
12671 (dump_plain_table) Removed partial table code.
12672 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12673 (dump_table) Supports partial tables.
12674 (dump_page) New argument to allow not drawing top and/or bottom
12675 headers. All callers changed. Supports partial tables.
12677 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12679 * data-out.c: Changed `#include <approx.h>' to `#include
12681 (convert_F) Comment fix. Now won't print `-.000', etc.
12683 * descript.q: Now Z-scores work, although there appears to
12684 be a bug (which might actually be in data-out.c:convert_F()).
12685 (descriptives_trns_proc, descriptives_trns_free) New functions.
12686 (run_z_pass) Implemented.
12688 * var.h: Comment fixes.
12689 (dsc_z_score, descriptives_trns) New structs.
12690 (descriptives_trns) Added to any_trns as `dsc'.
12692 * error.c, error.h: New error class, IS (Installation Script
12693 error), used in those instances where the error is in the
12694 installation, but there is a script file or installation file that
12695 can be usefully referred to.
12697 * output.c: Change many IE classes to IS classes.
12699 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12700 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12701 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12702 include the corresponding header?
12704 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12705 Don't bail out if termcap can't be read.
12707 * som.c: (som_destroy_table) Removed.
12708 (som_reduce_table, som_destroy_all_tables) New functions.
12709 (som_crush) New function, not implemented.
12711 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12712 som_submission_form. Function prototypes revised.
12714 Outputting huge tables (1000s of rows) a few rows at a time
12715 is supported, though untested. May even break everything.
12716 Actually, the code doesn't even compile right now.
12717 * som.c: (struct som) New fields htv, nt, seq_no.
12718 (som_submit_table) Multiple arguments changed to a single
12719 pointer to struct submission_form. Only increments subtable_num
12720 if seq_no is zero. Only destroys table if it's not going to
12722 (replicate_table) New function.
12723 (output_table) Comment fix.
12724 (examine_table) Changed inline code to code calling
12725 replicate_table(). Calculates htv. Supports partial tables.
12726 (draw_title) Removed comment.
12727 (build_target) Only allows for title on first part of partial
12729 (dump_plain_table) Only resets table chunk number on first part
12730 of partial tables; FIXME: doesn't work quite right. Supports
12732 (dump_page) Titles only on first part of partial tables.
12734 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12736 * Thanks to an unreliable IDE hard drive, I have spent the last
12737 day reconstructing my Debian GNU/Linux installation and redoing
12738 the previous day's changes--somehow I managed to save every file
12739 except for output.c and output.h. So the following changes could
12740 really be considered independent of the output.c, output.h changes
12743 * output.h, output.c: Moved the outp_configure_vec global var,
12744 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12745 outp_configure_vec is now static.
12747 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12749 * The entire philosophy behind configuration of the output drivers
12750 changed. Now there is a termcap-type configuration where drivers
12751 to be read are determined beforehand, rather than parsing the
12752 entire output init file and storing it in memory & deciding what
12753 to actually use later. Faster & more memory-efficient at the same
12756 * output.c: Comment fix. Removed outp_init_drivers global var.
12757 Removed all references to synonyms. New structure outp_defn. New
12758 global vars outp_macros, outp_configure_vec.
12759 (search_name, delete_name, add_name, check_configure_vec,
12760 expand_name, find_defn_value) New static functions.
12761 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12762 outp_read_devices) New extern functions.
12763 (outp_init) Much functionality moved into outp_read_devices.
12764 (outp_read_devices) Format of output init file changed; name of
12765 file is `devices' rather than `output' to avoid Makefile
12767 (outp_clear) Renamed outp_done.
12768 (outp_list_classes) Bug fix, cleaned up.
12769 (outp_list_drivers) Not implemented anymore.
12770 (outp_configure_driver) Now a static function; simplified; now
12771 interpolates macros; supports new structure.
12772 (outp_enable_driver, match_synonym) Removed; all references
12774 (find_driver) First argument removed.
12776 * output.h: Global var outp_init_drivers removed; new structure
12777 outp_names; new enum set OUTP_S_*; new global var
12778 outp_configure_vec; function prototypes for output.c exports
12781 * main.c: (main) Calls outp_read_devices() after parsing the
12784 * cmdline.c: (parse_command_line) New option -v --verbose;
12785 --version changed to -V. --device option changed syntax to just
12786 take a single device name. Accepts key=value declaration of
12787 output init file macros. Syntax message updated.
12789 * filename.c: (expand_line) New function.
12790 (interp_environ_vars) Renamed interp_vars; no longer uses
12792 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12793 overridden by real environment vars.
12794 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12795 * filename.h: interp_environ_vars() renamed interp_vars().
12797 * error.c, error.h: Added extern variable `verbosity', message
12800 * error.c: (vmsg) Support message class MM.
12801 (verbose_msg) New function.
12803 * descript.q: (generate_z_varname) Bug fix in generation of
12805 (dump_z_table) Bug fix in column headers.
12807 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12808 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12809 OPS_DONE]. Writes the uninit string when the driver is closed.
12810 (ascii_open_page) Write the init string before the first page.
12811 (output_shorts) Form of main loop changed from `while' to `for'.
12812 Bug fix with overstrikes: the character is printed *after* the
12813 backspace. Eliminated a lot of `& 0xff' modifiers.
12814 (advance_to_left_margin) New function.
12815 (return_carriage, output_lines) Handle left margin.
12817 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12819 * ascii.c: New option `carriage-return-style'.
12821 * ascii.c: (count_fancy_chars) New function.
12822 (delineate, text_metrics) Use new function; bug fixes regarding
12824 (text_draw) Bug fix with rich text.
12825 (output_string, output_shorts) Reordered.
12826 (output_shorts) Now handles boxchars and some overstrike font
12828 (output_char, return_carriage) New functions.
12829 (output_lines) Now handles overstriking and font changes properly;
12830 some code moved to output_shorts.
12832 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12835 * ascii.c: New member `debug' in ascii_driver_ext.
12836 (ascii_init_driver, delineate) Uses new member.
12838 Now you can set a vertical height on writing text.
12839 * ascii.c: (delineate) Keeps track of vertical position.
12840 (text_draw) No longer considers fully justified text an internal
12843 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12845 Tables' titles are drawn; they can have variable height.
12846 * som.c: `som' struct has new member, title_height.
12847 (draw_title) New argument. Moved within file. All caller
12849 (build_target) New argument, amount of space needed for first row.
12850 Calculates height of title, takes that into account. All callers
12852 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12854 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12856 (dump_columnated_table) Organized for readability.
12857 (dump_page) Makes use of som.title_height.
12859 * som.c: Many comment bug fixes.
12861 * descript.q: (try_name, generate_z_name) Bug fix regarding
12862 generation of Z-score variable names.
12863 * var.h: Removed num from descriptives_proc; all referents removed.
12865 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12867 * ascii.c: (ascii_line_horz, ascii_line_vert,
12868 ascii_line_intersection) Added debugging code.
12870 Added a descriptive line above each table to describe it.
12871 * command.c: (parse_cmd) Calls som_new_series.
12873 * som.c: New static vars table_num, subtable_num. New `som'
12875 (dump_page) New arguments.
12876 (som_submit_table) Handle new variables.
12878 * som.c, som.h: (som_submit_table) New arguments. All callers
12880 (som_new_series) New function.
12881 (build_target) Makes room for extra line.
12882 (draw_title) New function.
12883 (dump_page) Calls draw_title. Bug fix: doesn't always set
12886 Columnation of tables support.
12887 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12889 * som.c: Deleted references to fr, lr, ri.
12890 (som_columnate) Bux fix: sets group member of table.
12891 (som_add_options) Function removed.
12892 (dump_table) Split into three functions; extensively reworked.
12894 * descript.q: (dump_z_table) Better output table formatting; added
12895 title support to correspond to som.h changes.
12896 (display) Title support.
12898 * output.h: Added OUTP_T_NONE.
12900 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12902 * descript.q: Improved handling of Z scores; still not perfect.
12904 * output.h, ascii.c: Added hook for getting em width of current
12907 * som.c: Uses new em-width hook. Added debugging code to
12909 (som_columnate) New argument.
12910 (som_add_options) Removed.
12912 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12914 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12915 rules as a property of the table instead of as a property of the
12918 * ascii.c: Added `header' to table of options.
12920 * descript.q: Added even shorter statistic names; modified to work
12921 with new som interface.
12923 * misc.c (blp_getdelim): Bug fix.
12925 * version.c: includes 'conf.h'.
12927 ----------------------------------------------------------------------
12930 version-control: never