1 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
3 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
5 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
7 * postscript.c: (postopen) Cast `char' to `unsigned char' before
10 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
12 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
14 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
16 * histogram.c: Include <config.h>.
18 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
20 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
22 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
24 * format.c: (check_common_specifier) Fix msg() bug found by
26 (check_output_specifier) Ditto.
28 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
30 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
33 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
35 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
36 avoid "unused variable" warning.
38 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
40 * command.c: (find_word) Cast `char' to `unsigned char' before
43 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
45 * case.c: (case_compare) Implement as delegating to
48 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
50 * algorithm.c: Inclusion of <alloca.h> is unneeded.
52 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
54 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
55 -ansi changes the behavior of header files significantly. It
56 causes __STRICT_ANSI__ to be defined, and some headers interpret
57 that as cause to e.g. not use `long long' or __attribute__. The
58 former example is bad when off_t is supposed to be `long long',
59 and the latter prevents -Wformat from working.
61 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
63 Get rid of dependency on libgmp by writing our own routine for
64 floating-point base conversion.
66 * pfm-write.c: (write_float) Rewrote.
68 (pow30_nonnegative) New function.
70 (trig_to_char) New function.
71 (format_trig_digits) New function.
72 (recurse_format_trig_int) New function.
73 (format_trig_int) New function.
74 (should_round_up) New function.
75 (try_round_up) New function.
76 (format_trig_double) New function.
78 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
80 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
83 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
85 * pfm-read.c: (read_version_data) Read and ignore author field.
87 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
89 * get.c: (mtf_processing) Don't assume that
90 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
91 returns a negative, zero, or positive result. Fixes MATCH FILES
92 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
94 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
96 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
97 preprocessor test for sys/types.h was accidentally inverted. This
100 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
102 * get.c: (cmd_match_files) Fix memory leak on `by' and on
105 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
108 * vfm.c: (close_active_file) Remove unnecessary test.
110 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
112 Fix NDEBUG compile errors.
114 * hash.h: Needed explicit #include <assert.h>.
116 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
119 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
121 Implement embedding for PostScript driver. Fixes bug 12970.
123 * ascii.c: Fix compiler warnings.
127 * chart.h: Add `file' member.
129 * output.h: (struct outp_class) initialise_chart, finalise_chart
130 should take outp_driver *, not outp_class *. Update all
133 * plot-chart.c: (chart_create) Fix segfault when there are no
134 output drivers at all.
135 (chart_submit) Call d->class->finalise_chart.
137 * postscript.c: (ps_open_page) Set cp_y to 0.
138 (ps_submit) New function.
139 (ps_chart_initialise) Implement.
140 (ps_chart_finalise) Implement.
141 (static var postscript_class) Add ps_submit.
142 (static var epsf_class) Add ps_submit.
145 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
147 Did some more work on bug 12859 and then realized that a *good*
148 solution would require some fundamental restructuring. For now,
149 I'm marking REPEATING DATA unimplemented, and then we can revisit
152 * command.def: Make REPEATING DATA unimplemented.
154 * data-list.c: (cmd_repeating_data) Assume inline file is 80
156 (realize_value) Revert previous changes; no longer needed.
159 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
160 file_loc, to avoid bad references later.
164 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
166 Make some code tolerant of reentry. Should not be needed if other
167 code is correct but it is good to be generally tolerant.
169 * error.c: (err_hcf) Set file_loc to null after free().
171 * output.c: (outp_done) Similar changes.
173 * str.c: (ds_destroy) Ditto.
175 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
177 Continue work on bug 12859, plus some code cleanup.
179 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
180 boolean variables. Don't try to compute starts_end, cont_end for
181 inline file. Calculate length only after parsing variable
182 specifications. Add proper transformation to list.
183 (realize_value) If the rpd_num_or_var has no value, return new
184 DEFAULT_MEMBER argument (for use with inline file).
185 (repeating_data_trns_proc) Pass default values.
187 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
188 open, and only if we actually started reading data.
190 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
194 * output.c: (outp_read_devices) Fix message.
196 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
198 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
199 of the sort algorithm from the parser for the SORT command.
201 * rank.q: Added the parser for the RANK command.
203 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
207 * sort.c: (sort_parse_criteria) Only set *saw_direction if
208 saw_direction is non-null. Thanks to John Darrington for
211 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
213 * get.c: (mtf_processing) Handle case of a lookup table as the
214 active file. Thanks to John Darrington for reporting this bug.
216 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
218 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
219 POSIX calloc function.
221 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
222 reflect new signature.
224 * sfm-read.c: Now much more robust in the face of badly formed
227 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
229 *sfm-read.c: Fixed some bugs regarding long string continuation
230 records, which the previous fix uncovered.
232 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
234 * sfm-read.c, sfmP.h: Allow reading of system files when the
235 case_size value in the header is -1. Also changed some Errors to
236 Warnings when reading system files.
238 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
240 * data-list.c: (data_list_trns_free) Don't free the argument
241 because cancel_transformations() will do that itself.
242 (data_list_source_destroy) Destroy the argument to
243 data_list_trns_free(), because it no longer does so itself.
245 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
247 * data-out.c: (format_and_round) Don't output leading `-' if value
250 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
254 * som.c: (output_encodings) If some cell in the table won't fit
255 with the horizontal or vertical headers, cancel those headers.
257 * som.h: (struct som_table_class) Add fits_width, fits_length,
260 * tab.c: (tabi_fits_width) New function.
261 (tabi_fits_length) New function.
262 (tabi_set_headers) New function.
263 (global var tab_table_class) Add the new functions as appropriate
266 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
268 Fix rest of bug 13054.
270 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
271 DATETIME, TIME system/portable file values.
273 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
275 * data-list.c: (parse_free) Use make_input_format().
277 * data-out.c: (num_to_string) Use make_output_format().
279 * dictionary.c: (dict_create_var) Ditto.
281 * format.c: (global var f8_2) New var.
282 (make_input_format) New function.
283 (make_output_format) New function.
285 * get.c: (cmd_match_files) Use make_output_format().
287 * list.q: (cmd_list) Ditto.
289 * matrix-data.c: Ditto.
291 * sfm-read.c: (parse_format_spec) Check output specifier
294 * tab.c: (tab_float) Use make_output_format().
296 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
298 Fix more of bug 13054.
300 * format.def: FMT_A should allow 255-character output. FMT_AHEX
301 should allow 510-character input and output.
303 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
304 (convert_E) Handle non-finite values.
306 (format_and_round) New function.
307 (convert_infinite) New function used by try_F() and convert_E().
309 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
311 Regularize string and buffer function names so that they make some
314 * str.c: (mm_reverse) Rename buf_reverse(). Update all
316 (mm_find_reverse) Rename buf_find_reverse(). Update all
318 (mm_case_compare) Rename buf_compare_case(). Update all
320 (st_compare_pad) Rename buf_compare_rpad(). Update all
322 (str_compare_rpad) New function.
323 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
325 (buf_copy_str_lpad) New function.
326 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
328 (st_pad_copy) Rename str_copy_rpad(). Update all references.
329 (st_trim_copy) Rename str_copy_trunc(). Update all references.
330 (st_uppercase) Renamed str_uppercase(). Update all references.
332 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
334 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
337 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
339 * data-in.c: (data_in) Add assertion to check input specifier.
341 * data-out.c: (data_out) Add assertion to check output specifier.
343 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
345 Start to fix bug 13054.
347 * format.c: (check_input_specifier) Improve error message.
348 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
349 valid decimal places.
350 (check_output_specifier) Ditto (but different criteria).
351 (convert_fmt_ItoO) Assert valid input and output specifiers.
352 Also, if input specifier has *any* decimal places, make the output
353 specifier 1 place wider.
355 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
357 * sysfile-info.c: Fixed bug [# 13024 ]
359 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
361 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
362 actually implement it.
364 * command.c: (FILE_TYPE_okay) Always return 1.
366 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
368 * file-type.c: Add prototypes to get rid of warnings.
370 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
372 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
373 more ISO/IEC 9899:1990 conformance issues.
375 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
377 Fix bug 12948. See also new test in
378 tests/bugs/match-file-scratch.sh.
380 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
381 that deletes scratch variables that someone else might be using,
382 and because we can't reassign our sources' value indexes.
383 Instead, simply don't copy scratch variables into the master
386 * dictionary.c: (dict_compact_values) Delete variables from the
387 dictionary passed in, not from default_dict (!).
389 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
391 Improve hash.c comments, error-checking.
393 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
394 (hsh_create) size == 0 should *not* return NULL! Set
396 (hsh_clear) Set hash_ordered.
397 (locate_matching_entry) Check hash_ordered.
398 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
399 (hsh_data) Set hash_ordered. Add const-ness to return value and
403 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
405 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
407 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
409 * copyleft.c: Updated copyright date.
411 * Makefile.am: Removed erroneous explicit "-lplot"
413 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
415 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
417 * command.c command.def: Added description string for unimplemented commands.
419 * oneway.q: Sorted the hash tables before shipping out the results. Closes
422 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
426 * data-list.c: (parse_fixed) Use lex_end_of_command().
428 (cmd_repeating_data) Set cont_end.num in right situations.
429 (parse_repeating_data) Remove redundant test.
431 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
433 Partial fix for bug 12859.
435 * data-list.c: (cmd_data_list) Add transformation properly in
436 vfm_source == NULL case.
438 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
440 * lexer.c: (lex_error) Improve error messages.
442 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
444 * get.c: (cmd_match_files) Check token type before trying to match
445 tokid. Fixes bug 12923.
447 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
449 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
452 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
454 * expressions/generate.pl: (get_token) Make use of /g
455 backward-compatible with Perl 5.6.1.
457 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
459 * var-display.c: (cmd_variable_alignment) Fix memory leak.
460 (cmd_variable_level) Ditto.
462 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
464 Hash table had buggy deletion function. The fix required changing
465 other functions to do probing in the required order.
467 * hash.c: (locate_matching_entry) Rewrite and change interface.
468 (hsh_rehash) Rewrite to use locate_matching_entry().
471 (hsh_delete) Ditto. Also, fix stupid bugs.
473 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
475 * dictionary.c: (dict_clone) Properly copy vectors.
477 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
479 New implementation of long variable names. Each variable has a
480 "normal" name, which may be up to 64 bytes long and which is used
481 for all normal operations. Variables may have a "short" name,
482 which is limited to 8 bytes and used only for system and portable
483 file input and output.
485 Make tokid case-preserving. Update most uses of tokid to treat it
488 Update many commands to deal with long variable names.
490 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
492 * command.c: (cmd_parse) Ditto.
493 (match_strings) Use toupper() before comparing characters.
494 (conflicting_3char_prefixes) Use mm_case_compare() instead of
496 (cmd_match_words) Ditto.
498 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
501 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
502 Use st_trim_copy() instead of strcpy().
504 * data-in.c: (parse_enum) Use mm_case_compare() instead of
507 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
509 (parse_free) Use st_trim_copy() instead of strcpy().
511 * descript.c: (struct dsc_var) Change z_name[] to fit long var
513 (try_name) Use strcasecmp() instead of strcmp().
514 (generate_z_varname) Use st_trim_copy() instead of strcpy().
515 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
518 * dictionary.c: (struct dictionary) Removed `long_name_tab'
520 (compare_long_names) Removed.
521 (hash_long_name) Removed.
522 (dict_create) Don't initialize `long_name_tab' member.
523 (dict_clone) Copy short names into new dictionary.
524 (dict_clear) Don't clear `long_name_tab' member.
525 (dict_get_varname_block) Removed.
526 (dict_add_longvar_entry) Removed.
528 (dict_destroy) Don't destroy `long_name_tab' member.
529 (dict_create_var_from_short) Removed.
530 (dict_create_var_x) Removed.
531 (dict_create_var) Get rid of longname handling.
533 (dict_clone_var) Get rid of longname parameter and longname
535 (dict_lookup_var) Get rid of longname handling.
536 (dict_reorder_var) New function.
537 (dict_rename_var) Clear short name.
538 (dict_rename_vars) Get rid of longname handling. Clear short
540 (dict_create_vector) Support long vector names.
541 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
542 (quasi_base27) Removed.
543 (make_short_name) Removed.
544 (compare_strings) New function.
545 (hash_string) New function.
546 (dict_assign_short_names) New function.
548 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
550 (get_handle_for_filename) Support long handle names.
552 * file-type.c: (struct col_spec) Make `name' fit long var names.
553 (cmd_file_type) Use strcasecmp() instead of strcmp().
555 * flip.c: (make_new_var) Rewrite.
556 (flip_sink_write) Use st_trim_copy() instead of strncpy().
558 * format.c: (parse_format_specifier_name) Use mm_case_compare()
561 * get.c: (cmd_save_internal) Rephrase.
562 (rename_variables) Drop test for identical variable name.
563 (struct mtf_proc) Change `first', `last' to fit long var name.
565 * hash.c: (hsh_hash_case_string) New function for case-insensitive
568 * lexer.c: (restore_token) Use st_trim_copy() instead of
570 (lex_get) Don't uppercase string when copying into tokid.
571 (lex_put_back_id) Use st_trim_copy() instead of
574 * list.q: (determine_layout) Consider length of variable names in
575 choosing vertical layout.
577 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
579 (string_to_content_type) Ditto.
581 * modify-vars.c: (compare_variables_given_ordering) Ditto.
582 (struct var_renaming) Change `new_name' to fit long var name.
583 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
586 * pfm-read.c: (read_variables) Disallow system variables in system
588 (write_variables) Call dict_assign_short_names() and use
589 short_name[] members.
591 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
594 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
595 map. Reorder variables into same order as long variable map.
596 (read_variables) Set short name.
598 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
599 (write_variable) Use st_bare_pad_copy().
600 (write_longvar_table) Rewrite.
602 * str.c: (mm_case_compare) New function.
604 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
607 * t-test.q: (tts_custom_groups) Remove redundant test.
608 (tts_custom_pairs) Ditto.
610 * var.h: (struct variable) Change `name' to fit long var names.
611 Remove `longname'. Add `short_name' member. Reorder some
613 (struct name_table_entry) Removed.
614 (struct vector) Change `name' to fit long vector names.
616 * vars-atr.c: (var_is_valid_name) Allow long var names.
617 (compare_var_names) Use strcasecmp() instead of strcmp().
618 (compare_var_ptr_names) Ditto.
619 (hash_var_name) Use hsh_hash_case_string().
620 (hash_var_ptr_name) Ditto.
621 (var_set_short_name) New function.
622 (var_clear_short_name) New function.
623 (var_set_short_name_suffix) New function.
625 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
626 Use strcasecmp() instead of strcmp().
627 (struct array_var_set) Removed `longname_tab'.
628 (array_var_set_lookup_var_idx) Drop longname_tab support.
629 (array_var_set_destroy) Don't destroy `longname_tab'.
630 (var_set_create_from_array) Don't create `longname_tab'.
632 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
635 * expressions/parse.c: (word_matches) Use mm_case_compare()
637 (compare_strings) New function.
638 (lookup_function) Use compare_strings() instead of strcmp().
640 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
642 * algorithm.c: (move_element) New function.
644 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
646 * aggregate.c: (parse_aggregate_functions) Always initialize
649 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
651 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
653 * dictionary.c: (dict_clone) Ditto.
654 (dict_clone_var_assert) New function.
656 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
658 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
660 * error.c: Added a string for the compiler version to the
661 request_bug_report_and_abort function.
663 * groff_font.c, font.c: Removed manpage(1) style references from
664 comments, because RMS frowns upon them.
666 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
668 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
670 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
672 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
675 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
677 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
678 which should be LONG_NAME_LEN
680 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
682 * command.def echo.c: Added the ECHO command.
684 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
686 Finish fixing MATCH FILES (bug 11677).
688 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
689 keep_variables(), rename_variables().
690 (drop_variables) New function.
691 (keep_variables) New function.
692 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
693 (cmd_match_files) Deal with in_var. Use drop_variables(),
694 keep_variables(). When IN is specified, require BY. Set master
695 variables after master dictionary is complete. Add IN variables
696 after master dictionary is complete.
697 (mtf_free_file) Free `in_name'.
698 (mtf_delete_file_in_place) Set in_var value to 0.
699 (mtf_read_nonactive_records) Rephrase.
700 (mtf_processing) Support IN. Rephrase. Fix bugs.
701 (mtf_merge_dictionary) Don't set master variables; we do that
703 (get_master) Don't insist that there's a master variable.
705 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
707 Kluge to make some variable renaming sort of work.
710 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
712 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
714 Add functions for comparing sets of variables between cases.
717 * case.c: (case_compare) New function.
718 (case_compare_2dict) New function.
720 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
722 (cmd_aggregate) Nullify break_case. Don't call
723 initialize_aggregate_info().
724 (agr_destroy) Destroy break_case.
725 (aggregate_single_case) Rewrite. Use case_compare().
726 (dump_aggregate_info) Copy from break_case into output.
727 (initialize_aggregate_info) Copy break_case from input.
729 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
731 * vfm.c: (equal_splits) Use case_compare().
733 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
735 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
737 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
739 Start work on fixing MATCH FILES.
741 * get.c: (enum operation) Remove OP_MATCH.
742 (trim_dictionary) Change return value to bool. Don't support
744 (struct mtf_file) Remove `first', `last' members.
745 (struct mtf_proc) Add `first', `last' members. Change mtf_case
746 from `struct ccase *' to `struct ccase'. Remove `by' member.
747 (cmd_match_files) Essentially rewrite.
748 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
749 (mtf_read_nonactive_records) mtf_ parameter is not unused.
750 (mtf_processing) Ditto. Also rephrase some code.
751 (mtf_merge_dictionary) Rewrite for easy comprehension.
753 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
755 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
758 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
760 Thu Apr 14 2005 John Darrington
762 * var-display.c: New file.
764 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
765 display_width, measure and alignment parameters to variables.
767 * aggregate.c command.def compute.c count.c data-list.c descript.c
768 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
769 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
770 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
771 vars-prs.c vector.c :
772 - Replaced literal constants representing maximum variable name
773 length with macro definitions.
774 - Added support for long variable names.
775 - Changed lexer such that it no longer makes tokens upper
776 case, but relies upon case insensitive behaviour of commands.
778 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
780 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
781 fails, don't dereference the resulting null pointer (bug 12427).
782 Also, fix double free error.
784 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
786 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
787 (accumulate_aggregate_info) Set int1 to 1 for SUM.
788 (dump_aggregate_info) Only make SUM non-missing if there was at
791 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
793 * aggregate.c: (dump_aggregate_info) Properly test whether the
794 destination variable is numeric, when making the result
795 system-missing for columnwise missing values.
797 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
799 * misc.h: Remove GCC specializations.
801 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
803 Make sort stable (bug 12313).
805 * sort.c: Don't need to include some headers anymore.
806 (static var min_buffers) New variable.
807 (static var max_buffers) New variable.
808 (static var allow_internal_sort) New variable.
809 (cmd_sort_cases) Add test mode.
810 (sort_execute) Rephrase.
811 (do_internal_sort) Don't try internal sorting if
812 allow_internal_sort is set.
813 (struct external_sort) Renamed `initial_runs' to `runs' and
814 updated all references.
815 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
816 (macro MIN_BUFFER_SIZE_BYTES) Removed.
817 (macro MIN_BUFFER_SIZE_RECS) Removed.
818 (compare_initial_runs) Removed.
819 (struct record_run) Add member `idx'.
820 (write_initial_runs) Pass increasing values to process_case() as
822 (process_case) Add `idx' parameter and use it to initialize new
824 (allocate_cases) Limit allocated buffers to max_buffers.
825 (compare_record_run) Use new `idx' member for last resort
826 comparison, for stability.
827 (end_run) Call casefile_sleep() on irs->casefile, to prevent
828 running out of file descriptors.
829 (struct merge_state) Removed.
830 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
831 unless we have fewer runs left. Always merge consecutive runs,
832 for stability. Return the final run.
834 (choose_merge) New function.
835 (merge_once) Rewritten.
837 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
839 * cmdline.c: (static var testing_mode) Move into
840 parse_command_line().
842 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
844 * algorithm.c: (remove_range) New function.
845 (remove_element) New function.
847 * dictionary.c: (dict_delete_var) Use remove_element().
849 * flip.c: (cmd_flip) Ditto.
851 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
853 * file-handle.q: (struct file_handle) `open_mode' should not be
856 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
858 First phase of making SORT CASES stable (bug 12313).
860 * sort.c: (struct indexed_case) New structure.
861 (do_internal_sort) Rewrite to make internal sorting stable.
862 (compare_case_dblptrs) Removed.
863 (compare_indexed_cases) New function.
865 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
869 * casefile.c: (casereader_read_xfer_assert) New function.
871 * dictionary.c: (dict_compact_case) New function.
873 * flip.c: (struct flip_pgm) New member idx_to_fv.
874 (cmd_flip) Initialize idx_to_fv member.
875 (destroy_flip_pgm) Free idx_to_fv member.
876 (flip_sink_write) Use struct flip_pgm member instead of case_sink
878 (flip_sink_write) Ditto.
880 * vfm.c: (write_case) Use dict_compact_case() instead of
882 (compact_case) Removed.
883 (storage_source_create) Removed `dict' parameter. All references
886 * vfm.h: (struct case_source) Removed `value_cnt' member. All
888 (struct case_sink) Removed `dict', `idx_to_fv' members. All
891 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
893 More AGGREGATE fixes.
895 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
896 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
898 (initialize_aggregate_info) Fix initialization for MIN, MAX for
901 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
903 Start work on testing and debugging AGGREGATE.
905 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
906 of a bit-map. Require proper subcommand ordering. Make OUTFILE
907 subcommand mandatory.
908 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
909 functions' arguments are in the correct order and swap them if
911 (accumulate_aggregate_info) Make SUM include weights. Add various
913 (dump_aggregate_info) Add various string functions.
914 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
916 * sort.c: (sort_parse_criteria) Add parameter for returning
917 whether any directions were specified. All callers updated.
919 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
921 * t-test.q: Fixed erroneous logic in compare_group_binary.
923 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
925 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
926 keywords (bug 11628).
928 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
930 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
931 called *before* close_active_file().
933 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
935 * file-handle.q: (struct file_handle) Change open_mode from
936 character pointer to 3-char array, for safety. Updated all
939 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
941 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
944 * pfm-read.c: (read_header) Improve error message for many cases
945 in which the input is not actually a portable file.
947 * file-handle.q: (fh_open) When we give an error message, actually
950 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
952 * format.c: (check_common_specifier) New function for checks
953 common to check_input_specifier() and check_output_specifier().
954 (check_input_specifier) Use check_common_specifier().
955 (check_output_specifier) Use check_common_specifier().
956 (check_string_specifier) Removed.
957 (check_specifier_type) New function.
958 (check_specifier_width) New function.
959 (get_format_var_width) Fix bug.
961 * formats.c: (internal_cmd_formats) Only accept numeric variables.
963 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
964 update all references. Make case-insensitive.
966 * pfm-read.c: Essentially rewrite the whole file. Now much
969 * print.c: (check_string_width) New function.
970 (fixed_parse_compatible) Use check_string_width(),
971 check_specifier_type().
972 (dump_fmt_list) Ditto.
974 * str.c: (st_trim_copy) New function.
975 (st_uppercase) New function.
977 * vars-atr.c: (var_is_valid_name) New function.
979 * expressions/parse.c: (type_coercion_core) Use
980 check_specifier_type().
982 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
984 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
986 * expressions/parse.c: (no_match) Ditto.
988 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
990 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
992 * expressions/helpers.c: (struct func_params) Removed.
993 (generalized_idf) Removed.
996 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
998 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
999 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1000 Implement SIG.F, which I had overlooked previously.
1002 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1004 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1005 available only in testing mode.
1007 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1009 * data-in.c: Use `bool' throughout, where relevant.
1011 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1013 DATA LIST with free-field formats should not have implied decimal
1014 places (bug 12035). Also clean up data-in.c a bit.
1016 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1018 * data-in.c: (apply_implied_decimals) New function.
1019 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1020 set. Also, get rid of gotos.
1021 (parse_Z) Use apply_implied_decimals() if the field doesn't
1022 contain a decimal point.
1023 (parse_N) Use apply_implied_decimals().
1029 (parse_enum) New function.
1030 (macro CHAR_IS_ROMAN) Removed.
1031 (macro ROMAN_VALUE) Removed.
1032 (parse_month) Use parse_enum().
1033 (parse_weekday) Use parse_enum().
1034 (parse_DATETIME) Use long for weekday.
1036 * data-list.c: (read_from_data_list_fixed) Use
1037 DI_IMPLIED_DECIMALS.
1039 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1041 When the lexer sees something like `-5' in the input, it has to
1042 decide whether it's a negative numeric constant token or a '-'
1043 token followed by a positive numeric constant token. It always
1044 decides on the former, and then the parser can call
1045 lex_negative_to_dash() if it wants the latter. However, this
1046 doesn't work for the case of `-0', because negative zero is
1047 (portably) indistinguishable from positive zero. So now we divide
1048 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1049 distinction clear. This requires a little bit of extra effort,
1050 because there were several references to T_NUM in the code base.
1052 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1053 positive and negative numeric constants.
1054 (lex_double_p) Renamed lex_is_number(). Changed return type to
1055 bool. Updated all relevant references to T_NUM to instead use
1057 (lex_double) Renamed lex_number(). All references updated.
1058 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1059 bool. All references updated.
1060 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1061 (lex_negative_to_dash) Ditto.
1064 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1066 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1068 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1070 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1072 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1073 values as system-missing.
1075 * expressions/parse.c: (parse_vector_element) Fix order of
1076 arguments in call to expr_allocate_binary().
1078 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1080 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1083 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1084 failure, as indicated by function comment.
1085 (parse_binary_operators) Always return NULL on type_coercion()
1086 failure. Should have been doing this anyway, but bug in
1087 type_coercion_core() filtered through.
1088 (parse_add) Fix typo in user message.
1089 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1091 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1093 * expressions/operations.def: Add VALUE function.
1095 * expressions/parse.c: (parse_function) Need an unary composite
1096 node for variables in A TO B, not a variable node. Use
1097 allocate_unary_variable().
1098 (parse_primary) Use allocate_unary_variable().
1099 (allocate_unary_variable) New function.
1101 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1103 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1104 but fixed the real problem that was preventing the build from a
1105 separate directory. I liked it my way better ;-)
1107 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1109 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1110 John Darrington <john@darrington.wattle.id.au> for reporting this
1113 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1115 * expressions/Makefile.am expressions/evaluate.h.pl
1116 expressions/evaluate.inc.pl expressions/operations.h.pl
1117 expressions/optimize.inc.pl expressions/parse.inc.p:
1119 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1122 Fixed everything so that it can be built from an arbitrary
1125 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1127 * Makefile.am : Fixed up CLEANFILES target.
1129 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1131 * str.h: Changed `struct len_string' to `struct fixed_string', a
1132 more accurate name. Updated all references.
1134 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1136 Redo calendar support. Should now be bug-for-bug compatible.
1138 * calendar.c: New file.
1140 * calendar.h: New file.
1142 * data-in.c: Use new calendar functions.
1143 (parse_sign) Change sense of return value.
1144 (calendar_error) New function.
1145 (ymd_to_ofs) New function.
1146 (ymd_to_date) New function.
1147 (parse_DATE) Use new function.
1148 (parse_ADATE) Ditto.
1149 (parse_EDATE) Ditto.
1150 (parse_SDATE) Ditto.
1151 (parse_JDATE) Ditto.
1156 (parse_DTIME) Ditto.
1157 (parse_DATETIME) Ditto.
1159 * data-out.c: (convert_date) Use new calendar functions.
1161 * error.c: (err_vmsg) Changed interface to be more sensible.
1162 Updated all callers.
1163 (dump_message) Don't double new-lines (why did we do this
1166 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1168 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1169 (macro FLT64_MAX) Moved here from pref.h.orig.
1171 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1173 * set.q: Support SET EPOCH.
1174 (static var set_epoch) New var.
1175 (aux_stc_custom_epoch) New function.
1176 (stc_custom_epoch) New function.
1177 (get_epoch) New function.
1178 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1180 * format.c: Make it possible just to check whether a specifier is
1181 valid without emitting an error message.
1182 (parse_format_specifier_name) Change interface, update all
1184 (check_input_specifier) Ditto.
1185 (check_output_specifier) Ditto.
1186 (parse_format_specifier) Ditto.
1188 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1190 * command.def: Add DEBUG POOL.
1192 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1194 (pool_clear) Properly account for size of pool gizmo.
1195 (pool_realloc) Ditto.
1196 (pool_clone) New function.
1198 * pool.h: Mark our allocation functions MALLOC_LIKE.
1200 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1202 * Makefile.am: Move many definitions into new top-level
1203 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1204 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1207 * case.c: (case_resize) New function.
1208 (case_swap) New function.
1210 * casefile.c: Include mkfile.h.
1212 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1214 * sfm-read.c: Fixed a buglet which caused a crash when trying
1215 to read a non-existent file.
1217 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1221 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1222 Important part: get rid of spurious copying of function->format to
1223 destvar->print and destvar->write.
1225 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1227 Fix bug 11916, which was confusing a variable's `index' member
1228 with the variable's position in a var_set. Although these are
1229 usually the same, they are not for array `var_set's.
1231 Took advantage of this bug as an opportunity to clean up and
1232 rewrite parse_var_set_vars().
1234 * vars-prs.c: (parse_vs_variable_idx) New function.
1235 (parse_vs_variable) Reimplement in terms of
1236 parse_vs_variable_idx().
1237 (parse_var_idx_class) New function.
1238 (add_variable) New function.
1239 (add_variables) New function.
1240 (parse_var_set_vars) Rewritten.
1241 (struct var_set) Change `lookup_var' member that returns a
1242 variable into `lookup_var_idx' member that returns an int.
1243 Updated the var set implementations in obvious corresponding ways.
1244 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1246 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1248 Use our global variable compare & hash functions and give them
1249 better names. Add similar functions for dealing with double
1250 pointers to variables.
1252 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1253 (hash_variable) Renamed hash_var_name().
1254 (compare_var_ptr_names) New function.
1255 (hash_var_ptr_name) New function.
1257 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1259 (compare_var_name) Removed.
1260 (hash_var_name) Removed.
1262 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1266 * dictionary.c: (compare_variable_dblptrs) Rename
1267 compare_var_ptrs() and fix it to properly dereference the double
1270 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1272 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1273 declare subcommands as mandatory. Closed bug #11843
1275 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1277 * getline.c command.[ch] command.def: Added (very rudimentary)
1278 support for line completion when in interactive mode. Partially
1279 addresses bug #11693
1281 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1283 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1284 problems revealed by valgrind.
1287 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1289 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1290 whether or not PAGER is set.
1292 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1294 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1295 "invalid free" errors. Hopefully fixes bug #11722
1297 * compute.c expr-prs.c: Check that lvalues are populated before
1298 attempting to destroy them. Closes bug #11676
1300 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1302 * aggregate.c: Initialised the complete agr_proc structure.
1306 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1308 * print.c: (print_trns_free) Close the dfm writer if there is one,
1309 fixing a memory leak.
1311 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1313 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1317 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1319 * linked-list.[ch] Added
1321 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1322 set.q: Yet more memory leaks
1324 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1326 * t-test.q examine.q : More memory leaks fixed.
1328 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1330 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1333 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1335 * ascii.c cartesian.c casefile.c chart.h devind.c
1336 examine.q frequencies.q
1337 html.c output.h piechart.c plot-chart.c plot-hist.c
1339 Integrated the chart rendering into the output stream
1340 (currently only works for html).
1342 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1343 dummy-chart.c for compiling without charts.
1345 * mkfile.[ch] Created.
1347 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1348 Added type element so we can tell if it's a chart or a table.
1350 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1351 API of charts to be more like that of tables.
1353 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1355 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1356 main.c. Removed the handler for SIGQUIT.
1358 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1360 * casefile.c: Added a signal handler to delete temp files on
1363 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1365 * command.def Added a lot more unimplemented commands.
1367 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1369 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1371 * sort.c: (compare_initial_runs) Needed additional level of
1373 (merge_once) Fix plenty of stupid mistakes.
1375 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1377 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1378 calling casefile_to_disk() or we will lose the last block in the
1379 file if the casefile started out as disk-based.
1380 (casefile_get_reader) Initialize reader->destructive to 0.
1381 (cmd_debug_casefile) Add new test pattern.
1382 (test_casefile) Define new test pattern to make sure
1383 casefile_sleep() works properly.
1385 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1387 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1388 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1389 attempt to seperate the creation and processing of charts from their
1392 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1395 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1397 * main.c Added a signal handler for SIGFPE
1399 * sort.c Somewhat more robust fix to the previous entry.
1401 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1403 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1404 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1405 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1408 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1410 * case.h Fixed bug # 11307
1412 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1414 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1417 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1419 * pfm-read.c: (read_variables) Remove direct manipulation of
1420 v->aux, which is no longer needed. Fixes bug 11483.
1422 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1424 * data-list.c Fixed a bug in parsing delimiters.
1426 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1429 * percentiles.c Properly handled calculation of Tukey hinges where
1430 the number of data is small.
1432 * oneway.q Used the generic value_to_string function for independent
1433 variable instead of trying to do it ourselves.
1435 * box-whisker.c Fixed a buglet which caused a crash if the number of
1439 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1441 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1443 * percentiles.c Fixed some bugs when calculating percentiles when
1444 there's a small number of cases.
1446 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1448 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1450 * examine.q factor_stats.[ch] Added calculation of percentiles
1452 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1454 * t-test.q Fixed bug #11227 Made t-test work when the independent
1457 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1459 * factor_stats.c Fixed calculation of trimmed mean under various
1462 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1464 * histogram.c chart.[ch] factor_stats.c frequencies.q
1466 Added code to calculate sensible histogram ranges and limits.
1468 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1470 * chart.h Updated to reflect many API changes.
1472 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1473 cartesian.c and into chart.c
1475 * factorstats.[ch] Added the histogram calculations
1477 * casefile.c Removed an unused variable.
1479 * frequencies.q examine.q histogram.c Reworked the API for
1482 * piechart.c Revised the API for piecharts.
1484 * var.h Moved the definitions of freq_tab and freq out of var.h
1485 and into frequencies.q where they belong.
1487 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1489 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1490 using AC_TYPE_OFF_T.
1492 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1494 * flip.c: (flip_file) If fseeko() is not available, use long int
1495 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1496 reporting the problem.
1498 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1500 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1501 conflict with stdio.
1503 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1505 * var-labs.c (var_to_string) Now returns null if the variable is null
1507 * value-labels.c (value_to_string) Made it return null if either the
1508 value or the variable is null.
1510 * hash.c (hsh_clear) Fixed a buglet.
1512 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1513 with the wrong model.
1515 * casefile.[ch] Added a function to return the casereader.case_idx
1518 * examine.q Implemented the extreme values results.
1520 John Darrington <john@darrington.wattle.id.au>
1522 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1523 output.[ch] getline.c
1525 Plugged some memory leaks
1527 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1529 Adopt GSL random number generators, paving the way for providing
1530 the complete suite of random number generators on expressions.
1532 * Makefile.am: Remove random.c, random.h.
1534 * random.c: Removed.
1536 * random.h: Removed.
1538 * algorithm.c: (algo_default_random) Use GSL functions.
1540 * casefile.c: (test_casefile) Use GSL RNG functions.
1542 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1545 * sample.c: (cmd_sample) Use GSL RNG functions.
1546 (sample_trns_proc) Ditto.
1548 * set.q: (static var set_seed) Removed.
1549 (static var seed_flag) Removed.
1550 (static var rng) New variable.
1551 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1552 (stc_custom_seed) Use new seed functions.
1553 (seed_is_set) Removed.
1554 (get_rng) New function that composes the entire external
1556 (set_rng) New function.
1557 (random_seed) New function.
1559 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1561 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1562 John Darrington <john@darrington.wattle.id.au> for reporting this
1565 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1567 * permissions.c command.def Added the PERMISSIONS command
1569 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1571 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1572 output file because that will precede #include <config.h>, which
1574 (main) Add needed headers to /* (header) */ code.
1576 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1578 Instead of making system or portable file readers responsible for
1579 dropping and reordering variables, make them read full cases and
1580 let the caller take care of any changes.
1582 * get.c: New "case map" structure to handle this. Use for GET,
1583 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1585 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1586 changed appropriately.
1588 * sfm-read.c: (sfm_read_case) Ditto.
1590 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1592 Decided that case_serialize() and case_unserialize() were too
1593 abstract. Also we need a couple more functions to avoid excessive
1594 copying for data in/out fast paths.
1596 * case.c: (case_serial_size) Removed.
1597 (case_serialize) Rename case_to_values() and make its argument
1598 explicitly an array of union values.
1599 (case_unserialize) Rename case_from_values() and make its argument
1600 explicitly an array of union values.
1601 (case_data_all) New function.
1602 (case_data_all_rw) New function.
1604 * casefile.c: (struct casefile) Change buffer from array of
1605 unsigned char to array of union value for better accuracy.
1606 Redefine buffer_used and buffer_size in terms of values, not
1607 bytes. Remove case_size because it is now redundant with
1608 value_cnt. Fix up all references to these members.
1610 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1612 * barchart.c: (struct subcat) Make `label' member const to silence
1613 GCC warning with -Wwrite-strings.
1615 * cartesian.c: (struct dataset) Ditto.
1617 * case.c: Don't re-define NDEBUG if already defined.
1618 Add lots of comments.
1620 * str.c: Fix includes.
1622 * crosstabs.q: Fix includes.
1624 * examine.q: Fix includes. Fix GCC warning about unused
1627 * frequencies.q: (stat macro) Removed and replaced where used by
1630 * list.q: Fix includes.
1632 * oneway.q: Fix includes.
1634 * piechart.c: Fix includes. Only define M_PI if not already
1637 * sfm-read.c: (bswap) New function.
1638 (bswap_int32) Write in terms of bswap.
1639 (bswap_flt64) Ditto.
1641 * str.c: (ds_data) Add external definition here, needed because
1642 str.h has only an `extern inline' version.
1644 * value-labels.c: Fix includes.
1646 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1648 Instead of providing a system or portable file writer with a raw
1649 case in the format needed for output, provide it with a regular
1650 case. The writer takes care of any needed translation.
1652 * aggregate.c: Adopt new scheme for AGGREGATE.
1653 (struct agr_proc) sfm_agr_case member removed.
1654 (write_case_to_sfm) Removed because the new interface is easier to
1657 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1659 * pfm-write.c: Implement new scheme.
1661 * sfm-write.c: Ditto.
1663 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1665 Instead of treating `struct file_handle' as a class to subclass
1666 into data files, system files, and portable files, instead use it
1667 as a helper that coordinates access. Now it is opaque, too.
1669 This means that most references to a struct file_handle are now
1670 changed into references to one of struct dfm_reader, struct
1671 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1672 pfm_reader, or struct pfm_writer, according to what's being read
1675 Most related changes are only worth summarizing briefly.
1677 * dictionary.c: (dict_clear) Destroy aux data in deleted
1679 (dict_clear_aux) New function.
1680 (dict_create_var) Initialize aux, aux_dtor.
1681 (dict_delete_var) Destroy aux data in deleted variable.
1683 * file-handle.h: (struct fh_ext_class) Removed.
1684 (struct file_handle) Removed.
1685 (fh_init_files) Removed.
1687 * file-handle.q: Changed references to a handle's `private' member
1688 to direct references.
1689 (struct private_file_handle) Renamed file_handle.
1690 Add next, open_cnt, type, open_mode, aux members.
1691 (struct file_handle_list) Removed.
1692 (extern var inline_file) Removed.
1693 (static var file_handles) Changed from file_handle_list * to
1695 (create_file_handle) Initialize new members.
1696 (fh_close_handle) Removed.
1697 (mode_name) New function.
1698 (fh_open) New function.
1699 (fh_close) New function.
1700 (fh_parse_file_handle) Renamed fh_parse().
1702 * glob.c: (init_glob) Remove fh_init_files() call.
1704 * aggregate.c: use sfm_writer.
1705 (create_sysfile) Removed because the new interface is simpler.
1707 * apply-dict.c: Use sfm_reader.
1709 * data-list.c: Use dfm_reader.
1711 * file-type.c: Use dfm_reader.
1713 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1715 * inpt-pgm.c: Use dfm_reader.
1717 * print.c: Use dfm_writer.
1719 * sysfile-info: Use sfm_reader.
1721 * dfm-read.c: Adopt new file handle infrastructure.
1723 * dfm-write.c: Ditto.
1725 * pfm-read.c: Ditto.
1727 * pfm-write.c: Ditto.
1729 * sfm-read.c: Ditto.
1731 * sfm-write.c: Ditto.
1733 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1735 Break dictionary functions into separate header file.
1737 * dictionary.h: New file.
1739 * var.h: Moved dict_*() functions to dictionary.h.
1741 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1743 Get rid of procedure-specific union in struct variable, using
1744 instead a void * pointer and a destructor function.
1746 Most related changes are only worth brief summaries.
1748 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1749 old p.crs member in struct variable.
1751 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1752 of old p.frq member in struct variable.
1754 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1755 it's no longer possible to grab this from var->p.frq.
1757 * piechart.c: (draw_piechart) Ditto.
1759 * group.c: (group_proc_get) New function.
1761 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1768 * main.c: (execute_command) Clear aux data in default_dict after
1769 each command. (It's debatable whether this should be done.)
1771 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1772 member in struct variable.
1774 * means.q: Get rid of integer mode, which is not included in
1775 recent SPSS and was the only code that wanted per-variable private
1778 * var.h: (struct crosstab_proc) Removed.
1779 (struct frequencies_proc) Removed.
1780 (struct list_proc) Removed.
1781 (struct get_proc) Removed.
1782 (struct means_proc) Removed.
1783 (struct matrix_data_proc) Removed.
1784 (struct match_files_proc) Removed.
1785 (lots of enums) Removed.
1786 (struct variable) Removed members `p', `get'. Add member
1789 * vars-atr.c: (var_attach_aux) New function.
1790 (var_detach_aux) New function.
1791 (var_clear_aux) New function.
1792 (var_dtor_free) New function.
1793 (discard_variables) Use NULL instead of inline_file.
1795 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1797 * value-labs.c Fixed the implmentation of value_to_string, so
1798 that it properly handles alpha values.
1800 * oneway.q Changed instances where labels were being probed manually,
1801 to use the canonical {var,value}_to_string functions
1803 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1805 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1806 plots. Changed the API of the cartesian plot to be a much lower level
1809 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1811 * examine.q Added some of the parametric calculations
1813 * factor_stats.[ch] Created
1815 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1817 * examine.q Changed the definition of factors to be a composite, and
1818 dealt with the consequences.
1820 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1822 * examine.q Fixed problem where examine wasn't dealing properly with
1825 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1827 * oneway.q Fixed problem where oneway wasn't dealing properly with
1830 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1832 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1833 command which had settings didn't get the appropriate code
1836 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1837 to convert variables/values to strings.
1839 * examine.q Added framework for the EXAMINE command.
1841 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1843 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1844 subcommand types. Changed frequencies.q to use it rather then the
1845 custom parser. Dealt with the consequences. Added a test for NTILES
1846 subcommand of frequencies.
1848 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1850 * oneway.q Fixed up the behaviour when given missing values
1852 * levene.c oneway.q Fixed a buglet with the levene statistic and
1853 incorporated the levene test into the oneway command.
1855 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1856 global scope, since they're only relevant to T-TEST
1858 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1860 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1862 Made the t-test more consistent
1863 with the way it handles groups. That is, it now uses a hash instead
1864 of an array of 2. Also, made the levene.c file independent of the
1865 implementation of the t-test. So now levene should be fine for both
1868 * Added an oneway.q file for one way anova
1870 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1872 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1875 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1879 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1880 (data_list_trns_free) Free dls->delims.
1882 * t-test.q: (tts_custom_pairs) Free vars.
1883 (ssbox_one_sample_init) Fix tab_vline() argument.
1884 (ssbox_independent_samples_init) Ditto.
1885 (trbox_paired_init) Ditto.
1886 (trbox_one_sample_init) Ditto.
1888 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1890 Generalize casefiles to the extent that we can use them for
1891 sorting and other kinds of data transformations. Change cases to
1892 be copy-on-write to improve memory efficiency in common cases.
1893 Every access to a member of a `struct ccase' was changed to be a
1894 call to a case_*() function, especially case_data(), case_num(),
1895 case_str(), or case_data_rw(). Many instances of a local variable
1896 named "case_num" were changed to "case_idx" as a consequence.
1897 Many `struct ccase *' were changed to actual `struct ccase'
1898 because of copying semantics of cases. In several places there
1899 was a choice between updating debug code to work with the new ADTs
1900 or just deleting it because it was useless; I chose to delete it.
1902 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1908 * aggregate.c: (struct agr_proc) Change type of `sort' to
1909 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1910 Rename `vars' to `agr_vars', all references updated. Change
1911 `agr_case' to type `struct ccase'.
1912 (cmd_aggregate) Deal with new members. Use case_create(),
1913 sort_active_file_in_place(), sort_active_file_to_casefile().
1914 (agr_destroy) Deal with new members.
1915 (aggregate_single_case) Ditto.
1916 (dump_aggregate_info) Ditto.
1917 (initialize_aggregate_info) Ditto.
1918 (agr_to_active_file) Ditto.
1919 (presorted_agr_to_sysfile) Ditto.
1920 (sort_agr_to_sysfile) Removed.
1922 * alloc.c: (out_of_memory) Make non-static.
1924 * alloc.h: Prototype out_of_memory().
1926 * casefile.c: Switched from a linked list in-memory representation
1927 to a two-level array-style representation. The linked list was
1928 appropriate when we could stick a header onto cases, but that's no
1929 longer the case. Also, the two-level array will allow for random
1930 in-memory access in case that's ever wanted. Also added the
1931 concept of a `destructive casereader', one that destroys cases in
1932 the underlying casefile as they are read out.
1933 (macro CASES_PER_BLOCK) New macro.
1934 (struct casefile) New members `value_cnt', `case_list_size',
1935 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1937 (struct casereader) Removed `cur'. Added `destructive', `c'.
1938 (global var casefiles) Made static.
1939 (static var case_bytes) New var.
1940 (casefile_create) Takes a value count, not a case size in bytes,
1941 to conform to the case interface. All callers updated. Deal with
1942 new and removed members.
1943 (casefile_destroy) Deal with new and removed members.
1944 (casefile_sleep) New function.
1945 (casefile_get_case_size) Removed.
1946 (casefile_get_value_cnt) New function.
1947 (casefile_append) Rewritten to deal with new and removed members.
1948 (casefile_append_xfer) New function.
1949 (write_case_to_disk) Use case_serialize().
1950 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1951 Couldn't figure out why.
1952 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1953 deal with new and removed members.
1955 (merge_sort) Removed.
1956 (casefile_sort) Removed.
1957 (casefile_get_reader) Deal with new and removed members.
1958 (casefile_get_destructive_reader) New function.
1959 (reader_open_file) Make code more readable. Create case for
1961 (casereader_get_casefile) New function.
1962 (casereader_read) Deal with new and removed members. Now returns
1963 a copy of the case, so that the caller is responsible for
1964 destroying the returned case.
1965 (casereader_read_xfer) New function.
1966 (casereader_destroy) Destroy reader's case.
1967 (test_casefile) Second arg is now a value count, all callers
1968 updated. Now tests destructive readers too.
1969 (get_random_case) Deal with new case ADT.
1970 (write_random_case) Ditto.
1971 (read_and_verify_random_case) Ditto.
1973 * crosstabs.q: Remove debug code.
1975 * descript.q: (calc_descriptives) Deal with new case, casefile
1978 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1980 * do-if.c: Remove unneeded header inclusion.
1982 * expr-prs.c: Remove debug code.
1984 * exprP.h: Remove debug code.
1986 * flip.c: (flip_file) Use fseeko() if available.
1988 * formats.c: Remove debug code.
1990 * get.c: Remove debug code.
1991 (struct mtf_file) Change `input' from `union value *' to `struct
1992 ccase', all references updated.
1994 * levene.c: (levene) Deal with new case, casefile ADTs.
1996 * list.q: Remove debug code.
1998 * loop.c: Remove debug code.
2000 * matrix-data.c: Remove debug code.
2002 * means.q: Remove debug code.
2004 * mis-val.c: Remove debug code.
2006 * pfm-read.c: Remove debug code.
2007 (pfm_read_code) Change second arg from `union value *' to `struct
2008 ccase *', all references updated.
2010 * recode.c: (string_to_long) Make first arg const.
2011 (convert_to_double) Ditto.
2013 * repeat.c: Remove debug code.
2015 * sample.c: Remove debug code.
2017 * sfm-read.c: Remove debug code.
2018 (sfm_read_case) Change second arg from `union value *' to `struct
2021 * sort.c: Redone in terms of casefiles.
2022 (enum sort_direction) Moved here from sort.h.
2023 (struct sort_criterion) New structure.
2024 (struct sort_criteria) New structure.
2025 (cmd_sort_cases) Rewritten.
2026 (prepare_to_sort_active_file) New function.
2027 (sort_active_file_in_place) New function.
2028 (sort_active_file_to_casefile) New function.
2029 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2030 changed, all callers updated.
2031 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2032 rewritten & interface changed, all callers updated.
2033 (sort_cases) Renamed sort_execute(), rewritten & interface
2034 changed, all callers updated.
2035 (struct internal_sort) Removed.
2036 (do_internal_sort) Rewritten, interface changed.
2037 (destroy_internal_sort) Removed.
2038 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2039 (struct initial_run) Removed; an initial run is now just a
2041 (compare_initial_runs) Rewritten.
2042 (struct external_sort) Changed almost completely.
2043 (do_external_sort) Rewritten, interface changed.
2044 (destroy_external_sort) Rewritten.
2045 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2046 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2047 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2048 (init_external_sort) Removed.
2049 (simulate_error) Removed.
2050 (rmdir_temp_dir) Removed.
2051 (get_temp_file_name) Removed.
2052 (open_temp_file) Removed.
2053 (close_temp_file) Removed.
2054 (remove_temp_file) Removed.
2055 (write_temp_file) Removed.
2056 (read_temp_file) Removed.
2057 (struct record_run) Change `record' from `struct case_lit *' to
2059 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2060 `file_idx', `output_file'. Add `run', casefile'. Change
2061 `last_output' from `struct case_list *' to `struct ccase'.
2062 (write_initial_runs) Change interface, rewrite.
2063 (sort_sink_write) Renamed process_case(), changed interfaced,
2065 (destroy_initial_run_state) Rewritten.
2066 (allocate_cases) Rewritten.
2067 (compare_record) Interface changed, rewritten.
2068 (start_run) Rewritten.
2069 (end_run) Rewritten.
2070 (output_record) Rewritten.
2071 (grab_case) Removed.
2072 (release_case) Removed.
2073 (struct merge_case) Change `cases' from double pointer to single
2075 (merge) Deal with new case and casefile ADTs.
2076 (struct run) Removed.
2077 (merge_once) Rewritten, interface changed.
2078 (fill_run_buffer) Removed.
2079 (sort_sink_make_source) Removed.
2080 (sort_sink_class) Removed.
2081 (struct sort_source_aux) Removed.
2082 (sort_source_read_helper) Removed.
2083 (sort_source_read) Removed.
2084 (read_sort_output) Removed.
2085 (read_internal_sort_output) Removed.
2086 (read_external_sort_output) Removed.
2087 (sort_source_destroy) Removed.
2088 (sort_source_class) Removed.
2090 * sort.h: (struct sort_cases_pgm) Removed.
2091 (enum sort_direction) Moved to sort.c.
2093 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2095 * tab.c: Remove debug code.
2097 * var-labs.c: Remove debug code.
2099 * var.h: (struct ccase) Removed.
2100 (struct case_list) Removed.
2102 * vars-atr.c: (discard_variables) Use free_case_source().
2104 * vars-prs.c: (parse_vs_variable) Make arg const.
2105 (parse_dict_variable) Ditto.
2106 (parse_variables) Make struct dictionary * arg const.
2107 (parse_var_set_vars) Make struct var_set * arg const.
2108 (struct var_set) Add const to some of the function pointers' args.
2109 (var_set_get_cnt) Make arg const.
2110 (var_set_get_var) Make first arg const.
2111 (var_set_lookup_var) Make first arg const.
2112 (dict_var_set_get_cnt) Make arg const.
2113 (dict_var_set_get_var) Make first arg const.
2114 (dict_var_set_lookup_var) Make first arg const.
2115 (var_set_create_from_dict) Make arg const. Add cast to aux
2117 (struct array_var_set) Add const to var member.
2118 (array_var_set_get_cnt) Make arg const.
2119 (array_var_set_get_var) Make first arg const.
2120 (array_var_set_lookup_var) Make first arg const.
2121 (var_set_create_from_array) Make first arg const. Insert cast.
2123 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2124 members from `struct ccase *' to `struct ccase'.
2125 (static var lag_queue) Change from double to single pointer.
2126 (procedure) Optimize trivial case.
2127 (internal_procedure) Deal with changed case, case_source ADTs.
2128 (create_trns_case) Changed interface, rewrote.
2129 (open_active_interface) Initialize modified lag queue.
2130 (write_case) Deal with changed case ADT.
2131 (lag_case) Deal with modified lag queue.
2132 (close_active_file) Destroy modified lag queue.
2133 Deal with changed case_source, case_sink ADTs.
2134 (destroy_storage_stream_info) Make null arg into no-op.
2135 (storage_sink_make_source) Set aux in created source.
2136 (storage_source_read) Deal with changed case, casefile ADTs.
2137 (storage_source_create) New function.
2138 (lagged_case) Rewrite.
2139 (free_case_source) New function.
2140 (free_case_sink) Rewrite.
2141 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2143 (procedure_with_splits) Deal with changed prev_case.
2144 (procedure_with_splits_callback) Ditto.
2145 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2147 (multipass_procedure_with_splits) Deal with changed prev_case.
2148 (multipass_split_callback) Ditto.
2151 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2153 The workspace idea didn't work out.
2155 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2157 * workspace.c: Removed.
2159 * workspace.h: Removed.
2161 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2163 Fully implement arbitrary delimiters on DATA LIST, extending the
2164 half implementation that was already there.
2166 * data-list.c: (struct data_list_pgm) Remove `delim', add
2167 `delims', `delim_cnt'.
2168 (cmd_data_list) Initialize new members. Parse delimiters and
2169 clean up code a bit.
2170 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2171 handling of leading commas.
2172 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2174 (read_from_data_list_free) Adapt to new DFM interfaces.
2175 (read_from_data_list_list) Ditto.
2176 (repeating_data_trns_proc) Ditto.
2178 * dfm.c: Split up reader and writer into separate code, because
2179 they do different things. Use struct string instead of explicit
2180 allocation code, for clarity.
2181 (enum dfm_reader_flags) New enum.
2182 (struct dfm_fhuser_ext) Removed.
2183 (struct dfm_reader_ext) New.
2184 (get_reader) New function, used by just about all the reader
2186 (dfm_close) Removed.
2187 (close_reader) New function.
2188 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2189 (dfm_open_for_writing) Ditto.
2190 (macro force_line_buffer_expansion) Removed.
2191 (count_tabs) Removed.
2192 (tabs_to_spaces) Removed.
2193 (read_record) Deal with new dfm_reader_ext. Use struct string
2194 functions. Don't convert tabs to spaces.
2195 (dfm_eof) New function.
2196 (dfm_get_record) Changed interface, rewrote.
2197 (dfm_expand_tabs) New function.
2198 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2199 dfm_reader_ext, rewritten.
2200 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2201 dfm_reader_ext, rewritten.
2202 (dfm_set_record) Removed in favor of dfm_forward_columns().
2203 (dfm_forward_columns) New function.
2204 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2205 dfm_reader_ext, rewritten.
2206 (static var dfm_r_class) Use close_reader for the destructor.
2207 (struct dfm_writer_ext) New.
2208 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2209 bounce buffer now instead of local allocation.
2210 (close_writer) New function.
2211 (static var dfm_writer_ext) Use close_writer for destructor.
2212 (cmd_begin_data) Adapt to new dfm_reader_ext.
2214 * file-handle.q: Add support for per-file tab width.
2215 (struct private_file_handle) Add tab_width member.
2216 (q2c specifications) Add tabwidth subcommand.
2217 (cmd_file_handle) Put parsed tab width into private_file_handle.
2218 (create_file_handle) Set default tab width.
2219 (handle_get_tab_width) New function.
2221 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2223 * inpt-pgm.c: (reread_trns_proc) Ditto.
2225 * matrix-data.c: (context) Ditto.
2226 (another_token) Ditto.
2230 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2232 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2234 (casereader_destroy) Don't close file descriptor -1.
2236 * recode.c: (cmd_recode) Fix memory leak.
2238 * set.q: (q2c specifications) Fix typo in user message.
2240 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2241 undefined behavior for overlapping arguments.
2243 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2245 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2246 don't call it when we're running under valgrind.
2247 (call_posix_fadvise) New function.
2248 (casefile_to_disk) Use call_posix_fadvise().
2249 (reader_open_file) Ditto.
2251 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2253 Update our string ADTs, struct string and struct len_string. Get
2254 rid of pool support, which was largely unused. Rename lots of
2255 functions to have more obvious or consistent names.
2257 * ascii.c: Get rid of ascii_pool. It was only used for string
2259 (ascii_open_global) Don't create ascii_pool.
2260 (ascii_close_driver) Don't destroy ascii_pool.
2261 (ascii_postopen_driver) Don't use pool.
2262 (ascii_close_driver) Destroy strings manually.
2264 * str.c: (ds_create) Remove pool argument, all references updated.
2266 (ds_replace) Remove pool support, make more efficient when we
2267 don't need to reallocate.
2268 (ds_destroy) Remove pool support.
2269 (ds_rpad) New function.
2270 (ds_size) Renamed ds_capacity(), all references updated.
2271 (ds_value) Renamed ds_c_str(), all references updated.
2272 (ds_concat) Renamed ds_puts(), all references updated.
2273 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2274 (ds_putchar) Renamed ds_putc(), all references updated.
2275 (ds_getline) Renamed ds_gets(), all references updated.
2276 (ls_create) Remove pool argument, all references updated.
2277 (ls_create_buffer) Ditto.
2278 (ls_destroy) Removed pool support.
2279 (ls_value) Renamed ls_c_str(), all references updated.
2281 * str.h: (ls_length) [__GNUC__] Add inline version.
2282 (ls_c_str) [__GNUC__] Add inline version.
2283 (ls_end) [__GNUC__] Add inline version.
2284 (struct string) Remove pool member. Rename `size' to `capacity',
2285 all references updated.
2287 * tab.c: (text_format) Instead of using pool argument to
2288 ls_create_buffer(), call pool_register() on allocated data.
2290 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2292 We're abusing the current ASCII driver by telling it to allocate a
2293 9999-line, 9999-character page in the tests. This causes some
2294 systems to curl up and die because it allocates 20 MB of
2295 contiguous RAM. This change alleviates at least part of the
2296 problem. It is mostly a stop-gap until the new output system is
2299 * ascii.c: (struct line) New structure.
2300 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2301 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2302 (ascii_preopen_driver) Initialize new members, not old ones.
2303 (ascii_close_driver) Destroy new members, not old ones.
2304 (ascii_open_page) Allocate new members, not old ones.
2305 (expand_line) Allocate room in line.
2306 (draw_line) Use new members.
2307 (ascii_line_horz) Ditto.
2308 (ascii_line_vert) Ditto.
2309 (ascii_line_intersection) Ditto.
2311 (output_lines) Ditto.
2312 (ascii_close_page) Ditto.
2314 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2316 * matrix.c: Dead code. Removed.
2318 * matrix.h: Dead code. Removed.
2320 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2322 Contrary to what I'd always understood, there is an efficient
2323 algorithm for deletion from a hash table populated via linear
2324 probing. This change implements it.
2326 * hash.c: (hsh_rehash) Probe in increasing order.
2328 (locate_matching_entry) Ditto.
2329 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2331 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2333 * moments.c (calc_moments): Adjust calculation of kurtosis to
2334 avoid subtracting huge numbers from huge numbers, on Michael
2337 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2339 Rework moments routines for improved numerical stability based on
2340 Michael Kiefte's advice. Any bugs or remaining numerical problems
2341 are still mine though.
2343 There is now a struct moments1 for use with one-pass moments. It
2344 uses a provisional means algorithm as an attempt to improve
2345 accuracy of higher moments. The older struct moments now only
2346 handles two-pass moments.
2348 * aggregate.c: Use moments1 instead moments.
2350 * descript.c: Revert previous change, which is no longer needed
2351 due to the moments revision.
2353 * moments.c: (calc_moments) New function for calculating variance,
2355 (moments_pass_one) Only accumulate weights bigger than zero.
2356 (moments_calculate) Allow calculating the mean on pass one, others
2357 require pass two. Implement in terms of calc_moments().
2358 (struct moments1) New structure.
2359 (init_moments1) New function.
2360 (moments1_clear) Ditto.
2361 (moments1_create) Ditto.
2362 (moments1_add) Ditto.
2363 (moments1_calculate) Ditto.
2364 (moments1_destroy) Ditto.
2365 (cmd_debug_moments) Deal with `struct moments' or `struct
2366 moments1' as requested by user.
2368 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2370 * Makefile.am (pspp_SOURCES): Remove debug.c.
2372 * debug.c: Removed. It was empty anyway.
2374 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2376 * descript.c (calc_descriptives): Fix assert failure when only
2377 MOMENT_MEAN is needed.
2379 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2383 fixed problem with parsing in match_statistic() causing
2384 "DESCRIPTIVE STAT=MEAN." to barf.
2386 "MEAN" is now default if "SORT" given without specification.
2388 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2389 generally less forgiving of syntax errors: better to have it do
2390 nothing and type it in again then to not know what it actually did
2393 z-score transformation now checks score for user-missing values
2394 and checks std_dev for SYSMIS.
2396 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2398 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2399 Changed dict_get_case_weight() to accept an additional int * flag
2400 to complain about system-missing, user-missing, zero, or negative
2401 weights and updated existing functions to pass int * to
2402 dict_get_case_weight().
2404 2004-04-05 jmd <jmd@gnu.org>
2406 * main.c: Fixed configuration problems with gsl
2408 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2410 2004-04-03 blp <blp@gnu.org>
2412 * lexer.c, ChangeLog:
2413 Fix infinite loop on comment at end of file, add test.
2415 2004-04-03 jmd <jmd@gnu.org>
2417 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2418 Fixed the calculation of percentiles and added --syntax and --algorithm options
2420 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2422 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2425 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2427 * frequencies.q: Fixed the calculation of percentiles
2429 * Makefile.am: Added the --ansi flag and dealt with the
2430 consequences. Added some entries to PSPP_sources so that
2431 make distcheck would pass
2433 * cmdline.c: Added the --syntax and --algorithm options
2435 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2437 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2439 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2440 use the new multipass_split_... mechanism.
2442 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2444 * frequencies.q: (calc_stats) Use moments data structure and
2445 calc_seskew(), calc_sekurt() functions.
2447 * set.q main.c settings.h Added support for --syntax and --algorithm
2450 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2452 * vfm.c: Had to get last call to multipass_split_output() inside
2453 open_active_file()/close_active_file() pairing, so introduce new
2455 (internal_procedure) Move procedure() code here, except for calls
2456 to open_active_file() and close_active_file().
2457 (procedure) Wrap open_active_file() and close_active_file() around
2458 internal_procedure().
2459 (multipass_procedure_with_splits) Wrap open_active_file() and
2460 close_active_file() around internal_procedure().
2462 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2464 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2466 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2468 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2470 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2472 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2474 * algorithm.c: By default turn off some of the more expensive
2476 (expensive_assert) New macro which expands to assert if
2477 EXTRA_CHECKS is defined, to nothing otherwise.
2478 (unique) Use expensive_assert().
2479 (binary_search) Ditto.
2485 * command.c: (conflicting_3char_prefixes) Words that are the same
2486 don't cause conflicts when they are abbreviated to the first three
2489 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2490 nonterm_node's n earlier.
2491 (generic_str_func) Ditto.
2493 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2495 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2496 test multipass support, take advantage of new moments
2497 calculation, and to not be such crappy code. Get rid of q2c
2498 processing for DESCRIPTIVES.
2500 * vfm.c: (struct multipass_split_aux_data) New structure.
2501 (multipass_procedure_with_splits) New function.
2502 (multipass_split_callback) New function.
2503 (multipass_split_output) New function.
2504 * descript.q: Removed.
2506 * descript.c: New file.
2508 * var.h: Removed descriptives enums.
2509 (struct descriptives_proc) Removed.
2510 (struct variable) Removed p.dsc.
2512 * Makefile.am: (q_sources_c) Remove descript.c.
2513 (q_sources_q) Removed descript.q.
2515 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2517 New manager for keeping track of used workspace.
2519 * workspace.c: New file.
2521 * workspace.h: New file.
2523 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2525 * sort.c: (do_internal_sort) Use workspace_malloc().
2526 (destroy_internal_sort) Use workspace_free().
2528 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2530 New `struct casefile' for managing sets of cases.
2532 * casefile.c: New file.
2534 * casefile.h: New file.
2536 * command.def: Add DEBUG CASEFILE command.
2538 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2540 * sort.c: (sort_cases) Move logic for sending storage file to disk
2541 into do_external_sort().
2542 (struct internal_sort) Use an array of ccase pointers instead of a
2544 (do_internal_sort) Rewrite to handle casefiles.
2545 (compare_case_list) Removed.
2546 (compare_cases) New function.
2547 (compare_case_dblptrs) New function.
2548 (read_internal_sort_output) Deal with new struct internal_sort.
2550 * vfm.c: (static var workspace_overflow) Removed.
2551 (struct storage_stream_info) Removed all the members. Added
2552 struct casefile * member.
2553 (storage_sink_open) Use casefile.
2554 (open_storage_file) Removed.
2555 (write_storage_file) Removed.
2556 (storage_to_disk) Removed.
2557 (destroy_storage_stream_info) Use casefile.
2558 (storage_sink_write) Use casefile.
2559 (storage_sink_make_source) Use casefile.
2560 (storage_source_count) Use casefile.
2561 (storage_source_read) Use casefile.
2562 (storage_source_on_disk) Removed.
2563 (storage_source_get_cases) Removed.
2564 (storage_source_set_cases) Removed.
2565 (storage_source_get_casefile) New function.
2567 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2569 New `struct moments' for calculating moments.
2575 * moments.c: New file.
2577 * moments.h: New file.
2579 * command.def: Add DEBUG MOMENTS command.
2581 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2584 * aggregate.c: Modify AGGREGATE to use the new moments
2585 calculation, even if not in such a great way.
2586 (struct agr_var) Add `moments' member.
2587 (parse_aggregate_functions) Set `moments' member to null.
2588 (agr_destroy) Destroy `moments' member.
2589 (accumulate_aggregate_info) Use `moments' for standard deviation.
2590 (dump_aggregate_info) Ditto.
2591 (initialize_aggregate_info) Create or clear `moments'.
2593 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2594 cube(), pow4() that were in stats.h. All references updated.
2596 * crosstabs.q: stats.h had chi-square significance functions. Use
2598 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2600 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2601 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2603 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2605 * dictionary.c: (dict_compact_values) Compacted values need to
2608 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2610 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2611 `/' at start. Check return value of parse_variables() for error
2614 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2616 Revamp expressions: make the code a little nicer, and fix bugs
2619 * expr-evl.c: (expr_evaluate) Make expression argument const.
2620 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2621 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2622 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2623 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2624 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2625 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2626 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2627 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2628 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2629 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2630 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2631 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2632 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2634 * expr-opt.c: (optimize_expression) Rewrite.
2639 (macro s0l) Removed.
2641 (macro s1l) Removed.
2643 (macro s2l) Removed.
2646 (eq_num_con) New function.
2647 (optimize_tree) New function.
2648 (macro rnc) Removed.
2649 (macro frnc) Removed.
2650 (str_search) Add const to string params.
2651 (str_rsearch) Ditto.
2652 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2653 str[], str_len[] locals to substitute for most of removed macros.
2654 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2655 Removed support for missing values because we're never called with
2656 missing values. Use set_number() or set_number_errno() instead of
2657 rnc or frnc. Removed any stuff that caused trouble in testing.
2658 We can re-add it later if it really slows anything. Fix some
2660 (evaluate_tree_with_missing) Not yet supported. To be added later
2662 (repl_num_con) Removed.
2663 (collapse_node) New function.
2664 (force_repl_num_con) Removed.
2665 (set_number) New function.
2666 (set_number_errno) New function.
2667 (repl_str_con) Removed.
2668 (set_string) New function.
2669 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2671 (dump_node) No special case for OP_AND, OP_OR.
2673 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2674 (expr_get_type) New function.
2675 (type_check) Rewrite.
2676 (type_coercion) New function.
2677 (struct operator) New structure.
2678 (match_operator New function.
2679 (parse_binary_operators) New function.
2680 (parse_inverting_unary_operator) New function.
2681 (parse_or) Rewritten.
2682 (parse_and) Rewritten.
2683 (parse_not) Rewritten.
2684 (parse_rel) Rewritten.
2685 (parse_add) Rewritten.
2686 (parse_mul) Rewritten.
2687 (parse_neg) Rewritten.
2688 (parse_exp) Rewritten.
2689 (parse_sysvar) Add $TRUE, $FALSE system variables.
2690 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2691 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2693 (struct function) Remove desc, change `func' prototype.
2694 (unary_func) Remove special cases.
2695 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2696 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2697 (VALUE_func) Use allocate_var_node().
2698 (nary_num_func) Allow MIN and MAX for strings.
2699 Use allocate_var_node(). Properly clean up.
2701 (generic_str_func) Use local table instead of removed `desc'
2702 member. Mostly rewrite.
2703 (get_num_args) Revise error message.
2704 (parse_function) Return EXPR_ERROR, not 0 on error.
2706 (macro varies) Removed.
2707 (ops[]) Use expr.def.
2708 (free_node) Do nothing if node is null.
2709 (allocate_num_con) New function.
2710 (allocate_str_con) New function.
2711 (allocate_var_node) New function.
2712 (allocate_binary_nonterminal) New function.
2713 (append_nonterminal_arg) Removed.
2714 (static var func_tab[]) Revised.
2715 (expr_debug_print_postfix) Make parameter const.
2716 Use printf() instead of debug_printf().
2718 * expr.def: New file.
2720 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2721 use named enum instead of unnamed, all references updated. Add
2722 EXPR_ANY, EXPR_NO_OPTIMIZE.
2724 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2725 instead of defining OP_* directly.
2726 (macro IS_TERMINAL) New macro.
2727 (macro IS_NONTERMINAL) New macro.
2728 (enum OP_NO_FLAGS) New.
2730 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2732 * error.c: (err_assert_fail) msg variable needs to be non-const.
2734 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2736 * debug.c: (cmd_debug_evaluate) Rewrite.
2738 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2740 Fix some CROSSTABS bit rot stupidity.
2742 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2743 (internal_cmd_crosstabs) Initializes cells[] correctly.
2744 (float_M_suffix) Rename format_cell_entry(), change prototype,
2746 (display_crosstabulation) Fix cell formatting.
2748 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2750 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2751 to call lex_discard_line() to do that.
2753 * command.c: (run_command) Call lex_discard_line() after
2756 * lexer.c: (lex_entire_end) Change behavior.
2757 (lex_rest_of_line) Change behavior. Return const char *.
2758 (lex_discard_line) Don't clear getl_buf, don't emit message.
2760 * main.c: (handle_error) Emit message here.
2762 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2763 instead of lex_entire_line().
2765 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2767 * title.c: (get_title) Call lex_discard_line() after
2769 (cmd_file_label) Ditto.
2770 (cmd_document) Deal with const char * return value.
2772 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2774 Removed REMARK command.
2776 * command.c: (extract_prefix) Removed.
2777 (output_line) Removed.
2778 (cmd_remark) Removed.
2780 * command.def: Remove REMARK.
2782 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2784 Added abort() after lots of assert(0) invocations to avoid some
2785 compiler warnings. We really need a NOT_REACHED macro.
2787 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2789 * sort.c: Added missing call to temp_file_close. Changed error
2790 messages to warnings.
2792 * set.q: Improved setting of set_view{length,width} to be more tolerant
2795 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2797 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2798 used with incorrect syntax.
2800 * error.c, error.h et al: Overridden definition of assert for a
2803 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2804 subcommand was given when it ought to have been.
2806 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2808 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2812 (tab_joint_text) Ditto.
2814 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2816 * levene.c: Add #include.
2818 * set.q: (set_viewport) Add `int' argument to make its prototype
2819 correct for signal().
2821 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2823 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2826 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2828 Changed DFM from open-at-first-access to explicit-open. Before,
2829 calling dfm_get_record() or dfm_put_record() would automatically
2830 open the file. Now, you have to call dfm_open_for_reading() or
2831 dfm_open_for_writing() explicitly. This makes it possible to
2832 check permissions, file existence, etc. earlier.
2834 Also made struct file_handle more opaque, and clean up in general.
2836 * data-list.c: (cmd_data_list) Open handle for reading.
2838 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2840 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2841 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2842 (open_inline_file) Removed.
2843 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2844 it. Deal with line_number in extension record instead of file
2846 (dfm_get_record) Rewrote.
2847 (dfm_put_record) Rewrote.
2848 (dfm_push) Assert file is open and one of ours. Deal with
2849 line_number in extension record instead of file handle.
2850 (dfm_pop) Assert file is open and one of ours. Deal with
2851 line_number in extension record instead of file handle.
2852 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2855 * file-handle.h: (enum constants RH_RF_*) Removed.
2856 (enum constants FH_MD_*) Removed.
2857 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2858 `recform', `lrecl', `mode' members. Public references to
2859 `recform' changed to use handle_get_mode(), references to `lrecl'
2860 changed to use handle_get_record_width(). Added `private' member.
2861 (enum file_handle_mode) New.
2863 * file-handle.q: (struct private_file_handle) New structure.
2864 (struct file_handle_list) New structure.
2865 (static var files) New.
2866 (static var file_handles) Removed.
2867 (init_file_handle) Removed.
2868 (create_file_handle) Removed.
2869 (get_handle_with_name) New function.
2870 (get_handle_for_filename) New function.
2871 (cmd_file_handle) Rewritten.
2872 (hash_file_handle) Removed.
2873 (cmp_file_handle) Removed.
2874 (fh_init_files) Rewritten.
2875 (fh_parse_file_handle) Rewritten. Allows identifiers as
2877 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2879 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2880 references updated. Rewritten.
2881 (fh_record_width) Renamed handle_get_record_width(), all
2882 references updated. Rewritten.
2883 (handle_get_mode) New function.
2885 * file-type.c: (cmd_file_type) Open handle for reading.
2887 * filename.c: [unix] (struct file_identity) New structure.
2888 [unix] (fn_get_identity) New function.
2889 [unix] (fn_free_identity) New function.
2890 [unix] (fn_compare_file_identities) New function.
2891 [!unix] (struct file_identity) New structure.
2892 [!unix] (fn_get_identity) New function.
2893 [!unix] (fn_free_identity) New function.
2894 [!unix] (fn_compare_file_identities) New function.
2896 * lexer.c: (static var put) Renamed put_token, all references
2898 (static var put_tokstr) New.
2899 (static var put_tokval) New.
2900 (lex_init) Initialize put_tokstr().
2901 (restore_token) New function.
2902 (save_token) New function.
2903 (lex_get) Use restore_token().
2904 (lex_put_back) Use save_token().
2905 (lex_put_back_id) New function.
2906 (lex_put_forward) Removed.
2907 (lex_preprocess_line) Set put_token instead of using
2909 (lex_negative_to_dash) Use save_token(), set put_token directly.
2910 (dump_token) Use stderr instead of stdout.
2912 * main.c: (main) Remove call to cmd_init().
2914 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2916 * pfm-read.c: Use handle_get_filename() instead of trying to use
2917 h->fn directly, all over.
2919 * pfm-write.c: Ditto.
2921 * print.c: (internal_cmd_print) Open handle for writing.
2922 (dump_table) Use handle_get_filename().
2923 (print_trns_proc) Use handle_get_mode().
2924 (cmd_print_space) Use fh_parse_file_handle().
2925 Open handle for writing.
2926 [0] (debug_print) Removed.
2928 * sfm-read.c: Use handle_get_filename() instead of trying to use
2929 h->fn directly, all over.
2931 * sfm-write.c: Ditto.
2933 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2937 * autorecode.c: (arc_free) Free arc->src_values.
2939 * error.c: (msg) Free buf.
2941 * val-labs.c: (do_value_labels) Always free vars.
2943 * vfm.c: (close_active_file) If sink has no make_source then call
2944 its destroy function.
2946 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2948 Fixed cmd_parse() so that it always skips past a full command
2949 name. A few special commands for which this would be bad get
2950 special treatment. This lets us drop code for skipping past the
2951 end of a command name in most cmd_*() functions. It's not worth
2952 listing all the commands affected.
2954 * command.c: (struct command) Remove `cmd' member, replace by
2955 `name' member, all references updated. Remove `word', `next',
2956 `skip_entire_name' members.
2957 (macro DEFCMD) Deal with revised `struct command'.
2958 (macro UNIMPL) Ditto.
2959 (macro SPCCMD) New macro for commands whose last word shouldn't be
2961 (static array cmd_table[]) Make const, rename `commands', remove
2963 (macro COMMAND_CNT) New macro.
2964 (split_words) Removed.
2966 (FILE_TYPE_okay) Make parameter const.
2967 (cmd_parse) Improve error messages.
2968 (match_strings) New function.
2969 (next_word) New function.
2970 (enum command_match) New enum.
2971 (conflicting_3char_prefixes) New function.
2972 (conflicting_3char_prefix_command) New function.
2973 (cmd_match_words) New function.
2974 (count_matching_commands) New function.
2975 (get_command_name) New function.
2976 (free_words) New function.
2977 (unknown_command_error) New function.
2978 (figure_out_command) Renamed parse_command_name(), rewritten.
2980 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2981 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2982 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2985 * command.h: (macro SPCCMD) New.
2987 * include.c: (cmd_include_at) Removed.
2988 (cmd_include) Allow identifier to be used as filename.
2990 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2992 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2995 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2997 Start work on better test framework.
2999 * Makefile.am: (pspp_sources) Add debug.c.
3001 * debug.c: New file.
3003 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3004 cmd_debug_evaluate().
3006 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3008 * expr.h: (enum constant PXP_DUMP) Removed.
3010 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3012 * set.q: Implemented the SHOW command, and synced it to the existing
3015 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3016 changes as the window size is changed.
3018 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3019 environment variables if other methods are not available.
3021 glob.c: Removed a lot of global variables from glob.c and encapsulated
3024 random.c: Tidied up the way the random seed is set.
3026 str.c: Added a ds_vprintf function.
3028 error.c: Extended dump_message so that messages are always broken at
3031 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3033 * pfm-write.c: (bufwrite) Write out the correct element for string
3034 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3036 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3038 Get rid of static and global (!) vars in matrix-data.c.
3040 * matrix-data.c: (static var nr_data) Removed.
3041 (static var nr_factor_values) Removed.
3042 (static var max_cell_index) Removed.
3043 (static var split_values) Removed.
3044 (struct nr_aux_data) New structure.
3045 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3046 place of static vars, pass to create_case_source() and procedure()
3048 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3049 struct matrix_data_pgm *.
3050 (nr_read_splits) Ditto.
3051 (nr_read_factors) Ditto.
3052 (nr_output_data) Ditto.
3053 (static var wr_content) Removed.
3054 (global var wr_data) Removed.
3055 (global var wr_current) Removed.
3056 (struct wr_aux_data) New structure.
3057 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3058 place of static vars, pass to create_case_source() and procedure()
3060 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3061 instead of matrix_data_pgm *.
3062 (wr_read_splits) Ditto.
3063 (wr_output_data) Ditto.
3064 (wr_read_rowtype) Ditto.
3065 (wr_read_factors) Ditto.
3066 (wr_read_indeps) Ditto.
3068 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3070 Get rid of static vars in autorecode.c.
3072 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3073 `n_arc' to `spec_cnt'. All references updated.
3074 (static var v_src) Removed.
3075 (static var v_dest) Removed.
3076 (static var h_trns) Removed.
3077 (static var nv_src) Removed.
3078 (static var descend) Removed.
3079 (static var print) Removed.
3080 (enum direction) New enum.
3081 (struct autorecode_pgm) New structure.
3082 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3083 Move n_dest local var into struct autorecode_pgm for ease of
3084 clean-up. Use arc_free().
3085 (arc_free) New function.
3086 (recode) Modify to take struct autorecode_pgm * parameter instead
3087 of using statics. Let the caller clean up.
3088 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3089 instead of statics. Rearrange code a little.
3091 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3093 Get rid of static, global vars in recode.c. Remove debug code.
3095 * recode.c: (static var head) Removed.
3096 (global var v) Removed.
3097 (global var nv) Removed.
3098 (cmd_recode) New local variables head, v, nv. Initialize and free
3099 v. Don't call debug_print().
3100 [DEBUGGING] (dump_dest) Removed.
3101 [DEBUGGING] (debug_print) Removed.
3103 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3105 Get rid of static vars in expr-opt.c.
3107 * expr-opt.c: (static var e) Removed.
3108 (static var nop) Removed.
3109 (static var mop) Removed.
3110 (static var ndbl) Removed.
3111 (static var mdbl) Removed.
3112 (static var nstr) Removed.
3113 (static var mstr) Removed.
3114 (static var nvars) Removed.
3115 (static var mvars) Removed.
3116 (struct expr_dump_state) New structure.
3117 (dump_expression) Use new struct expr_dump_state instead of static
3118 vars and pass to functions we call.
3119 (dump_node) Use struct expr_dump_state * parameter.
3121 (emit_num_con) Ditto.
3122 (emit_str_con) Ditto.
3125 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3127 Get rid of static var in COUNT.
3129 * count.c: (static var head) Move into cmd_count().
3130 (cmd_count) [DEBUGGING] Don't call debug_print.
3131 [DEBUGGING] (debug_print) Removed.
3133 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3135 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3137 * val-labs.c: (static var v) Removed.
3138 (static var nv) Removed.
3139 [DEBUGGING] (debug_print) Removed.
3140 (verify_val_labs) Add struct variable **, int parameters.
3141 (get_label) Ditto. Improve error messages, streamline.
3142 (erase_labels) New function for erasing value labels, taking over
3143 part of verify_val_labs()'s function.
3146 (cmd_value_labels) No need to call init() or done() anymore.
3147 (cmd_add_value_labels) Ditto.
3148 (do_value_labels) Add vars, var_cnt local variables. Clean up
3149 after them internally. Call erase_labels() if we should. Don't
3152 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3154 Get rid of static vars in MATCH FILES.
3156 * get.c: (static var mtf_head) Removed.
3157 (static var mtf_tail) Removed.
3158 (static var mtf_by) Removed.
3159 (static var mtf_n_by) Removed.
3160 (static var mtf_master) Removed.
3161 (static var mtf_seq_num) Removed.
3162 (static var mtf_seq_nums) Removed.
3163 (static var mtf_sink) Removed.
3164 (static var mtf_case) Removed.
3165 (struct mtf_proc) New structure.
3166 (cmd_match_files) Use struct mtf_proc instead of static vars.
3167 (mtf_processing_finish) Ditto.
3169 (mtf_delete_file_in_place) Ditto.
3170 (mtf_read_nonactive_records) Ditto.
3171 (mtf_compare_BY_values) Ditto.
3172 (mtf_processing) Ditto.
3173 (mtf_merge_dictionary) Ditto.
3175 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3177 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3179 * dictionary.c: (dict_rename_var) Add assertion.
3180 (dict_contains_var) Check by index instead of name.
3182 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3184 Get rid of compaction_necessary, compaction_nval, compaction_case.
3185 Redo VFM interface. Replace disk_sink and memory_sink by
3186 storage_sink, disk_source and memory_source by storage_source.
3188 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3192 (struct write_case_data) Remove `begin_func', `end_func',
3193 `func_aux' members. Add `aux', `trns_case', `sink_case',
3194 `cases_written', `cases_analyzed' members.
3195 (global var compaction_necessary) Make static.
3196 (global var compaction_nval) Removed.
3197 (global var compaction_case) Removed.
3198 (static var case_count) Removed.
3199 (struct procedure_aux_data) Removed.
3200 (struct split_aux_data) Removed.
3201 (procedure) Remove begin_func, end_func parameters. Rewrite.
3202 (static var not_canceled) Removed.
3203 (process_active_file) Removed.
3204 (process_active_file_write_case) Removed.
3205 (process_active_file_output_case) Removed.
3206 (prepare_for_writing) Moved into open_active_file().
3207 (arrange_compaction) Ditto.
3209 (open_active_file) Rewrote.
3210 (write_case) New function.
3211 [DEBUGGING] (index_to_varname) Removed.
3212 (execute_transformations) New function.
3213 (exclude_this_case) Renamed filter_case(), changed interface.
3214 (clear_case) Added struct ccase * parameter to interface.
3215 (close_active_file) Added struct write_case_data * parameter,
3217 (disk_sink_create) Removed.
3218 (disk_sink_destroy) Removed.
3219 (disk_sink_make_source) Removed.
3220 (disk_sink_write) Removed.
3221 (disk_source_count) Removed.
3222 (disk_source_destroy) Removed.
3223 (disk_source_read) Removed.
3224 (global var disk_sink_class) Removed.
3225 (global var disk_source_class) Removed.
3226 (global var memory_sink_class) Removed.
3227 (global var memory_source_class) Removed.
3228 (memory_sink_create) Removed.
3229 (memory_sink_destroy) Removed.
3230 (memory_sink_make_source) Removed.
3231 (memory_sink_write) Removed.
3232 (memory_source_count) Removed.
3233 (memory_source_destroy) Removed.
3234 (memory_source_get_cases) Removed.
3235 (memory_source_read) Removed.
3236 (memory_source_set_cases) Removed.
3237 (struct disk_stream_info) Removed.
3238 (struct memory_sink_info) Removed.
3239 (struct memory_source_info) Removed.
3240 (write_active_file_to_disk) Removed.
3241 (destroy_storage_stream_info) New function.
3242 (global var null_sink_class) New var.
3243 (global var storage_sink_class) New var.
3244 (global var storage_source_class) New var.
3245 (open_storage_file) New function.
3246 (storage_sink_destroy) New function.
3247 (storage_sink_make_source) New function.
3248 (storage_sink_open) New function.
3249 (storage_sink_write) New function.
3250 (storage_source_count) New function.
3251 (storage_source_destroy) New function.
3252 (storage_source_get_cases) New function.
3253 (storage_source_on_disk) New function.
3254 (storage_source_read) New function.
3255 (storage_source_set_cases) New function.
3256 (storage_source_to_disk) New function.
3257 (storage_to_disk) New function.
3258 (struct storage_stream_info) New structure.
3259 (write_storage_file) New function.
3260 (procedure_write_case) Removed.
3261 (create_case_source) Add `struct dictionary *' parameter, all
3263 (create_case_sink) Ditto.
3264 (free_case_sink) New function.
3265 (struct split_aux_data) New structure.
3266 (procedure_with_splits) New function implementing what procedure()
3268 (SPLIT_FILE_proc_func) Removed.
3269 (procedure_with_splits_callback) New function.
3270 (equal_splits) New function.
3272 * aggregate.c: Pass around a struct instead of using statics.
3273 (static var outfile) Remove.
3274 (enum type) Give it tag `missing_treatment'.
3275 (static var missing) Remove.
3276 (static var sort) Remove.
3277 (static var agr_first) Remove.
3278 (static var agr_next) Remove.
3279 (static var case_count) Remove.
3280 (static var prev_case) Remove.
3281 (static var buf64_1xx) Remove.
3282 (static var buf_1xx) Remove.
3283 (struct agr_proc) New structure incorporating the above.
3284 (cmd_aggregate) Use new struct. Clean up error handling using
3285 agr_destroy(). Completely rewrite actual implementation of
3287 (create_sysfile) Add struct agr_proc * parameter, modify
3289 (parse_aggregate_functions) Ditto.
3290 (free_aggregate_functions) Ditto. Rename agr_destroy().
3291 (aggregate_single_case) Add struct agr_proc * parameter, modify
3293 (accumulate_aggregate_info) Ditto.
3294 (dump_aggregate_info) Ditto.
3295 (initialize_aggregate_info) Ditto.
3296 (agr_00x_trns_proc) Removed.
3297 (agr_00x_end_func) Removed.
3298 (agr_10x_trns_proc) Removed.
3299 (agr_10x_trns_free) Removed.
3300 (agr_10x_end_func) Removed.
3301 (agr_11x_read) Removed.
3302 (agr_11x_finish) Removed.
3303 [DEBUGGING] (debug_print) Removed.
3304 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3306 (agr_to_active_file) New function.
3307 (presorted_agr_to_sysfile) New function.
3308 (sort_agr_to_sysfile) New function.
3310 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3312 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3314 * descript.q: (cmd_descriptives) Ditto.
3316 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3317 to new procedure() interface.
3319 * command.c: (cmd_execute) Adapt to new procedure() interface.
3321 * dictionary.c: (dict_compact_values) Also delete scratch
3323 (dict_get_compacted_value_cnt) New function.
3324 (dict_get_compacted_idx_to_fv) New function.
3326 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3327 (cmd_flip) Adapt to new procedure() interface.
3328 (flip_sink_write) Use sink->idx_to_fv.
3330 * frequencies.q: (internal_cmd_frequencies) Use
3331 procedure_with_splits().
3333 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3334 (static var mtf_sink) New static var.
3335 (static var mtf_case) New static var.
3336 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3337 we actually implement the matching.
3338 (mtf_delete_file_in_place) Use mtf_case.
3339 (mtf_processing) Use mtf_case and mtf_sink.
3340 (cmd_export) Adapt to new procedure() interface.
3342 * levene.c: (levene) Use procedure_with_splits().
3344 * list.q: (cmd_list) Use procedure_with_splits().
3346 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3347 procedure() interface.
3348 (read_matrices_with_rowtype) Ditto.
3350 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3351 TEMPORARY. Adapt to new procedure() interface.
3353 * rename-vars.c: Warn about and cancel TEMPORARY.
3355 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3356 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3357 compaction_nval. Adapt to new procedure() interface. Use
3358 storage_source_to_disk().
3359 (do_internal_sort) Don't try to dump the cases to memory.
3360 (compare_case_lists) Pass null idx_to_fv.
3361 (struct initial_run_state) Add `idx_to_fv' member. Remove
3363 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3364 new procedure() interface. Reset irs->idx_to_fv after calling
3366 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3367 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3369 (destroy_initial_run_state) Don't dereference irs after freeing
3371 (allocate_cases) Don't calculate case_size locally.
3372 (compare_record) Add idx_to_fv parameter.
3373 (compare_record_run) Change parameter from struct sort_cases_pgm *
3374 to struct initial_run_state *. Pass irs->idx_to_fv to
3376 (compare_record_run) Third parameter now a struct
3377 initial_run_state *.
3378 (output_record) No need for out_case anymore. Pass irs, not
3379 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3381 (merge) Use case_size from struct sort_cases_pgm.
3382 (merge_once) Use case_size from struct sort_cases_pgm.
3383 Pass null pointer to compare_record() as idx_to_fv.
3384 (global var sort_sink_class) Make static.
3386 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3388 * temporary.c: Remove debugging crap.
3390 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3392 * t-test.q, levene.c: Fixed up the handling of MISSING values
3395 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3397 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3400 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3402 Change explicit variable name checks into use of
3403 dict_class_from_id().
3405 * dictionary.c: (dict_create_var) Change explicit variable name
3406 check into use of dict_class_from_id().
3408 * get.c: (trim_dictionary) Ditto.
3410 * sel-if.c: (cmd_filter) Ditto.
3412 * sysfile-info.c: (cmd_display) Ditto.
3414 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3416 * vfm.c: (arrange_compaction) Ditto.
3418 * weight.c: (cmd_weight) Ditto.
3420 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3422 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3423 transformation following the input program, if any, for some
3424 reason we special-cased f_trns. That's just wrong. It should
3425 always be set to n_trns.
3427 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3429 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3430 introduced in last check-in.
3432 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3434 * format.c: (global array translate_fmt[]) Removed.
3435 (translate_fmt) New function as replacement.
3436 (parse_format_specifier_name) Rewrite.
3438 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3441 * sfm-read.c: (parse_format_spec) Ditto.
3443 * postscript.c: (text) Fix handling of fonts with missing
3446 * sort.c: (struct external_sort) Add temp_name member.
3447 (destroy_external_sort) Free temp_dir, temp_name members.
3448 (init_external_sort) Allocate temp_name.
3449 (get_temp_file_name) Change prototype.
3450 (open_temp_file) Deal with change to get_temp_file_name().
3451 (close_temp_file) Ditto.
3452 (remove_temp_file) Ditto.
3453 (write_temp_file) Ditto.
3454 (read_temp_file) Ditto.
3455 (sort_sink_destroy) Removed.
3456 (sort_sink_class) Change destroy member to null.
3458 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3460 Eliminate temp_case.
3462 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3463 anymore. Use agr_11x_finish().
3464 (aggregate_single_case) Make first param const.
3465 (accumulate_aggregate_info) Ditto.
3466 (agr_00x_end_func) Use compaction_case, not temp_case.
3467 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3469 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3470 (cmd_data_list) Initialize case_size.
3471 (read_from_data_list_fixed) Add struct ccase * param, use instead
3473 (read_from_data_list_free) Ditto.
3474 (read_from_data_list_list) Ditto.
3475 (read_one_case) Rename data_list_trns_proc(), all references
3476 updated. Add argument in calling above functions. Use c
3477 argument instead of temp_case.
3478 (destroy_dls) Rename data_list_trns_free(), all references
3481 * expr-evl.c: (expr_evaluate) Make second parameter const.
3483 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3484 (cmd_end_file_type) Initialize `case_size'.
3485 (file_type_source_read) Add struct ccase * parameter. Use instead
3488 * flip.c: Rewritten.
3490 * get.c: (struct get_pgm) New structure to keep track of
3492 (cmd_get) Initialize case_size.
3494 (get_source) Deal with struct get_pgm.
3495 (get_source_read) Add struct ccase * parameter, use instead of
3497 (import_source_read) Ditto.
3499 * get.c: Use a null pointer instead of temp_case to represent the
3500 "current case" in a struct mtf_file's input member.
3501 (mtf_processing_finish) Pass null to mtf_processing(), not
3503 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3504 (mtf_compare_BY_values) Add extra arg, use instead of null input
3506 (mtf_processing) Use c parameter instead of temp_case. Pass
3507 compaction_case to process_active_file_output_case().
3509 * glob.c: (global variable temp_case) Removed.
3511 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3512 (cmd_input_program) Initialize case_size. Set
3513 vfm_source->value_cnt.
3514 (init_case) Add struct ccase * parameter, use instead of
3517 (input_program_source_read) Ditto.
3519 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3520 (dump_cell_content) Ditto.
3521 (nr_output_data) Ditto.
3522 (read_matrices_without_rowtype) Ditto.
3523 (matrix_data_read_with_rowtype) Ditto.
3524 (wr_read_splits) Ditto.
3525 (wr_output_data) Ditto.
3527 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3529 * sort.c: (sort_cases) Initialize scp->case_size.
3530 (struct external_sort) Remove `case_size' member.
3531 (write_initial_runs) Only call vfm_sink->class_destroy if
3533 (struct sort_source_aux) New structure.
3534 (sort_source_read_helper) New function.
3535 (sort_source_read) Use sort_source_read_helper().
3536 (read_sort_output) Change interface to be more reasonable.
3537 (read_internal_sort_output) Ditto.
3538 (read_external_sort_output) Ditto.
3540 * vars-prs.c: (dict_class_to_name) Pass return value through
3543 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3544 (procedure) Initialize trns_case.
3545 (procedure) Pass trns_case to vfm_source->class->read().
3547 (process_active_file) Start using struct procedure_aux_data.
3548 (process_active_file_write_case) Pass trns_case to
3549 transformations, lag_case(), clear_case().
3550 (process_active_file_output_case) Add struct ccase * parameter.
3551 (create_trns_case) New function.
3552 (make_temp_case) Removed.
3553 (vector_initialization) Removed.
3554 (close_active_file) Only call make_source if non-null, otherwise
3555 set vfm_source to null pointer. Don't free temp_case.
3556 (disk_source_read) Add struct ccase * parameter, use instead of
3558 (memory_source_read) Ditto.
3559 (lag_case) Add const struct ccase * member.
3560 (procedure_write_case) Use trns_case instead of temp_case.
3561 (clear_case) Add struct ccase * member, use instead of temp_case.
3562 (exclude_this_case) Ditto.
3563 (create_case_source) Add struct dictionary * parameter, use to
3564 initialize source->value_cnt.
3566 * vfm.h: (struct case_source) Add `value_cnt' member.
3567 (struct case_source_class) Add struct ccase * parameter to `read'
3568 member function pointer.
3569 (struct case_sink_class) Make struct ccase * parameter const in
3570 `write' member function pointer.
3572 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3574 Fix a lot of "possibly uninitialized variable" warnings. Some of
3575 them are even real bugs. A few of them make me wonder how the
3578 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3580 * ascii.c: (output_lines) Add default case to switch.
3582 * crosstabs.q: Remove static variable `expected' and all
3584 (display_crosstabulation) Always calculate expected value.
3586 (output_pivot_table) Initialize `cmp'.
3587 (display_crosstabulation) New variable `last_row', which is
3590 * data-in.c: (parse_numeric) Always initialize sign. How did this
3593 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3594 Always set info.ofs. (How did this work?!)
3596 * expr-opt.c: (optimize_tree) Always initialize `m'.
3597 (evaluate_tree) Always initialize `c'. (How did this work?)
3599 * frequencies.q: (frq_custom_variables) Always initialize min,
3601 (frq_custom_grouped) Always initialize `dl'.
3603 * groff-font.c: (groff_read_font) Always initialize char_set.
3605 * matrix-data.c: (nr_output_data) Initialize `split'.
3606 (wr_read_splits) Remove shadowing split_cnt declaration.
3607 (wr_output_data) Initialize `split'.
3609 * output.c: (tokener) Skip add character on syntax error.
3611 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3613 * postscript.c: (read_ps_encodings) Use line.string instead of
3615 (write_text) Add default case to switch.
3616 (text) Always initialize multiple variables. Fix bug with
3619 * print.c: (fixed_parse_fortran) Initialize head.
3620 (alloc_line) Add default case to switch.
3622 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3623 (recode_trns_proc) Move variable declaration inward. Add default
3626 * sfm-read.c: (read_header) Initialize skip_amt.
3628 * sysfile-info.c: (display_variables) Always initialize pc.
3630 * vars-prs.c: Initialized `included'.
3632 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3634 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3635 Just use signal() instead.
3637 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3639 Get rid of vfm_sink_info and vfm_source_info.
3641 * aggregate.c: (agr_00x_end_func) Don't increment
3642 sfm_sink_info.ncases.
3644 * sort.c: (do_internal_sort) Get case count from
3645 vfm_source->class->count().
3646 (struct external_sort) Add `case_size' member.
3647 (do_external_sort) Initialize case_size.
3648 (struct initial_run_state) Add `case_size' member.
3649 (write_initial_runs) Initialize case_size.
3650 (sort_sink_write) Use case_size.
3651 (read_external_sort_output) Use case_size. Get case_cnt from
3654 * vfm.c: (struct write_case_data) Add underscores to existing arg
3655 names, all references updated. Renamed `aux' as `func_aux', all
3656 references updated. Added new `aux' member.
3657 (global var vfm_source_info) Removed.
3658 (global var vfm_sink_info) Removed.
3659 (struct procedure_aux_data) New.
3660 (struct split_aux_data) New.
3661 (procedure) Use `aux' fields for procedure_aux_data,
3663 (process_active_file_write_case) Pass case_count + 1 to
3664 transformation procedures, exclude_this_case().
3665 (process_active_file_output_case) Don't increment
3666 vfm_sink_info.ncases.
3667 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3668 to send data to disk early.
3669 (make_temp_case) Don't use vfm_sink_info.case_size.
3670 (close_active_file) Don't initialize vfm_source_info.
3671 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3672 (disk_sink_create) Initialize and/or update disk_stream_info.
3673 (disk_sink_write) Ditto.
3674 (disk_sink_destroy) Ditto.
3675 (disk_sink_make_source) Ditto.
3676 (disk_source_read) Ditto.
3677 (disk_source_destroy) Ditto.
3678 (global var disk_source_class) Add disk_source_count().
3679 (disk_source_count) New function.
3680 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3681 (struct memory_source_info) Ditto.
3682 (memory_sink_create) Deal with case_cnt, case_size.
3683 (memory_sink_write) Ditto.
3684 (memory_sink_make_source) Ditto.
3685 (memory_source_read) Ditto.
3686 (memory_source_count) New function.
3687 (memory_source_class) Add memory_source_count().
3688 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3689 proc_aux->cases_written, and pass it to transformation procedures
3690 and exclude_this_case ().
3691 (exclude_this_case) Add case_num parameter. Pass it to
3693 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3696 * vfm.h: (struct case_source_class) Add `count' member.
3698 * vfmP.h: (struct stream_info) Removed.
3699 (global variable vfm_source_info) Removed.
3700 (global variable vfm_sink_info) Removed.
3702 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3704 * var.h: (typedef trns_proc_func) New typedef.
3705 (trns_free_func) New typedef.
3706 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3707 to type trns_free_func. This only changes the actual type of
3708 trns_proc_func, adding a `case_num' parameter. Updated all
3709 implementations to use the typedefs instead.
3711 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3712 (compute_num_vec) Ditto.
3713 (compute_str) Ditto.
3714 (compute_str_vec) Ditto.
3716 * do-if.c: (do_if_trns_proc) Ditto.
3718 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3721 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3722 pass to transformation functions.
3723 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3725 * loop.c: (loop_1_trns_proc) Ditto.
3726 (loop_2_trns_proc) Ditto.
3727 (loop_3_trns_proc) Ditto.
3729 * print.c: (print_space_trns_proc) Ditto.
3731 * sel-if.c: (select_if_proc) Ditto.
3733 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3735 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3736 destroying hash table.
3738 * glob.c: (read_active_file) Variable not referenced, removed.
3739 (cancel_input_pgm) Ditto.
3741 * levene.c: Add #include <stdlib.h> needed to call free().
3743 * aggregate.c: (parse_aggregate_functions) Make `function'
3746 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3748 Start working to eliminate VFM dependence on static variables.
3750 * command.c: (cmd_parse) Use case_source_is_class().
3752 * data-list.c: Rewrite to eliminate use of static variables.
3754 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3756 * file-handle.q: (fh_handle_name) Make parameter const.
3758 * file-type.c: Rewrite to eliminate use of static variables.
3760 * flip.c: Rewrite to eliminate use of static variables.
3762 * format.c: (get_format_var_width) New function.
3764 * get.c: Eliminate use of static variables.
3766 * inpt-pgm.c: Eliminate use of static variables.
3768 * matrix-data.c: Eliminate use of static variables.
3770 * set.q: (set_max_workspace) New variable.
3771 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3773 * var.h: (struct case_list) Move here from vfmP.h.
3775 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3777 * vfm.c: (vfm_source) Change type from struct case_stream to
3779 (vfm_sink) Change type from struct case_stream to struct
3781 (static var paging) Rename workspace_overflow, all references
3783 (procedure) Use new class structures.
3784 (process_active_file) Ditto.
3785 (process_active_file_write_case) Ditto.
3786 (prepare_for_writing) Use set_max_workspace. Use new class
3788 (close_active_file) Use new class structures. Free old sink.
3789 (global var disk_source_file) Removed.
3790 (global var disk_sink_file) Removed.
3791 (disk_stream_init) Removed.
3792 (disk_stream_read) Removed.
3793 (disk_stream_write) Removed.
3794 (disk_stream_mode) Removed.
3795 (disk_stream_destroy_source) Removed.
3796 (disk_stream_destroy_sink) Removed.
3797 (global var vfm_disk_stream) Removed.
3798 (disk_sink_create) New function.
3799 (disk_sink_write) New function.
3800 (disk_sink_destroy) New function.
3801 (disk_sink_make_source) New function.
3802 (disk_sink_class) New static var.
3803 (disk_source_read) New function.
3804 (disk_source_destroy) New function.
3805 (global var vfm_source_class) New var.
3806 (global var memory_source_cases) Removed.
3807 (global var memory_sink_cases) Removed.
3808 (global var memory_sink_max_cases) Removed.
3809 (struct memory_sink_info) New struct.
3810 (memory_stream_init) Removed.
3811 (memory_stream_read) Removed.
3812 (memory_stream_write) Removed.
3813 (memory_stream_mode) Removed.
3814 (memory_stream_destroy_source) Removed.
3815 (memory_stream_destroy_sink) Removed.
3816 (global var vfm_memory_stream) Removed.
3817 (page_to_disk) Renamed write_active_file_to_disk().
3818 (memory_sink_create) New function.
3819 (memory_sink_write) New function.
3820 (memory_sink_destroy) New function.
3821 (memory_sink_make_source) New function.
3822 (memory_sink_class) New static var.
3823 (memory_source_read) New function.
3824 (memory_source_destroy) New function.
3825 (memory_source_get_cases) New function.
3826 (memory_source_set_cases) New function.
3827 (global var vfm_source_class) New var.
3828 (procedure_write_case) Use new class structures.
3829 (create_case_source) New function.
3830 (case_source_is_complex) New function.
3831 (case_source_is_class) New function.
3832 (create_case_sink) New function.
3834 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3835 (global variable reinit_blanks) Not used, removed.
3836 (global variable init_zero) Not used, removed.
3837 (global variable init_blanks) Not used, removed.
3838 (struct case_source) New struct.
3839 (struct case_source_class) New struct.
3840 (struct case_sink) New struct.
3841 (struct case_sink_class) New struct.
3842 (struct case_stream) Removed.
3844 * vfmP.h: (struct case_list) Moved to var.h.
3846 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3848 * algorithm.c: (count_equal) New function.
3849 (count_if) New function.
3850 (unique) Add assertions.
3851 (partition) Add assertions.
3852 (is_partitioned) New function.
3853 (copy_if) Add assertions.
3854 (remove_equal) Add assertions.
3855 (lexicographical_compare) Rename lexicographical_compare_3way.
3856 (sort) Add assertions. Rephrase some code.
3857 (is_sorted) New function.
3859 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3863 * sort.c: Completely rewrite.
3865 * sort.h: Expose interface via struct sort_cases_pgm, not via
3868 * aggregate.c: (sort) New static var.
3869 (cmd_aggregate) Use sort.
3870 (create_sysfile) Ditto.
3871 (aggregate_single_case) Ditto.
3872 (dump_aggregate_info) Ditto.
3873 (agr_00x_end_func) Ditto.
3874 (debug_print) Ditto.
3876 * var.h: (enum SRT_ASCEND) Removed.
3877 (enum SRT_DESCEND) Removed.
3878 (struct sort_cases_proc) Removed.
3879 (struct variable) Remove p.srt member.
3881 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3883 Get rid of the old, crappy heap structure and replace it by a new,
3884 shiny, C++ STL-like heap structure.
3886 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3888 * algorithm.c: (push_heap) New function.
3899 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3901 Increase warning level.
3903 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3905 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3907 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3909 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3911 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3912 around by previous change log entry.
3914 * compute.c: (lvalue_finalize) Remove workaround from previous
3917 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3919 * compute.c: Fixed a bug where the Format was not getting set for
3920 computed variables (thus causing a crash when SAVEing).
3922 * Added a test to stop this bug ever coming back
3924 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3926 Got rid of approx.h. In general, replaced all references to
3927 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3930 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3932 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3933 test for mag < EPSILON.
3935 * misc.h: Add definition of EPSILON.
3937 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3939 * vfm.c: (procedure) Add check to prevent recursive call.
3941 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3943 * Moved the declarations relating to values to their own header file
3946 * Added levene.c and levene.h
3948 * vars-atr.c: Changed the signature of compare_values to
3949 take const * arguments.
3951 * t-test.q: Changed the structure of struct t_test_proc
3952 variables now contain their own group statistics information.
3953 Eventually, t_test_proc might get renamed, because it'd be
3954 applicable to other commands too.
3956 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3958 * data-out.c: Clean up. Changed interface of convert_*() to take
3959 either a `double' or a `const char *' instead of a `const union
3960 value *'. Update all implementations of those interfaces.
3961 (data_out) Use switch statements instead of a table.
3962 (convert_AHEX) Rewrite.
3964 * format.h: Update comment.
3966 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3968 * q2c.c: (dump_header) Add an Emacs header line to output files
3969 that makes generated .c files read-only by default, to make it
3970 difficult to accidentally change generated files.
3972 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3974 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3975 not bogus a->v.c <=> b->v.c pointer compare.
3976 (compare_freq_alpha_a) Ditto.
3977 (compare_freq_numeric_d) Ditto.
3978 (compare_freq_alpha_d) Ditto.
3980 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3982 Changed data_out() to store string data directly into a `union
3983 value''s s member, not indirectly into c.
3985 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3987 (table_value_missing) Ditto.
3988 (float_M_suffix) Ditto.
3989 (format_short) New function.
3991 * data-in.h: (data_in_finite_line) Remove inline definition.
3993 * data-list.c: (destroy_dls_var_spec) New function.
3994 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3995 (data_list_source_destroy_source) Avoid cast.
3996 (struct repeating_data_trns) New field `id_value'. Update
3998 (cmd_repeating_data) Initialize id_value. Use new
3999 repeating_data_trns_free() for freeing REPEATING DATA
4001 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4002 (repeating_data_trns_free) New function.
4004 * data-out.c: (data_out) Change return type to `void' by replacing
4005 error returns by writing a message into the output buffer.
4006 (convert_A) Read from v->s instead of v->c.
4007 (convert_AHEX) Ditto.
4009 * expr-evl.c: Update comment.
4010 (expr_evaluate) Add assertion in OP_STRING case.
4012 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4014 * list.q: (list_cases) Update for new data_out() semantics.
4016 * print.c: (print_trns_proc) Ditto.
4018 * tab.c: (tab_value) Ditto.
4019 (tab_float) Avoid stupid cast.
4021 * var.h: Update comments.
4022 (macro MAX_STRING) New macro.
4023 (macro MAX_ELEMS_PER_VALUE) New macro.
4025 * vars-atr.c: (compare_values) New function.
4027 * vfm.c: (dump_splits) Update for new data_out() semantics.
4029 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4031 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4033 (struct crosstab) Rename v[] to vars[]. All references updated.
4034 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4035 same time, which caused the hash value to depend only on a single
4036 value, not all of the variables' values.
4038 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4040 Clean up struct dictionary's value_cnt usage.
4042 * dictionary.c: Add a function comment to each function.
4043 (struct dictionary) Rename value_cnt to next_value_idx, which more
4044 accurately reflects its meaning. All references updated.
4045 (dict_rename_vars) Add assertion.
4046 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4048 (dict_get_case_size) New function.
4050 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4052 * get.c: (mtf_read_nonactive_records) Ditto.
4054 * sort.c: (allocate_cases) Ditto.
4055 (write_initial_runs) Ditto.
4059 * vfm.c: (prepare_for_writing) Ditto.
4063 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4065 Make vfm.c slightly less grotesque.
4067 * vfm.c: (filter_var) Removed.
4068 (filter_index) Removed.
4069 (FILTERED macro) Removed.
4070 (exclude_this_case) New function.
4071 (process_active_file_write_case) Use exclude_this_case() instead
4072 of FILTERED and inline tests.
4073 (procedure_write_case) Ditto.
4074 (setup_filter) Removed.
4075 (open_active_file) Don't call setup_filter().
4076 (close_active_file) Call dict_get_filter() instead of checking
4079 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4081 * var.h: (struct variable) Update comments.
4083 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4085 New functions dict_create_var_assert(), dict_lookup_var_assert().
4086 Converted several dict_*_var()/assert pairs into a single
4087 dict_*_var_assert().
4089 * dictionary.c: (dict_create_var_assert) New function.
4090 (dict_lookup_var_assert) New function.
4092 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4094 Got rid of "struct long_vec", envector(), devector(), etc. Added
4095 two members `init', `reinit' to struct variable as a substitute.
4097 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4103 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4106 * autorecode.c: (cmd_autorecode) destvars don't need init.
4108 * compute.c: (lvalue_finalize) Set reinit.
4110 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4111 (dump_fmt_list) Ditto.
4114 * descript.q: (run_z_pass) Don't need init for z-scores.
4116 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4118 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4120 * glob.c: (init_glob) Remove vec_init() calls.
4122 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4124 * loop.c: (internal_cmd_loop) Don't need to call envector().
4126 * numeric.c: (cmd_numeric) Ditto.
4128 (cmd_leave) Ditto. Set `init', `reinit' members.
4130 * recode.c: (cmd_recode) Don't need to call envector().
4132 * repeat.c: (internal_cmd_do_repeat) Ditto.
4134 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4135 (force_create_variable) Removed prototype.
4136 (force_dup_variable) Ditto.
4138 * vector.c: (cmd_vector) Don't need to call envector().
4140 * vfm.c: (reinit_sysmis) Removed.
4141 (reinit_blanks) Removed.
4142 (init_zero) Removed.
4143 (init_blanks) Removed.
4144 (process_active_file_write_case) No need to deal with vectors.
4145 Call clear_temp_case().
4146 (vector_initialization) Rewrite to use `init', `reinit'.
4147 (close_active_file) No need to call vec_clear().
4148 (procedure_write_case) Call clear_temp_case().
4149 (clear_temp_case) New function.
4151 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4153 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4156 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4158 Add auxiliary argument to procedure() interface. Associated small
4159 clean-ups of vfm interface.
4161 * Updated every caller of procedure() and process_active_file() to
4162 reflect modified interface. Simple, ordinary changes not listed
4165 * Updated every function that implements struct case_stream's
4166 `read' function to take a write_case_func and a write_case_data.
4167 Also updated every caller of write_case() to instead call them
4168 through these arguments. In some cases this meant that the extra
4169 args had to be threaded through a couple of extra levels. This
4170 wasn't difficult or interesting so the details won't be given.
4172 * data-list.c: (struct repeating_data_trns) Add members
4173 `write_case', `wc_data' as kluge.
4174 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4176 (repeating_data_set_write_case) New function.
4178 * data-list.h: New file to declare repeating_data_trns_proc() and
4179 repeating_data_set_write_case().
4181 * inpt-pgm.c: (input_program_source_read) Call
4182 repeating_data_set_write_case() for all the REPEATING DATA
4183 transformations, so that they know where to send their cases.
4184 It's a big kluge. Also kluge in END CASE.
4185 (end_case_trns_proc) Never called anymore, but we still need it,
4188 * sort.c: (read_sort_output) Update to match struct case_stream
4191 * vfm.c: (struct write_case_data) New structure.
4192 (proc_func) Removed.
4193 (virt_proc_func) Removed.
4194 (begin_func) Removed.
4195 (virt_begin_func) Removed.
4197 (write_case) Removed.
4198 (procedure) Added an auxiliary parameter to each function pointer
4199 argument's prototype. Added an auxiliary data parameter.
4201 (process_active_file) Ditto.
4202 (process_active_file_write_case) Pass aux data along.
4203 (close_active_file) Ditto.
4204 (procedure_write_case) Ditto.
4205 (SPLIT_FILE_procfunc) Ditto.
4207 * vfm.h: (typedef write_case_data) New.
4208 (typedef write_case_func) New.
4209 (struct case_stream) Add parameters to `read' member prototype.
4211 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4213 * t-test.q: Added calculations for independent samples. (But no Levene
4216 * Makefile.am: Moved q_sources_c into own variable
4218 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4220 Miscellaneous cleanups.
4222 * Change unused to UNUSED in many source files to reflect modified
4223 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4224 __CYGWIN32__, __unix__, and unix not to assume that they're
4225 defined to a nonzero value. Change use of __attribute__ to use
4226 NO_RETURN or PRINTF_FORMAT instead.
4228 * alloc.h: Move definitions for local_alloc(), local_free() here
4229 from ../pref.h.orig and simplify.
4231 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4232 use a pool allocator unconditionally.
4233 (CHECK_STRING_SPACE) Removed.
4234 (ALLOC_STRING_SPACE) Removed.
4235 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4238 * expr-opt.c: (dump_expression) Allocate string pool.
4240 * expr-prs.c: (expr_free) Free string pool.
4242 * pool.c: (pool_destroy) This pool must be removed from its
4243 parent's list of gizmos, not from its own. Use free_all_gizmos().
4244 (pool_clear) New function.
4245 (free_all_gizmos) New function.
4246 (pool_alloc) Use space in empty block after this one if any.
4247 (pool_release) Only empty out blocks, don't actually free() them.
4249 * print.c: Get rid of PAGED_STACK special case by always
4250 dynamically allocating line buffers.
4251 (struct print_trns) Always include the `line' member.
4252 (internal_cmd_print) Always initialize the `line' member.
4253 (alloc_line) Always allocate memory for `line'.
4254 (print_trns_proc) Always initialize buf from `line' member.
4255 (print_trns_free) Always free `line' memory.
4257 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4260 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4262 * flip.c: Fixed crash from FLIP when a numeric variable is
4263 specified on NEWNAMES and a large value is used, and a couple of
4264 other minor bugs besides.
4265 (struct varname) Make name a 9-character fixed-size array
4266 instead of a 1-character variable size array.
4267 (make_new_var) Allow digits in variable names.
4268 (flip_stream_write) Limit numeric values to 8 characters and
4269 format system missing and very large and small values more
4272 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4274 * command.c: Fixed test on command return status for the correct
4275 value, which had been causing a crash under certain invalid input.
4277 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4279 * t-test.q: Added calculations for the one sample variant of the T-TEST
4281 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4283 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4284 in joined cells to be rendered outside box boundaries.
4286 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4288 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4289 SET seed=xx has been called.
4291 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4293 * random.c (rng_get_double): Fix always-returning-zero bug in my
4294 preferred way, and at the same time make sure rounding doesn't
4297 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4299 * html.c: (change_attributes) Dead code, removed.
4300 (escape_string) Eliminate code to call change_attributes() that
4301 never actually called it.
4302 (output_tab_table) Get rid of dependence on tab_hit
4303 and struct tab_joined_cell's hit member, which are abominations.
4305 * tab.c: (tab_output_text) Don't call
4306 d->class->text_set_font_by_name if it's a null pointer.
4307 (macro UNROLL_LOOP) Eliminate.
4308 (macro UNROLL_3_LOOPS) Eliminate.
4309 (tabi_render) Rewrite not to use the above macros.
4311 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4313 Start working on a new output driver system, one that doesn't suck
4314 so much, by adding a "device-independent" output driver. The idea
4315 is to write out only a single output stream, then use separate
4316 processes to translate them into whatever formats we want. This
4317 is similar to how "groff" works with its various output drivers
4318 (grops, grotty, grodvi, ...).
4320 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4322 * list.q: (write_all_headers) Stub out devind class.
4324 (determine_layout) Ditto.
4327 * output.c: (outp_init) Add devind class.
4329 * devind.c: New file.
4331 * devind.h: New file.
4333 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4335 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4336 to use the proper string length.
4338 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4340 * Fixed bug where FREQ would crash on alpha values
4342 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4344 * Removed bletcherous alloca() workarounds for AIX from top of
4345 many files. AIX can use the alternative alloca() implementation
4348 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4350 * ascii.c: (ascii_option) Fix implementation of headers option.
4352 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4354 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4355 multiple blank lines into one.
4356 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4357 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4358 (static var option_tab) Add squeeze entry.
4359 (ascii_option) Set squeeze_blank_lines.
4360 (output_lines) Implement squeezing blank lines.
4362 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4364 * Removed redundant code from output.h
4366 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4368 Dictionary classes: each variable is "ordinary", "system", or
4371 * var.h: (enum dict_class) New enum.
4373 * vars-prs.c: (dict_class_from_id) New function.
4374 (dict_class_to_name) New function.
4376 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4378 * var.h: (struct freq_tab_set) Removed (not used).
4380 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4382 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4384 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4386 * stats.c: (hypercube) Rename pow4(). All references updated.
4388 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4390 * rename-vars.c: (cmd_rename_variables) Rewritten.
4391 (compare_name) Removed.
4393 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4395 var_set feature, and code taking advantage of it.
4397 * crosstabs.q: (static var var_dict) Removed.
4398 (static var variables) New variable.
4399 (static var variables_cnt) New variable.
4400 (cmd_crosstabs) Free variables instead of var_dict.
4401 (internal_cmd_crosstabs) Initialize and use variables,
4402 variables_cnt instead of var_dict.
4403 (free_var_dict) Removed.
4404 (crs_custom_tables) Use var_set instead of a copied dictionary.
4405 (crs_custom_variables) Set up variables, variables_cnt instead of
4407 [DEBUGGING] (debug_print) Ditto.
4409 * means.q: (mns_custom_tables) Use var_set instead of a copied
4412 * vars-prs.c: (parse_vs_variable) New function.
4413 (parse_dict_variable) Rewritten.
4414 (parse_variable) Rewritten.
4415 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4416 (parse_variables) New function in terms of parse_var_set_vars().
4417 Now requires its first argument to be non-null. All references
4418 that passed a null pointer updated to pass default_dict instead.
4419 (macro id_dict) Removed.
4420 (parse_DATA_LIST_vars) Add assertions.
4421 (parse_mixed_vars) Ditto.
4422 (struct var_set) New structure.
4423 (var_set_get_cnt) New function.
4424 (var_set_get_var) New function.
4425 (var_set_lookup_var) New function.
4426 (var_set_destroy) New function.
4427 (dict_var_set_get_cnt) New function.
4428 (dict_var_set_get_var) New function.
4429 (dict_var_set_lookup_var) New function.
4430 (dict_var_set_destroy) New function.
4431 (var_set_create_from_dict) New function.
4432 (struct array_var_set) New structure.
4433 (array_var_set_get_cnt) New function.
4434 (array_var_set_get_var) New function.
4435 (array_var_set_lookup_var) New function.
4436 (array_var_set_destroy) New function.
4437 (var_set_create_from_array) New function.
4439 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4440 instead of parse_variables(NULL, ...) in output code.
4442 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4444 Change inp_init from a 2-bit vector to an ordinary array.
4445 Initialize it all in cmd_end_input_program() instead of in
4448 * inpt-pgm.c: (enum value_init_type) New enum.
4449 (global var inp_init) Change to `enum value_init_type *', make
4451 (inp_init_size) Removed.
4452 (inp_nval) Change to `size_t', make static.
4453 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4454 (cmd_end_input_program) Initialize inp_init, inp_nval.
4455 (init_case) Rewrite.
4456 (clear_case) Rewrite.
4458 * inpt-pgm.h: Removed.
4460 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4462 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4463 Colin Plumb hash. It is simpler and should better resist
4465 (hsh_hash_string) Ditto.
4467 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4469 * get.c: (export_write_case_func) Remove debug printing code.
4471 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4473 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4475 (save_write_case_func) Use &trns->h instead of cast.
4476 (cmd_export) Use &t->h instead of cast.
4478 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4480 Moved vectors into the dictionary.
4482 * var.h: (struct vector) Moved here from vector.h. `index' member
4483 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4486 * vector.h: Removed.
4488 * vector.c: (global var vec) Removed.
4489 (global var nvec) Removed.
4490 (cmd_vector) Rewritten.
4491 (find_vector) Removed.
4493 * dictionary.c: (dict_create_vector) New function.
4494 (dict_get_vector) New function, replaces reading global vec[]
4496 (dict_get_vector_cnt) New function, replaces reading global nvec
4498 (dict_lookup_vector) New function, replaces find_vector().
4499 (dict_clear_vectors) New function.
4501 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4503 Start to move away from `struct variable' p `union' member to void
4506 * var.h: (struct variable) Add `aux' member.
4508 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4510 Get rid of struct variable `foo' member.
4512 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4514 (frq_custom_variables) Ditto.
4515 (frq_custom_grouped) Ditto.
4517 * get.c: (struct save_trns) Change `var' member from `int *' to
4518 `struct variable **'.
4519 (cmd_save_internal) Use aux instead of foo.
4520 (save_trns_proc) Use revised `var' member.
4521 (static var mtf_seq_no) Renamed mtf_seq_num.
4522 (static var mtf_seq_nums) New static var.
4523 (cmd_match_files) Initialize mtf_seq_nums.
4524 (mtf_free) Free mtf_seq_nums.
4525 (mtf_processing) Use mtf_seq_nums instead of foo.
4526 (mtf_merge_dictionary) No need to initialize mv->foo.
4527 (cmd_export) Use aux instead of foo. Use revised `var' member.
4528 (mns_custom_tables) Don't use foo to check for duplicates, that's
4529 what PV_NO_DUPLICATE is for.
4531 * var.h: (struct variable) Remove `foo' member.
4532 (struct frequencies_proc) New member.
4534 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4536 Clean up COMPUTE and IF.
4538 * compute.c: More or less rewrite the darn thing.
4539 (struct compute_trns) Rename and reorder and add and delete
4541 (cmd_compute) Rewrite.
4542 (compute_num) Make conditional on test expression. Now used for
4543 both COMPUTE and IF.
4544 (compute_num_vec) Ditto.
4545 (compute_str) Ditto.
4546 (compute_str_vec) Ditto.
4549 (if_num_vec) Removed.
4551 (if_str_vec) Removed.
4552 (parse_target_expression) Renamed parse_rvalue_expression(),
4554 (new_trns) Renamed compute_trns_create(), rewritten.
4555 (delete_trns) Removed.
4556 (free_trns) Renamed compute_trns_free(), rewritten.
4557 (struct lvalue) New structure.
4558 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4559 (lvalue_get_type) New function.
4560 (lvalue_is_vector) New function.
4561 (lvalue_finalize) New function.
4562 (lvalue_destroy) New function.
4564 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4566 * command.def: Disallow MODIFY VARS in input mode, so that
4567 variables can't get dropped and confuse cmd_end_input_program()'s
4568 attempt to fill inp_init[].
4570 * modify-vars.c: (static var forward_positional_ordering) New
4572 (struct var_modification) Entirely changed.
4573 (rearrange_dict) Interface changed, rewritten.
4574 (cmd_modify_vars) Deal with modified struct var_modification, much
4576 (struct var_renaming) New structure.
4577 (compare_var_renaming_by_new_name) New function.
4578 (validate_var_modification) New function.
4580 * var.h: (struct modify_vars_proc) Removed.
4581 (struct variable) Removed member p.mfv.
4583 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4585 Make EVALUATE a valid command whether we're debugging or not, so
4586 that `make check' can succeed regardless of whether debugging is
4589 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4591 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4593 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4595 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4596 statement by a simple if test.
4598 * dfm.c: (dfm_get_record) Add assertion.
4600 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4602 For each file x.c, move #include "x.h" to the very top of the
4603 include list, to catch x.h failing to include the proper headers.
4605 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4607 * algorithm.c: (find) New function.
4608 (remove_equal) New function.
4609 (set_difference) New function.
4610 (adjacent_find_equal) New function.
4611 [TEST_UNIQUE] Removed test case.
4612 (copy_if) Find end test.
4614 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4616 * dictionary.c: (dict_get_case_weight) New convenience function.
4618 * aggregate.c: (accumulate_aggregate_info) Use
4619 dict_get_case_weight().
4621 * frequencies.q: (calc_general) Ditto.
4622 (calc_integer) Ditto.
4625 * t-test.q: (groups_calc) Ditto.
4628 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4630 * glob.c: (global var default_dict) Change from `struct
4631 dictionary' to `struct dictionary *'. All references changed.
4632 (init_glob) Initialize default_dict with dict_create().
4634 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4636 struct dictionary now made opaque. All related functions:
4638 * get.c: (rename_variables) Removed.
4639 (dict_delete_run) Removed.
4641 * temporary.c: (copy_variable) Removed.
4642 (new_dictionary) Removed.
4643 (save_dictionary) Removed.
4644 (restore_dictionary) Removed.
4645 (free_dictionary) Removed.
4647 * vars-atr.c: (clear_default_dict) Removed.
4648 (find_variable) Removed.
4649 (find_dict_variable) Removed.
4650 (create_variable) Removed.
4651 (delete_variable) Removed.
4652 (common_init_stuff) Removed.
4653 (init_variable) Removed. Updating of inp_init moved into
4654 cmd_end_input_program().
4655 (replace_variable) Removed.
4656 (rename_variable) Removed.
4657 (clear_variable) Removed.
4658 (dup_variable) Removed.
4660 * vars-prs.c: (is_varname) Removed.
4661 (is_dict_varname) Removed.
4662 (fill_all_vars) Removed.
4664 * vector.c: (find_vector) Removed.
4666 * weight.c: (stop_weighting) Removed.
4668 * dictionary.c: New file.
4669 (dict_create) New, replaces new_dictionary().
4670 (dict_clone) New, replaces save_dictionary() and
4671 restore_dictionary().
4672 (dict_clear) New, replaces clear_default_dict().
4673 (dict_destroy) New, replaces free_dictionary().
4674 (dict_get_var_cnt) New function, replaces references to
4676 (dict_get_var) New function, replaces references to dict->var[i].
4677 (dict_get_vars) New function, replaces fill_all_vars().
4678 (dict_create_var) New, replaces create_variable(). Interface
4679 drops `type' parameter, using a zero `width' to designate numeric.
4680 (dict_clone_var) New, replaces dup_variable().
4681 (dict_rename_var) New, replaces rename_variable().
4682 (dict_lookup_var) New, replaces find_variable(),
4683 find_dict_variable(), is_varname().
4684 (dict_contains_var) New function.
4685 (compare_variable_dblptrs) New function.
4686 (dict_delete_var) New function, replaces clear_variable().
4687 (dict_delete_vars) New function, replaces dict_delete_run().
4688 (dict_reorder_vars) New function.
4689 (dict_rename_vars) New function, replaces rename_variables().
4690 (dict_get_weight) New function, replaces reading dict->weight_var.
4691 (dict_set_weight) New function, replaces writing dict->weight_var
4692 or calling stop_weight(dict).
4693 (dict_get_filter) New function, replaces reading dict->filter_var.
4694 (dict_set_filter) New function, replaces writing dict->filter_var.
4695 (dict_get_case_limit) New function, replaces reading dict->N.
4696 (dict_set_case_limit) New function, replaces writing dict->N.
4697 (dict_get_value_cnt) New function, replaces reading dict->nval.
4698 (dict_compact_values) New function, replaces a loop that was
4699 replicated in several places.
4700 (dict_get_split_vars) New function, replaces reading dict->splits.
4701 (dict_get_split_cnt) New function, replaces reading
4703 (dict_set_split_vars) New function, replaces writing dict->splits.
4704 (dict_get_label) New function, replaces reading dict->label.
4705 (dict_set_label) New function, replaces writing dict->label.
4706 (dict_get_documents) New function, replaces reading
4708 (dict_set_documents) New function, replaces writing
4711 All references to above functions updated.
4713 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4714 old dictionary to new by hand, because dict_create() can't do it
4715 itself. Use dict_set_documents(), dict_set_split_vars().
4717 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4718 calling dict_destroy().
4720 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4722 (fixed_parse_compatible) Some slightly nontrivial changes for
4724 (dump_fmt_list) Ditto.
4727 * file-type.c: (create_col_var) Ditto.
4729 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4730 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4731 (rename_variables) Use dict_rename_vars().
4732 (mtf_merge_dictionary) Use dict_get_documents(),
4733 dict_set_documents(), dict_compact_values().
4735 * pfm-read.c: (read_variables) Deal with changes to weighting.
4737 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4738 is_varname() in output code.
4740 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4741 other dictionary functions.
4743 * title.c: (add_document_line) Use dict_get_documents(),
4744 dict_set_documents().
4746 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4747 reset default_handle by hand. dict_clear() will clear vectors so
4748 there's no need for that by hand.
4750 * vfm.c: (close_active_file) Move call to finish_compaction()
4751 earlier, so that we can do the compaction as a single step using
4752 dict_compact_values(). Use dict_clear_vectors().
4753 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4755 Some functions don't have replacements:
4757 * vars-atr.c: (force_create_variable) Removed. All references
4758 updated to dict_create_var() followed by an assertion.
4759 (force_dup_variable) Removed. All references updated to
4760 dict_clone_var() followed by an assertion.
4762 * weight.c: (update_weighting) Removed. No longer necessary, so
4763 all references removed.
4765 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4769 * aggregate.c: Eliminate separation of weighted and unweighted
4770 case. It made the code too obscure and I doubt it was actually
4771 faster. Instead, all code uses the "weighted" code, because
4772 that's a generalization of the "unweighted" code.
4775 (parse_aggregate_functions) No need to set FWEIGHT.
4776 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4777 (dump_aggregate_info) Ditto.
4778 (initialize_aggregate_info) No need for special plain_function
4779 that gets rid of FWEIGHT option.
4781 * aggregate.c: Get rid of approximations.
4782 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4784 (aggregate_single_case) Don't use approx_ne().
4786 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4788 * ascii.c (ascii_line_width): Dead code, removed.
4790 * postscript.c (ps_line_width): Ditto.
4792 * q2c.c (xrealloc): Ditto.
4794 * count.c (internal_cmd_count): Ditto.
4796 * means.q (validate_dependent_endpoint): Ditto.
4798 * set.q: (cmd_gset) Ditto.
4800 * weight.c: [0] (weight_trns_proc) Ditto.
4802 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4804 Make the code -Wmissing-prototypes clean.
4806 * Makefile.am (version.c): Add #include "version.h".
4808 * ascii.c: (ascii_open_global) Make static.
4809 (ascii_close_page) Ditto.
4810 (ascii_font_sizes) Ditto.
4811 (ascii_postopen_driver) Ditto.
4812 (ascii_close_driver) Ditto.
4813 (ascii_option) Ditto.
4814 (ascii_open_page) Ditto.
4815 (ascii_line_horz) Ditto.
4816 (ascii_line_vert) Ditto.
4817 (ascii_line_intersection) Ditto.
4819 (ascii_polyline_begin) Ditto.
4820 (ascii_polyline_point) Ditto.
4821 (ascii_polyline_end) Ditto.
4822 (ascii_text_set_font_by_name) Ditto.
4823 (ascii_text_set_font_by_position) Ditto.
4824 (ascii_text_set_font_by_family) Ditto.
4825 (ascii_text_get_font_name) Ditto.
4826 (ascii_text_get_font_family) Ditto.
4827 (ascii_text_set_size) Ditto.
4828 (ascii_text_get_size) Ditto.
4829 (ascii_text_metrics) Ditto.
4830 (ascii_text_draw) Ditto.
4831 (ascii_close_page) Ditto.
4833 * cmdline.h: New header for parse_command_line(). Used where
4836 * command.c: Move prototypes for cmd_*() functions to command.h.
4838 * command.h: Prototypes for cmd_*() functions moved here from
4841 * crosstabs.q: (gamma_int) Ditto.
4843 * file-handle.h: Add fh_init_files() prototype.
4845 * getline.c: (welcome) Ditto.
4847 * glob.h: New header for init_glob(). Used where appropriate.
4849 * hash.c: (comparison_helper) Ditto.
4851 * html.c: (html_open_global) Ditto.
4852 (html_close_global) Ditto.
4853 (html_preopen_driver) Ditto.
4854 (html_postopen_driver) Ditto.
4855 (html_close_driver) Ditto.
4856 (html_option) Ditto.
4857 (html_open_page) Ditto.
4858 (html_close_page) Ditto.
4859 (html_submit) Ditto.
4861 * inpt-pgm.c: (input_program_source_read) Ditto.
4863 * output.c: (find_defn_value) Ditto.
4864 (destroy_list) Ditto.
4866 * pfm-read.c: (read_int) Ditto.
4868 * postscript.c: (ps_open_global) Ditto.
4869 (ps_close_global) Ditto.
4870 (ps_font_sizes) Ditto.
4871 (ps_preopen_driver) Ditto.
4872 (ps_postopen_driver) Ditto.
4873 (ps_close_driver) Ditto.
4875 (ps_open_page) Ditto.
4876 (ps_close_page) Ditto.
4877 (ps_line_horz) Ditto.
4878 (ps_line_vert) Ditto.
4879 (ps_line_intersection) Ditto.
4881 (ps_polyline_begin) Ditto.
4882 (ps_polyline_point) Ditto.
4883 (ps_polyline_end) Ditto.
4884 (ps_text_set_font_by_name) Ditto.
4885 (ps_text_set_font_by_position) Ditto.
4886 (ps_text_set_font_family) Ditto.
4887 (ps_text_get_font_name) Ditto.
4888 (ps_text_get_font_family) Ditto.
4889 (ps_text_set_size) Ditto.
4890 (ps_text_get_size) Ditto.
4891 (ps_text_metrics) Ditto.
4892 (ps_text_draw) Ditto.
4894 * q2c.c: (finish_up) Ditto.
4903 (find_symbol) Ditto.
4906 (force_string) Ditto.
4908 (match_token) Ditto.
4911 (parse_setting) Ditto.
4912 (parse_specifier) Ditto.
4913 (parse_specifiers) Ditto.
4914 (parse_subcommand) Ditto.
4915 (dump_specifier_vars) Ditto.
4917 (make_identifier) Ditto.
4918 (dump_declarations) Ditto.
4919 (dump_specifier_init) Ditto.
4920 (dump_vars_init) Ditto.
4922 (dump_specifier_parse) Ditto.
4923 (dump_subcommand) Ditto.
4924 (dump_parser) Ditto.
4925 (dump_header) Ditto.
4927 (recognize_directive) Ditto.
4929 * recode.c: (string_to_long) Ditto.
4931 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4933 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4936 * sort.c: (sort_stream_read) Ditto.
4937 (sort_stream_mode) Ditto.
4939 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4941 * algorithm.c (binary_search): Fix comparison.
4943 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4945 * algorithm.c: (binary_search) Fix assertion.
4947 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4949 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4951 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4953 * sort.c: (compare_case_lists) Rewrite.
4955 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4957 * quicksort.c: Removed (not used).
4959 * quicksort.h: Removed (not used).
4961 * sort.c: Removed blp_quicksort() prototype.
4963 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4965 * postscript.c: (int_2_compare) Rewrite.
4966 (compare_line) Rewrite.
4968 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4970 * matrix-data.c (compare_factors) Use lexicographical_compare()
4972 (compare_doubles) New function.
4974 * algorithm.c: (lexicographical_compare) New algorithm.
4976 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4978 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4980 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4982 * expr-prs.c: (cmp_func) Removed.
4983 (parse_function) Use binary_search() algorithm.
4984 (compare_functions) New function.
4985 (init_func_tab) Use sort() algorithm.
4987 * algorithm.c: (binary_search) New algorithm.
4989 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4991 * descript.q: (display) Use sort() algorithm instead of qsort().
4992 (compare_func) Removed.
4993 (descriptives_compare_variables) New function.
4995 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4997 Get rid of AVL trees. Hashes are more appropriate for everything
5000 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5006 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5008 Much code can be clarified by using C++ STL-like algorithms. Not
5009 all uses of these algorithms are listed below, only the ones where
5010 the change to an algorithm was the only change of interest.
5012 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5014 * algorithm.c: New file.
5016 * algorithm.h: New file.
5018 * modify-vars.c: (static var forward) Removed.
5019 (static var positional) Removed.
5020 (compare_variables) Removed.
5021 (struct ordering) New.
5022 (cmd_modify_vars) Use sort() algorithm.
5023 (compare_variables_given_ordering) New function.
5024 (rearrange_dict) Use sort() algorithm.
5026 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5027 (cmp_var_by_name) Removed.
5029 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5031 Make file handles use a hash table.
5033 * file-handle.q: (files) Change to hash table, make static.
5034 (cmd_file_handle) Use hash table functions.
5035 (fh_get_handle_by_filename) Ditto.
5036 (fh_get_handle_by_name) Ditto.
5037 (hash_file_handle) New function.
5038 (cmp_file_handle) Rewrite.
5039 (fh_init_files) Use hash table functions.
5041 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5043 Clean up FREQUENCIES.
5045 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5047 * frequencies.q: Remove a lot of old #if'd out code at the end.
5048 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5049 or calc_weight(). Initialize percentile_values.
5050 (calc) New function based on calc_weight() from frequencies.g.
5051 (precalc) Use hash functions.
5052 (static var comparison_func) Removed.
5053 (static var comparison_param) Removed.
5054 (comparison_helper) Removed.
5055 (get_freq_comparator) New function.
5056 (not_missing) New function.
5058 (postprocess_freq_tab) Use hash table functions, algorithms,
5059 get_freq_comparator(). Rewrite.
5060 (cleanup_freq_tab) Rephrase.
5061 (add_percentile) Clean up spacing.
5062 (hash_value_numeric) New function.
5063 (hash_value_alpha) New function.
5064 (compare_value_numeric_a) Rewrite.
5065 (compare_value_alpha_a) Rewrite.
5066 (compare_value_numeric_d) Rewrite.
5067 (compare_value_alpha_d) Rewrite.
5068 (compare_freq_numeric_a) Rewrite.
5069 (compare_freq_alpha_a) Rewrite.
5070 (compare_freq_numeric_d) Rewrite.
5071 (compare_freq_alpha_d) Rewrite.
5072 (calc_stats) Clean up mode, percentiles, max.
5073 (dump_statistics) Clean up spacing.
5075 * frequencies.g: Removed.
5077 * var.h: (struct freq_tab) Change `data' to hash table.
5079 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5081 * file-handle.h: Remove declaration of global variable `files',
5082 which wasn't used anywhere.
5084 * postscript.c: (add_encoding) Remove superfluous cast.
5087 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5090 * temporary.c: [0] (display_tree) Removed.
5092 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5094 Implement a new random number generator based on the alleged RC4
5097 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5100 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5101 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5103 (static var V[]) Removed.
5104 (static var Y) Removed.
5105 (static var X2) Removed.
5106 (setup_randomize) Removed.
5108 (rand_uniform) Removed.
5109 (rand_normal) Removed.
5110 (struct rng) New structure.
5111 (rng_create) New function.
5112 (rng_destroy) New function.
5113 (swap_byte) New static function.
5114 (rng_seed) New function.
5115 (rng_get_bytes) New function.
5116 (rng_get_int) New function.
5117 (rng_get_unsigned) New function.
5118 (rng_get_double) New function.
5119 (rng_get_double_normal) New function.
5120 (pspp_rng) New function.
5122 * random.h: Sync up to random.c.
5124 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5125 fraction of UINT_MAX, not 65536.
5126 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5129 * vfm.c: (open_active_file) No need to call setup_randomize() any
5132 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5134 Change dictionary name indexes to use hash tables instead of AVL
5137 * crosstabs.q: (free_var_dict) Use hash tables.
5138 (crs_custom_tables) Ditto.
5139 (calc_general) Ditto.
5140 (compare_table_entry) Rewrite.
5141 (enum_var_values) Reorder parameters. All references updated.
5144 * get.c: (rename_variable) Use hash tables.
5145 (mtf_merge_dictionary) Ditto.
5147 * glob.c: (init_glob) Use hash tables.
5148 (cmp_variable) Removed.
5150 * means.q: (mns_custom_tables) Use hash tables.
5152 * modify-vars.c: (rearrange_dict) Use hash tables.
5154 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5156 * sfm-read.c: (read_header) Use hash tables.
5157 (read_variables) Ditto.
5159 * temporary.c: (new_dictionary) Use hash tables.
5160 (save_dictionary) Ditto.
5161 (restore_dictionary) Ditto.
5163 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5164 hash table `name_tab'.
5166 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5167 [DEBUGGING] (dump_var_tree) Removed.
5168 (find_variable) Use hash tables.
5169 (find_dict_variable) Ditto.
5170 (common_init_stuff) Ditto.
5171 (rename_variable) Ditto.
5172 (clear_variable) Ditto. Also, remove debug code.
5173 (dup_variable) Use hash tables.
5175 * vars-prs.c: (fill_all_vars) Use hash tables.
5176 (is_dict_varname) Ditto.
5177 (parse_dict_variable) Ditto.
5179 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5181 Change value labels to use hash tables instead of AVL trees, and
5182 change value labels into an ADT.
5184 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5186 * value-labels.c: New file.
5188 * value-labels.h: New file.
5190 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5191 Get rid of a stupid use of goto.
5193 * autorecode.c: (compare_alpha_value) Rewrite.
5194 (hash_alpha_value) Ditto.
5195 (compare_numeric_value) Rewrite.
5196 (hash_numeric_value) Ditto.
5198 * frequencies.q: (dump_full) Use value label ADT.
5200 * pfm-read.c: (read_value_label) Use value label ADT.
5202 * pfm-write.c: (write_value_labels) Use value label ADT.
5204 * sfm-read.c: (read_variables) Use value label ADT.
5205 (read_value_labels) Rewrite.
5207 * sfm-write.c: (write_value_labels) Rewrite.
5209 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5210 (display_variables) Ditto.
5211 (describe_variable) Ditto.
5213 * t-test.q: (print_t_groups) Use value label ADT.
5215 * temporary.c: (copy_variable) Use value label ADT.
5216 (free_dictionary) Ditto.
5218 * val-labs.c: (verify_val_labs) Use value label ADT.
5220 (debug_print) Ditto.
5221 (val_lab_cmp) Removed.
5222 (inc_ref_count) Removed.
5223 (copy_value_labels) Removed.
5225 * var.h: (struct value_label) Removed.
5226 (struct variable) Change AVL tree `val_lab' into hash table
5229 * vars-atr.c: (init_variable) Use value label ADT.
5230 (clear_variable) Ditto.
5231 (free_value_label) Removed.
5232 (free_val_lab) Removed.
5233 (get_val_lab) Removed.
5234 (compare_variables) New function.
5235 (hash_variable) New function.
5237 * vfm.c: (dump_splits) Use value label ADT.
5239 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5241 Add to the hash table interface.
5243 * hash.c: (hsh_hash_bytes) Add assertion.
5244 (hsh_hash_string) Ditto.
5248 (hsh_create) Ditto. Also make minimum `size'.
5249 (hsh_destroy) Rephrase.
5250 (sort_nulls_last) Removed.
5251 (not_null) New function.
5253 (comparison_helper) Ditto.
5254 (hsh_sort) Rewritten.
5255 (hsh_data_copy) New function.
5256 (hsh_sort_copy) Ditto.
5258 (hsh_replace) Ditto.
5259 (hsh_hash_double) Ditto.
5260 (hsh_delete) Fix stupid bug.
5262 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5263 * added a calculation of the mode to FREQUENCIES
5265 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5267 * moved (un)defs of DEBUGGING to config.h
5269 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5271 * groff-font.c: (add_kern) Fix indentation.
5272 (add_kern) Use & instead of % to take power-of-2 modulus.
5273 (font_get_kern_adjust) Likewise.
5275 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5277 * autorecode.c: (recode) Replace stupid use of memcpy() by
5279 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5280 (hash_numeric_value) Ditto.
5281 (autorecode_proc_func) pool_strdup() was wrong here because the
5282 source string was not null-terminated. Use new pool_strndup()
5285 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5286 use of hsh_iterator_init().
5288 * data-in.c: (parse_N) Initialize i->v->f.
5290 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5293 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5294 (groff_read_font) Don't call hsh_next_prime(). Don't call
5296 (static var hash) Remove `size_p', `max_used' members.
5297 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5298 hsh_hash_string() instead of hashpjw(), & instead of %.
5299 (default_font) Don't call hsh_next_prime().
5301 * pool.c: (pool_strndup) New function.
5302 (pool_strdup) Reimplement in terms of pool_strndup.
5304 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5306 (hash_ps_encoding) Use hsh_hash_string().
5307 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5308 (hash_filename2font) Use hsh_hash_string().
5310 * som.c: Add #include <stdlib.h>.
5312 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5313 (by destroying its pool).
5315 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5317 Miscellaneous hash table code cleanup:
5319 * hash.h: (struct hsh_table) Moved into hash.c.
5320 (hsh_count) Ditto, and transformed into function.
5321 (hsh_compare_func) New typedef, used for defining otherwise-long
5322 function types here and in hash.c
5323 (hsh_hash_func) Ditto.
5324 (hsh_free_func) Ditto.
5326 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5327 `table' to `entries'. Removed `mp'. All references updated.
5328 (hsh_clear) Don't shrink entries array; if the hash was this big
5329 once, it probably will be again.
5330 (hsh_rehash) Made static.
5331 (force_hsh_insert) Renamed hsh_force_insert.
5332 (force_hsh_find) Renamed hsh_force_find.
5334 Made hash table sizes powers of 2, because that's fine with any
5335 reasonable hash function and because taking a power-of-2 modulus
5336 is faster than any other:
5338 (hsh_prime_tab) Removed;
5339 (hsh_next_prime) Ditto.
5340 (next_power_of_2) New function.
5341 (hsh_create) Use next_power_of_2.
5342 (hsh_rehash) Use & instead of %.
5344 Cleaned up hsh_sort:
5346 (internal_comparison_fn) Removed.
5347 (sort_nulls_last) New function.
5348 (hsh_sort) Removed second parameter, switched to using the new
5349 quicksort() function from quicksort.h to avoid using nasty need
5350 for static variables with qsort(). All references updated.
5352 Changed the hash functions offered, because there are better hash
5353 functions than the ones we had, and cleaned up the names to boot:
5355 * hash.c: (hashpjw_d) Removed.
5357 (hsh_hash_bytes) New function.
5358 (hsh_hash_string) New function.
5359 (hsh_hash_int) New function.
5361 Improved the hash table iteration interface:
5363 * hash.h: (hsh_iterator_init) Removed.
5364 (struct hsh_iterator) Removed `init' member, change `next' to
5367 * hash.c: (hsh_foreach) Removed. All references updated to use
5368 hsh_first/hsh_next instead.
5369 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5370 not treat a null pointer as an empty hash table.
5371 (hsh_next) New function.
5373 Made deletion possible, though slow:
5375 * hash.c: (locate_matching_entry) New function.
5376 (hsh_find) Use locate_matching_entry().
5377 (hsh_delete) New function also using locate_matching_entry().
5378 (hsh_force_delete) New function.
5380 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5382 * quicksort.c: New file implementing a sort routine with a
5383 interface better than qsort() because it passes a user-provided
5384 parameter to the sort routine.
5386 * Makefile.am: Add quicksort.c, quicksort.h.
5388 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5390 * All source files: Get rid of nasty special cases for Checker,
5391 which is pretty obsolete now.
5393 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5395 * Fixed a bug apparent when using the FREQUENCIES command with the
5396 html driver. The html driver was incorrectly trying to display
5399 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5401 * Makefile.am: Reorganized. Put locale dir in version.c instead
5402 of passing it to each compile command. Only put local gmp libs in
5403 LD_ADD if not installed on system. Remove `boast' target.
5405 * All source files: struct and union typedefs eliminated.
5406 `sizeof type' replaced by `sizeof object' where practical. Moved
5407 `unused' qualifiers from start to end of declarations for gcc
5408 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5409 assertions on pointers strictly compliant. Removed _ prefixes on
5410 some function parameter names.
5412 * alloc.c: New source file, containing these external linkage
5413 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5420 * ascii.c: Migrated from arenas to pools.
5421 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5422 c_string to len_string. All references changed.
5423 (ascii_option) Signature changed to comply to new output.c
5425 (count_fancy_chars) Removed.
5426 (delineate) Removed support for rich text.
5427 (ascii_text_metrics) Ditto.
5429 (output_shorts) Change `box', `off', `on' from c_string to
5430 len_string. Change `remaining' from int to size_t.
5431 (ascii_close_page) Make page numbering less haphazard.
5433 * autorecode.c: Migrate from arenas to pools.
5435 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5437 * bitvector.h: New file containing these macros from misc.h:
5438 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5440 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5441 word[3]. ncmd removed.
5442 (var empty_string) Removed.
5443 (var cmd_table) Declaration updated.
5444 (var cmdtab) Removed.
5445 (cmp_command) Removed.
5446 (split_words) Rewritten to use strtok_r().
5447 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5448 (find_command) Removed.
5449 (FILE_TYPE_okay) Rewritten.
5450 (cmd_parse) Rewritten. Semantics of the return value of command
5451 handlers has changed: they must now return one of the new CMD_*
5452 enumerals, rather than a magic value. This meant that all
5453 commands had to be modified, and they were.
5454 (figure_out_command) New function.
5456 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5457 #defines for INIT, INPU, etc.
5459 * command.h: New CMD_* enum series.
5460 (cur_proc) Make const char *, not char *.
5461 (cmd_init) Prototype.
5464 * common.c: Removed.
5466 * common.h: Removed.
5468 * correlations.q: New file.
5470 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5472 (custom_tables) Renamed crs_custom_tables().
5473 (custom_variables) Renamed crs_custom_variables().
5474 (calc_integer) Add in some `const' qualifiers.
5475 (table_value_missing) Change from a_string to len_string.
5476 (float_M_suffix) Change from a_string to len_string.
5478 * data-in.c: Rewritten. All references to
5479 parse_string_as_format() changed to data_in().
5481 * data-in.h: New file.
5483 * data-list.c: Change DLS_* from #define's to enums. Move from
5484 rpd_msg() to tmsg().
5485 (RPD_ERR) New #define.
5486 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5488 (read_from_data_list_fixed) Change from old
5489 parse_string_as_format() to new data_in().
5490 (read_from_data_list_free) Ditto.
5491 (read_from_data_list_list) Ditto.
5492 (cmd_repeating_data) Modify approach to checking for end of
5495 (rpd_parse_record) Change from old parse_string_as_format() to new
5496 data_in(). Change from old convert_format_to_string() to new
5498 (read_one_set_of_repetitions) Change dfm_push_cust() to
5499 dfm_push(), pop_cust() to dfm_pop().
5501 * data-out.c: Rewritten. All references to
5502 convert_format_to_string() changed to data_out().
5504 * descript.q: Migrate to new q2c.
5505 (cmd_descriptives) Removed.
5506 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5507 (custom_variables) Renamed dsc_custom_variables().
5509 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5511 (open_file_r) Initialize h->where.line_number. Migrate to new
5513 (open_file_w) Initialize h->where.line_number.
5514 (read_record) Change from ext->ln to h->where.line_number.
5515 Migrate to struct string.
5516 (dfm_put_record) Rephrased.
5517 (dfm_push_cust) Renamed dfm_push(), rewritten.
5518 (dfm_pop) New function.
5520 * error.c: All references updated.
5521 (glob var error_count) Renamed err_err_count.
5522 (glob var warning_count) Renamed err_warning_count.
5523 (glob var error_already_flagged) Renamed err_already_flagged.
5524 (glob var verbosity) Renamed err_verbosity.
5525 (glob var cust_fn) Removed.
5526 (glob var cust_ln) Removed.
5527 (static var file_loc) New.
5528 (static var nfile_loc) New.
5529 (static var mfile_loc) New.
5530 (tmsg) New function.
5531 (push_cust) Removed.
5534 (static var terminating) Removed.
5535 (failure) Renamed err_failure().
5536 (hcf) Renamed err_hcf().
5537 (err_push_file_locator) New function.
5538 (err_pop_file_locator) New function.
5539 (err_location) New function.
5540 (check_error_count) Renamed err_check_count().
5541 (vmsg) Renamed err_vmsg(). Interface changed.
5542 (verbose_msg) Removed.
5543 (err_cond_fail) New function.
5544 (error_break) Renamed err_break().
5546 * error.h: All references updated.
5547 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5548 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5550 (struct file_locator) New.
5552 (macro verbose_msg) Removed.
5553 (macro cond_fail) Removed.
5555 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5557 * expr-prs.c: Reorganized. All references updated.
5558 (exprtypename) Renamed expr_type_name().
5559 (typename) Renamed type_name().
5560 (free_expression) Renamed expr_free().
5561 (parse_expression) Renamed expr_parse(). Uses new type_check()
5563 (init_functab) Renamed init_func_tab().
5564 (type_check) New function.
5565 (parse_or) Rewritten to use new allocate_nonterminal() and
5566 append_nonterminal_arg() functions.
5569 (parse_rel) Ditto. Also simplified logic.
5574 (SYSMIS_func) Ditto.
5575 (VALUE_func) Rephrased.
5576 (CONCAT_func) Fix memory leak by replacing free by free_node on
5578 (generic_str_func) Ditto.
5579 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5581 (allocate_nonterminal) New function.
5582 (append_nonterminal_arg) New function.
5583 (static func_tab[]) Now at file level.
5585 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5587 * expr.h: (enum series OP_*) Moved to exprP.h.
5588 (OP_* defines) Ditto.
5589 (struct op_desc) Ditto.
5590 (global ops[]) Ditto.
5591 (struct num_con_node) Ditto.
5592 (struct str_con_node) Ditto.
5593 (struct var_node) Ditto.
5594 (struct lag_node) Ditto.
5595 (struct casenum_node) Ditto.
5596 (struct nonterm_node) Ditto.
5597 (union any_node) Members renamed.
5598 (struct sys_node) Removed.
5599 (struct val_node) Removed.
5600 (operator typedef) Removed.
5601 (typedef exprtype) Removed.
5602 (enum series EX_*) Moved to exprP.h.
5603 (struct expression) Ditto. Also renamed a lot of the members.
5604 (PXP_* defines) Changed to enums.
5605 (free_node prototype) Moved to exprP.h.
5607 * file-handle.h: (struct file_handle) New member `where'.
5609 * file-handle.q: Migrated to new q2c format.
5610 (prepend_current_directory) Removed (dead code).
5611 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5612 (fh_get_handle_by_filename) Removed dead code.
5613 Set new `where' member.
5615 * file-type.c: (file_type_source_read) References to
5616 parse_string_as_format() changed to data_in().
5617 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5619 * filename.c: All references updated.
5620 (init_filename) Renamed fn_init().
5621 (expand_line) Removed.
5622 (macro EXPAND_LINE) Removed.
5623 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5624 of custom functions.
5625 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5626 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5627 (normalize_filename) Renamed fn_normalize().
5628 (search_path) Renamed fn_search_path(), rewritten.
5629 (prepend_dir) Renamed fn_prepend_dir().
5630 (blp_getenv) Renamed fn_getenv().
5631 (blp_dirname) Renamed fn_dirname().
5632 (fn_basename) New function, not used.
5633 (absolute_filename_p) Renamed fn_absolute_p().
5634 (is_special_filename) Renamed fn_special_p().
5635 (file_exists) Renamed fn_exists_p().
5636 (readlink_malloc) Renamed fn_readlink().
5637 (getenv_default) Renamed fn_getenv_default().
5638 (open_file) Renamed fn_open().
5639 (close_file) Renamed fn_close().
5640 (open_file_ext) Renamed fn_open_ext().
5641 (close_file_ext) Renamed fn_close_ext().
5643 * font.h: Migrate from arenas to pools.
5645 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5647 * frequencies.g: Migrate from arenas to pools.
5649 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5652 * getline.c: All references updated.
5653 (global getl_buf) Changed from char * to struct string.
5654 (static getl_include_path) Ditto.
5655 (global getl_buf_len) Removed.
5656 (global getl_buf_size) Removed.
5657 (getl_include_path) Deal with new getl_buf, getl_include_path.
5658 (getl_uninitialize) New function.
5659 (getl_get_current_directory) Rewritten.
5660 (getl_clear_include_path) Rewritten.
5661 (getl_add_include_dir) Rewritten.
5662 (getl_add_file) Assertion fixed.
5663 (getl_add_virtual_file) Change initial value of `remaining_loops'
5665 (welcome) Rewritten.
5666 (handle_line_buffer) Make static. Change logic to make
5667 getl_add_virtual_file() change sensible. Use ds_*() strings.
5668 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5669 (getl_close_file) Moved.
5670 (getl_location) New function.
5672 * getline.h: All references updated.
5673 (macro curln) Removed.
5674 (macro curfn) Removed.
5675 (macro am_interactive) Renamed getl_am_interactive.
5676 (macro am_reading_script) Renamed getl_reading_script.
5678 * glob.c: (global fmt_parse_ignore_error) Removed.
5679 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5680 systems that support it (C99). Turn off SET ECHO by default. No
5681 necessary julcal initialization anymore.
5683 * groff-font.c: Migrate from arenas to pools.
5684 (groff_read_font) Use err_push_file_locator().
5685 (groff_read_DESC) Ditto.
5686 (font_msg) Use tmsg().
5688 * hash.c: (hsh_sort) Fix debug code.
5689 [GLOBAL_DEBUGGING] Include stdio.h.
5691 * hash.h: (macro force_hsh_insert) Rephrase.
5693 * heap.c: Rewritten.
5695 * heap.h: Rewritten.
5697 * html.c: (html_option) Change from outp_value to struct string.
5698 (postopen) Change from curfn to getl_location().
5699 (escape_string) Remove rich-text code. Signature changed.
5700 (output_tab_table) Switch from a_string to struct len_string.
5701 Remove rich text support.
5703 * lexer.c: All references updated. Largely rewritten. Major
5704 changes listed below. Removed tagged quote support. Adapted to
5705 struct string tokstr.
5706 (global tokstr) Changed to struct string.
5707 (global tokstr_size) Removed.
5708 (global tokstr_len) Removed.
5710 (global tokint) Removed.
5711 (global toklongstr) Removed.
5712 (C* defines) Removed.
5713 (static tbl[]) Removed.
5714 (static id[]) Removed.
5715 (static une[]) Removed.
5716 (discard_line) Renamed lex_discard_line().
5717 (get_entire_line) Renamed lex_entire_line().
5718 (get_rest_of_line) Renamed lex_rest_of_line().
5719 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5720 (make_hexit) Removed.
5721 (syntax_error) Renamed lex_error(). Return value removed.
5722 (get_token_representation) Renamed lex_token_representation().
5723 (putback) Renamed lex_put_back().
5724 (putfwd) Renamed lex_put_forward().
5725 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5726 (set_prog) Renamed lex_set_prog().
5727 (init_lex) Renamed lex_init().
5728 (reset_eof) Renamed lex_reset_eof().
5729 (lookahead) Renamed lex_look_ahead().
5730 (check_id) Rewritten.
5731 (yylex) Renamed lex_get(), rewritten.
5732 (lex_end_of_command) New function. Many commands were rephrased
5734 (lex_integer_p) New function. Replaces compare of tokint against
5736 (lex_integer) New function. Replaces tokint.
5737 (match_tok) Renamed lex_match().
5738 (match_id) Renamed lex_match_id().
5739 (match_int) Renamed lex_match_int().
5740 (force_match_id) Renamed lex_force_match_id(), added return value.
5741 (force_match) Renamed lex_force_match(), added return value.
5742 (force_string) Renamed lex_force_string(), added return value.
5743 (force_int) Renamed lex_force_int(), added return value.
5744 (lex_id_match_len) New function.
5745 (id_match) Renamed lex_id_match(), rewritten.
5746 (get_line) Renamed lex_get_line().
5747 (preprocess_line) Renamed lex_preprocess_line().
5748 (tokname) Renamed lex_token_name().
5749 (bin_value_func) Removed.
5750 (oct_value_func) Removed.
5751 (hex_value_func) Removed.
5752 (unexpected_eof) New function.
5753 (convert_numeric_string_to_char_string) New function.
5754 (parse_string) Rewritten, signature changed.
5755 (add_tokstr_char) Removed.
5756 (add_tokstr_unsigned) Removed.
5757 (add_tokstr_string) Removed.
5758 (parse_tagged_quote) Removed.
5759 (skip_comment) Renamed lex_skip_comment().
5761 * lexer.h: All references updated.
5762 (macro is_id1) Renamed CHAR_IS_ID1.
5763 (macro is_idn) Renamed CHAR_IS_IDN.
5764 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5765 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5766 (macro get_token) Removed.
5767 (macro id_match) Removed.
5768 (macro force_match_id) Removed.
5769 (macro force_match) Removed.
5770 (macro force_string) Removed.
5771 (macro force_int) Removed.
5772 (macro force_num) Removed.
5773 (macro force_id) Removed.
5775 * lexerP.h: Removed.
5777 * list.q: Migrated to new q2c format.
5778 (write_line) Deal with struct len_string.
5779 (write_varname) Ditto.
5780 (write_fallback_headers) Ditto.
5782 * magic.c: New file, incorporating the following global variables
5783 previously in other files: endian, second_lowest_value. And both
5784 of those are conditional on #define's.
5786 * magic.h: New file, incorporating the following global variable
5787 declarations: endian, second_lowest_value, and the following macro
5788 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5790 * main.c: Added declarations of pgmname, finished, curdate,
5792 (main) Call new parse_script() function.
5793 (parse_script) New function.
5794 (execute_command) New function.
5795 (dump_token) Removed.
5796 (handle_error) New function.
5798 * matrix.c: New file.
5800 * matrix.h: New file.
5802 * matrix-data.c: Migrated from arenas to pools.
5803 (mget_token) Change from parse_string_as_format() to data_in().
5805 * means.q: Migrate to new q2c.
5806 (custom_tables) Renamed mns_custom_tables().
5807 (custom_crossbreak) Renamed mns_custom_crossbreak().
5808 (custom_variables) Renamed mns_custom_variables().
5810 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5811 (parse_varnames) Prototype.
5812 (parse_numeric) Rephrasings.
5813 (parse_alpha) Adapt to new struct string tokstr.
5815 * misc.c: (intlog10) Rewritten.
5817 (ansi_rand) Renamed real_rand(), moved into random.c.
5818 (ansi_srand) Renamed real_srand(), moved into random.c.
5819 (setup_randomize) Moved to random.c.
5820 (rand_uniform) Ditto.
5821 (rand_normal) Ditto.
5822 (rand_simple) Ditto.
5823 (get_config_line) Removed.
5824 (reverse) Removed (dead code).
5826 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5827 (macro CLEAR_BIT) Ditto.
5828 (macro TEST_BIT) Ditto.
5829 (macro SET_BIT_TO) Ditto.
5830 (macro BIT_INDEX) Ditto.
5832 * output.c: (outp_read_devices) Move to err_push_file_locator()
5833 from push_cust(). Use struct string.
5834 (expand_op_tokstr) Removed.
5835 (static var op_tokstr) Changed to struct string.
5836 (static var op_tokstr_size) Removed.
5837 (tokener) Rephrasings. Use struct string.
5838 (parse_options) Use struct string.
5839 (destroy_driver) Fix assertion.
5840 (outp_get_paper_size) Move to err_push_file_locator().
5841 [0] Removed dead code.
5842 (outp_string_width) Move to len_string.
5844 * output.h: Comment fixes.
5845 (TAG_* enum series) Removed.
5846 (struct outp_value) Removed.
5847 (enum OUTP_T_FANCY) Removed.
5848 (struct outp_text) `s' changed from a_string to len_string.
5849 (struct outp_class) `option' change arg 3 from outp_value to
5852 * pfm-read.c: (corrupt_msg) Rewritten.
5854 * pfm-write.c: (bufwrite) Fix assertion.
5856 * pool.c: New file, reference version.
5858 * pool.h: New file, reference version.
5860 * postscript.c: (ps_font_sizes) Fix assertion.
5861 (ps_option) Change arg 3 from outp_value to struct string.
5862 Adapt to struct string.
5863 (macro output_line) Removed.
5864 (macro add_string) Removed.
5865 (output_encodings) Adapted to struct string. Moved to
5866 err_push_file_locator().
5867 (find_encoding_file) Fix assertion.
5868 (read_ps_encodings) Move to err_push_file_locator().
5869 (postopen) Use getl_location() instead of curfn.
5870 (out_text_plain) Move to len_string.
5871 (text) Ditto. Remove rich text support.
5873 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5874 (cmd_print_eject) Ditto.
5876 (internal_cmd_print) Now cleans up after itself. Uses
5877 fh_parse_file_handle() now.
5878 (cmd_print_space) Use PXP_NUMERIC to type-check.
5880 * q2c.c: Overhauled. Removed _("") i18n support. All references
5881 updated. All output functions updated to handle structures rather
5882 than local or static variables. Adapt to new PSPP lex_*()
5886 (macro MAX_N_SBC) Removed.
5887 (global bare) Removed.
5888 (enum STRING) Renamed T_STRING.
5889 (enum ID) Renamed T_ID.
5890 (get_buffer) Buffer size increased.
5891 (strlower) Renamed st_lower(), rephrased.
5892 (strupper) Renamed st_upper(), rephrased.
5893 (skip_ws) New function.
5894 (get_line) Don't special-case any types of lines (like those
5895 beginning with ! or $, for instance).
5896 (get_token) Renamed lex_get(). Rephrased.
5897 (static var `prefix') New.
5898 (parse) New function.
5899 (parse_setting) Minor rephrasing.
5900 (dump_specifier_vars) Ditto.
5901 (make_identifier) Put null terminator on identifier, duh.
5902 (dump_vars) Renamed dump_declarations(). Never indent. Never
5903 static. Output changed entirely.
5904 (dump_specifier_init) Rephrase.
5905 (dump_vars_init) No index variable needed. Other modifications.
5906 (dump_parser) Don't parse command name. Do dump functions instead
5907 of just code fragments.
5908 (dump_free) Dump function instead of code fragment.
5909 (recognize_directive) New function.
5910 (main) Use recognize_directive(). Don't rely on magic $ line
5911 beginning: instead, parse comments. Update list of headers.
5913 * random.c: New file, containing the following functions:
5914 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5915 rand_normal, rand_simple.
5917 * random.h: New file.
5919 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5920 function. `max_src_width', `max_dst_width' changed to size_t.
5921 (internal_cmd_recode) Removed.
5922 (parse_dest_spec) Merge similar cases.
5923 (parse_src_spec) Add assertion.
5925 * repeat.c: (recognize_keyword) New function.
5926 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5927 REPEAT. Improve recognition of END REPEAT (use
5928 recognize_keyword()). Move from curfn to getl_location(). Use
5931 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5933 * set.q: Adapt to new q2c.
5934 (cmd_set) Range-check some values better.
5935 (custom_blanks) Renamed stc_custom_blanks().
5936 (custom_length) Renamed stc_custom_length().
5937 (custom_results) Renamed stc_custom_results().
5938 (custom_seed) Renamed stc_custom_seed().
5939 (custom_width) Renamed stc_custom_width().
5940 (custom_format) Renamed stc_custom_format().
5941 (custom_journal) Renamed stc_custom_journal().
5942 (custom_color) Renamed stc_custom_color().
5943 (custom_listing) Renamed stc_custom_listing().
5944 (custom_disk) Renamed stc_custom_disk().
5945 (custom_log) Renamed stc_custom_log().
5946 (custom_rcolor) Renamed stc_custom_rcolor().
5947 (custom_viewlength) Renamed stc_custom_viewlength().
5948 (custom_workdev) Renamed stc_custom_workdev().
5950 * settings.h: Not necessary to include format.h any longer.
5952 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5953 (corrupt_msg) Rewritten.
5955 * sort.c: Adapt to rewritten heap ADT.
5957 * str.c: (aa_strcpy) Removed.
5958 (ab_strcpy) Removed.
5959 (ac_strcpy) Removed.
5960 (ba_strcpy) Removed.
5961 (bb_strcpy) Removed.
5962 (ca_strcpy) Removed.
5963 (aa_strdup) Removed.
5964 (aa_strdupcpy) Removed.
5965 (ba_strdup) Removed.
5966 (sa_strdup) Removed.
5967 (memrev) Renamed mm_reverse().
5968 (memrmem) Renamed mm_find_reverse().
5969 (cmp_str) Renamed st_compare_pad().
5970 (strmaxcpy) Removed.
5971 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5972 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5974 (strpadcpy) Renamed st_pad_copy(), signature changed.
5975 (blpstrset) Removed.
5976 (ds_create) New function.
5977 (ds_init) New function.
5978 (ds_replace) New function.
5979 (ds_destroy) New function.
5980 (ds_clear) New function.
5981 (ds_extend) New function.
5982 (ds_shrink) New function.
5983 (ds_truncate) New function.
5984 (ds_length) New function.
5985 (ds_size) New function.
5986 (ds_value) New function.
5987 (ds_end) New function.
5988 (ds_concat) New function.
5989 (ds_concat_buffer) New function.
5990 (ds_printf) New function.
5991 (ds_putchar) New function.
5992 (ds_getline) New function.
5993 (ds_get_config_line) New function derived from the old
5994 misc.c:get_config_line().
5995 (ls_create) New function.
5996 (ls_create_buffer) New function.
5997 (ls_init) New function.
5998 (ls_shallow_copy) New function.
5999 (ls_destroy) New function.
6000 (ls_null) New function.
6001 (ls_null_p) New function.
6002 (ls_empty_p) New function.
6003 (ls_length) New function.
6004 (ls_value) New function.
6005 (ls_end) New function.
6007 * str.h: Reformatted.
6008 (struct a_string) Removed.
6009 (struct b_string) Removed.
6010 (struct c_string) Removed.
6011 (struct len_string) New.
6012 (struct string) New.
6013 (macro as_streq) Removed.
6014 (macro bs_streq) Removed.
6015 (macro cs_streq) Removed.
6016 (macro sa_streq) Removed.
6017 (macro sb_streq) Removed.
6018 [__GNUC__] (inline function ds_putchar) New function.
6019 [__GNUC__] (inline function ds_length) New function.
6020 [__GNUC__] (inline function ds_value) New function.
6021 [__GNUC__] (inline function ds_end) New function.
6023 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6024 (display_vectors) Fix missing i18n.
6026 * t-test.q: Migrate to new q2c.
6028 * tab.c: Migrate from arenas to pools.
6029 (tab_create) Use struct len_string.
6030 (tab_realloc) Ditto.
6031 (text_format) Ditto.
6032 (tab_joint_text) Ditto.
6033 (tab_natural_width) Remove rich text support.
6034 (tab_natural_height) Ditto.
6035 (tab_output_text) Handle TAT_FIX.
6036 (tab_raw) Change arg from a_string to len_string.
6037 (tabi_driver) Fix assertion. Use struct len_string.
6038 (render_strip) Use struct len_string. Remove rich text support.
6039 Add `const' qualifiers.
6041 * tab.h: (enum TAB_RICH) Remove.
6042 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6043 SOM_COL_* updated to read TAB_COL_*.
6044 (struct tab_table) Change arena to pool. Change a_string to
6047 * temporary.c: (restore_dictionary) Rewrite Checker code.
6049 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6050 LOWEST, HIGHEST) Moved here from common.h.
6051 (typedef any_trns) Removed. All references changed to `struct
6054 * vars-atr.c: (force_create_variable) Fix assertion.
6055 (force_dup_variable) Fix assertion.
6057 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6059 Using alphanumeric variables in functions under AGGREGATE
6060 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6061 <BZN-mdksh@t-online.de> for reporting this bug.
6063 * aggregate.c: (parse_aggregate_functions) When setting the
6064 FSTRING bit, also allocate memory for the `string' member of
6066 (free_aggregate_functions) Free iter->string. Don't use the
6067 non-function bits when indexing the array of functions.
6068 [DEBUGGING] (debug_print) Don't use the non-function bits when
6069 indexing the array of functions.
6071 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6073 Under certain circumstances, the final case would be omitted from
6074 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6075 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6077 * aggregate.c (agr_00x_end_func): Increment number of cases in
6078 sink before writing case. For streams that keep track of how many
6079 cases there are based on this value, this means that the last case
6080 will be read in on the next stream read.
6082 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6084 Undefined behavior was invoked by referencing a freed pointer.
6086 * vfm.c (memory_stream_write): Free pointer *after* checking for
6089 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6091 A wrong record size was displayed when paging the active file to
6094 * vfm.c: (memory_stream_write) Fix off-by-one error.
6096 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6098 Not having enough temporary space for sorting caused a core dump.
6101 * sort.c: (allocate_cases) Initialize i.
6103 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6105 Syntax errors in function descriptions on AGGREGATE caused core
6108 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6109 free_aggregate_functions(), since that function already frees
6112 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6114 A null pointer was dereferenced, causing a core dump, when
6115 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6116 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6117 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6119 * arena.c: (arena_malloc) If the arena hasn't been initialized
6120 already, initialize it.
6122 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6124 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6125 for compilation with Cygnus Windows B20. Not used by other
6128 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6130 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6131 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6133 * sort.c: (compare_case_lists) Reverse sense of comparison if
6134 sorting in descending order.
6135 (compare_record) Ditto.
6137 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6139 SPLIT FILE with a string variable caused a core dump. Fixed.
6141 * vfm.c: If the variable is a string then make a temporary value
6142 struct pointing to it. The underlying problem is a lot bigger
6143 than this (see TODO) but this is a stopgap for the simple case at
6146 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6148 Nested INCLUDEs didn't work. Fixed.
6150 * getline.c: (getl_include) Set first_line to NULL in allocated
6153 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6155 The MATCH FILES procedure set the values of variables not present
6156 to 0. It should have been SYSMIS. This is now fixed.
6158 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6160 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6162 The REMARK command was too aggressive about skipping lines. It
6163 didn't like being the last command in a file.
6165 * command.c: (cmd_remark) Call get_entire_line() instead of
6168 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6170 Comment parsing wasn't consistent with the rest of the code in its
6171 idea of where one command ends and another starts. This meant
6172 that sometimes commands would be mysteriously ignored. Thanks to
6173 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6175 * command.c: (parse_cmd) Hand off comment parsing to new function
6176 skip_comment() in lexer.c.
6177 * lexer.c: (skip_comment) New function.
6179 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6181 The TABLE subcommand on MATCH FILES worked only erratically at
6182 best. This fixes it. Thanks to Dr. Dirk Melcher
6183 <BZN-mdksh@t-online.de> for reporting this bug.
6185 * get.c: (mtf_compare_BY_values) When comparing string values, a
6186 difference of 1 is still a difference :-)
6187 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6188 advance TABLE files automatically when matched. Comment fixes.
6190 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6192 VARIABLE LABELS rejected a slash before the first variable
6193 specification, contradicting the documentation. Thanks to Walter
6194 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6196 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6197 command specification.
6199 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6201 Because of an incorrect optimization in memory allocation,
6202 CROSSTABS sometimes segfaulted when asked to output multiple
6203 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6206 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6207 are passed to output_pivot_table() for its use.
6208 (output_pivot_table) Instead of assuming the number of columns is
6209 constant, keep track with maxcols. In general mode, use maxcells
6210 to determine whether more matrix cells need to be allocated.
6212 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6214 CROSSTABS didn't display value labels for column and row
6215 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6218 * crosstabs.q: (table_value_missing) If the specified value has a
6219 value label for this variable, then show it instead of the raw
6221 (display_dimensions) Delegate display of value_labels to
6222 table_value_missing.
6224 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6226 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6227 <BZN-mdksh@t-online.de> for reporting this bug.
6229 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6230 if the file isn't declared as binary.
6232 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6234 MATCH FILES corrupted memory and dumped core on some syntax
6237 * get.c: (cmd_match_files) Set file->handle to NULL before
6239 (mtf_free_file) Don't free a null dictionary.
6241 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6243 MATCH FILES should set numeric values not available to the
6244 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6245 <BZN-mdksh@t-online.de> for reporting this bug.
6247 * get.c: (mtf_processing) Set unused records to system-missing,
6250 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6252 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6253 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6255 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6256 in newly created dictionary, and add each copied variable to the
6259 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6263 * get.c: (trim_dictionary) Free variable list for KEEP after
6266 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6268 Some systems didn't like the way open_file was coded. Thanks to
6269 Hankin <hankin@rogue.consultco.com> for pointing this out.
6271 * filename.c: (open_file) Don't try to store stdin, stdout,
6272 stderr as part of an array, because that doesn't always work.
6274 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6276 The SAVE procedure didn't save long string variables properly.
6277 Fixed by this patch. Thanks to Hankin
6278 <hankin@rogue.consultco.com> for this patch.
6280 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6281 out variable pad records.
6283 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6285 Previously, if PRINT SPACE were given a negative argument, it
6286 would report an error, then spin in an (almost) infinite loop.
6287 This fixes that behavior.
6289 * print.c: (print_space_trns_proc) After reporting a negative
6290 argument, set number of lines to print to 1.
6292 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6294 SPSS 8.0 outputs some new record types in its system files, and it
6295 allows longer value labels. Accept these system files.
6297 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6298 11 emitted by SPSS 8.0.
6300 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6302 The LIST procedure was too conservative in allocating space for
6303 buffers, which caused a bug that only showed up with very long
6304 output variables. Thanks to Hankin <hankin@dunno.com> for this
6307 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6309 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6311 Typo meant string format specifiers weren't checked properly. I
6312 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6313 willing to be corrected on this point.
6315 * format.c: (check_string_specifier) Fix obvious typo.
6317 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6319 Using $CASENUM in an expression didn't work. Here's a fix.
6320 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6323 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6325 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6327 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6329 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6330 other behavior, *sigh*. This patch hopefully fixes that. This
6331 time I've actually tested it.
6333 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6335 * data-list.c: (read_from_data_list_free,
6336 read_from_data_list_list) Call parse_string_as_format() directly
6337 without mucking around with the field width.
6339 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6341 Occasionally, you may encounter a script that wants to be
6342 interpreted in interactive mode. Make -i emulate this behavior to
6343 allow such scripts to be executed with PSPP.
6345 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6347 * cmdline.c: (pre_syntax_message[]) Update -i description.
6349 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6350 when -i is given on the command line) don't treat unindented lines
6351 as starting a new command.
6353 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6355 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6356 mostly caused by local initialized aggregates. After egcs is
6357 fixed upstream these can be removed, but for now they're not a big
6360 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6361 initialized arrays. Avoid this.
6363 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6366 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6368 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6369 following changes avoid. Currently I compile sources with egcs
6370 1.1.1 and gcc 2.7.2.3 before sending them out.
6372 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6374 * ascii.c: (option_tab[]) Initialize all struct members.
6376 * avl.h: (avl_traverser_init) New macro.
6378 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6381 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6384 * hash.c: Comment fix.
6386 * hash.h: (hsh_iterator_init) New macro.
6388 * html.c: (option_tab[]) Initialize all struct members.
6390 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6393 * postscript.c: (option_tab[]) Initialize all struct members.
6394 (output_encodings, preclose, dump_lines) Use new
6395 hsh_iterator_init() macro.
6397 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6400 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6403 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6405 * data-in.c: Examined each of the parsing functions to make sure
6406 that they wouldn't dump core if they were passed a string of the
6407 wrong length, since now the DATA LIST FREE/LIST routines don't
6408 check for field width before passing it to the data parser.
6409 (parse_RBHEX, parse_AHEX) Reject odd length input.
6410 (parse_string_as_format) Reject input that's too short or too
6413 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6414 a field to its entire declared output width then pass it to the
6415 data-in parsing routines. This contradicted the documented
6416 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6417 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6418 free-format parsing that differed from SPSS.
6419 (cut_field) Commas and spaces are treated identically. Returns
6420 the proper column instead of a fixed 1 value.
6421 (parse_field) Removed.
6422 (read_from_data_list_free, read_from_data_list_list) Call
6423 parse_string_as_format directly instead of parse_field.
6425 * heap.c: (heap_delete) Stylistic fixes.
6427 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6429 * loop.c: (loop_2_trns_proc) Formatting fix.
6431 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6433 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6435 * vfm.c: (macro FILTERED) New.
6436 (static var filter_var) New.
6437 (process_active_file_write_case) Use FILTERED.
6438 (setup_filter) Set filter_var.
6439 (close_active_file) Delete the filter if not
6440 FILTER_before_TEMPORARY.
6441 (procedure_write_case) Use FILTERED.
6443 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6445 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6447 * data-in.c: (parse_day_count) Message fix.
6448 (parse_month) Style fix.
6450 * data-list.c: (struct data_list_pgm) New member eof.
6451 (cmd_data_list) Init eof to 0.
6452 (do_reading) Implement the /END subcommand and read-past-eof
6455 * do-if.c: Include stdio.h when debugging.
6456 (cmd_else_if) Make sure the command is .-terminated.
6458 * glob.c: (init_glob) Capitalize the command prompt.
6460 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6461 (end_file_trns_proc) Debugging message.
6463 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6465 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6467 * main.c: (dump_token) Make kwtab[] const.
6469 * set.q: Spelling, comment fixes.
6471 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6474 * vars-prs.c: (fill_all_vars) Style fix.
6476 * vfm.c: (index_to_varname) Return const.
6478 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6480 * Changes in many source files for partial -ansi -pedantic and
6481 no-debugging compliance: Remove trailing common in enum
6482 declarations; add `unused' attributes; insert some appropriate
6485 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6487 * command.c: (shell) Make static.
6488 (run_command) Make static.
6490 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6492 * dfm.c: (cmd_begin_data) I18n fix.
6494 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6496 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6498 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6501 * file-handle.q: Don't prepend the source file directory name to
6502 the data file name. (Ongoing issue.)
6503 (prepend_current_directory) Comment out.
6504 (internal_cmd_file_handle) Don't call prepend_current_directory().
6505 (fh_get_handle_by_filename) Ditto.
6507 * filename.c: Append zero byte to readlink() return value.
6509 * getline.c: (getl_read_line) I18n fix.
6511 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6513 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6515 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6518 * postscript.c: (output_encodings) Don't use local_strdup().
6521 * print.c: Don't use gcc features if __STRICT_ANSI__.
6523 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6525 * recode.c: (parse_src_spec) Fully brace nested if's.
6527 * set.q: (global var set_testing_mode) New var.
6529 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6531 * ascii.c: Add some more `unused' attributes that only come into
6532 play when NDEBUG is defined.
6533 (ascii_close_page) Set s_len when reallocating s.
6535 * crosstabs.q: (delete_missing) New function.
6536 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6537 (make_summary_table) Create summary table reallocable.
6539 * postscript.c: Add more `unused' attributes as above.
6541 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6542 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6544 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6547 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6548 gratuitous space between parameter definition.
6550 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6551 complaints about running off the end of functions with NDEBUG
6554 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6556 * Several source files: Removed some PORTME notes when reflection
6557 revealed that ANSI forbids that sort of breakage. Also, added
6558 lots of `unused' qualifiers here and there.
6560 * aggregate.c: (accumulate_aggregate_info) Remove local var
6561 weighting that turned out not to be used.
6563 * avl.c: Update to version 1.1.0. Add unused specifier.
6564 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6566 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6567 (avl_find) Cast return value to void *.
6568 (avl_delete) q doesn't need to be initialized at the beginning of
6569 the function. Replace some instances of 1 with +1.
6570 (force_avl_delete) Renamed avl_force_delete, all references changed.
6571 (compare_ints) `param' marked unused.
6572 (print_int) `param' marked unused.
6573 (recurse_tree) Replace some instances of 1 with +1.
6575 * avl.h: Update to version 1.1.0. Only declares avl function
6576 types if not already declared.
6577 (AVL_MAX_HEIGHT) Only define if not already defined.
6578 (struct avl_node) New unused member char pad[2].
6579 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6580 (force_avl_insert) Renamed avl_force_insert.
6581 (force_avl_delete) Renamed avl_force_delete.
6583 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6585 (struct crosstab) Add new member `ofs'.
6586 (glob var int_tab) Removed.
6587 (custom_tables) In integer mode, assign v[i] properly through the
6589 (custom_variables) Now p.crs.max == max + 1.
6590 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6591 (precalc) Implement integer mode.
6592 (calc_integer) Implement integer mode.
6593 (compare_table_entry) Remove unused local variable `comparing'.
6594 (make_summary_table) Implement integer mode.
6595 (macro ns_rows) Implemented as static variable now.
6596 (several variables) Made static, from global.
6597 (output_pivot_table) Use table_value_missing() for column heads.
6598 Remove several unused local variables. Implement integer mode
6599 table summing. Count up ns_rows.
6600 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6601 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6602 calls that function or find_pivot_extent_integer.
6603 (find_pivot_extent_integer) New function.
6604 (enum_var_values) Implemented for integer mode.
6605 (table_value_missing) New function.
6606 (display_dimensions) Call table_value_missing() for heads.
6607 (float_M_suffix) New function.
6608 (display_crosstabulation) Call table_value_missing() for row
6609 heads. Handle missing values in /MISSING=REPORT mode.
6610 (calc_fisher) Remove unused var N.
6611 (calc_r) Remove unused var fact.
6613 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6614 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6616 * data-out.c: (insert_commas) Remove unused var cp.
6617 (convert_CCx) Remove unused vars save_set_decimal,
6620 * descript.q: (dump_z_table) Fix table dimensioning.
6621 (pre_calc) Remove unused var j.
6622 (display) Remove unused vars title, s. Fix table dimensioning.
6624 * expr-evl.c: Comment fixes.
6626 * frequencies.q: (full_dim) New function.
6627 (dump_full) Fix table dimensioning.
6628 (condensed_dim) New function.
6629 (dump_condensed) Fix table dimensioning.
6631 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6634 * html.c: (html_close_drive) Remove unused var i.
6635 (postopen) Remove unused vars title, curfn_len, cp.
6636 (preclose) Remove unused vars this, x.
6638 * lexer.c: Comment fixes.
6640 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6642 * means.q: (custom_tables) Remove unused var m_dim.
6644 * mis-val.c: Format fix.
6646 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6648 * output.c: (outp_get_paper_size) Remove unused var cp.
6650 * pfm-read.c: (read_float) Remove unused var save, unused label
6652 (read_variables) Remove unused vars cp, j.
6653 (read_value_label) Remove unused var j.
6655 * pfm-write.c: (bufwrite) Remove unused var i.
6657 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6659 (output_encodings) Remove unused vars char_cp, n_output.
6660 (read_ps_encodings) Remove unused var ep.
6661 (postopen) Remove unused var title.
6662 (preclose) Remove unused var fp.
6663 (ps_open_page) Remove unused vars true, false, orientation,
6664 mirror_horz, mirror_vert, width, length.
6665 (ps_text_metrics) Remove unused var x.
6667 * q2c.c: (find_symbol) Remove unused var y.
6668 (parse_setting) Remove unused parameter sbc, all references
6670 (dump_parser) Remove unused var cp.
6671 (dump_free) Remove unused var i.
6673 * set.q: (static vars args, n) Removed.
6674 (internal_cmd_gset) Removed.
6676 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6677 (read_machine_flt64_info) Removed unused var file_endian.
6678 (read_documents) Removed unused var i.
6679 (read_compressed_data) Removed unused parameter dict, all
6682 * sfm-write.c: (bufwrite) Removed unused var i.
6683 (sfm_write_case) Removed unused var i.
6685 * sort.c: (merge_once) Remove unused var t.
6686 (write_separate) #if 0 out as dead code.
6688 * split-file.c: (cmd_split_file) Remove unused var i.
6690 * sysfile-info.c: (sysfile_info_dim) New function.
6691 (cmd_sysfile_info) Fix table dimensioning.
6692 (variables_dim) New function.
6693 (display_variables) Fix table dimensioning.
6694 (describe_variable) Remove unused var prev_r.
6696 * t-test.q: (z_postcalc) Removed.
6697 (pairs_calc) Remove unused var bad_weight.
6698 (postcalc) Remove unused vars dfn, dfd.
6700 * tab.c: (tab_create) Set t->dim to NULL.
6701 (tab_dim) Make sure t->dim is NULL first.
6702 (tab_natural_width) Remove parameter `clamp'.
6703 (tab_value) Remove duplicate assertion for table.
6704 (tab_raw) New function.
6705 (nowrap_dim) New function.
6706 (wrap_dim) New function.
6707 (tab_output_text) Fix table dimensioning.
6709 * tab.h: (tab_raw) New macro.
6711 * val-labs.c: (get_label) Remove unused var type.
6712 (copy_value_labels) Remove unused var trav.
6714 * var.h: (struct crosstab_proc) Completely changed.
6716 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6718 * vfm.c: (open_active_file) Remove unused vars i, lp.
6720 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6722 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6724 * Makefile.am: Add apply-dict.c, flip.c.
6726 * apply-dict.c: New file.
6728 * command.c: (struct command) Make cmd[] larger for CLEAR
6729 TRANSFORMATIONS command name.
6730 (parse_cmd) Make sure we're in a valid state before using it as an
6731 index. Discard variables and reset state on invalid transitions.
6732 (cmd_clear_transformations) New function.
6734 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6735 Add unimplemented PRESERVE, RESTORE.
6737 * file-handle.h: Include stddef.h.
6741 * pfm-read.c: (parse_value) Pad value label values with spaces,
6744 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6745 (sfm_close) Decrement reference count, make sure it's zero.
6746 (sfm_maybe_close) New function.
6747 (sfm_read_dictionary) Handle reference counts.
6749 * vars-atr.c: (clear_default_dict) New function.
6750 (discard_variables) Use clear_default_dict().
6752 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6754 * Makefile.am: Add pfm-write.c.
6755 (LDADD) Add the libgmp2 libraries.
6757 * command.def: Define EXPORT.
6759 * get.c: (cmd_export) New function.
6760 (export_write_case_func) New function.
6762 * pfm-read.c: (static spss2ascii[]) Make it const.
6764 * pfm-write.c: New file.
6766 * sfm-write.c: Formatting, comment fixes.
6768 * var.h: Comment fix.
6770 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6772 * Makefile.am: Add pfm.h, pfm-read.c.
6774 * command.def: IMPORT is now implemented.
6776 * format.c: (glob var translate_fmt[]) New var.
6778 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6779 (cmd_import) New function.
6780 (import_source_read) New function.
6781 (glob var import_source) New var.
6783 * pfm-read.c: New file.
6787 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6789 (dump_dictionary) Disabled printing a couple of items.
6791 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6793 * crosstabs.q: (postcalc) Call make_summary_table().
6794 (make_summary_table) New function.
6795 (insert_summary) New function.
6796 (display_dimensions) Remove some unnecessary arguments, all
6798 (output_pivot_table) Fix lots of problems with the risk table
6800 (submit) Don't display an empty table.
6801 (display_risk) Fix order of arguments to calc_risk().
6803 * glob.c: Always include assert.h and stdlib.h.
6805 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6808 * tab.c: (tab_create) Cosmetic changes.
6810 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6812 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6816 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6817 code simplified, moved into new function submit().
6818 (submit) New function.
6819 (crosstabs_dim) New function.
6820 (display_directional) Substitute variable names for %s where
6822 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6823 (calc_symmetric) Initialize parameters only if non-NULL.
6824 Calculate Somers' d.
6825 (calc_directional) Calculate Somers' d (or copy it, really).
6828 * output.c: (outp_string_width) New function.
6830 * postscript.c: (postopen) Calculate font widths based on the
6831 width of the zero '0' character, not the width of the space
6832 character. Set paper-width and paper-length based on points, not
6834 (ps_open_page) Fix page setup string for landscape mode.
6836 * som.h: (struct som_dimension) Removed.
6837 (struct som_table_class) height, width members take int * not
6840 * tab.c: Many functions now have added parameter validation.
6841 (tab_height, tab_width) These functions were removed and merged
6842 into a single function tab_resize(), and all references changed.
6843 (tab_dim) Rewritten since the interface changed; reduced from
6844 hundreds of lines to two. All callers were changed. Currently
6845 most of them just use tab_natural_dimensions as their callback and
6846 await detailed translation of functionality.
6847 (tab_natural_width) New function.
6848 (tab_natural_height) New function.
6849 (tab_natural_dimensions) New function. This is a callback
6850 function, not something that you'd want to call directly.
6851 (tab_nat_dim) Removed.
6852 (tabi_table) Allocates t->w and t->h.
6853 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6854 dimensions callback.
6855 (evaluate_dimensions) Removed.
6856 (sum_columns) Removed.
6858 * tab.h: (enum TAL_1THIN) Removed.
6859 (enum series t_*) Removed.
6860 (struct tab_table) Members trh, trv changed to unsigned char *
6861 from int *. Member dim changed to a function pointer from a
6862 unsigned char *. Member max_stack_height removed. New members
6864 (macros tab_l, tab_r, tab_t, tab_b) New.
6866 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6868 * ascii.c: (delineate) Assign last_space_nchars before skipping
6869 spaces, to fix right justification.
6871 * crosstabs.q: (static vars risk, direct) New vars.
6872 (static var pearson_r) Removed.
6873 (glob var chisq_fisher) Made static.
6874 (static vars row_tot[], col_tot[]) Don't include grand total
6876 (static var grand_total) Renamed W, all references changed.
6877 (output_pivot_table) Only make `table' if num_cells != 0. Make
6878 risk and directional tables. Deal with grand total no longer part
6879 of col_tot[]. Free rows and cols after we're done with them.
6880 (display_risk) New function.
6881 (display_directional) New function.
6882 (clac_r) Rewritten so that it stores all its results into its
6883 arguments, so it can be used for Spearman's correlation too.
6884 (calc_symmetric) Added a t[] argument, all references changed.
6885 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6886 Pearson's r, Cohen's kappa.
6887 (calc_risk) New function.
6888 (calc_directional) New function.
6890 * som.c: (som_submit) Improved debugging code.
6892 * stats.c: (hypercube) New function.
6893 (cube) New function.
6895 (normal_sig) Went back to old implementation, which actually
6898 * stats.h: (macros square, cube, hypercube) Removed. The
6899 equivalent functions in stats.c are inlined here; all references
6900 to square changed to sqr.
6902 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6904 * crosstabs.q: (N_SYMMETRIC) New define.
6905 (postcalc) Disable debug printing.
6906 (static vars chisq_fisher, pearson_r) New.
6907 (output_pivot_table) Add support for symmetric measures. Add
6908 chi-square output of exact sigs.
6909 (display_chisq) Rewritten.
6910 (display_symmetric) New function.
6911 (gamma_int) New function.
6913 (swap) New function.
6914 (calc_fisher) New function.
6915 (calc_chisq) Check boundary conditions better. Calculate Yates,
6916 Fisher, Mantel-Haenszel tests.
6917 (calc_r) New function.
6918 (calc_symmetric) New function.
6920 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6922 (chisq_sig) Better boundary conditions. Renamed from
6925 * tab.h: (struct tab_table) New member cf.
6927 * tab.c: (tab_create) Set cf.
6928 (tab_width) New function.
6929 (tab_realloc) Handle cf.
6930 (tab_vline) Handle cf.
6931 (tab_hline) Handle cf.
6932 (tab_box) Handle cf.
6933 (tab_value) Handle cf.
6934 (tab_float) Handle cf.
6935 (tab_text) Handle cf.
6936 (tab_joint_text) Handle cf.
6937 (tab_offset) Handle cf.
6938 (tab_next_row) Handle cf.
6939 (evaluate_dimensions) Handle cf.
6940 (render_strip) Handle cf.
6942 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6944 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6945 output_pivot_table().
6946 (output_pivot_table) Moved lots of local variables outside and
6947 made them static. Add beginnings of chi-square statistic
6948 support. Now column and row totals aren't in the main matrix.
6949 Always zero out any leftover rows & columns after we're done with
6950 the table entries. Move all output stuff into
6951 display_dimensions(), display_crosstabs(), display_chisq().
6952 (display_dimensions) New function.
6953 (display_crosstabulation) New function.
6954 (display_chisq) New function.
6955 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6957 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6958 references, simplify logic.
6960 * postscript.c: Remove scale, translate-x, translate-y,
6961 mirror-horz, mirror-vert, rotate-180 options.
6962 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6963 All references deleted.
6964 (macro YT) New macro.
6965 (array option_tab[]) Removed options.
6966 (ps_option) Removed options.
6967 (ps_open_page) Write page setup explicitly to output file, without
6968 using now-deleted BP function.
6969 (macro dump_line) Use YT().
6970 (macro dump_thick_line) Use YT().
6971 (draw_headers) Use YT().
6972 (switch_font) Reorder arguments to SF function.
6973 (write_text) Use YT().
6975 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6978 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6980 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6981 null-debugging code.
6982 (tab_realloc) Remove null-debugging code. Initialize new regions
6984 (tab_vline) Support offsets.
6985 (tab_hline) Support offsets.
6986 (tab_box) Support offsets.
6988 (tab_nulls) Removed.
6991 (evaluate_dimensions) Remove null-debugging code. Understand
6992 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6993 TAB_EMPTY not present.
6995 * tab.h: New cell attribute TAB_EMPTY.
6996 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6998 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6999 try to read them from system files.
7001 * vfm.c: (dump_splits) Don't call tab_null().
7003 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7005 * crosstabs.q: (struct crosstab) Added `missing' member.
7006 (custom_tables) Init missing.
7007 (calc_general) Handle missing values.
7008 (calc_chisq) New function.
7009 (output_pivot_table) Start work on chi-square output. Update for
7010 new tab offset support functions. Shorten statistic names.
7012 * Several files: add in more `const's to placate gcc's warnings.
7014 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7017 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7018 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7019 tab_joint_text) Add col_ofs and row_ofs support.
7020 (tab_offset) New function.
7021 (tab_next_row) New function.
7022 (tab_row) New function.
7023 (tab_col) New function.
7024 (tabi_table) Add col_ofs and row_ofs support.
7026 * vars-atr.c: (is_system_missing) New function.
7028 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7030 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7031 (static var no_cells) Removed.
7032 (static var num_cells) New.
7033 (static var expected) New.
7034 (static var cells[]) New.
7035 (internal_cmd_crosstabs) Deal with new variables.
7036 (postcalc) Removed most of the meat and put it in new function
7037 output_pivot_table().
7038 (output_pivot_table) Calculates and outputs an entire pivot table.
7040 * postscript.c: (postopen) Fix problems with free()ing addresses
7041 not obtained from malloc().
7043 * som.c: (som_submit) Add assertion.
7045 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7048 * tab.c: (static var tab_names[]) New.
7049 (tab_realloc) -1 for nc or nr indicates no change.
7050 (tab_nulls) New function.
7051 (tab_dim) Use tab_names[].
7052 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7053 (evaluate_dimensions) Don't terminate on uninited cells, just put
7054 an X in them and emit a notice. Use tab_names[].
7056 * tab.h: Move bits into tab.def.
7058 * tab.def: New. Don't try to declare tab_table_class because then
7059 som.h has to be included.
7061 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7063 * command.def: New file, contains all the command definitions
7064 previously included bodily in command.c.
7066 * format.def: New file, contains all of the format definitions
7067 previously split across format.h, format.c, and sfm-write.c.
7069 * lexer.h: Renamed from tokens.h in order to match corresponding
7072 * lexerP.h: Moved some rarely used functions exported by lexer.c
7075 * Makefile.am: Commemorate renamed files.
7076 (EXTRA_DIST) Add command.def, format.def.
7078 * command.c: [0] (walk_cmdtable_func) Removed.
7080 * crosstabs.q: (postcalc) Made it work and print out matrices
7082 (enum_column_values) Renamed enum_var_values, generalized for any
7085 * format.h: (struct fmt_desc) New member `spss'.
7087 * q2c.c: (main) Generated code includes lexer.h instead of
7090 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7091 instead of an independent translation table.
7093 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7095 * Lots of source files: Added const to declarations.
7097 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7099 * arena.c: (arena_clear) Set prev pointer to null when done.
7101 * ascii.c: (ascii_option) Rename index as indx.
7103 * avl.c: This is now a separate library called libavl.
7104 (xmalloc) Make static.
7105 (avl_probe) Step A7 can use the cache instead of an explicit
7107 (avl_delete) Don't maintain a q pointer because it's always
7108 available in the pointer stack. Comment fix.
7110 * avl.h: This is now a separate library called libavl.
7112 * command.c: (cmd_table[]) Remove spurious trailing "".
7114 * common.h: Only include random() fix if this system needs it.
7116 * crosstabs.q: Include alloca headers.
7117 (n_sorted_tab) New global var.
7118 (postcalc) Mostly rewritten.
7119 (find_pivot_extent) Rewritten.
7120 (enum_column_values) Rewritten.
7122 * data-out.c: (convert_F) Rename inner n as n_spaces.
7124 * error.c: (dump_message) Don't have an outer var i.
7126 * file-handle.q: (static var f) Removed. All references removed.
7127 (internal_cmd_file_handle) Uses a local variable instead of f.
7129 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7130 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7133 * getline.h: Declare getl_history as extern. Reported by
7134 palme@uni-wuppertal.de (Hubert Palme).
7136 * postscript.c: (postopen) Some large mods for constness.
7138 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7141 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7143 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7144 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7147 * avl.c, avl.h: New files. These form a clean-room
7148 reimplementation of avllib. Iterative algorithms are used in
7149 place of recursive ones, so there is no resemblance in the code.
7151 * Lots of headers: Don't include other headers by default.
7153 * Lots of source files: Explicitly include all needed headers.
7155 * arena.c: (arena_clear) New function.
7157 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7158 (static var ar) Removed.
7159 (staitc vars ar_tc, ar_col) New.
7160 (cmd_crosstabs) Destroy the arenas.
7161 (internal_cmd_crosstabs) Create the arenas.
7162 (precalc) Don't need a free function for the hash.
7163 (calc_general) Make sure to zero out the trailer on the key data
7165 (print_table_entries) Updated.
7166 (postcalc) Worked on actually implementing.
7167 (find_pivot_extent) New function.
7168 (compare_value) New function.
7169 (enum_column_values) New function.
7171 * data-in.c: (parse_month) Make local array `static const'.
7173 * data-out.c: (convert_date) Make local array `static const'.
7174 (convert_WKDAY) Same.
7175 (convert_MONTH) Same.
7177 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7178 been renamed to avl_walk().
7180 * hash.c: Rewritten more efficiently.
7182 * hash.h: Add attribute const to hsh_next_prime declaration.
7184 * lexer.c: (id_match) Make arguments const.
7186 * postscript.c: (ps_postopen_driver) Make default fonts the
7189 * q2c.c: (main) Generated code needs stdlib.h.
7191 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7192 initialized to 0 now, not to NULL. All other references to
7193 avl_traverser were updated in the same way.
7195 * tokens.h: Macro version of id_match updated to use const
7198 * val-labs.c: (inc_ref_count) New function.
7199 (copy_value_labels) Simply through use of new avl_copy() function.
7201 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7203 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7204 (postcalc) Worked on this.
7206 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7207 (struct ps_driver_ext) New line_width_thick member.
7208 (ps_preopen_drive) Init line_width_thick.
7209 (option_tab[]) Add line-* options.
7210 (ps_option) Parse line-* options.
7211 (postopen) Add line_width_thick support. Strip leading spaces on
7212 prologue output lines.
7213 (ps_open_page) Include line_width_thick in output.
7214 (macro dump_thick_line) New.
7215 (dump_fancy_line) Support thick lines as well as double lines.
7217 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7219 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7220 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7222 * Many source files: Rename `options' to `pv_opts' as appropriate.
7224 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7226 * common.c: (xcalloc) New function.
7228 * crosstabs.q: New file. Not finished yet, though.
7230 * data-list.c: Comment fix.
7232 * error.c: Remove some old Checker cruft.
7234 * frequencies.q: (dump_full) Cumulate valid percent instead of
7237 * getline.c: Comment fix.
7239 * hash.c: Comment fixes.
7241 * hash.h: (struct hsh_table) Make hash functions return unsigned
7242 instead of int to avoid problems with taking the modulo of
7243 negative return values. All references changed.
7245 * misc.c: (intlog10) Make its table static const instead of auto.
7247 * sfm-read.c: (read_header) Make `prefix' static const instead of
7250 * var.h: (union value) Add member `hash'.
7251 (struct variable) Rename prv_index as `foo'--all references
7253 (typedef pv_opts) Removed. All references changed.
7255 * vars-prs.c: (parse_variables) Message fixes.
7257 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7259 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7260 they are being inserted. Don't check for BY variables of
7261 different types. Discard variables if the active file isn't
7262 included in the merge.
7263 (mtf_processing) Essentially rewritten.
7264 (mtf_merge_dictionary) Check for master/slave variables of
7265 different types/widths.
7267 * vfm.c: (static var not_canceled) New var.
7268 (process_active_file) Don't call vfm_source->read() if
7269 there's no vfm-source. Initialize not_canceled.
7270 (process_active_file_write_case) Honor and update not_canceled.
7271 (prepare_for_writing) Rollback changes from yesterday, they were
7273 (close_active_file) Don't destroy vfm_source unless it exists.
7275 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7277 * Lots of source files: Added { } around nested if/else constructs
7278 to avoid new gcc 2.8 warnings.
7280 * data-in.c: (parse_Z) Declare `int' type explicitly.
7283 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7284 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7285 prev members. Put TABLEs at the end of the chain and FILEs at the
7286 beginning. Don't allow the active file in STATE_INIT. Use proper
7287 `seen' value for the active file. Fill out the by members and
7288 make sure they're of consistent type. Do the actual merge
7290 (mtf_processing_finish) New function.
7291 (var_type_description) New function.
7292 (mtf_free_file) New function.
7293 (mtf_free) Rewritten.
7294 (mtf_delete_file_in_place) New function.
7295 (mtf_read_nonactive_records) New function.
7296 (mtf_compare_BY_values) New function.
7297 (static var mtf_seq_no) New var.
7298 (mtf_processing) New function.
7299 (mtf_merge_dictionary) Assign nval members for the system file
7300 dictionary. Assign fv values for its variables. Point each slave
7301 variable to the corresponding master variable.
7303 * hash.c: Include str.h.
7305 * mis-val.c: (copy_missing_values) src arg is const.
7307 * misc.c: (spacing) Make `max' var explicitly int.
7309 * sfm-read.c: (dump_dictionary) Message reformatting.
7310 (sfm_read_case) Add assertion.
7312 * sort.c: Esthetic fixes.
7314 * var.h: (struct match_files_proc) New struct.
7315 (struct variable) Add private data match_files_proc.
7317 * vars-atr.c: (delete_variable) Implement. Add argument for the
7318 dictionary that owning the variable.
7319 (dup_variable) Add assertion.
7321 * vfm.c: Comment fixes, hopefully the comments are correct now.
7322 (process_active_file) New function.
7323 (process_active_file_write_case) New function.
7324 (process_active_file_output_case) New function.
7325 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7327 (write_case) Renamed procedure_write_case(). Now write_case is a
7328 pointer to a function. Style fixes.
7330 1998-03-05 Ben Pfaff <blp@gnu.org>
7332 * Makefile.am: (q2c) Link with libmisc.
7333 (version.c) Define default_config_path, include_path,
7336 * ascii.c: (ascii_postopen_driver) When the default newline string
7337 is requested, open file in text mode. Suggested by
7338 palme@uni-wuppertal.de (Hubert Palme).
7339 (static vars line_buf, line_p) Change from char * to unsigned char
7341 (ascii_close_page) char * to unsigned char *.
7343 * cmdline.c: (parse_command_line) Implement -r option by
7344 prepending ~/.pspp/rc to the list of files to process.
7346 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7347 before pulling in a final line.
7348 (null_func, null_int_func) Removed (dead code).
7350 * descript.q: (display) Calculate width of variable name column
7351 properly. Calculate number of valid cases properly. Reported by
7352 palme@uni-wuppertal.de (Hubert Palme).
7354 * filename.c: (init_filename) Use default_config_path instead of
7355 now obsolete CONFIG_PATH.
7357 * getline.c: (getl_initialize) Use include_path instead of now
7358 obsolete INCLUDE_PATH.
7359 (getl_add_file) New argument `where'. All references changed.
7361 * groff.c: (find_font_file) Use groff_font_path instead of now
7362 obsolete GROFF_FONT_PATH.
7364 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7365 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7366 avoid problems with constness.
7368 * str.h: (macro cs_streq) New macro.
7370 * version.h: (glob var default_config_path, include_path,
7371 groff_font_path) New vars.
7373 1998-02-23 Ben Pfaff <blp@gnu.org>
7375 * Many source files: Change verbose_msg() priority levels and
7378 * aggregate.c: Include debug-print.h.
7380 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7382 (static var pre_syntax_message) Document --safer/-s and
7385 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7387 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7388 because it's not used but it's still copied.
7389 (open_file_r) Remove gratuitous debug message.
7391 * filename.c: (safety_violation) New function.
7392 (open_file) Remove gratuitous debug messages. Don't allow pipe
7393 files if set_safer is set.
7395 * get.c: Turn off debugging.
7397 * getline.c: (getl_add_virtual_file) New function.
7398 (getl_read_line) Add verbose_msg() call for opening new syntax
7400 (getl_perform_delayed_reset) Add a return value describing whether
7401 any action was taken. Call reset_eof().
7403 * getline.h: Comment fix.
7405 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7406 place of incorrect `continue'. Use strtok_r() instead of
7407 strtok(). Always check strtok_r() return value.
7408 (groff_read_DESC) Use strtok_r() instead of strtok().
7410 * lexer.c: (reset_eof) New function.
7412 * main.c: (parse) Get a token after performing a delayed reset
7413 action; allow empty syntax files.
7415 * postscript.c: (output_encodings) Use strtok_r() instead of
7418 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7420 * set.q: Comment fixes.
7421 (glob var set_safer) New var.
7422 (internal_cmd_set) Support SAFER.
7424 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7426 * temporary.c: (free_dictionary) Set d->splits to NULL after
7429 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7430 variable deleted, not if it *isn't* deleted.
7432 1998-02-16 Ben Pfaff <blp@gnu.org>
7434 * command.c: (array cmd_table[]) Add MATCH FILES.
7436 * common.c: Comment fixes.
7438 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7439 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7440 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7443 * expr-opt.c: Include str.h. Problem reported by
7444 palme@uni-wuppertal.de (Hubert Palme).
7446 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7447 (static var mtf_by) Change from char ** to variable **.
7448 (static var mtf_master) New var.
7449 (mtf_merge_dictionary) New function.
7450 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7451 var type. Reorder tests properly. Initialize file->dict. Detect
7452 TABLE= without BY=. Read file dictionaries and merge them. Give
7453 subcommand name with IN, LAST, FIRST error messages. Create IN,
7454 LAST, FIRST variables. Comment fixes.
7455 (mtf_free) Don't free default_dict. Free mtf_master.
7457 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7459 (handle_line_buffer) Cast int to size_t in comparison to avoid
7462 * getline.h: Declare getl_mode extern.
7464 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7465 (groff_read_DESC) Make line_size a size_t.
7466 (match_tok) Parenthesize name to avoid macro expansion.
7468 * mis-val.c: (copy_missing_values) New function.
7470 * postscript.c: (postopen) Make buf_size a size_t.
7472 * sfm-read.c: (dump_dictionary) Make global from static. Print
7473 variable info in parts for easier debugging with Checker.
7475 * temporary.c: (copy_variable) Use copy_value_labels().
7476 (new_dictionary) New arg: whether to copy file label, documents.
7478 * val-labs.c: (copy_value_labels) New function.
7480 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7482 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7484 (dup_variable) Set prv_index, get.fv, get.nv.
7486 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7488 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7490 * Many source files: For ANSI-compliance, add empty statement
7491 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7492 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7494 * data-in.c: (parse_numeric) Some header files break on
7495 -DBL_MIN_10_EXP because they get a --; add () for safety.
7496 Reported by palme@uni-wuppertal.de (Hubert Palme).
7498 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7499 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7500 (dfm_close) Use close_file_ext.
7501 (open_inline_file) Set file.file to NULL, not file.
7502 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7503 struct and use open_file_ext().
7504 (read_record) Use file.file.
7506 * file-handle.q: (prepend_current_directory) Pass through special
7509 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7510 (normalize_filename) Pass through special filenames.
7511 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7513 (dirname) Rename blp_dirname() because of name conflict on some
7514 OS. All references changed. Reported by palme@uni-wuppertal.de
7516 (is_special_filename) New function.
7518 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7519 (trim_dictionary) Conditionalize some of the options on whether
7520 GTSV_OPT_MATCH_FILES is in *options.
7521 (rename_variables) Don't allow variables to be renamed as scratch
7523 (MTF_*) New enum series.
7524 (struct mtf_file) New struct.
7525 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7527 (cmd_match_files, mtf_free) New functions.
7529 * lexer.c: (match_int) Needed parentheses around name to escape
7530 macro expansion. Reported by Micah Altman
7531 <maltman@www-vdc.fas.harvard.edu>.
7533 * print.c: Needed to include alloca.h. Reported by Micah Altman
7534 <maltman@www-vdc.fas.harvard.edu>.
7536 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7537 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7540 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7541 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7543 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7545 * html.c: (struct html_driver_ext) Move into htmlP.h.
7546 (html_preopen_driver) Initialize cp_x, cp_y.
7547 (html_submit) Implement as call to output_tab_table().
7548 (change_attributes) New function.
7549 (escape_string) New function.
7550 (output_tab_table) New function.
7552 * list.q: (write_all_headers) Add code for writing headers for the
7554 (clean_up) Write out the html close-table tag.
7555 (determine_layout) Ignore html driver.
7556 (list_cases) Write html data.
7558 * som.c: (som_submit) Move more of the code into output_table().
7560 * tab.c: (static var hit) Make a global var and rename tab_hit.
7561 (static var tab_table_class) Make a global var.
7563 * htmlP.h: New file.
7565 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7567 * dump-sysfile.c: Removed.
7569 * html.c: (preclose) Change comment in emitted code.
7571 * matrix-data.c: Debugging off by default. Comment fixes.
7572 (static var container) New var.
7573 (cmd_matrix_data) Create and destroy container. Initialize
7574 is_per_factor[] to 0s. Move code into new function
7575 string_to_content_type(). Require split values to be present in
7576 the data when ROWTYPE_ is explicit. Call specific function, not
7577 general read_matrices().
7578 (string_to_content_type) New function.
7579 (context) Exclude all whitespace, not just spaces.
7580 (mget_token) A dot is a number. Add assertion.
7581 (static var data) Renamed nr_data.
7582 (static var factor_values) Renamed nr_factor_values.
7583 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7584 only specific case. Close data_file before exit.
7585 (fill_matrix) New function.
7586 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7587 printing. Style fixes. Message fixes. Move code into
7589 (read_matrices_without_rowtype) Rename
7590 matrix_data_read_without_rowtype(). Fix off-by-one error on
7591 loops. Allocate nr_data[] memory from arena.
7592 (read_matrices_with_rowtype) Removed.
7593 (read_splits) Renamed nr_read_splits(). Style fixes.
7594 (read_factors) Renamed nr_read_factors().
7595 (dump_cell_content) Comment fixes. Arguments changed. Change
7596 debug printing. All references changed.
7597 (output_data) Renamed nr_output_data().
7598 (static var wr_content) New var.
7599 (struct factor_data) New struct.
7600 (static var wr_data) New var.
7601 (static var wr_current) New var.
7602 (matrix_data_source_destroy_source) Removed.
7603 (read_matrices_with_rowtype) New function.
7604 (matrix_data_read_with_rowtype) New function.
7605 (wr_read_splits) New function.
7606 (compare_factors) New function.
7607 (wr_output_data) New function.
7608 (wr_read_rowtype) New function.
7609 (wr_read_factors) New function.
7610 (wr_read_indeps) New function.
7611 (glob var matrix_data_source) Make destroy_source member NULL as
7614 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7616 * lexer.c: (syntax_error) Give better error message when at end of
7619 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7620 N_SCALAR to output as plain N.
7621 (mdump_token) Change output format.
7622 (context) Fix message output interaction with spaces in input.
7623 (another_token) New function.
7624 (force_eol) Improved error message.
7625 (static var max_cell_index) New var.
7626 (read_matrices) Init `cells'. factor_values is now per-cell.
7627 Init max_cell_index.
7628 (read_data_lines) Replace `compare' local with new `compare' arg.
7629 Debugging messages changed. Only read factors if per_factor.
7630 Propagate error return from read_factors(), force_eol().
7631 Copy N_SCALAR values across the N vector.
7632 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7633 check parentheses manually since we now have is_per_factor[].
7634 Call read_data_lines() with new args. Check for end of data after
7635 looping, using another_token().
7636 (read_factors) Arguments changed. Use max_cell_index to determine
7637 whether to read or compare factors. Message fixes.
7638 (dump_cell_content) New function.
7639 (output_data) Completely rewritten because content types were
7640 supported to be nested inside factor values, not vice versa.
7642 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7644 * lexer.c: (syntax_error) Support formatted varargs messages.
7646 * matrix-data.c: Turn debugging on by default.
7647 (static content_type[]) New array.
7648 (static content_names[]) New array.
7649 (static rowtype_, varname_) New vars.
7650 (static is_per_factor[]) New array.
7651 (static split_values) Moved declaration.
7652 (static n_continuous, first_continuous) New var.
7653 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7654 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7655 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7656 Check for continuous variables.
7657 [DEBUGGING] (debug_print) Remove content_names[].
7658 (mdump_token) New macro.
7659 (mget_token_dump) New function.
7660 (mdump_token) New function.
7661 (context) New function.
7662 (mget_token) Fix messages.
7663 (static var data, split_values, factor_values) New vars.
7664 (read_matrices) Manage split_values, factor_values.
7665 (read_data_lines) New function.
7666 (read_matrices_without_rowtype) Implemented.
7667 (read_splits) Message fixes. Uses `just_read'.
7668 (read_factors) New function.
7669 (output_data) New function.
7670 (matrix_data_source_destroy_source) Close the file handle.
7671 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7674 * str.c: (strpadcmp) Removed.
7676 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7678 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7680 * Lots of source files: Add cast to unsigned character to calls to
7681 tolower() and toupper().
7683 * aggregate.c: Set default_dict.splits to NULL.
7685 * command.c: (static variable tab[]) Add MATRIX DATA.
7687 * data-in.c: Add debugging defines. Formatting fixes.
7689 * expr-opt.c: Formatting fixes.
7691 * lexer.c: (syntax_error) Message fixes.
7693 * matrix-data.c: New enum series.
7694 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7695 split_values, n_factors, factors, cells, pop_n, contents,
7696 n_contents) New vars.
7697 (cmd_matrix_data) Finished implementation.
7698 (compare_variables_by_mxd_vartype) New function.
7699 [DEBUGGING] (debug_print) New function.
7700 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7701 (read_matrices) New function.
7702 (read_matrices_without_rowtype) New function.
7703 (read_matrices_with_rowtype) New function.
7704 (read_splits) New function.
7705 (mget_token) New function.
7706 (force_eol) New function.
7707 [0] (test_tokenizer) New function.
7708 (matrix_data_source_destroy_source) New function.
7709 (glob var matrix_data_source) New var.
7711 * misc.h: Include ieeefp.h if present.
7713 * split-file.h: (cmd_split_file) Changes corresponding to struct
7716 * str.h: Fix memmem prototype.
7718 * temporary.c: (save_dictionary, restore_dictionary,
7719 free_dictionary) Changes corresponding to struct dictionary
7722 * var.h: (MXD_* enums) New enum series.
7723 (struct matrix_data_proc) New struct.
7724 (struct split) Removed.
7725 (struct dictionary) Changed `splits' member from `split *' to
7727 (macro force_create_variable) New macro. Replaced lots of
7728 create_variable()/assert() calls with calls to this macro.
7730 * vars-atr.c: (discard_variables) Changed assertion.
7731 [GLOBAL_DEBUGGING] (force_create_variable) New function
7732 called by the macro of the same name.
7733 (clear_variable) Changes to delete splits from the dictionary
7734 corresponding to struct dictionary changes.
7736 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7737 corrupted variable `index' values in the dictionary passed in
7738 every time this function is called.
7740 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7741 to struct dictionary changes.
7743 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7745 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7747 * command.c: New includes.
7748 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7749 (cmd_erase) New function.
7750 [unix] (shell) New function.
7751 (run_command) New function.
7752 (cmd_host) New function.
7753 (cmd_new_file) New function.
7755 * expr-prs.c: (parse_primary) Message fix.
7757 * inpt-pgm.c: Formatting fix.
7758 (cmd_reread) Implement the FILE subcommand.
7760 * matrix-data.c: New file.
7762 * q2c.c: (dump_header) Change output commenting style.
7764 * weight.c: Comment fix.
7766 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7768 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7770 (buf_10x) Renamed buf_1xx, all references changed.
7771 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7772 cases now implemented).
7773 (create_sysfile) New function.
7774 (agr_11x_func) New function.
7776 * data-in.c: (parse_numeric) Work properly if there's an
7777 explicitly coded decimal point in the data and decimal places are
7778 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7779 <el@linux.lisse.na>.
7781 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7782 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7783 Eberhard W Lisse <el@linux.lisse.na>.
7785 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7786 strerror.c. Bug reported by Alexandre Oliva
7787 <oliva@dcc.unicamp.br>.
7789 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7790 (static var separate_case_tab) New var.
7791 (cmd_sort_cases) Cancel temporary transformations here. Free
7792 v_sort before return.
7793 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7794 we're reading from a sort stream. Don't cancel temporary
7795 transformations. Offload internal sorting to do_internal_sort().
7796 (do_internal_sort) New function. Handles internal sorting even
7797 when SEPARATE is nonzero. Doesn't free v_sort.
7798 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7800 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7801 sink if SEPARATE is zero.
7802 (read_output_cases) Renamed read_sort_output(), all references
7803 changed. Now uses separate_case_tab when it exists.
7804 (write_separate) New function.
7806 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7807 memory_sink_cases. Don't redundantly call
7808 vfm_source->destroy_source().
7809 (memory_stream_mode) After switching over, set memory_sink_cases
7812 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7814 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7816 (static var prev_case) New, moved out of aggregate_single_case()
7818 (static var buf64_10x, buf_10x) New.
7819 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7820 the 000, 001, 100, and 101 cases. Free prev_case.
7821 (parse_aggregate_functions) Disallow scratch variables.
7822 (free_aggregate_functions) Only free agr_dict if non-null. Use
7823 iter->function to determine numeric/string type, not
7825 (aggregate_single_case) Don't manage prev_case. Initialize
7826 aggregate info after dumping it.
7827 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7828 mean, stddev, weighted stddev definitions.
7829 (dump_aggregate_info) Implemented.
7830 (initialize_aggregate_info) Renamed from
7831 initialize_aggregate_functions(). Initializes dbl[2].
7832 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7833 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7835 * cases.c: (alloc_val) Removed.
7837 * get.c: (cmd_save_internal) Initialize new `dict' member.
7839 * sfm-write.c: (sfm_write_dictionary, write_header,
7840 write_variable, write_value_labels, write_documents) Reorganize,
7841 simplify for new parameter structure.
7842 (write_variable) Only one variable * argument now.
7844 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7845 replaced by new `dict' member.
7847 * temporary.c: (new_dictionary) Initialize n_documents.
7849 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7851 (init_variable, replace_variable) Eliminate usage of alloc_val().
7853 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7855 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7856 signal that AGGREGATE is to be used for forming final cases.
7857 (close_active_file) Call end_func before stopping lagging. Cancel
7858 temporary after finishing compaction.
7859 (write_case) Comment fixes. Cleaned up.
7860 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7863 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7865 * Makefile.am: (BUILT_SOURCES) Add means.c.
7866 (pspp_SOURCES) Add means.c.
7867 (EXTRA_DIST) Add means.q.
7869 * command.c: (array cmd_table[]) Add MEANS.
7871 * common.h: Esthetic fixes. Comment fixes. Test for
7872 MAX_SHORT_STRING greater than 8.
7873 (macros LOWEST, HIGHEST) New.
7875 * data-in.c, data-list.c, recode.c: Comment fixes.
7877 * means.q: New file, base version.
7879 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7880 with LOWEST, DBL_MAX with HIGHEST.
7882 * q2c.c: (dump_vars) Add an enum to array types giving the number
7883 of values for the enum.
7885 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7886 Replace second_lowest_value with second_lowest_flt64.
7888 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7889 second_lowest_value with second_lowest_flt64.
7891 * t-test.q: Comment fix.
7893 * temporary.c: (restore_dictionary) Esthetic fix.
7895 * tokens.h: (force_match_id, force_match, force_string, force_int,
7896 force_num, force_id) Replace msg() with syntax_error().
7898 * var.h: (struct means_proc) New.
7899 (struct variable) Add mns member to `p' union.
7901 * vars-prs.c: (parse_variable, parse_dict_variable,
7902 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7905 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7907 * Makefile.am: (pspp_SOURCES) Add tab.h.
7909 * Most source files: Added a cast to unsigned char in usages of
7910 the ctype is*() functions. Replaced `end of command expected'
7911 calls to msg() with calls to syntax_error().
7913 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7915 * lexer.c: (hex_val) Removed (was dead code).
7916 (idmatch) Parenthesize function name to avoid macro expansion.
7918 * postscript.c: Comment fixes.
7919 (ps_preopen_driver) Change default font size to 10pt.
7921 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7923 (parse_format_spec) Change system-file format spec argument type
7924 to int32. Parse the format spec with bitwise operators.
7926 * sfmP.h: (struct sysfile_format) Removed.
7927 (struct sysfile_variable) Changed print, write members from
7928 sysfile_format to int32.
7930 * tokens.h: Esthetic fixes.
7931 [__GNUC__] (macro id_match) New macro to hopefully speed up
7932 identifier matching.
7933 (macros match_id, match_tok, match_int) Implemented in
7934 compiler-independent manner; no longer GNU C only.
7936 * vfm.h: Include time.h.
7938 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7940 * data-list.c: (dump_fixed_table) Change tab_dim().
7942 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7944 * error.c: Include command.h.
7946 * frequencies.g: Formatting fixes.
7948 * frequencies.q: Add tab_dim() calls. Make the total cell a
7951 * glob.c: Include command.h.
7953 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7955 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7956 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7957 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7958 the other elements (is this right?).
7959 (read_variables) Use lowest, highest members.
7960 (parse_format_spec) New arg `vv' for more stringent checking.
7961 (dump_dictionary) Byteswaps nonexplicit data.
7962 (sfm_read_case) Byteswap numeric data.
7964 * som.c: Initialize table_num to 1.
7965 (render_segments) Remember to increment y_index after each table
7968 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7969 avl_count() on a NULL tree. No title for the second table.
7970 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7971 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7972 fix call to display_variables().
7973 (display_variables) Default to 4 columns, not 3. Set up headers.
7974 Column title is Variable, not Name. Fix index column.
7975 Add joint text. Add tab_dim(). Handle value labels properly.
7976 Handle DISPLAY LABELS properly. Draw boxes correctly.
7977 (describe_variable) Value labels don't need titles. Don't clear
7978 nonexistent index column.
7979 (compare_vectors_by_name) New function.
7980 (display_vectors) New function.
7982 * tab.c: (tab_height) Add assertion.
7983 (tab_null) Add debug code.
7984 (evaluate_dimensions) Add debug code.
7986 * var.h: (struct variable) get_proc data is sometimes used
7987 simultaneously with other per-procedure info, therefore it was
7988 removed from the union. All references changed.
7990 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7992 * ascii.c: (ascii_close_page) Put title on second line of headers
7993 if there is no subtitle.
7995 * command.c: (glob var cur_proc) Move definition here, from
7997 (cmd_remark) Emit blank line before remarks.
7999 * command.h: (glob var cur_proc) Move declaration here, from
8002 * data-list.c: (dump_fixed_table) Fix messages.
8003 (dump_free_table) Call tab_nat_dim().
8005 * descript.q: (dump_z_table) Modify tab_dim() call.
8007 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8009 (dump_statistics) Don't output header.
8011 * groff-font.c: Minor format fix.
8013 * html.c: Comment fix.
8015 * list.q: (write_varname) Indent after advancing page.
8017 * output.h: Minor reordering.
8019 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8020 a reference to eol[].
8021 (struct ps_driver_ext) New member eol[].
8022 (ps_preopen_driver) Initialize eol[].
8023 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8024 defaults. Handle headers. Fix test for minimum page length.
8025 (static var option_tab[]) Add `line-ends'.
8026 (ps_option) Handle line-ends to change eol[].
8027 (postopen) Scale prop_em_width and fixed_width properly. Set the
8028 prologue title to outp_title if applicable. Replace the prologue
8029 line ends with eol[]. Call draw_headers() if headers are enabled.
8030 (text_width) New function.
8031 (out_text_plain) New function.
8032 (draw_headers) New function.
8034 * print.c: (dump_table) Call tab_nat_dim().
8036 * som.c: (som_blank_line) Only advance a line if not at the top of
8038 (som_submit) Move several informational table calls here.
8039 Increment subtable_num if SOMF_NO_TITLE not set.
8040 (output_table) Advance a line if SOMF_NO_SPACING not set.
8041 (render_columns, render_segments, render_simple) Handle spacing
8042 between tables. Handle table titles. Remove debug output.
8044 * som.h: (SOMF_*) New enum series.
8045 (struct som_table_class) New member `flags'.
8047 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8049 (display_variables) Calls tab_nat_dim().
8050 (describe_variable) Remove restriction on number of value labels.
8051 Make value labels separated by thin lines.
8053 * tab.c: (tab_create) Default `flags' to none.
8054 (tab_float) New arg `w'. All references changed.
8055 (tab_nat_dim) New function.
8056 (tab_output_text) No title or spacing.
8057 (tab_flags) New function.
8058 (tabi_flags) New function.
8059 (tabi_title) New function.
8060 (strip_height) Removed.
8061 (tabi_render) Skip title when necessary.
8062 (static var tab_tab_class) Add tabi_flags, tabi_title.
8063 (evaluate_dimensions) Disable display of column, row size.
8064 (sum_columns) Add title height to top header.
8065 (render_strip) Moved within file.
8067 * tab.h: (struct tab_table) New member `flags'.
8069 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8071 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8073 * Most source files: Add `const' attribute in all appropriate
8076 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8077 column to the variables table for use by describe_variable().
8078 (cmd_display) Disable for the present.
8079 (display_documents) Don't wrap documents.
8080 (display_variables) Table has four columns now.
8081 (describe_variable) Table has four columns now. Don't use a
8082 subtable, use joined cells instead.
8084 * tab.c: (tab_create) Don't set `join'.
8085 (tab_realloc) ct array is not made up of a_string's.
8086 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8087 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8088 (text_format) New function.
8089 (tab_title) Rewritten, uses text_format().
8090 (tab_text) Rewritten, uses text_format().
8091 (tab_joint_text) New function.
8093 (static var hit) New variable.
8094 (render_strip) New args r1, r2. Implement joined cells that fit
8096 (tabi_render) Increment hit. Pass new args to render_strip().
8097 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8098 cells. For t_naw and t_nah, ignore joined cells and null cells in
8101 * tab.h: (struct tab_join_rect) Removed.
8102 (struct tab_table) Removed `join'.
8103 (TAB_JOIN_MAIN) Removed.
8104 (struct tab_joined_cell) New struct.
8105 (TAT_NOWRAP) New enum.
8107 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8109 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8111 (ascii_postopen_driver) Fix initialization of *_spacing so that
8112 the TAL_0 bit doesn't count.
8114 * data-list.c: (dump_fixed_table) Use natural width for Format
8117 * glob.c: (rerange) Removed.
8118 (get_date) Formatting fixes. Internationalization fix.
8120 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8123 * postscript.c: (ps_postopen_driver) Replace
8124 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8126 * som.c: (som_submit) Don't eject page before every table.
8127 (output_table) Fix order of arguments on call to area().
8128 (render_columns) Fix calculation of max_len.
8130 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8131 (render_strip) New function.
8132 (strip_height) New function.
8133 (tabi_render) Rewrite as calls to render_strip().
8135 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8136 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8137 with the TAB_* and OUTP_T_* constants.
8139 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8141 * Makefile.am: Formatting fixes.
8143 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8146 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8148 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8150 * dump-sysfile.c: (glob var length) Make type off_t.
8151 (usage) Fix arguments.
8154 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8155 Now right-justification is the default so many references had to
8157 (struct outp_class) Removed line_width, all references changed.
8158 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8159 (struct outp_driver) Add elements horiz_line_width,
8160 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8163 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8165 (postopen) Initialize all the informational members of
8168 * som.c: (som_blank_line) New function, renamed from blank_line(),
8169 all references changed.
8170 (som_submit) Disables drivers whose pages can't be opened.
8171 (render_columns, render_simple, render_segments) Add debug output.
8172 (render_columns) Fix loop range.
8173 (render_simple) Don't try to render the headers, they're taken
8174 care of automatically. Advance cp_y past the table when done.
8175 (render_segments) Fix loop ranges.
8177 * tab.c: Initialize new members of tab_table.
8178 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8179 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8180 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8183 (tab_dim) New function.
8184 (tab_col_width) Removed.
8185 (tab_row_height) Removed.
8186 (tab_output_text) Call tab_dim().
8187 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8188 (tabi_area) Implemented.
8189 (tabi_cumulate) Implemented.
8190 (tabi_render) Partially implemented, but broken.
8191 (var tab_table_class) Made static.
8192 (evaluate_dimensions) New function.
8193 (sum_columns) New function.
8195 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8196 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8197 t_scr, t_srr, t_sentinel. Removed: t_nat.
8198 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8199 max_stack_height, w, h. Removed: ce, re.
8200 (macro blank_line) Removed.
8201 (glob var zero_length) Removed.
8203 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8205 * Most source files: include some of the new include files broken
8208 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8211 * aggregate.c: (glob var outfile) Make static.
8213 * command.c: (glob var pgm_state) Move here.
8215 * common.c: (glob vars endian, second_lowest_value, pgmname,
8216 finished, curdate, cur_proc, start_interactive, history_file) Move
8219 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8221 * file-handle.q: (glob vars files, inline_file) Move here.
8223 * glob.c: Lost lots of glob vars, detailed in individual file
8225 (init_glob) set_printer, set_screen were obsolete, deleted.
8226 set_cprompt has fewer spaces because pspp has fewer letters than
8229 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8230 (inp_nval) Made static.
8232 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8233 tokstr_len, toklongstr, tokint) Move here.
8235 * misc.c: Lost several vars and functions.
8237 * set.q: (all the set_* variables) Move here.
8239 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8240 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8243 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8245 * tab.h: (enum series t_*) New enums.
8246 (struct tab_table) Use arena struct tag. New members ce, re.
8248 * tokens.h: Comment fixes.
8250 * var.h: Move lots of enums and variables and functions and
8251 structures to other files. Use and declare a lot more union and
8252 struct tags. Comment fixes.
8254 * vector.c: (glob vars vec, nvec) Move here.
8256 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8257 init_blanks, last_vfm_invocation) Move here.
8259 * cases.h: New file.
8260 (struct long_vec) Move here.
8261 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8264 * command.h: New file.
8265 (STATE_* enums) Move here.
8266 (glob var pgm_state) Move here.
8268 * format.c: New file.
8269 (glob var formats) Move here.
8270 (parse_format_specifier_name, fmt_to_string,
8271 check_input_specifier, check_output_specifier,
8272 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8275 * format.h: New file. Move functions now in format.c here.
8276 (FMT_* enums) Move here.
8277 (struct fmt_desc) Move here.
8278 (FCAT_* enums) Move here.
8279 (struct fmt_spec) Move here.
8280 (glob vars formats, fmt_parse_ignore_error) Move here.
8282 * inpt-pgm.h: New file.
8283 (INP_* enums) Move here, make #defines into enums.
8284 (glob vars inp_init, inp_init_size) Move here.
8287 (glob vars v_sort, nv_sort) Move here.
8288 (sort_cases, read_sort_output) Move here.
8290 * vector.h: New file.
8291 (struct vector) Move here, add struct tag.
8292 (glob vars vec, nvec) Move here.
8293 (find_vector) Move here.
8296 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8297 reinit_blanks, init_zero, init_blanks) Move here.
8298 (struct case_stream) Move here.
8299 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8300 vfm_disk_stream, sort_stream, data_list_source,
8301 input_program_source, file_type_source, get_source, n_lag) Move
8303 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8306 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8308 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8309 (LDADD) Add libdcdflib.
8311 * ascii.c: Comment and formatting fixes. Almost every external
8312 function had an assert added, checking driver_open and page_open.
8313 (ascii_init_driver) Broken into ascii_preopen_driver,
8314 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8315 (ascii_open_page) Sets page_open.
8316 (ascii_close_page) Clears page_open.
8318 * html.c: Comment and formatting fixes. Almost every external
8319 function had an assert added, checking driver_open and page_open.
8320 (html_init_driver) Broken into html_preopen_driver,
8321 html_postopen_driver, html_close_driver. Manages driver_open.
8322 (html_open_page) Sets page_open.
8323 (html_close_page) Clears page_open.
8324 (html_submit) Disabled.
8326 * lexer.c: (parse_string) Remove debugging printf.
8328 * list.q: (determine_layout) Open a page if one is not yet open.
8330 * output.c: Comment fixes.
8331 (add_class) Set the class member of the new list element.
8332 (parse_options) Don't handle device type.
8333 (colon_tokenize) New function.
8334 (configure_driver) New four-field format with a field for device
8335 type. Now initialize driver_open, page_open, next, and prev
8336 fields. Use new colon_tokenize() function. Don't do a memory
8337 copy to replace a driver, it doesn't work; instead delete the old
8338 driver and insert a new one.
8339 (destroy_driver) Don't call som_destroy_driver(). Close the page
8340 if it's open. Find the class in the list of classes and decrement
8341 that reference count. Remove the driver from the global driver
8343 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8344 references changed. Rewritten. Don't return a driver that's not
8346 (outp_eject_page) All references to som_internal_eject_page()
8347 changed to use this. Sets cp_x to 0 as well as cp_y.
8349 * output.h: (OUTP_I_* enums) Removed.
8350 (struct som_submission_form) Removed.
8351 (struct outp_class) init_driver broken into preopen_driver,
8352 postopen_driver, and close_driver. submit changed to take a
8355 * postscript.c: Comment and formatting fixes. Almost every
8356 external function had an assert added, checking driver_open and
8358 (ps_init_driver) Broken into ps_preopen_driver,
8359 ps_postopen_driver, ps_close_driver. Manages driver_open.
8360 (ps_open_page) Sets page_open.
8361 (ps_close_page) Clears page_open.
8363 * som.c: New file, base implementation.
8365 * som.h: (struct som_table) Add struct tag.
8366 (enum SOM_COL_ACROSS) Removed.
8367 (SOM_ROWS, SOM_COLUMNS) New enums.
8368 (struct som_table_class) Add member `cumulate'. Remove `segment';
8369 change `render' arguments.
8370 (struct som_point, struct som_rect) Removed.
8371 (som_submit_table) Fixed typo, should have been som_submit.
8373 * sysfile-info: (describe_variable) Don't try to insert a
8374 subtable; just destroy it for now.
8376 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8377 references to value labels.
8379 * tab.c: (tab_destroy) New function.
8380 (tab_columns) Change argument.
8381 [0] (tab_submit) Remove dead code.
8382 (tab_title) Allocate string from the table's arena.
8383 (tab_output_text) Only free the buffer if we allocated it.
8384 (tab_submit) New function.
8385 (static vars t, d) New static vars.
8386 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8387 tabi_headers, tabi_cumulate, tabi_render) New functions.
8388 (glob var tab_table_class) New global var.
8390 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8391 encapsulate the rectangle. All references changed.
8393 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8395 * All header files updated to use struct tags in addition to
8396 typedefs for all structures. Don't use word `struct' in struct
8399 * Makefile.am: (pspp_SOURCES) Remove html.c.
8400 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8401 all references updated.
8403 * command.c: (parse_cmd) Remove call to som_check_workspace.
8404 (output_line) Update to new som.
8406 * data-in.c: (parse_numeric) A single dot is not an error; it is
8407 the system-missing value.
8409 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8412 * data-out.c: Added `const' as appropriate to many prototypes.
8413 (convert_E, convert_F, convert_CCx) Take double argument instead
8414 of value * argument.
8415 (convert_format_to_string) Call changed functions appropriately.
8416 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8417 make a local copy of the value.
8419 * descript.q: Remove custom_variables() prototype now provided by
8421 (custom_variables) Don't increment sbc_variables, the caller does
8423 (dump_z_table, display) Update to new som.
8425 * error.c: (vmsg) Add const to prototype. Remove code to handle
8426 `too many errors' condition.
8427 (check_error_count) New function.
8428 (msg) Add const to prototype.
8430 * filename.c: (open_file) Rewrite for elegance.
8432 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8433 (dump_full, dump_condensed, dump_statistics) Update for new som.
8435 * list.q: Don't include somP.h. Change all references to
8436 som_driver_ext to refer to the new members of som_driver. Change
8437 som_internal_eject_page() references to outp_eject_page().
8439 * main.c: (parse) Rewrite for elegance. Add call to
8440 check_error_count().
8442 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8443 Rewrite or revise for new outp_driver_class_list structure.
8444 (outp_iterate_enabled_drivers) Fix comparison between disabled
8445 devices and current device type.
8446 (outp_eject_page) New function.
8448 * output.h: Comment fixes.
8449 (struct outp_driver) New members driver_open, page_open, cp_x,
8450 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8452 (struct outp_driver_class_list) New struct.
8453 (outp_class_list) Changed to type outp_driver_class_list; all
8456 * print.c: (dump_table, print_trns_proc) Updated for new som.
8458 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8459 prototypes for custom subcommands.
8460 (dump_subcommand) Always include the `else'.
8461 (dump_parser) Fix comments in output code.
8463 * set.q: Reordered functions.
8465 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8467 * som.h: Rewritten from scratch.
8469 * str.h: Remove dead code.
8471 * tab.c, tab.h: New files, base implementation.
8473 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8476 * t-test.q: New code from John Williams
8477 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8478 Many many new static vars and defines.
8479 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8480 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8481 (struct value_list) New struct.
8482 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8483 t_crt, t_sig, print_t_groups) New functions.
8484 (cmd_t_test) Implemented.
8486 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8489 * vfm.c: (dump_splits) Update to new som.
8491 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8493 * Makefile.am: (fiasco_SOURCES) Add html.c.
8495 * aggregate.c: Base source.
8497 * ascii.c: (postopen, preclose) Reformat.
8499 * data-out.c, expr-evl.c: Comment fixes.
8501 * filename.c: (open_file) When opening a file for writing, use
8502 line buffering instead of full buffering for better interactive
8503 performance. Suggested by Valerio Aimale
8504 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8505 names `stdin', `stdout', `stderr'.
8507 * groff-font.c: Comment fixes.
8509 * html.c: New file; base version.
8511 * list.q: (write_all_headers, clean_up, determine_layout,
8512 list_cases) Ignore `special' devices for now. Needs to be fixed
8515 * output.c: (outp_init) Add html driver to list; reverse list
8518 * output.h: (struct outp_class_struct) New members `special',
8519 `submit'; comment fixes. All references changed.
8521 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8522 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8524 (postopen) Comment fix.
8525 (preclose) Comment fixes, formatting fixes. Change x->file.file
8526 references to more proper f->file.
8528 * som-high.c: (som_submit_table) Special classes use their own
8531 * som.h: Comment fixes.
8533 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8536 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8538 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8540 * aggregate.c: Still working on this.
8542 * command.c: (cmd_table[]) Add AGGREGATE back in.
8543 (split_words) Make '-' a legal word separator as well as ' '.
8545 * main.c: Comment fixes.
8547 * q2c.c: (dump_parser) Don't require the procedure's full name to
8548 be present, in the generated source.
8550 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8551 multiply specified and let it be default; let MISSING, CRITERIA,
8552 FORMAT be multiply specified.
8553 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8554 (custom_groups) Fix defaults.
8555 (custom_pairs) Check whether this is a PAIRS subcommand before
8556 attempting to parse. Better garbage collection. Proper storage
8558 [DEBUGGING] (debug_print) New function.
8560 * temporary.c: Comment fixes.
8561 (copy_variable) Don't copy variable name and index.
8562 (save_dictionary) Copy variable name and index by hand.
8564 * vars-atr.c: Comment fixes.
8565 (create_variable) New dictionary argument. All references
8567 (common_init_stuff) New dictionary argument. All references
8569 (init_variable) New dictionary argument. All references changed.
8570 (dup_variable) New function.
8572 * vars-prs.c: (parse_variables) If there are any errors, we always
8573 return 0. Previously, it was possible for some types of errors to
8576 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8578 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8581 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8583 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8586 * q2c.c: Comment fixes.
8587 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8589 * t-test.q: (cmd_list) Rename cmd_t_test.
8591 * temporary.c: (new_dictionary) Don't declare as static.
8593 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8595 * aggregate.c: Changes, still not finished.
8597 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8599 * q2c.c: Comment fixes. Now its output is internationalized.
8600 (get_token) Fix parsing of escapes within literal strings.
8601 (main) Fix bad #line directives in output.
8603 * t-test.q: Base implementation.
8605 * temporary.c: (new_dictionary) New function.
8606 (restore_dictionary) [__CHECKER__] Change fill character to *
8609 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8611 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8613 * aggregate.c: Changes, still not finished.
8615 * descript.q, list.q: Comment fixes.
8617 * q2c.c: Almost completely rewritten.
8619 * t-test.q: New file, not complete.
8621 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8623 * aggregate.c: Changes, still not finished.
8625 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8628 * temporary.c: (cancel_temporary) New function.
8630 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8631 of doing it by hand.
8633 * vfm.c: (close_active_file) After restoring a TEMPORARY
8634 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8636 (SPLIT_FILE_procfunc) Comment fix.
8638 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8640 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8642 * aggregate.c: New file, not finished yet.
8644 * command.c: (cmd_table) Add AGGREGATE.
8646 * common.h: (pgm_state) Move declaration to var.h.
8648 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8650 (parse_string) Message fix.
8652 * recode.c: Comment fix.
8654 * sfm-read.c: (read_variables) Code esthetic fixes.
8655 (write_header) Default date is `Jan', not `JAN'.
8657 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8659 * sort.c: (cmd_sort_cases) Farm the work out to new function
8660 parse_sort_variables().
8661 (parse_sort_variables) New function.
8662 (sort_cases) New function. Cancels temporary transformations,
8663 which sorting didn't do previously.
8664 (cmd_sort_cases) Better garbage collection on error. Uses
8666 (write_initial_runs, merge_once) Improved code esthetics.
8667 (sort_stream_read) Reduced to one call to read_output_cases().
8668 (read_output_cases) New function.
8670 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8671 variable labels to 120 characters.
8673 * var.h: Comment fixes.
8674 (glob var pgm_state) From common.h.
8676 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8678 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8679 options. Set *names to NULL on error.
8681 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8683 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8685 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8686 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8688 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8690 * vfm.c: (page_to_disk) Added missing local variables.
8692 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8694 * get.c: Comment fix.
8696 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8697 source is anything other than a disk stream, not just if it's in a
8698 memory stream. Call page_to_disk() before external sort.
8699 (allocate_cases) Message fix.
8701 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8703 (page_to_disk) New function.
8705 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8707 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8709 * common.h: (macro strerror) Remove. From Alexandre Oliva
8710 <oliva@dcc.unicamp.br>.
8712 * get.c: (dict_delete_run) The number of variables to delete is
8713 not necessarily the number of variables that need to be shifted
8715 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8716 too many variables to be deleted.
8718 * postscript.c: Comment fix.
8720 * q2c.c: Include strerror.c. From Alexandre Oliva
8721 <oliva@dcc.unicamp.br>.
8723 * set.q: #undef ON and OFF. From Alexandre Oliva
8724 <oliva@dcc.unicamp.br>.
8726 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8727 early, otherwise errors cause a bad free().
8729 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8730 Oliva <oliva@dcc.unicamp.br>.
8732 * temporary.c: (save_dictionary) Don't allocate memory if
8735 * vfm.c: (memory_stream_write) Message fix.
8737 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8739 * command.c: (static var cmd_table[]) Define REPEATING DATA
8742 * common.h: Added support for broken systems that are missing
8743 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8745 * Many source files: Replace syntax error messages via msg() with
8746 call to syntax_error().
8748 * data-list.c: (dump_fixed_table) Add support for dumping table
8749 for REPEATING DATA as well as DATA LIST FIXED.
8750 (cmd_repeating_data) Allows and requires `/' between subcommands.
8751 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8752 CONTINUED specifications to be omitted. Forces CONTINUED to be
8753 specified if ID is. Calculates starts_end, cont_end from logical
8754 record length as reported by fhp. Calls dump_fixed_table() if
8755 requested. Fixed length of record copied by memcpy.
8756 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8758 (realize_value) Returns sensible value for out-of-range variable
8760 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8761 length of occurrences and length of line. Added warning for
8762 fields that exceed the line length. Fixed infinite loop.
8763 (read_one_set_of_repetitions) Numerous minor changes for more
8764 complete SPSS compliance. Message fixes.
8766 * dfm.c: (dfm_close) If the file being closed is the inline file,
8767 read all the remaining data before closing it.
8768 (dfm_get_record) Don't close the file on lossage, as either it
8769 has been closed already or it doesn't belong to us.
8771 * error.c: (puts_stdout) New function.
8772 (vmsg) Use puts_stdout instead of puts.
8774 * file-handle.q: (fh_record_width) New function.
8776 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8779 (input_program_source_read) Made an old kluge an approved method.
8781 * lexer.c: (syntax_error) New function.
8783 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8786 * output.c: (oupt_get_paper_size) Message fix.
8788 * q2c.c: Numerous fixes to formatting of generated code made to
8789 conform to GNU coding standards. Uses syntax_error() in generated
8790 code. Other miscellaneous generated message fixes. Added support
8791 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8792 RAND_MAX, and/or strerror().
8794 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8796 * data-in.c: Comment fixes.
8798 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8799 (find_variable_input_spec) New function.
8800 (cmd_repeating_data) Initializes id_spec.
8801 (rpd_parse_record) Implemented.
8802 (read_one_set_of_repetitions) Returns -3 by default in order to
8803 kluge out some potential bugs.
8805 * data-out.c: Comment fixes.
8807 * file-type.c: (internal_cmd_record_type) Message fix.
8809 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8810 for handling -3 return value.
8812 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8814 * data-list.c: Comment fixes.
8815 (struct dls_var_spec) Reordered members.
8816 (read_from_data_list_fixed) Restructured.
8817 (struct repeating_data_trns) Reordered members. Renamed `starts'
8818 as `starts_beg', `ends' as `starts_end'.
8819 (cmd_repeating_data) Calculates length of repeated data if
8820 necessary and possible.
8821 (parse_num_or_var) Don't allow string variables.
8822 (realize_value) New function.
8823 (rpd_msg) New function.
8824 (rpd_parse_record) New function. Currently stubbed out.
8825 (read_one_set_of_repetitions) Implemented.
8827 * inpt-pgm.c: (input_program_source_read) Comment fix.
8829 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8831 * command.c: (cmd_end_repeat_p) Removed.
8832 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8833 (parse_cmd_name) Removed.
8835 * data-list.c: Comment fixes.
8836 (data_list_pgm) Removed `eof' member.
8837 (static var first) New var.
8838 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8839 FILE TYPE file inside FILE TYPE structures.
8840 (append_var_spec) Appends to *first, not dls.spec.
8841 (parse_fixed) Message fixes.
8842 (struct rpd_num_or_var) New.
8843 (struct repeating_data_trns) New.
8844 (static var rpd) New.
8845 (cmd_repeating_data) New function.
8846 (parse_num_or_var) New function.
8847 (parse_repeating_data) New function.
8848 (read_one_set_of_repetitions) New function.
8850 * file-type.c: (cmd_file_type) Message fixes. Always
8851 default_handle to FILE TYPE file handle.
8852 (internal_cmd_record_type) Message fixes.
8854 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8856 * repeat.c: Comment fix. Disable debugging.
8858 * temporary.c: (restore_dictionary) Sets splits to NULL and
8859 n_splits to 0 before destroying the variables because now doing
8860 this tries to remove split variables.
8862 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8863 destroying the dictionary.
8864 (clear_variable) Removes a variable from splits after destroying
8867 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8869 * cmdline.c: (set_compat) Removed.
8870 (pick_compat) Removed.
8871 (parse_command_line) Removed -c option.
8872 (pre_syntax_message) Removed -c option.
8873 (usage) Remove compatibility code.
8875 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8876 (glob var compat) Removed.
8878 * compute.c: (type_check) Fixed messages about type mismatches.
8880 * data-list.c: (cmd_data_list) Removed compatibility code.
8881 (fixed_parse_compatible) Calls convert_negative_to_dash().
8882 Fixed bug where it only set the variable in fx.spec if it created
8883 the variable itself.
8884 (dump_fmt_list) Spelling fix.
8885 (cut_field) Removed compatibility code.
8887 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8890 * expr-evl.c: (evaluate_expression) Implement LAG.
8892 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8893 (parse_neg) Calls convert_negative_to_dash().
8894 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8897 * expr.h: (struct expression_struct) Removed member max_lag.
8899 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8900 (internal_cmd_record_type) Removed special handling to produce
8901 negative numbers from dash tokens.
8903 * getline.c: (static var DO_REPEAT_level) New var.
8904 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8905 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8906 copy_with_DO_REPEAT_substitutions().
8907 (getl_read_line) Maintains value of getl_mode. Calls
8908 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8910 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8912 * getline.h: (getl_mode) New glob var.
8914 * glob.c: Comment fixes.
8915 (init_glob) Restructured. Sets set_seed.
8916 (init_compat_dependent) Removed. All references removed.
8917 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8918 (__htonl, __htons) Removed. (What were these for?)
8920 * lexer.c: (static var tbl) Dash set to class CNUM.
8921 (make_hexit) New function from data-out.c.
8922 (get_token_representation) Rewritten.
8923 (convert_negative_to_dash) New function.
8924 (lex_init_compat_dependent) Removed.
8925 (yylex) A dash is parsed as part of a number if it is followed by
8926 a digit. The ASCII representation of a number is copied to
8927 tokstr. String parsing farmed out to parse_string(). Comment
8929 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8931 (preprocess_line) Line processing depends on interactive/batch
8932 mode, not on compatibility mode. Removed PC+ compatibility code.
8934 * loop.c: (loop_3_trns_proc) Comment fix.
8936 * main.c: Remove dead code.
8937 (main) Remove call to init_compat_dependent().
8939 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8942 * print.c: (parse_string_argument) Calls
8943 convert_negative_to_dash().
8944 (fixed_parse_compatible) Calls convert_negative_to_dash().
8946 * repeat.c: (RPT_* defines) Removed.
8947 (struct rpt_numeric) Removed.
8948 (struct repeat_entry) New member type, changed `replacement' from
8950 (clean_up) Deallocation adapted to new repeat_entry.
8951 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8952 usage. Creates vars for `type' of 1.
8953 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8954 (store_numeric) Rewritten, new interface.
8955 (parse_numbers) Rewritten.
8956 (parse_strings) Rewritten.
8957 (find_DO_REPEAT_substitution) New function.
8958 (perform_DO_REPEAT_substitutions) New function.
8959 (copy_with_DO_REPEAT_substitutions) Removed.
8960 (debug_print) Rewritten.
8962 * set.q: Comment fix.
8963 (custom_results) Removed compatibility code.
8964 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8967 * sysfile-info.c: (cmd_display) Removed compatibility code.
8969 * tokens.h: Comment fixes.
8970 (token types enum) Removed `toktype' typedef name for this int
8971 type. Removed SUBST. Restructured.
8973 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8975 * vars-prs.c: Comment fix.
8977 * vfm.c: Comment fixes.
8978 (glob var n_lag) New var.
8979 (static vars lag_count, lag_head, lag_queue) New vars.
8980 (procedure) Removed argument nlag.
8981 (setup_lag) New function.
8982 (close_active_file) Discards lagging state.
8983 (lag_case) New function.
8984 (lagged_case) New function.
8985 (write_case) Lags a case if lagging.
8987 * weight.c: (cmd_weight) Removed compatibility code.
8989 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8991 * getline.h: (struct getl_script) New members loop_index, macros.
8993 * getline.c: (getl_add_file) Sets first_line field to NULL.
8994 (getl_add_DO_REPEAT_file) New function.
8995 (handle_line_buffer) When the current line's length is negative,
8996 set the filename and line number. Increment line number after
8997 reading line. Pass the line to
8998 copy_with_DO_REPEAT_substitutions() for processing.
8999 (getl_close_file) Free DO REPEAT lines before freeing the
9000 filename, and just set the filename to NULL when doing this,
9001 because otherwise the filename gets freed twice.
9003 * glob.c: (glob var queuing) Removed. All references removed.
9005 * lexer.c: Comment fixes.
9006 (get_token_representation) New function.
9008 * repeat.c: Comment fixes.
9009 (struct repeat_entry) Replaced type and v union members with a
9011 (append_record) New function.
9012 (internal_cmd_do_repeat) Started reforming it for the new
9013 repeat_entry struct. Properly records filename changes in the
9014 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9015 strncasecmp() result usage. Uses append_record() to simplify.
9016 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9019 (copy_with_DO_REPEAT_substitutions) Started coding.
9021 [DEBUGGING] (debug_print_lines) New function.
9023 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9025 * tokens.h: (macro is_id1, is_idn) New macros.
9027 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9029 * cmdline.c: (static var pre_syntax_message) Changed `win'
9030 compatibility mode to `wnd'.
9032 * data-list.c: (fixed_parse_spss) Renamed
9033 fixed_parse_compatible().
9035 * glob.c: (init_glob) Excise unused code for
9036 program_invocation_short_name.
9038 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9041 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9043 * set.q: `win' compatibility renamed `wnd'.
9045 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9047 * filename.c: [__WIN32__] Change the included Windows header files
9049 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9050 second character is absolute.
9051 (dirname) Fix logic error. Don't printf() the results.
9052 (prepend_dir) Don't printf() the results.
9054 * getline.c: (handle_line_buffer) New function.
9055 (getl_read_line) Reads line with handle_line_buffer() when
9057 (getl_close_file) Discard line buffer data.
9059 * getline.h: Comment fixes.
9060 (struct getl_line_list) New struct.
9061 (getl_script_struct) Added line buffer members. These are hooks
9062 for use by DO REPEAT to allow it to insert virtual source code
9065 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9066 Override Borland C++ stupidity that claims Windows has a console
9069 * repeat.c: This is in the process of being restructured from
9070 using a token-buffering approach to the DO REPEAT facility to
9071 using the more flexible approach of a line-buffering approach in
9072 conjunction with the getline module. Comment fixes.
9073 (struct tok_struct) Removed.
9074 (static vars queue_index, queue_head, queue) Removed.
9075 (static vars line_buf_head, line_buf_tail) New vars.
9076 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9078 (pull_queue, destroy_queue) Removed.
9079 [DEBUGGING] (debug_print_tokens) Removed.
9081 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9083 * file-handle.q: (prepend_current_directory) New function.
9084 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9085 current directory before normalizing filename.
9087 * filename.c: (gnu_getcwd) New function.
9088 (absolute_filename_p) New function.
9089 (search_path) New argument, PREPEND. All references changed to
9090 pass NULL except those explicitly mentioned. Uses
9091 absolute_filename_p(). Prepends PREPEND before trying the
9093 (dirname, prepend_dir) New functions.
9095 * getline.c: (getl_get_current_directory) New function.
9096 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9099 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9101 * In several source files, the term `script' was replaced with
9102 `syntax file' inside error messages. Usage of the term `script'
9103 in the sense of a syntax file is now deprecated.
9105 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9108 * dump-sysfile.c: (usage) Update message.
9110 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9112 * getline.h: (glob var getl_include_path) Declare extern.
9114 * list.q: Define EXTERN as extern before #including somP.h.
9116 * var.h: Remove declaration of `disptype' variable.
9118 * vfm.c: (close_active_file) After switching the data sink to a
9119 data source, set vfm_sink to NULL, because it doesn't exist any
9122 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9124 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9125 _matherrl() to ignore all math errors.
9127 * sfm-read.c: (read_value_labels) When reading the labels from
9128 disk, read the little parts separately instead of as a struct;
9129 this avoids alignment problems.
9131 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9132 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9133 (write_header) Allocates and initializes elem_type.
9134 (sfm_write_case) Uses elem_type to determine how to handle each
9136 (sfm_close) Frees elem_type.
9138 * sfmP.h: Comment fix.
9139 [__BORLANDC__] Uses #pragma -a to adjust structure member
9142 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9144 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9146 * common.c: Fix typo.
9148 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9149 sense of the condition.
9151 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9152 line-continuation backslash.
9154 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9156 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9157 non-constant expression as an argument to sizeof.
9159 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9160 undefine gettext macro because that's a conio function.
9162 * hash.h: (hsh_prime_tab declaration) Remove.
9164 * list.q: (write_fallback_headers) Move `leader' allocation out of
9165 main loop. Change to local_alloc() allocation.
9167 * output.h: Formatting fixes. Put __attribute__ in right place on
9168 function prototypes.
9170 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9171 incorrect `SECOND_LOWEST_VALUE' references to proper
9172 `second_lowest_value'.
9174 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9175 value. This way 2 out of 3 of the som files define the vars
9176 extern, the correct way, that actually works under BC++.
9177 (som_set_float) Don't use nonconstant initializers for a struct.
9179 * som-high.c: Add the standard alloca() header.
9180 (replicate_table) Add prototype.
9182 Merged DISPLAY routine.
9183 * sysfile-info.c: (AS_*) New enum series.
9184 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9186 (cmd_display, display_macros, display_documents,
9187 display_variables) Stolen from defunct display.c.
9188 (describe_variable) New function.
9190 * temporary.c: [0] (display_tree) New debug function.
9191 (copy_variable) Performs shallow copy of value labels instead of
9192 deep copy; i.e., just copys the AVL tree and increments the
9195 * val-labs.c: Comment fixes.
9196 (do_value_labels) Optionally skip leading forward slash.
9197 (get_label) Creates only a single value label instead of many
9198 copies of one, and sets the reference count.
9200 * display.c: Removed.
9202 * dump-sysfile.c: New file, not yet complete.
9204 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9206 For lots of source files I added more verbose_msg's. These aren't
9207 listed below as they have tested as being benign. In some cases
9208 these replaced debug_printf() calls.
9210 * output.c: (outp_read_devices) Message fix.
9212 * postscript.c: (output_encodings) Message fix. Reports errors on
9214 (postopen) Message fix.
9216 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9218 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9220 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9223 * main.c: Remove <malloc.h> #include.
9225 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9226 instead of trying to just set the missing[] itself, which is a
9229 * sfm-read.c: (read_variables) Same.
9231 * str.h: Add memmem() prototype.
9233 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9235 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9237 * Makefile.am: (q2c) Don't include any libraries in the link.
9239 * dfm.c: (force_line_buffer_extension) New macro.
9240 (count_tabs) New function.
9241 (tabs_To_spaces) New function.
9242 (read_record) Calls tabs_to_spaces() on the line being processed.
9244 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9245 have to be compiled twice (once for CC, once for LOCAL_CC).
9247 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9249 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9250 (LDADD) Add @INTLLIBS@.
9251 (q2c) Add LIBS, @INTLLIBS@ to link step.
9253 * inpt-pgm.c: Turn off debugging.
9255 * postscript.c: (postopen) Format fix. local_free() blocks
9256 returned by local_alloc(); don't free() them.
9258 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9260 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9263 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9264 LEN arg, not simply the full string length.
9266 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9267 directories before generic temp file directories.
9269 * vfm.c: Disable debugging.
9271 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9273 * get.c: Comment fix.
9274 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9276 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9278 * expr-prs.c: (debug_print_postfix) Conditionally included on
9279 GLOBAL_DEBUGGING. Removed out_header() reference.
9281 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9283 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9285 * ascii.c: Removed obsolete ascii_close_page() prototype.
9287 * command.c: (output_line) Comment fix.
9289 * data-in.c: Formatting fix.
9290 (parse_string_as_format) Now the `fc' argument is used only for
9291 the purpose of error messages; it is not an index into the string
9292 passed. All references changed.
9294 * data-list.c: Comment fix.
9295 (cut_field) Comment fix. Now returns the column number of the
9296 position of the field cut out on success.
9297 (parse_field) Added `column' argument. Puts the column numbers in
9299 (read_from_data_list_free, read_from_data_list_list) Record the
9300 column number returned by cut_field(), pass it to parse_field().
9302 * dfm.c: Comment fix.
9304 * do-ifP.h: Comment fix.
9306 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9307 the SYSMIS function.
9309 * expr.h, exprP.h: Comment fix.
9311 * glob.c: (init_glob) Only calls setlocale() and family if
9314 * hash.h: Comment fix.
9316 * include.c: Comment fix.
9318 * output.c: Comment fix.
9320 * postscript.c: (ps_line_intersection) Simplified assertion.
9322 * repeat.c: Comment fix.
9324 * vars-atr.c: Comment fix.
9326 * vars-prs.c: Comment fix.
9328 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9329 behavior with usage of postincrement.
9330 (memory_stream_read) Discards cases as it goes.
9332 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9334 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9337 * Most source files: Includes debug-print.h, related comment
9340 * cases.c: (alloc_val) Removed complex allocation code. Merely
9341 increments default_dict.nval and returns the former value.
9342 (envector, devector) Removed references to lv member of struct
9345 * common.h: (macro VME) Replaced complex definition with simple
9348 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9349 read_active_file and cancel_input_pgm.
9350 (read_from_data_list, cancel_data_list) Removed.
9351 (data_list_source_read, data_list_source_destroy_source) New
9353 (glob var data_list_source) New var.
9355 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9356 (cmd_begin_data) Improved criteria for an input program accessing
9357 the inline file. Still not perfect.
9359 * do-if.c: (do_if_trns_proc) Simplified debug output.
9361 * expr-prs.c: Comment fixes.
9362 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9364 * file-handle.q: (fh_close_handle) Simplified debug output.
9366 * file-type.c: Comment fixes.
9367 (cmd_file_type) Sets vfm_source instead of read_active_file and
9369 (cmd_end_file_type) On failure, discards variables in place of
9370 just canceling the input program.
9371 (read_from_file_type) Renamed file_type_source_read.
9372 (cancel_file_type) Renamed file_type_source_destroy_source.
9373 (glob var file_type_source) New var.
9375 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9376 (cmd_get) Initializes options to GTSV_NONE before passing to
9377 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9378 instead of read_active_file and cancel_input_pgm.
9379 (cmd_save_internal) Initializes options before passing to
9380 trim_dictionary(). Local var `nval' removed.
9381 (dict_delete_run) Comment fixes.
9382 (trim_dictionary) Comment fixes. Disallows scratch variables if
9383 GTSV_OPT_SAVE set in options.
9384 (read_from_get) Renamed get_source_read.
9385 (cancel_get) Renamed get_source_destroy_source.
9386 (glob var get_source) New var.
9388 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9389 read_active_file and cancel_input_pgm.
9390 (read_from_input_program) Renamed input_program_source_read.
9391 Simplified debug output.
9392 (cancel_input_program) Renamed
9393 input_program_source_destroy_source.
9394 (glob var input_program_source) New var.
9396 * loop.c: (loop_1_trns_proc) Simplified debug output.
9398 * main.c: (dump_token) Made eof output more explicit.
9400 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9403 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9404 code for always-memory or always-disk cases. malloc's case-list
9405 based on vfm_source_info.ncases. Explicit support for
9406 memory_stream via memory_source_cases.
9407 (do_external_sort) Sets vfm_source instead of read_active_file and
9409 (allocate_file_handles) The temporary directory permissions are
9410 set to 0700 instead of 0777.
9411 (allocate_cases) Formatting fixes. Simplified debug output.
9412 (output_record) Compacts the case if necessary before writing it
9414 (close_handle, open_handle_w) Simplified debug output.
9415 (write_initial_runs) Destroys vfm_sink, then sets it to
9416 sort_stream. Writes records to memory based on
9417 vfm_sink_info.case_size.
9418 (write_to_sort_cases) Renamed sort_stream_write().
9419 (merge) Simplified error handling. Simplified debug output.
9421 (read_from_external_sort) Renamed sort_stream_read().
9422 Reads records based on vfm_source_info.case_size.
9423 (sort_stream_write) Writes records to memory based on
9424 vfm_sink_info.case_size.
9425 (sort_stream_mode) New function.
9426 (glob var sort_stream) New variable.
9428 * temporary.c: (cmd_temporary) Simplified debug output.
9429 (copy_variable) Removed references to `lv'.
9431 * title.c: (get_title) Simplified debug output.
9433 * var.h: Comment fixes.
9434 (struct get_proc) Removed member `lv'.
9435 (struct variable) Removed member `lv'. Comment fixes.
9436 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9438 (struct case_stream) New.
9440 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9441 read_active_file references to use vfm_source.
9442 (init_variable, replace_variable) Removed references to `lv'.
9444 * vfm.c: Comment fixes.
9445 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9447 (static var queue, qh, qt, n_lag) Removed. All references
9449 (glob var compaction_necessary, compaction_nval, compaction_case,
9450 paging) New variables.
9451 (record_case) Removed.
9452 (procedure) Comment fixes. Calls vfm_source->read() instead of
9455 (prepare_for_writing, arrange_compaction, make_temp_case,
9456 vector_initialization, setup_filter) New function.
9457 (open_active_file) Most of the code moved into the abovementioned
9458 new functions. Now sets temp_dict to &default_dict if there is no
9459 temporary dictionary, for convenience. New debug output.
9460 (close_active_file) Deals with changing the sink to the source.
9461 Calls finish_compaction(). Frees compaction_case. Mostly
9463 (glob vars disk_source_file, disk_sink_file) New vars.
9464 (destroy_active_file, read_from_memory) Removed.
9465 (disk_stream_init, disk_stream_read, disk_stream_write,
9466 disk_stream_mode, disk_stream_destroy_source,
9467 disk_stream_destroy_sink) New functions.
9468 (glob var vfm_disk_stream) New var.
9469 (glob vars memory_source_cases, memory_sink_cases,
9470 memory_sink_iter, memory_sink_max_cases) New vars.
9471 (memory_stream_init, memory_stream_read, memory_stream_write,
9472 memory_stream_mode, memory_stream_destroy_source,
9473 memory_stream_destroy_sink) New functions.
9474 (glob var vfm_memory_stream) New var.
9475 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9476 named `more_cases'. Simplified debug output. Otherwise mostly
9478 (record_case) Moved into the stream drivers. Removed.
9479 (transform) Removed (was dead code).
9480 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9481 common case that the splits don't change, we don't need to copy
9482 the case into prev_case again--pointless.
9483 (compact_case) New function.
9484 (finish_compaction) New function.
9486 * vfmP.h: Comment fixes.
9487 (DEV_* enum series) Removed.
9488 (struct storage) Renamed `stream_info'. Removed variant record.
9489 Removed `device' member.
9491 * debug-print.h: New file.
9493 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9495 * autorecode.c: Turned off debugging.
9497 * data-list.c: (destroy_dls) Closes the associated file handle.
9499 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9500 parse_variables() options.
9502 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9504 * display.c: (display_variables) Really fixed null cell bug.
9506 * file-handle.q: (fh_close_handle) Changed debugging message.
9508 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9509 parse_variables() options.
9511 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9512 (cmd_list) Fails if no variables specified.
9513 (determine_layout) Writes blank lines manually.
9515 * loop.c: (loop_1_trns_proc) Made debugging code only print
9516 messages if debugging.
9518 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9519 parse_variables() arguments.
9520 (main) Parses optional parenthesized options to varlist
9521 subcommands into sbc->message.
9523 * sfm-read.c: Format fix.
9525 * var.h: (FV_*) New enum series.
9526 (PV_*) New enum PV_NO_SCRATCH.
9528 * vars-prs.c: (find_var) Removed.
9529 (fill_all_vars) Takes FV_* enum instead of boolean third
9530 argument. Rewritten to deal with scratch as well as system
9532 (parse_variables) Error message on scratch variable if
9535 * vfm.c: (static var virt_begin_func) New var.
9536 (procedure) Sets up virt_begin_func.
9537 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9538 after dump_splits(). For succeeding groups changes, calls
9539 virt_begin_func() instead of begin_func().
9541 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9543 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9546 * dfm.c: Added some debugging messages, disabled by default.
9547 (open_file_r) Fixed error message.
9548 (read_record) On eof on inline_file, instead of calling
9549 fh_close_handle(), simply jump to eof label like a normal file.
9552 * display.c: Thin lines between rows for certain kinds of
9553 listing. Fixed `null cell' bug.
9555 * error.c: (failure) Flush stdout, stderr before failing.
9557 * file-handle.q: (fh_close_handle) Added debugging message.
9559 * frequencies.q: (dump_full) Bottom line extends across entire
9560 table width. Changed title formatting.
9561 (dump_condensed) Changed title formatting.
9562 (dump_statistics) Fixed title formatting.
9564 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9565 Sets default value of set_format.
9567 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9568 Passes write_all_headers() to procedure() as pre-group func.
9569 (write_all_headers) New function.
9570 (determine_layout) Removed calls to write_header().
9571 Calls blank_line() before and after write_fallback_headers().
9573 * recode.c: (recode_trns_free) Only attempts to free head->map if
9576 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9577 file variable names but gives a warning. Sets `left' based on
9578 first character being/not being `#'. On lossage frees dict->var.
9580 * som-high.c: (som_draw_title) Simplified title formatting.
9582 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9584 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9586 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9587 beginning. Frees v_src, v_dest on successful exit. Frees
9588 h_trans[*], h_trans on lossage.
9589 (recode) Frees h_trans[*], h_trans.
9591 * dfm.c: (dfm_close) Formatting change.
9592 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9593 longer allocates its own in inline_file.
9594 (open_file_r) Passes the local dfm_fhuser_ext to
9596 (open_file_w) Message fix.
9597 (read_record) Buffer reallocation strategy changed. Frees
9598 ext->line even in inline_file to prevent leaks.
9599 (dfm_put_record) Fixed bug where `ext' was cached before the file
9600 was opened and thus it would be NULL when the file really was
9602 (cmd_begin_data) Sets up inline_file basics itself, then calls
9603 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9605 * list.q: (write_line) Formatting fix.
9606 (clean_up) Minor strategy change. Sets proportional font after
9608 (determine_layout) Sets fixed font before writing regular headers,
9609 or after writing fallback headers.
9611 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9612 and KEEP vars after using them.
9614 * postscript.c: (ps_init_driver) Frees x->family.
9615 (postopen) When loading fonts, free the temporary font name buffer
9617 (ps_text_set_font_by_position) Free temporary font name buffer
9619 (text) Fixed code that calculated `lig' so that `lig' always gets
9620 initialized. Formatting fix.
9622 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9624 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9625 cells, not xmalloc(), so that the cells will get destroyed
9628 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9631 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9633 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9636 * dfm.c: Comment fix.
9638 * list.q: Comment fixes. Include somP.h. Removed static vars
9639 table, n_columns, n_rows, part. New struct list_ext. New static
9641 (n_lines_remaining, n_chars_width, write_line) New functions.
9642 (cmd_list, list_cases) Rewritten.
9643 (begin_row, end_row, flush_table) Removed.
9644 (write_header, clean_up, write_varname, write_fallback_headers,
9645 determine_layout) New functions.
9647 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9649 * output.h: Comment fix.
9651 * postscript.c: Comment fix.
9652 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9653 added font_size. All references changed.
9654 (ps_init_driver) Initializes font_size. Simplified space checking
9656 (static var option_tab[]) Removed prop-size, fixed-size; added
9658 (ps_option) Handles font_size.
9660 * som-high.c: Moved prototypes into somP.h.
9661 (som_init_driver) New function.
9662 (som_submit_table) Moved some code into new function
9664 (build_target) Moved some code into new function
9665 som_internal_eject_page().
9666 (som_eject_page) Uses som_internal_eject_page().
9667 (som_internal_eject_page) New function.
9669 * som-low.c: Moved prototypes into somP.h.
9671 * som.h: Formatting fixes.
9673 * somP.h: (struct som_driver_ext) Removed em_width;
9674 added prop_em_width, fixed_width.
9676 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9678 * Makefile.am: Added `localedir' definition. Added
9679 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9681 * ascii.c: (macro draw_line) Fixed capitalization.
9683 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9684 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9685 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9686 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9687 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9688 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9689 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9690 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9691 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9692 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9693 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9694 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9695 for internationlization.
9697 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9699 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9701 * do-if.c, sort.c, val-labs.c: Comment fixes.
9703 * glob.c: (init_glob) Uncommented, updated i18n support.
9705 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9706 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9707 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9708 the declarations of macros taking arguments a lot nicer.
9710 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9712 * error.h: Removed CE, CW aliases for SE, SW.
9714 * q2c.c: Removed explicit streq() definition since it's duplicated
9717 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9718 stats.h, str.h, tokens.h: Made the declarations of macros taking
9719 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9722 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9724 * cmdline.c: Comment fixes.
9725 (pick_compat) Changed return type to int. Now, instead of setting
9726 glob var `compat' to the emulation, returns the emulation. All
9728 (parse_command_line) Added terminating null to end of
9729 `long_options' array definition.
9730 (pre_syntax_message) Fixes.
9731 (usage) Shows the default emulation in the syntax message by
9732 calling pick_compat().
9734 * getline.c: (getl_add_include_dir) Separates paths with
9735 PATH_DELIMITER, not DIR_SEPARATOR.
9737 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9738 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9740 * output.c: (outp_configure_macro) Make earlier definitions for a
9741 particular key override later ones for the same key.
9743 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9745 * ascii.c: Comment fixes.
9747 * output.c: (outp_get_paper_size)
9748 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9750 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9752 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9753 <errno.h>. GNU libc 2 enforces this!
9755 * command.c: (parse_cmd) Fixed problem with `else' clause being
9756 paired with wrong `if'. Comment fix.
9758 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9760 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9761 blp_getline() to getline().
9763 * output.c: (outp_eval_dimension) Changed the fix from last time;
9764 there was no variable `a'.
9766 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9768 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9770 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9771 numbers having fractional parts. Added case of a fraction without
9772 a whole-number part.
9774 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9776 * ascii.c: (ascii_text_get_font_position) Removed.
9778 * expr.h, exprP.h: Disabled debugging.
9780 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9783 * output.h: (struct outp_class_struct) Removed
9784 text_get_font_position method. All references deleted.
9786 * postscript.c: Big change here. Fontmaps were completely
9787 eliminated because of a change in philosophy. Comment fixes.
9788 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9790 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9791 `fixed_name' members removed. New members `prop_family',
9792 `fixed_family'. `family' member changed to type char *.
9793 (static var ps_fontmaps) Removed.
9795 (ps_init_driver) Removed obsolete references, updated.
9796 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9797 fontmap, of course. Refers to font names through internal_name
9798 rather than subversive means. Frees proper items.
9799 (static var option_tab[]) Removed `fontmap-file' option; renamed
9800 `fixed-font', `prop-font'.
9801 (ps_option) Corresponds to option_tab[].
9802 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9803 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9804 hash_family) Removed.
9805 (postopen) Generates font names from family names. Gets
9806 PostScript font name properly. New prologue file comment `!!!'
9808 (ps_open_page) Adds translate_x, translate_y to BP prologue
9809 function; gives SF argument floating-point format.
9810 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9811 font name. Doesn't change font family.
9812 (ps_text_set_font_by_position) Generates Groff font name from font
9813 family name instead of through table lookup.
9814 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9815 all references changed. Reduced to simple string assignment.
9816 (ps_get_font_name) Removed.
9817 (ps_get_font_family) Reduced to string return.
9818 (text) Doesn't save `position' since it no longer exists. Ugly
9819 kluge to save font family--fix soon?
9820 (load_font) Removed PostScript name argument.
9822 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9824 * postscript.c: Comment fix.
9825 (ps_open_page) Puts scale factor in PostScript output.
9827 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9829 * Makefile.am: Distcleans q2c.
9831 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9833 * ascii.c: (delineate) Sets text size even if width is zero.
9835 * command.c: Comment fix.
9836 (static var cmd_table[]) Re-enabled EVALUATE command.
9837 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9838 of comments in script files. Now more liberal on criteria for
9839 performing a state transition--if *anything* happened correctly,
9840 not just if *everything* happened correctly.
9842 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9843 Checker segfault on formatting large numbers and why in the fsck
9844 hadn't I noticed this before?
9846 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9848 * list.q: (cmd_list) Commented out the actual output routine
9849 because of various problems. Probably will abandon the idea of
9850 using the general `crushed tables' for the LIST procedure.
9852 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9853 clearing it. Allocates a new var_by_name dictionary before trying
9854 to add members to it.
9856 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9857 `sib'. Changed type of `node' argument.
9858 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9860 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9861 [DEBUGGING] Only deletes the variable from var_by_name if that var
9864 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9866 * Makefile.am: Added include files to SOURCES. Added
9867 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9868 includes rules for q2c. Added `boast' target.
9870 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9872 * Makefile.am: Maintainer-clean Makefile.in.
9874 * Makefile.am: Fixed redundant EXTRA_DIST line.
9876 * ascii.c: Comment fixes.
9877 (ascii_line_vert) Fixed overly aggressive range check.
9879 * display.c: Removed dead code.
9881 * list.q: Turn debugging on.
9882 (flush_table) New debug code.
9884 * sfm-read.c: (read_value_labels) malloc's the structure before
9885 trying to assign to its members.
9887 * sfm-write.c: Comment fix.
9889 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9891 (output_table) No arguments anymore--gets them through `som'
9892 global. New debug code. In crushed tables, now sets `htv' as
9893 well as `hv' to avoid bad confusion later.
9894 (dump_crush_page) New debug code.
9896 * som-low.c: (som_dump_crush_page) New debug code.
9898 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9900 All source files: Broke long lines into multiple lines.
9902 * ascii.c: (ascii_close_page) Uses host_system var in place of
9903 HOST_SYSTEM constant.
9905 * cmdline.c: (var syntax_message[]) Broke into
9906 pre_syntax_message[] and post_syntax_message[].
9907 (usage) Outputs both parts, separated by driver list.
9909 * error.h: Fixed broken formatting.
9911 * expr-opt.c: (str_search, str_rsearch) New functions.
9913 * misc.c: (blp_getdelim) Removed. All references changed to
9915 (str_search, str_rsearch) Removed.
9916 (memrmem) New function.
9918 * misc.h: (blp_getline) Removed. All reference changed to
9923 * filename.c: Includes "stat.h", not <sys/stat.h>.
9924 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9926 * output.c: (outp_list_classes) Changed output formatting.
9928 * sfm-write.c: (write_header) Uses host_system var instead of
9929 HOST_SYSTEM constant.
9930 (write_rec_7_34) Extracts version numbers from the version string.
9933 * sort.c: Includes "stat.h", not <sys/stat.h>.
9935 * str.c: (strcasecmp) Removed.
9937 * title.c: (cmd_document) Uses host_system var instead of
9938 HOST_SYSTEM constant.
9940 * version.c: Generated on-the-fly by the Makefile instead of being
9943 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9945 [!HAVE_STRNCASECMP] Declares strncasecmp().
9947 * version.h: Removed stray character. Comment fixes.
9948 (vars host_system, build_system) New vars.
9950 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9952 * Most source files: Changed formatting of copyright notice; fixed
9953 FSF address; reformatted to better conform to GNU standards;
9954 comment fixes. Added markups to prevent GNU indent from messing
9955 up my beautiful formatting :-).
9957 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9958 that GNU indent markups can be passed through without problems.
9960 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9962 * get.c: Turned off debugging.
9964 * glob.c: (init_glob) Turned on save-file compression by default.
9966 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9967 compression than was possible in save files.
9969 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9971 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9973 * frequencies.q: Removed Fiasco extensions. Updated calculation
9974 algorithms. Polished output format.
9975 (struct frq_info_struct) Removed members `max_degree', `min_n',
9976 all references removed.
9977 (macro frq_extensions) Removed.
9978 (static vars min_n, max_degree) Removed, all references removed.
9979 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9980 calculate `min_n', `max_degree'.
9981 (postcalc) Passes new arg to dump_statistics().
9982 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9984 (dump_condensed) Adds variable name title.
9985 (sum_freqs) Removed.
9986 (calc_stats) Updated calculation algorithm.
9987 (dump_statistics) Removed warning for too-few observations.
9988 Changed table formatting. Adds variable name title if passed new
9991 * output.h: Comment fix.
9993 * recode.c, sample.c, sort.c: Disabled debug code.
9995 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9996 Improved debug code.
9998 * var.h: (enum series frq_*) Removed Fiasco extensions.
10000 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10002 * command.c: Added PROCESS IF to command table.
10004 * Lots & lots of places, removed checks for NULLs preceding calls
10005 to free_expression(), which itself checks.
10007 * descript.q: Removed Fiasco extensions. Removed optimizations
10008 for non-weighted active files. Implemented some options.
10009 Finished polishing output format. Comment fixes. Merged
10011 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10012 max_degree, min_n) Removed.
10013 (macro dsc_extensions) Removed.
10014 (struct dsc_info_struct) Removed `min_n' member, all references
10016 (internal_cmd_descriptives) Removed calculation of min_n,
10017 max_degree. Only deals with one `calc' routine instead of two
10019 (precalc) Eliminated redundancy. Updated for changes to
10020 descriptives_proc structure.
10021 (calc) Moved here from `descript.g'. Rewritten to calculate
10022 statistics via `moments about the mean' rather than by summing,
10023 summing squares, summing cubes, and so on.
10024 (postcalc) Rewritten for new-style statistical calculation.
10025 (display) Removed support for displaying variables across rows.
10026 No longer crushes the descriptives table. Removed ancient code.
10027 Added display of N, by variable and listwise.
10029 * descript.g: Removed; merged into `descript.q'.
10031 * expr-evl.c: (evaluate_expression) Now returns a double. For
10032 numeric results, it returns the result as well as storing it in
10033 the passed `value' structure if non-NULL. For string results it
10034 just returns 0.0 and it must be passed non-NULL. Many references
10035 to this function were optimized by use of this change, especially
10036 but not exclusively in `compute.c'.
10038 * frequencies.g: Comment fix.
10040 * glob.c: (glob var process_if_expr) New global var.
10042 * postscript.c: (static var option_tab[]) Corrected entry for
10044 (postopen) Sets x->size to x->prop_size.
10045 (ps_text_set_font_by_name) Sets font size as well as typeface for
10046 PROP and FIXED fonts.
10048 * sel-if.c: (cmd_process_if) New function.
10050 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10051 (sfm_write_dictionary) Sets `n_cases' to 0.
10052 (sfm_write_case) Increments `n_cases'.
10053 (sfm_close) Attempts to seek the system file back to the header
10054 and write the number of cases in its proper slot.
10056 * som-frnt.c: (som_insert_table) Masks off expansion options since
10057 only SOPT_X_NORM seems to work sensibly.
10059 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10060 with a `fixed' value of 2.
10062 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10064 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10065 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10067 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10068 (struct descriptives_proc) Removed `miss_noweight'; new members
10069 `X_bar', `M2', `M3', `M4', `min', `max'.
10071 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10073 * vfm.c: (close_active_file) Cancels PROCESS IF.
10074 (write_case) Doesn't process cases unselected by PROCESS IF.
10076 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10078 * glob.c: (glob var err) Removed.
10080 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10081 doesn't have to take into account number of value labels since
10082 they're in a subtable anyway. Also, doesn't display more than 10
10083 value labels since we can't yet break pages in subtables.
10085 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10087 * som-frnt.c: (som_change_table_size) Simple change for elegance
10088 that shouldn't change behavior.
10089 (som_set_value) Comment fix.
10091 * som-high.c: (som_submit_table) Message fix.
10093 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10095 * command.c: Added SYSFILE INFO to command table.
10097 * file-handle.q: (fh_handle_filename) New function.
10099 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10102 * main.c: (parse) New return value for command functions, -3.
10104 * misc.h: Comment fix.
10106 * output.h: Comment fixes.
10107 (macro COMPONENTS) Removed.
10109 * postscript.c: (write_text) Modified literal_chars[] so that `('
10110 and ')' are not written to the output in strings as literals.
10112 * sfm-read.c: (sfm_read_dictionary) New argument.
10113 (read_header) New argument. Sets the information structure's
10114 values from the header information.
10115 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10116 bizarre Checker problem, I guess.
10117 (read_variables) Proper cleanup on lossage.
10119 * sfm.h: (struct sfm_read_info) New struct for use by
10120 sfm_read_dictionary().
10122 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10123 currently used just for tables that can be dynamically resized and
10124 thus have to be allocated with arena_malloc() instead of
10125 arena_alloc(). All references changed.
10126 (som_change_table_size) New function.
10127 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10129 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10130 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10133 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10135 (draw_intersection) Now takes an argument specifying the table in
10136 question. All references changed.
10137 (draw_table_cell) New function.
10138 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10139 (som_get_table_size) Many nice new explanatory comments.
10140 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10142 * som.h: New enum series SOM_CREATE_* for use as create flags with
10143 som_create_table().
10145 * str.h: Moved a comment here from TODO.
10147 * sysfile-info.c: New file. Reference implementation.
10149 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10151 * command.c: Added RENAME VARIABLES to table of commands.
10153 * data-in.c: (dls_error) Sets `cust_field'.
10154 (parse_N) Message fix.
10155 (parse_day_count) New function.
10156 (to_roman) Never outputs VX as a `short form' of V.
10157 (parse_month) Fixed parsing of Roman numerals.
10158 (parse_trailer) Message fix.
10159 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10160 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10161 the date is invalid.
10162 (parse_SDATE) Fixed swapped day, year.
10163 (parse_JDATE) Fixed bug for dates in 1582.
10164 (parse_DTIME) Allows days not between 1 and 31.
10165 (parse_numeric) Makes local copy of f.type for easier usage.
10168 * data-out.c: (convert_F) When outputting as scientific, properly
10169 sets f.type as fp->type.
10170 (insert_commas) Fixed operator precedence problem with setting of
10171 nitems. Changed strcpy to memcpy (no null terminator).
10172 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10173 (convert_CCx) Essentially rewritten, but now it works.
10175 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10176 feature of Fiasco).
10177 (display_documents) Implemented.
10179 * error.c: (glob var cust_field) New var.
10180 (vmsg) Displays cust_field as part of message classes DE and DW.
10182 * formats.c: (debug_print) Fixed to compile under updated
10185 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10188 * misc.c: (parse_format_specifier) Formatting fix.
10190 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10191 `n_rename' for clarity.
10192 (cmd_modify_vars) Initializes `forward' and `positional' at
10193 appropriate times. Frees lists of vars to rename on failure.
10194 Comment fix. Frees memory on success.
10195 (rearrange_dict) Simplified `for' loop condition.
10197 * rename-vars.c: New file (reference implementation).
10199 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10201 * sfm-read.c: (read_header) File label is created only if file
10202 label in file is not blank.
10203 (read_variables) Initializes `dict' local variable.
10204 (read_documents) Proper behavior on lossage.
10206 * sfm-write.c: (write_header) Doesn't blank out the file label
10207 (why was this here to begin with?!)
10209 * temporary.c: (save_dictionary) File label is copied only if
10210 non-NULL. Doesn't try to xstrdup() dictionary documents.
10211 Adapted so as to not irritate Checker.
10212 (free_dictionary) Only destroys var_by_name if non-NULL.
10214 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10215 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10216 lines to the document, indents the document. Also, it works now.
10217 (add_document_line) New function.
10219 * var.h: (struct dictionary) Reordering.
10221 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10222 bits if it was allocated to begin with.
10224 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10226 * command.c: Added MODIFY VARS to list of commands.
10228 * configure.in: Updated custom macros for autoconf 2.12. Removed
10229 mmap reference; fixed termcap library reference.
10231 * display.c: (display_variables) Fixed a few bugs although it's
10232 still not well written.
10234 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10235 (induce_segfault) Calls chkr_disp_call_chain() instead of
10236 inducing an actual SIGSEGV.
10238 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10239 str_search() and str_rsearch(). Fixed tests for matches on
10240 OP_INDEX and OP_RINDEX.
10242 * filename.c: (good_getcwd) Removed as the new libc for Checker
10243 doesn't contain this bug, apparently.
10245 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10246 consistency with GNU memmem.
10247 (blp_getdelim) Changed `len' from `int' to `size_t'.
10249 * modify-vars.c: Reference implementation.
10251 * som-frnt.c: (zero_length) New global var.
10252 (som_create_table) Message fix.
10254 * som.h: Added gcc attributions to som_set_text(),
10255 som_output_text() prototypes. blank_line() refers to
10256 zero_length[] instead of a literal null string to suppress gcc
10259 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10260 (allocate_cases) Decrements x_max so the last element of x[] can
10261 be used by the algorithm.
10263 * var.h: Changed minor details of `variable' declaration.
10264 (struct modify_vars_proc) New struct.
10265 (struct variable) Added field p.mfv.
10267 * vars-atr.c: Comment fix.
10269 * vars-prs.c: (fill_all_vars) More optimal implementation.
10271 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10272 character, which it shouldn't have to do but printf() seems to
10273 read the null byte even though I supply a maximum length...
10275 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10277 * command.c: Removed command alias X for QUIT.
10278 (parse_cmd) Fixed comment parsing.
10280 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10282 (read_record) Fixed references to len, size.
10283 (dfm_get_record) Restructured.
10285 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10288 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10291 * modify-vars.c: New file. Not complete.
10293 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10296 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10297 problems caused by int/size_t differences.
10299 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10302 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10303 being compared were of equal length.
10305 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10307 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10309 * lexer.c: (get_dotted_rest_of_line) New function.
10311 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10314 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10315 type 6 records. Frees the dictionary properly.
10316 (read_header) Initializes the dictionary instead of letting
10317 read_variables() do it. Sets the dictionary file label from the
10319 (read_documents) New function.
10321 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10322 write type 6 record if appropriate.
10323 (write_header) Writes file label from dictionary.
10324 (write_documents) New function.
10326 * temporary.c: (save_dictionary, restore_dictionary,
10327 free_dictionary) Properly handle new fields in dictionary struct.
10329 * title.c: (get_title) Returns after failure().
10330 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10331 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10333 * var.h: (struct dictionary) New fields `label', `n_documents',
10336 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10338 * command.c: Added FILTER to list of commands.
10340 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10343 * get.c: (cmd_save_internal) Removed weighting code since it's now
10344 handled by sfm-write.c. Properly commented out debug code.
10346 * glob.c: (glob var weighting) Removed.
10348 * sel-if.c: Comment fixes.
10349 (cmd_filter) New function.
10351 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10352 (sfm_read_dictionary) Sets weighting variable direct in the
10353 created dictionary now. (Apparently we previously didn't support
10355 (read_header) Sets weight_index field in sfm_fhuser_ext from
10356 header read from disk.
10358 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10359 (write_header) Now sets the weighting in the header from the
10360 passed primary dictionary instead of from the sfm_write_info.
10362 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10364 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10365 broke on boundary conditions.
10367 * var.h: (struct dictionary) New fields `weight_var',
10368 `weight_index', and `filter_var'.
10369 (glob var weighting) Removed. This is now part of struct
10370 dictionary. All references changed; the less mechanical changes
10371 are described above.
10373 * vars-atr.c: (find_dict_variable) New function.
10375 * vfm.c: (static var filter_index) New variable.
10376 (open_active_file) Initializes filter_index from default_dict.
10377 (write_case) Calls proc_func() only if the filter variable is
10378 nonzero; this implements FILTER behavior.
10380 * weight.c: (static var weight_varname) Removed.
10381 (cmd_weight) Modified default_dict instead of glob vars.
10382 (update_weighting) Changed the signature to modify a dictionary
10383 instead of glob vars. Now returns the weighting variable.
10384 (get_weighting_variable) Removed; its function is absorbed by
10385 update_weighting().
10386 (stop_weighting) Operates on a dictionary now.
10388 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10390 * sort.c: Removed debugging info from messages.
10391 (do_external_sort) Cleans up after itself by deleting the
10392 temporary directory on failure. (On success it is deleted by the
10394 (allocate_cases) Removed debug code. Added clean up code.
10395 (output_record) Removed debug code.
10396 (merge) Added code to close all the input files that are currently
10397 open. This is a likely location for bugs, because I'm not sure
10398 about boundary conditions. Removed an unnecesary heap_delete().
10399 (merge_once) Removed input file "optimization" that in fact
10400 screwed up the rest of the code. Message and comment fixes.
10402 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10404 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10406 * heap.c: (heap_delete) New argument.
10408 * sort.c: Finished implementation of external sort.
10410 * vfm.c: (read_from_disk) Returns after a disk error.
10412 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10414 * sort.c: (static var state) Removed.
10415 (static vars max_handles, tmp_basename, tmp_extname,
10416 huffman_queue) New variables.
10417 (do_external_sort) Moved most code to new functions.
10418 Creates huffman_queue.
10419 (allocate_file_handles, allocate_cases) New functions.
10420 (static vars run_no, run_length, file_index, case_count) New
10422 (output_record) Returns success. Now really writes to the output
10424 (begin_run, end_run) New functions.
10425 (write_initial_runs) Returns success. Initializes run_no to -1.
10426 Calls begin_run(), end_run() at appropriate times. Outputs debug
10428 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10430 (merge) New function.
10432 * heap.c, heap.h: New files. Hopefully in near-final form.
10434 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10436 * glob.c: Added write_active_file to global vars.
10438 * sort.c: Several new miscellaneous static variables.
10439 (cmd_sort_cases) Big comment fix.
10440 (perform_case_2) Renamed `do_external_sort' and completely
10442 (case_2_proc_func) Removed.
10443 (output_record, write_initial_runs, write_to_sort_cases,
10444 compare_record) New functions.
10446 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10448 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10450 * sort.c: (perform_case_2) Changed the method for allocation of
10451 lots of memory--now allocates one case at a time in hopes that
10452 more cases can be allocated with heavily fragmented memory.
10454 * var.h: (write_active_file) New global var.
10456 * vfm.c: (procedure, close_active_file, write_case,
10457 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10458 arguments to procedure() to be NULL. All references to
10459 procedure() that made use of dummy functions were changed to NULL
10461 (open_active_file) If write_active_file is non-NULL, the output
10462 device becomes DEV_PGM (a new enum).
10463 (close_active_file) Sets write_active_file to NULL.
10464 (read_from_memory) Comment fix.
10465 (record_case) Calls write_active_file() when the output device is
10468 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10470 * sort.c: New file.
10472 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10473 Fixed checking for duplicate varnames.
10474 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10476 (autorecode_trns_free) Destroys hash tables for each recoding
10478 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10480 * command.c: Added SORT CASES to cmd_table.
10481 (null_func, null_int_func) Prototyped.
10483 * descript.g: (calc_weight, calc_noweight) Computes own case
10486 * frequencies.q: (dump_statistics) Fixed problem with
10487 too-few-cases warning message.
10489 * get.c: (cmd_save_internal) Handles weighting properly.
10491 * hash.c: (hsh_dump) Output format changed.
10492 (force_hsh_insert) Actually works now, prototype changed.
10494 * list.q: (static var case_num) New variable.
10495 (cmd_list) Initializes case_num.
10496 (list_cases) Increments case_num.
10498 * var.h: Added definitions for SORT CASES. Comment fixes.
10500 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10501 fixes. `active' renamed vfm_active, `rep' renamed
10502 vfm_replacement, all references changed.
10503 (procedure) The procfunc no longer receives a case number. All
10504 references changed.
10505 (write_case) Subtle reordering.
10506 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10509 * weight.c: (get_weighting_variable) New function.
10511 * vfmP.h: New file with definitions from vfm.c.
10513 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10515 * command.c: (FILE_TYPE_okay) Commented out some tests because
10516 they're clumsy and not yet needed.
10518 * var.h: Most *_trns structures moved to their respective source
10519 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10520 (union any_trns) Changed to a typedef for trns_header.
10521 (struct input_program_pgm) Removed.
10523 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10524 was allocated in the first place.
10526 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10528 * autorecode.c: New file.
10530 * command.c: Added AUTORECODE to command table; re-enabled SET.
10532 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10534 * error.c: (vmsg) Comment fixes.
10536 * hash.c: Comment fix.
10537 (hashpjw_d) New function.
10538 (hashpjw) Reimplemented as call to more general function
10540 (internal_comparison_fn) Initializes pointers properly.
10541 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10542 (force_hsh_insert, force_hsh_find) New debugging wrapper
10545 * main.c: (main) Message fix.
10547 * output.c: (outp_read_devices) Message fix.
10549 * set.q: Comment fixes.
10550 (custom_results) Implemented Wnd/X form of subcommand.
10551 (set_routing) New function.
10552 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10554 * settings.h: (SET_ROUTE_*) New enum series.
10555 (set_results) Renamed set_results_file, all references changed.
10556 (set_messages) Removed.
10557 (glob vars set_errors, set_messages, set_results) New vars.
10559 * title.c: (get_title) Remembers to xstrdup() the result of
10560 get_rest_of_line().
10562 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10564 (union any_trns) New element `arc'.
10566 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10568 * command.c: (output_line) Removed references to set_screen.
10570 * error.c: (static var terminating) New var.
10571 (hcf) Sets terminating to 1.
10572 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10573 This prevents an infinite loop if an error occurs within hcf().
10575 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10576 statement circumlocution with `case 42000' trick.
10577 (evaluate_expression) New support for OP_STR_MIS.
10579 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10580 statement circumlocution with `case 42000' trick.
10581 (dump_node) Handles OP_STR_MIS.
10583 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10584 variables exceptions.
10585 (parse_function) Message fix.
10586 (ops[]) Added OP_STR_MIS.
10588 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10590 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10592 * glob.c: Removed set_scrnfile glob var.
10593 (init_glob) set_errorbreak set to 0 by default.
10595 * groff-font.c: Changed included files.
10596 (groff_read_font) Initializes font_arena local var correctly.
10597 (default_font) New function.
10599 * output.c: Comment fixes.
10600 (glob var disabled_devices) New variable.
10601 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10603 [GLOBAL_DEBUGGING] (reentrancy) New function.
10604 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10605 outp_iterate_enabled_drivers) Calls to reentrancy().
10606 (destroy_list) New function.
10607 (outp_done) Moved code to destroy_list().
10608 (parse_options) Parses `listing', `screen', `printer' options
10610 (configure_driver) Sets new `device' member of driver.
10611 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10613 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10614 (struct outp_driver_struct) New member `device'.
10616 * postscript.c: (find_encoding_file) Doesn't display its own error
10618 (default_encoding) New function.
10619 (switch_font) Calls default_encoding() if no encoding can be
10621 (text) Makes up a character metric if none exists for the desired
10623 (load_font) Properly copies a fallback filename. Calls
10624 default_font() for a font if none at all are known.
10626 * set.q: Comment fixes. Removed OUTPUT subcommand.
10627 (custom_listing) Calls outp_enable_device() to enable/disable
10629 (turn_screen_on) Removed.
10630 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10631 screen, printer devices.
10633 * settings.h: Comment fixes.
10634 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10637 * som-high.c: (som_submit_table, som_eject_page) Use
10638 outp_iterate_enabled_drivers() instead of iterating
10639 outp_driver_list directly.
10641 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10643 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10644 (parse_string_as_format) Handles new formats.
10645 (parse_numeric) Now handles DOT and PCT formats.
10647 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10649 (convert_date) Handle EDATE and SDATE formats.
10650 (convert_CCx) Now if there's not room for the currency characters,
10651 converts it as F format if it's positive instead of giving up
10652 quickly. Also fixed save-and-restore bug with decimal point
10654 (convert_format_to_string) Handles new formats.
10656 * misc.c: (formats[]) Added new formats.
10657 (convert_fmt_ItoO) Supports new formats.
10659 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10660 data checking. New argument, all references changed.
10662 * sfm-write.c: (write_format_spec) Supports new formats.
10664 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10667 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10669 * cmdline.c: Comment fixes.
10670 (parse_command_line) Changed return type to void.
10672 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10674 (parse_numeric) Handles international numbers (comma as decimal
10675 point). Some reformatting.
10677 * data-list.c: (parse_free) Default output format is now
10678 set_format instead of hard-coded F8.2.
10679 (read_from_data_list_list) Emits error message on undefined data
10680 only if set_undefined is nonzero.
10682 * data-out.c: (convert_E) Changes decimal point from period to
10683 comma if appropriate. Restructured. Better comments.
10684 (convert_F) Changes decimal point from period to comma if
10686 (insert_commas) Major bug with handling of negative values fixed.
10687 Also, inserts periods instead of commas if appropriate.
10688 (convert_CCx) New function.
10689 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10690 (num_to_string) Changed `.' to set_decimal.
10692 * dfm.c: Comment fixes.
10693 (dfm_close) Frees ext->line even in inline_file.
10694 (open_inline_file) New function.
10695 (open_file_r) When opening the inline file: now properly
10696 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10698 (read_record) Calls fh_close_handle() instead of dfm_close() to
10699 close the inline file. Makes a copy of the line getl_buf to avoid
10700 interlock problems.
10701 (dfm_get_record) Restructured. Now checks the return value of
10703 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10704 checking for use of inline file. No longer tries to close inline
10707 * error.c: (glob var error_already_flagged) New var.
10708 (vmsg) Message change. Now checks max number of errors/warnings,
10711 * file-handle.q: (fh_handle_name) Now allows closing of
10713 (fh_init_files) Reformatted.
10715 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10717 * getline.c: (getl_include) Fixed bug that popped up when called
10718 when file queue was empty.
10719 (read_console) Resets error_count, warning_count,
10720 error_already_flagged to zero.
10722 * glob.c: Many changes to update list of variables.
10723 (init_compat_dependent) Now this function is called whenever
10724 `compat' changes. It now sets set_seed only if it hasn't
10725 previously been referenced. It now calls
10726 lex_init_compat_dependent().
10728 * include.c: (cmd_include_at) Frees temporary buffer instead of
10730 (cmd_include) Doesn't make copy of include file name.
10732 * lexer.c: Comment fixes.
10733 (init_lex) Moved some code into new function
10734 lex_init_compat_dependent().
10735 (lex_init_compat_dependent) New function.
10736 (hex_val) Simplified.
10737 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10739 * main.c: Comment fixes.
10740 (main) Reformatted.
10742 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10743 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10744 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10745 (setup_randomize) Sets set_seed_used.
10747 * set.q: Comment fixes.
10748 (custom_results) Conditionalizes on `compat'.
10749 (custom_log) Calls custom_journal().
10750 (set_ccx) New function.
10751 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10752 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10753 when set_decimal changes. Range-checks values for MITERATE,
10754 MNEST. Message fixes.
10756 * settings.h: Comment fixes.
10757 (struct set_cust_currency) New struct.
10758 (set_cc[], set_grouping, set_seed_used) New global vars.
10760 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10761 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10763 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10765 * glob.c: Revised variables to correspond to settings.h.
10766 (init_glob) Initializes variables from settings.h properly.
10768 * set.q: Began long-overdue major revision to correspond to new
10769 philosophy. Most code changed.
10771 * settings.h: Mostly changed; reorganized, reordered, large new
10774 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10776 * get.c: (cmd_save_internal) No longer forces compression off.
10778 * sfm-read.c: (read_compressed_data) If eof is reached when
10779 reading a new instruction octet, only signal error if we're in the
10782 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10783 (struct sfm_fhuser_ext) New member `end'.
10784 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10785 (ensure_buf_space) New function.
10786 (sfm_write_case) Reimplemented in order to support compression.
10787 (sfm_close) Writes out the remaining contents of the compression
10790 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10792 * command.c: Defined SAVE and XSAVE commands in command table.
10794 * common.h: second_lowest_value is of type flt64, not double.
10796 * file-handle.h: Comment fix.
10798 * get.c: Comment fixes.
10799 (static var `trns') New.
10800 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10801 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10802 (dict_delete_run) Clears the variables and frees them now.
10803 (trim_dictionary) Sets default for compression.
10804 On KEEP subcommand, frees deleted variables as well as clearing
10805 them. Finally got the sense of the test for deleting all
10807 [DEBUGGING] (dump_dict_variables) Message fix.
10809 * glob.c: (init_glob) set_compression set to 1 by default.
10811 * list.q: Properly #includes config.h.
10813 * misc.h: New macro REM_RND_UP.
10815 * settings.h: Comment fix.
10817 * sfm-read.c: (structs sysfile_header, sysfile_format,
10818 sysfile_variable; inline function bswap_int32) Moved to new file
10820 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10821 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10823 (read_machine_flt64_info) Fixed some problems caused by confusion
10824 between flt64 and double types.
10825 (read_header) Message fix.
10826 (read_variables) Fixed set of cases in which we byte-swap sv.print
10827 and sv.write. Fixed confusion of flt64 and double.
10829 * sfm.h: (struct sfm_write_info) New.
10831 * som-high.c: (som_draw_title) Properly frees `s'.
10833 * temporary.c: (save_dictionary) Comment fix.
10835 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10836 (struct trns_header) Formatting fix.
10837 (struct save_trns) New.
10839 * vars-atr.c: (discard_variables) Comment fix.
10841 * sfm-write.c: New file, baseline release.
10843 * sfmP.h: New file, baseline release.
10845 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10847 * cmdline.c: (parse_command_line) `--version' output updated.
10848 (glob var syntax_message[]) Added my e-mail address.
10850 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10851 `illegal' to `invalid'.
10853 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10854 uncompression buffer.
10855 (sfm_close) Frees decompression buffer.
10856 (sfm_read_dictionary) Initializes decompression buffer.
10857 (buffer_input, read_compressed_data) New functions.
10858 (sfm_read_case) Restructured; now calls read_compressed_data() to
10859 handle compressed system file data.
10861 * var.h: Comment fix.
10863 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10865 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10868 * get.c: New comments. New static var `get_file'.
10869 (cmd_get) Now fully implemented. Calls discard_variables();
10870 initializes fv and lv for all variables; new debug code; sets
10871 up the dictionary; sets up the input program.
10872 (read_from_get, cancel_get) New functions.
10874 * sfm-read.c: Comment fixes.
10875 (sfm_close) New static function.
10876 (sfm_read_dictionary) Properly sets up the class of the
10877 file_handle. No longer cares what size the data is in records of
10878 type 7. Also, on failure, properly cleans up the file_handle and
10879 free()s some stuff.
10880 (read_variables) No longer thinks it knows `nval' of the
10881 dictionary. Now sets p.get.fv, etc., instead of speculatively
10883 (read_value_labels) Fixed off-by-one error in indexing of
10885 (sfm_read_case) New function.
10886 (sfm_r_class) New static var.
10888 * var.h: (get_proc) New struct.
10889 (struct variable) New member p.get.
10891 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10893 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10894 the manual's meaning.
10895 (rename_variables) New function.
10896 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10897 code. Now properly reorders the dictionary on the KEEP keyword.
10899 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10900 garbage collection.
10902 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10903 (rename_variable) New function.
10904 (free_val_lab) Reformatted.
10906 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10908 * var.h: Reindented entire file. Comment fixes.
10909 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10911 (glob var default_dict) New.
10912 (struct indirect_dictionary) Removed.
10914 * Many other source files were changed to add `default_dict.'
10915 before all references to the dictionary of the active file.
10917 * vars-atr.c: (make_indirect_dictionary) Removed.
10919 * glob.c: Reindented all variable declarations. Updated for
10920 changed var.h. Comment fixes.
10922 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10923 because now we can mainly copy dictionary structs.
10925 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10926 parse_variables) Takes dictionary instead of indirect_dictionary
10928 (parse_variables) Instead of calling make_indirect_dictionary,
10929 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10930 of `*dict.' references had to be changed to `dict->'. Removed
10933 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10935 * get.c: Added GTSV_OPT_* series of enums.
10936 (trim_dictionary, dict_delete_run) New functions.
10937 [DEBUGGING] (dump_dict_variables) New function.
10938 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10939 [DEBUGGING] Calls dump_dict_variables() to display results.
10941 * glob.c: (cmp_variable) Now a public function declared in var.h.
10943 * sfm-read.c: Turned off debug code. Comment fixes.
10944 (read_machine_int32_info, read_machine_flt64_info) New functions
10945 to parse type 7 records.
10946 (sfm_read_dictionary) Properly byteswaps several fields now.
10947 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10948 records. [DEBUGGING] Dumps dictionary.
10949 (read_variables) Sets `index' field of variables created properly.
10950 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10951 longer dumps dictionary.
10952 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10954 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10956 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10957 var before destroying any variables just to save a little time.
10959 * var.h: (struct variable) Reordered in order to make name[] the
10960 first member; this makes pointers to `variable' pointers to the
10961 variable name, simplifying avl trees, etc.
10962 (struct indirect_dictionary) New struct.
10964 * vars-atr.c: (find_variable) Rewritten for efficiency.
10965 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10967 (is_varname) Rewritten for efficiency.
10968 (parse_variables) New argument, which is a `dictionary *'. All
10969 references changed. This function now reads variable names from
10970 the dictionary passed, or from the default dictionary if NULL.
10972 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10974 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10975 rounding up. Changed many references to ROUND_UP to use this
10978 * sfm-read.c: Includes avl.h.
10979 (corrupt_msg) Induces a segfault under Checker.
10980 (macro assertive_bufread) New. Many references to bufread() now
10982 (sfm_read_dictionary) Split up into several functions. Added code
10983 to read dictionary records following the the type 2 records. Not
10984 quite complete. New variable `var_by_index'.
10985 (read_header, read_variables) New functions extracted from
10986 sfm_read_dictionary().
10987 (read_value_labels) New function.
10988 (bufread) Checks ferror() if fread() doesn't return the expected
10989 value; if ferror() is zero it's just EOF.
10990 (dump_dictionary) Stubbed out.
10992 * BTW: The source code now exceeds 50000 lines!
10994 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10996 * command.c: Added GET to cmd_table[].
10998 * list.q: Removed reference to alloca headers.
10999 (cmd_list) Gave prototype.
11001 * sfm-read.c: Added DEBUGGING comments.
11002 (sfm_read_dictionary) Checks bias correctly. Sets
11003 dict->var_by_name to NULL. Calculates long_string_count
11004 correctly. realloc's dict->var[] array to minimum size.
11005 [DEBUGGING] Calls dump_dictionary.
11006 [DEBUGGING] (dump_dictionary) New function.
11008 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11009 (restore_dictionary) If the dictionary contains a non-NULL
11010 var_by_name, uses that instead of generating one.
11011 (free_dictionary) Destroys var_by_name.
11013 * var.h: (struct dictionary) Added field `var_by_name'.
11015 * get.c: New file, not complete.
11017 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11019 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11020 (parse_num_or_range) New function.
11021 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11022 <n> THRU HIGH missing values.
11024 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11025 __attribute__((const)).
11027 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11029 * sfm-read.c: Finished reference implementation.
11031 * sfm.h: Includes var.h.
11033 * var.h: Comment fixes.
11034 (struct `variable') Reordered some fields.
11036 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11037 constants added previously.
11039 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11041 * common.h: Comment fixes. Added declaration of
11042 `second_lowest_value' as variable or macro. Made `compat_type',
11043 `pgm_state_type' into anonymous enums.
11045 * display.c: Comment fix.
11047 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11049 [!defined SECOND_LOWEST_VALUE] Added definition for
11050 `second_lowest_value' global var.
11051 (compat, pgm_state global vars) Changed types to `int'.
11052 (init_glob) Initializes `second_lowest_value'.
11054 * sfm-read.c: Continued work, not complete.
11056 * var.h: Added new MISSING_* constants to handle LOWEST and
11059 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11061 * sfm-read.c: New file, not complete.
11063 * cases.c: (vec_insert) Changed vector expansion algorithm.
11064 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11065 mucking up the RECODE transformation in particular.
11066 (envector) Harmless change in notation.
11068 dfm is now fairly well tested again.
11069 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11071 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11073 * recode.c: Comment fix.
11075 * sfm.h: Interface should be fairly final now, or at least for a
11078 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11079 (open_active_file) [DEBUGGING] Translates ccase indices into
11080 variable names now to make it easier to understand what's really
11083 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11085 * data-in.c: Comment fix.
11087 * data-list.c: Includes dfm.h.
11088 (do_reading) Uses new function dfm_push_cust().
11090 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11091 `return 1;' at end.
11093 * file-handle.h: Completely changed. Some parts split off into
11094 new file dfm.h. Implemented in file-handle.q.
11095 (enum FH_*) Removed.
11096 (struct fh_ext_class) New struct.
11097 (struct file_handle) Retained only these fields: name, norm_fn,
11098 fn, recform, lrecl, mode. New fields class, ext.
11099 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11100 close_handle, handle_name) Added `fh_' prefix to name, all
11101 references changed.
11103 * dfm.h: New file, implemented in dfm.c.
11104 (get_record, put_record, fwd_record, bkwd_record, set_record,
11105 get_cur_col) Functions moved from file-handle.h, now prefixed with
11107 (dfm_push_cust) New function.
11109 * sfm.h: New file. Incomplete.
11111 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11112 interface. Functions reordered, comments changed. Not well
11113 tested, probably full of bugs.
11114 (struct dfm_fhuser_ext) New struct.
11115 (dfm_close) New function.
11116 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11117 (open_file_w) User messages changed.
11118 (get_record) Comment fixed.
11119 (read_record) Increments ext->ln even for inline_file. Calls
11120 dfm_close() for inline_file when `END DATA.' encountered.
11121 (dfm_get_record) Experimental restructuring.
11122 (dfm_push_cust) New function.
11123 (cmd_begin_data) Detects whether the inline file was fully read by
11124 checking whether it is still open; detects whether it was read at
11125 all by checking whether the line number is greater than zero.
11127 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11128 interface. Functions reordered, comments changed. Not well
11129 tested, probably full of bugs.
11130 (init_file_handle) Removed initializers for obsolete fields, added
11132 (fh_close_handle) Much simpler, now mainly calls the class
11134 (fh_init_files) Renamed inline file internal filename.
11136 * file-type.c: Includes dfm.h.
11137 (read_from_file_type) Doesn't use dfm internal state anymore.
11139 * inpt-pgm.c, print.c: Include dfm.h.
11141 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11142 int in comparison with other int.
11144 * som-high.c: (build_target) Fixed operator precedence problem in
11145 if statement (& versus ==).
11147 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11149 * dfm.c: (read_record) Can now read fixed-length records; not
11151 (put_record) Can now write fixed-length records; not tested.
11153 * file-handle.h: FH_* defines changed to enums. New enum series
11155 (struct file_handle) New members recform, lrecl, mode.
11157 * file-handle.q: Parser changed.
11158 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11159 /LRECL subcommands. These are compatible with Windows.
11160 (init_file_handle) Initializes recform, mode fields.
11162 * q2c.c: (get_line) When outputting `!' comment lines, now
11163 increments the output file line number so that `#line' directives
11165 (make_identifier) New function that converts an arbitrary string
11166 into a valid C identifier.
11167 (dump_vars) Calls make_identifier() in two places in order to
11168 suppress some errors for bad identifiers.
11169 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11170 for NO. Allows numbers to be prefixed by underscores to make them
11171 acceptable C identifiers but still to be parsed as numbers by the
11174 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11176 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11178 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11179 was opened for writing.
11180 (open_file_w) New function.
11181 (read_record) Uses strncasecmp if available. Improved error
11182 messages, comments.
11183 (put_record) New function.
11185 * file-handle.h: Moved function comments into dfm.c and
11186 file-handle.q. Comment fixes. Removed declarations of
11187 tilde_expand() and normalize_filename().
11188 (struct file_handle) Changed `open' from boolean to enumerated
11189 field to allow for three states--closed, open for reading, open
11190 for writing--all references changed.
11192 * file-handle.q: Includes filename.h.
11194 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11195 references changed.
11196 (alloc_line) Makes allowance for line terminator characters in
11198 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11199 (print_space_trns_proc) Handles OUTFILE differences.
11201 * recode.c, sample.c: Comment fixes.
11203 * var.h: (struct print_trns) Changed boolean field `eject' to
11204 bitmapped field `options'; all references changed. New enums
11205 PRT_* for use with this field.
11207 * exception.h, test-exception.c: Removed.
11209 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11211 * ascii.c: (delineate) Turned off debug output.
11213 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11216 * data-in.c: (parse_string_as_format) Sets the entire string value
11217 to spaces, not just the short string part of it. Is this correct
11220 * data-out.c: (convert_date) Fixed DATETIME format problems with
11221 decimal places, removed debug code.
11223 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11224 middle of parsing BEGIN DATA that would cause the lexer to read
11225 from a wild pointer `prog'; now calls new function
11226 preprocess_line() in lexer.c.
11228 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11230 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11231 Now call induce_segfault() to induce the segfault.
11232 (induce_segfault) New function.
11234 * expr-opt.c: Comment fix.
11235 (parse_sysvar) New function.
11236 (parse_primary) Added system variable support--calls
11238 (global var ops) Added OP_CASENUM operator.
11240 * expr.h: Comment fixes.
11241 (OP_* enum) added OP_CASENUM operator.
11242 (struct casenum_node) New struct.
11243 (union any_union_union) New member `cas' of type `casenum_node'.
11245 * glob.c: (global var last_vfm_invocation) New var.
11246 (init_glob) Initializes last_vfm_invocation.
11248 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11250 * getline.c: (get_line) Split into get_line() and preprocess_line().
11251 (preprocess_line) New function.
11253 * var.h: Declares last_vfm_invocation.
11255 * vfm.c: (procedure) Sets last_vfm_invocation.
11257 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11259 * command.c: (parse_cmd) Fixed bad assertion related to
11262 * data-in.c: (parse_month) Implemented to parse months according
11263 to full interpretation of standard.
11264 (to_roman) New function.
11265 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11266 (parse_weekday) Bug fix (forgot to skip all the day name).
11268 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11269 up parsing of multirecord data items. Also fixed user message.
11271 * data-out.c: Comment fix.
11272 (year2, year4, convert_date, convert_time, convert_WKDAY,
11273 convert_MONTH) New functions to support time & date output.
11274 (convert_format_to_string) Calls new time & date output routines.
11276 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11278 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11281 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11283 * misc.c: (global var formats) Fixed declarations of DATETIME,
11286 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11287 the output_char buffer.
11289 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11290 memory bug. Fixed user messages.
11292 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11294 * Removed #pragma argsused from lots of places.
11296 * data-in.c: Implemented zoned decimal and time-date formats.
11297 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11300 * data-out.c: Implemented zoned decimal format.
11302 * expr.h: Moved yrmoda() declaration here from exprP.h.
11304 * misc.c: (global var formats) Minor fixes--added
11305 FCAT_SHIFT_DECIMAL to formats N and Z.
11306 (convert_fmt_ItoO) Added support for format Z.
11308 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11310 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11312 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11313 som_check_workspace() that is activated between commands.
11315 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11318 * list.q: (begin_row) Changed title expansion style from
11319 SOPT_X_VERT to SOPT_X_SHSP.
11321 * som-frnt.c: Now includes `somP.h'.
11322 (som_push_workspace, som_pop_workspace) New functions that, taken
11323 together, form a solution to the recursive table building problem
11324 mentioned yesterday. Surrounded every table output routine
11325 throughout the program with calls to these functions.
11326 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11327 (som_create_table) Checks that there's an active workspace.
11328 (som_destroy_all_tables, som_crush) Removed.
11330 * som-high.c: (global var som_preserve_tables) Removed, all
11331 references deleted.
11332 (som_submit_table) Checks that there's an active workspace.
11333 (dump_columnated_table) Doesn't columnate tables that would have
11334 just one row per column.
11335 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11336 (som_dump_crush_page) Moved row number labels from left side of
11337 tables to right side.
11338 (som_get_table_size) Added support for SOPT_X_SHSP.
11340 * som.h: New cell expansion type SOPT_X_SHSP.
11342 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11344 (global var curtab_arena) Moved from som-frnt.c.
11346 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11348 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11349 that causes bad location warnings to be suppressed.
11350 (delineate) Saves current font when calling draw_text(); fixed
11351 handling of NULLs when backing up. Also fixed line-wrapping bug.
11353 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11354 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11356 * common.c: Added code to cause assertion failure to dump core
11357 when run under Checker.
11359 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11360 there are still bugs.
11362 * glob.c: (__eprintf) Removed.
11364 * list.q: Inserted som_preserve_tables kluge that prevents tables
11365 from being thrown away due to recursive table building through
11366 som_output_line being called from a transformation during the LIST
11367 procedure invocation. This is a general problem that must be
11368 solved in a better way since it applies to all procedures in
11370 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11371 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11373 * numeric.c: Fixed several errors in the form of msg() calls.
11375 * print.c: Updated for use of som.
11376 (dump_table) Reimplemented.
11377 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11378 Calls som_output_text() instead of outs_line().
11380 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11382 (som_output_text) Function moved from som-low.c. Interface
11385 * som-high.c: (som_preserve_tables) New global public variable
11387 (som_submit_table) Destroys the tables only if som_preserve_tables
11389 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11390 one subrow per row. Now labels subrows if there's more than one
11392 (dump_crush_table) Added wishlist comment.
11393 (som_eject_page) New public function declared in som.h.
11395 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11396 more than one subrow per row.
11397 (som_output_text) Moved to som-frnt.c.
11399 * som.h: (SOM_TOPT_PRESERVE) Removed.
11401 * title.c: (get_title) Changed interface.
11402 (cmd_title) Changed `title' to `outp_title'.
11403 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11405 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11407 * list.q: (flush_table) Conforms to new partial options in
11408 som_submission_form.
11410 * som-high.c: (paginate_horizontally) Changed form of subrow
11412 (build_target) Omits spacing before table if
11413 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11414 (dump_crush_page) Changed interface. Only trims bottom rule if
11415 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11416 (dump_crush_table) Handles partial tables.
11417 (output_row_label) New function.
11418 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11419 rule on the right edge of narrow subrows.
11421 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11422 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11423 All references updated.
11425 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11427 * misc.c: Comment fix.
11429 * som-high.c: (examine_table) Treats crushed tables separates for
11430 purpose of determining header size.
11431 (paginate_horizontally) Allots space for line numbers in crushed
11432 tables with lots of subrows per row. Calculates the `maximum page
11433 width', the width of the widest horizontal page.
11434 (build_target) Removed trim argument; all references changed.
11435 Stricter assertions. (dump_crush_page) New function.
11436 (dump_crush_table) Reimplemented.
11438 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11439 (som_dump_crush_page) Reimplemented, interface changed.
11441 * somP.h: Many many new helper macros for use with crushed tables.
11442 (global var som) Removed `tv', `cum_y' members; all references
11443 removed. New members `mpw', `digit_space'.
11445 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11447 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11448 variable, changed to constant 1024.
11449 (arena_ca_strdup) Changed `sizeof(a_string)' to
11450 `sizeof(c_string)'.
11451 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11452 `(c_string *)' to `(char *)'; this fixed some offset problems.
11454 * filename.c: (readlink_malloc) Changed initial allocation from
11456 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11459 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11460 &fm->owner in several places.
11462 * som-high.c: (output_table) Changed interface to rest of world.
11463 (examine_crush_table) Removed. Crushed tables are re-broken now,
11464 in preparation for rewrite.
11466 * som.h: Comment fix.
11468 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11470 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11471 itself in the cleanup stage.
11473 * descript.q: (display) At least temporarily, changed the table
11474 format to a crushed table.
11476 * list.q: (begin_row) At least temporarily, added horizontal lines
11479 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11480 the horizontal "headers," that is, to the width of the far left
11481 and far right rules.
11482 (justify_pagination) Sets som.th to the width of the widest row
11483 in the crushed table. Fixed inner loop off-by-one error.
11485 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11488 * somP.h: Comment fix.
11490 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11492 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11493 before closing it; also, opens the constructed filename `s'
11494 instead of f->filename.
11496 * postscript.c: Moved initialization of x->loaded, x->prop,
11497 x->fixed, x->current, also the add_encoding() calls, into
11499 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11500 sets x->last_font to NULL; sets x->next_combo to zero.
11502 * som-high.c: (crushed_row_height) Moved definition farther up.
11503 (som_submit_table) Doesn't calculate line width, font size until
11504 after calling open_page(), to accomodate changes to PostScript
11506 (vert_headers) Removed; equivalent functionality moved to
11507 examine_table(), examine_crush_table().
11508 (justify_pagination) Replaced with different algorithm.
11509 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11510 at the bottom of the page.
11512 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11514 * command.c: Added cmd_list back into cmd_table.
11516 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11517 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11519 * list.q: (flush_table) Updated to new som_submission_form format.
11521 * som-frnt.c: Comment fix.
11523 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11524 (output_table) Calls som_get_table_size() directly; handles
11526 (examine_crush_table) New function; calls vert_headers().
11527 (examine_table) Moved some code into new function, vert_headers().
11528 (justify_pagination) New function.
11529 (dump_plain_table) Removed `static' from `cy'.
11530 (dump_crush_table) New function.
11532 * som-low.c: (som_dump_crush_page) New function.
11534 * som.h: Comment fixes.
11535 (enum SOM_TOPT_CRUSH) New.
11536 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11537 Temporarily set to zero to make do with LIST procedure.
11539 * somP.h: Re-ordering.
11541 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11543 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11545 * somP.h: New file for use by som-high.c, som-low.c.
11547 * q2c.c: Added definition for VME.
11548 (get_line) Now dumps `!' comment lines to the output file
11551 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11552 set.q: Changed format of `!' comment lines.
11554 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11556 * All source files: Added copyright notice.
11558 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11559 longs in msg() calls.
11561 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11563 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11565 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11567 * output.c: (outp_read_devices) Changed criteria for
11568 distinguishing different types of lines.
11570 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11572 * cmdline.c: Changed syntax message.
11574 * filename.c: (good_getcwd) Bug fix (?).
11575 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11577 (search_path) Appends DIR_SEPARATOR to directory name only if it
11578 does not already end with one.
11580 * glob.c: Checks STAT_PAGER envvar before PAGER.
11582 * output.c: Checks environment variables instead of just local
11585 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11587 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11588 when the pointer passed to the function was within the arena
11589 itself, so that it couldn't properly be set to NULL _after the
11592 * command.c: Re-enabled DISPLAY.
11594 * display.c: Rewritten to handle tables. Untested.
11596 * filename.c: (search_path) Fixed memory leak.
11598 * frequencies.q: (cmd_frequencies) Frees v_variables.
11599 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11600 (cleanup_freq_tab) New function to garbage collect.
11601 (dump_full) Elegantized.
11603 * main.c: New comment.
11605 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11607 * postscript.c: Comment fix.
11608 (release_fontmap, free_font_entry) New functions.
11609 (ps_init_driver) Sets free_font_entry() as the freefunc for
11610 hashtable `loaded'. Calls release_fontmap() when destroying a
11611 driver; also frees the output filename; also frees the
11612 ps_driver_ext block.
11613 (free_ps_encoding) Frees the filename as well as the encoding
11615 (output_encodings) Frees the line buffer and pops the msg-filename
11617 (read_fontmap) Frees the fontmap filename and the line buffer.
11618 (postopen, preclose) Misc. garbage collection fixes.
11619 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11620 to NULL; this fixes some output problems.
11621 (text) Handles TAG_NEWLINE. Untested.
11623 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11624 (som_set_string) Removed. All references changed to
11626 (som_set_text) Rewritten. New interface. More general.
11628 * som.h: Minor format changes.
11629 (struct som_value_cell) Removed; all references changed to
11631 (enums SOT_*) Changed.
11633 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11635 * command.c: Re-enabled SPLIT FILE.
11637 * postscript.c: Comment fix.
11639 * som.h: Added `SOT_NONE'.
11641 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11643 * vfm.c: (dump_splits) Reimplemented.
11645 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11647 * Compiled the project under gcc 2.7.2, which gave some new
11648 warnings. This led to many additions of casts from unsigned to
11649 int sprinkled throughout the code.
11651 * arena.c: Many uses of `unsigned' changed to `size_t'.
11653 * command.c: Added END FILE, END REPEAT to command table.
11654 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11655 (find_command, FILE_TYPE_okay) Not commented out anymore.
11656 (parse_cmd) Calls FILE_TYPE_okay again.
11657 (output_line) Added calls to som_output_text() to put the line
11658 in the output files.
11660 * common.c: (macro VME) Format changes.
11661 (xstrdup) Asserts that its argument is not NULL.
11663 * data-list.c: Implemented dump_fixed_table().
11665 * inpt-pgm.c: Formatting changes. Comment changes.
11666 (end_case_proc) Renamed end_case_trns_proc.
11667 (cmd_end_file, end_file_trns_proc) New functions.
11669 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11671 * misc.h: (local_strdup) New macro corresponding to strdup() but
11672 allocating its data through local_alloc() if possible--that is, if
11675 * postscript.c: Comment changes.
11676 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11677 (output_line, add_string) New macros supporting
11678 output_encodings().
11679 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11680 substitution vars. Calls output_encodings() when a line
11681 consisting of `!encodings' is encountered.
11682 (preclose) Some code moved into quote_ps_string().
11683 (dump_line) Changed into macro supporting dump_fancy_line().
11684 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11685 command when appropriate.
11686 (write_text) Fixed `literal_char' array (I think it's fixed, at
11688 (text) Fixed bug when width was zero. Now exits immediately on
11689 zero height_left. Now, when executing `goto restart;', checks
11690 that cp<end, so that we don't read beyond end-of-string. Also,
11691 outputs the correct code to the output file by outputting the code
11692 from the metric instead of the internal metric index.
11694 * repeat.c: (cmd_end_repeat) New function.
11696 * som.c: (var som) `headers' renamed `options' and semantics
11697 changed. All references changed.
11698 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11699 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11701 (som_text_table) Removed.
11702 (som_output_text) New function.
11704 * som.h: (struct som_submission_form) Removed `header', `reuse',
11705 replaced with bitmapped field `options'.
11706 (SOM_TOPT_*) New enum set for som_submission_form.options.
11707 (SOT_*) New enum set for som_output_text().
11709 * temporary.c: (copy_variable) When copying the var label, only
11710 calls xstrdup() if it's non-NULL.
11712 * var.h: (enum type `vartype') Removed; all references changed to
11715 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11718 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11720 * font.h: Comment changes.
11722 * groff-font.c: (groff_read_font) Initializes `name' field to
11723 NULL. Handles `encoding' field.
11725 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11727 * postscript.c: (struct font_entry) Removed `position' field.
11728 (struct ps_font_combo) New struct.
11729 (struct ps_driver_ext) Removed field `next_position'. New fields
11730 `combos', `next_combo'. `last_font' field changed from
11731 `font_entry *' to `ps_font_combo *'.
11732 (ps_init_driver) Reformatted; handles new fields. When
11733 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11735 (get_encoding, find_encoding_file) New functions.
11736 (add_encoding) Some code moved out into find_encoding_file().
11737 (postopen) Changed value for ${title}.
11738 (preclose) Sets `loaded' field to NULL after destroying the hash
11740 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11742 (ps_text_set_font_by_position) Figures out the current family if
11744 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11745 (switch_font) Implemented.
11746 (write_text) Calls switch_font() more often. Format changes.
11747 #undefs its macros after they're no longer useful.
11748 (text) Changed `continue' at one point to a jump to the top of the
11749 loop because we don't want `separate' reset to 0 at that point.
11750 (load_font) No longer sets `position' in the font_entry created.
11752 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11754 * font.h: (struct font_desc) New member `encoding', which is not
11755 properly handled yet.
11757 * glob.c: (init_glob) Some new i18n code, which is probably
11760 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11761 `size' local from `int' to `size_t'.
11763 * postscript.c: New driver configuration parameter `auto-encode'.
11764 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11765 (struct font_entry) New member `position'.
11766 (struct ps_driver_ext) Reordered. New hash table member
11767 `encodings'; new members `next_position', `next_encoding',
11768 `last_font'. Members `current', `prop', `fixed' changed from type
11769 `font_desc *' to `font_entry *'; all references changed.
11770 (struct ps_encoding) New struct.
11771 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11772 free_ps_encoding, add_encoding) New functions.
11773 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11774 x->output_options. Initializes new members of ps_driver_ext.
11775 Changed default value for prologue_fn, encoding_fn. Calls
11776 read_ps_encodings after loading default fonts.
11777 (option_tab[], ps_option) Handle new configuration parameter.
11778 (switch_font) New function.
11779 (struct output_char) `font' member changed from `font_desc *' to
11780 `font_entry *'. New member `separate'.
11781 (read_fontmap) Changed `size' from `int' to `size_t'.
11782 (output_line, put_number) New macros for write_text().
11783 (write_text) Optimizes text output by consolidating multiple
11784 calls to PostScript `show' operator.
11785 (text) Keeps track of when text arguments can't be consolidated by
11786 write_text(), and marks those spots in the output stream.
11787 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11788 the font hasn't been switched to by switch_font(), which is where
11789 the position is important--the PostScript is what cares about the
11792 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11794 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11795 call a NULL free_func.
11796 (hsh_rehash) Elegantized.
11797 (hsh_probe) Fix bug that manifested when the table was expanded
11798 and thus had to change location in memory. Good thing
11799 too--otherwise could have been much more subtle.
11800 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11801 (hsh_foreach) New function for hash table iteration.
11803 * hash.h: (struct hsh_iterator) New.
11805 * lexer.c: (parse_tagged_quote) Font and family name strings in
11806 tags are now null-terminated.
11808 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11810 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11811 documented. (Never before tested?)
11813 * output.h: Comment changes.
11815 * postscript.c: New driver options `optimize-text-size',
11816 `optimize-line-size', `max-fonts-simult'. New enum set for
11817 specing cached line types. Comment fixes.
11818 (struct line_form) New struct.
11819 (struct ps_driver_struct) New members `text_opt', `line_opt',
11820 `max_fonts', `lines'.
11821 (ps_init_driver) Initializes new members of ps_driver_struct.
11822 (user option type enum set) New member `nonneg_int_arg'.
11823 (static var option_tab[]) Supports new options.
11824 (ps_option) Handles new options.
11825 (find_ps_file) Made static. No longer calls hsh_dump().
11826 (ps_get_var) Made static.
11827 (preclose) Dumps out proper DSC trailer.
11828 (ps_open_page) Elegantized.
11829 (ps_close_page) Calls dump_lines() if appropriate.
11830 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11831 wrappers around line().
11832 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11833 dump_lines, hash_line, free_line, line) New functions for support
11835 (write_text, text) Made static.
11836 (text) Added to font support, not finished.
11838 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11840 * font.h: (struct font_desc) New members ascent, descent.
11842 * groff-font.c: (groff_read_font) Calculates font ascent and
11843 descent from the ascent and descent of the `d' and `p' characters,
11844 respectively, as per a suggestion on comp.fonts.
11846 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11847 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11849 (write_text) Handles text right-justification and centering (not
11850 full justification). Still very inefficient. (One output line
11852 (struct output_char) Added fields for font and font size.
11853 (text) Many bugfixes.
11855 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11857 * cmdline.c: (usage) Calls outp_list_classes().
11859 * font.h: Comment fix.
11861 * groff-font.c: New exported global var `space_index'.
11862 (groff_init) New function to initialize `space_index'.
11863 (hash_kern) Casts result to unsigned.
11864 (font_name_to_index) Renamed font_char_name_to_index. All
11865 references changed. Also, now returns the value of `space_index'
11866 when passed an ASCII space character as an argument. Fixed
11868 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11869 Handles passed NULL pointers properly.
11871 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11874 * output.c: (outp_list_drivers) Removed. Removed all references.
11876 * output.h: Comment fixes.
11878 * postscript.c: (ps_open_global) Calls groff_init().
11879 (output_char) New structure.
11880 (write_text) New function.
11881 (text) No longer stubbed out! Now the output is correct--with a
11882 few exceptions, one of them being that the page has to be held
11883 upside down into a mirror.
11885 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11887 * font.h: Comment fix.
11889 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11890 All callers changed.
11891 (number_to_index) Renamed font_number_to_index, made extern. All
11893 (font_get_kern_adjust, font_get_char_metrics) New functions.
11895 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11897 * postscript.c: Changed default line width back to 1/2 point.
11898 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11899 in the center of the space allotted for them, not just a fixed
11900 offset from the edge of the space; this fixes some bugs.
11901 (ps_line_intersection) Now supports all command line styles.
11902 (ps_text_get_size) Bug fix in computation of em width.
11903 (text) New function, the meat behind ps_text_metrics and
11904 ps_text_draw. Not complete.
11905 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11906 ascii.c; call text().
11908 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11910 * arena.c: (arena_free) Assert that the argument is non-NULL.
11912 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11913 only if old_kern is non-NULL.
11915 * postscript.c: (ps_init_driver) Changed default line width to 1
11917 (postopen) New prologue variables.
11918 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11919 more of the common line styles properly, but not all.
11920 (ps_text_metrics) Fixed problem with this stubbed out version that
11921 kept it from taking font sizes into account.
11923 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11925 * arena.c: (arena_malloc) Bug fix.
11926 (arena_dump) [GLOBAL_DEBUGGING] New function.
11928 * ascii.c: Comment fix.
11929 (count_fancy_chars, delineate) Now static functions.
11931 * filename.c: (interp_vars) Bug fixes.
11933 * font.h: Comment fixes.
11935 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11936 beginning in case we have an error message to display before
11937 initializing the display.
11939 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11941 (groff_read_font) Bug fixes.
11942 (name_to_index) Increments hash.used. Sets `name' field of hash
11944 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11946 * hash.c: Return type changed.
11948 * postscript.c: Continued development. Now marks lines on the
11949 paper, but very buggy.
11951 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11953 * Changed comments in many source files from `/* xxx /* yyy */' to
11954 `/* xxx */ /* yyy */' for cleanliness.
11956 * arena.c: (arena_sd_strdup) New function.
11958 * ascii.c: (struct ascii_driver_ext) New member `file'.
11959 (ascii_init_driver) Fills out member `file' for initing; uses
11960 close_file_ext for closing drivers.
11961 (ascii_option) Changed %.*s back to %s because the a_string's are
11962 always null-terminated.
11963 (postopen, preclose) New functions.
11964 (ascii_open_page) Uses new style of open_file_ext.
11965 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11966 instead of this->output.
11967 (__assert_fail) Removed.
11969 * cmdline.c: Changed syntax_message[].
11971 * error.c: #include's <readline/history.h> only if the history
11972 library is available, not if just the readline library is
11975 * filename.c: (expand_line) Removed alloca() support.
11976 (interp_vars) No longer tilde-expands argument. Limit on output
11978 (tilde_expand) Now treats argument as path rather than filename.
11979 [!unix] Now is a no-op function.
11980 (search_path) Better verbose message formatting.
11981 (open_file, close_file) Comment fixes.
11982 (close_file) [!unix] Doesn't bother with pipes.
11983 (open_file_ext) Completely rewritten, interface revamped.
11984 (close_file_ext) New function.
11986 * font.h: Comment changes.
11988 * frequencies.q: Removed AIX alloca support since it doesn't use
11991 * hash.c: Comment changes & additions.
11992 (hsh_create) Initializes entire table instead of first M entries.
11993 (hsh_probe) Stupid bug fixed. Now it works.
11994 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11996 * main.c: (parse) Detects EOF properly in token-eating loop.
11997 Should the STOP token have its value changed to 0?
11999 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12000 (blp_getline) Now it's a macro.
12002 * output.h: (struct outp_driver) Removed members output, filename.
12004 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12005 drivers in driver table.
12006 (outp_read_devices) Frees buf. Warns if there are no active
12008 (outp_configure_clear) Sets outp_configure_vec to NULL after
12009 deleting its elements.
12010 (configure_driver, destroy_driver) Removed references to output,
12011 filename members of outp_driver.
12012 (outp_evaluate_dimension, internal_get_paper_size,
12013 outp_get_paper_size) New functions.
12015 * postscript.c: Continued development. Now links but doesn't make
12016 any marks on the page. Lotsa bugs I suppose.
12018 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12020 * str.h: Comment changes.
12022 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12024 * Removed dependencies on non-nested comments in several files.
12025 Also removed references to (unix || __unix__) in #if's since
12026 prefh.orig makes those two equivalent.
12028 * ascii.c: (ascii_open_global) Creates ascii_arena.
12029 (ascii_close_global) Destroys ascii_arena.
12030 (ascii_init_driver) Doesn't create ascii_arena.
12031 (ascii_copy_driver) Removed.
12032 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12033 (outp_class ascii_class) Removed ascii_copy_driver reference.
12035 * frequencies.q: Now can display all statistics except median.
12036 Still not finished.
12038 * output.c: Handles outp_class.ref_count so output class
12039 destructors are called properly.
12040 (add_class) Sets ref_count to 0.
12041 (configure_driver) Initializes class if ref_count++ is 0.
12042 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12043 class output file name.
12045 * output.h: (struct outp_class) Removed copy_driver, inited.
12048 * postscript.c: Completely replaced but not finished.
12050 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12052 * approx.h: #includes <float.h>.
12054 * arena.h, arena.c: Many functions changed to take an arena **
12055 instead of an arena *, for consistency. All callers changed.
12056 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12057 (arena_destroy) Sets *A to NULL.
12059 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12060 assertion that `width' be positive.
12062 * command.c: Removed #if's from cmd_table.
12063 (walk_cmdtable_func) [0] New function (debug code).
12064 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12065 (parse_cmd) Doesn't return failure for unimplemented commands.
12067 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12068 (SYSCODE) New constant macro.
12070 * descript.q: Checks for positive n_variables before performing
12073 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12074 avl_find instead of &fp as arg 2.
12076 * frequencies.g, frequencies.q: Continued updating; now compiles &
12077 works again, but not complete.
12079 * main.c: Changes to user messages.
12081 * misc.c: (reverse) [0] New function.
12083 * settings.h: Comment removed. #includes "common.h".
12085 * som.c: (som_set_null) New function.
12086 (som_set_value, som_set_string, som_set_text) More detailing
12088 (som_set_float) Implemented function.
12089 (dump_columnated_table) Bug fix regarding page breaks.
12090 (draw_cell) Bug fix regarding text that spilled out of a cell.
12091 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12093 (get_cell_size) Support SCON_EMPTY cells.
12094 (get_table_size) When calculating rules' widths and heights, mask
12095 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12097 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12099 (struct som_submission_form) New member `header'; all users
12102 * val-labs.c: (get_label) User messages changed.
12104 * var.h: Changed FREQUENCIES structures.
12106 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12109 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12111 * approx.h: Definition of EPSILON now depends on system's
12112 DBL_EPSILON. Removed GNU C specific code.
12113 (cmpapx) Renamed approx_compare.
12115 * frequencies.g, frequencies.q: Continued updating; still doesn't
12118 * groff-font.c: (name_to_index) Fix bug that kept it from
12121 * hash.c, hash.h: Completed work.
12123 * var.h: Changes to freq_tab, frequencies_proc.
12125 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12128 * hash.c, hash.h: New files. Not completed.
12129 * Makefile.am: Added hash.c to source file list.
12130 * font.h: (struct font_desc) New member kern_size_p.
12131 * groff-font.c: Uses hash.h.
12132 (hashpjw) Moved to hash.c.
12133 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12135 (static var hash) New member size_p.
12136 * var.h: Includes hash.h.
12137 (struct freq_tab) Changed AVL_TREE to hash_tab.
12139 * vars-prs.c: Comment, formatting fixes.
12141 * frequencies.g, frequencies.q: Continued updating. Not yet
12144 * formats.c: Bug fix.
12146 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12148 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12149 * descript.g: Comment fixes.
12150 * descript.q: Comment fixes. Moved some declarations into var.h.
12151 Made dsc_info a static table. Updated FIXMEs.
12152 (internal_cmd_descriptives) Beautified.
12154 * frequencies.q: Started updating into working order.
12155 * frequencies.g: New file analogous to descript.g.
12156 * var.h: Comment fixes. Added structures for FREQUENCIES.
12158 * som.c: Removed vestiges of crushing and partial table support.
12160 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12162 * Many more changes to som.c especially, but these will not be
12163 documented as I have resolved to remove them. This patchlevel is
12164 being released solely so that I can fall back to it if I decide
12165 that removing the changes is not a good idea.
12167 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12169 * som.c: (global var som) New member `cum_y'.
12170 (build_target) Properly handles titles for partial tables.
12171 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12172 Merged into single new function dump_partial(). Fixed problem
12173 with titles on partial tables.
12174 (dump_table) Calls dump_partial() for all parts of partial tables.
12175 (dump_page) Criteria for drawing title changed.
12177 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12179 * command.c: (cmd_table) Added LIST, WEIGHT.
12181 * command.c: (cmd_remark) No longer frees `s' since it's not
12182 dynamically allocated.
12184 * data-out.c: (convert_f) Now correctly handles the case where
12185 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12186 number of decimals.
12187 (som_destroy_all_tables) Removed argument. All callers changed.
12188 (som_vline, som_hline) Argument validity checking corrected.
12189 (som_set_value) Implemented half-heartedly.
12190 (replicate_table) Copies tables piece-by-piece when using Checker.
12192 * som.h: New line style SLIN_1THIN, currently equivalent to
12193 SLIN_0. New enum set SOM_SUB_*.
12194 (struct som_submission_form) Removed `seq_no'. Added `type'.
12196 * list.q: Newly working file; uses partial tables.
12198 * som.c: (som_reduce_table) Renamed som_set_table_height().
12199 (som_crush) Removed argument `group'.
12200 (global var som) Removed `nt', `seq_no'. Added `type'.
12201 (som_submit_table) Arguments changed.
12202 (output_table) Removed partial table code.
12203 (build_target) New arg; partial table support added. All callers
12205 (dump_plain_table) Removed partial table code.
12206 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12207 (dump_table) Supports partial tables.
12208 (dump_page) New argument to allow not drawing top and/or bottom
12209 headers. All callers changed. Supports partial tables.
12211 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12213 * data-out.c: Changed `#include <approx.h>' to `#include
12215 (convert_F) Comment fix. Now won't print `-.000', etc.
12217 * descript.q: Now Z-scores work, although there appears to
12218 be a bug (which might actually be in data-out.c:convert_F()).
12219 (descriptives_trns_proc, descriptives_trns_free) New functions.
12220 (run_z_pass) Implemented.
12222 * var.h: Comment fixes.
12223 (dsc_z_score, descriptives_trns) New structs.
12224 (descriptives_trns) Added to any_trns as `dsc'.
12226 * error.c, error.h: New error class, IS (Installation Script
12227 error), used in those instances where the error is in the
12228 installation, but there is a script file or installation file that
12229 can be usefully referred to.
12231 * output.c: Change many IE classes to IS classes.
12233 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12234 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12235 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12236 include the corresponding header?
12238 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12239 Don't bail out if termcap can't be read.
12241 * som.c: (som_destroy_table) Removed.
12242 (som_reduce_table, som_destroy_all_tables) New functions.
12243 (som_crush) New function, not implemented.
12245 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12246 som_submission_form. Function prototypes revised.
12248 Outputting huge tables (1000s of rows) a few rows at a time
12249 is supported, though untested. May even break everything.
12250 Actually, the code doesn't even compile right now.
12251 * som.c: (struct som) New fields htv, nt, seq_no.
12252 (som_submit_table) Multiple arguments changed to a single
12253 pointer to struct submission_form. Only increments subtable_num
12254 if seq_no is zero. Only destroys table if it's not going to
12256 (replicate_table) New function.
12257 (output_table) Comment fix.
12258 (examine_table) Changed inline code to code calling
12259 replicate_table(). Calculates htv. Supports partial tables.
12260 (draw_title) Removed comment.
12261 (build_target) Only allows for title on first part of partial
12263 (dump_plain_table) Only resets table chunk number on first part
12264 of partial tables; FIXME: doesn't work quite right. Supports
12266 (dump_page) Titles only on first part of partial tables.
12268 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12270 * Thanks to an unreliable IDE hard drive, I have spent the last
12271 day reconstructing my Debian GNU/Linux installation and redoing
12272 the previous day's changes--somehow I managed to save every file
12273 except for output.c and output.h. So the following changes could
12274 really be considered independent of the output.c, output.h changes
12277 * output.h, output.c: Moved the outp_configure_vec global var,
12278 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12279 outp_configure_vec is now static.
12281 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12283 * The entire philosophy behind configuration of the output drivers
12284 changed. Now there is a termcap-type configuration where drivers
12285 to be read are determined beforehand, rather than parsing the
12286 entire output init file and storing it in memory & deciding what
12287 to actually use later. Faster & more memory-efficient at the same
12290 * output.c: Comment fix. Removed outp_init_drivers global var.
12291 Removed all references to synonyms. New structure outp_defn. New
12292 global vars outp_macros, outp_configure_vec.
12293 (search_name, delete_name, add_name, check_configure_vec,
12294 expand_name, find_defn_value) New static functions.
12295 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12296 outp_read_devices) New extern functions.
12297 (outp_init) Much functionality moved into outp_read_devices.
12298 (outp_read_devices) Format of output init file changed; name of
12299 file is `devices' rather than `output' to avoid Makefile
12301 (outp_clear) Renamed outp_done.
12302 (outp_list_classes) Bug fix, cleaned up.
12303 (outp_list_drivers) Not implemented anymore.
12304 (outp_configure_driver) Now a static function; simplified; now
12305 interpolates macros; supports new structure.
12306 (outp_enable_driver, match_synonym) Removed; all references
12308 (find_driver) First argument removed.
12310 * output.h: Global var outp_init_drivers removed; new structure
12311 outp_names; new enum set OUTP_S_*; new global var
12312 outp_configure_vec; function prototypes for output.c exports
12315 * main.c: (main) Calls outp_read_devices() after parsing the
12318 * cmdline.c: (parse_command_line) New option -v --verbose;
12319 --version changed to -V. --device option changed syntax to just
12320 take a single device name. Accepts key=value declaration of
12321 output init file macros. Syntax message updated.
12323 * filename.c: (expand_line) New function.
12324 (interp_environ_vars) Renamed interp_vars; no longer uses
12326 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12327 overridden by real environment vars.
12328 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12329 * filename.h: interp_environ_vars() renamed interp_vars().
12331 * error.c, error.h: Added extern variable `verbosity', message
12334 * error.c: (vmsg) Support message class MM.
12335 (verbose_msg) New function.
12337 * descript.q: (generate_z_varname) Bug fix in generation of
12339 (dump_z_table) Bug fix in column headers.
12341 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12342 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12343 OPS_DONE]. Writes the uninit string when the driver is closed.
12344 (ascii_open_page) Write the init string before the first page.
12345 (output_shorts) Form of main loop changed from `while' to `for'.
12346 Bug fix with overstrikes: the character is printed *after* the
12347 backspace. Eliminated a lot of `& 0xff' modifiers.
12348 (advance_to_left_margin) New function.
12349 (return_carriage, output_lines) Handle left margin.
12351 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12353 * ascii.c: New option `carriage-return-style'.
12355 * ascii.c: (count_fancy_chars) New function.
12356 (delineate, text_metrics) Use new function; bug fixes regarding
12358 (text_draw) Bug fix with rich text.
12359 (output_string, output_shorts) Reordered.
12360 (output_shorts) Now handles boxchars and some overstrike font
12362 (output_char, return_carriage) New functions.
12363 (output_lines) Now handles overstriking and font changes properly;
12364 some code moved to output_shorts.
12366 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12369 * ascii.c: New member `debug' in ascii_driver_ext.
12370 (ascii_init_driver, delineate) Uses new member.
12372 Now you can set a vertical height on writing text.
12373 * ascii.c: (delineate) Keeps track of vertical position.
12374 (text_draw) No longer considers fully justified text an internal
12377 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12379 Tables' titles are drawn; they can have variable height.
12380 * som.c: `som' struct has new member, title_height.
12381 (draw_title) New argument. Moved within file. All caller
12383 (build_target) New argument, amount of space needed for first row.
12384 Calculates height of title, takes that into account. All callers
12386 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12388 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12390 (dump_columnated_table) Organized for readability.
12391 (dump_page) Makes use of som.title_height.
12393 * som.c: Many comment bug fixes.
12395 * descript.q: (try_name, generate_z_name) Bug fix regarding
12396 generation of Z-score variable names.
12397 * var.h: Removed num from descriptives_proc; all referents removed.
12399 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12401 * ascii.c: (ascii_line_horz, ascii_line_vert,
12402 ascii_line_intersection) Added debugging code.
12404 Added a descriptive line above each table to describe it.
12405 * command.c: (parse_cmd) Calls som_new_series.
12407 * som.c: New static vars table_num, subtable_num. New `som'
12409 (dump_page) New arguments.
12410 (som_submit_table) Handle new variables.
12412 * som.c, som.h: (som_submit_table) New arguments. All callers
12414 (som_new_series) New function.
12415 (build_target) Makes room for extra line.
12416 (draw_title) New function.
12417 (dump_page) Calls draw_title. Bug fix: doesn't always set
12420 Columnation of tables support.
12421 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12423 * som.c: Deleted references to fr, lr, ri.
12424 (som_columnate) Bux fix: sets group member of table.
12425 (som_add_options) Function removed.
12426 (dump_table) Split into three functions; extensively reworked.
12428 * descript.q: (dump_z_table) Better output table formatting; added
12429 title support to correspond to som.h changes.
12430 (display) Title support.
12432 * output.h: Added OUTP_T_NONE.
12434 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12436 * descript.q: Improved handling of Z scores; still not perfect.
12438 * output.h, ascii.c: Added hook for getting em width of current
12441 * som.c: Uses new em-width hook. Added debugging code to
12443 (som_columnate) New argument.
12444 (som_add_options) Removed.
12446 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12448 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12449 rules as a property of the table instead of as a property of the
12452 * ascii.c: Added `header' to table of options.
12454 * descript.q: Added even shorter statistic names; modified to work
12455 with new som interface.
12457 * misc.c (blp_getdelim): Bug fix.
12459 * version.c: includes 'conf.h'.
12461 ----------------------------------------------------------------------
12464 version-control: never
projects / pspp-builds.git / blob