1 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
3 * data-list.c: (data_list_trns_free) Don't free the argument
4 because cancel_transformations() will do that itself.
5 (data_list_source_destroy) Destroy the argument to
6 data_list_trns_free(), because it no longer does so itself.
8 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
10 * data-out.c: (format_and_round) Don't output leading `-' if value
13 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
17 * som.c: (output_encodings) If some cell in the table won't fit
18 with the horizontal or vertical headers, cancel those headers.
20 * som.h: (struct som_table_class) Add fits_width, fits_length,
23 * tab.c: (tabi_fits_width) New function.
24 (tabi_fits_length) New function.
25 (tabi_set_headers) New function.
26 (global var tab_table_class) Add the new functions as appropriate
29 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
33 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
34 DATETIME, TIME system/portable file values.
36 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
38 * data-list.c: (parse_free) Use make_input_format().
40 * data-out.c: (num_to_string) Use make_output_format().
42 * dictionary.c: (dict_create_var) Ditto.
44 * format.c: (global var f8_2) New var.
45 (make_input_format) New function.
46 (make_output_format) New function.
48 * get.c: (cmd_match_files) Use make_output_format().
50 * list.q: (cmd_list) Ditto.
52 * matrix-data.c: Ditto.
54 * sfm-read.c: (parse_format_spec) Check output specifier
57 * tab.c: (tab_float) Use make_output_format().
59 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
63 * format.def: FMT_A should allow 255-character output. FMT_AHEX
64 should allow 510-character input and output.
66 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
67 (convert_E) Handle non-finite values.
69 (format_and_round) New function.
70 (convert_infinite) New function used by try_F() and convert_E().
72 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
74 Regularize string and buffer function names so that they make some
77 * str.c: (mm_reverse) Rename buf_reverse(). Update all
79 (mm_find_reverse) Rename buf_find_reverse(). Update all
81 (mm_case_compare) Rename buf_compare_case(). Update all
83 (st_compare_pad) Rename buf_compare_rpad(). Update all
85 (str_compare_rpad) New function.
86 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
88 (buf_copy_str_lpad) New function.
89 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
91 (st_pad_copy) Rename str_copy_rpad(). Update all references.
92 (st_trim_copy) Rename str_copy_trunc(). Update all references.
93 (st_uppercase) Renamed str_uppercase(). Update all references.
95 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
97 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
100 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
102 * data-in.c: (data_in) Add assertion to check input specifier.
104 * data-out.c: (data_out) Add assertion to check output specifier.
106 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
108 Start to fix PR 13054.
110 * format.c: (check_input_specifier) Improve error message.
111 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
112 valid decimal places.
113 (check_output_specifier) Ditto (but different criteria).
114 (convert_fmt_ItoO) Assert valid input and output specifiers.
115 Also, if input specifier has *any* decimal places, make the output
116 specifier 1 place wider.
118 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
120 * sysfile-info.c: Fixed bug [# 13024 ]
122 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
124 "Fix" PR 13021 by disabling FILE TYPE. Eventually, we should
125 actually implement it.
127 * command.c: (FILE_TYPE_okay) Always return 1.
129 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
131 * file-type.c: Add prototypes to get rid of warnings.
133 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
135 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
136 more ISO/IEC 9899:1990 conformance issues.
138 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
140 Fix PR 12948. See also new test in
141 tests/bugs/match-file-scratch.sh.
143 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
144 that deletes scratch variables that someone else might be using,
145 and because we can't reassign our sources' value indexes.
146 Instead, simply don't copy scratch variables into the master
149 * dictionary.c: (dict_compact_values) Delete variables from the
150 dictionary passed in, not from default_dict (!).
152 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
154 Improve hash.c comments, error-checking.
156 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
157 (hsh_create) size == 0 should *not* return NULL! Set
159 (hsh_clear) Set hash_ordered.
160 (locate_matching_entry) Check hash_ordered.
161 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
162 (hsh_data) Set hash_ordered. Add const-ness to return value and
166 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
168 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
170 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
172 * copyleft.c: Updated copyright date.
174 * Makefile.am: Removed erroneous explicit "-lplot"
176 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
178 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
180 * command.c command.def: Added description string for unimplemented commands.
182 * oneway.q: Sorted the hash tables before shipping out the results. Closes
185 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
189 * data-list.c: (parse_fixed) Use lex_end_of_command().
191 (cmd_repeating_data) Set cont_end.num in right situations.
192 (parse_repeating_data) Remove redundant test.
194 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
196 Partial fix for PR 12859.
198 * data-list.c: (cmd_data_list) Add transformation properly in
199 vfm_source == NULL case.
201 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
203 * lexer.c: (lex_error) Improve error messages.
205 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
207 * get.c: (cmd_match_files) Check token type before trying to match
208 tokid. Fixes PR 12923.
210 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
212 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes PR
215 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
217 * expressions/generate.pl: (get_token) Make use of /g
218 backward-compatible with Perl 5.6.1.
220 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
222 * var-display.c: (cmd_variable_alignment) Fix memory leak.
223 (cmd_variable_level) Ditto.
225 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
227 Hash table had buggy deletion function. The fix required changing
228 other functions to do probing in the required order.
230 * hash.c: (locate_matching_entry) Rewrite and change interface.
231 (hsh_rehash) Rewrite to use locate_matching_entry().
234 (hsh_delete) Ditto. Also, fix stupid bugs.
236 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
238 * dictionary.c: (dict_clone) Properly copy vectors.
240 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
242 New implementation of long variable names. Each variable has a
243 "normal" name, which may be up to 64 bytes long and which is used
244 for all normal operations. Variables may have a "short" name,
245 which is limited to 8 bytes and used only for system and portable
246 file input and output.
248 Make tokid case-preserving. Update most uses of tokid to treat it
251 Update many commands to deal with long variable names.
253 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
255 * command.c: (cmd_parse) Ditto.
256 (match_strings) Use toupper() before comparing characters.
257 (conflicting_3char_prefixes) Use mm_case_compare() instead of
259 (cmd_match_words) Ditto.
261 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
264 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
265 Use st_trim_copy() instead of strcpy().
267 * data-in.c: (parse_enum) Use mm_case_compare() instead of
270 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
272 (parse_free) Use st_trim_copy() instead of strcpy().
274 * descript.c: (struct dsc_var) Change z_name[] to fit long var
276 (try_name) Use strcasecmp() instead of strcmp().
277 (generate_z_varname) Use st_trim_copy() instead of strcpy().
278 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
281 * dictionary.c: (struct dictionary) Removed `long_name_tab'
283 (compare_long_names) Removed.
284 (hash_long_name) Removed.
285 (dict_create) Don't initialize `long_name_tab' member.
286 (dict_clone) Copy short names into new dictionary.
287 (dict_clear) Don't clear `long_name_tab' member.
288 (dict_get_varname_block) Removed.
289 (dict_add_longvar_entry) Removed.
291 (dict_destroy) Don't destroy `long_name_tab' member.
292 (dict_create_var_from_short) Removed.
293 (dict_create_var_x) Removed.
294 (dict_create_var) Get rid of longname handling.
296 (dict_clone_var) Get rid of longname parameter and longname
298 (dict_lookup_var) Get rid of longname handling.
299 (dict_reorder_var) New function.
300 (dict_rename_var) Clear short name.
301 (dict_rename_vars) Get rid of longname handling. Clear short
303 (dict_create_vector) Support long vector names.
304 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
305 (quasi_base27) Removed.
306 (make_short_name) Removed.
307 (compare_strings) New function.
308 (hash_string) New function.
309 (dict_assign_short_names) New function.
311 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
313 (get_handle_for_filename) Support long handle names.
315 * file-type.c: (struct col_spec) Make `name' fit long var names.
316 (cmd_file_type) Use strcasecmp() instead of strcmp().
318 * flip.c: (make_new_var) Rewrite.
319 (flip_sink_write) Use st_trim_copy() instead of strncpy().
321 * format.c: (parse_format_specifier_name) Use mm_case_compare()
324 * get.c: (cmd_save_internal) Rephrase.
325 (rename_variables) Drop test for identical variable name.
326 (struct mtf_proc) Change `first', `last' to fit long var name.
328 * hash.c: (hsh_hash_case_string) New function for case-insensitive
331 * lexer.c: (restore_token) Use st_trim_copy() instead of
333 (lex_get) Don't uppercase string when copying into tokid.
334 (lex_put_back_id) Use st_trim_copy() instead of
337 * list.q: (determine_layout) Consider length of variable names in
338 choosing vertical layout.
340 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
342 (string_to_content_type) Ditto.
344 * modify-vars.c: (compare_variables_given_ordering) Ditto.
345 (struct var_renaming) Change `new_name' to fit long var name.
346 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
349 * pfm-read.c: (read_variables) Disallow system variables in system
351 (write_variables) Call dict_assign_short_names() and use
352 short_name[] members.
354 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
357 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
358 map. Reorder variables into same order as long variable map.
359 (read_variables) Set short name.
361 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
362 (write_variable) Use st_bare_pad_copy().
363 (write_longvar_table) Rewrite.
365 * str.c: (mm_case_compare) New function.
367 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
370 * t-test.q: (tts_custom_groups) Remove redundant test.
371 (tts_custom_pairs) Ditto.
373 * var.h: (struct variable) Change `name' to fit long var names.
374 Remove `longname'. Add `short_name' member. Reorder some
376 (struct name_table_entry) Removed.
377 (struct vector) Change `name' to fit long vector names.
379 * vars-atr.c: (var_is_valid_name) Allow long var names.
380 (compare_var_names) Use strcasecmp() instead of strcmp().
381 (compare_var_ptr_names) Ditto.
382 (hash_var_name) Use hsh_hash_case_string().
383 (hash_var_ptr_name) Ditto.
384 (var_set_short_name) New function.
385 (var_clear_short_name) New function.
386 (var_set_short_name_suffix) New function.
388 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
389 Use strcasecmp() instead of strcmp().
390 (struct array_var_set) Removed `longname_tab'.
391 (array_var_set_lookup_var_idx) Drop longname_tab support.
392 (array_var_set_destroy) Don't destroy `longname_tab'.
393 (var_set_create_from_array) Don't create `longname_tab'.
395 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
398 * expressions/parse.c: (word_matches) Use mm_case_compare()
400 (compare_strings) New function.
401 (lookup_function) Use compare_strings() instead of strcmp().
403 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
405 * algorithm.c: (move_element) New function.
407 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
409 * aggregate.c: (parse_aggregate_functions) Always initialize
412 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
414 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
416 * dictionary.c: (dict_clone) Ditto.
417 (dict_clone_var_assert) New function.
419 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
421 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
423 * error.c: Added a string for the compiler version to the
424 request_bug_report_and_abort function.
426 * groff_font.c, font.c: Removed manpage(1) style references from
427 comments, because RMS frowns upon them.
429 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
431 * expressions/parse.c: Improve previous fix for PR 12858 (LAG).
433 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
435 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
438 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
440 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
441 which should be LONG_NAME_LEN
443 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
445 * command.def echo.c: Added the ECHO command.
447 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
449 Finish fixing MATCH FILES (PR 11677).
451 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
452 keep_variables(), rename_variables().
453 (drop_variables) New function.
454 (keep_variables) New function.
455 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
456 (cmd_match_files) Deal with in_var. Use drop_variables(),
457 keep_variables(). When IN is specified, require BY. Set master
458 variables after master dictionary is complete. Add IN variables
459 after master dictionary is complete.
460 (mtf_free_file) Free `in_name'.
461 (mtf_delete_file_in_place) Set in_var value to 0.
462 (mtf_read_nonactive_records) Rephrase.
463 (mtf_processing) Support IN. Rephrase. Fix bugs.
464 (mtf_merge_dictionary) Don't set master variables; we do that
466 (get_master) Don't insist that there's a master variable.
468 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
470 Kluge to make some variable renaming sort of work.
473 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
475 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
477 Add functions for comparing sets of variables between cases.
480 * case.c: (case_compare) New function.
481 (case_compare_2dict) New function.
483 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
485 (cmd_aggregate) Nullify break_case. Don't call
486 initialize_aggregate_info().
487 (agr_destroy) Destroy break_case.
488 (aggregate_single_case) Rewrite. Use case_compare().
489 (dump_aggregate_info) Copy from break_case into output.
490 (initialize_aggregate_info) Copy break_case from input.
492 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
494 * vfm.c: (equal_splits) Use case_compare().
496 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
498 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
500 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
502 Start work on fixing MATCH FILES.
504 * get.c: (enum operation) Remove OP_MATCH.
505 (trim_dictionary) Change return value to bool. Don't support
507 (struct mtf_file) Remove `first', `last' members.
508 (struct mtf_proc) Add `first', `last' members. Change mtf_case
509 from `struct ccase *' to `struct ccase'. Remove `by' member.
510 (cmd_match_files) Essentially rewrite.
511 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
512 (mtf_read_nonactive_records) mtf_ parameter is not unused.
513 (mtf_processing) Ditto. Also rephrase some code.
514 (mtf_merge_dictionary) Rewrite for easy comprehension.
516 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
518 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
521 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
523 Thu Apr 14 2005 John Darrington
525 * var-display.c: New file.
527 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
528 display_width, measure and alignment parameters to variables.
530 * aggregate.c command.def compute.c count.c data-list.c descript.c
531 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
532 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
533 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
534 vars-prs.c vector.c :
535 - Replaced literal constants representing maximum variable name
536 length with macro definitions.
537 - Added support for long variable names.
538 - Changed lexer such that it no longer makes tokens upper
539 case, but relies upon case insensitive behaviour of commands.
541 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
543 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
544 fails, don't dereference the resulting null pointer (PR 12427).
545 Also, fix double free error.
547 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
549 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
550 (accumulate_aggregate_info) Set int1 to 1 for SUM.
551 (dump_aggregate_info) Only make SUM non-missing if there was at
554 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
556 * aggregate.c: (dump_aggregate_info) Properly test whether the
557 destination variable is numeric, when making the result
558 system-missing for columnwise missing values.
560 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
562 * misc.h: Remove GCC specializations.
564 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
566 Make sort stable (PR 12313).
568 * sort.c: Don't need to include some headers anymore.
569 (static var min_buffers) New variable.
570 (static var max_buffers) New variable.
571 (static var allow_internal_sort) New variable.
572 (cmd_sort_cases) Add test mode.
573 (sort_execute) Rephrase.
574 (do_internal_sort) Don't try internal sorting if
575 allow_internal_sort is set.
576 (struct external_sort) Renamed `initial_runs' to `runs' and
577 updated all references.
578 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
579 (macro MIN_BUFFER_SIZE_BYTES) Removed.
580 (macro MIN_BUFFER_SIZE_RECS) Removed.
581 (compare_initial_runs) Removed.
582 (struct record_run) Add member `idx'.
583 (write_initial_runs) Pass increasing values to process_case() as
585 (process_case) Add `idx' parameter and use it to initialize new
587 (allocate_cases) Limit allocated buffers to max_buffers.
588 (compare_record_run) Use new `idx' member for last resort
589 comparison, for stability.
590 (end_run) Call casefile_sleep() on irs->casefile, to prevent
591 running out of file descriptors.
592 (struct merge_state) Removed.
593 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
594 unless we have fewer runs left. Always merge consecutive runs,
595 for stability. Return the final run.
597 (choose_merge) New function.
598 (merge_once) Rewritten.
600 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
602 * cmdline.c: (static var testing_mode) Move into
603 parse_command_line().
605 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
607 * algorithm.c: (remove_range) New function.
608 (remove_element) New function.
610 * dictionary.c: (dict_delete_var) Use remove_element().
612 * flip.c: (cmd_flip) Ditto.
614 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
616 * file-handle.q: (struct file_handle) `open_mode' should not be
619 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
621 First phase of making SORT CASES stable (PR 12313).
623 * sort.c: (struct indexed_case) New structure.
624 (do_internal_sort) Rewrite to make internal sorting stable.
625 (compare_case_dblptrs) Removed.
626 (compare_indexed_cases) New function.
628 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
632 * casefile.c: (casereader_read_xfer_assert) New function.
634 * dictionary.c: (dict_compact_case) New function.
636 * flip.c: (struct flip_pgm) New member idx_to_fv.
637 (cmd_flip) Initialize idx_to_fv member.
638 (destroy_flip_pgm) Free idx_to_fv member.
639 (flip_sink_write) Use struct flip_pgm member instead of case_sink
641 (flip_sink_write) Ditto.
643 * vfm.c: (write_case) Use dict_compact_case() instead of
645 (compact_case) Removed.
646 (storage_source_create) Removed `dict' parameter. All references
649 * vfm.h: (struct case_source) Removed `value_cnt' member. All
651 (struct case_sink) Removed `dict', `idx_to_fv' members. All
654 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
656 More AGGREGATE fixes.
658 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
659 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
661 (initialize_aggregate_info) Fix initialization for MIN, MAX for
664 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
666 Start work on testing and debugging AGGREGATE.
668 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
669 of a bit-map. Require proper subcommand ordering. Make OUTFILE
670 subcommand mandatory.
671 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
672 functions' arguments are in the correct order and swap them if
674 (accumulate_aggregate_info) Make SUM include weights. Add various
676 (dump_aggregate_info) Add various string functions.
677 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
679 * sort.c: (sort_parse_criteria) Add parameter for returning
680 whether any directions were specified. All callers updated.
682 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
684 * t-test.q: Fixed erroneous logic in compare_group_binary.
686 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
688 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
691 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
693 * vfm.c: (procedure_with_splits) Fix PR 11492: end_func() must be
694 called *before* close_active_file().
696 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
698 * file-handle.q: (struct file_handle) Change open_mode from
699 character pointer to 3-char array, for safety. Updated all
702 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
704 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
707 * pfm-read.c: (read_header) Improve error message for many cases
708 in which the input is not actually a portable file.
710 * file-handle.q: (fh_open) When we give an error message, actually
713 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
715 * format.c: (check_common_specifier) New function for checks
716 common to check_input_specifier() and check_output_specifier().
717 (check_input_specifier) Use check_common_specifier().
718 (check_output_specifier) Use check_common_specifier().
719 (check_string_specifier) Removed.
720 (check_specifier_type) New function.
721 (check_specifier_width) New function.
722 (get_format_var_width) Fix bug.
724 * formats.c: (internal_cmd_formats) Only accept numeric variables.
726 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
727 update all references. Make case-insensitive.
729 * pfm-read.c: Essentially rewrite the whole file. Now much
732 * print.c: (check_string_width) New function.
733 (fixed_parse_compatible) Use check_string_width(),
734 check_specifier_type().
735 (dump_fmt_list) Ditto.
737 * str.c: (st_trim_copy) New function.
738 (st_uppercase) New function.
740 * vars-atr.c: (var_is_valid_name) New function.
742 * expressions/parse.c: (type_coercion_core) Use
743 check_specifier_type().
745 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
747 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
749 * expressions/parse.c: (no_match) Ditto.
751 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
753 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
755 * expressions/helpers.c: (struct func_params) Removed.
756 (generalized_idf) Removed.
759 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
761 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
762 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
763 Implement SIG.F, which I had overlooked previously.
765 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
767 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
768 available only in testing mode.
770 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
772 * data-in.c: Use `bool' throughout, where relevant.
774 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
776 DATA LIST with free-field formats should not have implied decimal
777 places (PR 12035). Also clean up data-in.c a bit.
779 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
781 * data-in.c: (apply_implied_decimals) New function.
782 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
783 set. Also, get rid of gotos.
784 (parse_Z) Use apply_implied_decimals() if the field doesn't
785 contain a decimal point.
786 (parse_N) Use apply_implied_decimals().
792 (parse_enum) New function.
793 (macro CHAR_IS_ROMAN) Removed.
794 (macro ROMAN_VALUE) Removed.
795 (parse_month) Use parse_enum().
796 (parse_weekday) Use parse_enum().
797 (parse_DATETIME) Use long for weekday.
799 * data-list.c: (read_from_data_list_fixed) Use
802 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
804 When the lexer sees something like `-5' in the input, it has to
805 decide whether it's a negative numeric constant token or a '-'
806 token followed by a positive numeric constant token. It always
807 decides on the former, and then the parser can call
808 lex_negative_to_dash() if it wants the latter. However, this
809 doesn't work for the case of `-0', because negative zero is
810 (portably) indistinguishable from positive zero. So now we divide
811 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
812 distinction clear. This requires a little bit of extra effort,
813 because there were several references to T_NUM in the code base.
815 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
816 positive and negative numeric constants.
817 (lex_double_p) Renamed lex_is_number(). Changed return type to
818 bool. Updated all relevant references to T_NUM to instead use
820 (lex_double) Renamed lex_number(). All references updated.
821 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
822 bool. All references updated.
823 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
824 (lex_negative_to_dash) Ditto.
827 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
829 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
831 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
833 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
835 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
836 values as system-missing.
838 * expressions/parse.c: (parse_vector_element) Fix order of
839 arguments in call to expr_allocate_binary().
841 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
843 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
846 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
847 failure, as indicated by function comment.
848 (parse_binary_operators) Always return NULL on type_coercion()
849 failure. Should have been doing this anyway, but bug in
850 type_coercion_core() filtered through.
851 (parse_add) Fix typo in user message.
852 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
854 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
856 * expressions/operations.def: Add VALUE function.
858 * expressions/parse.c: (parse_function) Need an unary composite
859 node for variables in A TO B, not a variable node. Use
860 allocate_unary_variable().
861 (parse_primary) Use allocate_unary_variable().
862 (allocate_unary_variable) New function.
864 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
866 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
867 but fixed the real problem that was preventing the build from a
868 separate directory. I liked it my way better ;-)
870 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
872 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
873 John Darrington <john@darrington.wattle.id.au> for reporting this
876 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
878 * expressions/Makefile.am expressions/evaluate.h.pl
879 expressions/evaluate.inc.pl expressions/operations.h.pl
880 expressions/optimize.inc.pl expressions/parse.inc.p:
882 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
885 Fixed everything so that it can be built from an arbitrary
888 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
890 * Makefile.am : Fixed up CLEANFILES target.
892 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
894 * str.h: Changed `struct len_string' to `struct fixed_string', a
895 more accurate name. Updated all references.
897 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
899 Redo calendar support. Should now be bug-for-bug compatible.
901 * calendar.c: New file.
903 * calendar.h: New file.
905 * data-in.c: Use new calendar functions.
906 (parse_sign) Change sense of return value.
907 (calendar_error) New function.
908 (ymd_to_ofs) New function.
909 (ymd_to_date) New function.
910 (parse_DATE) Use new function.
920 (parse_DATETIME) Ditto.
922 * data-out.c: (convert_date) Use new calendar functions.
924 * error.c: (err_vmsg) Changed interface to be more sensible.
926 (dump_message) Don't double new-lines (why did we do this
929 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
931 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
932 (macro FLT64_MAX) Moved here from pref.h.orig.
934 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
936 * set.q: Support SET EPOCH.
937 (static var set_epoch) New var.
938 (aux_stc_custom_epoch) New function.
939 (stc_custom_epoch) New function.
940 (get_epoch) New function.
941 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
943 * format.c: Make it possible just to check whether a specifier is
944 valid without emitting an error message.
945 (parse_format_specifier_name) Change interface, update all
947 (check_input_specifier) Ditto.
948 (check_output_specifier) Ditto.
949 (parse_format_specifier) Ditto.
951 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
953 * command.def: Add DEBUG POOL.
955 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
957 (pool_clear) Properly account for size of pool gizmo.
958 (pool_realloc) Ditto.
959 (pool_clone) New function.
961 * pool.h: Mark our allocation functions MALLOC_LIKE.
963 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
965 * Makefile.am: Move many definitions into new top-level
966 Make.build. Add expressions to SUBDIRS. Add calendar.c,
967 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
970 * case.c: (case_resize) New function.
971 (case_swap) New function.
973 * casefile.c: Include mkfile.h.
975 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
977 * sfm-read.c: Fixed a buglet which caused a crash when trying
978 to read a non-existent file.
980 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
984 * aggregate.c: (parse_aggregate_functions) Code cleanup.
985 Important part: get rid of spurious copying of function->format to
986 destvar->print and destvar->write.
988 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
990 Fix PR 11916, which was confusing a variable's `index' member
991 with the variable's position in a var_set. Although these are
992 usually the same, they are not for array `var_set's.
994 Took advantage of this bug as an opportunity to clean up and
995 rewrite parse_var_set_vars().
997 * vars-prs.c: (parse_vs_variable_idx) New function.
998 (parse_vs_variable) Reimplement in terms of
999 parse_vs_variable_idx().
1000 (parse_var_idx_class) New function.
1001 (add_variable) New function.
1002 (add_variables) New function.
1003 (parse_var_set_vars) Rewritten.
1004 (struct var_set) Change `lookup_var' member that returns a
1005 variable into `lookup_var_idx' member that returns an int.
1006 Updated the var set implementations in obvious corresponding ways.
1007 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1009 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1011 Use our global variable compare & hash functions and give them
1012 better names. Add similar functions for dealing with double
1013 pointers to variables.
1015 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1016 (hash_variable) Renamed hash_var_name().
1017 (compare_var_ptr_names) New function.
1018 (hash_var_ptr_name) New function.
1020 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1022 (compare_var_name) Removed.
1023 (hash_var_name) Removed.
1025 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1029 * dictionary.c: (compare_variable_dblptrs) Rename
1030 compare_var_ptrs() and fix it to properly dereference the double
1033 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1035 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1036 declare subcommands as mandatory. Closed bug #11843
1038 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1040 * getline.c command.[ch] command.def: Added (very rudimentary)
1041 support for line completion when in interactive mode. Partially
1042 addresses bug #11693
1044 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1046 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1047 problems revealed by valgrind.
1050 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1052 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1053 whether or not PAGER is set.
1055 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1057 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1058 "invalid free" errors. Hopefully fixes bug #11722
1060 * compute.c expr-prs.c: Check that lvalues are populated before
1061 attempting to destroy them. Closes bug #11676
1063 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1065 * aggregate.c: Initialised the complete agr_proc structure.
1069 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1071 * print.c: (print_trns_free) Close the dfm writer if there is one,
1072 fixing a memory leak.
1074 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1076 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1080 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1082 * linked-list.[ch] Added
1084 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1085 set.q: Yet more memory leaks
1087 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1089 * t-test.q examine.q : More memory leaks fixed.
1091 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1093 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1096 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1098 * ascii.c cartesian.c casefile.c chart.h devind.c
1099 examine.q frequencies.q
1100 html.c output.h piechart.c plot-chart.c plot-hist.c
1102 Integrated the chart rendering into the output stream
1103 (currently only works for html).
1105 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1106 dummy-chart.c for compiling without charts.
1108 * mkfile.[ch] Created.
1110 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1111 Added type element so we can tell if it's a chart or a table.
1113 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1114 API of charts to be more like that of tables.
1116 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1118 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1119 main.c. Removed the handler for SIGQUIT.
1121 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1123 * casefile.c: Added a signal handler to delete temp files on
1126 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1128 * command.def Added a lot more unimplemented commands.
1130 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1132 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1134 * sort.c: (compare_initial_runs) Needed additional level of
1136 (merge_once) Fix plenty of stupid mistakes.
1138 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1140 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1141 calling casefile_to_disk() or we will lose the last block in the
1142 file if the casefile started out as disk-based.
1143 (casefile_get_reader) Initialize reader->destructive to 0.
1144 (cmd_debug_casefile) Add new test pattern.
1145 (test_casefile) Define new test pattern to make sure
1146 casefile_sleep() works properly.
1148 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1150 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1151 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1152 attempt to seperate the creation and processing of charts from their
1155 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1158 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1160 * main.c Added a signal handler for SIGFPE
1162 * sort.c Somewhat more robust fix to the previous entry.
1164 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1166 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1167 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1168 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1171 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1173 * case.h Fixed bug # 11307
1175 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1177 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1180 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1182 * pfm-read.c: (read_variables) Remove direct manipulation of
1183 v->aux, which is no longer needed. Fixes PR 11483.
1185 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1187 * data-list.c Fixed a bug in parsing delimiters.
1189 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1192 * percentiles.c Properly handled calculation of Tukey hinges where
1193 the number of data is small.
1195 * oneway.q Used the generic value_to_string function for independent
1196 variable instead of trying to do it ourselves.
1198 * box-whisker.c Fixed a buglet which caused a crash if the number of
1202 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1204 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1206 * percentiles.c Fixed some bugs when calculating percentiles when
1207 there's a small number of cases.
1209 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1211 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1213 * examine.q factor_stats.[ch] Added calculation of percentiles
1215 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1217 * t-test.q Fixed bug #11227 Made t-test work when the independent
1220 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1222 * factor_stats.c Fixed calculation of trimmed mean under various
1225 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1227 * histogram.c chart.[ch] factor_stats.c frequencies.q
1229 Added code to calculate sensible histogram ranges and limits.
1231 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1233 * chart.h Updated to reflect many API changes.
1235 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1236 cartesian.c and into chart.c
1238 * factorstats.[ch] Added the histogram calculations
1240 * casefile.c Removed an unused variable.
1242 * frequencies.q examine.q histogram.c Reworked the API for
1245 * piechart.c Revised the API for piecharts.
1247 * var.h Moved the definitions of freq_tab and freq out of var.h
1248 and into frequencies.q where they belong.
1250 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1252 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1253 using AC_TYPE_OFF_T.
1255 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1257 * flip.c: (flip_file) If fseeko() is not available, use long int
1258 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1259 reporting the problem.
1261 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1263 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1264 conflict with stdio.
1266 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1268 * var-labs.c (var_to_string) Now returns null if the variable is null
1270 * value-labels.c (value_to_string) Made it return null if either the
1271 value or the variable is null.
1273 * hash.c (hsh_clear) Fixed a buglet.
1275 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1276 with the wrong model.
1278 * casefile.[ch] Added a function to return the casereader.case_idx
1281 * examine.q Implemented the extreme values results.
1283 John Darrington <john@darrington.wattle.id.au>
1285 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1286 output.[ch] getline.c
1288 Plugged some memory leaks
1290 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1292 Adopt GSL random number generators, paving the way for providing
1293 the complete suite of random number generators on expressions.
1295 * Makefile.am: Remove random.c, random.h.
1297 * random.c: Removed.
1299 * random.h: Removed.
1301 * algorithm.c: (algo_default_random) Use GSL functions.
1303 * casefile.c: (test_casefile) Use GSL RNG functions.
1305 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1308 * sample.c: (cmd_sample) Use GSL RNG functions.
1309 (sample_trns_proc) Ditto.
1311 * set.q: (static var set_seed) Removed.
1312 (static var seed_flag) Removed.
1313 (static var rng) New variable.
1314 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1315 (stc_custom_seed) Use new seed functions.
1316 (seed_is_set) Removed.
1317 (get_rng) New function that composes the entire external
1319 (set_rng) New function.
1320 (random_seed) New function.
1322 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1324 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1325 John Darrington <john@darrington.wattle.id.au> for reporting this
1328 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1330 * permissions.c command.def Added the PERMISSIONS command
1332 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1334 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1335 output file because that will precede #include <config.h>, which
1337 (main) Add needed headers to /* (header) */ code.
1339 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1341 Instead of making system or portable file readers responsible for
1342 dropping and reordering variables, make them read full cases and
1343 let the caller take care of any changes.
1345 * get.c: New "case map" structure to handle this. Use for GET,
1346 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1348 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1349 changed appropriately.
1351 * sfm-read.c: (sfm_read_case) Ditto.
1353 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1355 Decided that case_serialize() and case_unserialize() were too
1356 abstract. Also we need a couple more functions to avoid excessive
1357 copying for data in/out fast paths.
1359 * case.c: (case_serial_size) Removed.
1360 (case_serialize) Rename case_to_values() and make its argument
1361 explicitly an array of union values.
1362 (case_unserialize) Rename case_from_values() and make its argument
1363 explicitly an array of union values.
1364 (case_data_all) New function.
1365 (case_data_all_rw) New function.
1367 * casefile.c: (struct casefile) Change buffer from array of
1368 unsigned char to array of union value for better accuracy.
1369 Redefine buffer_used and buffer_size in terms of values, not
1370 bytes. Remove case_size because it is now redundant with
1371 value_cnt. Fix up all references to these members.
1373 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1375 * barchart.c: (struct subcat) Make `label' member const to silence
1376 GCC warning with -Wwrite-strings.
1378 * cartesian.c: (struct dataset) Ditto.
1380 * case.c: Don't re-define NDEBUG if already defined.
1381 Add lots of comments.
1383 * str.c: Fix includes.
1385 * crosstabs.q: Fix includes.
1387 * examine.q: Fix includes. Fix GCC warning about unused
1390 * frequencies.q: (stat macro) Removed and replaced where used by
1393 * list.q: Fix includes.
1395 * oneway.q: Fix includes.
1397 * piechart.c: Fix includes. Only define M_PI if not already
1400 * sfm-read.c: (bswap) New function.
1401 (bswap_int32) Write in terms of bswap.
1402 (bswap_flt64) Ditto.
1404 * str.c: (ds_data) Add external definition here, needed because
1405 str.h has only an `extern inline' version.
1407 * value-labels.c: Fix includes.
1409 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1411 Instead of providing a system or portable file writer with a raw
1412 case in the format needed for output, provide it with a regular
1413 case. The writer takes care of any needed translation.
1415 * aggregate.c: Adopt new scheme for AGGREGATE.
1416 (struct agr_proc) sfm_agr_case member removed.
1417 (write_case_to_sfm) Removed because the new interface is easier to
1420 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1422 * pfm-write.c: Implement new scheme.
1424 * sfm-write.c: Ditto.
1426 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1428 Instead of treating `struct file_handle' as a class to subclass
1429 into data files, system files, and portable files, instead use it
1430 as a helper that coordinates access. Now it is opaque, too.
1432 This means that most references to a struct file_handle are now
1433 changed into references to one of struct dfm_reader, struct
1434 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1435 pfm_reader, or struct pfm_writer, according to what's being read
1438 Most related changes are only worth summarizing briefly.
1440 * dictionary.c: (dict_clear) Destroy aux data in deleted
1442 (dict_clear_aux) New function.
1443 (dict_create_var) Initialize aux, aux_dtor.
1444 (dict_delete_var) Destroy aux data in deleted variable.
1446 * file-handle.h: (struct fh_ext_class) Removed.
1447 (struct file_handle) Removed.
1448 (fh_init_files) Removed.
1450 * file-handle.q: Changed references to a handle's `private' member
1451 to direct references.
1452 (struct private_file_handle) Renamed file_handle.
1453 Add next, open_cnt, type, open_mode, aux members.
1454 (struct file_handle_list) Removed.
1455 (extern var inline_file) Removed.
1456 (static var file_handles) Changed from file_handle_list * to
1458 (create_file_handle) Initialize new members.
1459 (fh_close_handle) Removed.
1460 (mode_name) New function.
1461 (fh_open) New function.
1462 (fh_close) New function.
1463 (fh_parse_file_handle) Renamed fh_parse().
1465 * glob.c: (init_glob) Remove fh_init_files() call.
1467 * aggregate.c: use sfm_writer.
1468 (create_sysfile) Removed because the new interface is simpler.
1470 * apply-dict.c: Use sfm_reader.
1472 * data-list.c: Use dfm_reader.
1474 * file-type.c: Use dfm_reader.
1476 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1478 * inpt-pgm.c: Use dfm_reader.
1480 * print.c: Use dfm_writer.
1482 * sysfile-info: Use sfm_reader.
1484 * dfm-read.c: Adopt new file handle infrastructure.
1486 * dfm-write.c: Ditto.
1488 * pfm-read.c: Ditto.
1490 * pfm-write.c: Ditto.
1492 * sfm-read.c: Ditto.
1494 * sfm-write.c: Ditto.
1496 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1498 Break dictionary functions into separate header file.
1500 * dictionary.h: New file.
1502 * var.h: Moved dict_*() functions to dictionary.h.
1504 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1506 Get rid of procedure-specific union in struct variable, using
1507 instead a void * pointer and a destructor function.
1509 Most related changes are only worth brief summaries.
1511 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1512 old p.crs member in struct variable.
1514 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1515 of old p.frq member in struct variable.
1517 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1518 it's no longer possible to grab this from var->p.frq.
1520 * piechart.c: (draw_piechart) Ditto.
1522 * group.c: (group_proc_get) New function.
1524 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1531 * main.c: (execute_command) Clear aux data in default_dict after
1532 each command. (It's debatable whether this should be done.)
1534 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1535 member in struct variable.
1537 * means.q: Get rid of integer mode, which is not included in
1538 recent SPSS and was the only code that wanted per-variable private
1541 * var.h: (struct crosstab_proc) Removed.
1542 (struct frequencies_proc) Removed.
1543 (struct list_proc) Removed.
1544 (struct get_proc) Removed.
1545 (struct means_proc) Removed.
1546 (struct matrix_data_proc) Removed.
1547 (struct match_files_proc) Removed.
1548 (lots of enums) Removed.
1549 (struct variable) Removed members `p', `get'. Add member
1552 * vars-atr.c: (var_attach_aux) New function.
1553 (var_detach_aux) New function.
1554 (var_clear_aux) New function.
1555 (var_dtor_free) New function.
1556 (discard_variables) Use NULL instead of inline_file.
1558 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1560 * value-labs.c Fixed the implmentation of value_to_string, so
1561 that it properly handles alpha values.
1563 * oneway.q Changed instances where labels were being probed manually,
1564 to use the canonical {var,value}_to_string functions
1566 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1568 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1569 plots. Changed the API of the cartesian plot to be a much lower level
1572 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1574 * examine.q Added some of the parametric calculations
1576 * factor_stats.[ch] Created
1578 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1580 * examine.q Changed the definition of factors to be a composite, and
1581 dealt with the consequences.
1583 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1585 * examine.q Fixed problem where examine wasn't dealing properly with
1588 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1590 * oneway.q Fixed problem where oneway wasn't dealing properly with
1593 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1595 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1596 command which had settings didn't get the appropriate code
1599 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1600 to convert variables/values to strings.
1602 * examine.q Added framework for the EXAMINE command.
1604 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1606 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1607 subcommand types. Changed frequencies.q to use it rather then the
1608 custom parser. Dealt with the consequences. Added a test for NTILES
1609 subcommand of frequencies.
1611 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1613 * oneway.q Fixed up the behaviour when given missing values
1615 * levene.c oneway.q Fixed a buglet with the levene statistic and
1616 incorporated the levene test into the oneway command.
1618 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1619 global scope, since they're only relevant to T-TEST
1621 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1623 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1625 Made the t-test more consistent
1626 with the way it handles groups. That is, it now uses a hash instead
1627 of an array of 2. Also, made the levene.c file independent of the
1628 implementation of the t-test. So now levene should be fine for both
1631 * Added an oneway.q file for one way anova
1633 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1635 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1638 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1642 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1643 (data_list_trns_free) Free dls->delims.
1645 * t-test.q: (tts_custom_pairs) Free vars.
1646 (ssbox_one_sample_init) Fix tab_vline() argument.
1647 (ssbox_independent_samples_init) Ditto.
1648 (trbox_paired_init) Ditto.
1649 (trbox_one_sample_init) Ditto.
1651 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1653 Generalize casefiles to the extent that we can use them for
1654 sorting and other kinds of data transformations. Change cases to
1655 be copy-on-write to improve memory efficiency in common cases.
1656 Every access to a member of a `struct ccase' was changed to be a
1657 call to a case_*() function, especially case_data(), case_num(),
1658 case_str(), or case_data_rw(). Many instances of a local variable
1659 named "case_num" were changed to "case_idx" as a consequence.
1660 Many `struct ccase *' were changed to actual `struct ccase'
1661 because of copying semantics of cases. In several places there
1662 was a choice between updating debug code to work with the new ADTs
1663 or just deleting it because it was useless; I chose to delete it.
1665 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1671 * aggregate.c: (struct agr_proc) Change type of `sort' to
1672 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1673 Rename `vars' to `agr_vars', all references updated. Change
1674 `agr_case' to type `struct ccase'.
1675 (cmd_aggregate) Deal with new members. Use case_create(),
1676 sort_active_file_in_place(), sort_active_file_to_casefile().
1677 (agr_destroy) Deal with new members.
1678 (aggregate_single_case) Ditto.
1679 (dump_aggregate_info) Ditto.
1680 (initialize_aggregate_info) Ditto.
1681 (agr_to_active_file) Ditto.
1682 (presorted_agr_to_sysfile) Ditto.
1683 (sort_agr_to_sysfile) Removed.
1685 * alloc.c: (out_of_memory) Make non-static.
1687 * alloc.h: Prototype out_of_memory().
1689 * casefile.c: Switched from a linked list in-memory representation
1690 to a two-level array-style representation. The linked list was
1691 appropriate when we could stick a header onto cases, but that's no
1692 longer the case. Also, the two-level array will allow for random
1693 in-memory access in case that's ever wanted. Also added the
1694 concept of a `destructive casereader', one that destroys cases in
1695 the underlying casefile as they are read out.
1696 (macro CASES_PER_BLOCK) New macro.
1697 (struct casefile) New members `value_cnt', `case_list_size',
1698 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1700 (struct casereader) Removed `cur'. Added `destructive', `c'.
1701 (global var casefiles) Made static.
1702 (static var case_bytes) New var.
1703 (casefile_create) Takes a value count, not a case size in bytes,
1704 to conform to the case interface. All callers updated. Deal with
1705 new and removed members.
1706 (casefile_destroy) Deal with new and removed members.
1707 (casefile_sleep) New function.
1708 (casefile_get_case_size) Removed.
1709 (casefile_get_value_cnt) New function.
1710 (casefile_append) Rewritten to deal with new and removed members.
1711 (casefile_append_xfer) New function.
1712 (write_case_to_disk) Use case_serialize().
1713 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1714 Couldn't figure out why.
1715 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1716 deal with new and removed members.
1718 (merge_sort) Removed.
1719 (casefile_sort) Removed.
1720 (casefile_get_reader) Deal with new and removed members.
1721 (casefile_get_destructive_reader) New function.
1722 (reader_open_file) Make code more readable. Create case for
1724 (casereader_get_casefile) New function.
1725 (casereader_read) Deal with new and removed members. Now returns
1726 a copy of the case, so that the caller is responsible for
1727 destroying the returned case.
1728 (casereader_read_xfer) New function.
1729 (casereader_destroy) Destroy reader's case.
1730 (test_casefile) Second arg is now a value count, all callers
1731 updated. Now tests destructive readers too.
1732 (get_random_case) Deal with new case ADT.
1733 (write_random_case) Ditto.
1734 (read_and_verify_random_case) Ditto.
1736 * crosstabs.q: Remove debug code.
1738 * descript.q: (calc_descriptives) Deal with new case, casefile
1741 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1743 * do-if.c: Remove unneeded header inclusion.
1745 * expr-prs.c: Remove debug code.
1747 * exprP.h: Remove debug code.
1749 * flip.c: (flip_file) Use fseeko() if available.
1751 * formats.c: Remove debug code.
1753 * get.c: Remove debug code.
1754 (struct mtf_file) Change `input' from `union value *' to `struct
1755 ccase', all references updated.
1757 * levene.c: (levene) Deal with new case, casefile ADTs.
1759 * list.q: Remove debug code.
1761 * loop.c: Remove debug code.
1763 * matrix-data.c: Remove debug code.
1765 * means.q: Remove debug code.
1767 * mis-val.c: Remove debug code.
1769 * pfm-read.c: Remove debug code.
1770 (pfm_read_code) Change second arg from `union value *' to `struct
1771 ccase *', all references updated.
1773 * recode.c: (string_to_long) Make first arg const.
1774 (convert_to_double) Ditto.
1776 * repeat.c: Remove debug code.
1778 * sample.c: Remove debug code.
1780 * sfm-read.c: Remove debug code.
1781 (sfm_read_case) Change second arg from `union value *' to `struct
1784 * sort.c: Redone in terms of casefiles.
1785 (enum sort_direction) Moved here from sort.h.
1786 (struct sort_criterion) New structure.
1787 (struct sort_criteria) New structure.
1788 (cmd_sort_cases) Rewritten.
1789 (prepare_to_sort_active_file) New function.
1790 (sort_active_file_in_place) New function.
1791 (sort_active_file_to_casefile) New function.
1792 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1793 changed, all callers updated.
1794 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1795 rewritten & interface changed, all callers updated.
1796 (sort_cases) Renamed sort_execute(), rewritten & interface
1797 changed, all callers updated.
1798 (struct internal_sort) Removed.
1799 (do_internal_sort) Rewritten, interface changed.
1800 (destroy_internal_sort) Removed.
1801 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1802 (struct initial_run) Removed; an initial run is now just a
1804 (compare_initial_runs) Rewritten.
1805 (struct external_sort) Changed almost completely.
1806 (do_external_sort) Rewritten, interface changed.
1807 (destroy_external_sort) Rewritten.
1808 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1809 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1810 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1811 (init_external_sort) Removed.
1812 (simulate_error) Removed.
1813 (rmdir_temp_dir) Removed.
1814 (get_temp_file_name) Removed.
1815 (open_temp_file) Removed.
1816 (close_temp_file) Removed.
1817 (remove_temp_file) Removed.
1818 (write_temp_file) Removed.
1819 (read_temp_file) Removed.
1820 (struct record_run) Change `record' from `struct case_lit *' to
1822 (struct initial_run_state) Remove `idx_to_fv', `free_list',
1823 `file_idx', `output_file'. Add `run', casefile'. Change
1824 `last_output' from `struct case_list *' to `struct ccase'.
1825 (write_initial_runs) Change interface, rewrite.
1826 (sort_sink_write) Renamed process_case(), changed interfaced,
1828 (destroy_initial_run_state) Rewritten.
1829 (allocate_cases) Rewritten.
1830 (compare_record) Interface changed, rewritten.
1831 (start_run) Rewritten.
1832 (end_run) Rewritten.
1833 (output_record) Rewritten.
1834 (grab_case) Removed.
1835 (release_case) Removed.
1836 (struct merge_case) Change `cases' from double pointer to single
1838 (merge) Deal with new case and casefile ADTs.
1839 (struct run) Removed.
1840 (merge_once) Rewritten, interface changed.
1841 (fill_run_buffer) Removed.
1842 (sort_sink_make_source) Removed.
1843 (sort_sink_class) Removed.
1844 (struct sort_source_aux) Removed.
1845 (sort_source_read_helper) Removed.
1846 (sort_source_read) Removed.
1847 (read_sort_output) Removed.
1848 (read_internal_sort_output) Removed.
1849 (read_external_sort_output) Removed.
1850 (sort_source_destroy) Removed.
1851 (sort_source_class) Removed.
1853 * sort.h: (struct sort_cases_pgm) Removed.
1854 (enum sort_direction) Moved to sort.c.
1856 * t-test.q: (calculate) Deal with new case, casefile ADTs.
1858 * tab.c: Remove debug code.
1860 * var-labs.c: Remove debug code.
1862 * var.h: (struct ccase) Removed.
1863 (struct case_list) Removed.
1865 * vars-atr.c: (discard_variables) Use free_case_source().
1867 * vars-prs.c: (parse_vs_variable) Make arg const.
1868 (parse_dict_variable) Ditto.
1869 (parse_variables) Make struct dictionary * arg const.
1870 (parse_var_set_vars) Make struct var_set * arg const.
1871 (struct var_set) Add const to some of the function pointers' args.
1872 (var_set_get_cnt) Make arg const.
1873 (var_set_get_var) Make first arg const.
1874 (var_set_lookup_var) Make first arg const.
1875 (dict_var_set_get_cnt) Make arg const.
1876 (dict_var_set_get_var) Make first arg const.
1877 (dict_var_set_lookup_var) Make first arg const.
1878 (var_set_create_from_dict) Make arg const. Add cast to aux
1880 (struct array_var_set) Add const to var member.
1881 (array_var_set_get_cnt) Make arg const.
1882 (array_var_set_get_var) Make first arg const.
1883 (array_var_set_lookup_var) Make first arg const.
1884 (var_set_create_from_array) Make first arg const. Insert cast.
1886 * vfm.c: (struct write_case_data) Change trns_case, sink_case
1887 members from `struct ccase *' to `struct ccase'.
1888 (static var lag_queue) Change from double to single pointer.
1889 (procedure) Optimize trivial case.
1890 (internal_procedure) Deal with changed case, case_source ADTs.
1891 (create_trns_case) Changed interface, rewrote.
1892 (open_active_interface) Initialize modified lag queue.
1893 (write_case) Deal with changed case ADT.
1894 (lag_case) Deal with modified lag queue.
1895 (close_active_file) Destroy modified lag queue.
1896 Deal with changed case_source, case_sink ADTs.
1897 (destroy_storage_stream_info) Make null arg into no-op.
1898 (storage_sink_make_source) Set aux in created source.
1899 (storage_source_read) Deal with changed case, casefile ADTs.
1900 (storage_source_create) New function.
1901 (lagged_case) Rewrite.
1902 (free_case_source) New function.
1903 (free_case_sink) Rewrite.
1904 (struct split_aux_data) Changed prev_case from `struct ccase *' to
1906 (procedure_with_splits) Deal with changed prev_case.
1907 (procedure_with_splits_callback) Ditto.
1908 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
1910 (multipass_procedure_with_splits) Deal with changed prev_case.
1911 (multipass_split_callback) Ditto.
1914 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
1916 The workspace idea didn't work out.
1918 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
1920 * workspace.c: Removed.
1922 * workspace.h: Removed.
1924 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
1926 Fully implement arbitrary delimiters on DATA LIST, extending the
1927 half implementation that was already there.
1929 * data-list.c: (struct data_list_pgm) Remove `delim', add
1930 `delims', `delim_cnt'.
1931 (cmd_data_list) Initialize new members. Parse delimiters and
1932 clean up code a bit.
1933 (cut_field) Extract fields with arbitrary delimiters. Also, fix
1934 handling of leading commas.
1935 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
1937 (read_from_data_list_free) Adapt to new DFM interfaces.
1938 (read_from_data_list_list) Ditto.
1939 (repeating_data_trns_proc) Ditto.
1941 * dfm.c: Split up reader and writer into separate code, because
1942 they do different things. Use struct string instead of explicit
1943 allocation code, for clarity.
1944 (enum dfm_reader_flags) New enum.
1945 (struct dfm_fhuser_ext) Removed.
1946 (struct dfm_reader_ext) New.
1947 (get_reader) New function, used by just about all the reader
1949 (dfm_close) Removed.
1950 (close_reader) New function.
1951 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
1952 (dfm_open_for_writing) Ditto.
1953 (macro force_line_buffer_expansion) Removed.
1954 (count_tabs) Removed.
1955 (tabs_to_spaces) Removed.
1956 (read_record) Deal with new dfm_reader_ext. Use struct string
1957 functions. Don't convert tabs to spaces.
1958 (dfm_eof) New function.
1959 (dfm_get_record) Changed interface, rewrote.
1960 (dfm_expand_tabs) New function.
1961 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
1962 dfm_reader_ext, rewritten.
1963 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
1964 dfm_reader_ext, rewritten.
1965 (dfm_set_record) Removed in favor of dfm_forward_columns().
1966 (dfm_forward_columns) New function.
1967 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
1968 dfm_reader_ext, rewritten.
1969 (static var dfm_r_class) Use close_reader for the destructor.
1970 (struct dfm_writer_ext) New.
1971 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
1972 bounce buffer now instead of local allocation.
1973 (close_writer) New function.
1974 (static var dfm_writer_ext) Use close_writer for destructor.
1975 (cmd_begin_data) Adapt to new dfm_reader_ext.
1977 * file-handle.q: Add support for per-file tab width.
1978 (struct private_file_handle) Add tab_width member.
1979 (q2c specifications) Add tabwidth subcommand.
1980 (cmd_file_handle) Put parsed tab width into private_file_handle.
1981 (create_file_handle) Set default tab width.
1982 (handle_get_tab_width) New function.
1984 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
1986 * inpt-pgm.c: (reread_trns_proc) Ditto.
1988 * matrix-data.c: (context) Ditto.
1989 (another_token) Ditto.
1993 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
1995 * casefile.c: (casefile_destroy) Fix memory leak by freeing
1997 (casereader_destroy) Don't close file descriptor -1.
1999 * recode.c: (cmd_recode) Fix memory leak.
2001 * set.q: (q2c specifications) Fix typo in user message.
2003 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2004 undefined behavior for overlapping arguments.
2006 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2008 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2009 don't call it when we're running under valgrind.
2010 (call_posix_fadvise) New function.
2011 (casefile_to_disk) Use call_posix_fadvise().
2012 (reader_open_file) Ditto.
2014 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2016 Update our string ADTs, struct string and struct len_string. Get
2017 rid of pool support, which was largely unused. Rename lots of
2018 functions to have more obvious or consistent names.
2020 * ascii.c: Get rid of ascii_pool. It was only used for string
2022 (ascii_open_global) Don't create ascii_pool.
2023 (ascii_close_driver) Don't destroy ascii_pool.
2024 (ascii_postopen_driver) Don't use pool.
2025 (ascii_close_driver) Destroy strings manually.
2027 * str.c: (ds_create) Remove pool argument, all references updated.
2029 (ds_replace) Remove pool support, make more efficient when we
2030 don't need to reallocate.
2031 (ds_destroy) Remove pool support.
2032 (ds_rpad) New function.
2033 (ds_size) Renamed ds_capacity(), all references updated.
2034 (ds_value) Renamed ds_c_str(), all references updated.
2035 (ds_concat) Renamed ds_puts(), all references updated.
2036 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2037 (ds_putchar) Renamed ds_putc(), all references updated.
2038 (ds_getline) Renamed ds_gets(), all references updated.
2039 (ls_create) Remove pool argument, all references updated.
2040 (ls_create_buffer) Ditto.
2041 (ls_destroy) Removed pool support.
2042 (ls_value) Renamed ls_c_str(), all references updated.
2044 * str.h: (ls_length) [__GNUC__] Add inline version.
2045 (ls_c_str) [__GNUC__] Add inline version.
2046 (ls_end) [__GNUC__] Add inline version.
2047 (struct string) Remove pool member. Rename `size' to `capacity',
2048 all references updated.
2050 * tab.c: (text_format) Instead of using pool argument to
2051 ls_create_buffer(), call pool_register() on allocated data.
2053 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2055 We're abusing the current ASCII driver by telling it to allocate a
2056 9999-line, 9999-character page in the tests. This causes some
2057 systems to curl up and die because it allocates 20 MB of
2058 contiguous RAM. This change alleviates at least part of the
2059 problem. It is mostly a stop-gap until the new output system is
2062 * ascii.c: (struct line) New structure.
2063 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2064 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2065 (ascii_preopen_driver) Initialize new members, not old ones.
2066 (ascii_close_driver) Destroy new members, not old ones.
2067 (ascii_open_page) Allocate new members, not old ones.
2068 (expand_line) Allocate room in line.
2069 (draw_line) Use new members.
2070 (ascii_line_horz) Ditto.
2071 (ascii_line_vert) Ditto.
2072 (ascii_line_intersection) Ditto.
2074 (output_lines) Ditto.
2075 (ascii_close_page) Ditto.
2077 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2079 * matrix.c: Dead code. Removed.
2081 * matrix.h: Dead code. Removed.
2083 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2085 Contrary to what I'd always understood, there is an efficient
2086 algorithm for deletion from a hash table populated via linear
2087 probing. This change implements it.
2089 * hash.c: (hsh_rehash) Probe in increasing order.
2091 (locate_matching_entry) Ditto.
2092 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2094 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2096 * moments.c (calc_moments): Adjust calculation of kurtosis to
2097 avoid subtracting huge numbers from huge numbers, on Michael
2100 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2102 Rework moments routines for improved numerical stability based on
2103 Michael Kiefte's advice. Any bugs or remaining numerical problems
2104 are still mine though.
2106 There is now a struct moments1 for use with one-pass moments. It
2107 uses a provisional means algorithm as an attempt to improve
2108 accuracy of higher moments. The older struct moments now only
2109 handles two-pass moments.
2111 * aggregate.c: Use moments1 instead moments.
2113 * descript.c: Revert previous change, which is no longer needed
2114 due to the moments revision.
2116 * moments.c: (calc_moments) New function for calculating variance,
2118 (moments_pass_one) Only accumulate weights bigger than zero.
2119 (moments_calculate) Allow calculating the mean on pass one, others
2120 require pass two. Implement in terms of calc_moments().
2121 (struct moments1) New structure.
2122 (init_moments1) New function.
2123 (moments1_clear) Ditto.
2124 (moments1_create) Ditto.
2125 (moments1_add) Ditto.
2126 (moments1_calculate) Ditto.
2127 (moments1_destroy) Ditto.
2128 (cmd_debug_moments) Deal with `struct moments' or `struct
2129 moments1' as requested by user.
2131 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2133 * Makefile.am (pspp_SOURCES): Remove debug.c.
2135 * debug.c: Removed. It was empty anyway.
2137 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2139 * descript.c (calc_descriptives): Fix assert failure when only
2140 MOMENT_MEAN is needed.
2142 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2146 fixed problem with parsing in match_statistic() causing
2147 "DESCRIPTIVE STAT=MEAN." to barf.
2149 "MEAN" is now default if "SORT" given without specification.
2151 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2152 generally less forgiving of syntax errors: better to have it do
2153 nothing and type it in again then to not know what it actually did
2156 z-score transformation now checks score for user-missing values
2157 and checks std_dev for SYSMIS.
2159 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2161 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2162 Changed dict_get_case_weight() to accept an additional int * flag
2163 to complain about system-missing, user-missing, zero, or negative
2164 weights and updated existing functions to pass int * to
2165 dict_get_case_weight().
2167 2004-04-05 jmd <jmd@gnu.org>
2169 * main.c: Fixed configuration problems with gsl
2171 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2173 2004-04-03 blp <blp@gnu.org>
2175 * lexer.c, ChangeLog:
2176 Fix infinite loop on comment at end of file, add test.
2178 2004-04-03 jmd <jmd@gnu.org>
2180 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2181 Fixed the calculation of percentiles and added --syntax and --algorithm options
2183 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2185 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2188 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2190 * frequencies.q: Fixed the calculation of percentiles
2192 * Makefile.am: Added the --ansi flag and dealt with the
2193 consequences. Added some entries to PSPP_sources so that
2194 make distcheck would pass
2196 * cmdline.c: Added the --syntax and --algorithm options
2198 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2200 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2202 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2203 use the new multipass_split_... mechanism.
2205 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2207 * frequencies.q: (calc_stats) Use moments data structure and
2208 calc_seskew(), calc_sekurt() functions.
2210 * set.q main.c settings.h Added support for --syntax and --algorithm
2213 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2215 * vfm.c: Had to get last call to multipass_split_output() inside
2216 open_active_file()/close_active_file() pairing, so introduce new
2218 (internal_procedure) Move procedure() code here, except for calls
2219 to open_active_file() and close_active_file().
2220 (procedure) Wrap open_active_file() and close_active_file() around
2221 internal_procedure().
2222 (multipass_procedure_with_splits) Wrap open_active_file() and
2223 close_active_file() around internal_procedure().
2225 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2227 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2229 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2231 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2233 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2235 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2237 * algorithm.c: By default turn off some of the more expensive
2239 (expensive_assert) New macro which expands to assert if
2240 EXTRA_CHECKS is defined, to nothing otherwise.
2241 (unique) Use expensive_assert().
2242 (binary_search) Ditto.
2248 * command.c: (conflicting_3char_prefixes) Words that are the same
2249 don't cause conflicts when they are abbreviated to the first three
2252 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2253 nonterm_node's n earlier.
2254 (generic_str_func) Ditto.
2256 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2258 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2259 test multipass support, take advantage of new moments
2260 calculation, and to not be such crappy code. Get rid of q2c
2261 processing for DESCRIPTIVES.
2263 * vfm.c: (struct multipass_split_aux_data) New structure.
2264 (multipass_procedure_with_splits) New function.
2265 (multipass_split_callback) New function.
2266 (multipass_split_output) New function.
2267 * descript.q: Removed.
2269 * descript.c: New file.
2271 * var.h: Removed descriptives enums.
2272 (struct descriptives_proc) Removed.
2273 (struct variable) Removed p.dsc.
2275 * Makefile.am: (q_sources_c) Remove descript.c.
2276 (q_sources_q) Removed descript.q.
2278 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2280 New manager for keeping track of used workspace.
2282 * workspace.c: New file.
2284 * workspace.h: New file.
2286 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2288 * sort.c: (do_internal_sort) Use workspace_malloc().
2289 (destroy_internal_sort) Use workspace_free().
2291 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2293 New `struct casefile' for managing sets of cases.
2295 * casefile.c: New file.
2297 * casefile.h: New file.
2299 * command.def: Add DEBUG CASEFILE command.
2301 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2303 * sort.c: (sort_cases) Move logic for sending storage file to disk
2304 into do_external_sort().
2305 (struct internal_sort) Use an array of ccase pointers instead of a
2307 (do_internal_sort) Rewrite to handle casefiles.
2308 (compare_case_list) Removed.
2309 (compare_cases) New function.
2310 (compare_case_dblptrs) New function.
2311 (read_internal_sort_output) Deal with new struct internal_sort.
2313 * vfm.c: (static var workspace_overflow) Removed.
2314 (struct storage_stream_info) Removed all the members. Added
2315 struct casefile * member.
2316 (storage_sink_open) Use casefile.
2317 (open_storage_file) Removed.
2318 (write_storage_file) Removed.
2319 (storage_to_disk) Removed.
2320 (destroy_storage_stream_info) Use casefile.
2321 (storage_sink_write) Use casefile.
2322 (storage_sink_make_source) Use casefile.
2323 (storage_source_count) Use casefile.
2324 (storage_source_read) Use casefile.
2325 (storage_source_on_disk) Removed.
2326 (storage_source_get_cases) Removed.
2327 (storage_source_set_cases) Removed.
2328 (storage_source_get_casefile) New function.
2330 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2332 New `struct moments' for calculating moments.
2338 * moments.c: New file.
2340 * moments.h: New file.
2342 * command.def: Add DEBUG MOMENTS command.
2344 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2347 * aggregate.c: Modify AGGREGATE to use the new moments
2348 calculation, even if not in such a great way.
2349 (struct agr_var) Add `moments' member.
2350 (parse_aggregate_functions) Set `moments' member to null.
2351 (agr_destroy) Destroy `moments' member.
2352 (accumulate_aggregate_info) Use `moments' for standard deviation.
2353 (dump_aggregate_info) Ditto.
2354 (initialize_aggregate_info) Create or clear `moments'.
2356 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2357 cube(), pow4() that were in stats.h. All references updated.
2359 * crosstabs.q: stats.h had chi-square significance functions. Use
2361 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2363 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2364 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2366 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2368 * dictionary.c: (dict_compact_values) Compacted values need to
2371 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2373 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2374 `/' at start. Check return value of parse_variables() for error
2377 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2379 Revamp expressions: make the code a little nicer, and fix bugs
2382 * expr-evl.c: (expr_evaluate) Make expression argument const.
2383 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2384 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2385 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2386 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2387 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2388 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2389 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2390 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2391 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2392 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2393 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2394 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2395 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2397 * expr-opt.c: (optimize_expression) Rewrite.
2402 (macro s0l) Removed.
2404 (macro s1l) Removed.
2406 (macro s2l) Removed.
2409 (eq_num_con) New function.
2410 (optimize_tree) New function.
2411 (macro rnc) Removed.
2412 (macro frnc) Removed.
2413 (str_search) Add const to string params.
2414 (str_rsearch) Ditto.
2415 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2416 str[], str_len[] locals to substitute for most of removed macros.
2417 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2418 Removed support for missing values because we're never called with
2419 missing values. Use set_number() or set_number_errno() instead of
2420 rnc or frnc. Removed any stuff that caused trouble in testing.
2421 We can re-add it later if it really slows anything. Fix some
2423 (evaluate_tree_with_missing) Not yet supported. To be added later
2425 (repl_num_con) Removed.
2426 (collapse_node) New function.
2427 (force_repl_num_con) Removed.
2428 (set_number) New function.
2429 (set_number_errno) New function.
2430 (repl_str_con) Removed.
2431 (set_string) New function.
2432 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2434 (dump_node) No special case for OP_AND, OP_OR.
2436 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2437 (expr_get_type) New function.
2438 (type_check) Rewrite.
2439 (type_coercion) New function.
2440 (struct operator) New structure.
2441 (match_operator New function.
2442 (parse_binary_operators) New function.
2443 (parse_inverting_unary_operator) New function.
2444 (parse_or) Rewritten.
2445 (parse_and) Rewritten.
2446 (parse_not) Rewritten.
2447 (parse_rel) Rewritten.
2448 (parse_add) Rewritten.
2449 (parse_mul) Rewritten.
2450 (parse_neg) Rewritten.
2451 (parse_exp) Rewritten.
2452 (parse_sysvar) Add $TRUE, $FALSE system variables.
2453 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2454 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2456 (struct function) Remove desc, change `func' prototype.
2457 (unary_func) Remove special cases.
2458 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2459 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2460 (VALUE_func) Use allocate_var_node().
2461 (nary_num_func) Allow MIN and MAX for strings.
2462 Use allocate_var_node(). Properly clean up.
2464 (generic_str_func) Use local table instead of removed `desc'
2465 member. Mostly rewrite.
2466 (get_num_args) Revise error message.
2467 (parse_function) Return EXPR_ERROR, not 0 on error.
2469 (macro varies) Removed.
2470 (ops[]) Use expr.def.
2471 (free_node) Do nothing if node is null.
2472 (allocate_num_con) New function.
2473 (allocate_str_con) New function.
2474 (allocate_var_node) New function.
2475 (allocate_binary_nonterminal) New function.
2476 (append_nonterminal_arg) Removed.
2477 (static var func_tab[]) Revised.
2478 (expr_debug_print_postfix) Make parameter const.
2479 Use printf() instead of debug_printf().
2481 * expr.def: New file.
2483 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2484 use named enum instead of unnamed, all references updated. Add
2485 EXPR_ANY, EXPR_NO_OPTIMIZE.
2487 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2488 instead of defining OP_* directly.
2489 (macro IS_TERMINAL) New macro.
2490 (macro IS_NONTERMINAL) New macro.
2491 (enum OP_NO_FLAGS) New.
2493 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2495 * error.c: (err_assert_fail) msg variable needs to be non-const.
2497 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2499 * debug.c: (cmd_debug_evaluate) Rewrite.
2501 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2503 Fix some CROSSTABS bit rot stupidity.
2505 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2506 (internal_cmd_crosstabs) Initializes cells[] correctly.
2507 (float_M_suffix) Rename format_cell_entry(), change prototype,
2509 (display_crosstabulation) Fix cell formatting.
2511 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2513 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2514 to call lex_discard_line() to do that.
2516 * command.c: (run_command) Call lex_discard_line() after
2519 * lexer.c: (lex_entire_end) Change behavior.
2520 (lex_rest_of_line) Change behavior. Return const char *.
2521 (lex_discard_line) Don't clear getl_buf, don't emit message.
2523 * main.c: (handle_error) Emit message here.
2525 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2526 instead of lex_entire_line().
2528 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2530 * title.c: (get_title) Call lex_discard_line() after
2532 (cmd_file_label) Ditto.
2533 (cmd_document) Deal with const char * return value.
2535 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2537 Removed REMARK command.
2539 * command.c: (extract_prefix) Removed.
2540 (output_line) Removed.
2541 (cmd_remark) Removed.
2543 * command.def: Remove REMARK.
2545 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2547 Added abort() after lots of assert(0) invocations to avoid some
2548 compiler warnings. We really need a NOT_REACHED macro.
2550 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2552 * sort.c: Added missing call to temp_file_close. Changed error
2553 messages to warnings.
2555 * set.q: Improved setting of set_view{length,width} to be more tolerant
2558 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2560 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2561 used with incorrect syntax.
2563 * error.c, error.h et al: Overridden definition of assert for a
2566 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2567 subcommand was given when it ought to have been.
2569 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2571 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2575 (tab_joint_text) Ditto.
2577 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2579 * levene.c: Add #include.
2581 * set.q: (set_viewport) Add `int' argument to make its prototype
2582 correct for signal().
2584 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2586 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2589 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2591 Changed DFM from open-at-first-access to explicit-open. Before,
2592 calling dfm_get_record() or dfm_put_record() would automatically
2593 open the file. Now, you have to call dfm_open_for_reading() or
2594 dfm_open_for_writing() explicitly. This makes it possible to
2595 check permissions, file existence, etc. earlier.
2597 Also made struct file_handle more opaque, and clean up in general.
2599 * data-list.c: (cmd_data_list) Open handle for reading.
2601 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2603 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2604 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2605 (open_inline_file) Removed.
2606 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2607 it. Deal with line_number in extension record instead of file
2609 (dfm_get_record) Rewrote.
2610 (dfm_put_record) Rewrote.
2611 (dfm_push) Assert file is open and one of ours. Deal with
2612 line_number in extension record instead of file handle.
2613 (dfm_pop) Assert file is open and one of ours. Deal with
2614 line_number in extension record instead of file handle.
2615 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2618 * file-handle.h: (enum constants RH_RF_*) Removed.
2619 (enum constants FH_MD_*) Removed.
2620 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2621 `recform', `lrecl', `mode' members. Public references to
2622 `recform' changed to use handle_get_mode(), references to `lrecl'
2623 changed to use handle_get_record_width(). Added `private' member.
2624 (enum file_handle_mode) New.
2626 * file-handle.q: (struct private_file_handle) New structure.
2627 (struct file_handle_list) New structure.
2628 (static var files) New.
2629 (static var file_handles) Removed.
2630 (init_file_handle) Removed.
2631 (create_file_handle) Removed.
2632 (get_handle_with_name) New function.
2633 (get_handle_for_filename) New function.
2634 (cmd_file_handle) Rewritten.
2635 (hash_file_handle) Removed.
2636 (cmp_file_handle) Removed.
2637 (fh_init_files) Rewritten.
2638 (fh_parse_file_handle) Rewritten. Allows identifiers as
2640 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2642 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2643 references updated. Rewritten.
2644 (fh_record_width) Renamed handle_get_record_width(), all
2645 references updated. Rewritten.
2646 (handle_get_mode) New function.
2648 * file-type.c: (cmd_file_type) Open handle for reading.
2650 * filename.c: [unix] (struct file_identity) New structure.
2651 [unix] (fn_get_identity) New function.
2652 [unix] (fn_free_identity) New function.
2653 [unix] (fn_compare_file_identities) New function.
2654 [!unix] (struct file_identity) New structure.
2655 [!unix] (fn_get_identity) New function.
2656 [!unix] (fn_free_identity) New function.
2657 [!unix] (fn_compare_file_identities) New function.
2659 * lexer.c: (static var put) Renamed put_token, all references
2661 (static var put_tokstr) New.
2662 (static var put_tokval) New.
2663 (lex_init) Initialize put_tokstr().
2664 (restore_token) New function.
2665 (save_token) New function.
2666 (lex_get) Use restore_token().
2667 (lex_put_back) Use save_token().
2668 (lex_put_back_id) New function.
2669 (lex_put_forward) Removed.
2670 (lex_preprocess_line) Set put_token instead of using
2672 (lex_negative_to_dash) Use save_token(), set put_token directly.
2673 (dump_token) Use stderr instead of stdout.
2675 * main.c: (main) Remove call to cmd_init().
2677 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2679 * pfm-read.c: Use handle_get_filename() instead of trying to use
2680 h->fn directly, all over.
2682 * pfm-write.c: Ditto.
2684 * print.c: (internal_cmd_print) Open handle for writing.
2685 (dump_table) Use handle_get_filename().
2686 (print_trns_proc) Use handle_get_mode().
2687 (cmd_print_space) Use fh_parse_file_handle().
2688 Open handle for writing.
2689 [0] (debug_print) Removed.
2691 * sfm-read.c: Use handle_get_filename() instead of trying to use
2692 h->fn directly, all over.
2694 * sfm-write.c: Ditto.
2696 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2700 * autorecode.c: (arc_free) Free arc->src_values.
2702 * error.c: (msg) Free buf.
2704 * val-labs.c: (do_value_labels) Always free vars.
2706 * vfm.c: (close_active_file) If sink has no make_source then call
2707 its destroy function.
2709 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2711 Fixed cmd_parse() so that it always skips past a full command
2712 name. A few special commands for which this would be bad get
2713 special treatment. This lets us drop code for skipping past the
2714 end of a command name in most cmd_*() functions. It's not worth
2715 listing all the commands affected.
2717 * command.c: (struct command) Remove `cmd' member, replace by
2718 `name' member, all references updated. Remove `word', `next',
2719 `skip_entire_name' members.
2720 (macro DEFCMD) Deal with revised `struct command'.
2721 (macro UNIMPL) Ditto.
2722 (macro SPCCMD) New macro for commands whose last word shouldn't be
2724 (static array cmd_table[]) Make const, rename `commands', remove
2726 (macro COMMAND_CNT) New macro.
2727 (split_words) Removed.
2729 (FILE_TYPE_okay) Make parameter const.
2730 (cmd_parse) Improve error messages.
2731 (match_strings) New function.
2732 (next_word) New function.
2733 (enum command_match) New enum.
2734 (conflicting_3char_prefixes) New function.
2735 (conflicting_3char_prefix_command) New function.
2736 (cmd_match_words) New function.
2737 (count_matching_commands) New function.
2738 (get_command_name) New function.
2739 (free_words) New function.
2740 (unknown_command_error) New function.
2741 (figure_out_command) Renamed parse_command_name(), rewritten.
2743 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2744 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2745 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2748 * command.h: (macro SPCCMD) New.
2750 * include.c: (cmd_include_at) Removed.
2751 (cmd_include) Allow identifier to be used as filename.
2753 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2755 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2758 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2760 Start work on better test framework.
2762 * Makefile.am: (pspp_sources) Add debug.c.
2764 * debug.c: New file.
2766 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2767 cmd_debug_evaluate().
2769 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2771 * expr.h: (enum constant PXP_DUMP) Removed.
2773 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2775 * set.q: Implemented the SHOW command, and synced it to the existing
2778 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2779 changes as the window size is changed.
2781 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2782 environment variables if other methods are not available.
2784 glob.c: Removed a lot of global variables from glob.c and encapsulated
2787 random.c: Tidied up the way the random seed is set.
2789 str.c: Added a ds_vprintf function.
2791 error.c: Extended dump_message so that messages are always broken at
2794 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2796 * pfm-write.c: (bufwrite) Write out the correct element for string
2797 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2799 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2801 Get rid of static and global (!) vars in matrix-data.c.
2803 * matrix-data.c: (static var nr_data) Removed.
2804 (static var nr_factor_values) Removed.
2805 (static var max_cell_index) Removed.
2806 (static var split_values) Removed.
2807 (struct nr_aux_data) New structure.
2808 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2809 place of static vars, pass to create_case_source() and procedure()
2811 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2812 struct matrix_data_pgm *.
2813 (nr_read_splits) Ditto.
2814 (nr_read_factors) Ditto.
2815 (nr_output_data) Ditto.
2816 (static var wr_content) Removed.
2817 (global var wr_data) Removed.
2818 (global var wr_current) Removed.
2819 (struct wr_aux_data) New structure.
2820 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2821 place of static vars, pass to create_case_source() and procedure()
2823 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
2824 instead of matrix_data_pgm *.
2825 (wr_read_splits) Ditto.
2826 (wr_output_data) Ditto.
2827 (wr_read_rowtype) Ditto.
2828 (wr_read_factors) Ditto.
2829 (wr_read_indeps) Ditto.
2831 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
2833 Get rid of static vars in autorecode.c.
2835 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
2836 `n_arc' to `spec_cnt'. All references updated.
2837 (static var v_src) Removed.
2838 (static var v_dest) Removed.
2839 (static var h_trns) Removed.
2840 (static var nv_src) Removed.
2841 (static var descend) Removed.
2842 (static var print) Removed.
2843 (enum direction) New enum.
2844 (struct autorecode_pgm) New structure.
2845 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
2846 Move n_dest local var into struct autorecode_pgm for ease of
2847 clean-up. Use arc_free().
2848 (arc_free) New function.
2849 (recode) Modify to take struct autorecode_pgm * parameter instead
2850 of using statics. Let the caller clean up.
2851 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
2852 instead of statics. Rearrange code a little.
2854 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
2856 Get rid of static, global vars in recode.c. Remove debug code.
2858 * recode.c: (static var head) Removed.
2859 (global var v) Removed.
2860 (global var nv) Removed.
2861 (cmd_recode) New local variables head, v, nv. Initialize and free
2862 v. Don't call debug_print().
2863 [DEBUGGING] (dump_dest) Removed.
2864 [DEBUGGING] (debug_print) Removed.
2866 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
2868 Get rid of static vars in expr-opt.c.
2870 * expr-opt.c: (static var e) Removed.
2871 (static var nop) Removed.
2872 (static var mop) Removed.
2873 (static var ndbl) Removed.
2874 (static var mdbl) Removed.
2875 (static var nstr) Removed.
2876 (static var mstr) Removed.
2877 (static var nvars) Removed.
2878 (static var mvars) Removed.
2879 (struct expr_dump_state) New structure.
2880 (dump_expression) Use new struct expr_dump_state instead of static
2881 vars and pass to functions we call.
2882 (dump_node) Use struct expr_dump_state * parameter.
2884 (emit_num_con) Ditto.
2885 (emit_str_con) Ditto.
2888 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
2890 Get rid of static var in COUNT.
2892 * count.c: (static var head) Move into cmd_count().
2893 (cmd_count) [DEBUGGING] Don't call debug_print.
2894 [DEBUGGING] (debug_print) Removed.
2896 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
2898 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
2900 * val-labs.c: (static var v) Removed.
2901 (static var nv) Removed.
2902 [DEBUGGING] (debug_print) Removed.
2903 (verify_val_labs) Add struct variable **, int parameters.
2904 (get_label) Ditto. Improve error messages, streamline.
2905 (erase_labels) New function for erasing value labels, taking over
2906 part of verify_val_labs()'s function.
2909 (cmd_value_labels) No need to call init() or done() anymore.
2910 (cmd_add_value_labels) Ditto.
2911 (do_value_labels) Add vars, var_cnt local variables. Clean up
2912 after them internally. Call erase_labels() if we should. Don't
2915 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
2917 Get rid of static vars in MATCH FILES.
2919 * get.c: (static var mtf_head) Removed.
2920 (static var mtf_tail) Removed.
2921 (static var mtf_by) Removed.
2922 (static var mtf_n_by) Removed.
2923 (static var mtf_master) Removed.
2924 (static var mtf_seq_num) Removed.
2925 (static var mtf_seq_nums) Removed.
2926 (static var mtf_sink) Removed.
2927 (static var mtf_case) Removed.
2928 (struct mtf_proc) New structure.
2929 (cmd_match_files) Use struct mtf_proc instead of static vars.
2930 (mtf_processing_finish) Ditto.
2932 (mtf_delete_file_in_place) Ditto.
2933 (mtf_read_nonactive_records) Ditto.
2934 (mtf_compare_BY_values) Ditto.
2935 (mtf_processing) Ditto.
2936 (mtf_merge_dictionary) Ditto.
2938 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
2940 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
2942 * dictionary.c: (dict_rename_var) Add assertion.
2943 (dict_contains_var) Check by index instead of name.
2945 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
2947 Get rid of compaction_necessary, compaction_nval, compaction_case.
2948 Redo VFM interface. Replace disk_sink and memory_sink by
2949 storage_sink, disk_source and memory_source by storage_source.
2951 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
2955 (struct write_case_data) Remove `begin_func', `end_func',
2956 `func_aux' members. Add `aux', `trns_case', `sink_case',
2957 `cases_written', `cases_analyzed' members.
2958 (global var compaction_necessary) Make static.
2959 (global var compaction_nval) Removed.
2960 (global var compaction_case) Removed.
2961 (static var case_count) Removed.
2962 (struct procedure_aux_data) Removed.
2963 (struct split_aux_data) Removed.
2964 (procedure) Remove begin_func, end_func parameters. Rewrite.
2965 (static var not_canceled) Removed.
2966 (process_active_file) Removed.
2967 (process_active_file_write_case) Removed.
2968 (process_active_file_output_case) Removed.
2969 (prepare_for_writing) Moved into open_active_file().
2970 (arrange_compaction) Ditto.
2972 (open_active_file) Rewrote.
2973 (write_case) New function.
2974 [DEBUGGING] (index_to_varname) Removed.
2975 (execute_transformations) New function.
2976 (exclude_this_case) Renamed filter_case(), changed interface.
2977 (clear_case) Added struct ccase * parameter to interface.
2978 (close_active_file) Added struct write_case_data * parameter,
2980 (disk_sink_create) Removed.
2981 (disk_sink_destroy) Removed.
2982 (disk_sink_make_source) Removed.
2983 (disk_sink_write) Removed.
2984 (disk_source_count) Removed.
2985 (disk_source_destroy) Removed.
2986 (disk_source_read) Removed.
2987 (global var disk_sink_class) Removed.
2988 (global var disk_source_class) Removed.
2989 (global var memory_sink_class) Removed.
2990 (global var memory_source_class) Removed.
2991 (memory_sink_create) Removed.
2992 (memory_sink_destroy) Removed.
2993 (memory_sink_make_source) Removed.
2994 (memory_sink_write) Removed.
2995 (memory_source_count) Removed.
2996 (memory_source_destroy) Removed.
2997 (memory_source_get_cases) Removed.
2998 (memory_source_read) Removed.
2999 (memory_source_set_cases) Removed.
3000 (struct disk_stream_info) Removed.
3001 (struct memory_sink_info) Removed.
3002 (struct memory_source_info) Removed.
3003 (write_active_file_to_disk) Removed.
3004 (destroy_storage_stream_info) New function.
3005 (global var null_sink_class) New var.
3006 (global var storage_sink_class) New var.
3007 (global var storage_source_class) New var.
3008 (open_storage_file) New function.
3009 (storage_sink_destroy) New function.
3010 (storage_sink_make_source) New function.
3011 (storage_sink_open) New function.
3012 (storage_sink_write) New function.
3013 (storage_source_count) New function.
3014 (storage_source_destroy) New function.
3015 (storage_source_get_cases) New function.
3016 (storage_source_on_disk) New function.
3017 (storage_source_read) New function.
3018 (storage_source_set_cases) New function.
3019 (storage_source_to_disk) New function.
3020 (storage_to_disk) New function.
3021 (struct storage_stream_info) New structure.
3022 (write_storage_file) New function.
3023 (procedure_write_case) Removed.
3024 (create_case_source) Add `struct dictionary *' parameter, all
3026 (create_case_sink) Ditto.
3027 (free_case_sink) New function.
3028 (struct split_aux_data) New structure.
3029 (procedure_with_splits) New function implementing what procedure()
3031 (SPLIT_FILE_proc_func) Removed.
3032 (procedure_with_splits_callback) New function.
3033 (equal_splits) New function.
3035 * aggregate.c: Pass around a struct instead of using statics.
3036 (static var outfile) Remove.
3037 (enum type) Give it tag `missing_treatment'.
3038 (static var missing) Remove.
3039 (static var sort) Remove.
3040 (static var agr_first) Remove.
3041 (static var agr_next) Remove.
3042 (static var case_count) Remove.
3043 (static var prev_case) Remove.
3044 (static var buf64_1xx) Remove.
3045 (static var buf_1xx) Remove.
3046 (struct agr_proc) New structure incorporating the above.
3047 (cmd_aggregate) Use new struct. Clean up error handling using
3048 agr_destroy(). Completely rewrite actual implementation of
3050 (create_sysfile) Add struct agr_proc * parameter, modify
3052 (parse_aggregate_functions) Ditto.
3053 (free_aggregate_functions) Ditto. Rename agr_destroy().
3054 (aggregate_single_case) Add struct agr_proc * parameter, modify
3056 (accumulate_aggregate_info) Ditto.
3057 (dump_aggregate_info) Ditto.
3058 (initialize_aggregate_info) Ditto.
3059 (agr_00x_trns_proc) Removed.
3060 (agr_00x_end_func) Removed.
3061 (agr_10x_trns_proc) Removed.
3062 (agr_10x_trns_free) Removed.
3063 (agr_10x_end_func) Removed.
3064 (agr_11x_read) Removed.
3065 (agr_11x_finish) Removed.
3066 [DEBUGGING] (debug_print) Removed.
3067 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3069 (agr_to_active_file) New function.
3070 (presorted_agr_to_sysfile) New function.
3071 (sort_agr_to_sysfile) New function.
3073 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3075 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3077 * descript.q: (cmd_descriptives) Ditto.
3079 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3080 to new procedure() interface.
3082 * command.c: (cmd_execute) Adapt to new procedure() interface.
3084 * dictionary.c: (dict_compact_values) Also delete scratch
3086 (dict_get_compacted_value_cnt) New function.
3087 (dict_get_compacted_idx_to_fv) New function.
3089 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3090 (cmd_flip) Adapt to new procedure() interface.
3091 (flip_sink_write) Use sink->idx_to_fv.
3093 * frequencies.q: (internal_cmd_frequencies) Use
3094 procedure_with_splits().
3096 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3097 (static var mtf_sink) New static var.
3098 (static var mtf_case) New static var.
3099 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3100 we actually implement the matching.
3101 (mtf_delete_file_in_place) Use mtf_case.
3102 (mtf_processing) Use mtf_case and mtf_sink.
3103 (cmd_export) Adapt to new procedure() interface.
3105 * levene.c: (levene) Use procedure_with_splits().
3107 * list.q: (cmd_list) Use procedure_with_splits().
3109 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3110 procedure() interface.
3111 (read_matrices_with_rowtype) Ditto.
3113 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3114 TEMPORARY. Adapt to new procedure() interface.
3116 * rename-vars.c: Warn about and cancel TEMPORARY.
3118 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3119 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3120 compaction_nval. Adapt to new procedure() interface. Use
3121 storage_source_to_disk().
3122 (do_internal_sort) Don't try to dump the cases to memory.
3123 (compare_case_lists) Pass null idx_to_fv.
3124 (struct initial_run_state) Add `idx_to_fv' member. Remove
3126 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3127 new procedure() interface. Reset irs->idx_to_fv after calling
3129 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3130 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3132 (destroy_initial_run_state) Don't dereference irs after freeing
3134 (allocate_cases) Don't calculate case_size locally.
3135 (compare_record) Add idx_to_fv parameter.
3136 (compare_record_run) Change parameter from struct sort_cases_pgm *
3137 to struct initial_run_state *. Pass irs->idx_to_fv to
3139 (compare_record_run) Third parameter now a struct
3140 initial_run_state *.
3141 (output_record) No need for out_case anymore. Pass irs, not
3142 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3144 (merge) Use case_size from struct sort_cases_pgm.
3145 (merge_once) Use case_size from struct sort_cases_pgm.
3146 Pass null pointer to compare_record() as idx_to_fv.
3147 (global var sort_sink_class) Make static.
3149 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3151 * temporary.c: Remove debugging crap.
3153 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3155 * t-test.q, levene.c: Fixed up the handling of MISSING values
3158 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3160 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3163 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3165 Change explicit variable name checks into use of
3166 dict_class_from_id().
3168 * dictionary.c: (dict_create_var) Change explicit variable name
3169 check into use of dict_class_from_id().
3171 * get.c: (trim_dictionary) Ditto.
3173 * sel-if.c: (cmd_filter) Ditto.
3175 * sysfile-info.c: (cmd_display) Ditto.
3177 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3179 * vfm.c: (arrange_compaction) Ditto.
3181 * weight.c: (cmd_weight) Ditto.
3183 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3185 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3186 transformation following the input program, if any, for some
3187 reason we special-cased f_trns. That's just wrong. It should
3188 always be set to n_trns.
3190 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3192 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3193 introduced in last check-in.
3195 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3197 * format.c: (global array translate_fmt[]) Removed.
3198 (translate_fmt) New function as replacement.
3199 (parse_format_specifier_name) Rewrite.
3201 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3204 * sfm-read.c: (parse_format_spec) Ditto.
3206 * postscript.c: (text) Fix handling of fonts with missing
3209 * sort.c: (struct external_sort) Add temp_name member.
3210 (destroy_external_sort) Free temp_dir, temp_name members.
3211 (init_external_sort) Allocate temp_name.
3212 (get_temp_file_name) Change prototype.
3213 (open_temp_file) Deal with change to get_temp_file_name().
3214 (close_temp_file) Ditto.
3215 (remove_temp_file) Ditto.
3216 (write_temp_file) Ditto.
3217 (read_temp_file) Ditto.
3218 (sort_sink_destroy) Removed.
3219 (sort_sink_class) Change destroy member to null.
3221 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3223 Eliminate temp_case.
3225 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3226 anymore. Use agr_11x_finish().
3227 (aggregate_single_case) Make first param const.
3228 (accumulate_aggregate_info) Ditto.
3229 (agr_00x_end_func) Use compaction_case, not temp_case.
3230 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3232 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3233 (cmd_data_list) Initialize case_size.
3234 (read_from_data_list_fixed) Add struct ccase * param, use instead
3236 (read_from_data_list_free) Ditto.
3237 (read_from_data_list_list) Ditto.
3238 (read_one_case) Rename data_list_trns_proc(), all references
3239 updated. Add argument in calling above functions. Use c
3240 argument instead of temp_case.
3241 (destroy_dls) Rename data_list_trns_free(), all references
3244 * expr-evl.c: (expr_evaluate) Make second parameter const.
3246 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3247 (cmd_end_file_type) Initialize `case_size'.
3248 (file_type_source_read) Add struct ccase * parameter. Use instead
3251 * flip.c: Rewritten.
3253 * get.c: (struct get_pgm) New structure to keep track of
3255 (cmd_get) Initialize case_size.
3257 (get_source) Deal with struct get_pgm.
3258 (get_source_read) Add struct ccase * parameter, use instead of
3260 (import_source_read) Ditto.
3262 * get.c: Use a null pointer instead of temp_case to represent the
3263 "current case" in a struct mtf_file's input member.
3264 (mtf_processing_finish) Pass null to mtf_processing(), not
3266 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3267 (mtf_compare_BY_values) Add extra arg, use instead of null input
3269 (mtf_processing) Use c parameter instead of temp_case. Pass
3270 compaction_case to process_active_file_output_case().
3272 * glob.c: (global variable temp_case) Removed.
3274 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3275 (cmd_input_program) Initialize case_size. Set
3276 vfm_source->value_cnt.
3277 (init_case) Add struct ccase * parameter, use instead of
3280 (input_program_source_read) Ditto.
3282 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3283 (dump_cell_content) Ditto.
3284 (nr_output_data) Ditto.
3285 (read_matrices_without_rowtype) Ditto.
3286 (matrix_data_read_with_rowtype) Ditto.
3287 (wr_read_splits) Ditto.
3288 (wr_output_data) Ditto.
3290 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3292 * sort.c: (sort_cases) Initialize scp->case_size.
3293 (struct external_sort) Remove `case_size' member.
3294 (write_initial_runs) Only call vfm_sink->class_destroy if
3296 (struct sort_source_aux) New structure.
3297 (sort_source_read_helper) New function.
3298 (sort_source_read) Use sort_source_read_helper().
3299 (read_sort_output) Change interface to be more reasonable.
3300 (read_internal_sort_output) Ditto.
3301 (read_external_sort_output) Ditto.
3303 * vars-prs.c: (dict_class_to_name) Pass return value through
3306 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3307 (procedure) Initialize trns_case.
3308 (procedure) Pass trns_case to vfm_source->class->read().
3310 (process_active_file) Start using struct procedure_aux_data.
3311 (process_active_file_write_case) Pass trns_case to
3312 transformations, lag_case(), clear_case().
3313 (process_active_file_output_case) Add struct ccase * parameter.
3314 (create_trns_case) New function.
3315 (make_temp_case) Removed.
3316 (vector_initialization) Removed.
3317 (close_active_file) Only call make_source if non-null, otherwise
3318 set vfm_source to null pointer. Don't free temp_case.
3319 (disk_source_read) Add struct ccase * parameter, use instead of
3321 (memory_source_read) Ditto.
3322 (lag_case) Add const struct ccase * member.
3323 (procedure_write_case) Use trns_case instead of temp_case.
3324 (clear_case) Add struct ccase * member, use instead of temp_case.
3325 (exclude_this_case) Ditto.
3326 (create_case_source) Add struct dictionary * parameter, use to
3327 initialize source->value_cnt.
3329 * vfm.h: (struct case_source) Add `value_cnt' member.
3330 (struct case_source_class) Add struct ccase * parameter to `read'
3331 member function pointer.
3332 (struct case_sink_class) Make struct ccase * parameter const in
3333 `write' member function pointer.
3335 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3337 Fix a lot of "possibly uninitialized variable" warnings. Some of
3338 them are even real bugs. A few of them make me wonder how the
3341 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3343 * ascii.c: (output_lines) Add default case to switch.
3345 * crosstabs.q: Remove static variable `expected' and all
3347 (display_crosstabulation) Always calculate expected value.
3349 (output_pivot_table) Initialize `cmp'.
3350 (display_crosstabulation) New variable `last_row', which is
3353 * data-in.c: (parse_numeric) Always initialize sign. How did this
3356 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3357 Always set info.ofs. (How did this work?!)
3359 * expr-opt.c: (optimize_tree) Always initialize `m'.
3360 (evaluate_tree) Always initialize `c'. (How did this work?)
3362 * frequencies.q: (frq_custom_variables) Always initialize min,
3364 (frq_custom_grouped) Always initialize `dl'.
3366 * groff-font.c: (groff_read_font) Always initialize char_set.
3368 * matrix-data.c: (nr_output_data) Initialize `split'.
3369 (wr_read_splits) Remove shadowing split_cnt declaration.
3370 (wr_output_data) Initialize `split'.
3372 * output.c: (tokener) Skip add character on syntax error.
3374 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3376 * postscript.c: (read_ps_encodings) Use line.string instead of
3378 (write_text) Add default case to switch.
3379 (text) Always initialize multiple variables. Fix bug with
3382 * print.c: (fixed_parse_fortran) Initialize head.
3383 (alloc_line) Add default case to switch.
3385 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3386 (recode_trns_proc) Move variable declaration inward. Add default
3389 * sfm-read.c: (read_header) Initialize skip_amt.
3391 * sysfile-info.c: (display_variables) Always initialize pc.
3393 * vars-prs.c: Initialized `included'.
3395 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3397 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3398 Just use signal() instead.
3400 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3402 Get rid of vfm_sink_info and vfm_source_info.
3404 * aggregate.c: (agr_00x_end_func) Don't increment
3405 sfm_sink_info.ncases.
3407 * sort.c: (do_internal_sort) Get case count from
3408 vfm_source->class->count().
3409 (struct external_sort) Add `case_size' member.
3410 (do_external_sort) Initialize case_size.
3411 (struct initial_run_state) Add `case_size' member.
3412 (write_initial_runs) Initialize case_size.
3413 (sort_sink_write) Use case_size.
3414 (read_external_sort_output) Use case_size. Get case_cnt from
3417 * vfm.c: (struct write_case_data) Add underscores to existing arg
3418 names, all references updated. Renamed `aux' as `func_aux', all
3419 references updated. Added new `aux' member.
3420 (global var vfm_source_info) Removed.
3421 (global var vfm_sink_info) Removed.
3422 (struct procedure_aux_data) New.
3423 (struct split_aux_data) New.
3424 (procedure) Use `aux' fields for procedure_aux_data,
3426 (process_active_file_write_case) Pass case_count + 1 to
3427 transformation procedures, exclude_this_case().
3428 (process_active_file_output_case) Don't increment
3429 vfm_sink_info.ncases.
3430 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3431 to send data to disk early.
3432 (make_temp_case) Don't use vfm_sink_info.case_size.
3433 (close_active_file) Don't initialize vfm_source_info.
3434 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3435 (disk_sink_create) Initialize and/or update disk_stream_info.
3436 (disk_sink_write) Ditto.
3437 (disk_sink_destroy) Ditto.
3438 (disk_sink_make_source) Ditto.
3439 (disk_source_read) Ditto.
3440 (disk_source_destroy) Ditto.
3441 (global var disk_source_class) Add disk_source_count().
3442 (disk_source_count) New function.
3443 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3444 (struct memory_source_info) Ditto.
3445 (memory_sink_create) Deal with case_cnt, case_size.
3446 (memory_sink_write) Ditto.
3447 (memory_sink_make_source) Ditto.
3448 (memory_source_read) Ditto.
3449 (memory_source_count) New function.
3450 (memory_source_class) Add memory_source_count().
3451 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3452 proc_aux->cases_written, and pass it to transformation procedures
3453 and exclude_this_case ().
3454 (exclude_this_case) Add case_num parameter. Pass it to
3456 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3459 * vfm.h: (struct case_source_class) Add `count' member.
3461 * vfmP.h: (struct stream_info) Removed.
3462 (global variable vfm_source_info) Removed.
3463 (global variable vfm_sink_info) Removed.
3465 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3467 * var.h: (typedef trns_proc_func) New typedef.
3468 (trns_free_func) New typedef.
3469 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3470 to type trns_free_func. This only changes the actual type of
3471 trns_proc_func, adding a `case_num' parameter. Updated all
3472 implementations to use the typedefs instead.
3474 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3475 (compute_num_vec) Ditto.
3476 (compute_str) Ditto.
3477 (compute_str_vec) Ditto.
3479 * do-if.c: (do_if_trns_proc) Ditto.
3481 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3484 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3485 pass to transformation functions.
3486 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3488 * loop.c: (loop_1_trns_proc) Ditto.
3489 (loop_2_trns_proc) Ditto.
3490 (loop_3_trns_proc) Ditto.
3492 * print.c: (print_space_trns_proc) Ditto.
3494 * sel-if.c: (select_if_proc) Ditto.
3496 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3498 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3499 destroying hash table.
3501 * glob.c: (read_active_file) Variable not referenced, removed.
3502 (cancel_input_pgm) Ditto.
3504 * levene.c: Add #include <stdlib.h> needed to call free().
3506 * aggregate.c: (parse_aggregate_functions) Make `function'
3509 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3511 Start working to eliminate VFM dependence on static variables.
3513 * command.c: (cmd_parse) Use case_source_is_class().
3515 * data-list.c: Rewrite to eliminate use of static variables.
3517 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3519 * file-handle.q: (fh_handle_name) Make parameter const.
3521 * file-type.c: Rewrite to eliminate use of static variables.
3523 * flip.c: Rewrite to eliminate use of static variables.
3525 * format.c: (get_format_var_width) New function.
3527 * get.c: Eliminate use of static variables.
3529 * inpt-pgm.c: Eliminate use of static variables.
3531 * matrix-data.c: Eliminate use of static variables.
3533 * set.q: (set_max_workspace) New variable.
3534 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3536 * var.h: (struct case_list) Move here from vfmP.h.
3538 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3540 * vfm.c: (vfm_source) Change type from struct case_stream to
3542 (vfm_sink) Change type from struct case_stream to struct
3544 (static var paging) Rename workspace_overflow, all references
3546 (procedure) Use new class structures.
3547 (process_active_file) Ditto.
3548 (process_active_file_write_case) Ditto.
3549 (prepare_for_writing) Use set_max_workspace. Use new class
3551 (close_active_file) Use new class structures. Free old sink.
3552 (global var disk_source_file) Removed.
3553 (global var disk_sink_file) Removed.
3554 (disk_stream_init) Removed.
3555 (disk_stream_read) Removed.
3556 (disk_stream_write) Removed.
3557 (disk_stream_mode) Removed.
3558 (disk_stream_destroy_source) Removed.
3559 (disk_stream_destroy_sink) Removed.
3560 (global var vfm_disk_stream) Removed.
3561 (disk_sink_create) New function.
3562 (disk_sink_write) New function.
3563 (disk_sink_destroy) New function.
3564 (disk_sink_make_source) New function.
3565 (disk_sink_class) New static var.
3566 (disk_source_read) New function.
3567 (disk_source_destroy) New function.
3568 (global var vfm_source_class) New var.
3569 (global var memory_source_cases) Removed.
3570 (global var memory_sink_cases) Removed.
3571 (global var memory_sink_max_cases) Removed.
3572 (struct memory_sink_info) New struct.
3573 (memory_stream_init) Removed.
3574 (memory_stream_read) Removed.
3575 (memory_stream_write) Removed.
3576 (memory_stream_mode) Removed.
3577 (memory_stream_destroy_source) Removed.
3578 (memory_stream_destroy_sink) Removed.
3579 (global var vfm_memory_stream) Removed.
3580 (page_to_disk) Renamed write_active_file_to_disk().
3581 (memory_sink_create) New function.
3582 (memory_sink_write) New function.
3583 (memory_sink_destroy) New function.
3584 (memory_sink_make_source) New function.
3585 (memory_sink_class) New static var.
3586 (memory_source_read) New function.
3587 (memory_source_destroy) New function.
3588 (memory_source_get_cases) New function.
3589 (memory_source_set_cases) New function.
3590 (global var vfm_source_class) New var.
3591 (procedure_write_case) Use new class structures.
3592 (create_case_source) New function.
3593 (case_source_is_complex) New function.
3594 (case_source_is_class) New function.
3595 (create_case_sink) New function.
3597 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3598 (global variable reinit_blanks) Not used, removed.
3599 (global variable init_zero) Not used, removed.
3600 (global variable init_blanks) Not used, removed.
3601 (struct case_source) New struct.
3602 (struct case_source_class) New struct.
3603 (struct case_sink) New struct.
3604 (struct case_sink_class) New struct.
3605 (struct case_stream) Removed.
3607 * vfmP.h: (struct case_list) Moved to var.h.
3609 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3611 * algorithm.c: (count_equal) New function.
3612 (count_if) New function.
3613 (unique) Add assertions.
3614 (partition) Add assertions.
3615 (is_partitioned) New function.
3616 (copy_if) Add assertions.
3617 (remove_equal) Add assertions.
3618 (lexicographical_compare) Rename lexicographical_compare_3way.
3619 (sort) Add assertions. Rephrase some code.
3620 (is_sorted) New function.
3622 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3626 * sort.c: Completely rewrite.
3628 * sort.h: Expose interface via struct sort_cases_pgm, not via
3631 * aggregate.c: (sort) New static var.
3632 (cmd_aggregate) Use sort.
3633 (create_sysfile) Ditto.
3634 (aggregate_single_case) Ditto.
3635 (dump_aggregate_info) Ditto.
3636 (agr_00x_end_func) Ditto.
3637 (debug_print) Ditto.
3639 * var.h: (enum SRT_ASCEND) Removed.
3640 (enum SRT_DESCEND) Removed.
3641 (struct sort_cases_proc) Removed.
3642 (struct variable) Remove p.srt member.
3644 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3646 Get rid of the old, crappy heap structure and replace it by a new,
3647 shiny, C++ STL-like heap structure.
3649 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3651 * algorithm.c: (push_heap) New function.
3662 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3664 Increase warning level.
3666 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3668 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3670 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3672 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3674 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3675 around by previous change log entry.
3677 * compute.c: (lvalue_finalize) Remove workaround from previous
3680 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3682 * compute.c: Fixed a bug where the Format was not getting set for
3683 computed variables (thus causing a crash when SAVEing).
3685 * Added a test to stop this bug ever coming back
3687 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3689 Got rid of approx.h. In general, replaced all references to
3690 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3693 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3695 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3696 test for mag < EPSILON.
3698 * misc.h: Add definition of EPSILON.
3700 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3702 * vfm.c: (procedure) Add check to prevent recursive call.
3704 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3706 * Moved the declarations relating to values to their own header file
3709 * Added levene.c and levene.h
3711 * vars-atr.c: Changed the signature of compare_values to
3712 take const * arguments.
3714 * t-test.q: Changed the structure of struct t_test_proc
3715 variables now contain their own group statistics information.
3716 Eventually, t_test_proc might get renamed, because it'd be
3717 applicable to other commands too.
3719 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3721 * data-out.c: Clean up. Changed interface of convert_*() to take
3722 either a `double' or a `const char *' instead of a `const union
3723 value *'. Update all implementations of those interfaces.
3724 (data_out) Use switch statements instead of a table.
3725 (convert_AHEX) Rewrite.
3727 * format.h: Update comment.
3729 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3731 * q2c.c: (dump_header) Add an Emacs header line to output files
3732 that makes generated .c files read-only by default, to make it
3733 difficult to accidentally change generated files.
3735 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3737 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3738 not bogus a->v.c <=> b->v.c pointer compare.
3739 (compare_freq_alpha_a) Ditto.
3740 (compare_freq_numeric_d) Ditto.
3741 (compare_freq_alpha_d) Ditto.
3743 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3745 Changed data_out() to store string data directly into a `union
3746 value''s s member, not indirectly into c.
3748 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3750 (table_value_missing) Ditto.
3751 (float_M_suffix) Ditto.
3752 (format_short) New function.
3754 * data-in.h: (data_in_finite_line) Remove inline definition.
3756 * data-list.c: (destroy_dls_var_spec) New function.
3757 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3758 (data_list_source_destroy_source) Avoid cast.
3759 (struct repeating_data_trns) New field `id_value'. Update
3761 (cmd_repeating_data) Initialize id_value. Use new
3762 repeating_data_trns_free() for freeing REPEATING DATA
3764 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3765 (repeating_data_trns_free) New function.
3767 * data-out.c: (data_out) Change return type to `void' by replacing
3768 error returns by writing a message into the output buffer.
3769 (convert_A) Read from v->s instead of v->c.
3770 (convert_AHEX) Ditto.
3772 * expr-evl.c: Update comment.
3773 (expr_evaluate) Add assertion in OP_STRING case.
3775 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3777 * list.q: (list_cases) Update for new data_out() semantics.
3779 * print.c: (print_trns_proc) Ditto.
3781 * tab.c: (tab_value) Ditto.
3782 (tab_float) Avoid stupid cast.
3784 * var.h: Update comments.
3785 (macro MAX_STRING) New macro.
3786 (macro MAX_ELEMS_PER_VALUE) New macro.
3788 * vars-atr.c: (compare_values) New function.
3790 * vfm.c: (dump_splits) Update for new data_out() semantics.
3792 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3794 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3796 (struct crosstab) Rename v[] to vars[]. All references updated.
3797 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3798 same time, which caused the hash value to depend only on a single
3799 value, not all of the variables' values.
3801 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3803 Clean up struct dictionary's value_cnt usage.
3805 * dictionary.c: Add a function comment to each function.
3806 (struct dictionary) Rename value_cnt to next_value_idx, which more
3807 accurately reflects its meaning. All references updated.
3808 (dict_rename_vars) Add assertion.
3809 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3811 (dict_get_case_size) New function.
3813 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3815 * get.c: (mtf_read_nonactive_records) Ditto.
3817 * sort.c: (allocate_cases) Ditto.
3818 (write_initial_runs) Ditto.
3822 * vfm.c: (prepare_for_writing) Ditto.
3826 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
3828 Make vfm.c slightly less grotesque.
3830 * vfm.c: (filter_var) Removed.
3831 (filter_index) Removed.
3832 (FILTERED macro) Removed.
3833 (exclude_this_case) New function.
3834 (process_active_file_write_case) Use exclude_this_case() instead
3835 of FILTERED and inline tests.
3836 (procedure_write_case) Ditto.
3837 (setup_filter) Removed.
3838 (open_active_file) Don't call setup_filter().
3839 (close_active_file) Call dict_get_filter() instead of checking
3842 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
3844 * var.h: (struct variable) Update comments.
3846 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
3848 New functions dict_create_var_assert(), dict_lookup_var_assert().
3849 Converted several dict_*_var()/assert pairs into a single
3850 dict_*_var_assert().
3852 * dictionary.c: (dict_create_var_assert) New function.
3853 (dict_lookup_var_assert) New function.
3855 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
3857 Got rid of "struct long_vec", envector(), devector(), etc. Added
3858 two members `init', `reinit' to struct variable as a substitute.
3860 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
3866 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
3869 * autorecode.c: (cmd_autorecode) destvars don't need init.
3871 * compute.c: (lvalue_finalize) Set reinit.
3873 * data-list.c: (fixed_parse_compatible) Don't need init usually.
3874 (dump_fmt_list) Ditto.
3877 * descript.q: (run_z_pass) Don't need init for z-scores.
3879 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
3881 (dict_clone_var) Copy `reinit' member, initialize `init' member.
3883 * glob.c: (init_glob) Remove vec_init() calls.
3885 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
3887 * loop.c: (internal_cmd_loop) Don't need to call envector().
3889 * numeric.c: (cmd_numeric) Ditto.
3891 (cmd_leave) Ditto. Set `init', `reinit' members.
3893 * recode.c: (cmd_recode) Don't need to call envector().
3895 * repeat.c: (internal_cmd_do_repeat) Ditto.
3897 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
3898 (force_create_variable) Removed prototype.
3899 (force_dup_variable) Ditto.
3901 * vector.c: (cmd_vector) Don't need to call envector().
3903 * vfm.c: (reinit_sysmis) Removed.
3904 (reinit_blanks) Removed.
3905 (init_zero) Removed.
3906 (init_blanks) Removed.
3907 (process_active_file_write_case) No need to deal with vectors.
3908 Call clear_temp_case().
3909 (vector_initialization) Rewrite to use `init', `reinit'.
3910 (close_active_file) No need to call vec_clear().
3911 (procedure_write_case) Call clear_temp_case().
3912 (clear_temp_case) New function.
3914 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
3916 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
3919 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
3921 Add auxiliary argument to procedure() interface. Associated small
3922 clean-ups of vfm interface.
3924 * Updated every caller of procedure() and process_active_file() to
3925 reflect modified interface. Simple, ordinary changes not listed
3928 * Updated every function that implements struct case_stream's
3929 `read' function to take a write_case_func and a write_case_data.
3930 Also updated every caller of write_case() to instead call them
3931 through these arguments. In some cases this meant that the extra
3932 args had to be threaded through a couple of extra levels. This
3933 wasn't difficult or interesting so the details won't be given.
3935 * data-list.c: (struct repeating_data_trns) Add members
3936 `write_case', `wc_data' as kluge.
3937 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
3939 (repeating_data_set_write_case) New function.
3941 * data-list.h: New file to declare repeating_data_trns_proc() and
3942 repeating_data_set_write_case().
3944 * inpt-pgm.c: (input_program_source_read) Call
3945 repeating_data_set_write_case() for all the REPEATING DATA
3946 transformations, so that they know where to send their cases.
3947 It's a big kluge. Also kluge in END CASE.
3948 (end_case_trns_proc) Never called anymore, but we still need it,
3951 * sort.c: (read_sort_output) Update to match struct case_stream
3954 * vfm.c: (struct write_case_data) New structure.
3955 (proc_func) Removed.
3956 (virt_proc_func) Removed.
3957 (begin_func) Removed.
3958 (virt_begin_func) Removed.
3960 (write_case) Removed.
3961 (procedure) Added an auxiliary parameter to each function pointer
3962 argument's prototype. Added an auxiliary data parameter.
3964 (process_active_file) Ditto.
3965 (process_active_file_write_case) Pass aux data along.
3966 (close_active_file) Ditto.
3967 (procedure_write_case) Ditto.
3968 (SPLIT_FILE_procfunc) Ditto.
3970 * vfm.h: (typedef write_case_data) New.
3971 (typedef write_case_func) New.
3972 (struct case_stream) Add parameters to `read' member prototype.
3974 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
3976 * t-test.q: Added calculations for independent samples. (But no Levene
3979 * Makefile.am: Moved q_sources_c into own variable
3981 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
3983 Miscellaneous cleanups.
3985 * Change unused to UNUSED in many source files to reflect modified
3986 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
3987 __CYGWIN32__, __unix__, and unix not to assume that they're
3988 defined to a nonzero value. Change use of __attribute__ to use
3989 NO_RETURN or PRINTF_FORMAT instead.
3991 * alloc.h: Move definitions for local_alloc(), local_free() here
3992 from ../pref.h.orig and simplify.
3994 * expr-evl.c: Instead of working differently based on PAGED_STACK,
3995 use a pool allocator unconditionally.
3996 (CHECK_STRING_SPACE) Removed.
3997 (ALLOC_STRING_SPACE) Removed.
3998 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4001 * expr-opt.c: (dump_expression) Allocate string pool.
4003 * expr-prs.c: (expr_free) Free string pool.
4005 * pool.c: (pool_destroy) This pool must be removed from its
4006 parent's list of gizmos, not from its own. Use free_all_gizmos().
4007 (pool_clear) New function.
4008 (free_all_gizmos) New function.
4009 (pool_alloc) Use space in empty block after this one if any.
4010 (pool_release) Only empty out blocks, don't actually free() them.
4012 * print.c: Get rid of PAGED_STACK special case by always
4013 dynamically allocating line buffers.
4014 (struct print_trns) Always include the `line' member.
4015 (internal_cmd_print) Always initialize the `line' member.
4016 (alloc_line) Always allocate memory for `line'.
4017 (print_trns_proc) Always initialize buf from `line' member.
4018 (print_trns_free) Always free `line' memory.
4020 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4023 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4025 * flip.c: Fixed crash from FLIP when a numeric variable is
4026 specified on NEWNAMES and a large value is used, and a couple of
4027 other minor bugs besides.
4028 (struct varname) Make name a 9-character fixed-size array
4029 instead of a 1-character variable size array.
4030 (make_new_var) Allow digits in variable names.
4031 (flip_stream_write) Limit numeric values to 8 characters and
4032 format system missing and very large and small values more
4035 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4037 * command.c: Fixed test on command return status for the correct
4038 value, which had been causing a crash under certain invalid input.
4040 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4042 * t-test.q: Added calculations for the one sample variant of the T-TEST
4044 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4046 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4047 in joined cells to be rendered outside box boundaries.
4049 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4051 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4052 SET seed=xx has been called.
4054 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4056 * random.c (rng_get_double): Fix always-returning-zero bug in my
4057 preferred way, and at the same time make sure rounding doesn't
4060 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4062 * html.c: (change_attributes) Dead code, removed.
4063 (escape_string) Eliminate code to call change_attributes() that
4064 never actually called it.
4065 (output_tab_table) Get rid of dependence on tab_hit
4066 and struct tab_joined_cell's hit member, which are abominations.
4068 * tab.c: (tab_output_text) Don't call
4069 d->class->text_set_font_by_name if it's a null pointer.
4070 (macro UNROLL_LOOP) Eliminate.
4071 (macro UNROLL_3_LOOPS) Eliminate.
4072 (tabi_render) Rewrite not to use the above macros.
4074 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4076 Start working on a new output driver system, one that doesn't suck
4077 so much, by adding a "device-independent" output driver. The idea
4078 is to write out only a single output stream, then use separate
4079 processes to translate them into whatever formats we want. This
4080 is similar to how "groff" works with its various output drivers
4081 (grops, grotty, grodvi, ...).
4083 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4085 * list.q: (write_all_headers) Stub out devind class.
4087 (determine_layout) Ditto.
4090 * output.c: (outp_init) Add devind class.
4092 * devind.c: New file.
4094 * devind.h: New file.
4096 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4098 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4099 to use the proper string length.
4101 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4103 * Fixed bug where FREQ would crash on alpha values
4105 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4107 * Removed bletcherous alloca() workarounds for AIX from top of
4108 many files. AIX can use the alternative alloca() implementation
4111 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4113 * ascii.c: (ascii_option) Fix implementation of headers option.
4115 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4117 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4118 multiple blank lines into one.
4119 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4120 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4121 (static var option_tab) Add squeeze entry.
4122 (ascii_option) Set squeeze_blank_lines.
4123 (output_lines) Implement squeezing blank lines.
4125 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4127 * Removed redundant code from output.h
4129 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4131 Dictionary classes: each variable is "ordinary", "system", or
4134 * var.h: (enum dict_class) New enum.
4136 * vars-prs.c: (dict_class_from_id) New function.
4137 (dict_class_to_name) New function.
4139 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4141 * var.h: (struct freq_tab_set) Removed (not used).
4143 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4145 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4147 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4149 * stats.c: (hypercube) Rename pow4(). All references updated.
4151 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4153 * rename-vars.c: (cmd_rename_variables) Rewritten.
4154 (compare_name) Removed.
4156 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4158 var_set feature, and code taking advantage of it.
4160 * crosstabs.q: (static var var_dict) Removed.
4161 (static var variables) New variable.
4162 (static var variables_cnt) New variable.
4163 (cmd_crosstabs) Free variables instead of var_dict.
4164 (internal_cmd_crosstabs) Initialize and use variables,
4165 variables_cnt instead of var_dict.
4166 (free_var_dict) Removed.
4167 (crs_custom_tables) Use var_set instead of a copied dictionary.
4168 (crs_custom_variables) Set up variables, variables_cnt instead of
4170 [DEBUGGING] (debug_print) Ditto.
4172 * means.q: (mns_custom_tables) Use var_set instead of a copied
4175 * vars-prs.c: (parse_vs_variable) New function.
4176 (parse_dict_variable) Rewritten.
4177 (parse_variable) Rewritten.
4178 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4179 (parse_variables) New function in terms of parse_var_set_vars().
4180 Now requires its first argument to be non-null. All references
4181 that passed a null pointer updated to pass default_dict instead.
4182 (macro id_dict) Removed.
4183 (parse_DATA_LIST_vars) Add assertions.
4184 (parse_mixed_vars) Ditto.
4185 (struct var_set) New structure.
4186 (var_set_get_cnt) New function.
4187 (var_set_get_var) New function.
4188 (var_set_lookup_var) New function.
4189 (var_set_destroy) New function.
4190 (dict_var_set_get_cnt) New function.
4191 (dict_var_set_get_var) New function.
4192 (dict_var_set_lookup_var) New function.
4193 (dict_var_set_destroy) New function.
4194 (var_set_create_from_dict) New function.
4195 (struct array_var_set) New structure.
4196 (array_var_set_get_cnt) New function.
4197 (array_var_set_get_var) New function.
4198 (array_var_set_lookup_var) New function.
4199 (array_var_set_destroy) New function.
4200 (var_set_create_from_array) New function.
4202 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4203 instead of parse_variables(NULL, ...) in output code.
4205 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4207 Change inp_init from a 2-bit vector to an ordinary array.
4208 Initialize it all in cmd_end_input_program() instead of in
4211 * inpt-pgm.c: (enum value_init_type) New enum.
4212 (global var inp_init) Change to `enum value_init_type *', make
4214 (inp_init_size) Removed.
4215 (inp_nval) Change to `size_t', make static.
4216 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4217 (cmd_end_input_program) Initialize inp_init, inp_nval.
4218 (init_case) Rewrite.
4219 (clear_case) Rewrite.
4221 * inpt-pgm.h: Removed.
4223 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4225 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4226 Colin Plumb hash. It is simpler and should better resist
4228 (hsh_hash_string) Ditto.
4230 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4232 * get.c: (export_write_case_func) Remove debug printing code.
4234 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4236 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4238 (save_write_case_func) Use &trns->h instead of cast.
4239 (cmd_export) Use &t->h instead of cast.
4241 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4243 Moved vectors into the dictionary.
4245 * var.h: (struct vector) Moved here from vector.h. `index' member
4246 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4249 * vector.h: Removed.
4251 * vector.c: (global var vec) Removed.
4252 (global var nvec) Removed.
4253 (cmd_vector) Rewritten.
4254 (find_vector) Removed.
4256 * dictionary.c: (dict_create_vector) New function.
4257 (dict_get_vector) New function, replaces reading global vec[]
4259 (dict_get_vector_cnt) New function, replaces reading global nvec
4261 (dict_lookup_vector) New function, replaces find_vector().
4262 (dict_clear_vectors) New function.
4264 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4266 Start to move away from `struct variable' p `union' member to void
4269 * var.h: (struct variable) Add `aux' member.
4271 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4273 Get rid of struct variable `foo' member.
4275 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4277 (frq_custom_variables) Ditto.
4278 (frq_custom_grouped) Ditto.
4280 * get.c: (struct save_trns) Change `var' member from `int *' to
4281 `struct variable **'.
4282 (cmd_save_internal) Use aux instead of foo.
4283 (save_trns_proc) Use revised `var' member.
4284 (static var mtf_seq_no) Renamed mtf_seq_num.
4285 (static var mtf_seq_nums) New static var.
4286 (cmd_match_files) Initialize mtf_seq_nums.
4287 (mtf_free) Free mtf_seq_nums.
4288 (mtf_processing) Use mtf_seq_nums instead of foo.
4289 (mtf_merge_dictionary) No need to initialize mv->foo.
4290 (cmd_export) Use aux instead of foo. Use revised `var' member.
4291 (mns_custom_tables) Don't use foo to check for duplicates, that's
4292 what PV_NO_DUPLICATE is for.
4294 * var.h: (struct variable) Remove `foo' member.
4295 (struct frequencies_proc) New member.
4297 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4299 Clean up COMPUTE and IF.
4301 * compute.c: More or less rewrite the darn thing.
4302 (struct compute_trns) Rename and reorder and add and delete
4304 (cmd_compute) Rewrite.
4305 (compute_num) Make conditional on test expression. Now used for
4306 both COMPUTE and IF.
4307 (compute_num_vec) Ditto.
4308 (compute_str) Ditto.
4309 (compute_str_vec) Ditto.
4312 (if_num_vec) Removed.
4314 (if_str_vec) Removed.
4315 (parse_target_expression) Renamed parse_rvalue_expression(),
4317 (new_trns) Renamed compute_trns_create(), rewritten.
4318 (delete_trns) Removed.
4319 (free_trns) Renamed compute_trns_free(), rewritten.
4320 (struct lvalue) New structure.
4321 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4322 (lvalue_get_type) New function.
4323 (lvalue_is_vector) New function.
4324 (lvalue_finalize) New function.
4325 (lvalue_destroy) New function.
4327 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4329 * command.def: Disallow MODIFY VARS in input mode, so that
4330 variables can't get dropped and confuse cmd_end_input_program()'s
4331 attempt to fill inp_init[].
4333 * modify-vars.c: (static var forward_positional_ordering) New
4335 (struct var_modification) Entirely changed.
4336 (rearrange_dict) Interface changed, rewritten.
4337 (cmd_modify_vars) Deal with modified struct var_modification, much
4339 (struct var_renaming) New structure.
4340 (compare_var_renaming_by_new_name) New function.
4341 (validate_var_modification) New function.
4343 * var.h: (struct modify_vars_proc) Removed.
4344 (struct variable) Removed member p.mfv.
4346 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4348 Make EVALUATE a valid command whether we're debugging or not, so
4349 that `make check' can succeed regardless of whether debugging is
4352 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4354 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4356 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4358 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4359 statement by a simple if test.
4361 * dfm.c: (dfm_get_record) Add assertion.
4363 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4365 For each file x.c, move #include "x.h" to the very top of the
4366 include list, to catch x.h failing to include the proper headers.
4368 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4370 * algorithm.c: (find) New function.
4371 (remove_equal) New function.
4372 (set_difference) New function.
4373 (adjacent_find_equal) New function.
4374 [TEST_UNIQUE] Removed test case.
4375 (copy_if) Find end test.
4377 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4379 * dictionary.c: (dict_get_case_weight) New convenience function.
4381 * aggregate.c: (accumulate_aggregate_info) Use
4382 dict_get_case_weight().
4384 * frequencies.q: (calc_general) Ditto.
4385 (calc_integer) Ditto.
4388 * t-test.q: (groups_calc) Ditto.
4391 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4393 * glob.c: (global var default_dict) Change from `struct
4394 dictionary' to `struct dictionary *'. All references changed.
4395 (init_glob) Initialize default_dict with dict_create().
4397 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4399 struct dictionary now made opaque. All related functions:
4401 * get.c: (rename_variables) Removed.
4402 (dict_delete_run) Removed.
4404 * temporary.c: (copy_variable) Removed.
4405 (new_dictionary) Removed.
4406 (save_dictionary) Removed.
4407 (restore_dictionary) Removed.
4408 (free_dictionary) Removed.
4410 * vars-atr.c: (clear_default_dict) Removed.
4411 (find_variable) Removed.
4412 (find_dict_variable) Removed.
4413 (create_variable) Removed.
4414 (delete_variable) Removed.
4415 (common_init_stuff) Removed.
4416 (init_variable) Removed. Updating of inp_init moved into
4417 cmd_end_input_program().
4418 (replace_variable) Removed.
4419 (rename_variable) Removed.
4420 (clear_variable) Removed.
4421 (dup_variable) Removed.
4423 * vars-prs.c: (is_varname) Removed.
4424 (is_dict_varname) Removed.
4425 (fill_all_vars) Removed.
4427 * vector.c: (find_vector) Removed.
4429 * weight.c: (stop_weighting) Removed.
4431 * dictionary.c: New file.
4432 (dict_create) New, replaces new_dictionary().
4433 (dict_clone) New, replaces save_dictionary() and
4434 restore_dictionary().
4435 (dict_clear) New, replaces clear_default_dict().
4436 (dict_destroy) New, replaces free_dictionary().
4437 (dict_get_var_cnt) New function, replaces references to
4439 (dict_get_var) New function, replaces references to dict->var[i].
4440 (dict_get_vars) New function, replaces fill_all_vars().
4441 (dict_create_var) New, replaces create_variable(). Interface
4442 drops `type' parameter, using a zero `width' to designate numeric.
4443 (dict_clone_var) New, replaces dup_variable().
4444 (dict_rename_var) New, replaces rename_variable().
4445 (dict_lookup_var) New, replaces find_variable(),
4446 find_dict_variable(), is_varname().
4447 (dict_contains_var) New function.
4448 (compare_variable_dblptrs) New function.
4449 (dict_delete_var) New function, replaces clear_variable().
4450 (dict_delete_vars) New function, replaces dict_delete_run().
4451 (dict_reorder_vars) New function.
4452 (dict_rename_vars) New function, replaces rename_variables().
4453 (dict_get_weight) New function, replaces reading dict->weight_var.
4454 (dict_set_weight) New function, replaces writing dict->weight_var
4455 or calling stop_weight(dict).
4456 (dict_get_filter) New function, replaces reading dict->filter_var.
4457 (dict_set_filter) New function, replaces writing dict->filter_var.
4458 (dict_get_case_limit) New function, replaces reading dict->N.
4459 (dict_set_case_limit) New function, replaces writing dict->N.
4460 (dict_get_value_cnt) New function, replaces reading dict->nval.
4461 (dict_compact_values) New function, replaces a loop that was
4462 replicated in several places.
4463 (dict_get_split_vars) New function, replaces reading dict->splits.
4464 (dict_get_split_cnt) New function, replaces reading
4466 (dict_set_split_vars) New function, replaces writing dict->splits.
4467 (dict_get_label) New function, replaces reading dict->label.
4468 (dict_set_label) New function, replaces writing dict->label.
4469 (dict_get_documents) New function, replaces reading
4471 (dict_set_documents) New function, replaces writing
4474 All references to above functions updated.
4476 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4477 old dictionary to new by hand, because dict_create() can't do it
4478 itself. Use dict_set_documents(), dict_set_split_vars().
4480 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4481 calling dict_destroy().
4483 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4485 (fixed_parse_compatible) Some slightly nontrivial changes for
4487 (dump_fmt_list) Ditto.
4490 * file-type.c: (create_col_var) Ditto.
4492 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4493 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4494 (rename_variables) Use dict_rename_vars().
4495 (mtf_merge_dictionary) Use dict_get_documents(),
4496 dict_set_documents(), dict_compact_values().
4498 * pfm-read.c: (read_variables) Deal with changes to weighting.
4500 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4501 is_varname() in output code.
4503 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4504 other dictionary functions.
4506 * title.c: (add_document_line) Use dict_get_documents(),
4507 dict_set_documents().
4509 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4510 reset default_handle by hand. dict_clear() will clear vectors so
4511 there's no need for that by hand.
4513 * vfm.c: (close_active_file) Move call to finish_compaction()
4514 earlier, so that we can do the compaction as a single step using
4515 dict_compact_values(). Use dict_clear_vectors().
4516 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4518 Some functions don't have replacements:
4520 * vars-atr.c: (force_create_variable) Removed. All references
4521 updated to dict_create_var() followed by an assertion.
4522 (force_dup_variable) Removed. All references updated to
4523 dict_clone_var() followed by an assertion.
4525 * weight.c: (update_weighting) Removed. No longer necessary, so
4526 all references removed.
4528 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4532 * aggregate.c: Eliminate separation of weighted and unweighted
4533 case. It made the code too obscure and I doubt it was actually
4534 faster. Instead, all code uses the "weighted" code, because
4535 that's a generalization of the "unweighted" code.
4538 (parse_aggregate_functions) No need to set FWEIGHT.
4539 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4540 (dump_aggregate_info) Ditto.
4541 (initialize_aggregate_info) No need for special plain_function
4542 that gets rid of FWEIGHT option.
4544 * aggregate.c: Get rid of approximations.
4545 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4547 (aggregate_single_case) Don't use approx_ne().
4549 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4551 * ascii.c (ascii_line_width): Dead code, removed.
4553 * postscript.c (ps_line_width): Ditto.
4555 * q2c.c (xrealloc): Ditto.
4557 * count.c (internal_cmd_count): Ditto.
4559 * means.q (validate_dependent_endpoint): Ditto.
4561 * set.q: (cmd_gset) Ditto.
4563 * weight.c: [0] (weight_trns_proc) Ditto.
4565 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4567 Make the code -Wmissing-prototypes clean.
4569 * Makefile.am (version.c): Add #include "version.h".
4571 * ascii.c: (ascii_open_global) Make static.
4572 (ascii_close_page) Ditto.
4573 (ascii_font_sizes) Ditto.
4574 (ascii_postopen_driver) Ditto.
4575 (ascii_close_driver) Ditto.
4576 (ascii_option) Ditto.
4577 (ascii_open_page) Ditto.
4578 (ascii_line_horz) Ditto.
4579 (ascii_line_vert) Ditto.
4580 (ascii_line_intersection) Ditto.
4582 (ascii_polyline_begin) Ditto.
4583 (ascii_polyline_point) Ditto.
4584 (ascii_polyline_end) Ditto.
4585 (ascii_text_set_font_by_name) Ditto.
4586 (ascii_text_set_font_by_position) Ditto.
4587 (ascii_text_set_font_by_family) Ditto.
4588 (ascii_text_get_font_name) Ditto.
4589 (ascii_text_get_font_family) Ditto.
4590 (ascii_text_set_size) Ditto.
4591 (ascii_text_get_size) Ditto.
4592 (ascii_text_metrics) Ditto.
4593 (ascii_text_draw) Ditto.
4594 (ascii_close_page) Ditto.
4596 * cmdline.h: New header for parse_command_line(). Used where
4599 * command.c: Move prototypes for cmd_*() functions to command.h.
4601 * command.h: Prototypes for cmd_*() functions moved here from
4604 * crosstabs.q: (gamma_int) Ditto.
4606 * file-handle.h: Add fh_init_files() prototype.
4608 * getline.c: (welcome) Ditto.
4610 * glob.h: New header for init_glob(). Used where appropriate.
4612 * hash.c: (comparison_helper) Ditto.
4614 * html.c: (html_open_global) Ditto.
4615 (html_close_global) Ditto.
4616 (html_preopen_driver) Ditto.
4617 (html_postopen_driver) Ditto.
4618 (html_close_driver) Ditto.
4619 (html_option) Ditto.
4620 (html_open_page) Ditto.
4621 (html_close_page) Ditto.
4622 (html_submit) Ditto.
4624 * inpt-pgm.c: (input_program_source_read) Ditto.
4626 * output.c: (find_defn_value) Ditto.
4627 (destroy_list) Ditto.
4629 * pfm-read.c: (read_int) Ditto.
4631 * postscript.c: (ps_open_global) Ditto.
4632 (ps_close_global) Ditto.
4633 (ps_font_sizes) Ditto.
4634 (ps_preopen_driver) Ditto.
4635 (ps_postopen_driver) Ditto.
4636 (ps_close_driver) Ditto.
4638 (ps_open_page) Ditto.
4639 (ps_close_page) Ditto.
4640 (ps_line_horz) Ditto.
4641 (ps_line_vert) Ditto.
4642 (ps_line_intersection) Ditto.
4644 (ps_polyline_begin) Ditto.
4645 (ps_polyline_point) Ditto.
4646 (ps_polyline_end) Ditto.
4647 (ps_text_set_font_by_name) Ditto.
4648 (ps_text_set_font_by_position) Ditto.
4649 (ps_text_set_font_family) Ditto.
4650 (ps_text_get_font_name) Ditto.
4651 (ps_text_get_font_family) Ditto.
4652 (ps_text_set_size) Ditto.
4653 (ps_text_get_size) Ditto.
4654 (ps_text_metrics) Ditto.
4655 (ps_text_draw) Ditto.
4657 * q2c.c: (finish_up) Ditto.
4666 (find_symbol) Ditto.
4669 (force_string) Ditto.
4671 (match_token) Ditto.
4674 (parse_setting) Ditto.
4675 (parse_specifier) Ditto.
4676 (parse_specifiers) Ditto.
4677 (parse_subcommand) Ditto.
4678 (dump_specifier_vars) Ditto.
4680 (make_identifier) Ditto.
4681 (dump_declarations) Ditto.
4682 (dump_specifier_init) Ditto.
4683 (dump_vars_init) Ditto.
4685 (dump_specifier_parse) Ditto.
4686 (dump_subcommand) Ditto.
4687 (dump_parser) Ditto.
4688 (dump_header) Ditto.
4690 (recognize_directive) Ditto.
4692 * recode.c: (string_to_long) Ditto.
4694 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4696 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4699 * sort.c: (sort_stream_read) Ditto.
4700 (sort_stream_mode) Ditto.
4702 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4704 * algorithm.c (binary_search): Fix comparison.
4706 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4708 * algorithm.c: (binary_search) Fix assertion.
4710 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4712 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4714 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4716 * sort.c: (compare_case_lists) Rewrite.
4718 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4720 * quicksort.c: Removed (not used).
4722 * quicksort.h: Removed (not used).
4724 * sort.c: Removed blp_quicksort() prototype.
4726 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4728 * postscript.c: (int_2_compare) Rewrite.
4729 (compare_line) Rewrite.
4731 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4733 * matrix-data.c (compare_factors) Use lexicographical_compare()
4735 (compare_doubles) New function.
4737 * algorithm.c: (lexicographical_compare) New algorithm.
4739 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4741 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4743 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4745 * expr-prs.c: (cmp_func) Removed.
4746 (parse_function) Use binary_search() algorithm.
4747 (compare_functions) New function.
4748 (init_func_tab) Use sort() algorithm.
4750 * algorithm.c: (binary_search) New algorithm.
4752 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4754 * descript.q: (display) Use sort() algorithm instead of qsort().
4755 (compare_func) Removed.
4756 (descriptives_compare_variables) New function.
4758 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4760 Get rid of AVL trees. Hashes are more appropriate for everything
4763 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4769 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4771 Much code can be clarified by using C++ STL-like algorithms. Not
4772 all uses of these algorithms are listed below, only the ones where
4773 the change to an algorithm was the only change of interest.
4775 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4777 * algorithm.c: New file.
4779 * algorithm.h: New file.
4781 * modify-vars.c: (static var forward) Removed.
4782 (static var positional) Removed.
4783 (compare_variables) Removed.
4784 (struct ordering) New.
4785 (cmd_modify_vars) Use sort() algorithm.
4786 (compare_variables_given_ordering) New function.
4787 (rearrange_dict) Use sort() algorithm.
4789 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4790 (cmp_var_by_name) Removed.
4792 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4794 Make file handles use a hash table.
4796 * file-handle.q: (files) Change to hash table, make static.
4797 (cmd_file_handle) Use hash table functions.
4798 (fh_get_handle_by_filename) Ditto.
4799 (fh_get_handle_by_name) Ditto.
4800 (hash_file_handle) New function.
4801 (cmp_file_handle) Rewrite.
4802 (fh_init_files) Use hash table functions.
4804 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4806 Clean up FREQUENCIES.
4808 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4810 * frequencies.q: Remove a lot of old #if'd out code at the end.
4811 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4812 or calc_weight(). Initialize percentile_values.
4813 (calc) New function based on calc_weight() from frequencies.g.
4814 (precalc) Use hash functions.
4815 (static var comparison_func) Removed.
4816 (static var comparison_param) Removed.
4817 (comparison_helper) Removed.
4818 (get_freq_comparator) New function.
4819 (not_missing) New function.
4821 (postprocess_freq_tab) Use hash table functions, algorithms,
4822 get_freq_comparator(). Rewrite.
4823 (cleanup_freq_tab) Rephrase.
4824 (add_percentile) Clean up spacing.
4825 (hash_value_numeric) New function.
4826 (hash_value_alpha) New function.
4827 (compare_value_numeric_a) Rewrite.
4828 (compare_value_alpha_a) Rewrite.
4829 (compare_value_numeric_d) Rewrite.
4830 (compare_value_alpha_d) Rewrite.
4831 (compare_freq_numeric_a) Rewrite.
4832 (compare_freq_alpha_a) Rewrite.
4833 (compare_freq_numeric_d) Rewrite.
4834 (compare_freq_alpha_d) Rewrite.
4835 (calc_stats) Clean up mode, percentiles, max.
4836 (dump_statistics) Clean up spacing.
4838 * frequencies.g: Removed.
4840 * var.h: (struct freq_tab) Change `data' to hash table.
4842 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
4844 * file-handle.h: Remove declaration of global variable `files',
4845 which wasn't used anywhere.
4847 * postscript.c: (add_encoding) Remove superfluous cast.
4850 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
4853 * temporary.c: [0] (display_tree) Removed.
4855 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
4857 Implement a new random number generator based on the alleged RC4
4860 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
4863 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
4864 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
4866 (static var V[]) Removed.
4867 (static var Y) Removed.
4868 (static var X2) Removed.
4869 (setup_randomize) Removed.
4871 (rand_uniform) Removed.
4872 (rand_normal) Removed.
4873 (struct rng) New structure.
4874 (rng_create) New function.
4875 (rng_destroy) New function.
4876 (swap_byte) New static function.
4877 (rng_seed) New function.
4878 (rng_get_bytes) New function.
4879 (rng_get_int) New function.
4880 (rng_get_unsigned) New function.
4881 (rng_get_double) New function.
4882 (rng_get_double_normal) New function.
4883 (pspp_rng) New function.
4885 * random.h: Sync up to random.c.
4887 * sample.c: (struct sample_trns) Make `frac' unsigned and a
4888 fraction of UINT_MAX, not 65536.
4889 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
4892 * vfm.c: (open_active_file) No need to call setup_randomize() any
4895 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
4897 Change dictionary name indexes to use hash tables instead of AVL
4900 * crosstabs.q: (free_var_dict) Use hash tables.
4901 (crs_custom_tables) Ditto.
4902 (calc_general) Ditto.
4903 (compare_table_entry) Rewrite.
4904 (enum_var_values) Reorder parameters. All references updated.
4907 * get.c: (rename_variable) Use hash tables.
4908 (mtf_merge_dictionary) Ditto.
4910 * glob.c: (init_glob) Use hash tables.
4911 (cmp_variable) Removed.
4913 * means.q: (mns_custom_tables) Use hash tables.
4915 * modify-vars.c: (rearrange_dict) Use hash tables.
4917 * rename-vars.c: (cmd_rename_variables) Use hash tables.
4919 * sfm-read.c: (read_header) Use hash tables.
4920 (read_variables) Ditto.
4922 * temporary.c: (new_dictionary) Use hash tables.
4923 (save_dictionary) Ditto.
4924 (restore_dictionary) Ditto.
4926 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
4927 hash table `name_tab'.
4929 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
4930 [DEBUGGING] (dump_var_tree) Removed.
4931 (find_variable) Use hash tables.
4932 (find_dict_variable) Ditto.
4933 (common_init_stuff) Ditto.
4934 (rename_variable) Ditto.
4935 (clear_variable) Ditto. Also, remove debug code.
4936 (dup_variable) Use hash tables.
4938 * vars-prs.c: (fill_all_vars) Use hash tables.
4939 (is_dict_varname) Ditto.
4940 (parse_dict_variable) Ditto.
4942 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
4944 Change value labels to use hash tables instead of AVL trees, and
4945 change value labels into an ADT.
4947 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
4949 * value-labels.c: New file.
4951 * value-labels.h: New file.
4953 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
4954 Get rid of a stupid use of goto.
4956 * autorecode.c: (compare_alpha_value) Rewrite.
4957 (hash_alpha_value) Ditto.
4958 (compare_numeric_value) Rewrite.
4959 (hash_numeric_value) Ditto.
4961 * frequencies.q: (dump_full) Use value label ADT.
4963 * pfm-read.c: (read_value_label) Use value label ADT.
4965 * pfm-write.c: (write_value_labels) Use value label ADT.
4967 * sfm-read.c: (read_variables) Use value label ADT.
4968 (read_value_labels) Rewrite.
4970 * sfm-write.c: (write_value_labels) Rewrite.
4972 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
4973 (display_variables) Ditto.
4974 (describe_variable) Ditto.
4976 * t-test.q: (print_t_groups) Use value label ADT.
4978 * temporary.c: (copy_variable) Use value label ADT.
4979 (free_dictionary) Ditto.
4981 * val-labs.c: (verify_val_labs) Use value label ADT.
4983 (debug_print) Ditto.
4984 (val_lab_cmp) Removed.
4985 (inc_ref_count) Removed.
4986 (copy_value_labels) Removed.
4988 * var.h: (struct value_label) Removed.
4989 (struct variable) Change AVL tree `val_lab' into hash table
4992 * vars-atr.c: (init_variable) Use value label ADT.
4993 (clear_variable) Ditto.
4994 (free_value_label) Removed.
4995 (free_val_lab) Removed.
4996 (get_val_lab) Removed.
4997 (compare_variables) New function.
4998 (hash_variable) New function.
5000 * vfm.c: (dump_splits) Use value label ADT.
5002 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5004 Add to the hash table interface.
5006 * hash.c: (hsh_hash_bytes) Add assertion.
5007 (hsh_hash_string) Ditto.
5011 (hsh_create) Ditto. Also make minimum `size'.
5012 (hsh_destroy) Rephrase.
5013 (sort_nulls_last) Removed.
5014 (not_null) New function.
5016 (comparison_helper) Ditto.
5017 (hsh_sort) Rewritten.
5018 (hsh_data_copy) New function.
5019 (hsh_sort_copy) Ditto.
5021 (hsh_replace) Ditto.
5022 (hsh_hash_double) Ditto.
5023 (hsh_delete) Fix stupid bug.
5025 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5026 * added a calculation of the mode to FREQUENCIES
5028 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5030 * moved (un)defs of DEBUGGING to config.h
5032 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5034 * groff-font.c: (add_kern) Fix indentation.
5035 (add_kern) Use & instead of % to take power-of-2 modulus.
5036 (font_get_kern_adjust) Likewise.
5038 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5040 * autorecode.c: (recode) Replace stupid use of memcpy() by
5042 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5043 (hash_numeric_value) Ditto.
5044 (autorecode_proc_func) pool_strdup() was wrong here because the
5045 source string was not null-terminated. Use new pool_strndup()
5048 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5049 use of hsh_iterator_init().
5051 * data-in.c: (parse_N) Initialize i->v->f.
5053 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5056 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5057 (groff_read_font) Don't call hsh_next_prime(). Don't call
5059 (static var hash) Remove `size_p', `max_used' members.
5060 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5061 hsh_hash_string() instead of hashpjw(), & instead of %.
5062 (default_font) Don't call hsh_next_prime().
5064 * pool.c: (pool_strndup) New function.
5065 (pool_strdup) Reimplement in terms of pool_strndup.
5067 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5069 (hash_ps_encoding) Use hsh_hash_string().
5070 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5071 (hash_filename2font) Use hsh_hash_string().
5073 * som.c: Add #include <stdlib.h>.
5075 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5076 (by destroying its pool).
5078 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5080 Miscellaneous hash table code cleanup:
5082 * hash.h: (struct hsh_table) Moved into hash.c.
5083 (hsh_count) Ditto, and transformed into function.
5084 (hsh_compare_func) New typedef, used for defining otherwise-long
5085 function types here and in hash.c
5086 (hsh_hash_func) Ditto.
5087 (hsh_free_func) Ditto.
5089 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5090 `table' to `entries'. Removed `mp'. All references updated.
5091 (hsh_clear) Don't shrink entries array; if the hash was this big
5092 once, it probably will be again.
5093 (hsh_rehash) Made static.
5094 (force_hsh_insert) Renamed hsh_force_insert.
5095 (force_hsh_find) Renamed hsh_force_find.
5097 Made hash table sizes powers of 2, because that's fine with any
5098 reasonable hash function and because taking a power-of-2 modulus
5099 is faster than any other:
5101 (hsh_prime_tab) Removed;
5102 (hsh_next_prime) Ditto.
5103 (next_power_of_2) New function.
5104 (hsh_create) Use next_power_of_2.
5105 (hsh_rehash) Use & instead of %.
5107 Cleaned up hsh_sort:
5109 (internal_comparison_fn) Removed.
5110 (sort_nulls_last) New function.
5111 (hsh_sort) Removed second parameter, switched to using the new
5112 quicksort() function from quicksort.h to avoid using nasty need
5113 for static variables with qsort(). All references updated.
5115 Changed the hash functions offered, because there are better hash
5116 functions than the ones we had, and cleaned up the names to boot:
5118 * hash.c: (hashpjw_d) Removed.
5120 (hsh_hash_bytes) New function.
5121 (hsh_hash_string) New function.
5122 (hsh_hash_int) New function.
5124 Improved the hash table iteration interface:
5126 * hash.h: (hsh_iterator_init) Removed.
5127 (struct hsh_iterator) Removed `init' member, change `next' to
5130 * hash.c: (hsh_foreach) Removed. All references updated to use
5131 hsh_first/hsh_next instead.
5132 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5133 not treat a null pointer as an empty hash table.
5134 (hsh_next) New function.
5136 Made deletion possible, though slow:
5138 * hash.c: (locate_matching_entry) New function.
5139 (hsh_find) Use locate_matching_entry().
5140 (hsh_delete) New function also using locate_matching_entry().
5141 (hsh_force_delete) New function.
5143 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5145 * quicksort.c: New file implementing a sort routine with a
5146 interface better than qsort() because it passes a user-provided
5147 parameter to the sort routine.
5149 * Makefile.am: Add quicksort.c, quicksort.h.
5151 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5153 * All source files: Get rid of nasty special cases for Checker,
5154 which is pretty obsolete now.
5156 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5158 * Fixed a bug apparent when using the FREQUENCIES command with the
5159 html driver. The html driver was incorrectly trying to display
5162 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5164 * Makefile.am: Reorganized. Put locale dir in version.c instead
5165 of passing it to each compile command. Only put local gmp libs in
5166 LD_ADD if not installed on system. Remove `boast' target.
5168 * All source files: struct and union typedefs eliminated.
5169 `sizeof type' replaced by `sizeof object' where practical. Moved
5170 `unused' qualifiers from start to end of declarations for gcc
5171 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5172 assertions on pointers strictly compliant. Removed _ prefixes on
5173 some function parameter names.
5175 * alloc.c: New source file, containing these external linkage
5176 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5183 * ascii.c: Migrated from arenas to pools.
5184 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5185 c_string to len_string. All references changed.
5186 (ascii_option) Signature changed to comply to new output.c
5188 (count_fancy_chars) Removed.
5189 (delineate) Removed support for rich text.
5190 (ascii_text_metrics) Ditto.
5192 (output_shorts) Change `box', `off', `on' from c_string to
5193 len_string. Change `remaining' from int to size_t.
5194 (ascii_close_page) Make page numbering less haphazard.
5196 * autorecode.c: Migrate from arenas to pools.
5198 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5200 * bitvector.h: New file containing these macros from misc.h:
5201 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5203 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5204 word[3]. ncmd removed.
5205 (var empty_string) Removed.
5206 (var cmd_table) Declaration updated.
5207 (var cmdtab) Removed.
5208 (cmp_command) Removed.
5209 (split_words) Rewritten to use strtok_r().
5210 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5211 (find_command) Removed.
5212 (FILE_TYPE_okay) Rewritten.
5213 (cmd_parse) Rewritten. Semantics of the return value of command
5214 handlers has changed: they must now return one of the new CMD_*
5215 enumerals, rather than a magic value. This meant that all
5216 commands had to be modified, and they were.
5217 (figure_out_command) New function.
5219 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5220 #defines for INIT, INPU, etc.
5222 * command.h: New CMD_* enum series.
5223 (cur_proc) Make const char *, not char *.
5224 (cmd_init) Prototype.
5227 * common.c: Removed.
5229 * common.h: Removed.
5231 * correlations.q: New file.
5233 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5235 (custom_tables) Renamed crs_custom_tables().
5236 (custom_variables) Renamed crs_custom_variables().
5237 (calc_integer) Add in some `const' qualifiers.
5238 (table_value_missing) Change from a_string to len_string.
5239 (float_M_suffix) Change from a_string to len_string.
5241 * data-in.c: Rewritten. All references to
5242 parse_string_as_format() changed to data_in().
5244 * data-in.h: New file.
5246 * data-list.c: Change DLS_* from #define's to enums. Move from
5247 rpd_msg() to tmsg().
5248 (RPD_ERR) New #define.
5249 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5251 (read_from_data_list_fixed) Change from old
5252 parse_string_as_format() to new data_in().
5253 (read_from_data_list_free) Ditto.
5254 (read_from_data_list_list) Ditto.
5255 (cmd_repeating_data) Modify approach to checking for end of
5258 (rpd_parse_record) Change from old parse_string_as_format() to new
5259 data_in(). Change from old convert_format_to_string() to new
5261 (read_one_set_of_repetitions) Change dfm_push_cust() to
5262 dfm_push(), pop_cust() to dfm_pop().
5264 * data-out.c: Rewritten. All references to
5265 convert_format_to_string() changed to data_out().
5267 * descript.q: Migrate to new q2c.
5268 (cmd_descriptives) Removed.
5269 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5270 (custom_variables) Renamed dsc_custom_variables().
5272 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5274 (open_file_r) Initialize h->where.line_number. Migrate to new
5276 (open_file_w) Initialize h->where.line_number.
5277 (read_record) Change from ext->ln to h->where.line_number.
5278 Migrate to struct string.
5279 (dfm_put_record) Rephrased.
5280 (dfm_push_cust) Renamed dfm_push(), rewritten.
5281 (dfm_pop) New function.
5283 * error.c: All references updated.
5284 (glob var error_count) Renamed err_err_count.
5285 (glob var warning_count) Renamed err_warning_count.
5286 (glob var error_already_flagged) Renamed err_already_flagged.
5287 (glob var verbosity) Renamed err_verbosity.
5288 (glob var cust_fn) Removed.
5289 (glob var cust_ln) Removed.
5290 (static var file_loc) New.
5291 (static var nfile_loc) New.
5292 (static var mfile_loc) New.
5293 (tmsg) New function.
5294 (push_cust) Removed.
5297 (static var terminating) Removed.
5298 (failure) Renamed err_failure().
5299 (hcf) Renamed err_hcf().
5300 (err_push_file_locator) New function.
5301 (err_pop_file_locator) New function.
5302 (err_location) New function.
5303 (check_error_count) Renamed err_check_count().
5304 (vmsg) Renamed err_vmsg(). Interface changed.
5305 (verbose_msg) Removed.
5306 (err_cond_fail) New function.
5307 (error_break) Renamed err_break().
5309 * error.h: All references updated.
5310 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5311 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5313 (struct file_locator) New.
5315 (macro verbose_msg) Removed.
5316 (macro cond_fail) Removed.
5318 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5320 * expr-prs.c: Reorganized. All references updated.
5321 (exprtypename) Renamed expr_type_name().
5322 (typename) Renamed type_name().
5323 (free_expression) Renamed expr_free().
5324 (parse_expression) Renamed expr_parse(). Uses new type_check()
5326 (init_functab) Renamed init_func_tab().
5327 (type_check) New function.
5328 (parse_or) Rewritten to use new allocate_nonterminal() and
5329 append_nonterminal_arg() functions.
5332 (parse_rel) Ditto. Also simplified logic.
5337 (SYSMIS_func) Ditto.
5338 (VALUE_func) Rephrased.
5339 (CONCAT_func) Fix memory leak by replacing free by free_node on
5341 (generic_str_func) Ditto.
5342 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5344 (allocate_nonterminal) New function.
5345 (append_nonterminal_arg) New function.
5346 (static func_tab[]) Now at file level.
5348 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5350 * expr.h: (enum series OP_*) Moved to exprP.h.
5351 (OP_* defines) Ditto.
5352 (struct op_desc) Ditto.
5353 (global ops[]) Ditto.
5354 (struct num_con_node) Ditto.
5355 (struct str_con_node) Ditto.
5356 (struct var_node) Ditto.
5357 (struct lag_node) Ditto.
5358 (struct casenum_node) Ditto.
5359 (struct nonterm_node) Ditto.
5360 (union any_node) Members renamed.
5361 (struct sys_node) Removed.
5362 (struct val_node) Removed.
5363 (operator typedef) Removed.
5364 (typedef exprtype) Removed.
5365 (enum series EX_*) Moved to exprP.h.
5366 (struct expression) Ditto. Also renamed a lot of the members.
5367 (PXP_* defines) Changed to enums.
5368 (free_node prototype) Moved to exprP.h.
5370 * file-handle.h: (struct file_handle) New member `where'.
5372 * file-handle.q: Migrated to new q2c format.
5373 (prepend_current_directory) Removed (dead code).
5374 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5375 (fh_get_handle_by_filename) Removed dead code.
5376 Set new `where' member.
5378 * file-type.c: (file_type_source_read) References to
5379 parse_string_as_format() changed to data_in().
5380 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5382 * filename.c: All references updated.
5383 (init_filename) Renamed fn_init().
5384 (expand_line) Removed.
5385 (macro EXPAND_LINE) Removed.
5386 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5387 of custom functions.
5388 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5389 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5390 (normalize_filename) Renamed fn_normalize().
5391 (search_path) Renamed fn_search_path(), rewritten.
5392 (prepend_dir) Renamed fn_prepend_dir().
5393 (blp_getenv) Renamed fn_getenv().
5394 (blp_dirname) Renamed fn_dirname().
5395 (fn_basename) New function, not used.
5396 (absolute_filename_p) Renamed fn_absolute_p().
5397 (is_special_filename) Renamed fn_special_p().
5398 (file_exists) Renamed fn_exists_p().
5399 (readlink_malloc) Renamed fn_readlink().
5400 (getenv_default) Renamed fn_getenv_default().
5401 (open_file) Renamed fn_open().
5402 (close_file) Renamed fn_close().
5403 (open_file_ext) Renamed fn_open_ext().
5404 (close_file_ext) Renamed fn_close_ext().
5406 * font.h: Migrate from arenas to pools.
5408 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5410 * frequencies.g: Migrate from arenas to pools.
5412 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5415 * getline.c: All references updated.
5416 (global getl_buf) Changed from char * to struct string.
5417 (static getl_include_path) Ditto.
5418 (global getl_buf_len) Removed.
5419 (global getl_buf_size) Removed.
5420 (getl_include_path) Deal with new getl_buf, getl_include_path.
5421 (getl_uninitialize) New function.
5422 (getl_get_current_directory) Rewritten.
5423 (getl_clear_include_path) Rewritten.
5424 (getl_add_include_dir) Rewritten.
5425 (getl_add_file) Assertion fixed.
5426 (getl_add_virtual_file) Change initial value of `remaining_loops'
5428 (welcome) Rewritten.
5429 (handle_line_buffer) Make static. Change logic to make
5430 getl_add_virtual_file() change sensible. Use ds_*() strings.
5431 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5432 (getl_close_file) Moved.
5433 (getl_location) New function.
5435 * getline.h: All references updated.
5436 (macro curln) Removed.
5437 (macro curfn) Removed.
5438 (macro am_interactive) Renamed getl_am_interactive.
5439 (macro am_reading_script) Renamed getl_reading_script.
5441 * glob.c: (global fmt_parse_ignore_error) Removed.
5442 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5443 systems that support it (C99). Turn off SET ECHO by default. No
5444 necessary julcal initialization anymore.
5446 * groff-font.c: Migrate from arenas to pools.
5447 (groff_read_font) Use err_push_file_locator().
5448 (groff_read_DESC) Ditto.
5449 (font_msg) Use tmsg().
5451 * hash.c: (hsh_sort) Fix debug code.
5452 [GLOBAL_DEBUGGING] Include stdio.h.
5454 * hash.h: (macro force_hsh_insert) Rephrase.
5456 * heap.c: Rewritten.
5458 * heap.h: Rewritten.
5460 * html.c: (html_option) Change from outp_value to struct string.
5461 (postopen) Change from curfn to getl_location().
5462 (escape_string) Remove rich-text code. Signature changed.
5463 (output_tab_table) Switch from a_string to struct len_string.
5464 Remove rich text support.
5466 * lexer.c: All references updated. Largely rewritten. Major
5467 changes listed below. Removed tagged quote support. Adapted to
5468 struct string tokstr.
5469 (global tokstr) Changed to struct string.
5470 (global tokstr_size) Removed.
5471 (global tokstr_len) Removed.
5473 (global tokint) Removed.
5474 (global toklongstr) Removed.
5475 (C* defines) Removed.
5476 (static tbl[]) Removed.
5477 (static id[]) Removed.
5478 (static une[]) Removed.
5479 (discard_line) Renamed lex_discard_line().
5480 (get_entire_line) Renamed lex_entire_line().
5481 (get_rest_of_line) Renamed lex_rest_of_line().
5482 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5483 (make_hexit) Removed.
5484 (syntax_error) Renamed lex_error(). Return value removed.
5485 (get_token_representation) Renamed lex_token_representation().
5486 (putback) Renamed lex_put_back().
5487 (putfwd) Renamed lex_put_forward().
5488 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5489 (set_prog) Renamed lex_set_prog().
5490 (init_lex) Renamed lex_init().
5491 (reset_eof) Renamed lex_reset_eof().
5492 (lookahead) Renamed lex_look_ahead().
5493 (check_id) Rewritten.
5494 (yylex) Renamed lex_get(), rewritten.
5495 (lex_end_of_command) New function. Many commands were rephrased
5497 (lex_integer_p) New function. Replaces compare of tokint against
5499 (lex_integer) New function. Replaces tokint.
5500 (match_tok) Renamed lex_match().
5501 (match_id) Renamed lex_match_id().
5502 (match_int) Renamed lex_match_int().
5503 (force_match_id) Renamed lex_force_match_id(), added return value.
5504 (force_match) Renamed lex_force_match(), added return value.
5505 (force_string) Renamed lex_force_string(), added return value.
5506 (force_int) Renamed lex_force_int(), added return value.
5507 (lex_id_match_len) New function.
5508 (id_match) Renamed lex_id_match(), rewritten.
5509 (get_line) Renamed lex_get_line().
5510 (preprocess_line) Renamed lex_preprocess_line().
5511 (tokname) Renamed lex_token_name().
5512 (bin_value_func) Removed.
5513 (oct_value_func) Removed.
5514 (hex_value_func) Removed.
5515 (unexpected_eof) New function.
5516 (convert_numeric_string_to_char_string) New function.
5517 (parse_string) Rewritten, signature changed.
5518 (add_tokstr_char) Removed.
5519 (add_tokstr_unsigned) Removed.
5520 (add_tokstr_string) Removed.
5521 (parse_tagged_quote) Removed.
5522 (skip_comment) Renamed lex_skip_comment().
5524 * lexer.h: All references updated.
5525 (macro is_id1) Renamed CHAR_IS_ID1.
5526 (macro is_idn) Renamed CHAR_IS_IDN.
5527 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5528 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5529 (macro get_token) Removed.
5530 (macro id_match) Removed.
5531 (macro force_match_id) Removed.
5532 (macro force_match) Removed.
5533 (macro force_string) Removed.
5534 (macro force_int) Removed.
5535 (macro force_num) Removed.
5536 (macro force_id) Removed.
5538 * lexerP.h: Removed.
5540 * list.q: Migrated to new q2c format.
5541 (write_line) Deal with struct len_string.
5542 (write_varname) Ditto.
5543 (write_fallback_headers) Ditto.
5545 * magic.c: New file, incorporating the following global variables
5546 previously in other files: endian, second_lowest_value. And both
5547 of those are conditional on #define's.
5549 * magic.h: New file, incorporating the following global variable
5550 declarations: endian, second_lowest_value, and the following macro
5551 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5553 * main.c: Added declarations of pgmname, finished, curdate,
5555 (main) Call new parse_script() function.
5556 (parse_script) New function.
5557 (execute_command) New function.
5558 (dump_token) Removed.
5559 (handle_error) New function.
5561 * matrix.c: New file.
5563 * matrix.h: New file.
5565 * matrix-data.c: Migrated from arenas to pools.
5566 (mget_token) Change from parse_string_as_format() to data_in().
5568 * means.q: Migrate to new q2c.
5569 (custom_tables) Renamed mns_custom_tables().
5570 (custom_crossbreak) Renamed mns_custom_crossbreak().
5571 (custom_variables) Renamed mns_custom_variables().
5573 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5574 (parse_varnames) Prototype.
5575 (parse_numeric) Rephrasings.
5576 (parse_alpha) Adapt to new struct string tokstr.
5578 * misc.c: (intlog10) Rewritten.
5580 (ansi_rand) Renamed real_rand(), moved into random.c.
5581 (ansi_srand) Renamed real_srand(), moved into random.c.
5582 (setup_randomize) Moved to random.c.
5583 (rand_uniform) Ditto.
5584 (rand_normal) Ditto.
5585 (rand_simple) Ditto.
5586 (get_config_line) Removed.
5587 (reverse) Removed (dead code).
5589 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5590 (macro CLEAR_BIT) Ditto.
5591 (macro TEST_BIT) Ditto.
5592 (macro SET_BIT_TO) Ditto.
5593 (macro BIT_INDEX) Ditto.
5595 * output.c: (outp_read_devices) Move to err_push_file_locator()
5596 from push_cust(). Use struct string.
5597 (expand_op_tokstr) Removed.
5598 (static var op_tokstr) Changed to struct string.
5599 (static var op_tokstr_size) Removed.
5600 (tokener) Rephrasings. Use struct string.
5601 (parse_options) Use struct string.
5602 (destroy_driver) Fix assertion.
5603 (outp_get_paper_size) Move to err_push_file_locator().
5604 [0] Removed dead code.
5605 (outp_string_width) Move to len_string.
5607 * output.h: Comment fixes.
5608 (TAG_* enum series) Removed.
5609 (struct outp_value) Removed.
5610 (enum OUTP_T_FANCY) Removed.
5611 (struct outp_text) `s' changed from a_string to len_string.
5612 (struct outp_class) `option' change arg 3 from outp_value to
5615 * pfm-read.c: (corrupt_msg) Rewritten.
5617 * pfm-write.c: (bufwrite) Fix assertion.
5619 * pool.c: New file, reference version.
5621 * pool.h: New file, reference version.
5623 * postscript.c: (ps_font_sizes) Fix assertion.
5624 (ps_option) Change arg 3 from outp_value to struct string.
5625 Adapt to struct string.
5626 (macro output_line) Removed.
5627 (macro add_string) Removed.
5628 (output_encodings) Adapted to struct string. Moved to
5629 err_push_file_locator().
5630 (find_encoding_file) Fix assertion.
5631 (read_ps_encodings) Move to err_push_file_locator().
5632 (postopen) Use getl_location() instead of curfn.
5633 (out_text_plain) Move to len_string.
5634 (text) Ditto. Remove rich text support.
5636 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5637 (cmd_print_eject) Ditto.
5639 (internal_cmd_print) Now cleans up after itself. Uses
5640 fh_parse_file_handle() now.
5641 (cmd_print_space) Use PXP_NUMERIC to type-check.
5643 * q2c.c: Overhauled. Removed _("") i18n support. All references
5644 updated. All output functions updated to handle structures rather
5645 than local or static variables. Adapt to new PSPP lex_*()
5649 (macro MAX_N_SBC) Removed.
5650 (global bare) Removed.
5651 (enum STRING) Renamed T_STRING.
5652 (enum ID) Renamed T_ID.
5653 (get_buffer) Buffer size increased.
5654 (strlower) Renamed st_lower(), rephrased.
5655 (strupper) Renamed st_upper(), rephrased.
5656 (skip_ws) New function.
5657 (get_line) Don't special-case any types of lines (like those
5658 beginning with ! or $, for instance).
5659 (get_token) Renamed lex_get(). Rephrased.
5660 (static var `prefix') New.
5661 (parse) New function.
5662 (parse_setting) Minor rephrasing.
5663 (dump_specifier_vars) Ditto.
5664 (make_identifier) Put null terminator on identifier, duh.
5665 (dump_vars) Renamed dump_declarations(). Never indent. Never
5666 static. Output changed entirely.
5667 (dump_specifier_init) Rephrase.
5668 (dump_vars_init) No index variable needed. Other modifications.
5669 (dump_parser) Don't parse command name. Do dump functions instead
5670 of just code fragments.
5671 (dump_free) Dump function instead of code fragment.
5672 (recognize_directive) New function.
5673 (main) Use recognize_directive(). Don't rely on magic $ line
5674 beginning: instead, parse comments. Update list of headers.
5676 * random.c: New file, containing the following functions:
5677 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5678 rand_normal, rand_simple.
5680 * random.h: New file.
5682 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5683 function. `max_src_width', `max_dst_width' changed to size_t.
5684 (internal_cmd_recode) Removed.
5685 (parse_dest_spec) Merge similar cases.
5686 (parse_src_spec) Add assertion.
5688 * repeat.c: (recognize_keyword) New function.
5689 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5690 REPEAT. Improve recognition of END REPEAT (use
5691 recognize_keyword()). Move from curfn to getl_location(). Use
5694 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5696 * set.q: Adapt to new q2c.
5697 (cmd_set) Range-check some values better.
5698 (custom_blanks) Renamed stc_custom_blanks().
5699 (custom_length) Renamed stc_custom_length().
5700 (custom_results) Renamed stc_custom_results().
5701 (custom_seed) Renamed stc_custom_seed().
5702 (custom_width) Renamed stc_custom_width().
5703 (custom_format) Renamed stc_custom_format().
5704 (custom_journal) Renamed stc_custom_journal().
5705 (custom_color) Renamed stc_custom_color().
5706 (custom_listing) Renamed stc_custom_listing().
5707 (custom_disk) Renamed stc_custom_disk().
5708 (custom_log) Renamed stc_custom_log().
5709 (custom_rcolor) Renamed stc_custom_rcolor().
5710 (custom_viewlength) Renamed stc_custom_viewlength().
5711 (custom_workdev) Renamed stc_custom_workdev().
5713 * settings.h: Not necessary to include format.h any longer.
5715 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5716 (corrupt_msg) Rewritten.
5718 * sort.c: Adapt to rewritten heap ADT.
5720 * str.c: (aa_strcpy) Removed.
5721 (ab_strcpy) Removed.
5722 (ac_strcpy) Removed.
5723 (ba_strcpy) Removed.
5724 (bb_strcpy) Removed.
5725 (ca_strcpy) Removed.
5726 (aa_strdup) Removed.
5727 (aa_strdupcpy) Removed.
5728 (ba_strdup) Removed.
5729 (sa_strdup) Removed.
5730 (memrev) Renamed mm_reverse().
5731 (memrmem) Renamed mm_find_reverse().
5732 (cmp_str) Renamed st_compare_pad().
5733 (strmaxcpy) Removed.
5734 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5735 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5737 (strpadcpy) Renamed st_pad_copy(), signature changed.
5738 (blpstrset) Removed.
5739 (ds_create) New function.
5740 (ds_init) New function.
5741 (ds_replace) New function.
5742 (ds_destroy) New function.
5743 (ds_clear) New function.
5744 (ds_extend) New function.
5745 (ds_shrink) New function.
5746 (ds_truncate) New function.
5747 (ds_length) New function.
5748 (ds_size) New function.
5749 (ds_value) New function.
5750 (ds_end) New function.
5751 (ds_concat) New function.
5752 (ds_concat_buffer) New function.
5753 (ds_printf) New function.
5754 (ds_putchar) New function.
5755 (ds_getline) New function.
5756 (ds_get_config_line) New function derived from the old
5757 misc.c:get_config_line().
5758 (ls_create) New function.
5759 (ls_create_buffer) New function.
5760 (ls_init) New function.
5761 (ls_shallow_copy) New function.
5762 (ls_destroy) New function.
5763 (ls_null) New function.
5764 (ls_null_p) New function.
5765 (ls_empty_p) New function.
5766 (ls_length) New function.
5767 (ls_value) New function.
5768 (ls_end) New function.
5770 * str.h: Reformatted.
5771 (struct a_string) Removed.
5772 (struct b_string) Removed.
5773 (struct c_string) Removed.
5774 (struct len_string) New.
5775 (struct string) New.
5776 (macro as_streq) Removed.
5777 (macro bs_streq) Removed.
5778 (macro cs_streq) Removed.
5779 (macro sa_streq) Removed.
5780 (macro sb_streq) Removed.
5781 [__GNUC__] (inline function ds_putchar) New function.
5782 [__GNUC__] (inline function ds_length) New function.
5783 [__GNUC__] (inline function ds_value) New function.
5784 [__GNUC__] (inline function ds_end) New function.
5786 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5787 (display_vectors) Fix missing i18n.
5789 * t-test.q: Migrate to new q2c.
5791 * tab.c: Migrate from arenas to pools.
5792 (tab_create) Use struct len_string.
5793 (tab_realloc) Ditto.
5794 (text_format) Ditto.
5795 (tab_joint_text) Ditto.
5796 (tab_natural_width) Remove rich text support.
5797 (tab_natural_height) Ditto.
5798 (tab_output_text) Handle TAT_FIX.
5799 (tab_raw) Change arg from a_string to len_string.
5800 (tabi_driver) Fix assertion. Use struct len_string.
5801 (render_strip) Use struct len_string. Remove rich text support.
5802 Add `const' qualifiers.
5804 * tab.h: (enum TAB_RICH) Remove.
5805 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5806 SOM_COL_* updated to read TAB_COL_*.
5807 (struct tab_table) Change arena to pool. Change a_string to
5810 * temporary.c: (restore_dictionary) Rewrite Checker code.
5812 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5813 LOWEST, HIGHEST) Moved here from common.h.
5814 (typedef any_trns) Removed. All references changed to `struct
5817 * vars-atr.c: (force_create_variable) Fix assertion.
5818 (force_dup_variable) Fix assertion.
5820 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5822 Using alphanumeric variables in functions under AGGREGATE
5823 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
5824 <BZN-mdksh@t-online.de> for reporting this bug.
5826 * aggregate.c: (parse_aggregate_functions) When setting the
5827 FSTRING bit, also allocate memory for the `string' member of
5829 (free_aggregate_functions) Free iter->string. Don't use the
5830 non-function bits when indexing the array of functions.
5831 [DEBUGGING] (debug_print) Don't use the non-function bits when
5832 indexing the array of functions.
5834 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
5836 Under certain circumstances, the final case would be omitted from
5837 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
5838 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5840 * aggregate.c (agr_00x_end_func): Increment number of cases in
5841 sink before writing case. For streams that keep track of how many
5842 cases there are based on this value, this means that the last case
5843 will be read in on the next stream read.
5845 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
5847 Undefined behavior was invoked by referencing a freed pointer.
5849 * vfm.c (memory_stream_write): Free pointer *after* checking for
5852 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
5854 A wrong record size was displayed when paging the active file to
5857 * vfm.c: (memory_stream_write) Fix off-by-one error.
5859 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
5861 Not having enough temporary space for sorting caused a core dump.
5864 * sort.c: (allocate_cases) Initialize i.
5866 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
5868 Syntax errors in function descriptions on AGGREGATE caused core
5871 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
5872 free_aggregate_functions(), since that function already frees
5875 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
5877 A null pointer was dereferenced, causing a core dump, when
5878 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
5879 but PSPP still doesn't calculate percentiles. Thanks to Regnor
5880 Jernsletten <rjernsle@eunet.no> for reporting this problem.
5882 * arena.c: (arena_malloc) If the arena hasn't been initialized
5883 already, initialize it.
5885 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
5887 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
5888 for compilation with Cygnus Windows B20. Not used by other
5891 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
5893 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
5894 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5896 * sort.c: (compare_case_lists) Reverse sense of comparison if
5897 sorting in descending order.
5898 (compare_record) Ditto.
5900 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
5902 SPLIT FILE with a string variable caused a core dump. Fixed.
5904 * vfm.c: If the variable is a string then make a temporary value
5905 struct pointing to it. The underlying problem is a lot bigger
5906 than this (see TODO) but this is a stopgap for the simple case at
5909 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
5911 Nested INCLUDEs didn't work. Fixed.
5913 * getline.c: (getl_include) Set first_line to NULL in allocated
5916 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
5918 The MATCH FILES procedure set the values of variables not present
5919 to 0. It should have been SYSMIS. This is now fixed.
5921 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
5923 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
5925 The REMARK command was too aggressive about skipping lines. It
5926 didn't like being the last command in a file.
5928 * command.c: (cmd_remark) Call get_entire_line() instead of
5931 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
5933 Comment parsing wasn't consistent with the rest of the code in its
5934 idea of where one command ends and another starts. This meant
5935 that sometimes commands would be mysteriously ignored. Thanks to
5936 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5938 * command.c: (parse_cmd) Hand off comment parsing to new function
5939 skip_comment() in lexer.c.
5940 * lexer.c: (skip_comment) New function.
5942 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
5944 The TABLE subcommand on MATCH FILES worked only erratically at
5945 best. This fixes it. Thanks to Dr. Dirk Melcher
5946 <BZN-mdksh@t-online.de> for reporting this bug.
5948 * get.c: (mtf_compare_BY_values) When comparing string values, a
5949 difference of 1 is still a difference :-)
5950 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
5951 advance TABLE files automatically when matched. Comment fixes.
5953 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
5955 VARIABLE LABELS rejected a slash before the first variable
5956 specification, contradicting the documentation. Thanks to Walter
5957 M. Gray <graywm@northernc.on.ca> for reporting this bug.
5959 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
5960 command specification.
5962 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
5964 Because of an incorrect optimization in memory allocation,
5965 CROSSTABS sometimes segfaulted when asked to output multiple
5966 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5969 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
5970 are passed to output_pivot_table() for its use.
5971 (output_pivot_table) Instead of assuming the number of columns is
5972 constant, keep track with maxcols. In general mode, use maxcells
5973 to determine whether more matrix cells need to be allocated.
5975 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
5977 CROSSTABS didn't display value labels for column and row
5978 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5981 * crosstabs.q: (table_value_missing) If the specified value has a
5982 value label for this variable, then show it instead of the raw
5984 (display_dimensions) Delegate display of value_labels to
5985 table_value_missing.
5987 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
5989 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
5990 <BZN-mdksh@t-online.de> for reporting this bug.
5992 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
5993 if the file isn't declared as binary.
5995 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
5997 MATCH FILES corrupted memory and dumped core on some syntax
6000 * get.c: (cmd_match_files) Set file->handle to NULL before
6002 (mtf_free_file) Don't free a null dictionary.
6004 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6006 MATCH FILES should set numeric values not available to the
6007 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6008 <BZN-mdksh@t-online.de> for reporting this bug.
6010 * get.c: (mtf_processing) Set unused records to system-missing,
6013 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6015 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6016 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6018 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6019 in newly created dictionary, and add each copied variable to the
6022 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6026 * get.c: (trim_dictionary) Free variable list for KEEP after
6029 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6031 Some systems didn't like the way open_file was coded. Thanks to
6032 Hankin <hankin@rogue.consultco.com> for pointing this out.
6034 * filename.c: (open_file) Don't try to store stdin, stdout,
6035 stderr as part of an array, because that doesn't always work.
6037 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6039 The SAVE procedure didn't save long string variables properly.
6040 Fixed by this patch. Thanks to Hankin
6041 <hankin@rogue.consultco.com> for this patch.
6043 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6044 out variable pad records.
6046 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6048 Previously, if PRINT SPACE were given a negative argument, it
6049 would report an error, then spin in an (almost) infinite loop.
6050 This fixes that behavior.
6052 * print.c: (print_space_trns_proc) After reporting a negative
6053 argument, set number of lines to print to 1.
6055 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6057 SPSS 8.0 outputs some new record types in its system files, and it
6058 allows longer value labels. Accept these system files.
6060 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6061 11 emitted by SPSS 8.0.
6063 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6065 The LIST procedure was too conservative in allocating space for
6066 buffers, which caused a bug that only showed up with very long
6067 output variables. Thanks to Hankin <hankin@dunno.com> for this
6070 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6072 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6074 Typo meant string format specifiers weren't checked properly. I
6075 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6076 willing to be corrected on this point.
6078 * format.c: (check_string_specifier) Fix obvious typo.
6080 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6082 Using $CASENUM in an expression didn't work. Here's a fix.
6083 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6086 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6088 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6090 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6092 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6093 other behavior, *sigh*. This patch hopefully fixes that. This
6094 time I've actually tested it.
6096 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6098 * data-list.c: (read_from_data_list_free,
6099 read_from_data_list_list) Call parse_string_as_format() directly
6100 without mucking around with the field width.
6102 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6104 Occasionally, you may encounter a script that wants to be
6105 interpreted in interactive mode. Make -i emulate this behavior to
6106 allow such scripts to be executed with PSPP.
6108 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6110 * cmdline.c: (pre_syntax_message[]) Update -i description.
6112 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6113 when -i is given on the command line) don't treat unindented lines
6114 as starting a new command.
6116 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6118 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6119 mostly caused by local initialized aggregates. After egcs is
6120 fixed upstream these can be removed, but for now they're not a big
6123 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6124 initialized arrays. Avoid this.
6126 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6129 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6131 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6132 following changes avoid. Currently I compile sources with egcs
6133 1.1.1 and gcc 2.7.2.3 before sending them out.
6135 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6137 * ascii.c: (option_tab[]) Initialize all struct members.
6139 * avl.h: (avl_traverser_init) New macro.
6141 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6144 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6147 * hash.c: Comment fix.
6149 * hash.h: (hsh_iterator_init) New macro.
6151 * html.c: (option_tab[]) Initialize all struct members.
6153 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6156 * postscript.c: (option_tab[]) Initialize all struct members.
6157 (output_encodings, preclose, dump_lines) Use new
6158 hsh_iterator_init() macro.
6160 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6163 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6166 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6168 * data-in.c: Examined each of the parsing functions to make sure
6169 that they wouldn't dump core if they were passed a string of the
6170 wrong length, since now the DATA LIST FREE/LIST routines don't
6171 check for field width before passing it to the data parser.
6172 (parse_RBHEX, parse_AHEX) Reject odd length input.
6173 (parse_string_as_format) Reject input that's too short or too
6176 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6177 a field to its entire declared output width then pass it to the
6178 data-in parsing routines. This contradicted the documented
6179 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6180 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6181 free-format parsing that differed from SPSS.
6182 (cut_field) Commas and spaces are treated identically. Returns
6183 the proper column instead of a fixed 1 value.
6184 (parse_field) Removed.
6185 (read_from_data_list_free, read_from_data_list_list) Call
6186 parse_string_as_format directly instead of parse_field.
6188 * heap.c: (heap_delete) Stylistic fixes.
6190 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6192 * loop.c: (loop_2_trns_proc) Formatting fix.
6194 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6196 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6198 * vfm.c: (macro FILTERED) New.
6199 (static var filter_var) New.
6200 (process_active_file_write_case) Use FILTERED.
6201 (setup_filter) Set filter_var.
6202 (close_active_file) Delete the filter if not
6203 FILTER_before_TEMPORARY.
6204 (procedure_write_case) Use FILTERED.
6206 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6208 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6210 * data-in.c: (parse_day_count) Message fix.
6211 (parse_month) Style fix.
6213 * data-list.c: (struct data_list_pgm) New member eof.
6214 (cmd_data_list) Init eof to 0.
6215 (do_reading) Implement the /END subcommand and read-past-eof
6218 * do-if.c: Include stdio.h when debugging.
6219 (cmd_else_if) Make sure the command is .-terminated.
6221 * glob.c: (init_glob) Capitalize the command prompt.
6223 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6224 (end_file_trns_proc) Debugging message.
6226 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6228 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6230 * main.c: (dump_token) Make kwtab[] const.
6232 * set.q: Spelling, comment fixes.
6234 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6237 * vars-prs.c: (fill_all_vars) Style fix.
6239 * vfm.c: (index_to_varname) Return const.
6241 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6243 * Changes in many source files for partial -ansi -pedantic and
6244 no-debugging compliance: Remove trailing common in enum
6245 declarations; add `unused' attributes; insert some appropriate
6248 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6250 * command.c: (shell) Make static.
6251 (run_command) Make static.
6253 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6255 * dfm.c: (cmd_begin_data) I18n fix.
6257 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6259 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6261 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6264 * file-handle.q: Don't prepend the source file directory name to
6265 the data file name. (Ongoing issue.)
6266 (prepend_current_directory) Comment out.
6267 (internal_cmd_file_handle) Don't call prepend_current_directory().
6268 (fh_get_handle_by_filename) Ditto.
6270 * filename.c: Append zero byte to readlink() return value.
6272 * getline.c: (getl_read_line) I18n fix.
6274 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6276 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6278 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6281 * postscript.c: (output_encodings) Don't use local_strdup().
6284 * print.c: Don't use gcc features if __STRICT_ANSI__.
6286 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6288 * recode.c: (parse_src_spec) Fully brace nested if's.
6290 * set.q: (global var set_testing_mode) New var.
6292 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6294 * ascii.c: Add some more `unused' attributes that only come into
6295 play when NDEBUG is defined.
6296 (ascii_close_page) Set s_len when reallocating s.
6298 * crosstabs.q: (delete_missing) New function.
6299 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6300 (make_summary_table) Create summary table reallocable.
6302 * postscript.c: Add more `unused' attributes as above.
6304 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6305 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6307 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6310 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6311 gratuitous space between parameter definition.
6313 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6314 complaints about running off the end of functions with NDEBUG
6317 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6319 * Several source files: Removed some PORTME notes when reflection
6320 revealed that ANSI forbids that sort of breakage. Also, added
6321 lots of `unused' qualifiers here and there.
6323 * aggregate.c: (accumulate_aggregate_info) Remove local var
6324 weighting that turned out not to be used.
6326 * avl.c: Update to version 1.1.0. Add unused specifier.
6327 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6329 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6330 (avl_find) Cast return value to void *.
6331 (avl_delete) q doesn't need to be initialized at the beginning of
6332 the function. Replace some instances of 1 with +1.
6333 (force_avl_delete) Renamed avl_force_delete, all references changed.
6334 (compare_ints) `param' marked unused.
6335 (print_int) `param' marked unused.
6336 (recurse_tree) Replace some instances of 1 with +1.
6338 * avl.h: Update to version 1.1.0. Only declares avl function
6339 types if not already declared.
6340 (AVL_MAX_HEIGHT) Only define if not already defined.
6341 (struct avl_node) New unused member char pad[2].
6342 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6343 (force_avl_insert) Renamed avl_force_insert.
6344 (force_avl_delete) Renamed avl_force_delete.
6346 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6348 (struct crosstab) Add new member `ofs'.
6349 (glob var int_tab) Removed.
6350 (custom_tables) In integer mode, assign v[i] properly through the
6352 (custom_variables) Now p.crs.max == max + 1.
6353 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6354 (precalc) Implement integer mode.
6355 (calc_integer) Implement integer mode.
6356 (compare_table_entry) Remove unused local variable `comparing'.
6357 (make_summary_table) Implement integer mode.
6358 (macro ns_rows) Implemented as static variable now.
6359 (several variables) Made static, from global.
6360 (output_pivot_table) Use table_value_missing() for column heads.
6361 Remove several unused local variables. Implement integer mode
6362 table summing. Count up ns_rows.
6363 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6364 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6365 calls that function or find_pivot_extent_integer.
6366 (find_pivot_extent_integer) New function.
6367 (enum_var_values) Implemented for integer mode.
6368 (table_value_missing) New function.
6369 (display_dimensions) Call table_value_missing() for heads.
6370 (float_M_suffix) New function.
6371 (display_crosstabulation) Call table_value_missing() for row
6372 heads. Handle missing values in /MISSING=REPORT mode.
6373 (calc_fisher) Remove unused var N.
6374 (calc_r) Remove unused var fact.
6376 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6377 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6379 * data-out.c: (insert_commas) Remove unused var cp.
6380 (convert_CCx) Remove unused vars save_set_decimal,
6383 * descript.q: (dump_z_table) Fix table dimensioning.
6384 (pre_calc) Remove unused var j.
6385 (display) Remove unused vars title, s. Fix table dimensioning.
6387 * expr-evl.c: Comment fixes.
6389 * frequencies.q: (full_dim) New function.
6390 (dump_full) Fix table dimensioning.
6391 (condensed_dim) New function.
6392 (dump_condensed) Fix table dimensioning.
6394 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6397 * html.c: (html_close_drive) Remove unused var i.
6398 (postopen) Remove unused vars title, curfn_len, cp.
6399 (preclose) Remove unused vars this, x.
6401 * lexer.c: Comment fixes.
6403 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6405 * means.q: (custom_tables) Remove unused var m_dim.
6407 * mis-val.c: Format fix.
6409 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6411 * output.c: (outp_get_paper_size) Remove unused var cp.
6413 * pfm-read.c: (read_float) Remove unused var save, unused label
6415 (read_variables) Remove unused vars cp, j.
6416 (read_value_label) Remove unused var j.
6418 * pfm-write.c: (bufwrite) Remove unused var i.
6420 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6422 (output_encodings) Remove unused vars char_cp, n_output.
6423 (read_ps_encodings) Remove unused var ep.
6424 (postopen) Remove unused var title.
6425 (preclose) Remove unused var fp.
6426 (ps_open_page) Remove unused vars true, false, orientation,
6427 mirror_horz, mirror_vert, width, length.
6428 (ps_text_metrics) Remove unused var x.
6430 * q2c.c: (find_symbol) Remove unused var y.
6431 (parse_setting) Remove unused parameter sbc, all references
6433 (dump_parser) Remove unused var cp.
6434 (dump_free) Remove unused var i.
6436 * set.q: (static vars args, n) Removed.
6437 (internal_cmd_gset) Removed.
6439 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6440 (read_machine_flt64_info) Removed unused var file_endian.
6441 (read_documents) Removed unused var i.
6442 (read_compressed_data) Removed unused parameter dict, all
6445 * sfm-write.c: (bufwrite) Removed unused var i.
6446 (sfm_write_case) Removed unused var i.
6448 * sort.c: (merge_once) Remove unused var t.
6449 (write_separate) #if 0 out as dead code.
6451 * split-file.c: (cmd_split_file) Remove unused var i.
6453 * sysfile-info.c: (sysfile_info_dim) New function.
6454 (cmd_sysfile_info) Fix table dimensioning.
6455 (variables_dim) New function.
6456 (display_variables) Fix table dimensioning.
6457 (describe_variable) Remove unused var prev_r.
6459 * t-test.q: (z_postcalc) Removed.
6460 (pairs_calc) Remove unused var bad_weight.
6461 (postcalc) Remove unused vars dfn, dfd.
6463 * tab.c: (tab_create) Set t->dim to NULL.
6464 (tab_dim) Make sure t->dim is NULL first.
6465 (tab_natural_width) Remove parameter `clamp'.
6466 (tab_value) Remove duplicate assertion for table.
6467 (tab_raw) New function.
6468 (nowrap_dim) New function.
6469 (wrap_dim) New function.
6470 (tab_output_text) Fix table dimensioning.
6472 * tab.h: (tab_raw) New macro.
6474 * val-labs.c: (get_label) Remove unused var type.
6475 (copy_value_labels) Remove unused var trav.
6477 * var.h: (struct crosstab_proc) Completely changed.
6479 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6481 * vfm.c: (open_active_file) Remove unused vars i, lp.
6483 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6485 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6487 * Makefile.am: Add apply-dict.c, flip.c.
6489 * apply-dict.c: New file.
6491 * command.c: (struct command) Make cmd[] larger for CLEAR
6492 TRANSFORMATIONS command name.
6493 (parse_cmd) Make sure we're in a valid state before using it as an
6494 index. Discard variables and reset state on invalid transitions.
6495 (cmd_clear_transformations) New function.
6497 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6498 Add unimplemented PRESERVE, RESTORE.
6500 * file-handle.h: Include stddef.h.
6504 * pfm-read.c: (parse_value) Pad value label values with spaces,
6507 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6508 (sfm_close) Decrement reference count, make sure it's zero.
6509 (sfm_maybe_close) New function.
6510 (sfm_read_dictionary) Handle reference counts.
6512 * vars-atr.c: (clear_default_dict) New function.
6513 (discard_variables) Use clear_default_dict().
6515 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6517 * Makefile.am: Add pfm-write.c.
6518 (LDADD) Add the libgmp2 libraries.
6520 * command.def: Define EXPORT.
6522 * get.c: (cmd_export) New function.
6523 (export_write_case_func) New function.
6525 * pfm-read.c: (static spss2ascii[]) Make it const.
6527 * pfm-write.c: New file.
6529 * sfm-write.c: Formatting, comment fixes.
6531 * var.h: Comment fix.
6533 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6535 * Makefile.am: Add pfm.h, pfm-read.c.
6537 * command.def: IMPORT is now implemented.
6539 * format.c: (glob var translate_fmt[]) New var.
6541 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6542 (cmd_import) New function.
6543 (import_source_read) New function.
6544 (glob var import_source) New var.
6546 * pfm-read.c: New file.
6550 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6552 (dump_dictionary) Disabled printing a couple of items.
6554 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6556 * crosstabs.q: (postcalc) Call make_summary_table().
6557 (make_summary_table) New function.
6558 (insert_summary) New function.
6559 (display_dimensions) Remove some unnecessary arguments, all
6561 (output_pivot_table) Fix lots of problems with the risk table
6563 (submit) Don't display an empty table.
6564 (display_risk) Fix order of arguments to calc_risk().
6566 * glob.c: Always include assert.h and stdlib.h.
6568 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6571 * tab.c: (tab_create) Cosmetic changes.
6573 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6575 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6579 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6580 code simplified, moved into new function submit().
6581 (submit) New function.
6582 (crosstabs_dim) New function.
6583 (display_directional) Substitute variable names for %s where
6585 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6586 (calc_symmetric) Initialize parameters only if non-NULL.
6587 Calculate Somers' d.
6588 (calc_directional) Calculate Somers' d (or copy it, really).
6591 * output.c: (outp_string_width) New function.
6593 * postscript.c: (postopen) Calculate font widths based on the
6594 width of the zero '0' character, not the width of the space
6595 character. Set paper-width and paper-length based on points, not
6597 (ps_open_page) Fix page setup string for landscape mode.
6599 * som.h: (struct som_dimension) Removed.
6600 (struct som_table_class) height, width members take int * not
6603 * tab.c: Many functions now have added parameter validation.
6604 (tab_height, tab_width) These functions were removed and merged
6605 into a single function tab_resize(), and all references changed.
6606 (tab_dim) Rewritten since the interface changed; reduced from
6607 hundreds of lines to two. All callers were changed. Currently
6608 most of them just use tab_natural_dimensions as their callback and
6609 await detailed translation of functionality.
6610 (tab_natural_width) New function.
6611 (tab_natural_height) New function.
6612 (tab_natural_dimensions) New function. This is a callback
6613 function, not something that you'd want to call directly.
6614 (tab_nat_dim) Removed.
6615 (tabi_table) Allocates t->w and t->h.
6616 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6617 dimensions callback.
6618 (evaluate_dimensions) Removed.
6619 (sum_columns) Removed.
6621 * tab.h: (enum TAL_1THIN) Removed.
6622 (enum series t_*) Removed.
6623 (struct tab_table) Members trh, trv changed to unsigned char *
6624 from int *. Member dim changed to a function pointer from a
6625 unsigned char *. Member max_stack_height removed. New members
6627 (macros tab_l, tab_r, tab_t, tab_b) New.
6629 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6631 * ascii.c: (delineate) Assign last_space_nchars before skipping
6632 spaces, to fix right justification.
6634 * crosstabs.q: (static vars risk, direct) New vars.
6635 (static var pearson_r) Removed.
6636 (glob var chisq_fisher) Made static.
6637 (static vars row_tot[], col_tot[]) Don't include grand total
6639 (static var grand_total) Renamed W, all references changed.
6640 (output_pivot_table) Only make `table' if num_cells != 0. Make
6641 risk and directional tables. Deal with grand total no longer part
6642 of col_tot[]. Free rows and cols after we're done with them.
6643 (display_risk) New function.
6644 (display_directional) New function.
6645 (clac_r) Rewritten so that it stores all its results into its
6646 arguments, so it can be used for Spearman's correlation too.
6647 (calc_symmetric) Added a t[] argument, all references changed.
6648 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6649 Pearson's r, Cohen's kappa.
6650 (calc_risk) New function.
6651 (calc_directional) New function.
6653 * som.c: (som_submit) Improved debugging code.
6655 * stats.c: (hypercube) New function.
6656 (cube) New function.
6658 (normal_sig) Went back to old implementation, which actually
6661 * stats.h: (macros square, cube, hypercube) Removed. The
6662 equivalent functions in stats.c are inlined here; all references
6663 to square changed to sqr.
6665 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6667 * crosstabs.q: (N_SYMMETRIC) New define.
6668 (postcalc) Disable debug printing.
6669 (static vars chisq_fisher, pearson_r) New.
6670 (output_pivot_table) Add support for symmetric measures. Add
6671 chi-square output of exact sigs.
6672 (display_chisq) Rewritten.
6673 (display_symmetric) New function.
6674 (gamma_int) New function.
6676 (swap) New function.
6677 (calc_fisher) New function.
6678 (calc_chisq) Check boundary conditions better. Calculate Yates,
6679 Fisher, Mantel-Haenszel tests.
6680 (calc_r) New function.
6681 (calc_symmetric) New function.
6683 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6685 (chisq_sig) Better boundary conditions. Renamed from
6688 * tab.h: (struct tab_table) New member cf.
6690 * tab.c: (tab_create) Set cf.
6691 (tab_width) New function.
6692 (tab_realloc) Handle cf.
6693 (tab_vline) Handle cf.
6694 (tab_hline) Handle cf.
6695 (tab_box) Handle cf.
6696 (tab_value) Handle cf.
6697 (tab_float) Handle cf.
6698 (tab_text) Handle cf.
6699 (tab_joint_text) Handle cf.
6700 (tab_offset) Handle cf.
6701 (tab_next_row) Handle cf.
6702 (evaluate_dimensions) Handle cf.
6703 (render_strip) Handle cf.
6705 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6707 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6708 output_pivot_table().
6709 (output_pivot_table) Moved lots of local variables outside and
6710 made them static. Add beginnings of chi-square statistic
6711 support. Now column and row totals aren't in the main matrix.
6712 Always zero out any leftover rows & columns after we're done with
6713 the table entries. Move all output stuff into
6714 display_dimensions(), display_crosstabs(), display_chisq().
6715 (display_dimensions) New function.
6716 (display_crosstabulation) New function.
6717 (display_chisq) New function.
6718 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6720 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6721 references, simplify logic.
6723 * postscript.c: Remove scale, translate-x, translate-y,
6724 mirror-horz, mirror-vert, rotate-180 options.
6725 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6726 All references deleted.
6727 (macro YT) New macro.
6728 (array option_tab[]) Removed options.
6729 (ps_option) Removed options.
6730 (ps_open_page) Write page setup explicitly to output file, without
6731 using now-deleted BP function.
6732 (macro dump_line) Use YT().
6733 (macro dump_thick_line) Use YT().
6734 (draw_headers) Use YT().
6735 (switch_font) Reorder arguments to SF function.
6736 (write_text) Use YT().
6738 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6741 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6743 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6744 null-debugging code.
6745 (tab_realloc) Remove null-debugging code. Initialize new regions
6747 (tab_vline) Support offsets.
6748 (tab_hline) Support offsets.
6749 (tab_box) Support offsets.
6751 (tab_nulls) Removed.
6754 (evaluate_dimensions) Remove null-debugging code. Understand
6755 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6756 TAB_EMPTY not present.
6758 * tab.h: New cell attribute TAB_EMPTY.
6759 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6761 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6762 try to read them from system files.
6764 * vfm.c: (dump_splits) Don't call tab_null().
6766 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6768 * crosstabs.q: (struct crosstab) Added `missing' member.
6769 (custom_tables) Init missing.
6770 (calc_general) Handle missing values.
6771 (calc_chisq) New function.
6772 (output_pivot_table) Start work on chi-square output. Update for
6773 new tab offset support functions. Shorten statistic names.
6775 * Several files: add in more `const's to placate gcc's warnings.
6777 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6780 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6781 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6782 tab_joint_text) Add col_ofs and row_ofs support.
6783 (tab_offset) New function.
6784 (tab_next_row) New function.
6785 (tab_row) New function.
6786 (tab_col) New function.
6787 (tabi_table) Add col_ofs and row_ofs support.
6789 * vars-atr.c: (is_system_missing) New function.
6791 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6793 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6794 (static var no_cells) Removed.
6795 (static var num_cells) New.
6796 (static var expected) New.
6797 (static var cells[]) New.
6798 (internal_cmd_crosstabs) Deal with new variables.
6799 (postcalc) Removed most of the meat and put it in new function
6800 output_pivot_table().
6801 (output_pivot_table) Calculates and outputs an entire pivot table.
6803 * postscript.c: (postopen) Fix problems with free()ing addresses
6804 not obtained from malloc().
6806 * som.c: (som_submit) Add assertion.
6808 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6811 * tab.c: (static var tab_names[]) New.
6812 (tab_realloc) -1 for nc or nr indicates no change.
6813 (tab_nulls) New function.
6814 (tab_dim) Use tab_names[].
6815 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6816 (evaluate_dimensions) Don't terminate on uninited cells, just put
6817 an X in them and emit a notice. Use tab_names[].
6819 * tab.h: Move bits into tab.def.
6821 * tab.def: New. Don't try to declare tab_table_class because then
6822 som.h has to be included.
6824 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
6826 * command.def: New file, contains all the command definitions
6827 previously included bodily in command.c.
6829 * format.def: New file, contains all of the format definitions
6830 previously split across format.h, format.c, and sfm-write.c.
6832 * lexer.h: Renamed from tokens.h in order to match corresponding
6835 * lexerP.h: Moved some rarely used functions exported by lexer.c
6838 * Makefile.am: Commemorate renamed files.
6839 (EXTRA_DIST) Add command.def, format.def.
6841 * command.c: [0] (walk_cmdtable_func) Removed.
6843 * crosstabs.q: (postcalc) Made it work and print out matrices
6845 (enum_column_values) Renamed enum_var_values, generalized for any
6848 * format.h: (struct fmt_desc) New member `spss'.
6850 * q2c.c: (main) Generated code includes lexer.h instead of
6853 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
6854 instead of an independent translation table.
6856 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
6858 * Lots of source files: Added const to declarations.
6860 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
6862 * arena.c: (arena_clear) Set prev pointer to null when done.
6864 * ascii.c: (ascii_option) Rename index as indx.
6866 * avl.c: This is now a separate library called libavl.
6867 (xmalloc) Make static.
6868 (avl_probe) Step A7 can use the cache instead of an explicit
6870 (avl_delete) Don't maintain a q pointer because it's always
6871 available in the pointer stack. Comment fix.
6873 * avl.h: This is now a separate library called libavl.
6875 * command.c: (cmd_table[]) Remove spurious trailing "".
6877 * common.h: Only include random() fix if this system needs it.
6879 * crosstabs.q: Include alloca headers.
6880 (n_sorted_tab) New global var.
6881 (postcalc) Mostly rewritten.
6882 (find_pivot_extent) Rewritten.
6883 (enum_column_values) Rewritten.
6885 * data-out.c: (convert_F) Rename inner n as n_spaces.
6887 * error.c: (dump_message) Don't have an outer var i.
6889 * file-handle.q: (static var f) Removed. All references removed.
6890 (internal_cmd_file_handle) Uses a local variable instead of f.
6892 * get.c: (trim_dictionary) Change scope of i, i1, i2.
6893 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
6896 * getline.h: Declare getl_history as extern. Reported by
6897 palme@uni-wuppertal.de (Hubert Palme).
6899 * postscript.c: (postopen) Some large mods for constness.
6901 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
6904 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
6906 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
6907 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
6910 * avl.c, avl.h: New files. These form a clean-room
6911 reimplementation of avllib. Iterative algorithms are used in
6912 place of recursive ones, so there is no resemblance in the code.
6914 * Lots of headers: Don't include other headers by default.
6916 * Lots of source files: Explicitly include all needed headers.
6918 * arena.c: (arena_clear) New function.
6920 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
6921 (static var ar) Removed.
6922 (staitc vars ar_tc, ar_col) New.
6923 (cmd_crosstabs) Destroy the arenas.
6924 (internal_cmd_crosstabs) Create the arenas.
6925 (precalc) Don't need a free function for the hash.
6926 (calc_general) Make sure to zero out the trailer on the key data
6928 (print_table_entries) Updated.
6929 (postcalc) Worked on actually implementing.
6930 (find_pivot_extent) New function.
6931 (compare_value) New function.
6932 (enum_column_values) New function.
6934 * data-in.c: (parse_month) Make local array `static const'.
6936 * data-out.c: (convert_date) Make local array `static const'.
6937 (convert_WKDAY) Same.
6938 (convert_MONTH) Same.
6940 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
6941 been renamed to avl_walk().
6943 * hash.c: Rewritten more efficiently.
6945 * hash.h: Add attribute const to hsh_next_prime declaration.
6947 * lexer.c: (id_match) Make arguments const.
6949 * postscript.c: (ps_postopen_driver) Make default fonts the
6952 * q2c.c: (main) Generated code needs stdlib.h.
6954 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
6955 initialized to 0 now, not to NULL. All other references to
6956 avl_traverser were updated in the same way.
6958 * tokens.h: Macro version of id_match updated to use const
6961 * val-labs.c: (inc_ref_count) New function.
6962 (copy_value_labels) Simply through use of new avl_copy() function.
6964 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
6966 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
6967 (postcalc) Worked on this.
6969 * postscript.c: (OPO_DOUBLE_LINE) New enum.
6970 (struct ps_driver_ext) New line_width_thick member.
6971 (ps_preopen_drive) Init line_width_thick.
6972 (option_tab[]) Add line-* options.
6973 (ps_option) Parse line-* options.
6974 (postopen) Add line_width_thick support. Strip leading spaces on
6975 prologue output lines.
6976 (ps_open_page) Include line_width_thick in output.
6977 (macro dump_thick_line) New.
6978 (dump_fancy_line) Support thick lines as well as double lines.
6980 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
6982 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
6983 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
6985 * Many source files: Rename `options' to `pv_opts' as appropriate.
6987 * command.c: (static var cmd_table[]) Add CROSSTABS command.
6989 * common.c: (xcalloc) New function.
6991 * crosstabs.q: New file. Not finished yet, though.
6993 * data-list.c: Comment fix.
6995 * error.c: Remove some old Checker cruft.
6997 * frequencies.q: (dump_full) Cumulate valid percent instead of
7000 * getline.c: Comment fix.
7002 * hash.c: Comment fixes.
7004 * hash.h: (struct hsh_table) Make hash functions return unsigned
7005 instead of int to avoid problems with taking the modulo of
7006 negative return values. All references changed.
7008 * misc.c: (intlog10) Make its table static const instead of auto.
7010 * sfm-read.c: (read_header) Make `prefix' static const instead of
7013 * var.h: (union value) Add member `hash'.
7014 (struct variable) Rename prv_index as `foo'--all references
7016 (typedef pv_opts) Removed. All references changed.
7018 * vars-prs.c: (parse_variables) Message fixes.
7020 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7022 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7023 they are being inserted. Don't check for BY variables of
7024 different types. Discard variables if the active file isn't
7025 included in the merge.
7026 (mtf_processing) Essentially rewritten.
7027 (mtf_merge_dictionary) Check for master/slave variables of
7028 different types/widths.
7030 * vfm.c: (static var not_canceled) New var.
7031 (process_active_file) Don't call vfm_source->read() if
7032 there's no vfm-source. Initialize not_canceled.
7033 (process_active_file_write_case) Honor and update not_canceled.
7034 (prepare_for_writing) Rollback changes from yesterday, they were
7036 (close_active_file) Don't destroy vfm_source unless it exists.
7038 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7040 * Lots of source files: Added { } around nested if/else constructs
7041 to avoid new gcc 2.8 warnings.
7043 * data-in.c: (parse_Z) Declare `int' type explicitly.
7046 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7047 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7048 prev members. Put TABLEs at the end of the chain and FILEs at the
7049 beginning. Don't allow the active file in STATE_INIT. Use proper
7050 `seen' value for the active file. Fill out the by members and
7051 make sure they're of consistent type. Do the actual merge
7053 (mtf_processing_finish) New function.
7054 (var_type_description) New function.
7055 (mtf_free_file) New function.
7056 (mtf_free) Rewritten.
7057 (mtf_delete_file_in_place) New function.
7058 (mtf_read_nonactive_records) New function.
7059 (mtf_compare_BY_values) New function.
7060 (static var mtf_seq_no) New var.
7061 (mtf_processing) New function.
7062 (mtf_merge_dictionary) Assign nval members for the system file
7063 dictionary. Assign fv values for its variables. Point each slave
7064 variable to the corresponding master variable.
7066 * hash.c: Include str.h.
7068 * mis-val.c: (copy_missing_values) src arg is const.
7070 * misc.c: (spacing) Make `max' var explicitly int.
7072 * sfm-read.c: (dump_dictionary) Message reformatting.
7073 (sfm_read_case) Add assertion.
7075 * sort.c: Esthetic fixes.
7077 * var.h: (struct match_files_proc) New struct.
7078 (struct variable) Add private data match_files_proc.
7080 * vars-atr.c: (delete_variable) Implement. Add argument for the
7081 dictionary that owning the variable.
7082 (dup_variable) Add assertion.
7084 * vfm.c: Comment fixes, hopefully the comments are correct now.
7085 (process_active_file) New function.
7086 (process_active_file_write_case) New function.
7087 (process_active_file_output_case) New function.
7088 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7090 (write_case) Renamed procedure_write_case(). Now write_case is a
7091 pointer to a function. Style fixes.
7093 1998-03-05 Ben Pfaff <blp@gnu.org>
7095 * Makefile.am: (q2c) Link with libmisc.
7096 (version.c) Define default_config_path, include_path,
7099 * ascii.c: (ascii_postopen_driver) When the default newline string
7100 is requested, open file in text mode. Suggested by
7101 palme@uni-wuppertal.de (Hubert Palme).
7102 (static vars line_buf, line_p) Change from char * to unsigned char
7104 (ascii_close_page) char * to unsigned char *.
7106 * cmdline.c: (parse_command_line) Implement -r option by
7107 prepending ~/.pspp/rc to the list of files to process.
7109 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7110 before pulling in a final line.
7111 (null_func, null_int_func) Removed (dead code).
7113 * descript.q: (display) Calculate width of variable name column
7114 properly. Calculate number of valid cases properly. Reported by
7115 palme@uni-wuppertal.de (Hubert Palme).
7117 * filename.c: (init_filename) Use default_config_path instead of
7118 now obsolete CONFIG_PATH.
7120 * getline.c: (getl_initialize) Use include_path instead of now
7121 obsolete INCLUDE_PATH.
7122 (getl_add_file) New argument `where'. All references changed.
7124 * groff.c: (find_font_file) Use groff_font_path instead of now
7125 obsolete GROFF_FONT_PATH.
7127 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7128 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7129 avoid problems with constness.
7131 * str.h: (macro cs_streq) New macro.
7133 * version.h: (glob var default_config_path, include_path,
7134 groff_font_path) New vars.
7136 1998-02-23 Ben Pfaff <blp@gnu.org>
7138 * Many source files: Change verbose_msg() priority levels and
7141 * aggregate.c: Include debug-print.h.
7143 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7145 (static var pre_syntax_message) Document --safer/-s and
7148 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7150 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7151 because it's not used but it's still copied.
7152 (open_file_r) Remove gratuitous debug message.
7154 * filename.c: (safety_violation) New function.
7155 (open_file) Remove gratuitous debug messages. Don't allow pipe
7156 files if set_safer is set.
7158 * get.c: Turn off debugging.
7160 * getline.c: (getl_add_virtual_file) New function.
7161 (getl_read_line) Add verbose_msg() call for opening new syntax
7163 (getl_perform_delayed_reset) Add a return value describing whether
7164 any action was taken. Call reset_eof().
7166 * getline.h: Comment fix.
7168 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7169 place of incorrect `continue'. Use strtok_r() instead of
7170 strtok(). Always check strtok_r() return value.
7171 (groff_read_DESC) Use strtok_r() instead of strtok().
7173 * lexer.c: (reset_eof) New function.
7175 * main.c: (parse) Get a token after performing a delayed reset
7176 action; allow empty syntax files.
7178 * postscript.c: (output_encodings) Use strtok_r() instead of
7181 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7183 * set.q: Comment fixes.
7184 (glob var set_safer) New var.
7185 (internal_cmd_set) Support SAFER.
7187 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7189 * temporary.c: (free_dictionary) Set d->splits to NULL after
7192 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7193 variable deleted, not if it *isn't* deleted.
7195 1998-02-16 Ben Pfaff <blp@gnu.org>
7197 * command.c: (array cmd_table[]) Add MATCH FILES.
7199 * common.c: Comment fixes.
7201 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7202 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7203 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7206 * expr-opt.c: Include str.h. Problem reported by
7207 palme@uni-wuppertal.de (Hubert Palme).
7209 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7210 (static var mtf_by) Change from char ** to variable **.
7211 (static var mtf_master) New var.
7212 (mtf_merge_dictionary) New function.
7213 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7214 var type. Reorder tests properly. Initialize file->dict. Detect
7215 TABLE= without BY=. Read file dictionaries and merge them. Give
7216 subcommand name with IN, LAST, FIRST error messages. Create IN,
7217 LAST, FIRST variables. Comment fixes.
7218 (mtf_free) Don't free default_dict. Free mtf_master.
7220 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7222 (handle_line_buffer) Cast int to size_t in comparison to avoid
7225 * getline.h: Declare getl_mode extern.
7227 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7228 (groff_read_DESC) Make line_size a size_t.
7229 (match_tok) Parenthesize name to avoid macro expansion.
7231 * mis-val.c: (copy_missing_values) New function.
7233 * postscript.c: (postopen) Make buf_size a size_t.
7235 * sfm-read.c: (dump_dictionary) Make global from static. Print
7236 variable info in parts for easier debugging with Checker.
7238 * temporary.c: (copy_variable) Use copy_value_labels().
7239 (new_dictionary) New arg: whether to copy file label, documents.
7241 * val-labs.c: (copy_value_labels) New function.
7243 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7245 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7247 (dup_variable) Set prv_index, get.fv, get.nv.
7249 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7251 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7253 * Many source files: For ANSI-compliance, add empty statement
7254 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7255 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7257 * data-in.c: (parse_numeric) Some header files break on
7258 -DBL_MIN_10_EXP because they get a --; add () for safety.
7259 Reported by palme@uni-wuppertal.de (Hubert Palme).
7261 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7262 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7263 (dfm_close) Use close_file_ext.
7264 (open_inline_file) Set file.file to NULL, not file.
7265 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7266 struct and use open_file_ext().
7267 (read_record) Use file.file.
7269 * file-handle.q: (prepend_current_directory) Pass through special
7272 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7273 (normalize_filename) Pass through special filenames.
7274 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7276 (dirname) Rename blp_dirname() because of name conflict on some
7277 OS. All references changed. Reported by palme@uni-wuppertal.de
7279 (is_special_filename) New function.
7281 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7282 (trim_dictionary) Conditionalize some of the options on whether
7283 GTSV_OPT_MATCH_FILES is in *options.
7284 (rename_variables) Don't allow variables to be renamed as scratch
7286 (MTF_*) New enum series.
7287 (struct mtf_file) New struct.
7288 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7290 (cmd_match_files, mtf_free) New functions.
7292 * lexer.c: (match_int) Needed parentheses around name to escape
7293 macro expansion. Reported by Micah Altman
7294 <maltman@www-vdc.fas.harvard.edu>.
7296 * print.c: Needed to include alloca.h. Reported by Micah Altman
7297 <maltman@www-vdc.fas.harvard.edu>.
7299 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7300 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7303 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7304 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7306 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7308 * html.c: (struct html_driver_ext) Move into htmlP.h.
7309 (html_preopen_driver) Initialize cp_x, cp_y.
7310 (html_submit) Implement as call to output_tab_table().
7311 (change_attributes) New function.
7312 (escape_string) New function.
7313 (output_tab_table) New function.
7315 * list.q: (write_all_headers) Add code for writing headers for the
7317 (clean_up) Write out the html close-table tag.
7318 (determine_layout) Ignore html driver.
7319 (list_cases) Write html data.
7321 * som.c: (som_submit) Move more of the code into output_table().
7323 * tab.c: (static var hit) Make a global var and rename tab_hit.
7324 (static var tab_table_class) Make a global var.
7326 * htmlP.h: New file.
7328 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7330 * dump-sysfile.c: Removed.
7332 * html.c: (preclose) Change comment in emitted code.
7334 * matrix-data.c: Debugging off by default. Comment fixes.
7335 (static var container) New var.
7336 (cmd_matrix_data) Create and destroy container. Initialize
7337 is_per_factor[] to 0s. Move code into new function
7338 string_to_content_type(). Require split values to be present in
7339 the data when ROWTYPE_ is explicit. Call specific function, not
7340 general read_matrices().
7341 (string_to_content_type) New function.
7342 (context) Exclude all whitespace, not just spaces.
7343 (mget_token) A dot is a number. Add assertion.
7344 (static var data) Renamed nr_data.
7345 (static var factor_values) Renamed nr_factor_values.
7346 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7347 only specific case. Close data_file before exit.
7348 (fill_matrix) New function.
7349 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7350 printing. Style fixes. Message fixes. Move code into
7352 (read_matrices_without_rowtype) Rename
7353 matrix_data_read_without_rowtype(). Fix off-by-one error on
7354 loops. Allocate nr_data[] memory from arena.
7355 (read_matrices_with_rowtype) Removed.
7356 (read_splits) Renamed nr_read_splits(). Style fixes.
7357 (read_factors) Renamed nr_read_factors().
7358 (dump_cell_content) Comment fixes. Arguments changed. Change
7359 debug printing. All references changed.
7360 (output_data) Renamed nr_output_data().
7361 (static var wr_content) New var.
7362 (struct factor_data) New struct.
7363 (static var wr_data) New var.
7364 (static var wr_current) New var.
7365 (matrix_data_source_destroy_source) Removed.
7366 (read_matrices_with_rowtype) New function.
7367 (matrix_data_read_with_rowtype) New function.
7368 (wr_read_splits) New function.
7369 (compare_factors) New function.
7370 (wr_output_data) New function.
7371 (wr_read_rowtype) New function.
7372 (wr_read_factors) New function.
7373 (wr_read_indeps) New function.
7374 (glob var matrix_data_source) Make destroy_source member NULL as
7377 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7379 * lexer.c: (syntax_error) Give better error message when at end of
7382 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7383 N_SCALAR to output as plain N.
7384 (mdump_token) Change output format.
7385 (context) Fix message output interaction with spaces in input.
7386 (another_token) New function.
7387 (force_eol) Improved error message.
7388 (static var max_cell_index) New var.
7389 (read_matrices) Init `cells'. factor_values is now per-cell.
7390 Init max_cell_index.
7391 (read_data_lines) Replace `compare' local with new `compare' arg.
7392 Debugging messages changed. Only read factors if per_factor.
7393 Propagate error return from read_factors(), force_eol().
7394 Copy N_SCALAR values across the N vector.
7395 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7396 check parentheses manually since we now have is_per_factor[].
7397 Call read_data_lines() with new args. Check for end of data after
7398 looping, using another_token().
7399 (read_factors) Arguments changed. Use max_cell_index to determine
7400 whether to read or compare factors. Message fixes.
7401 (dump_cell_content) New function.
7402 (output_data) Completely rewritten because content types were
7403 supported to be nested inside factor values, not vice versa.
7405 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7407 * lexer.c: (syntax_error) Support formatted varargs messages.
7409 * matrix-data.c: Turn debugging on by default.
7410 (static content_type[]) New array.
7411 (static content_names[]) New array.
7412 (static rowtype_, varname_) New vars.
7413 (static is_per_factor[]) New array.
7414 (static split_values) Moved declaration.
7415 (static n_continuous, first_continuous) New var.
7416 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7417 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7418 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7419 Check for continuous variables.
7420 [DEBUGGING] (debug_print) Remove content_names[].
7421 (mdump_token) New macro.
7422 (mget_token_dump) New function.
7423 (mdump_token) New function.
7424 (context) New function.
7425 (mget_token) Fix messages.
7426 (static var data, split_values, factor_values) New vars.
7427 (read_matrices) Manage split_values, factor_values.
7428 (read_data_lines) New function.
7429 (read_matrices_without_rowtype) Implemented.
7430 (read_splits) Message fixes. Uses `just_read'.
7431 (read_factors) New function.
7432 (output_data) New function.
7433 (matrix_data_source_destroy_source) Close the file handle.
7434 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7437 * str.c: (strpadcmp) Removed.
7439 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7441 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7443 * Lots of source files: Add cast to unsigned character to calls to
7444 tolower() and toupper().
7446 * aggregate.c: Set default_dict.splits to NULL.
7448 * command.c: (static variable tab[]) Add MATRIX DATA.
7450 * data-in.c: Add debugging defines. Formatting fixes.
7452 * expr-opt.c: Formatting fixes.
7454 * lexer.c: (syntax_error) Message fixes.
7456 * matrix-data.c: New enum series.
7457 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7458 split_values, n_factors, factors, cells, pop_n, contents,
7459 n_contents) New vars.
7460 (cmd_matrix_data) Finished implementation.
7461 (compare_variables_by_mxd_vartype) New function.
7462 [DEBUGGING] (debug_print) New function.
7463 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7464 (read_matrices) New function.
7465 (read_matrices_without_rowtype) New function.
7466 (read_matrices_with_rowtype) New function.
7467 (read_splits) New function.
7468 (mget_token) New function.
7469 (force_eol) New function.
7470 [0] (test_tokenizer) New function.
7471 (matrix_data_source_destroy_source) New function.
7472 (glob var matrix_data_source) New var.
7474 * misc.h: Include ieeefp.h if present.
7476 * split-file.h: (cmd_split_file) Changes corresponding to struct
7479 * str.h: Fix memmem prototype.
7481 * temporary.c: (save_dictionary, restore_dictionary,
7482 free_dictionary) Changes corresponding to struct dictionary
7485 * var.h: (MXD_* enums) New enum series.
7486 (struct matrix_data_proc) New struct.
7487 (struct split) Removed.
7488 (struct dictionary) Changed `splits' member from `split *' to
7490 (macro force_create_variable) New macro. Replaced lots of
7491 create_variable()/assert() calls with calls to this macro.
7493 * vars-atr.c: (discard_variables) Changed assertion.
7494 [GLOBAL_DEBUGGING] (force_create_variable) New function
7495 called by the macro of the same name.
7496 (clear_variable) Changes to delete splits from the dictionary
7497 corresponding to struct dictionary changes.
7499 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7500 corrupted variable `index' values in the dictionary passed in
7501 every time this function is called.
7503 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7504 to struct dictionary changes.
7506 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7508 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7510 * command.c: New includes.
7511 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7512 (cmd_erase) New function.
7513 [unix] (shell) New function.
7514 (run_command) New function.
7515 (cmd_host) New function.
7516 (cmd_new_file) New function.
7518 * expr-prs.c: (parse_primary) Message fix.
7520 * inpt-pgm.c: Formatting fix.
7521 (cmd_reread) Implement the FILE subcommand.
7523 * matrix-data.c: New file.
7525 * q2c.c: (dump_header) Change output commenting style.
7527 * weight.c: Comment fix.
7529 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7531 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7533 (buf_10x) Renamed buf_1xx, all references changed.
7534 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7535 cases now implemented).
7536 (create_sysfile) New function.
7537 (agr_11x_func) New function.
7539 * data-in.c: (parse_numeric) Work properly if there's an
7540 explicitly coded decimal point in the data and decimal places are
7541 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7542 <el@linux.lisse.na>.
7544 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7545 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7546 Eberhard W Lisse <el@linux.lisse.na>.
7548 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7549 strerror.c. Bug reported by Alexandre Oliva
7550 <oliva@dcc.unicamp.br>.
7552 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7553 (static var separate_case_tab) New var.
7554 (cmd_sort_cases) Cancel temporary transformations here. Free
7555 v_sort before return.
7556 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7557 we're reading from a sort stream. Don't cancel temporary
7558 transformations. Offload internal sorting to do_internal_sort().
7559 (do_internal_sort) New function. Handles internal sorting even
7560 when SEPARATE is nonzero. Doesn't free v_sort.
7561 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7563 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7564 sink if SEPARATE is zero.
7565 (read_output_cases) Renamed read_sort_output(), all references
7566 changed. Now uses separate_case_tab when it exists.
7567 (write_separate) New function.
7569 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7570 memory_sink_cases. Don't redundantly call
7571 vfm_source->destroy_source().
7572 (memory_stream_mode) After switching over, set memory_sink_cases
7575 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7577 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7579 (static var prev_case) New, moved out of aggregate_single_case()
7581 (static var buf64_10x, buf_10x) New.
7582 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7583 the 000, 001, 100, and 101 cases. Free prev_case.
7584 (parse_aggregate_functions) Disallow scratch variables.
7585 (free_aggregate_functions) Only free agr_dict if non-null. Use
7586 iter->function to determine numeric/string type, not
7588 (aggregate_single_case) Don't manage prev_case. Initialize
7589 aggregate info after dumping it.
7590 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7591 mean, stddev, weighted stddev definitions.
7592 (dump_aggregate_info) Implemented.
7593 (initialize_aggregate_info) Renamed from
7594 initialize_aggregate_functions(). Initializes dbl[2].
7595 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7596 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7598 * cases.c: (alloc_val) Removed.
7600 * get.c: (cmd_save_internal) Initialize new `dict' member.
7602 * sfm-write.c: (sfm_write_dictionary, write_header,
7603 write_variable, write_value_labels, write_documents) Reorganize,
7604 simplify for new parameter structure.
7605 (write_variable) Only one variable * argument now.
7607 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7608 replaced by new `dict' member.
7610 * temporary.c: (new_dictionary) Initialize n_documents.
7612 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7614 (init_variable, replace_variable) Eliminate usage of alloc_val().
7616 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7618 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7619 signal that AGGREGATE is to be used for forming final cases.
7620 (close_active_file) Call end_func before stopping lagging. Cancel
7621 temporary after finishing compaction.
7622 (write_case) Comment fixes. Cleaned up.
7623 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7626 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7628 * Makefile.am: (BUILT_SOURCES) Add means.c.
7629 (pspp_SOURCES) Add means.c.
7630 (EXTRA_DIST) Add means.q.
7632 * command.c: (array cmd_table[]) Add MEANS.
7634 * common.h: Esthetic fixes. Comment fixes. Test for
7635 MAX_SHORT_STRING greater than 8.
7636 (macros LOWEST, HIGHEST) New.
7638 * data-in.c, data-list.c, recode.c: Comment fixes.
7640 * means.q: New file, base version.
7642 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7643 with LOWEST, DBL_MAX with HIGHEST.
7645 * q2c.c: (dump_vars) Add an enum to array types giving the number
7646 of values for the enum.
7648 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7649 Replace second_lowest_value with second_lowest_flt64.
7651 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7652 second_lowest_value with second_lowest_flt64.
7654 * t-test.q: Comment fix.
7656 * temporary.c: (restore_dictionary) Esthetic fix.
7658 * tokens.h: (force_match_id, force_match, force_string, force_int,
7659 force_num, force_id) Replace msg() with syntax_error().
7661 * var.h: (struct means_proc) New.
7662 (struct variable) Add mns member to `p' union.
7664 * vars-prs.c: (parse_variable, parse_dict_variable,
7665 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7668 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7670 * Makefile.am: (pspp_SOURCES) Add tab.h.
7672 * Most source files: Added a cast to unsigned char in usages of
7673 the ctype is*() functions. Replaced `end of command expected'
7674 calls to msg() with calls to syntax_error().
7676 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7678 * lexer.c: (hex_val) Removed (was dead code).
7679 (idmatch) Parenthesize function name to avoid macro expansion.
7681 * postscript.c: Comment fixes.
7682 (ps_preopen_driver) Change default font size to 10pt.
7684 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7686 (parse_format_spec) Change system-file format spec argument type
7687 to int32. Parse the format spec with bitwise operators.
7689 * sfmP.h: (struct sysfile_format) Removed.
7690 (struct sysfile_variable) Changed print, write members from
7691 sysfile_format to int32.
7693 * tokens.h: Esthetic fixes.
7694 [__GNUC__] (macro id_match) New macro to hopefully speed up
7695 identifier matching.
7696 (macros match_id, match_tok, match_int) Implemented in
7697 compiler-independent manner; no longer GNU C only.
7699 * vfm.h: Include time.h.
7701 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7703 * data-list.c: (dump_fixed_table) Change tab_dim().
7705 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7707 * error.c: Include command.h.
7709 * frequencies.g: Formatting fixes.
7711 * frequencies.q: Add tab_dim() calls. Make the total cell a
7714 * glob.c: Include command.h.
7716 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7718 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7719 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7720 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7721 the other elements (is this right?).
7722 (read_variables) Use lowest, highest members.
7723 (parse_format_spec) New arg `vv' for more stringent checking.
7724 (dump_dictionary) Byteswaps nonexplicit data.
7725 (sfm_read_case) Byteswap numeric data.
7727 * som.c: Initialize table_num to 1.
7728 (render_segments) Remember to increment y_index after each table
7731 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7732 avl_count() on a NULL tree. No title for the second table.
7733 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7734 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7735 fix call to display_variables().
7736 (display_variables) Default to 4 columns, not 3. Set up headers.
7737 Column title is Variable, not Name. Fix index column.
7738 Add joint text. Add tab_dim(). Handle value labels properly.
7739 Handle DISPLAY LABELS properly. Draw boxes correctly.
7740 (describe_variable) Value labels don't need titles. Don't clear
7741 nonexistent index column.
7742 (compare_vectors_by_name) New function.
7743 (display_vectors) New function.
7745 * tab.c: (tab_height) Add assertion.
7746 (tab_null) Add debug code.
7747 (evaluate_dimensions) Add debug code.
7749 * var.h: (struct variable) get_proc data is sometimes used
7750 simultaneously with other per-procedure info, therefore it was
7751 removed from the union. All references changed.
7753 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7755 * ascii.c: (ascii_close_page) Put title on second line of headers
7756 if there is no subtitle.
7758 * command.c: (glob var cur_proc) Move definition here, from
7760 (cmd_remark) Emit blank line before remarks.
7762 * command.h: (glob var cur_proc) Move declaration here, from
7765 * data-list.c: (dump_fixed_table) Fix messages.
7766 (dump_free_table) Call tab_nat_dim().
7768 * descript.q: (dump_z_table) Modify tab_dim() call.
7770 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7772 (dump_statistics) Don't output header.
7774 * groff-font.c: Minor format fix.
7776 * html.c: Comment fix.
7778 * list.q: (write_varname) Indent after advancing page.
7780 * output.h: Minor reordering.
7782 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7783 a reference to eol[].
7784 (struct ps_driver_ext) New member eol[].
7785 (ps_preopen_driver) Initialize eol[].
7786 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7787 defaults. Handle headers. Fix test for minimum page length.
7788 (static var option_tab[]) Add `line-ends'.
7789 (ps_option) Handle line-ends to change eol[].
7790 (postopen) Scale prop_em_width and fixed_width properly. Set the
7791 prologue title to outp_title if applicable. Replace the prologue
7792 line ends with eol[]. Call draw_headers() if headers are enabled.
7793 (text_width) New function.
7794 (out_text_plain) New function.
7795 (draw_headers) New function.
7797 * print.c: (dump_table) Call tab_nat_dim().
7799 * som.c: (som_blank_line) Only advance a line if not at the top of
7801 (som_submit) Move several informational table calls here.
7802 Increment subtable_num if SOMF_NO_TITLE not set.
7803 (output_table) Advance a line if SOMF_NO_SPACING not set.
7804 (render_columns, render_segments, render_simple) Handle spacing
7805 between tables. Handle table titles. Remove debug output.
7807 * som.h: (SOMF_*) New enum series.
7808 (struct som_table_class) New member `flags'.
7810 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7812 (display_variables) Calls tab_nat_dim().
7813 (describe_variable) Remove restriction on number of value labels.
7814 Make value labels separated by thin lines.
7816 * tab.c: (tab_create) Default `flags' to none.
7817 (tab_float) New arg `w'. All references changed.
7818 (tab_nat_dim) New function.
7819 (tab_output_text) No title or spacing.
7820 (tab_flags) New function.
7821 (tabi_flags) New function.
7822 (tabi_title) New function.
7823 (strip_height) Removed.
7824 (tabi_render) Skip title when necessary.
7825 (static var tab_tab_class) Add tabi_flags, tabi_title.
7826 (evaluate_dimensions) Disable display of column, row size.
7827 (sum_columns) Add title height to top header.
7828 (render_strip) Moved within file.
7830 * tab.h: (struct tab_table) New member `flags'.
7832 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
7834 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
7836 * Most source files: Add `const' attribute in all appropriate
7839 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
7840 column to the variables table for use by describe_variable().
7841 (cmd_display) Disable for the present.
7842 (display_documents) Don't wrap documents.
7843 (display_variables) Table has four columns now.
7844 (describe_variable) Table has four columns now. Don't use a
7845 subtable, use joined cells instead.
7847 * tab.c: (tab_create) Don't set `join'.
7848 (tab_realloc) ct array is not made up of a_string's.
7849 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
7850 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
7851 (text_format) New function.
7852 (tab_title) Rewritten, uses text_format().
7853 (tab_text) Rewritten, uses text_format().
7854 (tab_joint_text) New function.
7856 (static var hit) New variable.
7857 (render_strip) New args r1, r2. Implement joined cells that fit
7859 (tabi_render) Increment hit. Pass new args to render_strip().
7860 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
7861 cells. For t_naw and t_nah, ignore joined cells and null cells in
7864 * tab.h: (struct tab_join_rect) Removed.
7865 (struct tab_table) Removed `join'.
7866 (TAB_JOIN_MAIN) Removed.
7867 (struct tab_joined_cell) New struct.
7868 (TAT_NOWRAP) New enum.
7870 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
7872 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
7874 (ascii_postopen_driver) Fix initialization of *_spacing so that
7875 the TAL_0 bit doesn't count.
7877 * data-list.c: (dump_fixed_table) Use natural width for Format
7880 * glob.c: (rerange) Removed.
7881 (get_date) Formatting fixes. Internationalization fix.
7883 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
7886 * postscript.c: (ps_postopen_driver) Replace
7887 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
7889 * som.c: (som_submit) Don't eject page before every table.
7890 (output_table) Fix order of arguments on call to area().
7891 (render_columns) Fix calculation of max_len.
7893 * tab.c: (tabi_cumulate) Minor change to increase elegance.
7894 (render_strip) New function.
7895 (strip_height) New function.
7896 (tabi_render) Rewrite as calls to render_strip().
7898 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
7899 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
7900 with the TAB_* and OUTP_T_* constants.
7902 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
7904 * Makefile.am: Formatting fixes.
7906 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
7909 * data-list.c: (dump_fixed_table) Add tab_dim() call.
7911 * descript.q: (dump_z_table, display) Add tab_dim() calls.
7913 * dump-sysfile.c: (glob var length) Make type off_t.
7914 (usage) Fix arguments.
7917 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
7918 Now right-justification is the default so many references had to
7920 (struct outp_class) Removed line_width, all references changed.
7921 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
7922 (struct outp_driver) Add elements horiz_line_width,
7923 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
7926 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
7928 (postopen) Initialize all the informational members of
7931 * som.c: (som_blank_line) New function, renamed from blank_line(),
7932 all references changed.
7933 (som_submit) Disables drivers whose pages can't be opened.
7934 (render_columns, render_simple, render_segments) Add debug output.
7935 (render_columns) Fix loop range.
7936 (render_simple) Don't try to render the headers, they're taken
7937 care of automatically. Advance cp_y past the table when done.
7938 (render_segments) Fix loop ranges.
7940 * tab.c: Initialize new members of tab_table.
7941 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
7942 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
7943 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
7946 (tab_dim) New function.
7947 (tab_col_width) Removed.
7948 (tab_row_height) Removed.
7949 (tab_output_text) Call tab_dim().
7950 (tabi_driver) Call evaluate_dimensions(), sum_columns().
7951 (tabi_area) Implemented.
7952 (tabi_cumulate) Implemented.
7953 (tabi_render) Partially implemented, but broken.
7954 (var tab_table_class) Made static.
7955 (evaluate_dimensions) New function.
7956 (sum_columns) New function.
7958 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
7959 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
7960 t_scr, t_srr, t_sentinel. Removed: t_nat.
7961 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
7962 max_stack_height, w, h. Removed: ce, re.
7963 (macro blank_line) Removed.
7964 (glob var zero_length) Removed.
7966 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
7968 * Most source files: include some of the new include files broken
7971 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
7974 * aggregate.c: (glob var outfile) Make static.
7976 * command.c: (glob var pgm_state) Move here.
7978 * common.c: (glob vars endian, second_lowest_value, pgmname,
7979 finished, curdate, cur_proc, start_interactive, history_file) Move
7982 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
7984 * file-handle.q: (glob vars files, inline_file) Move here.
7986 * glob.c: Lost lots of glob vars, detailed in individual file
7988 (init_glob) set_printer, set_screen were obsolete, deleted.
7989 set_cprompt has fewer spaces because pspp has fewer letters than
7992 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
7993 (inp_nval) Made static.
7995 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
7996 tokstr_len, toklongstr, tokint) Move here.
7998 * misc.c: Lost several vars and functions.
8000 * set.q: (all the set_* variables) Move here.
8002 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8003 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8006 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8008 * tab.h: (enum series t_*) New enums.
8009 (struct tab_table) Use arena struct tag. New members ce, re.
8011 * tokens.h: Comment fixes.
8013 * var.h: Move lots of enums and variables and functions and
8014 structures to other files. Use and declare a lot more union and
8015 struct tags. Comment fixes.
8017 * vector.c: (glob vars vec, nvec) Move here.
8019 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8020 init_blanks, last_vfm_invocation) Move here.
8022 * cases.h: New file.
8023 (struct long_vec) Move here.
8024 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8027 * command.h: New file.
8028 (STATE_* enums) Move here.
8029 (glob var pgm_state) Move here.
8031 * format.c: New file.
8032 (glob var formats) Move here.
8033 (parse_format_specifier_name, fmt_to_string,
8034 check_input_specifier, check_output_specifier,
8035 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8038 * format.h: New file. Move functions now in format.c here.
8039 (FMT_* enums) Move here.
8040 (struct fmt_desc) Move here.
8041 (FCAT_* enums) Move here.
8042 (struct fmt_spec) Move here.
8043 (glob vars formats, fmt_parse_ignore_error) Move here.
8045 * inpt-pgm.h: New file.
8046 (INP_* enums) Move here, make #defines into enums.
8047 (glob vars inp_init, inp_init_size) Move here.
8050 (glob vars v_sort, nv_sort) Move here.
8051 (sort_cases, read_sort_output) Move here.
8053 * vector.h: New file.
8054 (struct vector) Move here, add struct tag.
8055 (glob vars vec, nvec) Move here.
8056 (find_vector) Move here.
8059 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8060 reinit_blanks, init_zero, init_blanks) Move here.
8061 (struct case_stream) Move here.
8062 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8063 vfm_disk_stream, sort_stream, data_list_source,
8064 input_program_source, file_type_source, get_source, n_lag) Move
8066 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8069 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8071 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8072 (LDADD) Add libdcdflib.
8074 * ascii.c: Comment and formatting fixes. Almost every external
8075 function had an assert added, checking driver_open and page_open.
8076 (ascii_init_driver) Broken into ascii_preopen_driver,
8077 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8078 (ascii_open_page) Sets page_open.
8079 (ascii_close_page) Clears page_open.
8081 * html.c: Comment and formatting fixes. Almost every external
8082 function had an assert added, checking driver_open and page_open.
8083 (html_init_driver) Broken into html_preopen_driver,
8084 html_postopen_driver, html_close_driver. Manages driver_open.
8085 (html_open_page) Sets page_open.
8086 (html_close_page) Clears page_open.
8087 (html_submit) Disabled.
8089 * lexer.c: (parse_string) Remove debugging printf.
8091 * list.q: (determine_layout) Open a page if one is not yet open.
8093 * output.c: Comment fixes.
8094 (add_class) Set the class member of the new list element.
8095 (parse_options) Don't handle device type.
8096 (colon_tokenize) New function.
8097 (configure_driver) New four-field format with a field for device
8098 type. Now initialize driver_open, page_open, next, and prev
8099 fields. Use new colon_tokenize() function. Don't do a memory
8100 copy to replace a driver, it doesn't work; instead delete the old
8101 driver and insert a new one.
8102 (destroy_driver) Don't call som_destroy_driver(). Close the page
8103 if it's open. Find the class in the list of classes and decrement
8104 that reference count. Remove the driver from the global driver
8106 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8107 references changed. Rewritten. Don't return a driver that's not
8109 (outp_eject_page) All references to som_internal_eject_page()
8110 changed to use this. Sets cp_x to 0 as well as cp_y.
8112 * output.h: (OUTP_I_* enums) Removed.
8113 (struct som_submission_form) Removed.
8114 (struct outp_class) init_driver broken into preopen_driver,
8115 postopen_driver, and close_driver. submit changed to take a
8118 * postscript.c: Comment and formatting fixes. Almost every
8119 external function had an assert added, checking driver_open and
8121 (ps_init_driver) Broken into ps_preopen_driver,
8122 ps_postopen_driver, ps_close_driver. Manages driver_open.
8123 (ps_open_page) Sets page_open.
8124 (ps_close_page) Clears page_open.
8126 * som.c: New file, base implementation.
8128 * som.h: (struct som_table) Add struct tag.
8129 (enum SOM_COL_ACROSS) Removed.
8130 (SOM_ROWS, SOM_COLUMNS) New enums.
8131 (struct som_table_class) Add member `cumulate'. Remove `segment';
8132 change `render' arguments.
8133 (struct som_point, struct som_rect) Removed.
8134 (som_submit_table) Fixed typo, should have been som_submit.
8136 * sysfile-info: (describe_variable) Don't try to insert a
8137 subtable; just destroy it for now.
8139 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8140 references to value labels.
8142 * tab.c: (tab_destroy) New function.
8143 (tab_columns) Change argument.
8144 [0] (tab_submit) Remove dead code.
8145 (tab_title) Allocate string from the table's arena.
8146 (tab_output_text) Only free the buffer if we allocated it.
8147 (tab_submit) New function.
8148 (static vars t, d) New static vars.
8149 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8150 tabi_headers, tabi_cumulate, tabi_render) New functions.
8151 (glob var tab_table_class) New global var.
8153 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8154 encapsulate the rectangle. All references changed.
8156 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8158 * All header files updated to use struct tags in addition to
8159 typedefs for all structures. Don't use word `struct' in struct
8162 * Makefile.am: (pspp_SOURCES) Remove html.c.
8163 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8164 all references updated.
8166 * command.c: (parse_cmd) Remove call to som_check_workspace.
8167 (output_line) Update to new som.
8169 * data-in.c: (parse_numeric) A single dot is not an error; it is
8170 the system-missing value.
8172 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8175 * data-out.c: Added `const' as appropriate to many prototypes.
8176 (convert_E, convert_F, convert_CCx) Take double argument instead
8177 of value * argument.
8178 (convert_format_to_string) Call changed functions appropriately.
8179 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8180 make a local copy of the value.
8182 * descript.q: Remove custom_variables() prototype now provided by
8184 (custom_variables) Don't increment sbc_variables, the caller does
8186 (dump_z_table, display) Update to new som.
8188 * error.c: (vmsg) Add const to prototype. Remove code to handle
8189 `too many errors' condition.
8190 (check_error_count) New function.
8191 (msg) Add const to prototype.
8193 * filename.c: (open_file) Rewrite for elegance.
8195 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8196 (dump_full, dump_condensed, dump_statistics) Update for new som.
8198 * list.q: Don't include somP.h. Change all references to
8199 som_driver_ext to refer to the new members of som_driver. Change
8200 som_internal_eject_page() references to outp_eject_page().
8202 * main.c: (parse) Rewrite for elegance. Add call to
8203 check_error_count().
8205 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8206 Rewrite or revise for new outp_driver_class_list structure.
8207 (outp_iterate_enabled_drivers) Fix comparison between disabled
8208 devices and current device type.
8209 (outp_eject_page) New function.
8211 * output.h: Comment fixes.
8212 (struct outp_driver) New members driver_open, page_open, cp_x,
8213 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8215 (struct outp_driver_class_list) New struct.
8216 (outp_class_list) Changed to type outp_driver_class_list; all
8219 * print.c: (dump_table, print_trns_proc) Updated for new som.
8221 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8222 prototypes for custom subcommands.
8223 (dump_subcommand) Always include the `else'.
8224 (dump_parser) Fix comments in output code.
8226 * set.q: Reordered functions.
8228 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8230 * som.h: Rewritten from scratch.
8232 * str.h: Remove dead code.
8234 * tab.c, tab.h: New files, base implementation.
8236 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8239 * t-test.q: New code from John Williams
8240 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8241 Many many new static vars and defines.
8242 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8243 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8244 (struct value_list) New struct.
8245 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8246 t_crt, t_sig, print_t_groups) New functions.
8247 (cmd_t_test) Implemented.
8249 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8252 * vfm.c: (dump_splits) Update to new som.
8254 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8256 * Makefile.am: (fiasco_SOURCES) Add html.c.
8258 * aggregate.c: Base source.
8260 * ascii.c: (postopen, preclose) Reformat.
8262 * data-out.c, expr-evl.c: Comment fixes.
8264 * filename.c: (open_file) When opening a file for writing, use
8265 line buffering instead of full buffering for better interactive
8266 performance. Suggested by Valerio Aimale
8267 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8268 names `stdin', `stdout', `stderr'.
8270 * groff-font.c: Comment fixes.
8272 * html.c: New file; base version.
8274 * list.q: (write_all_headers, clean_up, determine_layout,
8275 list_cases) Ignore `special' devices for now. Needs to be fixed
8278 * output.c: (outp_init) Add html driver to list; reverse list
8281 * output.h: (struct outp_class_struct) New members `special',
8282 `submit'; comment fixes. All references changed.
8284 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8285 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8287 (postopen) Comment fix.
8288 (preclose) Comment fixes, formatting fixes. Change x->file.file
8289 references to more proper f->file.
8291 * som-high.c: (som_submit_table) Special classes use their own
8294 * som.h: Comment fixes.
8296 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8299 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8301 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8303 * aggregate.c: Still working on this.
8305 * command.c: (cmd_table[]) Add AGGREGATE back in.
8306 (split_words) Make '-' a legal word separator as well as ' '.
8308 * main.c: Comment fixes.
8310 * q2c.c: (dump_parser) Don't require the procedure's full name to
8311 be present, in the generated source.
8313 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8314 multiply specified and let it be default; let MISSING, CRITERIA,
8315 FORMAT be multiply specified.
8316 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8317 (custom_groups) Fix defaults.
8318 (custom_pairs) Check whether this is a PAIRS subcommand before
8319 attempting to parse. Better garbage collection. Proper storage
8321 [DEBUGGING] (debug_print) New function.
8323 * temporary.c: Comment fixes.
8324 (copy_variable) Don't copy variable name and index.
8325 (save_dictionary) Copy variable name and index by hand.
8327 * vars-atr.c: Comment fixes.
8328 (create_variable) New dictionary argument. All references
8330 (common_init_stuff) New dictionary argument. All references
8332 (init_variable) New dictionary argument. All references changed.
8333 (dup_variable) New function.
8335 * vars-prs.c: (parse_variables) If there are any errors, we always
8336 return 0. Previously, it was possible for some types of errors to
8339 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8341 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8344 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8346 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8349 * q2c.c: Comment fixes.
8350 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8352 * t-test.q: (cmd_list) Rename cmd_t_test.
8354 * temporary.c: (new_dictionary) Don't declare as static.
8356 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8358 * aggregate.c: Changes, still not finished.
8360 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8362 * q2c.c: Comment fixes. Now its output is internationalized.
8363 (get_token) Fix parsing of escapes within literal strings.
8364 (main) Fix bad #line directives in output.
8366 * t-test.q: Base implementation.
8368 * temporary.c: (new_dictionary) New function.
8369 (restore_dictionary) [__CHECKER__] Change fill character to *
8372 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8374 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8376 * aggregate.c: Changes, still not finished.
8378 * descript.q, list.q: Comment fixes.
8380 * q2c.c: Almost completely rewritten.
8382 * t-test.q: New file, not complete.
8384 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8386 * aggregate.c: Changes, still not finished.
8388 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8391 * temporary.c: (cancel_temporary) New function.
8393 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8394 of doing it by hand.
8396 * vfm.c: (close_active_file) After restoring a TEMPORARY
8397 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8399 (SPLIT_FILE_procfunc) Comment fix.
8401 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8403 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8405 * aggregate.c: New file, not finished yet.
8407 * command.c: (cmd_table) Add AGGREGATE.
8409 * common.h: (pgm_state) Move declaration to var.h.
8411 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8413 (parse_string) Message fix.
8415 * recode.c: Comment fix.
8417 * sfm-read.c: (read_variables) Code esthetic fixes.
8418 (write_header) Default date is `Jan', not `JAN'.
8420 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8422 * sort.c: (cmd_sort_cases) Farm the work out to new function
8423 parse_sort_variables().
8424 (parse_sort_variables) New function.
8425 (sort_cases) New function. Cancels temporary transformations,
8426 which sorting didn't do previously.
8427 (cmd_sort_cases) Better garbage collection on error. Uses
8429 (write_initial_runs, merge_once) Improved code esthetics.
8430 (sort_stream_read) Reduced to one call to read_output_cases().
8431 (read_output_cases) New function.
8433 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8434 variable labels to 120 characters.
8436 * var.h: Comment fixes.
8437 (glob var pgm_state) From common.h.
8439 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8441 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8442 options. Set *names to NULL on error.
8444 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8446 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8448 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8449 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8451 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8453 * vfm.c: (page_to_disk) Added missing local variables.
8455 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8457 * get.c: Comment fix.
8459 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8460 source is anything other than a disk stream, not just if it's in a
8461 memory stream. Call page_to_disk() before external sort.
8462 (allocate_cases) Message fix.
8464 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8466 (page_to_disk) New function.
8468 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8470 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8472 * common.h: (macro strerror) Remove. From Alexandre Oliva
8473 <oliva@dcc.unicamp.br>.
8475 * get.c: (dict_delete_run) The number of variables to delete is
8476 not necessarily the number of variables that need to be shifted
8478 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8479 too many variables to be deleted.
8481 * postscript.c: Comment fix.
8483 * q2c.c: Include strerror.c. From Alexandre Oliva
8484 <oliva@dcc.unicamp.br>.
8486 * set.q: #undef ON and OFF. From Alexandre Oliva
8487 <oliva@dcc.unicamp.br>.
8489 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8490 early, otherwise errors cause a bad free().
8492 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8493 Oliva <oliva@dcc.unicamp.br>.
8495 * temporary.c: (save_dictionary) Don't allocate memory if
8498 * vfm.c: (memory_stream_write) Message fix.
8500 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8502 * command.c: (static var cmd_table[]) Define REPEATING DATA
8505 * common.h: Added support for broken systems that are missing
8506 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8508 * Many source files: Replace syntax error messages via msg() with
8509 call to syntax_error().
8511 * data-list.c: (dump_fixed_table) Add support for dumping table
8512 for REPEATING DATA as well as DATA LIST FIXED.
8513 (cmd_repeating_data) Allows and requires `/' between subcommands.
8514 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8515 CONTINUED specifications to be omitted. Forces CONTINUED to be
8516 specified if ID is. Calculates starts_end, cont_end from logical
8517 record length as reported by fhp. Calls dump_fixed_table() if
8518 requested. Fixed length of record copied by memcpy.
8519 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8521 (realize_value) Returns sensible value for out-of-range variable
8523 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8524 length of occurrences and length of line. Added warning for
8525 fields that exceed the line length. Fixed infinite loop.
8526 (read_one_set_of_repetitions) Numerous minor changes for more
8527 complete SPSS compliance. Message fixes.
8529 * dfm.c: (dfm_close) If the file being closed is the inline file,
8530 read all the remaining data before closing it.
8531 (dfm_get_record) Don't close the file on lossage, as either it
8532 has been closed already or it doesn't belong to us.
8534 * error.c: (puts_stdout) New function.
8535 (vmsg) Use puts_stdout instead of puts.
8537 * file-handle.q: (fh_record_width) New function.
8539 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8542 (input_program_source_read) Made an old kluge an approved method.
8544 * lexer.c: (syntax_error) New function.
8546 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8549 * output.c: (oupt_get_paper_size) Message fix.
8551 * q2c.c: Numerous fixes to formatting of generated code made to
8552 conform to GNU coding standards. Uses syntax_error() in generated
8553 code. Other miscellaneous generated message fixes. Added support
8554 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8555 RAND_MAX, and/or strerror().
8557 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8559 * data-in.c: Comment fixes.
8561 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8562 (find_variable_input_spec) New function.
8563 (cmd_repeating_data) Initializes id_spec.
8564 (rpd_parse_record) Implemented.
8565 (read_one_set_of_repetitions) Returns -3 by default in order to
8566 kluge out some potential bugs.
8568 * data-out.c: Comment fixes.
8570 * file-type.c: (internal_cmd_record_type) Message fix.
8572 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8573 for handling -3 return value.
8575 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8577 * data-list.c: Comment fixes.
8578 (struct dls_var_spec) Reordered members.
8579 (read_from_data_list_fixed) Restructured.
8580 (struct repeating_data_trns) Reordered members. Renamed `starts'
8581 as `starts_beg', `ends' as `starts_end'.
8582 (cmd_repeating_data) Calculates length of repeated data if
8583 necessary and possible.
8584 (parse_num_or_var) Don't allow string variables.
8585 (realize_value) New function.
8586 (rpd_msg) New function.
8587 (rpd_parse_record) New function. Currently stubbed out.
8588 (read_one_set_of_repetitions) Implemented.
8590 * inpt-pgm.c: (input_program_source_read) Comment fix.
8592 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8594 * command.c: (cmd_end_repeat_p) Removed.
8595 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8596 (parse_cmd_name) Removed.
8598 * data-list.c: Comment fixes.
8599 (data_list_pgm) Removed `eof' member.
8600 (static var first) New var.
8601 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8602 FILE TYPE file inside FILE TYPE structures.
8603 (append_var_spec) Appends to *first, not dls.spec.
8604 (parse_fixed) Message fixes.
8605 (struct rpd_num_or_var) New.
8606 (struct repeating_data_trns) New.
8607 (static var rpd) New.
8608 (cmd_repeating_data) New function.
8609 (parse_num_or_var) New function.
8610 (parse_repeating_data) New function.
8611 (read_one_set_of_repetitions) New function.
8613 * file-type.c: (cmd_file_type) Message fixes. Always
8614 default_handle to FILE TYPE file handle.
8615 (internal_cmd_record_type) Message fixes.
8617 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8619 * repeat.c: Comment fix. Disable debugging.
8621 * temporary.c: (restore_dictionary) Sets splits to NULL and
8622 n_splits to 0 before destroying the variables because now doing
8623 this tries to remove split variables.
8625 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8626 destroying the dictionary.
8627 (clear_variable) Removes a variable from splits after destroying
8630 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8632 * cmdline.c: (set_compat) Removed.
8633 (pick_compat) Removed.
8634 (parse_command_line) Removed -c option.
8635 (pre_syntax_message) Removed -c option.
8636 (usage) Remove compatibility code.
8638 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8639 (glob var compat) Removed.
8641 * compute.c: (type_check) Fixed messages about type mismatches.
8643 * data-list.c: (cmd_data_list) Removed compatibility code.
8644 (fixed_parse_compatible) Calls convert_negative_to_dash().
8645 Fixed bug where it only set the variable in fx.spec if it created
8646 the variable itself.
8647 (dump_fmt_list) Spelling fix.
8648 (cut_field) Removed compatibility code.
8650 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8653 * expr-evl.c: (evaluate_expression) Implement LAG.
8655 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8656 (parse_neg) Calls convert_negative_to_dash().
8657 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8660 * expr.h: (struct expression_struct) Removed member max_lag.
8662 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8663 (internal_cmd_record_type) Removed special handling to produce
8664 negative numbers from dash tokens.
8666 * getline.c: (static var DO_REPEAT_level) New var.
8667 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8668 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8669 copy_with_DO_REPEAT_substitutions().
8670 (getl_read_line) Maintains value of getl_mode. Calls
8671 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8673 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8675 * getline.h: (getl_mode) New glob var.
8677 * glob.c: Comment fixes.
8678 (init_glob) Restructured. Sets set_seed.
8679 (init_compat_dependent) Removed. All references removed.
8680 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8681 (__htonl, __htons) Removed. (What were these for?)
8683 * lexer.c: (static var tbl) Dash set to class CNUM.
8684 (make_hexit) New function from data-out.c.
8685 (get_token_representation) Rewritten.
8686 (convert_negative_to_dash) New function.
8687 (lex_init_compat_dependent) Removed.
8688 (yylex) A dash is parsed as part of a number if it is followed by
8689 a digit. The ASCII representation of a number is copied to
8690 tokstr. String parsing farmed out to parse_string(). Comment
8692 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8694 (preprocess_line) Line processing depends on interactive/batch
8695 mode, not on compatibility mode. Removed PC+ compatibility code.
8697 * loop.c: (loop_3_trns_proc) Comment fix.
8699 * main.c: Remove dead code.
8700 (main) Remove call to init_compat_dependent().
8702 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8705 * print.c: (parse_string_argument) Calls
8706 convert_negative_to_dash().
8707 (fixed_parse_compatible) Calls convert_negative_to_dash().
8709 * repeat.c: (RPT_* defines) Removed.
8710 (struct rpt_numeric) Removed.
8711 (struct repeat_entry) New member type, changed `replacement' from
8713 (clean_up) Deallocation adapted to new repeat_entry.
8714 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8715 usage. Creates vars for `type' of 1.
8716 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8717 (store_numeric) Rewritten, new interface.
8718 (parse_numbers) Rewritten.
8719 (parse_strings) Rewritten.
8720 (find_DO_REPEAT_substitution) New function.
8721 (perform_DO_REPEAT_substitutions) New function.
8722 (copy_with_DO_REPEAT_substitutions) Removed.
8723 (debug_print) Rewritten.
8725 * set.q: Comment fix.
8726 (custom_results) Removed compatibility code.
8727 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8730 * sysfile-info.c: (cmd_display) Removed compatibility code.
8732 * tokens.h: Comment fixes.
8733 (token types enum) Removed `toktype' typedef name for this int
8734 type. Removed SUBST. Restructured.
8736 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8738 * vars-prs.c: Comment fix.
8740 * vfm.c: Comment fixes.
8741 (glob var n_lag) New var.
8742 (static vars lag_count, lag_head, lag_queue) New vars.
8743 (procedure) Removed argument nlag.
8744 (setup_lag) New function.
8745 (close_active_file) Discards lagging state.
8746 (lag_case) New function.
8747 (lagged_case) New function.
8748 (write_case) Lags a case if lagging.
8750 * weight.c: (cmd_weight) Removed compatibility code.
8752 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8754 * getline.h: (struct getl_script) New members loop_index, macros.
8756 * getline.c: (getl_add_file) Sets first_line field to NULL.
8757 (getl_add_DO_REPEAT_file) New function.
8758 (handle_line_buffer) When the current line's length is negative,
8759 set the filename and line number. Increment line number after
8760 reading line. Pass the line to
8761 copy_with_DO_REPEAT_substitutions() for processing.
8762 (getl_close_file) Free DO REPEAT lines before freeing the
8763 filename, and just set the filename to NULL when doing this,
8764 because otherwise the filename gets freed twice.
8766 * glob.c: (glob var queuing) Removed. All references removed.
8768 * lexer.c: Comment fixes.
8769 (get_token_representation) New function.
8771 * repeat.c: Comment fixes.
8772 (struct repeat_entry) Replaced type and v union members with a
8774 (append_record) New function.
8775 (internal_cmd_do_repeat) Started reforming it for the new
8776 repeat_entry struct. Properly records filename changes in the
8777 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8778 strncasecmp() result usage. Uses append_record() to simplify.
8779 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8782 (copy_with_DO_REPEAT_substitutions) Started coding.
8784 [DEBUGGING] (debug_print_lines) New function.
8786 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8788 * tokens.h: (macro is_id1, is_idn) New macros.
8790 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8792 * cmdline.c: (static var pre_syntax_message) Changed `win'
8793 compatibility mode to `wnd'.
8795 * data-list.c: (fixed_parse_spss) Renamed
8796 fixed_parse_compatible().
8798 * glob.c: (init_glob) Excise unused code for
8799 program_invocation_short_name.
8801 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8804 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8806 * set.q: `win' compatibility renamed `wnd'.
8808 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8810 * filename.c: [__WIN32__] Change the included Windows header files
8812 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8813 second character is absolute.
8814 (dirname) Fix logic error. Don't printf() the results.
8815 (prepend_dir) Don't printf() the results.
8817 * getline.c: (handle_line_buffer) New function.
8818 (getl_read_line) Reads line with handle_line_buffer() when
8820 (getl_close_file) Discard line buffer data.
8822 * getline.h: Comment fixes.
8823 (struct getl_line_list) New struct.
8824 (getl_script_struct) Added line buffer members. These are hooks
8825 for use by DO REPEAT to allow it to insert virtual source code
8828 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
8829 Override Borland C++ stupidity that claims Windows has a console
8832 * repeat.c: This is in the process of being restructured from
8833 using a token-buffering approach to the DO REPEAT facility to
8834 using the more flexible approach of a line-buffering approach in
8835 conjunction with the getline module. Comment fixes.
8836 (struct tok_struct) Removed.
8837 (static vars queue_index, queue_head, queue) Removed.
8838 (static vars line_buf_head, line_buf_tail) New vars.
8839 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
8841 (pull_queue, destroy_queue) Removed.
8842 [DEBUGGING] (debug_print_tokens) Removed.
8844 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
8846 * file-handle.q: (prepend_current_directory) New function.
8847 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
8848 current directory before normalizing filename.
8850 * filename.c: (gnu_getcwd) New function.
8851 (absolute_filename_p) New function.
8852 (search_path) New argument, PREPEND. All references changed to
8853 pass NULL except those explicitly mentioned. Uses
8854 absolute_filename_p(). Prepends PREPEND before trying the
8856 (dirname, prepend_dir) New functions.
8858 * getline.c: (getl_get_current_directory) New function.
8859 (getl_include) Passes getl_get_current_directory() as PREPEND arg
8862 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
8864 * In several source files, the term `script' was replaced with
8865 `syntax file' inside error messages. Usage of the term `script'
8866 in the sense of a syntax file is now deprecated.
8868 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
8871 * dump-sysfile.c: (usage) Update message.
8873 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
8875 * getline.h: (glob var getl_include_path) Declare extern.
8877 * list.q: Define EXTERN as extern before #including somP.h.
8879 * var.h: Remove declaration of `disptype' variable.
8881 * vfm.c: (close_active_file) After switching the data sink to a
8882 data source, set vfm_sink to NULL, because it doesn't exist any
8885 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
8887 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
8888 _matherrl() to ignore all math errors.
8890 * sfm-read.c: (read_value_labels) When reading the labels from
8891 disk, read the little parts separately instead of as a struct;
8892 this avoids alignment problems.
8894 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
8895 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
8896 (write_header) Allocates and initializes elem_type.
8897 (sfm_write_case) Uses elem_type to determine how to handle each
8899 (sfm_close) Frees elem_type.
8901 * sfmP.h: Comment fix.
8902 [__BORLANDC__] Uses #pragma -a to adjust structure member
8905 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
8907 * Makefile.am: (fiasco_SOURCES) Remove display.c.
8909 * common.c: Fix typo.
8911 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
8912 sense of the condition.
8914 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
8915 line-continuation backslash.
8917 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
8919 * frequencies.q: (custom_grouped, add_percentile) Don't use a
8920 non-constant expression as an argument to sizeof.
8922 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
8923 undefine gettext macro because that's a conio function.
8925 * hash.h: (hsh_prime_tab declaration) Remove.
8927 * list.q: (write_fallback_headers) Move `leader' allocation out of
8928 main loop. Change to local_alloc() allocation.
8930 * output.h: Formatting fixes. Put __attribute__ in right place on
8931 function prototypes.
8933 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
8934 incorrect `SECOND_LOWEST_VALUE' references to proper
8935 `second_lowest_value'.
8937 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
8938 value. This way 2 out of 3 of the som files define the vars
8939 extern, the correct way, that actually works under BC++.
8940 (som_set_float) Don't use nonconstant initializers for a struct.
8942 * som-high.c: Add the standard alloca() header.
8943 (replicate_table) Add prototype.
8945 Merged DISPLAY routine.
8946 * sysfile-info.c: (AS_*) New enum series.
8947 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
8949 (cmd_display, display_macros, display_documents,
8950 display_variables) Stolen from defunct display.c.
8951 (describe_variable) New function.
8953 * temporary.c: [0] (display_tree) New debug function.
8954 (copy_variable) Performs shallow copy of value labels instead of
8955 deep copy; i.e., just copys the AVL tree and increments the
8958 * val-labs.c: Comment fixes.
8959 (do_value_labels) Optionally skip leading forward slash.
8960 (get_label) Creates only a single value label instead of many
8961 copies of one, and sets the reference count.
8963 * display.c: Removed.
8965 * dump-sysfile.c: New file, not yet complete.
8967 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
8969 For lots of source files I added more verbose_msg's. These aren't
8970 listed below as they have tested as being benign. In some cases
8971 these replaced debug_printf() calls.
8973 * output.c: (outp_read_devices) Message fix.
8975 * postscript.c: (output_encodings) Message fix. Reports errors on
8977 (postopen) Message fix.
8979 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
8981 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
8983 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
8986 * main.c: Remove <malloc.h> #include.
8988 * mis-val.c: (parse_numeric) Set .f member for each missing[]
8989 instead of trying to just set the missing[] itself, which is a
8992 * sfm-read.c: (read_variables) Same.
8994 * str.h: Add memmem() prototype.
8996 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
8998 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9000 * Makefile.am: (q2c) Don't include any libraries in the link.
9002 * dfm.c: (force_line_buffer_extension) New macro.
9003 (count_tabs) New function.
9004 (tabs_To_spaces) New function.
9005 (read_record) Calls tabs_to_spaces() on the line being processed.
9007 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9008 have to be compiled twice (once for CC, once for LOCAL_CC).
9010 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9012 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9013 (LDADD) Add @INTLLIBS@.
9014 (q2c) Add LIBS, @INTLLIBS@ to link step.
9016 * inpt-pgm.c: Turn off debugging.
9018 * postscript.c: (postopen) Format fix. local_free() blocks
9019 returned by local_alloc(); don't free() them.
9021 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9023 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9026 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9027 LEN arg, not simply the full string length.
9029 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9030 directories before generic temp file directories.
9032 * vfm.c: Disable debugging.
9034 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9036 * get.c: Comment fix.
9037 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9039 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9041 * expr-prs.c: (debug_print_postfix) Conditionally included on
9042 GLOBAL_DEBUGGING. Removed out_header() reference.
9044 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9046 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9048 * ascii.c: Removed obsolete ascii_close_page() prototype.
9050 * command.c: (output_line) Comment fix.
9052 * data-in.c: Formatting fix.
9053 (parse_string_as_format) Now the `fc' argument is used only for
9054 the purpose of error messages; it is not an index into the string
9055 passed. All references changed.
9057 * data-list.c: Comment fix.
9058 (cut_field) Comment fix. Now returns the column number of the
9059 position of the field cut out on success.
9060 (parse_field) Added `column' argument. Puts the column numbers in
9062 (read_from_data_list_free, read_from_data_list_list) Record the
9063 column number returned by cut_field(), pass it to parse_field().
9065 * dfm.c: Comment fix.
9067 * do-ifP.h: Comment fix.
9069 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9070 the SYSMIS function.
9072 * expr.h, exprP.h: Comment fix.
9074 * glob.c: (init_glob) Only calls setlocale() and family if
9077 * hash.h: Comment fix.
9079 * include.c: Comment fix.
9081 * output.c: Comment fix.
9083 * postscript.c: (ps_line_intersection) Simplified assertion.
9085 * repeat.c: Comment fix.
9087 * vars-atr.c: Comment fix.
9089 * vars-prs.c: Comment fix.
9091 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9092 behavior with usage of postincrement.
9093 (memory_stream_read) Discards cases as it goes.
9095 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9097 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9100 * Most source files: Includes debug-print.h, related comment
9103 * cases.c: (alloc_val) Removed complex allocation code. Merely
9104 increments default_dict.nval and returns the former value.
9105 (envector, devector) Removed references to lv member of struct
9108 * common.h: (macro VME) Replaced complex definition with simple
9111 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9112 read_active_file and cancel_input_pgm.
9113 (read_from_data_list, cancel_data_list) Removed.
9114 (data_list_source_read, data_list_source_destroy_source) New
9116 (glob var data_list_source) New var.
9118 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9119 (cmd_begin_data) Improved criteria for an input program accessing
9120 the inline file. Still not perfect.
9122 * do-if.c: (do_if_trns_proc) Simplified debug output.
9124 * expr-prs.c: Comment fixes.
9125 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9127 * file-handle.q: (fh_close_handle) Simplified debug output.
9129 * file-type.c: Comment fixes.
9130 (cmd_file_type) Sets vfm_source instead of read_active_file and
9132 (cmd_end_file_type) On failure, discards variables in place of
9133 just canceling the input program.
9134 (read_from_file_type) Renamed file_type_source_read.
9135 (cancel_file_type) Renamed file_type_source_destroy_source.
9136 (glob var file_type_source) New var.
9138 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9139 (cmd_get) Initializes options to GTSV_NONE before passing to
9140 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9141 instead of read_active_file and cancel_input_pgm.
9142 (cmd_save_internal) Initializes options before passing to
9143 trim_dictionary(). Local var `nval' removed.
9144 (dict_delete_run) Comment fixes.
9145 (trim_dictionary) Comment fixes. Disallows scratch variables if
9146 GTSV_OPT_SAVE set in options.
9147 (read_from_get) Renamed get_source_read.
9148 (cancel_get) Renamed get_source_destroy_source.
9149 (glob var get_source) New var.
9151 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9152 read_active_file and cancel_input_pgm.
9153 (read_from_input_program) Renamed input_program_source_read.
9154 Simplified debug output.
9155 (cancel_input_program) Renamed
9156 input_program_source_destroy_source.
9157 (glob var input_program_source) New var.
9159 * loop.c: (loop_1_trns_proc) Simplified debug output.
9161 * main.c: (dump_token) Made eof output more explicit.
9163 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9166 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9167 code for always-memory or always-disk cases. malloc's case-list
9168 based on vfm_source_info.ncases. Explicit support for
9169 memory_stream via memory_source_cases.
9170 (do_external_sort) Sets vfm_source instead of read_active_file and
9172 (allocate_file_handles) The temporary directory permissions are
9173 set to 0700 instead of 0777.
9174 (allocate_cases) Formatting fixes. Simplified debug output.
9175 (output_record) Compacts the case if necessary before writing it
9177 (close_handle, open_handle_w) Simplified debug output.
9178 (write_initial_runs) Destroys vfm_sink, then sets it to
9179 sort_stream. Writes records to memory based on
9180 vfm_sink_info.case_size.
9181 (write_to_sort_cases) Renamed sort_stream_write().
9182 (merge) Simplified error handling. Simplified debug output.
9184 (read_from_external_sort) Renamed sort_stream_read().
9185 Reads records based on vfm_source_info.case_size.
9186 (sort_stream_write) Writes records to memory based on
9187 vfm_sink_info.case_size.
9188 (sort_stream_mode) New function.
9189 (glob var sort_stream) New variable.
9191 * temporary.c: (cmd_temporary) Simplified debug output.
9192 (copy_variable) Removed references to `lv'.
9194 * title.c: (get_title) Simplified debug output.
9196 * var.h: Comment fixes.
9197 (struct get_proc) Removed member `lv'.
9198 (struct variable) Removed member `lv'. Comment fixes.
9199 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9201 (struct case_stream) New.
9203 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9204 read_active_file references to use vfm_source.
9205 (init_variable, replace_variable) Removed references to `lv'.
9207 * vfm.c: Comment fixes.
9208 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9210 (static var queue, qh, qt, n_lag) Removed. All references
9212 (glob var compaction_necessary, compaction_nval, compaction_case,
9213 paging) New variables.
9214 (record_case) Removed.
9215 (procedure) Comment fixes. Calls vfm_source->read() instead of
9218 (prepare_for_writing, arrange_compaction, make_temp_case,
9219 vector_initialization, setup_filter) New function.
9220 (open_active_file) Most of the code moved into the abovementioned
9221 new functions. Now sets temp_dict to &default_dict if there is no
9222 temporary dictionary, for convenience. New debug output.
9223 (close_active_file) Deals with changing the sink to the source.
9224 Calls finish_compaction(). Frees compaction_case. Mostly
9226 (glob vars disk_source_file, disk_sink_file) New vars.
9227 (destroy_active_file, read_from_memory) Removed.
9228 (disk_stream_init, disk_stream_read, disk_stream_write,
9229 disk_stream_mode, disk_stream_destroy_source,
9230 disk_stream_destroy_sink) New functions.
9231 (glob var vfm_disk_stream) New var.
9232 (glob vars memory_source_cases, memory_sink_cases,
9233 memory_sink_iter, memory_sink_max_cases) New vars.
9234 (memory_stream_init, memory_stream_read, memory_stream_write,
9235 memory_stream_mode, memory_stream_destroy_source,
9236 memory_stream_destroy_sink) New functions.
9237 (glob var vfm_memory_stream) New var.
9238 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9239 named `more_cases'. Simplified debug output. Otherwise mostly
9241 (record_case) Moved into the stream drivers. Removed.
9242 (transform) Removed (was dead code).
9243 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9244 common case that the splits don't change, we don't need to copy
9245 the case into prev_case again--pointless.
9246 (compact_case) New function.
9247 (finish_compaction) New function.
9249 * vfmP.h: Comment fixes.
9250 (DEV_* enum series) Removed.
9251 (struct storage) Renamed `stream_info'. Removed variant record.
9252 Removed `device' member.
9254 * debug-print.h: New file.
9256 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9258 * autorecode.c: Turned off debugging.
9260 * data-list.c: (destroy_dls) Closes the associated file handle.
9262 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9263 parse_variables() options.
9265 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9267 * display.c: (display_variables) Really fixed null cell bug.
9269 * file-handle.q: (fh_close_handle) Changed debugging message.
9271 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9272 parse_variables() options.
9274 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9275 (cmd_list) Fails if no variables specified.
9276 (determine_layout) Writes blank lines manually.
9278 * loop.c: (loop_1_trns_proc) Made debugging code only print
9279 messages if debugging.
9281 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9282 parse_variables() arguments.
9283 (main) Parses optional parenthesized options to varlist
9284 subcommands into sbc->message.
9286 * sfm-read.c: Format fix.
9288 * var.h: (FV_*) New enum series.
9289 (PV_*) New enum PV_NO_SCRATCH.
9291 * vars-prs.c: (find_var) Removed.
9292 (fill_all_vars) Takes FV_* enum instead of boolean third
9293 argument. Rewritten to deal with scratch as well as system
9295 (parse_variables) Error message on scratch variable if
9298 * vfm.c: (static var virt_begin_func) New var.
9299 (procedure) Sets up virt_begin_func.
9300 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9301 after dump_splits(). For succeeding groups changes, calls
9302 virt_begin_func() instead of begin_func().
9304 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9306 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9309 * dfm.c: Added some debugging messages, disabled by default.
9310 (open_file_r) Fixed error message.
9311 (read_record) On eof on inline_file, instead of calling
9312 fh_close_handle(), simply jump to eof label like a normal file.
9315 * display.c: Thin lines between rows for certain kinds of
9316 listing. Fixed `null cell' bug.
9318 * error.c: (failure) Flush stdout, stderr before failing.
9320 * file-handle.q: (fh_close_handle) Added debugging message.
9322 * frequencies.q: (dump_full) Bottom line extends across entire
9323 table width. Changed title formatting.
9324 (dump_condensed) Changed title formatting.
9325 (dump_statistics) Fixed title formatting.
9327 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9328 Sets default value of set_format.
9330 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9331 Passes write_all_headers() to procedure() as pre-group func.
9332 (write_all_headers) New function.
9333 (determine_layout) Removed calls to write_header().
9334 Calls blank_line() before and after write_fallback_headers().
9336 * recode.c: (recode_trns_free) Only attempts to free head->map if
9339 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9340 file variable names but gives a warning. Sets `left' based on
9341 first character being/not being `#'. On lossage frees dict->var.
9343 * som-high.c: (som_draw_title) Simplified title formatting.
9345 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9347 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9349 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9350 beginning. Frees v_src, v_dest on successful exit. Frees
9351 h_trans[*], h_trans on lossage.
9352 (recode) Frees h_trans[*], h_trans.
9354 * dfm.c: (dfm_close) Formatting change.
9355 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9356 longer allocates its own in inline_file.
9357 (open_file_r) Passes the local dfm_fhuser_ext to
9359 (open_file_w) Message fix.
9360 (read_record) Buffer reallocation strategy changed. Frees
9361 ext->line even in inline_file to prevent leaks.
9362 (dfm_put_record) Fixed bug where `ext' was cached before the file
9363 was opened and thus it would be NULL when the file really was
9365 (cmd_begin_data) Sets up inline_file basics itself, then calls
9366 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9368 * list.q: (write_line) Formatting fix.
9369 (clean_up) Minor strategy change. Sets proportional font after
9371 (determine_layout) Sets fixed font before writing regular headers,
9372 or after writing fallback headers.
9374 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9375 and KEEP vars after using them.
9377 * postscript.c: (ps_init_driver) Frees x->family.
9378 (postopen) When loading fonts, free the temporary font name buffer
9380 (ps_text_set_font_by_position) Free temporary font name buffer
9382 (text) Fixed code that calculated `lig' so that `lig' always gets
9383 initialized. Formatting fix.
9385 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9387 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9388 cells, not xmalloc(), so that the cells will get destroyed
9391 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9394 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9396 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9399 * dfm.c: Comment fix.
9401 * list.q: Comment fixes. Include somP.h. Removed static vars
9402 table, n_columns, n_rows, part. New struct list_ext. New static
9404 (n_lines_remaining, n_chars_width, write_line) New functions.
9405 (cmd_list, list_cases) Rewritten.
9406 (begin_row, end_row, flush_table) Removed.
9407 (write_header, clean_up, write_varname, write_fallback_headers,
9408 determine_layout) New functions.
9410 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9412 * output.h: Comment fix.
9414 * postscript.c: Comment fix.
9415 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9416 added font_size. All references changed.
9417 (ps_init_driver) Initializes font_size. Simplified space checking
9419 (static var option_tab[]) Removed prop-size, fixed-size; added
9421 (ps_option) Handles font_size.
9423 * som-high.c: Moved prototypes into somP.h.
9424 (som_init_driver) New function.
9425 (som_submit_table) Moved some code into new function
9427 (build_target) Moved some code into new function
9428 som_internal_eject_page().
9429 (som_eject_page) Uses som_internal_eject_page().
9430 (som_internal_eject_page) New function.
9432 * som-low.c: Moved prototypes into somP.h.
9434 * som.h: Formatting fixes.
9436 * somP.h: (struct som_driver_ext) Removed em_width;
9437 added prop_em_width, fixed_width.
9439 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9441 * Makefile.am: Added `localedir' definition. Added
9442 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9444 * ascii.c: (macro draw_line) Fixed capitalization.
9446 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9447 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9448 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9449 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9450 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9451 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9452 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9453 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9454 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9455 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9456 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9457 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9458 for internationlization.
9460 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9462 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9464 * do-if.c, sort.c, val-labs.c: Comment fixes.
9466 * glob.c: (init_glob) Uncommented, updated i18n support.
9468 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9469 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9470 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9471 the declarations of macros taking arguments a lot nicer.
9473 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9475 * error.h: Removed CE, CW aliases for SE, SW.
9477 * q2c.c: Removed explicit streq() definition since it's duplicated
9480 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9481 stats.h, str.h, tokens.h: Made the declarations of macros taking
9482 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9485 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9487 * cmdline.c: Comment fixes.
9488 (pick_compat) Changed return type to int. Now, instead of setting
9489 glob var `compat' to the emulation, returns the emulation. All
9491 (parse_command_line) Added terminating null to end of
9492 `long_options' array definition.
9493 (pre_syntax_message) Fixes.
9494 (usage) Shows the default emulation in the syntax message by
9495 calling pick_compat().
9497 * getline.c: (getl_add_include_dir) Separates paths with
9498 PATH_DELIMITER, not DIR_SEPARATOR.
9500 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9501 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9503 * output.c: (outp_configure_macro) Make earlier definitions for a
9504 particular key override later ones for the same key.
9506 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9508 * ascii.c: Comment fixes.
9510 * output.c: (outp_get_paper_size)
9511 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9513 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9515 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9516 <errno.h>. GNU libc 2 enforces this!
9518 * command.c: (parse_cmd) Fixed problem with `else' clause being
9519 paired with wrong `if'. Comment fix.
9521 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9523 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9524 blp_getline() to getline().
9526 * output.c: (outp_eval_dimension) Changed the fix from last time;
9527 there was no variable `a'.
9529 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9531 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9533 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9534 numbers having fractional parts. Added case of a fraction without
9535 a whole-number part.
9537 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9539 * ascii.c: (ascii_text_get_font_position) Removed.
9541 * expr.h, exprP.h: Disabled debugging.
9543 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9546 * output.h: (struct outp_class_struct) Removed
9547 text_get_font_position method. All references deleted.
9549 * postscript.c: Big change here. Fontmaps were completely
9550 eliminated because of a change in philosophy. Comment fixes.
9551 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9553 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9554 `fixed_name' members removed. New members `prop_family',
9555 `fixed_family'. `family' member changed to type char *.
9556 (static var ps_fontmaps) Removed.
9558 (ps_init_driver) Removed obsolete references, updated.
9559 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9560 fontmap, of course. Refers to font names through internal_name
9561 rather than subversive means. Frees proper items.
9562 (static var option_tab[]) Removed `fontmap-file' option; renamed
9563 `fixed-font', `prop-font'.
9564 (ps_option) Corresponds to option_tab[].
9565 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9566 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9567 hash_family) Removed.
9568 (postopen) Generates font names from family names. Gets
9569 PostScript font name properly. New prologue file comment `!!!'
9571 (ps_open_page) Adds translate_x, translate_y to BP prologue
9572 function; gives SF argument floating-point format.
9573 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9574 font name. Doesn't change font family.
9575 (ps_text_set_font_by_position) Generates Groff font name from font
9576 family name instead of through table lookup.
9577 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9578 all references changed. Reduced to simple string assignment.
9579 (ps_get_font_name) Removed.
9580 (ps_get_font_family) Reduced to string return.
9581 (text) Doesn't save `position' since it no longer exists. Ugly
9582 kluge to save font family--fix soon?
9583 (load_font) Removed PostScript name argument.
9585 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9587 * postscript.c: Comment fix.
9588 (ps_open_page) Puts scale factor in PostScript output.
9590 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9592 * Makefile.am: Distcleans q2c.
9594 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9596 * ascii.c: (delineate) Sets text size even if width is zero.
9598 * command.c: Comment fix.
9599 (static var cmd_table[]) Re-enabled EVALUATE command.
9600 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9601 of comments in script files. Now more liberal on criteria for
9602 performing a state transition--if *anything* happened correctly,
9603 not just if *everything* happened correctly.
9605 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9606 Checker segfault on formatting large numbers and why in the fsck
9607 hadn't I noticed this before?
9609 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9611 * list.q: (cmd_list) Commented out the actual output routine
9612 because of various problems. Probably will abandon the idea of
9613 using the general `crushed tables' for the LIST procedure.
9615 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9616 clearing it. Allocates a new var_by_name dictionary before trying
9617 to add members to it.
9619 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9620 `sib'. Changed type of `node' argument.
9621 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9623 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9624 [DEBUGGING] Only deletes the variable from var_by_name if that var
9627 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9629 * Makefile.am: Added include files to SOURCES. Added
9630 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9631 includes rules for q2c. Added `boast' target.
9633 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9635 * Makefile.am: Maintainer-clean Makefile.in.
9637 * Makefile.am: Fixed redundant EXTRA_DIST line.
9639 * ascii.c: Comment fixes.
9640 (ascii_line_vert) Fixed overly aggressive range check.
9642 * display.c: Removed dead code.
9644 * list.q: Turn debugging on.
9645 (flush_table) New debug code.
9647 * sfm-read.c: (read_value_labels) malloc's the structure before
9648 trying to assign to its members.
9650 * sfm-write.c: Comment fix.
9652 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9654 (output_table) No arguments anymore--gets them through `som'
9655 global. New debug code. In crushed tables, now sets `htv' as
9656 well as `hv' to avoid bad confusion later.
9657 (dump_crush_page) New debug code.
9659 * som-low.c: (som_dump_crush_page) New debug code.
9661 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9663 All source files: Broke long lines into multiple lines.
9665 * ascii.c: (ascii_close_page) Uses host_system var in place of
9666 HOST_SYSTEM constant.
9668 * cmdline.c: (var syntax_message[]) Broke into
9669 pre_syntax_message[] and post_syntax_message[].
9670 (usage) Outputs both parts, separated by driver list.
9672 * error.h: Fixed broken formatting.
9674 * expr-opt.c: (str_search, str_rsearch) New functions.
9676 * misc.c: (blp_getdelim) Removed. All references changed to
9678 (str_search, str_rsearch) Removed.
9679 (memrmem) New function.
9681 * misc.h: (blp_getline) Removed. All reference changed to
9686 * filename.c: Includes "stat.h", not <sys/stat.h>.
9687 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9689 * output.c: (outp_list_classes) Changed output formatting.
9691 * sfm-write.c: (write_header) Uses host_system var instead of
9692 HOST_SYSTEM constant.
9693 (write_rec_7_34) Extracts version numbers from the version string.
9696 * sort.c: Includes "stat.h", not <sys/stat.h>.
9698 * str.c: (strcasecmp) Removed.
9700 * title.c: (cmd_document) Uses host_system var instead of
9701 HOST_SYSTEM constant.
9703 * version.c: Generated on-the-fly by the Makefile instead of being
9706 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9708 [!HAVE_STRNCASECMP] Declares strncasecmp().
9710 * version.h: Removed stray character. Comment fixes.
9711 (vars host_system, build_system) New vars.
9713 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9715 * Most source files: Changed formatting of copyright notice; fixed
9716 FSF address; reformatted to better conform to GNU standards;
9717 comment fixes. Added markups to prevent GNU indent from messing
9718 up my beautiful formatting :-).
9720 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9721 that GNU indent markups can be passed through without problems.
9723 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9725 * get.c: Turned off debugging.
9727 * glob.c: (init_glob) Turned on save-file compression by default.
9729 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9730 compression than was possible in save files.
9732 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9734 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9736 * frequencies.q: Removed Fiasco extensions. Updated calculation
9737 algorithms. Polished output format.
9738 (struct frq_info_struct) Removed members `max_degree', `min_n',
9739 all references removed.
9740 (macro frq_extensions) Removed.
9741 (static vars min_n, max_degree) Removed, all references removed.
9742 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9743 calculate `min_n', `max_degree'.
9744 (postcalc) Passes new arg to dump_statistics().
9745 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9747 (dump_condensed) Adds variable name title.
9748 (sum_freqs) Removed.
9749 (calc_stats) Updated calculation algorithm.
9750 (dump_statistics) Removed warning for too-few observations.
9751 Changed table formatting. Adds variable name title if passed new
9754 * output.h: Comment fix.
9756 * recode.c, sample.c, sort.c: Disabled debug code.
9758 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9759 Improved debug code.
9761 * var.h: (enum series frq_*) Removed Fiasco extensions.
9763 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9765 * command.c: Added PROCESS IF to command table.
9767 * Lots & lots of places, removed checks for NULLs preceding calls
9768 to free_expression(), which itself checks.
9770 * descript.q: Removed Fiasco extensions. Removed optimizations
9771 for non-weighted active files. Implemented some options.
9772 Finished polishing output format. Comment fixes. Merged
9774 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9775 max_degree, min_n) Removed.
9776 (macro dsc_extensions) Removed.
9777 (struct dsc_info_struct) Removed `min_n' member, all references
9779 (internal_cmd_descriptives) Removed calculation of min_n,
9780 max_degree. Only deals with one `calc' routine instead of two
9782 (precalc) Eliminated redundancy. Updated for changes to
9783 descriptives_proc structure.
9784 (calc) Moved here from `descript.g'. Rewritten to calculate
9785 statistics via `moments about the mean' rather than by summing,
9786 summing squares, summing cubes, and so on.
9787 (postcalc) Rewritten for new-style statistical calculation.
9788 (display) Removed support for displaying variables across rows.
9789 No longer crushes the descriptives table. Removed ancient code.
9790 Added display of N, by variable and listwise.
9792 * descript.g: Removed; merged into `descript.q'.
9794 * expr-evl.c: (evaluate_expression) Now returns a double. For
9795 numeric results, it returns the result as well as storing it in
9796 the passed `value' structure if non-NULL. For string results it
9797 just returns 0.0 and it must be passed non-NULL. Many references
9798 to this function were optimized by use of this change, especially
9799 but not exclusively in `compute.c'.
9801 * frequencies.g: Comment fix.
9803 * glob.c: (glob var process_if_expr) New global var.
9805 * postscript.c: (static var option_tab[]) Corrected entry for
9807 (postopen) Sets x->size to x->prop_size.
9808 (ps_text_set_font_by_name) Sets font size as well as typeface for
9809 PROP and FIXED fonts.
9811 * sel-if.c: (cmd_process_if) New function.
9813 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9814 (sfm_write_dictionary) Sets `n_cases' to 0.
9815 (sfm_write_case) Increments `n_cases'.
9816 (sfm_close) Attempts to seek the system file back to the header
9817 and write the number of cases in its proper slot.
9819 * som-frnt.c: (som_insert_table) Masks off expansion options since
9820 only SOPT_X_NORM seems to work sensibly.
9822 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
9823 with a `fixed' value of 2.
9825 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
9827 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
9828 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
9830 * var.h: (enum series dsc_*) Removed Fiasco extensions.
9831 (struct descriptives_proc) Removed `miss_noweight'; new members
9832 `X_bar', `M2', `M3', `M4', `min', `max'.
9834 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
9836 * vfm.c: (close_active_file) Cancels PROCESS IF.
9837 (write_case) Doesn't process cases unselected by PROCESS IF.
9839 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
9841 * glob.c: (glob var err) Removed.
9843 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
9844 doesn't have to take into account number of value labels since
9845 they're in a subtable anyway. Also, doesn't display more than 10
9846 value labels since we can't yet break pages in subtables.
9848 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
9850 * som-frnt.c: (som_change_table_size) Simple change for elegance
9851 that shouldn't change behavior.
9852 (som_set_value) Comment fix.
9854 * som-high.c: (som_submit_table) Message fix.
9856 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
9858 * command.c: Added SYSFILE INFO to command table.
9860 * file-handle.q: (fh_handle_filename) New function.
9862 * get.c: (save_trns_proc) Fixed a bug in padding of output data
9865 * main.c: (parse) New return value for command functions, -3.
9867 * misc.h: Comment fix.
9869 * output.h: Comment fixes.
9870 (macro COMPONENTS) Removed.
9872 * postscript.c: (write_text) Modified literal_chars[] so that `('
9873 and ')' are not written to the output in strings as literals.
9875 * sfm-read.c: (sfm_read_dictionary) New argument.
9876 (read_header) New argument. Sets the information structure's
9877 values from the header information.
9878 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
9879 bizarre Checker problem, I guess.
9880 (read_variables) Proper cleanup on lossage.
9882 * sfm.h: (struct sfm_read_info) New struct for use by
9883 sfm_read_dictionary().
9885 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
9886 currently used just for tables that can be dynamically resized and
9887 thus have to be allocated with arena_malloc() instead of
9888 arena_alloc(). All references changed.
9889 (som_change_table_size) New function.
9890 (som_insert_table) Bugfix: now inserts `cell', not `c'!
9892 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
9893 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
9896 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
9898 (draw_intersection) Now takes an argument specifying the table in
9899 question. All references changed.
9900 (draw_table_cell) New function.
9901 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
9902 (som_get_table_size) Many nice new explanatory comments.
9903 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
9905 * som.h: New enum series SOM_CREATE_* for use as create flags with
9908 * str.h: Moved a comment here from TODO.
9910 * sysfile-info.c: New file. Reference implementation.
9912 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
9914 * command.c: Added RENAME VARIABLES to table of commands.
9916 * data-in.c: (dls_error) Sets `cust_field'.
9917 (parse_N) Message fix.
9918 (parse_day_count) New function.
9919 (to_roman) Never outputs VX as a `short form' of V.
9920 (parse_month) Fixed parsing of Roman numerals.
9921 (parse_trailer) Message fix.
9922 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
9923 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
9924 the date is invalid.
9925 (parse_SDATE) Fixed swapped day, year.
9926 (parse_JDATE) Fixed bug for dates in 1582.
9927 (parse_DTIME) Allows days not between 1 and 31.
9928 (parse_numeric) Makes local copy of f.type for easier usage.
9931 * data-out.c: (convert_F) When outputting as scientific, properly
9932 sets f.type as fp->type.
9933 (insert_commas) Fixed operator precedence problem with setting of
9934 nitems. Changed strcpy to memcpy (no null terminator).
9935 (convert_date) Fixed FMT_JDATE: added 1900 to year.
9936 (convert_CCx) Essentially rewritten, but now it works.
9938 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
9940 (display_documents) Implemented.
9942 * error.c: (glob var cust_field) New var.
9943 (vmsg) Displays cust_field as part of message classes DE and DW.
9945 * formats.c: (debug_print) Fixed to compile under updated
9948 * get.c: (cmd_get, cmd_save_internal) Close file handle on
9951 * misc.c: (parse_format_specifier) Formatting fix.
9953 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
9954 `n_rename' for clarity.
9955 (cmd_modify_vars) Initializes `forward' and `positional' at
9956 appropriate times. Frees lists of vars to rename on failure.
9957 Comment fix. Frees memory on success.
9958 (rearrange_dict) Simplified `for' loop condition.
9960 * rename-vars.c: New file (reference implementation).
9962 * set.q: (internal_cmd_set) Fixed `emu' test condition.
9964 * sfm-read.c: (read_header) File label is created only if file
9965 label in file is not blank.
9966 (read_variables) Initializes `dict' local variable.
9967 (read_documents) Proper behavior on lossage.
9969 * sfm-write.c: (write_header) Doesn't blank out the file label
9970 (why was this here to begin with?!)
9972 * temporary.c: (save_dictionary) File label is copied only if
9973 non-NULL. Doesn't try to xstrdup() dictionary documents.
9974 Adapted so as to not irritate Checker.
9975 (free_dictionary) Only destroys var_by_name if non-NULL.
9977 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
9978 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
9979 lines to the document, indents the document. Also, it works now.
9980 (add_document_line) New function.
9982 * var.h: (struct dictionary) Reordering.
9984 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
9985 bits if it was allocated to begin with.
9987 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
9989 * command.c: Added MODIFY VARS to list of commands.
9991 * configure.in: Updated custom macros for autoconf 2.12. Removed
9992 mmap reference; fixed termcap library reference.
9994 * display.c: (display_variables) Fixed a few bugs although it's
9995 still not well written.
9997 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
9998 (induce_segfault) Calls chkr_disp_call_chain() instead of
9999 inducing an actual SIGSEGV.
10001 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10002 str_search() and str_rsearch(). Fixed tests for matches on
10003 OP_INDEX and OP_RINDEX.
10005 * filename.c: (good_getcwd) Removed as the new libc for Checker
10006 doesn't contain this bug, apparently.
10008 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10009 consistency with GNU memmem.
10010 (blp_getdelim) Changed `len' from `int' to `size_t'.
10012 * modify-vars.c: Reference implementation.
10014 * som-frnt.c: (zero_length) New global var.
10015 (som_create_table) Message fix.
10017 * som.h: Added gcc attributions to som_set_text(),
10018 som_output_text() prototypes. blank_line() refers to
10019 zero_length[] instead of a literal null string to suppress gcc
10022 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10023 (allocate_cases) Decrements x_max so the last element of x[] can
10024 be used by the algorithm.
10026 * var.h: Changed minor details of `variable' declaration.
10027 (struct modify_vars_proc) New struct.
10028 (struct variable) Added field p.mfv.
10030 * vars-atr.c: Comment fix.
10032 * vars-prs.c: (fill_all_vars) More optimal implementation.
10034 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10035 character, which it shouldn't have to do but printf() seems to
10036 read the null byte even though I supply a maximum length...
10038 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10040 * command.c: Removed command alias X for QUIT.
10041 (parse_cmd) Fixed comment parsing.
10043 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10045 (read_record) Fixed references to len, size.
10046 (dfm_get_record) Restructured.
10048 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10051 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10054 * modify-vars.c: New file. Not complete.
10056 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10059 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10060 problems caused by int/size_t differences.
10062 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10065 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10066 being compared were of equal length.
10068 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10070 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10072 * lexer.c: (get_dotted_rest_of_line) New function.
10074 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10077 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10078 type 6 records. Frees the dictionary properly.
10079 (read_header) Initializes the dictionary instead of letting
10080 read_variables() do it. Sets the dictionary file label from the
10082 (read_documents) New function.
10084 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10085 write type 6 record if appropriate.
10086 (write_header) Writes file label from dictionary.
10087 (write_documents) New function.
10089 * temporary.c: (save_dictionary, restore_dictionary,
10090 free_dictionary) Properly handle new fields in dictionary struct.
10092 * title.c: (get_title) Returns after failure().
10093 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10094 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10096 * var.h: (struct dictionary) New fields `label', `n_documents',
10099 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10101 * command.c: Added FILTER to list of commands.
10103 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10106 * get.c: (cmd_save_internal) Removed weighting code since it's now
10107 handled by sfm-write.c. Properly commented out debug code.
10109 * glob.c: (glob var weighting) Removed.
10111 * sel-if.c: Comment fixes.
10112 (cmd_filter) New function.
10114 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10115 (sfm_read_dictionary) Sets weighting variable direct in the
10116 created dictionary now. (Apparently we previously didn't support
10118 (read_header) Sets weight_index field in sfm_fhuser_ext from
10119 header read from disk.
10121 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10122 (write_header) Now sets the weighting in the header from the
10123 passed primary dictionary instead of from the sfm_write_info.
10125 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10127 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10128 broke on boundary conditions.
10130 * var.h: (struct dictionary) New fields `weight_var',
10131 `weight_index', and `filter_var'.
10132 (glob var weighting) Removed. This is now part of struct
10133 dictionary. All references changed; the less mechanical changes
10134 are described above.
10136 * vars-atr.c: (find_dict_variable) New function.
10138 * vfm.c: (static var filter_index) New variable.
10139 (open_active_file) Initializes filter_index from default_dict.
10140 (write_case) Calls proc_func() only if the filter variable is
10141 nonzero; this implements FILTER behavior.
10143 * weight.c: (static var weight_varname) Removed.
10144 (cmd_weight) Modified default_dict instead of glob vars.
10145 (update_weighting) Changed the signature to modify a dictionary
10146 instead of glob vars. Now returns the weighting variable.
10147 (get_weighting_variable) Removed; its function is absorbed by
10148 update_weighting().
10149 (stop_weighting) Operates on a dictionary now.
10151 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10153 * sort.c: Removed debugging info from messages.
10154 (do_external_sort) Cleans up after itself by deleting the
10155 temporary directory on failure. (On success it is deleted by the
10157 (allocate_cases) Removed debug code. Added clean up code.
10158 (output_record) Removed debug code.
10159 (merge) Added code to close all the input files that are currently
10160 open. This is a likely location for bugs, because I'm not sure
10161 about boundary conditions. Removed an unnecesary heap_delete().
10162 (merge_once) Removed input file "optimization" that in fact
10163 screwed up the rest of the code. Message and comment fixes.
10165 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10167 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10169 * heap.c: (heap_delete) New argument.
10171 * sort.c: Finished implementation of external sort.
10173 * vfm.c: (read_from_disk) Returns after a disk error.
10175 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10177 * sort.c: (static var state) Removed.
10178 (static vars max_handles, tmp_basename, tmp_extname,
10179 huffman_queue) New variables.
10180 (do_external_sort) Moved most code to new functions.
10181 Creates huffman_queue.
10182 (allocate_file_handles, allocate_cases) New functions.
10183 (static vars run_no, run_length, file_index, case_count) New
10185 (output_record) Returns success. Now really writes to the output
10187 (begin_run, end_run) New functions.
10188 (write_initial_runs) Returns success. Initializes run_no to -1.
10189 Calls begin_run(), end_run() at appropriate times. Outputs debug
10191 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10193 (merge) New function.
10195 * heap.c, heap.h: New files. Hopefully in near-final form.
10197 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10199 * glob.c: Added write_active_file to global vars.
10201 * sort.c: Several new miscellaneous static variables.
10202 (cmd_sort_cases) Big comment fix.
10203 (perform_case_2) Renamed `do_external_sort' and completely
10205 (case_2_proc_func) Removed.
10206 (output_record, write_initial_runs, write_to_sort_cases,
10207 compare_record) New functions.
10209 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10211 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10213 * sort.c: (perform_case_2) Changed the method for allocation of
10214 lots of memory--now allocates one case at a time in hopes that
10215 more cases can be allocated with heavily fragmented memory.
10217 * var.h: (write_active_file) New global var.
10219 * vfm.c: (procedure, close_active_file, write_case,
10220 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10221 arguments to procedure() to be NULL. All references to
10222 procedure() that made use of dummy functions were changed to NULL
10224 (open_active_file) If write_active_file is non-NULL, the output
10225 device becomes DEV_PGM (a new enum).
10226 (close_active_file) Sets write_active_file to NULL.
10227 (read_from_memory) Comment fix.
10228 (record_case) Calls write_active_file() when the output device is
10231 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10233 * sort.c: New file.
10235 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10236 Fixed checking for duplicate varnames.
10237 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10239 (autorecode_trns_free) Destroys hash tables for each recoding
10241 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10243 * command.c: Added SORT CASES to cmd_table.
10244 (null_func, null_int_func) Prototyped.
10246 * descript.g: (calc_weight, calc_noweight) Computes own case
10249 * frequencies.q: (dump_statistics) Fixed problem with
10250 too-few-cases warning message.
10252 * get.c: (cmd_save_internal) Handles weighting properly.
10254 * hash.c: (hsh_dump) Output format changed.
10255 (force_hsh_insert) Actually works now, prototype changed.
10257 * list.q: (static var case_num) New variable.
10258 (cmd_list) Initializes case_num.
10259 (list_cases) Increments case_num.
10261 * var.h: Added definitions for SORT CASES. Comment fixes.
10263 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10264 fixes. `active' renamed vfm_active, `rep' renamed
10265 vfm_replacement, all references changed.
10266 (procedure) The procfunc no longer receives a case number. All
10267 references changed.
10268 (write_case) Subtle reordering.
10269 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10272 * weight.c: (get_weighting_variable) New function.
10274 * vfmP.h: New file with definitions from vfm.c.
10276 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10278 * command.c: (FILE_TYPE_okay) Commented out some tests because
10279 they're clumsy and not yet needed.
10281 * var.h: Most *_trns structures moved to their respective source
10282 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10283 (union any_trns) Changed to a typedef for trns_header.
10284 (struct input_program_pgm) Removed.
10286 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10287 was allocated in the first place.
10289 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10291 * autorecode.c: New file.
10293 * command.c: Added AUTORECODE to command table; re-enabled SET.
10295 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10297 * error.c: (vmsg) Comment fixes.
10299 * hash.c: Comment fix.
10300 (hashpjw_d) New function.
10301 (hashpjw) Reimplemented as call to more general function
10303 (internal_comparison_fn) Initializes pointers properly.
10304 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10305 (force_hsh_insert, force_hsh_find) New debugging wrapper
10308 * main.c: (main) Message fix.
10310 * output.c: (outp_read_devices) Message fix.
10312 * set.q: Comment fixes.
10313 (custom_results) Implemented Wnd/X form of subcommand.
10314 (set_routing) New function.
10315 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10317 * settings.h: (SET_ROUTE_*) New enum series.
10318 (set_results) Renamed set_results_file, all references changed.
10319 (set_messages) Removed.
10320 (glob vars set_errors, set_messages, set_results) New vars.
10322 * title.c: (get_title) Remembers to xstrdup() the result of
10323 get_rest_of_line().
10325 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10327 (union any_trns) New element `arc'.
10329 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10331 * command.c: (output_line) Removed references to set_screen.
10333 * error.c: (static var terminating) New var.
10334 (hcf) Sets terminating to 1.
10335 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10336 This prevents an infinite loop if an error occurs within hcf().
10338 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10339 statement circumlocution with `case 42000' trick.
10340 (evaluate_expression) New support for OP_STR_MIS.
10342 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10343 statement circumlocution with `case 42000' trick.
10344 (dump_node) Handles OP_STR_MIS.
10346 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10347 variables exceptions.
10348 (parse_function) Message fix.
10349 (ops[]) Added OP_STR_MIS.
10351 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10353 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10355 * glob.c: Removed set_scrnfile glob var.
10356 (init_glob) set_errorbreak set to 0 by default.
10358 * groff-font.c: Changed included files.
10359 (groff_read_font) Initializes font_arena local var correctly.
10360 (default_font) New function.
10362 * output.c: Comment fixes.
10363 (glob var disabled_devices) New variable.
10364 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10366 [GLOBAL_DEBUGGING] (reentrancy) New function.
10367 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10368 outp_iterate_enabled_drivers) Calls to reentrancy().
10369 (destroy_list) New function.
10370 (outp_done) Moved code to destroy_list().
10371 (parse_options) Parses `listing', `screen', `printer' options
10373 (configure_driver) Sets new `device' member of driver.
10374 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10376 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10377 (struct outp_driver_struct) New member `device'.
10379 * postscript.c: (find_encoding_file) Doesn't display its own error
10381 (default_encoding) New function.
10382 (switch_font) Calls default_encoding() if no encoding can be
10384 (text) Makes up a character metric if none exists for the desired
10386 (load_font) Properly copies a fallback filename. Calls
10387 default_font() for a font if none at all are known.
10389 * set.q: Comment fixes. Removed OUTPUT subcommand.
10390 (custom_listing) Calls outp_enable_device() to enable/disable
10392 (turn_screen_on) Removed.
10393 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10394 screen, printer devices.
10396 * settings.h: Comment fixes.
10397 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10400 * som-high.c: (som_submit_table, som_eject_page) Use
10401 outp_iterate_enabled_drivers() instead of iterating
10402 outp_driver_list directly.
10404 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10406 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10407 (parse_string_as_format) Handles new formats.
10408 (parse_numeric) Now handles DOT and PCT formats.
10410 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10412 (convert_date) Handle EDATE and SDATE formats.
10413 (convert_CCx) Now if there's not room for the currency characters,
10414 converts it as F format if it's positive instead of giving up
10415 quickly. Also fixed save-and-restore bug with decimal point
10417 (convert_format_to_string) Handles new formats.
10419 * misc.c: (formats[]) Added new formats.
10420 (convert_fmt_ItoO) Supports new formats.
10422 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10423 data checking. New argument, all references changed.
10425 * sfm-write.c: (write_format_spec) Supports new formats.
10427 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10430 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10432 * cmdline.c: Comment fixes.
10433 (parse_command_line) Changed return type to void.
10435 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10437 (parse_numeric) Handles international numbers (comma as decimal
10438 point). Some reformatting.
10440 * data-list.c: (parse_free) Default output format is now
10441 set_format instead of hard-coded F8.2.
10442 (read_from_data_list_list) Emits error message on undefined data
10443 only if set_undefined is nonzero.
10445 * data-out.c: (convert_E) Changes decimal point from period to
10446 comma if appropriate. Restructured. Better comments.
10447 (convert_F) Changes decimal point from period to comma if
10449 (insert_commas) Major bug with handling of negative values fixed.
10450 Also, inserts periods instead of commas if appropriate.
10451 (convert_CCx) New function.
10452 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10453 (num_to_string) Changed `.' to set_decimal.
10455 * dfm.c: Comment fixes.
10456 (dfm_close) Frees ext->line even in inline_file.
10457 (open_inline_file) New function.
10458 (open_file_r) When opening the inline file: now properly
10459 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10461 (read_record) Calls fh_close_handle() instead of dfm_close() to
10462 close the inline file. Makes a copy of the line getl_buf to avoid
10463 interlock problems.
10464 (dfm_get_record) Restructured. Now checks the return value of
10466 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10467 checking for use of inline file. No longer tries to close inline
10470 * error.c: (glob var error_already_flagged) New var.
10471 (vmsg) Message change. Now checks max number of errors/warnings,
10474 * file-handle.q: (fh_handle_name) Now allows closing of
10476 (fh_init_files) Reformatted.
10478 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10480 * getline.c: (getl_include) Fixed bug that popped up when called
10481 when file queue was empty.
10482 (read_console) Resets error_count, warning_count,
10483 error_already_flagged to zero.
10485 * glob.c: Many changes to update list of variables.
10486 (init_compat_dependent) Now this function is called whenever
10487 `compat' changes. It now sets set_seed only if it hasn't
10488 previously been referenced. It now calls
10489 lex_init_compat_dependent().
10491 * include.c: (cmd_include_at) Frees temporary buffer instead of
10493 (cmd_include) Doesn't make copy of include file name.
10495 * lexer.c: Comment fixes.
10496 (init_lex) Moved some code into new function
10497 lex_init_compat_dependent().
10498 (lex_init_compat_dependent) New function.
10499 (hex_val) Simplified.
10500 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10502 * main.c: Comment fixes.
10503 (main) Reformatted.
10505 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10506 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10507 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10508 (setup_randomize) Sets set_seed_used.
10510 * set.q: Comment fixes.
10511 (custom_results) Conditionalizes on `compat'.
10512 (custom_log) Calls custom_journal().
10513 (set_ccx) New function.
10514 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10515 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10516 when set_decimal changes. Range-checks values for MITERATE,
10517 MNEST. Message fixes.
10519 * settings.h: Comment fixes.
10520 (struct set_cust_currency) New struct.
10521 (set_cc[], set_grouping, set_seed_used) New global vars.
10523 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10524 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10526 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10528 * glob.c: Revised variables to correspond to settings.h.
10529 (init_glob) Initializes variables from settings.h properly.
10531 * set.q: Began long-overdue major revision to correspond to new
10532 philosophy. Most code changed.
10534 * settings.h: Mostly changed; reorganized, reordered, large new
10537 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10539 * get.c: (cmd_save_internal) No longer forces compression off.
10541 * sfm-read.c: (read_compressed_data) If eof is reached when
10542 reading a new instruction octet, only signal error if we're in the
10545 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10546 (struct sfm_fhuser_ext) New member `end'.
10547 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10548 (ensure_buf_space) New function.
10549 (sfm_write_case) Reimplemented in order to support compression.
10550 (sfm_close) Writes out the remaining contents of the compression
10553 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10555 * command.c: Defined SAVE and XSAVE commands in command table.
10557 * common.h: second_lowest_value is of type flt64, not double.
10559 * file-handle.h: Comment fix.
10561 * get.c: Comment fixes.
10562 (static var `trns') New.
10563 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10564 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10565 (dict_delete_run) Clears the variables and frees them now.
10566 (trim_dictionary) Sets default for compression.
10567 On KEEP subcommand, frees deleted variables as well as clearing
10568 them. Finally got the sense of the test for deleting all
10570 [DEBUGGING] (dump_dict_variables) Message fix.
10572 * glob.c: (init_glob) set_compression set to 1 by default.
10574 * list.q: Properly #includes config.h.
10576 * misc.h: New macro REM_RND_UP.
10578 * settings.h: Comment fix.
10580 * sfm-read.c: (structs sysfile_header, sysfile_format,
10581 sysfile_variable; inline function bswap_int32) Moved to new file
10583 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10584 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10586 (read_machine_flt64_info) Fixed some problems caused by confusion
10587 between flt64 and double types.
10588 (read_header) Message fix.
10589 (read_variables) Fixed set of cases in which we byte-swap sv.print
10590 and sv.write. Fixed confusion of flt64 and double.
10592 * sfm.h: (struct sfm_write_info) New.
10594 * som-high.c: (som_draw_title) Properly frees `s'.
10596 * temporary.c: (save_dictionary) Comment fix.
10598 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10599 (struct trns_header) Formatting fix.
10600 (struct save_trns) New.
10602 * vars-atr.c: (discard_variables) Comment fix.
10604 * sfm-write.c: New file, baseline release.
10606 * sfmP.h: New file, baseline release.
10608 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10610 * cmdline.c: (parse_command_line) `--version' output updated.
10611 (glob var syntax_message[]) Added my e-mail address.
10613 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10614 `illegal' to `invalid'.
10616 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10617 uncompression buffer.
10618 (sfm_close) Frees decompression buffer.
10619 (sfm_read_dictionary) Initializes decompression buffer.
10620 (buffer_input, read_compressed_data) New functions.
10621 (sfm_read_case) Restructured; now calls read_compressed_data() to
10622 handle compressed system file data.
10624 * var.h: Comment fix.
10626 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10628 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10631 * get.c: New comments. New static var `get_file'.
10632 (cmd_get) Now fully implemented. Calls discard_variables();
10633 initializes fv and lv for all variables; new debug code; sets
10634 up the dictionary; sets up the input program.
10635 (read_from_get, cancel_get) New functions.
10637 * sfm-read.c: Comment fixes.
10638 (sfm_close) New static function.
10639 (sfm_read_dictionary) Properly sets up the class of the
10640 file_handle. No longer cares what size the data is in records of
10641 type 7. Also, on failure, properly cleans up the file_handle and
10642 free()s some stuff.
10643 (read_variables) No longer thinks it knows `nval' of the
10644 dictionary. Now sets p.get.fv, etc., instead of speculatively
10646 (read_value_labels) Fixed off-by-one error in indexing of
10648 (sfm_read_case) New function.
10649 (sfm_r_class) New static var.
10651 * var.h: (get_proc) New struct.
10652 (struct variable) New member p.get.
10654 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10656 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10657 the manual's meaning.
10658 (rename_variables) New function.
10659 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10660 code. Now properly reorders the dictionary on the KEEP keyword.
10662 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10663 garbage collection.
10665 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10666 (rename_variable) New function.
10667 (free_val_lab) Reformatted.
10669 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10671 * var.h: Reindented entire file. Comment fixes.
10672 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10674 (glob var default_dict) New.
10675 (struct indirect_dictionary) Removed.
10677 * Many other source files were changed to add `default_dict.'
10678 before all references to the dictionary of the active file.
10680 * vars-atr.c: (make_indirect_dictionary) Removed.
10682 * glob.c: Reindented all variable declarations. Updated for
10683 changed var.h. Comment fixes.
10685 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10686 because now we can mainly copy dictionary structs.
10688 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10689 parse_variables) Takes dictionary instead of indirect_dictionary
10691 (parse_variables) Instead of calling make_indirect_dictionary,
10692 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10693 of `*dict.' references had to be changed to `dict->'. Removed
10696 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10698 * get.c: Added GTSV_OPT_* series of enums.
10699 (trim_dictionary, dict_delete_run) New functions.
10700 [DEBUGGING] (dump_dict_variables) New function.
10701 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10702 [DEBUGGING] Calls dump_dict_variables() to display results.
10704 * glob.c: (cmp_variable) Now a public function declared in var.h.
10706 * sfm-read.c: Turned off debug code. Comment fixes.
10707 (read_machine_int32_info, read_machine_flt64_info) New functions
10708 to parse type 7 records.
10709 (sfm_read_dictionary) Properly byteswaps several fields now.
10710 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10711 records. [DEBUGGING] Dumps dictionary.
10712 (read_variables) Sets `index' field of variables created properly.
10713 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10714 longer dumps dictionary.
10715 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10717 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10719 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10720 var before destroying any variables just to save a little time.
10722 * var.h: (struct variable) Reordered in order to make name[] the
10723 first member; this makes pointers to `variable' pointers to the
10724 variable name, simplifying avl trees, etc.
10725 (struct indirect_dictionary) New struct.
10727 * vars-atr.c: (find_variable) Rewritten for efficiency.
10728 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10730 (is_varname) Rewritten for efficiency.
10731 (parse_variables) New argument, which is a `dictionary *'. All
10732 references changed. This function now reads variable names from
10733 the dictionary passed, or from the default dictionary if NULL.
10735 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10737 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10738 rounding up. Changed many references to ROUND_UP to use this
10741 * sfm-read.c: Includes avl.h.
10742 (corrupt_msg) Induces a segfault under Checker.
10743 (macro assertive_bufread) New. Many references to bufread() now
10745 (sfm_read_dictionary) Split up into several functions. Added code
10746 to read dictionary records following the the type 2 records. Not
10747 quite complete. New variable `var_by_index'.
10748 (read_header, read_variables) New functions extracted from
10749 sfm_read_dictionary().
10750 (read_value_labels) New function.
10751 (bufread) Checks ferror() if fread() doesn't return the expected
10752 value; if ferror() is zero it's just EOF.
10753 (dump_dictionary) Stubbed out.
10755 * BTW: The source code now exceeds 50000 lines!
10757 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10759 * command.c: Added GET to cmd_table[].
10761 * list.q: Removed reference to alloca headers.
10762 (cmd_list) Gave prototype.
10764 * sfm-read.c: Added DEBUGGING comments.
10765 (sfm_read_dictionary) Checks bias correctly. Sets
10766 dict->var_by_name to NULL. Calculates long_string_count
10767 correctly. realloc's dict->var[] array to minimum size.
10768 [DEBUGGING] Calls dump_dictionary.
10769 [DEBUGGING] (dump_dictionary) New function.
10771 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10772 (restore_dictionary) If the dictionary contains a non-NULL
10773 var_by_name, uses that instead of generating one.
10774 (free_dictionary) Destroys var_by_name.
10776 * var.h: (struct dictionary) Added field `var_by_name'.
10778 * get.c: New file, not complete.
10780 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10782 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10783 (parse_num_or_range) New function.
10784 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10785 <n> THRU HIGH missing values.
10787 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10788 __attribute__((const)).
10790 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10792 * sfm-read.c: Finished reference implementation.
10794 * sfm.h: Includes var.h.
10796 * var.h: Comment fixes.
10797 (struct `variable') Reordered some fields.
10799 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10800 constants added previously.
10802 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10804 * common.h: Comment fixes. Added declaration of
10805 `second_lowest_value' as variable or macro. Made `compat_type',
10806 `pgm_state_type' into anonymous enums.
10808 * display.c: Comment fix.
10810 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10812 [!defined SECOND_LOWEST_VALUE] Added definition for
10813 `second_lowest_value' global var.
10814 (compat, pgm_state global vars) Changed types to `int'.
10815 (init_glob) Initializes `second_lowest_value'.
10817 * sfm-read.c: Continued work, not complete.
10819 * var.h: Added new MISSING_* constants to handle LOWEST and
10822 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
10824 * sfm-read.c: New file, not complete.
10826 * cases.c: (vec_insert) Changed vector expansion algorithm.
10827 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
10828 mucking up the RECODE transformation in particular.
10829 (envector) Harmless change in notation.
10831 dfm is now fairly well tested again.
10832 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
10834 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
10836 * recode.c: Comment fix.
10838 * sfm.h: Interface should be fairly final now, or at least for a
10841 * vfm.c: [DEBUGGING] (index_to_varname) New function.
10842 (open_active_file) [DEBUGGING] Translates ccase indices into
10843 variable names now to make it easier to understand what's really
10846 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
10848 * data-in.c: Comment fix.
10850 * data-list.c: Includes dfm.h.
10851 (do_reading) Uses new function dfm_push_cust().
10853 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
10854 `return 1;' at end.
10856 * file-handle.h: Completely changed. Some parts split off into
10857 new file dfm.h. Implemented in file-handle.q.
10858 (enum FH_*) Removed.
10859 (struct fh_ext_class) New struct.
10860 (struct file_handle) Retained only these fields: name, norm_fn,
10861 fn, recform, lrecl, mode. New fields class, ext.
10862 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
10863 close_handle, handle_name) Added `fh_' prefix to name, all
10864 references changed.
10866 * dfm.h: New file, implemented in dfm.c.
10867 (get_record, put_record, fwd_record, bkwd_record, set_record,
10868 get_cur_col) Functions moved from file-handle.h, now prefixed with
10870 (dfm_push_cust) New function.
10872 * sfm.h: New file. Incomplete.
10874 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
10875 interface. Functions reordered, comments changed. Not well
10876 tested, probably full of bugs.
10877 (struct dfm_fhuser_ext) New struct.
10878 (dfm_close) New function.
10879 (open_file_r) Pickier about finding `BEGIN DATA.' line.
10880 (open_file_w) User messages changed.
10881 (get_record) Comment fixed.
10882 (read_record) Increments ext->ln even for inline_file. Calls
10883 dfm_close() for inline_file when `END DATA.' encountered.
10884 (dfm_get_record) Experimental restructuring.
10885 (dfm_push_cust) New function.
10886 (cmd_begin_data) Detects whether the inline file was fully read by
10887 checking whether it is still open; detects whether it was read at
10888 all by checking whether the line number is greater than zero.
10890 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
10891 interface. Functions reordered, comments changed. Not well
10892 tested, probably full of bugs.
10893 (init_file_handle) Removed initializers for obsolete fields, added
10895 (fh_close_handle) Much simpler, now mainly calls the class
10897 (fh_init_files) Renamed inline file internal filename.
10899 * file-type.c: Includes dfm.h.
10900 (read_from_file_type) Doesn't use dfm internal state anymore.
10902 * inpt-pgm.c, print.c: Include dfm.h.
10904 * recode.c: (internal_cmd_recode) Casts strlen() return value to
10905 int in comparison with other int.
10907 * som-high.c: (build_target) Fixed operator precedence problem in
10908 if statement (& versus ==).
10910 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
10912 * dfm.c: (read_record) Can now read fixed-length records; not
10914 (put_record) Can now write fixed-length records; not tested.
10916 * file-handle.h: FH_* defines changed to enums. New enum series
10918 (struct file_handle) New members recform, lrecl, mode.
10920 * file-handle.q: Parser changed.
10921 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
10922 /LRECL subcommands. These are compatible with Windows.
10923 (init_file_handle) Initializes recform, mode fields.
10925 * q2c.c: (get_line) When outputting `!' comment lines, now
10926 increments the output file line number so that `#line' directives
10928 (make_identifier) New function that converts an arbitrary string
10929 into a valid C identifier.
10930 (dump_vars) Calls make_identifier() in two places in order to
10931 suppress some errors for bad identifiers.
10932 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
10933 for NO. Allows numbers to be prefixed by underscores to make them
10934 acceptable C identifiers but still to be parsed as numbers by the
10937 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
10939 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
10941 * dfm.c: Comment fixes. (get_record) Gives error if file handle
10942 was opened for writing.
10943 (open_file_w) New function.
10944 (read_record) Uses strncasecmp if available. Improved error
10945 messages, comments.
10946 (put_record) New function.
10948 * file-handle.h: Moved function comments into dfm.c and
10949 file-handle.q. Comment fixes. Removed declarations of
10950 tilde_expand() and normalize_filename().
10951 (struct file_handle) Changed `open' from boolean to enumerated
10952 field to allow for three states--closed, open for reading, open
10953 for writing--all references changed.
10955 * file-handle.q: Includes filename.h.
10957 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
10958 references changed.
10959 (alloc_line) Makes allowance for line terminator characters in
10961 (print_trns_proc) Now handles OUTFILE, WRITE differences.
10962 (print_space_trns_proc) Handles OUTFILE differences.
10964 * recode.c, sample.c: Comment fixes.
10966 * var.h: (struct print_trns) Changed boolean field `eject' to
10967 bitmapped field `options'; all references changed. New enums
10968 PRT_* for use with this field.
10970 * exception.h, test-exception.c: Removed.
10972 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
10974 * ascii.c: (delineate) Turned off debug output.
10976 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
10979 * data-in.c: (parse_string_as_format) Sets the entire string value
10980 to spaces, not just the short string part of it. Is this correct
10983 * data-out.c: (convert_date) Fixed DATETIME format problems with
10984 decimal places, removed debug code.
10986 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
10987 middle of parsing BEGIN DATA that would cause the lexer to read
10988 from a wild pointer `prog'; now calls new function
10989 preprocess_line() in lexer.c.
10991 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
10993 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
10994 Now call induce_segfault() to induce the segfault.
10995 (induce_segfault) New function.
10997 * expr-opt.c: Comment fix.
10998 (parse_sysvar) New function.
10999 (parse_primary) Added system variable support--calls
11001 (global var ops) Added OP_CASENUM operator.
11003 * expr.h: Comment fixes.
11004 (OP_* enum) added OP_CASENUM operator.
11005 (struct casenum_node) New struct.
11006 (union any_union_union) New member `cas' of type `casenum_node'.
11008 * glob.c: (global var last_vfm_invocation) New var.
11009 (init_glob) Initializes last_vfm_invocation.
11011 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11013 * getline.c: (get_line) Split into get_line() and preprocess_line().
11014 (preprocess_line) New function.
11016 * var.h: Declares last_vfm_invocation.
11018 * vfm.c: (procedure) Sets last_vfm_invocation.
11020 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11022 * command.c: (parse_cmd) Fixed bad assertion related to
11025 * data-in.c: (parse_month) Implemented to parse months according
11026 to full interpretation of standard.
11027 (to_roman) New function.
11028 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11029 (parse_weekday) Bug fix (forgot to skip all the day name).
11031 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11032 up parsing of multirecord data items. Also fixed user message.
11034 * data-out.c: Comment fix.
11035 (year2, year4, convert_date, convert_time, convert_WKDAY,
11036 convert_MONTH) New functions to support time & date output.
11037 (convert_format_to_string) Calls new time & date output routines.
11039 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11041 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11044 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11046 * misc.c: (global var formats) Fixed declarations of DATETIME,
11049 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11050 the output_char buffer.
11052 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11053 memory bug. Fixed user messages.
11055 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11057 * Removed #pragma argsused from lots of places.
11059 * data-in.c: Implemented zoned decimal and time-date formats.
11060 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11063 * data-out.c: Implemented zoned decimal format.
11065 * expr.h: Moved yrmoda() declaration here from exprP.h.
11067 * misc.c: (global var formats) Minor fixes--added
11068 FCAT_SHIFT_DECIMAL to formats N and Z.
11069 (convert_fmt_ItoO) Added support for format Z.
11071 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11073 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11075 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11076 som_check_workspace() that is activated between commands.
11078 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11081 * list.q: (begin_row) Changed title expansion style from
11082 SOPT_X_VERT to SOPT_X_SHSP.
11084 * som-frnt.c: Now includes `somP.h'.
11085 (som_push_workspace, som_pop_workspace) New functions that, taken
11086 together, form a solution to the recursive table building problem
11087 mentioned yesterday. Surrounded every table output routine
11088 throughout the program with calls to these functions.
11089 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11090 (som_create_table) Checks that there's an active workspace.
11091 (som_destroy_all_tables, som_crush) Removed.
11093 * som-high.c: (global var som_preserve_tables) Removed, all
11094 references deleted.
11095 (som_submit_table) Checks that there's an active workspace.
11096 (dump_columnated_table) Doesn't columnate tables that would have
11097 just one row per column.
11098 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11099 (som_dump_crush_page) Moved row number labels from left side of
11100 tables to right side.
11101 (som_get_table_size) Added support for SOPT_X_SHSP.
11103 * som.h: New cell expansion type SOPT_X_SHSP.
11105 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11107 (global var curtab_arena) Moved from som-frnt.c.
11109 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11111 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11112 that causes bad location warnings to be suppressed.
11113 (delineate) Saves current font when calling draw_text(); fixed
11114 handling of NULLs when backing up. Also fixed line-wrapping bug.
11116 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11117 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11119 * common.c: Added code to cause assertion failure to dump core
11120 when run under Checker.
11122 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11123 there are still bugs.
11125 * glob.c: (__eprintf) Removed.
11127 * list.q: Inserted som_preserve_tables kluge that prevents tables
11128 from being thrown away due to recursive table building through
11129 som_output_line being called from a transformation during the LIST
11130 procedure invocation. This is a general problem that must be
11131 solved in a better way since it applies to all procedures in
11133 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11134 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11136 * numeric.c: Fixed several errors in the form of msg() calls.
11138 * print.c: Updated for use of som.
11139 (dump_table) Reimplemented.
11140 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11141 Calls som_output_text() instead of outs_line().
11143 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11145 (som_output_text) Function moved from som-low.c. Interface
11148 * som-high.c: (som_preserve_tables) New global public variable
11150 (som_submit_table) Destroys the tables only if som_preserve_tables
11152 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11153 one subrow per row. Now labels subrows if there's more than one
11155 (dump_crush_table) Added wishlist comment.
11156 (som_eject_page) New public function declared in som.h.
11158 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11159 more than one subrow per row.
11160 (som_output_text) Moved to som-frnt.c.
11162 * som.h: (SOM_TOPT_PRESERVE) Removed.
11164 * title.c: (get_title) Changed interface.
11165 (cmd_title) Changed `title' to `outp_title'.
11166 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11168 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11170 * list.q: (flush_table) Conforms to new partial options in
11171 som_submission_form.
11173 * som-high.c: (paginate_horizontally) Changed form of subrow
11175 (build_target) Omits spacing before table if
11176 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11177 (dump_crush_page) Changed interface. Only trims bottom rule if
11178 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11179 (dump_crush_table) Handles partial tables.
11180 (output_row_label) New function.
11181 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11182 rule on the right edge of narrow subrows.
11184 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11185 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11186 All references updated.
11188 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11190 * misc.c: Comment fix.
11192 * som-high.c: (examine_table) Treats crushed tables separates for
11193 purpose of determining header size.
11194 (paginate_horizontally) Allots space for line numbers in crushed
11195 tables with lots of subrows per row. Calculates the `maximum page
11196 width', the width of the widest horizontal page.
11197 (build_target) Removed trim argument; all references changed.
11198 Stricter assertions. (dump_crush_page) New function.
11199 (dump_crush_table) Reimplemented.
11201 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11202 (som_dump_crush_page) Reimplemented, interface changed.
11204 * somP.h: Many many new helper macros for use with crushed tables.
11205 (global var som) Removed `tv', `cum_y' members; all references
11206 removed. New members `mpw', `digit_space'.
11208 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11210 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11211 variable, changed to constant 1024.
11212 (arena_ca_strdup) Changed `sizeof(a_string)' to
11213 `sizeof(c_string)'.
11214 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11215 `(c_string *)' to `(char *)'; this fixed some offset problems.
11217 * filename.c: (readlink_malloc) Changed initial allocation from
11219 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11222 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11223 &fm->owner in several places.
11225 * som-high.c: (output_table) Changed interface to rest of world.
11226 (examine_crush_table) Removed. Crushed tables are re-broken now,
11227 in preparation for rewrite.
11229 * som.h: Comment fix.
11231 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11233 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11234 itself in the cleanup stage.
11236 * descript.q: (display) At least temporarily, changed the table
11237 format to a crushed table.
11239 * list.q: (begin_row) At least temporarily, added horizontal lines
11242 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11243 the horizontal "headers," that is, to the width of the far left
11244 and far right rules.
11245 (justify_pagination) Sets som.th to the width of the widest row
11246 in the crushed table. Fixed inner loop off-by-one error.
11248 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11251 * somP.h: Comment fix.
11253 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11255 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11256 before closing it; also, opens the constructed filename `s'
11257 instead of f->filename.
11259 * postscript.c: Moved initialization of x->loaded, x->prop,
11260 x->fixed, x->current, also the add_encoding() calls, into
11262 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11263 sets x->last_font to NULL; sets x->next_combo to zero.
11265 * som-high.c: (crushed_row_height) Moved definition farther up.
11266 (som_submit_table) Doesn't calculate line width, font size until
11267 after calling open_page(), to accomodate changes to PostScript
11269 (vert_headers) Removed; equivalent functionality moved to
11270 examine_table(), examine_crush_table().
11271 (justify_pagination) Replaced with different algorithm.
11272 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11273 at the bottom of the page.
11275 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11277 * command.c: Added cmd_list back into cmd_table.
11279 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11280 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11282 * list.q: (flush_table) Updated to new som_submission_form format.
11284 * som-frnt.c: Comment fix.
11286 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11287 (output_table) Calls som_get_table_size() directly; handles
11289 (examine_crush_table) New function; calls vert_headers().
11290 (examine_table) Moved some code into new function, vert_headers().
11291 (justify_pagination) New function.
11292 (dump_plain_table) Removed `static' from `cy'.
11293 (dump_crush_table) New function.
11295 * som-low.c: (som_dump_crush_page) New function.
11297 * som.h: Comment fixes.
11298 (enum SOM_TOPT_CRUSH) New.
11299 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11300 Temporarily set to zero to make do with LIST procedure.
11302 * somP.h: Re-ordering.
11304 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11306 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11308 * somP.h: New file for use by som-high.c, som-low.c.
11310 * q2c.c: Added definition for VME.
11311 (get_line) Now dumps `!' comment lines to the output file
11314 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11315 set.q: Changed format of `!' comment lines.
11317 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11319 * All source files: Added copyright notice.
11321 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11322 longs in msg() calls.
11324 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11326 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11328 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11330 * output.c: (outp_read_devices) Changed criteria for
11331 distinguishing different types of lines.
11333 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11335 * cmdline.c: Changed syntax message.
11337 * filename.c: (good_getcwd) Bug fix (?).
11338 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11340 (search_path) Appends DIR_SEPARATOR to directory name only if it
11341 does not already end with one.
11343 * glob.c: Checks STAT_PAGER envvar before PAGER.
11345 * output.c: Checks environment variables instead of just local
11348 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11350 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11351 when the pointer passed to the function was within the arena
11352 itself, so that it couldn't properly be set to NULL _after the
11355 * command.c: Re-enabled DISPLAY.
11357 * display.c: Rewritten to handle tables. Untested.
11359 * filename.c: (search_path) Fixed memory leak.
11361 * frequencies.q: (cmd_frequencies) Frees v_variables.
11362 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11363 (cleanup_freq_tab) New function to garbage collect.
11364 (dump_full) Elegantized.
11366 * main.c: New comment.
11368 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11370 * postscript.c: Comment fix.
11371 (release_fontmap, free_font_entry) New functions.
11372 (ps_init_driver) Sets free_font_entry() as the freefunc for
11373 hashtable `loaded'. Calls release_fontmap() when destroying a
11374 driver; also frees the output filename; also frees the
11375 ps_driver_ext block.
11376 (free_ps_encoding) Frees the filename as well as the encoding
11378 (output_encodings) Frees the line buffer and pops the msg-filename
11380 (read_fontmap) Frees the fontmap filename and the line buffer.
11381 (postopen, preclose) Misc. garbage collection fixes.
11382 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11383 to NULL; this fixes some output problems.
11384 (text) Handles TAG_NEWLINE. Untested.
11386 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11387 (som_set_string) Removed. All references changed to
11389 (som_set_text) Rewritten. New interface. More general.
11391 * som.h: Minor format changes.
11392 (struct som_value_cell) Removed; all references changed to
11394 (enums SOT_*) Changed.
11396 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11398 * command.c: Re-enabled SPLIT FILE.
11400 * postscript.c: Comment fix.
11402 * som.h: Added `SOT_NONE'.
11404 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11406 * vfm.c: (dump_splits) Reimplemented.
11408 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11410 * Compiled the project under gcc 2.7.2, which gave some new
11411 warnings. This led to many additions of casts from unsigned to
11412 int sprinkled throughout the code.
11414 * arena.c: Many uses of `unsigned' changed to `size_t'.
11416 * command.c: Added END FILE, END REPEAT to command table.
11417 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11418 (find_command, FILE_TYPE_okay) Not commented out anymore.
11419 (parse_cmd) Calls FILE_TYPE_okay again.
11420 (output_line) Added calls to som_output_text() to put the line
11421 in the output files.
11423 * common.c: (macro VME) Format changes.
11424 (xstrdup) Asserts that its argument is not NULL.
11426 * data-list.c: Implemented dump_fixed_table().
11428 * inpt-pgm.c: Formatting changes. Comment changes.
11429 (end_case_proc) Renamed end_case_trns_proc.
11430 (cmd_end_file, end_file_trns_proc) New functions.
11432 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11434 * misc.h: (local_strdup) New macro corresponding to strdup() but
11435 allocating its data through local_alloc() if possible--that is, if
11438 * postscript.c: Comment changes.
11439 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11440 (output_line, add_string) New macros supporting
11441 output_encodings().
11442 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11443 substitution vars. Calls output_encodings() when a line
11444 consisting of `!encodings' is encountered.
11445 (preclose) Some code moved into quote_ps_string().
11446 (dump_line) Changed into macro supporting dump_fancy_line().
11447 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11448 command when appropriate.
11449 (write_text) Fixed `literal_char' array (I think it's fixed, at
11451 (text) Fixed bug when width was zero. Now exits immediately on
11452 zero height_left. Now, when executing `goto restart;', checks
11453 that cp<end, so that we don't read beyond end-of-string. Also,
11454 outputs the correct code to the output file by outputting the code
11455 from the metric instead of the internal metric index.
11457 * repeat.c: (cmd_end_repeat) New function.
11459 * som.c: (var som) `headers' renamed `options' and semantics
11460 changed. All references changed.
11461 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11462 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11464 (som_text_table) Removed.
11465 (som_output_text) New function.
11467 * som.h: (struct som_submission_form) Removed `header', `reuse',
11468 replaced with bitmapped field `options'.
11469 (SOM_TOPT_*) New enum set for som_submission_form.options.
11470 (SOT_*) New enum set for som_output_text().
11472 * temporary.c: (copy_variable) When copying the var label, only
11473 calls xstrdup() if it's non-NULL.
11475 * var.h: (enum type `vartype') Removed; all references changed to
11478 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11481 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11483 * font.h: Comment changes.
11485 * groff-font.c: (groff_read_font) Initializes `name' field to
11486 NULL. Handles `encoding' field.
11488 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11490 * postscript.c: (struct font_entry) Removed `position' field.
11491 (struct ps_font_combo) New struct.
11492 (struct ps_driver_ext) Removed field `next_position'. New fields
11493 `combos', `next_combo'. `last_font' field changed from
11494 `font_entry *' to `ps_font_combo *'.
11495 (ps_init_driver) Reformatted; handles new fields. When
11496 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11498 (get_encoding, find_encoding_file) New functions.
11499 (add_encoding) Some code moved out into find_encoding_file().
11500 (postopen) Changed value for ${title}.
11501 (preclose) Sets `loaded' field to NULL after destroying the hash
11503 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11505 (ps_text_set_font_by_position) Figures out the current family if
11507 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11508 (switch_font) Implemented.
11509 (write_text) Calls switch_font() more often. Format changes.
11510 #undefs its macros after they're no longer useful.
11511 (text) Changed `continue' at one point to a jump to the top of the
11512 loop because we don't want `separate' reset to 0 at that point.
11513 (load_font) No longer sets `position' in the font_entry created.
11515 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11517 * font.h: (struct font_desc) New member `encoding', which is not
11518 properly handled yet.
11520 * glob.c: (init_glob) Some new i18n code, which is probably
11523 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11524 `size' local from `int' to `size_t'.
11526 * postscript.c: New driver configuration parameter `auto-encode'.
11527 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11528 (struct font_entry) New member `position'.
11529 (struct ps_driver_ext) Reordered. New hash table member
11530 `encodings'; new members `next_position', `next_encoding',
11531 `last_font'. Members `current', `prop', `fixed' changed from type
11532 `font_desc *' to `font_entry *'; all references changed.
11533 (struct ps_encoding) New struct.
11534 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11535 free_ps_encoding, add_encoding) New functions.
11536 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11537 x->output_options. Initializes new members of ps_driver_ext.
11538 Changed default value for prologue_fn, encoding_fn. Calls
11539 read_ps_encodings after loading default fonts.
11540 (option_tab[], ps_option) Handle new configuration parameter.
11541 (switch_font) New function.
11542 (struct output_char) `font' member changed from `font_desc *' to
11543 `font_entry *'. New member `separate'.
11544 (read_fontmap) Changed `size' from `int' to `size_t'.
11545 (output_line, put_number) New macros for write_text().
11546 (write_text) Optimizes text output by consolidating multiple
11547 calls to PostScript `show' operator.
11548 (text) Keeps track of when text arguments can't be consolidated by
11549 write_text(), and marks those spots in the output stream.
11550 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11551 the font hasn't been switched to by switch_font(), which is where
11552 the position is important--the PostScript is what cares about the
11555 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11557 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11558 call a NULL free_func.
11559 (hsh_rehash) Elegantized.
11560 (hsh_probe) Fix bug that manifested when the table was expanded
11561 and thus had to change location in memory. Good thing
11562 too--otherwise could have been much more subtle.
11563 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11564 (hsh_foreach) New function for hash table iteration.
11566 * hash.h: (struct hsh_iterator) New.
11568 * lexer.c: (parse_tagged_quote) Font and family name strings in
11569 tags are now null-terminated.
11571 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11573 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11574 documented. (Never before tested?)
11576 * output.h: Comment changes.
11578 * postscript.c: New driver options `optimize-text-size',
11579 `optimize-line-size', `max-fonts-simult'. New enum set for
11580 specing cached line types. Comment fixes.
11581 (struct line_form) New struct.
11582 (struct ps_driver_struct) New members `text_opt', `line_opt',
11583 `max_fonts', `lines'.
11584 (ps_init_driver) Initializes new members of ps_driver_struct.
11585 (user option type enum set) New member `nonneg_int_arg'.
11586 (static var option_tab[]) Supports new options.
11587 (ps_option) Handles new options.
11588 (find_ps_file) Made static. No longer calls hsh_dump().
11589 (ps_get_var) Made static.
11590 (preclose) Dumps out proper DSC trailer.
11591 (ps_open_page) Elegantized.
11592 (ps_close_page) Calls dump_lines() if appropriate.
11593 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11594 wrappers around line().
11595 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11596 dump_lines, hash_line, free_line, line) New functions for support
11598 (write_text, text) Made static.
11599 (text) Added to font support, not finished.
11601 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11603 * font.h: (struct font_desc) New members ascent, descent.
11605 * groff-font.c: (groff_read_font) Calculates font ascent and
11606 descent from the ascent and descent of the `d' and `p' characters,
11607 respectively, as per a suggestion on comp.fonts.
11609 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11610 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11612 (write_text) Handles text right-justification and centering (not
11613 full justification). Still very inefficient. (One output line
11615 (struct output_char) Added fields for font and font size.
11616 (text) Many bugfixes.
11618 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11620 * cmdline.c: (usage) Calls outp_list_classes().
11622 * font.h: Comment fix.
11624 * groff-font.c: New exported global var `space_index'.
11625 (groff_init) New function to initialize `space_index'.
11626 (hash_kern) Casts result to unsigned.
11627 (font_name_to_index) Renamed font_char_name_to_index. All
11628 references changed. Also, now returns the value of `space_index'
11629 when passed an ASCII space character as an argument. Fixed
11631 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11632 Handles passed NULL pointers properly.
11634 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11637 * output.c: (outp_list_drivers) Removed. Removed all references.
11639 * output.h: Comment fixes.
11641 * postscript.c: (ps_open_global) Calls groff_init().
11642 (output_char) New structure.
11643 (write_text) New function.
11644 (text) No longer stubbed out! Now the output is correct--with a
11645 few exceptions, one of them being that the page has to be held
11646 upside down into a mirror.
11648 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11650 * font.h: Comment fix.
11652 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11653 All callers changed.
11654 (number_to_index) Renamed font_number_to_index, made extern. All
11656 (font_get_kern_adjust, font_get_char_metrics) New functions.
11658 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11660 * postscript.c: Changed default line width back to 1/2 point.
11661 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11662 in the center of the space allotted for them, not just a fixed
11663 offset from the edge of the space; this fixes some bugs.
11664 (ps_line_intersection) Now supports all command line styles.
11665 (ps_text_get_size) Bug fix in computation of em width.
11666 (text) New function, the meat behind ps_text_metrics and
11667 ps_text_draw. Not complete.
11668 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11669 ascii.c; call text().
11671 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11673 * arena.c: (arena_free) Assert that the argument is non-NULL.
11675 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11676 only if old_kern is non-NULL.
11678 * postscript.c: (ps_init_driver) Changed default line width to 1
11680 (postopen) New prologue variables.
11681 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11682 more of the common line styles properly, but not all.
11683 (ps_text_metrics) Fixed problem with this stubbed out version that
11684 kept it from taking font sizes into account.
11686 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11688 * arena.c: (arena_malloc) Bug fix.
11689 (arena_dump) [GLOBAL_DEBUGGING] New function.
11691 * ascii.c: Comment fix.
11692 (count_fancy_chars, delineate) Now static functions.
11694 * filename.c: (interp_vars) Bug fixes.
11696 * font.h: Comment fixes.
11698 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11699 beginning in case we have an error message to display before
11700 initializing the display.
11702 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11704 (groff_read_font) Bug fixes.
11705 (name_to_index) Increments hash.used. Sets `name' field of hash
11707 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11709 * hash.c: Return type changed.
11711 * postscript.c: Continued development. Now marks lines on the
11712 paper, but very buggy.
11714 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11716 * Changed comments in many source files from `/* xxx /* yyy */' to
11717 `/* xxx */ /* yyy */' for cleanliness.
11719 * arena.c: (arena_sd_strdup) New function.
11721 * ascii.c: (struct ascii_driver_ext) New member `file'.
11722 (ascii_init_driver) Fills out member `file' for initing; uses
11723 close_file_ext for closing drivers.
11724 (ascii_option) Changed %.*s back to %s because the a_string's are
11725 always null-terminated.
11726 (postopen, preclose) New functions.
11727 (ascii_open_page) Uses new style of open_file_ext.
11728 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11729 instead of this->output.
11730 (__assert_fail) Removed.
11732 * cmdline.c: Changed syntax_message[].
11734 * error.c: #include's <readline/history.h> only if the history
11735 library is available, not if just the readline library is
11738 * filename.c: (expand_line) Removed alloca() support.
11739 (interp_vars) No longer tilde-expands argument. Limit on output
11741 (tilde_expand) Now treats argument as path rather than filename.
11742 [!unix] Now is a no-op function.
11743 (search_path) Better verbose message formatting.
11744 (open_file, close_file) Comment fixes.
11745 (close_file) [!unix] Doesn't bother with pipes.
11746 (open_file_ext) Completely rewritten, interface revamped.
11747 (close_file_ext) New function.
11749 * font.h: Comment changes.
11751 * frequencies.q: Removed AIX alloca support since it doesn't use
11754 * hash.c: Comment changes & additions.
11755 (hsh_create) Initializes entire table instead of first M entries.
11756 (hsh_probe) Stupid bug fixed. Now it works.
11757 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11759 * main.c: (parse) Detects EOF properly in token-eating loop.
11760 Should the STOP token have its value changed to 0?
11762 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11763 (blp_getline) Now it's a macro.
11765 * output.h: (struct outp_driver) Removed members output, filename.
11767 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11768 drivers in driver table.
11769 (outp_read_devices) Frees buf. Warns if there are no active
11771 (outp_configure_clear) Sets outp_configure_vec to NULL after
11772 deleting its elements.
11773 (configure_driver, destroy_driver) Removed references to output,
11774 filename members of outp_driver.
11775 (outp_evaluate_dimension, internal_get_paper_size,
11776 outp_get_paper_size) New functions.
11778 * postscript.c: Continued development. Now links but doesn't make
11779 any marks on the page. Lotsa bugs I suppose.
11781 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11783 * str.h: Comment changes.
11785 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11787 * Removed dependencies on non-nested comments in several files.
11788 Also removed references to (unix || __unix__) in #if's since
11789 prefh.orig makes those two equivalent.
11791 * ascii.c: (ascii_open_global) Creates ascii_arena.
11792 (ascii_close_global) Destroys ascii_arena.
11793 (ascii_init_driver) Doesn't create ascii_arena.
11794 (ascii_copy_driver) Removed.
11795 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11796 (outp_class ascii_class) Removed ascii_copy_driver reference.
11798 * frequencies.q: Now can display all statistics except median.
11799 Still not finished.
11801 * output.c: Handles outp_class.ref_count so output class
11802 destructors are called properly.
11803 (add_class) Sets ref_count to 0.
11804 (configure_driver) Initializes class if ref_count++ is 0.
11805 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11806 class output file name.
11808 * output.h: (struct outp_class) Removed copy_driver, inited.
11811 * postscript.c: Completely replaced but not finished.
11813 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11815 * approx.h: #includes <float.h>.
11817 * arena.h, arena.c: Many functions changed to take an arena **
11818 instead of an arena *, for consistency. All callers changed.
11819 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11820 (arena_destroy) Sets *A to NULL.
11822 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
11823 assertion that `width' be positive.
11825 * command.c: Removed #if's from cmd_table.
11826 (walk_cmdtable_func) [0] New function (debug code).
11827 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
11828 (parse_cmd) Doesn't return failure for unimplemented commands.
11830 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
11831 (SYSCODE) New constant macro.
11833 * descript.q: Checks for positive n_variables before performing
11836 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
11837 avl_find instead of &fp as arg 2.
11839 * frequencies.g, frequencies.q: Continued updating; now compiles &
11840 works again, but not complete.
11842 * main.c: Changes to user messages.
11844 * misc.c: (reverse) [0] New function.
11846 * settings.h: Comment removed. #includes "common.h".
11848 * som.c: (som_set_null) New function.
11849 (som_set_value, som_set_string, som_set_text) More detailing
11851 (som_set_float) Implemented function.
11852 (dump_columnated_table) Bug fix regarding page breaks.
11853 (draw_cell) Bug fix regarding text that spilled out of a cell.
11854 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
11856 (get_cell_size) Support SCON_EMPTY cells.
11857 (get_table_size) When calculating rules' widths and heights, mask
11858 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
11860 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
11862 (struct som_submission_form) New member `header'; all users
11865 * val-labs.c: (get_label) User messages changed.
11867 * var.h: Changed FREQUENCIES structures.
11869 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
11872 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
11874 * approx.h: Definition of EPSILON now depends on system's
11875 DBL_EPSILON. Removed GNU C specific code.
11876 (cmpapx) Renamed approx_compare.
11878 * frequencies.g, frequencies.q: Continued updating; still doesn't
11881 * groff-font.c: (name_to_index) Fix bug that kept it from
11884 * hash.c, hash.h: Completed work.
11886 * var.h: Changes to freq_tab, frequencies_proc.
11888 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
11891 * hash.c, hash.h: New files. Not completed.
11892 * Makefile.am: Added hash.c to source file list.
11893 * font.h: (struct font_desc) New member kern_size_p.
11894 * groff-font.c: Uses hash.h.
11895 (hashpjw) Moved to hash.c.
11896 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
11898 (static var hash) New member size_p.
11899 * var.h: Includes hash.h.
11900 (struct freq_tab) Changed AVL_TREE to hash_tab.
11902 * vars-prs.c: Comment, formatting fixes.
11904 * frequencies.g, frequencies.q: Continued updating. Not yet
11907 * formats.c: Bug fix.
11909 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
11911 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
11912 * descript.g: Comment fixes.
11913 * descript.q: Comment fixes. Moved some declarations into var.h.
11914 Made dsc_info a static table. Updated FIXMEs.
11915 (internal_cmd_descriptives) Beautified.
11917 * frequencies.q: Started updating into working order.
11918 * frequencies.g: New file analogous to descript.g.
11919 * var.h: Comment fixes. Added structures for FREQUENCIES.
11921 * som.c: Removed vestiges of crushing and partial table support.
11923 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
11925 * Many more changes to som.c especially, but these will not be
11926 documented as I have resolved to remove them. This patchlevel is
11927 being released solely so that I can fall back to it if I decide
11928 that removing the changes is not a good idea.
11930 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
11932 * som.c: (global var som) New member `cum_y'.
11933 (build_target) Properly handles titles for partial tables.
11934 (dump_partial_beg, dump_partial_mid, dump_partial_end)
11935 Merged into single new function dump_partial(). Fixed problem
11936 with titles on partial tables.
11937 (dump_table) Calls dump_partial() for all parts of partial tables.
11938 (dump_page) Criteria for drawing title changed.
11940 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
11942 * command.c: (cmd_table) Added LIST, WEIGHT.
11944 * command.c: (cmd_remark) No longer frees `s' since it's not
11945 dynamically allocated.
11947 * data-out.c: (convert_f) Now correctly handles the case where
11948 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
11949 number of decimals.
11950 (som_destroy_all_tables) Removed argument. All callers changed.
11951 (som_vline, som_hline) Argument validity checking corrected.
11952 (som_set_value) Implemented half-heartedly.
11953 (replicate_table) Copies tables piece-by-piece when using Checker.
11955 * som.h: New line style SLIN_1THIN, currently equivalent to
11956 SLIN_0. New enum set SOM_SUB_*.
11957 (struct som_submission_form) Removed `seq_no'. Added `type'.
11959 * list.q: Newly working file; uses partial tables.
11961 * som.c: (som_reduce_table) Renamed som_set_table_height().
11962 (som_crush) Removed argument `group'.
11963 (global var som) Removed `nt', `seq_no'. Added `type'.
11964 (som_submit_table) Arguments changed.
11965 (output_table) Removed partial table code.
11966 (build_target) New arg; partial table support added. All callers
11968 (dump_plain_table) Removed partial table code.
11969 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
11970 (dump_table) Supports partial tables.
11971 (dump_page) New argument to allow not drawing top and/or bottom
11972 headers. All callers changed. Supports partial tables.
11974 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
11976 * data-out.c: Changed `#include <approx.h>' to `#include
11978 (convert_F) Comment fix. Now won't print `-.000', etc.
11980 * descript.q: Now Z-scores work, although there appears to
11981 be a bug (which might actually be in data-out.c:convert_F()).
11982 (descriptives_trns_proc, descriptives_trns_free) New functions.
11983 (run_z_pass) Implemented.
11985 * var.h: Comment fixes.
11986 (dsc_z_score, descriptives_trns) New structs.
11987 (descriptives_trns) Added to any_trns as `dsc'.
11989 * error.c, error.h: New error class, IS (Installation Script
11990 error), used in those instances where the error is in the
11991 installation, but there is a script file or installation file that
11992 can be usefully referred to.
11994 * output.c: Change many IE classes to IS classes.
11996 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
11997 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
11998 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
11999 include the corresponding header?
12001 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12002 Don't bail out if termcap can't be read.
12004 * som.c: (som_destroy_table) Removed.
12005 (som_reduce_table, som_destroy_all_tables) New functions.
12006 (som_crush) New function, not implemented.
12008 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12009 som_submission_form. Function prototypes revised.
12011 Outputting huge tables (1000s of rows) a few rows at a time
12012 is supported, though untested. May even break everything.
12013 Actually, the code doesn't even compile right now.
12014 * som.c: (struct som) New fields htv, nt, seq_no.
12015 (som_submit_table) Multiple arguments changed to a single
12016 pointer to struct submission_form. Only increments subtable_num
12017 if seq_no is zero. Only destroys table if it's not going to
12019 (replicate_table) New function.
12020 (output_table) Comment fix.
12021 (examine_table) Changed inline code to code calling
12022 replicate_table(). Calculates htv. Supports partial tables.
12023 (draw_title) Removed comment.
12024 (build_target) Only allows for title on first part of partial
12026 (dump_plain_table) Only resets table chunk number on first part
12027 of partial tables; FIXME: doesn't work quite right. Supports
12029 (dump_page) Titles only on first part of partial tables.
12031 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12033 * Thanks to an unreliable IDE hard drive, I have spent the last
12034 day reconstructing my Debian GNU/Linux installation and redoing
12035 the previous day's changes--somehow I managed to save every file
12036 except for output.c and output.h. So the following changes could
12037 really be considered independent of the output.c, output.h changes
12040 * output.h, output.c: Moved the outp_configure_vec global var,
12041 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12042 outp_configure_vec is now static.
12044 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12046 * The entire philosophy behind configuration of the output drivers
12047 changed. Now there is a termcap-type configuration where drivers
12048 to be read are determined beforehand, rather than parsing the
12049 entire output init file and storing it in memory & deciding what
12050 to actually use later. Faster & more memory-efficient at the same
12053 * output.c: Comment fix. Removed outp_init_drivers global var.
12054 Removed all references to synonyms. New structure outp_defn. New
12055 global vars outp_macros, outp_configure_vec.
12056 (search_name, delete_name, add_name, check_configure_vec,
12057 expand_name, find_defn_value) New static functions.
12058 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12059 outp_read_devices) New extern functions.
12060 (outp_init) Much functionality moved into outp_read_devices.
12061 (outp_read_devices) Format of output init file changed; name of
12062 file is `devices' rather than `output' to avoid Makefile
12064 (outp_clear) Renamed outp_done.
12065 (outp_list_classes) Bug fix, cleaned up.
12066 (outp_list_drivers) Not implemented anymore.
12067 (outp_configure_driver) Now a static function; simplified; now
12068 interpolates macros; supports new structure.
12069 (outp_enable_driver, match_synonym) Removed; all references
12071 (find_driver) First argument removed.
12073 * output.h: Global var outp_init_drivers removed; new structure
12074 outp_names; new enum set OUTP_S_*; new global var
12075 outp_configure_vec; function prototypes for output.c exports
12078 * main.c: (main) Calls outp_read_devices() after parsing the
12081 * cmdline.c: (parse_command_line) New option -v --verbose;
12082 --version changed to -V. --device option changed syntax to just
12083 take a single device name. Accepts key=value declaration of
12084 output init file macros. Syntax message updated.
12086 * filename.c: (expand_line) New function.
12087 (interp_environ_vars) Renamed interp_vars; no longer uses
12089 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12090 overridden by real environment vars.
12091 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12092 * filename.h: interp_environ_vars() renamed interp_vars().
12094 * error.c, error.h: Added extern variable `verbosity', message
12097 * error.c: (vmsg) Support message class MM.
12098 (verbose_msg) New function.
12100 * descript.q: (generate_z_varname) Bug fix in generation of
12102 (dump_z_table) Bug fix in column headers.
12104 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12105 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12106 OPS_DONE]. Writes the uninit string when the driver is closed.
12107 (ascii_open_page) Write the init string before the first page.
12108 (output_shorts) Form of main loop changed from `while' to `for'.
12109 Bug fix with overstrikes: the character is printed *after* the
12110 backspace. Eliminated a lot of `& 0xff' modifiers.
12111 (advance_to_left_margin) New function.
12112 (return_carriage, output_lines) Handle left margin.
12114 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12116 * ascii.c: New option `carriage-return-style'.
12118 * ascii.c: (count_fancy_chars) New function.
12119 (delineate, text_metrics) Use new function; bug fixes regarding
12121 (text_draw) Bug fix with rich text.
12122 (output_string, output_shorts) Reordered.
12123 (output_shorts) Now handles boxchars and some overstrike font
12125 (output_char, return_carriage) New functions.
12126 (output_lines) Now handles overstriking and font changes properly;
12127 some code moved to output_shorts.
12129 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12132 * ascii.c: New member `debug' in ascii_driver_ext.
12133 (ascii_init_driver, delineate) Uses new member.
12135 Now you can set a vertical height on writing text.
12136 * ascii.c: (delineate) Keeps track of vertical position.
12137 (text_draw) No longer considers fully justified text an internal
12140 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12142 Tables' titles are drawn; they can have variable height.
12143 * som.c: `som' struct has new member, title_height.
12144 (draw_title) New argument. Moved within file. All caller
12146 (build_target) New argument, amount of space needed for first row.
12147 Calculates height of title, takes that into account. All callers
12149 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12151 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12153 (dump_columnated_table) Organized for readability.
12154 (dump_page) Makes use of som.title_height.
12156 * som.c: Many comment bug fixes.
12158 * descript.q: (try_name, generate_z_name) Bug fix regarding
12159 generation of Z-score variable names.
12160 * var.h: Removed num from descriptives_proc; all referents removed.
12162 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12164 * ascii.c: (ascii_line_horz, ascii_line_vert,
12165 ascii_line_intersection) Added debugging code.
12167 Added a descriptive line above each table to describe it.
12168 * command.c: (parse_cmd) Calls som_new_series.
12170 * som.c: New static vars table_num, subtable_num. New `som'
12172 (dump_page) New arguments.
12173 (som_submit_table) Handle new variables.
12175 * som.c, som.h: (som_submit_table) New arguments. All callers
12177 (som_new_series) New function.
12178 (build_target) Makes room for extra line.
12179 (draw_title) New function.
12180 (dump_page) Calls draw_title. Bug fix: doesn't always set
12183 Columnation of tables support.
12184 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12186 * som.c: Deleted references to fr, lr, ri.
12187 (som_columnate) Bux fix: sets group member of table.
12188 (som_add_options) Function removed.
12189 (dump_table) Split into three functions; extensively reworked.
12191 * descript.q: (dump_z_table) Better output table formatting; added
12192 title support to correspond to som.h changes.
12193 (display) Title support.
12195 * output.h: Added OUTP_T_NONE.
12197 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12199 * descript.q: Improved handling of Z scores; still not perfect.
12201 * output.h, ascii.c: Added hook for getting em width of current
12204 * som.c: Uses new em-width hook. Added debugging code to
12206 (som_columnate) New argument.
12207 (som_add_options) Removed.
12209 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12211 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12212 rules as a property of the table instead of as a property of the
12215 * ascii.c: Added `header' to table of options.
12217 * descript.q: Added even shorter statistic names; modified to work
12218 with new som interface.
12220 * misc.c (blp_getdelim): Bug fix.
12222 * version.c: includes 'conf.h'.
12224 ----------------------------------------------------------------------
12227 version-control: never