1 * var-labs.c (var_to_string) Now returns null if the variable is null
3 * value-labels.c (value_to_string) Made it return null if either the
4 value or the variable is null.
6 * hash.c (hsh_clear) Fixed a buglet.
8 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
11 * casefile.[ch] Added a function to return the casereader.case_idx
14 * examine.q Implemented the extreme values results.
16 John Darrington <john@darrington.wattle.id.au>
18 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
21 Plugged some memory leaks
23 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
25 Adopt GSL random number generators, paving the way for providing
26 the complete suite of random number generators on expressions.
28 * Makefile.am: Remove random.c, random.h.
34 * algorithm.c: (algo_default_random) Use GSL functions.
36 * casefile.c: (test_casefile) Use GSL RNG functions.
38 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
41 * sample.c: (cmd_sample) Use GSL RNG functions.
42 (sample_trns_proc) Ditto.
44 * set.q: (static var set_seed) Removed.
45 (static var seed_flag) Removed.
46 (static var rng) New variable.
47 (aux_stc_custom_seed) No seed value anymore, don't print anything.
48 (stc_custom_seed) Use new seed functions.
49 (seed_is_set) Removed.
50 (get_rng) New function that composes the entire external
52 (set_rng) New function.
53 (random_seed) New function.
55 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
57 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
58 John Darrington <john@darrington.wattle.id.au> for reporting this
61 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
63 * permissions.c command.def Added the PERMISSIONS command
66 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
68 * q2c.c: (dump_header) Don't try to emit #includes at very top of
69 output file because that will precede #include <config.h>, which
71 (main) Add needed headers to /* (header) */ code.
73 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
75 Instead of making system or portable file readers responsible for
76 dropping and reordering variables, make them read full cases and
77 let the caller take care of any changes.
79 * get.c: New "case map" structure to handle this. Use for GET,
80 IMPORT, MATCH FILES. Essentially rewrite the whole file.
82 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
83 changed appropriately.
85 * sfm-read.c: (sfm_read_case) Ditto.
87 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
89 Decided that case_serialize() and case_unserialize() were too
90 abstract. Also we need a couple more functions to avoid excessive
91 copying for data in/out fast paths.
93 * case.c: (case_serial_size) Removed.
94 (case_serialize) Rename case_to_values() and make its argument
95 explicitly an array of union values.
96 (case_unserialize) Rename case_from_values() and make its argument
97 explicitly an array of union values.
98 (case_data_all) New function.
99 (case_data_all_rw) New function.
101 * casefile.c: (struct casefile) Change buffer from array of
102 unsigned char to array of union value for better accuracy.
103 Redefine buffer_used and buffer_size in terms of values, not
104 bytes. Remove case_size because it is now redundant with
105 value_cnt. Fix up all references to these members.
107 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
109 * barchart.c: (struct subcat) Make `label' member const to silence
110 GCC warning with -Wwrite-strings.
112 * cartesian.c: (struct dataset) Ditto.
114 * case.c: Don't re-define NDEBUG if already defined.
115 Add lots of comments.
117 * str.c: Fix includes.
119 * crosstabs.q: Fix includes.
121 * examine.q: Fix includes. Fix GCC warning about unused
124 * frequencies.q: (stat macro) Removed and replaced where used by
127 * list.q: Fix includes.
129 * oneway.q: Fix includes.
131 * piechart.c: Fix includes. Only define M_PI if not already
134 * sfm-read.c: (bswap) New function.
135 (bswap_int32) Write in terms of bswap.
138 * str.c: (ds_data) Add external definition here, needed because
139 str.h has only an `extern inline' version.
141 * value-labels.c: Fix includes.
143 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
145 Instead of providing a system or portable file writer with a raw
146 case in the format needed for output, provide it with a regular
147 case. The writer takes care of any needed translation.
149 * aggregate.c: Adopt new scheme for AGGREGATE.
150 (struct agr_proc) sfm_agr_case member removed.
151 (write_case_to_sfm) Removed because the new interface is easier to
154 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
156 * pfm-write.c: Implement new scheme.
158 * sfm-write.c: Ditto.
160 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
162 Instead of treating `struct file_handle' as a class to subclass
163 into data files, system files, and portable files, instead use it
164 as a helper that coordinates access. Now it is opaque, too.
166 This means that most references to a struct file_handle are now
167 changed into references to one of struct dfm_reader, struct
168 dfm_writer, struct sfm_reader, struct sfm_writer, struct
169 pfm_reader, or struct pfm_writer, according to what's being read
172 Most related changes are only worth summarizing briefly.
174 * dictionary.c: (dict_clear) Destroy aux data in deleted
176 (dict_clear_aux) New function.
177 (dict_create_var) Initialize aux, aux_dtor.
178 (dict_delete_var) Destroy aux data in deleted variable.
180 * file-handle.h: (struct fh_ext_class) Removed.
181 (struct file_handle) Removed.
182 (fh_init_files) Removed.
184 * file-handle.q: Changed references to a handle's `private' member
185 to direct references.
186 (struct private_file_handle) Renamed file_handle.
187 Add next, open_cnt, type, open_mode, aux members.
188 (struct file_handle_list) Removed.
189 (extern var inline_file) Removed.
190 (static var file_handles) Changed from file_handle_list * to
192 (create_file_handle) Initialize new members.
193 (fh_close_handle) Removed.
194 (mode_name) New function.
195 (fh_open) New function.
196 (fh_close) New function.
197 (fh_parse_file_handle) Renamed fh_parse().
199 * glob.c: (init_glob) Remove fh_init_files() call.
201 * aggregate.c: use sfm_writer.
202 (create_sysfile) Removed because the new interface is simpler.
204 * apply-dict.c: Use sfm_reader.
206 * data-list.c: Use dfm_reader.
208 * file-type.c: Use dfm_reader.
210 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
212 * inpt-pgm.c: Use dfm_reader.
214 * print.c: Use dfm_writer.
216 * sysfile-info: Use sfm_reader.
218 * dfm-read.c: Adopt new file handle infrastructure.
220 * dfm-write.c: Ditto.
224 * pfm-write.c: Ditto.
228 * sfm-write.c: Ditto.
230 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
232 Break dictionary functions into separate header file.
234 * dictionary.h: New file.
236 * var.h: Moved dict_*() functions to dictionary.h.
238 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
240 Get rid of procedure-specific union in struct variable, using
241 instead a void * pointer and a destructor function.
243 Most related changes are only worth brief summaries.
245 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
246 old p.crs member in struct variable.
248 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
249 of old p.frq member in struct variable.
251 * histogram.c: (draw_histogram) Takes new freq_tab arg because
252 it's no longer possible to grab this from var->p.frq.
254 * piechart.c: (draw_piechart) Ditto.
256 * group.c: (group_proc_get) New function.
258 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
265 * main.c: (execute_command) Clear aux data in default_dict after
266 each command. (It's debatable whether this should be done.)
268 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
269 member in struct variable.
271 * means.q: Get rid of integer mode, which is not included in
272 recent SPSS and was the only code that wanted per-variable private
275 * var.h: (struct crosstab_proc) Removed.
276 (struct frequencies_proc) Removed.
277 (struct list_proc) Removed.
278 (struct get_proc) Removed.
279 (struct means_proc) Removed.
280 (struct matrix_data_proc) Removed.
281 (struct match_files_proc) Removed.
282 (lots of enums) Removed.
283 (struct variable) Removed members `p', `get'. Add member
286 * vars-atr.c: (var_attach_aux) New function.
287 (var_detach_aux) New function.
288 (var_clear_aux) New function.
289 (var_dtor_free) New function.
290 (discard_variables) Use NULL instead of inline_file.
293 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
295 * value-labs.c Fixed the implmentation of value_to_string, so
296 that it properly handles alpha values.
298 * oneway.q Changed instances where labels were being probed manually,
299 to use the canonical {var,value}_to_string functions
301 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
303 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
304 plots. Changed the API of the cartesian plot to be a much lower level
307 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
309 * examine.q Added some of the parametric calculations
311 * factor_stats.[ch] Created
313 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
315 * examine.q Changed the definition of factors to be a composite, and
316 dealt with the consequences.
318 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
320 * examine.q Fixed problem where examine wasn't dealing properly with
323 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
325 * oneway.q Fixed problem where oneway wasn't dealing properly with
328 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
330 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
331 command which had settings didn't get the appropriate code
334 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
335 to convert variables/values to strings.
337 * examine.q Added framework for the EXAMINE command.
339 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
341 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
342 subcommand types. Changed frequencies.q to use it rather then the
343 custom parser. Dealt with the consequences. Added a test for NTILES
344 subcommand of frequencies.
346 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
348 * oneway.q Fixed up the behaviour when given missing values
350 * levene.c oneway.q Fixed a buglet with the levene statistic and
351 incorporated the levene test into the oneway command.
353 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
354 global scope, since they're only relevant to T-TEST
356 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
358 * group.c group.h group_proc.h levene.c oneway.q t-test.q
360 Made the t-test more consistent
361 with the way it handles groups. That is, it now uses a hash instead
362 of an array of 2. Also, made the levene.c file independent of the
363 implementation of the t-test. So now levene should be fine for both
366 * Added an oneway.q file for one way anova
368 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
370 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
373 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
377 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
378 (data_list_trns_free) Free dls->delims.
380 * t-test.q: (tts_custom_pairs) Free vars.
381 (ssbox_one_sample_init) Fix tab_vline() argument.
382 (ssbox_independent_samples_init) Ditto.
383 (trbox_paired_init) Ditto.
384 (trbox_one_sample_init) Ditto.
386 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
388 Generalize casefiles to the extent that we can use them for
389 sorting and other kinds of data transformations. Change cases to
390 be copy-on-write to improve memory efficiency in common cases.
391 Every access to a member of a `struct ccase' was changed to be a
392 call to a case_*() function, especially case_data(), case_num(),
393 case_str(), or case_data_rw(). Many instances of a local variable
394 named "case_num" were changed to "case_idx" as a consequence.
395 Many `struct ccase *' were changed to actual `struct ccase'
396 because of copying semantics of cases. In several places there
397 was a choice between updating debug code to work with the new ADTs
398 or just deleting it because it was useless; I chose to delete it.
400 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
406 * aggregate.c: (struct agr_proc) Change type of `sort' to
407 sort_criteria *. Add `break_vars', `break_var_cnt' members.
408 Rename `vars' to `agr_vars', all references updated. Change
409 `agr_case' to type `struct ccase'.
410 (cmd_aggregate) Deal with new members. Use case_create(),
411 sort_active_file_in_place(), sort_active_file_to_casefile().
412 (agr_destroy) Deal with new members.
413 (aggregate_single_case) Ditto.
414 (dump_aggregate_info) Ditto.
415 (initialize_aggregate_info) Ditto.
416 (agr_to_active_file) Ditto.
417 (presorted_agr_to_sysfile) Ditto.
418 (sort_agr_to_sysfile) Removed.
420 * alloc.c: (out_of_memory) Make non-static.
422 * alloc.h: Prototype out_of_memory().
424 * casefile.c: Switched from a linked list in-memory representation
425 to a two-level array-style representation. The linked list was
426 appropriate when we could stick a header onto cases, but that's no
427 longer the case. Also, the two-level array will allow for random
428 in-memory access in case that's ever wanted. Also added the
429 concept of a `destructive casereader', one that destroys cases in
430 the underlying casefile as they are read out.
431 (macro CASES_PER_BLOCK) New macro.
432 (struct casefile) New members `value_cnt', `case_list_size',
433 `case_acct_size', `being_destroyed', `cases'. Removed `head',
435 (struct casereader) Removed `cur'. Added `destructive', `c'.
436 (global var casefiles) Made static.
437 (static var case_bytes) New var.
438 (casefile_create) Takes a value count, not a case size in bytes,
439 to conform to the case interface. All callers updated. Deal with
440 new and removed members.
441 (casefile_destroy) Deal with new and removed members.
442 (casefile_sleep) New function.
443 (casefile_get_case_size) Removed.
444 (casefile_get_value_cnt) New function.
445 (casefile_append) Rewritten to deal with new and removed members.
446 (casefile_append_xfer) New function.
447 (write_case_to_disk) Use case_serialize().
448 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
449 Couldn't figure out why.
450 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
451 deal with new and removed members.
453 (merge_sort) Removed.
454 (casefile_sort) Removed.
455 (casefile_get_reader) Deal with new and removed members.
456 (casefile_get_destructive_reader) New function.
457 (reader_open_file) Make code more readable. Create case for
459 (casereader_get_casefile) New function.
460 (casereader_read) Deal with new and removed members. Now returns
461 a copy of the case, so that the caller is responsible for
462 destroying the returned case.
463 (casereader_read_xfer) New function.
464 (casereader_destroy) Destroy reader's case.
465 (test_casefile) Second arg is now a value count, all callers
466 updated. Now tests destructive readers too.
467 (get_random_case) Deal with new case ADT.
468 (write_random_case) Ditto.
469 (read_and_verify_random_case) Ditto.
471 * crosstabs.q: Remove debug code.
473 * descript.q: (calc_descriptives) Deal with new case, casefile
476 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
478 * do-if.c: Remove unneeded header inclusion.
480 * expr-prs.c: Remove debug code.
482 * exprP.h: Remove debug code.
484 * flip.c: (flip_file) Use fseeko() if available.
486 * formats.c: Remove debug code.
488 * get.c: Remove debug code.
489 (struct mtf_file) Change `input' from `union value *' to `struct
490 ccase', all references updated.
492 * levene.c: (levene) Deal with new case, casefile ADTs.
494 * list.q: Remove debug code.
496 * loop.c: Remove debug code.
498 * matrix-data.c: Remove debug code.
500 * means.q: Remove debug code.
502 * mis-val.c: Remove debug code.
504 * pfm-read.c: Remove debug code.
505 (pfm_read_code) Change second arg from `union value *' to `struct
506 ccase *', all references updated.
508 * recode.c: (string_to_long) Make first arg const.
509 (convert_to_double) Ditto.
511 * repeat.c: Remove debug code.
513 * sample.c: Remove debug code.
515 * sfm-read.c: Remove debug code.
516 (sfm_read_case) Change second arg from `union value *' to `struct
519 * sort.c: Redone in terms of casefiles.
520 (enum sort_direction) Moved here from sort.h.
521 (struct sort_criterion) New structure.
522 (struct sort_criteria) New structure.
523 (cmd_sort_cases) Rewritten.
524 (prepare_to_sort_active_file) New function.
525 (sort_active_file_in_place) New function.
526 (sort_active_file_to_casefile) New function.
527 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
528 changed, all callers updated.
529 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
530 rewritten & interface changed, all callers updated.
531 (sort_cases) Renamed sort_execute(), rewritten & interface
532 changed, all callers updated.
533 (struct internal_sort) Removed.
534 (do_internal_sort) Rewritten, interface changed.
535 (destroy_internal_sort) Removed.
536 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
537 (struct initial_run) Removed; an initial run is now just a
539 (compare_initial_runs) Rewritten.
540 (struct external_sort) Changed almost completely.
541 (do_external_sort) Rewritten, interface changed.
542 (destroy_external_sort) Rewritten.
543 [HAVE_MKDTEMP] (make_temp_dir) Removed.
544 [!HAVE_MKDTEMP] (do_mkdir) Removed.
545 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
546 (init_external_sort) Removed.
547 (simulate_error) Removed.
548 (rmdir_temp_dir) Removed.
549 (get_temp_file_name) Removed.
550 (open_temp_file) Removed.
551 (close_temp_file) Removed.
552 (remove_temp_file) Removed.
553 (write_temp_file) Removed.
554 (read_temp_file) Removed.
555 (struct record_run) Change `record' from `struct case_lit *' to
557 (struct initial_run_state) Remove `idx_to_fv', `free_list',
558 `file_idx', `output_file'. Add `run', casefile'. Change
559 `last_output' from `struct case_list *' to `struct ccase'.
560 (write_initial_runs) Change interface, rewrite.
561 (sort_sink_write) Renamed process_case(), changed interfaced,
563 (destroy_initial_run_state) Rewritten.
564 (allocate_cases) Rewritten.
565 (compare_record) Interface changed, rewritten.
566 (start_run) Rewritten.
568 (output_record) Rewritten.
570 (release_case) Removed.
571 (struct merge_case) Change `cases' from double pointer to single
573 (merge) Deal with new case and casefile ADTs.
574 (struct run) Removed.
575 (merge_once) Rewritten, interface changed.
576 (fill_run_buffer) Removed.
577 (sort_sink_make_source) Removed.
578 (sort_sink_class) Removed.
579 (struct sort_source_aux) Removed.
580 (sort_source_read_helper) Removed.
581 (sort_source_read) Removed.
582 (read_sort_output) Removed.
583 (read_internal_sort_output) Removed.
584 (read_external_sort_output) Removed.
585 (sort_source_destroy) Removed.
586 (sort_source_class) Removed.
588 * sort.h: (struct sort_cases_pgm) Removed.
589 (enum sort_direction) Moved to sort.c.
591 * t-test.q: (calculate) Deal with new case, casefile ADTs.
593 * tab.c: Remove debug code.
595 * var-labs.c: Remove debug code.
597 * var.h: (struct ccase) Removed.
598 (struct case_list) Removed.
600 * vars-atr.c: (discard_variables) Use free_case_source().
602 * vars-prs.c: (parse_vs_variable) Make arg const.
603 (parse_dict_variable) Ditto.
604 (parse_variables) Make struct dictionary * arg const.
605 (parse_var_set_vars) Make struct var_set * arg const.
606 (struct var_set) Add const to some of the function pointers' args.
607 (var_set_get_cnt) Make arg const.
608 (var_set_get_var) Make first arg const.
609 (var_set_lookup_var) Make first arg const.
610 (dict_var_set_get_cnt) Make arg const.
611 (dict_var_set_get_var) Make first arg const.
612 (dict_var_set_lookup_var) Make first arg const.
613 (var_set_create_from_dict) Make arg const. Add cast to aux
615 (struct array_var_set) Add const to var member.
616 (array_var_set_get_cnt) Make arg const.
617 (array_var_set_get_var) Make first arg const.
618 (array_var_set_lookup_var) Make first arg const.
619 (var_set_create_from_array) Make first arg const. Insert cast.
621 * vfm.c: (struct write_case_data) Change trns_case, sink_case
622 members from `struct ccase *' to `struct ccase'.
623 (static var lag_queue) Change from double to single pointer.
624 (procedure) Optimize trivial case.
625 (internal_procedure) Deal with changed case, case_source ADTs.
626 (create_trns_case) Changed interface, rewrote.
627 (open_active_interface) Initialize modified lag queue.
628 (write_case) Deal with changed case ADT.
629 (lag_case) Deal with modified lag queue.
630 (close_active_file) Destroy modified lag queue.
631 Deal with changed case_source, case_sink ADTs.
632 (destroy_storage_stream_info) Make null arg into no-op.
633 (storage_sink_make_source) Set aux in created source.
634 (storage_source_read) Deal with changed case, casefile ADTs.
635 (storage_source_create) New function.
636 (lagged_case) Rewrite.
637 (free_case_source) New function.
638 (free_case_sink) Rewrite.
639 (struct split_aux_data) Changed prev_case from `struct ccase *' to
641 (procedure_with_splits) Deal with changed prev_case.
642 (procedure_with_splits_callback) Ditto.
643 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
645 (multipass_procedure_with_splits) Deal with changed prev_case.
646 (multipass_split_callback) Ditto.
649 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
651 The workspace idea didn't work out.
653 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
655 * workspace.c: Removed.
657 * workspace.h: Removed.
659 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
661 Fully implement arbitrary delimiters on DATA LIST, extending the
662 half implementation that was already there.
664 * data-list.c: (struct data_list_pgm) Remove `delim', add
665 `delims', `delim_cnt'.
666 (cmd_data_list) Initialize new members. Parse delimiters and
668 (cut_field) Extract fields with arbitrary delimiters. Also, fix
669 handling of leading commas.
670 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
672 (read_from_data_list_free) Adapt to new DFM interfaces.
673 (read_from_data_list_list) Ditto.
674 (repeating_data_trns_proc) Ditto.
676 * dfm.c: Split up reader and writer into separate code, because
677 they do different things. Use struct string instead of explicit
678 allocation code, for clarity.
679 (enum dfm_reader_flags) New enum.
680 (struct dfm_fhuser_ext) Removed.
681 (struct dfm_reader_ext) New.
682 (get_reader) New function, used by just about all the reader
685 (close_reader) New function.
686 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
687 (dfm_open_for_writing) Ditto.
688 (macro force_line_buffer_expansion) Removed.
689 (count_tabs) Removed.
690 (tabs_to_spaces) Removed.
691 (read_record) Deal with new dfm_reader_ext. Use struct string
692 functions. Don't convert tabs to spaces.
693 (dfm_eof) New function.
694 (dfm_get_record) Changed interface, rewrote.
695 (dfm_expand_tabs) New function.
696 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
697 dfm_reader_ext, rewritten.
698 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
699 dfm_reader_ext, rewritten.
700 (dfm_set_record) Removed in favor of dfm_forward_columns().
701 (dfm_forward_columns) New function.
702 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
703 dfm_reader_ext, rewritten.
704 (static var dfm_r_class) Use close_reader for the destructor.
705 (struct dfm_writer_ext) New.
706 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
707 bounce buffer now instead of local allocation.
708 (close_writer) New function.
709 (static var dfm_writer_ext) Use close_writer for destructor.
710 (cmd_begin_data) Adapt to new dfm_reader_ext.
712 * file-handle.q: Add support for per-file tab width.
713 (struct private_file_handle) Add tab_width member.
714 (q2c specifications) Add tabwidth subcommand.
715 (cmd_file_handle) Put parsed tab width into private_file_handle.
716 (create_file_handle) Set default tab width.
717 (handle_get_tab_width) New function.
719 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
721 * inpt-pgm.c: (reread_trns_proc) Ditto.
723 * matrix-data.c: (context) Ditto.
724 (another_token) Ditto.
728 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
730 * casefile.c: (casefile_destroy) Fix memory leak by freeing
732 (casereader_destroy) Don't close file descriptor -1.
734 * recode.c: (cmd_recode) Fix memory leak.
736 * set.q: (q2c specifications) Fix typo in user message.
738 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
739 undefined behavior for overlapping arguments.
741 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
743 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
744 don't call it when we're running under valgrind.
745 (call_posix_fadvise) New function.
746 (casefile_to_disk) Use call_posix_fadvise().
747 (reader_open_file) Ditto.
749 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
751 Update our string ADTs, struct string and struct len_string. Get
752 rid of pool support, which was largely unused. Rename lots of
753 functions to have more obvious or consistent names.
755 * ascii.c: Get rid of ascii_pool. It was only used for string
757 (ascii_open_global) Don't create ascii_pool.
758 (ascii_close_driver) Don't destroy ascii_pool.
759 (ascii_postopen_driver) Don't use pool.
760 (ascii_close_driver) Destroy strings manually.
762 * str.c: (ds_create) Remove pool argument, all references updated.
764 (ds_replace) Remove pool support, make more efficient when we
765 don't need to reallocate.
766 (ds_destroy) Remove pool support.
767 (ds_rpad) New function.
768 (ds_size) Renamed ds_capacity(), all references updated.
769 (ds_value) Renamed ds_c_str(), all references updated.
770 (ds_concat) Renamed ds_puts(), all references updated.
771 (ds_concat_buffer) Renamed ds_concat(), all references updated.
772 (ds_putchar) Renamed ds_putc(), all references updated.
773 (ds_getline) Renamed ds_gets(), all references updated.
774 (ls_create) Remove pool argument, all references updated.
775 (ls_create_buffer) Ditto.
776 (ls_destroy) Removed pool support.
777 (ls_value) Renamed ls_c_str(), all references updated.
779 * str.h: (ls_length) [__GNUC__] Add inline version.
780 (ls_c_str) [__GNUC__] Add inline version.
781 (ls_end) [__GNUC__] Add inline version.
782 (struct string) Remove pool member. Rename `size' to `capacity',
783 all references updated.
785 * tab.c: (text_format) Instead of using pool argument to
786 ls_create_buffer(), call pool_register() on allocated data.
788 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
790 We're abusing the current ASCII driver by telling it to allocate a
791 9999-line, 9999-character page in the tests. This causes some
792 systems to curl up and die because it allocates 20 MB of
793 contiguous RAM. This change alleviates at least part of the
794 problem. It is mostly a stop-gap until the new output system is
797 * ascii.c: (struct line) New structure.
798 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
799 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
800 (ascii_preopen_driver) Initialize new members, not old ones.
801 (ascii_close_driver) Destroy new members, not old ones.
802 (ascii_open_page) Allocate new members, not old ones.
803 (expand_line) Allocate room in line.
804 (draw_line) Use new members.
805 (ascii_line_horz) Ditto.
806 (ascii_line_vert) Ditto.
807 (ascii_line_intersection) Ditto.
809 (output_lines) Ditto.
810 (ascii_close_page) Ditto.
812 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
814 * matrix.c: Dead code. Removed.
816 * matrix.h: Dead code. Removed.
818 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
820 Contrary to what I'd always understood, there is an efficient
821 algorithm for deletion from a hash table populated via linear
822 probing. This change implements it.
824 * hash.c: (hsh_rehash) Probe in increasing order.
826 (locate_matching_entry) Ditto.
827 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
829 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
831 * moments.c (calc_moments): Adjust calculation of kurtosis to
832 avoid subtracting huge numbers from huge numbers, on Michael
835 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
837 Rework moments routines for improved numerical stability based on
838 Michael Kiefte's advice. Any bugs or remaining numerical problems
839 are still mine though.
841 There is now a struct moments1 for use with one-pass moments. It
842 uses a provisional means algorithm as an attempt to improve
843 accuracy of higher moments. The older struct moments now only
844 handles two-pass moments.
846 * aggregate.c: Use moments1 instead moments.
848 * descript.c: Revert previous change, which is no longer needed
849 due to the moments revision.
851 * moments.c: (calc_moments) New function for calculating variance,
853 (moments_pass_one) Only accumulate weights bigger than zero.
854 (moments_calculate) Allow calculating the mean on pass one, others
855 require pass two. Implement in terms of calc_moments().
856 (struct moments1) New structure.
857 (init_moments1) New function.
858 (moments1_clear) Ditto.
859 (moments1_create) Ditto.
860 (moments1_add) Ditto.
861 (moments1_calculate) Ditto.
862 (moments1_destroy) Ditto.
863 (cmd_debug_moments) Deal with `struct moments' or `struct
864 moments1' as requested by user.
866 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
868 * Makefile.am (pspp_SOURCES): Remove debug.c.
870 * debug.c: Removed. It was empty anyway.
872 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
874 * descript.c (calc_descriptives): Fix assert failure when only
875 MOMENT_MEAN is needed.
877 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
881 fixed problem with parsing in match_statistic() causing
882 "DESCRIPTIVE STAT=MEAN." to barf.
884 "MEAN" is now default if "SORT" given without specification.
886 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
887 generally less forgiving of syntax errors: better to have it do
888 nothing and type it in again then to not know what it actually did
891 z-score transformation now checks score for user-missing values
892 and checks std_dev for SYSMIS.
894 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
896 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
897 Changed dict_get_case_weight() to accept an additional int * flag
898 to complain about system-missing, user-missing, zero, or negative
899 weights and updated existing functions to pass int * to
900 dict_get_case_weight().
902 2004-04-05 jmd <jmd@gnu.org>
904 * main.c: Fixed configuration problems with gsl
906 * t-test.q: Fixed some problems encountered when compiling under Cygwin
908 2004-04-03 blp <blp@gnu.org>
910 * lexer.c, ChangeLog:
911 Fix infinite loop on comment at end of file, add test.
913 2004-04-03 jmd <jmd@gnu.org>
915 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
916 Fixed the calculation of percentiles and added --syntax and --algorithm options
918 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
920 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
923 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
925 * frequencies.q: Fixed the calculation of percentiles
927 * Makefile.am: Added the --ansi flag and dealt with the
928 consequences. Added some entries to PSPP_sources so that
929 make distcheck would pass
931 * cmdline.c: Added the --syntax and --algorithm options
933 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
935 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
937 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
938 use the new multipass_split_... mechanism.
940 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
942 * frequencies.q: (calc_stats) Use moments data structure and
943 calc_seskew(), calc_sekurt() functions.
945 * set.q main.c settings.h Added support for --syntax and --algorithm
948 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
950 * vfm.c: Had to get last call to multipass_split_output() inside
951 open_active_file()/close_active_file() pairing, so introduce new
953 (internal_procedure) Move procedure() code here, except for calls
954 to open_active_file() and close_active_file().
955 (procedure) Wrap open_active_file() and close_active_file() around
956 internal_procedure().
957 (multipass_procedure_with_splits) Wrap open_active_file() and
958 close_active_file() around internal_procedure().
960 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
962 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
964 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
966 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
968 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
970 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
972 * algorithm.c: By default turn off some of the more expensive
974 (expensive_assert) New macro which expands to assert if
975 EXTRA_CHECKS is defined, to nothing otherwise.
976 (unique) Use expensive_assert().
977 (binary_search) Ditto.
983 * command.c: (conflicting_3char_prefixes) Words that are the same
984 don't cause conflicts when they are abbreviated to the first three
987 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
988 nonterm_node's n earlier.
989 (generic_str_func) Ditto.
991 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
993 Add support for multipass procedures. Rewrite DESCRIPTIVES to
994 test multipass support, take advantage of new moments
995 calculation, and to not be such crappy code. Get rid of q2c
996 processing for DESCRIPTIVES.
998 * vfm.c: (struct multipass_split_aux_data) New structure.
999 (multipass_procedure_with_splits) New function.
1000 (multipass_split_callback) New function.
1001 (multipass_split_output) New function.
1002 * descript.q: Removed.
1004 * descript.c: New file.
1006 * var.h: Removed descriptives enums.
1007 (struct descriptives_proc) Removed.
1008 (struct variable) Removed p.dsc.
1010 * Makefile.am: (q_sources_c) Remove descript.c.
1011 (q_sources_q) Removed descript.q.
1013 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
1015 New manager for keeping track of used workspace.
1017 * workspace.c: New file.
1019 * workspace.h: New file.
1021 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
1023 * sort.c: (do_internal_sort) Use workspace_malloc().
1024 (destroy_internal_sort) Use workspace_free().
1026 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
1028 New `struct casefile' for managing sets of cases.
1030 * casefile.c: New file.
1032 * casefile.h: New file.
1034 * command.def: Add DEBUG CASEFILE command.
1036 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
1038 * sort.c: (sort_cases) Move logic for sending storage file to disk
1039 into do_external_sort().
1040 (struct internal_sort) Use an array of ccase pointers instead of a
1042 (do_internal_sort) Rewrite to handle casefiles.
1043 (compare_case_list) Removed.
1044 (compare_cases) New function.
1045 (compare_case_dblptrs) New function.
1046 (read_internal_sort_output) Deal with new struct internal_sort.
1048 * vfm.c: (static var workspace_overflow) Removed.
1049 (struct storage_stream_info) Removed all the members. Added
1050 struct casefile * member.
1051 (storage_sink_open) Use casefile.
1052 (open_storage_file) Removed.
1053 (write_storage_file) Removed.
1054 (storage_to_disk) Removed.
1055 (destroy_storage_stream_info) Use casefile.
1056 (storage_sink_write) Use casefile.
1057 (storage_sink_make_source) Use casefile.
1058 (storage_source_count) Use casefile.
1059 (storage_source_read) Use casefile.
1060 (storage_source_on_disk) Removed.
1061 (storage_source_get_cases) Removed.
1062 (storage_source_set_cases) Removed.
1063 (storage_source_get_casefile) New function.
1065 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
1067 New `struct moments' for calculating moments.
1073 * moments.c: New file.
1075 * moments.h: New file.
1077 * command.def: Add DEBUG MOMENTS command.
1079 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
1082 * aggregate.c: Modify AGGREGATE to use the new moments
1083 calculation, even if not in such a great way.
1084 (struct agr_var) Add `moments' member.
1085 (parse_aggregate_functions) Set `moments' member to null.
1086 (agr_destroy) Destroy `moments' member.
1087 (accumulate_aggregate_info) Use `moments' for standard deviation.
1088 (dump_aggregate_info) Ditto.
1089 (initialize_aggregate_info) Create or clear `moments'.
1091 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
1092 cube(), pow4() that were in stats.h. All references updated.
1094 * crosstabs.q: stats.h had chi-square significance functions. Use
1096 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
1098 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
1099 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
1101 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
1103 * dictionary.c: (dict_compact_values) Compacted values need to
1106 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
1108 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
1109 `/' at start. Check return value of parse_variables() for error
1112 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
1114 Revamp expressions: make the code a little nicer, and fix bugs
1117 * expr-evl.c: (expr_evaluate) Make expression argument const.
1118 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1119 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
1120 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
1121 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
1122 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
1123 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
1124 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
1125 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
1126 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
1127 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
1128 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
1129 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
1130 Simplify OP_SYSMIS. Remove OP_STR_MIS.
1132 * expr-opt.c: (optimize_expression) Rewrite.
1137 (macro s0l) Removed.
1139 (macro s1l) Removed.
1141 (macro s2l) Removed.
1144 (eq_num_con) New function.
1145 (optimize_tree) New function.
1146 (macro rnc) Removed.
1147 (macro frnc) Removed.
1148 (str_search) Add const to string params.
1149 (str_rsearch) Ditto.
1150 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
1151 str[], str_len[] locals to substitute for most of removed macros.
1152 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1153 Removed support for missing values because we're never called with
1154 missing values. Use set_number() or set_number_errno() instead of
1155 rnc or frnc. Removed any stuff that caused trouble in testing.
1156 We can re-add it later if it really slows anything. Fix some
1158 (evaluate_tree_with_missing) Not yet supported. To be added later
1160 (repl_num_con) Removed.
1161 (collapse_node) New function.
1162 (force_repl_num_con) Removed.
1163 (set_number) New function.
1164 (set_number_errno) New function.
1165 (repl_str_con) Removed.
1166 (set_string) New function.
1167 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
1169 (dump_node) No special case for OP_AND, OP_OR.
1171 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
1172 (expr_get_type) New function.
1173 (type_check) Rewrite.
1174 (type_coercion) New function.
1175 (struct operator) New structure.
1176 (match_operator New function.
1177 (parse_binary_operators) New function.
1178 (parse_inverting_unary_operator) New function.
1179 (parse_or) Rewritten.
1180 (parse_and) Rewritten.
1181 (parse_not) Rewritten.
1182 (parse_rel) Rewritten.
1183 (parse_add) Rewritten.
1184 (parse_mul) Rewritten.
1185 (parse_neg) Rewritten.
1186 (parse_exp) Rewritten.
1187 (parse_sysvar) Add $TRUE, $FALSE system variables.
1188 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
1189 (parse_primary) Use allocate_var_node(), allocate_num_con(),
1191 (struct function) Remove desc, change `func' prototype.
1192 (unary_func) Remove special cases.
1193 (MISSING_func) Reduce to unary_func() that just returns a boolean.
1194 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
1195 (VALUE_func) Use allocate_var_node().
1196 (nary_num_func) Allow MIN and MAX for strings.
1197 Use allocate_var_node(). Properly clean up.
1199 (generic_str_func) Use local table instead of removed `desc'
1200 member. Mostly rewrite.
1201 (get_num_args) Revise error message.
1202 (parse_function) Return EXPR_ERROR, not 0 on error.
1204 (macro varies) Removed.
1205 (ops[]) Use expr.def.
1206 (free_node) Do nothing if node is null.
1207 (allocate_num_con) New function.
1208 (allocate_str_con) New function.
1209 (allocate_var_node) New function.
1210 (allocate_binary_nonterminal) New function.
1211 (append_nonterminal_arg) Removed.
1212 (static var func_tab[]) Revised.
1213 (expr_debug_print_postfix) Make parameter const.
1214 Use printf() instead of debug_printf().
1216 * expr.def: New file.
1218 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
1219 use named enum instead of unnamed, all references updated. Add
1220 EXPR_ANY, EXPR_NO_OPTIMIZE.
1222 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
1223 instead of defining OP_* directly.
1224 (macro IS_TERMINAL) New macro.
1225 (macro IS_NONTERMINAL) New macro.
1226 (enum OP_NO_FLAGS) New.
1228 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
1230 * error.c: (err_assert_fail) msg variable needs to be non-const.
1232 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
1234 * debug.c: (cmd_debug_evaluate) Rewrite.
1236 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
1238 Fix some CROSSTABS bit rot stupidity.
1240 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
1241 (internal_cmd_crosstabs) Initializes cells[] correctly.
1242 (float_M_suffix) Rename format_cell_entry(), change prototype,
1244 (display_crosstabulation) Fix cell formatting.
1246 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
1248 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
1249 to call lex_discard_line() to do that.
1251 * command.c: (run_command) Call lex_discard_line() after
1254 * lexer.c: (lex_entire_end) Change behavior.
1255 (lex_rest_of_line) Change behavior. Return const char *.
1256 (lex_discard_line) Don't clear getl_buf, don't emit message.
1258 * main.c: (handle_error) Emit message here.
1260 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
1261 instead of lex_entire_line().
1263 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
1265 * title.c: (get_title) Call lex_discard_line() after
1267 (cmd_file_label) Ditto.
1268 (cmd_document) Deal with const char * return value.
1270 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
1272 Removed REMARK command.
1274 * command.c: (extract_prefix) Removed.
1275 (output_line) Removed.
1276 (cmd_remark) Removed.
1278 * command.def: Remove REMARK.
1280 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
1282 Added abort() after lots of assert(0) invocations to avoid some
1283 compiler warnings. We really need a NOT_REACHED macro.
1285 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1287 * sort.c: Added missing call to temp_file_close. Changed error
1288 messages to warnings.
1290 * set.q: Improved setting of set_view{length,width} to be more tolerant
1293 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
1295 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
1296 used with incorrect syntax.
1298 * error.c, error.h et al: Overridden definition of assert for a
1301 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
1302 subcommand was given when it ought to have been.
1304 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
1306 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
1310 (tab_joint_text) Ditto.
1312 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
1314 * levene.c: Add #include.
1316 * set.q: (set_viewport) Add `int' argument to make its prototype
1317 correct for signal().
1319 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
1321 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
1324 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
1326 Changed DFM from open-at-first-access to explicit-open. Before,
1327 calling dfm_get_record() or dfm_put_record() would automatically
1328 open the file. Now, you have to call dfm_open_for_reading() or
1329 dfm_open_for_writing() explicitly. This makes it possible to
1330 check permissions, file existence, etc. earlier.
1332 Also made struct file_handle more opaque, and clean up in general.
1334 * data-list.c: (cmd_data_list) Open handle for reading.
1336 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
1338 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
1339 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
1340 (open_inline_file) Removed.
1341 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
1342 it. Deal with line_number in extension record instead of file
1344 (dfm_get_record) Rewrote.
1345 (dfm_put_record) Rewrote.
1346 (dfm_push) Assert file is open and one of ours. Deal with
1347 line_number in extension record instead of file handle.
1348 (dfm_pop) Assert file is open and one of ours. Deal with
1349 line_number in extension record instead of file handle.
1350 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
1353 * file-handle.h: (enum constants RH_RF_*) Removed.
1354 (enum constants FH_MD_*) Removed.
1355 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
1356 `recform', `lrecl', `mode' members. Public references to
1357 `recform' changed to use handle_get_mode(), references to `lrecl'
1358 changed to use handle_get_record_width(). Added `private' member.
1359 (enum file_handle_mode) New.
1361 * file-handle.q: (struct private_file_handle) New structure.
1362 (struct file_handle_list) New structure.
1363 (static var files) New.
1364 (static var file_handles) Removed.
1365 (init_file_handle) Removed.
1366 (create_file_handle) Removed.
1367 (get_handle_with_name) New function.
1368 (get_handle_for_filename) New function.
1369 (cmd_file_handle) Rewritten.
1370 (hash_file_handle) Removed.
1371 (cmp_file_handle) Removed.
1372 (fh_init_files) Rewritten.
1373 (fh_parse_file_handle) Rewritten. Allows identifiers as
1375 (fh_get_handle_by_name) Renamed handle_get_name(), all references
1377 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
1378 references updated. Rewritten.
1379 (fh_record_width) Renamed handle_get_record_width(), all
1380 references updated. Rewritten.
1381 (handle_get_mode) New function.
1383 * file-type.c: (cmd_file_type) Open handle for reading.
1385 * filename.c: [unix] (struct file_identity) New structure.
1386 [unix] (fn_get_identity) New function.
1387 [unix] (fn_free_identity) New function.
1388 [unix] (fn_compare_file_identities) New function.
1389 [!unix] (struct file_identity) New structure.
1390 [!unix] (fn_get_identity) New function.
1391 [!unix] (fn_free_identity) New function.
1392 [!unix] (fn_compare_file_identities) New function.
1394 * lexer.c: (static var put) Renamed put_token, all references
1396 (static var put_tokstr) New.
1397 (static var put_tokval) New.
1398 (lex_init) Initialize put_tokstr().
1399 (restore_token) New function.
1400 (save_token) New function.
1401 (lex_get) Use restore_token().
1402 (lex_put_back) Use save_token().
1403 (lex_put_back_id) New function.
1404 (lex_put_forward) Removed.
1405 (lex_preprocess_line) Set put_token instead of using
1407 (lex_negative_to_dash) Use save_token(), set put_token directly.
1408 (dump_token) Use stderr instead of stdout.
1410 * main.c: (main) Remove call to cmd_init().
1412 * matrix-data.c: (cmd_matrix_data) Open file for reading.
1414 * pfm-read.c: Use handle_get_filename() instead of trying to use
1415 h->fn directly, all over.
1417 * pfm-write.c: Ditto.
1419 * print.c: (internal_cmd_print) Open handle for writing.
1420 (dump_table) Use handle_get_filename().
1421 (print_trns_proc) Use handle_get_mode().
1422 (cmd_print_space) Use fh_parse_file_handle().
1423 Open handle for writing.
1424 [0] (debug_print) Removed.
1426 * sfm-read.c: Use handle_get_filename() instead of trying to use
1427 h->fn directly, all over.
1429 * sfm-write.c: Ditto.
1431 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
1435 * autorecode.c: (arc_free) Free arc->src_values.
1437 * error.c: (msg) Free buf.
1439 * val-labs.c: (do_value_labels) Always free vars.
1441 * vfm.c: (close_active_file) If sink has no make_source then call
1442 its destroy function.
1444 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
1446 Fixed cmd_parse() so that it always skips past a full command
1447 name. A few special commands for which this would be bad get
1448 special treatment. This lets us drop code for skipping past the
1449 end of a command name in most cmd_*() functions. It's not worth
1450 listing all the commands affected.
1452 * command.c: (struct command) Remove `cmd' member, replace by
1453 `name' member, all references updated. Remove `word', `next',
1454 `skip_entire_name' members.
1455 (macro DEFCMD) Deal with revised `struct command'.
1456 (macro UNIMPL) Ditto.
1457 (macro SPCCMD) New macro for commands whose last word shouldn't be
1459 (static array cmd_table[]) Make const, rename `commands', remove
1461 (macro COMMAND_CNT) New macro.
1462 (split_words) Removed.
1464 (FILE_TYPE_okay) Make parameter const.
1465 (cmd_parse) Improve error messages.
1466 (match_strings) New function.
1467 (next_word) New function.
1468 (enum command_match) New enum.
1469 (conflicting_3char_prefixes) New function.
1470 (conflicting_3char_prefix_command) New function.
1471 (cmd_match_words) New function.
1472 (count_matching_commands) New function.
1473 (get_command_name) New function.
1474 (free_words) New function.
1475 (unknown_command_error) New function.
1476 (figure_out_command) Renamed parse_command_name(), rewritten.
1478 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
1479 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
1480 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
1483 * command.h: (macro SPCCMD) New.
1485 * include.c: (cmd_include_at) Removed.
1486 (cmd_include) Allow identifier to be used as filename.
1488 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
1490 * t-test.q: (cmd_t_test) Command name is now parsed for us.
1493 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
1495 Start work on better test framework.
1497 * Makefile.am: (pspp_sources) Add debug.c.
1499 * debug.c: New file.
1501 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
1502 cmd_debug_evaluate().
1504 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
1506 * expr.h: (enum constant PXP_DUMP) Removed.
1508 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
1510 * set.q: Implemented the SHOW command, and synced it to the existing
1513 Added a handler for SIGWINCH so that viewlength and viewwidth follow
1514 changes as the window size is changed.
1516 Added fallback to set viewlength and viewwidth from LINES and COLUMS
1517 environment variables if other methods are not available.
1519 glob.c: Removed a lot of global variables from glob.c and encapsulated
1522 random.c: Tidied up the way the random seed is set.
1524 str.c: Added a ds_vprintf function.
1526 error.c: Extended dump_message so that messages are always broken at
1529 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
1531 * pfm-write.c: (bufwrite) Write out the correct element for string
1532 variables. From Andreas Streichardt <streichardt@globalpark.de>.
1534 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
1536 Get rid of static and global (!) vars in matrix-data.c.
1538 * matrix-data.c: (static var nr_data) Removed.
1539 (static var nr_factor_values) Removed.
1540 (static var max_cell_index) Removed.
1541 (static var split_values) Removed.
1542 (struct nr_aux_data) New structure.
1543 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
1544 place of static vars, pass to create_case_source() and procedure()
1546 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
1547 struct matrix_data_pgm *.
1548 (nr_read_splits) Ditto.
1549 (nr_read_factors) Ditto.
1550 (nr_output_data) Ditto.
1551 (static var wr_content) Removed.
1552 (global var wr_data) Removed.
1553 (global var wr_current) Removed.
1554 (struct wr_aux_data) New structure.
1555 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
1556 place of static vars, pass to create_case_source() and procedure()
1558 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
1559 instead of matrix_data_pgm *.
1560 (wr_read_splits) Ditto.
1561 (wr_output_data) Ditto.
1562 (wr_read_rowtype) Ditto.
1563 (wr_read_factors) Ditto.
1564 (wr_read_indeps) Ditto.
1566 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
1568 Get rid of static vars in autorecode.c.
1570 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
1571 `n_arc' to `spec_cnt'. All references updated.
1572 (static var v_src) Removed.
1573 (static var v_dest) Removed.
1574 (static var h_trns) Removed.
1575 (static var nv_src) Removed.
1576 (static var descend) Removed.
1577 (static var print) Removed.
1578 (enum direction) New enum.
1579 (struct autorecode_pgm) New structure.
1580 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
1581 Move n_dest local var into struct autorecode_pgm for ease of
1582 clean-up. Use arc_free().
1583 (arc_free) New function.
1584 (recode) Modify to take struct autorecode_pgm * parameter instead
1585 of using statics. Let the caller clean up.
1586 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
1587 instead of statics. Rearrange code a little.
1589 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
1591 Get rid of static, global vars in recode.c. Remove debug code.
1593 * recode.c: (static var head) Removed.
1594 (global var v) Removed.
1595 (global var nv) Removed.
1596 (cmd_recode) New local variables head, v, nv. Initialize and free
1597 v. Don't call debug_print().
1598 [DEBUGGING] (dump_dest) Removed.
1599 [DEBUGGING] (debug_print) Removed.
1601 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
1603 Get rid of static vars in expr-opt.c.
1605 * expr-opt.c: (static var e) Removed.
1606 (static var nop) Removed.
1607 (static var mop) Removed.
1608 (static var ndbl) Removed.
1609 (static var mdbl) Removed.
1610 (static var nstr) Removed.
1611 (static var mstr) Removed.
1612 (static var nvars) Removed.
1613 (static var mvars) Removed.
1614 (struct expr_dump_state) New structure.
1615 (dump_expression) Use new struct expr_dump_state instead of static
1616 vars and pass to functions we call.
1617 (dump_node) Use struct expr_dump_state * parameter.
1619 (emit_num_con) Ditto.
1620 (emit_str_con) Ditto.
1623 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
1625 Get rid of static var in COUNT.
1627 * count.c: (static var head) Move into cmd_count().
1628 (cmd_count) [DEBUGGING] Don't call debug_print.
1629 [DEBUGGING] (debug_print) Removed.
1631 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
1633 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
1635 * val-labs.c: (static var v) Removed.
1636 (static var nv) Removed.
1637 [DEBUGGING] (debug_print) Removed.
1638 (verify_val_labs) Add struct variable **, int parameters.
1639 (get_label) Ditto. Improve error messages, streamline.
1640 (erase_labels) New function for erasing value labels, taking over
1641 part of verify_val_labs()'s function.
1644 (cmd_value_labels) No need to call init() or done() anymore.
1645 (cmd_add_value_labels) Ditto.
1646 (do_value_labels) Add vars, var_cnt local variables. Clean up
1647 after them internally. Call erase_labels() if we should. Don't
1650 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
1652 Get rid of static vars in MATCH FILES.
1654 * get.c: (static var mtf_head) Removed.
1655 (static var mtf_tail) Removed.
1656 (static var mtf_by) Removed.
1657 (static var mtf_n_by) Removed.
1658 (static var mtf_master) Removed.
1659 (static var mtf_seq_num) Removed.
1660 (static var mtf_seq_nums) Removed.
1661 (static var mtf_sink) Removed.
1662 (static var mtf_case) Removed.
1663 (struct mtf_proc) New structure.
1664 (cmd_match_files) Use struct mtf_proc instead of static vars.
1665 (mtf_processing_finish) Ditto.
1667 (mtf_delete_file_in_place) Ditto.
1668 (mtf_read_nonactive_records) Ditto.
1669 (mtf_compare_BY_values) Ditto.
1670 (mtf_processing) Ditto.
1671 (mtf_merge_dictionary) Ditto.
1673 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
1675 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
1677 * dictionary.c: (dict_rename_var) Add assertion.
1678 (dict_contains_var) Check by index instead of name.
1680 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
1682 Get rid of compaction_necessary, compaction_nval, compaction_case.
1683 Redo VFM interface. Replace disk_sink and memory_sink by
1684 storage_sink, disk_source and memory_source by storage_source.
1686 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
1690 (struct write_case_data) Remove `begin_func', `end_func',
1691 `func_aux' members. Add `aux', `trns_case', `sink_case',
1692 `cases_written', `cases_analyzed' members.
1693 (global var compaction_necessary) Make static.
1694 (global var compaction_nval) Removed.
1695 (global var compaction_case) Removed.
1696 (static var case_count) Removed.
1697 (struct procedure_aux_data) Removed.
1698 (struct split_aux_data) Removed.
1699 (procedure) Remove begin_func, end_func parameters. Rewrite.
1700 (static var not_canceled) Removed.
1701 (process_active_file) Removed.
1702 (process_active_file_write_case) Removed.
1703 (process_active_file_output_case) Removed.
1704 (prepare_for_writing) Moved into open_active_file().
1705 (arrange_compaction) Ditto.
1707 (open_active_file) Rewrote.
1708 (write_case) New function.
1709 [DEBUGGING] (index_to_varname) Removed.
1710 (execute_transformations) New function.
1711 (exclude_this_case) Renamed filter_case(), changed interface.
1712 (clear_case) Added struct ccase * parameter to interface.
1713 (close_active_file) Added struct write_case_data * parameter,
1715 (disk_sink_create) Removed.
1716 (disk_sink_destroy) Removed.
1717 (disk_sink_make_source) Removed.
1718 (disk_sink_write) Removed.
1719 (disk_source_count) Removed.
1720 (disk_source_destroy) Removed.
1721 (disk_source_read) Removed.
1722 (global var disk_sink_class) Removed.
1723 (global var disk_source_class) Removed.
1724 (global var memory_sink_class) Removed.
1725 (global var memory_source_class) Removed.
1726 (memory_sink_create) Removed.
1727 (memory_sink_destroy) Removed.
1728 (memory_sink_make_source) Removed.
1729 (memory_sink_write) Removed.
1730 (memory_source_count) Removed.
1731 (memory_source_destroy) Removed.
1732 (memory_source_get_cases) Removed.
1733 (memory_source_read) Removed.
1734 (memory_source_set_cases) Removed.
1735 (struct disk_stream_info) Removed.
1736 (struct memory_sink_info) Removed.
1737 (struct memory_source_info) Removed.
1738 (write_active_file_to_disk) Removed.
1739 (destroy_storage_stream_info) New function.
1740 (global var null_sink_class) New var.
1741 (global var storage_sink_class) New var.
1742 (global var storage_source_class) New var.
1743 (open_storage_file) New function.
1744 (storage_sink_destroy) New function.
1745 (storage_sink_make_source) New function.
1746 (storage_sink_open) New function.
1747 (storage_sink_write) New function.
1748 (storage_source_count) New function.
1749 (storage_source_destroy) New function.
1750 (storage_source_get_cases) New function.
1751 (storage_source_on_disk) New function.
1752 (storage_source_read) New function.
1753 (storage_source_set_cases) New function.
1754 (storage_source_to_disk) New function.
1755 (storage_to_disk) New function.
1756 (struct storage_stream_info) New structure.
1757 (write_storage_file) New function.
1758 (procedure_write_case) Removed.
1759 (create_case_source) Add `struct dictionary *' parameter, all
1761 (create_case_sink) Ditto.
1762 (free_case_sink) New function.
1763 (struct split_aux_data) New structure.
1764 (procedure_with_splits) New function implementing what procedure()
1766 (SPLIT_FILE_proc_func) Removed.
1767 (procedure_with_splits_callback) New function.
1768 (equal_splits) New function.
1770 * aggregate.c: Pass around a struct instead of using statics.
1771 (static var outfile) Remove.
1772 (enum type) Give it tag `missing_treatment'.
1773 (static var missing) Remove.
1774 (static var sort) Remove.
1775 (static var agr_first) Remove.
1776 (static var agr_next) Remove.
1777 (static var case_count) Remove.
1778 (static var prev_case) Remove.
1779 (static var buf64_1xx) Remove.
1780 (static var buf_1xx) Remove.
1781 (struct agr_proc) New structure incorporating the above.
1782 (cmd_aggregate) Use new struct. Clean up error handling using
1783 agr_destroy(). Completely rewrite actual implementation of
1785 (create_sysfile) Add struct agr_proc * parameter, modify
1787 (parse_aggregate_functions) Ditto.
1788 (free_aggregate_functions) Ditto. Rename agr_destroy().
1789 (aggregate_single_case) Add struct agr_proc * parameter, modify
1791 (accumulate_aggregate_info) Ditto.
1792 (dump_aggregate_info) Ditto.
1793 (initialize_aggregate_info) Ditto.
1794 (agr_00x_trns_proc) Removed.
1795 (agr_00x_end_func) Removed.
1796 (agr_10x_trns_proc) Removed.
1797 (agr_10x_trns_free) Removed.
1798 (agr_10x_end_func) Removed.
1799 (agr_11x_read) Removed.
1800 (agr_11x_finish) Removed.
1801 [DEBUGGING] (debug_print) Removed.
1802 (write_case_to_sfm) Add struct agr_proc * parameter, modify
1804 (agr_to_active_file) New function.
1805 (presorted_agr_to_sysfile) New function.
1806 (sort_agr_to_sysfile) New function.
1808 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
1810 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
1812 * descript.q: (cmd_descriptives) Ditto.
1814 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
1815 to new procedure() interface.
1817 * command.c: (cmd_execute) Adapt to new procedure() interface.
1819 * dictionary.c: (dict_compact_values) Also delete scratch
1821 (dict_get_compacted_value_cnt) New function.
1822 (dict_get_compacted_idx_to_fv) New function.
1824 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
1825 (cmd_flip) Adapt to new procedure() interface.
1826 (flip_sink_write) Use sink->idx_to_fv.
1828 * frequencies.q: (internal_cmd_frequencies) Use
1829 procedure_with_splits().
1831 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
1832 (static var mtf_sink) New static var.
1833 (static var mtf_case) New static var.
1834 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
1835 we actually implement the matching.
1836 (mtf_delete_file_in_place) Use mtf_case.
1837 (mtf_processing) Use mtf_case and mtf_sink.
1838 (cmd_export) Adapt to new procedure() interface.
1840 * levene.c: (levene) Use procedure_with_splits().
1842 * list.q: (cmd_list) Use procedure_with_splits().
1844 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
1845 procedure() interface.
1846 (read_matrices_with_rowtype) Ditto.
1848 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
1849 TEMPORARY. Adapt to new procedure() interface.
1851 * rename-vars.c: Warn about and cancel TEMPORARY.
1853 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
1854 (sort_cases) Use dict_get_compacted_value_cnt() instead of
1855 compaction_nval. Adapt to new procedure() interface. Use
1856 storage_source_to_disk().
1857 (do_internal_sort) Don't try to dump the cases to memory.
1858 (compare_case_lists) Pass null idx_to_fv.
1859 (struct initial_run_state) Add `idx_to_fv' member. Remove
1861 (write_initial_runs) Don't initialize irs->case_size. Adapt to
1862 new procedure() interface. Reset irs->idx_to_fv after calling
1864 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
1865 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
1867 (destroy_initial_run_state) Don't dereference irs after freeing
1869 (allocate_cases) Don't calculate case_size locally.
1870 (compare_record) Add idx_to_fv parameter.
1871 (compare_record_run) Change parameter from struct sort_cases_pgm *
1872 to struct initial_run_state *. Pass irs->idx_to_fv to
1874 (compare_record_run) Third parameter now a struct
1875 initial_run_state *.
1876 (output_record) No need for out_case anymore. Pass irs, not
1877 struct sort_cases_pgm to pop_heap(). Use case_size from struct
1879 (merge) Use case_size from struct sort_cases_pgm.
1880 (merge_once) Use case_size from struct sort_cases_pgm.
1881 Pass null pointer to compare_record() as idx_to_fv.
1882 (global var sort_sink_class) Make static.
1884 * t-test.q: (cmd_t_test) Use procedure_with_splits().
1886 * temporary.c: Remove debugging crap.
1888 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
1890 * t-test.q, levene.c: Fixed up the handling of MISSING values
1893 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
1895 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
1898 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
1900 Change explicit variable name checks into use of
1901 dict_class_from_id().
1903 * dictionary.c: (dict_create_var) Change explicit variable name
1904 check into use of dict_class_from_id().
1906 * get.c: (trim_dictionary) Ditto.
1908 * sel-if.c: (cmd_filter) Ditto.
1910 * sysfile-info.c: (cmd_display) Ditto.
1912 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
1914 * vfm.c: (arrange_compaction) Ditto.
1916 * weight.c: (cmd_weight) Ditto.
1918 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
1920 * temporary.c: (cmd_temporary) When TEMPORARY was the first
1921 transformation following the input program, if any, for some
1922 reason we special-cased f_trns. That's just wrong. It should
1923 always be set to n_trns.
1925 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
1927 * format.c: (parse_format_specifier_name) Fix brown-bag bug
1928 introduced in last check-in.
1930 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
1932 * format.c: (global array translate_fmt[]) Removed.
1933 (translate_fmt) New function as replacement.
1934 (parse_format_specifier_name) Rewrite.
1936 * pfm-read.c: (convert_format) Use translate_fmt() instead of
1939 * sfm-read.c: (parse_format_spec) Ditto.
1941 * postscript.c: (text) Fix handling of fonts with missing
1944 * sort.c: (struct external_sort) Add temp_name member.
1945 (destroy_external_sort) Free temp_dir, temp_name members.
1946 (init_external_sort) Allocate temp_name.
1947 (get_temp_file_name) Change prototype.
1948 (open_temp_file) Deal with change to get_temp_file_name().
1949 (close_temp_file) Ditto.
1950 (remove_temp_file) Ditto.
1951 (write_temp_file) Ditto.
1952 (read_temp_file) Ditto.
1953 (sort_sink_destroy) Removed.
1954 (sort_sink_class) Change destroy member to null.
1956 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
1958 Eliminate temp_case.
1960 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
1961 anymore. Use agr_11x_finish().
1962 (aggregate_single_case) Make first param const.
1963 (accumulate_aggregate_info) Ditto.
1964 (agr_00x_end_func) Use compaction_case, not temp_case.
1965 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
1967 * data-list.c: (struct data_list_pgm) Add `case_size' member.
1968 (cmd_data_list) Initialize case_size.
1969 (read_from_data_list_fixed) Add struct ccase * param, use instead
1971 (read_from_data_list_free) Ditto.
1972 (read_from_data_list_list) Ditto.
1973 (read_one_case) Rename data_list_trns_proc(), all references
1974 updated. Add argument in calling above functions. Use c
1975 argument instead of temp_case.
1976 (destroy_dls) Rename data_list_trns_free(), all references
1979 * expr-evl.c: (expr_evaluate) Make second parameter const.
1981 * file-type.c: (struct file_type_pgm) Add `case_size' member.
1982 (cmd_end_file_type) Initialize `case_size'.
1983 (file_type_source_read) Add struct ccase * parameter. Use instead
1986 * flip.c: Rewritten.
1988 * get.c: (struct get_pgm) New structure to keep track of
1990 (cmd_get) Initialize case_size.
1992 (get_source) Deal with struct get_pgm.
1993 (get_source_read) Add struct ccase * parameter, use instead of
1995 (import_source_read) Ditto.
1997 * get.c: Use a null pointer instead of temp_case to represent the
1998 "current case" in a struct mtf_file's input member.
1999 (mtf_processing_finish) Pass null to mtf_processing(), not
2001 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
2002 (mtf_compare_BY_values) Add extra arg, use instead of null input
2004 (mtf_processing) Use c parameter instead of temp_case. Pass
2005 compaction_case to process_active_file_output_case().
2007 * glob.c: (global variable temp_case) Removed.
2009 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
2010 (cmd_input_program) Initialize case_size. Set
2011 vfm_source->value_cnt.
2012 (init_case) Add struct ccase * parameter, use instead of
2015 (input_program_source_read) Ditto.
2017 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
2018 (dump_cell_content) Ditto.
2019 (nr_output_data) Ditto.
2020 (read_matrices_without_rowtype) Ditto.
2021 (matrix_data_read_with_rowtype) Ditto.
2022 (wr_read_splits) Ditto.
2023 (wr_output_data) Ditto.
2025 * sort.h: (struct sort_cases_pgm) New member `case_size'.
2027 * sort.c: (sort_cases) Initialize scp->case_size.
2028 (struct external_sort) Remove `case_size' member.
2029 (write_initial_runs) Only call vfm_sink->class_destroy if
2031 (struct sort_source_aux) New structure.
2032 (sort_source_read_helper) New function.
2033 (sort_source_read) Use sort_source_read_helper().
2034 (read_sort_output) Change interface to be more reasonable.
2035 (read_internal_sort_output) Ditto.
2036 (read_external_sort_output) Ditto.
2038 * vars-prs.c: (dict_class_to_name) Pass return value through
2041 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
2042 (procedure) Initialize trns_case.
2043 (procedure) Pass trns_case to vfm_source->class->read().
2045 (process_active_file) Start using struct procedure_aux_data.
2046 (process_active_file_write_case) Pass trns_case to
2047 transformations, lag_case(), clear_case().
2048 (process_active_file_output_case) Add struct ccase * parameter.
2049 (create_trns_case) New function.
2050 (make_temp_case) Removed.
2051 (vector_initialization) Removed.
2052 (close_active_file) Only call make_source if non-null, otherwise
2053 set vfm_source to null pointer. Don't free temp_case.
2054 (disk_source_read) Add struct ccase * parameter, use instead of
2056 (memory_source_read) Ditto.
2057 (lag_case) Add const struct ccase * member.
2058 (procedure_write_case) Use trns_case instead of temp_case.
2059 (clear_case) Add struct ccase * member, use instead of temp_case.
2060 (exclude_this_case) Ditto.
2061 (create_case_source) Add struct dictionary * parameter, use to
2062 initialize source->value_cnt.
2064 * vfm.h: (struct case_source) Add `value_cnt' member.
2065 (struct case_source_class) Add struct ccase * parameter to `read'
2066 member function pointer.
2067 (struct case_sink_class) Make struct ccase * parameter const in
2068 `write' member function pointer.
2070 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
2072 Fix a lot of "possibly uninitialized variable" warnings. Some of
2073 them are even real bugs. A few of them make me wonder how the
2076 * aggregate.c: (parse_aggregate_functions) Initialize `function.
2078 * ascii.c: (output_lines) Add default case to switch.
2080 * crosstabs.q: Remove static variable `expected' and all
2082 (display_crosstabulation) Always calculate expected value.
2084 (output_pivot_table) Initialize `cmp'.
2085 (display_crosstabulation) New variable `last_row', which is
2088 * data-in.c: (parse_numeric) Always initialize sign. How did this
2091 * data-list.c: (repeating_data_trns_proc) Always initialize code.
2092 Always set info.ofs. (How did this work?!)
2094 * expr-opt.c: (optimize_tree) Always initialize `m'.
2095 (evaluate_tree) Always initialize `c'. (How did this work?)
2097 * frequencies.q: (frq_custom_variables) Always initialize min,
2099 (frq_custom_grouped) Always initialize `dl'.
2101 * groff-font.c: (groff_read_font) Always initialize char_set.
2103 * matrix-data.c: (nr_output_data) Initialize `split'.
2104 (wr_read_splits) Remove shadowing split_cnt declaration.
2105 (wr_output_data) Initialize `split'.
2107 * output.c: (tokener) Skip add character on syntax error.
2109 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
2111 * postscript.c: (read_ps_encodings) Use line.string instead of
2113 (write_text) Add default case to switch.
2114 (text) Always initialize multiple variables. Fix bug with
2117 * print.c: (fixed_parse_fortran) Initialize head.
2118 (alloc_line) Add default case to switch.
2120 * recode.c: (parse_dest_spec) Handle case where nothing matches.
2121 (recode_trns_proc) Move variable declaration inward. Add default
2124 * sfm-read.c: (read_header) Initialize skip_amt.
2126 * sysfile-info.c: (display_variables) Always initialize pc.
2128 * vars-prs.c: Initialized `included'.
2130 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
2132 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
2133 Just use signal() instead.
2135 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
2137 Get rid of vfm_sink_info and vfm_source_info.
2139 * aggregate.c: (agr_00x_end_func) Don't increment
2140 sfm_sink_info.ncases.
2142 * sort.c: (do_internal_sort) Get case count from
2143 vfm_source->class->count().
2144 (struct external_sort) Add `case_size' member.
2145 (do_external_sort) Initialize case_size.
2146 (struct initial_run_state) Add `case_size' member.
2147 (write_initial_runs) Initialize case_size.
2148 (sort_sink_write) Use case_size.
2149 (read_external_sort_output) Use case_size. Get case_cnt from
2152 * vfm.c: (struct write_case_data) Add underscores to existing arg
2153 names, all references updated. Renamed `aux' as `func_aux', all
2154 references updated. Added new `aux' member.
2155 (global var vfm_source_info) Removed.
2156 (global var vfm_sink_info) Removed.
2157 (struct procedure_aux_data) New.
2158 (struct split_aux_data) New.
2159 (procedure) Use `aux' fields for procedure_aux_data,
2161 (process_active_file_write_case) Pass case_count + 1 to
2162 transformation procedures, exclude_this_case().
2163 (process_active_file_output_case) Don't increment
2164 vfm_sink_info.ncases.
2165 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
2166 to send data to disk early.
2167 (make_temp_case) Don't use vfm_sink_info.case_size.
2168 (close_active_file) Don't initialize vfm_source_info.
2169 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
2170 (disk_sink_create) Initialize and/or update disk_stream_info.
2171 (disk_sink_write) Ditto.
2172 (disk_sink_destroy) Ditto.
2173 (disk_sink_make_source) Ditto.
2174 (disk_source_read) Ditto.
2175 (disk_source_destroy) Ditto.
2176 (global var disk_source_class) Add disk_source_count().
2177 (disk_source_count) New function.
2178 (struct memory_sink_info) Add `case_cnt', `case_size' members.
2179 (struct memory_source_info) Ditto.
2180 (memory_sink_create) Deal with case_cnt, case_size.
2181 (memory_sink_write) Ditto.
2182 (memory_sink_make_source) Ditto.
2183 (memory_source_read) Ditto.
2184 (memory_source_count) New function.
2185 (memory_source_class) Add memory_source_count().
2186 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
2187 proc_aux->cases_written, and pass it to transformation procedures
2188 and exclude_this_case ().
2189 (exclude_this_case) Add case_num parameter. Pass it to
2191 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
2194 * vfm.h: (struct case_source_class) Add `count' member.
2196 * vfmP.h: (struct stream_info) Removed.
2197 (global variable vfm_source_info) Removed.
2198 (global variable vfm_sink_info) Removed.
2200 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
2202 * var.h: (typedef trns_proc_func) New typedef.
2203 (trns_free_func) New typedef.
2204 (struct trns_header) Change `proc' to type trns_proc_func, `free'
2205 to type trns_free_func. This only changes the actual type of
2206 trns_proc_func, adding a `case_num' parameter. Updated all
2207 implementations to use the typedefs instead.
2209 * compute.c: (compute_num) Pass case_num to expr_evaluate().
2210 (compute_num_vec) Ditto.
2211 (compute_str) Ditto.
2212 (compute_str_vec) Ditto.
2214 * do-if.c: (do_if_trns_proc) Ditto.
2216 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
2219 * inpt-pgm.c: (input_program_source_read) Maintain case count,
2220 pass to transformation functions.
2221 (reread_trns_proc) Pass case_num arg to expr_evaluate().
2223 * loop.c: (loop_1_trns_proc) Ditto.
2224 (loop_2_trns_proc) Ditto.
2225 (loop_3_trns_proc) Ditto.
2227 * print.c: (print_space_trns_proc) Ditto.
2229 * sel-if.c: (select_if_proc) Ditto.
2231 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
2233 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
2234 destroying hash table.
2236 * glob.c: (read_active_file) Variable not referenced, removed.
2237 (cancel_input_pgm) Ditto.
2239 * levene.c: Add #include <stdlib.h> needed to call free().
2241 * aggregate.c: (parse_aggregate_functions) Make `function'
2244 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
2246 Start working to eliminate VFM dependence on static variables.
2248 * command.c: (cmd_parse) Use case_source_is_class().
2250 * data-list.c: Rewrite to eliminate use of static variables.
2252 * dfm.c: (cmd_begin_data) Use case_source_is_class().
2254 * file-handle.q: (fh_handle_name) Make parameter const.
2256 * file-type.c: Rewrite to eliminate use of static variables.
2258 * flip.c: Rewrite to eliminate use of static variables.
2260 * format.c: (get_format_var_width) New function.
2262 * get.c: Eliminate use of static variables.
2264 * inpt-pgm.c: Eliminate use of static variables.
2266 * matrix-data.c: Eliminate use of static variables.
2268 * set.q: (set_max_workspace) New variable.
2269 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
2271 * var.h: (struct case_list) Move here from vfmP.h.
2273 * vars-atr.c: (discard_variables) Handle new vfm_source type.
2275 * vfm.c: (vfm_source) Change type from struct case_stream to
2277 (vfm_sink) Change type from struct case_stream to struct
2279 (static var paging) Rename workspace_overflow, all references
2281 (procedure) Use new class structures.
2282 (process_active_file) Ditto.
2283 (process_active_file_write_case) Ditto.
2284 (prepare_for_writing) Use set_max_workspace. Use new class
2286 (close_active_file) Use new class structures. Free old sink.
2287 (global var disk_source_file) Removed.
2288 (global var disk_sink_file) Removed.
2289 (disk_stream_init) Removed.
2290 (disk_stream_read) Removed.
2291 (disk_stream_write) Removed.
2292 (disk_stream_mode) Removed.
2293 (disk_stream_destroy_source) Removed.
2294 (disk_stream_destroy_sink) Removed.
2295 (global var vfm_disk_stream) Removed.
2296 (disk_sink_create) New function.
2297 (disk_sink_write) New function.
2298 (disk_sink_destroy) New function.
2299 (disk_sink_make_source) New function.
2300 (disk_sink_class) New static var.
2301 (disk_source_read) New function.
2302 (disk_source_destroy) New function.
2303 (global var vfm_source_class) New var.
2304 (global var memory_source_cases) Removed.
2305 (global var memory_sink_cases) Removed.
2306 (global var memory_sink_max_cases) Removed.
2307 (struct memory_sink_info) New struct.
2308 (memory_stream_init) Removed.
2309 (memory_stream_read) Removed.
2310 (memory_stream_write) Removed.
2311 (memory_stream_mode) Removed.
2312 (memory_stream_destroy_source) Removed.
2313 (memory_stream_destroy_sink) Removed.
2314 (global var vfm_memory_stream) Removed.
2315 (page_to_disk) Renamed write_active_file_to_disk().
2316 (memory_sink_create) New function.
2317 (memory_sink_write) New function.
2318 (memory_sink_destroy) New function.
2319 (memory_sink_make_source) New function.
2320 (memory_sink_class) New static var.
2321 (memory_source_read) New function.
2322 (memory_source_destroy) New function.
2323 (memory_source_get_cases) New function.
2324 (memory_source_set_cases) New function.
2325 (global var vfm_source_class) New var.
2326 (procedure_write_case) Use new class structures.
2327 (create_case_source) New function.
2328 (case_source_is_complex) New function.
2329 (case_source_is_class) New function.
2330 (create_case_sink) New function.
2332 * vfm.h: (global variable reinit_sysmis) Not used, removed.
2333 (global variable reinit_blanks) Not used, removed.
2334 (global variable init_zero) Not used, removed.
2335 (global variable init_blanks) Not used, removed.
2336 (struct case_source) New struct.
2337 (struct case_source_class) New struct.
2338 (struct case_sink) New struct.
2339 (struct case_sink_class) New struct.
2340 (struct case_stream) Removed.
2342 * vfmP.h: (struct case_list) Moved to var.h.
2344 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
2346 * algorithm.c: (count_equal) New function.
2347 (count_if) New function.
2348 (unique) Add assertions.
2349 (partition) Add assertions.
2350 (is_partitioned) New function.
2351 (copy_if) Add assertions.
2352 (remove_equal) Add assertions.
2353 (lexicographical_compare) Rename lexicographical_compare_3way.
2354 (sort) Add assertions. Rephrase some code.
2355 (is_sorted) New function.
2357 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
2361 * sort.c: Completely rewrite.
2363 * sort.h: Expose interface via struct sort_cases_pgm, not via
2366 * aggregate.c: (sort) New static var.
2367 (cmd_aggregate) Use sort.
2368 (create_sysfile) Ditto.
2369 (aggregate_single_case) Ditto.
2370 (dump_aggregate_info) Ditto.
2371 (agr_00x_end_func) Ditto.
2372 (debug_print) Ditto.
2374 * var.h: (enum SRT_ASCEND) Removed.
2375 (enum SRT_DESCEND) Removed.
2376 (struct sort_cases_proc) Removed.
2377 (struct variable) Remove p.srt member.
2379 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
2381 Get rid of the old, crappy heap structure and replace it by a new,
2382 shiny, C++ STL-like heap structure.
2384 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
2386 * algorithm.c: (push_heap) New function.
2397 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
2399 Increase warning level.
2401 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
2403 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
2405 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
2407 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
2409 * dictionary.c: (dict_create_var) Fix root cause of bug worked
2410 around by previous change log entry.
2412 * compute.c: (lvalue_finalize) Remove workaround from previous
2415 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2417 * compute.c: Fixed a bug where the Format was not getting set for
2418 computed variables (thus causing a crash when SAVEing).
2420 * Added a test to stop this bug ever coming back
2422 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
2424 Got rid of approx.h. In general, replaced all references to
2425 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
2428 * Makefile.am: (pspp_SOURCES) Removed approx.h.
2430 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
2431 test for mag < EPSILON.
2433 * misc.h: Add definition of EPSILON.
2435 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
2437 * vfm.c: (procedure) Add check to prevent recursive call.
2439 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
2441 * Moved the declarations relating to values to their own header file
2444 * Added levene.c and levene.h
2446 * vars-atr.c: Changed the signature of compare_values to
2447 take const * arguments.
2449 * t-test.q: Changed the structure of struct t_test_proc
2450 variables now contain their own group statistics information.
2451 Eventually, t_test_proc might get renamed, because it'd be
2452 applicable to other commands too.
2454 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
2456 * data-out.c: Clean up. Changed interface of convert_*() to take
2457 either a `double' or a `const char *' instead of a `const union
2458 value *'. Update all implementations of those interfaces.
2459 (data_out) Use switch statements instead of a table.
2460 (convert_AHEX) Rewrite.
2462 * format.h: Update comment.
2464 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
2466 * q2c.c: (dump_header) Add an Emacs header line to output files
2467 that makes generated .c files read-only by default, to make it
2468 difficult to accidentally change generated files.
2470 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
2472 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
2473 not bogus a->v.c <=> b->v.c pointer compare.
2474 (compare_freq_alpha_a) Ditto.
2475 (compare_freq_numeric_d) Ditto.
2476 (compare_freq_alpha_d) Ditto.
2478 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
2480 Changed data_out() to store string data directly into a `union
2481 value''s s member, not indirectly into c.
2483 * crosstabs.q: (output_pivot_table) Use format_short() instead of
2485 (table_value_missing) Ditto.
2486 (float_M_suffix) Ditto.
2487 (format_short) New function.
2489 * data-in.h: (data_in_finite_line) Remove inline definition.
2491 * data-list.c: (destroy_dls_var_spec) New function.
2492 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
2493 (data_list_source_destroy_source) Avoid cast.
2494 (struct repeating_data_trns) New field `id_value'. Update
2496 (cmd_repeating_data) Initialize id_value. Use new
2497 repeating_data_trns_free() for freeing REPEATING DATA
2499 (rpd_parse_record) Rewrite support for record ID to be less bogus.
2500 (repeating_data_trns_free) New function.
2502 * data-out.c: (data_out) Change return type to `void' by replacing
2503 error returns by writing a message into the output buffer.
2504 (convert_A) Read from v->s instead of v->c.
2505 (convert_AHEX) Ditto.
2507 * expr-evl.c: Update comment.
2508 (expr_evaluate) Add assertion in OP_STRING case.
2510 * format.h: (macro MAX_FORMATTED_LEN) New macro.
2512 * list.q: (list_cases) Update for new data_out() semantics.
2514 * print.c: (print_trns_proc) Ditto.
2516 * tab.c: (tab_value) Ditto.
2517 (tab_float) Avoid stupid cast.
2519 * var.h: Update comments.
2520 (macro MAX_STRING) New macro.
2521 (macro MAX_ELEMS_PER_VALUE) New macro.
2523 * vars-atr.c: (compare_values) New function.
2525 * vfm.c: (dump_splits) Update for new data_out() semantics.
2527 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
2529 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
2531 (struct crosstab) Rename v[] to vars[]. All references updated.
2532 (hash_table_entry) Replace the hash algorithm and fix a bug at the
2533 same time, which caused the hash value to depend only on a single
2534 value, not all of the variables' values.
2536 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
2538 Clean up struct dictionary's value_cnt usage.
2540 * dictionary.c: Add a function comment to each function.
2541 (struct dictionary) Rename value_cnt to next_value_idx, which more
2542 accurately reflects its meaning. All references updated.
2543 (dict_rename_vars) Add assertion.
2544 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
2546 (dict_get_case_size) New function.
2548 * aggregate.c: (create_sysfile) Use dict_get_case_size().
2550 * get.c: (mtf_read_nonactive_records) Ditto.
2552 * sort.c: (allocate_cases) Ditto.
2553 (write_initial_runs) Ditto.
2557 * vfm.c: (prepare_for_writing) Ditto.
2561 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
2563 Make vfm.c slightly less grotesque.
2565 * vfm.c: (filter_var) Removed.
2566 (filter_index) Removed.
2567 (FILTERED macro) Removed.
2568 (exclude_this_case) New function.
2569 (process_active_file_write_case) Use exclude_this_case() instead
2570 of FILTERED and inline tests.
2571 (procedure_write_case) Ditto.
2572 (setup_filter) Removed.
2573 (open_active_file) Don't call setup_filter().
2574 (close_active_file) Call dict_get_filter() instead of checking
2577 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
2579 * var.h: (struct variable) Update comments.
2581 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
2583 New functions dict_create_var_assert(), dict_lookup_var_assert().
2584 Converted several dict_*_var()/assert pairs into a single
2585 dict_*_var_assert().
2587 * dictionary.c: (dict_create_var_assert) New function.
2588 (dict_lookup_var_assert) New function.
2590 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
2592 Got rid of "struct long_vec", envector(), devector(), etc. Added
2593 two members `init', `reinit' to struct variable as a substitute.
2595 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
2601 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
2604 * autorecode.c: (cmd_autorecode) destvars don't need init.
2606 * compute.c: (lvalue_finalize) Set reinit.
2608 * data-list.c: (fixed_parse_compatible) Don't need init usually.
2609 (dump_fmt_list) Ditto.
2612 * descript.q: (run_z_pass) Don't need init for z-scores.
2614 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
2616 (dict_clone_var) Copy `reinit' member, initialize `init' member.
2618 * glob.c: (init_glob) Remove vec_init() calls.
2620 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
2622 * loop.c: (internal_cmd_loop) Don't need to call envector().
2624 * numeric.c: (cmd_numeric) Ditto.
2626 (cmd_leave) Ditto. Set `init', `reinit' members.
2628 * recode.c: (cmd_recode) Don't need to call envector().
2630 * repeat.c: (internal_cmd_do_repeat) Ditto.
2632 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
2633 (force_create_variable) Removed prototype.
2634 (force_dup_variable) Ditto.
2636 * vector.c: (cmd_vector) Don't need to call envector().
2638 * vfm.c: (reinit_sysmis) Removed.
2639 (reinit_blanks) Removed.
2640 (init_zero) Removed.
2641 (init_blanks) Removed.
2642 (process_active_file_write_case) No need to deal with vectors.
2643 Call clear_temp_case().
2644 (vector_initialization) Rewrite to use `init', `reinit'.
2645 (close_active_file) No need to call vec_clear().
2646 (procedure_write_case) Call clear_temp_case().
2647 (clear_temp_case) New function.
2649 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
2651 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
2654 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
2656 Add auxiliary argument to procedure() interface. Associated small
2657 clean-ups of vfm interface.
2659 * Updated every caller of procedure() and process_active_file() to
2660 reflect modified interface. Simple, ordinary changes not listed
2663 * Updated every function that implements struct case_stream's
2664 `read' function to take a write_case_func and a write_case_data.
2665 Also updated every caller of write_case() to instead call them
2666 through these arguments. In some cases this meant that the extra
2667 args had to be threaded through a couple of extra levels. This
2668 wasn't difficult or interesting so the details won't be given.
2670 * data-list.c: (struct repeating_data_trns) Add members
2671 `write_case', `wc_data' as kluge.
2672 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
2674 (repeating_data_set_write_case) New function.
2676 * data-list.h: New file to declare repeating_data_trns_proc() and
2677 repeating_data_set_write_case().
2679 * inpt-pgm.c: (input_program_source_read) Call
2680 repeating_data_set_write_case() for all the REPEATING DATA
2681 transformations, so that they know where to send their cases.
2682 It's a big kluge. Also kluge in END CASE.
2683 (end_case_trns_proc) Never called anymore, but we still need it,
2686 * sort.c: (read_sort_output) Update to match struct case_stream
2689 * vfm.c: (struct write_case_data) New structure.
2690 (proc_func) Removed.
2691 (virt_proc_func) Removed.
2692 (begin_func) Removed.
2693 (virt_begin_func) Removed.
2695 (write_case) Removed.
2696 (procedure) Added an auxiliary parameter to each function pointer
2697 argument's prototype. Added an auxiliary data parameter.
2699 (process_active_file) Ditto.
2700 (process_active_file_write_case) Pass aux data along.
2701 (close_active_file) Ditto.
2702 (procedure_write_case) Ditto.
2703 (SPLIT_FILE_procfunc) Ditto.
2705 * vfm.h: (typedef write_case_data) New.
2706 (typedef write_case_func) New.
2707 (struct case_stream) Add parameters to `read' member prototype.
2709 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
2711 * t-test.q: Added calculations for independent samples. (But no Levene
2714 * Makefile.am: Moved q_sources_c into own variable
2716 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
2718 Miscellaneous cleanups.
2720 * Change unused to UNUSED in many source files to reflect modified
2721 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
2722 __CYGWIN32__, __unix__, and unix not to assume that they're
2723 defined to a nonzero value. Change use of __attribute__ to use
2724 NO_RETURN or PRINTF_FORMAT instead.
2726 * alloc.h: Move definitions for local_alloc(), local_free() here
2727 from ../pref.h.orig and simplify.
2729 * expr-evl.c: Instead of working differently based on PAGED_STACK,
2730 use a pool allocator unconditionally.
2731 (CHECK_STRING_SPACE) Removed.
2732 (ALLOC_STRING_SPACE) Removed.
2733 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
2736 * expr-opt.c: (dump_expression) Allocate string pool.
2738 * expr-prs.c: (expr_free) Free string pool.
2740 * pool.c: (pool_destroy) This pool must be removed from its
2741 parent's list of gizmos, not from its own. Use free_all_gizmos().
2742 (pool_clear) New function.
2743 (free_all_gizmos) New function.
2744 (pool_alloc) Use space in empty block after this one if any.
2745 (pool_release) Only empty out blocks, don't actually free() them.
2747 * print.c: Get rid of PAGED_STACK special case by always
2748 dynamically allocating line buffers.
2749 (struct print_trns) Always include the `line' member.
2750 (internal_cmd_print) Always initialize the `line' member.
2751 (alloc_line) Always allocate memory for `line'.
2752 (print_trns_proc) Always initialize buf from `line' member.
2753 (print_trns_free) Always free `line' memory.
2755 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
2758 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
2760 * flip.c: Fixed crash from FLIP when a numeric variable is
2761 specified on NEWNAMES and a large value is used, and a couple of
2762 other minor bugs besides.
2763 (struct varname) Make name a 9-character fixed-size array
2764 instead of a 1-character variable size array.
2765 (make_new_var) Allow digits in variable names.
2766 (flip_stream_write) Limit numeric values to 8 characters and
2767 format system missing and very large and small values more
2770 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2772 * command.c: Fixed test on command return status for the correct
2773 value, which had been causing a crash under certain invalid input.
2775 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2777 * t-test.q: Added calculations for the one sample variant of the T-TEST
2779 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
2781 * tab.c: (render_strip) Fix bug that sometimes caused joined text
2782 in joined cells to be rendered outside box boundaries.
2784 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2786 * random.c (rng_create): Fixed seeding so that it gets reseeded after
2787 SET seed=xx has been called.
2789 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
2791 * random.c (rng_get_double): Fix always-returning-zero bug in my
2792 preferred way, and at the same time make sure rounding doesn't
2795 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
2797 * html.c: (change_attributes) Dead code, removed.
2798 (escape_string) Eliminate code to call change_attributes() that
2799 never actually called it.
2800 (output_tab_table) Get rid of dependence on tab_hit
2801 and struct tab_joined_cell's hit member, which are abominations.
2803 * tab.c: (tab_output_text) Don't call
2804 d->class->text_set_font_by_name if it's a null pointer.
2805 (macro UNROLL_LOOP) Eliminate.
2806 (macro UNROLL_3_LOOPS) Eliminate.
2807 (tabi_render) Rewrite not to use the above macros.
2809 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
2811 Start working on a new output driver system, one that doesn't suck
2812 so much, by adding a "device-independent" output driver. The idea
2813 is to write out only a single output stream, then use separate
2814 processes to translate them into whatever formats we want. This
2815 is similar to how "groff" works with its various output drivers
2816 (grops, grotty, grodvi, ...).
2818 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
2820 * list.q: (write_all_headers) Stub out devind class.
2822 (determine_layout) Ditto.
2825 * output.c: (outp_init) Add devind class.
2827 * devind.c: New file.
2829 * devind.h: New file.
2831 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
2833 * frequencies.q: (hash_value_alpha) Fixed up the previous change
2834 to use the proper string length.
2836 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
2838 * Fixed bug where FREQ would crash on alpha values
2840 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
2842 * Removed bletcherous alloca() workarounds for AIX from top of
2843 many files. AIX can use the alternative alloca() implementation
2846 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
2848 * ascii.c: (ascii_option) Fix implementation of headers option.
2850 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
2852 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
2853 multiple blank lines into one.
2854 (struct ascii_driver_ext) Add squeeze_blank_lines option.
2855 (ascii_preopen_driver) Initialize squeeze_blank_lines.
2856 (static var option_tab) Add squeeze entry.
2857 (ascii_option) Set squeeze_blank_lines.
2858 (output_lines) Implement squeezing blank lines.
2860 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
2862 * Removed redundant code from output.h
2864 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
2866 Dictionary classes: each variable is "ordinary", "system", or
2869 * var.h: (enum dict_class) New enum.
2871 * vars-prs.c: (dict_class_from_id) New function.
2872 (dict_class_to_name) New function.
2874 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
2876 * var.h: (struct freq_tab_set) Removed (not used).
2878 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
2880 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
2882 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
2884 * stats.c: (hypercube) Rename pow4(). All references updated.
2886 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
2888 * rename-vars.c: (cmd_rename_variables) Rewritten.
2889 (compare_name) Removed.
2891 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
2893 var_set feature, and code taking advantage of it.
2895 * crosstabs.q: (static var var_dict) Removed.
2896 (static var variables) New variable.
2897 (static var variables_cnt) New variable.
2898 (cmd_crosstabs) Free variables instead of var_dict.
2899 (internal_cmd_crosstabs) Initialize and use variables,
2900 variables_cnt instead of var_dict.
2901 (free_var_dict) Removed.
2902 (crs_custom_tables) Use var_set instead of a copied dictionary.
2903 (crs_custom_variables) Set up variables, variables_cnt instead of
2905 [DEBUGGING] (debug_print) Ditto.
2907 * means.q: (mns_custom_tables) Use var_set instead of a copied
2910 * vars-prs.c: (parse_vs_variable) New function.
2911 (parse_dict_variable) Rewritten.
2912 (parse_variable) Rewritten.
2913 (parse_variables) Renamed parse_var_set_vars(), rewritten.
2914 (parse_variables) New function in terms of parse_var_set_vars().
2915 Now requires its first argument to be non-null. All references
2916 that passed a null pointer updated to pass default_dict instead.
2917 (macro id_dict) Removed.
2918 (parse_DATA_LIST_vars) Add assertions.
2919 (parse_mixed_vars) Ditto.
2920 (struct var_set) New structure.
2921 (var_set_get_cnt) New function.
2922 (var_set_get_var) New function.
2923 (var_set_lookup_var) New function.
2924 (var_set_destroy) New function.
2925 (dict_var_set_get_cnt) New function.
2926 (dict_var_set_get_var) New function.
2927 (dict_var_set_lookup_var) New function.
2928 (dict_var_set_destroy) New function.
2929 (var_set_create_from_dict) New function.
2930 (struct array_var_set) New structure.
2931 (array_var_set_get_cnt) New function.
2932 (array_var_set_get_var) New function.
2933 (array_var_set_lookup_var) New function.
2934 (array_var_set_destroy) New function.
2935 (var_set_create_from_array) New function.
2937 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
2938 instead of parse_variables(NULL, ...) in output code.
2940 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
2942 Change inp_init from a 2-bit vector to an ordinary array.
2943 Initialize it all in cmd_end_input_program() instead of in
2946 * inpt-pgm.c: (enum value_init_type) New enum.
2947 (global var inp_init) Change to `enum value_init_type *', make
2949 (inp_init_size) Removed.
2950 (inp_nval) Change to `size_t', make static.
2951 (cmd_input_program) Don't initialize inp_init or inp_init_size.
2952 (cmd_end_input_program) Initialize inp_init, inp_nval.
2953 (init_case) Rewrite.
2954 (clear_case) Rewrite.
2956 * inpt-pgm.h: Removed.
2958 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
2960 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
2961 Colin Plumb hash. It is simpler and should better resist
2963 (hsh_hash_string) Ditto.
2965 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
2967 * get.c: (export_write_case_func) Remove debug printing code.
2969 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
2971 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
2973 (save_write_case_func) Use &trns->h instead of cast.
2974 (cmd_export) Use &t->h instead of cast.
2976 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
2978 Moved vectors into the dictionary.
2980 * var.h: (struct vector) Moved here from vector.h. `index' member
2981 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
2984 * vector.h: Removed.
2986 * vector.c: (global var vec) Removed.
2987 (global var nvec) Removed.
2988 (cmd_vector) Rewritten.
2989 (find_vector) Removed.
2991 * dictionary.c: (dict_create_vector) New function.
2992 (dict_get_vector) New function, replaces reading global vec[]
2994 (dict_get_vector_cnt) New function, replaces reading global nvec
2996 (dict_lookup_vector) New function, replaces find_vector().
2997 (dict_clear_vectors) New function.
2999 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
3001 Start to move away from `struct variable' p `union' member to void
3004 * var.h: (struct variable) Add `aux' member.
3006 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
3008 Get rid of struct variable `foo' member.
3010 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
3012 (frq_custom_variables) Ditto.
3013 (frq_custom_grouped) Ditto.
3015 * get.c: (struct save_trns) Change `var' member from `int *' to
3016 `struct variable **'.
3017 (cmd_save_internal) Use aux instead of foo.
3018 (save_trns_proc) Use revised `var' member.
3019 (static var mtf_seq_no) Renamed mtf_seq_num.
3020 (static var mtf_seq_nums) New static var.
3021 (cmd_match_files) Initialize mtf_seq_nums.
3022 (mtf_free) Free mtf_seq_nums.
3023 (mtf_processing) Use mtf_seq_nums instead of foo.
3024 (mtf_merge_dictionary) No need to initialize mv->foo.
3025 (cmd_export) Use aux instead of foo. Use revised `var' member.
3026 (mns_custom_tables) Don't use foo to check for duplicates, that's
3027 what PV_NO_DUPLICATE is for.
3029 * var.h: (struct variable) Remove `foo' member.
3030 (struct frequencies_proc) New member.
3032 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
3034 Clean up COMPUTE and IF.
3036 * compute.c: More or less rewrite the darn thing.
3037 (struct compute_trns) Rename and reorder and add and delete
3039 (cmd_compute) Rewrite.
3040 (compute_num) Make conditional on test expression. Now used for
3041 both COMPUTE and IF.
3042 (compute_num_vec) Ditto.
3043 (compute_str) Ditto.
3044 (compute_str_vec) Ditto.
3047 (if_num_vec) Removed.
3049 (if_str_vec) Removed.
3050 (parse_target_expression) Renamed parse_rvalue_expression(),
3052 (new_trns) Renamed compute_trns_create(), rewritten.
3053 (delete_trns) Removed.
3054 (free_trns) Renamed compute_trns_free(), rewritten.
3055 (struct lvalue) New structure.
3056 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
3057 (lvalue_get_type) New function.
3058 (lvalue_is_vector) New function.
3059 (lvalue_finalize) New function.
3060 (lvalue_destroy) New function.
3062 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
3064 * command.def: Disallow MODIFY VARS in input mode, so that
3065 variables can't get dropped and confuse cmd_end_input_program()'s
3066 attempt to fill inp_init[].
3068 * modify-vars.c: (static var forward_positional_ordering) New
3070 (struct var_modification) Entirely changed.
3071 (rearrange_dict) Interface changed, rewritten.
3072 (cmd_modify_vars) Deal with modified struct var_modification, much
3074 (struct var_renaming) New structure.
3075 (compare_var_renaming_by_new_name) New function.
3076 (validate_var_modification) New function.
3078 * var.h: (struct modify_vars_proc) Removed.
3079 (struct variable) Removed member p.mfv.
3081 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
3083 Make EVALUATE a valid command whether we're debugging or not, so
3084 that `make check' can succeed regardless of whether debugging is
3087 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
3089 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
3091 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
3093 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
3094 statement by a simple if test.
3096 * dfm.c: (dfm_get_record) Add assertion.
3098 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
3100 For each file x.c, move #include "x.h" to the very top of the
3101 include list, to catch x.h failing to include the proper headers.
3103 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
3105 * algorithm.c: (find) New function.
3106 (remove_equal) New function.
3107 (set_difference) New function.
3108 (adjacent_find_equal) New function.
3109 [TEST_UNIQUE] Removed test case.
3110 (copy_if) Find end test.
3112 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
3114 * dictionary.c: (dict_get_case_weight) New convenience function.
3116 * aggregate.c: (accumulate_aggregate_info) Use
3117 dict_get_case_weight().
3119 * frequencies.q: (calc_general) Ditto.
3120 (calc_integer) Ditto.
3123 * t-test.q: (groups_calc) Ditto.
3126 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
3128 * glob.c: (global var default_dict) Change from `struct
3129 dictionary' to `struct dictionary *'. All references changed.
3130 (init_glob) Initialize default_dict with dict_create().
3132 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
3134 struct dictionary now made opaque. All related functions:
3136 * get.c: (rename_variables) Removed.
3137 (dict_delete_run) Removed.
3139 * temporary.c: (copy_variable) Removed.
3140 (new_dictionary) Removed.
3141 (save_dictionary) Removed.
3142 (restore_dictionary) Removed.
3143 (free_dictionary) Removed.
3145 * vars-atr.c: (clear_default_dict) Removed.
3146 (find_variable) Removed.
3147 (find_dict_variable) Removed.
3148 (create_variable) Removed.
3149 (delete_variable) Removed.
3150 (common_init_stuff) Removed.
3151 (init_variable) Removed. Updating of inp_init moved into
3152 cmd_end_input_program().
3153 (replace_variable) Removed.
3154 (rename_variable) Removed.
3155 (clear_variable) Removed.
3156 (dup_variable) Removed.
3158 * vars-prs.c: (is_varname) Removed.
3159 (is_dict_varname) Removed.
3160 (fill_all_vars) Removed.
3162 * vector.c: (find_vector) Removed.
3164 * weight.c: (stop_weighting) Removed.
3166 * dictionary.c: New file.
3167 (dict_create) New, replaces new_dictionary().
3168 (dict_clone) New, replaces save_dictionary() and
3169 restore_dictionary().
3170 (dict_clear) New, replaces clear_default_dict().
3171 (dict_destroy) New, replaces free_dictionary().
3172 (dict_get_var_cnt) New function, replaces references to
3174 (dict_get_var) New function, replaces references to dict->var[i].
3175 (dict_get_vars) New function, replaces fill_all_vars().
3176 (dict_create_var) New, replaces create_variable(). Interface
3177 drops `type' parameter, using a zero `width' to designate numeric.
3178 (dict_clone_var) New, replaces dup_variable().
3179 (dict_rename_var) New, replaces rename_variable().
3180 (dict_lookup_var) New, replaces find_variable(),
3181 find_dict_variable(), is_varname().
3182 (dict_contains_var) New function.
3183 (compare_variable_dblptrs) New function.
3184 (dict_delete_var) New function, replaces clear_variable().
3185 (dict_delete_vars) New function, replaces dict_delete_run().
3186 (dict_reorder_vars) New function.
3187 (dict_rename_vars) New function, replaces rename_variables().
3188 (dict_get_weight) New function, replaces reading dict->weight_var.
3189 (dict_set_weight) New function, replaces writing dict->weight_var
3190 or calling stop_weight(dict).
3191 (dict_get_filter) New function, replaces reading dict->filter_var.
3192 (dict_set_filter) New function, replaces writing dict->filter_var.
3193 (dict_get_case_limit) New function, replaces reading dict->N.
3194 (dict_set_case_limit) New function, replaces writing dict->N.
3195 (dict_get_value_cnt) New function, replaces reading dict->nval.
3196 (dict_compact_values) New function, replaces a loop that was
3197 replicated in several places.
3198 (dict_get_split_vars) New function, replaces reading dict->splits.
3199 (dict_get_split_cnt) New function, replaces reading
3201 (dict_set_split_vars) New function, replaces writing dict->splits.
3202 (dict_get_label) New function, replaces reading dict->label.
3203 (dict_set_label) New function, replaces writing dict->label.
3204 (dict_get_documents) New function, replaces reading
3206 (dict_set_documents) New function, replaces writing
3209 All references to above functions updated.
3211 * aggregate.c: (cmd_aggregate) Copy file label and documents from
3212 old dictionary to new by hand, because dict_create() can't do it
3213 itself. Use dict_set_documents(), dict_set_split_vars().
3215 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
3216 calling dict_destroy().
3218 * data-list.c: (dls_var_spec) Remove `type' member, replace by
3220 (fixed_parse_compatible) Some slightly nontrivial changes for
3222 (dump_fmt_list) Ditto.
3225 * file-type.c: (create_col_var) Ditto.
3227 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
3228 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
3229 (rename_variables) Use dict_rename_vars().
3230 (mtf_merge_dictionary) Use dict_get_documents(),
3231 dict_set_documents(), dict_compact_values().
3233 * pfm-read.c: (read_variables) Deal with changes to weighting.
3235 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
3236 is_varname() in output code.
3238 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
3239 other dictionary functions.
3241 * title.c: (add_document_line) Use dict_get_documents(),
3242 dict_set_documents().
3244 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
3245 reset default_handle by hand. dict_clear() will clear vectors so
3246 there's no need for that by hand.
3248 * vfm.c: (close_active_file) Move call to finish_compaction()
3249 earlier, so that we can do the compaction as a single step using
3250 dict_compact_values(). Use dict_clear_vectors().
3251 (finish_compaction) Use dict_delete_var(), dict_compact_values().
3253 Some functions don't have replacements:
3255 * vars-atr.c: (force_create_variable) Removed. All references
3256 updated to dict_create_var() followed by an assertion.
3257 (force_dup_variable) Removed. All references updated to
3258 dict_clone_var() followed by an assertion.
3260 * weight.c: (update_weighting) Removed. No longer necessary, so
3261 all references removed.
3263 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
3267 * aggregate.c: Eliminate separation of weighted and unweighted
3268 case. It made the code too obscure and I doubt it was actually
3269 faster. Instead, all code uses the "weighted" code, because
3270 that's a generalization of the "unweighted" code.
3273 (parse_aggregate_functions) No need to set FWEIGHT.
3274 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
3275 (dump_aggregate_info) Ditto.
3276 (initialize_aggregate_info) No need for special plain_function
3277 that gets rid of FWEIGHT option.
3279 * aggregate.c: Get rid of approximations.
3280 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
3282 (aggregate_single_case) Don't use approx_ne().
3284 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
3286 * ascii.c (ascii_line_width): Dead code, removed.
3288 * postscript.c (ps_line_width): Ditto.
3290 * q2c.c (xrealloc): Ditto.
3292 * count.c (internal_cmd_count): Ditto.
3294 * means.q (validate_dependent_endpoint): Ditto.
3296 * set.q: (cmd_gset) Ditto.
3298 * weight.c: [0] (weight_trns_proc) Ditto.
3300 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
3302 Make the code -Wmissing-prototypes clean.
3304 * Makefile.am (version.c): Add #include "version.h".
3306 * ascii.c: (ascii_open_global) Make static.
3307 (ascii_close_page) Ditto.
3308 (ascii_font_sizes) Ditto.
3309 (ascii_postopen_driver) Ditto.
3310 (ascii_close_driver) Ditto.
3311 (ascii_option) Ditto.
3312 (ascii_open_page) Ditto.
3313 (ascii_line_horz) Ditto.
3314 (ascii_line_vert) Ditto.
3315 (ascii_line_intersection) Ditto.
3317 (ascii_polyline_begin) Ditto.
3318 (ascii_polyline_point) Ditto.
3319 (ascii_polyline_end) Ditto.
3320 (ascii_text_set_font_by_name) Ditto.
3321 (ascii_text_set_font_by_position) Ditto.
3322 (ascii_text_set_font_by_family) Ditto.
3323 (ascii_text_get_font_name) Ditto.
3324 (ascii_text_get_font_family) Ditto.
3325 (ascii_text_set_size) Ditto.
3326 (ascii_text_get_size) Ditto.
3327 (ascii_text_metrics) Ditto.
3328 (ascii_text_draw) Ditto.
3329 (ascii_close_page) Ditto.
3331 * cmdline.h: New header for parse_command_line(). Used where
3334 * command.c: Move prototypes for cmd_*() functions to command.h.
3336 * command.h: Prototypes for cmd_*() functions moved here from
3339 * crosstabs.q: (gamma_int) Ditto.
3341 * file-handle.h: Add fh_init_files() prototype.
3343 * getline.c: (welcome) Ditto.
3345 * glob.h: New header for init_glob(). Used where appropriate.
3347 * hash.c: (comparison_helper) Ditto.
3349 * html.c: (html_open_global) Ditto.
3350 (html_close_global) Ditto.
3351 (html_preopen_driver) Ditto.
3352 (html_postopen_driver) Ditto.
3353 (html_close_driver) Ditto.
3354 (html_option) Ditto.
3355 (html_open_page) Ditto.
3356 (html_close_page) Ditto.
3357 (html_submit) Ditto.
3359 * inpt-pgm.c: (input_program_source_read) Ditto.
3361 * output.c: (find_defn_value) Ditto.
3362 (destroy_list) Ditto.
3364 * pfm-read.c: (read_int) Ditto.
3366 * postscript.c: (ps_open_global) Ditto.
3367 (ps_close_global) Ditto.
3368 (ps_font_sizes) Ditto.
3369 (ps_preopen_driver) Ditto.
3370 (ps_postopen_driver) Ditto.
3371 (ps_close_driver) Ditto.
3373 (ps_open_page) Ditto.
3374 (ps_close_page) Ditto.
3375 (ps_line_horz) Ditto.
3376 (ps_line_vert) Ditto.
3377 (ps_line_intersection) Ditto.
3379 (ps_polyline_begin) Ditto.
3380 (ps_polyline_point) Ditto.
3381 (ps_polyline_end) Ditto.
3382 (ps_text_set_font_by_name) Ditto.
3383 (ps_text_set_font_by_position) Ditto.
3384 (ps_text_set_font_family) Ditto.
3385 (ps_text_get_font_name) Ditto.
3386 (ps_text_get_font_family) Ditto.
3387 (ps_text_set_size) Ditto.
3388 (ps_text_get_size) Ditto.
3389 (ps_text_metrics) Ditto.
3390 (ps_text_draw) Ditto.
3392 * q2c.c: (finish_up) Ditto.
3401 (find_symbol) Ditto.
3404 (force_string) Ditto.
3406 (match_token) Ditto.
3409 (parse_setting) Ditto.
3410 (parse_specifier) Ditto.
3411 (parse_specifiers) Ditto.
3412 (parse_subcommand) Ditto.
3413 (dump_specifier_vars) Ditto.
3415 (make_identifier) Ditto.
3416 (dump_declarations) Ditto.
3417 (dump_specifier_init) Ditto.
3418 (dump_vars_init) Ditto.
3420 (dump_specifier_parse) Ditto.
3421 (dump_subcommand) Ditto.
3422 (dump_parser) Ditto.
3423 (dump_header) Ditto.
3425 (recognize_directive) Ditto.
3427 * recode.c: (string_to_long) Ditto.
3429 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
3431 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
3434 * sort.c: (sort_stream_read) Ditto.
3435 (sort_stream_mode) Ditto.
3437 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
3439 * algorithm.c (binary_search): Fix comparison.
3441 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
3443 * algorithm.c: (binary_search) Fix assertion.
3445 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
3447 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
3449 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
3451 * sort.c: (compare_case_lists) Rewrite.
3453 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
3455 * quicksort.c: Removed (not used).
3457 * quicksort.h: Removed (not used).
3459 * sort.c: Removed blp_quicksort() prototype.
3461 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
3463 * postscript.c: (int_2_compare) Rewrite.
3464 (compare_line) Rewrite.
3466 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
3468 * matrix-data.c (compare_factors) Use lexicographical_compare()
3470 (compare_doubles) New function.
3472 * algorithm.c: (lexicographical_compare) New algorithm.
3474 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
3476 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
3478 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
3480 * expr-prs.c: (cmp_func) Removed.
3481 (parse_function) Use binary_search() algorithm.
3482 (compare_functions) New function.
3483 (init_func_tab) Use sort() algorithm.
3485 * algorithm.c: (binary_search) New algorithm.
3487 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
3489 * descript.q: (display) Use sort() algorithm instead of qsort().
3490 (compare_func) Removed.
3491 (descriptives_compare_variables) New function.
3493 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
3495 Get rid of AVL trees. Hashes are more appropriate for everything
3498 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
3504 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
3506 Much code can be clarified by using C++ STL-like algorithms. Not
3507 all uses of these algorithms are listed below, only the ones where
3508 the change to an algorithm was the only change of interest.
3510 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
3512 * algorithm.c: New file.
3514 * algorithm.h: New file.
3516 * modify-vars.c: (static var forward) Removed.
3517 (static var positional) Removed.
3518 (compare_variables) Removed.
3519 (struct ordering) New.
3520 (cmd_modify_vars) Use sort() algorithm.
3521 (compare_variables_given_ordering) New function.
3522 (rearrange_dict) Use sort() algorithm.
3524 * sysfile-info.c: (cmd_display) Use sort() algorithm.
3525 (cmp_var_by_name) Removed.
3527 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
3529 Make file handles use a hash table.
3531 * file-handle.q: (files) Change to hash table, make static.
3532 (cmd_file_handle) Use hash table functions.
3533 (fh_get_handle_by_filename) Ditto.
3534 (fh_get_handle_by_name) Ditto.
3535 (hash_file_handle) New function.
3536 (cmp_file_handle) Rewrite.
3537 (fh_init_files) Use hash table functions.
3539 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
3541 Clean up FREQUENCIES.
3543 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
3545 * frequencies.q: Remove a lot of old #if'd out code at the end.
3546 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
3547 or calc_weight(). Initialize percentile_values.
3548 (calc) New function based on calc_weight() from frequencies.g.
3549 (precalc) Use hash functions.
3550 (static var comparison_func) Removed.
3551 (static var comparison_param) Removed.
3552 (comparison_helper) Removed.
3553 (get_freq_comparator) New function.
3554 (not_missing) New function.
3556 (postprocess_freq_tab) Use hash table functions, algorithms,
3557 get_freq_comparator(). Rewrite.
3558 (cleanup_freq_tab) Rephrase.
3559 (add_percentile) Clean up spacing.
3560 (hash_value_numeric) New function.
3561 (hash_value_alpha) New function.
3562 (compare_value_numeric_a) Rewrite.
3563 (compare_value_alpha_a) Rewrite.
3564 (compare_value_numeric_d) Rewrite.
3565 (compare_value_alpha_d) Rewrite.
3566 (compare_freq_numeric_a) Rewrite.
3567 (compare_freq_alpha_a) Rewrite.
3568 (compare_freq_numeric_d) Rewrite.
3569 (compare_freq_alpha_d) Rewrite.
3570 (calc_stats) Clean up mode, percentiles, max.
3571 (dump_statistics) Clean up spacing.
3573 * frequencies.g: Removed.
3575 * var.h: (struct freq_tab) Change `data' to hash table.
3577 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
3579 * file-handle.h: Remove declaration of global variable `files',
3580 which wasn't used anywhere.
3582 * postscript.c: (add_encoding) Remove superfluous cast.
3585 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
3588 * temporary.c: [0] (display_tree) Removed.
3590 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
3592 Implement a new random number generator based on the alleged RC4
3595 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
3598 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
3599 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
3601 (static var V[]) Removed.
3602 (static var Y) Removed.
3603 (static var X2) Removed.
3604 (setup_randomize) Removed.
3606 (rand_uniform) Removed.
3607 (rand_normal) Removed.
3608 (struct rng) New structure.
3609 (rng_create) New function.
3610 (rng_destroy) New function.
3611 (swap_byte) New static function.
3612 (rng_seed) New function.
3613 (rng_get_bytes) New function.
3614 (rng_get_int) New function.
3615 (rng_get_unsigned) New function.
3616 (rng_get_double) New function.
3617 (rng_get_double_normal) New function.
3618 (pspp_rng) New function.
3620 * random.h: Sync up to random.c.
3622 * sample.c: (struct sample_trns) Make `frac' unsigned and a
3623 fraction of UINT_MAX, not 65536.
3624 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
3627 * vfm.c: (open_active_file) No need to call setup_randomize() any
3630 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
3632 Change dictionary name indexes to use hash tables instead of AVL
3635 * crosstabs.q: (free_var_dict) Use hash tables.
3636 (crs_custom_tables) Ditto.
3637 (calc_general) Ditto.
3638 (compare_table_entry) Rewrite.
3639 (enum_var_values) Reorder parameters. All references updated.
3642 * get.c: (rename_variable) Use hash tables.
3643 (mtf_merge_dictionary) Ditto.
3645 * glob.c: (init_glob) Use hash tables.
3646 (cmp_variable) Removed.
3648 * means.q: (mns_custom_tables) Use hash tables.
3650 * modify-vars.c: (rearrange_dict) Use hash tables.
3652 * rename-vars.c: (cmd_rename_variables) Use hash tables.
3654 * sfm-read.c: (read_header) Use hash tables.
3655 (read_variables) Ditto.
3657 * temporary.c: (new_dictionary) Use hash tables.
3658 (save_dictionary) Ditto.
3659 (restore_dictionary) Ditto.
3661 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
3662 hash table `name_tab'.
3664 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
3665 [DEBUGGING] (dump_var_tree) Removed.
3666 (find_variable) Use hash tables.
3667 (find_dict_variable) Ditto.
3668 (common_init_stuff) Ditto.
3669 (rename_variable) Ditto.
3670 (clear_variable) Ditto. Also, remove debug code.
3671 (dup_variable) Use hash tables.
3673 * vars-prs.c: (fill_all_vars) Use hash tables.
3674 (is_dict_varname) Ditto.
3675 (parse_dict_variable) Ditto.
3677 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
3679 Change value labels to use hash tables instead of AVL trees, and
3680 change value labels into an ADT.
3682 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
3684 * value-labels.c: New file.
3686 * value-labels.h: New file.
3688 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
3689 Get rid of a stupid use of goto.
3691 * autorecode.c: (compare_alpha_value) Rewrite.
3692 (hash_alpha_value) Ditto.
3693 (compare_numeric_value) Rewrite.
3694 (hash_numeric_value) Ditto.
3696 * frequencies.q: (dump_full) Use value label ADT.
3698 * pfm-read.c: (read_value_label) Use value label ADT.
3700 * pfm-write.c: (write_value_labels) Use value label ADT.
3702 * sfm-read.c: (read_variables) Use value label ADT.
3703 (read_value_labels) Rewrite.
3705 * sfm-write.c: (write_value_labels) Rewrite.
3707 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
3708 (display_variables) Ditto.
3709 (describe_variable) Ditto.
3711 * t-test.q: (print_t_groups) Use value label ADT.
3713 * temporary.c: (copy_variable) Use value label ADT.
3714 (free_dictionary) Ditto.
3716 * val-labs.c: (verify_val_labs) Use value label ADT.
3718 (debug_print) Ditto.
3719 (val_lab_cmp) Removed.
3720 (inc_ref_count) Removed.
3721 (copy_value_labels) Removed.
3723 * var.h: (struct value_label) Removed.
3724 (struct variable) Change AVL tree `val_lab' into hash table
3727 * vars-atr.c: (init_variable) Use value label ADT.
3728 (clear_variable) Ditto.
3729 (free_value_label) Removed.
3730 (free_val_lab) Removed.
3731 (get_val_lab) Removed.
3732 (compare_variables) New function.
3733 (hash_variable) New function.
3735 * vfm.c: (dump_splits) Use value label ADT.
3737 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
3739 Add to the hash table interface.
3741 * hash.c: (hsh_hash_bytes) Add assertion.
3742 (hsh_hash_string) Ditto.
3746 (hsh_create) Ditto. Also make minimum `size'.
3747 (hsh_destroy) Rephrase.
3748 (sort_nulls_last) Removed.
3749 (not_null) New function.
3751 (comparison_helper) Ditto.
3752 (hsh_sort) Rewritten.
3753 (hsh_data_copy) New function.
3754 (hsh_sort_copy) Ditto.
3756 (hsh_replace) Ditto.
3757 (hsh_hash_double) Ditto.
3758 (hsh_delete) Fix stupid bug.
3760 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3761 * added a calculation of the mode to FREQUENCIES
3763 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3765 * moved (un)defs of DEBUGGING to config.h
3767 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
3769 * groff-font.c: (add_kern) Fix indentation.
3770 (add_kern) Use & instead of % to take power-of-2 modulus.
3771 (font_get_kern_adjust) Likewise.
3773 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
3775 * autorecode.c: (recode) Replace stupid use of memcpy() by
3777 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
3778 (hash_numeric_value) Ditto.
3779 (autorecode_proc_func) pool_strdup() was wrong here because the
3780 source string was not null-terminated. Use new pool_strndup()
3783 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
3784 use of hsh_iterator_init().
3786 * data-in.c: (parse_N) Initialize i->v->f.
3788 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
3791 * groff-font.c: Use power-of-2 hash table sizes, not prime.
3792 (groff_read_font) Don't call hsh_next_prime(). Don't call
3794 (static var hash) Remove `size_p', `max_used' members.
3795 (font_char_name_to_index) Don't call hsh_next_prime(). Use
3796 hsh_hash_string() instead of hashpjw(), & instead of %.
3797 (default_font) Don't call hsh_next_prime().
3799 * pool.c: (pool_strndup) New function.
3800 (pool_strdup) Reimplement in terms of pool_strndup.
3802 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
3804 (hash_ps_encoding) Use hsh_hash_string().
3805 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
3806 (hash_filename2font) Use hsh_hash_string().
3808 * som.c: Add #include <stdlib.h>.
3810 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
3811 (by destroying its pool).
3813 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
3815 Miscellaneous hash table code cleanup:
3817 * hash.h: (struct hsh_table) Moved into hash.c.
3818 (hsh_count) Ditto, and transformed into function.
3819 (hsh_compare_func) New typedef, used for defining otherwise-long
3820 function types here and in hash.c
3821 (hsh_hash_func) Ditto.
3822 (hsh_free_func) Ditto.
3824 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
3825 `table' to `entries'. Removed `mp'. All references updated.
3826 (hsh_clear) Don't shrink entries array; if the hash was this big
3827 once, it probably will be again.
3828 (hsh_rehash) Made static.
3829 (force_hsh_insert) Renamed hsh_force_insert.
3830 (force_hsh_find) Renamed hsh_force_find.
3832 Made hash table sizes powers of 2, because that's fine with any
3833 reasonable hash function and because taking a power-of-2 modulus
3834 is faster than any other:
3836 (hsh_prime_tab) Removed;
3837 (hsh_next_prime) Ditto.
3838 (next_power_of_2) New function.
3839 (hsh_create) Use next_power_of_2.
3840 (hsh_rehash) Use & instead of %.
3842 Cleaned up hsh_sort:
3844 (internal_comparison_fn) Removed.
3845 (sort_nulls_last) New function.
3846 (hsh_sort) Removed second parameter, switched to using the new
3847 quicksort() function from quicksort.h to avoid using nasty need
3848 for static variables with qsort(). All references updated.
3850 Changed the hash functions offered, because there are better hash
3851 functions than the ones we had, and cleaned up the names to boot:
3853 * hash.c: (hashpjw_d) Removed.
3855 (hsh_hash_bytes) New function.
3856 (hsh_hash_string) New function.
3857 (hsh_hash_int) New function.
3859 Improved the hash table iteration interface:
3861 * hash.h: (hsh_iterator_init) Removed.
3862 (struct hsh_iterator) Removed `init' member, change `next' to
3865 * hash.c: (hsh_foreach) Removed. All references updated to use
3866 hsh_first/hsh_next instead.
3867 (hsh_first) New function. Notably, unlike hsh_foreach() it does
3868 not treat a null pointer as an empty hash table.
3869 (hsh_next) New function.
3871 Made deletion possible, though slow:
3873 * hash.c: (locate_matching_entry) New function.
3874 (hsh_find) Use locate_matching_entry().
3875 (hsh_delete) New function also using locate_matching_entry().
3876 (hsh_force_delete) New function.
3878 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
3880 * quicksort.c: New file implementing a sort routine with a
3881 interface better than qsort() because it passes a user-provided
3882 parameter to the sort routine.
3884 * Makefile.am: Add quicksort.c, quicksort.h.
3886 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
3888 * All source files: Get rid of nasty special cases for Checker,
3889 which is pretty obsolete now.
3891 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
3893 * Fixed a bug apparent when using the FREQUENCIES command with the
3894 html driver. The html driver was incorrectly trying to display
3897 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
3899 * Makefile.am: Reorganized. Put locale dir in version.c instead
3900 of passing it to each compile command. Only put local gmp libs in
3901 LD_ADD if not installed on system. Remove `boast' target.
3903 * All source files: struct and union typedefs eliminated.
3904 `sizeof type' replaced by `sizeof object' where practical. Moved
3905 `unused' qualifiers from start to end of declarations for gcc
3906 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
3907 assertions on pointers strictly compliant. Removed _ prefixes on
3908 some function parameter names.
3910 * alloc.c: New source file, containing these external linkage
3911 functions removed from common.c: xmalloc, xcalloc, xrealloc,
3918 * ascii.c: Migrated from arenas to pools.
3919 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
3920 c_string to len_string. All references changed.
3921 (ascii_option) Signature changed to comply to new output.c
3923 (count_fancy_chars) Removed.
3924 (delineate) Removed support for rich text.
3925 (ascii_text_metrics) Ditto.
3927 (output_shorts) Change `box', `off', `on' from c_string to
3928 len_string. Change `remaining' from int to size_t.
3929 (ascii_close_page) Make page numbering less haphazard.
3931 * autorecode.c: Migrate from arenas to pools.
3933 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
3935 * bitvector.h: New file containing these macros from misc.h:
3936 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
3938 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
3939 word[3]. ncmd removed.
3940 (var empty_string) Removed.
3941 (var cmd_table) Declaration updated.
3942 (var cmdtab) Removed.
3943 (cmp_command) Removed.
3944 (split_words) Rewritten to use strtok_r().
3945 (init_cmd_parser) Renamed cmd_init(). Rewritten.
3946 (find_command) Removed.
3947 (FILE_TYPE_okay) Rewritten.
3948 (cmd_parse) Rewritten. Semantics of the return value of command
3949 handlers has changed: they must now return one of the new CMD_*
3950 enumerals, rather than a magic value. This meant that all
3951 commands had to be modified, and they were.
3952 (figure_out_command) New function.
3954 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
3955 #defines for INIT, INPU, etc.
3957 * command.h: New CMD_* enum series.
3958 (cur_proc) Make const char *, not char *.
3959 (cmd_init) Prototype.
3962 * common.c: Removed.
3964 * common.h: Removed.
3966 * correlations.q: New file.
3968 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
3970 (custom_tables) Renamed crs_custom_tables().
3971 (custom_variables) Renamed crs_custom_variables().
3972 (calc_integer) Add in some `const' qualifiers.
3973 (table_value_missing) Change from a_string to len_string.
3974 (float_M_suffix) Change from a_string to len_string.
3976 * data-in.c: Rewritten. All references to
3977 parse_string_as_format() changed to data_in().
3979 * data-in.h: New file.
3981 * data-list.c: Change DLS_* from #define's to enums. Move from
3982 rpd_msg() to tmsg().
3983 (RPD_ERR) New #define.
3984 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
3986 (read_from_data_list_fixed) Change from old
3987 parse_string_as_format() to new data_in().
3988 (read_from_data_list_free) Ditto.
3989 (read_from_data_list_list) Ditto.
3990 (cmd_repeating_data) Modify approach to checking for end of
3993 (rpd_parse_record) Change from old parse_string_as_format() to new
3994 data_in(). Change from old convert_format_to_string() to new
3996 (read_one_set_of_repetitions) Change dfm_push_cust() to
3997 dfm_push(), pop_cust() to dfm_pop().
3999 * data-out.c: Rewritten. All references to
4000 convert_format_to_string() changed to data_out().
4002 * descript.q: Migrate to new q2c.
4003 (cmd_descriptives) Removed.
4004 (internal_cmd_descriptives) Renamed cmd_descriptives ().
4005 (custom_variables) Renamed dsc_custom_variables().
4007 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
4009 (open_file_r) Initialize h->where.line_number. Migrate to new
4011 (open_file_w) Initialize h->where.line_number.
4012 (read_record) Change from ext->ln to h->where.line_number.
4013 Migrate to struct string.
4014 (dfm_put_record) Rephrased.
4015 (dfm_push_cust) Renamed dfm_push(), rewritten.
4016 (dfm_pop) New function.
4018 * error.c: All references updated.
4019 (glob var error_count) Renamed err_err_count.
4020 (glob var warning_count) Renamed err_warning_count.
4021 (glob var error_already_flagged) Renamed err_already_flagged.
4022 (glob var verbosity) Renamed err_verbosity.
4023 (glob var cust_fn) Removed.
4024 (glob var cust_ln) Removed.
4025 (static var file_loc) New.
4026 (static var nfile_loc) New.
4027 (static var mfile_loc) New.
4028 (tmsg) New function.
4029 (push_cust) Removed.
4032 (static var terminating) Removed.
4033 (failure) Renamed err_failure().
4034 (hcf) Renamed err_hcf().
4035 (err_push_file_locator) New function.
4036 (err_pop_file_locator) New function.
4037 (err_location) New function.
4038 (check_error_count) Renamed err_check_count().
4039 (vmsg) Renamed err_vmsg(). Interface changed.
4040 (verbose_msg) Removed.
4041 (err_cond_fail) New function.
4042 (error_break) Renamed err_break().
4044 * error.h: All references updated.
4045 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
4046 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
4048 (struct file_locator) New.
4050 (macro verbose_msg) Removed.
4051 (macro cond_fail) Removed.
4053 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
4055 * expr-prs.c: Reorganized. All references updated.
4056 (exprtypename) Renamed expr_type_name().
4057 (typename) Renamed type_name().
4058 (free_expression) Renamed expr_free().
4059 (parse_expression) Renamed expr_parse(). Uses new type_check()
4061 (init_functab) Renamed init_func_tab().
4062 (type_check) New function.
4063 (parse_or) Rewritten to use new allocate_nonterminal() and
4064 append_nonterminal_arg() functions.
4067 (parse_rel) Ditto. Also simplified logic.
4072 (SYSMIS_func) Ditto.
4073 (VALUE_func) Rephrased.
4074 (CONCAT_func) Fix memory leak by replacing free by free_node on
4076 (generic_str_func) Ditto.
4077 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
4079 (allocate_nonterminal) New function.
4080 (append_nonterminal_arg) New function.
4081 (static func_tab[]) Now at file level.
4083 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
4085 * expr.h: (enum series OP_*) Moved to exprP.h.
4086 (OP_* defines) Ditto.
4087 (struct op_desc) Ditto.
4088 (global ops[]) Ditto.
4089 (struct num_con_node) Ditto.
4090 (struct str_con_node) Ditto.
4091 (struct var_node) Ditto.
4092 (struct lag_node) Ditto.
4093 (struct casenum_node) Ditto.
4094 (struct nonterm_node) Ditto.
4095 (union any_node) Members renamed.
4096 (struct sys_node) Removed.
4097 (struct val_node) Removed.
4098 (operator typedef) Removed.
4099 (typedef exprtype) Removed.
4100 (enum series EX_*) Moved to exprP.h.
4101 (struct expression) Ditto. Also renamed a lot of the members.
4102 (PXP_* defines) Changed to enums.
4103 (free_node prototype) Moved to exprP.h.
4105 * file-handle.h: (struct file_handle) New member `where'.
4107 * file-handle.q: Migrated to new q2c format.
4108 (prepend_current_directory) Removed (dead code).
4109 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
4110 (fh_get_handle_by_filename) Removed dead code.
4111 Set new `where' member.
4113 * file-type.c: (file_type_source_read) References to
4114 parse_string_as_format() changed to data_in().
4115 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
4117 * filename.c: All references updated.
4118 (init_filename) Renamed fn_init().
4119 (expand_line) Removed.
4120 (macro EXPAND_LINE) Removed.
4121 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
4122 of custom functions.
4123 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
4124 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
4125 (normalize_filename) Renamed fn_normalize().
4126 (search_path) Renamed fn_search_path(), rewritten.
4127 (prepend_dir) Renamed fn_prepend_dir().
4128 (blp_getenv) Renamed fn_getenv().
4129 (blp_dirname) Renamed fn_dirname().
4130 (fn_basename) New function, not used.
4131 (absolute_filename_p) Renamed fn_absolute_p().
4132 (is_special_filename) Renamed fn_special_p().
4133 (file_exists) Renamed fn_exists_p().
4134 (readlink_malloc) Renamed fn_readlink().
4135 (getenv_default) Renamed fn_getenv_default().
4136 (open_file) Renamed fn_open().
4137 (close_file) Renamed fn_close().
4138 (open_file_ext) Renamed fn_open_ext().
4139 (close_file_ext) Renamed fn_close_ext().
4141 * font.h: Migrate from arenas to pools.
4143 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
4145 * frequencies.g: Migrate from arenas to pools.
4147 * frequencies.q: Migrate to new q2c version. Migrate from arenas
4150 * getline.c: All references updated.
4151 (global getl_buf) Changed from char * to struct string.
4152 (static getl_include_path) Ditto.
4153 (global getl_buf_len) Removed.
4154 (global getl_buf_size) Removed.
4155 (getl_include_path) Deal with new getl_buf, getl_include_path.
4156 (getl_uninitialize) New function.
4157 (getl_get_current_directory) Rewritten.
4158 (getl_clear_include_path) Rewritten.
4159 (getl_add_include_dir) Rewritten.
4160 (getl_add_file) Assertion fixed.
4161 (getl_add_virtual_file) Change initial value of `remaining_loops'
4163 (welcome) Rewritten.
4164 (handle_line_buffer) Make static. Change logic to make
4165 getl_add_virtual_file() change sensible. Use ds_*() strings.
4166 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
4167 (getl_close_file) Moved.
4168 (getl_location) New function.
4170 * getline.h: All references updated.
4171 (macro curln) Removed.
4172 (macro curfn) Removed.
4173 (macro am_interactive) Renamed getl_am_interactive.
4174 (macro am_reading_script) Renamed getl_reading_script.
4176 * glob.c: (global fmt_parse_ignore_error) Removed.
4177 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
4178 systems that support it (C99). Turn off SET ECHO by default. No
4179 necessary julcal initialization anymore.
4181 * groff-font.c: Migrate from arenas to pools.
4182 (groff_read_font) Use err_push_file_locator().
4183 (groff_read_DESC) Ditto.
4184 (font_msg) Use tmsg().
4186 * hash.c: (hsh_sort) Fix debug code.
4187 [GLOBAL_DEBUGGING] Include stdio.h.
4189 * hash.h: (macro force_hsh_insert) Rephrase.
4191 * heap.c: Rewritten.
4193 * heap.h: Rewritten.
4195 * html.c: (html_option) Change from outp_value to struct string.
4196 (postopen) Change from curfn to getl_location().
4197 (escape_string) Remove rich-text code. Signature changed.
4198 (output_tab_table) Switch from a_string to struct len_string.
4199 Remove rich text support.
4201 * lexer.c: All references updated. Largely rewritten. Major
4202 changes listed below. Removed tagged quote support. Adapted to
4203 struct string tokstr.
4204 (global tokstr) Changed to struct string.
4205 (global tokstr_size) Removed.
4206 (global tokstr_len) Removed.
4208 (global tokint) Removed.
4209 (global toklongstr) Removed.
4210 (C* defines) Removed.
4211 (static tbl[]) Removed.
4212 (static id[]) Removed.
4213 (static une[]) Removed.
4214 (discard_line) Renamed lex_discard_line().
4215 (get_entire_line) Renamed lex_entire_line().
4216 (get_rest_of_line) Renamed lex_rest_of_line().
4217 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
4218 (make_hexit) Removed.
4219 (syntax_error) Renamed lex_error(). Return value removed.
4220 (get_token_representation) Renamed lex_token_representation().
4221 (putback) Renamed lex_put_back().
4222 (putfwd) Renamed lex_put_forward().
4223 (convert_negative_to_dash) Renamed lex_negative_to_dash().
4224 (set_prog) Renamed lex_set_prog().
4225 (init_lex) Renamed lex_init().
4226 (reset_eof) Renamed lex_reset_eof().
4227 (lookahead) Renamed lex_look_ahead().
4228 (check_id) Rewritten.
4229 (yylex) Renamed lex_get(), rewritten.
4230 (lex_end_of_command) New function. Many commands were rephrased
4232 (lex_integer_p) New function. Replaces compare of tokint against
4234 (lex_integer) New function. Replaces tokint.
4235 (match_tok) Renamed lex_match().
4236 (match_id) Renamed lex_match_id().
4237 (match_int) Renamed lex_match_int().
4238 (force_match_id) Renamed lex_force_match_id(), added return value.
4239 (force_match) Renamed lex_force_match(), added return value.
4240 (force_string) Renamed lex_force_string(), added return value.
4241 (force_int) Renamed lex_force_int(), added return value.
4242 (lex_id_match_len) New function.
4243 (id_match) Renamed lex_id_match(), rewritten.
4244 (get_line) Renamed lex_get_line().
4245 (preprocess_line) Renamed lex_preprocess_line().
4246 (tokname) Renamed lex_token_name().
4247 (bin_value_func) Removed.
4248 (oct_value_func) Removed.
4249 (hex_value_func) Removed.
4250 (unexpected_eof) New function.
4251 (convert_numeric_string_to_char_string) New function.
4252 (parse_string) Rewritten, signature changed.
4253 (add_tokstr_char) Removed.
4254 (add_tokstr_unsigned) Removed.
4255 (add_tokstr_string) Removed.
4256 (parse_tagged_quote) Removed.
4257 (skip_comment) Renamed lex_skip_comment().
4259 * lexer.h: All references updated.
4260 (macro is_id1) Renamed CHAR_IS_ID1.
4261 (macro is_idn) Renamed CHAR_IS_IDN.
4262 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
4263 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
4264 (macro get_token) Removed.
4265 (macro id_match) Removed.
4266 (macro force_match_id) Removed.
4267 (macro force_match) Removed.
4268 (macro force_string) Removed.
4269 (macro force_int) Removed.
4270 (macro force_num) Removed.
4271 (macro force_id) Removed.
4273 * lexerP.h: Removed.
4275 * list.q: Migrated to new q2c format.
4276 (write_line) Deal with struct len_string.
4277 (write_varname) Ditto.
4278 (write_fallback_headers) Ditto.
4280 * magic.c: New file, incorporating the following global variables
4281 previously in other files: endian, second_lowest_value. And both
4282 of those are conditional on #define's.
4284 * magic.h: New file, incorporating the following global variable
4285 declarations: endian, second_lowest_value, and the following macro
4286 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
4288 * main.c: Added declarations of pgmname, finished, curdate,
4290 (main) Call new parse_script() function.
4291 (parse_script) New function.
4292 (execute_command) New function.
4293 (dump_token) Removed.
4294 (handle_error) New function.
4296 * matrix.c: New file.
4298 * matrix.h: New file.
4300 * matrix-data.c: Migrated from arenas to pools.
4301 (mget_token) Change from parse_string_as_format() to data_in().
4303 * means.q: Migrate to new q2c.
4304 (custom_tables) Renamed mns_custom_tables().
4305 (custom_crossbreak) Renamed mns_custom_crossbreak().
4306 (custom_variables) Renamed mns_custom_variables().
4308 * mis-val.c: (static var width) Changed from `int' to `size_t'.
4309 (parse_varnames) Prototype.
4310 (parse_numeric) Rephrasings.
4311 (parse_alpha) Adapt to new struct string tokstr.
4313 * misc.c: (intlog10) Rewritten.
4315 (ansi_rand) Renamed real_rand(), moved into random.c.
4316 (ansi_srand) Renamed real_srand(), moved into random.c.
4317 (setup_randomize) Moved to random.c.
4318 (rand_uniform) Ditto.
4319 (rand_normal) Ditto.
4320 (rand_simple) Ditto.
4321 (get_config_line) Removed.
4322 (reverse) Removed (dead code).
4324 * misc.h: (macro SET_BIT) Moved to bitvector.h.
4325 (macro CLEAR_BIT) Ditto.
4326 (macro TEST_BIT) Ditto.
4327 (macro SET_BIT_TO) Ditto.
4328 (macro BIT_INDEX) Ditto.
4330 * output.c: (outp_read_devices) Move to err_push_file_locator()
4331 from push_cust(). Use struct string.
4332 (expand_op_tokstr) Removed.
4333 (static var op_tokstr) Changed to struct string.
4334 (static var op_tokstr_size) Removed.
4335 (tokener) Rephrasings. Use struct string.
4336 (parse_options) Use struct string.
4337 (destroy_driver) Fix assertion.
4338 (outp_get_paper_size) Move to err_push_file_locator().
4339 [0] Removed dead code.
4340 (outp_string_width) Move to len_string.
4342 * output.h: Comment fixes.
4343 (TAG_* enum series) Removed.
4344 (struct outp_value) Removed.
4345 (enum OUTP_T_FANCY) Removed.
4346 (struct outp_text) `s' changed from a_string to len_string.
4347 (struct outp_class) `option' change arg 3 from outp_value to
4350 * pfm-read.c: (corrupt_msg) Rewritten.
4352 * pfm-write.c: (bufwrite) Fix assertion.
4354 * pool.c: New file, reference version.
4356 * pool.h: New file, reference version.
4358 * postscript.c: (ps_font_sizes) Fix assertion.
4359 (ps_option) Change arg 3 from outp_value to struct string.
4360 Adapt to struct string.
4361 (macro output_line) Removed.
4362 (macro add_string) Removed.
4363 (output_encodings) Adapted to struct string. Moved to
4364 err_push_file_locator().
4365 (find_encoding_file) Fix assertion.
4366 (read_ps_encodings) Move to err_push_file_locator().
4367 (postopen) Use getl_location() instead of curfn.
4368 (out_text_plain) Move to len_string.
4369 (text) Ditto. Remove rich text support.
4371 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
4372 (cmd_print_eject) Ditto.
4374 (internal_cmd_print) Now cleans up after itself. Uses
4375 fh_parse_file_handle() now.
4376 (cmd_print_space) Use PXP_NUMERIC to type-check.
4378 * q2c.c: Overhauled. Removed _("") i18n support. All references
4379 updated. All output functions updated to handle structures rather
4380 than local or static variables. Adapt to new PSPP lex_*()
4384 (macro MAX_N_SBC) Removed.
4385 (global bare) Removed.
4386 (enum STRING) Renamed T_STRING.
4387 (enum ID) Renamed T_ID.
4388 (get_buffer) Buffer size increased.
4389 (strlower) Renamed st_lower(), rephrased.
4390 (strupper) Renamed st_upper(), rephrased.
4391 (skip_ws) New function.
4392 (get_line) Don't special-case any types of lines (like those
4393 beginning with ! or $, for instance).
4394 (get_token) Renamed lex_get(). Rephrased.
4395 (static var `prefix') New.
4396 (parse) New function.
4397 (parse_setting) Minor rephrasing.
4398 (dump_specifier_vars) Ditto.
4399 (make_identifier) Put null terminator on identifier, duh.
4400 (dump_vars) Renamed dump_declarations(). Never indent. Never
4401 static. Output changed entirely.
4402 (dump_specifier_init) Rephrase.
4403 (dump_vars_init) No index variable needed. Other modifications.
4404 (dump_parser) Don't parse command name. Do dump functions instead
4405 of just code fragments.
4406 (dump_free) Dump function instead of code fragment.
4407 (recognize_directive) New function.
4408 (main) Use recognize_directive(). Don't rely on magic $ line
4409 beginning: instead, parse comments. Update list of headers.
4411 * random.c: New file, containing the following functions:
4412 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
4413 rand_normal, rand_simple.
4415 * random.h: New file.
4417 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
4418 function. `max_src_width', `max_dst_width' changed to size_t.
4419 (internal_cmd_recode) Removed.
4420 (parse_dest_spec) Merge similar cases.
4421 (parse_src_spec) Add assertion.
4423 * repeat.c: (recognize_keyword) New function.
4424 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
4425 REPEAT. Improve recognition of END REPEAT (use
4426 recognize_keyword()). Move from curfn to getl_location(). Use
4429 (perform_DO_REPEAT_substitutions) Adapt to struct string.
4431 * set.q: Adapt to new q2c.
4432 (cmd_set) Range-check some values better.
4433 (custom_blanks) Renamed stc_custom_blanks().
4434 (custom_length) Renamed stc_custom_length().
4435 (custom_results) Renamed stc_custom_results().
4436 (custom_seed) Renamed stc_custom_seed().
4437 (custom_width) Renamed stc_custom_width().
4438 (custom_format) Renamed stc_custom_format().
4439 (custom_journal) Renamed stc_custom_journal().
4440 (custom_color) Renamed stc_custom_color().
4441 (custom_listing) Renamed stc_custom_listing().
4442 (custom_disk) Renamed stc_custom_disk().
4443 (custom_log) Renamed stc_custom_log().
4444 (custom_rcolor) Renamed stc_custom_rcolor().
4445 (custom_viewlength) Renamed stc_custom_viewlength().
4446 (custom_workdev) Renamed stc_custom_workdev().
4448 * settings.h: Not necessary to include format.h any longer.
4450 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
4451 (corrupt_msg) Rewritten.
4453 * sort.c: Adapt to rewritten heap ADT.
4455 * str.c: (aa_strcpy) Removed.
4456 (ab_strcpy) Removed.
4457 (ac_strcpy) Removed.
4458 (ba_strcpy) Removed.
4459 (bb_strcpy) Removed.
4460 (ca_strcpy) Removed.
4461 (aa_strdup) Removed.
4462 (aa_strdupcpy) Removed.
4463 (ba_strdup) Removed.
4464 (sa_strdup) Removed.
4465 (memrev) Renamed mm_reverse().
4466 (memrmem) Renamed mm_find_reverse().
4467 (cmp_str) Renamed st_compare_pad().
4468 (strmaxcpy) Removed.
4469 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
4470 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
4472 (strpadcpy) Renamed st_pad_copy(), signature changed.
4473 (blpstrset) Removed.
4474 (ds_create) New function.
4475 (ds_init) New function.
4476 (ds_replace) New function.
4477 (ds_destroy) New function.
4478 (ds_clear) New function.
4479 (ds_extend) New function.
4480 (ds_shrink) New function.
4481 (ds_truncate) New function.
4482 (ds_length) New function.
4483 (ds_size) New function.
4484 (ds_value) New function.
4485 (ds_end) New function.
4486 (ds_concat) New function.
4487 (ds_concat_buffer) New function.
4488 (ds_printf) New function.
4489 (ds_putchar) New function.
4490 (ds_getline) New function.
4491 (ds_get_config_line) New function derived from the old
4492 misc.c:get_config_line().
4493 (ls_create) New function.
4494 (ls_create_buffer) New function.
4495 (ls_init) New function.
4496 (ls_shallow_copy) New function.
4497 (ls_destroy) New function.
4498 (ls_null) New function.
4499 (ls_null_p) New function.
4500 (ls_empty_p) New function.
4501 (ls_length) New function.
4502 (ls_value) New function.
4503 (ls_end) New function.
4505 * str.h: Reformatted.
4506 (struct a_string) Removed.
4507 (struct b_string) Removed.
4508 (struct c_string) Removed.
4509 (struct len_string) New.
4510 (struct string) New.
4511 (macro as_streq) Removed.
4512 (macro bs_streq) Removed.
4513 (macro cs_streq) Removed.
4514 (macro sa_streq) Removed.
4515 (macro sb_streq) Removed.
4516 [__GNUC__] (inline function ds_putchar) New function.
4517 [__GNUC__] (inline function ds_length) New function.
4518 [__GNUC__] (inline function ds_value) New function.
4519 [__GNUC__] (inline function ds_end) New function.
4521 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
4522 (display_vectors) Fix missing i18n.
4524 * t-test.q: Migrate to new q2c.
4526 * tab.c: Migrate from arenas to pools.
4527 (tab_create) Use struct len_string.
4528 (tab_realloc) Ditto.
4529 (text_format) Ditto.
4530 (tab_joint_text) Ditto.
4531 (tab_natural_width) Remove rich text support.
4532 (tab_natural_height) Ditto.
4533 (tab_output_text) Handle TAT_FIX.
4534 (tab_raw) Change arg from a_string to len_string.
4535 (tabi_driver) Fix assertion. Use struct len_string.
4536 (render_strip) Use struct len_string. Remove rich text support.
4537 Add `const' qualifiers.
4539 * tab.h: (enum TAB_RICH) Remove.
4540 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
4541 SOM_COL_* updated to read TAB_COL_*.
4542 (struct tab_table) Change arena to pool. Change a_string to
4545 * temporary.c: (restore_dictionary) Rewrite Checker code.
4547 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
4548 LOWEST, HIGHEST) Moved here from common.h.
4549 (typedef any_trns) Removed. All references changed to `struct
4552 * vars-atr.c: (force_create_variable) Fix assertion.
4553 (force_dup_variable) Fix assertion.
4555 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
4557 Using alphanumeric variables in functions under AGGREGATE
4558 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
4559 <BZN-mdksh@t-online.de> for reporting this bug.
4561 * aggregate.c: (parse_aggregate_functions) When setting the
4562 FSTRING bit, also allocate memory for the `string' member of
4564 (free_aggregate_functions) Free iter->string. Don't use the
4565 non-function bits when indexing the array of functions.
4566 [DEBUGGING] (debug_print) Don't use the non-function bits when
4567 indexing the array of functions.
4569 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
4571 Under certain circumstances, the final case would be omitted from
4572 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
4573 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4575 * aggregate.c (agr_00x_end_func): Increment number of cases in
4576 sink before writing case. For streams that keep track of how many
4577 cases there are based on this value, this means that the last case
4578 will be read in on the next stream read.
4580 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
4582 Undefined behavior was invoked by referencing a freed pointer.
4584 * vfm.c (memory_stream_write): Free pointer *after* checking for
4587 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
4589 A wrong record size was displayed when paging the active file to
4592 * vfm.c: (memory_stream_write) Fix off-by-one error.
4594 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
4596 Not having enough temporary space for sorting caused a core dump.
4599 * sort.c: (allocate_cases) Initialize i.
4601 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
4603 Syntax errors in function descriptions on AGGREGATE caused core
4606 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
4607 free_aggregate_functions(), since that function already frees
4610 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
4612 A null pointer was dereferenced, causing a core dump, when
4613 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
4614 but PSPP still doesn't calculate percentiles. Thanks to Regnor
4615 Jernsletten <rjernsle@eunet.no> for reporting this problem.
4617 * arena.c: (arena_malloc) If the arena hasn't been initialized
4618 already, initialize it.
4620 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
4622 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
4623 for compilation with Cygnus Windows B20. Not used by other
4626 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
4628 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
4629 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4631 * sort.c: (compare_case_lists) Reverse sense of comparison if
4632 sorting in descending order.
4633 (compare_record) Ditto.
4635 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
4637 SPLIT FILE with a string variable caused a core dump. Fixed.
4639 * vfm.c: If the variable is a string then make a temporary value
4640 struct pointing to it. The underlying problem is a lot bigger
4641 than this (see TODO) but this is a stopgap for the simple case at
4644 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
4646 Nested INCLUDEs didn't work. Fixed.
4648 * getline.c: (getl_include) Set first_line to NULL in allocated
4651 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
4653 The MATCH FILES procedure set the values of variables not present
4654 to 0. It should have been SYSMIS. This is now fixed.
4656 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
4658 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
4660 The REMARK command was too aggressive about skipping lines. It
4661 didn't like being the last command in a file.
4663 * command.c: (cmd_remark) Call get_entire_line() instead of
4666 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
4668 Comment parsing wasn't consistent with the rest of the code in its
4669 idea of where one command ends and another starts. This meant
4670 that sometimes commands would be mysteriously ignored. Thanks to
4671 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4673 * command.c: (parse_cmd) Hand off comment parsing to new function
4674 skip_comment() in lexer.c.
4675 * lexer.c: (skip_comment) New function.
4677 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
4679 The TABLE subcommand on MATCH FILES worked only erratically at
4680 best. This fixes it. Thanks to Dr. Dirk Melcher
4681 <BZN-mdksh@t-online.de> for reporting this bug.
4683 * get.c: (mtf_compare_BY_values) When comparing string values, a
4684 difference of 1 is still a difference :-)
4685 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
4686 advance TABLE files automatically when matched. Comment fixes.
4688 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
4690 VARIABLE LABELS rejected a slash before the first variable
4691 specification, contradicting the documentation. Thanks to Walter
4692 M. Gray <graywm@northernc.on.ca> for reporting this bug.
4694 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
4695 command specification.
4697 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
4699 Because of an incorrect optimization in memory allocation,
4700 CROSSTABS sometimes segfaulted when asked to output multiple
4701 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4704 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
4705 are passed to output_pivot_table() for its use.
4706 (output_pivot_table) Instead of assuming the number of columns is
4707 constant, keep track with maxcols. In general mode, use maxcells
4708 to determine whether more matrix cells need to be allocated.
4710 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
4712 CROSSTABS didn't display value labels for column and row
4713 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4716 * crosstabs.q: (table_value_missing) If the specified value has a
4717 value label for this variable, then show it instead of the raw
4719 (display_dimensions) Delegate display of value_labels to
4720 table_value_missing.
4722 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
4724 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
4725 <BZN-mdksh@t-online.de> for reporting this bug.
4727 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
4728 if the file isn't declared as binary.
4730 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
4732 MATCH FILES corrupted memory and dumped core on some syntax
4735 * get.c: (cmd_match_files) Set file->handle to NULL before
4737 (mtf_free_file) Don't free a null dictionary.
4739 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
4741 MATCH FILES should set numeric values not available to the
4742 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
4743 <BZN-mdksh@t-online.de> for reporting this bug.
4745 * get.c: (mtf_processing) Set unused records to system-missing,
4748 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
4750 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
4751 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
4753 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
4754 in newly created dictionary, and add each copied variable to the
4757 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
4761 * get.c: (trim_dictionary) Free variable list for KEEP after
4764 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
4766 Some systems didn't like the way open_file was coded. Thanks to
4767 Hankin <hankin@rogue.consultco.com> for pointing this out.
4769 * filename.c: (open_file) Don't try to store stdin, stdout,
4770 stderr as part of an array, because that doesn't always work.
4772 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
4774 The SAVE procedure didn't save long string variables properly.
4775 Fixed by this patch. Thanks to Hankin
4776 <hankin@rogue.consultco.com> for this patch.
4778 * sfm-write.c: (write_variable) Fix off-by-one error in writing
4779 out variable pad records.
4781 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
4783 Previously, if PRINT SPACE were given a negative argument, it
4784 would report an error, then spin in an (almost) infinite loop.
4785 This fixes that behavior.
4787 * print.c: (print_space_trns_proc) After reporting a negative
4788 argument, set number of lines to print to 1.
4790 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
4792 SPSS 8.0 outputs some new record types in its system files, and it
4793 allows longer value labels. Accept these system files.
4795 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
4796 11 emitted by SPSS 8.0.
4798 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
4800 The LIST procedure was too conservative in allocating space for
4801 buffers, which caused a bug that only showed up with very long
4802 output variables. Thanks to Hankin <hankin@dunno.com> for this
4805 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
4807 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
4809 Typo meant string format specifiers weren't checked properly. I
4810 think that Hankin <hankin@dunno.com> sent me this report, but I'm
4811 willing to be corrected on this point.
4813 * format.c: (check_string_specifier) Fix obvious typo.
4815 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
4817 Using $CASENUM in an expression didn't work. Here's a fix.
4818 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
4821 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
4823 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
4825 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
4827 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
4828 other behavior, *sigh*. This patch hopefully fixes that. This
4829 time I've actually tested it.
4831 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
4833 * data-list.c: (read_from_data_list_free,
4834 read_from_data_list_list) Call parse_string_as_format() directly
4835 without mucking around with the field width.
4837 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
4839 Occasionally, you may encounter a script that wants to be
4840 interpreted in interactive mode. Make -i emulate this behavior to
4841 allow such scripts to be executed with PSPP.
4843 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
4845 * cmdline.c: (pre_syntax_message[]) Update -i description.
4847 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
4848 when -i is given on the command line) don't treat unindented lines
4849 as starting a new command.
4851 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
4853 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
4854 mostly caused by local initialized aggregates. After egcs is
4855 fixed upstream these can be removed, but for now they're not a big
4858 * ascii.c: (ascii_postopen_driver) Checker chokes on local
4859 initialized arrays. Avoid this.
4861 * sfm-write.c: (sfm_write_dictionary) Don't use a local
4864 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
4866 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
4867 following changes avoid. Currently I compile sources with egcs
4868 1.1.1 and gcc 2.7.2.3 before sending them out.
4870 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
4872 * ascii.c: (option_tab[]) Initialize all struct members.
4874 * avl.h: (avl_traverser_init) New macro.
4876 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
4879 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
4882 * hash.c: Comment fix.
4884 * hash.h: (hsh_iterator_init) New macro.
4886 * html.c: (option_tab[]) Initialize all struct members.
4888 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
4891 * postscript.c: (option_tab[]) Initialize all struct members.
4892 (output_encodings, preclose, dump_lines) Use new
4893 hsh_iterator_init() macro.
4895 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
4898 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
4901 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
4903 * data-in.c: Examined each of the parsing functions to make sure
4904 that they wouldn't dump core if they were passed a string of the
4905 wrong length, since now the DATA LIST FREE/LIST routines don't
4906 check for field width before passing it to the data parser.
4907 (parse_RBHEX, parse_AHEX) Reject odd length input.
4908 (parse_string_as_format) Reject input that's too short or too
4911 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
4912 a field to its entire declared output width then pass it to the
4913 data-in parsing routines. This contradicted the documented
4914 behavior. This is fixed in these changes. Thanks to Mark H. Wood
4915 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
4916 free-format parsing that differed from SPSS.
4917 (cut_field) Commas and spaces are treated identically. Returns
4918 the proper column instead of a fixed 1 value.
4919 (parse_field) Removed.
4920 (read_from_data_list_free, read_from_data_list_list) Call
4921 parse_string_as_format directly instead of parse_field.
4923 * heap.c: (heap_delete) Stylistic fixes.
4925 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
4927 * loop.c: (loop_2_trns_proc) Formatting fix.
4929 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
4931 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
4933 * vfm.c: (macro FILTERED) New.
4934 (static var filter_var) New.
4935 (process_active_file_write_case) Use FILTERED.
4936 (setup_filter) Set filter_var.
4937 (close_active_file) Delete the filter if not
4938 FILTER_before_TEMPORARY.
4939 (procedure_write_case) Use FILTERED.
4941 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
4943 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
4945 * data-in.c: (parse_day_count) Message fix.
4946 (parse_month) Style fix.
4948 * data-list.c: (struct data_list_pgm) New member eof.
4949 (cmd_data_list) Init eof to 0.
4950 (do_reading) Implement the /END subcommand and read-past-eof
4953 * do-if.c: Include stdio.h when debugging.
4954 (cmd_else_if) Make sure the command is .-terminated.
4956 * glob.c: (init_glob) Capitalize the command prompt.
4958 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
4959 (end_file_trns_proc) Debugging message.
4961 * loop.c: (internal_cmd_loop) Make it work when there's no loop
4963 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
4965 * main.c: (dump_token) Make kwtab[] const.
4967 * set.q: Spelling, comment fixes.
4969 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
4972 * vars-prs.c: (fill_all_vars) Style fix.
4974 * vfm.c: (index_to_varname) Return const.
4976 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
4978 * Changes in many source files for partial -ansi -pedantic and
4979 no-debugging compliance: Remove trailing common in enum
4980 declarations; add `unused' attributes; insert some appropriate
4983 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
4985 * command.c: (shell) Make static.
4986 (run_command) Make static.
4988 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
4990 * dfm.c: (cmd_begin_data) I18n fix.
4992 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
4994 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
4996 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
4999 * file-handle.q: Don't prepend the source file directory name to
5000 the data file name. (Ongoing issue.)
5001 (prepend_current_directory) Comment out.
5002 (internal_cmd_file_handle) Don't call prepend_current_directory().
5003 (fh_get_handle_by_filename) Ditto.
5005 * filename.c: Append zero byte to readlink() return value.
5007 * getline.c: (getl_read_line) I18n fix.
5009 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
5011 * misc.h: Don't use gcc features if __STRICT_ANSI__.
5013 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
5016 * postscript.c: (output_encodings) Don't use local_strdup().
5019 * print.c: Don't use gcc features if __STRICT_ANSI__.
5021 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
5023 * recode.c: (parse_src_spec) Fully brace nested if's.
5025 * set.q: (global var set_testing_mode) New var.
5027 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
5029 * ascii.c: Add some more `unused' attributes that only come into
5030 play when NDEBUG is defined.
5031 (ascii_close_page) Set s_len when reallocating s.
5033 * crosstabs.q: (delete_missing) New function.
5034 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
5035 (make_summary_table) Create summary table reallocable.
5037 * postscript.c: Add more `unused' attributes as above.
5039 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
5040 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
5042 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
5045 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
5046 gratuitous space between parameter definition.
5048 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
5049 complaints about running off the end of functions with NDEBUG
5052 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
5054 * Several source files: Removed some PORTME notes when reflection
5055 revealed that ANSI forbids that sort of breakage. Also, added
5056 lots of `unused' qualifiers here and there.
5058 * aggregate.c: (accumulate_aggregate_info) Remove local var
5059 weighting that turned out not to be used.
5061 * avl.c: Update to version 1.1.0. Add unused specifier.
5062 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
5064 (avl_probe) Replace some instances of 1 with +1 where appropriate.
5065 (avl_find) Cast return value to void *.
5066 (avl_delete) q doesn't need to be initialized at the beginning of
5067 the function. Replace some instances of 1 with +1.
5068 (force_avl_delete) Renamed avl_force_delete, all references changed.
5069 (compare_ints) `param' marked unused.
5070 (print_int) `param' marked unused.
5071 (recurse_tree) Replace some instances of 1 with +1.
5073 * avl.h: Update to version 1.1.0. Only declares avl function
5074 types if not already declared.
5075 (AVL_MAX_HEIGHT) Only define if not already defined.
5076 (struct avl_node) New unused member char pad[2].
5077 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
5078 (force_avl_insert) Renamed avl_force_insert.
5079 (force_avl_delete) Renamed avl_force_delete.
5081 * crosstabs.q: (struct table_entry) Put `freq' into a union with
5083 (struct crosstab) Add new member `ofs'.
5084 (glob var int_tab) Removed.
5085 (custom_tables) In integer mode, assign v[i] properly through the
5087 (custom_variables) Now p.crs.max == max + 1.
5088 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
5089 (precalc) Implement integer mode.
5090 (calc_integer) Implement integer mode.
5091 (compare_table_entry) Remove unused local variable `comparing'.
5092 (make_summary_table) Implement integer mode.
5093 (macro ns_rows) Implemented as static variable now.
5094 (several variables) Made static, from global.
5095 (output_pivot_table) Use table_value_missing() for column heads.
5096 Remove several unused local variables. Implement integer mode
5097 table summing. Count up ns_rows.
5098 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
5099 (find_pivot_extent) Moved into find_pivot_extent_general; now just
5100 calls that function or find_pivot_extent_integer.
5101 (find_pivot_extent_integer) New function.
5102 (enum_var_values) Implemented for integer mode.
5103 (table_value_missing) New function.
5104 (display_dimensions) Call table_value_missing() for heads.
5105 (float_M_suffix) New function.
5106 (display_crosstabulation) Call table_value_missing() for row
5107 heads. Handle missing values in /MISSING=REPORT mode.
5108 (calc_fisher) Remove unused var N.
5109 (calc_r) Remove unused var fact.
5111 * data-list.c: (dump_fixed_table) Fix table dimensioning.
5112 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
5114 * data-out.c: (insert_commas) Remove unused var cp.
5115 (convert_CCx) Remove unused vars save_set_decimal,
5118 * descript.q: (dump_z_table) Fix table dimensioning.
5119 (pre_calc) Remove unused var j.
5120 (display) Remove unused vars title, s. Fix table dimensioning.
5122 * expr-evl.c: Comment fixes.
5124 * frequencies.q: (full_dim) New function.
5125 (dump_full) Fix table dimensioning.
5126 (condensed_dim) New function.
5127 (dump_condensed) Fix table dimensioning.
5129 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
5132 * html.c: (html_close_drive) Remove unused var i.
5133 (postopen) Remove unused vars title, curfn_len, cp.
5134 (preclose) Remove unused vars this, x.
5136 * lexer.c: Comment fixes.
5138 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
5140 * means.q: (custom_tables) Remove unused var m_dim.
5142 * mis-val.c: Format fix.
5144 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
5146 * output.c: (outp_get_paper_size) Remove unused var cp.
5148 * pfm-read.c: (read_float) Remove unused var save, unused label
5150 (read_variables) Remove unused vars cp, j.
5151 (read_value_label) Remove unused var j.
5153 * pfm-write.c: (bufwrite) Remove unused var i.
5155 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
5157 (output_encodings) Remove unused vars char_cp, n_output.
5158 (read_ps_encodings) Remove unused var ep.
5159 (postopen) Remove unused var title.
5160 (preclose) Remove unused var fp.
5161 (ps_open_page) Remove unused vars true, false, orientation,
5162 mirror_horz, mirror_vert, width, length.
5163 (ps_text_metrics) Remove unused var x.
5165 * q2c.c: (find_symbol) Remove unused var y.
5166 (parse_setting) Remove unused parameter sbc, all references
5168 (dump_parser) Remove unused var cp.
5169 (dump_free) Remove unused var i.
5171 * set.q: (static vars args, n) Removed.
5172 (internal_cmd_gset) Removed.
5174 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
5175 (read_machine_flt64_info) Removed unused var file_endian.
5176 (read_documents) Removed unused var i.
5177 (read_compressed_data) Removed unused parameter dict, all
5180 * sfm-write.c: (bufwrite) Removed unused var i.
5181 (sfm_write_case) Removed unused var i.
5183 * sort.c: (merge_once) Remove unused var t.
5184 (write_separate) #if 0 out as dead code.
5186 * split-file.c: (cmd_split_file) Remove unused var i.
5188 * sysfile-info.c: (sysfile_info_dim) New function.
5189 (cmd_sysfile_info) Fix table dimensioning.
5190 (variables_dim) New function.
5191 (display_variables) Fix table dimensioning.
5192 (describe_variable) Remove unused var prev_r.
5194 * t-test.q: (z_postcalc) Removed.
5195 (pairs_calc) Remove unused var bad_weight.
5196 (postcalc) Remove unused vars dfn, dfd.
5198 * tab.c: (tab_create) Set t->dim to NULL.
5199 (tab_dim) Make sure t->dim is NULL first.
5200 (tab_natural_width) Remove parameter `clamp'.
5201 (tab_value) Remove duplicate assertion for table.
5202 (tab_raw) New function.
5203 (nowrap_dim) New function.
5204 (wrap_dim) New function.
5205 (tab_output_text) Fix table dimensioning.
5207 * tab.h: (tab_raw) New macro.
5209 * val-labs.c: (get_label) Remove unused var type.
5210 (copy_value_labels) Remove unused var trav.
5212 * var.h: (struct crosstab_proc) Completely changed.
5214 * vars-prs.c: (parse_dict_variable) Remove unused var v.
5216 * vfm.c: (open_active_file) Remove unused vars i, lp.
5218 * weight.c: (weight_trns_proc) #if 0 out as dead code.
5220 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
5222 * Makefile.am: Add apply-dict.c, flip.c.
5224 * apply-dict.c: New file.
5226 * command.c: (struct command) Make cmd[] larger for CLEAR
5227 TRANSFORMATIONS command name.
5228 (parse_cmd) Make sure we're in a valid state before using it as an
5229 index. Discard variables and reset state on invalid transitions.
5230 (cmd_clear_transformations) New function.
5232 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
5233 Add unimplemented PRESERVE, RESTORE.
5235 * file-handle.h: Include stddef.h.
5239 * pfm-read.c: (parse_value) Pad value label values with spaces,
5242 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
5243 (sfm_close) Decrement reference count, make sure it's zero.
5244 (sfm_maybe_close) New function.
5245 (sfm_read_dictionary) Handle reference counts.
5247 * vars-atr.c: (clear_default_dict) New function.
5248 (discard_variables) Use clear_default_dict().
5250 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
5252 * Makefile.am: Add pfm-write.c.
5253 (LDADD) Add the libgmp2 libraries.
5255 * command.def: Define EXPORT.
5257 * get.c: (cmd_export) New function.
5258 (export_write_case_func) New function.
5260 * pfm-read.c: (static spss2ascii[]) Make it const.
5262 * pfm-write.c: New file.
5264 * sfm-write.c: Formatting, comment fixes.
5266 * var.h: Comment fix.
5268 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
5270 * Makefile.am: Add pfm.h, pfm-read.c.
5272 * command.def: IMPORT is now implemented.
5274 * format.c: (glob var translate_fmt[]) New var.
5276 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
5277 (cmd_import) New function.
5278 (import_source_read) New function.
5279 (glob var import_source) New var.
5281 * pfm-read.c: New file.
5285 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
5287 (dump_dictionary) Disabled printing a couple of items.
5289 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
5291 * crosstabs.q: (postcalc) Call make_summary_table().
5292 (make_summary_table) New function.
5293 (insert_summary) New function.
5294 (display_dimensions) Remove some unnecessary arguments, all
5296 (output_pivot_table) Fix lots of problems with the risk table
5298 (submit) Don't display an empty table.
5299 (display_risk) Fix order of arguments to calc_risk().
5301 * glob.c: Always include assert.h and stdlib.h.
5303 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
5306 * tab.c: (tab_create) Cosmetic changes.
5308 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
5310 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
5314 * crosstabs.q: (output_pivot_table) Headers drawing and submission
5315 code simplified, moved into new function submit().
5316 (submit) New function.
5317 (crosstabs_dim) New function.
5318 (display_directional) Substitute variable names for %s where
5320 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
5321 (calc_symmetric) Initialize parameters only if non-NULL.
5322 Calculate Somers' d.
5323 (calc_directional) Calculate Somers' d (or copy it, really).
5326 * output.c: (outp_string_width) New function.
5328 * postscript.c: (postopen) Calculate font widths based on the
5329 width of the zero '0' character, not the width of the space
5330 character. Set paper-width and paper-length based on points, not
5332 (ps_open_page) Fix page setup string for landscape mode.
5334 * som.h: (struct som_dimension) Removed.
5335 (struct som_table_class) height, width members take int * not
5338 * tab.c: Many functions now have added parameter validation.
5339 (tab_height, tab_width) These functions were removed and merged
5340 into a single function tab_resize(), and all references changed.
5341 (tab_dim) Rewritten since the interface changed; reduced from
5342 hundreds of lines to two. All callers were changed. Currently
5343 most of them just use tab_natural_dimensions as their callback and
5344 await detailed translation of functionality.
5345 (tab_natural_width) New function.
5346 (tab_natural_height) New function.
5347 (tab_natural_dimensions) New function. This is a callback
5348 function, not something that you'd want to call directly.
5349 (tab_nat_dim) Removed.
5350 (tabi_table) Allocates t->w and t->h.
5351 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
5352 dimensions callback.
5353 (evaluate_dimensions) Removed.
5354 (sum_columns) Removed.
5356 * tab.h: (enum TAL_1THIN) Removed.
5357 (enum series t_*) Removed.
5358 (struct tab_table) Members trh, trv changed to unsigned char *
5359 from int *. Member dim changed to a function pointer from a
5360 unsigned char *. Member max_stack_height removed. New members
5362 (macros tab_l, tab_r, tab_t, tab_b) New.
5364 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
5366 * ascii.c: (delineate) Assign last_space_nchars before skipping
5367 spaces, to fix right justification.
5369 * crosstabs.q: (static vars risk, direct) New vars.
5370 (static var pearson_r) Removed.
5371 (glob var chisq_fisher) Made static.
5372 (static vars row_tot[], col_tot[]) Don't include grand total
5374 (static var grand_total) Renamed W, all references changed.
5375 (output_pivot_table) Only make `table' if num_cells != 0. Make
5376 risk and directional tables. Deal with grand total no longer part
5377 of col_tot[]. Free rows and cols after we're done with them.
5378 (display_risk) New function.
5379 (display_directional) New function.
5380 (clac_r) Rewritten so that it stores all its results into its
5381 arguments, so it can be used for Spearman's correlation too.
5382 (calc_symmetric) Added a t[] argument, all references changed.
5383 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
5384 Pearson's r, Cohen's kappa.
5385 (calc_risk) New function.
5386 (calc_directional) New function.
5388 * som.c: (som_submit) Improved debugging code.
5390 * stats.c: (hypercube) New function.
5391 (cube) New function.
5393 (normal_sig) Went back to old implementation, which actually
5396 * stats.h: (macros square, cube, hypercube) Removed. The
5397 equivalent functions in stats.c are inlined here; all references
5398 to square changed to sqr.
5400 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
5402 * crosstabs.q: (N_SYMMETRIC) New define.
5403 (postcalc) Disable debug printing.
5404 (static vars chisq_fisher, pearson_r) New.
5405 (output_pivot_table) Add support for symmetric measures. Add
5406 chi-square output of exact sigs.
5407 (display_chisq) Rewritten.
5408 (display_symmetric) New function.
5409 (gamma_int) New function.
5411 (swap) New function.
5412 (calc_fisher) New function.
5413 (calc_chisq) Check boundary conditions better. Calculate Yates,
5414 Fisher, Mantel-Haenszel tests.
5415 (calc_r) New function.
5416 (calc_symmetric) New function.
5418 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
5420 (chisq_sig) Better boundary conditions. Renamed from
5423 * tab.h: (struct tab_table) New member cf.
5425 * tab.c: (tab_create) Set cf.
5426 (tab_width) New function.
5427 (tab_realloc) Handle cf.
5428 (tab_vline) Handle cf.
5429 (tab_hline) Handle cf.
5430 (tab_box) Handle cf.
5431 (tab_value) Handle cf.
5432 (tab_float) Handle cf.
5433 (tab_text) Handle cf.
5434 (tab_joint_text) Handle cf.
5435 (tab_offset) Handle cf.
5436 (tab_next_row) Handle cf.
5437 (evaluate_dimensions) Handle cf.
5438 (render_strip) Handle cf.
5440 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
5442 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
5443 output_pivot_table().
5444 (output_pivot_table) Moved lots of local variables outside and
5445 made them static. Add beginnings of chi-square statistic
5446 support. Now column and row totals aren't in the main matrix.
5447 Always zero out any leftover rows & columns after we're done with
5448 the table entries. Move all output stuff into
5449 display_dimensions(), display_crosstabs(), display_chisq().
5450 (display_dimensions) New function.
5451 (display_crosstabulation) New function.
5452 (display_chisq) New function.
5453 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
5455 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
5456 references, simplify logic.
5458 * postscript.c: Remove scale, translate-x, translate-y,
5459 mirror-horz, mirror-vert, rotate-180 options.
5460 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
5461 All references deleted.
5462 (macro YT) New macro.
5463 (array option_tab[]) Removed options.
5464 (ps_option) Removed options.
5465 (ps_open_page) Write page setup explicitly to output file, without
5466 using now-deleted BP function.
5467 (macro dump_line) Use YT().
5468 (macro dump_thick_line) Use YT().
5469 (draw_headers) Use YT().
5470 (switch_font) Reorder arguments to SF function.
5471 (write_text) Use YT().
5473 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
5476 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
5478 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
5479 null-debugging code.
5480 (tab_realloc) Remove null-debugging code. Initialize new regions
5482 (tab_vline) Support offsets.
5483 (tab_hline) Support offsets.
5484 (tab_box) Support offsets.
5486 (tab_nulls) Removed.
5489 (evaluate_dimensions) Remove null-debugging code. Understand
5490 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
5491 TAB_EMPTY not present.
5493 * tab.h: New cell attribute TAB_EMPTY.
5494 (macros tab_nr, tab_nc, tab_row, tab_col) New.
5496 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
5497 try to read them from system files.
5499 * vfm.c: (dump_splits) Don't call tab_null().
5501 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
5503 * crosstabs.q: (struct crosstab) Added `missing' member.
5504 (custom_tables) Init missing.
5505 (calc_general) Handle missing values.
5506 (calc_chisq) New function.
5507 (output_pivot_table) Start work on chi-square output. Update for
5508 new tab offset support functions. Shorten statistic names.
5510 * Several files: add in more `const's to placate gcc's warnings.
5512 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
5515 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
5516 tab_null, tab_nulls, tab_value, tab_float, tab_text,
5517 tab_joint_text) Add col_ofs and row_ofs support.
5518 (tab_offset) New function.
5519 (tab_next_row) New function.
5520 (tab_row) New function.
5521 (tab_col) New function.
5522 (tabi_table) Add col_ofs and row_ofs support.
5524 * vars-atr.c: (is_system_missing) New function.
5526 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
5528 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
5529 (static var no_cells) Removed.
5530 (static var num_cells) New.
5531 (static var expected) New.
5532 (static var cells[]) New.
5533 (internal_cmd_crosstabs) Deal with new variables.
5534 (postcalc) Removed most of the meat and put it in new function
5535 output_pivot_table().
5536 (output_pivot_table) Calculates and outputs an entire pivot table.
5538 * postscript.c: (postopen) Fix problems with free()ing addresses
5539 not obtained from malloc().
5541 * som.c: (som_submit) Add assertion.
5543 * sysfile-info.c: (describe_variable) Use new tab_nulls()
5546 * tab.c: (static var tab_names[]) New.
5547 (tab_realloc) -1 for nc or nr indicates no change.
5548 (tab_nulls) New function.
5549 (tab_dim) Use tab_names[].
5550 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
5551 (evaluate_dimensions) Don't terminate on uninited cells, just put
5552 an X in them and emit a notice. Use tab_names[].
5554 * tab.h: Move bits into tab.def.
5556 * tab.def: New. Don't try to declare tab_table_class because then
5557 som.h has to be included.
5559 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
5561 * command.def: New file, contains all the command definitions
5562 previously included bodily in command.c.
5564 * format.def: New file, contains all of the format definitions
5565 previously split across format.h, format.c, and sfm-write.c.
5567 * lexer.h: Renamed from tokens.h in order to match corresponding
5570 * lexerP.h: Moved some rarely used functions exported by lexer.c
5573 * Makefile.am: Commemorate renamed files.
5574 (EXTRA_DIST) Add command.def, format.def.
5576 * command.c: [0] (walk_cmdtable_func) Removed.
5578 * crosstabs.q: (postcalc) Made it work and print out matrices
5580 (enum_column_values) Renamed enum_var_values, generalized for any
5583 * format.h: (struct fmt_desc) New member `spss'.
5585 * q2c.c: (main) Generated code includes lexer.h instead of
5588 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
5589 instead of an independent translation table.
5591 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
5593 * Lots of source files: Added const to declarations.
5595 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
5597 * arena.c: (arena_clear) Set prev pointer to null when done.
5599 * ascii.c: (ascii_option) Rename index as indx.
5601 * avl.c: This is now a separate library called libavl.
5602 (xmalloc) Make static.
5603 (avl_probe) Step A7 can use the cache instead of an explicit
5605 (avl_delete) Don't maintain a q pointer because it's always
5606 available in the pointer stack. Comment fix.
5608 * avl.h: This is now a separate library called libavl.
5610 * command.c: (cmd_table[]) Remove spurious trailing "".
5612 * common.h: Only include random() fix if this system needs it.
5614 * crosstabs.q: Include alloca headers.
5615 (n_sorted_tab) New global var.
5616 (postcalc) Mostly rewritten.
5617 (find_pivot_extent) Rewritten.
5618 (enum_column_values) Rewritten.
5620 * data-out.c: (convert_F) Rename inner n as n_spaces.
5622 * error.c: (dump_message) Don't have an outer var i.
5624 * file-handle.q: (static var f) Removed. All references removed.
5625 (internal_cmd_file_handle) Uses a local variable instead of f.
5627 * get.c: (trim_dictionary) Change scope of i, i1, i2.
5628 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
5631 * getline.h: Declare getl_history as extern. Reported by
5632 palme@uni-wuppertal.de (Hubert Palme).
5634 * postscript.c: (postopen) Some large mods for constness.
5636 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
5639 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
5641 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
5642 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
5645 * avl.c, avl.h: New files. These form a clean-room
5646 reimplementation of avllib. Iterative algorithms are used in
5647 place of recursive ones, so there is no resemblance in the code.
5649 * Lots of headers: Don't include other headers by default.
5651 * Lots of source files: Explicitly include all needed headers.
5653 * arena.c: (arena_clear) New function.
5655 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
5656 (static var ar) Removed.
5657 (staitc vars ar_tc, ar_col) New.
5658 (cmd_crosstabs) Destroy the arenas.
5659 (internal_cmd_crosstabs) Create the arenas.
5660 (precalc) Don't need a free function for the hash.
5661 (calc_general) Make sure to zero out the trailer on the key data
5663 (print_table_entries) Updated.
5664 (postcalc) Worked on actually implementing.
5665 (find_pivot_extent) New function.
5666 (compare_value) New function.
5667 (enum_column_values) New function.
5669 * data-in.c: (parse_month) Make local array `static const'.
5671 * data-out.c: (convert_date) Make local array `static const'.
5672 (convert_WKDAY) Same.
5673 (convert_MONTH) Same.
5675 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
5676 been renamed to avl_walk().
5678 * hash.c: Rewritten more efficiently.
5680 * hash.h: Add attribute const to hsh_next_prime declaration.
5682 * lexer.c: (id_match) Make arguments const.
5684 * postscript.c: (ps_postopen_driver) Make default fonts the
5687 * q2c.c: (main) Generated code needs stdlib.h.
5689 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
5690 initialized to 0 now, not to NULL. All other references to
5691 avl_traverser were updated in the same way.
5693 * tokens.h: Macro version of id_match updated to use const
5696 * val-labs.c: (inc_ref_count) New function.
5697 (copy_value_labels) Simply through use of new avl_copy() function.
5699 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
5701 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
5702 (postcalc) Worked on this.
5704 * postscript.c: (OPO_DOUBLE_LINE) New enum.
5705 (struct ps_driver_ext) New line_width_thick member.
5706 (ps_preopen_drive) Init line_width_thick.
5707 (option_tab[]) Add line-* options.
5708 (ps_option) Parse line-* options.
5709 (postopen) Add line_width_thick support. Strip leading spaces on
5710 prologue output lines.
5711 (ps_open_page) Include line_width_thick in output.
5712 (macro dump_thick_line) New.
5713 (dump_fancy_line) Support thick lines as well as double lines.
5715 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
5717 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
5718 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
5720 * Many source files: Rename `options' to `pv_opts' as appropriate.
5722 * command.c: (static var cmd_table[]) Add CROSSTABS command.
5724 * common.c: (xcalloc) New function.
5726 * crosstabs.q: New file. Not finished yet, though.
5728 * data-list.c: Comment fix.
5730 * error.c: Remove some old Checker cruft.
5732 * frequencies.q: (dump_full) Cumulate valid percent instead of
5735 * getline.c: Comment fix.
5737 * hash.c: Comment fixes.
5739 * hash.h: (struct hsh_table) Make hash functions return unsigned
5740 instead of int to avoid problems with taking the modulo of
5741 negative return values. All references changed.
5743 * misc.c: (intlog10) Make its table static const instead of auto.
5745 * sfm-read.c: (read_header) Make `prefix' static const instead of
5748 * var.h: (union value) Add member `hash'.
5749 (struct variable) Rename prv_index as `foo'--all references
5751 (typedef pv_opts) Removed. All references changed.
5753 * vars-prs.c: (parse_variables) Message fixes.
5755 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
5757 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
5758 they are being inserted. Don't check for BY variables of
5759 different types. Discard variables if the active file isn't
5760 included in the merge.
5761 (mtf_processing) Essentially rewritten.
5762 (mtf_merge_dictionary) Check for master/slave variables of
5763 different types/widths.
5765 * vfm.c: (static var not_canceled) New var.
5766 (process_active_file) Don't call vfm_source->read() if
5767 there's no vfm-source. Initialize not_canceled.
5768 (process_active_file_write_case) Honor and update not_canceled.
5769 (prepare_for_writing) Rollback changes from yesterday, they were
5771 (close_active_file) Don't destroy vfm_source unless it exists.
5773 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
5775 * Lots of source files: Added { } around nested if/else constructs
5776 to avoid new gcc 2.8 warnings.
5778 * data-in.c: (parse_Z) Declare `int' type explicitly.
5781 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
5782 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
5783 prev members. Put TABLEs at the end of the chain and FILEs at the
5784 beginning. Don't allow the active file in STATE_INIT. Use proper
5785 `seen' value for the active file. Fill out the by members and
5786 make sure they're of consistent type. Do the actual merge
5788 (mtf_processing_finish) New function.
5789 (var_type_description) New function.
5790 (mtf_free_file) New function.
5791 (mtf_free) Rewritten.
5792 (mtf_delete_file_in_place) New function.
5793 (mtf_read_nonactive_records) New function.
5794 (mtf_compare_BY_values) New function.
5795 (static var mtf_seq_no) New var.
5796 (mtf_processing) New function.
5797 (mtf_merge_dictionary) Assign nval members for the system file
5798 dictionary. Assign fv values for its variables. Point each slave
5799 variable to the corresponding master variable.
5801 * hash.c: Include str.h.
5803 * mis-val.c: (copy_missing_values) src arg is const.
5805 * misc.c: (spacing) Make `max' var explicitly int.
5807 * sfm-read.c: (dump_dictionary) Message reformatting.
5808 (sfm_read_case) Add assertion.
5810 * sort.c: Esthetic fixes.
5812 * var.h: (struct match_files_proc) New struct.
5813 (struct variable) Add private data match_files_proc.
5815 * vars-atr.c: (delete_variable) Implement. Add argument for the
5816 dictionary that owning the variable.
5817 (dup_variable) Add assertion.
5819 * vfm.c: Comment fixes, hopefully the comments are correct now.
5820 (process_active_file) New function.
5821 (process_active_file_write_case) New function.
5822 (process_active_file_output_case) New function.
5823 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
5825 (write_case) Renamed procedure_write_case(). Now write_case is a
5826 pointer to a function. Style fixes.
5828 1998-03-05 Ben Pfaff <blp@gnu.org>
5830 * Makefile.am: (q2c) Link with libmisc.
5831 (version.c) Define default_config_path, include_path,
5834 * ascii.c: (ascii_postopen_driver) When the default newline string
5835 is requested, open file in text mode. Suggested by
5836 palme@uni-wuppertal.de (Hubert Palme).
5837 (static vars line_buf, line_p) Change from char * to unsigned char
5839 (ascii_close_page) char * to unsigned char *.
5841 * cmdline.c: (parse_command_line) Implement -r option by
5842 prepending ~/.pspp/rc to the list of files to process.
5844 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
5845 before pulling in a final line.
5846 (null_func, null_int_func) Removed (dead code).
5848 * descript.q: (display) Calculate width of variable name column
5849 properly. Calculate number of valid cases properly. Reported by
5850 palme@uni-wuppertal.de (Hubert Palme).
5852 * filename.c: (init_filename) Use default_config_path instead of
5853 now obsolete CONFIG_PATH.
5855 * getline.c: (getl_initialize) Use include_path instead of now
5856 obsolete INCLUDE_PATH.
5857 (getl_add_file) New argument `where'. All references changed.
5859 * groff.c: (find_font_file) Use groff_font_path instead of now
5860 obsolete GROFF_FONT_PATH.
5862 * postscript.c: (find_ps_file) Use groff_font_path instead of now
5863 obsolete GROFF_FONT_PATH. Copy through temporary variable to
5864 avoid problems with constness.
5866 * str.h: (macro cs_streq) New macro.
5868 * version.h: (glob var default_config_path, include_path,
5869 groff_font_path) New vars.
5871 1998-02-23 Ben Pfaff <blp@gnu.org>
5873 * Many source files: Change verbose_msg() priority levels and
5876 * aggregate.c: Include debug-print.h.
5878 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
5880 (static var pre_syntax_message) Document --safer/-s and
5883 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
5885 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
5886 because it's not used but it's still copied.
5887 (open_file_r) Remove gratuitous debug message.
5889 * filename.c: (safety_violation) New function.
5890 (open_file) Remove gratuitous debug messages. Don't allow pipe
5891 files if set_safer is set.
5893 * get.c: Turn off debugging.
5895 * getline.c: (getl_add_virtual_file) New function.
5896 (getl_read_line) Add verbose_msg() call for opening new syntax
5898 (getl_perform_delayed_reset) Add a return value describing whether
5899 any action was taken. Call reset_eof().
5901 * getline.h: Comment fix.
5903 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
5904 place of incorrect `continue'. Use strtok_r() instead of
5905 strtok(). Always check strtok_r() return value.
5906 (groff_read_DESC) Use strtok_r() instead of strtok().
5908 * lexer.c: (reset_eof) New function.
5910 * main.c: (parse) Get a token after performing a delayed reset
5911 action; allow empty syntax files.
5913 * postscript.c: (output_encodings) Use strtok_r() instead of
5916 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
5918 * set.q: Comment fixes.
5919 (glob var set_safer) New var.
5920 (internal_cmd_set) Support SAFER.
5922 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
5924 * temporary.c: (free_dictionary) Set d->splits to NULL after
5927 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
5928 variable deleted, not if it *isn't* deleted.
5930 1998-02-16 Ben Pfaff <blp@gnu.org>
5932 * command.c: (array cmd_table[]) Add MATCH FILES.
5934 * common.c: Comment fixes.
5936 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
5937 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
5938 Include alloca.h. Problem reported by palme@uni-wuppertal.de
5941 * expr-opt.c: Include str.h. Problem reported by
5942 palme@uni-wuppertal.de (Hubert Palme).
5944 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
5945 (static var mtf_by) Change from char ** to variable **.
5946 (static var mtf_master) New var.
5947 (mtf_merge_dictionary) New function.
5948 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
5949 var type. Reorder tests properly. Initialize file->dict. Detect
5950 TABLE= without BY=. Read file dictionaries and merge them. Give
5951 subcommand name with IN, LAST, FIRST error messages. Create IN,
5952 LAST, FIRST variables. Comment fixes.
5953 (mtf_free) Don't free default_dict. Free mtf_master.
5955 * getline.c: Define getl_mode. Change getl_buf_size to size_t
5957 (handle_line_buffer) Cast int to size_t in comparison to avoid
5960 * getline.h: Declare getl_mode extern.
5962 * groff-font.c: (groff_read_font) Type-fix calls to getline.
5963 (groff_read_DESC) Make line_size a size_t.
5964 (match_tok) Parenthesize name to avoid macro expansion.
5966 * mis-val.c: (copy_missing_values) New function.
5968 * postscript.c: (postopen) Make buf_size a size_t.
5970 * sfm-read.c: (dump_dictionary) Make global from static. Print
5971 variable info in parts for easier debugging with Checker.
5973 * temporary.c: (copy_variable) Use copy_value_labels().
5974 (new_dictionary) New arg: whether to copy file label, documents.
5976 * val-labs.c: (copy_value_labels) New function.
5978 * var.h: (enums MISSING_*) Add MISSING_COUNT.
5980 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
5982 (dup_variable) Set prv_index, get.fv, get.nv.
5984 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
5986 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
5988 * Many source files: For ANSI-compliance, add empty statement
5989 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
5990 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
5992 * data-in.c: (parse_numeric) Some header files break on
5993 -DBL_MIN_10_EXP because they get a --; add () for safety.
5994 Reported by palme@uni-wuppertal.de (Hubert Palme).
5996 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
5997 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
5998 (dfm_close) Use close_file_ext.
5999 (open_inline_file) Set file.file to NULL, not file.
6000 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
6001 struct and use open_file_ext().
6002 (read_record) Use file.file.
6004 * file-handle.q: (prepend_current_directory) Pass through special
6007 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
6008 (normalize_filename) Pass through special filenames.
6009 (open_file, close_file) Accept pipe| and |pipe syntaxes as
6011 (dirname) Rename blp_dirname() because of name conflict on some
6012 OS. All references changed. Reported by palme@uni-wuppertal.de
6014 (is_special_filename) New function.
6016 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
6017 (trim_dictionary) Conditionalize some of the options on whether
6018 GTSV_OPT_MATCH_FILES is in *options.
6019 (rename_variables) Don't allow variables to be renamed as scratch
6021 (MTF_*) New enum series.
6022 (struct mtf_file) New struct.
6023 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
6025 (cmd_match_files, mtf_free) New functions.
6027 * lexer.c: (match_int) Needed parentheses around name to escape
6028 macro expansion. Reported by Micah Altman
6029 <maltman@www-vdc.fas.harvard.edu>.
6031 * print.c: Needed to include alloca.h. Reported by Micah Altman
6032 <maltman@www-vdc.fas.harvard.edu>.
6034 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
6035 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
6038 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
6039 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6041 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
6043 * html.c: (struct html_driver_ext) Move into htmlP.h.
6044 (html_preopen_driver) Initialize cp_x, cp_y.
6045 (html_submit) Implement as call to output_tab_table().
6046 (change_attributes) New function.
6047 (escape_string) New function.
6048 (output_tab_table) New function.
6050 * list.q: (write_all_headers) Add code for writing headers for the
6052 (clean_up) Write out the html close-table tag.
6053 (determine_layout) Ignore html driver.
6054 (list_cases) Write html data.
6056 * som.c: (som_submit) Move more of the code into output_table().
6058 * tab.c: (static var hit) Make a global var and rename tab_hit.
6059 (static var tab_table_class) Make a global var.
6061 * htmlP.h: New file.
6063 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
6065 * dump-sysfile.c: Removed.
6067 * html.c: (preclose) Change comment in emitted code.
6069 * matrix-data.c: Debugging off by default. Comment fixes.
6070 (static var container) New var.
6071 (cmd_matrix_data) Create and destroy container. Initialize
6072 is_per_factor[] to 0s. Move code into new function
6073 string_to_content_type(). Require split values to be present in
6074 the data when ROWTYPE_ is explicit. Call specific function, not
6075 general read_matrices().
6076 (string_to_content_type) New function.
6077 (context) Exclude all whitespace, not just spaces.
6078 (mget_token) A dot is a number. Add assertion.
6079 (static var data) Renamed nr_data.
6080 (static var factor_values) Renamed nr_factor_values.
6081 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
6082 only specific case. Close data_file before exit.
6083 (fill_matrix) New function.
6084 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
6085 printing. Style fixes. Message fixes. Move code into
6087 (read_matrices_without_rowtype) Rename
6088 matrix_data_read_without_rowtype(). Fix off-by-one error on
6089 loops. Allocate nr_data[] memory from arena.
6090 (read_matrices_with_rowtype) Removed.
6091 (read_splits) Renamed nr_read_splits(). Style fixes.
6092 (read_factors) Renamed nr_read_factors().
6093 (dump_cell_content) Comment fixes. Arguments changed. Change
6094 debug printing. All references changed.
6095 (output_data) Renamed nr_output_data().
6096 (static var wr_content) New var.
6097 (struct factor_data) New struct.
6098 (static var wr_data) New var.
6099 (static var wr_current) New var.
6100 (matrix_data_source_destroy_source) Removed.
6101 (read_matrices_with_rowtype) New function.
6102 (matrix_data_read_with_rowtype) New function.
6103 (wr_read_splits) New function.
6104 (compare_factors) New function.
6105 (wr_output_data) New function.
6106 (wr_read_rowtype) New function.
6107 (wr_read_factors) New function.
6108 (wr_read_indeps) New function.
6109 (glob var matrix_data_source) Make destroy_source member NULL as
6112 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
6114 * lexer.c: (syntax_error) Give better error message when at end of
6117 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
6118 N_SCALAR to output as plain N.
6119 (mdump_token) Change output format.
6120 (context) Fix message output interaction with spaces in input.
6121 (another_token) New function.
6122 (force_eol) Improved error message.
6123 (static var max_cell_index) New var.
6124 (read_matrices) Init `cells'. factor_values is now per-cell.
6125 Init max_cell_index.
6126 (read_data_lines) Replace `compare' local with new `compare' arg.
6127 Debugging messages changed. Only read factors if per_factor.
6128 Propagate error return from read_factors(), force_eol().
6129 Copy N_SCALAR values across the N vector.
6130 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
6131 check parentheses manually since we now have is_per_factor[].
6132 Call read_data_lines() with new args. Check for end of data after
6133 looping, using another_token().
6134 (read_factors) Arguments changed. Use max_cell_index to determine
6135 whether to read or compare factors. Message fixes.
6136 (dump_cell_content) New function.
6137 (output_data) Completely rewritten because content types were
6138 supported to be nested inside factor values, not vice versa.
6140 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
6142 * lexer.c: (syntax_error) Support formatted varargs messages.
6144 * matrix-data.c: Turn debugging on by default.
6145 (static content_type[]) New array.
6146 (static content_names[]) New array.
6147 (static rowtype_, varname_) New vars.
6148 (static is_per_factor[]) New array.
6149 (static split_values) Moved declaration.
6150 (static n_continuous, first_continuous) New var.
6151 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
6152 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
6153 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
6154 Check for continuous variables.
6155 [DEBUGGING] (debug_print) Remove content_names[].
6156 (mdump_token) New macro.
6157 (mget_token_dump) New function.
6158 (mdump_token) New function.
6159 (context) New function.
6160 (mget_token) Fix messages.
6161 (static var data, split_values, factor_values) New vars.
6162 (read_matrices) Manage split_values, factor_values.
6163 (read_data_lines) New function.
6164 (read_matrices_without_rowtype) Implemented.
6165 (read_splits) Message fixes. Uses `just_read'.
6166 (read_factors) New function.
6167 (output_data) New function.
6168 (matrix_data_source_destroy_source) Close the file handle.
6169 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
6172 * str.c: (strpadcmp) Removed.
6174 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
6176 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
6178 * Lots of source files: Add cast to unsigned character to calls to
6179 tolower() and toupper().
6181 * aggregate.c: Set default_dict.splits to NULL.
6183 * command.c: (static variable tab[]) Add MATRIX DATA.
6185 * data-in.c: Add debugging defines. Formatting fixes.
6187 * expr-opt.c: Formatting fixes.
6189 * lexer.c: (syntax_error) Message fixes.
6191 * matrix-data.c: New enum series.
6192 (static vars fmt, section, diag, explicit_rowtype, signle_split,
6193 split_values, n_factors, factors, cells, pop_n, contents,
6194 n_contents) New vars.
6195 (cmd_matrix_data) Finished implementation.
6196 (compare_variables_by_mxd_vartype) New function.
6197 [DEBUGGING] (debug_print) New function.
6198 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
6199 (read_matrices) New function.
6200 (read_matrices_without_rowtype) New function.
6201 (read_matrices_with_rowtype) New function.
6202 (read_splits) New function.
6203 (mget_token) New function.
6204 (force_eol) New function.
6205 [0] (test_tokenizer) New function.
6206 (matrix_data_source_destroy_source) New function.
6207 (glob var matrix_data_source) New var.
6209 * misc.h: Include ieeefp.h if present.
6211 * split-file.h: (cmd_split_file) Changes corresponding to struct
6214 * str.h: Fix memmem prototype.
6216 * temporary.c: (save_dictionary, restore_dictionary,
6217 free_dictionary) Changes corresponding to struct dictionary
6220 * var.h: (MXD_* enums) New enum series.
6221 (struct matrix_data_proc) New struct.
6222 (struct split) Removed.
6223 (struct dictionary) Changed `splits' member from `split *' to
6225 (macro force_create_variable) New macro. Replaced lots of
6226 create_variable()/assert() calls with calls to this macro.
6228 * vars-atr.c: (discard_variables) Changed assertion.
6229 [GLOBAL_DEBUGGING] (force_create_variable) New function
6230 called by the macro of the same name.
6231 (clear_variable) Changes to delete splits from the dictionary
6232 corresponding to struct dictionary changes.
6234 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
6235 corrupted variable `index' values in the dictionary passed in
6236 every time this function is called.
6238 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
6239 to struct dictionary changes.
6241 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
6243 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
6245 * command.c: New includes.
6246 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
6247 (cmd_erase) New function.
6248 [unix] (shell) New function.
6249 (run_command) New function.
6250 (cmd_host) New function.
6251 (cmd_new_file) New function.
6253 * expr-prs.c: (parse_primary) Message fix.
6255 * inpt-pgm.c: Formatting fix.
6256 (cmd_reread) Implement the FILE subcommand.
6258 * matrix-data.c: New file.
6260 * q2c.c: (dump_header) Change output commenting style.
6262 * weight.c: Comment fix.
6264 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
6266 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
6268 (buf_10x) Renamed buf_1xx, all references changed.
6269 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
6270 cases now implemented).
6271 (create_sysfile) New function.
6272 (agr_11x_func) New function.
6274 * data-in.c: (parse_numeric) Work properly if there's an
6275 explicitly coded decimal point in the data and decimal places are
6276 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
6277 <el@linux.lisse.na>.
6279 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
6280 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
6281 Eberhard W Lisse <el@linux.lisse.na>.
6283 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
6284 strerror.c. Bug reported by Alexandre Oliva
6285 <oliva@dcc.unicamp.br>.
6287 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
6288 (static var separate_case_tab) New var.
6289 (cmd_sort_cases) Cancel temporary transformations here. Free
6290 v_sort before return.
6291 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
6292 we're reading from a sort stream. Don't cancel temporary
6293 transformations. Offload internal sorting to do_internal_sort().
6294 (do_internal_sort) New function. Handles internal sorting even
6295 when SEPARATE is nonzero. Doesn't free v_sort.
6296 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
6298 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
6299 sink if SEPARATE is zero.
6300 (read_output_cases) Renamed read_sort_output(), all references
6301 changed. Now uses separate_case_tab when it exists.
6302 (write_separate) New function.
6304 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
6305 memory_sink_cases. Don't redundantly call
6306 vfm_source->destroy_source().
6307 (memory_stream_mode) After switching over, set memory_sink_cases
6310 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
6312 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
6314 (static var prev_case) New, moved out of aggregate_single_case()
6316 (static var buf64_10x, buf_10x) New.
6317 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
6318 the 000, 001, 100, and 101 cases. Free prev_case.
6319 (parse_aggregate_functions) Disallow scratch variables.
6320 (free_aggregate_functions) Only free agr_dict if non-null. Use
6321 iter->function to determine numeric/string type, not
6323 (aggregate_single_case) Don't manage prev_case. Initialize
6324 aggregate info after dumping it.
6325 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
6326 mean, stddev, weighted stddev definitions.
6327 (dump_aggregate_info) Implemented.
6328 (initialize_aggregate_info) Renamed from
6329 initialize_aggregate_functions(). Initializes dbl[2].
6330 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
6331 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
6333 * cases.c: (alloc_val) Removed.
6335 * get.c: (cmd_save_internal) Initialize new `dict' member.
6337 * sfm-write.c: (sfm_write_dictionary, write_header,
6338 write_variable, write_value_labels, write_documents) Reorganize,
6339 simplify for new parameter structure.
6340 (write_variable) Only one variable * argument now.
6342 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
6343 replaced by new `dict' member.
6345 * temporary.c: (new_dictionary) Initialize n_documents.
6347 * vars-atr.c: (dup_variable) Allocate `value's from dict into
6349 (init_variable, replace_variable) Eliminate usage of alloc_val().
6351 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
6353 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
6354 signal that AGGREGATE is to be used for forming final cases.
6355 (close_active_file) Call end_func before stopping lagging. Cancel
6356 temporary after finishing compaction.
6357 (write_case) Comment fixes. Cleaned up.
6358 (compact_case) Let AGGREGATE handle compaction when `temporary' is
6361 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
6363 * Makefile.am: (BUILT_SOURCES) Add means.c.
6364 (pspp_SOURCES) Add means.c.
6365 (EXTRA_DIST) Add means.q.
6367 * command.c: (array cmd_table[]) Add MEANS.
6369 * common.h: Esthetic fixes. Comment fixes. Test for
6370 MAX_SHORT_STRING greater than 8.
6371 (macros LOWEST, HIGHEST) New.
6373 * data-in.c, data-list.c, recode.c: Comment fixes.
6375 * means.q: New file, base version.
6377 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
6378 with LOWEST, DBL_MAX with HIGHEST.
6380 * q2c.c: (dump_vars) Add an enum to array types giving the number
6381 of values for the enum.
6383 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
6384 Replace second_lowest_value with second_lowest_flt64.
6386 * sfm-write.c: (write_variable, write_rec_7_34) Replace
6387 second_lowest_value with second_lowest_flt64.
6389 * t-test.q: Comment fix.
6391 * temporary.c: (restore_dictionary) Esthetic fix.
6393 * tokens.h: (force_match_id, force_match, force_string, force_int,
6394 force_num, force_id) Replace msg() with syntax_error().
6396 * var.h: (struct means_proc) New.
6397 (struct variable) Add mns member to `p' union.
6399 * vars-prs.c: (parse_variable, parse_dict_variable,
6400 parse_variables, parse_DATA_LIST_vars) Replace msg() with
6403 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
6405 * Makefile.am: (pspp_SOURCES) Add tab.h.
6407 * Most source files: Added a cast to unsigned char in usages of
6408 the ctype is*() functions. Replaced `end of command expected'
6409 calls to msg() with calls to syntax_error().
6411 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
6413 * lexer.c: (hex_val) Removed (was dead code).
6414 (idmatch) Parenthesize function name to avoid macro expansion.
6416 * postscript.c: Comment fixes.
6417 (ps_preopen_driver) Change default font size to 10pt.
6419 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
6421 (parse_format_spec) Change system-file format spec argument type
6422 to int32. Parse the format spec with bitwise operators.
6424 * sfmP.h: (struct sysfile_format) Removed.
6425 (struct sysfile_variable) Changed print, write members from
6426 sysfile_format to int32.
6428 * tokens.h: Esthetic fixes.
6429 [__GNUC__] (macro id_match) New macro to hopefully speed up
6430 identifier matching.
6431 (macros match_id, match_tok, match_int) Implemented in
6432 compiler-independent manner; no longer GNU C only.
6434 * vfm.h: Include time.h.
6436 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
6438 * data-list.c: (dump_fixed_table) Change tab_dim().
6440 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
6442 * error.c: Include command.h.
6444 * frequencies.g: Formatting fixes.
6446 * frequencies.q: Add tab_dim() calls. Make the total cell a
6449 * glob.c: Include command.h.
6451 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
6453 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
6454 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
6455 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
6456 the other elements (is this right?).
6457 (read_variables) Use lowest, highest members.
6458 (parse_format_spec) New arg `vv' for more stringent checking.
6459 (dump_dictionary) Byteswaps nonexplicit data.
6460 (sfm_read_case) Byteswap numeric data.
6462 * som.c: Initialize table_num to 1.
6463 (render_segments) Remember to increment y_index after each table
6466 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
6467 avl_count() on a NULL tree. No title for the second table.
6468 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
6469 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
6470 fix call to display_variables().
6471 (display_variables) Default to 4 columns, not 3. Set up headers.
6472 Column title is Variable, not Name. Fix index column.
6473 Add joint text. Add tab_dim(). Handle value labels properly.
6474 Handle DISPLAY LABELS properly. Draw boxes correctly.
6475 (describe_variable) Value labels don't need titles. Don't clear
6476 nonexistent index column.
6477 (compare_vectors_by_name) New function.
6478 (display_vectors) New function.
6480 * tab.c: (tab_height) Add assertion.
6481 (tab_null) Add debug code.
6482 (evaluate_dimensions) Add debug code.
6484 * var.h: (struct variable) get_proc data is sometimes used
6485 simultaneously with other per-procedure info, therefore it was
6486 removed from the union. All references changed.
6488 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
6490 * ascii.c: (ascii_close_page) Put title on second line of headers
6491 if there is no subtitle.
6493 * command.c: (glob var cur_proc) Move definition here, from
6495 (cmd_remark) Emit blank line before remarks.
6497 * command.h: (glob var cur_proc) Move declaration here, from
6500 * data-list.c: (dump_fixed_table) Fix messages.
6501 (dump_free_table) Call tab_nat_dim().
6503 * descript.q: (dump_z_table) Modify tab_dim() call.
6505 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
6507 (dump_statistics) Don't output header.
6509 * groff-font.c: Minor format fix.
6511 * html.c: Comment fix.
6513 * list.q: (write_varname) Indent after advancing page.
6515 * output.h: Minor reordering.
6517 * postscript.c: Comment fixes. Many places, '\n' was replaced by
6518 a reference to eol[].
6519 (struct ps_driver_ext) New member eol[].
6520 (ps_preopen_driver) Initialize eol[].
6521 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
6522 defaults. Handle headers. Fix test for minimum page length.
6523 (static var option_tab[]) Add `line-ends'.
6524 (ps_option) Handle line-ends to change eol[].
6525 (postopen) Scale prop_em_width and fixed_width properly. Set the
6526 prologue title to outp_title if applicable. Replace the prologue
6527 line ends with eol[]. Call draw_headers() if headers are enabled.
6528 (text_width) New function.
6529 (out_text_plain) New function.
6530 (draw_headers) New function.
6532 * print.c: (dump_table) Call tab_nat_dim().
6534 * som.c: (som_blank_line) Only advance a line if not at the top of
6536 (som_submit) Move several informational table calls here.
6537 Increment subtable_num if SOMF_NO_TITLE not set.
6538 (output_table) Advance a line if SOMF_NO_SPACING not set.
6539 (render_columns, render_segments, render_simple) Handle spacing
6540 between tables. Handle table titles. Remove debug output.
6542 * som.h: (SOMF_*) New enum series.
6543 (struct som_table_class) New member `flags'.
6545 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
6547 (display_variables) Calls tab_nat_dim().
6548 (describe_variable) Remove restriction on number of value labels.
6549 Make value labels separated by thin lines.
6551 * tab.c: (tab_create) Default `flags' to none.
6552 (tab_float) New arg `w'. All references changed.
6553 (tab_nat_dim) New function.
6554 (tab_output_text) No title or spacing.
6555 (tab_flags) New function.
6556 (tabi_flags) New function.
6557 (tabi_title) New function.
6558 (strip_height) Removed.
6559 (tabi_render) Skip title when necessary.
6560 (static var tab_tab_class) Add tabi_flags, tabi_title.
6561 (evaluate_dimensions) Disable display of column, row size.
6562 (sum_columns) Add title height to top header.
6563 (render_strip) Moved within file.
6565 * tab.h: (struct tab_table) New member `flags'.
6567 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
6569 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
6571 * Most source files: Add `const' attribute in all appropriate
6574 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
6575 column to the variables table for use by describe_variable().
6576 (cmd_display) Disable for the present.
6577 (display_documents) Don't wrap documents.
6578 (display_variables) Table has four columns now.
6579 (describe_variable) Table has four columns now. Don't use a
6580 subtable, use joined cells instead.
6582 * tab.c: (tab_create) Don't set `join'.
6583 (tab_realloc) ct array is not made up of a_string's.
6584 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
6585 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
6586 (text_format) New function.
6587 (tab_title) Rewritten, uses text_format().
6588 (tab_text) Rewritten, uses text_format().
6589 (tab_joint_text) New function.
6591 (static var hit) New variable.
6592 (render_strip) New args r1, r2. Implement joined cells that fit
6594 (tabi_render) Increment hit. Pass new args to render_strip().
6595 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
6596 cells. For t_naw and t_nah, ignore joined cells and null cells in
6599 * tab.h: (struct tab_join_rect) Removed.
6600 (struct tab_table) Removed `join'.
6601 (TAB_JOIN_MAIN) Removed.
6602 (struct tab_joined_cell) New struct.
6603 (TAT_NOWRAP) New enum.
6605 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
6607 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
6609 (ascii_postopen_driver) Fix initialization of *_spacing so that
6610 the TAL_0 bit doesn't count.
6612 * data-list.c: (dump_fixed_table) Use natural width for Format
6615 * glob.c: (rerange) Removed.
6616 (get_date) Formatting fixes. Internationalization fix.
6618 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
6621 * postscript.c: (ps_postopen_driver) Replace
6622 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
6624 * som.c: (som_submit) Don't eject page before every table.
6625 (output_table) Fix order of arguments on call to area().
6626 (render_columns) Fix calculation of max_len.
6628 * tab.c: (tabi_cumulate) Minor change to increase elegance.
6629 (render_strip) New function.
6630 (strip_height) New function.
6631 (tabi_render) Rewrite as calls to render_strip().
6633 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
6634 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
6635 with the TAB_* and OUTP_T_* constants.
6637 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
6639 * Makefile.am: Formatting fixes.
6641 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
6644 * data-list.c: (dump_fixed_table) Add tab_dim() call.
6646 * descript.q: (dump_z_table, display) Add tab_dim() calls.
6648 * dump-sysfile.c: (glob var length) Make type off_t.
6649 (usage) Fix arguments.
6652 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
6653 Now right-justification is the default so many references had to
6655 (struct outp_class) Removed line_width, all references changed.
6656 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
6657 (struct outp_driver) Add elements horiz_line_width,
6658 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
6661 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
6663 (postopen) Initialize all the informational members of
6666 * som.c: (som_blank_line) New function, renamed from blank_line(),
6667 all references changed.
6668 (som_submit) Disables drivers whose pages can't be opened.
6669 (render_columns, render_simple, render_segments) Add debug output.
6670 (render_columns) Fix loop range.
6671 (render_simple) Don't try to render the headers, they're taken
6672 care of automatically. Advance cp_y past the table when done.
6673 (render_segments) Fix loop ranges.
6675 * tab.c: Initialize new members of tab_table.
6676 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
6677 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
6678 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
6681 (tab_dim) New function.
6682 (tab_col_width) Removed.
6683 (tab_row_height) Removed.
6684 (tab_output_text) Call tab_dim().
6685 (tabi_driver) Call evaluate_dimensions(), sum_columns().
6686 (tabi_area) Implemented.
6687 (tabi_cumulate) Implemented.
6688 (tabi_render) Partially implemented, but broken.
6689 (var tab_table_class) Made static.
6690 (evaluate_dimensions) New function.
6691 (sum_columns) New function.
6693 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
6694 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
6695 t_scr, t_srr, t_sentinel. Removed: t_nat.
6696 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
6697 max_stack_height, w, h. Removed: ce, re.
6698 (macro blank_line) Removed.
6699 (glob var zero_length) Removed.
6701 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
6703 * Most source files: include some of the new include files broken
6706 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
6709 * aggregate.c: (glob var outfile) Make static.
6711 * command.c: (glob var pgm_state) Move here.
6713 * common.c: (glob vars endian, second_lowest_value, pgmname,
6714 finished, curdate, cur_proc, start_interactive, history_file) Move
6717 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
6719 * file-handle.q: (glob vars files, inline_file) Move here.
6721 * glob.c: Lost lots of glob vars, detailed in individual file
6723 (init_glob) set_printer, set_screen were obsolete, deleted.
6724 set_cprompt has fewer spaces because pspp has fewer letters than
6727 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
6728 (inp_nval) Made static.
6730 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
6731 tokstr_len, toklongstr, tokint) Move here.
6733 * misc.c: Lost several vars and functions.
6735 * set.q: (all the set_* variables) Move here.
6737 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
6738 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
6741 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
6743 * tab.h: (enum series t_*) New enums.
6744 (struct tab_table) Use arena struct tag. New members ce, re.
6746 * tokens.h: Comment fixes.
6748 * var.h: Move lots of enums and variables and functions and
6749 structures to other files. Use and declare a lot more union and
6750 struct tags. Comment fixes.
6752 * vector.c: (glob vars vec, nvec) Move here.
6754 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
6755 init_blanks, last_vfm_invocation) Move here.
6757 * cases.h: New file.
6758 (struct long_vec) Move here.
6759 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
6762 * command.h: New file.
6763 (STATE_* enums) Move here.
6764 (glob var pgm_state) Move here.
6766 * format.c: New file.
6767 (glob var formats) Move here.
6768 (parse_format_specifier_name, fmt_to_string,
6769 check_input_specifier, check_output_specifier,
6770 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
6773 * format.h: New file. Move functions now in format.c here.
6774 (FMT_* enums) Move here.
6775 (struct fmt_desc) Move here.
6776 (FCAT_* enums) Move here.
6777 (struct fmt_spec) Move here.
6778 (glob vars formats, fmt_parse_ignore_error) Move here.
6780 * inpt-pgm.h: New file.
6781 (INP_* enums) Move here, make #defines into enums.
6782 (glob vars inp_init, inp_init_size) Move here.
6785 (glob vars v_sort, nv_sort) Move here.
6786 (sort_cases, read_sort_output) Move here.
6788 * vector.h: New file.
6789 (struct vector) Move here, add struct tag.
6790 (glob vars vec, nvec) Move here.
6791 (find_vector) Move here.
6794 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
6795 reinit_blanks, init_zero, init_blanks) Move here.
6796 (struct case_stream) Move here.
6797 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
6798 vfm_disk_stream, sort_stream, data_list_source,
6799 input_program_source, file_type_source, get_source, n_lag) Move
6801 (procedure, write_case, lagged_case, compact_case, page_to_disk)
6804 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
6806 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
6807 (LDADD) Add libdcdflib.
6809 * ascii.c: Comment and formatting fixes. Almost every external
6810 function had an assert added, checking driver_open and page_open.
6811 (ascii_init_driver) Broken into ascii_preopen_driver,
6812 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
6813 (ascii_open_page) Sets page_open.
6814 (ascii_close_page) Clears page_open.
6816 * html.c: Comment and formatting fixes. Almost every external
6817 function had an assert added, checking driver_open and page_open.
6818 (html_init_driver) Broken into html_preopen_driver,
6819 html_postopen_driver, html_close_driver. Manages driver_open.
6820 (html_open_page) Sets page_open.
6821 (html_close_page) Clears page_open.
6822 (html_submit) Disabled.
6824 * lexer.c: (parse_string) Remove debugging printf.
6826 * list.q: (determine_layout) Open a page if one is not yet open.
6828 * output.c: Comment fixes.
6829 (add_class) Set the class member of the new list element.
6830 (parse_options) Don't handle device type.
6831 (colon_tokenize) New function.
6832 (configure_driver) New four-field format with a field for device
6833 type. Now initialize driver_open, page_open, next, and prev
6834 fields. Use new colon_tokenize() function. Don't do a memory
6835 copy to replace a driver, it doesn't work; instead delete the old
6836 driver and insert a new one.
6837 (destroy_driver) Don't call som_destroy_driver(). Close the page
6838 if it's open. Find the class in the list of classes and decrement
6839 that reference count. Remove the driver from the global driver
6841 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
6842 references changed. Rewritten. Don't return a driver that's not
6844 (outp_eject_page) All references to som_internal_eject_page()
6845 changed to use this. Sets cp_x to 0 as well as cp_y.
6847 * output.h: (OUTP_I_* enums) Removed.
6848 (struct som_submission_form) Removed.
6849 (struct outp_class) init_driver broken into preopen_driver,
6850 postopen_driver, and close_driver. submit changed to take a
6853 * postscript.c: Comment and formatting fixes. Almost every
6854 external function had an assert added, checking driver_open and
6856 (ps_init_driver) Broken into ps_preopen_driver,
6857 ps_postopen_driver, ps_close_driver. Manages driver_open.
6858 (ps_open_page) Sets page_open.
6859 (ps_close_page) Clears page_open.
6861 * som.c: New file, base implementation.
6863 * som.h: (struct som_table) Add struct tag.
6864 (enum SOM_COL_ACROSS) Removed.
6865 (SOM_ROWS, SOM_COLUMNS) New enums.
6866 (struct som_table_class) Add member `cumulate'. Remove `segment';
6867 change `render' arguments.
6868 (struct som_point, struct som_rect) Removed.
6869 (som_submit_table) Fixed typo, should have been som_submit.
6871 * sysfile-info: (describe_variable) Don't try to insert a
6872 subtable; just destroy it for now.
6874 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
6875 references to value labels.
6877 * tab.c: (tab_destroy) New function.
6878 (tab_columns) Change argument.
6879 [0] (tab_submit) Remove dead code.
6880 (tab_title) Allocate string from the table's arena.
6881 (tab_output_text) Only free the buffer if we allocated it.
6882 (tab_submit) New function.
6883 (static vars t, d) New static vars.
6884 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
6885 tabi_headers, tabi_cumulate, tabi_render) New functions.
6886 (glob var tab_table_class) New global var.
6888 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
6889 encapsulate the rectangle. All references changed.
6891 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
6893 * All header files updated to use struct tags in addition to
6894 typedefs for all structures. Don't use word `struct' in struct
6897 * Makefile.am: (pspp_SOURCES) Remove html.c.
6898 (INCLUDES) Replace the lib/* includes with a single lib/ include;
6899 all references updated.
6901 * command.c: (parse_cmd) Remove call to som_check_workspace.
6902 (output_line) Update to new som.
6904 * data-in.c: (parse_numeric) A single dot is not an error; it is
6905 the system-missing value.
6907 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
6910 * data-out.c: Added `const' as appropriate to many prototypes.
6911 (convert_E, convert_F, convert_CCx) Take double argument instead
6912 of value * argument.
6913 (convert_format_to_string) Call changed functions appropriately.
6914 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
6915 make a local copy of the value.
6917 * descript.q: Remove custom_variables() prototype now provided by
6919 (custom_variables) Don't increment sbc_variables, the caller does
6921 (dump_z_table, display) Update to new som.
6923 * error.c: (vmsg) Add const to prototype. Remove code to handle
6924 `too many errors' condition.
6925 (check_error_count) New function.
6926 (msg) Add const to prototype.
6928 * filename.c: (open_file) Rewrite for elegance.
6930 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
6931 (dump_full, dump_condensed, dump_statistics) Update for new som.
6933 * list.q: Don't include somP.h. Change all references to
6934 som_driver_ext to refer to the new members of som_driver. Change
6935 som_internal_eject_page() references to outp_eject_page().
6937 * main.c: (parse) Rewrite for elegance. Add call to
6938 check_error_count().
6940 * output.c: (add_class, outp_list_classes, outp_configure_driver)
6941 Rewrite or revise for new outp_driver_class_list structure.
6942 (outp_iterate_enabled_drivers) Fix comparison between disabled
6943 devices and current device type.
6944 (outp_eject_page) New function.
6946 * output.h: Comment fixes.
6947 (struct outp_driver) New members driver_open, page_open, cp_x,
6948 cp_y, font_height, prop_em_width, fixed_width. Deleted members
6950 (struct outp_driver_class_list) New struct.
6951 (outp_class_list) Changed to type outp_driver_class_list; all
6954 * print.c: (dump_table, print_trns_proc) Updated for new som.
6956 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
6957 prototypes for custom subcommands.
6958 (dump_subcommand) Always include the `else'.
6959 (dump_parser) Fix comments in output code.
6961 * set.q: Reordered functions.
6963 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
6965 * som.h: Rewritten from scratch.
6967 * str.h: Remove dead code.
6969 * tab.c, tab.h: New files, base implementation.
6971 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
6974 * t-test.q: New code from John Williams
6975 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
6976 Many many new static vars and defines.
6977 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
6978 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
6979 (struct value_list) New struct.
6980 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
6981 t_crt, t_sig, print_t_groups) New functions.
6982 (cmd_t_test) Implemented.
6984 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
6987 * vfm.c: (dump_splits) Update to new som.
6989 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
6991 * Makefile.am: (fiasco_SOURCES) Add html.c.
6993 * aggregate.c: Base source.
6995 * ascii.c: (postopen, preclose) Reformat.
6997 * data-out.c, expr-evl.c: Comment fixes.
6999 * filename.c: (open_file) When opening a file for writing, use
7000 line buffering instead of full buffering for better interactive
7001 performance. Suggested by Valerio Aimale
7002 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
7003 names `stdin', `stdout', `stderr'.
7005 * groff-font.c: Comment fixes.
7007 * html.c: New file; base version.
7009 * list.q: (write_all_headers, clean_up, determine_layout,
7010 list_cases) Ignore `special' devices for now. Needs to be fixed
7013 * output.c: (outp_init) Add html driver to list; reverse list
7016 * output.h: (struct outp_class_struct) New members `special',
7017 `submit'; comment fixes. All references changed.
7019 * postscript.c: (ps_init_driver) Make defaults for text_opt,
7020 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
7022 (postopen) Comment fix.
7023 (preclose) Comment fixes, formatting fixes. Change x->file.file
7024 references to more proper f->file.
7026 * som-high.c: (som_submit_table) Special classes use their own
7029 * som.h: Comment fixes.
7031 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
7034 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
7036 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
7038 * aggregate.c: Still working on this.
7040 * command.c: (cmd_table[]) Add AGGREGATE back in.
7041 (split_words) Make '-' a legal word separator as well as ' '.
7043 * main.c: Comment fixes.
7045 * q2c.c: (dump_parser) Don't require the procedure's full name to
7046 be present, in the generated source.
7048 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
7049 multiply specified and let it be default; let MISSING, CRITERIA,
7050 FORMAT be multiply specified.
7051 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
7052 (custom_groups) Fix defaults.
7053 (custom_pairs) Check whether this is a PAIRS subcommand before
7054 attempting to parse. Better garbage collection. Proper storage
7056 [DEBUGGING] (debug_print) New function.
7058 * temporary.c: Comment fixes.
7059 (copy_variable) Don't copy variable name and index.
7060 (save_dictionary) Copy variable name and index by hand.
7062 * vars-atr.c: Comment fixes.
7063 (create_variable) New dictionary argument. All references
7065 (common_init_stuff) New dictionary argument. All references
7067 (init_variable) New dictionary argument. All references changed.
7068 (dup_variable) New function.
7070 * vars-prs.c: (parse_variables) If there are any errors, we always
7071 return 0. Previously, it was possible for some types of errors to
7074 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
7076 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
7079 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
7081 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
7084 * q2c.c: Comment fixes.
7085 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
7087 * t-test.q: (cmd_list) Rename cmd_t_test.
7089 * temporary.c: (new_dictionary) Don't declare as static.
7091 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
7093 * aggregate.c: Changes, still not finished.
7095 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
7097 * q2c.c: Comment fixes. Now its output is internationalized.
7098 (get_token) Fix parsing of escapes within literal strings.
7099 (main) Fix bad #line directives in output.
7101 * t-test.q: Base implementation.
7103 * temporary.c: (new_dictionary) New function.
7104 (restore_dictionary) [__CHECKER__] Change fill character to *
7107 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
7109 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
7111 * aggregate.c: Changes, still not finished.
7113 * descript.q, list.q: Comment fixes.
7115 * q2c.c: Almost completely rewritten.
7117 * t-test.q: New file, not complete.
7119 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
7121 * aggregate.c: Changes, still not finished.
7123 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
7126 * temporary.c: (cancel_temporary) New function.
7128 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
7129 of doing it by hand.
7131 * vfm.c: (close_active_file) After restoring a TEMPORARY
7132 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
7134 (SPLIT_FILE_procfunc) Comment fix.
7136 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
7138 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
7140 * aggregate.c: New file, not finished yet.
7142 * command.c: (cmd_table) Add AGGREGATE.
7144 * common.h: (pgm_state) Move declaration to var.h.
7146 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
7148 (parse_string) Message fix.
7150 * recode.c: Comment fix.
7152 * sfm-read.c: (read_variables) Code esthetic fixes.
7153 (write_header) Default date is `Jan', not `JAN'.
7155 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
7157 * sort.c: (cmd_sort_cases) Farm the work out to new function
7158 parse_sort_variables().
7159 (parse_sort_variables) New function.
7160 (sort_cases) New function. Cancels temporary transformations,
7161 which sorting didn't do previously.
7162 (cmd_sort_cases) Better garbage collection on error. Uses
7164 (write_initial_runs, merge_once) Improved code esthetics.
7165 (sort_stream_read) Reduced to one call to read_output_cases().
7166 (read_output_cases) New function.
7168 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
7169 variable labels to 120 characters.
7171 * var.h: Comment fixes.
7172 (glob var pgm_state) From common.h.
7174 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
7176 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
7177 options. Set *names to NULL on error.
7179 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
7181 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
7183 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
7184 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
7186 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
7188 * vfm.c: (page_to_disk) Added missing local variables.
7190 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
7192 * get.c: Comment fix.
7194 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
7195 source is anything other than a disk stream, not just if it's in a
7196 memory stream. Call page_to_disk() before external sort.
7197 (allocate_cases) Message fix.
7199 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
7201 (page_to_disk) New function.
7203 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
7205 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
7207 * common.h: (macro strerror) Remove. From Alexandre Oliva
7208 <oliva@dcc.unicamp.br>.
7210 * get.c: (dict_delete_run) The number of variables to delete is
7211 not necessarily the number of variables that need to be shifted
7213 (trim_dictionary) Don't set *options to 0. Fix bug that caused
7214 too many variables to be deleted.
7216 * postscript.c: Comment fix.
7218 * q2c.c: Include strerror.c. From Alexandre Oliva
7219 <oliva@dcc.unicamp.br>.
7221 * set.q: #undef ON and OFF. From Alexandre Oliva
7222 <oliva@dcc.unicamp.br>.
7224 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
7225 early, otherwise errors cause a bad free().
7227 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
7228 Oliva <oliva@dcc.unicamp.br>.
7230 * temporary.c: (save_dictionary) Don't allocate memory if
7233 * vfm.c: (memory_stream_write) Message fix.
7235 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
7237 * command.c: (static var cmd_table[]) Define REPEATING DATA
7240 * common.h: Added support for broken systems that are missing
7241 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
7243 * Many source files: Replace syntax error messages via msg() with
7244 call to syntax_error().
7246 * data-list.c: (dump_fixed_table) Add support for dumping table
7247 for REPEATING DATA as well as DATA LIST FIXED.
7248 (cmd_repeating_data) Allows and requires `/' between subcommands.
7249 Does proper thing with allowing rpd.starts_end to stay 0. Allows
7250 CONTINUED specifications to be omitted. Forces CONTINUED to be
7251 specified if ID is. Calculates starts_end, cont_end from logical
7252 record length as reported by fhp. Calls dump_fixed_table() if
7253 requested. Fixed length of record copied by memcpy.
7254 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
7256 (realize_value) Returns sensible value for out-of-range variable
7258 (rpd_parse_record) New argument `ofs'. Fixed confusion between
7259 length of occurrences and length of line. Added warning for
7260 fields that exceed the line length. Fixed infinite loop.
7261 (read_one_set_of_repetitions) Numerous minor changes for more
7262 complete SPSS compliance. Message fixes.
7264 * dfm.c: (dfm_close) If the file being closed is the inline file,
7265 read all the remaining data before closing it.
7266 (dfm_get_record) Don't close the file on lossage, as either it
7267 has been closed already or it doesn't belong to us.
7269 * error.c: (puts_stdout) New function.
7270 (vmsg) Use puts_stdout instead of puts.
7272 * file-handle.q: (fh_record_width) New function.
7274 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
7277 (input_program_source_read) Made an old kluge an approved method.
7279 * lexer.c: (syntax_error) New function.
7281 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
7284 * output.c: (oupt_get_paper_size) Message fix.
7286 * q2c.c: Numerous fixes to formatting of generated code made to
7287 conform to GNU coding standards. Uses syntax_error() in generated
7288 code. Other miscellaneous generated message fixes. Added support
7289 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
7290 RAND_MAX, and/or strerror().
7292 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
7294 * data-in.c: Comment fixes.
7296 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
7297 (find_variable_input_spec) New function.
7298 (cmd_repeating_data) Initializes id_spec.
7299 (rpd_parse_record) Implemented.
7300 (read_one_set_of_repetitions) Returns -3 by default in order to
7301 kluge out some potential bugs.
7303 * data-out.c: Comment fixes.
7305 * file-type.c: (internal_cmd_record_type) Message fix.
7307 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
7308 for handling -3 return value.
7310 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
7312 * data-list.c: Comment fixes.
7313 (struct dls_var_spec) Reordered members.
7314 (read_from_data_list_fixed) Restructured.
7315 (struct repeating_data_trns) Reordered members. Renamed `starts'
7316 as `starts_beg', `ends' as `starts_end'.
7317 (cmd_repeating_data) Calculates length of repeated data if
7318 necessary and possible.
7319 (parse_num_or_var) Don't allow string variables.
7320 (realize_value) New function.
7321 (rpd_msg) New function.
7322 (rpd_parse_record) New function. Currently stubbed out.
7323 (read_one_set_of_repetitions) Implemented.
7325 * inpt-pgm.c: (input_program_source_read) Comment fix.
7327 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
7329 * command.c: (cmd_end_repeat_p) Removed.
7330 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
7331 (parse_cmd_name) Removed.
7333 * data-list.c: Comment fixes.
7334 (data_list_pgm) Removed `eof' member.
7335 (static var first) New var.
7336 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
7337 FILE TYPE file inside FILE TYPE structures.
7338 (append_var_spec) Appends to *first, not dls.spec.
7339 (parse_fixed) Message fixes.
7340 (struct rpd_num_or_var) New.
7341 (struct repeating_data_trns) New.
7342 (static var rpd) New.
7343 (cmd_repeating_data) New function.
7344 (parse_num_or_var) New function.
7345 (parse_repeating_data) New function.
7346 (read_one_set_of_repetitions) New function.
7348 * file-type.c: (cmd_file_type) Message fixes. Always
7349 default_handle to FILE TYPE file handle.
7350 (internal_cmd_record_type) Message fixes.
7352 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
7354 * repeat.c: Comment fix. Disable debugging.
7356 * temporary.c: (restore_dictionary) Sets splits to NULL and
7357 n_splits to 0 before destroying the variables because now doing
7358 this tries to remove split variables.
7360 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
7361 destroying the dictionary.
7362 (clear_variable) Removes a variable from splits after destroying
7365 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
7367 * cmdline.c: (set_compat) Removed.
7368 (pick_compat) Removed.
7369 (parse_command_line) Removed -c option.
7370 (pre_syntax_message) Removed -c option.
7371 (usage) Remove compatibility code.
7373 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
7374 (glob var compat) Removed.
7376 * compute.c: (type_check) Fixed messages about type mismatches.
7378 * data-list.c: (cmd_data_list) Removed compatibility code.
7379 (fixed_parse_compatible) Calls convert_negative_to_dash().
7380 Fixed bug where it only set the variable in fx.spec if it created
7381 the variable itself.
7382 (dump_fmt_list) Spelling fix.
7383 (cut_field) Removed compatibility code.
7385 * dfm.c: (cmd_begin_data) Don't require a command terminator on
7388 * expr-evl.c: (evaluate_expression) Implement LAG.
7390 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
7391 (parse_neg) Calls convert_negative_to_dash().
7392 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
7395 * expr.h: (struct expression_struct) Removed member max_lag.
7397 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
7398 (internal_cmd_record_type) Removed special handling to produce
7399 negative numbers from dash tokens.
7401 * getline.c: (static var DO_REPEAT_level) New var.
7402 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
7403 (handle_line_buffer) Copies the line into getl_buf; doesn't call
7404 copy_with_DO_REPEAT_substitutions().
7405 (getl_read_line) Maintains value of getl_mode. Calls
7406 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
7408 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
7410 * getline.h: (getl_mode) New glob var.
7412 * glob.c: Comment fixes.
7413 (init_glob) Restructured. Sets set_seed.
7414 (init_compat_dependent) Removed. All references removed.
7415 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
7416 (__htonl, __htons) Removed. (What were these for?)
7418 * lexer.c: (static var tbl) Dash set to class CNUM.
7419 (make_hexit) New function from data-out.c.
7420 (get_token_representation) Rewritten.
7421 (convert_negative_to_dash) New function.
7422 (lex_init_compat_dependent) Removed.
7423 (yylex) A dash is parsed as part of a number if it is followed by
7424 a digit. The ASCII representation of a number is copied to
7425 tokstr. String parsing farmed out to parse_string(). Comment
7427 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
7429 (preprocess_line) Line processing depends on interactive/batch
7430 mode, not on compatibility mode. Removed PC+ compatibility code.
7432 * loop.c: (loop_3_trns_proc) Comment fix.
7434 * main.c: Remove dead code.
7435 (main) Remove call to init_compat_dependent().
7437 * misc.c: (convert_fmt_ItoO) Make E format conversion more
7440 * print.c: (parse_string_argument) Calls
7441 convert_negative_to_dash().
7442 (fixed_parse_compatible) Calls convert_negative_to_dash().
7444 * repeat.c: (RPT_* defines) Removed.
7445 (struct rpt_numeric) Removed.
7446 (struct repeat_entry) New member type, changed `replacement' from
7448 (clean_up) Deallocation adapted to new repeat_entry.
7449 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
7450 usage. Creates vars for `type' of 1.
7451 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
7452 (store_numeric) Rewritten, new interface.
7453 (parse_numbers) Rewritten.
7454 (parse_strings) Rewritten.
7455 (find_DO_REPEAT_substitution) New function.
7456 (perform_DO_REPEAT_substitutions) New function.
7457 (copy_with_DO_REPEAT_substitutions) Removed.
7458 (debug_print) Rewritten.
7460 * set.q: Comment fix.
7461 (custom_results) Removed compatibility code.
7462 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
7465 * sysfile-info.c: (cmd_display) Removed compatibility code.
7467 * tokens.h: Comment fixes.
7468 (token types enum) Removed `toktype' typedef name for this int
7469 type. Removed SUBST. Restructured.
7471 * vars-atr.c: (discard_variables) Sets n_lag to 0.
7473 * vars-prs.c: Comment fix.
7475 * vfm.c: Comment fixes.
7476 (glob var n_lag) New var.
7477 (static vars lag_count, lag_head, lag_queue) New vars.
7478 (procedure) Removed argument nlag.
7479 (setup_lag) New function.
7480 (close_active_file) Discards lagging state.
7481 (lag_case) New function.
7482 (lagged_case) New function.
7483 (write_case) Lags a case if lagging.
7485 * weight.c: (cmd_weight) Removed compatibility code.
7487 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
7489 * getline.h: (struct getl_script) New members loop_index, macros.
7491 * getline.c: (getl_add_file) Sets first_line field to NULL.
7492 (getl_add_DO_REPEAT_file) New function.
7493 (handle_line_buffer) When the current line's length is negative,
7494 set the filename and line number. Increment line number after
7495 reading line. Pass the line to
7496 copy_with_DO_REPEAT_substitutions() for processing.
7497 (getl_close_file) Free DO REPEAT lines before freeing the
7498 filename, and just set the filename to NULL when doing this,
7499 because otherwise the filename gets freed twice.
7501 * glob.c: (glob var queuing) Removed. All references removed.
7503 * lexer.c: Comment fixes.
7504 (get_token_representation) New function.
7506 * repeat.c: Comment fixes.
7507 (struct repeat_entry) Replaced type and v union members with a
7509 (append_record) New function.
7510 (internal_cmd_do_repeat) Started reforming it for the new
7511 repeat_entry struct. Properly records filename changes in the
7512 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
7513 strncasecmp() result usage. Uses append_record() to simplify.
7514 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
7517 (copy_with_DO_REPEAT_substitutions) Started coding.
7519 [DEBUGGING] (debug_print_lines) New function.
7521 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
7523 * tokens.h: (macro is_id1, is_idn) New macros.
7525 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
7527 * cmdline.c: (static var pre_syntax_message) Changed `win'
7528 compatibility mode to `wnd'.
7530 * data-list.c: (fixed_parse_spss) Renamed
7531 fixed_parse_compatible().
7533 * glob.c: (init_glob) Excise unused code for
7534 program_invocation_short_name.
7536 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
7539 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
7541 * set.q: `win' compatibility renamed `wnd'.
7543 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
7545 * filename.c: [__WIN32__] Change the included Windows header files
7547 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
7548 second character is absolute.
7549 (dirname) Fix logic error. Don't printf() the results.
7550 (prepend_dir) Don't printf() the results.
7552 * getline.c: (handle_line_buffer) New function.
7553 (getl_read_line) Reads line with handle_line_buffer() when
7555 (getl_close_file) Discard line buffer data.
7557 * getline.h: Comment fixes.
7558 (struct getl_line_list) New struct.
7559 (getl_script_struct) Added line buffer members. These are hooks
7560 for use by DO REPEAT to allow it to insert virtual source code
7563 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
7564 Override Borland C++ stupidity that claims Windows has a console
7567 * repeat.c: This is in the process of being restructured from
7568 using a token-buffering approach to the DO REPEAT facility to
7569 using the more flexible approach of a line-buffering approach in
7570 conjunction with the getline module. Comment fixes.
7571 (struct tok_struct) Removed.
7572 (static vars queue_index, queue_head, queue) Removed.
7573 (static vars line_buf_head, line_buf_tail) New vars.
7574 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
7576 (pull_queue, destroy_queue) Removed.
7577 [DEBUGGING] (debug_print_tokens) Removed.
7579 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
7581 * file-handle.q: (prepend_current_directory) New function.
7582 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
7583 current directory before normalizing filename.
7585 * filename.c: (gnu_getcwd) New function.
7586 (absolute_filename_p) New function.
7587 (search_path) New argument, PREPEND. All references changed to
7588 pass NULL except those explicitly mentioned. Uses
7589 absolute_filename_p(). Prepends PREPEND before trying the
7591 (dirname, prepend_dir) New functions.
7593 * getline.c: (getl_get_current_directory) New function.
7594 (getl_include) Passes getl_get_current_directory() as PREPEND arg
7597 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
7599 * In several source files, the term `script' was replaced with
7600 `syntax file' inside error messages. Usage of the term `script'
7601 in the sense of a syntax file is now deprecated.
7603 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
7606 * dump-sysfile.c: (usage) Update message.
7608 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
7610 * getline.h: (glob var getl_include_path) Declare extern.
7612 * list.q: Define EXTERN as extern before #including somP.h.
7614 * var.h: Remove declaration of `disptype' variable.
7616 * vfm.c: (close_active_file) After switching the data sink to a
7617 data source, set vfm_sink to NULL, because it doesn't exist any
7620 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
7622 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
7623 _matherrl() to ignore all math errors.
7625 * sfm-read.c: (read_value_labels) When reading the labels from
7626 disk, read the little parts separately instead of as a struct;
7627 this avoids alignment problems.
7629 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
7630 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
7631 (write_header) Allocates and initializes elem_type.
7632 (sfm_write_case) Uses elem_type to determine how to handle each
7634 (sfm_close) Frees elem_type.
7636 * sfmP.h: Comment fix.
7637 [__BORLANDC__] Uses #pragma -a to adjust structure member
7640 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
7642 * Makefile.am: (fiasco_SOURCES) Remove display.c.
7644 * common.c: Fix typo.
7646 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
7647 sense of the condition.
7649 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
7650 line-continuation backslash.
7652 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
7654 * frequencies.q: (custom_grouped, add_percentile) Don't use a
7655 non-constant expression as an argument to sizeof.
7657 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
7658 undefine gettext macro because that's a conio function.
7660 * hash.h: (hsh_prime_tab declaration) Remove.
7662 * list.q: (write_fallback_headers) Move `leader' allocation out of
7663 main loop. Change to local_alloc() allocation.
7665 * output.h: Formatting fixes. Put __attribute__ in right place on
7666 function prototypes.
7668 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
7669 incorrect `SECOND_LOWEST_VALUE' references to proper
7670 `second_lowest_value'.
7672 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
7673 value. This way 2 out of 3 of the som files define the vars
7674 extern, the correct way, that actually works under BC++.
7675 (som_set_float) Don't use nonconstant initializers for a struct.
7677 * som-high.c: Add the standard alloca() header.
7678 (replicate_table) Add prototype.
7680 Merged DISPLAY routine.
7681 * sysfile-info.c: (AS_*) New enum series.
7682 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
7684 (cmd_display, display_macros, display_documents,
7685 display_variables) Stolen from defunct display.c.
7686 (describe_variable) New function.
7688 * temporary.c: [0] (display_tree) New debug function.
7689 (copy_variable) Performs shallow copy of value labels instead of
7690 deep copy; i.e., just copys the AVL tree and increments the
7693 * val-labs.c: Comment fixes.
7694 (do_value_labels) Optionally skip leading forward slash.
7695 (get_label) Creates only a single value label instead of many
7696 copies of one, and sets the reference count.
7698 * display.c: Removed.
7700 * dump-sysfile.c: New file, not yet complete.
7702 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
7704 For lots of source files I added more verbose_msg's. These aren't
7705 listed below as they have tested as being benign. In some cases
7706 these replaced debug_printf() calls.
7708 * output.c: (outp_read_devices) Message fix.
7710 * postscript.c: (output_encodings) Message fix. Reports errors on
7712 (postopen) Message fix.
7714 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
7716 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
7718 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
7721 * main.c: Remove <malloc.h> #include.
7723 * mis-val.c: (parse_numeric) Set .f member for each missing[]
7724 instead of trying to just set the missing[] itself, which is a
7727 * sfm-read.c: (read_variables) Same.
7729 * str.h: Add memmem() prototype.
7731 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
7733 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
7735 * Makefile.am: (q2c) Don't include any libraries in the link.
7737 * dfm.c: (force_line_buffer_extension) New macro.
7738 (count_tabs) New function.
7739 (tabs_To_spaces) New function.
7740 (read_record) Calls tabs_to_spaces() on the line being processed.
7742 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
7743 have to be compiled twice (once for CC, once for LOCAL_CC).
7745 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
7747 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
7748 (LDADD) Add @INTLLIBS@.
7749 (q2c) Add LIBS, @INTLLIBS@ to link step.
7751 * inpt-pgm.c: Turn off debugging.
7753 * postscript.c: (postopen) Format fix. local_free() blocks
7754 returned by local_alloc(); don't free() them.
7756 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
7758 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
7761 * data-list.c: (read_from_data_list_fixed) Pass proper value for
7762 LEN arg, not simply the full string length.
7764 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
7765 directories before generic temp file directories.
7767 * vfm.c: Disable debugging.
7769 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
7771 * get.c: Comment fix.
7772 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
7774 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
7776 * expr-prs.c: (debug_print_postfix) Conditionally included on
7777 GLOBAL_DEBUGGING. Removed out_header() reference.
7779 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
7781 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
7783 * ascii.c: Removed obsolete ascii_close_page() prototype.
7785 * command.c: (output_line) Comment fix.
7787 * data-in.c: Formatting fix.
7788 (parse_string_as_format) Now the `fc' argument is used only for
7789 the purpose of error messages; it is not an index into the string
7790 passed. All references changed.
7792 * data-list.c: Comment fix.
7793 (cut_field) Comment fix. Now returns the column number of the
7794 position of the field cut out on success.
7795 (parse_field) Added `column' argument. Puts the column numbers in
7797 (read_from_data_list_free, read_from_data_list_list) Record the
7798 column number returned by cut_field(), pass it to parse_field().
7800 * dfm.c: Comment fix.
7802 * do-ifP.h: Comment fix.
7804 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
7805 the SYSMIS function.
7807 * expr.h, exprP.h: Comment fix.
7809 * glob.c: (init_glob) Only calls setlocale() and family if
7812 * hash.h: Comment fix.
7814 * include.c: Comment fix.
7816 * output.c: Comment fix.
7818 * postscript.c: (ps_line_intersection) Simplified assertion.
7820 * repeat.c: Comment fix.
7822 * vars-atr.c: Comment fix.
7824 * vars-prs.c: Comment fix.
7826 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
7827 behavior with usage of postincrement.
7828 (memory_stream_read) Discards cases as it goes.
7830 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
7832 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
7835 * Most source files: Includes debug-print.h, related comment
7838 * cases.c: (alloc_val) Removed complex allocation code. Merely
7839 increments default_dict.nval and returns the former value.
7840 (envector, devector) Removed references to lv member of struct
7843 * common.h: (macro VME) Replaced complex definition with simple
7846 * data-list.c: (cmd_data_list) Sets vfm_source instead of
7847 read_active_file and cancel_input_pgm.
7848 (read_from_data_list, cancel_data_list) Removed.
7849 (data_list_source_read, data_list_source_destroy_source) New
7851 (glob var data_list_source) New var.
7853 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
7854 (cmd_begin_data) Improved criteria for an input program accessing
7855 the inline file. Still not perfect.
7857 * do-if.c: (do_if_trns_proc) Simplified debug output.
7859 * expr-prs.c: Comment fixes.
7860 [DEBUGGING] (debug_print_postfix) Simplified debug output.
7862 * file-handle.q: (fh_close_handle) Simplified debug output.
7864 * file-type.c: Comment fixes.
7865 (cmd_file_type) Sets vfm_source instead of read_active_file and
7867 (cmd_end_file_type) On failure, discards variables in place of
7868 just canceling the input program.
7869 (read_from_file_type) Renamed file_type_source_read.
7870 (cancel_file_type) Renamed file_type_source_destroy_source.
7871 (glob var file_type_source) New var.
7873 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
7874 (cmd_get) Initializes options to GTSV_NONE before passing to
7875 trim_dictionary(). Removed `lv' reference. Sets vfm_source
7876 instead of read_active_file and cancel_input_pgm.
7877 (cmd_save_internal) Initializes options before passing to
7878 trim_dictionary(). Local var `nval' removed.
7879 (dict_delete_run) Comment fixes.
7880 (trim_dictionary) Comment fixes. Disallows scratch variables if
7881 GTSV_OPT_SAVE set in options.
7882 (read_from_get) Renamed get_source_read.
7883 (cancel_get) Renamed get_source_destroy_source.
7884 (glob var get_source) New var.
7886 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
7887 read_active_file and cancel_input_pgm.
7888 (read_from_input_program) Renamed input_program_source_read.
7889 Simplified debug output.
7890 (cancel_input_program) Renamed
7891 input_program_source_destroy_source.
7892 (glob var input_program_source) New var.
7894 * loop.c: (loop_1_trns_proc) Simplified debug output.
7896 * main.c: (dump_token) Made eof output more explicit.
7898 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
7901 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
7902 code for always-memory or always-disk cases. malloc's case-list
7903 based on vfm_source_info.ncases. Explicit support for
7904 memory_stream via memory_source_cases.
7905 (do_external_sort) Sets vfm_source instead of read_active_file and
7907 (allocate_file_handles) The temporary directory permissions are
7908 set to 0700 instead of 0777.
7909 (allocate_cases) Formatting fixes. Simplified debug output.
7910 (output_record) Compacts the case if necessary before writing it
7912 (close_handle, open_handle_w) Simplified debug output.
7913 (write_initial_runs) Destroys vfm_sink, then sets it to
7914 sort_stream. Writes records to memory based on
7915 vfm_sink_info.case_size.
7916 (write_to_sort_cases) Renamed sort_stream_write().
7917 (merge) Simplified error handling. Simplified debug output.
7919 (read_from_external_sort) Renamed sort_stream_read().
7920 Reads records based on vfm_source_info.case_size.
7921 (sort_stream_write) Writes records to memory based on
7922 vfm_sink_info.case_size.
7923 (sort_stream_mode) New function.
7924 (glob var sort_stream) New variable.
7926 * temporary.c: (cmd_temporary) Simplified debug output.
7927 (copy_variable) Removed references to `lv'.
7929 * title.c: (get_title) Simplified debug output.
7931 * var.h: Comment fixes.
7932 (struct get_proc) Removed member `lv'.
7933 (struct variable) Removed member `lv'. Comment fixes.
7934 (glob vars read_active_file, write_active_file, cancel_input_pgm)
7936 (struct case_stream) New.
7938 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
7939 read_active_file references to use vfm_source.
7940 (init_variable, replace_variable) Removed references to `lv'.
7942 * vfm.c: Comment fixes.
7943 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
7945 (static var queue, qh, qt, n_lag) Removed. All references
7947 (glob var compaction_necessary, compaction_nval, compaction_case,
7948 paging) New variables.
7949 (record_case) Removed.
7950 (procedure) Comment fixes. Calls vfm_source->read() instead of
7953 (prepare_for_writing, arrange_compaction, make_temp_case,
7954 vector_initialization, setup_filter) New function.
7955 (open_active_file) Most of the code moved into the abovementioned
7956 new functions. Now sets temp_dict to &default_dict if there is no
7957 temporary dictionary, for convenience. New debug output.
7958 (close_active_file) Deals with changing the sink to the source.
7959 Calls finish_compaction(). Frees compaction_case. Mostly
7961 (glob vars disk_source_file, disk_sink_file) New vars.
7962 (destroy_active_file, read_from_memory) Removed.
7963 (disk_stream_init, disk_stream_read, disk_stream_write,
7964 disk_stream_mode, disk_stream_destroy_source,
7965 disk_stream_destroy_sink) New functions.
7966 (glob var vfm_disk_stream) New var.
7967 (glob vars memory_source_cases, memory_sink_cases,
7968 memory_sink_iter, memory_sink_max_cases) New vars.
7969 (memory_stream_init, memory_stream_read, memory_stream_write,
7970 memory_stream_mode, memory_stream_destroy_source,
7971 memory_stream_destroy_sink) New functions.
7972 (glob var vfm_memory_stream) New var.
7973 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
7974 named `more_cases'. Simplified debug output. Otherwise mostly
7976 (record_case) Moved into the stream drivers. Removed.
7977 (transform) Removed (was dead code).
7978 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
7979 common case that the splits don't change, we don't need to copy
7980 the case into prev_case again--pointless.
7981 (compact_case) New function.
7982 (finish_compaction) New function.
7984 * vfmP.h: Comment fixes.
7985 (DEV_* enum series) Removed.
7986 (struct storage) Renamed `stream_info'. Removed variant record.
7987 Removed `device' member.
7989 * debug-print.h: New file.
7991 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
7993 * autorecode.c: Turned off debugging.
7995 * data-list.c: (destroy_dls) Closes the associated file handle.
7997 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
7998 parse_variables() options.
8000 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
8002 * display.c: (display_variables) Really fixed null cell bug.
8004 * file-handle.q: (fh_close_handle) Changed debugging message.
8006 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
8007 parse_variables() options.
8009 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
8010 (cmd_list) Fails if no variables specified.
8011 (determine_layout) Writes blank lines manually.
8013 * loop.c: (loop_1_trns_proc) Made debugging code only print
8014 messages if debugging.
8016 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
8017 parse_variables() arguments.
8018 (main) Parses optional parenthesized options to varlist
8019 subcommands into sbc->message.
8021 * sfm-read.c: Format fix.
8023 * var.h: (FV_*) New enum series.
8024 (PV_*) New enum PV_NO_SCRATCH.
8026 * vars-prs.c: (find_var) Removed.
8027 (fill_all_vars) Takes FV_* enum instead of boolean third
8028 argument. Rewritten to deal with scratch as well as system
8030 (parse_variables) Error message on scratch variable if
8033 * vfm.c: (static var virt_begin_func) New var.
8034 (procedure) Sets up virt_begin_func.
8035 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
8036 after dump_splits(). For succeeding groups changes, calls
8037 virt_begin_func() instead of begin_func().
8039 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
8041 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
8044 * dfm.c: Added some debugging messages, disabled by default.
8045 (open_file_r) Fixed error message.
8046 (read_record) On eof on inline_file, instead of calling
8047 fh_close_handle(), simply jump to eof label like a normal file.
8050 * display.c: Thin lines between rows for certain kinds of
8051 listing. Fixed `null cell' bug.
8053 * error.c: (failure) Flush stdout, stderr before failing.
8055 * file-handle.q: (fh_close_handle) Added debugging message.
8057 * frequencies.q: (dump_full) Bottom line extends across entire
8058 table width. Changed title formatting.
8059 (dump_condensed) Changed title formatting.
8060 (dump_statistics) Fixed title formatting.
8062 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
8063 Sets default value of set_format.
8065 * list.q: (cmd_list) Calls blank_line() before determine_layout().
8066 Passes write_all_headers() to procedure() as pre-group func.
8067 (write_all_headers) New function.
8068 (determine_layout) Removed calls to write_header().
8069 Calls blank_line() before and after write_fallback_headers().
8071 * recode.c: (recode_trns_free) Only attempts to free head->map if
8074 * sfm-read.c: (read_variables) Allows `#' at beginning of system
8075 file variable names but gives a warning. Sets `left' based on
8076 first character being/not being `#'. On lossage frees dict->var.
8078 * som-high.c: (som_draw_title) Simplified title formatting.
8080 * vfm.c: (dump_splits) Fixed and changed splits formatting.
8082 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
8084 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
8085 beginning. Frees v_src, v_dest on successful exit. Frees
8086 h_trans[*], h_trans on lossage.
8087 (recode) Frees h_trans[*], h_trans.
8089 * dfm.c: (dfm_close) Formatting change.
8090 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
8091 longer allocates its own in inline_file.
8092 (open_file_r) Passes the local dfm_fhuser_ext to
8094 (open_file_w) Message fix.
8095 (read_record) Buffer reallocation strategy changed. Frees
8096 ext->line even in inline_file to prevent leaks.
8097 (dfm_put_record) Fixed bug where `ext' was cached before the file
8098 was opened and thus it would be NULL when the file really was
8100 (cmd_begin_data) Sets up inline_file basics itself, then calls
8101 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
8103 * list.q: (write_line) Formatting fix.
8104 (clean_up) Minor strategy change. Sets proportional font after
8106 (determine_layout) Sets fixed font before writing regular headers,
8107 or after writing fallback headers.
8109 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
8110 and KEEP vars after using them.
8112 * postscript.c: (ps_init_driver) Frees x->family.
8113 (postopen) When loading fonts, free the temporary font name buffer
8115 (ps_text_set_font_by_position) Free temporary font name buffer
8117 (text) Fixed code that calculated `lig' so that `lig' always gets
8118 initialized. Formatting fix.
8120 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
8122 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
8123 cells, not xmalloc(), so that the cells will get destroyed
8126 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
8129 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
8131 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
8134 * dfm.c: Comment fix.
8136 * list.q: Comment fixes. Include somP.h. Removed static vars
8137 table, n_columns, n_rows, part. New struct list_ext. New static
8139 (n_lines_remaining, n_chars_width, write_line) New functions.
8140 (cmd_list, list_cases) Rewritten.
8141 (begin_row, end_row, flush_table) Removed.
8142 (write_header, clean_up, write_varname, write_fallback_headers,
8143 determine_layout) New functions.
8145 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
8147 * output.h: Comment fix.
8149 * postscript.c: Comment fix.
8150 (struct ps_driver_ext) Removed prop_size, fixed_size members;
8151 added font_size. All references changed.
8152 (ps_init_driver) Initializes font_size. Simplified space checking
8154 (static var option_tab[]) Removed prop-size, fixed-size; added
8156 (ps_option) Handles font_size.
8158 * som-high.c: Moved prototypes into somP.h.
8159 (som_init_driver) New function.
8160 (som_submit_table) Moved some code into new function
8162 (build_target) Moved some code into new function
8163 som_internal_eject_page().
8164 (som_eject_page) Uses som_internal_eject_page().
8165 (som_internal_eject_page) New function.
8167 * som-low.c: Moved prototypes into somP.h.
8169 * som.h: Formatting fixes.
8171 * somP.h: (struct som_driver_ext) Removed em_width;
8172 added prop_em_width, fixed_width.
8174 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
8176 * Makefile.am: Added `localedir' definition. Added
8177 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
8179 * ascii.c: (macro draw_line) Fixed capitalization.
8181 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
8182 compute.c, count.c, data-in.c, data-list.c, data-out.c,
8183 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
8184 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
8185 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
8186 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
8187 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
8188 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
8189 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
8190 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
8191 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
8192 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
8193 for internationlization.
8195 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
8197 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
8199 * do-if.c, sort.c, val-labs.c: Comment fixes.
8201 * glob.c: (init_glob) Uncommented, updated i18n support.
8203 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
8204 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
8205 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
8206 the declarations of macros taking arguments a lot nicer.
8208 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
8210 * error.h: Removed CE, CW aliases for SE, SW.
8212 * q2c.c: Removed explicit streq() definition since it's duplicated
8215 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
8216 stats.h, str.h, tokens.h: Made the declarations of macros taking
8217 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
8220 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
8222 * cmdline.c: Comment fixes.
8223 (pick_compat) Changed return type to int. Now, instead of setting
8224 glob var `compat' to the emulation, returns the emulation. All
8226 (parse_command_line) Added terminating null to end of
8227 `long_options' array definition.
8228 (pre_syntax_message) Fixes.
8229 (usage) Shows the default emulation in the syntax message by
8230 calling pick_compat().
8232 * getline.c: (getl_add_include_dir) Separates paths with
8233 PATH_DELIMITER, not DIR_SEPARATOR.
8235 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
8236 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
8238 * output.c: (outp_configure_macro) Make earlier definitions for a
8239 particular key override later ones for the same key.
8241 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
8243 * ascii.c: Comment fixes.
8245 * output.c: (outp_get_paper_size)
8246 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
8248 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
8250 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
8251 <errno.h>. GNU libc 2 enforces this!
8253 * command.c: (parse_cmd) Fixed problem with `else' clause being
8254 paired with wrong `if'. Comment fix.
8256 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
8258 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
8259 blp_getline() to getline().
8261 * output.c: (outp_eval_dimension) Changed the fix from last time;
8262 there was no variable `a'.
8264 * q2c.c: (get_line) Fixed boundary condition overrun bug.
8266 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
8268 * output.c: (outp_evaluate_dimension) Fixed handling of negative
8269 numbers having fractional parts. Added case of a fraction without
8270 a whole-number part.
8272 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
8274 * ascii.c: (ascii_text_get_font_position) Removed.
8276 * expr.h, exprP.h: Disabled debugging.
8278 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
8281 * output.h: (struct outp_class_struct) Removed
8282 text_get_font_position method. All references deleted.
8284 * postscript.c: Big change here. Fontmaps were completely
8285 eliminated because of a change in philosophy. Comment fixes.
8286 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
8288 (struct ps_driver_ext) `position', `fontmap', `prop_name',
8289 `fixed_name' members removed. New members `prop_family',
8290 `fixed_family'. `family' member changed to type char *.
8291 (static var ps_fontmaps) Removed.
8293 (ps_init_driver) Removed obsolete references, updated.
8294 Initializes `translate_x', `translate_y', `scale'. Doesn't read
8295 fontmap, of course. Refers to font names through internal_name
8296 rather than subversive means. Frees proper items.
8297 (static var option_tab[]) Removed `fontmap-file' option; renamed
8298 `fixed-font', `prop-font'.
8299 (ps_option) Corresponds to option_tab[].
8300 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
8301 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
8302 hash_family) Removed.
8303 (postopen) Generates font names from family names. Gets
8304 PostScript font name properly. New prologue file comment `!!!'
8306 (ps_open_page) Adds translate_x, translate_y to BP prologue
8307 function; gives SF argument floating-point format.
8308 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
8309 font name. Doesn't change font family.
8310 (ps_text_set_font_by_position) Generates Groff font name from font
8311 family name instead of through table lookup.
8312 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
8313 all references changed. Reduced to simple string assignment.
8314 (ps_get_font_name) Removed.
8315 (ps_get_font_family) Reduced to string return.
8316 (text) Doesn't save `position' since it no longer exists. Ugly
8317 kluge to save font family--fix soon?
8318 (load_font) Removed PostScript name argument.
8320 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
8322 * postscript.c: Comment fix.
8323 (ps_open_page) Puts scale factor in PostScript output.
8325 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
8327 * Makefile.am: Distcleans q2c.
8329 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
8331 * ascii.c: (delineate) Sets text size even if width is zero.
8333 * command.c: Comment fix.
8334 (static var cmd_table[]) Re-enabled EVALUATE command.
8335 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
8336 of comments in script files. Now more liberal on criteria for
8337 performing a state transition--if *anything* happened correctly,
8338 not just if *everything* happened correctly.
8340 * data-out.c: (convert_F) Comment fix. Why in the fsck does
8341 Checker segfault on formatting large numbers and why in the fsck
8342 hadn't I noticed this before?
8344 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
8346 * list.q: (cmd_list) Commented out the actual output routine
8347 because of various problems. Probably will abandon the idea of
8348 using the general `crushed tables' for the LIST procedure.
8350 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
8351 clearing it. Allocates a new var_by_name dictionary before trying
8352 to add members to it.
8354 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
8355 `sib'. Changed type of `node' argument.
8356 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
8358 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
8359 [DEBUGGING] Only deletes the variable from var_by_name if that var
8362 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
8364 * Makefile.am: Added include files to SOURCES. Added
8365 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
8366 includes rules for q2c. Added `boast' target.
8368 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
8370 * Makefile.am: Maintainer-clean Makefile.in.
8372 * Makefile.am: Fixed redundant EXTRA_DIST line.
8374 * ascii.c: Comment fixes.
8375 (ascii_line_vert) Fixed overly aggressive range check.
8377 * display.c: Removed dead code.
8379 * list.q: Turn debugging on.
8380 (flush_table) New debug code.
8382 * sfm-read.c: (read_value_labels) malloc's the structure before
8383 trying to assign to its members.
8385 * sfm-write.c: Comment fix.
8387 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
8389 (output_table) No arguments anymore--gets them through `som'
8390 global. New debug code. In crushed tables, now sets `htv' as
8391 well as `hv' to avoid bad confusion later.
8392 (dump_crush_page) New debug code.
8394 * som-low.c: (som_dump_crush_page) New debug code.
8396 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
8398 All source files: Broke long lines into multiple lines.
8400 * ascii.c: (ascii_close_page) Uses host_system var in place of
8401 HOST_SYSTEM constant.
8403 * cmdline.c: (var syntax_message[]) Broke into
8404 pre_syntax_message[] and post_syntax_message[].
8405 (usage) Outputs both parts, separated by driver list.
8407 * error.h: Fixed broken formatting.
8409 * expr-opt.c: (str_search, str_rsearch) New functions.
8411 * misc.c: (blp_getdelim) Removed. All references changed to
8413 (str_search, str_rsearch) Removed.
8414 (memrmem) New function.
8416 * misc.h: (blp_getline) Removed. All reference changed to
8421 * filename.c: Includes "stat.h", not <sys/stat.h>.
8422 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
8424 * output.c: (outp_list_classes) Changed output formatting.
8426 * sfm-write.c: (write_header) Uses host_system var instead of
8427 HOST_SYSTEM constant.
8428 (write_rec_7_34) Extracts version numbers from the version string.
8431 * sort.c: Includes "stat.h", not <sys/stat.h>.
8433 * str.c: (strcasecmp) Removed.
8435 * title.c: (cmd_document) Uses host_system var instead of
8436 HOST_SYSTEM constant.
8438 * version.c: Generated on-the-fly by the Makefile instead of being
8441 * str.h: Comment fixes. Doesn't substitute for missing memmove or
8443 [!HAVE_STRNCASECMP] Declares strncasecmp().
8445 * version.h: Removed stray character. Comment fixes.
8446 (vars host_system, build_system) New vars.
8448 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
8450 * Most source files: Changed formatting of copyright notice; fixed
8451 FSF address; reformatted to better conform to GNU standards;
8452 comment fixes. Added markups to prevent GNU indent from messing
8453 up my beautiful formatting :-).
8455 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
8456 that GNU indent markups can be passed through without problems.
8458 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
8460 * get.c: Turned off debugging.
8462 * glob.c: (init_glob) Turned on save-file compression by default.
8464 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
8465 compression than was possible in save files.
8467 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
8469 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
8471 * frequencies.q: Removed Fiasco extensions. Updated calculation
8472 algorithms. Polished output format.
8473 (struct frq_info_struct) Removed members `max_degree', `min_n',
8474 all references removed.
8475 (macro frq_extensions) Removed.
8476 (static vars min_n, max_degree) Removed, all references removed.
8477 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
8478 calculate `min_n', `max_degree'.
8479 (postcalc) Passes new arg to dump_statistics().
8480 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
8482 (dump_condensed) Adds variable name title.
8483 (sum_freqs) Removed.
8484 (calc_stats) Updated calculation algorithm.
8485 (dump_statistics) Removed warning for too-few observations.
8486 Changed table formatting. Adds variable name title if passed new
8489 * output.h: Comment fix.
8491 * recode.c, sample.c, sort.c: Disabled debug code.
8493 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
8494 Improved debug code.
8496 * var.h: (enum series frq_*) Removed Fiasco extensions.
8498 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
8500 * command.c: Added PROCESS IF to command table.
8502 * Lots & lots of places, removed checks for NULLs preceding calls
8503 to free_expression(), which itself checks.
8505 * descript.q: Removed Fiasco extensions. Removed optimizations
8506 for non-weighted active files. Implemented some options.
8507 Finished polishing output format. Comment fixes. Merged
8509 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
8510 max_degree, min_n) Removed.
8511 (macro dsc_extensions) Removed.
8512 (struct dsc_info_struct) Removed `min_n' member, all references
8514 (internal_cmd_descriptives) Removed calculation of min_n,
8515 max_degree. Only deals with one `calc' routine instead of two
8517 (precalc) Eliminated redundancy. Updated for changes to
8518 descriptives_proc structure.
8519 (calc) Moved here from `descript.g'. Rewritten to calculate
8520 statistics via `moments about the mean' rather than by summing,
8521 summing squares, summing cubes, and so on.
8522 (postcalc) Rewritten for new-style statistical calculation.
8523 (display) Removed support for displaying variables across rows.
8524 No longer crushes the descriptives table. Removed ancient code.
8525 Added display of N, by variable and listwise.
8527 * descript.g: Removed; merged into `descript.q'.
8529 * expr-evl.c: (evaluate_expression) Now returns a double. For
8530 numeric results, it returns the result as well as storing it in
8531 the passed `value' structure if non-NULL. For string results it
8532 just returns 0.0 and it must be passed non-NULL. Many references
8533 to this function were optimized by use of this change, especially
8534 but not exclusively in `compute.c'.
8536 * frequencies.g: Comment fix.
8538 * glob.c: (glob var process_if_expr) New global var.
8540 * postscript.c: (static var option_tab[]) Corrected entry for
8542 (postopen) Sets x->size to x->prop_size.
8543 (ps_text_set_font_by_name) Sets font size as well as typeface for
8544 PROP and FIXED fonts.
8546 * sel-if.c: (cmd_process_if) New function.
8548 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
8549 (sfm_write_dictionary) Sets `n_cases' to 0.
8550 (sfm_write_case) Increments `n_cases'.
8551 (sfm_close) Attempts to seek the system file back to the header
8552 and write the number of cases in its proper slot.
8554 * som-frnt.c: (som_insert_table) Masks off expansion options since
8555 only SOPT_X_NORM seems to work sensibly.
8557 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
8558 with a `fixed' value of 2.
8560 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
8562 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
8563 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
8565 * var.h: (enum series dsc_*) Removed Fiasco extensions.
8566 (struct descriptives_proc) Removed `miss_noweight'; new members
8567 `X_bar', `M2', `M3', `M4', `min', `max'.
8569 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
8571 * vfm.c: (close_active_file) Cancels PROCESS IF.
8572 (write_case) Doesn't process cases unselected by PROCESS IF.
8574 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
8576 * glob.c: (glob var err) Removed.
8578 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
8579 doesn't have to take into account number of value labels since
8580 they're in a subtable anyway. Also, doesn't display more than 10
8581 value labels since we can't yet break pages in subtables.
8583 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
8585 * som-frnt.c: (som_change_table_size) Simple change for elegance
8586 that shouldn't change behavior.
8587 (som_set_value) Comment fix.
8589 * som-high.c: (som_submit_table) Message fix.
8591 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
8593 * command.c: Added SYSFILE INFO to command table.
8595 * file-handle.q: (fh_handle_filename) New function.
8597 * get.c: (save_trns_proc) Fixed a bug in padding of output data
8600 * main.c: (parse) New return value for command functions, -3.
8602 * misc.h: Comment fix.
8604 * output.h: Comment fixes.
8605 (macro COMPONENTS) Removed.
8607 * postscript.c: (write_text) Modified literal_chars[] so that `('
8608 and ')' are not written to the output in strings as literals.
8610 * sfm-read.c: (sfm_read_dictionary) New argument.
8611 (read_header) New argument. Sets the information structure's
8612 values from the header information.
8613 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
8614 bizarre Checker problem, I guess.
8615 (read_variables) Proper cleanup on lossage.
8617 * sfm.h: (struct sfm_read_info) New struct for use by
8618 sfm_read_dictionary().
8620 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
8621 currently used just for tables that can be dynamically resized and
8622 thus have to be allocated with arena_malloc() instead of
8623 arena_alloc(). All references changed.
8624 (som_change_table_size) New function.
8625 (som_insert_table) Bugfix: now inserts `cell', not `c'!
8627 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
8628 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
8631 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
8633 (draw_intersection) Now takes an argument specifying the table in
8634 question. All references changed.
8635 (draw_table_cell) New function.
8636 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
8637 (som_get_table_size) Many nice new explanatory comments.
8638 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
8640 * som.h: New enum series SOM_CREATE_* for use as create flags with
8643 * str.h: Moved a comment here from TODO.
8645 * sysfile-info.c: New file. Reference implementation.
8647 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
8649 * command.c: Added RENAME VARIABLES to table of commands.
8651 * data-in.c: (dls_error) Sets `cust_field'.
8652 (parse_N) Message fix.
8653 (parse_day_count) New function.
8654 (to_roman) Never outputs VX as a `short form' of V.
8655 (parse_month) Fixed parsing of Roman numerals.
8656 (parse_trailer) Message fix.
8657 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
8658 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
8659 the date is invalid.
8660 (parse_SDATE) Fixed swapped day, year.
8661 (parse_JDATE) Fixed bug for dates in 1582.
8662 (parse_DTIME) Allows days not between 1 and 31.
8663 (parse_numeric) Makes local copy of f.type for easier usage.
8666 * data-out.c: (convert_F) When outputting as scientific, properly
8667 sets f.type as fp->type.
8668 (insert_commas) Fixed operator precedence problem with setting of
8669 nitems. Changed strcpy to memcpy (no null terminator).
8670 (convert_date) Fixed FMT_JDATE: added 1900 to year.
8671 (convert_CCx) Essentially rewritten, but now it works.
8673 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
8675 (display_documents) Implemented.
8677 * error.c: (glob var cust_field) New var.
8678 (vmsg) Displays cust_field as part of message classes DE and DW.
8680 * formats.c: (debug_print) Fixed to compile under updated
8683 * get.c: (cmd_get, cmd_save_internal) Close file handle on
8686 * misc.c: (parse_format_specifier) Formatting fix.
8688 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
8689 `n_rename' for clarity.
8690 (cmd_modify_vars) Initializes `forward' and `positional' at
8691 appropriate times. Frees lists of vars to rename on failure.
8692 Comment fix. Frees memory on success.
8693 (rearrange_dict) Simplified `for' loop condition.
8695 * rename-vars.c: New file (reference implementation).
8697 * set.q: (internal_cmd_set) Fixed `emu' test condition.
8699 * sfm-read.c: (read_header) File label is created only if file
8700 label in file is not blank.
8701 (read_variables) Initializes `dict' local variable.
8702 (read_documents) Proper behavior on lossage.
8704 * sfm-write.c: (write_header) Doesn't blank out the file label
8705 (why was this here to begin with?!)
8707 * temporary.c: (save_dictionary) File label is copied only if
8708 non-NULL. Doesn't try to xstrdup() dictionary documents.
8709 Adapted so as to not irritate Checker.
8710 (free_dictionary) Only destroys var_by_name if non-NULL.
8712 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
8713 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
8714 lines to the document, indents the document. Also, it works now.
8715 (add_document_line) New function.
8717 * var.h: (struct dictionary) Reordering.
8719 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
8720 bits if it was allocated to begin with.
8722 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
8724 * command.c: Added MODIFY VARS to list of commands.
8726 * configure.in: Updated custom macros for autoconf 2.12. Removed
8727 mmap reference; fixed termcap library reference.
8729 * display.c: (display_variables) Fixed a few bugs although it's
8730 still not well written.
8732 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
8733 (induce_segfault) Calls chkr_disp_call_chain() instead of
8734 inducing an actual SIGSEGV.
8736 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
8737 str_search() and str_rsearch(). Fixed tests for matches on
8738 OP_INDEX and OP_RINDEX.
8740 * filename.c: (good_getcwd) Removed as the new libc for Checker
8741 doesn't contain this bug, apparently.
8743 * misc.c: (str_search, str_rsearch) Changed order of arguments for
8744 consistency with GNU memmem.
8745 (blp_getdelim) Changed `len' from `int' to `size_t'.
8747 * modify-vars.c: Reference implementation.
8749 * som-frnt.c: (zero_length) New global var.
8750 (som_create_table) Message fix.
8752 * som.h: Added gcc attributions to som_set_text(),
8753 som_output_text() prototypes. blank_line() refers to
8754 zero_length[] instead of a literal null string to suppress gcc
8757 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
8758 (allocate_cases) Decrements x_max so the last element of x[] can
8759 be used by the algorithm.
8761 * var.h: Changed minor details of `variable' declaration.
8762 (struct modify_vars_proc) New struct.
8763 (struct variable) Added field p.mfv.
8765 * vars-atr.c: Comment fix.
8767 * vars-prs.c: (fill_all_vars) More optimal implementation.
8769 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
8770 character, which it shouldn't have to do but printf() seems to
8771 read the null byte even though I supply a maximum length...
8773 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
8775 * command.c: Removed command alias X for QUIT.
8776 (parse_cmd) Fixed comment parsing.
8778 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
8780 (read_record) Fixed references to len, size.
8781 (dfm_get_record) Restructured.
8783 * file-handle.h: (struct file_handle) Field `lrecl' now of type
8786 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
8789 * modify-vars.c: New file. Not complete.
8791 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
8794 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
8795 problems caused by int/size_t differences.
8797 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
8800 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
8801 being compared were of equal length.
8803 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
8805 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
8807 * lexer.c: (get_dotted_rest_of_line) New function.
8809 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
8812 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
8813 type 6 records. Frees the dictionary properly.
8814 (read_header) Initializes the dictionary instead of letting
8815 read_variables() do it. Sets the dictionary file label from the
8817 (read_documents) New function.
8819 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
8820 write type 6 record if appropriate.
8821 (write_header) Writes file label from dictionary.
8822 (write_documents) New function.
8824 * temporary.c: (save_dictionary, restore_dictionary,
8825 free_dictionary) Properly handle new fields in dictionary struct.
8827 * title.c: (get_title) Returns after failure().
8828 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
8829 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
8831 * var.h: (struct dictionary) New fields `label', `n_documents',
8834 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
8836 * command.c: Added FILTER to list of commands.
8838 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
8841 * get.c: (cmd_save_internal) Removed weighting code since it's now
8842 handled by sfm-write.c. Properly commented out debug code.
8844 * glob.c: (glob var weighting) Removed.
8846 * sel-if.c: Comment fixes.
8847 (cmd_filter) New function.
8849 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
8850 (sfm_read_dictionary) Sets weighting variable direct in the
8851 created dictionary now. (Apparently we previously didn't support
8853 (read_header) Sets weight_index field in sfm_fhuser_ext from
8854 header read from disk.
8856 * sfm-write.c: (sfm_write_dictionary) Comment fix.
8857 (write_header) Now sets the weighting in the header from the
8858 passed primary dictionary instead of from the sfm_write_info.
8860 * sfm.h: (struct sfm_write_info) Removed field `weight'.
8862 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
8863 broke on boundary conditions.
8865 * var.h: (struct dictionary) New fields `weight_var',
8866 `weight_index', and `filter_var'.
8867 (glob var weighting) Removed. This is now part of struct
8868 dictionary. All references changed; the less mechanical changes
8869 are described above.
8871 * vars-atr.c: (find_dict_variable) New function.
8873 * vfm.c: (static var filter_index) New variable.
8874 (open_active_file) Initializes filter_index from default_dict.
8875 (write_case) Calls proc_func() only if the filter variable is
8876 nonzero; this implements FILTER behavior.
8878 * weight.c: (static var weight_varname) Removed.
8879 (cmd_weight) Modified default_dict instead of glob vars.
8880 (update_weighting) Changed the signature to modify a dictionary
8881 instead of glob vars. Now returns the weighting variable.
8882 (get_weighting_variable) Removed; its function is absorbed by
8884 (stop_weighting) Operates on a dictionary now.
8886 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
8888 * sort.c: Removed debugging info from messages.
8889 (do_external_sort) Cleans up after itself by deleting the
8890 temporary directory on failure. (On success it is deleted by the
8892 (allocate_cases) Removed debug code. Added clean up code.
8893 (output_record) Removed debug code.
8894 (merge) Added code to close all the input files that are currently
8895 open. This is a likely location for bugs, because I'm not sure
8896 about boundary conditions. Removed an unnecesary heap_delete().
8897 (merge_once) Removed input file "optimization" that in fact
8898 screwed up the rest of the code. Message and comment fixes.
8900 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
8902 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
8904 * heap.c: (heap_delete) New argument.
8906 * sort.c: Finished implementation of external sort.
8908 * vfm.c: (read_from_disk) Returns after a disk error.
8910 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
8912 * sort.c: (static var state) Removed.
8913 (static vars max_handles, tmp_basename, tmp_extname,
8914 huffman_queue) New variables.
8915 (do_external_sort) Moved most code to new functions.
8916 Creates huffman_queue.
8917 (allocate_file_handles, allocate_cases) New functions.
8918 (static vars run_no, run_length, file_index, case_count) New
8920 (output_record) Returns success. Now really writes to the output
8922 (begin_run, end_run) New functions.
8923 (write_initial_runs) Returns success. Initializes run_no to -1.
8924 Calls begin_run(), end_run() at appropriate times. Outputs debug
8926 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
8928 (merge) New function.
8930 * heap.c, heap.h: New files. Hopefully in near-final form.
8932 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
8934 * glob.c: Added write_active_file to global vars.
8936 * sort.c: Several new miscellaneous static variables.
8937 (cmd_sort_cases) Big comment fix.
8938 (perform_case_2) Renamed `do_external_sort' and completely
8940 (case_2_proc_func) Removed.
8941 (output_record, write_initial_runs, write_to_sort_cases,
8942 compare_record) New functions.
8944 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
8946 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
8948 * sort.c: (perform_case_2) Changed the method for allocation of
8949 lots of memory--now allocates one case at a time in hopes that
8950 more cases can be allocated with heavily fragmented memory.
8952 * var.h: (write_active_file) New global var.
8954 * vfm.c: (procedure, close_active_file, write_case,
8955 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
8956 arguments to procedure() to be NULL. All references to
8957 procedure() that made use of dummy functions were changed to NULL
8959 (open_active_file) If write_active_file is non-NULL, the output
8960 device becomes DEV_PGM (a new enum).
8961 (close_active_file) Sets write_active_file to NULL.
8962 (read_from_memory) Comment fix.
8963 (record_case) Calls write_active_file() when the output device is
8966 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
8970 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
8971 Fixed checking for duplicate varnames.
8972 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
8974 (autorecode_trns_free) Destroys hash tables for each recoding
8976 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
8978 * command.c: Added SORT CASES to cmd_table.
8979 (null_func, null_int_func) Prototyped.
8981 * descript.g: (calc_weight, calc_noweight) Computes own case
8984 * frequencies.q: (dump_statistics) Fixed problem with
8985 too-few-cases warning message.
8987 * get.c: (cmd_save_internal) Handles weighting properly.
8989 * hash.c: (hsh_dump) Output format changed.
8990 (force_hsh_insert) Actually works now, prototype changed.
8992 * list.q: (static var case_num) New variable.
8993 (cmd_list) Initializes case_num.
8994 (list_cases) Increments case_num.
8996 * var.h: Added definitions for SORT CASES. Comment fixes.
8998 * vfm.c: Some definitions moved to new file vfmP.h. Comment
8999 fixes. `active' renamed vfm_active, `rep' renamed
9000 vfm_replacement, all references changed.
9001 (procedure) The procfunc no longer receives a case number. All
9003 (write_case) Subtle reordering.
9004 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
9007 * weight.c: (get_weighting_variable) New function.
9009 * vfmP.h: New file with definitions from vfm.c.
9011 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
9013 * command.c: (FILE_TYPE_okay) Commented out some tests because
9014 they're clumsy and not yet needed.
9016 * var.h: Most *_trns structures moved to their respective source
9017 files. Some were moved into a new file, do-ifP.h. Comment fixes.
9018 (union any_trns) Changed to a typedef for trns_header.
9019 (struct input_program_pgm) Removed.
9021 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
9022 was allocated in the first place.
9024 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
9026 * autorecode.c: New file.
9028 * command.c: Added AUTORECODE to command table; re-enabled SET.
9030 * data-out.c: (convert_F) Handles infinities and NaNs properly.
9032 * error.c: (vmsg) Comment fixes.
9034 * hash.c: Comment fix.
9035 (hashpjw_d) New function.
9036 (hashpjw) Reimplemented as call to more general function
9038 (internal_comparison_fn) Initializes pointers properly.
9039 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
9040 (force_hsh_insert, force_hsh_find) New debugging wrapper
9043 * main.c: (main) Message fix.
9045 * output.c: (outp_read_devices) Message fix.
9047 * set.q: Comment fixes.
9048 (custom_results) Implemented Wnd/X form of subcommand.
9049 (set_routing) New function.
9050 (internal_cmd_set) Implemented ERRORS, MESSAGES.
9052 * settings.h: (SET_ROUTE_*) New enum series.
9053 (set_results) Renamed set_results_file, all references changed.
9054 (set_messages) Removed.
9055 (glob vars set_errors, set_messages, set_results) New vars.
9057 * title.c: (get_title) Remembers to xstrdup() the result of
9060 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
9062 (union any_trns) New element `arc'.
9064 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
9066 * command.c: (output_line) Removed references to set_screen.
9068 * error.c: (static var terminating) New var.
9069 (hcf) Sets terminating to 1.
9070 (vmsg) If terminating is nonzero, does not attempt to call hcf().
9071 This prevents an infinite loop if an error occurs within hcf().
9073 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
9074 statement circumlocution with `case 42000' trick.
9075 (evaluate_expression) New support for OP_STR_MIS.
9077 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
9078 statement circumlocution with `case 42000' trick.
9079 (dump_node) Handles OP_STR_MIS.
9081 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
9082 variables exceptions.
9083 (parse_function) Message fix.
9084 (ops[]) Added OP_STR_MIS.
9086 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
9088 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
9090 * glob.c: Removed set_scrnfile glob var.
9091 (init_glob) set_errorbreak set to 0 by default.
9093 * groff-font.c: Changed included files.
9094 (groff_read_font) Initializes font_arena local var correctly.
9095 (default_font) New function.
9097 * output.c: Comment fixes.
9098 (glob var disabled_devices) New variable.
9099 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
9101 [GLOBAL_DEBUGGING] (reentrancy) New function.
9102 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
9103 outp_iterate_enabled_drivers) Calls to reentrancy().
9104 (destroy_list) New function.
9105 (outp_done) Moved code to destroy_list().
9106 (parse_options) Parses `listing', `screen', `printer' options
9108 (configure_driver) Sets new `device' member of driver.
9109 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
9111 * output.h: Comment fixes. New enum series OUTP_DEV_*.
9112 (struct outp_driver_struct) New member `device'.
9114 * postscript.c: (find_encoding_file) Doesn't display its own error
9116 (default_encoding) New function.
9117 (switch_font) Calls default_encoding() if no encoding can be
9119 (text) Makes up a character metric if none exists for the desired
9121 (load_font) Properly copies a fallback filename. Calls
9122 default_font() for a font if none at all are known.
9124 * set.q: Comment fixes. Removed OUTPUT subcommand.
9125 (custom_listing) Calls outp_enable_device() to enable/disable
9127 (turn_screen_on) Removed.
9128 (internal_cmd_set) Calls outp_enable_device() to enable/disable
9129 screen, printer devices.
9131 * settings.h: Comment fixes.
9132 (glob vars set_output, set_printer, set_screen, set_scrnfile)
9135 * som-high.c: (som_submit_table, som_eject_page) Use
9136 outp_iterate_enabled_drivers() instead of iterating
9137 outp_driver_list directly.
9139 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
9141 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
9142 (parse_string_as_format) Handles new formats.
9143 (parse_numeric) Now handles DOT and PCT formats.
9145 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
9147 (convert_date) Handle EDATE and SDATE formats.
9148 (convert_CCx) Now if there's not room for the currency characters,
9149 converts it as F format if it's positive instead of giving up
9150 quickly. Also fixed save-and-restore bug with decimal point
9152 (convert_format_to_string) Handles new formats.
9154 * misc.c: (formats[]) Added new formats.
9155 (convert_fmt_ItoO) Supports new formats.
9157 * sfm-read.c: (parse_format_spec) Supports new formats. Better
9158 data checking. New argument, all references changed.
9160 * sfm-write.c: (write_format_spec) Supports new formats.
9162 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
9165 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
9167 * cmdline.c: Comment fixes.
9168 (parse_command_line) Changed return type to void.
9170 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
9172 (parse_numeric) Handles international numbers (comma as decimal
9173 point). Some reformatting.
9175 * data-list.c: (parse_free) Default output format is now
9176 set_format instead of hard-coded F8.2.
9177 (read_from_data_list_list) Emits error message on undefined data
9178 only if set_undefined is nonzero.
9180 * data-out.c: (convert_E) Changes decimal point from period to
9181 comma if appropriate. Restructured. Better comments.
9182 (convert_F) Changes decimal point from period to comma if
9184 (insert_commas) Major bug with handling of negative values fixed.
9185 Also, inserts periods instead of commas if appropriate.
9186 (convert_CCx) New function.
9187 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
9188 (num_to_string) Changed `.' to set_decimal.
9190 * dfm.c: Comment fixes.
9191 (dfm_close) Frees ext->line even in inline_file.
9192 (open_inline_file) New function.
9193 (open_file_r) When opening the inline file: now properly
9194 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
9196 (read_record) Calls fh_close_handle() instead of dfm_close() to
9197 close the inline file. Makes a copy of the line getl_buf to avoid
9199 (dfm_get_record) Restructured. Now checks the return value of
9201 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
9202 checking for use of inline file. No longer tries to close inline
9205 * error.c: (glob var error_already_flagged) New var.
9206 (vmsg) Message change. Now checks max number of errors/warnings,
9209 * file-handle.q: (fh_handle_name) Now allows closing of
9211 (fh_init_files) Reformatted.
9213 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
9215 * getline.c: (getl_include) Fixed bug that popped up when called
9216 when file queue was empty.
9217 (read_console) Resets error_count, warning_count,
9218 error_already_flagged to zero.
9220 * glob.c: Many changes to update list of variables.
9221 (init_compat_dependent) Now this function is called whenever
9222 `compat' changes. It now sets set_seed only if it hasn't
9223 previously been referenced. It now calls
9224 lex_init_compat_dependent().
9226 * include.c: (cmd_include_at) Frees temporary buffer instead of
9228 (cmd_include) Doesn't make copy of include file name.
9230 * lexer.c: Comment fixes.
9231 (init_lex) Moved some code into new function
9232 lex_init_compat_dependent().
9233 (lex_init_compat_dependent) New function.
9234 (hex_val) Simplified.
9235 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
9237 * main.c: Comment fixes.
9240 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
9241 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
9242 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
9243 (setup_randomize) Sets set_seed_used.
9245 * set.q: Comment fixes.
9246 (custom_results) Conditionalizes on `compat'.
9247 (custom_log) Calls custom_journal().
9248 (set_ccx) New function.
9249 (cmd_set) Calls init_compat_dependent() when `compat' changes.
9250 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
9251 when set_decimal changes. Range-checks values for MITERATE,
9252 MNEST. Message fixes.
9254 * settings.h: Comment fixes.
9255 (struct set_cust_currency) New struct.
9256 (set_cc[], set_grouping, set_seed_used) New global vars.
9258 * var.h: (FMT_CCA...FMT_CCE) New output formats.
9259 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
9261 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
9263 * glob.c: Revised variables to correspond to settings.h.
9264 (init_glob) Initializes variables from settings.h properly.
9266 * set.q: Began long-overdue major revision to correspond to new
9267 philosophy. Most code changed.
9269 * settings.h: Mostly changed; reorganized, reordered, large new
9272 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
9274 * get.c: (cmd_save_internal) No longer forces compression off.
9276 * sfm-read.c: (read_compressed_data) If eof is reached when
9277 reading a new instruction octet, only signal error if we're in the
9280 * sfm-write.c: (COMPRESSION_BIAS) New #define.
9281 (struct sfm_fhuser_ext) New member `end'.
9282 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
9283 (ensure_buf_space) New function.
9284 (sfm_write_case) Reimplemented in order to support compression.
9285 (sfm_close) Writes out the remaining contents of the compression
9288 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
9290 * command.c: Defined SAVE and XSAVE commands in command table.
9292 * common.h: second_lowest_value is of type flt64, not double.
9294 * file-handle.h: Comment fix.
9296 * get.c: Comment fixes.
9297 (static var `trns') New.
9298 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
9299 cmd_save_internal, cmd_save, cmd_xsave) New functions.
9300 (dict_delete_run) Clears the variables and frees them now.
9301 (trim_dictionary) Sets default for compression.
9302 On KEEP subcommand, frees deleted variables as well as clearing
9303 them. Finally got the sense of the test for deleting all
9305 [DEBUGGING] (dump_dict_variables) Message fix.
9307 * glob.c: (init_glob) set_compression set to 1 by default.
9309 * list.q: Properly #includes config.h.
9311 * misc.h: New macro REM_RND_UP.
9313 * settings.h: Comment fix.
9315 * sfm-read.c: (structs sysfile_header, sysfile_format,
9316 sysfile_variable; inline function bswap_int32) Moved to new file
9318 (corrupt_msg) [__CHECKER__] No longer induces segfault.
9319 (sfm_read_dictionary) Fixed bug caused by failing to initialize
9321 (read_machine_flt64_info) Fixed some problems caused by confusion
9322 between flt64 and double types.
9323 (read_header) Message fix.
9324 (read_variables) Fixed set of cases in which we byte-swap sv.print
9325 and sv.write. Fixed confusion of flt64 and double.
9327 * sfm.h: (struct sfm_write_info) New.
9329 * som-high.c: (som_draw_title) Properly frees `s'.
9331 * temporary.c: (save_dictionary) Comment fix.
9333 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
9334 (struct trns_header) Formatting fix.
9335 (struct save_trns) New.
9337 * vars-atr.c: (discard_variables) Comment fix.
9339 * sfm-write.c: New file, baseline release.
9341 * sfmP.h: New file, baseline release.
9343 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
9345 * cmdline.c: (parse_command_line) `--version' output updated.
9346 (glob var syntax_message[]) Added my e-mail address.
9348 * file-handle.q, lexer.c, vfm.c: Changed many instances of
9349 `illegal' to `invalid'.
9351 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
9352 uncompression buffer.
9353 (sfm_close) Frees decompression buffer.
9354 (sfm_read_dictionary) Initializes decompression buffer.
9355 (buffer_input, read_compressed_data) New functions.
9356 (sfm_read_case) Restructured; now calls read_compressed_data() to
9357 handle compressed system file data.
9359 * var.h: Comment fix.
9361 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
9363 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
9366 * get.c: New comments. New static var `get_file'.
9367 (cmd_get) Now fully implemented. Calls discard_variables();
9368 initializes fv and lv for all variables; new debug code; sets
9369 up the dictionary; sets up the input program.
9370 (read_from_get, cancel_get) New functions.
9372 * sfm-read.c: Comment fixes.
9373 (sfm_close) New static function.
9374 (sfm_read_dictionary) Properly sets up the class of the
9375 file_handle. No longer cares what size the data is in records of
9376 type 7. Also, on failure, properly cleans up the file_handle and
9378 (read_variables) No longer thinks it knows `nval' of the
9379 dictionary. Now sets p.get.fv, etc., instead of speculatively
9381 (read_value_labels) Fixed off-by-one error in indexing of
9383 (sfm_read_case) New function.
9384 (sfm_r_class) New static var.
9386 * var.h: (get_proc) New struct.
9387 (struct variable) New member p.get.
9389 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
9391 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
9392 the manual's meaning.
9393 (rename_variables) New function.
9394 (trim_variables) Doesn't try to parse MAP any more. Removed debug
9395 code. Now properly reorders the dictionary on the KEEP keyword.
9397 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
9400 * vars-atr.c: (clear_variable) New argument `dictionary *'.
9401 (rename_variable) New function.
9402 (free_val_lab) Reformatted.
9404 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
9406 * var.h: Reindented entire file. Comment fixes.
9407 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
9409 (glob var default_dict) New.
9410 (struct indirect_dictionary) Removed.
9412 * Many other source files were changed to add `default_dict.'
9413 before all references to the dictionary of the active file.
9415 * vars-atr.c: (make_indirect_dictionary) Removed.
9417 * glob.c: Reindented all variable declarations. Updated for
9418 changed var.h. Comment fixes.
9420 * temporary.c: (restore_dictionary, save_dictionary) Simplified
9421 because now we can mainly copy dictionary structs.
9423 * vars-prs.c: (is_dict_varname, parse_dict_variable,
9424 parse_variables) Takes dictionary instead of indirect_dictionary
9426 (parse_variables) Instead of calling make_indirect_dictionary,
9427 just sets DICT to &default_dict if DICT is NULL. Of course, lots
9428 of `*dict.' references had to be changed to `dict->'. Removed
9431 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
9433 * get.c: Added GTSV_OPT_* series of enums.
9434 (trim_dictionary, dict_delete_run) New functions.
9435 [DEBUGGING] (dump_dict_variables) New function.
9436 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
9437 [DEBUGGING] Calls dump_dict_variables() to display results.
9439 * glob.c: (cmp_variable) Now a public function declared in var.h.
9441 * sfm-read.c: Turned off debug code. Comment fixes.
9442 (read_machine_int32_info, read_machine_flt64_info) New functions
9443 to parse type 7 records.
9444 (sfm_read_dictionary) Properly byteswaps several fields now.
9445 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
9446 records. [DEBUGGING] Dumps dictionary.
9447 (read_variables) Sets `index' field of variables created properly.
9448 Constructs avl tree of variables in dictionary. [DEBUGGING] No
9449 longer dumps dictionary.
9450 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
9452 [DEBUGGING] (dump_dictionary) No longer stubbed out.
9454 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
9455 var before destroying any variables just to save a little time.
9457 * var.h: (struct variable) Reordered in order to make name[] the
9458 first member; this makes pointers to `variable' pointers to the
9459 variable name, simplifying avl trees, etc.
9460 (struct indirect_dictionary) New struct.
9462 * vars-atr.c: (find_variable) Rewritten for efficiency.
9463 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
9465 (is_varname) Rewritten for efficiency.
9466 (parse_variables) New argument, which is a `dictionary *'. All
9467 references changed. This function now reads variable names from
9468 the dictionary passed, or from the default dictionary if NULL.
9470 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
9472 * misc.h: Added new macro DIV_RND_UP to perform integer division,
9473 rounding up. Changed many references to ROUND_UP to use this
9476 * sfm-read.c: Includes avl.h.
9477 (corrupt_msg) Induces a segfault under Checker.
9478 (macro assertive_bufread) New. Many references to bufread() now
9480 (sfm_read_dictionary) Split up into several functions. Added code
9481 to read dictionary records following the the type 2 records. Not
9482 quite complete. New variable `var_by_index'.
9483 (read_header, read_variables) New functions extracted from
9484 sfm_read_dictionary().
9485 (read_value_labels) New function.
9486 (bufread) Checks ferror() if fread() doesn't return the expected
9487 value; if ferror() is zero it's just EOF.
9488 (dump_dictionary) Stubbed out.
9490 * BTW: The source code now exceeds 50000 lines!
9492 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
9494 * command.c: Added GET to cmd_table[].
9496 * list.q: Removed reference to alloca headers.
9497 (cmd_list) Gave prototype.
9499 * sfm-read.c: Added DEBUGGING comments.
9500 (sfm_read_dictionary) Checks bias correctly. Sets
9501 dict->var_by_name to NULL. Calculates long_string_count
9502 correctly. realloc's dict->var[] array to minimum size.
9503 [DEBUGGING] Calls dump_dictionary.
9504 [DEBUGGING] (dump_dictionary) New function.
9506 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
9507 (restore_dictionary) If the dictionary contains a non-NULL
9508 var_by_name, uses that instead of generating one.
9509 (free_dictionary) Destroys var_by_name.
9511 * var.h: (struct dictionary) Added field `var_by_name'.
9513 * get.c: New file, not complete.
9515 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
9517 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
9518 (parse_num_or_range) New function.
9519 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
9520 <n> THRU HIGH missing values.
9522 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
9523 __attribute__((const)).
9525 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
9527 * sfm-read.c: Finished reference implementation.
9529 * sfm.h: Includes var.h.
9531 * var.h: Comment fixes.
9532 (struct `variable') Reordered some fields.
9534 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
9535 constants added previously.
9537 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
9539 * common.h: Comment fixes. Added declaration of
9540 `second_lowest_value' as variable or macro. Made `compat_type',
9541 `pgm_state_type' into anonymous enums.
9543 * display.c: Comment fix.
9545 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
9547 [!defined SECOND_LOWEST_VALUE] Added definition for
9548 `second_lowest_value' global var.
9549 (compat, pgm_state global vars) Changed types to `int'.
9550 (init_glob) Initializes `second_lowest_value'.
9552 * sfm-read.c: Continued work, not complete.
9554 * var.h: Added new MISSING_* constants to handle LOWEST and
9557 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
9559 * sfm-read.c: New file, not complete.
9561 * cases.c: (vec_insert) Changed vector expansion algorithm.
9562 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
9563 mucking up the RECODE transformation in particular.
9564 (envector) Harmless change in notation.
9566 dfm is now fairly well tested again.
9567 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
9569 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
9571 * recode.c: Comment fix.
9573 * sfm.h: Interface should be fairly final now, or at least for a
9576 * vfm.c: [DEBUGGING] (index_to_varname) New function.
9577 (open_active_file) [DEBUGGING] Translates ccase indices into
9578 variable names now to make it easier to understand what's really
9581 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
9583 * data-in.c: Comment fix.
9585 * data-list.c: Includes dfm.h.
9586 (do_reading) Uses new function dfm_push_cust().
9588 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
9591 * file-handle.h: Completely changed. Some parts split off into
9592 new file dfm.h. Implemented in file-handle.q.
9593 (enum FH_*) Removed.
9594 (struct fh_ext_class) New struct.
9595 (struct file_handle) Retained only these fields: name, norm_fn,
9596 fn, recform, lrecl, mode. New fields class, ext.
9597 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
9598 close_handle, handle_name) Added `fh_' prefix to name, all
9601 * dfm.h: New file, implemented in dfm.c.
9602 (get_record, put_record, fwd_record, bkwd_record, set_record,
9603 get_cur_col) Functions moved from file-handle.h, now prefixed with
9605 (dfm_push_cust) New function.
9607 * sfm.h: New file. Incomplete.
9609 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
9610 interface. Functions reordered, comments changed. Not well
9611 tested, probably full of bugs.
9612 (struct dfm_fhuser_ext) New struct.
9613 (dfm_close) New function.
9614 (open_file_r) Pickier about finding `BEGIN DATA.' line.
9615 (open_file_w) User messages changed.
9616 (get_record) Comment fixed.
9617 (read_record) Increments ext->ln even for inline_file. Calls
9618 dfm_close() for inline_file when `END DATA.' encountered.
9619 (dfm_get_record) Experimental restructuring.
9620 (dfm_push_cust) New function.
9621 (cmd_begin_data) Detects whether the inline file was fully read by
9622 checking whether it is still open; detects whether it was read at
9623 all by checking whether the line number is greater than zero.
9625 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
9626 interface. Functions reordered, comments changed. Not well
9627 tested, probably full of bugs.
9628 (init_file_handle) Removed initializers for obsolete fields, added
9630 (fh_close_handle) Much simpler, now mainly calls the class
9632 (fh_init_files) Renamed inline file internal filename.
9634 * file-type.c: Includes dfm.h.
9635 (read_from_file_type) Doesn't use dfm internal state anymore.
9637 * inpt-pgm.c, print.c: Include dfm.h.
9639 * recode.c: (internal_cmd_recode) Casts strlen() return value to
9640 int in comparison with other int.
9642 * som-high.c: (build_target) Fixed operator precedence problem in
9643 if statement (& versus ==).
9645 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
9647 * dfm.c: (read_record) Can now read fixed-length records; not
9649 (put_record) Can now write fixed-length records; not tested.
9651 * file-handle.h: FH_* defines changed to enums. New enum series
9653 (struct file_handle) New members recform, lrecl, mode.
9655 * file-handle.q: Parser changed.
9656 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
9657 /LRECL subcommands. These are compatible with Windows.
9658 (init_file_handle) Initializes recform, mode fields.
9660 * q2c.c: (get_line) When outputting `!' comment lines, now
9661 increments the output file line number so that `#line' directives
9663 (make_identifier) New function that converts an arbitrary string
9664 into a valid C identifier.
9665 (dump_vars) Calls make_identifier() in two places in order to
9666 suppress some errors for bad identifiers.
9667 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
9668 for NO. Allows numbers to be prefixed by underscores to make them
9669 acceptable C identifiers but still to be parsed as numbers by the
9672 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
9674 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
9676 * dfm.c: Comment fixes. (get_record) Gives error if file handle
9677 was opened for writing.
9678 (open_file_w) New function.
9679 (read_record) Uses strncasecmp if available. Improved error
9681 (put_record) New function.
9683 * file-handle.h: Moved function comments into dfm.c and
9684 file-handle.q. Comment fixes. Removed declarations of
9685 tilde_expand() and normalize_filename().
9686 (struct file_handle) Changed `open' from boolean to enumerated
9687 field to allow for three states--closed, open for reading, open
9688 for writing--all references changed.
9690 * file-handle.q: Includes filename.h.
9692 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
9694 (alloc_line) Makes allowance for line terminator characters in
9696 (print_trns_proc) Now handles OUTFILE, WRITE differences.
9697 (print_space_trns_proc) Handles OUTFILE differences.
9699 * recode.c, sample.c: Comment fixes.
9701 * var.h: (struct print_trns) Changed boolean field `eject' to
9702 bitmapped field `options'; all references changed. New enums
9703 PRT_* for use with this field.
9705 * exception.h, test-exception.c: Removed.
9707 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
9709 * ascii.c: (delineate) Turned off debug output.
9711 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
9714 * data-in.c: (parse_string_as_format) Sets the entire string value
9715 to spaces, not just the short string part of it. Is this correct
9718 * data-out.c: (convert_date) Fixed DATETIME format problems with
9719 decimal places, removed debug code.
9721 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
9722 middle of parsing BEGIN DATA that would cause the lexer to read
9723 from a wild pointer `prog'; now calls new function
9724 preprocess_line() in lexer.c.
9726 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
9728 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
9729 Now call induce_segfault() to induce the segfault.
9730 (induce_segfault) New function.
9732 * expr-opt.c: Comment fix.
9733 (parse_sysvar) New function.
9734 (parse_primary) Added system variable support--calls
9736 (global var ops) Added OP_CASENUM operator.
9738 * expr.h: Comment fixes.
9739 (OP_* enum) added OP_CASENUM operator.
9740 (struct casenum_node) New struct.
9741 (union any_union_union) New member `cas' of type `casenum_node'.
9743 * glob.c: (global var last_vfm_invocation) New var.
9744 (init_glob) Initializes last_vfm_invocation.
9746 * lexer.c: (lookahead) Fixed reversed condition on if statement.
9748 * getline.c: (get_line) Split into get_line() and preprocess_line().
9749 (preprocess_line) New function.
9751 * var.h: Declares last_vfm_invocation.
9753 * vfm.c: (procedure) Sets last_vfm_invocation.
9755 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
9757 * command.c: (parse_cmd) Fixed bad assertion related to
9760 * data-in.c: (parse_month) Implemented to parse months according
9761 to full interpretation of standard.
9762 (to_roman) New function.
9763 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
9764 (parse_weekday) Bug fix (forgot to skip all the day name).
9766 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
9767 up parsing of multirecord data items. Also fixed user message.
9769 * data-out.c: Comment fix.
9770 (year2, year4, convert_date, convert_time, convert_WKDAY,
9771 convert_MONTH) New functions to support time & date output.
9772 (convert_format_to_string) Calls new time & date output routines.
9774 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
9776 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
9779 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
9781 * misc.c: (global var formats) Fixed declarations of DATETIME,
9784 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
9785 the output_char buffer.
9787 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
9788 memory bug. Fixed user messages.
9790 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
9792 * Removed #pragma argsused from lots of places.
9794 * data-in.c: Implemented zoned decimal and time-date formats.
9795 Untested. This is a huge chunk of code--maybe 1000 lines and 50
9798 * data-out.c: Implemented zoned decimal format.
9800 * expr.h: Moved yrmoda() declaration here from exprP.h.
9802 * misc.c: (global var formats) Minor fixes--added
9803 FCAT_SHIFT_DECIMAL to formats N and Z.
9804 (convert_fmt_ItoO) Added support for format Z.
9806 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
9808 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
9810 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
9811 som_check_workspace() that is activated between commands.
9813 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
9816 * list.q: (begin_row) Changed title expansion style from
9817 SOPT_X_VERT to SOPT_X_SHSP.
9819 * som-frnt.c: Now includes `somP.h'.
9820 (som_push_workspace, som_pop_workspace) New functions that, taken
9821 together, form a solution to the recursive table building problem
9822 mentioned yesterday. Surrounded every table output routine
9823 throughout the program with calls to these functions.
9824 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
9825 (som_create_table) Checks that there's an active workspace.
9826 (som_destroy_all_tables, som_crush) Removed.
9828 * som-high.c: (global var som_preserve_tables) Removed, all
9830 (som_submit_table) Checks that there's an active workspace.
9831 (dump_columnated_table) Doesn't columnate tables that would have
9832 just one row per column.
9833 (dump_crush_page, som_dump_crush_page) Removed debugging code.
9834 (som_dump_crush_page) Moved row number labels from left side of
9835 tables to right side.
9836 (som_get_table_size) Added support for SOPT_X_SHSP.
9838 * som.h: New cell expansion type SOPT_X_SHSP.
9840 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
9842 (global var curtab_arena) Moved from som-frnt.c.
9844 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
9846 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
9847 that causes bad location warnings to be suppressed.
9848 (delineate) Saves current font when calling draw_text(); fixed
9849 handling of NULLs when backing up. Also fixed line-wrapping bug.
9851 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
9852 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
9854 * common.c: Added code to cause assertion failure to dump core
9855 when run under Checker.
9857 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
9858 there are still bugs.
9860 * glob.c: (__eprintf) Removed.
9862 * list.q: Inserted som_preserve_tables kluge that prevents tables
9863 from being thrown away due to recursive table building through
9864 som_output_line being called from a transformation during the LIST
9865 procedure invocation. This is a general problem that must be
9866 solved in a better way since it applies to all procedures in
9868 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
9869 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
9871 * numeric.c: Fixed several errors in the form of msg() calls.
9873 * print.c: Updated for use of som.
9874 (dump_table) Reimplemented.
9875 (print_trns_proc) Calls som_eject_page() instead of eject_page().
9876 Calls som_output_text() instead of outs_line().
9878 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
9880 (som_output_text) Function moved from som-low.c. Interface
9883 * som-high.c: (som_preserve_tables) New global public variable
9885 (som_submit_table) Destroys the tables only if som_preserve_tables
9887 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
9888 one subrow per row. Now labels subrows if there's more than one
9890 (dump_crush_table) Added wishlist comment.
9891 (som_eject_page) New public function declared in som.h.
9893 * som-low.c: (som_dump_crush_page) Draws row labels if there's
9894 more than one subrow per row.
9895 (som_output_text) Moved to som-frnt.c.
9897 * som.h: (SOM_TOPT_PRESERVE) Removed.
9899 * title.c: (get_title) Changed interface.
9900 (cmd_title) Changed `title' to `outp_title'.
9901 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
9903 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
9905 * list.q: (flush_table) Conforms to new partial options in
9906 som_submission_form.
9908 * som-high.c: (paginate_horizontally) Changed form of subrow
9910 (build_target) Omits spacing before table if
9911 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
9912 (dump_crush_page) Changed interface. Only trims bottom rule if
9913 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
9914 (dump_crush_table) Handles partial tables.
9915 (output_row_label) New function.
9916 (som_dump_crush_page) Emits subrow number labels. Draws vertical
9917 rule on the right edge of narrow subrows.
9919 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
9920 constants to a series of SOM_TOPT_PARTIAL_* submission options.
9921 All references updated.
9923 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
9925 * misc.c: Comment fix.
9927 * som-high.c: (examine_table) Treats crushed tables separates for
9928 purpose of determining header size.
9929 (paginate_horizontally) Allots space for line numbers in crushed
9930 tables with lots of subrows per row. Calculates the `maximum page
9931 width', the width of the widest horizontal page.
9932 (build_target) Removed trim argument; all references changed.
9933 Stricter assertions. (dump_crush_page) New function.
9934 (dump_crush_table) Reimplemented.
9936 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
9937 (som_dump_crush_page) Reimplemented, interface changed.
9939 * somP.h: Many many new helper macros for use with crushed tables.
9940 (global var som) Removed `tv', `cum_y' members; all references
9941 removed. New members `mpw', `digit_space'.
9943 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
9945 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
9946 variable, changed to constant 1024.
9947 (arena_ca_strdup) Changed `sizeof(a_string)' to
9949 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
9950 `(c_string *)' to `(char *)'; this fixed some offset problems.
9952 * filename.c: (readlink_malloc) Changed initial allocation from
9954 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
9957 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
9958 &fm->owner in several places.
9960 * som-high.c: (output_table) Changed interface to rest of world.
9961 (examine_crush_table) Removed. Crushed tables are re-broken now,
9962 in preparation for rewrite.
9964 * som.h: Comment fix.
9966 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
9968 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
9969 itself in the cleanup stage.
9971 * descript.q: (display) At least temporarily, changed the table
9972 format to a crushed table.
9974 * list.q: (begin_row) At least temporarily, added horizontal lines
9977 * som-high.c: (examine_crush_table) Sets som.hh to the width of
9978 the horizontal "headers," that is, to the width of the far left
9979 and far right rules.
9980 (justify_pagination) Sets som.th to the width of the widest row
9981 in the crushed table. Fixed inner loop off-by-one error.
9983 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
9986 * somP.h: Comment fix.
9988 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
9990 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
9991 before closing it; also, opens the constructed filename `s'
9992 instead of f->filename.
9994 * postscript.c: Moved initialization of x->loaded, x->prop,
9995 x->fixed, x->current, also the add_encoding() calls, into
9997 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
9998 sets x->last_font to NULL; sets x->next_combo to zero.
10000 * som-high.c: (crushed_row_height) Moved definition farther up.
10001 (som_submit_table) Doesn't calculate line width, font size until
10002 after calling open_page(), to accomodate changes to PostScript
10004 (vert_headers) Removed; equivalent functionality moved to
10005 examine_table(), examine_crush_table().
10006 (justify_pagination) Replaced with different algorithm.
10007 (dump_crush_table) Bugfix that caused tables to fail to be clipped
10008 at the bottom of the page.
10010 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
10012 * command.c: Added cmd_list back into cmd_table.
10014 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
10015 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
10017 * list.q: (flush_table) Updated to new som_submission_form format.
10019 * som-frnt.c: Comment fix.
10021 * som-high.c: Changed `#endif' to `#undef EXTERN'.
10022 (output_table) Calls som_get_table_size() directly; handles
10024 (examine_crush_table) New function; calls vert_headers().
10025 (examine_table) Moved some code into new function, vert_headers().
10026 (justify_pagination) New function.
10027 (dump_plain_table) Removed `static' from `cy'.
10028 (dump_crush_table) New function.
10030 * som-low.c: (som_dump_crush_page) New function.
10032 * som.h: Comment fixes.
10033 (enum SOM_TOPT_CRUSH) New.
10034 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
10035 Temporarily set to zero to make do with LIST procedure.
10037 * somP.h: Re-ordering.
10039 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
10041 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
10043 * somP.h: New file for use by som-high.c, som-low.c.
10045 * q2c.c: Added definition for VME.
10046 (get_line) Now dumps `!' comment lines to the output file
10049 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
10050 set.q: Changed format of `!' comment lines.
10052 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
10054 * All source files: Added copyright notice.
10056 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
10057 longs in msg() calls.
10059 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
10061 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
10063 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
10065 * output.c: (outp_read_devices) Changed criteria for
10066 distinguishing different types of lines.
10068 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
10070 * cmdline.c: Changed syntax message.
10072 * filename.c: (good_getcwd) Bug fix (?).
10073 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
10075 (search_path) Appends DIR_SEPARATOR to directory name only if it
10076 does not already end with one.
10078 * glob.c: Checks STAT_PAGER envvar before PAGER.
10080 * output.c: Checks environment variables instead of just local
10083 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
10085 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
10086 when the pointer passed to the function was within the arena
10087 itself, so that it couldn't properly be set to NULL _after the
10090 * command.c: Re-enabled DISPLAY.
10092 * display.c: Rewritten to handle tables. Untested.
10094 * filename.c: (search_path) Fixed memory leak.
10096 * frequencies.q: (cmd_frequencies) Frees v_variables.
10097 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
10098 (cleanup_freq_tab) New function to garbage collect.
10099 (dump_full) Elegantized.
10101 * main.c: New comment.
10103 * output.h: New tag for tagged quotes: TAG_NEWLINE.
10105 * postscript.c: Comment fix.
10106 (release_fontmap, free_font_entry) New functions.
10107 (ps_init_driver) Sets free_font_entry() as the freefunc for
10108 hashtable `loaded'. Calls release_fontmap() when destroying a
10109 driver; also frees the output filename; also frees the
10110 ps_driver_ext block.
10111 (free_ps_encoding) Frees the filename as well as the encoding
10113 (output_encodings) Frees the line buffer and pops the msg-filename
10115 (read_fontmap) Frees the fontmap filename and the line buffer.
10116 (postopen, preclose) Misc. garbage collection fixes.
10117 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
10118 to NULL; this fixes some output problems.
10119 (text) Handles TAG_NEWLINE. Untested.
10121 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
10122 (som_set_string) Removed. All references changed to
10124 (som_set_text) Rewritten. New interface. More general.
10126 * som.h: Minor format changes.
10127 (struct som_value_cell) Removed; all references changed to
10129 (enums SOT_*) Changed.
10131 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
10133 * command.c: Re-enabled SPLIT FILE.
10135 * postscript.c: Comment fix.
10137 * som.h: Added `SOT_NONE'.
10139 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
10141 * vfm.c: (dump_splits) Reimplemented.
10143 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
10145 * Compiled the project under gcc 2.7.2, which gave some new
10146 warnings. This led to many additions of casts from unsigned to
10147 int sprinkled throughout the code.
10149 * arena.c: Many uses of `unsigned' changed to `size_t'.
10151 * command.c: Added END FILE, END REPEAT to command table.
10152 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
10153 (find_command, FILE_TYPE_okay) Not commented out anymore.
10154 (parse_cmd) Calls FILE_TYPE_okay again.
10155 (output_line) Added calls to som_output_text() to put the line
10156 in the output files.
10158 * common.c: (macro VME) Format changes.
10159 (xstrdup) Asserts that its argument is not NULL.
10161 * data-list.c: Implemented dump_fixed_table().
10163 * inpt-pgm.c: Formatting changes. Comment changes.
10164 (end_case_proc) Renamed end_case_trns_proc.
10165 (cmd_end_file, end_file_trns_proc) New functions.
10167 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
10169 * misc.h: (local_strdup) New macro corresponding to strdup() but
10170 allocating its data through local_alloc() if possible--that is, if
10173 * postscript.c: Comment changes.
10174 (quote_ps_name, quote_ps_string, output_encodings) New functions.
10175 (output_line, add_string) New macros supporting
10176 output_encodings().
10177 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
10178 substitution vars. Calls output_encodings() when a line
10179 consisting of `!encodings' is encountered.
10180 (preclose) Some code moved into quote_ps_string().
10181 (dump_line) Changed into macro supporting dump_fancy_line().
10182 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
10183 command when appropriate.
10184 (write_text) Fixed `literal_char' array (I think it's fixed, at
10186 (text) Fixed bug when width was zero. Now exits immediately on
10187 zero height_left. Now, when executing `goto restart;', checks
10188 that cp<end, so that we don't read beyond end-of-string. Also,
10189 outputs the correct code to the output file by outputting the code
10190 from the metric instead of the internal metric index.
10192 * repeat.c: (cmd_end_repeat) New function.
10194 * som.c: (var som) `headers' renamed `options' and semantics
10195 changed. All references changed.
10196 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
10197 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
10199 (som_text_table) Removed.
10200 (som_output_text) New function.
10202 * som.h: (struct som_submission_form) Removed `header', `reuse',
10203 replaced with bitmapped field `options'.
10204 (SOM_TOPT_*) New enum set for som_submission_form.options.
10205 (SOT_*) New enum set for som_output_text().
10207 * temporary.c: (copy_variable) When copying the var label, only
10208 calls xstrdup() if it's non-NULL.
10210 * var.h: (enum type `vartype') Removed; all references changed to
10213 * vars-atr.c: (init_variable) Changed local var `nbytes' from
10216 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
10218 * font.h: Comment changes.
10220 * groff-font.c: (groff_read_font) Initializes `name' field to
10221 NULL. Handles `encoding' field.
10223 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
10225 * postscript.c: (struct font_entry) Removed `position' field.
10226 (struct ps_font_combo) New struct.
10227 (struct ps_driver_ext) Removed field `next_position'. New fields
10228 `combos', `next_combo'. `last_font' field changed from
10229 `font_entry *' to `ps_font_combo *'.
10230 (ps_init_driver) Reformatted; handles new fields. When
10231 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
10233 (get_encoding, find_encoding_file) New functions.
10234 (add_encoding) Some code moved out into find_encoding_file().
10235 (postopen) Changed value for ${title}.
10236 (preclose) Sets `loaded' field to NULL after destroying the hash
10238 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
10240 (ps_text_set_font_by_position) Figures out the current family if
10242 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
10243 (switch_font) Implemented.
10244 (write_text) Calls switch_font() more often. Format changes.
10245 #undefs its macros after they're no longer useful.
10246 (text) Changed `continue' at one point to a jump to the top of the
10247 loop because we don't want `separate' reset to 0 at that point.
10248 (load_font) No longer sets `position' in the font_entry created.
10250 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
10252 * font.h: (struct font_desc) New member `encoding', which is not
10253 properly handled yet.
10255 * glob.c: (init_glob) Some new i18n code, which is probably
10258 * output.c: (outp_read_devices, outp_get_paper_size) Changed
10259 `size' local from `int' to `size_t'.
10261 * postscript.c: New driver configuration parameter `auto-encode'.
10262 New enums OPO_AUTO_ENCODE, ODA_COUNT.
10263 (struct font_entry) New member `position'.
10264 (struct ps_driver_ext) Reordered. New hash table member
10265 `encodings'; new members `next_position', `next_encoding',
10266 `last_font'. Members `current', `prop', `fixed' changed from type
10267 `font_desc *' to `font_entry *'; all references changed.
10268 (struct ps_encoding) New struct.
10269 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
10270 free_ps_encoding, add_encoding) New functions.
10271 (ps_init_driver) Added OPO_AUTO_ENCODE to default
10272 x->output_options. Initializes new members of ps_driver_ext.
10273 Changed default value for prologue_fn, encoding_fn. Calls
10274 read_ps_encodings after loading default fonts.
10275 (option_tab[], ps_option) Handle new configuration parameter.
10276 (switch_font) New function.
10277 (struct output_char) `font' member changed from `font_desc *' to
10278 `font_entry *'. New member `separate'.
10279 (read_fontmap) Changed `size' from `int' to `size_t'.
10280 (output_line, put_number) New macros for write_text().
10281 (write_text) Optimizes text output by consolidating multiple
10282 calls to PostScript `show' operator.
10283 (text) Keeps track of when text arguments can't be consolidated by
10284 write_text(), and marks those spots in the output stream.
10285 (load_font) Sets `position' of the allocated font_entry to -1, cuz
10286 the font hasn't been switched to by switch_font(), which is where
10287 the position is important--the PostScript is what cares about the
10290 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
10292 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
10293 call a NULL free_func.
10294 (hsh_rehash) Elegantized.
10295 (hsh_probe) Fix bug that manifested when the table was expanded
10296 and thus had to change location in memory. Good thing
10297 too--otherwise could have been much more subtle.
10298 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
10299 (hsh_foreach) New function for hash table iteration.
10301 * hash.h: (struct hsh_iterator) New.
10303 * lexer.c: (parse_tagged_quote) Font and family name strings in
10304 tags are now null-terminated.
10306 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
10308 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
10309 documented. (Never before tested?)
10311 * output.h: Comment changes.
10313 * postscript.c: New driver options `optimize-text-size',
10314 `optimize-line-size', `max-fonts-simult'. New enum set for
10315 specing cached line types. Comment fixes.
10316 (struct line_form) New struct.
10317 (struct ps_driver_struct) New members `text_opt', `line_opt',
10318 `max_fonts', `lines'.
10319 (ps_init_driver) Initializes new members of ps_driver_struct.
10320 (user option type enum set) New member `nonneg_int_arg'.
10321 (static var option_tab[]) Supports new options.
10322 (ps_option) Handles new options.
10323 (find_ps_file) Made static. No longer calls hsh_dump().
10324 (ps_get_var) Made static.
10325 (preclose) Dumps out proper DSC trailer.
10326 (ps_open_page) Elegantized.
10327 (ps_close_page) Calls dump_lines() if appropriate.
10328 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
10329 wrappers around line().
10330 (int_2_compare, compare_line, dump_line, dump_fancy_line,
10331 dump_lines, hash_line, free_line, line) New functions for support
10333 (write_text, text) Made static.
10334 (text) Added to font support, not finished.
10336 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
10338 * font.h: (struct font_desc) New members ascent, descent.
10340 * groff-font.c: (groff_read_font) Calculates font ascent and
10341 descent from the ascent and descent of the `d' and `p' characters,
10342 respectively, as per a suggestion on comp.fonts.
10344 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
10345 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
10347 (write_text) Handles text right-justification and centering (not
10348 full justification). Still very inefficient. (One output line
10350 (struct output_char) Added fields for font and font size.
10351 (text) Many bugfixes.
10353 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
10355 * cmdline.c: (usage) Calls outp_list_classes().
10357 * font.h: Comment fix.
10359 * groff-font.c: New exported global var `space_index'.
10360 (groff_init) New function to initialize `space_index'.
10361 (hash_kern) Casts result to unsigned.
10362 (font_name_to_index) Renamed font_char_name_to_index. All
10363 references changed. Also, now returns the value of `space_index'
10364 when passed an ASCII space character as an argument. Fixed
10366 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
10367 Handles passed NULL pointers properly.
10369 * lexer.c: (parse_tagged_quote) Comment fix. Better range
10372 * output.c: (outp_list_drivers) Removed. Removed all references.
10374 * output.h: Comment fixes.
10376 * postscript.c: (ps_open_global) Calls groff_init().
10377 (output_char) New structure.
10378 (write_text) New function.
10379 (text) No longer stubbed out! Now the output is correct--with a
10380 few exceptions, one of them being that the page has to be held
10381 upside down into a mirror.
10383 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
10385 * font.h: Comment fix.
10387 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
10388 All callers changed.
10389 (number_to_index) Renamed font_number_to_index, made extern. All
10391 (font_get_kern_adjust, font_get_char_metrics) New functions.
10393 * output.h: New constant OUTP_T_INTERNAL_DRAW.
10395 * postscript.c: Changed default line width back to 1/2 point.
10396 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
10397 in the center of the space allotted for them, not just a fixed
10398 offset from the edge of the space; this fixes some bugs.
10399 (ps_line_intersection) Now supports all command line styles.
10400 (ps_text_get_size) Bug fix in computation of em width.
10401 (text) New function, the meat behind ps_text_metrics and
10402 ps_text_draw. Not complete.
10403 (ps_text_metrics, ps_text_draw) Removed the stub taken from
10404 ascii.c; call text().
10406 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
10408 * arena.c: (arena_free) Assert that the argument is non-NULL.
10410 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
10411 only if old_kern is non-NULL.
10413 * postscript.c: (ps_init_driver) Changed default line width to 1
10415 (postopen) New prologue variables.
10416 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
10417 more of the common line styles properly, but not all.
10418 (ps_text_metrics) Fixed problem with this stubbed out version that
10419 kept it from taking font sizes into account.
10421 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
10423 * arena.c: (arena_malloc) Bug fix.
10424 (arena_dump) [GLOBAL_DEBUGGING] New function.
10426 * ascii.c: Comment fix.
10427 (count_fancy_chars, delineate) Now static functions.
10429 * filename.c: (interp_vars) Bug fixes.
10431 * font.h: Comment fixes.
10433 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
10434 beginning in case we have an error message to display before
10435 initializing the display.
10437 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
10439 (groff_read_font) Bug fixes.
10440 (name_to_index) Increments hash.used. Sets `name' field of hash
10442 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
10444 * hash.c: Return type changed.
10446 * postscript.c: Continued development. Now marks lines on the
10447 paper, but very buggy.
10449 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
10451 * Changed comments in many source files from `/* xxx /* yyy */' to
10452 `/* xxx */ /* yyy */' for cleanliness.
10454 * arena.c: (arena_sd_strdup) New function.
10456 * ascii.c: (struct ascii_driver_ext) New member `file'.
10457 (ascii_init_driver) Fills out member `file' for initing; uses
10458 close_file_ext for closing drivers.
10459 (ascii_option) Changed %.*s back to %s because the a_string's are
10460 always null-terminated.
10461 (postopen, preclose) New functions.
10462 (ascii_open_page) Uses new style of open_file_ext.
10463 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
10464 instead of this->output.
10465 (__assert_fail) Removed.
10467 * cmdline.c: Changed syntax_message[].
10469 * error.c: #include's <readline/history.h> only if the history
10470 library is available, not if just the readline library is
10473 * filename.c: (expand_line) Removed alloca() support.
10474 (interp_vars) No longer tilde-expands argument. Limit on output
10476 (tilde_expand) Now treats argument as path rather than filename.
10477 [!unix] Now is a no-op function.
10478 (search_path) Better verbose message formatting.
10479 (open_file, close_file) Comment fixes.
10480 (close_file) [!unix] Doesn't bother with pipes.
10481 (open_file_ext) Completely rewritten, interface revamped.
10482 (close_file_ext) New function.
10484 * font.h: Comment changes.
10486 * frequencies.q: Removed AIX alloca support since it doesn't use
10489 * hash.c: Comment changes & additions.
10490 (hsh_create) Initializes entire table instead of first M entries.
10491 (hsh_probe) Stupid bug fixed. Now it works.
10492 (hsh_dump) [GLOBAL_DEBUGGING] New function.
10494 * main.c: (parse) Detects EOF properly in token-eating loop.
10495 Should the STOP token have its value changed to 0?
10497 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
10498 (blp_getline) Now it's a macro.
10500 * output.h: (struct outp_driver) Removed members output, filename.
10502 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
10503 drivers in driver table.
10504 (outp_read_devices) Frees buf. Warns if there are no active
10506 (outp_configure_clear) Sets outp_configure_vec to NULL after
10507 deleting its elements.
10508 (configure_driver, destroy_driver) Removed references to output,
10509 filename members of outp_driver.
10510 (outp_evaluate_dimension, internal_get_paper_size,
10511 outp_get_paper_size) New functions.
10513 * postscript.c: Continued development. Now links but doesn't make
10514 any marks on the page. Lotsa bugs I suppose.
10516 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
10518 * str.h: Comment changes.
10520 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
10522 * Removed dependencies on non-nested comments in several files.
10523 Also removed references to (unix || __unix__) in #if's since
10524 prefh.orig makes those two equivalent.
10526 * ascii.c: (ascii_open_global) Creates ascii_arena.
10527 (ascii_close_global) Destroys ascii_arena.
10528 (ascii_init_driver) Doesn't create ascii_arena.
10529 (ascii_copy_driver) Removed.
10530 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
10531 (outp_class ascii_class) Removed ascii_copy_driver reference.
10533 * frequencies.q: Now can display all statistics except median.
10534 Still not finished.
10536 * output.c: Handles outp_class.ref_count so output class
10537 destructors are called properly.
10538 (add_class) Sets ref_count to 0.
10539 (configure_driver) Initializes class if ref_count++ is 0.
10540 (destroy_driver) Destructs class if --ref_count is 0. Frees the
10541 class output file name.
10543 * output.h: (struct outp_class) Removed copy_driver, inited.
10546 * postscript.c: Completely replaced but not finished.
10548 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
10550 * approx.h: #includes <float.h>.
10552 * arena.h, arena.c: Many functions changed to take an arena **
10553 instead of an arena *, for consistency. All callers changed.
10554 (arena_alloc) Now creates a new arena if passed *A that is NULL.
10555 (arena_destroy) Sets *A to NULL.
10557 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
10558 assertion that `width' be positive.
10560 * command.c: Removed #if's from cmd_table.
10561 (walk_cmdtable_func) [0] New function (debug code).
10562 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
10563 (parse_cmd) Doesn't return failure for unimplemented commands.
10565 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
10566 (SYSCODE) New constant macro.
10568 * descript.q: Checks for positive n_variables before performing
10571 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
10572 avl_find instead of &fp as arg 2.
10574 * frequencies.g, frequencies.q: Continued updating; now compiles &
10575 works again, but not complete.
10577 * main.c: Changes to user messages.
10579 * misc.c: (reverse) [0] New function.
10581 * settings.h: Comment removed. #includes "common.h".
10583 * som.c: (som_set_null) New function.
10584 (som_set_value, som_set_string, som_set_text) More detailing
10586 (som_set_float) Implemented function.
10587 (dump_columnated_table) Bug fix regarding page breaks.
10588 (draw_cell) Bug fix regarding text that spilled out of a cell.
10589 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
10591 (get_cell_size) Support SCON_EMPTY cells.
10592 (get_table_size) When calculating rules' widths and heights, mask
10593 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
10595 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
10597 (struct som_submission_form) New member `header'; all users
10600 * val-labs.c: (get_label) User messages changed.
10602 * var.h: Changed FREQUENCIES structures.
10604 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
10607 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
10609 * approx.h: Definition of EPSILON now depends on system's
10610 DBL_EPSILON. Removed GNU C specific code.
10611 (cmpapx) Renamed approx_compare.
10613 * frequencies.g, frequencies.q: Continued updating; still doesn't
10616 * groff-font.c: (name_to_index) Fix bug that kept it from
10619 * hash.c, hash.h: Completed work.
10621 * var.h: Changes to freq_tab, frequencies_proc.
10623 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
10626 * hash.c, hash.h: New files. Not completed.
10627 * Makefile.am: Added hash.c to source file list.
10628 * font.h: (struct font_desc) New member kern_size_p.
10629 * groff-font.c: Uses hash.h.
10630 (hashpjw) Moved to hash.c.
10631 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
10633 (static var hash) New member size_p.
10634 * var.h: Includes hash.h.
10635 (struct freq_tab) Changed AVL_TREE to hash_tab.
10637 * vars-prs.c: Comment, formatting fixes.
10639 * frequencies.g, frequencies.q: Continued updating. Not yet
10642 * formats.c: Bug fix.
10644 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
10646 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
10647 * descript.g: Comment fixes.
10648 * descript.q: Comment fixes. Moved some declarations into var.h.
10649 Made dsc_info a static table. Updated FIXMEs.
10650 (internal_cmd_descriptives) Beautified.
10652 * frequencies.q: Started updating into working order.
10653 * frequencies.g: New file analogous to descript.g.
10654 * var.h: Comment fixes. Added structures for FREQUENCIES.
10656 * som.c: Removed vestiges of crushing and partial table support.
10658 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
10660 * Many more changes to som.c especially, but these will not be
10661 documented as I have resolved to remove them. This patchlevel is
10662 being released solely so that I can fall back to it if I decide
10663 that removing the changes is not a good idea.
10665 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
10667 * som.c: (global var som) New member `cum_y'.
10668 (build_target) Properly handles titles for partial tables.
10669 (dump_partial_beg, dump_partial_mid, dump_partial_end)
10670 Merged into single new function dump_partial(). Fixed problem
10671 with titles on partial tables.
10672 (dump_table) Calls dump_partial() for all parts of partial tables.
10673 (dump_page) Criteria for drawing title changed.
10675 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
10677 * command.c: (cmd_table) Added LIST, WEIGHT.
10679 * command.c: (cmd_remark) No longer frees `s' since it's not
10680 dynamically allocated.
10682 * data-out.c: (convert_f) Now correctly handles the case where
10683 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
10684 number of decimals.
10685 (som_destroy_all_tables) Removed argument. All callers changed.
10686 (som_vline, som_hline) Argument validity checking corrected.
10687 (som_set_value) Implemented half-heartedly.
10688 (replicate_table) Copies tables piece-by-piece when using Checker.
10690 * som.h: New line style SLIN_1THIN, currently equivalent to
10691 SLIN_0. New enum set SOM_SUB_*.
10692 (struct som_submission_form) Removed `seq_no'. Added `type'.
10694 * list.q: Newly working file; uses partial tables.
10696 * som.c: (som_reduce_table) Renamed som_set_table_height().
10697 (som_crush) Removed argument `group'.
10698 (global var som) Removed `nt', `seq_no'. Added `type'.
10699 (som_submit_table) Arguments changed.
10700 (output_table) Removed partial table code.
10701 (build_target) New arg; partial table support added. All callers
10703 (dump_plain_table) Removed partial table code.
10704 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
10705 (dump_table) Supports partial tables.
10706 (dump_page) New argument to allow not drawing top and/or bottom
10707 headers. All callers changed. Supports partial tables.
10709 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
10711 * data-out.c: Changed `#include <approx.h>' to `#include
10713 (convert_F) Comment fix. Now won't print `-.000', etc.
10715 * descript.q: Now Z-scores work, although there appears to
10716 be a bug (which might actually be in data-out.c:convert_F()).
10717 (descriptives_trns_proc, descriptives_trns_free) New functions.
10718 (run_z_pass) Implemented.
10720 * var.h: Comment fixes.
10721 (dsc_z_score, descriptives_trns) New structs.
10722 (descriptives_trns) Added to any_trns as `dsc'.
10724 * error.c, error.h: New error class, IS (Installation Script
10725 error), used in those instances where the error is in the
10726 installation, but there is a script file or installation file that
10727 can be usefully referred to.
10729 * output.c: Change many IE classes to IS classes.
10731 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
10732 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
10733 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
10734 include the corresponding header?
10736 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
10737 Don't bail out if termcap can't be read.
10739 * som.c: (som_destroy_table) Removed.
10740 (som_reduce_table, som_destroy_all_tables) New functions.
10741 (som_crush) New function, not implemented.
10743 * som.h: New table option STAB_CRUSH. Comment fix. New struct
10744 som_submission_form. Function prototypes revised.
10746 Outputting huge tables (1000s of rows) a few rows at a time
10747 is supported, though untested. May even break everything.
10748 Actually, the code doesn't even compile right now.
10749 * som.c: (struct som) New fields htv, nt, seq_no.
10750 (som_submit_table) Multiple arguments changed to a single
10751 pointer to struct submission_form. Only increments subtable_num
10752 if seq_no is zero. Only destroys table if it's not going to
10754 (replicate_table) New function.
10755 (output_table) Comment fix.
10756 (examine_table) Changed inline code to code calling
10757 replicate_table(). Calculates htv. Supports partial tables.
10758 (draw_title) Removed comment.
10759 (build_target) Only allows for title on first part of partial
10761 (dump_plain_table) Only resets table chunk number on first part
10762 of partial tables; FIXME: doesn't work quite right. Supports
10764 (dump_page) Titles only on first part of partial tables.
10766 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
10768 * Thanks to an unreliable IDE hard drive, I have spent the last
10769 day reconstructing my Debian GNU/Linux installation and redoing
10770 the previous day's changes--somehow I managed to save every file
10771 except for output.c and output.h. So the following changes could
10772 really be considered independent of the output.c, output.h changes
10775 * output.h, output.c: Moved the outp_configure_vec global var,
10776 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
10777 outp_configure_vec is now static.
10779 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
10781 * The entire philosophy behind configuration of the output drivers
10782 changed. Now there is a termcap-type configuration where drivers
10783 to be read are determined beforehand, rather than parsing the
10784 entire output init file and storing it in memory & deciding what
10785 to actually use later. Faster & more memory-efficient at the same
10788 * output.c: Comment fix. Removed outp_init_drivers global var.
10789 Removed all references to synonyms. New structure outp_defn. New
10790 global vars outp_macros, outp_configure_vec.
10791 (search_name, delete_name, add_name, check_configure_vec,
10792 expand_name, find_defn_value) New static functions.
10793 (outp_configure_clear, outp_configure_add, outp_configure_macro,
10794 outp_read_devices) New extern functions.
10795 (outp_init) Much functionality moved into outp_read_devices.
10796 (outp_read_devices) Format of output init file changed; name of
10797 file is `devices' rather than `output' to avoid Makefile
10799 (outp_clear) Renamed outp_done.
10800 (outp_list_classes) Bug fix, cleaned up.
10801 (outp_list_drivers) Not implemented anymore.
10802 (outp_configure_driver) Now a static function; simplified; now
10803 interpolates macros; supports new structure.
10804 (outp_enable_driver, match_synonym) Removed; all references
10806 (find_driver) First argument removed.
10808 * output.h: Global var outp_init_drivers removed; new structure
10809 outp_names; new enum set OUTP_S_*; new global var
10810 outp_configure_vec; function prototypes for output.c exports
10813 * main.c: (main) Calls outp_read_devices() after parsing the
10816 * cmdline.c: (parse_command_line) New option -v --verbose;
10817 --version changed to -V. --device option changed syntax to just
10818 take a single device name. Accepts key=value declaration of
10819 output init file macros. Syntax message updated.
10821 * filename.c: (expand_line) New function.
10822 (interp_environ_vars) Renamed interp_vars; no longer uses
10824 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
10825 overridden by real environment vars.
10826 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
10827 * filename.h: interp_environ_vars() renamed interp_vars().
10829 * error.c, error.h: Added extern variable `verbosity', message
10832 * error.c: (vmsg) Support message class MM.
10833 (verbose_msg) New function.
10835 * descript.q: (generate_z_varname) Bug fix in generation of
10837 (dump_z_table) Bug fix in column headers.
10839 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
10840 page from 29 to 15. Don't set a default for ops[OPS_INIT,
10841 OPS_DONE]. Writes the uninit string when the driver is closed.
10842 (ascii_open_page) Write the init string before the first page.
10843 (output_shorts) Form of main loop changed from `while' to `for'.
10844 Bug fix with overstrikes: the character is printed *after* the
10845 backspace. Eliminated a lot of `& 0xff' modifiers.
10846 (advance_to_left_margin) New function.
10847 (return_carriage, output_lines) Handle left margin.
10849 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
10851 * ascii.c: New option `carriage-return-style'.
10853 * ascii.c: (count_fancy_chars) New function.
10854 (delineate, text_metrics) Use new function; bug fixes regarding
10856 (text_draw) Bug fix with rich text.
10857 (output_string, output_shorts) Reordered.
10858 (output_shorts) Now handles boxchars and some overstrike font
10860 (output_char, return_carriage) New functions.
10861 (output_lines) Now handles overstriking and font changes properly;
10862 some code moved to output_shorts.
10864 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
10867 * ascii.c: New member `debug' in ascii_driver_ext.
10868 (ascii_init_driver, delineate) Uses new member.
10870 Now you can set a vertical height on writing text.
10871 * ascii.c: (delineate) Keeps track of vertical position.
10872 (text_draw) No longer considers fully justified text an internal
10875 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
10877 Tables' titles are drawn; they can have variable height.
10878 * som.c: `som' struct has new member, title_height.
10879 (draw_title) New argument. Moved within file. All caller
10881 (build_target) New argument, amount of space needed for first row.
10882 Calculates height of title, takes that into account. All callers
10884 (dump_plain_table, dump_columnated_table) Took calculation of y1,
10886 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
10888 (dump_columnated_table) Organized for readability.
10889 (dump_page) Makes use of som.title_height.
10891 * som.c: Many comment bug fixes.
10893 * descript.q: (try_name, generate_z_name) Bug fix regarding
10894 generation of Z-score variable names.
10895 * var.h: Removed num from descriptives_proc; all referents removed.
10897 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
10899 * ascii.c: (ascii_line_horz, ascii_line_vert,
10900 ascii_line_intersection) Added debugging code.
10902 Added a descriptive line above each table to describe it.
10903 * command.c: (parse_cmd) Calls som_new_series.
10905 * som.c: New static vars table_num, subtable_num. New `som'
10907 (dump_page) New arguments.
10908 (som_submit_table) Handle new variables.
10910 * som.c, som.h: (som_submit_table) New arguments. All callers
10912 (som_new_series) New function.
10913 (build_target) Makes room for extra line.
10914 (draw_title) New function.
10915 (dump_page) Calls draw_title. Bug fix: doesn't always set
10918 Columnation of tables support.
10919 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
10921 * som.c: Deleted references to fr, lr, ri.
10922 (som_columnate) Bux fix: sets group member of table.
10923 (som_add_options) Function removed.
10924 (dump_table) Split into three functions; extensively reworked.
10926 * descript.q: (dump_z_table) Better output table formatting; added
10927 title support to correspond to som.h changes.
10928 (display) Title support.
10930 * output.h: Added OUTP_T_NONE.
10932 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
10934 * descript.q: Improved handling of Z scores; still not perfect.
10936 * output.h, ascii.c: Added hook for getting em width of current
10939 * som.c: Uses new em-width hook. Added debugging code to
10941 (som_columnate) New argument.
10942 (som_add_options) Removed.
10944 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
10946 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
10947 rules as a property of the table instead of as a property of the
10950 * ascii.c: Added `header' to table of options.
10952 * descript.q: Added even shorter statistic names; modified to work
10953 with new som interface.
10955 * misc.c (blp_getdelim): Bug fix.
10957 * version.c: includes 'conf.h'.
10959 ----------------------------------------------------------------------
10962 version-control: never
projects / pspp-builds.git / blob