1 Fri Feb 3 20:34:52 2006 Ben Pfaff <blp@gnu.org>
3 * font.h: (struct font_set) Removed, because unused.
5 Sat Jan 28 17:45:36 2006 Ben Pfaff <blp@gnu.org>
7 Cleaner (faster?) way to compact cases.
9 * dictionary.c: (dict_compact_case) Removed.
10 (dict_needs_compaction) New function.
11 (struct copy_map) New structure.
12 (struct dict_compactor) New structure.
13 (dict_make_compactor) New function.
14 (dict_compactor_compact) New function.
15 (dict_compactor_destroy) New function.
17 Sat Jan 28 17:24:22 2006 Ben Pfaff <blp@gnu.org>
21 * data-list.c: Make data_list_source_class static.
22 (dump_fixed_table) Use fh_get_name() to describe source of data.
23 (dump_free_table) Ditto.
24 (cmd_repeating_data) Eliminate special cases for inline file.
26 * dictionary.c: (dict_contains_var) Change return value from int to
28 (dict_rename_vars) Ditto.
29 (dict_create_vector) Ditto.
31 Sat Jan 28 17:20:50 2006 Ben Pfaff <blp@gnu.org>
33 Add scratch file handles.
35 Now a file handle can refer to a disk file, to an in-memory
36 structure, or to the "inline" file, instead of just to a disk
37 file. The introduction of new categories means that special cases
38 for the inline file in a few places could be eliminated, but it
39 also means that code that assumed that a handle refers to a file
40 has to check for that.
42 Also, now file handles can be freed, so code now must be sure not
43 to access a handle after closing it (with fh_close()).
45 * Makefile.am: Add any-reader.c, any-reader.h, any-writer.c,
46 any-writer.h, scratch-handle.c, scratch-handle.h,
47 scratch-reader.c, scratch-reader.h, scratch-writer.c,
48 scratch-writer.h to pspp_SOURCES.
50 * any-reader.c: New file.
52 * any-reader.h: New file.
54 * any-writer.c: New file.
56 * any-writer.h: New file.
58 * scratch-handle.c: New file.
60 * scratch-handle.h: New file.
62 * scratch-reader.c: New file.
64 * scratch-reader.h: New file.
66 * scratch-writer.c: New file.
68 * scratch-writer.h: New file.
70 * aggregate.c: Use an any_writer instead of an sfm_writer, to add
73 * apply-dict.c: Use an any_reader instead of an sfm_reader, to add
76 * command.def: Add CLOSE FILE HANDLE command.
78 * dfm-reader.c: Now fewer special cases for inline file.
79 (static var inline_open_cnt) Removed.
80 (static var inline_file) Removed.
81 (dfm_close_reader) Eliminate a special case for inline file.
82 Reorganize to avoid access-after-free.
83 (dfm_open_reader) Eliminate a special case for inline file.
84 (read_inline_record) Use bool instead of int. No need to
85 increment line number.
86 (read_file_record) Use bool instead of int.
87 (read_record) Check whether file handle is inline file, instead of
90 (dfm_expand_tabs) Ditto.
93 (cmd_begin_data) Fix inaccurate check for whether the inline file
94 is in use--now we can tell by checking whether the inline file's
95 open count is positive.
97 * file-handle-def.c: (struct file_handle) Reorder members. Add
98 `deleted' member. Add `referent' member. Add `sh' member.
99 (static var default_handle) New variable.
100 (static var inline_file) New variable.
101 (fh_init) Initialize inline file.
102 (free_handle) New function.
104 (fh_from_name) Don't return deleted handles.
105 (fh_from_filename) Ditto.
107 (create_handle) New function.
108 (fh_create_file) New function.
109 (fh_create_scratch) New function.
110 (fh_inline_file) New function.
112 (fh_open) Now requires a referent type mask and verifies it. All
114 (fh_close) If open_cnt goes to 0 on a deleted handle, free it.
115 (fh_is_open) New function.
116 (fh_get_referent) New function.
117 (fh_get_filename) Limit to handles that refer to files.
119 (fh_get_record_width) Limit to handles that refer to files or the
121 (fh_get_tab_width) Ditto.
122 (fh_get_scratch_handle) New function.
123 (fh_set_scratch_handle) New function.
124 (fh_get_default_handle) New function.
125 (fh_set_default_handle) New function.
127 * file-handle.h: (enum fh_referent) New type.
128 (enum fh_mode) Rename MODE_TEXT to FH_MODE_TEXT, MODE_BINARY to
129 FH_MODE_BINARY, and update all usages.
131 * file-handle.q: Add "scratch" as a possible mode.
132 (cmd_file_handle) Mention CLOSE FILE HANDLE in error message.
133 Use lex_end_of_command(), lex_sbc_missing(). Support creating
135 (cmd_close_file_handle) New function.
136 (referent_name) New function.
137 (fh_parse) Now takes a referent type mask to specify handles that
138 can be accepted. Updated all references.
140 * filename.c: (fn_extension) New function.
142 * get.c: Use any_reader and any_writer and thereby merge code that
143 has been duplicated for each kind of file. Also, we had something
144 here called `any_writer' before, so its name had to be changed to
146 (enum operation) Removed, because unused.
147 (struct get_pgm) Removed.
148 (get_pgm_free) Removed.
149 (get_source_destroy) Removed.
150 (get_source_read) Removed.
151 (global var get_source_class) Removed.
152 (static var case_reader_source_class) Removed.
153 (enum reader_command) New enum.
154 (struct case_reader_pgm) New struct.
155 (parse_read_command) New function.
156 (case_reader_pgm_free) New function.
157 (case_reader_source_destroy) New function.
158 (case_Reader_source_Read) New function.
159 (cmd_get) Rewrote as a call to parse_read_command().
161 (struct any_writer) Rename to case_writer. Drop `writer_type',
162 `writer' members in favor of an `any_writer' member named
164 (any_writer_destroy) Rename case_writer_destroy. Use
166 (parse_write_command) Allow scratch files. Use any_writer.
167 (any_writer_write_case) Rename case_writer_write_case(). Use
169 ` (struct mtf_file) Use any_reader.
170 (cmd_match_files) Allow scratch files. Use any_reader.
171 (mtf_free_file) Use any_reader_close().
172 (mtf_read_nonactive_records) Use any_reader_read().
173 (mtf_processing) Use any_reader_read().
174 (struct import_pgm) Removed.
175 (import_pgm_free) Removed.
176 (import_source_destroy) Removed.
177 (import_source_read) Removed.
178 (global var import_source_class) Removed.
180 * glob.c: (global var default_handle) Removed. Replaced all
181 references by fh_get_default_handle() or fh_set_default_handle().
183 * pfm-read.c: (static var portable_to_local) Moved from inside
184 read_header() to top level.
185 (pfm_detect) New function.
187 * pfm-write.c: (pfm_write_case) Make case argument const.
188 Reorganize to avoid access-after-free.
190 * print.c: (dump_table) Use fh_get_name() to describe source of
193 * sfm-read.c: (sfm_close_reader) Reorganize to avoid
195 (sfm_detect) New function.
197 * str.c: (str_lowercase) New function.
199 * vfm.c: Use new compaction interface.
200 (static var compaction_necessary) Removed.
201 (static var compactor) New variable.
202 (open_active_file) Initialize compactor.
203 (write_case) Use compactor.
204 (close_active_file) Free compactor.
206 Wed Jan 11 19:28:39 2006 Ben Pfaff <blp@gnu.org>
208 Clean up file handle code in preparation to add scratch file
211 * file-handle-def.c: Lots of formatting cleanup. Added function
213 (struct file_handle) Renamed `length' member
214 to `record_width'. All references updated.
215 (fh_init) New function. Moved here from file-handle.q.
216 (fh_done) New function. Moved here from file-handle.q and
218 (get_handle_with_name) Renamed fh_from_name().
219 (get_handle_for_filename) Renamed fh_from_filename().
220 (create_file_handle) Renamed fh_create(). Changed to take a
221 `struct fh_properties' instead of discrete values. Updated all
223 (create_file_handle_with_defaults) Removed. Updated all
224 references to use fh_create() with fh_default_properties().
225 (fh_default_properties) New function.
226 (destroy_file_handle) Removed. The code is now in fh_done().
227 (handle_get_name) Renamed fh_get_name().
228 (handle_get_filename) Renamed fh_get_filename().
229 (handle_get_record_width) Renamed fh_get_record_width().
230 (handle_get_tab_width) Renamed fh_get_tab_width().
232 * file-handle-def.h: Formatting, comment fixes.
233 (enum file_handle_mode) Renamed struct fh_mode.
234 (struct fh_properties) New structure.
235 (fh_init) Move prototype here from file-handle.h.
239 * file-handle.q: (static var handle_list) Removed.
240 (fh_parse) Don't add handle to handle_list, because
241 file-handle-def.c has its own list.
242 (fh_init) Moved to file-handle-def.c.
245 Sun Jan 9 01:09 Jason Stover <jason@sakla.net>
247 * regression.q: (run_regression) Moved coefficient initialization
248 to the linreg library. Altered other functions accordingly.
250 Sat Jan 7 13:30:54 WST 2006 John Darrington <john@darrington.wattle.id.au>
252 * command.c data-in.c main.c: Fixed bug which crept in when
253 separating getl from readline.
255 * vars-atr.c value-labels.h: Fixed constness of val_labs_count.
257 Fri Dec 23 20:59:01 WST 2005 John Darrington <john@darrington.wattle.id.au>
259 * getl.c error.c: Separated file_loc functionality from error.c
261 Mon Dec 19 14:01:56 WST 2005 John Darrington <john@darrington.wattle.id.au>
263 * format.c: Additional error checking.
264 * getl.[ch]: Separated into getl.c and readln.c
265 * settings.[ch]: Made CC_CNT public
267 Fri Dec 16 09:11:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
269 * examine.q: Fixed buglet when cleaning up at end of procedure.
271 Tue Dec 13 22:34:42 2005 Ben Pfaff <blp@gnu.org>
273 Move global initialization and cleanup code into main.c.
274 Remove vestigial log infrastructure.
275 Minor related cleanups.
277 * command.c: (shell) When execl() fails, use _exit(), not
280 * error.c: (err_hcf) Move into main.c, rename terminate(). All
282 (err_done) New function with just the error.c-specific code for
283 err_hcf(). Called by terminate().
285 * glob.c: Removed all Borland C, DJGPP cruft.
286 (init_glob) Merged into main().
287 (done_glob) Merged into terminate().
289 (get_start_date) New function. All users of curdate updated to call
290 this function instead.
292 * lexer.c: (lex_init) Moved initialization of tokstr here, from
294 (lex_done) Moved destruction of tokstr here, from done_glob().
296 * main.c: (global var pgmname) Removed. Changed all references to
297 program_name, which is defined by gnulib.
298 (global var curdate) Removed.
299 (main) Moved init_glob() code here. Merged parse_script() in
301 (parse_script) Removed.
302 (terminate) Moved err_hcf() here from error.c and renamed
303 terminate(). Merged done_glob() code in here. Call err_done().
305 (i18n_init) New function.
306 (fpu_init) New function.
308 * output.c: (outp_init) Make void.
309 (init_default_drivers) New function.
310 (outp_read_devices) If no drivers are initialized successfully,
311 call init_default_drivers() to initialize a default driver.
312 (outp_done) Make void.
313 (static var prog) Make const.
314 (parse_options) Make parameter const.
315 (colon_tokenize) Make return value const.
316 (configure_driver) Change prototype to take a broken-down driver
317 configuration instead of a line of text.
318 (configure_driver_line) New function that does what
319 configure_driver() did before.
321 * q2c.c: (global var pgmname) Rename program_name.
323 * settings.c: (settings_init) Renamed from init_settings().
324 (settings_done) Renamed from done_settings().
326 * vfm.c: (global var last_vfm_invocation) Make static.
327 (vfm_last_invocation) New function. All references to
328 last_vfm_invocation update to call this.
329 (procedure) Call update_last_vfm_invocation().
330 (internal_procedure) Ditto.
331 (update_last_vfm_invocation) New function.
333 Sat Dec 10 23:30:19 2005 Ben Pfaff <blp@gnu.org>
335 Separate random numbers from other settings because of GSL
338 * Makefile.am: Add random.c, random.h to sources.
340 * glob.c: (init_glob) Call random_init().
341 (done_glob) Call random_done().
343 * settings.c: (static var rng) Move to random.c.
344 (done_settings) Move freeing of RNG to random_done().
345 (get_rng) Move to random.c
348 * random.c: New file.
350 * random.h: New file.
352 Sat Dec 10 18:13:36 2005 Ben Pfaff <blp@gnu.org>
354 Separate settings and the SET command, for modularity.
356 * Makefile.am: Add settings.c to sources.
358 * glob.c: (global variable test_mode) Removed.
360 * set.q: Remove all the set_* variables. Remove a lot of obsolete
361 SPSS/PC+ settings. Remove the aux_*() routines. Moved the
362 get_*() functions into settings.c. Rewrite the settings code and
363 functions to call the new set_*() functions. Rewrite custom
364 currency parsing. Write new by-hand cmd_show().
366 * esttings.c: New file. Moved the get_*() functions here from
367 set.q. Created new set_*() functions to correspond with them.
368 Regularized the names and types of some functions and updated
369 their callers. Added static, file-scope variables to support the
372 * q2c.c: Remove "aux" support, which was only needed by set.q.
374 Sun Nov 27 06:43:46 WST 2005 John Darrington <john@darington.wattle.id.au>
376 * data-out.c format.h: Added return value to data_out function.
378 * value-labels.c: Fixed bug in val_labs_remove.
380 Sat Nov 5 18:37:26 2005 Ben Pfaff <blp@gnu.org>
382 * Makefile.am: Remove devind.c, devind.h from list of source
389 * list.q: Removed "support" for devind.
391 * output.c: Don't add devind class.
393 Sat Nov 5 18:21:00 2005 Ben Pfaff <blp@gnu.org>
395 * var.h: (struct variable) Make `init', `reinit' bool values.
398 Fri Nov 4 19:43:01 2005 Ben Pfaff <blp@gnu.org>
400 * recode.c: Rewrote whole file, as clean-up.
402 Fri Nov 4 19:37:50 2005 Ben Pfaff <blp@gnu.org>
404 * pool.c: Don't make alignment exception for x86.
405 (pool_alloc) Return null for 0-size blocks.
406 (pool_alloc_unaligned) New function.
407 (pool_strndup) Removed. Changed callers to use pool_clone_unaligned().
408 (pool_clone_unaligned) New function.
409 (pool_strdup) Use pool_clone_unaligned().
411 * var.h: (enum var_type) Give the NUMERIC, ALPHA enum this name.
412 (struct variable) Use `enum var_type' for `type'.
414 * vars-atr.c: (var_type_adj) New function.
415 (var_type_noun) New function.
417 * vars-prs: (parse_mixed_vars) Fix freeing code.
418 (parse_mixed_vars_pool) New function.
420 Wed Nov 2 21:24:48 2005 Ben Pfaff <blp@gnu.org>
422 * file-handle-def.c: Needed another #include, to avoid missing
425 * file-handle.q: (cmd_file_handle) Declarations must precede
426 statements. Free parse data on success as well as on failure, to
429 * get.c: (parse_write_command) Destroy dict on success, to avoid
432 * data-list.c: (cmd_repeating_data) Fix usage of saw_occurs,
433 saw_length, saw_continued, saw_id, which were boolean but
434 incorrectly treated as bitmaps as result of a previous
435 half-finished cleanup.
437 * weight.c: (struct weight_trns) Unused, so removed.
439 * Makefile.am: Add range-prs.h to sources.
441 Wed Nov 2 21:24:15 2005 Ben Pfaff <blp@gnu.org>
445 * Makefile.am: Add ctl-stack.c, ctl-stack.h to source files.
446 Reformat source file list to list one file per file, so that
447 patches for future changes will be easier to read.
449 * ctl-stack.c, ctl-stack.h: New files.
451 * do-if.c: Rewrote whole file.
455 * loop.c: Rewrote whole file.
457 * glob.c: (global var ctl_stack) Move into ctl-stack.c.
459 * temporary.c: (cmd_temporary) Use ctl_stack_is_empty().
461 * vfm.c: (open_active_file) Use ctl_stack_clear().
463 Wed Nov 2 21:18:13 2005 Ben Pfaff <blp@gnu.org>
467 * pool.c: (pool_create_at_offset) New function.
468 (pool_add_subpool) New function.
470 * pool.h: (pool_create_container) New macro.
472 * expressions/parse.c: (expr_parse_pool) New function.
474 * autorecode.c: (recode) Use pool_create_container().
476 * count.c: (cmd_count) Ditto.
478 Wed Nov 2 19:59:32 2005 Ben Pfaff <blp@gnu.org>
480 Clean up transformations, by getting rid of `struct trns_header',
481 replacing it by `struct transformation' that has a void *
482 `private' member. Updated all uses of transformations to match,
483 which was a lot of code. Only major related changes listed below.
485 * compute.c: (cmd_if) Use get_proc_func().
486 (cmd_compute) Use get_proc_func().
487 (get_proc_func) New function.
489 * glob.c: (global var m_trns) Change type to size_t.
490 (global var n_trns) Ditto.
491 (global var f_trns) Ditto.
492 (global var t_trns) Change type to struct transformation *.
494 * var.h: (struct trns_header) Removed.
495 (struct transformation) New.
496 (typedef trns_proc_func) Takes a void * instead of a struct
498 (typedef trns_free_func) Ditto.
500 * vfm.c: (execute_transformations) Takes an array of
501 transformations instead of trns_headers.
502 (add_transformation) Change prototype from (trns_header *) to
503 (trns_proc_func *, trns_free_func *, void *).
504 (next_transformation) New function.
506 Sat Oct 29 16:25:36 2005 Ben Pfaff <blp@gnu.org>
508 * count.c: Major cleanups. Rename practically everything.
509 Rewrite much of the code. Use pools for memory management. Use
510 the new parse_num_range().
512 * mis-val.c: (cmd_missing_values) Use the new parse_num_range().
513 (parse_number) Removed.
515 * missing-values.c: (mv_add_num_range) Don't add out-of-order
516 ranges, e.g. where low > high.
518 * pool.c: (pool_2nrealloc) New function.
520 * range-prs.c: New file.
521 (parse_num_range) New function.
522 (parse_number) New function.
524 Fri Oct 28 22:47:48 2005 Ben Pfaff <blp@gnu.org>
526 Fix up potential overflows in size calculations by replacing
527 instances of pool_alloc(p, x * sizeof *y) by pool_malloc(p, x,
528 sizeof *y) everywhere I could find them. Similarly by
529 pool_malloc(), pool_realloc().
530 (Order is important: pool_alloc(p, sizeof *y, x) will divide by 0
533 * pool.c: (pool_nalloc) New function.
534 (pool_nmalloc) New function.
535 (pool_nrealloc) New function.
537 Thu Oct 27 11:16:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
539 Separated the definition of a file handle object from the stuff
540 pertaining to the FILE HANDLE command.
542 * file-handle-def.[ch]: New files.
544 * dfm-read.c file-handle.h file-handle.q
546 Tue Oct 25 21:56:23 2005 Ben Pfaff <blp@gnu.org>
548 Fix up potential overflows in size calculations by replacing
549 instances of xmalloc(x * sizeof *y) by xnmalloc(x, sizeof *y)
550 everywhere I could find them. Similarly by xrealloc(), malloc().
551 (Order is important: xnmalloc(sizeof *y, x) will divide by 0 if x
554 * alloc.c: (nmalloc) New function.
555 (out_of_memory) Removed. Replaced references by xalloc_die().
557 * sort.c: (allocate_cases) Fix segfault if memory allocation
560 * subclist.c: (subc_list_double_create) Use xnmalloc() instead of
562 (subc_list_double_push) Use xnrealloc() instead of realloc().
564 Wed Oct 26 08:43:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
566 Dictionary abstraction part #2
568 * algorithm.c format.c str.c sysfile-info.c val.h var.h vars-atr.c:
569 Removed unnecessary #include directives
571 Mon Oct 24 21:35:08 2005 Ben Pfaff <blp@gnu.org>
573 * groff-font.c (font_msg): Use err_vmsg() instead of incorrectly
574 trying to pass a va_list to tmsg(). Thanks to Jason Stover for
577 Mon Oct 24 21:24:15 2005 Ben Pfaff <blp@gnu.org>
579 Work to get rid of GCC 4.0 warnings, part 2.
581 In many files, change `unsigned char' to `char'. This often
582 requires adding casts to <ctype.h> functions.
584 * data-in.c: (parse_A) Use buf_copy_rpad().
586 * str.c: (str_copy_buf_trunc) New function.
588 * value-labels.c: (value_to_string) Fix mistaken use of strncpy(),
591 Mon Oct 24 13:42:32 WST 2005 John Darrington <john@darrington.wattle.id.au>
593 Moved some definitions to make it easier to abstract a dictionary
594 from the rest of PSPP.
596 * format-prs.c lex-def.[ch]: New files.
598 * Makefile.am lexer.[ch] dictionary.c vars-atr.c vfm.c algorithm.c
599 format.c: Moved some functions between modules.
601 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
603 Work to get rid of GCC 4.0 warnings, part 1.
605 In many files, change count parameters to parse_variables(),
606 etc. from `int' to `size_t'. Also change related variables and
607 struct members. Also change messages as needed (e.g. %d to %u
608 with cast to unsigned). Also change arithmetic as necessary
609 (e.g. n >= m - 1 to n + 1 >= m).
611 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
614 * q2c.c: (dump_declarations) Generate code for size_t instead of
617 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
619 * output.c: (outp_read_devices) Fix message.
621 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
623 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
624 address is passed to dict_get_vars() from size_t to int to match
627 * modify-vars.c: (validate_var_modification) Ditto.
629 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
631 * dictionary.[ch] Changed cnt from size_t* to int* since that's
632 what it's called as, and on x86_64 machines they're different sizes.
634 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
636 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
638 * lexer.c: (lex_sbc_only_once) New function.
639 (lex_sbc_missing) New function.
641 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
643 * case.h: (case_str) Make it return `unsigned char'.
645 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
647 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
648 subcommands that we didn't support. Fix bug 13911. Fix bug
649 reported by Adam Pierson (COMPRESSED and other subcommands didn't
650 work on SAVE). Refactor all related code.
652 * command.def: Add XEXPORT command.
654 * dictionary.c: (dict_delete_scratch_vars) New function.
656 * get.c: (cmd_get) Fix parsing.
657 (struct save_trns) Removed.
658 (cmd_save_internal) Removed.
660 (do_write_case) Removed.
661 (save_write_case_func) Removed.
662 (save_trns_proc) Removed.
663 (save_trns_free) Removed.
664 (trim_dictionary) Removed.
665 (struct export_proc) Removed.
666 (cmd_export) Rewrote.
667 (export_write_case_func) Removed.
668 (export_proc_free) Removed.
669 (enum writer_type) New enum.
670 (enum command_type) New enum.
671 (struct any_writer) New struct.
672 (any_writer_destroy) New function.
673 (parse_write_command) New function.
674 (any_writer_write_case) New function.
675 (parse_output_proc) New function.
676 (output_proc) New function.
679 (struct output_trns) New struct.
680 (parse_output_trns) New function.
681 (output_trns_proc) New function.
682 (output_trns_free) New function.
684 (cmd_xexport) New function.
685 (parse_dict_trim) New function.
686 (struct mtf_proc) Change `by_cnt' member type to `int'.
687 (cmd_import) Rewrote.
689 * pfm-write.c: (struct pfm_writer) Add `digits' member.
690 (pfm_writer_default_options) New function.
691 (pfm_open_writer) Add `opts' argument and handle options.
692 (write_float) Write only as many digits as `digits' member says.
693 (format_trig_double) Limit base-10 precision to LDBL_DIG.
695 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
696 (struct pfm_write_options) New struct.
698 * sfm-write.c: (sfm_writer_default_options) New function.
699 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
700 `opts' argument. Implement options.
702 * sfm-write.h: (struct sfm_write_options) New struct.
704 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
705 char *' instead of `char *'.
707 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
709 * factor_stats.c: Needed <config.h> included earlier.
711 * percentiles.c: Needed to include <config.h>.
713 * val.h: Don't include "config.h".
715 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
717 Clean up treatment of missing values by moving all the code into
718 one place. All references to the missing value function were
719 updated, but only major changes are detailed below.
721 * Makefile.am: Add missing-values.c, missing-values.h to sources.
723 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
725 * dictionary.c: (dict_create_var) Initialize `miss' member with
727 (dict_clone_var) Copy `miss' member with mv_copy().
729 * get.c: (mtf_merge_dictionary) Use mv_copy().
731 * missing-values.c: New file.
733 * missing-values.h: New file.
735 * mis-val.c: Rewrite. New version implements updated semantics.
737 * pfm-read.c: (read_variables) Rewrite missing value handling.
739 * pfm-write.c: (write_variables) Rewrite missing value handling.
741 * sfm-read.c: (read_variables) Rewrite missing value handling.
743 * sfm-write.c: (write_variable) Rewrite missing value handling.
745 * sfmP.h: Include "magic.h" to get definition of
748 * sysfile-info.c: (describe_variable) Rewrite missing value
751 * val.h: Include "magic.h" to get definition of
754 * var.h: Include "missing-values.h". Drop MISSING_* enums.
755 (struct variable) Remove `miss_type', `missing'. Add `miss'.
757 * vars-atr.c: (is_num_user_missing) Removed--use
758 mv_is_num_user_missing().
759 (is_str_user_missing) Removed--use mv_is_str_user_missing().
760 (is_system_missing) Removed--use mv_is_value_system_missing().
761 (is_missing) Removed--use mv_is_value_missing().
762 (is_user_missing) Removed--use mv_is_value_user_missing().
764 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
766 Adopt use of gnulib for portability.
768 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
771 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
772 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
775 * In many source files, added an explicit inclusion of gettext.h
776 and definition of _ macro. These are no longer in pref.h because
777 it interfered with definitions in a few gnulib source files.
779 * In many source files, changed #include "bool.h" to #include
780 <stdbool.h>, which is provided by gnulib.
782 * alloc.c: Removed functions defined in gnulib:
787 (out_of_memory) Redefined as wrapper for xalloc_die().
789 * alloc.h: Replace prototypes by #include "xalloc.h".
791 * casefile.c: Use full_read() and full_write() from gnulib instead
792 of our home-grown versions.
794 (full_write) Removed.
796 * getline.c: Renamed getl.c.
798 * getline.h: Renamed getl.h, updated all references.
800 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
803 * glob.c: Just #include <time.h> instead of the crazy rigmarole
805 (init_glob) Call set_program_name() to initial gnulib progname
808 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
810 * permissions.c: Use "stat-macros.h" from gnulib.
812 * postscript.c: Just #include <time.h> instead of the crazy
813 rigmarole here before.
815 * q2c.c: (main) Make generated code #include "gettext.h".
817 * str.h: Get rid of most explicit declarations of standard
818 functions, in favor of including gnulib header files.
820 * expressions/evaluate.c: Ditto.
822 * expressions/operations.h.pl: Make generated code #include
823 <stdbool.h>, not "bool.h".
825 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
827 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
830 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
832 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
833 null pointer to printf for %.*s.
835 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
837 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
840 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
842 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
844 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
846 * postscript.c: (postopen) Cast `char' to `unsigned char' before
847 passing to isspace().
849 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
851 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
853 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
855 * histogram.c: Include <config.h>.
857 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
859 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
861 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
863 * format.c: (check_common_specifier) Fix msg() bug found by
865 (check_output_specifier) Ditto.
867 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
869 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
872 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
874 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
875 avoid "unused variable" warning.
877 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
879 * command.c: (find_word) Cast `char' to `unsigned char' before
880 passing to isspace().
882 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
884 * case.c: (case_compare) Implement as delegating to
885 case_compare_2dict().
887 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
889 * algorithm.c: Inclusion of <alloca.h> is unneeded.
891 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
893 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
894 -ansi changes the behavior of header files significantly. It
895 causes __STRICT_ANSI__ to be defined, and some headers interpret
896 that as cause to e.g. not use `long long' or __attribute__. The
897 former example is bad when off_t is supposed to be `long long',
898 and the latter prevents -Wformat from working.
900 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
902 Get rid of dependency on libgmp by writing our own routine for
903 floating-point base conversion.
905 * pfm-write.c: (write_float) Rewrote.
907 (pow30_nonnegative) New function.
908 (pow30) New function.
909 (trig_to_char) New function.
910 (format_trig_digits) New function.
911 (recurse_format_trig_int) New function.
912 (format_trig_int) New function.
913 (should_round_up) New function.
914 (try_round_up) New function.
915 (format_trig_double) New function.
917 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
919 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
922 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
924 * pfm-read.c: (read_version_data) Read and ignore author field.
926 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
928 * get.c: (mtf_processing) Don't assume that
929 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
930 returns a negative, zero, or positive result. Fixes MATCH FILES
931 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
933 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
935 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
936 preprocessor test for sys/types.h was accidentally inverted. This
939 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
941 * get.c: (cmd_match_files) Fix memory leak on `by' and on
944 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
947 * vfm.c: (close_active_file) Remove unnecessary test.
949 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
951 Fix NDEBUG compile errors.
953 * hash.h: Needed explicit #include <assert.h>.
955 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
958 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
960 Implement embedding for PostScript driver. Fixes bug 12970.
962 * ascii.c: Fix compiler warnings.
966 * chart.h: Add `file' member.
968 * output.h: (struct outp_class) initialise_chart, finalise_chart
969 should take outp_driver *, not outp_class *. Update all
972 * plot-chart.c: (chart_create) Fix segfault when there are no
973 output drivers at all.
974 (chart_submit) Call d->class->finalise_chart.
976 * postscript.c: (ps_open_page) Set cp_y to 0.
977 (ps_submit) New function.
978 (ps_chart_initialise) Implement.
979 (ps_chart_finalise) Implement.
980 (static var postscript_class) Add ps_submit.
981 (static var epsf_class) Add ps_submit.
984 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
986 Did some more work on bug 12859 and then realized that a *good*
987 solution would require some fundamental restructuring. For now,
988 I'm marking REPEATING DATA unimplemented, and then we can revisit
991 * command.def: Make REPEATING DATA unimplemented.
993 * data-list.c: (cmd_repeating_data) Assume inline file is 80
995 (realize_value) Revert previous changes; no longer needed.
998 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
999 file_loc, to avoid bad references later.
1003 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
1005 Make some code tolerant of reentry. Should not be needed if other
1006 code is correct but it is good to be generally tolerant.
1008 * error.c: (err_hcf) Set file_loc to null after free().
1010 * output.c: (outp_done) Similar changes.
1012 * str.c: (ds_destroy) Ditto.
1014 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
1016 Continue work on bug 12859, plus some code cleanup.
1018 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
1019 boolean variables. Don't try to compute starts_end, cont_end for
1020 inline file. Calculate length only after parsing variable
1021 specifications. Add proper transformation to list.
1022 (realize_value) If the rpd_num_or_var has no value, return new
1023 DEFAULT_MEMBER argument (for use with inline file).
1024 (repeating_data_trns_proc) Pass default values.
1026 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
1027 open, and only if we actually started reading data.
1029 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
1033 * output.c: (outp_read_devices) Fix message.
1035 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1037 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
1038 of the sort algorithm from the parser for the SORT command.
1040 * rank.q: Added the parser for the RANK command.
1042 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
1046 * sort.c: (sort_parse_criteria) Only set *saw_direction if
1047 saw_direction is non-null. Thanks to John Darrington for
1050 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
1052 * get.c: (mtf_processing) Handle case of a lookup table as the
1053 active file. Thanks to John Darrington for reporting this bug.
1055 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1057 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
1058 POSIX calloc function.
1060 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
1061 reflect new signature.
1063 * sfm-read.c: Now much more robust in the face of badly formed
1066 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
1068 *sfm-read.c: Fixed some bugs regarding long string continuation
1069 records, which the previous fix uncovered.
1071 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
1073 * sfm-read.c, sfmP.h: Allow reading of system files when the
1074 case_size value in the header is -1. Also changed some Errors to
1075 Warnings when reading system files.
1077 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
1079 * data-list.c: (data_list_trns_free) Don't free the argument
1080 because cancel_transformations() will do that itself.
1081 (data_list_source_destroy) Destroy the argument to
1082 data_list_trns_free(), because it no longer does so itself.
1084 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
1086 * data-out.c: (format_and_round) Don't output leading `-' if value
1089 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
1093 * som.c: (output_encodings) If some cell in the table won't fit
1094 with the horizontal or vertical headers, cancel those headers.
1096 * som.h: (struct som_table_class) Add fits_width, fits_length,
1097 set_headers members.
1099 * tab.c: (tabi_fits_width) New function.
1100 (tabi_fits_length) New function.
1101 (tabi_set_headers) New function.
1102 (global var tab_table_class) Add the new functions as appropriate
1105 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
1107 Fix rest of bug 13054.
1109 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
1110 DATETIME, TIME system/portable file values.
1112 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
1114 * data-list.c: (parse_free) Use make_input_format().
1116 * data-out.c: (num_to_string) Use make_output_format().
1118 * dictionary.c: (dict_create_var) Ditto.
1120 * format.c: (global var f8_2) New var.
1121 (make_input_format) New function.
1122 (make_output_format) New function.
1124 * get.c: (cmd_match_files) Use make_output_format().
1126 * list.q: (cmd_list) Ditto.
1128 * matrix-data.c: Ditto.
1130 * sfm-read.c: (parse_format_spec) Check output specifier
1133 * tab.c: (tab_float) Use make_output_format().
1135 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
1137 Fix more of bug 13054.
1139 * format.def: FMT_A should allow 255-character output. FMT_AHEX
1140 should allow 510-character input and output.
1142 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
1143 (convert_E) Handle non-finite values.
1145 (format_and_round) New function.
1146 (convert_infinite) New function used by try_F() and convert_E().
1148 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
1150 Regularize string and buffer function names so that they make some
1153 * str.c: (mm_reverse) Rename buf_reverse(). Update all
1155 (mm_find_reverse) Rename buf_find_reverse(). Update all
1157 (mm_case_compare) Rename buf_compare_case(). Update all
1159 (st_compare_pad) Rename buf_compare_rpad(). Update all
1161 (str_compare_rpad) New function.
1162 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
1164 (buf_copy_str_lpad) New function.
1165 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
1167 (st_pad_copy) Rename str_copy_rpad(). Update all references.
1168 (st_trim_copy) Rename str_copy_trunc(). Update all references.
1169 (st_uppercase) Renamed str_uppercase(). Update all references.
1171 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1173 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
1176 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
1178 * data-in.c: (data_in) Add assertion to check input specifier.
1180 * data-out.c: (data_out) Add assertion to check output specifier.
1182 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
1184 Start to fix bug 13054.
1186 * format.c: (check_input_specifier) Improve error message.
1187 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
1188 valid decimal places.
1189 (check_output_specifier) Ditto (but different criteria).
1190 (convert_fmt_ItoO) Assert valid input and output specifiers.
1191 Also, if input specifier has *any* decimal places, make the output
1192 specifier 1 place wider.
1194 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
1196 * sysfile-info.c: Fixed bug [# 13024 ]
1198 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
1200 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
1201 actually implement it.
1203 * command.c: (FILE_TYPE_okay) Always return 1.
1205 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
1207 * file-type.c: Add prototypes to get rid of warnings.
1209 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
1211 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
1212 more ISO/IEC 9899:1990 conformance issues.
1214 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
1216 Fix bug 12948. See also new test in
1217 tests/bugs/match-file-scratch.sh.
1219 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
1220 that deletes scratch variables that someone else might be using,
1221 and because we can't reassign our sources' value indexes.
1222 Instead, simply don't copy scratch variables into the master
1225 * dictionary.c: (dict_compact_values) Delete variables from the
1226 dictionary passed in, not from default_dict (!).
1228 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
1230 Improve hash.c comments, error-checking.
1232 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
1233 (hsh_create) size == 0 should *not* return NULL! Set
1235 (hsh_clear) Set hash_ordered.
1236 (locate_matching_entry) Check hash_ordered.
1237 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
1238 (hsh_data) Set hash_ordered. Add const-ness to return value and
1242 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1244 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
1246 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1248 * copyleft.c: Updated copyright date.
1250 * Makefile.am: Removed erroneous explicit "-lplot"
1252 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
1254 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
1256 * command.c command.def: Added description string for unimplemented commands.
1258 * oneway.q: Sorted the hash tables before shipping out the results. Closes
1261 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
1265 * data-list.c: (parse_fixed) Use lex_end_of_command().
1267 (cmd_repeating_data) Set cont_end.num in right situations.
1268 (parse_repeating_data) Remove redundant test.
1270 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
1272 Partial fix for bug 12859.
1274 * data-list.c: (cmd_data_list) Add transformation properly in
1275 vfm_source == NULL case.
1277 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
1279 * lexer.c: (lex_error) Improve error messages.
1281 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
1283 * get.c: (cmd_match_files) Check token type before trying to match
1284 tokid. Fixes bug 12923.
1286 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
1288 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
1291 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
1293 * expressions/generate.pl: (get_token) Make use of /g
1294 backward-compatible with Perl 5.6.1.
1296 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
1298 * var-display.c: (cmd_variable_alignment) Fix memory leak.
1299 (cmd_variable_level) Ditto.
1301 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
1303 Hash table had buggy deletion function. The fix required changing
1304 other functions to do probing in the required order.
1306 * hash.c: (locate_matching_entry) Rewrite and change interface.
1307 (hsh_rehash) Rewrite to use locate_matching_entry().
1310 (hsh_delete) Ditto. Also, fix stupid bugs.
1312 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
1314 * dictionary.c: (dict_clone) Properly copy vectors.
1316 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
1318 New implementation of long variable names. Each variable has a
1319 "normal" name, which may be up to 64 bytes long and which is used
1320 for all normal operations. Variables may have a "short" name,
1321 which is limited to 8 bytes and used only for system and portable
1322 file input and output.
1324 Make tokid case-preserving. Update most uses of tokid to treat it
1327 Update many commands to deal with long variable names.
1329 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
1331 * command.c: (cmd_parse) Ditto.
1332 (match_strings) Use toupper() before comparing characters.
1333 (conflicting_3char_prefixes) Use mm_case_compare() instead of
1335 (cmd_match_words) Ditto.
1337 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
1340 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
1341 Use st_trim_copy() instead of strcpy().
1343 * data-in.c: (parse_enum) Use mm_case_compare() instead of
1346 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
1348 (parse_free) Use st_trim_copy() instead of strcpy().
1350 * descript.c: (struct dsc_var) Change z_name[] to fit long var
1352 (try_name) Use strcasecmp() instead of strcmp().
1353 (generate_z_varname) Use st_trim_copy() instead of strcpy().
1354 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
1357 * dictionary.c: (struct dictionary) Removed `long_name_tab'
1359 (compare_long_names) Removed.
1360 (hash_long_name) Removed.
1361 (dict_create) Don't initialize `long_name_tab' member.
1362 (dict_clone) Copy short names into new dictionary.
1363 (dict_clear) Don't clear `long_name_tab' member.
1364 (dict_get_varname_block) Removed.
1365 (dict_add_longvar_entry) Removed.
1367 (dict_destroy) Don't destroy `long_name_tab' member.
1368 (dict_create_var_from_short) Removed.
1369 (dict_create_var_x) Removed.
1370 (dict_create_var) Get rid of longname handling.
1372 (dict_clone_var) Get rid of longname parameter and longname
1374 (dict_lookup_var) Get rid of longname handling.
1375 (dict_reorder_var) New function.
1376 (dict_rename_var) Clear short name.
1377 (dict_rename_vars) Get rid of longname handling. Clear short
1379 (dict_create_vector) Support long vector names.
1380 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
1381 (quasi_base27) Removed.
1382 (make_short_name) Removed.
1383 (compare_strings) New function.
1384 (hash_string) New function.
1385 (dict_assign_short_names) New function.
1387 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
1389 (get_handle_for_filename) Support long handle names.
1391 * file-type.c: (struct col_spec) Make `name' fit long var names.
1392 (cmd_file_type) Use strcasecmp() instead of strcmp().
1394 * flip.c: (make_new_var) Rewrite.
1395 (flip_sink_write) Use st_trim_copy() instead of strncpy().
1397 * format.c: (parse_format_specifier_name) Use mm_case_compare()
1398 instead of memcmp().
1400 * get.c: (cmd_save_internal) Rephrase.
1401 (rename_variables) Drop test for identical variable name.
1402 (struct mtf_proc) Change `first', `last' to fit long var name.
1404 * hash.c: (hsh_hash_case_string) New function for case-insensitive
1407 * lexer.c: (restore_token) Use st_trim_copy() instead of
1409 (lex_get) Don't uppercase string when copying into tokid.
1410 (lex_put_back_id) Use st_trim_copy() instead of
1413 * list.q: (determine_layout) Consider length of variable names in
1414 choosing vertical layout.
1416 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
1418 (string_to_content_type) Ditto.
1420 * modify-vars.c: (compare_variables_given_ordering) Ditto.
1421 (struct var_renaming) Change `new_name' to fit long var name.
1422 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
1425 * pfm-read.c: (read_variables) Disallow system variables in system
1427 (write_variables) Call dict_assign_short_names() and use
1428 short_name[] members.
1430 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
1433 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
1434 map. Reorder variables into same order as long variable map.
1435 (read_variables) Set short name.
1437 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
1438 (write_variable) Use st_bare_pad_copy().
1439 (write_longvar_table) Rewrite.
1441 * str.c: (mm_case_compare) New function.
1443 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
1444 instead of strcmp().
1446 * t-test.q: (tts_custom_groups) Remove redundant test.
1447 (tts_custom_pairs) Ditto.
1449 * var.h: (struct variable) Change `name' to fit long var names.
1450 Remove `longname'. Add `short_name' member. Reorder some
1452 (struct name_table_entry) Removed.
1453 (struct vector) Change `name' to fit long vector names.
1455 * vars-atr.c: (var_is_valid_name) Allow long var names.
1456 (compare_var_names) Use strcasecmp() instead of strcmp().
1457 (compare_var_ptr_names) Ditto.
1458 (hash_var_name) Use hsh_hash_case_string().
1459 (hash_var_ptr_name) Ditto.
1460 (var_set_short_name) New function.
1461 (var_clear_short_name) New function.
1462 (var_set_short_name_suffix) New function.
1464 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
1465 Use strcasecmp() instead of strcmp().
1466 (struct array_var_set) Removed `longname_tab'.
1467 (array_var_set_lookup_var_idx) Drop longname_tab support.
1468 (array_var_set_destroy) Don't destroy `longname_tab'.
1469 (var_set_create_from_array) Don't create `longname_tab'.
1471 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
1474 * expressions/parse.c: (word_matches) Use mm_case_compare()
1475 instead of memcmp().
1476 (compare_strings) New function.
1477 (lookup_function) Use compare_strings() instead of strcmp().
1479 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
1481 * algorithm.c: (move_element) New function.
1483 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
1485 * aggregate.c: (parse_aggregate_functions) Always initialize
1488 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
1490 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
1492 * dictionary.c: (dict_clone) Ditto.
1493 (dict_clone_var_assert) New function.
1495 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
1497 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1499 * error.c: Added a string for the compiler version to the
1500 request_bug_report_and_abort function.
1502 * groff_font.c, font.c: Removed manpage(1) style references from
1503 comments, because RMS frowns upon them.
1505 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
1507 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
1509 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
1511 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
1512 Fixed bug [#12858] .
1514 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
1516 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
1517 which should be LONG_NAME_LEN
1519 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
1521 * command.def echo.c: Added the ECHO command.
1523 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
1525 Finish fixing MATCH FILES (bug 11677).
1527 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
1528 keep_variables(), rename_variables().
1529 (drop_variables) New function.
1530 (keep_variables) New function.
1531 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
1532 (cmd_match_files) Deal with in_var. Use drop_variables(),
1533 keep_variables(). When IN is specified, require BY. Set master
1534 variables after master dictionary is complete. Add IN variables
1535 after master dictionary is complete.
1536 (mtf_free_file) Free `in_name'.
1537 (mtf_delete_file_in_place) Set in_var value to 0.
1538 (mtf_read_nonactive_records) Rephrase.
1539 (mtf_processing) Support IN. Rephrase. Fix bugs.
1540 (mtf_merge_dictionary) Don't set master variables; we do that
1542 (get_master) Don't insist that there's a master variable.
1544 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
1546 Kluge to make some variable renaming sort of work.
1549 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
1551 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
1553 Add functions for comparing sets of variables between cases.
1556 * case.c: (case_compare) New function.
1557 (case_compare_2dict) New function.
1559 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
1561 (cmd_aggregate) Nullify break_case. Don't call
1562 initialize_aggregate_info().
1563 (agr_destroy) Destroy break_case.
1564 (aggregate_single_case) Rewrite. Use case_compare().
1565 (dump_aggregate_info) Copy from break_case into output.
1566 (initialize_aggregate_info) Copy break_case from input.
1568 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
1570 * vfm.c: (equal_splits) Use case_compare().
1572 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
1574 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
1576 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
1578 Start work on fixing MATCH FILES.
1580 * get.c: (enum operation) Remove OP_MATCH.
1581 (trim_dictionary) Change return value to bool. Don't support
1583 (struct mtf_file) Remove `first', `last' members.
1584 (struct mtf_proc) Add `first', `last' members. Change mtf_case
1585 from `struct ccase *' to `struct ccase'. Remove `by' member.
1586 (cmd_match_files) Essentially rewrite.
1587 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
1588 (mtf_read_nonactive_records) mtf_ parameter is not unused.
1589 (mtf_processing) Ditto. Also rephrase some code.
1590 (mtf_merge_dictionary) Rewrite for easy comprehension.
1592 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
1594 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
1597 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
1599 Thu Apr 14 2005 John Darrington
1601 * var-display.c: New file.
1603 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
1604 display_width, measure and alignment parameters to variables.
1606 * aggregate.c command.def compute.c count.c data-list.c descript.c
1607 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
1608 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
1609 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
1610 vars-prs.c vector.c :
1611 - Replaced literal constants representing maximum variable name
1612 length with macro definitions.
1613 - Added support for long variable names.
1614 - Changed lexer such that it no longer makes tokens upper
1615 case, but relies upon case insensitive behaviour of commands.
1617 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
1619 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
1620 fails, don't dereference the resulting null pointer (bug 12427).
1621 Also, fix double free error.
1623 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
1625 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
1626 (accumulate_aggregate_info) Set int1 to 1 for SUM.
1627 (dump_aggregate_info) Only make SUM non-missing if there was at
1630 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
1632 * aggregate.c: (dump_aggregate_info) Properly test whether the
1633 destination variable is numeric, when making the result
1634 system-missing for columnwise missing values.
1636 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
1638 * misc.h: Remove GCC specializations.
1640 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
1642 Make sort stable (bug 12313).
1644 * sort.c: Don't need to include some headers anymore.
1645 (static var min_buffers) New variable.
1646 (static var max_buffers) New variable.
1647 (static var allow_internal_sort) New variable.
1648 (cmd_sort_cases) Add test mode.
1649 (sort_execute) Rephrase.
1650 (do_internal_sort) Don't try internal sorting if
1651 allow_internal_sort is set.
1652 (struct external_sort) Renamed `initial_runs' to `runs' and
1653 updated all references.
1654 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
1655 (macro MIN_BUFFER_SIZE_BYTES) Removed.
1656 (macro MIN_BUFFER_SIZE_RECS) Removed.
1657 (compare_initial_runs) Removed.
1658 (struct record_run) Add member `idx'.
1659 (write_initial_runs) Pass increasing values to process_case() as
1661 (process_case) Add `idx' parameter and use it to initialize new
1663 (allocate_cases) Limit allocated buffers to max_buffers.
1664 (compare_record_run) Use new `idx' member for last resort
1665 comparison, for stability.
1666 (end_run) Call casefile_sleep() on irs->casefile, to prevent
1667 running out of file descriptors.
1668 (struct merge_state) Removed.
1669 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
1670 unless we have fewer runs left. Always merge consecutive runs,
1671 for stability. Return the final run.
1673 (choose_merge) New function.
1674 (merge_once) Rewritten.
1676 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
1678 * cmdline.c: (static var testing_mode) Move into
1679 parse_command_line().
1681 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
1683 * algorithm.c: (remove_range) New function.
1684 (remove_element) New function.
1686 * dictionary.c: (dict_delete_var) Use remove_element().
1688 * flip.c: (cmd_flip) Ditto.
1690 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
1692 * file-handle.q: (struct file_handle) `open_mode' should not be
1695 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
1697 First phase of making SORT CASES stable (bug 12313).
1699 * sort.c: (struct indexed_case) New structure.
1700 (do_internal_sort) Rewrite to make internal sorting stable.
1701 (compare_case_dblptrs) Removed.
1702 (compare_indexed_cases) New function.
1704 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
1708 * casefile.c: (casereader_read_xfer_assert) New function.
1710 * dictionary.c: (dict_compact_case) New function.
1712 * flip.c: (struct flip_pgm) New member idx_to_fv.
1713 (cmd_flip) Initialize idx_to_fv member.
1714 (destroy_flip_pgm) Free idx_to_fv member.
1715 (flip_sink_write) Use struct flip_pgm member instead of case_sink
1717 (flip_sink_write) Ditto.
1719 * vfm.c: (write_case) Use dict_compact_case() instead of
1721 (compact_case) Removed.
1722 (storage_source_create) Removed `dict' parameter. All references
1725 * vfm.h: (struct case_source) Removed `value_cnt' member. All
1727 (struct case_sink) Removed `dict', `idx_to_fv' members. All
1730 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
1732 More AGGREGATE fixes.
1734 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
1735 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
1737 (initialize_aggregate_info) Fix initialization for MIN, MAX for
1740 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
1742 Start work on testing and debugging AGGREGATE.
1744 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
1745 of a bit-map. Require proper subcommand ordering. Make OUTFILE
1746 subcommand mandatory.
1747 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
1748 functions' arguments are in the correct order and swap them if
1750 (accumulate_aggregate_info) Make SUM include weights. Add various
1752 (dump_aggregate_info) Add various string functions.
1753 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
1755 * sort.c: (sort_parse_criteria) Add parameter for returning
1756 whether any directions were specified. All callers updated.
1758 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
1760 * t-test.q: Fixed erroneous logic in compare_group_binary.
1762 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
1764 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
1765 keywords (bug 11628).
1767 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
1769 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
1770 called *before* close_active_file().
1772 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
1774 * file-handle.q: (struct file_handle) Change open_mode from
1775 character pointer to 3-char array, for safety. Updated all
1778 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
1780 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
1783 * pfm-read.c: (read_header) Improve error message for many cases
1784 in which the input is not actually a portable file.
1786 * file-handle.q: (fh_open) When we give an error message, actually
1789 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
1791 * format.c: (check_common_specifier) New function for checks
1792 common to check_input_specifier() and check_output_specifier().
1793 (check_input_specifier) Use check_common_specifier().
1794 (check_output_specifier) Use check_common_specifier().
1795 (check_string_specifier) Removed.
1796 (check_specifier_type) New function.
1797 (check_specifier_width) New function.
1798 (get_format_var_width) Fix bug.
1800 * formats.c: (internal_cmd_formats) Only accept numeric variables.
1802 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
1803 update all references. Make case-insensitive.
1805 * pfm-read.c: Essentially rewrite the whole file. Now much
1808 * print.c: (check_string_width) New function.
1809 (fixed_parse_compatible) Use check_string_width(),
1810 check_specifier_type().
1811 (dump_fmt_list) Ditto.
1813 * str.c: (st_trim_copy) New function.
1814 (st_uppercase) New function.
1816 * vars-atr.c: (var_is_valid_name) New function.
1818 * expressions/parse.c: (type_coercion_core) Use
1819 check_specifier_type().
1821 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
1823 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
1825 * expressions/parse.c: (no_match) Ditto.
1827 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
1829 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
1831 * expressions/helpers.c: (struct func_params) Removed.
1832 (generalized_idf) Removed.
1835 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
1837 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
1838 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1839 Implement SIG.F, which I had overlooked previously.
1841 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1843 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1844 available only in testing mode.
1846 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1848 * data-in.c: Use `bool' throughout, where relevant.
1850 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1852 DATA LIST with free-field formats should not have implied decimal
1853 places (bug 12035). Also clean up data-in.c a bit.
1855 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1857 * data-in.c: (apply_implied_decimals) New function.
1858 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1859 set. Also, get rid of gotos.
1860 (parse_Z) Use apply_implied_decimals() if the field doesn't
1861 contain a decimal point.
1862 (parse_N) Use apply_implied_decimals().
1868 (parse_enum) New function.
1869 (macro CHAR_IS_ROMAN) Removed.
1870 (macro ROMAN_VALUE) Removed.
1871 (parse_month) Use parse_enum().
1872 (parse_weekday) Use parse_enum().
1873 (parse_DATETIME) Use long for weekday.
1875 * data-list.c: (read_from_data_list_fixed) Use
1876 DI_IMPLIED_DECIMALS.
1878 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1880 When the lexer sees something like `-5' in the input, it has to
1881 decide whether it's a negative numeric constant token or a '-'
1882 token followed by a positive numeric constant token. It always
1883 decides on the former, and then the parser can call
1884 lex_negative_to_dash() if it wants the latter. However, this
1885 doesn't work for the case of `-0', because negative zero is
1886 (portably) indistinguishable from positive zero. So now we divide
1887 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1888 distinction clear. This requires a little bit of extra effort,
1889 because there were several references to T_NUM in the code base.
1891 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1892 positive and negative numeric constants.
1893 (lex_double_p) Renamed lex_is_number(). Changed return type to
1894 bool. Updated all relevant references to T_NUM to instead use
1896 (lex_double) Renamed lex_number(). All references updated.
1897 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1898 bool. All references updated.
1899 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1900 (lex_negative_to_dash) Ditto.
1903 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1905 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1907 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1909 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1911 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1912 values as system-missing.
1914 * expressions/parse.c: (parse_vector_element) Fix order of
1915 arguments in call to expr_allocate_binary().
1917 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1919 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1922 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1923 failure, as indicated by function comment.
1924 (parse_binary_operators) Always return NULL on type_coercion()
1925 failure. Should have been doing this anyway, but bug in
1926 type_coercion_core() filtered through.
1927 (parse_add) Fix typo in user message.
1928 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1930 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1932 * expressions/operations.def: Add VALUE function.
1934 * expressions/parse.c: (parse_function) Need an unary composite
1935 node for variables in A TO B, not a variable node. Use
1936 allocate_unary_variable().
1937 (parse_primary) Use allocate_unary_variable().
1938 (allocate_unary_variable) New function.
1940 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1942 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1943 but fixed the real problem that was preventing the build from a
1944 separate directory. I liked it my way better ;-)
1946 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1948 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1949 John Darrington <john@darrington.wattle.id.au> for reporting this
1952 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1954 * expressions/Makefile.am expressions/evaluate.h.pl
1955 expressions/evaluate.inc.pl expressions/operations.h.pl
1956 expressions/optimize.inc.pl expressions/parse.inc.p:
1958 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1961 Fixed everything so that it can be built from an arbitrary
1964 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1966 * Makefile.am : Fixed up CLEANFILES target.
1968 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1970 * str.h: Changed `struct len_string' to `struct fixed_string', a
1971 more accurate name. Updated all references.
1973 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1975 Redo calendar support. Should now be bug-for-bug compatible.
1977 * calendar.c: New file.
1979 * calendar.h: New file.
1981 * data-in.c: Use new calendar functions.
1982 (parse_sign) Change sense of return value.
1983 (calendar_error) New function.
1984 (ymd_to_ofs) New function.
1985 (ymd_to_date) New function.
1986 (parse_DATE) Use new function.
1987 (parse_ADATE) Ditto.
1988 (parse_EDATE) Ditto.
1989 (parse_SDATE) Ditto.
1990 (parse_JDATE) Ditto.
1995 (parse_DTIME) Ditto.
1996 (parse_DATETIME) Ditto.
1998 * data-out.c: (convert_date) Use new calendar functions.
2000 * error.c: (err_vmsg) Changed interface to be more sensible.
2001 Updated all callers.
2002 (dump_message) Don't double new-lines (why did we do this
2005 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
2007 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
2008 (macro FLT64_MAX) Moved here from pref.h.orig.
2010 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
2012 * set.q: Support SET EPOCH.
2013 (static var set_epoch) New var.
2014 (aux_stc_custom_epoch) New function.
2015 (stc_custom_epoch) New function.
2016 (get_epoch) New function.
2017 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
2019 * format.c: Make it possible just to check whether a specifier is
2020 valid without emitting an error message.
2021 (parse_format_specifier_name) Change interface, update all
2023 (check_input_specifier) Ditto.
2024 (check_output_specifier) Ditto.
2025 (parse_format_specifier) Ditto.
2027 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
2029 * command.def: Add DEBUG POOL.
2031 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
2033 (pool_clear) Properly account for size of pool gizmo.
2034 (pool_realloc) Ditto.
2035 (pool_clone) New function.
2037 * pool.h: Mark our allocation functions MALLOC_LIKE.
2039 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
2041 * Makefile.am: Move many definitions into new top-level
2042 Make.build. Add expressions to SUBDIRS. Add calendar.c,
2043 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
2046 * case.c: (case_resize) New function.
2047 (case_swap) New function.
2049 * casefile.c: Include mkfile.h.
2051 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
2053 * sfm-read.c: Fixed a buglet which caused a crash when trying
2054 to read a non-existent file.
2056 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
2060 * aggregate.c: (parse_aggregate_functions) Code cleanup.
2061 Important part: get rid of spurious copying of function->format to
2062 destvar->print and destvar->write.
2064 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
2066 Fix bug 11916, which was confusing a variable's `index' member
2067 with the variable's position in a var_set. Although these are
2068 usually the same, they are not for array `var_set's.
2070 Took advantage of this bug as an opportunity to clean up and
2071 rewrite parse_var_set_vars().
2073 * vars-prs.c: (parse_vs_variable_idx) New function.
2074 (parse_vs_variable) Reimplement in terms of
2075 parse_vs_variable_idx().
2076 (parse_var_idx_class) New function.
2077 (add_variable) New function.
2078 (add_variables) New function.
2079 (parse_var_set_vars) Rewritten.
2080 (struct var_set) Change `lookup_var' member that returns a
2081 variable into `lookup_var_idx' member that returns an int.
2082 Updated the var set implementations in obvious corresponding ways.
2083 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
2085 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
2087 Use our global variable compare & hash functions and give them
2088 better names. Add similar functions for dealing with double
2089 pointers to variables.
2091 * vars-atr.c: (compare_variables) Renamed compare_var_names().
2092 (hash_variable) Renamed hash_var_name().
2093 (compare_var_ptr_names) New function.
2094 (hash_var_ptr_name) New function.
2096 * t-test.q: (cmd_t_test) Use global compare_var_names(),
2098 (compare_var_name) Removed.
2099 (hash_var_name) Removed.
2101 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
2105 * dictionary.c: (compare_variable_dblptrs) Rename
2106 compare_var_ptrs() and fix it to properly dereference the double
2109 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
2111 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
2112 declare subcommands as mandatory. Closed bug #11843
2114 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
2116 * getline.c command.[ch] command.def: Added (very rudimentary)
2117 support for line completion when in interactive mode. Partially
2118 addresses bug #11693
2120 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
2122 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
2123 problems revealed by valgrind.
2126 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
2128 * set.q: Affixed a fix to the previous fix such that we'll be OK now
2129 whether or not PAGER is set.
2131 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
2133 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
2134 "invalid free" errors. Hopefully fixes bug #11722
2136 * compute.c expr-prs.c: Check that lvalues are populated before
2137 attempting to destroy them. Closes bug #11676
2139 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
2141 * aggregate.c: Initialised the complete agr_proc structure.
2145 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
2147 * print.c: (print_trns_free) Close the dfm writer if there is one,
2148 fixing a memory leak.
2150 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
2152 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
2156 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
2158 * linked-list.[ch] Added
2160 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
2161 set.q: Yet more memory leaks
2163 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
2165 * t-test.q examine.q : More memory leaks fixed.
2167 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
2169 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
2172 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
2174 * ascii.c cartesian.c casefile.c chart.h devind.c
2175 examine.q frequencies.q
2176 html.c output.h piechart.c plot-chart.c plot-hist.c
2178 Integrated the chart rendering into the output stream
2179 (currently only works for html).
2181 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
2182 dummy-chart.c for compiling without charts.
2184 * mkfile.[ch] Created.
2186 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
2187 Added type element so we can tell if it's a chart or a table.
2189 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
2190 API of charts to be more like that of tables.
2192 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
2194 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
2195 main.c. Removed the handler for SIGQUIT.
2197 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
2199 * casefile.c: Added a signal handler to delete temp files on
2202 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
2204 * command.def Added a lot more unimplemented commands.
2206 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
2208 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
2210 * sort.c: (compare_initial_runs) Needed additional level of
2212 (merge_once) Fix plenty of stupid mistakes.
2214 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
2216 * casefile.c: (casefile_sleep) Need to flush_buffer() after
2217 calling casefile_to_disk() or we will lose the last block in the
2218 file if the casefile started out as disk-based.
2219 (casefile_get_reader) Initialize reader->destructive to 0.
2220 (cmd_debug_casefile) Add new test pattern.
2221 (test_casefile) Define new test pattern to make sure
2222 casefile_sleep() works properly.
2224 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
2226 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
2227 plot-hist.c plot-chart.c (Added) Reorganised these files in an
2228 attempt to seperate the creation and processing of charts from their
2231 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
2234 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
2236 * main.c Added a signal handler for SIGFPE
2238 * sort.c Somewhat more robust fix to the previous entry.
2240 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
2242 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
2243 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
2244 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
2247 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
2249 * case.h Fixed bug # 11307
2251 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
2253 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
2256 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
2258 * pfm-read.c: (read_variables) Remove direct manipulation of
2259 v->aux, which is no longer needed. Fixes bug 11483.
2261 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
2263 * data-list.c Fixed a bug in parsing delimiters.
2265 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
2268 * percentiles.c Properly handled calculation of Tukey hinges where
2269 the number of data is small.
2271 * oneway.q Used the generic value_to_string function for independent
2272 variable instead of trying to do it ourselves.
2274 * box-whisker.c Fixed a buglet which caused a crash if the number of
2278 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2280 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
2282 * percentiles.c Fixed some bugs when calculating percentiles when
2283 there's a small number of cases.
2285 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
2287 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
2289 * examine.q factor_stats.[ch] Added calculation of percentiles
2291 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2293 * t-test.q Fixed bug #11227 Made t-test work when the independent
2296 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2298 * factor_stats.c Fixed calculation of trimmed mean under various
2301 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2303 * histogram.c chart.[ch] factor_stats.c frequencies.q
2305 Added code to calculate sensible histogram ranges and limits.
2307 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
2309 * chart.h Updated to reflect many API changes.
2311 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
2312 cartesian.c and into chart.c
2314 * factorstats.[ch] Added the histogram calculations
2316 * casefile.c Removed an unused variable.
2318 * frequencies.q examine.q histogram.c Reworked the API for
2321 * piechart.c Revised the API for piecharts.
2323 * var.h Moved the definitions of freq_tab and freq out of var.h
2324 and into frequencies.q where they belong.
2326 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
2328 * flip.c: (flip_file) Check for off_t separately from fseeko(),
2329 using AC_TYPE_OFF_T.
2331 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
2333 * flip.c: (flip_file) If fseeko() is not available, use long int
2334 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
2335 reporting the problem.
2337 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
2339 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
2340 conflict with stdio.
2342 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
2344 * var-labs.c (var_to_string) Now returns null if the variable is null
2346 * value-labels.c (value_to_string) Made it return null if either the
2347 value or the variable is null.
2349 * hash.c (hsh_clear) Fixed a buglet.
2351 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
2352 with the wrong model.
2354 * casefile.[ch] Added a function to return the casereader.case_idx
2357 * examine.q Implemented the extreme values results.
2359 John Darrington <john@darrington.wattle.id.au>
2361 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
2362 output.[ch] getline.c
2364 Plugged some memory leaks
2366 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
2368 Adopt GSL random number generators, paving the way for providing
2369 the complete suite of random number generators on expressions.
2371 * Makefile.am: Remove random.c, random.h.
2373 * random.c: Removed.
2375 * random.h: Removed.
2377 * algorithm.c: (algo_default_random) Use GSL functions.
2379 * casefile.c: (test_casefile) Use GSL RNG functions.
2381 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
2384 * sample.c: (cmd_sample) Use GSL RNG functions.
2385 (sample_trns_proc) Ditto.
2387 * set.q: (static var set_seed) Removed.
2388 (static var seed_flag) Removed.
2389 (static var rng) New variable.
2390 (aux_stc_custom_seed) No seed value anymore, don't print anything.
2391 (stc_custom_seed) Use new seed functions.
2392 (seed_is_set) Removed.
2393 (get_rng) New function that composes the entire external
2395 (set_rng) New function.
2396 (random_seed) New function.
2398 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
2400 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
2401 John Darrington <john@darrington.wattle.id.au> for reporting this
2404 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2406 * permissions.c command.def Added the PERMISSIONS command
2408 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
2410 * q2c.c: (dump_header) Don't try to emit #includes at very top of
2411 output file because that will precede #include <config.h>, which
2413 (main) Add needed headers to /* (header) */ code.
2415 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
2417 Instead of making system or portable file readers responsible for
2418 dropping and reordering variables, make them read full cases and
2419 let the caller take care of any changes.
2421 * get.c: New "case map" structure to handle this. Use for GET,
2422 IMPORT, MATCH FILES. Essentially rewrite the whole file.
2424 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
2425 changed appropriately.
2427 * sfm-read.c: (sfm_read_case) Ditto.
2429 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
2431 Decided that case_serialize() and case_unserialize() were too
2432 abstract. Also we need a couple more functions to avoid excessive
2433 copying for data in/out fast paths.
2435 * case.c: (case_serial_size) Removed.
2436 (case_serialize) Rename case_to_values() and make its argument
2437 explicitly an array of union values.
2438 (case_unserialize) Rename case_from_values() and make its argument
2439 explicitly an array of union values.
2440 (case_data_all) New function.
2441 (case_data_all_rw) New function.
2443 * casefile.c: (struct casefile) Change buffer from array of
2444 unsigned char to array of union value for better accuracy.
2445 Redefine buffer_used and buffer_size in terms of values, not
2446 bytes. Remove case_size because it is now redundant with
2447 value_cnt. Fix up all references to these members.
2449 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
2451 * barchart.c: (struct subcat) Make `label' member const to silence
2452 GCC warning with -Wwrite-strings.
2454 * cartesian.c: (struct dataset) Ditto.
2456 * case.c: Don't re-define NDEBUG if already defined.
2457 Add lots of comments.
2459 * str.c: Fix includes.
2461 * crosstabs.q: Fix includes.
2463 * examine.q: Fix includes. Fix GCC warning about unused
2466 * frequencies.q: (stat macro) Removed and replaced where used by
2469 * list.q: Fix includes.
2471 * oneway.q: Fix includes.
2473 * piechart.c: Fix includes. Only define M_PI if not already
2476 * sfm-read.c: (bswap) New function.
2477 (bswap_int32) Write in terms of bswap.
2478 (bswap_flt64) Ditto.
2480 * str.c: (ds_data) Add external definition here, needed because
2481 str.h has only an `extern inline' version.
2483 * value-labels.c: Fix includes.
2485 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
2487 Instead of providing a system or portable file writer with a raw
2488 case in the format needed for output, provide it with a regular
2489 case. The writer takes care of any needed translation.
2491 * aggregate.c: Adopt new scheme for AGGREGATE.
2492 (struct agr_proc) sfm_agr_case member removed.
2493 (write_case_to_sfm) Removed because the new interface is easier to
2496 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
2498 * pfm-write.c: Implement new scheme.
2500 * sfm-write.c: Ditto.
2502 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
2504 Instead of treating `struct file_handle' as a class to subclass
2505 into data files, system files, and portable files, instead use it
2506 as a helper that coordinates access. Now it is opaque, too.
2508 This means that most references to a struct file_handle are now
2509 changed into references to one of struct dfm_reader, struct
2510 dfm_writer, struct sfm_reader, struct sfm_writer, struct
2511 pfm_reader, or struct pfm_writer, according to what's being read
2514 Most related changes are only worth summarizing briefly.
2516 * dictionary.c: (dict_clear) Destroy aux data in deleted
2518 (dict_clear_aux) New function.
2519 (dict_create_var) Initialize aux, aux_dtor.
2520 (dict_delete_var) Destroy aux data in deleted variable.
2522 * file-handle.h: (struct fh_ext_class) Removed.
2523 (struct file_handle) Removed.
2524 (fh_init_files) Removed.
2526 * file-handle.q: Changed references to a handle's `private' member
2527 to direct references.
2528 (struct private_file_handle) Renamed file_handle.
2529 Add next, open_cnt, type, open_mode, aux members.
2530 (struct file_handle_list) Removed.
2531 (extern var inline_file) Removed.
2532 (static var file_handles) Changed from file_handle_list * to
2534 (create_file_handle) Initialize new members.
2535 (fh_close_handle) Removed.
2536 (mode_name) New function.
2537 (fh_open) New function.
2538 (fh_close) New function.
2539 (fh_parse_file_handle) Renamed fh_parse().
2541 * glob.c: (init_glob) Remove fh_init_files() call.
2543 * aggregate.c: use sfm_writer.
2544 (create_sysfile) Removed because the new interface is simpler.
2546 * apply-dict.c: Use sfm_reader.
2548 * data-list.c: Use dfm_reader.
2550 * file-type.c: Use dfm_reader.
2552 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
2554 * inpt-pgm.c: Use dfm_reader.
2556 * print.c: Use dfm_writer.
2558 * sysfile-info: Use sfm_reader.
2560 * dfm-read.c: Adopt new file handle infrastructure.
2562 * dfm-write.c: Ditto.
2564 * pfm-read.c: Ditto.
2566 * pfm-write.c: Ditto.
2568 * sfm-read.c: Ditto.
2570 * sfm-write.c: Ditto.
2572 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
2574 Break dictionary functions into separate header file.
2576 * dictionary.h: New file.
2578 * var.h: Moved dict_*() functions to dictionary.h.
2580 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
2582 Get rid of procedure-specific union in struct variable, using
2583 instead a void * pointer and a destructor function.
2585 Most related changes are only worth brief summaries.
2587 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
2588 old p.crs member in struct variable.
2590 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
2591 of old p.frq member in struct variable.
2593 * histogram.c: (draw_histogram) Takes new freq_tab arg because
2594 it's no longer possible to grab this from var->p.frq.
2596 * piechart.c: (draw_piechart) Ditto.
2598 * group.c: (group_proc_get) New function.
2600 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
2607 * main.c: (execute_command) Clear aux data in default_dict after
2608 each command. (It's debatable whether this should be done.)
2610 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
2611 member in struct variable.
2613 * means.q: Get rid of integer mode, which is not included in
2614 recent SPSS and was the only code that wanted per-variable private
2617 * var.h: (struct crosstab_proc) Removed.
2618 (struct frequencies_proc) Removed.
2619 (struct list_proc) Removed.
2620 (struct get_proc) Removed.
2621 (struct means_proc) Removed.
2622 (struct matrix_data_proc) Removed.
2623 (struct match_files_proc) Removed.
2624 (lots of enums) Removed.
2625 (struct variable) Removed members `p', `get'. Add member
2628 * vars-atr.c: (var_attach_aux) New function.
2629 (var_detach_aux) New function.
2630 (var_clear_aux) New function.
2631 (var_dtor_free) New function.
2632 (discard_variables) Use NULL instead of inline_file.
2634 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2636 * value-labs.c Fixed the implmentation of value_to_string, so
2637 that it properly handles alpha values.
2639 * oneway.q Changed instances where labels were being probed manually,
2640 to use the canonical {var,value}_to_string functions
2642 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2644 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
2645 plots. Changed the API of the cartesian plot to be a much lower level
2648 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
2650 * examine.q Added some of the parametric calculations
2652 * factor_stats.[ch] Created
2654 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2656 * examine.q Changed the definition of factors to be a composite, and
2657 dealt with the consequences.
2659 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
2661 * examine.q Fixed problem where examine wasn't dealing properly with
2664 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
2666 * oneway.q Fixed problem where oneway wasn't dealing properly with
2669 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
2671 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
2672 command which had settings didn't get the appropriate code
2675 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
2676 to convert variables/values to strings.
2678 * examine.q Added framework for the EXAMINE command.
2680 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
2682 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
2683 subcommand types. Changed frequencies.q to use it rather then the
2684 custom parser. Dealt with the consequences. Added a test for NTILES
2685 subcommand of frequencies.
2687 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
2689 * oneway.q Fixed up the behaviour when given missing values
2691 * levene.c oneway.q Fixed a buglet with the levene statistic and
2692 incorporated the levene test into the oneway command.
2694 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
2695 global scope, since they're only relevant to T-TEST
2697 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
2699 * group.c group.h group_proc.h levene.c oneway.q t-test.q
2701 Made the t-test more consistent
2702 with the way it handles groups. That is, it now uses a hash instead
2703 of an array of 2. Also, made the levene.c file independent of the
2704 implementation of the t-test. So now levene should be fine for both
2707 * Added an oneway.q file for one way anova
2709 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
2711 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
2714 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
2718 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
2719 (data_list_trns_free) Free dls->delims.
2721 * t-test.q: (tts_custom_pairs) Free vars.
2722 (ssbox_one_sample_init) Fix tab_vline() argument.
2723 (ssbox_independent_samples_init) Ditto.
2724 (trbox_paired_init) Ditto.
2725 (trbox_one_sample_init) Ditto.
2727 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
2729 Generalize casefiles to the extent that we can use them for
2730 sorting and other kinds of data transformations. Change cases to
2731 be copy-on-write to improve memory efficiency in common cases.
2732 Every access to a member of a `struct ccase' was changed to be a
2733 call to a case_*() function, especially case_data(), case_num(),
2734 case_str(), or case_data_rw(). Many instances of a local variable
2735 named "case_num" were changed to "case_idx" as a consequence.
2736 Many `struct ccase *' were changed to actual `struct ccase'
2737 because of copying semantics of cases. In several places there
2738 was a choice between updating debug code to work with the new ADTs
2739 or just deleting it because it was useless; I chose to delete it.
2741 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
2747 * aggregate.c: (struct agr_proc) Change type of `sort' to
2748 sort_criteria *. Add `break_vars', `break_var_cnt' members.
2749 Rename `vars' to `agr_vars', all references updated. Change
2750 `agr_case' to type `struct ccase'.
2751 (cmd_aggregate) Deal with new members. Use case_create(),
2752 sort_active_file_in_place(), sort_active_file_to_casefile().
2753 (agr_destroy) Deal with new members.
2754 (aggregate_single_case) Ditto.
2755 (dump_aggregate_info) Ditto.
2756 (initialize_aggregate_info) Ditto.
2757 (agr_to_active_file) Ditto.
2758 (presorted_agr_to_sysfile) Ditto.
2759 (sort_agr_to_sysfile) Removed.
2761 * alloc.c: (out_of_memory) Make non-static.
2763 * alloc.h: Prototype out_of_memory().
2765 * casefile.c: Switched from a linked list in-memory representation
2766 to a two-level array-style representation. The linked list was
2767 appropriate when we could stick a header onto cases, but that's no
2768 longer the case. Also, the two-level array will allow for random
2769 in-memory access in case that's ever wanted. Also added the
2770 concept of a `destructive casereader', one that destroys cases in
2771 the underlying casefile as they are read out.
2772 (macro CASES_PER_BLOCK) New macro.
2773 (struct casefile) New members `value_cnt', `case_list_size',
2774 `case_acct_size', `being_destroyed', `cases'. Removed `head',
2776 (struct casereader) Removed `cur'. Added `destructive', `c'.
2777 (global var casefiles) Made static.
2778 (static var case_bytes) New var.
2779 (casefile_create) Takes a value count, not a case size in bytes,
2780 to conform to the case interface. All callers updated. Deal with
2781 new and removed members.
2782 (casefile_destroy) Deal with new and removed members.
2783 (casefile_sleep) New function.
2784 (casefile_get_case_size) Removed.
2785 (casefile_get_value_cnt) New function.
2786 (casefile_append) Rewritten to deal with new and removed members.
2787 (casefile_append_xfer) New function.
2788 (write_case_to_disk) Use case_serialize().
2789 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
2790 Couldn't figure out why.
2791 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
2792 deal with new and removed members.
2794 (merge_sort) Removed.
2795 (casefile_sort) Removed.
2796 (casefile_get_reader) Deal with new and removed members.
2797 (casefile_get_destructive_reader) New function.
2798 (reader_open_file) Make code more readable. Create case for
2800 (casereader_get_casefile) New function.
2801 (casereader_read) Deal with new and removed members. Now returns
2802 a copy of the case, so that the caller is responsible for
2803 destroying the returned case.
2804 (casereader_read_xfer) New function.
2805 (casereader_destroy) Destroy reader's case.
2806 (test_casefile) Second arg is now a value count, all callers
2807 updated. Now tests destructive readers too.
2808 (get_random_case) Deal with new case ADT.
2809 (write_random_case) Ditto.
2810 (read_and_verify_random_case) Ditto.
2812 * crosstabs.q: Remove debug code.
2814 * descript.q: (calc_descriptives) Deal with new case, casefile
2817 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
2819 * do-if.c: Remove unneeded header inclusion.
2821 * expr-prs.c: Remove debug code.
2823 * exprP.h: Remove debug code.
2825 * flip.c: (flip_file) Use fseeko() if available.
2827 * formats.c: Remove debug code.
2829 * get.c: Remove debug code.
2830 (struct mtf_file) Change `input' from `union value *' to `struct
2831 ccase', all references updated.
2833 * levene.c: (levene) Deal with new case, casefile ADTs.
2835 * list.q: Remove debug code.
2837 * loop.c: Remove debug code.
2839 * matrix-data.c: Remove debug code.
2841 * means.q: Remove debug code.
2843 * mis-val.c: Remove debug code.
2845 * pfm-read.c: Remove debug code.
2846 (pfm_read_code) Change second arg from `union value *' to `struct
2847 ccase *', all references updated.
2849 * recode.c: (string_to_long) Make first arg const.
2850 (convert_to_double) Ditto.
2852 * repeat.c: Remove debug code.
2854 * sample.c: Remove debug code.
2856 * sfm-read.c: Remove debug code.
2857 (sfm_read_case) Change second arg from `union value *' to `struct
2860 * sort.c: Redone in terms of casefiles.
2861 (enum sort_direction) Moved here from sort.h.
2862 (struct sort_criterion) New structure.
2863 (struct sort_criteria) New structure.
2864 (cmd_sort_cases) Rewritten.
2865 (prepare_to_sort_active_file) New function.
2866 (sort_active_file_in_place) New function.
2867 (sort_active_file_to_casefile) New function.
2868 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2869 changed, all callers updated.
2870 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2871 rewritten & interface changed, all callers updated.
2872 (sort_cases) Renamed sort_execute(), rewritten & interface
2873 changed, all callers updated.
2874 (struct internal_sort) Removed.
2875 (do_internal_sort) Rewritten, interface changed.
2876 (destroy_internal_sort) Removed.
2877 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2878 (struct initial_run) Removed; an initial run is now just a
2880 (compare_initial_runs) Rewritten.
2881 (struct external_sort) Changed almost completely.
2882 (do_external_sort) Rewritten, interface changed.
2883 (destroy_external_sort) Rewritten.
2884 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2885 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2886 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2887 (init_external_sort) Removed.
2888 (simulate_error) Removed.
2889 (rmdir_temp_dir) Removed.
2890 (get_temp_file_name) Removed.
2891 (open_temp_file) Removed.
2892 (close_temp_file) Removed.
2893 (remove_temp_file) Removed.
2894 (write_temp_file) Removed.
2895 (read_temp_file) Removed.
2896 (struct record_run) Change `record' from `struct case_lit *' to
2898 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2899 `file_idx', `output_file'. Add `run', casefile'. Change
2900 `last_output' from `struct case_list *' to `struct ccase'.
2901 (write_initial_runs) Change interface, rewrite.
2902 (sort_sink_write) Renamed process_case(), changed interfaced,
2904 (destroy_initial_run_state) Rewritten.
2905 (allocate_cases) Rewritten.
2906 (compare_record) Interface changed, rewritten.
2907 (start_run) Rewritten.
2908 (end_run) Rewritten.
2909 (output_record) Rewritten.
2910 (grab_case) Removed.
2911 (release_case) Removed.
2912 (struct merge_case) Change `cases' from double pointer to single
2914 (merge) Deal with new case and casefile ADTs.
2915 (struct run) Removed.
2916 (merge_once) Rewritten, interface changed.
2917 (fill_run_buffer) Removed.
2918 (sort_sink_make_source) Removed.
2919 (sort_sink_class) Removed.
2920 (struct sort_source_aux) Removed.
2921 (sort_source_read_helper) Removed.
2922 (sort_source_read) Removed.
2923 (read_sort_output) Removed.
2924 (read_internal_sort_output) Removed.
2925 (read_external_sort_output) Removed.
2926 (sort_source_destroy) Removed.
2927 (sort_source_class) Removed.
2929 * sort.h: (struct sort_cases_pgm) Removed.
2930 (enum sort_direction) Moved to sort.c.
2932 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2934 * tab.c: Remove debug code.
2936 * var-labs.c: Remove debug code.
2938 * var.h: (struct ccase) Removed.
2939 (struct case_list) Removed.
2941 * vars-atr.c: (discard_variables) Use free_case_source().
2943 * vars-prs.c: (parse_vs_variable) Make arg const.
2944 (parse_dict_variable) Ditto.
2945 (parse_variables) Make struct dictionary * arg const.
2946 (parse_var_set_vars) Make struct var_set * arg const.
2947 (struct var_set) Add const to some of the function pointers' args.
2948 (var_set_get_cnt) Make arg const.
2949 (var_set_get_var) Make first arg const.
2950 (var_set_lookup_var) Make first arg const.
2951 (dict_var_set_get_cnt) Make arg const.
2952 (dict_var_set_get_var) Make first arg const.
2953 (dict_var_set_lookup_var) Make first arg const.
2954 (var_set_create_from_dict) Make arg const. Add cast to aux
2956 (struct array_var_set) Add const to var member.
2957 (array_var_set_get_cnt) Make arg const.
2958 (array_var_set_get_var) Make first arg const.
2959 (array_var_set_lookup_var) Make first arg const.
2960 (var_set_create_from_array) Make first arg const. Insert cast.
2962 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2963 members from `struct ccase *' to `struct ccase'.
2964 (static var lag_queue) Change from double to single pointer.
2965 (procedure) Optimize trivial case.
2966 (internal_procedure) Deal with changed case, case_source ADTs.
2967 (create_trns_case) Changed interface, rewrote.
2968 (open_active_interface) Initialize modified lag queue.
2969 (write_case) Deal with changed case ADT.
2970 (lag_case) Deal with modified lag queue.
2971 (close_active_file) Destroy modified lag queue.
2972 Deal with changed case_source, case_sink ADTs.
2973 (destroy_storage_stream_info) Make null arg into no-op.
2974 (storage_sink_make_source) Set aux in created source.
2975 (storage_source_read) Deal with changed case, casefile ADTs.
2976 (storage_source_create) New function.
2977 (lagged_case) Rewrite.
2978 (free_case_source) New function.
2979 (free_case_sink) Rewrite.
2980 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2982 (procedure_with_splits) Deal with changed prev_case.
2983 (procedure_with_splits_callback) Ditto.
2984 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2986 (multipass_procedure_with_splits) Deal with changed prev_case.
2987 (multipass_split_callback) Ditto.
2990 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2992 The workspace idea didn't work out.
2994 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2996 * workspace.c: Removed.
2998 * workspace.h: Removed.
3000 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
3002 Fully implement arbitrary delimiters on DATA LIST, extending the
3003 half implementation that was already there.
3005 * data-list.c: (struct data_list_pgm) Remove `delim', add
3006 `delims', `delim_cnt'.
3007 (cmd_data_list) Initialize new members. Parse delimiters and
3008 clean up code a bit.
3009 (cut_field) Extract fields with arbitrary delimiters. Also, fix
3010 handling of leading commas.
3011 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
3013 (read_from_data_list_free) Adapt to new DFM interfaces.
3014 (read_from_data_list_list) Ditto.
3015 (repeating_data_trns_proc) Ditto.
3017 * dfm.c: Split up reader and writer into separate code, because
3018 they do different things. Use struct string instead of explicit
3019 allocation code, for clarity.
3020 (enum dfm_reader_flags) New enum.
3021 (struct dfm_fhuser_ext) Removed.
3022 (struct dfm_reader_ext) New.
3023 (get_reader) New function, used by just about all the reader
3025 (dfm_close) Removed.
3026 (close_reader) New function.
3027 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
3028 (dfm_open_for_writing) Ditto.
3029 (macro force_line_buffer_expansion) Removed.
3030 (count_tabs) Removed.
3031 (tabs_to_spaces) Removed.
3032 (read_record) Deal with new dfm_reader_ext. Use struct string
3033 functions. Don't convert tabs to spaces.
3034 (dfm_eof) New function.
3035 (dfm_get_record) Changed interface, rewrote.
3036 (dfm_expand_tabs) New function.
3037 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
3038 dfm_reader_ext, rewritten.
3039 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
3040 dfm_reader_ext, rewritten.
3041 (dfm_set_record) Removed in favor of dfm_forward_columns().
3042 (dfm_forward_columns) New function.
3043 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
3044 dfm_reader_ext, rewritten.
3045 (static var dfm_r_class) Use close_reader for the destructor.
3046 (struct dfm_writer_ext) New.
3047 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
3048 bounce buffer now instead of local allocation.
3049 (close_writer) New function.
3050 (static var dfm_writer_ext) Use close_writer for destructor.
3051 (cmd_begin_data) Adapt to new dfm_reader_ext.
3053 * file-handle.q: Add support for per-file tab width.
3054 (struct private_file_handle) Add tab_width member.
3055 (q2c specifications) Add tabwidth subcommand.
3056 (cmd_file_handle) Put parsed tab width into private_file_handle.
3057 (create_file_handle) Set default tab width.
3058 (handle_get_tab_width) New function.
3060 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
3062 * inpt-pgm.c: (reread_trns_proc) Ditto.
3064 * matrix-data.c: (context) Ditto.
3065 (another_token) Ditto.
3069 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
3071 * casefile.c: (casefile_destroy) Fix memory leak by freeing
3073 (casereader_destroy) Don't close file descriptor -1.
3075 * recode.c: (cmd_recode) Fix memory leak.
3077 * set.q: (q2c specifications) Fix typo in user message.
3079 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
3080 undefined behavior for overlapping arguments.
3082 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
3084 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
3085 don't call it when we're running under valgrind.
3086 (call_posix_fadvise) New function.
3087 (casefile_to_disk) Use call_posix_fadvise().
3088 (reader_open_file) Ditto.
3090 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
3092 Update our string ADTs, struct string and struct len_string. Get
3093 rid of pool support, which was largely unused. Rename lots of
3094 functions to have more obvious or consistent names.
3096 * ascii.c: Get rid of ascii_pool. It was only used for string
3098 (ascii_open_global) Don't create ascii_pool.
3099 (ascii_close_driver) Don't destroy ascii_pool.
3100 (ascii_postopen_driver) Don't use pool.
3101 (ascii_close_driver) Destroy strings manually.
3103 * str.c: (ds_create) Remove pool argument, all references updated.
3105 (ds_replace) Remove pool support, make more efficient when we
3106 don't need to reallocate.
3107 (ds_destroy) Remove pool support.
3108 (ds_rpad) New function.
3109 (ds_size) Renamed ds_capacity(), all references updated.
3110 (ds_value) Renamed ds_c_str(), all references updated.
3111 (ds_concat) Renamed ds_puts(), all references updated.
3112 (ds_concat_buffer) Renamed ds_concat(), all references updated.
3113 (ds_putchar) Renamed ds_putc(), all references updated.
3114 (ds_getline) Renamed ds_gets(), all references updated.
3115 (ls_create) Remove pool argument, all references updated.
3116 (ls_create_buffer) Ditto.
3117 (ls_destroy) Removed pool support.
3118 (ls_value) Renamed ls_c_str(), all references updated.
3120 * str.h: (ls_length) [__GNUC__] Add inline version.
3121 (ls_c_str) [__GNUC__] Add inline version.
3122 (ls_end) [__GNUC__] Add inline version.
3123 (struct string) Remove pool member. Rename `size' to `capacity',
3124 all references updated.
3126 * tab.c: (text_format) Instead of using pool argument to
3127 ls_create_buffer(), call pool_register() on allocated data.
3129 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
3131 We're abusing the current ASCII driver by telling it to allocate a
3132 9999-line, 9999-character page in the tests. This causes some
3133 systems to curl up and die because it allocates 20 MB of
3134 contiguous RAM. This change alleviates at least part of the
3135 problem. It is mostly a stop-gap until the new output system is
3138 * ascii.c: (struct line) New structure.
3139 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
3140 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
3141 (ascii_preopen_driver) Initialize new members, not old ones.
3142 (ascii_close_driver) Destroy new members, not old ones.
3143 (ascii_open_page) Allocate new members, not old ones.
3144 (expand_line) Allocate room in line.
3145 (draw_line) Use new members.
3146 (ascii_line_horz) Ditto.
3147 (ascii_line_vert) Ditto.
3148 (ascii_line_intersection) Ditto.
3150 (output_lines) Ditto.
3151 (ascii_close_page) Ditto.
3153 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
3155 * matrix.c: Dead code. Removed.
3157 * matrix.h: Dead code. Removed.
3159 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
3161 Contrary to what I'd always understood, there is an efficient
3162 algorithm for deletion from a hash table populated via linear
3163 probing. This change implements it.
3165 * hash.c: (hsh_rehash) Probe in increasing order.
3167 (locate_matching_entry) Ditto.
3168 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
3170 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
3172 * moments.c (calc_moments): Adjust calculation of kurtosis to
3173 avoid subtracting huge numbers from huge numbers, on Michael
3176 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
3178 Rework moments routines for improved numerical stability based on
3179 Michael Kiefte's advice. Any bugs or remaining numerical problems
3180 are still mine though.
3182 There is now a struct moments1 for use with one-pass moments. It
3183 uses a provisional means algorithm as an attempt to improve
3184 accuracy of higher moments. The older struct moments now only
3185 handles two-pass moments.
3187 * aggregate.c: Use moments1 instead moments.
3189 * descript.c: Revert previous change, which is no longer needed
3190 due to the moments revision.
3192 * moments.c: (calc_moments) New function for calculating variance,
3194 (moments_pass_one) Only accumulate weights bigger than zero.
3195 (moments_calculate) Allow calculating the mean on pass one, others
3196 require pass two. Implement in terms of calc_moments().
3197 (struct moments1) New structure.
3198 (init_moments1) New function.
3199 (moments1_clear) Ditto.
3200 (moments1_create) Ditto.
3201 (moments1_add) Ditto.
3202 (moments1_calculate) Ditto.
3203 (moments1_destroy) Ditto.
3204 (cmd_debug_moments) Deal with `struct moments' or `struct
3205 moments1' as requested by user.
3207 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
3209 * Makefile.am (pspp_SOURCES): Remove debug.c.
3211 * debug.c: Removed. It was empty anyway.
3213 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
3215 * descript.c (calc_descriptives): Fix assert failure when only
3216 MOMENT_MEAN is needed.
3218 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
3222 fixed problem with parsing in match_statistic() causing
3223 "DESCRIPTIVE STAT=MEAN." to barf.
3225 "MEAN" is now default if "SORT" given without specification.
3227 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
3228 generally less forgiving of syntax errors: better to have it do
3229 nothing and type it in again then to not know what it actually did
3232 z-score transformation now checks score for user-missing values
3233 and checks std_dev for SYSMIS.
3235 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
3237 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
3238 Changed dict_get_case_weight() to accept an additional int * flag
3239 to complain about system-missing, user-missing, zero, or negative
3240 weights and updated existing functions to pass int * to
3241 dict_get_case_weight().
3243 2004-04-05 jmd <jmd@gnu.org>
3245 * main.c: Fixed configuration problems with gsl
3247 * t-test.q: Fixed some problems encountered when compiling under Cygwin
3249 2004-04-03 blp <blp@gnu.org>
3251 * lexer.c, ChangeLog:
3252 Fix infinite loop on comment at end of file, add test.
3254 2004-04-03 jmd <jmd@gnu.org>
3256 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
3257 Fixed the calculation of percentiles and added --syntax and --algorithm options
3259 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
3261 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
3264 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
3266 * frequencies.q: Fixed the calculation of percentiles
3268 * Makefile.am: Added the --ansi flag and dealt with the
3269 consequences. Added some entries to PSPP_sources so that
3270 make distcheck would pass
3272 * cmdline.c: Added the --syntax and --algorithm options
3274 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
3276 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3278 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
3279 use the new multipass_split_... mechanism.
3281 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
3283 * frequencies.q: (calc_stats) Use moments data structure and
3284 calc_seskew(), calc_sekurt() functions.
3286 * set.q main.c settings.h Added support for --syntax and --algorithm
3289 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
3291 * vfm.c: Had to get last call to multipass_split_output() inside
3292 open_active_file()/close_active_file() pairing, so introduce new
3294 (internal_procedure) Move procedure() code here, except for calls
3295 to open_active_file() and close_active_file().
3296 (procedure) Wrap open_active_file() and close_active_file() around
3297 internal_procedure().
3298 (multipass_procedure_with_splits) Wrap open_active_file() and
3299 close_active_file() around internal_procedure().
3301 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
3303 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
3305 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
3307 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
3309 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
3311 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
3313 * algorithm.c: By default turn off some of the more expensive
3315 (expensive_assert) New macro which expands to assert if
3316 EXTRA_CHECKS is defined, to nothing otherwise.
3317 (unique) Use expensive_assert().
3318 (binary_search) Ditto.
3324 * command.c: (conflicting_3char_prefixes) Words that are the same
3325 don't cause conflicts when they are abbreviated to the first three
3328 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
3329 nonterm_node's n earlier.
3330 (generic_str_func) Ditto.
3332 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
3334 Add support for multipass procedures. Rewrite DESCRIPTIVES to
3335 test multipass support, take advantage of new moments
3336 calculation, and to not be such crappy code. Get rid of q2c
3337 processing for DESCRIPTIVES.
3339 * vfm.c: (struct multipass_split_aux_data) New structure.
3340 (multipass_procedure_with_splits) New function.
3341 (multipass_split_callback) New function.
3342 (multipass_split_output) New function.
3343 * descript.q: Removed.
3345 * descript.c: New file.
3347 * var.h: Removed descriptives enums.
3348 (struct descriptives_proc) Removed.
3349 (struct variable) Removed p.dsc.
3351 * Makefile.am: (q_sources_c) Remove descript.c.
3352 (q_sources_q) Removed descript.q.
3354 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
3356 New manager for keeping track of used workspace.
3358 * workspace.c: New file.
3360 * workspace.h: New file.
3362 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
3364 * sort.c: (do_internal_sort) Use workspace_malloc().
3365 (destroy_internal_sort) Use workspace_free().
3367 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
3369 New `struct casefile' for managing sets of cases.
3371 * casefile.c: New file.
3373 * casefile.h: New file.
3375 * command.def: Add DEBUG CASEFILE command.
3377 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
3379 * sort.c: (sort_cases) Move logic for sending storage file to disk
3380 into do_external_sort().
3381 (struct internal_sort) Use an array of ccase pointers instead of a
3383 (do_internal_sort) Rewrite to handle casefiles.
3384 (compare_case_list) Removed.
3385 (compare_cases) New function.
3386 (compare_case_dblptrs) New function.
3387 (read_internal_sort_output) Deal with new struct internal_sort.
3389 * vfm.c: (static var workspace_overflow) Removed.
3390 (struct storage_stream_info) Removed all the members. Added
3391 struct casefile * member.
3392 (storage_sink_open) Use casefile.
3393 (open_storage_file) Removed.
3394 (write_storage_file) Removed.
3395 (storage_to_disk) Removed.
3396 (destroy_storage_stream_info) Use casefile.
3397 (storage_sink_write) Use casefile.
3398 (storage_sink_make_source) Use casefile.
3399 (storage_source_count) Use casefile.
3400 (storage_source_read) Use casefile.
3401 (storage_source_on_disk) Removed.
3402 (storage_source_get_cases) Removed.
3403 (storage_source_set_cases) Removed.
3404 (storage_source_get_casefile) New function.
3406 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
3408 New `struct moments' for calculating moments.
3414 * moments.c: New file.
3416 * moments.h: New file.
3418 * command.def: Add DEBUG MOMENTS command.
3420 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
3423 * aggregate.c: Modify AGGREGATE to use the new moments
3424 calculation, even if not in such a great way.
3425 (struct agr_var) Add `moments' member.
3426 (parse_aggregate_functions) Set `moments' member to null.
3427 (agr_destroy) Destroy `moments' member.
3428 (accumulate_aggregate_info) Use `moments' for standard deviation.
3429 (dump_aggregate_info) Ditto.
3430 (initialize_aggregate_info) Create or clear `moments'.
3432 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
3433 cube(), pow4() that were in stats.h. All references updated.
3435 * crosstabs.q: stats.h had chi-square significance functions. Use
3437 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
3439 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
3440 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
3442 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
3444 * dictionary.c: (dict_compact_values) Compacted values need to
3447 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
3449 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
3450 `/' at start. Check return value of parse_variables() for error
3453 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
3455 Revamp expressions: make the code a little nicer, and fix bugs
3458 * expr-evl.c: (expr_evaluate) Make expression argument const.
3459 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
3460 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
3461 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
3462 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
3463 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
3464 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
3465 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
3466 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
3467 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
3468 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
3469 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
3470 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
3471 Simplify OP_SYSMIS. Remove OP_STR_MIS.
3473 * expr-opt.c: (optimize_expression) Rewrite.
3478 (macro s0l) Removed.
3480 (macro s1l) Removed.
3482 (macro s2l) Removed.
3485 (eq_num_con) New function.
3486 (optimize_tree) New function.
3487 (macro rnc) Removed.
3488 (macro frnc) Removed.
3489 (str_search) Add const to string params.
3490 (str_rsearch) Ditto.
3491 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
3492 str[], str_len[] locals to substitute for most of removed macros.
3493 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
3494 Removed support for missing values because we're never called with
3495 missing values. Use set_number() or set_number_errno() instead of
3496 rnc or frnc. Removed any stuff that caused trouble in testing.
3497 We can re-add it later if it really slows anything. Fix some
3499 (evaluate_tree_with_missing) Not yet supported. To be added later
3501 (repl_num_con) Removed.
3502 (collapse_node) New function.
3503 (force_repl_num_con) Removed.
3504 (set_number) New function.
3505 (set_number_errno) New function.
3506 (repl_str_con) Removed.
3507 (set_string) New function.
3508 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
3510 (dump_node) No special case for OP_AND, OP_OR.
3512 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
3513 (expr_get_type) New function.
3514 (type_check) Rewrite.
3515 (type_coercion) New function.
3516 (struct operator) New structure.
3517 (match_operator New function.
3518 (parse_binary_operators) New function.
3519 (parse_inverting_unary_operator) New function.
3520 (parse_or) Rewritten.
3521 (parse_and) Rewritten.
3522 (parse_not) Rewritten.
3523 (parse_rel) Rewritten.
3524 (parse_add) Rewritten.
3525 (parse_mul) Rewritten.
3526 (parse_neg) Rewritten.
3527 (parse_exp) Rewritten.
3528 (parse_sysvar) Add $TRUE, $FALSE system variables.
3529 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
3530 (parse_primary) Use allocate_var_node(), allocate_num_con(),
3532 (struct function) Remove desc, change `func' prototype.
3533 (unary_func) Remove special cases.
3534 (MISSING_func) Reduce to unary_func() that just returns a boolean.
3535 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
3536 (VALUE_func) Use allocate_var_node().
3537 (nary_num_func) Allow MIN and MAX for strings.
3538 Use allocate_var_node(). Properly clean up.
3540 (generic_str_func) Use local table instead of removed `desc'
3541 member. Mostly rewrite.
3542 (get_num_args) Revise error message.
3543 (parse_function) Return EXPR_ERROR, not 0 on error.
3545 (macro varies) Removed.
3546 (ops[]) Use expr.def.
3547 (free_node) Do nothing if node is null.
3548 (allocate_num_con) New function.
3549 (allocate_str_con) New function.
3550 (allocate_var_node) New function.
3551 (allocate_binary_nonterminal) New function.
3552 (append_nonterminal_arg) Removed.
3553 (static var func_tab[]) Revised.
3554 (expr_debug_print_postfix) Make parameter const.
3555 Use printf() instead of debug_printf().
3557 * expr.def: New file.
3559 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
3560 use named enum instead of unnamed, all references updated. Add
3561 EXPR_ANY, EXPR_NO_OPTIMIZE.
3563 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
3564 instead of defining OP_* directly.
3565 (macro IS_TERMINAL) New macro.
3566 (macro IS_NONTERMINAL) New macro.
3567 (enum OP_NO_FLAGS) New.
3569 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
3571 * error.c: (err_assert_fail) msg variable needs to be non-const.
3573 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
3575 * debug.c: (cmd_debug_evaluate) Rewrite.
3577 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
3579 Fix some CROSSTABS bit rot stupidity.
3581 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
3582 (internal_cmd_crosstabs) Initializes cells[] correctly.
3583 (float_M_suffix) Rename format_cell_entry(), change prototype,
3585 (display_crosstabulation) Fix cell formatting.
3587 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
3589 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
3590 to call lex_discard_line() to do that.
3592 * command.c: (run_command) Call lex_discard_line() after
3595 * lexer.c: (lex_entire_end) Change behavior.
3596 (lex_rest_of_line) Change behavior. Return const char *.
3597 (lex_discard_line) Don't clear getl_buf, don't emit message.
3599 * main.c: (handle_error) Emit message here.
3601 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
3602 instead of lex_entire_line().
3604 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
3606 * title.c: (get_title) Call lex_discard_line() after
3608 (cmd_file_label) Ditto.
3609 (cmd_document) Deal with const char * return value.
3611 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
3613 Removed REMARK command.
3615 * command.c: (extract_prefix) Removed.
3616 (output_line) Removed.
3617 (cmd_remark) Removed.
3619 * command.def: Remove REMARK.
3621 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
3623 Added abort() after lots of assert(0) invocations to avoid some
3624 compiler warnings. We really need a NOT_REACHED macro.
3626 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3628 * sort.c: Added missing call to temp_file_close. Changed error
3629 messages to warnings.
3631 * set.q: Improved setting of set_view{length,width} to be more tolerant
3634 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
3636 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
3637 used with incorrect syntax.
3639 * error.c, error.h et al: Overridden definition of assert for a
3642 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
3643 subcommand was given when it ought to have been.
3645 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
3647 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
3651 (tab_joint_text) Ditto.
3653 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
3655 * levene.c: Add #include.
3657 * set.q: (set_viewport) Add `int' argument to make its prototype
3658 correct for signal().
3660 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
3662 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
3665 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
3667 Changed DFM from open-at-first-access to explicit-open. Before,
3668 calling dfm_get_record() or dfm_put_record() would automatically
3669 open the file. Now, you have to call dfm_open_for_reading() or
3670 dfm_open_for_writing() explicitly. This makes it possible to
3671 check permissions, file existence, etc. earlier.
3673 Also made struct file_handle more opaque, and clean up in general.
3675 * data-list.c: (cmd_data_list) Open handle for reading.
3677 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
3679 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
3680 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
3681 (open_inline_file) Removed.
3682 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
3683 it. Deal with line_number in extension record instead of file
3685 (dfm_get_record) Rewrote.
3686 (dfm_put_record) Rewrote.
3687 (dfm_push) Assert file is open and one of ours. Deal with
3688 line_number in extension record instead of file handle.
3689 (dfm_pop) Assert file is open and one of ours. Deal with
3690 line_number in extension record instead of file handle.
3691 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
3694 * file-handle.h: (enum constants RH_RF_*) Removed.
3695 (enum constants FH_MD_*) Removed.
3696 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
3697 `recform', `lrecl', `mode' members. Public references to
3698 `recform' changed to use handle_get_mode(), references to `lrecl'
3699 changed to use handle_get_record_width(). Added `private' member.
3700 (enum file_handle_mode) New.
3702 * file-handle.q: (struct private_file_handle) New structure.
3703 (struct file_handle_list) New structure.
3704 (static var files) New.
3705 (static var file_handles) Removed.
3706 (init_file_handle) Removed.
3707 (create_file_handle) Removed.
3708 (get_handle_with_name) New function.
3709 (get_handle_for_filename) New function.
3710 (cmd_file_handle) Rewritten.
3711 (hash_file_handle) Removed.
3712 (cmp_file_handle) Removed.
3713 (fh_init_files) Rewritten.
3714 (fh_parse_file_handle) Rewritten. Allows identifiers as
3716 (fh_get_handle_by_name) Renamed handle_get_name(), all references
3718 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
3719 references updated. Rewritten.
3720 (fh_record_width) Renamed handle_get_record_width(), all
3721 references updated. Rewritten.
3722 (handle_get_mode) New function.
3724 * file-type.c: (cmd_file_type) Open handle for reading.
3726 * filename.c: [unix] (struct file_identity) New structure.
3727 [unix] (fn_get_identity) New function.
3728 [unix] (fn_free_identity) New function.
3729 [unix] (fn_compare_file_identities) New function.
3730 [!unix] (struct file_identity) New structure.
3731 [!unix] (fn_get_identity) New function.
3732 [!unix] (fn_free_identity) New function.
3733 [!unix] (fn_compare_file_identities) New function.
3735 * lexer.c: (static var put) Renamed put_token, all references
3737 (static var put_tokstr) New.
3738 (static var put_tokval) New.
3739 (lex_init) Initialize put_tokstr().
3740 (restore_token) New function.
3741 (save_token) New function.
3742 (lex_get) Use restore_token().
3743 (lex_put_back) Use save_token().
3744 (lex_put_back_id) New function.
3745 (lex_put_forward) Removed.
3746 (lex_preprocess_line) Set put_token instead of using
3748 (lex_negative_to_dash) Use save_token(), set put_token directly.
3749 (dump_token) Use stderr instead of stdout.
3751 * main.c: (main) Remove call to cmd_init().
3753 * matrix-data.c: (cmd_matrix_data) Open file for reading.
3755 * pfm-read.c: Use handle_get_filename() instead of trying to use
3756 h->fn directly, all over.
3758 * pfm-write.c: Ditto.
3760 * print.c: (internal_cmd_print) Open handle for writing.
3761 (dump_table) Use handle_get_filename().
3762 (print_trns_proc) Use handle_get_mode().
3763 (cmd_print_space) Use fh_parse_file_handle().
3764 Open handle for writing.
3765 [0] (debug_print) Removed.
3767 * sfm-read.c: Use handle_get_filename() instead of trying to use
3768 h->fn directly, all over.
3770 * sfm-write.c: Ditto.
3772 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
3776 * autorecode.c: (arc_free) Free arc->src_values.
3778 * error.c: (msg) Free buf.
3780 * val-labs.c: (do_value_labels) Always free vars.
3782 * vfm.c: (close_active_file) If sink has no make_source then call
3783 its destroy function.
3785 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
3787 Fixed cmd_parse() so that it always skips past a full command
3788 name. A few special commands for which this would be bad get
3789 special treatment. This lets us drop code for skipping past the
3790 end of a command name in most cmd_*() functions. It's not worth
3791 listing all the commands affected.
3793 * command.c: (struct command) Remove `cmd' member, replace by
3794 `name' member, all references updated. Remove `word', `next',
3795 `skip_entire_name' members.
3796 (macro DEFCMD) Deal with revised `struct command'.
3797 (macro UNIMPL) Ditto.
3798 (macro SPCCMD) New macro for commands whose last word shouldn't be
3800 (static array cmd_table[]) Make const, rename `commands', remove
3802 (macro COMMAND_CNT) New macro.
3803 (split_words) Removed.
3805 (FILE_TYPE_okay) Make parameter const.
3806 (cmd_parse) Improve error messages.
3807 (match_strings) New function.
3808 (next_word) New function.
3809 (enum command_match) New enum.
3810 (conflicting_3char_prefixes) New function.
3811 (conflicting_3char_prefix_command) New function.
3812 (cmd_match_words) New function.
3813 (count_matching_commands) New function.
3814 (get_command_name) New function.
3815 (free_words) New function.
3816 (unknown_command_error) New function.
3817 (figure_out_command) Renamed parse_command_name(), rewritten.
3819 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
3820 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
3821 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
3824 * command.h: (macro SPCCMD) New.
3826 * include.c: (cmd_include_at) Removed.
3827 (cmd_include) Allow identifier to be used as filename.
3829 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
3831 * t-test.q: (cmd_t_test) Command name is now parsed for us.
3834 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
3836 Start work on better test framework.
3838 * Makefile.am: (pspp_sources) Add debug.c.
3840 * debug.c: New file.
3842 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3843 cmd_debug_evaluate().
3845 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3847 * expr.h: (enum constant PXP_DUMP) Removed.
3849 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3851 * set.q: Implemented the SHOW command, and synced it to the existing
3854 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3855 changes as the window size is changed.
3857 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3858 environment variables if other methods are not available.
3860 glob.c: Removed a lot of global variables from glob.c and encapsulated
3863 random.c: Tidied up the way the random seed is set.
3865 str.c: Added a ds_vprintf function.
3867 error.c: Extended dump_message so that messages are always broken at
3870 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3872 * pfm-write.c: (bufwrite) Write out the correct element for string
3873 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3875 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3877 Get rid of static and global (!) vars in matrix-data.c.
3879 * matrix-data.c: (static var nr_data) Removed.
3880 (static var nr_factor_values) Removed.
3881 (static var max_cell_index) Removed.
3882 (static var split_values) Removed.
3883 (struct nr_aux_data) New structure.
3884 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3885 place of static vars, pass to create_case_source() and procedure()
3887 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3888 struct matrix_data_pgm *.
3889 (nr_read_splits) Ditto.
3890 (nr_read_factors) Ditto.
3891 (nr_output_data) Ditto.
3892 (static var wr_content) Removed.
3893 (global var wr_data) Removed.
3894 (global var wr_current) Removed.
3895 (struct wr_aux_data) New structure.
3896 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3897 place of static vars, pass to create_case_source() and procedure()
3899 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3900 instead of matrix_data_pgm *.
3901 (wr_read_splits) Ditto.
3902 (wr_output_data) Ditto.
3903 (wr_read_rowtype) Ditto.
3904 (wr_read_factors) Ditto.
3905 (wr_read_indeps) Ditto.
3907 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3909 Get rid of static vars in autorecode.c.
3911 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3912 `n_arc' to `spec_cnt'. All references updated.
3913 (static var v_src) Removed.
3914 (static var v_dest) Removed.
3915 (static var h_trns) Removed.
3916 (static var nv_src) Removed.
3917 (static var descend) Removed.
3918 (static var print) Removed.
3919 (enum direction) New enum.
3920 (struct autorecode_pgm) New structure.
3921 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3922 Move n_dest local var into struct autorecode_pgm for ease of
3923 clean-up. Use arc_free().
3924 (arc_free) New function.
3925 (recode) Modify to take struct autorecode_pgm * parameter instead
3926 of using statics. Let the caller clean up.
3927 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3928 instead of statics. Rearrange code a little.
3930 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3932 Get rid of static, global vars in recode.c. Remove debug code.
3934 * recode.c: (static var head) Removed.
3935 (global var v) Removed.
3936 (global var nv) Removed.
3937 (cmd_recode) New local variables head, v, nv. Initialize and free
3938 v. Don't call debug_print().
3939 [DEBUGGING] (dump_dest) Removed.
3940 [DEBUGGING] (debug_print) Removed.
3942 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3944 Get rid of static vars in expr-opt.c.
3946 * expr-opt.c: (static var e) Removed.
3947 (static var nop) Removed.
3948 (static var mop) Removed.
3949 (static var ndbl) Removed.
3950 (static var mdbl) Removed.
3951 (static var nstr) Removed.
3952 (static var mstr) Removed.
3953 (static var nvars) Removed.
3954 (static var mvars) Removed.
3955 (struct expr_dump_state) New structure.
3956 (dump_expression) Use new struct expr_dump_state instead of static
3957 vars and pass to functions we call.
3958 (dump_node) Use struct expr_dump_state * parameter.
3960 (emit_num_con) Ditto.
3961 (emit_str_con) Ditto.
3964 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3966 Get rid of static var in COUNT.
3968 * count.c: (static var head) Move into cmd_count().
3969 (cmd_count) [DEBUGGING] Don't call debug_print.
3970 [DEBUGGING] (debug_print) Removed.
3972 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3974 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3976 * val-labs.c: (static var v) Removed.
3977 (static var nv) Removed.
3978 [DEBUGGING] (debug_print) Removed.
3979 (verify_val_labs) Add struct variable **, int parameters.
3980 (get_label) Ditto. Improve error messages, streamline.
3981 (erase_labels) New function for erasing value labels, taking over
3982 part of verify_val_labs()'s function.
3985 (cmd_value_labels) No need to call init() or done() anymore.
3986 (cmd_add_value_labels) Ditto.
3987 (do_value_labels) Add vars, var_cnt local variables. Clean up
3988 after them internally. Call erase_labels() if we should. Don't
3991 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3993 Get rid of static vars in MATCH FILES.
3995 * get.c: (static var mtf_head) Removed.
3996 (static var mtf_tail) Removed.
3997 (static var mtf_by) Removed.
3998 (static var mtf_n_by) Removed.
3999 (static var mtf_master) Removed.
4000 (static var mtf_seq_num) Removed.
4001 (static var mtf_seq_nums) Removed.
4002 (static var mtf_sink) Removed.
4003 (static var mtf_case) Removed.
4004 (struct mtf_proc) New structure.
4005 (cmd_match_files) Use struct mtf_proc instead of static vars.
4006 (mtf_processing_finish) Ditto.
4008 (mtf_delete_file_in_place) Ditto.
4009 (mtf_read_nonactive_records) Ditto.
4010 (mtf_compare_BY_values) Ditto.
4011 (mtf_processing) Ditto.
4012 (mtf_merge_dictionary) Ditto.
4014 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
4016 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
4018 * dictionary.c: (dict_rename_var) Add assertion.
4019 (dict_contains_var) Check by index instead of name.
4021 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
4023 Get rid of compaction_necessary, compaction_nval, compaction_case.
4024 Redo VFM interface. Replace disk_sink and memory_sink by
4025 storage_sink, disk_source and memory_source by storage_source.
4027 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
4031 (struct write_case_data) Remove `begin_func', `end_func',
4032 `func_aux' members. Add `aux', `trns_case', `sink_case',
4033 `cases_written', `cases_analyzed' members.
4034 (global var compaction_necessary) Make static.
4035 (global var compaction_nval) Removed.
4036 (global var compaction_case) Removed.
4037 (static var case_count) Removed.
4038 (struct procedure_aux_data) Removed.
4039 (struct split_aux_data) Removed.
4040 (procedure) Remove begin_func, end_func parameters. Rewrite.
4041 (static var not_canceled) Removed.
4042 (process_active_file) Removed.
4043 (process_active_file_write_case) Removed.
4044 (process_active_file_output_case) Removed.
4045 (prepare_for_writing) Moved into open_active_file().
4046 (arrange_compaction) Ditto.
4048 (open_active_file) Rewrote.
4049 (write_case) New function.
4050 [DEBUGGING] (index_to_varname) Removed.
4051 (execute_transformations) New function.
4052 (exclude_this_case) Renamed filter_case(), changed interface.
4053 (clear_case) Added struct ccase * parameter to interface.
4054 (close_active_file) Added struct write_case_data * parameter,
4056 (disk_sink_create) Removed.
4057 (disk_sink_destroy) Removed.
4058 (disk_sink_make_source) Removed.
4059 (disk_sink_write) Removed.
4060 (disk_source_count) Removed.
4061 (disk_source_destroy) Removed.
4062 (disk_source_read) Removed.
4063 (global var disk_sink_class) Removed.
4064 (global var disk_source_class) Removed.
4065 (global var memory_sink_class) Removed.
4066 (global var memory_source_class) Removed.
4067 (memory_sink_create) Removed.
4068 (memory_sink_destroy) Removed.
4069 (memory_sink_make_source) Removed.
4070 (memory_sink_write) Removed.
4071 (memory_source_count) Removed.
4072 (memory_source_destroy) Removed.
4073 (memory_source_get_cases) Removed.
4074 (memory_source_read) Removed.
4075 (memory_source_set_cases) Removed.
4076 (struct disk_stream_info) Removed.
4077 (struct memory_sink_info) Removed.
4078 (struct memory_source_info) Removed.
4079 (write_active_file_to_disk) Removed.
4080 (destroy_storage_stream_info) New function.
4081 (global var null_sink_class) New var.
4082 (global var storage_sink_class) New var.
4083 (global var storage_source_class) New var.
4084 (open_storage_file) New function.
4085 (storage_sink_destroy) New function.
4086 (storage_sink_make_source) New function.
4087 (storage_sink_open) New function.
4088 (storage_sink_write) New function.
4089 (storage_source_count) New function.
4090 (storage_source_destroy) New function.
4091 (storage_source_get_cases) New function.
4092 (storage_source_on_disk) New function.
4093 (storage_source_read) New function.
4094 (storage_source_set_cases) New function.
4095 (storage_source_to_disk) New function.
4096 (storage_to_disk) New function.
4097 (struct storage_stream_info) New structure.
4098 (write_storage_file) New function.
4099 (procedure_write_case) Removed.
4100 (create_case_source) Add `struct dictionary *' parameter, all
4102 (create_case_sink) Ditto.
4103 (free_case_sink) New function.
4104 (struct split_aux_data) New structure.
4105 (procedure_with_splits) New function implementing what procedure()
4107 (SPLIT_FILE_proc_func) Removed.
4108 (procedure_with_splits_callback) New function.
4109 (equal_splits) New function.
4111 * aggregate.c: Pass around a struct instead of using statics.
4112 (static var outfile) Remove.
4113 (enum type) Give it tag `missing_treatment'.
4114 (static var missing) Remove.
4115 (static var sort) Remove.
4116 (static var agr_first) Remove.
4117 (static var agr_next) Remove.
4118 (static var case_count) Remove.
4119 (static var prev_case) Remove.
4120 (static var buf64_1xx) Remove.
4121 (static var buf_1xx) Remove.
4122 (struct agr_proc) New structure incorporating the above.
4123 (cmd_aggregate) Use new struct. Clean up error handling using
4124 agr_destroy(). Completely rewrite actual implementation of
4126 (create_sysfile) Add struct agr_proc * parameter, modify
4128 (parse_aggregate_functions) Ditto.
4129 (free_aggregate_functions) Ditto. Rename agr_destroy().
4130 (aggregate_single_case) Add struct agr_proc * parameter, modify
4132 (accumulate_aggregate_info) Ditto.
4133 (dump_aggregate_info) Ditto.
4134 (initialize_aggregate_info) Ditto.
4135 (agr_00x_trns_proc) Removed.
4136 (agr_00x_end_func) Removed.
4137 (agr_10x_trns_proc) Removed.
4138 (agr_10x_trns_free) Removed.
4139 (agr_10x_end_func) Removed.
4140 (agr_11x_read) Removed.
4141 (agr_11x_finish) Removed.
4142 [DEBUGGING] (debug_print) Removed.
4143 (write_case_to_sfm) Add struct agr_proc * parameter, modify
4145 (agr_to_active_file) New function.
4146 (presorted_agr_to_sysfile) New function.
4147 (sort_agr_to_sysfile) New function.
4149 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
4151 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
4153 * descript.q: (cmd_descriptives) Ditto.
4155 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
4156 to new procedure() interface.
4158 * command.c: (cmd_execute) Adapt to new procedure() interface.
4160 * dictionary.c: (dict_compact_values) Also delete scratch
4162 (dict_get_compacted_value_cnt) New function.
4163 (dict_get_compacted_idx_to_fv) New function.
4165 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
4166 (cmd_flip) Adapt to new procedure() interface.
4167 (flip_sink_write) Use sink->idx_to_fv.
4169 * frequencies.q: (internal_cmd_frequencies) Use
4170 procedure_with_splits().
4172 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
4173 (static var mtf_sink) New static var.
4174 (static var mtf_case) New static var.
4175 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
4176 we actually implement the matching.
4177 (mtf_delete_file_in_place) Use mtf_case.
4178 (mtf_processing) Use mtf_case and mtf_sink.
4179 (cmd_export) Adapt to new procedure() interface.
4181 * levene.c: (levene) Use procedure_with_splits().
4183 * list.q: (cmd_list) Use procedure_with_splits().
4185 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
4186 procedure() interface.
4187 (read_matrices_with_rowtype) Ditto.
4189 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
4190 TEMPORARY. Adapt to new procedure() interface.
4192 * rename-vars.c: Warn about and cancel TEMPORARY.
4194 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
4195 (sort_cases) Use dict_get_compacted_value_cnt() instead of
4196 compaction_nval. Adapt to new procedure() interface. Use
4197 storage_source_to_disk().
4198 (do_internal_sort) Don't try to dump the cases to memory.
4199 (compare_case_lists) Pass null idx_to_fv.
4200 (struct initial_run_state) Add `idx_to_fv' member. Remove
4202 (write_initial_runs) Don't initialize irs->case_size. Adapt to
4203 new procedure() interface. Reset irs->idx_to_fv after calling
4205 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
4206 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
4208 (destroy_initial_run_state) Don't dereference irs after freeing
4210 (allocate_cases) Don't calculate case_size locally.
4211 (compare_record) Add idx_to_fv parameter.
4212 (compare_record_run) Change parameter from struct sort_cases_pgm *
4213 to struct initial_run_state *. Pass irs->idx_to_fv to
4215 (compare_record_run) Third parameter now a struct
4216 initial_run_state *.
4217 (output_record) No need for out_case anymore. Pass irs, not
4218 struct sort_cases_pgm to pop_heap(). Use case_size from struct
4220 (merge) Use case_size from struct sort_cases_pgm.
4221 (merge_once) Use case_size from struct sort_cases_pgm.
4222 Pass null pointer to compare_record() as idx_to_fv.
4223 (global var sort_sink_class) Make static.
4225 * t-test.q: (cmd_t_test) Use procedure_with_splits().
4227 * temporary.c: Remove debugging crap.
4229 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
4231 * t-test.q, levene.c: Fixed up the handling of MISSING values
4234 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
4236 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
4239 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
4241 Change explicit variable name checks into use of
4242 dict_class_from_id().
4244 * dictionary.c: (dict_create_var) Change explicit variable name
4245 check into use of dict_class_from_id().
4247 * get.c: (trim_dictionary) Ditto.
4249 * sel-if.c: (cmd_filter) Ditto.
4251 * sysfile-info.c: (cmd_display) Ditto.
4253 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
4255 * vfm.c: (arrange_compaction) Ditto.
4257 * weight.c: (cmd_weight) Ditto.
4259 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
4261 * temporary.c: (cmd_temporary) When TEMPORARY was the first
4262 transformation following the input program, if any, for some
4263 reason we special-cased f_trns. That's just wrong. It should
4264 always be set to n_trns.
4266 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
4268 * format.c: (parse_format_specifier_name) Fix brown-bag bug
4269 introduced in last check-in.
4271 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
4273 * format.c: (global array translate_fmt[]) Removed.
4274 (translate_fmt) New function as replacement.
4275 (parse_format_specifier_name) Rewrite.
4277 * pfm-read.c: (convert_format) Use translate_fmt() instead of
4280 * sfm-read.c: (parse_format_spec) Ditto.
4282 * postscript.c: (text) Fix handling of fonts with missing
4285 * sort.c: (struct external_sort) Add temp_name member.
4286 (destroy_external_sort) Free temp_dir, temp_name members.
4287 (init_external_sort) Allocate temp_name.
4288 (get_temp_file_name) Change prototype.
4289 (open_temp_file) Deal with change to get_temp_file_name().
4290 (close_temp_file) Ditto.
4291 (remove_temp_file) Ditto.
4292 (write_temp_file) Ditto.
4293 (read_temp_file) Ditto.
4294 (sort_sink_destroy) Removed.
4295 (sort_sink_class) Change destroy member to null.
4297 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
4299 Eliminate temp_case.
4301 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
4302 anymore. Use agr_11x_finish().
4303 (aggregate_single_case) Make first param const.
4304 (accumulate_aggregate_info) Ditto.
4305 (agr_00x_end_func) Use compaction_case, not temp_case.
4306 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
4308 * data-list.c: (struct data_list_pgm) Add `case_size' member.
4309 (cmd_data_list) Initialize case_size.
4310 (read_from_data_list_fixed) Add struct ccase * param, use instead
4312 (read_from_data_list_free) Ditto.
4313 (read_from_data_list_list) Ditto.
4314 (read_one_case) Rename data_list_trns_proc(), all references
4315 updated. Add argument in calling above functions. Use c
4316 argument instead of temp_case.
4317 (destroy_dls) Rename data_list_trns_free(), all references
4320 * expr-evl.c: (expr_evaluate) Make second parameter const.
4322 * file-type.c: (struct file_type_pgm) Add `case_size' member.
4323 (cmd_end_file_type) Initialize `case_size'.
4324 (file_type_source_read) Add struct ccase * parameter. Use instead
4327 * flip.c: Rewritten.
4329 * get.c: (struct get_pgm) New structure to keep track of
4331 (cmd_get) Initialize case_size.
4333 (get_source) Deal with struct get_pgm.
4334 (get_source_read) Add struct ccase * parameter, use instead of
4336 (import_source_read) Ditto.
4338 * get.c: Use a null pointer instead of temp_case to represent the
4339 "current case" in a struct mtf_file's input member.
4340 (mtf_processing_finish) Pass null to mtf_processing(), not
4342 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
4343 (mtf_compare_BY_values) Add extra arg, use instead of null input
4345 (mtf_processing) Use c parameter instead of temp_case. Pass
4346 compaction_case to process_active_file_output_case().
4348 * glob.c: (global variable temp_case) Removed.
4350 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
4351 (cmd_input_program) Initialize case_size. Set
4352 vfm_source->value_cnt.
4353 (init_case) Add struct ccase * parameter, use instead of
4356 (input_program_source_read) Ditto.
4358 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
4359 (dump_cell_content) Ditto.
4360 (nr_output_data) Ditto.
4361 (read_matrices_without_rowtype) Ditto.
4362 (matrix_data_read_with_rowtype) Ditto.
4363 (wr_read_splits) Ditto.
4364 (wr_output_data) Ditto.
4366 * sort.h: (struct sort_cases_pgm) New member `case_size'.
4368 * sort.c: (sort_cases) Initialize scp->case_size.
4369 (struct external_sort) Remove `case_size' member.
4370 (write_initial_runs) Only call vfm_sink->class_destroy if
4372 (struct sort_source_aux) New structure.
4373 (sort_source_read_helper) New function.
4374 (sort_source_read) Use sort_source_read_helper().
4375 (read_sort_output) Change interface to be more reasonable.
4376 (read_internal_sort_output) Ditto.
4377 (read_external_sort_output) Ditto.
4379 * vars-prs.c: (dict_class_to_name) Pass return value through
4382 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
4383 (procedure) Initialize trns_case.
4384 (procedure) Pass trns_case to vfm_source->class->read().
4386 (process_active_file) Start using struct procedure_aux_data.
4387 (process_active_file_write_case) Pass trns_case to
4388 transformations, lag_case(), clear_case().
4389 (process_active_file_output_case) Add struct ccase * parameter.
4390 (create_trns_case) New function.
4391 (make_temp_case) Removed.
4392 (vector_initialization) Removed.
4393 (close_active_file) Only call make_source if non-null, otherwise
4394 set vfm_source to null pointer. Don't free temp_case.
4395 (disk_source_read) Add struct ccase * parameter, use instead of
4397 (memory_source_read) Ditto.
4398 (lag_case) Add const struct ccase * member.
4399 (procedure_write_case) Use trns_case instead of temp_case.
4400 (clear_case) Add struct ccase * member, use instead of temp_case.
4401 (exclude_this_case) Ditto.
4402 (create_case_source) Add struct dictionary * parameter, use to
4403 initialize source->value_cnt.
4405 * vfm.h: (struct case_source) Add `value_cnt' member.
4406 (struct case_source_class) Add struct ccase * parameter to `read'
4407 member function pointer.
4408 (struct case_sink_class) Make struct ccase * parameter const in
4409 `write' member function pointer.
4411 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
4413 Fix a lot of "possibly uninitialized variable" warnings. Some of
4414 them are even real bugs. A few of them make me wonder how the
4417 * aggregate.c: (parse_aggregate_functions) Initialize `function.
4419 * ascii.c: (output_lines) Add default case to switch.
4421 * crosstabs.q: Remove static variable `expected' and all
4423 (display_crosstabulation) Always calculate expected value.
4425 (output_pivot_table) Initialize `cmp'.
4426 (display_crosstabulation) New variable `last_row', which is
4429 * data-in.c: (parse_numeric) Always initialize sign. How did this
4432 * data-list.c: (repeating_data_trns_proc) Always initialize code.
4433 Always set info.ofs. (How did this work?!)
4435 * expr-opt.c: (optimize_tree) Always initialize `m'.
4436 (evaluate_tree) Always initialize `c'. (How did this work?)
4438 * frequencies.q: (frq_custom_variables) Always initialize min,
4440 (frq_custom_grouped) Always initialize `dl'.
4442 * groff-font.c: (groff_read_font) Always initialize char_set.
4444 * matrix-data.c: (nr_output_data) Initialize `split'.
4445 (wr_read_splits) Remove shadowing split_cnt declaration.
4446 (wr_output_data) Initialize `split'.
4448 * output.c: (tokener) Skip add character on syntax error.
4450 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
4452 * postscript.c: (read_ps_encodings) Use line.string instead of
4454 (write_text) Add default case to switch.
4455 (text) Always initialize multiple variables. Fix bug with
4458 * print.c: (fixed_parse_fortran) Initialize head.
4459 (alloc_line) Add default case to switch.
4461 * recode.c: (parse_dest_spec) Handle case where nothing matches.
4462 (recode_trns_proc) Move variable declaration inward. Add default
4465 * sfm-read.c: (read_header) Initialize skip_amt.
4467 * sysfile-info.c: (display_variables) Always initialize pc.
4469 * vars-prs.c: Initialized `included'.
4471 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
4473 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
4474 Just use signal() instead.
4476 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
4478 Get rid of vfm_sink_info and vfm_source_info.
4480 * aggregate.c: (agr_00x_end_func) Don't increment
4481 sfm_sink_info.ncases.
4483 * sort.c: (do_internal_sort) Get case count from
4484 vfm_source->class->count().
4485 (struct external_sort) Add `case_size' member.
4486 (do_external_sort) Initialize case_size.
4487 (struct initial_run_state) Add `case_size' member.
4488 (write_initial_runs) Initialize case_size.
4489 (sort_sink_write) Use case_size.
4490 (read_external_sort_output) Use case_size. Get case_cnt from
4493 * vfm.c: (struct write_case_data) Add underscores to existing arg
4494 names, all references updated. Renamed `aux' as `func_aux', all
4495 references updated. Added new `aux' member.
4496 (global var vfm_source_info) Removed.
4497 (global var vfm_sink_info) Removed.
4498 (struct procedure_aux_data) New.
4499 (struct split_aux_data) New.
4500 (procedure) Use `aux' fields for procedure_aux_data,
4502 (process_active_file_write_case) Pass case_count + 1 to
4503 transformation procedures, exclude_this_case().
4504 (process_active_file_output_case) Don't increment
4505 vfm_sink_info.ncases.
4506 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
4507 to send data to disk early.
4508 (make_temp_case) Don't use vfm_sink_info.case_size.
4509 (close_active_file) Don't initialize vfm_source_info.
4510 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
4511 (disk_sink_create) Initialize and/or update disk_stream_info.
4512 (disk_sink_write) Ditto.
4513 (disk_sink_destroy) Ditto.
4514 (disk_sink_make_source) Ditto.
4515 (disk_source_read) Ditto.
4516 (disk_source_destroy) Ditto.
4517 (global var disk_source_class) Add disk_source_count().
4518 (disk_source_count) New function.
4519 (struct memory_sink_info) Add `case_cnt', `case_size' members.
4520 (struct memory_source_info) Ditto.
4521 (memory_sink_create) Deal with case_cnt, case_size.
4522 (memory_sink_write) Ditto.
4523 (memory_sink_make_source) Ditto.
4524 (memory_source_read) Ditto.
4525 (memory_source_count) New function.
4526 (memory_source_class) Add memory_source_count().
4527 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
4528 proc_aux->cases_written, and pass it to transformation procedures
4529 and exclude_this_case ().
4530 (exclude_this_case) Add case_num parameter. Pass it to
4532 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
4535 * vfm.h: (struct case_source_class) Add `count' member.
4537 * vfmP.h: (struct stream_info) Removed.
4538 (global variable vfm_source_info) Removed.
4539 (global variable vfm_sink_info) Removed.
4541 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
4543 * var.h: (typedef trns_proc_func) New typedef.
4544 (trns_free_func) New typedef.
4545 (struct trns_header) Change `proc' to type trns_proc_func, `free'
4546 to type trns_free_func. This only changes the actual type of
4547 trns_proc_func, adding a `case_num' parameter. Updated all
4548 implementations to use the typedefs instead.
4550 * compute.c: (compute_num) Pass case_num to expr_evaluate().
4551 (compute_num_vec) Ditto.
4552 (compute_str) Ditto.
4553 (compute_str_vec) Ditto.
4555 * do-if.c: (do_if_trns_proc) Ditto.
4557 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
4560 * inpt-pgm.c: (input_program_source_read) Maintain case count,
4561 pass to transformation functions.
4562 (reread_trns_proc) Pass case_num arg to expr_evaluate().
4564 * loop.c: (loop_1_trns_proc) Ditto.
4565 (loop_2_trns_proc) Ditto.
4566 (loop_3_trns_proc) Ditto.
4568 * print.c: (print_space_trns_proc) Ditto.
4570 * sel-if.c: (select_if_proc) Ditto.
4572 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
4574 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
4575 destroying hash table.
4577 * glob.c: (read_active_file) Variable not referenced, removed.
4578 (cancel_input_pgm) Ditto.
4580 * levene.c: Add #include <stdlib.h> needed to call free().
4582 * aggregate.c: (parse_aggregate_functions) Make `function'
4585 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
4587 Start working to eliminate VFM dependence on static variables.
4589 * command.c: (cmd_parse) Use case_source_is_class().
4591 * data-list.c: Rewrite to eliminate use of static variables.
4593 * dfm.c: (cmd_begin_data) Use case_source_is_class().
4595 * file-handle.q: (fh_handle_name) Make parameter const.
4597 * file-type.c: Rewrite to eliminate use of static variables.
4599 * flip.c: Rewrite to eliminate use of static variables.
4601 * format.c: (get_format_var_width) New function.
4603 * get.c: Eliminate use of static variables.
4605 * inpt-pgm.c: Eliminate use of static variables.
4607 * matrix-data.c: Eliminate use of static variables.
4609 * set.q: (set_max_workspace) New variable.
4610 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
4612 * var.h: (struct case_list) Move here from vfmP.h.
4614 * vars-atr.c: (discard_variables) Handle new vfm_source type.
4616 * vfm.c: (vfm_source) Change type from struct case_stream to
4618 (vfm_sink) Change type from struct case_stream to struct
4620 (static var paging) Rename workspace_overflow, all references
4622 (procedure) Use new class structures.
4623 (process_active_file) Ditto.
4624 (process_active_file_write_case) Ditto.
4625 (prepare_for_writing) Use set_max_workspace. Use new class
4627 (close_active_file) Use new class structures. Free old sink.
4628 (global var disk_source_file) Removed.
4629 (global var disk_sink_file) Removed.
4630 (disk_stream_init) Removed.
4631 (disk_stream_read) Removed.
4632 (disk_stream_write) Removed.
4633 (disk_stream_mode) Removed.
4634 (disk_stream_destroy_source) Removed.
4635 (disk_stream_destroy_sink) Removed.
4636 (global var vfm_disk_stream) Removed.
4637 (disk_sink_create) New function.
4638 (disk_sink_write) New function.
4639 (disk_sink_destroy) New function.
4640 (disk_sink_make_source) New function.
4641 (disk_sink_class) New static var.
4642 (disk_source_read) New function.
4643 (disk_source_destroy) New function.
4644 (global var vfm_source_class) New var.
4645 (global var memory_source_cases) Removed.
4646 (global var memory_sink_cases) Removed.
4647 (global var memory_sink_max_cases) Removed.
4648 (struct memory_sink_info) New struct.
4649 (memory_stream_init) Removed.
4650 (memory_stream_read) Removed.
4651 (memory_stream_write) Removed.
4652 (memory_stream_mode) Removed.
4653 (memory_stream_destroy_source) Removed.
4654 (memory_stream_destroy_sink) Removed.
4655 (global var vfm_memory_stream) Removed.
4656 (page_to_disk) Renamed write_active_file_to_disk().
4657 (memory_sink_create) New function.
4658 (memory_sink_write) New function.
4659 (memory_sink_destroy) New function.
4660 (memory_sink_make_source) New function.
4661 (memory_sink_class) New static var.
4662 (memory_source_read) New function.
4663 (memory_source_destroy) New function.
4664 (memory_source_get_cases) New function.
4665 (memory_source_set_cases) New function.
4666 (global var vfm_source_class) New var.
4667 (procedure_write_case) Use new class structures.
4668 (create_case_source) New function.
4669 (case_source_is_complex) New function.
4670 (case_source_is_class) New function.
4671 (create_case_sink) New function.
4673 * vfm.h: (global variable reinit_sysmis) Not used, removed.
4674 (global variable reinit_blanks) Not used, removed.
4675 (global variable init_zero) Not used, removed.
4676 (global variable init_blanks) Not used, removed.
4677 (struct case_source) New struct.
4678 (struct case_source_class) New struct.
4679 (struct case_sink) New struct.
4680 (struct case_sink_class) New struct.
4681 (struct case_stream) Removed.
4683 * vfmP.h: (struct case_list) Moved to var.h.
4685 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
4687 * algorithm.c: (count_equal) New function.
4688 (count_if) New function.
4689 (unique) Add assertions.
4690 (partition) Add assertions.
4691 (is_partitioned) New function.
4692 (copy_if) Add assertions.
4693 (remove_equal) Add assertions.
4694 (lexicographical_compare) Rename lexicographical_compare_3way.
4695 (sort) Add assertions. Rephrase some code.
4696 (is_sorted) New function.
4698 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
4702 * sort.c: Completely rewrite.
4704 * sort.h: Expose interface via struct sort_cases_pgm, not via
4707 * aggregate.c: (sort) New static var.
4708 (cmd_aggregate) Use sort.
4709 (create_sysfile) Ditto.
4710 (aggregate_single_case) Ditto.
4711 (dump_aggregate_info) Ditto.
4712 (agr_00x_end_func) Ditto.
4713 (debug_print) Ditto.
4715 * var.h: (enum SRT_ASCEND) Removed.
4716 (enum SRT_DESCEND) Removed.
4717 (struct sort_cases_proc) Removed.
4718 (struct variable) Remove p.srt member.
4720 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
4722 Get rid of the old, crappy heap structure and replace it by a new,
4723 shiny, C++ STL-like heap structure.
4725 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
4727 * algorithm.c: (push_heap) New function.
4738 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
4740 Increase warning level.
4742 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
4744 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
4746 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
4748 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
4750 * dictionary.c: (dict_create_var) Fix root cause of bug worked
4751 around by previous change log entry.
4753 * compute.c: (lvalue_finalize) Remove workaround from previous
4756 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4758 * compute.c: Fixed a bug where the Format was not getting set for
4759 computed variables (thus causing a crash when SAVEing).
4761 * Added a test to stop this bug ever coming back
4763 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
4765 Got rid of approx.h. In general, replaced all references to
4766 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
4769 * Makefile.am: (pspp_SOURCES) Removed approx.h.
4771 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
4772 test for mag < EPSILON.
4774 * misc.h: Add definition of EPSILON.
4776 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
4778 * vfm.c: (procedure) Add check to prevent recursive call.
4780 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
4782 * Moved the declarations relating to values to their own header file
4785 * Added levene.c and levene.h
4787 * vars-atr.c: Changed the signature of compare_values to
4788 take const * arguments.
4790 * t-test.q: Changed the structure of struct t_test_proc
4791 variables now contain their own group statistics information.
4792 Eventually, t_test_proc might get renamed, because it'd be
4793 applicable to other commands too.
4795 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
4797 * data-out.c: Clean up. Changed interface of convert_*() to take
4798 either a `double' or a `const char *' instead of a `const union
4799 value *'. Update all implementations of those interfaces.
4800 (data_out) Use switch statements instead of a table.
4801 (convert_AHEX) Rewrite.
4803 * format.h: Update comment.
4805 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
4807 * q2c.c: (dump_header) Add an Emacs header line to output files
4808 that makes generated .c files read-only by default, to make it
4809 difficult to accidentally change generated files.
4811 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
4813 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
4814 not bogus a->v.c <=> b->v.c pointer compare.
4815 (compare_freq_alpha_a) Ditto.
4816 (compare_freq_numeric_d) Ditto.
4817 (compare_freq_alpha_d) Ditto.
4819 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
4821 Changed data_out() to store string data directly into a `union
4822 value''s s member, not indirectly into c.
4824 * crosstabs.q: (output_pivot_table) Use format_short() instead of
4826 (table_value_missing) Ditto.
4827 (float_M_suffix) Ditto.
4828 (format_short) New function.
4830 * data-in.h: (data_in_finite_line) Remove inline definition.
4832 * data-list.c: (destroy_dls_var_spec) New function.
4833 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
4834 (data_list_source_destroy_source) Avoid cast.
4835 (struct repeating_data_trns) New field `id_value'. Update
4837 (cmd_repeating_data) Initialize id_value. Use new
4838 repeating_data_trns_free() for freeing REPEATING DATA
4840 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4841 (repeating_data_trns_free) New function.
4843 * data-out.c: (data_out) Change return type to `void' by replacing
4844 error returns by writing a message into the output buffer.
4845 (convert_A) Read from v->s instead of v->c.
4846 (convert_AHEX) Ditto.
4848 * expr-evl.c: Update comment.
4849 (expr_evaluate) Add assertion in OP_STRING case.
4851 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4853 * list.q: (list_cases) Update for new data_out() semantics.
4855 * print.c: (print_trns_proc) Ditto.
4857 * tab.c: (tab_value) Ditto.
4858 (tab_float) Avoid stupid cast.
4860 * var.h: Update comments.
4861 (macro MAX_STRING) New macro.
4862 (macro MAX_ELEMS_PER_VALUE) New macro.
4864 * vars-atr.c: (compare_values) New function.
4866 * vfm.c: (dump_splits) Update for new data_out() semantics.
4868 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4870 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4872 (struct crosstab) Rename v[] to vars[]. All references updated.
4873 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4874 same time, which caused the hash value to depend only on a single
4875 value, not all of the variables' values.
4877 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4879 Clean up struct dictionary's value_cnt usage.
4881 * dictionary.c: Add a function comment to each function.
4882 (struct dictionary) Rename value_cnt to next_value_idx, which more
4883 accurately reflects its meaning. All references updated.
4884 (dict_rename_vars) Add assertion.
4885 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4887 (dict_get_case_size) New function.
4889 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4891 * get.c: (mtf_read_nonactive_records) Ditto.
4893 * sort.c: (allocate_cases) Ditto.
4894 (write_initial_runs) Ditto.
4898 * vfm.c: (prepare_for_writing) Ditto.
4902 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4904 Make vfm.c slightly less grotesque.
4906 * vfm.c: (filter_var) Removed.
4907 (filter_index) Removed.
4908 (FILTERED macro) Removed.
4909 (exclude_this_case) New function.
4910 (process_active_file_write_case) Use exclude_this_case() instead
4911 of FILTERED and inline tests.
4912 (procedure_write_case) Ditto.
4913 (setup_filter) Removed.
4914 (open_active_file) Don't call setup_filter().
4915 (close_active_file) Call dict_get_filter() instead of checking
4918 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4920 * var.h: (struct variable) Update comments.
4922 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4924 New functions dict_create_var_assert(), dict_lookup_var_assert().
4925 Converted several dict_*_var()/assert pairs into a single
4926 dict_*_var_assert().
4928 * dictionary.c: (dict_create_var_assert) New function.
4929 (dict_lookup_var_assert) New function.
4931 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4933 Got rid of "struct long_vec", envector(), devector(), etc. Added
4934 two members `init', `reinit' to struct variable as a substitute.
4936 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4942 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4945 * autorecode.c: (cmd_autorecode) destvars don't need init.
4947 * compute.c: (lvalue_finalize) Set reinit.
4949 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4950 (dump_fmt_list) Ditto.
4953 * descript.q: (run_z_pass) Don't need init for z-scores.
4955 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4957 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4959 * glob.c: (init_glob) Remove vec_init() calls.
4961 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4963 * loop.c: (internal_cmd_loop) Don't need to call envector().
4965 * numeric.c: (cmd_numeric) Ditto.
4967 (cmd_leave) Ditto. Set `init', `reinit' members.
4969 * recode.c: (cmd_recode) Don't need to call envector().
4971 * repeat.c: (internal_cmd_do_repeat) Ditto.
4973 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4974 (force_create_variable) Removed prototype.
4975 (force_dup_variable) Ditto.
4977 * vector.c: (cmd_vector) Don't need to call envector().
4979 * vfm.c: (reinit_sysmis) Removed.
4980 (reinit_blanks) Removed.
4981 (init_zero) Removed.
4982 (init_blanks) Removed.
4983 (process_active_file_write_case) No need to deal with vectors.
4984 Call clear_temp_case().
4985 (vector_initialization) Rewrite to use `init', `reinit'.
4986 (close_active_file) No need to call vec_clear().
4987 (procedure_write_case) Call clear_temp_case().
4988 (clear_temp_case) New function.
4990 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4992 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4995 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4997 Add auxiliary argument to procedure() interface. Associated small
4998 clean-ups of vfm interface.
5000 * Updated every caller of procedure() and process_active_file() to
5001 reflect modified interface. Simple, ordinary changes not listed
5004 * Updated every function that implements struct case_stream's
5005 `read' function to take a write_case_func and a write_case_data.
5006 Also updated every caller of write_case() to instead call them
5007 through these arguments. In some cases this meant that the extra
5008 args had to be threaded through a couple of extra levels. This
5009 wasn't difficult or interesting so the details won't be given.
5011 * data-list.c: (struct repeating_data_trns) Add members
5012 `write_case', `wc_data' as kluge.
5013 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
5015 (repeating_data_set_write_case) New function.
5017 * data-list.h: New file to declare repeating_data_trns_proc() and
5018 repeating_data_set_write_case().
5020 * inpt-pgm.c: (input_program_source_read) Call
5021 repeating_data_set_write_case() for all the REPEATING DATA
5022 transformations, so that they know where to send their cases.
5023 It's a big kluge. Also kluge in END CASE.
5024 (end_case_trns_proc) Never called anymore, but we still need it,
5027 * sort.c: (read_sort_output) Update to match struct case_stream
5030 * vfm.c: (struct write_case_data) New structure.
5031 (proc_func) Removed.
5032 (virt_proc_func) Removed.
5033 (begin_func) Removed.
5034 (virt_begin_func) Removed.
5036 (write_case) Removed.
5037 (procedure) Added an auxiliary parameter to each function pointer
5038 argument's prototype. Added an auxiliary data parameter.
5040 (process_active_file) Ditto.
5041 (process_active_file_write_case) Pass aux data along.
5042 (close_active_file) Ditto.
5043 (procedure_write_case) Ditto.
5044 (SPLIT_FILE_procfunc) Ditto.
5046 * vfm.h: (typedef write_case_data) New.
5047 (typedef write_case_func) New.
5048 (struct case_stream) Add parameters to `read' member prototype.
5050 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
5052 * t-test.q: Added calculations for independent samples. (But no Levene
5055 * Makefile.am: Moved q_sources_c into own variable
5057 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
5059 Miscellaneous cleanups.
5061 * Change unused to UNUSED in many source files to reflect modified
5062 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
5063 __CYGWIN32__, __unix__, and unix not to assume that they're
5064 defined to a nonzero value. Change use of __attribute__ to use
5065 NO_RETURN or PRINTF_FORMAT instead.
5067 * alloc.h: Move definitions for local_alloc(), local_free() here
5068 from ../pref.h.orig and simplify.
5070 * expr-evl.c: Instead of working differently based on PAGED_STACK,
5071 use a pool allocator unconditionally.
5072 (CHECK_STRING_SPACE) Removed.
5073 (ALLOC_STRING_SPACE) Removed.
5074 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
5077 * expr-opt.c: (dump_expression) Allocate string pool.
5079 * expr-prs.c: (expr_free) Free string pool.
5081 * pool.c: (pool_destroy) This pool must be removed from its
5082 parent's list of gizmos, not from its own. Use free_all_gizmos().
5083 (pool_clear) New function.
5084 (free_all_gizmos) New function.
5085 (pool_alloc) Use space in empty block after this one if any.
5086 (pool_release) Only empty out blocks, don't actually free() them.
5088 * print.c: Get rid of PAGED_STACK special case by always
5089 dynamically allocating line buffers.
5090 (struct print_trns) Always include the `line' member.
5091 (internal_cmd_print) Always initialize the `line' member.
5092 (alloc_line) Always allocate memory for `line'.
5093 (print_trns_proc) Always initialize buf from `line' member.
5094 (print_trns_free) Always free `line' memory.
5096 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
5099 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
5101 * flip.c: Fixed crash from FLIP when a numeric variable is
5102 specified on NEWNAMES and a large value is used, and a couple of
5103 other minor bugs besides.
5104 (struct varname) Make name a 9-character fixed-size array
5105 instead of a 1-character variable size array.
5106 (make_new_var) Allow digits in variable names.
5107 (flip_stream_write) Limit numeric values to 8 characters and
5108 format system missing and very large and small values more
5111 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
5113 * command.c: Fixed test on command return status for the correct
5114 value, which had been causing a crash under certain invalid input.
5116 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
5118 * t-test.q: Added calculations for the one sample variant of the T-TEST
5120 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
5122 * tab.c: (render_strip) Fix bug that sometimes caused joined text
5123 in joined cells to be rendered outside box boundaries.
5125 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
5127 * random.c (rng_create): Fixed seeding so that it gets reseeded after
5128 SET seed=xx has been called.
5130 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
5132 * random.c (rng_get_double): Fix always-returning-zero bug in my
5133 preferred way, and at the same time make sure rounding doesn't
5136 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
5138 * html.c: (change_attributes) Dead code, removed.
5139 (escape_string) Eliminate code to call change_attributes() that
5140 never actually called it.
5141 (output_tab_table) Get rid of dependence on tab_hit
5142 and struct tab_joined_cell's hit member, which are abominations.
5144 * tab.c: (tab_output_text) Don't call
5145 d->class->text_set_font_by_name if it's a null pointer.
5146 (macro UNROLL_LOOP) Eliminate.
5147 (macro UNROLL_3_LOOPS) Eliminate.
5148 (tabi_render) Rewrite not to use the above macros.
5150 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
5152 Start working on a new output driver system, one that doesn't suck
5153 so much, by adding a "device-independent" output driver. The idea
5154 is to write out only a single output stream, then use separate
5155 processes to translate them into whatever formats we want. This
5156 is similar to how "groff" works with its various output drivers
5157 (grops, grotty, grodvi, ...).
5159 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
5161 * list.q: (write_all_headers) Stub out devind class.
5163 (determine_layout) Ditto.
5166 * output.c: (outp_init) Add devind class.
5168 * devind.c: New file.
5170 * devind.h: New file.
5172 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
5174 * frequencies.q: (hash_value_alpha) Fixed up the previous change
5175 to use the proper string length.
5177 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5179 * Fixed bug where FREQ would crash on alpha values
5181 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
5183 * Removed bletcherous alloca() workarounds for AIX from top of
5184 many files. AIX can use the alternative alloca() implementation
5187 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
5189 * ascii.c: (ascii_option) Fix implementation of headers option.
5191 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
5193 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
5194 multiple blank lines into one.
5195 (struct ascii_driver_ext) Add squeeze_blank_lines option.
5196 (ascii_preopen_driver) Initialize squeeze_blank_lines.
5197 (static var option_tab) Add squeeze entry.
5198 (ascii_option) Set squeeze_blank_lines.
5199 (output_lines) Implement squeezing blank lines.
5201 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
5203 * Removed redundant code from output.h
5205 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
5207 Dictionary classes: each variable is "ordinary", "system", or
5210 * var.h: (enum dict_class) New enum.
5212 * vars-prs.c: (dict_class_from_id) New function.
5213 (dict_class_to_name) New function.
5215 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
5217 * var.h: (struct freq_tab_set) Removed (not used).
5219 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
5221 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
5223 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
5225 * stats.c: (hypercube) Rename pow4(). All references updated.
5227 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
5229 * rename-vars.c: (cmd_rename_variables) Rewritten.
5230 (compare_name) Removed.
5232 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
5234 var_set feature, and code taking advantage of it.
5236 * crosstabs.q: (static var var_dict) Removed.
5237 (static var variables) New variable.
5238 (static var variables_cnt) New variable.
5239 (cmd_crosstabs) Free variables instead of var_dict.
5240 (internal_cmd_crosstabs) Initialize and use variables,
5241 variables_cnt instead of var_dict.
5242 (free_var_dict) Removed.
5243 (crs_custom_tables) Use var_set instead of a copied dictionary.
5244 (crs_custom_variables) Set up variables, variables_cnt instead of
5246 [DEBUGGING] (debug_print) Ditto.
5248 * means.q: (mns_custom_tables) Use var_set instead of a copied
5251 * vars-prs.c: (parse_vs_variable) New function.
5252 (parse_dict_variable) Rewritten.
5253 (parse_variable) Rewritten.
5254 (parse_variables) Renamed parse_var_set_vars(), rewritten.
5255 (parse_variables) New function in terms of parse_var_set_vars().
5256 Now requires its first argument to be non-null. All references
5257 that passed a null pointer updated to pass default_dict instead.
5258 (macro id_dict) Removed.
5259 (parse_DATA_LIST_vars) Add assertions.
5260 (parse_mixed_vars) Ditto.
5261 (struct var_set) New structure.
5262 (var_set_get_cnt) New function.
5263 (var_set_get_var) New function.
5264 (var_set_lookup_var) New function.
5265 (var_set_destroy) New function.
5266 (dict_var_set_get_cnt) New function.
5267 (dict_var_set_get_var) New function.
5268 (dict_var_set_lookup_var) New function.
5269 (dict_var_set_destroy) New function.
5270 (var_set_create_from_dict) New function.
5271 (struct array_var_set) New structure.
5272 (array_var_set_get_cnt) New function.
5273 (array_var_set_get_var) New function.
5274 (array_var_set_lookup_var) New function.
5275 (array_var_set_destroy) New function.
5276 (var_set_create_from_array) New function.
5278 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
5279 instead of parse_variables(NULL, ...) in output code.
5281 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
5283 Change inp_init from a 2-bit vector to an ordinary array.
5284 Initialize it all in cmd_end_input_program() instead of in
5287 * inpt-pgm.c: (enum value_init_type) New enum.
5288 (global var inp_init) Change to `enum value_init_type *', make
5290 (inp_init_size) Removed.
5291 (inp_nval) Change to `size_t', make static.
5292 (cmd_input_program) Don't initialize inp_init or inp_init_size.
5293 (cmd_end_input_program) Initialize inp_init, inp_nval.
5294 (init_case) Rewrite.
5295 (clear_case) Rewrite.
5297 * inpt-pgm.h: Removed.
5299 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
5301 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
5302 Colin Plumb hash. It is simpler and should better resist
5304 (hsh_hash_string) Ditto.
5306 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
5308 * get.c: (export_write_case_func) Remove debug printing code.
5310 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
5312 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
5314 (save_write_case_func) Use &trns->h instead of cast.
5315 (cmd_export) Use &t->h instead of cast.
5317 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
5319 Moved vectors into the dictionary.
5321 * var.h: (struct vector) Moved here from vector.h. `index' member
5322 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
5325 * vector.h: Removed.
5327 * vector.c: (global var vec) Removed.
5328 (global var nvec) Removed.
5329 (cmd_vector) Rewritten.
5330 (find_vector) Removed.
5332 * dictionary.c: (dict_create_vector) New function.
5333 (dict_get_vector) New function, replaces reading global vec[]
5335 (dict_get_vector_cnt) New function, replaces reading global nvec
5337 (dict_lookup_vector) New function, replaces find_vector().
5338 (dict_clear_vectors) New function.
5340 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
5342 Start to move away from `struct variable' p `union' member to void
5345 * var.h: (struct variable) Add `aux' member.
5347 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
5349 Get rid of struct variable `foo' member.
5351 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
5353 (frq_custom_variables) Ditto.
5354 (frq_custom_grouped) Ditto.
5356 * get.c: (struct save_trns) Change `var' member from `int *' to
5357 `struct variable **'.
5358 (cmd_save_internal) Use aux instead of foo.
5359 (save_trns_proc) Use revised `var' member.
5360 (static var mtf_seq_no) Renamed mtf_seq_num.
5361 (static var mtf_seq_nums) New static var.
5362 (cmd_match_files) Initialize mtf_seq_nums.
5363 (mtf_free) Free mtf_seq_nums.
5364 (mtf_processing) Use mtf_seq_nums instead of foo.
5365 (mtf_merge_dictionary) No need to initialize mv->foo.
5366 (cmd_export) Use aux instead of foo. Use revised `var' member.
5367 (mns_custom_tables) Don't use foo to check for duplicates, that's
5368 what PV_NO_DUPLICATE is for.
5370 * var.h: (struct variable) Remove `foo' member.
5371 (struct frequencies_proc) New member.
5373 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
5375 Clean up COMPUTE and IF.
5377 * compute.c: More or less rewrite the darn thing.
5378 (struct compute_trns) Rename and reorder and add and delete
5380 (cmd_compute) Rewrite.
5381 (compute_num) Make conditional on test expression. Now used for
5382 both COMPUTE and IF.
5383 (compute_num_vec) Ditto.
5384 (compute_str) Ditto.
5385 (compute_str_vec) Ditto.
5388 (if_num_vec) Removed.
5390 (if_str_vec) Removed.
5391 (parse_target_expression) Renamed parse_rvalue_expression(),
5393 (new_trns) Renamed compute_trns_create(), rewritten.
5394 (delete_trns) Removed.
5395 (free_trns) Renamed compute_trns_free(), rewritten.
5396 (struct lvalue) New structure.
5397 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
5398 (lvalue_get_type) New function.
5399 (lvalue_is_vector) New function.
5400 (lvalue_finalize) New function.
5401 (lvalue_destroy) New function.
5403 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
5405 * command.def: Disallow MODIFY VARS in input mode, so that
5406 variables can't get dropped and confuse cmd_end_input_program()'s
5407 attempt to fill inp_init[].
5409 * modify-vars.c: (static var forward_positional_ordering) New
5411 (struct var_modification) Entirely changed.
5412 (rearrange_dict) Interface changed, rewritten.
5413 (cmd_modify_vars) Deal with modified struct var_modification, much
5415 (struct var_renaming) New structure.
5416 (compare_var_renaming_by_new_name) New function.
5417 (validate_var_modification) New function.
5419 * var.h: (struct modify_vars_proc) Removed.
5420 (struct variable) Removed member p.mfv.
5422 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
5424 Make EVALUATE a valid command whether we're debugging or not, so
5425 that `make check' can succeed regardless of whether debugging is
5428 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
5430 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
5432 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
5434 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
5435 statement by a simple if test.
5437 * dfm.c: (dfm_get_record) Add assertion.
5439 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
5441 For each file x.c, move #include "x.h" to the very top of the
5442 include list, to catch x.h failing to include the proper headers.
5444 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
5446 * algorithm.c: (find) New function.
5447 (remove_equal) New function.
5448 (set_difference) New function.
5449 (adjacent_find_equal) New function.
5450 [TEST_UNIQUE] Removed test case.
5451 (copy_if) Find end test.
5453 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
5455 * dictionary.c: (dict_get_case_weight) New convenience function.
5457 * aggregate.c: (accumulate_aggregate_info) Use
5458 dict_get_case_weight().
5460 * frequencies.q: (calc_general) Ditto.
5461 (calc_integer) Ditto.
5464 * t-test.q: (groups_calc) Ditto.
5467 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
5469 * glob.c: (global var default_dict) Change from `struct
5470 dictionary' to `struct dictionary *'. All references changed.
5471 (init_glob) Initialize default_dict with dict_create().
5473 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
5475 struct dictionary now made opaque. All related functions:
5477 * get.c: (rename_variables) Removed.
5478 (dict_delete_run) Removed.
5480 * temporary.c: (copy_variable) Removed.
5481 (new_dictionary) Removed.
5482 (save_dictionary) Removed.
5483 (restore_dictionary) Removed.
5484 (free_dictionary) Removed.
5486 * vars-atr.c: (clear_default_dict) Removed.
5487 (find_variable) Removed.
5488 (find_dict_variable) Removed.
5489 (create_variable) Removed.
5490 (delete_variable) Removed.
5491 (common_init_stuff) Removed.
5492 (init_variable) Removed. Updating of inp_init moved into
5493 cmd_end_input_program().
5494 (replace_variable) Removed.
5495 (rename_variable) Removed.
5496 (clear_variable) Removed.
5497 (dup_variable) Removed.
5499 * vars-prs.c: (is_varname) Removed.
5500 (is_dict_varname) Removed.
5501 (fill_all_vars) Removed.
5503 * vector.c: (find_vector) Removed.
5505 * weight.c: (stop_weighting) Removed.
5507 * dictionary.c: New file.
5508 (dict_create) New, replaces new_dictionary().
5509 (dict_clone) New, replaces save_dictionary() and
5510 restore_dictionary().
5511 (dict_clear) New, replaces clear_default_dict().
5512 (dict_destroy) New, replaces free_dictionary().
5513 (dict_get_var_cnt) New function, replaces references to
5515 (dict_get_var) New function, replaces references to dict->var[i].
5516 (dict_get_vars) New function, replaces fill_all_vars().
5517 (dict_create_var) New, replaces create_variable(). Interface
5518 drops `type' parameter, using a zero `width' to designate numeric.
5519 (dict_clone_var) New, replaces dup_variable().
5520 (dict_rename_var) New, replaces rename_variable().
5521 (dict_lookup_var) New, replaces find_variable(),
5522 find_dict_variable(), is_varname().
5523 (dict_contains_var) New function.
5524 (compare_variable_dblptrs) New function.
5525 (dict_delete_var) New function, replaces clear_variable().
5526 (dict_delete_vars) New function, replaces dict_delete_run().
5527 (dict_reorder_vars) New function.
5528 (dict_rename_vars) New function, replaces rename_variables().
5529 (dict_get_weight) New function, replaces reading dict->weight_var.
5530 (dict_set_weight) New function, replaces writing dict->weight_var
5531 or calling stop_weight(dict).
5532 (dict_get_filter) New function, replaces reading dict->filter_var.
5533 (dict_set_filter) New function, replaces writing dict->filter_var.
5534 (dict_get_case_limit) New function, replaces reading dict->N.
5535 (dict_set_case_limit) New function, replaces writing dict->N.
5536 (dict_get_value_cnt) New function, replaces reading dict->nval.
5537 (dict_compact_values) New function, replaces a loop that was
5538 replicated in several places.
5539 (dict_get_split_vars) New function, replaces reading dict->splits.
5540 (dict_get_split_cnt) New function, replaces reading
5542 (dict_set_split_vars) New function, replaces writing dict->splits.
5543 (dict_get_label) New function, replaces reading dict->label.
5544 (dict_set_label) New function, replaces writing dict->label.
5545 (dict_get_documents) New function, replaces reading
5547 (dict_set_documents) New function, replaces writing
5550 All references to above functions updated.
5552 * aggregate.c: (cmd_aggregate) Copy file label and documents from
5553 old dictionary to new by hand, because dict_create() can't do it
5554 itself. Use dict_set_documents(), dict_set_split_vars().
5556 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
5557 calling dict_destroy().
5559 * data-list.c: (dls_var_spec) Remove `type' member, replace by
5561 (fixed_parse_compatible) Some slightly nontrivial changes for
5563 (dump_fmt_list) Ditto.
5566 * file-type.c: (create_col_var) Ditto.
5568 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
5569 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
5570 (rename_variables) Use dict_rename_vars().
5571 (mtf_merge_dictionary) Use dict_get_documents(),
5572 dict_set_documents(), dict_compact_values().
5574 * pfm-read.c: (read_variables) Deal with changes to weighting.
5576 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
5577 is_varname() in output code.
5579 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
5580 other dictionary functions.
5582 * title.c: (add_document_line) Use dict_get_documents(),
5583 dict_set_documents().
5585 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
5586 reset default_handle by hand. dict_clear() will clear vectors so
5587 there's no need for that by hand.
5589 * vfm.c: (close_active_file) Move call to finish_compaction()
5590 earlier, so that we can do the compaction as a single step using
5591 dict_compact_values(). Use dict_clear_vectors().
5592 (finish_compaction) Use dict_delete_var(), dict_compact_values().
5594 Some functions don't have replacements:
5596 * vars-atr.c: (force_create_variable) Removed. All references
5597 updated to dict_create_var() followed by an assertion.
5598 (force_dup_variable) Removed. All references updated to
5599 dict_clone_var() followed by an assertion.
5601 * weight.c: (update_weighting) Removed. No longer necessary, so
5602 all references removed.
5604 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
5608 * aggregate.c: Eliminate separation of weighted and unweighted
5609 case. It made the code too obscure and I doubt it was actually
5610 faster. Instead, all code uses the "weighted" code, because
5611 that's a generalization of the "unweighted" code.
5614 (parse_aggregate_functions) No need to set FWEIGHT.
5615 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
5616 (dump_aggregate_info) Ditto.
5617 (initialize_aggregate_info) No need for special plain_function
5618 that gets rid of FWEIGHT option.
5620 * aggregate.c: Get rid of approximations.
5621 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
5623 (aggregate_single_case) Don't use approx_ne().
5625 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
5627 * ascii.c (ascii_line_width): Dead code, removed.
5629 * postscript.c (ps_line_width): Ditto.
5631 * q2c.c (xrealloc): Ditto.
5633 * count.c (internal_cmd_count): Ditto.
5635 * means.q (validate_dependent_endpoint): Ditto.
5637 * set.q: (cmd_gset) Ditto.
5639 * weight.c: [0] (weight_trns_proc) Ditto.
5641 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
5643 Make the code -Wmissing-prototypes clean.
5645 * Makefile.am (version.c): Add #include "version.h".
5647 * ascii.c: (ascii_open_global) Make static.
5648 (ascii_close_page) Ditto.
5649 (ascii_font_sizes) Ditto.
5650 (ascii_postopen_driver) Ditto.
5651 (ascii_close_driver) Ditto.
5652 (ascii_option) Ditto.
5653 (ascii_open_page) Ditto.
5654 (ascii_line_horz) Ditto.
5655 (ascii_line_vert) Ditto.
5656 (ascii_line_intersection) Ditto.
5658 (ascii_polyline_begin) Ditto.
5659 (ascii_polyline_point) Ditto.
5660 (ascii_polyline_end) Ditto.
5661 (ascii_text_set_font_by_name) Ditto.
5662 (ascii_text_set_font_by_position) Ditto.
5663 (ascii_text_set_font_by_family) Ditto.
5664 (ascii_text_get_font_name) Ditto.
5665 (ascii_text_get_font_family) Ditto.
5666 (ascii_text_set_size) Ditto.
5667 (ascii_text_get_size) Ditto.
5668 (ascii_text_metrics) Ditto.
5669 (ascii_text_draw) Ditto.
5670 (ascii_close_page) Ditto.
5672 * cmdline.h: New header for parse_command_line(). Used where
5675 * command.c: Move prototypes for cmd_*() functions to command.h.
5677 * command.h: Prototypes for cmd_*() functions moved here from
5680 * crosstabs.q: (gamma_int) Ditto.
5682 * file-handle.h: Add fh_init_files() prototype.
5684 * getline.c: (welcome) Ditto.
5686 * glob.h: New header for init_glob(). Used where appropriate.
5688 * hash.c: (comparison_helper) Ditto.
5690 * html.c: (html_open_global) Ditto.
5691 (html_close_global) Ditto.
5692 (html_preopen_driver) Ditto.
5693 (html_postopen_driver) Ditto.
5694 (html_close_driver) Ditto.
5695 (html_option) Ditto.
5696 (html_open_page) Ditto.
5697 (html_close_page) Ditto.
5698 (html_submit) Ditto.
5700 * inpt-pgm.c: (input_program_source_read) Ditto.
5702 * output.c: (find_defn_value) Ditto.
5703 (destroy_list) Ditto.
5705 * pfm-read.c: (read_int) Ditto.
5707 * postscript.c: (ps_open_global) Ditto.
5708 (ps_close_global) Ditto.
5709 (ps_font_sizes) Ditto.
5710 (ps_preopen_driver) Ditto.
5711 (ps_postopen_driver) Ditto.
5712 (ps_close_driver) Ditto.
5714 (ps_open_page) Ditto.
5715 (ps_close_page) Ditto.
5716 (ps_line_horz) Ditto.
5717 (ps_line_vert) Ditto.
5718 (ps_line_intersection) Ditto.
5720 (ps_polyline_begin) Ditto.
5721 (ps_polyline_point) Ditto.
5722 (ps_polyline_end) Ditto.
5723 (ps_text_set_font_by_name) Ditto.
5724 (ps_text_set_font_by_position) Ditto.
5725 (ps_text_set_font_family) Ditto.
5726 (ps_text_get_font_name) Ditto.
5727 (ps_text_get_font_family) Ditto.
5728 (ps_text_set_size) Ditto.
5729 (ps_text_get_size) Ditto.
5730 (ps_text_metrics) Ditto.
5731 (ps_text_draw) Ditto.
5733 * q2c.c: (finish_up) Ditto.
5742 (find_symbol) Ditto.
5745 (force_string) Ditto.
5747 (match_token) Ditto.
5750 (parse_setting) Ditto.
5751 (parse_specifier) Ditto.
5752 (parse_specifiers) Ditto.
5753 (parse_subcommand) Ditto.
5754 (dump_specifier_vars) Ditto.
5756 (make_identifier) Ditto.
5757 (dump_declarations) Ditto.
5758 (dump_specifier_init) Ditto.
5759 (dump_vars_init) Ditto.
5761 (dump_specifier_parse) Ditto.
5762 (dump_subcommand) Ditto.
5763 (dump_parser) Ditto.
5764 (dump_header) Ditto.
5766 (recognize_directive) Ditto.
5768 * recode.c: (string_to_long) Ditto.
5770 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
5772 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
5775 * sort.c: (sort_stream_read) Ditto.
5776 (sort_stream_mode) Ditto.
5778 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
5780 * algorithm.c (binary_search): Fix comparison.
5782 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
5784 * algorithm.c: (binary_search) Fix assertion.
5786 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
5788 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
5790 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
5792 * sort.c: (compare_case_lists) Rewrite.
5794 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
5796 * quicksort.c: Removed (not used).
5798 * quicksort.h: Removed (not used).
5800 * sort.c: Removed blp_quicksort() prototype.
5802 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
5804 * postscript.c: (int_2_compare) Rewrite.
5805 (compare_line) Rewrite.
5807 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
5809 * matrix-data.c (compare_factors) Use lexicographical_compare()
5811 (compare_doubles) New function.
5813 * algorithm.c: (lexicographical_compare) New algorithm.
5815 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
5817 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
5819 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
5821 * expr-prs.c: (cmp_func) Removed.
5822 (parse_function) Use binary_search() algorithm.
5823 (compare_functions) New function.
5824 (init_func_tab) Use sort() algorithm.
5826 * algorithm.c: (binary_search) New algorithm.
5828 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
5830 * descript.q: (display) Use sort() algorithm instead of qsort().
5831 (compare_func) Removed.
5832 (descriptives_compare_variables) New function.
5834 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
5836 Get rid of AVL trees. Hashes are more appropriate for everything
5839 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5845 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5847 Much code can be clarified by using C++ STL-like algorithms. Not
5848 all uses of these algorithms are listed below, only the ones where
5849 the change to an algorithm was the only change of interest.
5851 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5853 * algorithm.c: New file.
5855 * algorithm.h: New file.
5857 * modify-vars.c: (static var forward) Removed.
5858 (static var positional) Removed.
5859 (compare_variables) Removed.
5860 (struct ordering) New.
5861 (cmd_modify_vars) Use sort() algorithm.
5862 (compare_variables_given_ordering) New function.
5863 (rearrange_dict) Use sort() algorithm.
5865 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5866 (cmp_var_by_name) Removed.
5868 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5870 Make file handles use a hash table.
5872 * file-handle.q: (files) Change to hash table, make static.
5873 (cmd_file_handle) Use hash table functions.
5874 (fh_get_handle_by_filename) Ditto.
5875 (fh_get_handle_by_name) Ditto.
5876 (hash_file_handle) New function.
5877 (cmp_file_handle) Rewrite.
5878 (fh_init_files) Use hash table functions.
5880 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5882 Clean up FREQUENCIES.
5884 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5886 * frequencies.q: Remove a lot of old #if'd out code at the end.
5887 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5888 or calc_weight(). Initialize percentile_values.
5889 (calc) New function based on calc_weight() from frequencies.g.
5890 (precalc) Use hash functions.
5891 (static var comparison_func) Removed.
5892 (static var comparison_param) Removed.
5893 (comparison_helper) Removed.
5894 (get_freq_comparator) New function.
5895 (not_missing) New function.
5897 (postprocess_freq_tab) Use hash table functions, algorithms,
5898 get_freq_comparator(). Rewrite.
5899 (cleanup_freq_tab) Rephrase.
5900 (add_percentile) Clean up spacing.
5901 (hash_value_numeric) New function.
5902 (hash_value_alpha) New function.
5903 (compare_value_numeric_a) Rewrite.
5904 (compare_value_alpha_a) Rewrite.
5905 (compare_value_numeric_d) Rewrite.
5906 (compare_value_alpha_d) Rewrite.
5907 (compare_freq_numeric_a) Rewrite.
5908 (compare_freq_alpha_a) Rewrite.
5909 (compare_freq_numeric_d) Rewrite.
5910 (compare_freq_alpha_d) Rewrite.
5911 (calc_stats) Clean up mode, percentiles, max.
5912 (dump_statistics) Clean up spacing.
5914 * frequencies.g: Removed.
5916 * var.h: (struct freq_tab) Change `data' to hash table.
5918 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5920 * file-handle.h: Remove declaration of global variable `files',
5921 which wasn't used anywhere.
5923 * postscript.c: (add_encoding) Remove superfluous cast.
5926 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5929 * temporary.c: [0] (display_tree) Removed.
5931 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5933 Implement a new random number generator based on the alleged RC4
5936 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5939 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5940 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5942 (static var V[]) Removed.
5943 (static var Y) Removed.
5944 (static var X2) Removed.
5945 (setup_randomize) Removed.
5947 (rand_uniform) Removed.
5948 (rand_normal) Removed.
5949 (struct rng) New structure.
5950 (rng_create) New function.
5951 (rng_destroy) New function.
5952 (swap_byte) New static function.
5953 (rng_seed) New function.
5954 (rng_get_bytes) New function.
5955 (rng_get_int) New function.
5956 (rng_get_unsigned) New function.
5957 (rng_get_double) New function.
5958 (rng_get_double_normal) New function.
5959 (pspp_rng) New function.
5961 * random.h: Sync up to random.c.
5963 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5964 fraction of UINT_MAX, not 65536.
5965 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5968 * vfm.c: (open_active_file) No need to call setup_randomize() any
5971 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5973 Change dictionary name indexes to use hash tables instead of AVL
5976 * crosstabs.q: (free_var_dict) Use hash tables.
5977 (crs_custom_tables) Ditto.
5978 (calc_general) Ditto.
5979 (compare_table_entry) Rewrite.
5980 (enum_var_values) Reorder parameters. All references updated.
5983 * get.c: (rename_variable) Use hash tables.
5984 (mtf_merge_dictionary) Ditto.
5986 * glob.c: (init_glob) Use hash tables.
5987 (cmp_variable) Removed.
5989 * means.q: (mns_custom_tables) Use hash tables.
5991 * modify-vars.c: (rearrange_dict) Use hash tables.
5993 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5995 * sfm-read.c: (read_header) Use hash tables.
5996 (read_variables) Ditto.
5998 * temporary.c: (new_dictionary) Use hash tables.
5999 (save_dictionary) Ditto.
6000 (restore_dictionary) Ditto.
6002 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
6003 hash table `name_tab'.
6005 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
6006 [DEBUGGING] (dump_var_tree) Removed.
6007 (find_variable) Use hash tables.
6008 (find_dict_variable) Ditto.
6009 (common_init_stuff) Ditto.
6010 (rename_variable) Ditto.
6011 (clear_variable) Ditto. Also, remove debug code.
6012 (dup_variable) Use hash tables.
6014 * vars-prs.c: (fill_all_vars) Use hash tables.
6015 (is_dict_varname) Ditto.
6016 (parse_dict_variable) Ditto.
6018 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
6020 Change value labels to use hash tables instead of AVL trees, and
6021 change value labels into an ADT.
6023 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
6025 * value-labels.c: New file.
6027 * value-labels.h: New file.
6029 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
6030 Get rid of a stupid use of goto.
6032 * autorecode.c: (compare_alpha_value) Rewrite.
6033 (hash_alpha_value) Ditto.
6034 (compare_numeric_value) Rewrite.
6035 (hash_numeric_value) Ditto.
6037 * frequencies.q: (dump_full) Use value label ADT.
6039 * pfm-read.c: (read_value_label) Use value label ADT.
6041 * pfm-write.c: (write_value_labels) Use value label ADT.
6043 * sfm-read.c: (read_variables) Use value label ADT.
6044 (read_value_labels) Rewrite.
6046 * sfm-write.c: (write_value_labels) Rewrite.
6048 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
6049 (display_variables) Ditto.
6050 (describe_variable) Ditto.
6052 * t-test.q: (print_t_groups) Use value label ADT.
6054 * temporary.c: (copy_variable) Use value label ADT.
6055 (free_dictionary) Ditto.
6057 * val-labs.c: (verify_val_labs) Use value label ADT.
6059 (debug_print) Ditto.
6060 (val_lab_cmp) Removed.
6061 (inc_ref_count) Removed.
6062 (copy_value_labels) Removed.
6064 * var.h: (struct value_label) Removed.
6065 (struct variable) Change AVL tree `val_lab' into hash table
6068 * vars-atr.c: (init_variable) Use value label ADT.
6069 (clear_variable) Ditto.
6070 (free_value_label) Removed.
6071 (free_val_lab) Removed.
6072 (get_val_lab) Removed.
6073 (compare_variables) New function.
6074 (hash_variable) New function.
6076 * vfm.c: (dump_splits) Use value label ADT.
6078 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
6080 Add to the hash table interface.
6082 * hash.c: (hsh_hash_bytes) Add assertion.
6083 (hsh_hash_string) Ditto.
6087 (hsh_create) Ditto. Also make minimum `size'.
6088 (hsh_destroy) Rephrase.
6089 (sort_nulls_last) Removed.
6090 (not_null) New function.
6092 (comparison_helper) Ditto.
6093 (hsh_sort) Rewritten.
6094 (hsh_data_copy) New function.
6095 (hsh_sort_copy) Ditto.
6097 (hsh_replace) Ditto.
6098 (hsh_hash_double) Ditto.
6099 (hsh_delete) Fix stupid bug.
6101 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
6102 * added a calculation of the mode to FREQUENCIES
6104 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
6106 * moved (un)defs of DEBUGGING to config.h
6108 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
6110 * groff-font.c: (add_kern) Fix indentation.
6111 (add_kern) Use & instead of % to take power-of-2 modulus.
6112 (font_get_kern_adjust) Likewise.
6114 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
6116 * autorecode.c: (recode) Replace stupid use of memcpy() by
6118 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
6119 (hash_numeric_value) Ditto.
6120 (autorecode_proc_func) pool_strdup() was wrong here because the
6121 source string was not null-terminated. Use new pool_strndup()
6124 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
6125 use of hsh_iterator_init().
6127 * data-in.c: (parse_N) Initialize i->v->f.
6129 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
6132 * groff-font.c: Use power-of-2 hash table sizes, not prime.
6133 (groff_read_font) Don't call hsh_next_prime(). Don't call
6135 (static var hash) Remove `size_p', `max_used' members.
6136 (font_char_name_to_index) Don't call hsh_next_prime(). Use
6137 hsh_hash_string() instead of hashpjw(), & instead of %.
6138 (default_font) Don't call hsh_next_prime().
6140 * pool.c: (pool_strndup) New function.
6141 (pool_strdup) Reimplement in terms of pool_strndup.
6143 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
6145 (hash_ps_encoding) Use hsh_hash_string().
6146 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
6147 (hash_filename2font) Use hsh_hash_string().
6149 * som.c: Add #include <stdlib.h>.
6151 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
6152 (by destroying its pool).
6154 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
6156 Miscellaneous hash table code cleanup:
6158 * hash.h: (struct hsh_table) Moved into hash.c.
6159 (hsh_count) Ditto, and transformed into function.
6160 (hsh_compare_func) New typedef, used for defining otherwise-long
6161 function types here and in hash.c
6162 (hsh_hash_func) Ditto.
6163 (hsh_free_func) Ditto.
6165 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
6166 `table' to `entries'. Removed `mp'. All references updated.
6167 (hsh_clear) Don't shrink entries array; if the hash was this big
6168 once, it probably will be again.
6169 (hsh_rehash) Made static.
6170 (force_hsh_insert) Renamed hsh_force_insert.
6171 (force_hsh_find) Renamed hsh_force_find.
6173 Made hash table sizes powers of 2, because that's fine with any
6174 reasonable hash function and because taking a power-of-2 modulus
6175 is faster than any other:
6177 (hsh_prime_tab) Removed;
6178 (hsh_next_prime) Ditto.
6179 (next_power_of_2) New function.
6180 (hsh_create) Use next_power_of_2.
6181 (hsh_rehash) Use & instead of %.
6183 Cleaned up hsh_sort:
6185 (internal_comparison_fn) Removed.
6186 (sort_nulls_last) New function.
6187 (hsh_sort) Removed second parameter, switched to using the new
6188 quicksort() function from quicksort.h to avoid using nasty need
6189 for static variables with qsort(). All references updated.
6191 Changed the hash functions offered, because there are better hash
6192 functions than the ones we had, and cleaned up the names to boot:
6194 * hash.c: (hashpjw_d) Removed.
6196 (hsh_hash_bytes) New function.
6197 (hsh_hash_string) New function.
6198 (hsh_hash_int) New function.
6200 Improved the hash table iteration interface:
6202 * hash.h: (hsh_iterator_init) Removed.
6203 (struct hsh_iterator) Removed `init' member, change `next' to
6206 * hash.c: (hsh_foreach) Removed. All references updated to use
6207 hsh_first/hsh_next instead.
6208 (hsh_first) New function. Notably, unlike hsh_foreach() it does
6209 not treat a null pointer as an empty hash table.
6210 (hsh_next) New function.
6212 Made deletion possible, though slow:
6214 * hash.c: (locate_matching_entry) New function.
6215 (hsh_find) Use locate_matching_entry().
6216 (hsh_delete) New function also using locate_matching_entry().
6217 (hsh_force_delete) New function.
6219 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
6221 * quicksort.c: New file implementing a sort routine with a
6222 interface better than qsort() because it passes a user-provided
6223 parameter to the sort routine.
6225 * Makefile.am: Add quicksort.c, quicksort.h.
6227 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
6229 * All source files: Get rid of nasty special cases for Checker,
6230 which is pretty obsolete now.
6232 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
6234 * Fixed a bug apparent when using the FREQUENCIES command with the
6235 html driver. The html driver was incorrectly trying to display
6238 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
6240 * Makefile.am: Reorganized. Put locale dir in version.c instead
6241 of passing it to each compile command. Only put local gmp libs in
6242 LD_ADD if not installed on system. Remove `boast' target.
6244 * All source files: struct and union typedefs eliminated.
6245 `sizeof type' replaced by `sizeof object' where practical. Moved
6246 `unused' qualifiers from start to end of declarations for gcc
6247 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
6248 assertions on pointers strictly compliant. Removed _ prefixes on
6249 some function parameter names.
6251 * alloc.c: New source file, containing these external linkage
6252 functions removed from common.c: xmalloc, xcalloc, xrealloc,
6259 * ascii.c: Migrated from arenas to pools.
6260 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
6261 c_string to len_string. All references changed.
6262 (ascii_option) Signature changed to comply to new output.c
6264 (count_fancy_chars) Removed.
6265 (delineate) Removed support for rich text.
6266 (ascii_text_metrics) Ditto.
6268 (output_shorts) Change `box', `off', `on' from c_string to
6269 len_string. Change `remaining' from int to size_t.
6270 (ascii_close_page) Make page numbering less haphazard.
6272 * autorecode.c: Migrate from arenas to pools.
6274 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
6276 * bitvector.h: New file containing these macros from misc.h:
6277 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
6279 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
6280 word[3]. ncmd removed.
6281 (var empty_string) Removed.
6282 (var cmd_table) Declaration updated.
6283 (var cmdtab) Removed.
6284 (cmp_command) Removed.
6285 (split_words) Rewritten to use strtok_r().
6286 (init_cmd_parser) Renamed cmd_init(). Rewritten.
6287 (find_command) Removed.
6288 (FILE_TYPE_okay) Rewritten.
6289 (cmd_parse) Rewritten. Semantics of the return value of command
6290 handlers has changed: they must now return one of the new CMD_*
6291 enumerals, rather than a magic value. This meant that all
6292 commands had to be modified, and they were.
6293 (figure_out_command) New function.
6295 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
6296 #defines for INIT, INPU, etc.
6298 * command.h: New CMD_* enum series.
6299 (cur_proc) Make const char *, not char *.
6300 (cmd_init) Prototype.
6303 * common.c: Removed.
6305 * common.h: Removed.
6307 * correlations.q: New file.
6309 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
6311 (custom_tables) Renamed crs_custom_tables().
6312 (custom_variables) Renamed crs_custom_variables().
6313 (calc_integer) Add in some `const' qualifiers.
6314 (table_value_missing) Change from a_string to len_string.
6315 (float_M_suffix) Change from a_string to len_string.
6317 * data-in.c: Rewritten. All references to
6318 parse_string_as_format() changed to data_in().
6320 * data-in.h: New file.
6322 * data-list.c: Change DLS_* from #define's to enums. Move from
6323 rpd_msg() to tmsg().
6324 (RPD_ERR) New #define.
6325 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
6327 (read_from_data_list_fixed) Change from old
6328 parse_string_as_format() to new data_in().
6329 (read_from_data_list_free) Ditto.
6330 (read_from_data_list_list) Ditto.
6331 (cmd_repeating_data) Modify approach to checking for end of
6334 (rpd_parse_record) Change from old parse_string_as_format() to new
6335 data_in(). Change from old convert_format_to_string() to new
6337 (read_one_set_of_repetitions) Change dfm_push_cust() to
6338 dfm_push(), pop_cust() to dfm_pop().
6340 * data-out.c: Rewritten. All references to
6341 convert_format_to_string() changed to data_out().
6343 * descript.q: Migrate to new q2c.
6344 (cmd_descriptives) Removed.
6345 (internal_cmd_descriptives) Renamed cmd_descriptives ().
6346 (custom_variables) Renamed dsc_custom_variables().
6348 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
6350 (open_file_r) Initialize h->where.line_number. Migrate to new
6352 (open_file_w) Initialize h->where.line_number.
6353 (read_record) Change from ext->ln to h->where.line_number.
6354 Migrate to struct string.
6355 (dfm_put_record) Rephrased.
6356 (dfm_push_cust) Renamed dfm_push(), rewritten.
6357 (dfm_pop) New function.
6359 * error.c: All references updated.
6360 (glob var error_count) Renamed err_err_count.
6361 (glob var warning_count) Renamed err_warning_count.
6362 (glob var error_already_flagged) Renamed err_already_flagged.
6363 (glob var verbosity) Renamed err_verbosity.
6364 (glob var cust_fn) Removed.
6365 (glob var cust_ln) Removed.
6366 (static var file_loc) New.
6367 (static var nfile_loc) New.
6368 (static var mfile_loc) New.
6369 (tmsg) New function.
6370 (push_cust) Removed.
6373 (static var terminating) Removed.
6374 (failure) Renamed err_failure().
6375 (hcf) Renamed err_hcf().
6376 (err_push_file_locator) New function.
6377 (err_pop_file_locator) New function.
6378 (err_location) New function.
6379 (check_error_count) Renamed err_check_count().
6380 (vmsg) Renamed err_vmsg(). Interface changed.
6381 (verbose_msg) Removed.
6382 (err_cond_fail) New function.
6383 (error_break) Renamed err_break().
6385 * error.h: All references updated.
6386 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
6387 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
6389 (struct file_locator) New.
6391 (macro verbose_msg) Removed.
6392 (macro cond_fail) Removed.
6394 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
6396 * expr-prs.c: Reorganized. All references updated.
6397 (exprtypename) Renamed expr_type_name().
6398 (typename) Renamed type_name().
6399 (free_expression) Renamed expr_free().
6400 (parse_expression) Renamed expr_parse(). Uses new type_check()
6402 (init_functab) Renamed init_func_tab().
6403 (type_check) New function.
6404 (parse_or) Rewritten to use new allocate_nonterminal() and
6405 append_nonterminal_arg() functions.
6408 (parse_rel) Ditto. Also simplified logic.
6413 (SYSMIS_func) Ditto.
6414 (VALUE_func) Rephrased.
6415 (CONCAT_func) Fix memory leak by replacing free by free_node on
6417 (generic_str_func) Ditto.
6418 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
6420 (allocate_nonterminal) New function.
6421 (append_nonterminal_arg) New function.
6422 (static func_tab[]) Now at file level.
6424 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
6426 * expr.h: (enum series OP_*) Moved to exprP.h.
6427 (OP_* defines) Ditto.
6428 (struct op_desc) Ditto.
6429 (global ops[]) Ditto.
6430 (struct num_con_node) Ditto.
6431 (struct str_con_node) Ditto.
6432 (struct var_node) Ditto.
6433 (struct lag_node) Ditto.
6434 (struct casenum_node) Ditto.
6435 (struct nonterm_node) Ditto.
6436 (union any_node) Members renamed.
6437 (struct sys_node) Removed.
6438 (struct val_node) Removed.
6439 (operator typedef) Removed.
6440 (typedef exprtype) Removed.
6441 (enum series EX_*) Moved to exprP.h.
6442 (struct expression) Ditto. Also renamed a lot of the members.
6443 (PXP_* defines) Changed to enums.
6444 (free_node prototype) Moved to exprP.h.
6446 * file-handle.h: (struct file_handle) New member `where'.
6448 * file-handle.q: Migrated to new q2c format.
6449 (prepend_current_directory) Removed (dead code).
6450 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
6451 (fh_get_handle_by_filename) Removed dead code.
6452 Set new `where' member.
6454 * file-type.c: (file_type_source_read) References to
6455 parse_string_as_format() changed to data_in().
6456 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
6458 * filename.c: All references updated.
6459 (init_filename) Renamed fn_init().
6460 (expand_line) Removed.
6461 (macro EXPAND_LINE) Removed.
6462 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
6463 of custom functions.
6464 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
6465 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
6466 (normalize_filename) Renamed fn_normalize().
6467 (search_path) Renamed fn_search_path(), rewritten.
6468 (prepend_dir) Renamed fn_prepend_dir().
6469 (blp_getenv) Renamed fn_getenv().
6470 (blp_dirname) Renamed fn_dirname().
6471 (fn_basename) New function, not used.
6472 (absolute_filename_p) Renamed fn_absolute_p().
6473 (is_special_filename) Renamed fn_special_p().
6474 (file_exists) Renamed fn_exists_p().
6475 (readlink_malloc) Renamed fn_readlink().
6476 (getenv_default) Renamed fn_getenv_default().
6477 (open_file) Renamed fn_open().
6478 (close_file) Renamed fn_close().
6479 (open_file_ext) Renamed fn_open_ext().
6480 (close_file_ext) Renamed fn_close_ext().
6482 * font.h: Migrate from arenas to pools.
6484 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
6486 * frequencies.g: Migrate from arenas to pools.
6488 * frequencies.q: Migrate to new q2c version. Migrate from arenas
6491 * getline.c: All references updated.
6492 (global getl_buf) Changed from char * to struct string.
6493 (static getl_include_path) Ditto.
6494 (global getl_buf_len) Removed.
6495 (global getl_buf_size) Removed.
6496 (getl_include_path) Deal with new getl_buf, getl_include_path.
6497 (getl_uninitialize) New function.
6498 (getl_get_current_directory) Rewritten.
6499 (getl_clear_include_path) Rewritten.
6500 (getl_add_include_dir) Rewritten.
6501 (getl_add_file) Assertion fixed.
6502 (getl_add_virtual_file) Change initial value of `remaining_loops'
6504 (welcome) Rewritten.
6505 (handle_line_buffer) Make static. Change logic to make
6506 getl_add_virtual_file() change sensible. Use ds_*() strings.
6507 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
6508 (getl_close_file) Moved.
6509 (getl_location) New function.
6511 * getline.h: All references updated.
6512 (macro curln) Removed.
6513 (macro curfn) Removed.
6514 (macro am_interactive) Renamed getl_am_interactive.
6515 (macro am_reading_script) Renamed getl_reading_script.
6517 * glob.c: (global fmt_parse_ignore_error) Removed.
6518 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
6519 systems that support it (C99). Turn off SET ECHO by default. No
6520 necessary julcal initialization anymore.
6522 * groff-font.c: Migrate from arenas to pools.
6523 (groff_read_font) Use err_push_file_locator().
6524 (groff_read_DESC) Ditto.
6525 (font_msg) Use tmsg().
6527 * hash.c: (hsh_sort) Fix debug code.
6528 [GLOBAL_DEBUGGING] Include stdio.h.
6530 * hash.h: (macro force_hsh_insert) Rephrase.
6532 * heap.c: Rewritten.
6534 * heap.h: Rewritten.
6536 * html.c: (html_option) Change from outp_value to struct string.
6537 (postopen) Change from curfn to getl_location().
6538 (escape_string) Remove rich-text code. Signature changed.
6539 (output_tab_table) Switch from a_string to struct len_string.
6540 Remove rich text support.
6542 * lexer.c: All references updated. Largely rewritten. Major
6543 changes listed below. Removed tagged quote support. Adapted to
6544 struct string tokstr.
6545 (global tokstr) Changed to struct string.
6546 (global tokstr_size) Removed.
6547 (global tokstr_len) Removed.
6549 (global tokint) Removed.
6550 (global toklongstr) Removed.
6551 (C* defines) Removed.
6552 (static tbl[]) Removed.
6553 (static id[]) Removed.
6554 (static une[]) Removed.
6555 (discard_line) Renamed lex_discard_line().
6556 (get_entire_line) Renamed lex_entire_line().
6557 (get_rest_of_line) Renamed lex_rest_of_line().
6558 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
6559 (make_hexit) Removed.
6560 (syntax_error) Renamed lex_error(). Return value removed.
6561 (get_token_representation) Renamed lex_token_representation().
6562 (putback) Renamed lex_put_back().
6563 (putfwd) Renamed lex_put_forward().
6564 (convert_negative_to_dash) Renamed lex_negative_to_dash().
6565 (set_prog) Renamed lex_set_prog().
6566 (init_lex) Renamed lex_init().
6567 (reset_eof) Renamed lex_reset_eof().
6568 (lookahead) Renamed lex_look_ahead().
6569 (check_id) Rewritten.
6570 (yylex) Renamed lex_get(), rewritten.
6571 (lex_end_of_command) New function. Many commands were rephrased
6573 (lex_integer_p) New function. Replaces compare of tokint against
6575 (lex_integer) New function. Replaces tokint.
6576 (match_tok) Renamed lex_match().
6577 (match_id) Renamed lex_match_id().
6578 (match_int) Renamed lex_match_int().
6579 (force_match_id) Renamed lex_force_match_id(), added return value.
6580 (force_match) Renamed lex_force_match(), added return value.
6581 (force_string) Renamed lex_force_string(), added return value.
6582 (force_int) Renamed lex_force_int(), added return value.
6583 (lex_id_match_len) New function.
6584 (id_match) Renamed lex_id_match(), rewritten.
6585 (get_line) Renamed lex_get_line().
6586 (preprocess_line) Renamed lex_preprocess_line().
6587 (tokname) Renamed lex_token_name().
6588 (bin_value_func) Removed.
6589 (oct_value_func) Removed.
6590 (hex_value_func) Removed.
6591 (unexpected_eof) New function.
6592 (convert_numeric_string_to_char_string) New function.
6593 (parse_string) Rewritten, signature changed.
6594 (add_tokstr_char) Removed.
6595 (add_tokstr_unsigned) Removed.
6596 (add_tokstr_string) Removed.
6597 (parse_tagged_quote) Removed.
6598 (skip_comment) Renamed lex_skip_comment().
6600 * lexer.h: All references updated.
6601 (macro is_id1) Renamed CHAR_IS_ID1.
6602 (macro is_idn) Renamed CHAR_IS_IDN.
6603 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
6604 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
6605 (macro get_token) Removed.
6606 (macro id_match) Removed.
6607 (macro force_match_id) Removed.
6608 (macro force_match) Removed.
6609 (macro force_string) Removed.
6610 (macro force_int) Removed.
6611 (macro force_num) Removed.
6612 (macro force_id) Removed.
6614 * lexerP.h: Removed.
6616 * list.q: Migrated to new q2c format.
6617 (write_line) Deal with struct len_string.
6618 (write_varname) Ditto.
6619 (write_fallback_headers) Ditto.
6621 * magic.c: New file, incorporating the following global variables
6622 previously in other files: endian, second_lowest_value. And both
6623 of those are conditional on #define's.
6625 * magic.h: New file, incorporating the following global variable
6626 declarations: endian, second_lowest_value, and the following macro
6627 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
6629 * main.c: Added declarations of pgmname, finished, curdate,
6631 (main) Call new parse_script() function.
6632 (parse_script) New function.
6633 (execute_command) New function.
6634 (dump_token) Removed.
6635 (handle_error) New function.
6637 * matrix.c: New file.
6639 * matrix.h: New file.
6641 * matrix-data.c: Migrated from arenas to pools.
6642 (mget_token) Change from parse_string_as_format() to data_in().
6644 * means.q: Migrate to new q2c.
6645 (custom_tables) Renamed mns_custom_tables().
6646 (custom_crossbreak) Renamed mns_custom_crossbreak().
6647 (custom_variables) Renamed mns_custom_variables().
6649 * mis-val.c: (static var width) Changed from `int' to `size_t'.
6650 (parse_varnames) Prototype.
6651 (parse_numeric) Rephrasings.
6652 (parse_alpha) Adapt to new struct string tokstr.
6654 * misc.c: (intlog10) Rewritten.
6656 (ansi_rand) Renamed real_rand(), moved into random.c.
6657 (ansi_srand) Renamed real_srand(), moved into random.c.
6658 (setup_randomize) Moved to random.c.
6659 (rand_uniform) Ditto.
6660 (rand_normal) Ditto.
6661 (rand_simple) Ditto.
6662 (get_config_line) Removed.
6663 (reverse) Removed (dead code).
6665 * misc.h: (macro SET_BIT) Moved to bitvector.h.
6666 (macro CLEAR_BIT) Ditto.
6667 (macro TEST_BIT) Ditto.
6668 (macro SET_BIT_TO) Ditto.
6669 (macro BIT_INDEX) Ditto.
6671 * output.c: (outp_read_devices) Move to err_push_file_locator()
6672 from push_cust(). Use struct string.
6673 (expand_op_tokstr) Removed.
6674 (static var op_tokstr) Changed to struct string.
6675 (static var op_tokstr_size) Removed.
6676 (tokener) Rephrasings. Use struct string.
6677 (parse_options) Use struct string.
6678 (destroy_driver) Fix assertion.
6679 (outp_get_paper_size) Move to err_push_file_locator().
6680 [0] Removed dead code.
6681 (outp_string_width) Move to len_string.
6683 * output.h: Comment fixes.
6684 (TAG_* enum series) Removed.
6685 (struct outp_value) Removed.
6686 (enum OUTP_T_FANCY) Removed.
6687 (struct outp_text) `s' changed from a_string to len_string.
6688 (struct outp_class) `option' change arg 3 from outp_value to
6691 * pfm-read.c: (corrupt_msg) Rewritten.
6693 * pfm-write.c: (bufwrite) Fix assertion.
6695 * pool.c: New file, reference version.
6697 * pool.h: New file, reference version.
6699 * postscript.c: (ps_font_sizes) Fix assertion.
6700 (ps_option) Change arg 3 from outp_value to struct string.
6701 Adapt to struct string.
6702 (macro output_line) Removed.
6703 (macro add_string) Removed.
6704 (output_encodings) Adapted to struct string. Moved to
6705 err_push_file_locator().
6706 (find_encoding_file) Fix assertion.
6707 (read_ps_encodings) Move to err_push_file_locator().
6708 (postopen) Use getl_location() instead of curfn.
6709 (out_text_plain) Move to len_string.
6710 (text) Ditto. Remove rich text support.
6712 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
6713 (cmd_print_eject) Ditto.
6715 (internal_cmd_print) Now cleans up after itself. Uses
6716 fh_parse_file_handle() now.
6717 (cmd_print_space) Use PXP_NUMERIC to type-check.
6719 * q2c.c: Overhauled. Removed _("") i18n support. All references
6720 updated. All output functions updated to handle structures rather
6721 than local or static variables. Adapt to new PSPP lex_*()
6725 (macro MAX_N_SBC) Removed.
6726 (global bare) Removed.
6727 (enum STRING) Renamed T_STRING.
6728 (enum ID) Renamed T_ID.
6729 (get_buffer) Buffer size increased.
6730 (strlower) Renamed st_lower(), rephrased.
6731 (strupper) Renamed st_upper(), rephrased.
6732 (skip_ws) New function.
6733 (get_line) Don't special-case any types of lines (like those
6734 beginning with ! or $, for instance).
6735 (get_token) Renamed lex_get(). Rephrased.
6736 (static var `prefix') New.
6737 (parse) New function.
6738 (parse_setting) Minor rephrasing.
6739 (dump_specifier_vars) Ditto.
6740 (make_identifier) Put null terminator on identifier, duh.
6741 (dump_vars) Renamed dump_declarations(). Never indent. Never
6742 static. Output changed entirely.
6743 (dump_specifier_init) Rephrase.
6744 (dump_vars_init) No index variable needed. Other modifications.
6745 (dump_parser) Don't parse command name. Do dump functions instead
6746 of just code fragments.
6747 (dump_free) Dump function instead of code fragment.
6748 (recognize_directive) New function.
6749 (main) Use recognize_directive(). Don't rely on magic $ line
6750 beginning: instead, parse comments. Update list of headers.
6752 * random.c: New file, containing the following functions:
6753 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
6754 rand_normal, rand_simple.
6756 * random.h: New file.
6758 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
6759 function. `max_src_width', `max_dst_width' changed to size_t.
6760 (internal_cmd_recode) Removed.
6761 (parse_dest_spec) Merge similar cases.
6762 (parse_src_spec) Add assertion.
6764 * repeat.c: (recognize_keyword) New function.
6765 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
6766 REPEAT. Improve recognition of END REPEAT (use
6767 recognize_keyword()). Move from curfn to getl_location(). Use
6770 (perform_DO_REPEAT_substitutions) Adapt to struct string.
6772 * set.q: Adapt to new q2c.
6773 (cmd_set) Range-check some values better.
6774 (custom_blanks) Renamed stc_custom_blanks().
6775 (custom_length) Renamed stc_custom_length().
6776 (custom_results) Renamed stc_custom_results().
6777 (custom_seed) Renamed stc_custom_seed().
6778 (custom_width) Renamed stc_custom_width().
6779 (custom_format) Renamed stc_custom_format().
6780 (custom_journal) Renamed stc_custom_journal().
6781 (custom_color) Renamed stc_custom_color().
6782 (custom_listing) Renamed stc_custom_listing().
6783 (custom_disk) Renamed stc_custom_disk().
6784 (custom_log) Renamed stc_custom_log().
6785 (custom_rcolor) Renamed stc_custom_rcolor().
6786 (custom_viewlength) Renamed stc_custom_viewlength().
6787 (custom_workdev) Renamed stc_custom_workdev().
6789 * settings.h: Not necessary to include format.h any longer.
6791 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
6792 (corrupt_msg) Rewritten.
6794 * sort.c: Adapt to rewritten heap ADT.
6796 * str.c: (aa_strcpy) Removed.
6797 (ab_strcpy) Removed.
6798 (ac_strcpy) Removed.
6799 (ba_strcpy) Removed.
6800 (bb_strcpy) Removed.
6801 (ca_strcpy) Removed.
6802 (aa_strdup) Removed.
6803 (aa_strdupcpy) Removed.
6804 (ba_strdup) Removed.
6805 (sa_strdup) Removed.
6806 (memrev) Renamed mm_reverse().
6807 (memrmem) Renamed mm_find_reverse().
6808 (cmp_str) Renamed st_compare_pad().
6809 (strmaxcpy) Removed.
6810 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
6811 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
6813 (strpadcpy) Renamed st_pad_copy(), signature changed.
6814 (blpstrset) Removed.
6815 (ds_create) New function.
6816 (ds_init) New function.
6817 (ds_replace) New function.
6818 (ds_destroy) New function.
6819 (ds_clear) New function.
6820 (ds_extend) New function.
6821 (ds_shrink) New function.
6822 (ds_truncate) New function.
6823 (ds_length) New function.
6824 (ds_size) New function.
6825 (ds_value) New function.
6826 (ds_end) New function.
6827 (ds_concat) New function.
6828 (ds_concat_buffer) New function.
6829 (ds_printf) New function.
6830 (ds_putchar) New function.
6831 (ds_getline) New function.
6832 (ds_get_config_line) New function derived from the old
6833 misc.c:get_config_line().
6834 (ls_create) New function.
6835 (ls_create_buffer) New function.
6836 (ls_init) New function.
6837 (ls_shallow_copy) New function.
6838 (ls_destroy) New function.
6839 (ls_null) New function.
6840 (ls_null_p) New function.
6841 (ls_empty_p) New function.
6842 (ls_length) New function.
6843 (ls_value) New function.
6844 (ls_end) New function.
6846 * str.h: Reformatted.
6847 (struct a_string) Removed.
6848 (struct b_string) Removed.
6849 (struct c_string) Removed.
6850 (struct len_string) New.
6851 (struct string) New.
6852 (macro as_streq) Removed.
6853 (macro bs_streq) Removed.
6854 (macro cs_streq) Removed.
6855 (macro sa_streq) Removed.
6856 (macro sb_streq) Removed.
6857 [__GNUC__] (inline function ds_putchar) New function.
6858 [__GNUC__] (inline function ds_length) New function.
6859 [__GNUC__] (inline function ds_value) New function.
6860 [__GNUC__] (inline function ds_end) New function.
6862 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6863 (display_vectors) Fix missing i18n.
6865 * t-test.q: Migrate to new q2c.
6867 * tab.c: Migrate from arenas to pools.
6868 (tab_create) Use struct len_string.
6869 (tab_realloc) Ditto.
6870 (text_format) Ditto.
6871 (tab_joint_text) Ditto.
6872 (tab_natural_width) Remove rich text support.
6873 (tab_natural_height) Ditto.
6874 (tab_output_text) Handle TAT_FIX.
6875 (tab_raw) Change arg from a_string to len_string.
6876 (tabi_driver) Fix assertion. Use struct len_string.
6877 (render_strip) Use struct len_string. Remove rich text support.
6878 Add `const' qualifiers.
6880 * tab.h: (enum TAB_RICH) Remove.
6881 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6882 SOM_COL_* updated to read TAB_COL_*.
6883 (struct tab_table) Change arena to pool. Change a_string to
6886 * temporary.c: (restore_dictionary) Rewrite Checker code.
6888 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6889 LOWEST, HIGHEST) Moved here from common.h.
6890 (typedef any_trns) Removed. All references changed to `struct
6893 * vars-atr.c: (force_create_variable) Fix assertion.
6894 (force_dup_variable) Fix assertion.
6896 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6898 Using alphanumeric variables in functions under AGGREGATE
6899 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6900 <BZN-mdksh@t-online.de> for reporting this bug.
6902 * aggregate.c: (parse_aggregate_functions) When setting the
6903 FSTRING bit, also allocate memory for the `string' member of
6905 (free_aggregate_functions) Free iter->string. Don't use the
6906 non-function bits when indexing the array of functions.
6907 [DEBUGGING] (debug_print) Don't use the non-function bits when
6908 indexing the array of functions.
6910 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6912 Under certain circumstances, the final case would be omitted from
6913 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6914 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6916 * aggregate.c (agr_00x_end_func): Increment number of cases in
6917 sink before writing case. For streams that keep track of how many
6918 cases there are based on this value, this means that the last case
6919 will be read in on the next stream read.
6921 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6923 Undefined behavior was invoked by referencing a freed pointer.
6925 * vfm.c (memory_stream_write): Free pointer *after* checking for
6928 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6930 A wrong record size was displayed when paging the active file to
6933 * vfm.c: (memory_stream_write) Fix off-by-one error.
6935 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6937 Not having enough temporary space for sorting caused a core dump.
6940 * sort.c: (allocate_cases) Initialize i.
6942 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6944 Syntax errors in function descriptions on AGGREGATE caused core
6947 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6948 free_aggregate_functions(), since that function already frees
6951 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6953 A null pointer was dereferenced, causing a core dump, when
6954 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6955 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6956 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6958 * arena.c: (arena_malloc) If the arena hasn't been initialized
6959 already, initialize it.
6961 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6963 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6964 for compilation with Cygnus Windows B20. Not used by other
6967 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6969 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6970 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6972 * sort.c: (compare_case_lists) Reverse sense of comparison if
6973 sorting in descending order.
6974 (compare_record) Ditto.
6976 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6978 SPLIT FILE with a string variable caused a core dump. Fixed.
6980 * vfm.c: If the variable is a string then make a temporary value
6981 struct pointing to it. The underlying problem is a lot bigger
6982 than this (see TODO) but this is a stopgap for the simple case at
6985 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6987 Nested INCLUDEs didn't work. Fixed.
6989 * getline.c: (getl_include) Set first_line to NULL in allocated
6992 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6994 The MATCH FILES procedure set the values of variables not present
6995 to 0. It should have been SYSMIS. This is now fixed.
6997 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6999 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
7001 The REMARK command was too aggressive about skipping lines. It
7002 didn't like being the last command in a file.
7004 * command.c: (cmd_remark) Call get_entire_line() instead of
7007 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
7009 Comment parsing wasn't consistent with the rest of the code in its
7010 idea of where one command ends and another starts. This meant
7011 that sometimes commands would be mysteriously ignored. Thanks to
7012 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7014 * command.c: (parse_cmd) Hand off comment parsing to new function
7015 skip_comment() in lexer.c.
7016 * lexer.c: (skip_comment) New function.
7018 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
7020 The TABLE subcommand on MATCH FILES worked only erratically at
7021 best. This fixes it. Thanks to Dr. Dirk Melcher
7022 <BZN-mdksh@t-online.de> for reporting this bug.
7024 * get.c: (mtf_compare_BY_values) When comparing string values, a
7025 difference of 1 is still a difference :-)
7026 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
7027 advance TABLE files automatically when matched. Comment fixes.
7029 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
7031 VARIABLE LABELS rejected a slash before the first variable
7032 specification, contradicting the documentation. Thanks to Walter
7033 M. Gray <graywm@northernc.on.ca> for reporting this bug.
7035 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
7036 command specification.
7038 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
7040 Because of an incorrect optimization in memory allocation,
7041 CROSSTABS sometimes segfaulted when asked to output multiple
7042 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7045 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
7046 are passed to output_pivot_table() for its use.
7047 (output_pivot_table) Instead of assuming the number of columns is
7048 constant, keep track with maxcols. In general mode, use maxcells
7049 to determine whether more matrix cells need to be allocated.
7051 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
7053 CROSSTABS didn't display value labels for column and row
7054 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7057 * crosstabs.q: (table_value_missing) If the specified value has a
7058 value label for this variable, then show it instead of the raw
7060 (display_dimensions) Delegate display of value_labels to
7061 table_value_missing.
7063 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
7065 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
7066 <BZN-mdksh@t-online.de> for reporting this bug.
7068 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
7069 if the file isn't declared as binary.
7071 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
7073 MATCH FILES corrupted memory and dumped core on some syntax
7076 * get.c: (cmd_match_files) Set file->handle to NULL before
7078 (mtf_free_file) Don't free a null dictionary.
7080 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
7082 MATCH FILES should set numeric values not available to the
7083 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
7084 <BZN-mdksh@t-online.de> for reporting this bug.
7086 * get.c: (mtf_processing) Set unused records to system-missing,
7089 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
7091 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
7092 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
7094 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
7095 in newly created dictionary, and add each copied variable to the
7098 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
7102 * get.c: (trim_dictionary) Free variable list for KEEP after
7105 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
7107 Some systems didn't like the way open_file was coded. Thanks to
7108 Hankin <hankin@rogue.consultco.com> for pointing this out.
7110 * filename.c: (open_file) Don't try to store stdin, stdout,
7111 stderr as part of an array, because that doesn't always work.
7113 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
7115 The SAVE procedure didn't save long string variables properly.
7116 Fixed by this patch. Thanks to Hankin
7117 <hankin@rogue.consultco.com> for this patch.
7119 * sfm-write.c: (write_variable) Fix off-by-one error in writing
7120 out variable pad records.
7122 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
7124 Previously, if PRINT SPACE were given a negative argument, it
7125 would report an error, then spin in an (almost) infinite loop.
7126 This fixes that behavior.
7128 * print.c: (print_space_trns_proc) After reporting a negative
7129 argument, set number of lines to print to 1.
7131 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
7133 SPSS 8.0 outputs some new record types in its system files, and it
7134 allows longer value labels. Accept these system files.
7136 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
7137 11 emitted by SPSS 8.0.
7139 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
7141 The LIST procedure was too conservative in allocating space for
7142 buffers, which caused a bug that only showed up with very long
7143 output variables. Thanks to Hankin <hankin@dunno.com> for this
7146 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
7148 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
7150 Typo meant string format specifiers weren't checked properly. I
7151 think that Hankin <hankin@dunno.com> sent me this report, but I'm
7152 willing to be corrected on this point.
7154 * format.c: (check_string_specifier) Fix obvious typo.
7156 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
7158 Using $CASENUM in an expression didn't work. Here's a fix.
7159 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
7162 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
7164 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
7166 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
7168 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
7169 other behavior, *sigh*. This patch hopefully fixes that. This
7170 time I've actually tested it.
7172 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
7174 * data-list.c: (read_from_data_list_free,
7175 read_from_data_list_list) Call parse_string_as_format() directly
7176 without mucking around with the field width.
7178 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
7180 Occasionally, you may encounter a script that wants to be
7181 interpreted in interactive mode. Make -i emulate this behavior to
7182 allow such scripts to be executed with PSPP.
7184 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
7186 * cmdline.c: (pre_syntax_message[]) Update -i description.
7188 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
7189 when -i is given on the command line) don't treat unindented lines
7190 as starting a new command.
7192 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
7194 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
7195 mostly caused by local initialized aggregates. After egcs is
7196 fixed upstream these can be removed, but for now they're not a big
7199 * ascii.c: (ascii_postopen_driver) Checker chokes on local
7200 initialized arrays. Avoid this.
7202 * sfm-write.c: (sfm_write_dictionary) Don't use a local
7205 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
7207 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
7208 following changes avoid. Currently I compile sources with egcs
7209 1.1.1 and gcc 2.7.2.3 before sending them out.
7211 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
7213 * ascii.c: (option_tab[]) Initialize all struct members.
7215 * avl.h: (avl_traverser_init) New macro.
7217 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
7220 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
7223 * hash.c: Comment fix.
7225 * hash.h: (hsh_iterator_init) New macro.
7227 * html.c: (option_tab[]) Initialize all struct members.
7229 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
7232 * postscript.c: (option_tab[]) Initialize all struct members.
7233 (output_encodings, preclose, dump_lines) Use new
7234 hsh_iterator_init() macro.
7236 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
7239 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
7242 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
7244 * data-in.c: Examined each of the parsing functions to make sure
7245 that they wouldn't dump core if they were passed a string of the
7246 wrong length, since now the DATA LIST FREE/LIST routines don't
7247 check for field width before passing it to the data parser.
7248 (parse_RBHEX, parse_AHEX) Reject odd length input.
7249 (parse_string_as_format) Reject input that's too short or too
7252 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
7253 a field to its entire declared output width then pass it to the
7254 data-in parsing routines. This contradicted the documented
7255 behavior. This is fixed in these changes. Thanks to Mark H. Wood
7256 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
7257 free-format parsing that differed from SPSS.
7258 (cut_field) Commas and spaces are treated identically. Returns
7259 the proper column instead of a fixed 1 value.
7260 (parse_field) Removed.
7261 (read_from_data_list_free, read_from_data_list_list) Call
7262 parse_string_as_format directly instead of parse_field.
7264 * heap.c: (heap_delete) Stylistic fixes.
7266 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
7268 * loop.c: (loop_2_trns_proc) Formatting fix.
7270 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
7272 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
7274 * vfm.c: (macro FILTERED) New.
7275 (static var filter_var) New.
7276 (process_active_file_write_case) Use FILTERED.
7277 (setup_filter) Set filter_var.
7278 (close_active_file) Delete the filter if not
7279 FILTER_before_TEMPORARY.
7280 (procedure_write_case) Use FILTERED.
7282 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
7284 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
7286 * data-in.c: (parse_day_count) Message fix.
7287 (parse_month) Style fix.
7289 * data-list.c: (struct data_list_pgm) New member eof.
7290 (cmd_data_list) Init eof to 0.
7291 (do_reading) Implement the /END subcommand and read-past-eof
7294 * do-if.c: Include stdio.h when debugging.
7295 (cmd_else_if) Make sure the command is .-terminated.
7297 * glob.c: (init_glob) Capitalize the command prompt.
7299 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
7300 (end_file_trns_proc) Debugging message.
7302 * loop.c: (internal_cmd_loop) Make it work when there's no loop
7304 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
7306 * main.c: (dump_token) Make kwtab[] const.
7308 * set.q: Spelling, comment fixes.
7310 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
7313 * vars-prs.c: (fill_all_vars) Style fix.
7315 * vfm.c: (index_to_varname) Return const.
7317 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
7319 * Changes in many source files for partial -ansi -pedantic and
7320 no-debugging compliance: Remove trailing common in enum
7321 declarations; add `unused' attributes; insert some appropriate
7324 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
7326 * command.c: (shell) Make static.
7327 (run_command) Make static.
7329 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
7331 * dfm.c: (cmd_begin_data) I18n fix.
7333 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
7335 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
7337 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
7340 * file-handle.q: Don't prepend the source file directory name to
7341 the data file name. (Ongoing issue.)
7342 (prepend_current_directory) Comment out.
7343 (internal_cmd_file_handle) Don't call prepend_current_directory().
7344 (fh_get_handle_by_filename) Ditto.
7346 * filename.c: Append zero byte to readlink() return value.
7348 * getline.c: (getl_read_line) I18n fix.
7350 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
7352 * misc.h: Don't use gcc features if __STRICT_ANSI__.
7354 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
7357 * postscript.c: (output_encodings) Don't use local_strdup().
7360 * print.c: Don't use gcc features if __STRICT_ANSI__.
7362 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
7364 * recode.c: (parse_src_spec) Fully brace nested if's.
7366 * set.q: (global var set_testing_mode) New var.
7368 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
7370 * ascii.c: Add some more `unused' attributes that only come into
7371 play when NDEBUG is defined.
7372 (ascii_close_page) Set s_len when reallocating s.
7374 * crosstabs.q: (delete_missing) New function.
7375 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
7376 (make_summary_table) Create summary table reallocable.
7378 * postscript.c: Add more `unused' attributes as above.
7380 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
7381 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
7383 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
7386 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
7387 gratuitous space between parameter definition.
7389 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
7390 complaints about running off the end of functions with NDEBUG
7393 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
7395 * Several source files: Removed some PORTME notes when reflection
7396 revealed that ANSI forbids that sort of breakage. Also, added
7397 lots of `unused' qualifiers here and there.
7399 * aggregate.c: (accumulate_aggregate_info) Remove local var
7400 weighting that turned out not to be used.
7402 * avl.c: Update to version 1.1.0. Add unused specifier.
7403 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
7405 (avl_probe) Replace some instances of 1 with +1 where appropriate.
7406 (avl_find) Cast return value to void *.
7407 (avl_delete) q doesn't need to be initialized at the beginning of
7408 the function. Replace some instances of 1 with +1.
7409 (force_avl_delete) Renamed avl_force_delete, all references changed.
7410 (compare_ints) `param' marked unused.
7411 (print_int) `param' marked unused.
7412 (recurse_tree) Replace some instances of 1 with +1.
7414 * avl.h: Update to version 1.1.0. Only declares avl function
7415 types if not already declared.
7416 (AVL_MAX_HEIGHT) Only define if not already defined.
7417 (struct avl_node) New unused member char pad[2].
7418 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
7419 (force_avl_insert) Renamed avl_force_insert.
7420 (force_avl_delete) Renamed avl_force_delete.
7422 * crosstabs.q: (struct table_entry) Put `freq' into a union with
7424 (struct crosstab) Add new member `ofs'.
7425 (glob var int_tab) Removed.
7426 (custom_tables) In integer mode, assign v[i] properly through the
7428 (custom_variables) Now p.crs.max == max + 1.
7429 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
7430 (precalc) Implement integer mode.
7431 (calc_integer) Implement integer mode.
7432 (compare_table_entry) Remove unused local variable `comparing'.
7433 (make_summary_table) Implement integer mode.
7434 (macro ns_rows) Implemented as static variable now.
7435 (several variables) Made static, from global.
7436 (output_pivot_table) Use table_value_missing() for column heads.
7437 Remove several unused local variables. Implement integer mode
7438 table summing. Count up ns_rows.
7439 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
7440 (find_pivot_extent) Moved into find_pivot_extent_general; now just
7441 calls that function or find_pivot_extent_integer.
7442 (find_pivot_extent_integer) New function.
7443 (enum_var_values) Implemented for integer mode.
7444 (table_value_missing) New function.
7445 (display_dimensions) Call table_value_missing() for heads.
7446 (float_M_suffix) New function.
7447 (display_crosstabulation) Call table_value_missing() for row
7448 heads. Handle missing values in /MISSING=REPORT mode.
7449 (calc_fisher) Remove unused var N.
7450 (calc_r) Remove unused var fact.
7452 * data-list.c: (dump_fixed_table) Fix table dimensioning.
7453 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
7455 * data-out.c: (insert_commas) Remove unused var cp.
7456 (convert_CCx) Remove unused vars save_set_decimal,
7459 * descript.q: (dump_z_table) Fix table dimensioning.
7460 (pre_calc) Remove unused var j.
7461 (display) Remove unused vars title, s. Fix table dimensioning.
7463 * expr-evl.c: Comment fixes.
7465 * frequencies.q: (full_dim) New function.
7466 (dump_full) Fix table dimensioning.
7467 (condensed_dim) New function.
7468 (dump_condensed) Fix table dimensioning.
7470 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
7473 * html.c: (html_close_drive) Remove unused var i.
7474 (postopen) Remove unused vars title, curfn_len, cp.
7475 (preclose) Remove unused vars this, x.
7477 * lexer.c: Comment fixes.
7479 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
7481 * means.q: (custom_tables) Remove unused var m_dim.
7483 * mis-val.c: Format fix.
7485 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
7487 * output.c: (outp_get_paper_size) Remove unused var cp.
7489 * pfm-read.c: (read_float) Remove unused var save, unused label
7491 (read_variables) Remove unused vars cp, j.
7492 (read_value_label) Remove unused var j.
7494 * pfm-write.c: (bufwrite) Remove unused var i.
7496 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
7498 (output_encodings) Remove unused vars char_cp, n_output.
7499 (read_ps_encodings) Remove unused var ep.
7500 (postopen) Remove unused var title.
7501 (preclose) Remove unused var fp.
7502 (ps_open_page) Remove unused vars true, false, orientation,
7503 mirror_horz, mirror_vert, width, length.
7504 (ps_text_metrics) Remove unused var x.
7506 * q2c.c: (find_symbol) Remove unused var y.
7507 (parse_setting) Remove unused parameter sbc, all references
7509 (dump_parser) Remove unused var cp.
7510 (dump_free) Remove unused var i.
7512 * set.q: (static vars args, n) Removed.
7513 (internal_cmd_gset) Removed.
7515 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
7516 (read_machine_flt64_info) Removed unused var file_endian.
7517 (read_documents) Removed unused var i.
7518 (read_compressed_data) Removed unused parameter dict, all
7521 * sfm-write.c: (bufwrite) Removed unused var i.
7522 (sfm_write_case) Removed unused var i.
7524 * sort.c: (merge_once) Remove unused var t.
7525 (write_separate) #if 0 out as dead code.
7527 * split-file.c: (cmd_split_file) Remove unused var i.
7529 * sysfile-info.c: (sysfile_info_dim) New function.
7530 (cmd_sysfile_info) Fix table dimensioning.
7531 (variables_dim) New function.
7532 (display_variables) Fix table dimensioning.
7533 (describe_variable) Remove unused var prev_r.
7535 * t-test.q: (z_postcalc) Removed.
7536 (pairs_calc) Remove unused var bad_weight.
7537 (postcalc) Remove unused vars dfn, dfd.
7539 * tab.c: (tab_create) Set t->dim to NULL.
7540 (tab_dim) Make sure t->dim is NULL first.
7541 (tab_natural_width) Remove parameter `clamp'.
7542 (tab_value) Remove duplicate assertion for table.
7543 (tab_raw) New function.
7544 (nowrap_dim) New function.
7545 (wrap_dim) New function.
7546 (tab_output_text) Fix table dimensioning.
7548 * tab.h: (tab_raw) New macro.
7550 * val-labs.c: (get_label) Remove unused var type.
7551 (copy_value_labels) Remove unused var trav.
7553 * var.h: (struct crosstab_proc) Completely changed.
7555 * vars-prs.c: (parse_dict_variable) Remove unused var v.
7557 * vfm.c: (open_active_file) Remove unused vars i, lp.
7559 * weight.c: (weight_trns_proc) #if 0 out as dead code.
7561 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
7563 * Makefile.am: Add apply-dict.c, flip.c.
7565 * apply-dict.c: New file.
7567 * command.c: (struct command) Make cmd[] larger for CLEAR
7568 TRANSFORMATIONS command name.
7569 (parse_cmd) Make sure we're in a valid state before using it as an
7570 index. Discard variables and reset state on invalid transitions.
7571 (cmd_clear_transformations) New function.
7573 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
7574 Add unimplemented PRESERVE, RESTORE.
7576 * file-handle.h: Include stddef.h.
7580 * pfm-read.c: (parse_value) Pad value label values with spaces,
7583 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
7584 (sfm_close) Decrement reference count, make sure it's zero.
7585 (sfm_maybe_close) New function.
7586 (sfm_read_dictionary) Handle reference counts.
7588 * vars-atr.c: (clear_default_dict) New function.
7589 (discard_variables) Use clear_default_dict().
7591 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
7593 * Makefile.am: Add pfm-write.c.
7594 (LDADD) Add the libgmp2 libraries.
7596 * command.def: Define EXPORT.
7598 * get.c: (cmd_export) New function.
7599 (export_write_case_func) New function.
7601 * pfm-read.c: (static spss2ascii[]) Make it const.
7603 * pfm-write.c: New file.
7605 * sfm-write.c: Formatting, comment fixes.
7607 * var.h: Comment fix.
7609 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
7611 * Makefile.am: Add pfm.h, pfm-read.c.
7613 * command.def: IMPORT is now implemented.
7615 * format.c: (glob var translate_fmt[]) New var.
7617 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
7618 (cmd_import) New function.
7619 (import_source_read) New function.
7620 (glob var import_source) New var.
7622 * pfm-read.c: New file.
7626 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
7628 (dump_dictionary) Disabled printing a couple of items.
7630 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
7632 * crosstabs.q: (postcalc) Call make_summary_table().
7633 (make_summary_table) New function.
7634 (insert_summary) New function.
7635 (display_dimensions) Remove some unnecessary arguments, all
7637 (output_pivot_table) Fix lots of problems with the risk table
7639 (submit) Don't display an empty table.
7640 (display_risk) Fix order of arguments to calc_risk().
7642 * glob.c: Always include assert.h and stdlib.h.
7644 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
7647 * tab.c: (tab_create) Cosmetic changes.
7649 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
7651 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
7655 * crosstabs.q: (output_pivot_table) Headers drawing and submission
7656 code simplified, moved into new function submit().
7657 (submit) New function.
7658 (crosstabs_dim) New function.
7659 (display_directional) Substitute variable names for %s where
7661 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
7662 (calc_symmetric) Initialize parameters only if non-NULL.
7663 Calculate Somers' d.
7664 (calc_directional) Calculate Somers' d (or copy it, really).
7667 * output.c: (outp_string_width) New function.
7669 * postscript.c: (postopen) Calculate font widths based on the
7670 width of the zero '0' character, not the width of the space
7671 character. Set paper-width and paper-length based on points, not
7673 (ps_open_page) Fix page setup string for landscape mode.
7675 * som.h: (struct som_dimension) Removed.
7676 (struct som_table_class) height, width members take int * not
7679 * tab.c: Many functions now have added parameter validation.
7680 (tab_height, tab_width) These functions were removed and merged
7681 into a single function tab_resize(), and all references changed.
7682 (tab_dim) Rewritten since the interface changed; reduced from
7683 hundreds of lines to two. All callers were changed. Currently
7684 most of them just use tab_natural_dimensions as their callback and
7685 await detailed translation of functionality.
7686 (tab_natural_width) New function.
7687 (tab_natural_height) New function.
7688 (tab_natural_dimensions) New function. This is a callback
7689 function, not something that you'd want to call directly.
7690 (tab_nat_dim) Removed.
7691 (tabi_table) Allocates t->w and t->h.
7692 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
7693 dimensions callback.
7694 (evaluate_dimensions) Removed.
7695 (sum_columns) Removed.
7697 * tab.h: (enum TAL_1THIN) Removed.
7698 (enum series t_*) Removed.
7699 (struct tab_table) Members trh, trv changed to unsigned char *
7700 from int *. Member dim changed to a function pointer from a
7701 unsigned char *. Member max_stack_height removed. New members
7703 (macros tab_l, tab_r, tab_t, tab_b) New.
7705 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
7707 * ascii.c: (delineate) Assign last_space_nchars before skipping
7708 spaces, to fix right justification.
7710 * crosstabs.q: (static vars risk, direct) New vars.
7711 (static var pearson_r) Removed.
7712 (glob var chisq_fisher) Made static.
7713 (static vars row_tot[], col_tot[]) Don't include grand total
7715 (static var grand_total) Renamed W, all references changed.
7716 (output_pivot_table) Only make `table' if num_cells != 0. Make
7717 risk and directional tables. Deal with grand total no longer part
7718 of col_tot[]. Free rows and cols after we're done with them.
7719 (display_risk) New function.
7720 (display_directional) New function.
7721 (clac_r) Rewritten so that it stores all its results into its
7722 arguments, so it can be used for Spearman's correlation too.
7723 (calc_symmetric) Added a t[] argument, all references changed.
7724 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
7725 Pearson's r, Cohen's kappa.
7726 (calc_risk) New function.
7727 (calc_directional) New function.
7729 * som.c: (som_submit) Improved debugging code.
7731 * stats.c: (hypercube) New function.
7732 (cube) New function.
7734 (normal_sig) Went back to old implementation, which actually
7737 * stats.h: (macros square, cube, hypercube) Removed. The
7738 equivalent functions in stats.c are inlined here; all references
7739 to square changed to sqr.
7741 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
7743 * crosstabs.q: (N_SYMMETRIC) New define.
7744 (postcalc) Disable debug printing.
7745 (static vars chisq_fisher, pearson_r) New.
7746 (output_pivot_table) Add support for symmetric measures. Add
7747 chi-square output of exact sigs.
7748 (display_chisq) Rewritten.
7749 (display_symmetric) New function.
7750 (gamma_int) New function.
7752 (swap) New function.
7753 (calc_fisher) New function.
7754 (calc_chisq) Check boundary conditions better. Calculate Yates,
7755 Fisher, Mantel-Haenszel tests.
7756 (calc_r) New function.
7757 (calc_symmetric) New function.
7759 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
7761 (chisq_sig) Better boundary conditions. Renamed from
7764 * tab.h: (struct tab_table) New member cf.
7766 * tab.c: (tab_create) Set cf.
7767 (tab_width) New function.
7768 (tab_realloc) Handle cf.
7769 (tab_vline) Handle cf.
7770 (tab_hline) Handle cf.
7771 (tab_box) Handle cf.
7772 (tab_value) Handle cf.
7773 (tab_float) Handle cf.
7774 (tab_text) Handle cf.
7775 (tab_joint_text) Handle cf.
7776 (tab_offset) Handle cf.
7777 (tab_next_row) Handle cf.
7778 (evaluate_dimensions) Handle cf.
7779 (render_strip) Handle cf.
7781 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
7783 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
7784 output_pivot_table().
7785 (output_pivot_table) Moved lots of local variables outside and
7786 made them static. Add beginnings of chi-square statistic
7787 support. Now column and row totals aren't in the main matrix.
7788 Always zero out any leftover rows & columns after we're done with
7789 the table entries. Move all output stuff into
7790 display_dimensions(), display_crosstabs(), display_chisq().
7791 (display_dimensions) New function.
7792 (display_crosstabulation) New function.
7793 (display_chisq) New function.
7794 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
7796 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
7797 references, simplify logic.
7799 * postscript.c: Remove scale, translate-x, translate-y,
7800 mirror-horz, mirror-vert, rotate-180 options.
7801 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
7802 All references deleted.
7803 (macro YT) New macro.
7804 (array option_tab[]) Removed options.
7805 (ps_option) Removed options.
7806 (ps_open_page) Write page setup explicitly to output file, without
7807 using now-deleted BP function.
7808 (macro dump_line) Use YT().
7809 (macro dump_thick_line) Use YT().
7810 (draw_headers) Use YT().
7811 (switch_font) Reorder arguments to SF function.
7812 (write_text) Use YT().
7814 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
7817 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
7819 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
7820 null-debugging code.
7821 (tab_realloc) Remove null-debugging code. Initialize new regions
7823 (tab_vline) Support offsets.
7824 (tab_hline) Support offsets.
7825 (tab_box) Support offsets.
7827 (tab_nulls) Removed.
7830 (evaluate_dimensions) Remove null-debugging code. Understand
7831 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
7832 TAB_EMPTY not present.
7834 * tab.h: New cell attribute TAB_EMPTY.
7835 (macros tab_nr, tab_nc, tab_row, tab_col) New.
7837 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
7838 try to read them from system files.
7840 * vfm.c: (dump_splits) Don't call tab_null().
7842 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7844 * crosstabs.q: (struct crosstab) Added `missing' member.
7845 (custom_tables) Init missing.
7846 (calc_general) Handle missing values.
7847 (calc_chisq) New function.
7848 (output_pivot_table) Start work on chi-square output. Update for
7849 new tab offset support functions. Shorten statistic names.
7851 * Several files: add in more `const's to placate gcc's warnings.
7853 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7856 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7857 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7858 tab_joint_text) Add col_ofs and row_ofs support.
7859 (tab_offset) New function.
7860 (tab_next_row) New function.
7861 (tab_row) New function.
7862 (tab_col) New function.
7863 (tabi_table) Add col_ofs and row_ofs support.
7865 * vars-atr.c: (is_system_missing) New function.
7867 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7869 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7870 (static var no_cells) Removed.
7871 (static var num_cells) New.
7872 (static var expected) New.
7873 (static var cells[]) New.
7874 (internal_cmd_crosstabs) Deal with new variables.
7875 (postcalc) Removed most of the meat and put it in new function
7876 output_pivot_table().
7877 (output_pivot_table) Calculates and outputs an entire pivot table.
7879 * postscript.c: (postopen) Fix problems with free()ing addresses
7880 not obtained from malloc().
7882 * som.c: (som_submit) Add assertion.
7884 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7887 * tab.c: (static var tab_names[]) New.
7888 (tab_realloc) -1 for nc or nr indicates no change.
7889 (tab_nulls) New function.
7890 (tab_dim) Use tab_names[].
7891 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7892 (evaluate_dimensions) Don't terminate on uninited cells, just put
7893 an X in them and emit a notice. Use tab_names[].
7895 * tab.h: Move bits into tab.def.
7897 * tab.def: New. Don't try to declare tab_table_class because then
7898 som.h has to be included.
7900 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7902 * command.def: New file, contains all the command definitions
7903 previously included bodily in command.c.
7905 * format.def: New file, contains all of the format definitions
7906 previously split across format.h, format.c, and sfm-write.c.
7908 * lexer.h: Renamed from tokens.h in order to match corresponding
7911 * lexerP.h: Moved some rarely used functions exported by lexer.c
7914 * Makefile.am: Commemorate renamed files.
7915 (EXTRA_DIST) Add command.def, format.def.
7917 * command.c: [0] (walk_cmdtable_func) Removed.
7919 * crosstabs.q: (postcalc) Made it work and print out matrices
7921 (enum_column_values) Renamed enum_var_values, generalized for any
7924 * format.h: (struct fmt_desc) New member `spss'.
7926 * q2c.c: (main) Generated code includes lexer.h instead of
7929 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7930 instead of an independent translation table.
7932 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7934 * Lots of source files: Added const to declarations.
7936 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7938 * arena.c: (arena_clear) Set prev pointer to null when done.
7940 * ascii.c: (ascii_option) Rename index as indx.
7942 * avl.c: This is now a separate library called libavl.
7943 (xmalloc) Make static.
7944 (avl_probe) Step A7 can use the cache instead of an explicit
7946 (avl_delete) Don't maintain a q pointer because it's always
7947 available in the pointer stack. Comment fix.
7949 * avl.h: This is now a separate library called libavl.
7951 * command.c: (cmd_table[]) Remove spurious trailing "".
7953 * common.h: Only include random() fix if this system needs it.
7955 * crosstabs.q: Include alloca headers.
7956 (n_sorted_tab) New global var.
7957 (postcalc) Mostly rewritten.
7958 (find_pivot_extent) Rewritten.
7959 (enum_column_values) Rewritten.
7961 * data-out.c: (convert_F) Rename inner n as n_spaces.
7963 * error.c: (dump_message) Don't have an outer var i.
7965 * file-handle.q: (static var f) Removed. All references removed.
7966 (internal_cmd_file_handle) Uses a local variable instead of f.
7968 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7969 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7972 * getline.h: Declare getl_history as extern. Reported by
7973 palme@uni-wuppertal.de (Hubert Palme).
7975 * postscript.c: (postopen) Some large mods for constness.
7977 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7980 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7982 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7983 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7986 * avl.c, avl.h: New files. These form a clean-room
7987 reimplementation of avllib. Iterative algorithms are used in
7988 place of recursive ones, so there is no resemblance in the code.
7990 * Lots of headers: Don't include other headers by default.
7992 * Lots of source files: Explicitly include all needed headers.
7994 * arena.c: (arena_clear) New function.
7996 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7997 (static var ar) Removed.
7998 (staitc vars ar_tc, ar_col) New.
7999 (cmd_crosstabs) Destroy the arenas.
8000 (internal_cmd_crosstabs) Create the arenas.
8001 (precalc) Don't need a free function for the hash.
8002 (calc_general) Make sure to zero out the trailer on the key data
8004 (print_table_entries) Updated.
8005 (postcalc) Worked on actually implementing.
8006 (find_pivot_extent) New function.
8007 (compare_value) New function.
8008 (enum_column_values) New function.
8010 * data-in.c: (parse_month) Make local array `static const'.
8012 * data-out.c: (convert_date) Make local array `static const'.
8013 (convert_WKDAY) Same.
8014 (convert_MONTH) Same.
8016 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
8017 been renamed to avl_walk().
8019 * hash.c: Rewritten more efficiently.
8021 * hash.h: Add attribute const to hsh_next_prime declaration.
8023 * lexer.c: (id_match) Make arguments const.
8025 * postscript.c: (ps_postopen_driver) Make default fonts the
8028 * q2c.c: (main) Generated code needs stdlib.h.
8030 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
8031 initialized to 0 now, not to NULL. All other references to
8032 avl_traverser were updated in the same way.
8034 * tokens.h: Macro version of id_match updated to use const
8037 * val-labs.c: (inc_ref_count) New function.
8038 (copy_value_labels) Simply through use of new avl_copy() function.
8040 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
8042 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
8043 (postcalc) Worked on this.
8045 * postscript.c: (OPO_DOUBLE_LINE) New enum.
8046 (struct ps_driver_ext) New line_width_thick member.
8047 (ps_preopen_drive) Init line_width_thick.
8048 (option_tab[]) Add line-* options.
8049 (ps_option) Parse line-* options.
8050 (postopen) Add line_width_thick support. Strip leading spaces on
8051 prologue output lines.
8052 (ps_open_page) Include line_width_thick in output.
8053 (macro dump_thick_line) New.
8054 (dump_fancy_line) Support thick lines as well as double lines.
8056 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
8058 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
8059 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
8061 * Many source files: Rename `options' to `pv_opts' as appropriate.
8063 * command.c: (static var cmd_table[]) Add CROSSTABS command.
8065 * common.c: (xcalloc) New function.
8067 * crosstabs.q: New file. Not finished yet, though.
8069 * data-list.c: Comment fix.
8071 * error.c: Remove some old Checker cruft.
8073 * frequencies.q: (dump_full) Cumulate valid percent instead of
8076 * getline.c: Comment fix.
8078 * hash.c: Comment fixes.
8080 * hash.h: (struct hsh_table) Make hash functions return unsigned
8081 instead of int to avoid problems with taking the modulo of
8082 negative return values. All references changed.
8084 * misc.c: (intlog10) Make its table static const instead of auto.
8086 * sfm-read.c: (read_header) Make `prefix' static const instead of
8089 * var.h: (union value) Add member `hash'.
8090 (struct variable) Rename prv_index as `foo'--all references
8092 (typedef pv_opts) Removed. All references changed.
8094 * vars-prs.c: (parse_variables) Message fixes.
8096 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
8098 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
8099 they are being inserted. Don't check for BY variables of
8100 different types. Discard variables if the active file isn't
8101 included in the merge.
8102 (mtf_processing) Essentially rewritten.
8103 (mtf_merge_dictionary) Check for master/slave variables of
8104 different types/widths.
8106 * vfm.c: (static var not_canceled) New var.
8107 (process_active_file) Don't call vfm_source->read() if
8108 there's no vfm-source. Initialize not_canceled.
8109 (process_active_file_write_case) Honor and update not_canceled.
8110 (prepare_for_writing) Rollback changes from yesterday, they were
8112 (close_active_file) Don't destroy vfm_source unless it exists.
8114 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
8116 * Lots of source files: Added { } around nested if/else constructs
8117 to avoid new gcc 2.8 warnings.
8119 * data-in.c: (parse_Z) Declare `int' type explicitly.
8122 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
8123 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
8124 prev members. Put TABLEs at the end of the chain and FILEs at the
8125 beginning. Don't allow the active file in STATE_INIT. Use proper
8126 `seen' value for the active file. Fill out the by members and
8127 make sure they're of consistent type. Do the actual merge
8129 (mtf_processing_finish) New function.
8130 (var_type_description) New function.
8131 (mtf_free_file) New function.
8132 (mtf_free) Rewritten.
8133 (mtf_delete_file_in_place) New function.
8134 (mtf_read_nonactive_records) New function.
8135 (mtf_compare_BY_values) New function.
8136 (static var mtf_seq_no) New var.
8137 (mtf_processing) New function.
8138 (mtf_merge_dictionary) Assign nval members for the system file
8139 dictionary. Assign fv values for its variables. Point each slave
8140 variable to the corresponding master variable.
8142 * hash.c: Include str.h.
8144 * mis-val.c: (copy_missing_values) src arg is const.
8146 * misc.c: (spacing) Make `max' var explicitly int.
8148 * sfm-read.c: (dump_dictionary) Message reformatting.
8149 (sfm_read_case) Add assertion.
8151 * sort.c: Esthetic fixes.
8153 * var.h: (struct match_files_proc) New struct.
8154 (struct variable) Add private data match_files_proc.
8156 * vars-atr.c: (delete_variable) Implement. Add argument for the
8157 dictionary that owning the variable.
8158 (dup_variable) Add assertion.
8160 * vfm.c: Comment fixes, hopefully the comments are correct now.
8161 (process_active_file) New function.
8162 (process_active_file_write_case) New function.
8163 (process_active_file_output_case) New function.
8164 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
8166 (write_case) Renamed procedure_write_case(). Now write_case is a
8167 pointer to a function. Style fixes.
8169 1998-03-05 Ben Pfaff <blp@gnu.org>
8171 * Makefile.am: (q2c) Link with libmisc.
8172 (version.c) Define default_config_path, include_path,
8175 * ascii.c: (ascii_postopen_driver) When the default newline string
8176 is requested, open file in text mode. Suggested by
8177 palme@uni-wuppertal.de (Hubert Palme).
8178 (static vars line_buf, line_p) Change from char * to unsigned char
8180 (ascii_close_page) char * to unsigned char *.
8182 * cmdline.c: (parse_command_line) Implement -r option by
8183 prepending ~/.pspp/rc to the list of files to process.
8185 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
8186 before pulling in a final line.
8187 (null_func, null_int_func) Removed (dead code).
8189 * descript.q: (display) Calculate width of variable name column
8190 properly. Calculate number of valid cases properly. Reported by
8191 palme@uni-wuppertal.de (Hubert Palme).
8193 * filename.c: (init_filename) Use default_config_path instead of
8194 now obsolete CONFIG_PATH.
8196 * getline.c: (getl_initialize) Use include_path instead of now
8197 obsolete INCLUDE_PATH.
8198 (getl_add_file) New argument `where'. All references changed.
8200 * groff.c: (find_font_file) Use groff_font_path instead of now
8201 obsolete GROFF_FONT_PATH.
8203 * postscript.c: (find_ps_file) Use groff_font_path instead of now
8204 obsolete GROFF_FONT_PATH. Copy through temporary variable to
8205 avoid problems with constness.
8207 * str.h: (macro cs_streq) New macro.
8209 * version.h: (glob var default_config_path, include_path,
8210 groff_font_path) New vars.
8212 1998-02-23 Ben Pfaff <blp@gnu.org>
8214 * Many source files: Change verbose_msg() priority levels and
8217 * aggregate.c: Include debug-print.h.
8219 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
8221 (static var pre_syntax_message) Document --safer/-s and
8224 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
8226 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
8227 because it's not used but it's still copied.
8228 (open_file_r) Remove gratuitous debug message.
8230 * filename.c: (safety_violation) New function.
8231 (open_file) Remove gratuitous debug messages. Don't allow pipe
8232 files if set_safer is set.
8234 * get.c: Turn off debugging.
8236 * getline.c: (getl_add_virtual_file) New function.
8237 (getl_read_line) Add verbose_msg() call for opening new syntax
8239 (getl_perform_delayed_reset) Add a return value describing whether
8240 any action was taken. Call reset_eof().
8242 * getline.h: Comment fix.
8244 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
8245 place of incorrect `continue'. Use strtok_r() instead of
8246 strtok(). Always check strtok_r() return value.
8247 (groff_read_DESC) Use strtok_r() instead of strtok().
8249 * lexer.c: (reset_eof) New function.
8251 * main.c: (parse) Get a token after performing a delayed reset
8252 action; allow empty syntax files.
8254 * postscript.c: (output_encodings) Use strtok_r() instead of
8257 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
8259 * set.q: Comment fixes.
8260 (glob var set_safer) New var.
8261 (internal_cmd_set) Support SAFER.
8263 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
8265 * temporary.c: (free_dictionary) Set d->splits to NULL after
8268 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
8269 variable deleted, not if it *isn't* deleted.
8271 1998-02-16 Ben Pfaff <blp@gnu.org>
8273 * command.c: (array cmd_table[]) Add MATCH FILES.
8275 * common.c: Comment fixes.
8277 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
8278 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
8279 Include alloca.h. Problem reported by palme@uni-wuppertal.de
8282 * expr-opt.c: Include str.h. Problem reported by
8283 palme@uni-wuppertal.de (Hubert Palme).
8285 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
8286 (static var mtf_by) Change from char ** to variable **.
8287 (static var mtf_master) New var.
8288 (mtf_merge_dictionary) New function.
8289 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
8290 var type. Reorder tests properly. Initialize file->dict. Detect
8291 TABLE= without BY=. Read file dictionaries and merge them. Give
8292 subcommand name with IN, LAST, FIRST error messages. Create IN,
8293 LAST, FIRST variables. Comment fixes.
8294 (mtf_free) Don't free default_dict. Free mtf_master.
8296 * getline.c: Define getl_mode. Change getl_buf_size to size_t
8298 (handle_line_buffer) Cast int to size_t in comparison to avoid
8301 * getline.h: Declare getl_mode extern.
8303 * groff-font.c: (groff_read_font) Type-fix calls to getline.
8304 (groff_read_DESC) Make line_size a size_t.
8305 (match_tok) Parenthesize name to avoid macro expansion.
8307 * mis-val.c: (copy_missing_values) New function.
8309 * postscript.c: (postopen) Make buf_size a size_t.
8311 * sfm-read.c: (dump_dictionary) Make global from static. Print
8312 variable info in parts for easier debugging with Checker.
8314 * temporary.c: (copy_variable) Use copy_value_labels().
8315 (new_dictionary) New arg: whether to copy file label, documents.
8317 * val-labs.c: (copy_value_labels) New function.
8319 * var.h: (enums MISSING_*) Add MISSING_COUNT.
8321 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
8323 (dup_variable) Set prv_index, get.fv, get.nv.
8325 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
8327 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
8329 * Many source files: For ANSI-compliance, add empty statement
8330 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
8331 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
8333 * data-in.c: (parse_numeric) Some header files break on
8334 -DBL_MIN_10_EXP because they get a --; add () for safety.
8335 Reported by palme@uni-wuppertal.de (Hubert Palme).
8337 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
8338 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
8339 (dfm_close) Use close_file_ext.
8340 (open_inline_file) Set file.file to NULL, not file.
8341 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
8342 struct and use open_file_ext().
8343 (read_record) Use file.file.
8345 * file-handle.q: (prepend_current_directory) Pass through special
8348 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
8349 (normalize_filename) Pass through special filenames.
8350 (open_file, close_file) Accept pipe| and |pipe syntaxes as
8352 (dirname) Rename blp_dirname() because of name conflict on some
8353 OS. All references changed. Reported by palme@uni-wuppertal.de
8355 (is_special_filename) New function.
8357 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
8358 (trim_dictionary) Conditionalize some of the options on whether
8359 GTSV_OPT_MATCH_FILES is in *options.
8360 (rename_variables) Don't allow variables to be renamed as scratch
8362 (MTF_*) New enum series.
8363 (struct mtf_file) New struct.
8364 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
8366 (cmd_match_files, mtf_free) New functions.
8368 * lexer.c: (match_int) Needed parentheses around name to escape
8369 macro expansion. Reported by Micah Altman
8370 <maltman@www-vdc.fas.harvard.edu>.
8372 * print.c: Needed to include alloca.h. Reported by Micah Altman
8373 <maltman@www-vdc.fas.harvard.edu>.
8375 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
8376 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
8379 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
8380 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
8382 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
8384 * html.c: (struct html_driver_ext) Move into htmlP.h.
8385 (html_preopen_driver) Initialize cp_x, cp_y.
8386 (html_submit) Implement as call to output_tab_table().
8387 (change_attributes) New function.
8388 (escape_string) New function.
8389 (output_tab_table) New function.
8391 * list.q: (write_all_headers) Add code for writing headers for the
8393 (clean_up) Write out the html close-table tag.
8394 (determine_layout) Ignore html driver.
8395 (list_cases) Write html data.
8397 * som.c: (som_submit) Move more of the code into output_table().
8399 * tab.c: (static var hit) Make a global var and rename tab_hit.
8400 (static var tab_table_class) Make a global var.
8402 * htmlP.h: New file.
8404 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
8406 * dump-sysfile.c: Removed.
8408 * html.c: (preclose) Change comment in emitted code.
8410 * matrix-data.c: Debugging off by default. Comment fixes.
8411 (static var container) New var.
8412 (cmd_matrix_data) Create and destroy container. Initialize
8413 is_per_factor[] to 0s. Move code into new function
8414 string_to_content_type(). Require split values to be present in
8415 the data when ROWTYPE_ is explicit. Call specific function, not
8416 general read_matrices().
8417 (string_to_content_type) New function.
8418 (context) Exclude all whitespace, not just spaces.
8419 (mget_token) A dot is a number. Add assertion.
8420 (static var data) Renamed nr_data.
8421 (static var factor_values) Renamed nr_factor_values.
8422 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
8423 only specific case. Close data_file before exit.
8424 (fill_matrix) New function.
8425 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
8426 printing. Style fixes. Message fixes. Move code into
8428 (read_matrices_without_rowtype) Rename
8429 matrix_data_read_without_rowtype(). Fix off-by-one error on
8430 loops. Allocate nr_data[] memory from arena.
8431 (read_matrices_with_rowtype) Removed.
8432 (read_splits) Renamed nr_read_splits(). Style fixes.
8433 (read_factors) Renamed nr_read_factors().
8434 (dump_cell_content) Comment fixes. Arguments changed. Change
8435 debug printing. All references changed.
8436 (output_data) Renamed nr_output_data().
8437 (static var wr_content) New var.
8438 (struct factor_data) New struct.
8439 (static var wr_data) New var.
8440 (static var wr_current) New var.
8441 (matrix_data_source_destroy_source) Removed.
8442 (read_matrices_with_rowtype) New function.
8443 (matrix_data_read_with_rowtype) New function.
8444 (wr_read_splits) New function.
8445 (compare_factors) New function.
8446 (wr_output_data) New function.
8447 (wr_read_rowtype) New function.
8448 (wr_read_factors) New function.
8449 (wr_read_indeps) New function.
8450 (glob var matrix_data_source) Make destroy_source member NULL as
8453 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
8455 * lexer.c: (syntax_error) Give better error message when at end of
8458 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
8459 N_SCALAR to output as plain N.
8460 (mdump_token) Change output format.
8461 (context) Fix message output interaction with spaces in input.
8462 (another_token) New function.
8463 (force_eol) Improved error message.
8464 (static var max_cell_index) New var.
8465 (read_matrices) Init `cells'. factor_values is now per-cell.
8466 Init max_cell_index.
8467 (read_data_lines) Replace `compare' local with new `compare' arg.
8468 Debugging messages changed. Only read factors if per_factor.
8469 Propagate error return from read_factors(), force_eol().
8470 Copy N_SCALAR values across the N vector.
8471 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
8472 check parentheses manually since we now have is_per_factor[].
8473 Call read_data_lines() with new args. Check for end of data after
8474 looping, using another_token().
8475 (read_factors) Arguments changed. Use max_cell_index to determine
8476 whether to read or compare factors. Message fixes.
8477 (dump_cell_content) New function.
8478 (output_data) Completely rewritten because content types were
8479 supported to be nested inside factor values, not vice versa.
8481 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
8483 * lexer.c: (syntax_error) Support formatted varargs messages.
8485 * matrix-data.c: Turn debugging on by default.
8486 (static content_type[]) New array.
8487 (static content_names[]) New array.
8488 (static rowtype_, varname_) New vars.
8489 (static is_per_factor[]) New array.
8490 (static split_values) Moved declaration.
8491 (static n_continuous, first_continuous) New var.
8492 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
8493 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
8494 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
8495 Check for continuous variables.
8496 [DEBUGGING] (debug_print) Remove content_names[].
8497 (mdump_token) New macro.
8498 (mget_token_dump) New function.
8499 (mdump_token) New function.
8500 (context) New function.
8501 (mget_token) Fix messages.
8502 (static var data, split_values, factor_values) New vars.
8503 (read_matrices) Manage split_values, factor_values.
8504 (read_data_lines) New function.
8505 (read_matrices_without_rowtype) Implemented.
8506 (read_splits) Message fixes. Uses `just_read'.
8507 (read_factors) New function.
8508 (output_data) New function.
8509 (matrix_data_source_destroy_source) Close the file handle.
8510 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
8513 * str.c: (strpadcmp) Removed.
8515 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
8517 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
8519 * Lots of source files: Add cast to unsigned character to calls to
8520 tolower() and toupper().
8522 * aggregate.c: Set default_dict.splits to NULL.
8524 * command.c: (static variable tab[]) Add MATRIX DATA.
8526 * data-in.c: Add debugging defines. Formatting fixes.
8528 * expr-opt.c: Formatting fixes.
8530 * lexer.c: (syntax_error) Message fixes.
8532 * matrix-data.c: New enum series.
8533 (static vars fmt, section, diag, explicit_rowtype, signle_split,
8534 split_values, n_factors, factors, cells, pop_n, contents,
8535 n_contents) New vars.
8536 (cmd_matrix_data) Finished implementation.
8537 (compare_variables_by_mxd_vartype) New function.
8538 [DEBUGGING] (debug_print) New function.
8539 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
8540 (read_matrices) New function.
8541 (read_matrices_without_rowtype) New function.
8542 (read_matrices_with_rowtype) New function.
8543 (read_splits) New function.
8544 (mget_token) New function.
8545 (force_eol) New function.
8546 [0] (test_tokenizer) New function.
8547 (matrix_data_source_destroy_source) New function.
8548 (glob var matrix_data_source) New var.
8550 * misc.h: Include ieeefp.h if present.
8552 * split-file.h: (cmd_split_file) Changes corresponding to struct
8555 * str.h: Fix memmem prototype.
8557 * temporary.c: (save_dictionary, restore_dictionary,
8558 free_dictionary) Changes corresponding to struct dictionary
8561 * var.h: (MXD_* enums) New enum series.
8562 (struct matrix_data_proc) New struct.
8563 (struct split) Removed.
8564 (struct dictionary) Changed `splits' member from `split *' to
8566 (macro force_create_variable) New macro. Replaced lots of
8567 create_variable()/assert() calls with calls to this macro.
8569 * vars-atr.c: (discard_variables) Changed assertion.
8570 [GLOBAL_DEBUGGING] (force_create_variable) New function
8571 called by the macro of the same name.
8572 (clear_variable) Changes to delete splits from the dictionary
8573 corresponding to struct dictionary changes.
8575 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
8576 corrupted variable `index' values in the dictionary passed in
8577 every time this function is called.
8579 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
8580 to struct dictionary changes.
8582 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
8584 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
8586 * command.c: New includes.
8587 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
8588 (cmd_erase) New function.
8589 [unix] (shell) New function.
8590 (run_command) New function.
8591 (cmd_host) New function.
8592 (cmd_new_file) New function.
8594 * expr-prs.c: (parse_primary) Message fix.
8596 * inpt-pgm.c: Formatting fix.
8597 (cmd_reread) Implement the FILE subcommand.
8599 * matrix-data.c: New file.
8601 * q2c.c: (dump_header) Change output commenting style.
8603 * weight.c: Comment fix.
8605 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
8607 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
8609 (buf_10x) Renamed buf_1xx, all references changed.
8610 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
8611 cases now implemented).
8612 (create_sysfile) New function.
8613 (agr_11x_func) New function.
8615 * data-in.c: (parse_numeric) Work properly if there's an
8616 explicitly coded decimal point in the data and decimal places are
8617 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
8618 <el@linux.lisse.na>.
8620 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
8621 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
8622 Eberhard W Lisse <el@linux.lisse.na>.
8624 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
8625 strerror.c. Bug reported by Alexandre Oliva
8626 <oliva@dcc.unicamp.br>.
8628 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
8629 (static var separate_case_tab) New var.
8630 (cmd_sort_cases) Cancel temporary transformations here. Free
8631 v_sort before return.
8632 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
8633 we're reading from a sort stream. Don't cancel temporary
8634 transformations. Offload internal sorting to do_internal_sort().
8635 (do_internal_sort) New function. Handles internal sorting even
8636 when SEPARATE is nonzero. Doesn't free v_sort.
8637 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
8639 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
8640 sink if SEPARATE is zero.
8641 (read_output_cases) Renamed read_sort_output(), all references
8642 changed. Now uses separate_case_tab when it exists.
8643 (write_separate) New function.
8645 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
8646 memory_sink_cases. Don't redundantly call
8647 vfm_source->destroy_source().
8648 (memory_stream_mode) After switching over, set memory_sink_cases
8651 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
8653 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
8655 (static var prev_case) New, moved out of aggregate_single_case()
8657 (static var buf64_10x, buf_10x) New.
8658 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
8659 the 000, 001, 100, and 101 cases. Free prev_case.
8660 (parse_aggregate_functions) Disallow scratch variables.
8661 (free_aggregate_functions) Only free agr_dict if non-null. Use
8662 iter->function to determine numeric/string type, not
8664 (aggregate_single_case) Don't manage prev_case. Initialize
8665 aggregate info after dumping it.
8666 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
8667 mean, stddev, weighted stddev definitions.
8668 (dump_aggregate_info) Implemented.
8669 (initialize_aggregate_info) Renamed from
8670 initialize_aggregate_functions(). Initializes dbl[2].
8671 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
8672 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
8674 * cases.c: (alloc_val) Removed.
8676 * get.c: (cmd_save_internal) Initialize new `dict' member.
8678 * sfm-write.c: (sfm_write_dictionary, write_header,
8679 write_variable, write_value_labels, write_documents) Reorganize,
8680 simplify for new parameter structure.
8681 (write_variable) Only one variable * argument now.
8683 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
8684 replaced by new `dict' member.
8686 * temporary.c: (new_dictionary) Initialize n_documents.
8688 * vars-atr.c: (dup_variable) Allocate `value's from dict into
8690 (init_variable, replace_variable) Eliminate usage of alloc_val().
8692 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
8694 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
8695 signal that AGGREGATE is to be used for forming final cases.
8696 (close_active_file) Call end_func before stopping lagging. Cancel
8697 temporary after finishing compaction.
8698 (write_case) Comment fixes. Cleaned up.
8699 (compact_case) Let AGGREGATE handle compaction when `temporary' is
8702 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
8704 * Makefile.am: (BUILT_SOURCES) Add means.c.
8705 (pspp_SOURCES) Add means.c.
8706 (EXTRA_DIST) Add means.q.
8708 * command.c: (array cmd_table[]) Add MEANS.
8710 * common.h: Esthetic fixes. Comment fixes. Test for
8711 MAX_SHORT_STRING greater than 8.
8712 (macros LOWEST, HIGHEST) New.
8714 * data-in.c, data-list.c, recode.c: Comment fixes.
8716 * means.q: New file, base version.
8718 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
8719 with LOWEST, DBL_MAX with HIGHEST.
8721 * q2c.c: (dump_vars) Add an enum to array types giving the number
8722 of values for the enum.
8724 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
8725 Replace second_lowest_value with second_lowest_flt64.
8727 * sfm-write.c: (write_variable, write_rec_7_34) Replace
8728 second_lowest_value with second_lowest_flt64.
8730 * t-test.q: Comment fix.
8732 * temporary.c: (restore_dictionary) Esthetic fix.
8734 * tokens.h: (force_match_id, force_match, force_string, force_int,
8735 force_num, force_id) Replace msg() with syntax_error().
8737 * var.h: (struct means_proc) New.
8738 (struct variable) Add mns member to `p' union.
8740 * vars-prs.c: (parse_variable, parse_dict_variable,
8741 parse_variables, parse_DATA_LIST_vars) Replace msg() with
8744 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
8746 * Makefile.am: (pspp_SOURCES) Add tab.h.
8748 * Most source files: Added a cast to unsigned char in usages of
8749 the ctype is*() functions. Replaced `end of command expected'
8750 calls to msg() with calls to syntax_error().
8752 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
8754 * lexer.c: (hex_val) Removed (was dead code).
8755 (idmatch) Parenthesize function name to avoid macro expansion.
8757 * postscript.c: Comment fixes.
8758 (ps_preopen_driver) Change default font size to 10pt.
8760 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
8762 (parse_format_spec) Change system-file format spec argument type
8763 to int32. Parse the format spec with bitwise operators.
8765 * sfmP.h: (struct sysfile_format) Removed.
8766 (struct sysfile_variable) Changed print, write members from
8767 sysfile_format to int32.
8769 * tokens.h: Esthetic fixes.
8770 [__GNUC__] (macro id_match) New macro to hopefully speed up
8771 identifier matching.
8772 (macros match_id, match_tok, match_int) Implemented in
8773 compiler-independent manner; no longer GNU C only.
8775 * vfm.h: Include time.h.
8777 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
8779 * data-list.c: (dump_fixed_table) Change tab_dim().
8781 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
8783 * error.c: Include command.h.
8785 * frequencies.g: Formatting fixes.
8787 * frequencies.q: Add tab_dim() calls. Make the total cell a
8790 * glob.c: Include command.h.
8792 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
8794 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
8795 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
8796 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
8797 the other elements (is this right?).
8798 (read_variables) Use lowest, highest members.
8799 (parse_format_spec) New arg `vv' for more stringent checking.
8800 (dump_dictionary) Byteswaps nonexplicit data.
8801 (sfm_read_case) Byteswap numeric data.
8803 * som.c: Initialize table_num to 1.
8804 (render_segments) Remember to increment y_index after each table
8807 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
8808 avl_count() on a NULL tree. No title for the second table.
8809 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
8810 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
8811 fix call to display_variables().
8812 (display_variables) Default to 4 columns, not 3. Set up headers.
8813 Column title is Variable, not Name. Fix index column.
8814 Add joint text. Add tab_dim(). Handle value labels properly.
8815 Handle DISPLAY LABELS properly. Draw boxes correctly.
8816 (describe_variable) Value labels don't need titles. Don't clear
8817 nonexistent index column.
8818 (compare_vectors_by_name) New function.
8819 (display_vectors) New function.
8821 * tab.c: (tab_height) Add assertion.
8822 (tab_null) Add debug code.
8823 (evaluate_dimensions) Add debug code.
8825 * var.h: (struct variable) get_proc data is sometimes used
8826 simultaneously with other per-procedure info, therefore it was
8827 removed from the union. All references changed.
8829 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
8831 * ascii.c: (ascii_close_page) Put title on second line of headers
8832 if there is no subtitle.
8834 * command.c: (glob var cur_proc) Move definition here, from
8836 (cmd_remark) Emit blank line before remarks.
8838 * command.h: (glob var cur_proc) Move declaration here, from
8841 * data-list.c: (dump_fixed_table) Fix messages.
8842 (dump_free_table) Call tab_nat_dim().
8844 * descript.q: (dump_z_table) Modify tab_dim() call.
8846 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8848 (dump_statistics) Don't output header.
8850 * groff-font.c: Minor format fix.
8852 * html.c: Comment fix.
8854 * list.q: (write_varname) Indent after advancing page.
8856 * output.h: Minor reordering.
8858 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8859 a reference to eol[].
8860 (struct ps_driver_ext) New member eol[].
8861 (ps_preopen_driver) Initialize eol[].
8862 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8863 defaults. Handle headers. Fix test for minimum page length.
8864 (static var option_tab[]) Add `line-ends'.
8865 (ps_option) Handle line-ends to change eol[].
8866 (postopen) Scale prop_em_width and fixed_width properly. Set the
8867 prologue title to outp_title if applicable. Replace the prologue
8868 line ends with eol[]. Call draw_headers() if headers are enabled.
8869 (text_width) New function.
8870 (out_text_plain) New function.
8871 (draw_headers) New function.
8873 * print.c: (dump_table) Call tab_nat_dim().
8875 * som.c: (som_blank_line) Only advance a line if not at the top of
8877 (som_submit) Move several informational table calls here.
8878 Increment subtable_num if SOMF_NO_TITLE not set.
8879 (output_table) Advance a line if SOMF_NO_SPACING not set.
8880 (render_columns, render_segments, render_simple) Handle spacing
8881 between tables. Handle table titles. Remove debug output.
8883 * som.h: (SOMF_*) New enum series.
8884 (struct som_table_class) New member `flags'.
8886 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8888 (display_variables) Calls tab_nat_dim().
8889 (describe_variable) Remove restriction on number of value labels.
8890 Make value labels separated by thin lines.
8892 * tab.c: (tab_create) Default `flags' to none.
8893 (tab_float) New arg `w'. All references changed.
8894 (tab_nat_dim) New function.
8895 (tab_output_text) No title or spacing.
8896 (tab_flags) New function.
8897 (tabi_flags) New function.
8898 (tabi_title) New function.
8899 (strip_height) Removed.
8900 (tabi_render) Skip title when necessary.
8901 (static var tab_tab_class) Add tabi_flags, tabi_title.
8902 (evaluate_dimensions) Disable display of column, row size.
8903 (sum_columns) Add title height to top header.
8904 (render_strip) Moved within file.
8906 * tab.h: (struct tab_table) New member `flags'.
8908 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8910 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8912 * Most source files: Add `const' attribute in all appropriate
8915 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8916 column to the variables table for use by describe_variable().
8917 (cmd_display) Disable for the present.
8918 (display_documents) Don't wrap documents.
8919 (display_variables) Table has four columns now.
8920 (describe_variable) Table has four columns now. Don't use a
8921 subtable, use joined cells instead.
8923 * tab.c: (tab_create) Don't set `join'.
8924 (tab_realloc) ct array is not made up of a_string's.
8925 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8926 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8927 (text_format) New function.
8928 (tab_title) Rewritten, uses text_format().
8929 (tab_text) Rewritten, uses text_format().
8930 (tab_joint_text) New function.
8932 (static var hit) New variable.
8933 (render_strip) New args r1, r2. Implement joined cells that fit
8935 (tabi_render) Increment hit. Pass new args to render_strip().
8936 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8937 cells. For t_naw and t_nah, ignore joined cells and null cells in
8940 * tab.h: (struct tab_join_rect) Removed.
8941 (struct tab_table) Removed `join'.
8942 (TAB_JOIN_MAIN) Removed.
8943 (struct tab_joined_cell) New struct.
8944 (TAT_NOWRAP) New enum.
8946 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8948 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8950 (ascii_postopen_driver) Fix initialization of *_spacing so that
8951 the TAL_0 bit doesn't count.
8953 * data-list.c: (dump_fixed_table) Use natural width for Format
8956 * glob.c: (rerange) Removed.
8957 (get_date) Formatting fixes. Internationalization fix.
8959 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8962 * postscript.c: (ps_postopen_driver) Replace
8963 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8965 * som.c: (som_submit) Don't eject page before every table.
8966 (output_table) Fix order of arguments on call to area().
8967 (render_columns) Fix calculation of max_len.
8969 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8970 (render_strip) New function.
8971 (strip_height) New function.
8972 (tabi_render) Rewrite as calls to render_strip().
8974 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8975 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8976 with the TAB_* and OUTP_T_* constants.
8978 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8980 * Makefile.am: Formatting fixes.
8982 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8985 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8987 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8989 * dump-sysfile.c: (glob var length) Make type off_t.
8990 (usage) Fix arguments.
8993 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8994 Now right-justification is the default so many references had to
8996 (struct outp_class) Removed line_width, all references changed.
8997 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8998 (struct outp_driver) Add elements horiz_line_width,
8999 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
9002 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
9004 (postopen) Initialize all the informational members of
9007 * som.c: (som_blank_line) New function, renamed from blank_line(),
9008 all references changed.
9009 (som_submit) Disables drivers whose pages can't be opened.
9010 (render_columns, render_simple, render_segments) Add debug output.
9011 (render_columns) Fix loop range.
9012 (render_simple) Don't try to render the headers, they're taken
9013 care of automatically. Advance cp_y past the table when done.
9014 (render_segments) Fix loop ranges.
9016 * tab.c: Initialize new members of tab_table.
9017 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
9018 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
9019 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
9022 (tab_dim) New function.
9023 (tab_col_width) Removed.
9024 (tab_row_height) Removed.
9025 (tab_output_text) Call tab_dim().
9026 (tabi_driver) Call evaluate_dimensions(), sum_columns().
9027 (tabi_area) Implemented.
9028 (tabi_cumulate) Implemented.
9029 (tabi_render) Partially implemented, but broken.
9030 (var tab_table_class) Made static.
9031 (evaluate_dimensions) New function.
9032 (sum_columns) New function.
9034 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
9035 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
9036 t_scr, t_srr, t_sentinel. Removed: t_nat.
9037 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
9038 max_stack_height, w, h. Removed: ce, re.
9039 (macro blank_line) Removed.
9040 (glob var zero_length) Removed.
9042 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
9044 * Most source files: include some of the new include files broken
9047 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
9050 * aggregate.c: (glob var outfile) Make static.
9052 * command.c: (glob var pgm_state) Move here.
9054 * common.c: (glob vars endian, second_lowest_value, pgmname,
9055 finished, curdate, cur_proc, start_interactive, history_file) Move
9058 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
9060 * file-handle.q: (glob vars files, inline_file) Move here.
9062 * glob.c: Lost lots of glob vars, detailed in individual file
9064 (init_glob) set_printer, set_screen were obsolete, deleted.
9065 set_cprompt has fewer spaces because pspp has fewer letters than
9068 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
9069 (inp_nval) Made static.
9071 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
9072 tokstr_len, toklongstr, tokint) Move here.
9074 * misc.c: Lost several vars and functions.
9076 * set.q: (all the set_* variables) Move here.
9078 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
9079 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
9082 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
9084 * tab.h: (enum series t_*) New enums.
9085 (struct tab_table) Use arena struct tag. New members ce, re.
9087 * tokens.h: Comment fixes.
9089 * var.h: Move lots of enums and variables and functions and
9090 structures to other files. Use and declare a lot more union and
9091 struct tags. Comment fixes.
9093 * vector.c: (glob vars vec, nvec) Move here.
9095 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
9096 init_blanks, last_vfm_invocation) Move here.
9098 * cases.h: New file.
9099 (struct long_vec) Move here.
9100 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
9103 * command.h: New file.
9104 (STATE_* enums) Move here.
9105 (glob var pgm_state) Move here.
9107 * format.c: New file.
9108 (glob var formats) Move here.
9109 (parse_format_specifier_name, fmt_to_string,
9110 check_input_specifier, check_output_specifier,
9111 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
9114 * format.h: New file. Move functions now in format.c here.
9115 (FMT_* enums) Move here.
9116 (struct fmt_desc) Move here.
9117 (FCAT_* enums) Move here.
9118 (struct fmt_spec) Move here.
9119 (glob vars formats, fmt_parse_ignore_error) Move here.
9121 * inpt-pgm.h: New file.
9122 (INP_* enums) Move here, make #defines into enums.
9123 (glob vars inp_init, inp_init_size) Move here.
9126 (glob vars v_sort, nv_sort) Move here.
9127 (sort_cases, read_sort_output) Move here.
9129 * vector.h: New file.
9130 (struct vector) Move here, add struct tag.
9131 (glob vars vec, nvec) Move here.
9132 (find_vector) Move here.
9135 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
9136 reinit_blanks, init_zero, init_blanks) Move here.
9137 (struct case_stream) Move here.
9138 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
9139 vfm_disk_stream, sort_stream, data_list_source,
9140 input_program_source, file_type_source, get_source, n_lag) Move
9142 (procedure, write_case, lagged_case, compact_case, page_to_disk)
9145 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
9147 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
9148 (LDADD) Add libdcdflib.
9150 * ascii.c: Comment and formatting fixes. Almost every external
9151 function had an assert added, checking driver_open and page_open.
9152 (ascii_init_driver) Broken into ascii_preopen_driver,
9153 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
9154 (ascii_open_page) Sets page_open.
9155 (ascii_close_page) Clears page_open.
9157 * html.c: Comment and formatting fixes. Almost every external
9158 function had an assert added, checking driver_open and page_open.
9159 (html_init_driver) Broken into html_preopen_driver,
9160 html_postopen_driver, html_close_driver. Manages driver_open.
9161 (html_open_page) Sets page_open.
9162 (html_close_page) Clears page_open.
9163 (html_submit) Disabled.
9165 * lexer.c: (parse_string) Remove debugging printf.
9167 * list.q: (determine_layout) Open a page if one is not yet open.
9169 * output.c: Comment fixes.
9170 (add_class) Set the class member of the new list element.
9171 (parse_options) Don't handle device type.
9172 (colon_tokenize) New function.
9173 (configure_driver) New four-field format with a field for device
9174 type. Now initialize driver_open, page_open, next, and prev
9175 fields. Use new colon_tokenize() function. Don't do a memory
9176 copy to replace a driver, it doesn't work; instead delete the old
9177 driver and insert a new one.
9178 (destroy_driver) Don't call som_destroy_driver(). Close the page
9179 if it's open. Find the class in the list of classes and decrement
9180 that reference count. Remove the driver from the global driver
9182 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
9183 references changed. Rewritten. Don't return a driver that's not
9185 (outp_eject_page) All references to som_internal_eject_page()
9186 changed to use this. Sets cp_x to 0 as well as cp_y.
9188 * output.h: (OUTP_I_* enums) Removed.
9189 (struct som_submission_form) Removed.
9190 (struct outp_class) init_driver broken into preopen_driver,
9191 postopen_driver, and close_driver. submit changed to take a
9194 * postscript.c: Comment and formatting fixes. Almost every
9195 external function had an assert added, checking driver_open and
9197 (ps_init_driver) Broken into ps_preopen_driver,
9198 ps_postopen_driver, ps_close_driver. Manages driver_open.
9199 (ps_open_page) Sets page_open.
9200 (ps_close_page) Clears page_open.
9202 * som.c: New file, base implementation.
9204 * som.h: (struct som_table) Add struct tag.
9205 (enum SOM_COL_ACROSS) Removed.
9206 (SOM_ROWS, SOM_COLUMNS) New enums.
9207 (struct som_table_class) Add member `cumulate'. Remove `segment';
9208 change `render' arguments.
9209 (struct som_point, struct som_rect) Removed.
9210 (som_submit_table) Fixed typo, should have been som_submit.
9212 * sysfile-info: (describe_variable) Don't try to insert a
9213 subtable; just destroy it for now.
9215 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
9216 references to value labels.
9218 * tab.c: (tab_destroy) New function.
9219 (tab_columns) Change argument.
9220 [0] (tab_submit) Remove dead code.
9221 (tab_title) Allocate string from the table's arena.
9222 (tab_output_text) Only free the buffer if we allocated it.
9223 (tab_submit) New function.
9224 (static vars t, d) New static vars.
9225 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
9226 tabi_headers, tabi_cumulate, tabi_render) New functions.
9227 (glob var tab_table_class) New global var.
9229 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
9230 encapsulate the rectangle. All references changed.
9232 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
9234 * All header files updated to use struct tags in addition to
9235 typedefs for all structures. Don't use word `struct' in struct
9238 * Makefile.am: (pspp_SOURCES) Remove html.c.
9239 (INCLUDES) Replace the lib/* includes with a single lib/ include;
9240 all references updated.
9242 * command.c: (parse_cmd) Remove call to som_check_workspace.
9243 (output_line) Update to new som.
9245 * data-in.c: (parse_numeric) A single dot is not an error; it is
9246 the system-missing value.
9248 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
9251 * data-out.c: Added `const' as appropriate to many prototypes.
9252 (convert_E, convert_F, convert_CCx) Take double argument instead
9253 of value * argument.
9254 (convert_format_to_string) Call changed functions appropriately.
9255 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
9256 make a local copy of the value.
9258 * descript.q: Remove custom_variables() prototype now provided by
9260 (custom_variables) Don't increment sbc_variables, the caller does
9262 (dump_z_table, display) Update to new som.
9264 * error.c: (vmsg) Add const to prototype. Remove code to handle
9265 `too many errors' condition.
9266 (check_error_count) New function.
9267 (msg) Add const to prototype.
9269 * filename.c: (open_file) Rewrite for elegance.
9271 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
9272 (dump_full, dump_condensed, dump_statistics) Update for new som.
9274 * list.q: Don't include somP.h. Change all references to
9275 som_driver_ext to refer to the new members of som_driver. Change
9276 som_internal_eject_page() references to outp_eject_page().
9278 * main.c: (parse) Rewrite for elegance. Add call to
9279 check_error_count().
9281 * output.c: (add_class, outp_list_classes, outp_configure_driver)
9282 Rewrite or revise for new outp_driver_class_list structure.
9283 (outp_iterate_enabled_drivers) Fix comparison between disabled
9284 devices and current device type.
9285 (outp_eject_page) New function.
9287 * output.h: Comment fixes.
9288 (struct outp_driver) New members driver_open, page_open, cp_x,
9289 cp_y, font_height, prop_em_width, fixed_width. Deleted members
9291 (struct outp_driver_class_list) New struct.
9292 (outp_class_list) Changed to type outp_driver_class_list; all
9295 * print.c: (dump_table, print_trns_proc) Updated for new som.
9297 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
9298 prototypes for custom subcommands.
9299 (dump_subcommand) Always include the `else'.
9300 (dump_parser) Fix comments in output code.
9302 * set.q: Reordered functions.
9304 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
9306 * som.h: Rewritten from scratch.
9308 * str.h: Remove dead code.
9310 * tab.c, tab.h: New files, base implementation.
9312 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
9315 * t-test.q: New code from John Williams
9316 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
9317 Many many new static vars and defines.
9318 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
9319 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
9320 (struct value_list) New struct.
9321 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
9322 t_crt, t_sig, print_t_groups) New functions.
9323 (cmd_t_test) Implemented.
9325 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
9328 * vfm.c: (dump_splits) Update to new som.
9330 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
9332 * Makefile.am: (fiasco_SOURCES) Add html.c.
9334 * aggregate.c: Base source.
9336 * ascii.c: (postopen, preclose) Reformat.
9338 * data-out.c, expr-evl.c: Comment fixes.
9340 * filename.c: (open_file) When opening a file for writing, use
9341 line buffering instead of full buffering for better interactive
9342 performance. Suggested by Valerio Aimale
9343 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
9344 names `stdin', `stdout', `stderr'.
9346 * groff-font.c: Comment fixes.
9348 * html.c: New file; base version.
9350 * list.q: (write_all_headers, clean_up, determine_layout,
9351 list_cases) Ignore `special' devices for now. Needs to be fixed
9354 * output.c: (outp_init) Add html driver to list; reverse list
9357 * output.h: (struct outp_class_struct) New members `special',
9358 `submit'; comment fixes. All references changed.
9360 * postscript.c: (ps_init_driver) Make defaults for text_opt,
9361 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
9363 (postopen) Comment fix.
9364 (preclose) Comment fixes, formatting fixes. Change x->file.file
9365 references to more proper f->file.
9367 * som-high.c: (som_submit_table) Special classes use their own
9370 * som.h: Comment fixes.
9372 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
9375 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
9377 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
9379 * aggregate.c: Still working on this.
9381 * command.c: (cmd_table[]) Add AGGREGATE back in.
9382 (split_words) Make '-' a legal word separator as well as ' '.
9384 * main.c: Comment fixes.
9386 * q2c.c: (dump_parser) Don't require the procedure's full name to
9387 be present, in the generated source.
9389 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
9390 multiply specified and let it be default; let MISSING, CRITERIA,
9391 FORMAT be multiply specified.
9392 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
9393 (custom_groups) Fix defaults.
9394 (custom_pairs) Check whether this is a PAIRS subcommand before
9395 attempting to parse. Better garbage collection. Proper storage
9397 [DEBUGGING] (debug_print) New function.
9399 * temporary.c: Comment fixes.
9400 (copy_variable) Don't copy variable name and index.
9401 (save_dictionary) Copy variable name and index by hand.
9403 * vars-atr.c: Comment fixes.
9404 (create_variable) New dictionary argument. All references
9406 (common_init_stuff) New dictionary argument. All references
9408 (init_variable) New dictionary argument. All references changed.
9409 (dup_variable) New function.
9411 * vars-prs.c: (parse_variables) If there are any errors, we always
9412 return 0. Previously, it was possible for some types of errors to
9415 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
9417 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
9420 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
9422 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
9425 * q2c.c: Comment fixes.
9426 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
9428 * t-test.q: (cmd_list) Rename cmd_t_test.
9430 * temporary.c: (new_dictionary) Don't declare as static.
9432 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
9434 * aggregate.c: Changes, still not finished.
9436 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
9438 * q2c.c: Comment fixes. Now its output is internationalized.
9439 (get_token) Fix parsing of escapes within literal strings.
9440 (main) Fix bad #line directives in output.
9442 * t-test.q: Base implementation.
9444 * temporary.c: (new_dictionary) New function.
9445 (restore_dictionary) [__CHECKER__] Change fill character to *
9448 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
9450 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
9452 * aggregate.c: Changes, still not finished.
9454 * descript.q, list.q: Comment fixes.
9456 * q2c.c: Almost completely rewritten.
9458 * t-test.q: New file, not complete.
9460 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
9462 * aggregate.c: Changes, still not finished.
9464 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
9467 * temporary.c: (cancel_temporary) New function.
9469 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
9470 of doing it by hand.
9472 * vfm.c: (close_active_file) After restoring a TEMPORARY
9473 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
9475 (SPLIT_FILE_procfunc) Comment fix.
9477 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
9479 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
9481 * aggregate.c: New file, not finished yet.
9483 * command.c: (cmd_table) Add AGGREGATE.
9485 * common.h: (pgm_state) Move declaration to var.h.
9487 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
9489 (parse_string) Message fix.
9491 * recode.c: Comment fix.
9493 * sfm-read.c: (read_variables) Code esthetic fixes.
9494 (write_header) Default date is `Jan', not `JAN'.
9496 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
9498 * sort.c: (cmd_sort_cases) Farm the work out to new function
9499 parse_sort_variables().
9500 (parse_sort_variables) New function.
9501 (sort_cases) New function. Cancels temporary transformations,
9502 which sorting didn't do previously.
9503 (cmd_sort_cases) Better garbage collection on error. Uses
9505 (write_initial_runs, merge_once) Improved code esthetics.
9506 (sort_stream_read) Reduced to one call to read_output_cases().
9507 (read_output_cases) New function.
9509 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
9510 variable labels to 120 characters.
9512 * var.h: Comment fixes.
9513 (glob var pgm_state) From common.h.
9515 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
9517 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
9518 options. Set *names to NULL on error.
9520 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
9522 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
9524 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
9525 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
9527 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
9529 * vfm.c: (page_to_disk) Added missing local variables.
9531 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
9533 * get.c: Comment fix.
9535 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
9536 source is anything other than a disk stream, not just if it's in a
9537 memory stream. Call page_to_disk() before external sort.
9538 (allocate_cases) Message fix.
9540 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
9542 (page_to_disk) New function.
9544 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
9546 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
9548 * common.h: (macro strerror) Remove. From Alexandre Oliva
9549 <oliva@dcc.unicamp.br>.
9551 * get.c: (dict_delete_run) The number of variables to delete is
9552 not necessarily the number of variables that need to be shifted
9554 (trim_dictionary) Don't set *options to 0. Fix bug that caused
9555 too many variables to be deleted.
9557 * postscript.c: Comment fix.
9559 * q2c.c: Include strerror.c. From Alexandre Oliva
9560 <oliva@dcc.unicamp.br>.
9562 * set.q: #undef ON and OFF. From Alexandre Oliva
9563 <oliva@dcc.unicamp.br>.
9565 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
9566 early, otherwise errors cause a bad free().
9568 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
9569 Oliva <oliva@dcc.unicamp.br>.
9571 * temporary.c: (save_dictionary) Don't allocate memory if
9574 * vfm.c: (memory_stream_write) Message fix.
9576 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
9578 * command.c: (static var cmd_table[]) Define REPEATING DATA
9581 * common.h: Added support for broken systems that are missing
9582 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
9584 * Many source files: Replace syntax error messages via msg() with
9585 call to syntax_error().
9587 * data-list.c: (dump_fixed_table) Add support for dumping table
9588 for REPEATING DATA as well as DATA LIST FIXED.
9589 (cmd_repeating_data) Allows and requires `/' between subcommands.
9590 Does proper thing with allowing rpd.starts_end to stay 0. Allows
9591 CONTINUED specifications to be omitted. Forces CONTINUED to be
9592 specified if ID is. Calculates starts_end, cont_end from logical
9593 record length as reported by fhp. Calls dump_fixed_table() if
9594 requested. Fixed length of record copied by memcpy.
9595 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
9597 (realize_value) Returns sensible value for out-of-range variable
9599 (rpd_parse_record) New argument `ofs'. Fixed confusion between
9600 length of occurrences and length of line. Added warning for
9601 fields that exceed the line length. Fixed infinite loop.
9602 (read_one_set_of_repetitions) Numerous minor changes for more
9603 complete SPSS compliance. Message fixes.
9605 * dfm.c: (dfm_close) If the file being closed is the inline file,
9606 read all the remaining data before closing it.
9607 (dfm_get_record) Don't close the file on lossage, as either it
9608 has been closed already or it doesn't belong to us.
9610 * error.c: (puts_stdout) New function.
9611 (vmsg) Use puts_stdout instead of puts.
9613 * file-handle.q: (fh_record_width) New function.
9615 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
9618 (input_program_source_read) Made an old kluge an approved method.
9620 * lexer.c: (syntax_error) New function.
9622 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
9625 * output.c: (oupt_get_paper_size) Message fix.
9627 * q2c.c: Numerous fixes to formatting of generated code made to
9628 conform to GNU coding standards. Uses syntax_error() in generated
9629 code. Other miscellaneous generated message fixes. Added support
9630 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
9631 RAND_MAX, and/or strerror().
9633 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
9635 * data-in.c: Comment fixes.
9637 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
9638 (find_variable_input_spec) New function.
9639 (cmd_repeating_data) Initializes id_spec.
9640 (rpd_parse_record) Implemented.
9641 (read_one_set_of_repetitions) Returns -3 by default in order to
9642 kluge out some potential bugs.
9644 * data-out.c: Comment fixes.
9646 * file-type.c: (internal_cmd_record_type) Message fix.
9648 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
9649 for handling -3 return value.
9651 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
9653 * data-list.c: Comment fixes.
9654 (struct dls_var_spec) Reordered members.
9655 (read_from_data_list_fixed) Restructured.
9656 (struct repeating_data_trns) Reordered members. Renamed `starts'
9657 as `starts_beg', `ends' as `starts_end'.
9658 (cmd_repeating_data) Calculates length of repeated data if
9659 necessary and possible.
9660 (parse_num_or_var) Don't allow string variables.
9661 (realize_value) New function.
9662 (rpd_msg) New function.
9663 (rpd_parse_record) New function. Currently stubbed out.
9664 (read_one_set_of_repetitions) Implemented.
9666 * inpt-pgm.c: (input_program_source_read) Comment fix.
9668 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
9670 * command.c: (cmd_end_repeat_p) Removed.
9671 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
9672 (parse_cmd_name) Removed.
9674 * data-list.c: Comment fixes.
9675 (data_list_pgm) Removed `eof' member.
9676 (static var first) New var.
9677 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
9678 FILE TYPE file inside FILE TYPE structures.
9679 (append_var_spec) Appends to *first, not dls.spec.
9680 (parse_fixed) Message fixes.
9681 (struct rpd_num_or_var) New.
9682 (struct repeating_data_trns) New.
9683 (static var rpd) New.
9684 (cmd_repeating_data) New function.
9685 (parse_num_or_var) New function.
9686 (parse_repeating_data) New function.
9687 (read_one_set_of_repetitions) New function.
9689 * file-type.c: (cmd_file_type) Message fixes. Always
9690 default_handle to FILE TYPE file handle.
9691 (internal_cmd_record_type) Message fixes.
9693 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
9695 * repeat.c: Comment fix. Disable debugging.
9697 * temporary.c: (restore_dictionary) Sets splits to NULL and
9698 n_splits to 0 before destroying the variables because now doing
9699 this tries to remove split variables.
9701 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
9702 destroying the dictionary.
9703 (clear_variable) Removes a variable from splits after destroying
9706 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
9708 * cmdline.c: (set_compat) Removed.
9709 (pick_compat) Removed.
9710 (parse_command_line) Removed -c option.
9711 (pre_syntax_message) Removed -c option.
9712 (usage) Remove compatibility code.
9714 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
9715 (glob var compat) Removed.
9717 * compute.c: (type_check) Fixed messages about type mismatches.
9719 * data-list.c: (cmd_data_list) Removed compatibility code.
9720 (fixed_parse_compatible) Calls convert_negative_to_dash().
9721 Fixed bug where it only set the variable in fx.spec if it created
9722 the variable itself.
9723 (dump_fmt_list) Spelling fix.
9724 (cut_field) Removed compatibility code.
9726 * dfm.c: (cmd_begin_data) Don't require a command terminator on
9729 * expr-evl.c: (evaluate_expression) Implement LAG.
9731 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
9732 (parse_neg) Calls convert_negative_to_dash().
9733 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
9736 * expr.h: (struct expression_struct) Removed member max_lag.
9738 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
9739 (internal_cmd_record_type) Removed special handling to produce
9740 negative numbers from dash tokens.
9742 * getline.c: (static var DO_REPEAT_level) New var.
9743 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
9744 (handle_line_buffer) Copies the line into getl_buf; doesn't call
9745 copy_with_DO_REPEAT_substitutions().
9746 (getl_read_line) Maintains value of getl_mode. Calls
9747 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
9749 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
9751 * getline.h: (getl_mode) New glob var.
9753 * glob.c: Comment fixes.
9754 (init_glob) Restructured. Sets set_seed.
9755 (init_compat_dependent) Removed. All references removed.
9756 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
9757 (__htonl, __htons) Removed. (What were these for?)
9759 * lexer.c: (static var tbl) Dash set to class CNUM.
9760 (make_hexit) New function from data-out.c.
9761 (get_token_representation) Rewritten.
9762 (convert_negative_to_dash) New function.
9763 (lex_init_compat_dependent) Removed.
9764 (yylex) A dash is parsed as part of a number if it is followed by
9765 a digit. The ASCII representation of a number is copied to
9766 tokstr. String parsing farmed out to parse_string(). Comment
9768 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
9770 (preprocess_line) Line processing depends on interactive/batch
9771 mode, not on compatibility mode. Removed PC+ compatibility code.
9773 * loop.c: (loop_3_trns_proc) Comment fix.
9775 * main.c: Remove dead code.
9776 (main) Remove call to init_compat_dependent().
9778 * misc.c: (convert_fmt_ItoO) Make E format conversion more
9781 * print.c: (parse_string_argument) Calls
9782 convert_negative_to_dash().
9783 (fixed_parse_compatible) Calls convert_negative_to_dash().
9785 * repeat.c: (RPT_* defines) Removed.
9786 (struct rpt_numeric) Removed.
9787 (struct repeat_entry) New member type, changed `replacement' from
9789 (clean_up) Deallocation adapted to new repeat_entry.
9790 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
9791 usage. Creates vars for `type' of 1.
9792 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
9793 (store_numeric) Rewritten, new interface.
9794 (parse_numbers) Rewritten.
9795 (parse_strings) Rewritten.
9796 (find_DO_REPEAT_substitution) New function.
9797 (perform_DO_REPEAT_substitutions) New function.
9798 (copy_with_DO_REPEAT_substitutions) Removed.
9799 (debug_print) Rewritten.
9801 * set.q: Comment fix.
9802 (custom_results) Removed compatibility code.
9803 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
9806 * sysfile-info.c: (cmd_display) Removed compatibility code.
9808 * tokens.h: Comment fixes.
9809 (token types enum) Removed `toktype' typedef name for this int
9810 type. Removed SUBST. Restructured.
9812 * vars-atr.c: (discard_variables) Sets n_lag to 0.
9814 * vars-prs.c: Comment fix.
9816 * vfm.c: Comment fixes.
9817 (glob var n_lag) New var.
9818 (static vars lag_count, lag_head, lag_queue) New vars.
9819 (procedure) Removed argument nlag.
9820 (setup_lag) New function.
9821 (close_active_file) Discards lagging state.
9822 (lag_case) New function.
9823 (lagged_case) New function.
9824 (write_case) Lags a case if lagging.
9826 * weight.c: (cmd_weight) Removed compatibility code.
9828 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
9830 * getline.h: (struct getl_script) New members loop_index, macros.
9832 * getline.c: (getl_add_file) Sets first_line field to NULL.
9833 (getl_add_DO_REPEAT_file) New function.
9834 (handle_line_buffer) When the current line's length is negative,
9835 set the filename and line number. Increment line number after
9836 reading line. Pass the line to
9837 copy_with_DO_REPEAT_substitutions() for processing.
9838 (getl_close_file) Free DO REPEAT lines before freeing the
9839 filename, and just set the filename to NULL when doing this,
9840 because otherwise the filename gets freed twice.
9842 * glob.c: (glob var queuing) Removed. All references removed.
9844 * lexer.c: Comment fixes.
9845 (get_token_representation) New function.
9847 * repeat.c: Comment fixes.
9848 (struct repeat_entry) Replaced type and v union members with a
9850 (append_record) New function.
9851 (internal_cmd_do_repeat) Started reforming it for the new
9852 repeat_entry struct. Properly records filename changes in the
9853 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9854 strncasecmp() result usage. Uses append_record() to simplify.
9855 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9858 (copy_with_DO_REPEAT_substitutions) Started coding.
9860 [DEBUGGING] (debug_print_lines) New function.
9862 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9864 * tokens.h: (macro is_id1, is_idn) New macros.
9866 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9868 * cmdline.c: (static var pre_syntax_message) Changed `win'
9869 compatibility mode to `wnd'.
9871 * data-list.c: (fixed_parse_spss) Renamed
9872 fixed_parse_compatible().
9874 * glob.c: (init_glob) Excise unused code for
9875 program_invocation_short_name.
9877 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9880 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9882 * set.q: `win' compatibility renamed `wnd'.
9884 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9886 * filename.c: [__WIN32__] Change the included Windows header files
9888 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9889 second character is absolute.
9890 (dirname) Fix logic error. Don't printf() the results.
9891 (prepend_dir) Don't printf() the results.
9893 * getline.c: (handle_line_buffer) New function.
9894 (getl_read_line) Reads line with handle_line_buffer() when
9896 (getl_close_file) Discard line buffer data.
9898 * getline.h: Comment fixes.
9899 (struct getl_line_list) New struct.
9900 (getl_script_struct) Added line buffer members. These are hooks
9901 for use by DO REPEAT to allow it to insert virtual source code
9904 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9905 Override Borland C++ stupidity that claims Windows has a console
9908 * repeat.c: This is in the process of being restructured from
9909 using a token-buffering approach to the DO REPEAT facility to
9910 using the more flexible approach of a line-buffering approach in
9911 conjunction with the getline module. Comment fixes.
9912 (struct tok_struct) Removed.
9913 (static vars queue_index, queue_head, queue) Removed.
9914 (static vars line_buf_head, line_buf_tail) New vars.
9915 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9917 (pull_queue, destroy_queue) Removed.
9918 [DEBUGGING] (debug_print_tokens) Removed.
9920 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9922 * file-handle.q: (prepend_current_directory) New function.
9923 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9924 current directory before normalizing filename.
9926 * filename.c: (gnu_getcwd) New function.
9927 (absolute_filename_p) New function.
9928 (search_path) New argument, PREPEND. All references changed to
9929 pass NULL except those explicitly mentioned. Uses
9930 absolute_filename_p(). Prepends PREPEND before trying the
9932 (dirname, prepend_dir) New functions.
9934 * getline.c: (getl_get_current_directory) New function.
9935 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9938 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9940 * In several source files, the term `script' was replaced with
9941 `syntax file' inside error messages. Usage of the term `script'
9942 in the sense of a syntax file is now deprecated.
9944 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9947 * dump-sysfile.c: (usage) Update message.
9949 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9951 * getline.h: (glob var getl_include_path) Declare extern.
9953 * list.q: Define EXTERN as extern before #including somP.h.
9955 * var.h: Remove declaration of `disptype' variable.
9957 * vfm.c: (close_active_file) After switching the data sink to a
9958 data source, set vfm_sink to NULL, because it doesn't exist any
9961 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9963 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9964 _matherrl() to ignore all math errors.
9966 * sfm-read.c: (read_value_labels) When reading the labels from
9967 disk, read the little parts separately instead of as a struct;
9968 this avoids alignment problems.
9970 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9971 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9972 (write_header) Allocates and initializes elem_type.
9973 (sfm_write_case) Uses elem_type to determine how to handle each
9975 (sfm_close) Frees elem_type.
9977 * sfmP.h: Comment fix.
9978 [__BORLANDC__] Uses #pragma -a to adjust structure member
9981 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9983 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9985 * common.c: Fix typo.
9987 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9988 sense of the condition.
9990 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9991 line-continuation backslash.
9993 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9995 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9996 non-constant expression as an argument to sizeof.
9998 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9999 undefine gettext macro because that's a conio function.
10001 * hash.h: (hsh_prime_tab declaration) Remove.
10003 * list.q: (write_fallback_headers) Move `leader' allocation out of
10004 main loop. Change to local_alloc() allocation.
10006 * output.h: Formatting fixes. Put __attribute__ in right place on
10007 function prototypes.
10009 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
10010 incorrect `SECOND_LOWEST_VALUE' references to proper
10011 `second_lowest_value'.
10013 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
10014 value. This way 2 out of 3 of the som files define the vars
10015 extern, the correct way, that actually works under BC++.
10016 (som_set_float) Don't use nonconstant initializers for a struct.
10018 * som-high.c: Add the standard alloca() header.
10019 (replicate_table) Add prototype.
10021 Merged DISPLAY routine.
10022 * sysfile-info.c: (AS_*) New enum series.
10023 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
10025 (cmd_display, display_macros, display_documents,
10026 display_variables) Stolen from defunct display.c.
10027 (describe_variable) New function.
10029 * temporary.c: [0] (display_tree) New debug function.
10030 (copy_variable) Performs shallow copy of value labels instead of
10031 deep copy; i.e., just copys the AVL tree and increments the
10034 * val-labs.c: Comment fixes.
10035 (do_value_labels) Optionally skip leading forward slash.
10036 (get_label) Creates only a single value label instead of many
10037 copies of one, and sets the reference count.
10039 * display.c: Removed.
10041 * dump-sysfile.c: New file, not yet complete.
10043 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
10045 For lots of source files I added more verbose_msg's. These aren't
10046 listed below as they have tested as being benign. In some cases
10047 these replaced debug_printf() calls.
10049 * output.c: (outp_read_devices) Message fix.
10051 * postscript.c: (output_encodings) Message fix. Reports errors on
10053 (postopen) Message fix.
10055 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
10057 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
10059 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
10062 * main.c: Remove <malloc.h> #include.
10064 * mis-val.c: (parse_numeric) Set .f member for each missing[]
10065 instead of trying to just set the missing[] itself, which is a
10066 gcc-specific idiom.
10068 * sfm-read.c: (read_variables) Same.
10070 * str.h: Add memmem() prototype.
10072 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
10074 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
10076 * Makefile.am: (q2c) Don't include any libraries in the link.
10078 * dfm.c: (force_line_buffer_extension) New macro.
10079 (count_tabs) New function.
10080 (tabs_To_spaces) New function.
10081 (read_record) Calls tabs_to_spaces() on the line being processed.
10083 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
10084 have to be compiled twice (once for CC, once for LOCAL_CC).
10086 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
10088 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
10089 (LDADD) Add @INTLLIBS@.
10090 (q2c) Add LIBS, @INTLLIBS@ to link step.
10092 * inpt-pgm.c: Turn off debugging.
10094 * postscript.c: (postopen) Format fix. local_free() blocks
10095 returned by local_alloc(); don't free() them.
10097 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
10099 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
10102 * data-list.c: (read_from_data_list_fixed) Pass proper value for
10103 LEN arg, not simply the full string length.
10105 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
10106 directories before generic temp file directories.
10108 * vfm.c: Disable debugging.
10110 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
10112 * get.c: Comment fix.
10113 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
10115 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
10117 * expr-prs.c: (debug_print_postfix) Conditionally included on
10118 GLOBAL_DEBUGGING. Removed out_header() reference.
10120 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
10122 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
10124 * ascii.c: Removed obsolete ascii_close_page() prototype.
10126 * command.c: (output_line) Comment fix.
10128 * data-in.c: Formatting fix.
10129 (parse_string_as_format) Now the `fc' argument is used only for
10130 the purpose of error messages; it is not an index into the string
10131 passed. All references changed.
10133 * data-list.c: Comment fix.
10134 (cut_field) Comment fix. Now returns the column number of the
10135 position of the field cut out on success.
10136 (parse_field) Added `column' argument. Puts the column numbers in
10138 (read_from_data_list_free, read_from_data_list_list) Record the
10139 column number returned by cut_field(), pass it to parse_field().
10141 * dfm.c: Comment fix.
10143 * do-ifP.h: Comment fix.
10145 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
10146 the SYSMIS function.
10148 * expr.h, exprP.h: Comment fix.
10150 * glob.c: (init_glob) Only calls setlocale() and family if
10153 * hash.h: Comment fix.
10155 * include.c: Comment fix.
10157 * output.c: Comment fix.
10159 * postscript.c: (ps_line_intersection) Simplified assertion.
10161 * repeat.c: Comment fix.
10163 * vars-atr.c: Comment fix.
10165 * vars-prs.c: Comment fix.
10167 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
10168 behavior with usage of postincrement.
10169 (memory_stream_read) Discards cases as it goes.
10171 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
10173 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
10176 * Most source files: Includes debug-print.h, related comment
10179 * cases.c: (alloc_val) Removed complex allocation code. Merely
10180 increments default_dict.nval and returns the former value.
10181 (envector, devector) Removed references to lv member of struct
10184 * common.h: (macro VME) Replaced complex definition with simple
10187 * data-list.c: (cmd_data_list) Sets vfm_source instead of
10188 read_active_file and cancel_input_pgm.
10189 (read_from_data_list, cancel_data_list) Removed.
10190 (data_list_source_read, data_list_source_destroy_source) New
10192 (glob var data_list_source) New var.
10194 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
10195 (cmd_begin_data) Improved criteria for an input program accessing
10196 the inline file. Still not perfect.
10198 * do-if.c: (do_if_trns_proc) Simplified debug output.
10200 * expr-prs.c: Comment fixes.
10201 [DEBUGGING] (debug_print_postfix) Simplified debug output.
10203 * file-handle.q: (fh_close_handle) Simplified debug output.
10205 * file-type.c: Comment fixes.
10206 (cmd_file_type) Sets vfm_source instead of read_active_file and
10208 (cmd_end_file_type) On failure, discards variables in place of
10209 just canceling the input program.
10210 (read_from_file_type) Renamed file_type_source_read.
10211 (cancel_file_type) Renamed file_type_source_destroy_source.
10212 (glob var file_type_source) New var.
10214 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
10215 (cmd_get) Initializes options to GTSV_NONE before passing to
10216 trim_dictionary(). Removed `lv' reference. Sets vfm_source
10217 instead of read_active_file and cancel_input_pgm.
10218 (cmd_save_internal) Initializes options before passing to
10219 trim_dictionary(). Local var `nval' removed.
10220 (dict_delete_run) Comment fixes.
10221 (trim_dictionary) Comment fixes. Disallows scratch variables if
10222 GTSV_OPT_SAVE set in options.
10223 (read_from_get) Renamed get_source_read.
10224 (cancel_get) Renamed get_source_destroy_source.
10225 (glob var get_source) New var.
10227 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
10228 read_active_file and cancel_input_pgm.
10229 (read_from_input_program) Renamed input_program_source_read.
10230 Simplified debug output.
10231 (cancel_input_program) Renamed
10232 input_program_source_destroy_source.
10233 (glob var input_program_source) New var.
10235 * loop.c: (loop_1_trns_proc) Simplified debug output.
10237 * main.c: (dump_token) Made eof output more explicit.
10239 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
10242 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
10243 code for always-memory or always-disk cases. malloc's case-list
10244 based on vfm_source_info.ncases. Explicit support for
10245 memory_stream via memory_source_cases.
10246 (do_external_sort) Sets vfm_source instead of read_active_file and
10248 (allocate_file_handles) The temporary directory permissions are
10249 set to 0700 instead of 0777.
10250 (allocate_cases) Formatting fixes. Simplified debug output.
10251 (output_record) Compacts the case if necessary before writing it
10253 (close_handle, open_handle_w) Simplified debug output.
10254 (write_initial_runs) Destroys vfm_sink, then sets it to
10255 sort_stream. Writes records to memory based on
10256 vfm_sink_info.case_size.
10257 (write_to_sort_cases) Renamed sort_stream_write().
10258 (merge) Simplified error handling. Simplified debug output.
10260 (read_from_external_sort) Renamed sort_stream_read().
10261 Reads records based on vfm_source_info.case_size.
10262 (sort_stream_write) Writes records to memory based on
10263 vfm_sink_info.case_size.
10264 (sort_stream_mode) New function.
10265 (glob var sort_stream) New variable.
10267 * temporary.c: (cmd_temporary) Simplified debug output.
10268 (copy_variable) Removed references to `lv'.
10270 * title.c: (get_title) Simplified debug output.
10272 * var.h: Comment fixes.
10273 (struct get_proc) Removed member `lv'.
10274 (struct variable) Removed member `lv'. Comment fixes.
10275 (glob vars read_active_file, write_active_file, cancel_input_pgm)
10277 (struct case_stream) New.
10279 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
10280 read_active_file references to use vfm_source.
10281 (init_variable, replace_variable) Removed references to `lv'.
10283 * vfm.c: Comment fixes.
10284 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
10286 (static var queue, qh, qt, n_lag) Removed. All references
10288 (glob var compaction_necessary, compaction_nval, compaction_case,
10289 paging) New variables.
10290 (record_case) Removed.
10291 (procedure) Comment fixes. Calls vfm_source->read() instead of
10292 read_active_file().
10294 (prepare_for_writing, arrange_compaction, make_temp_case,
10295 vector_initialization, setup_filter) New function.
10296 (open_active_file) Most of the code moved into the abovementioned
10297 new functions. Now sets temp_dict to &default_dict if there is no
10298 temporary dictionary, for convenience. New debug output.
10299 (close_active_file) Deals with changing the sink to the source.
10300 Calls finish_compaction(). Frees compaction_case. Mostly
10302 (glob vars disk_source_file, disk_sink_file) New vars.
10303 (destroy_active_file, read_from_memory) Removed.
10304 (disk_stream_init, disk_stream_read, disk_stream_write,
10305 disk_stream_mode, disk_stream_destroy_source,
10306 disk_stream_destroy_sink) New functions.
10307 (glob var vfm_disk_stream) New var.
10308 (glob vars memory_source_cases, memory_sink_cases,
10309 memory_sink_iter, memory_sink_max_cases) New vars.
10310 (memory_stream_init, memory_stream_read, memory_stream_write,
10311 memory_stream_mode, memory_stream_destroy_source,
10312 memory_stream_destroy_sink) New functions.
10313 (glob var vfm_memory_stream) New var.
10314 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
10315 named `more_cases'. Simplified debug output. Otherwise mostly
10317 (record_case) Moved into the stream drivers. Removed.
10318 (transform) Removed (was dead code).
10319 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
10320 common case that the splits don't change, we don't need to copy
10321 the case into prev_case again--pointless.
10322 (compact_case) New function.
10323 (finish_compaction) New function.
10325 * vfmP.h: Comment fixes.
10326 (DEV_* enum series) Removed.
10327 (struct storage) Renamed `stream_info'. Removed variant record.
10328 Removed `device' member.
10330 * debug-print.h: New file.
10332 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
10334 * autorecode.c: Turned off debugging.
10336 * data-list.c: (destroy_dls) Closes the associated file handle.
10338 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
10339 parse_variables() options.
10341 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
10343 * display.c: (display_variables) Really fixed null cell bug.
10345 * file-handle.q: (fh_close_handle) Changed debugging message.
10347 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
10348 parse_variables() options.
10350 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
10351 (cmd_list) Fails if no variables specified.
10352 (determine_layout) Writes blank lines manually.
10354 * loop.c: (loop_1_trns_proc) Made debugging code only print
10355 messages if debugging.
10357 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
10358 parse_variables() arguments.
10359 (main) Parses optional parenthesized options to varlist
10360 subcommands into sbc->message.
10362 * sfm-read.c: Format fix.
10364 * var.h: (FV_*) New enum series.
10365 (PV_*) New enum PV_NO_SCRATCH.
10367 * vars-prs.c: (find_var) Removed.
10368 (fill_all_vars) Takes FV_* enum instead of boolean third
10369 argument. Rewritten to deal with scratch as well as system
10371 (parse_variables) Error message on scratch variable if
10374 * vfm.c: (static var virt_begin_func) New var.
10375 (procedure) Sets up virt_begin_func.
10376 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
10377 after dump_splits(). For succeeding groups changes, calls
10378 virt_begin_func() instead of begin_func().
10380 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
10382 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
10385 * dfm.c: Added some debugging messages, disabled by default.
10386 (open_file_r) Fixed error message.
10387 (read_record) On eof on inline_file, instead of calling
10388 fh_close_handle(), simply jump to eof label like a normal file.
10391 * display.c: Thin lines between rows for certain kinds of
10392 listing. Fixed `null cell' bug.
10394 * error.c: (failure) Flush stdout, stderr before failing.
10396 * file-handle.q: (fh_close_handle) Added debugging message.
10398 * frequencies.q: (dump_full) Bottom line extends across entire
10399 table width. Changed title formatting.
10400 (dump_condensed) Changed title formatting.
10401 (dump_statistics) Fixed title formatting.
10403 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
10404 Sets default value of set_format.
10406 * list.q: (cmd_list) Calls blank_line() before determine_layout().
10407 Passes write_all_headers() to procedure() as pre-group func.
10408 (write_all_headers) New function.
10409 (determine_layout) Removed calls to write_header().
10410 Calls blank_line() before and after write_fallback_headers().
10412 * recode.c: (recode_trns_free) Only attempts to free head->map if
10415 * sfm-read.c: (read_variables) Allows `#' at beginning of system
10416 file variable names but gives a warning. Sets `left' based on
10417 first character being/not being `#'. On lossage frees dict->var.
10419 * som-high.c: (som_draw_title) Simplified title formatting.
10421 * vfm.c: (dump_splits) Fixed and changed splits formatting.
10423 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
10425 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
10426 beginning. Frees v_src, v_dest on successful exit. Frees
10427 h_trans[*], h_trans on lossage.
10428 (recode) Frees h_trans[*], h_trans.
10430 * dfm.c: (dfm_close) Formatting change.
10431 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
10432 longer allocates its own in inline_file.
10433 (open_file_r) Passes the local dfm_fhuser_ext to
10434 open_inline_file().
10435 (open_file_w) Message fix.
10436 (read_record) Buffer reallocation strategy changed. Frees
10437 ext->line even in inline_file to prevent leaks.
10438 (dfm_put_record) Fixed bug where `ext' was cached before the file
10439 was opened and thus it would be NULL when the file really was
10441 (cmd_begin_data) Sets up inline_file basics itself, then calls
10442 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
10444 * list.q: (write_line) Formatting fix.
10445 (clean_up) Minor strategy change. Sets proportional font after
10447 (determine_layout) Sets fixed font before writing regular headers,
10448 or after writing fallback headers.
10450 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
10451 and KEEP vars after using them.
10453 * postscript.c: (ps_init_driver) Frees x->family.
10454 (postopen) When loading fonts, free the temporary font name buffer
10456 (ps_text_set_font_by_position) Free temporary font name buffer
10458 (text) Fixed code that calculated `lig' so that `lig' always gets
10459 initialized. Formatting fix.
10461 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
10463 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
10464 cells, not xmalloc(), so that the cells will get destroyed
10467 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
10470 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
10472 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
10475 * dfm.c: Comment fix.
10477 * list.q: Comment fixes. Include somP.h. Removed static vars
10478 table, n_columns, n_rows, part. New struct list_ext. New static
10480 (n_lines_remaining, n_chars_width, write_line) New functions.
10481 (cmd_list, list_cases) Rewritten.
10482 (begin_row, end_row, flush_table) Removed.
10483 (write_header, clean_up, write_varname, write_fallback_headers,
10484 determine_layout) New functions.
10486 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
10488 * output.h: Comment fix.
10490 * postscript.c: Comment fix.
10491 (struct ps_driver_ext) Removed prop_size, fixed_size members;
10492 added font_size. All references changed.
10493 (ps_init_driver) Initializes font_size. Simplified space checking
10495 (static var option_tab[]) Removed prop-size, fixed-size; added
10497 (ps_option) Handles font_size.
10499 * som-high.c: Moved prototypes into somP.h.
10500 (som_init_driver) New function.
10501 (som_submit_table) Moved some code into new function
10503 (build_target) Moved some code into new function
10504 som_internal_eject_page().
10505 (som_eject_page) Uses som_internal_eject_page().
10506 (som_internal_eject_page) New function.
10508 * som-low.c: Moved prototypes into somP.h.
10510 * som.h: Formatting fixes.
10512 * somP.h: (struct som_driver_ext) Removed em_width;
10513 added prop_em_width, fixed_width.
10515 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
10517 * Makefile.am: Added `localedir' definition. Added
10518 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
10520 * ascii.c: (macro draw_line) Fixed capitalization.
10522 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
10523 compute.c, count.c, data-in.c, data-list.c, data-out.c,
10524 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
10525 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
10526 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
10527 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
10528 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
10529 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
10530 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
10531 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
10532 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
10533 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
10534 for internationlization.
10536 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
10538 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
10540 * do-if.c, sort.c, val-labs.c: Comment fixes.
10542 * glob.c: (init_glob) Uncommented, updated i18n support.
10544 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
10545 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
10546 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
10547 the declarations of macros taking arguments a lot nicer.
10549 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
10551 * error.h: Removed CE, CW aliases for SE, SW.
10553 * q2c.c: Removed explicit streq() definition since it's duplicated
10556 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
10557 stats.h, str.h, tokens.h: Made the declarations of macros taking
10558 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
10561 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
10563 * cmdline.c: Comment fixes.
10564 (pick_compat) Changed return type to int. Now, instead of setting
10565 glob var `compat' to the emulation, returns the emulation. All
10566 references changed.
10567 (parse_command_line) Added terminating null to end of
10568 `long_options' array definition.
10569 (pre_syntax_message) Fixes.
10570 (usage) Shows the default emulation in the syntax message by
10571 calling pick_compat().
10573 * getline.c: (getl_add_include_dir) Separates paths with
10574 PATH_DELIMITER, not DIR_SEPARATOR.
10576 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
10577 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
10579 * output.c: (outp_configure_macro) Make earlier definitions for a
10580 particular key override later ones for the same key.
10582 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
10584 * ascii.c: Comment fixes.
10586 * output.c: (outp_get_paper_size)
10587 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
10589 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
10591 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
10592 <errno.h>. GNU libc 2 enforces this!
10594 * command.c: (parse_cmd) Fixed problem with `else' clause being
10595 paired with wrong `if'. Comment fix.
10597 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
10599 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
10600 blp_getline() to getline().
10602 * output.c: (outp_eval_dimension) Changed the fix from last time;
10603 there was no variable `a'.
10605 * q2c.c: (get_line) Fixed boundary condition overrun bug.
10607 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
10609 * output.c: (outp_evaluate_dimension) Fixed handling of negative
10610 numbers having fractional parts. Added case of a fraction without
10611 a whole-number part.
10613 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
10615 * ascii.c: (ascii_text_get_font_position) Removed.
10617 * expr.h, exprP.h: Disabled debugging.
10619 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
10622 * output.h: (struct outp_class_struct) Removed
10623 text_get_font_position method. All references deleted.
10625 * postscript.c: Big change here. Fontmaps were completely
10626 eliminated because of a change in philosophy. Comment fixes.
10627 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
10629 (struct ps_driver_ext) `position', `fontmap', `prop_name',
10630 `fixed_name' members removed. New members `prop_family',
10631 `fixed_family'. `family' member changed to type char *.
10632 (static var ps_fontmaps) Removed.
10634 (ps_init_driver) Removed obsolete references, updated.
10635 Initializes `translate_x', `translate_y', `scale'. Doesn't read
10636 fontmap, of course. Refers to font names through internal_name
10637 rather than subversive means. Frees proper items.
10638 (static var option_tab[]) Removed `fontmap-file' option; renamed
10639 `fixed-font', `prop-font'.
10640 (ps_option) Corresponds to option_tab[].
10641 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
10642 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
10643 hash_family) Removed.
10644 (postopen) Generates font names from family names. Gets
10645 PostScript font name properly. New prologue file comment `!!!'
10647 (ps_open_page) Adds translate_x, translate_y to BP prologue
10648 function; gives SF argument floating-point format.
10649 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
10650 font name. Doesn't change font family.
10651 (ps_text_set_font_by_position) Generates Groff font name from font
10652 family name instead of through table lookup.
10653 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
10654 all references changed. Reduced to simple string assignment.
10655 (ps_get_font_name) Removed.
10656 (ps_get_font_family) Reduced to string return.
10657 (text) Doesn't save `position' since it no longer exists. Ugly
10658 kluge to save font family--fix soon?
10659 (load_font) Removed PostScript name argument.
10661 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
10663 * postscript.c: Comment fix.
10664 (ps_open_page) Puts scale factor in PostScript output.
10666 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
10668 * Makefile.am: Distcleans q2c.
10670 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
10672 * ascii.c: (delineate) Sets text size even if width is zero.
10674 * command.c: Comment fix.
10675 (static var cmd_table[]) Re-enabled EVALUATE command.
10676 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
10677 of comments in script files. Now more liberal on criteria for
10678 performing a state transition--if *anything* happened correctly,
10679 not just if *everything* happened correctly.
10681 * data-out.c: (convert_F) Comment fix. Why in the fsck does
10682 Checker segfault on formatting large numbers and why in the fsck
10683 hadn't I noticed this before?
10685 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
10687 * list.q: (cmd_list) Commented out the actual output routine
10688 because of various problems. Probably will abandon the idea of
10689 using the general `crushed tables' for the LIST procedure.
10691 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
10692 clearing it. Allocates a new var_by_name dictionary before trying
10693 to add members to it.
10695 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
10696 `sib'. Changed type of `node' argument.
10697 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
10698 avl_walk_inorder().
10699 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
10700 [DEBUGGING] Only deletes the variable from var_by_name if that var
10703 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
10705 * Makefile.am: Added include files to SOURCES. Added
10706 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
10707 includes rules for q2c. Added `boast' target.
10709 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
10711 * Makefile.am: Maintainer-clean Makefile.in.
10713 * Makefile.am: Fixed redundant EXTRA_DIST line.
10715 * ascii.c: Comment fixes.
10716 (ascii_line_vert) Fixed overly aggressive range check.
10718 * display.c: Removed dead code.
10720 * list.q: Turn debugging on.
10721 (flush_table) New debug code.
10723 * sfm-read.c: (read_value_labels) malloc's the structure before
10724 trying to assign to its members.
10726 * sfm-write.c: Comment fix.
10728 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
10730 (output_table) No arguments anymore--gets them through `som'
10731 global. New debug code. In crushed tables, now sets `htv' as
10732 well as `hv' to avoid bad confusion later.
10733 (dump_crush_page) New debug code.
10735 * som-low.c: (som_dump_crush_page) New debug code.
10737 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
10739 All source files: Broke long lines into multiple lines.
10741 * ascii.c: (ascii_close_page) Uses host_system var in place of
10742 HOST_SYSTEM constant.
10744 * cmdline.c: (var syntax_message[]) Broke into
10745 pre_syntax_message[] and post_syntax_message[].
10746 (usage) Outputs both parts, separated by driver list.
10748 * error.h: Fixed broken formatting.
10750 * expr-opt.c: (str_search, str_rsearch) New functions.
10752 * misc.c: (blp_getdelim) Removed. All references changed to
10754 (str_search, str_rsearch) Removed.
10755 (memrmem) New function.
10757 * misc.h: (blp_getline) Removed. All reference changed to
10760 * stat.h: New file.
10762 * filename.c: Includes "stat.h", not <sys/stat.h>.
10763 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
10765 * output.c: (outp_list_classes) Changed output formatting.
10767 * sfm-write.c: (write_header) Uses host_system var instead of
10768 HOST_SYSTEM constant.
10769 (write_rec_7_34) Extracts version numbers from the version string.
10772 * sort.c: Includes "stat.h", not <sys/stat.h>.
10774 * str.c: (strcasecmp) Removed.
10776 * title.c: (cmd_document) Uses host_system var instead of
10777 HOST_SYSTEM constant.
10779 * version.c: Generated on-the-fly by the Makefile instead of being
10782 * str.h: Comment fixes. Doesn't substitute for missing memmove or
10784 [!HAVE_STRNCASECMP] Declares strncasecmp().
10786 * version.h: Removed stray character. Comment fixes.
10787 (vars host_system, build_system) New vars.
10789 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
10791 * Most source files: Changed formatting of copyright notice; fixed
10792 FSF address; reformatted to better conform to GNU standards;
10793 comment fixes. Added markups to prevent GNU indent from messing
10794 up my beautiful formatting :-).
10796 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
10797 that GNU indent markups can be passed through without problems.
10799 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
10801 * get.c: Turned off debugging.
10803 * glob.c: (init_glob) Turned on save-file compression by default.
10805 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
10806 compression than was possible in save files.
10808 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
10810 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
10812 * frequencies.q: Removed Fiasco extensions. Updated calculation
10813 algorithms. Polished output format.
10814 (struct frq_info_struct) Removed members `max_degree', `min_n',
10815 all references removed.
10816 (macro frq_extensions) Removed.
10817 (static vars min_n, max_degree) Removed, all references removed.
10818 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
10819 calculate `min_n', `max_degree'.
10820 (postcalc) Passes new arg to dump_statistics().
10821 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
10823 (dump_condensed) Adds variable name title.
10824 (sum_freqs) Removed.
10825 (calc_stats) Updated calculation algorithm.
10826 (dump_statistics) Removed warning for too-few observations.
10827 Changed table formatting. Adds variable name title if passed new
10830 * output.h: Comment fix.
10832 * recode.c, sample.c, sort.c: Disabled debug code.
10834 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
10835 Improved debug code.
10837 * var.h: (enum series frq_*) Removed Fiasco extensions.
10839 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10841 * command.c: Added PROCESS IF to command table.
10843 * Lots & lots of places, removed checks for NULLs preceding calls
10844 to free_expression(), which itself checks.
10846 * descript.q: Removed Fiasco extensions. Removed optimizations
10847 for non-weighted active files. Implemented some options.
10848 Finished polishing output format. Comment fixes. Merged
10850 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10851 max_degree, min_n) Removed.
10852 (macro dsc_extensions) Removed.
10853 (struct dsc_info_struct) Removed `min_n' member, all references
10855 (internal_cmd_descriptives) Removed calculation of min_n,
10856 max_degree. Only deals with one `calc' routine instead of two
10858 (precalc) Eliminated redundancy. Updated for changes to
10859 descriptives_proc structure.
10860 (calc) Moved here from `descript.g'. Rewritten to calculate
10861 statistics via `moments about the mean' rather than by summing,
10862 summing squares, summing cubes, and so on.
10863 (postcalc) Rewritten for new-style statistical calculation.
10864 (display) Removed support for displaying variables across rows.
10865 No longer crushes the descriptives table. Removed ancient code.
10866 Added display of N, by variable and listwise.
10868 * descript.g: Removed; merged into `descript.q'.
10870 * expr-evl.c: (evaluate_expression) Now returns a double. For
10871 numeric results, it returns the result as well as storing it in
10872 the passed `value' structure if non-NULL. For string results it
10873 just returns 0.0 and it must be passed non-NULL. Many references
10874 to this function were optimized by use of this change, especially
10875 but not exclusively in `compute.c'.
10877 * frequencies.g: Comment fix.
10879 * glob.c: (glob var process_if_expr) New global var.
10881 * postscript.c: (static var option_tab[]) Corrected entry for
10883 (postopen) Sets x->size to x->prop_size.
10884 (ps_text_set_font_by_name) Sets font size as well as typeface for
10885 PROP and FIXED fonts.
10887 * sel-if.c: (cmd_process_if) New function.
10889 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10890 (sfm_write_dictionary) Sets `n_cases' to 0.
10891 (sfm_write_case) Increments `n_cases'.
10892 (sfm_close) Attempts to seek the system file back to the header
10893 and write the number of cases in its proper slot.
10895 * som-frnt.c: (som_insert_table) Masks off expansion options since
10896 only SOPT_X_NORM seems to work sensibly.
10898 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10899 with a `fixed' value of 2.
10901 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10903 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10904 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10906 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10907 (struct descriptives_proc) Removed `miss_noweight'; new members
10908 `X_bar', `M2', `M3', `M4', `min', `max'.
10910 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10912 * vfm.c: (close_active_file) Cancels PROCESS IF.
10913 (write_case) Doesn't process cases unselected by PROCESS IF.
10915 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10917 * glob.c: (glob var err) Removed.
10919 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10920 doesn't have to take into account number of value labels since
10921 they're in a subtable anyway. Also, doesn't display more than 10
10922 value labels since we can't yet break pages in subtables.
10924 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10926 * som-frnt.c: (som_change_table_size) Simple change for elegance
10927 that shouldn't change behavior.
10928 (som_set_value) Comment fix.
10930 * som-high.c: (som_submit_table) Message fix.
10932 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10934 * command.c: Added SYSFILE INFO to command table.
10936 * file-handle.q: (fh_handle_filename) New function.
10938 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10941 * main.c: (parse) New return value for command functions, -3.
10943 * misc.h: Comment fix.
10945 * output.h: Comment fixes.
10946 (macro COMPONENTS) Removed.
10948 * postscript.c: (write_text) Modified literal_chars[] so that `('
10949 and ')' are not written to the output in strings as literals.
10951 * sfm-read.c: (sfm_read_dictionary) New argument.
10952 (read_header) New argument. Sets the information structure's
10953 values from the header information.
10954 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10955 bizarre Checker problem, I guess.
10956 (read_variables) Proper cleanup on lossage.
10958 * sfm.h: (struct sfm_read_info) New struct for use by
10959 sfm_read_dictionary().
10961 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10962 currently used just for tables that can be dynamically resized and
10963 thus have to be allocated with arena_malloc() instead of
10964 arena_alloc(). All references changed.
10965 (som_change_table_size) New function.
10966 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10968 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10969 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10972 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10974 (draw_intersection) Now takes an argument specifying the table in
10975 question. All references changed.
10976 (draw_table_cell) New function.
10977 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10978 (som_get_table_size) Many nice new explanatory comments.
10979 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10981 * som.h: New enum series SOM_CREATE_* for use as create flags with
10982 som_create_table().
10984 * str.h: Moved a comment here from TODO.
10986 * sysfile-info.c: New file. Reference implementation.
10988 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10990 * command.c: Added RENAME VARIABLES to table of commands.
10992 * data-in.c: (dls_error) Sets `cust_field'.
10993 (parse_N) Message fix.
10994 (parse_day_count) New function.
10995 (to_roman) Never outputs VX as a `short form' of V.
10996 (parse_month) Fixed parsing of Roman numerals.
10997 (parse_trailer) Message fix.
10998 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10999 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
11000 the date is invalid.
11001 (parse_SDATE) Fixed swapped day, year.
11002 (parse_JDATE) Fixed bug for dates in 1582.
11003 (parse_DTIME) Allows days not between 1 and 31.
11004 (parse_numeric) Makes local copy of f.type for easier usage.
11007 * data-out.c: (convert_F) When outputting as scientific, properly
11008 sets f.type as fp->type.
11009 (insert_commas) Fixed operator precedence problem with setting of
11010 nitems. Changed strcpy to memcpy (no null terminator).
11011 (convert_date) Fixed FMT_JDATE: added 1900 to year.
11012 (convert_CCx) Essentially rewritten, but now it works.
11014 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
11015 feature of Fiasco).
11016 (display_documents) Implemented.
11018 * error.c: (glob var cust_field) New var.
11019 (vmsg) Displays cust_field as part of message classes DE and DW.
11021 * formats.c: (debug_print) Fixed to compile under updated
11024 * get.c: (cmd_get, cmd_save_internal) Close file handle on
11027 * misc.c: (parse_format_specifier) Formatting fix.
11029 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
11030 `n_rename' for clarity.
11031 (cmd_modify_vars) Initializes `forward' and `positional' at
11032 appropriate times. Frees lists of vars to rename on failure.
11033 Comment fix. Frees memory on success.
11034 (rearrange_dict) Simplified `for' loop condition.
11036 * rename-vars.c: New file (reference implementation).
11038 * set.q: (internal_cmd_set) Fixed `emu' test condition.
11040 * sfm-read.c: (read_header) File label is created only if file
11041 label in file is not blank.
11042 (read_variables) Initializes `dict' local variable.
11043 (read_documents) Proper behavior on lossage.
11045 * sfm-write.c: (write_header) Doesn't blank out the file label
11046 (why was this here to begin with?!)
11048 * temporary.c: (save_dictionary) File label is copied only if
11049 non-NULL. Doesn't try to xstrdup() dictionary documents.
11050 Adapted so as to not irritate Checker.
11051 (free_dictionary) Only destroys var_by_name if non-NULL.
11053 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
11054 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
11055 lines to the document, indents the document. Also, it works now.
11056 (add_document_line) New function.
11058 * var.h: (struct dictionary) Reordering.
11060 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
11061 bits if it was allocated to begin with.
11063 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
11065 * command.c: Added MODIFY VARS to list of commands.
11067 * configure.in: Updated custom macros for autoconf 2.12. Removed
11068 mmap reference; fixed termcap library reference.
11070 * display.c: (display_variables) Fixed a few bugs although it's
11071 still not well written.
11073 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
11074 (induce_segfault) Calls chkr_disp_call_chain() instead of
11075 inducing an actual SIGSEGV.
11077 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
11078 str_search() and str_rsearch(). Fixed tests for matches on
11079 OP_INDEX and OP_RINDEX.
11081 * filename.c: (good_getcwd) Removed as the new libc for Checker
11082 doesn't contain this bug, apparently.
11084 * misc.c: (str_search, str_rsearch) Changed order of arguments for
11085 consistency with GNU memmem.
11086 (blp_getdelim) Changed `len' from `int' to `size_t'.
11088 * modify-vars.c: Reference implementation.
11090 * som-frnt.c: (zero_length) New global var.
11091 (som_create_table) Message fix.
11093 * som.h: Added gcc attributions to som_set_text(),
11094 som_output_text() prototypes. blank_line() refers to
11095 zero_length[] instead of a literal null string to suppress gcc
11098 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
11099 (allocate_cases) Decrements x_max so the last element of x[] can
11100 be used by the algorithm.
11102 * var.h: Changed minor details of `variable' declaration.
11103 (struct modify_vars_proc) New struct.
11104 (struct variable) Added field p.mfv.
11106 * vars-atr.c: Comment fix.
11108 * vars-prs.c: (fill_all_vars) More optimal implementation.
11110 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
11111 character, which it shouldn't have to do but printf() seems to
11112 read the null byte even though I supply a maximum length...
11114 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
11116 * command.c: Removed command alias X for QUIT.
11117 (parse_cmd) Fixed comment parsing.
11119 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
11121 (read_record) Fixed references to len, size.
11122 (dfm_get_record) Restructured.
11124 * file-handle.h: (struct file_handle) Field `lrecl' now of type
11127 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
11130 * modify-vars.c: New file. Not complete.
11132 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
11135 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
11136 problems caused by int/size_t differences.
11138 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
11141 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
11142 being compared were of equal length.
11144 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
11146 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
11148 * lexer.c: (get_dotted_rest_of_line) New function.
11150 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
11153 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
11154 type 6 records. Frees the dictionary properly.
11155 (read_header) Initializes the dictionary instead of letting
11156 read_variables() do it. Sets the dictionary file label from the
11158 (read_documents) New function.
11160 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
11161 write type 6 record if appropriate.
11162 (write_header) Writes file label from dictionary.
11163 (write_documents) New function.
11165 * temporary.c: (save_dictionary, restore_dictionary,
11166 free_dictionary) Properly handle new fields in dictionary struct.
11168 * title.c: (get_title) Returns after failure().
11169 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
11170 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
11172 * var.h: (struct dictionary) New fields `label', `n_documents',
11175 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
11177 * command.c: Added FILTER to list of commands.
11179 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
11182 * get.c: (cmd_save_internal) Removed weighting code since it's now
11183 handled by sfm-write.c. Properly commented out debug code.
11185 * glob.c: (glob var weighting) Removed.
11187 * sel-if.c: Comment fixes.
11188 (cmd_filter) New function.
11190 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
11191 (sfm_read_dictionary) Sets weighting variable direct in the
11192 created dictionary now. (Apparently we previously didn't support
11194 (read_header) Sets weight_index field in sfm_fhuser_ext from
11195 header read from disk.
11197 * sfm-write.c: (sfm_write_dictionary) Comment fix.
11198 (write_header) Now sets the weighting in the header from the
11199 passed primary dictionary instead of from the sfm_write_info.
11201 * sfm.h: (struct sfm_write_info) Removed field `weight'.
11203 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
11204 broke on boundary conditions.
11206 * var.h: (struct dictionary) New fields `weight_var',
11207 `weight_index', and `filter_var'.
11208 (glob var weighting) Removed. This is now part of struct
11209 dictionary. All references changed; the less mechanical changes
11210 are described above.
11212 * vars-atr.c: (find_dict_variable) New function.
11214 * vfm.c: (static var filter_index) New variable.
11215 (open_active_file) Initializes filter_index from default_dict.
11216 (write_case) Calls proc_func() only if the filter variable is
11217 nonzero; this implements FILTER behavior.
11219 * weight.c: (static var weight_varname) Removed.
11220 (cmd_weight) Modified default_dict instead of glob vars.
11221 (update_weighting) Changed the signature to modify a dictionary
11222 instead of glob vars. Now returns the weighting variable.
11223 (get_weighting_variable) Removed; its function is absorbed by
11224 update_weighting().
11225 (stop_weighting) Operates on a dictionary now.
11227 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
11229 * sort.c: Removed debugging info from messages.
11230 (do_external_sort) Cleans up after itself by deleting the
11231 temporary directory on failure. (On success it is deleted by the
11233 (allocate_cases) Removed debug code. Added clean up code.
11234 (output_record) Removed debug code.
11235 (merge) Added code to close all the input files that are currently
11236 open. This is a likely location for bugs, because I'm not sure
11237 about boundary conditions. Removed an unnecesary heap_delete().
11238 (merge_once) Removed input file "optimization" that in fact
11239 screwed up the rest of the code. Message and comment fixes.
11241 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
11243 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
11245 * heap.c: (heap_delete) New argument.
11247 * sort.c: Finished implementation of external sort.
11249 * vfm.c: (read_from_disk) Returns after a disk error.
11251 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
11253 * sort.c: (static var state) Removed.
11254 (static vars max_handles, tmp_basename, tmp_extname,
11255 huffman_queue) New variables.
11256 (do_external_sort) Moved most code to new functions.
11257 Creates huffman_queue.
11258 (allocate_file_handles, allocate_cases) New functions.
11259 (static vars run_no, run_length, file_index, case_count) New
11261 (output_record) Returns success. Now really writes to the output
11263 (begin_run, end_run) New functions.
11264 (write_initial_runs) Returns success. Initializes run_no to -1.
11265 Calls begin_run(), end_run() at appropriate times. Outputs debug
11267 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
11269 (merge) New function.
11271 * heap.c, heap.h: New files. Hopefully in near-final form.
11273 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
11275 * glob.c: Added write_active_file to global vars.
11277 * sort.c: Several new miscellaneous static variables.
11278 (cmd_sort_cases) Big comment fix.
11279 (perform_case_2) Renamed `do_external_sort' and completely
11281 (case_2_proc_func) Removed.
11282 (output_record, write_initial_runs, write_to_sort_cases,
11283 compare_record) New functions.
11285 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
11287 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
11289 * sort.c: (perform_case_2) Changed the method for allocation of
11290 lots of memory--now allocates one case at a time in hopes that
11291 more cases can be allocated with heavily fragmented memory.
11293 * var.h: (write_active_file) New global var.
11295 * vfm.c: (procedure, close_active_file, write_case,
11296 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
11297 arguments to procedure() to be NULL. All references to
11298 procedure() that made use of dummy functions were changed to NULL
11300 (open_active_file) If write_active_file is non-NULL, the output
11301 device becomes DEV_PGM (a new enum).
11302 (close_active_file) Sets write_active_file to NULL.
11303 (read_from_memory) Comment fix.
11304 (record_case) Calls write_active_file() when the output device is
11307 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
11309 * sort.c: New file.
11311 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
11312 Fixed checking for duplicate varnames.
11313 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
11315 (autorecode_trns_free) Destroys hash tables for each recoding
11317 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
11319 * command.c: Added SORT CASES to cmd_table.
11320 (null_func, null_int_func) Prototyped.
11322 * descript.g: (calc_weight, calc_noweight) Computes own case
11325 * frequencies.q: (dump_statistics) Fixed problem with
11326 too-few-cases warning message.
11328 * get.c: (cmd_save_internal) Handles weighting properly.
11330 * hash.c: (hsh_dump) Output format changed.
11331 (force_hsh_insert) Actually works now, prototype changed.
11333 * list.q: (static var case_num) New variable.
11334 (cmd_list) Initializes case_num.
11335 (list_cases) Increments case_num.
11337 * var.h: Added definitions for SORT CASES. Comment fixes.
11339 * vfm.c: Some definitions moved to new file vfmP.h. Comment
11340 fixes. `active' renamed vfm_active, `rep' renamed
11341 vfm_replacement, all references changed.
11342 (procedure) The procfunc no longer receives a case number. All
11343 references changed.
11344 (write_case) Subtle reordering.
11345 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
11348 * weight.c: (get_weighting_variable) New function.
11350 * vfmP.h: New file with definitions from vfm.c.
11352 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
11354 * command.c: (FILE_TYPE_okay) Commented out some tests because
11355 they're clumsy and not yet needed.
11357 * var.h: Most *_trns structures moved to their respective source
11358 files. Some were moved into a new file, do-ifP.h. Comment fixes.
11359 (union any_trns) Changed to a typedef for trns_header.
11360 (struct input_program_pgm) Removed.
11362 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
11363 was allocated in the first place.
11365 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
11367 * autorecode.c: New file.
11369 * command.c: Added AUTORECODE to command table; re-enabled SET.
11371 * data-out.c: (convert_F) Handles infinities and NaNs properly.
11373 * error.c: (vmsg) Comment fixes.
11375 * hash.c: Comment fix.
11376 (hashpjw_d) New function.
11377 (hashpjw) Reimplemented as call to more general function
11379 (internal_comparison_fn) Initializes pointers properly.
11380 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
11381 (force_hsh_insert, force_hsh_find) New debugging wrapper
11384 * main.c: (main) Message fix.
11386 * output.c: (outp_read_devices) Message fix.
11388 * set.q: Comment fixes.
11389 (custom_results) Implemented Wnd/X form of subcommand.
11390 (set_routing) New function.
11391 (internal_cmd_set) Implemented ERRORS, MESSAGES.
11393 * settings.h: (SET_ROUTE_*) New enum series.
11394 (set_results) Renamed set_results_file, all references changed.
11395 (set_messages) Removed.
11396 (glob vars set_errors, set_messages, set_results) New vars.
11398 * title.c: (get_title) Remembers to xstrdup() the result of
11399 get_rest_of_line().
11401 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
11403 (union any_trns) New element `arc'.
11405 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
11407 * command.c: (output_line) Removed references to set_screen.
11409 * error.c: (static var terminating) New var.
11410 (hcf) Sets terminating to 1.
11411 (vmsg) If terminating is nonzero, does not attempt to call hcf().
11412 This prevents an infinite loop if an error occurs within hcf().
11414 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
11415 statement circumlocution with `case 42000' trick.
11416 (evaluate_expression) New support for OP_STR_MIS.
11418 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
11419 statement circumlocution with `case 42000' trick.
11420 (dump_node) Handles OP_STR_MIS.
11422 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
11423 variables exceptions.
11424 (parse_function) Message fix.
11425 (ops[]) Added OP_STR_MIS.
11427 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
11429 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
11431 * glob.c: Removed set_scrnfile glob var.
11432 (init_glob) set_errorbreak set to 0 by default.
11434 * groff-font.c: Changed included files.
11435 (groff_read_font) Initializes font_arena local var correctly.
11436 (default_font) New function.
11438 * output.c: Comment fixes.
11439 (glob var disabled_devices) New variable.
11440 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
11442 [GLOBAL_DEBUGGING] (reentrancy) New function.
11443 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
11444 outp_iterate_enabled_drivers) Calls to reentrancy().
11445 (destroy_list) New function.
11446 (outp_done) Moved code to destroy_list().
11447 (parse_options) Parses `listing', `screen', `printer' options
11449 (configure_driver) Sets new `device' member of driver.
11450 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
11452 * output.h: Comment fixes. New enum series OUTP_DEV_*.
11453 (struct outp_driver_struct) New member `device'.
11455 * postscript.c: (find_encoding_file) Doesn't display its own error
11457 (default_encoding) New function.
11458 (switch_font) Calls default_encoding() if no encoding can be
11460 (text) Makes up a character metric if none exists for the desired
11462 (load_font) Properly copies a fallback filename. Calls
11463 default_font() for a font if none at all are known.
11465 * set.q: Comment fixes. Removed OUTPUT subcommand.
11466 (custom_listing) Calls outp_enable_device() to enable/disable
11468 (turn_screen_on) Removed.
11469 (internal_cmd_set) Calls outp_enable_device() to enable/disable
11470 screen, printer devices.
11472 * settings.h: Comment fixes.
11473 (glob vars set_output, set_printer, set_screen, set_scrnfile)
11476 * som-high.c: (som_submit_table, som_eject_page) Use
11477 outp_iterate_enabled_drivers() instead of iterating
11478 outp_driver_list directly.
11480 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
11482 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
11483 (parse_string_as_format) Handles new formats.
11484 (parse_numeric) Now handles DOT and PCT formats.
11486 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
11488 (convert_date) Handle EDATE and SDATE formats.
11489 (convert_CCx) Now if there's not room for the currency characters,
11490 converts it as F format if it's positive instead of giving up
11491 quickly. Also fixed save-and-restore bug with decimal point
11493 (convert_format_to_string) Handles new formats.
11495 * misc.c: (formats[]) Added new formats.
11496 (convert_fmt_ItoO) Supports new formats.
11498 * sfm-read.c: (parse_format_spec) Supports new formats. Better
11499 data checking. New argument, all references changed.
11501 * sfm-write.c: (write_format_spec) Supports new formats.
11503 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
11506 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
11508 * cmdline.c: Comment fixes.
11509 (parse_command_line) Changed return type to void.
11511 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
11513 (parse_numeric) Handles international numbers (comma as decimal
11514 point). Some reformatting.
11516 * data-list.c: (parse_free) Default output format is now
11517 set_format instead of hard-coded F8.2.
11518 (read_from_data_list_list) Emits error message on undefined data
11519 only if set_undefined is nonzero.
11521 * data-out.c: (convert_E) Changes decimal point from period to
11522 comma if appropriate. Restructured. Better comments.
11523 (convert_F) Changes decimal point from period to comma if
11525 (insert_commas) Major bug with handling of negative values fixed.
11526 Also, inserts periods instead of commas if appropriate.
11527 (convert_CCx) New function.
11528 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
11529 (num_to_string) Changed `.' to set_decimal.
11531 * dfm.c: Comment fixes.
11532 (dfm_close) Frees ext->line even in inline_file.
11533 (open_inline_file) New function.
11534 (open_file_r) When opening the inline file: now properly
11535 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
11537 (read_record) Calls fh_close_handle() instead of dfm_close() to
11538 close the inline file. Makes a copy of the line getl_buf to avoid
11539 interlock problems.
11540 (dfm_get_record) Restructured. Now checks the return value of
11542 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
11543 checking for use of inline file. No longer tries to close inline
11546 * error.c: (glob var error_already_flagged) New var.
11547 (vmsg) Message change. Now checks max number of errors/warnings,
11550 * file-handle.q: (fh_handle_name) Now allows closing of
11552 (fh_init_files) Reformatted.
11554 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
11556 * getline.c: (getl_include) Fixed bug that popped up when called
11557 when file queue was empty.
11558 (read_console) Resets error_count, warning_count,
11559 error_already_flagged to zero.
11561 * glob.c: Many changes to update list of variables.
11562 (init_compat_dependent) Now this function is called whenever
11563 `compat' changes. It now sets set_seed only if it hasn't
11564 previously been referenced. It now calls
11565 lex_init_compat_dependent().
11567 * include.c: (cmd_include_at) Frees temporary buffer instead of
11569 (cmd_include) Doesn't make copy of include file name.
11571 * lexer.c: Comment fixes.
11572 (init_lex) Moved some code into new function
11573 lex_init_compat_dependent().
11574 (lex_init_compat_dependent) New function.
11575 (hex_val) Simplified.
11576 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
11578 * main.c: Comment fixes.
11579 (main) Reformatted.
11581 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
11582 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
11583 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
11584 (setup_randomize) Sets set_seed_used.
11586 * set.q: Comment fixes.
11587 (custom_results) Conditionalizes on `compat'.
11588 (custom_log) Calls custom_journal().
11589 (set_ccx) New function.
11590 (cmd_set) Calls init_compat_dependent() when `compat' changes.
11591 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
11592 when set_decimal changes. Range-checks values for MITERATE,
11593 MNEST. Message fixes.
11595 * settings.h: Comment fixes.
11596 (struct set_cust_currency) New struct.
11597 (set_cc[], set_grouping, set_seed_used) New global vars.
11599 * var.h: (FMT_CCA...FMT_CCE) New output formats.
11600 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
11602 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
11604 * glob.c: Revised variables to correspond to settings.h.
11605 (init_glob) Initializes variables from settings.h properly.
11607 * set.q: Began long-overdue major revision to correspond to new
11608 philosophy. Most code changed.
11610 * settings.h: Mostly changed; reorganized, reordered, large new
11613 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
11615 * get.c: (cmd_save_internal) No longer forces compression off.
11617 * sfm-read.c: (read_compressed_data) If eof is reached when
11618 reading a new instruction octet, only signal error if we're in the
11621 * sfm-write.c: (COMPRESSION_BIAS) New #define.
11622 (struct sfm_fhuser_ext) New member `end'.
11623 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
11624 (ensure_buf_space) New function.
11625 (sfm_write_case) Reimplemented in order to support compression.
11626 (sfm_close) Writes out the remaining contents of the compression
11629 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
11631 * command.c: Defined SAVE and XSAVE commands in command table.
11633 * common.h: second_lowest_value is of type flt64, not double.
11635 * file-handle.h: Comment fix.
11637 * get.c: Comment fixes.
11638 (static var `trns') New.
11639 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
11640 cmd_save_internal, cmd_save, cmd_xsave) New functions.
11641 (dict_delete_run) Clears the variables and frees them now.
11642 (trim_dictionary) Sets default for compression.
11643 On KEEP subcommand, frees deleted variables as well as clearing
11644 them. Finally got the sense of the test for deleting all
11646 [DEBUGGING] (dump_dict_variables) Message fix.
11648 * glob.c: (init_glob) set_compression set to 1 by default.
11650 * list.q: Properly #includes config.h.
11652 * misc.h: New macro REM_RND_UP.
11654 * settings.h: Comment fix.
11656 * sfm-read.c: (structs sysfile_header, sysfile_format,
11657 sysfile_variable; inline function bswap_int32) Moved to new file
11659 (corrupt_msg) [__CHECKER__] No longer induces segfault.
11660 (sfm_read_dictionary) Fixed bug caused by failing to initialize
11662 (read_machine_flt64_info) Fixed some problems caused by confusion
11663 between flt64 and double types.
11664 (read_header) Message fix.
11665 (read_variables) Fixed set of cases in which we byte-swap sv.print
11666 and sv.write. Fixed confusion of flt64 and double.
11668 * sfm.h: (struct sfm_write_info) New.
11670 * som-high.c: (som_draw_title) Properly frees `s'.
11672 * temporary.c: (save_dictionary) Comment fix.
11674 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
11675 (struct trns_header) Formatting fix.
11676 (struct save_trns) New.
11678 * vars-atr.c: (discard_variables) Comment fix.
11680 * sfm-write.c: New file, baseline release.
11682 * sfmP.h: New file, baseline release.
11684 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
11686 * cmdline.c: (parse_command_line) `--version' output updated.
11687 (glob var syntax_message[]) Added my e-mail address.
11689 * file-handle.q, lexer.c, vfm.c: Changed many instances of
11690 `illegal' to `invalid'.
11692 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
11693 uncompression buffer.
11694 (sfm_close) Frees decompression buffer.
11695 (sfm_read_dictionary) Initializes decompression buffer.
11696 (buffer_input, read_compressed_data) New functions.
11697 (sfm_read_case) Restructured; now calls read_compressed_data() to
11698 handle compressed system file data.
11700 * var.h: Comment fix.
11702 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
11704 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
11707 * get.c: New comments. New static var `get_file'.
11708 (cmd_get) Now fully implemented. Calls discard_variables();
11709 initializes fv and lv for all variables; new debug code; sets
11710 up the dictionary; sets up the input program.
11711 (read_from_get, cancel_get) New functions.
11713 * sfm-read.c: Comment fixes.
11714 (sfm_close) New static function.
11715 (sfm_read_dictionary) Properly sets up the class of the
11716 file_handle. No longer cares what size the data is in records of
11717 type 7. Also, on failure, properly cleans up the file_handle and
11718 free()s some stuff.
11719 (read_variables) No longer thinks it knows `nval' of the
11720 dictionary. Now sets p.get.fv, etc., instead of speculatively
11722 (read_value_labels) Fixed off-by-one error in indexing of
11724 (sfm_read_case) New function.
11725 (sfm_r_class) New static var.
11727 * var.h: (get_proc) New struct.
11728 (struct variable) New member p.get.
11730 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
11732 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
11733 the manual's meaning.
11734 (rename_variables) New function.
11735 (trim_variables) Doesn't try to parse MAP any more. Removed debug
11736 code. Now properly reorders the dictionary on the KEEP keyword.
11738 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
11739 garbage collection.
11741 * vars-atr.c: (clear_variable) New argument `dictionary *'.
11742 (rename_variable) New function.
11743 (free_val_lab) Reformatted.
11745 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
11747 * var.h: Reindented entire file. Comment fixes.
11748 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
11750 (glob var default_dict) New.
11751 (struct indirect_dictionary) Removed.
11753 * Many other source files were changed to add `default_dict.'
11754 before all references to the dictionary of the active file.
11756 * vars-atr.c: (make_indirect_dictionary) Removed.
11758 * glob.c: Reindented all variable declarations. Updated for
11759 changed var.h. Comment fixes.
11761 * temporary.c: (restore_dictionary, save_dictionary) Simplified
11762 because now we can mainly copy dictionary structs.
11764 * vars-prs.c: (is_dict_varname, parse_dict_variable,
11765 parse_variables) Takes dictionary instead of indirect_dictionary
11767 (parse_variables) Instead of calling make_indirect_dictionary,
11768 just sets DICT to &default_dict if DICT is NULL. Of course, lots
11769 of `*dict.' references had to be changed to `dict->'. Removed
11772 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
11774 * get.c: Added GTSV_OPT_* series of enums.
11775 (trim_dictionary, dict_delete_run) New functions.
11776 [DEBUGGING] (dump_dict_variables) New function.
11777 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
11778 [DEBUGGING] Calls dump_dict_variables() to display results.
11780 * glob.c: (cmp_variable) Now a public function declared in var.h.
11782 * sfm-read.c: Turned off debug code. Comment fixes.
11783 (read_machine_int32_info, read_machine_flt64_info) New functions
11784 to parse type 7 records.
11785 (sfm_read_dictionary) Properly byteswaps several fields now.
11786 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
11787 records. [DEBUGGING] Dumps dictionary.
11788 (read_variables) Sets `index' field of variables created properly.
11789 Constructs avl tree of variables in dictionary. [DEBUGGING] No
11790 longer dumps dictionary.
11791 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
11793 [DEBUGGING] (dump_dictionary) No longer stubbed out.
11795 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
11796 var before destroying any variables just to save a little time.
11798 * var.h: (struct variable) Reordered in order to make name[] the
11799 first member; this makes pointers to `variable' pointers to the
11800 variable name, simplifying avl trees, etc.
11801 (struct indirect_dictionary) New struct.
11803 * vars-atr.c: (find_variable) Rewritten for efficiency.
11804 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
11806 (is_varname) Rewritten for efficiency.
11807 (parse_variables) New argument, which is a `dictionary *'. All
11808 references changed. This function now reads variable names from
11809 the dictionary passed, or from the default dictionary if NULL.
11811 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
11813 * misc.h: Added new macro DIV_RND_UP to perform integer division,
11814 rounding up. Changed many references to ROUND_UP to use this
11817 * sfm-read.c: Includes avl.h.
11818 (corrupt_msg) Induces a segfault under Checker.
11819 (macro assertive_bufread) New. Many references to bufread() now
11821 (sfm_read_dictionary) Split up into several functions. Added code
11822 to read dictionary records following the the type 2 records. Not
11823 quite complete. New variable `var_by_index'.
11824 (read_header, read_variables) New functions extracted from
11825 sfm_read_dictionary().
11826 (read_value_labels) New function.
11827 (bufread) Checks ferror() if fread() doesn't return the expected
11828 value; if ferror() is zero it's just EOF.
11829 (dump_dictionary) Stubbed out.
11831 * BTW: The source code now exceeds 50000 lines!
11833 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
11835 * command.c: Added GET to cmd_table[].
11837 * list.q: Removed reference to alloca headers.
11838 (cmd_list) Gave prototype.
11840 * sfm-read.c: Added DEBUGGING comments.
11841 (sfm_read_dictionary) Checks bias correctly. Sets
11842 dict->var_by_name to NULL. Calculates long_string_count
11843 correctly. realloc's dict->var[] array to minimum size.
11844 [DEBUGGING] Calls dump_dictionary.
11845 [DEBUGGING] (dump_dictionary) New function.
11847 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11848 (restore_dictionary) If the dictionary contains a non-NULL
11849 var_by_name, uses that instead of generating one.
11850 (free_dictionary) Destroys var_by_name.
11852 * var.h: (struct dictionary) Added field `var_by_name'.
11854 * get.c: New file, not complete.
11856 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11858 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11859 (parse_num_or_range) New function.
11860 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11861 <n> THRU HIGH missing values.
11863 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11864 __attribute__((const)).
11866 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11868 * sfm-read.c: Finished reference implementation.
11870 * sfm.h: Includes var.h.
11872 * var.h: Comment fixes.
11873 (struct `variable') Reordered some fields.
11875 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11876 constants added previously.
11878 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11880 * common.h: Comment fixes. Added declaration of
11881 `second_lowest_value' as variable or macro. Made `compat_type',
11882 `pgm_state_type' into anonymous enums.
11884 * display.c: Comment fix.
11886 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11888 [!defined SECOND_LOWEST_VALUE] Added definition for
11889 `second_lowest_value' global var.
11890 (compat, pgm_state global vars) Changed types to `int'.
11891 (init_glob) Initializes `second_lowest_value'.
11893 * sfm-read.c: Continued work, not complete.
11895 * var.h: Added new MISSING_* constants to handle LOWEST and
11898 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11900 * sfm-read.c: New file, not complete.
11902 * cases.c: (vec_insert) Changed vector expansion algorithm.
11903 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11904 mucking up the RECODE transformation in particular.
11905 (envector) Harmless change in notation.
11907 dfm is now fairly well tested again.
11908 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11910 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11912 * recode.c: Comment fix.
11914 * sfm.h: Interface should be fairly final now, or at least for a
11917 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11918 (open_active_file) [DEBUGGING] Translates ccase indices into
11919 variable names now to make it easier to understand what's really
11922 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11924 * data-in.c: Comment fix.
11926 * data-list.c: Includes dfm.h.
11927 (do_reading) Uses new function dfm_push_cust().
11929 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11930 `return 1;' at end.
11932 * file-handle.h: Completely changed. Some parts split off into
11933 new file dfm.h. Implemented in file-handle.q.
11934 (enum FH_*) Removed.
11935 (struct fh_ext_class) New struct.
11936 (struct file_handle) Retained only these fields: name, norm_fn,
11937 fn, recform, lrecl, mode. New fields class, ext.
11938 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11939 close_handle, handle_name) Added `fh_' prefix to name, all
11940 references changed.
11942 * dfm.h: New file, implemented in dfm.c.
11943 (get_record, put_record, fwd_record, bkwd_record, set_record,
11944 get_cur_col) Functions moved from file-handle.h, now prefixed with
11946 (dfm_push_cust) New function.
11948 * sfm.h: New file. Incomplete.
11950 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11951 interface. Functions reordered, comments changed. Not well
11952 tested, probably full of bugs.
11953 (struct dfm_fhuser_ext) New struct.
11954 (dfm_close) New function.
11955 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11956 (open_file_w) User messages changed.
11957 (get_record) Comment fixed.
11958 (read_record) Increments ext->ln even for inline_file. Calls
11959 dfm_close() for inline_file when `END DATA.' encountered.
11960 (dfm_get_record) Experimental restructuring.
11961 (dfm_push_cust) New function.
11962 (cmd_begin_data) Detects whether the inline file was fully read by
11963 checking whether it is still open; detects whether it was read at
11964 all by checking whether the line number is greater than zero.
11966 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11967 interface. Functions reordered, comments changed. Not well
11968 tested, probably full of bugs.
11969 (init_file_handle) Removed initializers for obsolete fields, added
11971 (fh_close_handle) Much simpler, now mainly calls the class
11973 (fh_init_files) Renamed inline file internal filename.
11975 * file-type.c: Includes dfm.h.
11976 (read_from_file_type) Doesn't use dfm internal state anymore.
11978 * inpt-pgm.c, print.c: Include dfm.h.
11980 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11981 int in comparison with other int.
11983 * som-high.c: (build_target) Fixed operator precedence problem in
11984 if statement (& versus ==).
11986 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11988 * dfm.c: (read_record) Can now read fixed-length records; not
11990 (put_record) Can now write fixed-length records; not tested.
11992 * file-handle.h: FH_* defines changed to enums. New enum series
11994 (struct file_handle) New members recform, lrecl, mode.
11996 * file-handle.q: Parser changed.
11997 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11998 /LRECL subcommands. These are compatible with Windows.
11999 (init_file_handle) Initializes recform, mode fields.
12001 * q2c.c: (get_line) When outputting `!' comment lines, now
12002 increments the output file line number so that `#line' directives
12004 (make_identifier) New function that converts an arbitrary string
12005 into a valid C identifier.
12006 (dump_vars) Calls make_identifier() in two places in order to
12007 suppress some errors for bad identifiers.
12008 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
12009 for NO. Allows numbers to be prefixed by underscores to make them
12010 acceptable C identifiers but still to be parsed as numbers by the
12013 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
12015 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
12017 * dfm.c: Comment fixes. (get_record) Gives error if file handle
12018 was opened for writing.
12019 (open_file_w) New function.
12020 (read_record) Uses strncasecmp if available. Improved error
12021 messages, comments.
12022 (put_record) New function.
12024 * file-handle.h: Moved function comments into dfm.c and
12025 file-handle.q. Comment fixes. Removed declarations of
12026 tilde_expand() and normalize_filename().
12027 (struct file_handle) Changed `open' from boolean to enumerated
12028 field to allow for three states--closed, open for reading, open
12029 for writing--all references changed.
12031 * file-handle.q: Includes filename.h.
12033 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
12034 references changed.
12035 (alloc_line) Makes allowance for line terminator characters in
12037 (print_trns_proc) Now handles OUTFILE, WRITE differences.
12038 (print_space_trns_proc) Handles OUTFILE differences.
12040 * recode.c, sample.c: Comment fixes.
12042 * var.h: (struct print_trns) Changed boolean field `eject' to
12043 bitmapped field `options'; all references changed. New enums
12044 PRT_* for use with this field.
12046 * exception.h, test-exception.c: Removed.
12048 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
12050 * ascii.c: (delineate) Turned off debug output.
12052 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
12055 * data-in.c: (parse_string_as_format) Sets the entire string value
12056 to spaces, not just the short string part of it. Is this correct
12059 * data-out.c: (convert_date) Fixed DATETIME format problems with
12060 decimal places, removed debug code.
12062 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
12063 middle of parsing BEGIN DATA that would cause the lexer to read
12064 from a wild pointer `prog'; now calls new function
12065 preprocess_line() in lexer.c.
12067 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
12069 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
12070 Now call induce_segfault() to induce the segfault.
12071 (induce_segfault) New function.
12073 * expr-opt.c: Comment fix.
12074 (parse_sysvar) New function.
12075 (parse_primary) Added system variable support--calls
12077 (global var ops) Added OP_CASENUM operator.
12079 * expr.h: Comment fixes.
12080 (OP_* enum) added OP_CASENUM operator.
12081 (struct casenum_node) New struct.
12082 (union any_union_union) New member `cas' of type `casenum_node'.
12084 * glob.c: (global var last_vfm_invocation) New var.
12085 (init_glob) Initializes last_vfm_invocation.
12087 * lexer.c: (lookahead) Fixed reversed condition on if statement.
12089 * getline.c: (get_line) Split into get_line() and preprocess_line().
12090 (preprocess_line) New function.
12092 * var.h: Declares last_vfm_invocation.
12094 * vfm.c: (procedure) Sets last_vfm_invocation.
12096 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
12098 * command.c: (parse_cmd) Fixed bad assertion related to
12101 * data-in.c: (parse_month) Implemented to parse months according
12102 to full interpretation of standard.
12103 (to_roman) New function.
12104 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
12105 (parse_weekday) Bug fix (forgot to skip all the day name).
12107 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
12108 up parsing of multirecord data items. Also fixed user message.
12110 * data-out.c: Comment fix.
12111 (year2, year4, convert_date, convert_time, convert_WKDAY,
12112 convert_MONTH) New functions to support time & date output.
12113 (convert_format_to_string) Calls new time & date output routines.
12115 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
12117 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
12120 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
12122 * misc.c: (global var formats) Fixed declarations of DATETIME,
12125 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
12126 the output_char buffer.
12128 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
12129 memory bug. Fixed user messages.
12131 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
12133 * Removed #pragma argsused from lots of places.
12135 * data-in.c: Implemented zoned decimal and time-date formats.
12136 Untested. This is a huge chunk of code--maybe 1000 lines and 50
12139 * data-out.c: Implemented zoned decimal format.
12141 * expr.h: Moved yrmoda() declaration here from exprP.h.
12143 * misc.c: (global var formats) Minor fixes--added
12144 FCAT_SHIFT_DECIMAL to formats N and Z.
12145 (convert_fmt_ItoO) Added support for format Z.
12147 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
12149 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
12151 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
12152 som_check_workspace() that is activated between commands.
12154 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
12157 * list.q: (begin_row) Changed title expansion style from
12158 SOPT_X_VERT to SOPT_X_SHSP.
12160 * som-frnt.c: Now includes `somP.h'.
12161 (som_push_workspace, som_pop_workspace) New functions that, taken
12162 together, form a solution to the recursive table building problem
12163 mentioned yesterday. Surrounded every table output routine
12164 throughout the program with calls to these functions.
12165 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
12166 (som_create_table) Checks that there's an active workspace.
12167 (som_destroy_all_tables, som_crush) Removed.
12169 * som-high.c: (global var som_preserve_tables) Removed, all
12170 references deleted.
12171 (som_submit_table) Checks that there's an active workspace.
12172 (dump_columnated_table) Doesn't columnate tables that would have
12173 just one row per column.
12174 (dump_crush_page, som_dump_crush_page) Removed debugging code.
12175 (som_dump_crush_page) Moved row number labels from left side of
12176 tables to right side.
12177 (som_get_table_size) Added support for SOPT_X_SHSP.
12179 * som.h: New cell expansion type SOPT_X_SHSP.
12181 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
12183 (global var curtab_arena) Moved from som-frnt.c.
12185 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
12187 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
12188 that causes bad location warnings to be suppressed.
12189 (delineate) Saves current font when calling draw_text(); fixed
12190 handling of NULLs when backing up. Also fixed line-wrapping bug.
12192 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
12193 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
12195 * common.c: Added code to cause assertion failure to dump core
12196 when run under Checker.
12198 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
12199 there are still bugs.
12201 * glob.c: (__eprintf) Removed.
12203 * list.q: Inserted som_preserve_tables kluge that prevents tables
12204 from being thrown away due to recursive table building through
12205 som_output_line being called from a transformation during the LIST
12206 procedure invocation. This is a general problem that must be
12207 solved in a better way since it applies to all procedures in
12209 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
12210 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
12212 * numeric.c: Fixed several errors in the form of msg() calls.
12214 * print.c: Updated for use of som.
12215 (dump_table) Reimplemented.
12216 (print_trns_proc) Calls som_eject_page() instead of eject_page().
12217 Calls som_output_text() instead of outs_line().
12219 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
12221 (som_output_text) Function moved from som-low.c. Interface
12224 * som-high.c: (som_preserve_tables) New global public variable
12226 (som_submit_table) Destroys the tables only if som_preserve_tables
12228 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
12229 one subrow per row. Now labels subrows if there's more than one
12231 (dump_crush_table) Added wishlist comment.
12232 (som_eject_page) New public function declared in som.h.
12234 * som-low.c: (som_dump_crush_page) Draws row labels if there's
12235 more than one subrow per row.
12236 (som_output_text) Moved to som-frnt.c.
12238 * som.h: (SOM_TOPT_PRESERVE) Removed.
12240 * title.c: (get_title) Changed interface.
12241 (cmd_title) Changed `title' to `outp_title'.
12242 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
12244 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
12246 * list.q: (flush_table) Conforms to new partial options in
12247 som_submission_form.
12249 * som-high.c: (paginate_horizontally) Changed form of subrow
12251 (build_target) Omits spacing before table if
12252 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
12253 (dump_crush_page) Changed interface. Only trims bottom rule if
12254 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
12255 (dump_crush_table) Handles partial tables.
12256 (output_row_label) New function.
12257 (som_dump_crush_page) Emits subrow number labels. Draws vertical
12258 rule on the right edge of narrow subrows.
12260 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
12261 constants to a series of SOM_TOPT_PARTIAL_* submission options.
12262 All references updated.
12264 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
12266 * misc.c: Comment fix.
12268 * som-high.c: (examine_table) Treats crushed tables separates for
12269 purpose of determining header size.
12270 (paginate_horizontally) Allots space for line numbers in crushed
12271 tables with lots of subrows per row. Calculates the `maximum page
12272 width', the width of the widest horizontal page.
12273 (build_target) Removed trim argument; all references changed.
12274 Stricter assertions. (dump_crush_page) New function.
12275 (dump_crush_table) Reimplemented.
12277 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
12278 (som_dump_crush_page) Reimplemented, interface changed.
12280 * somP.h: Many many new helper macros for use with crushed tables.
12281 (global var som) Removed `tv', `cum_y' members; all references
12282 removed. New members `mpw', `digit_space'.
12284 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
12286 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
12287 variable, changed to constant 1024.
12288 (arena_ca_strdup) Changed `sizeof(a_string)' to
12289 `sizeof(c_string)'.
12290 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
12291 `(c_string *)' to `(char *)'; this fixed some offset problems.
12293 * filename.c: (readlink_malloc) Changed initial allocation from
12295 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
12298 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
12299 &fm->owner in several places.
12301 * som-high.c: (output_table) Changed interface to rest of world.
12302 (examine_crush_table) Removed. Crushed tables are re-broken now,
12303 in preparation for rewrite.
12305 * som.h: Comment fix.
12307 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
12309 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
12310 itself in the cleanup stage.
12312 * descript.q: (display) At least temporarily, changed the table
12313 format to a crushed table.
12315 * list.q: (begin_row) At least temporarily, added horizontal lines
12318 * som-high.c: (examine_crush_table) Sets som.hh to the width of
12319 the horizontal "headers," that is, to the width of the far left
12320 and far right rules.
12321 (justify_pagination) Sets som.th to the width of the widest row
12322 in the crushed table. Fixed inner loop off-by-one error.
12324 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
12327 * somP.h: Comment fix.
12329 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
12331 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
12332 before closing it; also, opens the constructed filename `s'
12333 instead of f->filename.
12335 * postscript.c: Moved initialization of x->loaded, x->prop,
12336 x->fixed, x->current, also the add_encoding() calls, into
12338 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
12339 sets x->last_font to NULL; sets x->next_combo to zero.
12341 * som-high.c: (crushed_row_height) Moved definition farther up.
12342 (som_submit_table) Doesn't calculate line width, font size until
12343 after calling open_page(), to accomodate changes to PostScript
12345 (vert_headers) Removed; equivalent functionality moved to
12346 examine_table(), examine_crush_table().
12347 (justify_pagination) Replaced with different algorithm.
12348 (dump_crush_table) Bugfix that caused tables to fail to be clipped
12349 at the bottom of the page.
12351 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
12353 * command.c: Added cmd_list back into cmd_table.
12355 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
12356 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
12358 * list.q: (flush_table) Updated to new som_submission_form format.
12360 * som-frnt.c: Comment fix.
12362 * som-high.c: Changed `#endif' to `#undef EXTERN'.
12363 (output_table) Calls som_get_table_size() directly; handles
12365 (examine_crush_table) New function; calls vert_headers().
12366 (examine_table) Moved some code into new function, vert_headers().
12367 (justify_pagination) New function.
12368 (dump_plain_table) Removed `static' from `cy'.
12369 (dump_crush_table) New function.
12371 * som-low.c: (som_dump_crush_page) New function.
12373 * som.h: Comment fixes.
12374 (enum SOM_TOPT_CRUSH) New.
12375 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
12376 Temporarily set to zero to make do with LIST procedure.
12378 * somP.h: Re-ordering.
12380 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
12382 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
12384 * somP.h: New file for use by som-high.c, som-low.c.
12386 * q2c.c: Added definition for VME.
12387 (get_line) Now dumps `!' comment lines to the output file
12390 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
12391 set.q: Changed format of `!' comment lines.
12393 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
12395 * All source files: Added copyright notice.
12397 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
12398 longs in msg() calls.
12400 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
12402 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
12404 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
12406 * output.c: (outp_read_devices) Changed criteria for
12407 distinguishing different types of lines.
12409 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
12411 * cmdline.c: Changed syntax message.
12413 * filename.c: (good_getcwd) Bug fix (?).
12414 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
12416 (search_path) Appends DIR_SEPARATOR to directory name only if it
12417 does not already end with one.
12419 * glob.c: Checks STAT_PAGER envvar before PAGER.
12421 * output.c: Checks environment variables instead of just local
12424 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
12426 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
12427 when the pointer passed to the function was within the arena
12428 itself, so that it couldn't properly be set to NULL _after the
12431 * command.c: Re-enabled DISPLAY.
12433 * display.c: Rewritten to handle tables. Untested.
12435 * filename.c: (search_path) Fixed memory leak.
12437 * frequencies.q: (cmd_frequencies) Frees v_variables.
12438 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
12439 (cleanup_freq_tab) New function to garbage collect.
12440 (dump_full) Elegantized.
12442 * main.c: New comment.
12444 * output.h: New tag for tagged quotes: TAG_NEWLINE.
12446 * postscript.c: Comment fix.
12447 (release_fontmap, free_font_entry) New functions.
12448 (ps_init_driver) Sets free_font_entry() as the freefunc for
12449 hashtable `loaded'. Calls release_fontmap() when destroying a
12450 driver; also frees the output filename; also frees the
12451 ps_driver_ext block.
12452 (free_ps_encoding) Frees the filename as well as the encoding
12454 (output_encodings) Frees the line buffer and pops the msg-filename
12456 (read_fontmap) Frees the fontmap filename and the line buffer.
12457 (postopen, preclose) Misc. garbage collection fixes.
12458 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
12459 to NULL; this fixes some output problems.
12460 (text) Handles TAG_NEWLINE. Untested.
12462 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
12463 (som_set_string) Removed. All references changed to
12465 (som_set_text) Rewritten. New interface. More general.
12467 * som.h: Minor format changes.
12468 (struct som_value_cell) Removed; all references changed to
12470 (enums SOT_*) Changed.
12472 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
12474 * command.c: Re-enabled SPLIT FILE.
12476 * postscript.c: Comment fix.
12478 * som.h: Added `SOT_NONE'.
12480 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
12482 * vfm.c: (dump_splits) Reimplemented.
12484 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
12486 * Compiled the project under gcc 2.7.2, which gave some new
12487 warnings. This led to many additions of casts from unsigned to
12488 int sprinkled throughout the code.
12490 * arena.c: Many uses of `unsigned' changed to `size_t'.
12492 * command.c: Added END FILE, END REPEAT to command table.
12493 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
12494 (find_command, FILE_TYPE_okay) Not commented out anymore.
12495 (parse_cmd) Calls FILE_TYPE_okay again.
12496 (output_line) Added calls to som_output_text() to put the line
12497 in the output files.
12499 * common.c: (macro VME) Format changes.
12500 (xstrdup) Asserts that its argument is not NULL.
12502 * data-list.c: Implemented dump_fixed_table().
12504 * inpt-pgm.c: Formatting changes. Comment changes.
12505 (end_case_proc) Renamed end_case_trns_proc.
12506 (cmd_end_file, end_file_trns_proc) New functions.
12508 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
12510 * misc.h: (local_strdup) New macro corresponding to strdup() but
12511 allocating its data through local_alloc() if possible--that is, if
12514 * postscript.c: Comment changes.
12515 (quote_ps_name, quote_ps_string, output_encodings) New functions.
12516 (output_line, add_string) New macros supporting
12517 output_encodings().
12518 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
12519 substitution vars. Calls output_encodings() when a line
12520 consisting of `!encodings' is encountered.
12521 (preclose) Some code moved into quote_ps_string().
12522 (dump_line) Changed into macro supporting dump_fancy_line().
12523 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
12524 command when appropriate.
12525 (write_text) Fixed `literal_char' array (I think it's fixed, at
12527 (text) Fixed bug when width was zero. Now exits immediately on
12528 zero height_left. Now, when executing `goto restart;', checks
12529 that cp<end, so that we don't read beyond end-of-string. Also,
12530 outputs the correct code to the output file by outputting the code
12531 from the metric instead of the internal metric index.
12533 * repeat.c: (cmd_end_repeat) New function.
12535 * som.c: (var som) `headers' renamed `options' and semantics
12536 changed. All references changed.
12537 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
12538 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
12540 (som_text_table) Removed.
12541 (som_output_text) New function.
12543 * som.h: (struct som_submission_form) Removed `header', `reuse',
12544 replaced with bitmapped field `options'.
12545 (SOM_TOPT_*) New enum set for som_submission_form.options.
12546 (SOT_*) New enum set for som_output_text().
12548 * temporary.c: (copy_variable) When copying the var label, only
12549 calls xstrdup() if it's non-NULL.
12551 * var.h: (enum type `vartype') Removed; all references changed to
12554 * vars-atr.c: (init_variable) Changed local var `nbytes' from
12557 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
12559 * font.h: Comment changes.
12561 * groff-font.c: (groff_read_font) Initializes `name' field to
12562 NULL. Handles `encoding' field.
12564 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
12566 * postscript.c: (struct font_entry) Removed `position' field.
12567 (struct ps_font_combo) New struct.
12568 (struct ps_driver_ext) Removed field `next_position'. New fields
12569 `combos', `next_combo'. `last_font' field changed from
12570 `font_entry *' to `ps_font_combo *'.
12571 (ps_init_driver) Reformatted; handles new fields. When
12572 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
12574 (get_encoding, find_encoding_file) New functions.
12575 (add_encoding) Some code moved out into find_encoding_file().
12576 (postopen) Changed value for ${title}.
12577 (preclose) Sets `loaded' field to NULL after destroying the hash
12579 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
12581 (ps_text_set_font_by_position) Figures out the current family if
12583 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
12584 (switch_font) Implemented.
12585 (write_text) Calls switch_font() more often. Format changes.
12586 #undefs its macros after they're no longer useful.
12587 (text) Changed `continue' at one point to a jump to the top of the
12588 loop because we don't want `separate' reset to 0 at that point.
12589 (load_font) No longer sets `position' in the font_entry created.
12591 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
12593 * font.h: (struct font_desc) New member `encoding', which is not
12594 properly handled yet.
12596 * glob.c: (init_glob) Some new i18n code, which is probably
12599 * output.c: (outp_read_devices, outp_get_paper_size) Changed
12600 `size' local from `int' to `size_t'.
12602 * postscript.c: New driver configuration parameter `auto-encode'.
12603 New enums OPO_AUTO_ENCODE, ODA_COUNT.
12604 (struct font_entry) New member `position'.
12605 (struct ps_driver_ext) Reordered. New hash table member
12606 `encodings'; new members `next_position', `next_encoding',
12607 `last_font'. Members `current', `prop', `fixed' changed from type
12608 `font_desc *' to `font_entry *'; all references changed.
12609 (struct ps_encoding) New struct.
12610 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
12611 free_ps_encoding, add_encoding) New functions.
12612 (ps_init_driver) Added OPO_AUTO_ENCODE to default
12613 x->output_options. Initializes new members of ps_driver_ext.
12614 Changed default value for prologue_fn, encoding_fn. Calls
12615 read_ps_encodings after loading default fonts.
12616 (option_tab[], ps_option) Handle new configuration parameter.
12617 (switch_font) New function.
12618 (struct output_char) `font' member changed from `font_desc *' to
12619 `font_entry *'. New member `separate'.
12620 (read_fontmap) Changed `size' from `int' to `size_t'.
12621 (output_line, put_number) New macros for write_text().
12622 (write_text) Optimizes text output by consolidating multiple
12623 calls to PostScript `show' operator.
12624 (text) Keeps track of when text arguments can't be consolidated by
12625 write_text(), and marks those spots in the output stream.
12626 (load_font) Sets `position' of the allocated font_entry to -1, cuz
12627 the font hasn't been switched to by switch_font(), which is where
12628 the position is important--the PostScript is what cares about the
12631 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
12633 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
12634 call a NULL free_func.
12635 (hsh_rehash) Elegantized.
12636 (hsh_probe) Fix bug that manifested when the table was expanded
12637 and thus had to change location in memory. Good thing
12638 too--otherwise could have been much more subtle.
12639 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
12640 (hsh_foreach) New function for hash table iteration.
12642 * hash.h: (struct hsh_iterator) New.
12644 * lexer.c: (parse_tagged_quote) Font and family name strings in
12645 tags are now null-terminated.
12647 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
12649 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
12650 documented. (Never before tested?)
12652 * output.h: Comment changes.
12654 * postscript.c: New driver options `optimize-text-size',
12655 `optimize-line-size', `max-fonts-simult'. New enum set for
12656 specing cached line types. Comment fixes.
12657 (struct line_form) New struct.
12658 (struct ps_driver_struct) New members `text_opt', `line_opt',
12659 `max_fonts', `lines'.
12660 (ps_init_driver) Initializes new members of ps_driver_struct.
12661 (user option type enum set) New member `nonneg_int_arg'.
12662 (static var option_tab[]) Supports new options.
12663 (ps_option) Handles new options.
12664 (find_ps_file) Made static. No longer calls hsh_dump().
12665 (ps_get_var) Made static.
12666 (preclose) Dumps out proper DSC trailer.
12667 (ps_open_page) Elegantized.
12668 (ps_close_page) Calls dump_lines() if appropriate.
12669 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
12670 wrappers around line().
12671 (int_2_compare, compare_line, dump_line, dump_fancy_line,
12672 dump_lines, hash_line, free_line, line) New functions for support
12674 (write_text, text) Made static.
12675 (text) Added to font support, not finished.
12677 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
12679 * font.h: (struct font_desc) New members ascent, descent.
12681 * groff-font.c: (groff_read_font) Calculates font ascent and
12682 descent from the ascent and descent of the `d' and `p' characters,
12683 respectively, as per a suggestion on comp.fonts.
12685 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
12686 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
12688 (write_text) Handles text right-justification and centering (not
12689 full justification). Still very inefficient. (One output line
12691 (struct output_char) Added fields for font and font size.
12692 (text) Many bugfixes.
12694 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
12696 * cmdline.c: (usage) Calls outp_list_classes().
12698 * font.h: Comment fix.
12700 * groff-font.c: New exported global var `space_index'.
12701 (groff_init) New function to initialize `space_index'.
12702 (hash_kern) Casts result to unsigned.
12703 (font_name_to_index) Renamed font_char_name_to_index. All
12704 references changed. Also, now returns the value of `space_index'
12705 when passed an ASCII space character as an argument. Fixed
12707 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
12708 Handles passed NULL pointers properly.
12710 * lexer.c: (parse_tagged_quote) Comment fix. Better range
12713 * output.c: (outp_list_drivers) Removed. Removed all references.
12715 * output.h: Comment fixes.
12717 * postscript.c: (ps_open_global) Calls groff_init().
12718 (output_char) New structure.
12719 (write_text) New function.
12720 (text) No longer stubbed out! Now the output is correct--with a
12721 few exceptions, one of them being that the page has to be held
12722 upside down into a mirror.
12724 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
12726 * font.h: Comment fix.
12728 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
12729 All callers changed.
12730 (number_to_index) Renamed font_number_to_index, made extern. All
12732 (font_get_kern_adjust, font_get_char_metrics) New functions.
12734 * output.h: New constant OUTP_T_INTERNAL_DRAW.
12736 * postscript.c: Changed default line width back to 1/2 point.
12737 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
12738 in the center of the space allotted for them, not just a fixed
12739 offset from the edge of the space; this fixes some bugs.
12740 (ps_line_intersection) Now supports all command line styles.
12741 (ps_text_get_size) Bug fix in computation of em width.
12742 (text) New function, the meat behind ps_text_metrics and
12743 ps_text_draw. Not complete.
12744 (ps_text_metrics, ps_text_draw) Removed the stub taken from
12745 ascii.c; call text().
12747 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
12749 * arena.c: (arena_free) Assert that the argument is non-NULL.
12751 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
12752 only if old_kern is non-NULL.
12754 * postscript.c: (ps_init_driver) Changed default line width to 1
12756 (postopen) New prologue variables.
12757 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
12758 more of the common line styles properly, but not all.
12759 (ps_text_metrics) Fixed problem with this stubbed out version that
12760 kept it from taking font sizes into account.
12762 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
12764 * arena.c: (arena_malloc) Bug fix.
12765 (arena_dump) [GLOBAL_DEBUGGING] New function.
12767 * ascii.c: Comment fix.
12768 (count_fancy_chars, delineate) Now static functions.
12770 * filename.c: (interp_vars) Bug fixes.
12772 * font.h: Comment fixes.
12774 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
12775 beginning in case we have an error message to display before
12776 initializing the display.
12778 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
12780 (groff_read_font) Bug fixes.
12781 (name_to_index) Increments hash.used. Sets `name' field of hash
12783 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
12785 * hash.c: Return type changed.
12787 * postscript.c: Continued development. Now marks lines on the
12788 paper, but very buggy.
12790 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
12792 * Changed comments in many source files from `/* xxx /* yyy */' to
12793 `/* xxx */ /* yyy */' for cleanliness.
12795 * arena.c: (arena_sd_strdup) New function.
12797 * ascii.c: (struct ascii_driver_ext) New member `file'.
12798 (ascii_init_driver) Fills out member `file' for initing; uses
12799 close_file_ext for closing drivers.
12800 (ascii_option) Changed %.*s back to %s because the a_string's are
12801 always null-terminated.
12802 (postopen, preclose) New functions.
12803 (ascii_open_page) Uses new style of open_file_ext.
12804 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
12805 instead of this->output.
12806 (__assert_fail) Removed.
12808 * cmdline.c: Changed syntax_message[].
12810 * error.c: #include's <readline/history.h> only if the history
12811 library is available, not if just the readline library is
12814 * filename.c: (expand_line) Removed alloca() support.
12815 (interp_vars) No longer tilde-expands argument. Limit on output
12817 (tilde_expand) Now treats argument as path rather than filename.
12818 [!unix] Now is a no-op function.
12819 (search_path) Better verbose message formatting.
12820 (open_file, close_file) Comment fixes.
12821 (close_file) [!unix] Doesn't bother with pipes.
12822 (open_file_ext) Completely rewritten, interface revamped.
12823 (close_file_ext) New function.
12825 * font.h: Comment changes.
12827 * frequencies.q: Removed AIX alloca support since it doesn't use
12830 * hash.c: Comment changes & additions.
12831 (hsh_create) Initializes entire table instead of first M entries.
12832 (hsh_probe) Stupid bug fixed. Now it works.
12833 (hsh_dump) [GLOBAL_DEBUGGING] New function.
12835 * main.c: (parse) Detects EOF properly in token-eating loop.
12836 Should the STOP token have its value changed to 0?
12838 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12839 (blp_getline) Now it's a macro.
12841 * output.h: (struct outp_driver) Removed members output, filename.
12843 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12844 drivers in driver table.
12845 (outp_read_devices) Frees buf. Warns if there are no active
12847 (outp_configure_clear) Sets outp_configure_vec to NULL after
12848 deleting its elements.
12849 (configure_driver, destroy_driver) Removed references to output,
12850 filename members of outp_driver.
12851 (outp_evaluate_dimension, internal_get_paper_size,
12852 outp_get_paper_size) New functions.
12854 * postscript.c: Continued development. Now links but doesn't make
12855 any marks on the page. Lotsa bugs I suppose.
12857 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12859 * str.h: Comment changes.
12861 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12863 * Removed dependencies on non-nested comments in several files.
12864 Also removed references to (unix || __unix__) in #if's since
12865 prefh.orig makes those two equivalent.
12867 * ascii.c: (ascii_open_global) Creates ascii_arena.
12868 (ascii_close_global) Destroys ascii_arena.
12869 (ascii_init_driver) Doesn't create ascii_arena.
12870 (ascii_copy_driver) Removed.
12871 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12872 (outp_class ascii_class) Removed ascii_copy_driver reference.
12874 * frequencies.q: Now can display all statistics except median.
12875 Still not finished.
12877 * output.c: Handles outp_class.ref_count so output class
12878 destructors are called properly.
12879 (add_class) Sets ref_count to 0.
12880 (configure_driver) Initializes class if ref_count++ is 0.
12881 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12882 class output file name.
12884 * output.h: (struct outp_class) Removed copy_driver, inited.
12887 * postscript.c: Completely replaced but not finished.
12889 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12891 * approx.h: #includes <float.h>.
12893 * arena.h, arena.c: Many functions changed to take an arena **
12894 instead of an arena *, for consistency. All callers changed.
12895 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12896 (arena_destroy) Sets *A to NULL.
12898 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12899 assertion that `width' be positive.
12901 * command.c: Removed #if's from cmd_table.
12902 (walk_cmdtable_func) [0] New function (debug code).
12903 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12904 (parse_cmd) Doesn't return failure for unimplemented commands.
12906 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12907 (SYSCODE) New constant macro.
12909 * descript.q: Checks for positive n_variables before performing
12912 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12913 avl_find instead of &fp as arg 2.
12915 * frequencies.g, frequencies.q: Continued updating; now compiles &
12916 works again, but not complete.
12918 * main.c: Changes to user messages.
12920 * misc.c: (reverse) [0] New function.
12922 * settings.h: Comment removed. #includes "common.h".
12924 * som.c: (som_set_null) New function.
12925 (som_set_value, som_set_string, som_set_text) More detailing
12927 (som_set_float) Implemented function.
12928 (dump_columnated_table) Bug fix regarding page breaks.
12929 (draw_cell) Bug fix regarding text that spilled out of a cell.
12930 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12932 (get_cell_size) Support SCON_EMPTY cells.
12933 (get_table_size) When calculating rules' widths and heights, mask
12934 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12936 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12938 (struct som_submission_form) New member `header'; all users
12941 * val-labs.c: (get_label) User messages changed.
12943 * var.h: Changed FREQUENCIES structures.
12945 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12948 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12950 * approx.h: Definition of EPSILON now depends on system's
12951 DBL_EPSILON. Removed GNU C specific code.
12952 (cmpapx) Renamed approx_compare.
12954 * frequencies.g, frequencies.q: Continued updating; still doesn't
12957 * groff-font.c: (name_to_index) Fix bug that kept it from
12960 * hash.c, hash.h: Completed work.
12962 * var.h: Changes to freq_tab, frequencies_proc.
12964 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12967 * hash.c, hash.h: New files. Not completed.
12968 * Makefile.am: Added hash.c to source file list.
12969 * font.h: (struct font_desc) New member kern_size_p.
12970 * groff-font.c: Uses hash.h.
12971 (hashpjw) Moved to hash.c.
12972 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12974 (static var hash) New member size_p.
12975 * var.h: Includes hash.h.
12976 (struct freq_tab) Changed AVL_TREE to hash_tab.
12978 * vars-prs.c: Comment, formatting fixes.
12980 * frequencies.g, frequencies.q: Continued updating. Not yet
12983 * formats.c: Bug fix.
12985 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12987 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12988 * descript.g: Comment fixes.
12989 * descript.q: Comment fixes. Moved some declarations into var.h.
12990 Made dsc_info a static table. Updated FIXMEs.
12991 (internal_cmd_descriptives) Beautified.
12993 * frequencies.q: Started updating into working order.
12994 * frequencies.g: New file analogous to descript.g.
12995 * var.h: Comment fixes. Added structures for FREQUENCIES.
12997 * som.c: Removed vestiges of crushing and partial table support.
12999 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
13001 * Many more changes to som.c especially, but these will not be
13002 documented as I have resolved to remove them. This patchlevel is
13003 being released solely so that I can fall back to it if I decide
13004 that removing the changes is not a good idea.
13006 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
13008 * som.c: (global var som) New member `cum_y'.
13009 (build_target) Properly handles titles for partial tables.
13010 (dump_partial_beg, dump_partial_mid, dump_partial_end)
13011 Merged into single new function dump_partial(). Fixed problem
13012 with titles on partial tables.
13013 (dump_table) Calls dump_partial() for all parts of partial tables.
13014 (dump_page) Criteria for drawing title changed.
13016 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
13018 * command.c: (cmd_table) Added LIST, WEIGHT.
13020 * command.c: (cmd_remark) No longer frees `s' since it's not
13021 dynamically allocated.
13023 * data-out.c: (convert_f) Now correctly handles the case where
13024 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
13025 number of decimals.
13026 (som_destroy_all_tables) Removed argument. All callers changed.
13027 (som_vline, som_hline) Argument validity checking corrected.
13028 (som_set_value) Implemented half-heartedly.
13029 (replicate_table) Copies tables piece-by-piece when using Checker.
13031 * som.h: New line style SLIN_1THIN, currently equivalent to
13032 SLIN_0. New enum set SOM_SUB_*.
13033 (struct som_submission_form) Removed `seq_no'. Added `type'.
13035 * list.q: Newly working file; uses partial tables.
13037 * som.c: (som_reduce_table) Renamed som_set_table_height().
13038 (som_crush) Removed argument `group'.
13039 (global var som) Removed `nt', `seq_no'. Added `type'.
13040 (som_submit_table) Arguments changed.
13041 (output_table) Removed partial table code.
13042 (build_target) New arg; partial table support added. All callers
13044 (dump_plain_table) Removed partial table code.
13045 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
13046 (dump_table) Supports partial tables.
13047 (dump_page) New argument to allow not drawing top and/or bottom
13048 headers. All callers changed. Supports partial tables.
13050 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
13052 * data-out.c: Changed `#include <approx.h>' to `#include
13054 (convert_F) Comment fix. Now won't print `-.000', etc.
13056 * descript.q: Now Z-scores work, although there appears to
13057 be a bug (which might actually be in data-out.c:convert_F()).
13058 (descriptives_trns_proc, descriptives_trns_free) New functions.
13059 (run_z_pass) Implemented.
13061 * var.h: Comment fixes.
13062 (dsc_z_score, descriptives_trns) New structs.
13063 (descriptives_trns) Added to any_trns as `dsc'.
13065 * error.c, error.h: New error class, IS (Installation Script
13066 error), used in those instances where the error is in the
13067 installation, but there is a script file or installation file that
13068 can be usefully referred to.
13070 * output.c: Change many IE classes to IS classes.
13072 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
13073 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
13074 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
13075 include the corresponding header?
13077 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
13078 Don't bail out if termcap can't be read.
13080 * som.c: (som_destroy_table) Removed.
13081 (som_reduce_table, som_destroy_all_tables) New functions.
13082 (som_crush) New function, not implemented.
13084 * som.h: New table option STAB_CRUSH. Comment fix. New struct
13085 som_submission_form. Function prototypes revised.
13087 Outputting huge tables (1000s of rows) a few rows at a time
13088 is supported, though untested. May even break everything.
13089 Actually, the code doesn't even compile right now.
13090 * som.c: (struct som) New fields htv, nt, seq_no.
13091 (som_submit_table) Multiple arguments changed to a single
13092 pointer to struct submission_form. Only increments subtable_num
13093 if seq_no is zero. Only destroys table if it's not going to
13095 (replicate_table) New function.
13096 (output_table) Comment fix.
13097 (examine_table) Changed inline code to code calling
13098 replicate_table(). Calculates htv. Supports partial tables.
13099 (draw_title) Removed comment.
13100 (build_target) Only allows for title on first part of partial
13102 (dump_plain_table) Only resets table chunk number on first part
13103 of partial tables; FIXME: doesn't work quite right. Supports
13105 (dump_page) Titles only on first part of partial tables.
13107 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
13109 * Thanks to an unreliable IDE hard drive, I have spent the last
13110 day reconstructing my Debian GNU/Linux installation and redoing
13111 the previous day's changes--somehow I managed to save every file
13112 except for output.c and output.h. So the following changes could
13113 really be considered independent of the output.c, output.h changes
13116 * output.h, output.c: Moved the outp_configure_vec global var,
13117 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
13118 outp_configure_vec is now static.
13120 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
13122 * The entire philosophy behind configuration of the output drivers
13123 changed. Now there is a termcap-type configuration where drivers
13124 to be read are determined beforehand, rather than parsing the
13125 entire output init file and storing it in memory & deciding what
13126 to actually use later. Faster & more memory-efficient at the same
13129 * output.c: Comment fix. Removed outp_init_drivers global var.
13130 Removed all references to synonyms. New structure outp_defn. New
13131 global vars outp_macros, outp_configure_vec.
13132 (search_name, delete_name, add_name, check_configure_vec,
13133 expand_name, find_defn_value) New static functions.
13134 (outp_configure_clear, outp_configure_add, outp_configure_macro,
13135 outp_read_devices) New extern functions.
13136 (outp_init) Much functionality moved into outp_read_devices.
13137 (outp_read_devices) Format of output init file changed; name of
13138 file is `devices' rather than `output' to avoid Makefile
13140 (outp_clear) Renamed outp_done.
13141 (outp_list_classes) Bug fix, cleaned up.
13142 (outp_list_drivers) Not implemented anymore.
13143 (outp_configure_driver) Now a static function; simplified; now
13144 interpolates macros; supports new structure.
13145 (outp_enable_driver, match_synonym) Removed; all references
13147 (find_driver) First argument removed.
13149 * output.h: Global var outp_init_drivers removed; new structure
13150 outp_names; new enum set OUTP_S_*; new global var
13151 outp_configure_vec; function prototypes for output.c exports
13154 * main.c: (main) Calls outp_read_devices() after parsing the
13157 * cmdline.c: (parse_command_line) New option -v --verbose;
13158 --version changed to -V. --device option changed syntax to just
13159 take a single device name. Accepts key=value declaration of
13160 output init file macros. Syntax message updated.
13162 * filename.c: (expand_line) New function.
13163 (interp_environ_vars) Renamed interp_vars; no longer uses
13165 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
13166 overridden by real environment vars.
13167 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
13168 * filename.h: interp_environ_vars() renamed interp_vars().
13170 * error.c, error.h: Added extern variable `verbosity', message
13173 * error.c: (vmsg) Support message class MM.
13174 (verbose_msg) New function.
13176 * descript.q: (generate_z_varname) Bug fix in generation of
13178 (dump_z_table) Bug fix in column headers.
13180 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
13181 page from 29 to 15. Don't set a default for ops[OPS_INIT,
13182 OPS_DONE]. Writes the uninit string when the driver is closed.
13183 (ascii_open_page) Write the init string before the first page.
13184 (output_shorts) Form of main loop changed from `while' to `for'.
13185 Bug fix with overstrikes: the character is printed *after* the
13186 backspace. Eliminated a lot of `& 0xff' modifiers.
13187 (advance_to_left_margin) New function.
13188 (return_carriage, output_lines) Handle left margin.
13190 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
13192 * ascii.c: New option `carriage-return-style'.
13194 * ascii.c: (count_fancy_chars) New function.
13195 (delineate, text_metrics) Use new function; bug fixes regarding
13197 (text_draw) Bug fix with rich text.
13198 (output_string, output_shorts) Reordered.
13199 (output_shorts) Now handles boxchars and some overstrike font
13201 (output_char, return_carriage) New functions.
13202 (output_lines) Now handles overstriking and font changes properly;
13203 some code moved to output_shorts.
13205 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
13208 * ascii.c: New member `debug' in ascii_driver_ext.
13209 (ascii_init_driver, delineate) Uses new member.
13211 Now you can set a vertical height on writing text.
13212 * ascii.c: (delineate) Keeps track of vertical position.
13213 (text_draw) No longer considers fully justified text an internal
13216 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
13218 Tables' titles are drawn; they can have variable height.
13219 * som.c: `som' struct has new member, title_height.
13220 (draw_title) New argument. Moved within file. All caller
13222 (build_target) New argument, amount of space needed for first row.
13223 Calculates height of title, takes that into account. All callers
13225 (dump_plain_table, dump_columnated_table) Took calculation of y1,
13227 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
13229 (dump_columnated_table) Organized for readability.
13230 (dump_page) Makes use of som.title_height.
13232 * som.c: Many comment bug fixes.
13234 * descript.q: (try_name, generate_z_name) Bug fix regarding
13235 generation of Z-score variable names.
13236 * var.h: Removed num from descriptives_proc; all referents removed.
13238 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
13240 * ascii.c: (ascii_line_horz, ascii_line_vert,
13241 ascii_line_intersection) Added debugging code.
13243 Added a descriptive line above each table to describe it.
13244 * command.c: (parse_cmd) Calls som_new_series.
13246 * som.c: New static vars table_num, subtable_num. New `som'
13248 (dump_page) New arguments.
13249 (som_submit_table) Handle new variables.
13251 * som.c, som.h: (som_submit_table) New arguments. All callers
13253 (som_new_series) New function.
13254 (build_target) Makes room for extra line.
13255 (draw_title) New function.
13256 (dump_page) Calls draw_title. Bug fix: doesn't always set
13259 Columnation of tables support.
13260 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
13262 * som.c: Deleted references to fr, lr, ri.
13263 (som_columnate) Bux fix: sets group member of table.
13264 (som_add_options) Function removed.
13265 (dump_table) Split into three functions; extensively reworked.
13267 * descript.q: (dump_z_table) Better output table formatting; added
13268 title support to correspond to som.h changes.
13269 (display) Title support.
13271 * output.h: Added OUTP_T_NONE.
13273 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
13275 * descript.q: Improved handling of Z scores; still not perfect.
13277 * output.h, ascii.c: Added hook for getting em width of current
13280 * som.c: Uses new em-width hook. Added debugging code to
13282 (som_columnate) New argument.
13283 (som_add_options) Removed.
13285 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
13287 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
13288 rules as a property of the table instead of as a property of the
13291 * ascii.c: Added `header' to table of options.
13293 * descript.q: Added even shorter statistic names; modified to work
13294 with new som interface.
13296 * misc.c (blp_getdelim): Bug fix.
13298 * version.c: includes 'conf.h'.
13300 ----------------------------------------------------------------------
13303 version-control: never