1 2007-09-18 Ben Pfaff <blp@gnu.org>
3 * procedure.c (proc_extract_active_file_data): New function.
5 * lazy-casereader.h: New file.
7 * lazy-casereader.c: New file.
9 * casereader.c (casereader_dynamic_cast): New function.
11 2007-09-14 Ben Pfaff <blp@gnu.org>
13 * dictionary.c (dict_clone): Copy case indexes from cloned
14 dictionary. Fixes bug #21061. Reviewed by John Darrington.
16 2007-09-13 John Darrington <john@darrington.wattle.id.au>
18 * value.c value.h (create_value): New function.
20 2007-09-12 Ben Pfaff <blp@gnu.org>
22 Make it clear that translator casereader and casewriter translate
23 functions are supposed to destroy their input case.
25 * casereader-translator.c (struct casereader_translator): Change
26 input case parameter of translate member function from const
27 struct ccase * to struct ccase *.
28 (casereader_create_translator): Ditto, for translate parameter.
30 * casewriter-translator.c (struct casewriter_translator): Ditto.
31 (casewriter_create_translator): Ditto.
33 2007-08-27 John Darrington <john@darrington.wattle.id.au>
35 * sys-file-reader.c (read_display_parameters): Force display width
36 to 8, if the sys file says 0 (like SPSS does).
38 2007-08-12 Ben Pfaff <blp@gnu.org>
40 * dictionary.c (dict_dump): New function.
42 2007-08-12 Ben Pfaff <blp@gnu.org>
44 Drop dict_compactor in favor of using the new struct case_map.
46 * dictionary.c (struct copy_map): Removed.
47 (struct dict_compactor): Removed.
48 (dict_make_compactor): Removed.
49 (dict_compactor_compact): Removed.
50 (dict_compactor_destroy): Removed.
52 * procedure.c (struct data_set): Change `compactor' member to be a
54 (proc_open): Use case_map_to_compact_dict instead of
56 (proc_casereader_read): Use case_map_execute instead of
57 dict_compactor_compact.
58 (proc_commit): Use case_map_destroy instead of
59 dict_compactor_destroy.
61 * scratch-writer.c (struct scratch_writer): Change `compactor'
62 member to be a struct case_map *.
63 (scratch_writer_open): Use case_map_to_compact_dict instead of
65 (scratch_writer_casewriter_write): Use case_map_execute instead of
66 dict_compactor_compact.
68 2007-08-12 Ben Pfaff <blp@gnu.org>
70 * automake.mk: Add case-map.c, case-map.h.
72 * case-map.c: New file.
74 * case-map.h: New file.
76 2007-08-12 Ben Pfaff <blp@gnu.org>
78 * dictionary.c (dict_compact_values): Don't delete scratch
79 variables as well as compacting case indexes. Update all callers.
80 (dict_get_compacted_value_cnt): Rename dict_count_values and
81 change interface. Update all callers.
82 (dict_get_compacted_value_cnt): Remove.
83 (dict_compacting_would_shrink): Remove.
84 (dict_compacting_would_change): Remove.
85 (dict_make_compactor): Add new parameter. Update all callers.
87 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
88 instead of dict_count_values, changing an O(N) operation into
91 2007-08-12 Ben Pfaff <blp@gnu.org>
93 * casereader.c (casereader_read): Don't require cases read by a
94 casereader to be exactly the expected size: as long as they're big
97 2007-08-12 Ben Pfaff <blp@gnu.org>
99 Make casewriters keep track of the number of `union value's in
100 each case. This is useful for two reasons: casewriter_write can
101 then check that the case being written is large enough, and later
102 recipients of the casewriter can determine the size of the case.
104 * casewriter-translator.c (casewriter_create_translator): Add
107 * casewriter.c (struct casewriter): Add value_cnt member.
108 (casewriter_write): Check that the case passed in is big enough.
109 (casewriter_get_value_cnt): New function.
110 (casewriter_create): Add value_cnt parameter.
112 2007-08-09 Ben Pfaff <blp@gnu.org>
114 Fix bug reported by Jason Stover.
115 * settings.c: Move get_termcap_viewport and in particular the
116 #include for <curses.h> to the end of the file. curses.h
117 redefines bool on some systems (e.g. OpenBSD), which causes
118 disagreement between uses of bool before its inclusion and
120 Tested by Jason Stover.
122 2007-07-29 Ben Pfaff <blp@gnu.org>
124 Provisional fix for bug #18692 and bug #20161. Reviewed by John
127 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
128 argument (never "rb" or "wb") because SUSv3 says that only those
129 modes are defined, and glibc in fact rejects other modes.
131 Open portable files with fn_open so that they can be read from
132 pipes. Fix missing fh_close call to go along with fh_open.
133 Report an error if the file close reports an error.
134 * por-file-reader.c (close_reader): New function.
135 (por_file_casereader_destroy): Use close_reader.
136 (pfm_open_reader): Open file with fn_open.
138 2007-07-28 Ben Pfaff <blp@gnu.org>
140 Make PSPP able to read all the portable files I could find on the
141 web. Thanks to John Darrington for review. Bug #17620.
142 * por-file-reader.c (struct pfm_reader): New member `line_length'.
143 (error): Print file offset in hexadecimal.
144 (warning): New function.
145 (advance): Treat lines less than 80 bytes long as padded to 80
147 (pfm_open_reader): Call read_documents if we find an "E" record.
148 (convert_format): Convert invalid formats to the default format
149 instead of aborting reading the file.
150 (read_variables): Rename duplicate variable names instead of
151 aborting reading the file.
152 (read_value_label): Allow string variables of different widths to
153 be assigned value labels in the same record. Replace duplicate
154 value labels instead of aborting.
155 (read_documents): New function.
157 * por-file-writer.c (pfm_open_writer): Call write_documents if the
158 dictionary has documents.
159 (write_documents): New function.
161 2007-07-25 Ben Pfaff <blp@gnu.org>
163 Fix bugs related to bug #17213.
165 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
166 since the former is what config.h has. Include the needed ncurses
168 (static var echo) Rename to `do_echo' because the original name is
169 the same as an ncurses identifier.
170 (get_termcap_viewport) Use error instead of msg.
172 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
173 (fn_close): Don't close stdin, stdout, stderr.
175 2007-07-26 John Darrington <john@darrington.wattle.id.au>
177 * procedure.c procedure.h: Added callbacks which get invoked whenever
178 a dataset's transformation chain changes.
180 2007-07-24 Ben Pfaff <blp@gnu.org>
183 * sys-file-writer.c (write_variable_display_parameters): Use new
184 var_default_display_width function to choose display width of
185 segments after the first one in a given variable.
186 * variable.c (var_create): Use var_default_display_width to pick
187 new variable's display width.
188 (var_default_display_width): New function.
189 Reviewed by John Darrington.
191 2007-07-24 Ben Pfaff <blp@gnu.org>
194 * por-file-writer.c (write_variables): Write weight variable.
195 Reviewed by John Darrington.
197 2007-07-23 Ben Pfaff <blp@gnu.org>
199 Improvements to system file reader and writer.
201 First, move all detailed knowledge of very long strings into
202 sys-file-private.[ch], so that this nasty stuff can be isolated.
204 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
205 (EFFECTIVE_VLS_CHUNK): New macro.
206 (min_int): New function.
207 (max_int): New function.
208 (sfm_width_to_bytes): Rewrite.
209 (sfm_width_to_octs): New function.
210 (sfm_segment_alloc_width): New function.
211 (sfm_segment_alloc_bytes): New function.
212 (sfm_segment_used_bytes): New function.
213 (sfm_segment_offset): New function.
214 (sfm_segment_effective_offset): New function.
215 (sfm_dictionary_to_sfm_vars): New function.
217 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
218 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
219 (struct sfm_var): New structure.
221 Next, improvements to the system file reader.
223 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
224 type casenumber. Added `version_major', `version_minor',
227 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
228 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
229 Change `case_cnt' to type casenumber. Removed `has_vls'.
230 (struct sfm_var): Removed.
231 (sfm_open_reader): Don't warn on wrong case size if the file was
232 written by SPSS 13, which tends to get it wrong. Use
233 sfm_dictionary_to_sfm_vars.
234 (read_header): Always output system file info.
235 (read_variable_record): Simplify code for reading missing values.
236 (read_machine_int32_info): Save version numbers from system file
237 into info struct passed as new argument.
238 (read_long_string_map): Restructured to use new sys-file-private
240 (read_value_labels): Use size_overflow_p.
241 (sys_file_casereader_read): Get rid of distinction between fast
242 and slow paths. Use information provided by sys-file-primate's
243 struct sfm_var to simplify code.
244 (skip_whole_strings): New function.
245 (read_int32): Renamed read_int. Changed return value to int.
247 (read_flt64): Renamed read_float. Changed return value to
248 double. Updated all callers.
249 (int32_to_native): Removed. Changed callers to use
251 (flt64_to_double): Removed. Changed callers to use float_convert.
253 Finally, get rid of int32, flt64 terminology and types in system
254 file writer. The former wasn't very useful since a POSIX "int"
255 can hold the whole range of int32 and we generally didn't have a
256 need for it to be exactly-32-bits, just at-least-32-bits. The
257 latter was inconvenient because we had to assume that it could be
258 different from double and thereby convert special values SYSMIS,
259 HIGHEST, LOWEST to and from it in multiple places. Instead, now
260 we just use "int" and "double" in most places, and do conversions,
261 if necessary, very close to where we do I/O. This change meant
262 that the writer code couldn't represent records in the file as C
263 structs any longer, but that's no great loss. The code actually
264 seems to be more readable without them.
266 Simplify the compression buffering code: only buffer as much as
267 necessary, which is no more than eight 8-byte units at any given
270 * sys-file-writer.c (typedef flt64): Removed.
271 (macro second_lowest_flt64): Removed.
272 (struct sysfile_header): Removed.
273 (struct sysfile_variable): Removed.
274 (struct sfm_writer): Removed `needs_translation', `has_vls',
275 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
276 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
277 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
278 compression buffering by `opcodes', `opcode_cnt', `data',
279 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
280 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
281 data writer functions instead of structures.
282 (calc_oct_idx): New function.
283 (write_header): Use simple data writer functions instead of
285 (write_format_spec): Renamed write_format. New argument.
286 (write_variable_continuation_records): New function.
287 (write_variable): Use simple data writer functions instead of
288 structures. Use write_variable_continuation_records. Write
289 entire very long string instead of requiring caller to understand
291 (write_value_labels): Use simple data writer functions instead of
293 (write_documents): Ditto.
294 (write_variable_display_parameters): Use sys-file-private
295 functions to simplify. Use simple data writer functions instead
297 (write_vls_length_table): Use simple data writer functions instead
299 (write_longvar_table): Ditto.
300 (write_rec_7_34): Break into new functions
301 write_integer_info_record, write_float_info_record. Use simple
302 data writer functions instead of structures.
303 (buf_write): Removed.
304 (append_string_max): Removed.
305 (ensure_buf_space): Removed.
306 (sys_file_casewriter_write): Get rid of the distinction between
307 fast and slow paths, which didn't seem to be too useful. Use new
308 functions write_case_uncompressed, write_case_compressed.
309 (put_instruction): Removed.
310 (put_element): Removed.
311 (write_compressed_data): Removed.
312 (close_writer): Use flush_compressed. Only write case count to
313 system file if it will fit in the field.
314 (write_case_compressed): New function.
315 (write_case_uncompressed): New function.
316 (flush_compressed): New function.
317 (put_cmp_opcode): New function.
318 (put_cmp_number): New function.
319 (write_int): New function.
320 (convert_double_to_output_format): New function.
321 (write_float): New function.
322 (write_value): New function.
323 (write_string): New function.
324 (write_bytes): New function.
325 (write_zeros): New function.
326 (write_spaces): New function.
328 Reviewed by John Darrington.
330 2007-07-22 Ben Pfaff <blp@gnu.org>
332 Don't try to write very long strings to portable files. The
333 format does not support it.
335 * por-file-writer.c (MAX_POR_WIDTH): New macro.
336 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
337 (write_format): Add arg to take width to resize format to.
338 (write_value): Limit width of value written to MAX_POR_WIDTH.
339 (write_variables): Limit width of variable and its output formats
341 Reviewed by John Darrington.
343 2007-07-22 Ben Pfaff <blp@gnu.org>
345 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
346 local variable instead of literal 5.
347 Reviewed by John Darrington.
349 2007-07-22 Ben Pfaff <blp@gnu.org>
351 Fix problems with uniqueness of short names in system files with
352 very long string variables. Now a variable may have multiple
355 * automake.mk (src_data_libdata_a_SOURCES): Add new files
356 short-names.c, short-names.h.
358 * dictionary.c (dict_clone): Clone all the short names.
359 (compare_strings): Move into short-names.c.
360 (hash_strings): Ditto.
361 (set_var_short_name_suffix): Ditto.
362 (dict_assign_short_names): Ditto, rename short_names_assign,
363 change to assign all short names.
365 * por-file-writer.c (write_variables): Use short_names_assign
366 instead of dict_assign_short_names.
368 * short-names.c: New file.
370 * short-names.h: New file.
372 * sys-file-private.c (sfm_width_to_segments): New function.
374 * sys-file-reader.c (read_long_var_name_map): Save and restore all
375 the short names, not just the first one.
377 * sys-file-writer.c (cont_var_name): Removed.
378 (sfm_open_writer): Use short_names_assign instead of
379 dict_assign_short_names. Use unique short names assigned by
380 short_names_assign instead of those generated by cont_var_name.
382 * variable.c (struct variable): Remove `short_name' member,
383 replace by `short_names' and `short_name_cnt'.
384 (var_create) Initialize new members.
385 (var_get_short_name_cnt): New function.
386 (var_get_short_name): Now takes an index argument. Changed most
388 (var_set_short_name): Ditto.
389 (var_clear_short_name): Renamed var_clear_short_names, changed to
390 clear all short names.
392 Reviewed by John Darrington.
394 2007-07-22 Ben Pfaff <blp@gnu.org>
396 * variable.c (var_set_width): Use new var_set_width function.
398 * missing-values.c (mv_n_values): Drop assertion, which was not
401 * format.c (fmt_default_for_width): New function.
402 (fmt_resize): New function.
404 Reviewed by John Darrington.
406 2007-07-18 John Darrington <john@darrington.wattle.id.au>
408 * datasheet.c (datasheet_delete_columns): Added assertion to check
409 we're not deleting outside the range of the sheet.
412 * dictionary.c dictionary.h variable.c: Added the ability for string
413 variables to be resized.
415 * vardict.h: Added some prototypes (moved from dictionary.h) as
416 these should only be called by variable.c
419 2007-07-14 John Darrington <john@darrington.wattle.id.au>
421 * sfm-reader.c: Respect case_cnt field in file header.
423 2007-07-01 John Darrington <john@darrington.wattle.id.au>
425 * transformation.c transformation.h (trns_chain_execute): Changed the
426 signature (Patch #6057)
428 2007-06-10 Ben Pfaff <blp@gnu.org>
430 * casereader-filter.c (casereader_filter_destroy): Make sure to
431 write all the remaining excluded cases to the casewriter, if any.
433 * caseinit.c (init_list_destroy): Rewrite.
434 (init_list_clear): Ditto.
436 * casegrouper.c (casegrouper_get_next_group): Always set *reader
437 to null when returning false.
439 2007-06-06 Ben Pfaff <blp@gnu.org>
441 Actually implement the new procedure code and adapt all of its
442 clients to match. Also adapt all of the other case sources and
443 sinks in the tree and their clients to use the
444 casereader/casewriter infrastructure.
446 * automake.mk: Add and remove files.
448 * any-reader.c: Change into a casereader.
449 * por-file-reader.c: Ditto.
450 * scratch-reader.c: Ditto.
451 * sys-file-reader.c: Ditto.
453 * any-writer.c: Change into a casewriter.
454 * por-file-writer.c: Ditto.
455 * scratch-writer.c: Ditto.
456 * sys-file-writer.c: Ditto.
458 * procedure.c: Change to use casereader, casewriter, caseinit, and
459 other new infrastructure.
461 * scratch-handle.c: Adapt to new infrastructure.
463 * case-sink.c: Removed, now dead code.
464 * case-sink.h: Ditto.
465 * case-source.c: Ditto.
466 * case-source.h: Ditto.
467 * casefile-factory.c: Ditto.
468 * casefile-private.h: Ditto.
471 * casefilter.c: Ditto.
472 * casefilter.h: Ditto.
475 * fastfile-factory.c: Ditto.
476 * fastfile-factory.h: Ditto.
477 * storage-stream.c: Ditto.
478 * storage-stream.h: Ditto.
480 2007-06-06 Ben Pfaff <blp@gnu.org>
484 * automake.mk: Add new files.
486 * datasheet.c: New file.
488 * datasheet.h: New file.
490 2007-06-06 Ben Pfaff <blp@gnu.org>
492 Until now, the procedure code has provided a case to the
493 case_source, which has filled in the data values that come from
494 the active file. "Left" data values that don't come from the
495 active file naturally stay the same from case to case, because the
496 procedure code keeps using that same case.
498 One of the compromises that comes with the new procedure code is
499 that the active file allocates and provides its own case, which
500 the procedure code then has to resize to provide room for any
501 other variables that should go in the case and then fill in the
502 values of "left" variables. Then, when we're done with that case,
503 we have to save the values of "left" variables to copy into the
504 next case read from the active file.
506 The caseinit code helps with this.
508 * automake.mk: Add new files.
510 * caseinit.c: New file.
512 * caseinit.h: New file.
514 2007-06-06 Ben Pfaff <blp@gnu.org>
516 * value.h (value_cnt_from_width): New function.
518 * variable.c (var_get_value_cnt): Use new function.
520 2007-06-06 Ben Pfaff <blp@gnu.org>
522 Add casegrouper, to allow cases read from a given casereader to be
523 broken into groups, each of which has its own casereader.
524 Generally cases are grouped based on having equal values for some
527 * automake.mk: Add new files.
529 * casegrouper.c: New file.
531 * casegrouper.h: New file.
533 2007-06-06 Ben Pfaff <blp@gnu.org>
535 Add interface to lexicographical ordering of cases.
537 * automake.mk: Add new files.
539 * case-ordering.c: New file.
541 * case-ordering.h: New file.
543 2007-06-06 Ben Pfaff <blp@gnu.org>
545 Add casereaders and casewriters, the basis of the new data processing
546 implementation. A casereader is a uniform interface to reading cases
547 from a data source; a casewriter is a uniform interface to writing
548 cases to a data sink.
550 * automake.mk: Add new files.
552 * casereader-filter.c: New file.
554 * casereader-provider.h: New file.
556 * casereader-translator.c: New file.
558 * casereader.c: New file.
560 * casereader.h: New file.
562 * casewriter-provider.h: New file.
564 * casewriter-translator.c: New file.
566 * casewriter.c: New file.
568 * casewriter.h: New file.
570 2007-06-06 Ben Pfaff <blp@gnu.org>
572 "casewindow" data structure that extends the deque (from libpspp)
573 of cases with the ability to dump cases to disk if we get too many
576 * automake.mk: Add new files.
578 * casewindow.c: New file.
580 * casewindow.h: New file.
582 2007-06-06 Ben Pfaff <blp@gnu.org>
584 sparse_cases data structure that augments a sparse_array of cases
585 with the ability to dump cases to disk if we get too many cases in
588 * automake.mk: Add new files.
590 * sparse-cases.c: New file.
592 * sparse-cases.h: New file.
594 2007-06-06 Ben Pfaff <blp@gnu.org>
596 Adds a low-level on-disk case array data structure.
598 * automake.mk: Add new files.
600 * case-tmpfile.c: New file.
602 * case-tmpfile.h: New file.
604 2007-06-06 Ben Pfaff <blp@gnu.org>
606 In a couple of places we calculate the maximum number of cases to
607 keep in memory based on the user-defined workspace. Enable
608 centralizing the calculation through a new function.
610 * settings.c (get_workspace_cases): New function.
612 2007-06-06 Ben Pfaff <blp@gnu.org>
614 The casenumber type is defined in transformations.h, but case.h is
615 a more sensible place. Move it.
617 * case.h (CASENUMBER_MAX): New macro.
618 (typedef casenumber): Move here, from transformations.h.
620 2007-06-03 Ben Pfaff <blp@gnu.org>
622 Slightly generalize case_to_values and case_from_values functions.
624 * case.c (case_to_values): Rename case_copy_out, change interface.
625 (case_from_values): Rename case_copy_in, change interface.
627 * fastfile.c (fastfilereader_get_next_case): Update caller.
628 (write_case_to_disk): Ditto.
630 2007-06-02 Ben Pfaff <blp@gnu.org>
632 Clean up after a forgotten part of patch #5829.
634 * casedeque.h: Remove unused file.
636 * automake.mk: Remove casedeque.h from sources.
638 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
640 * category.c: Removed redundant #include
642 2007-05-06 Ben Pfaff <blp@gnu.org>
644 Abstract the documents within a dictionary a little better.
645 Thanks to John Darrington for suggestion, initial version, and
648 * dictionary.c (struct dictionary): Change `documents' member from
649 char * to struct string.
650 (dict_clear): Destroy struct string.
651 (dict_get_documents): Convert struct string to char *.
652 (dict_set_documents): Set struct string. Pad to 80-character
654 (dict_clear_documents): New function.
655 (dict_add_document_line): New function.
656 (dict_get_document_line_cnt): New function.
657 (dict_get_document_line): New function.
659 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
661 * sys-file-reader.c (read_documents): Use new document functions.
663 2007-04-19 John Darrington <john@darrington.wattle.id.au>
665 * sys-file-reader.c: When reading a system file which has no
666 long name table, automatically create one where the long names
667 are the lower case versions of the short names.
669 2007-04-22 Ben Pfaff <blp@gnu.org>
671 * dictionary.c (dict_set_split_vars): dict_destroy expects that
672 dict_clear will free most data related to the dictionary.
673 dict_clear does a decent job, except that dict_set_split_vars on
674 some systems won't actually free the dict's "split" member.
675 Instead, it'll allocate a 1-byte region. Fix this.
677 * value.c (value_copy): New function.
678 (value_set_missing): Ditto.
680 2007-04-22 John Darrington <john@darrington.wattle.id.au>
682 * Deleted existing category.h and moved cat-routines.h into
683 category.h Encapsulated struct cat_vals better.
685 2007-04-19 John Darrington <john@darrington.wattle.id.au>
687 * sys-file-reader.c: When reading a system file which has no
688 long name table, automatically create one where the long names
689 are the lower case versions of the short names.
691 2007-04-16 John Darrington <john@darrington.wattle.id.au>
693 * sys-file-reader.c: Some versions of Other Software seem to
694 produce system files with string variables' measure set to
695 zero. We'll assume these are supposed to be nominal variables.
697 2007-03-30 Ben Pfaff <blp@gnu.org>
699 * procedure.c: Adapt to new deque data structure.
701 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
702 Ben Pfaff <blp@gnu.org>
704 * file-name.c: Mingw compatibility fixes.
705 (fn_search_path): Use ISSLASH instead of comparing against '/'
707 (fn_dir_name): Use dir_name from gnulib.
708 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
709 (fn_get_identity): Use GetFullPathName instead of canonicalize
710 from gnulib, because the latter does not fully support
711 Windows-style path names. Use this implementation based on the
712 detected presence of Windows instead of the absence of Unix, since
713 the new implementation is Windows-specific.
714 (fn_compare_file_identities): In Windows implementation, compare
715 names case-insensitively.
717 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
719 * make-file.c: Don't include mkstemp.h, because gnulib now causes
720 <stdlib.h> to have the same effect.
722 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
724 * por-file-reader.c: Add missing _() around messages.
726 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
728 * make-file.c: Include "mkstemp.h", without which linking on
731 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
733 Reduce platform dependence.
735 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
736 Everywhere we using this, we really should have just depended on
737 the shell to expand tildes.
738 (fn_search_path): Simplify, given that we don't do tilde expansion
740 (fn_normalize): Removed. Caller changed to use the canonicalize
742 (fn_get_cwd): Removed. Only user was fn_normalize.
743 (fn_is_absolute): Really only test for absolute names.
744 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
746 (fn_readlink): Removed, as it was only used fn_normalize.
747 (fn_exists): Assume the stat function is available; gnulib does.
748 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
750 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
752 * dictionary.c (dict_create_vector_assert): New function.
754 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
756 * file-name.c (fn_normalize): Correct name of function
757 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
758 for pointing this out.
760 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
762 We are using a single member in struct file_handle, the "name"
763 field, for more than one purpose. When it begins with '"', it's a
764 file name; otherwise, it's a token that can be used to identify
765 it. When that assertion fires, it's because we searched for the
766 name case-sensitively as a file name (so that there was no match),
767 and then we try to insert it case-insensitively as a token, which
768 fails because duplicates aren't allowed.
770 Solution: break the two purposes into two separate fields. This
771 fixes the problem and likely makes the code easier to read too.
773 Fixes bug #18922. Thanks to John Darrington for bug report and
776 * file-handle-def.c (struct file_handle): New `id' member.
777 (fh_from_name): Rename fh_from_id. Update all callers.
778 (create_handle): New `id' parameter. Update all callers.
779 (fh_create_file): Ditto.
780 (fh_get_id): New function.
782 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
784 * case.c (case_is_null): Change return type to bool.
786 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
790 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
791 reference counting to share data. This makes it easy for
792 valgrind, etc. to find accesses to cases that have been destroyed
793 but have been kept around by another user's ref-count. This often
794 happens when the data set is small enough to find in memory; if a
795 bigger data set that would overflow to disk were used, then data
796 corruption would occur.
798 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
802 * case.c (case_unshare): Make it check internally whether the
803 ref_cnt is greater than 1, so that the callers don't have to.
804 Update callers not to check.
806 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
808 Before, I was thinking that I might want to get rid of reference
809 counting at some point. Now, I'm pretty sure that it's here to
810 stay. Thus, because we have to store the value_cnt anyway for
811 reference-counted cases, we might as well expose it to users.
813 * case.c (case_get_value_cnt): New function.
814 (case_resize): Drop OLD_CNT argument. Update all callers. Only
815 resize case if its size actually changed.
817 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
818 instead of peeking inside struct case directly.
819 (casefile_append): Ditto.
821 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
823 Get rid of the inlines for the case functions, which made the
824 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
825 the inlines didn't speed up "make check" at all, which is not a
826 perfect benchmark but seems indicative.)
828 * case.c: Remove #ifdef DEBUGGING...#endif around many function
829 definitions. Remove some assertions on nonnull pointers that were
830 redundant with a pointer dereference soon after in the function.
832 (struct case_data): Move definition here from case.h.
836 (case_data_wr): Ditto.
838 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
840 * automake.mk: Add casedeque.h to sources.
842 * casedeque.h: New file.
844 * procedure.c: (struct dataset) Change lag_count, lag_head,
845 lag_queue member into single struct casedeque member. Update all
846 users to use the casedeque instead.
849 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
851 * procedure.c: Simplify lagged cases interface. Updated all
852 clients--well, the only client--to use the simplified interface.
853 (dataset_n_lag) Removed.
854 (dataset_set_n_lag) Removed.
855 (dataset_need_lag) New function.
857 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
859 * dictionary.c procedure.c: More changes to ensure that callbacks occur
860 whenever appropriate, but only when the dataset/dictionary is in a
863 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
865 * dictionary.c dictionary.h : Added callbacks for change of filter and
866 split variables. Refactored some code to ensure that callbacks get
867 invoked when appropriate.
869 * procedure.c (proc_cancel_temporary_transformations): Make sure that
870 replace_dict callback occurs when permanent_dict replaces the current
873 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
875 * dictionary.c dictionary.h : Added callback for when the weight
876 variable of a dictionary changes.
878 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
880 * dictionary.c dictionary.h : Added replace_source and replace_dict
881 callbacks, and functions to deal with them.
883 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
885 Simplify missing value handling.
887 * missing-values.h (enum mv_class): New type.
888 (enum mv_type): Moved definition into missing-values.c and renamed
889 each MV_* to MVT_*, to distinguish them from the exposed mv_class
890 enums. Updated all uses.
891 (struct missing_values): Changed type of `type' from `enum
892 mv_type' to `int' because the definition is no longer exposed.
894 * missing-values.c (mv_is_value_missing): Add new enum mv_class
895 parameter. Update all callers.
896 (mv_is_num_missing): Ditto.
897 (mv_is_str_missing): Ditto.
898 (mv_is_value_user_missing): Removed. Changed callers to use
900 (mv_is_num_user_missing): Removed. Changed callers to use
902 (mv_is_str_user_missing): Removed. Changed callers to use
904 (mv_is_value_system_missing): Removed. Changed callers to use
906 (mv_set_type): Removed. Changed callers to use mv_clear.
907 (mv_clear): New function.
909 * variable.c (var_is_value_missing): Add new enum mv_class
910 parameter. Update all callers.
911 (var_is_num_missing): Ditto.
912 (var_is_str_missing): Ditto.
913 (var_is_value_user_missing): Removed. Changed callers to use
914 var_is_value_missing.
915 (var_is_num_user_missing): Removed. Changed callers to use
917 (var_is_str_user_missing): Removed. Changed callers to use
919 (var_is_value_system_missing): Removed. Changed callers to use
920 var_is_value_missing.
922 * casefilter.c (struct casefilter): Use enum mv_class in place of
924 (casefilter_variable_missing): Adapt to new member.
925 (casefilter_create): Change signature to take enum mv_class,
928 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
930 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
932 * case-sink.c case-sink.h procedure.c procedure.h
933 storage-stream.c: Now uses the factory.
935 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
937 Make it possible to pull cases from the active file with a
938 function call, instead of requiring indirection through a callback
941 * case-source.h (struct case_source_class): Change ->read function
942 to return a single case, instead of calling a callback function
943 for each case. Change ->destroy function to return an error
946 * case-source.c (free_case_source): Pass along the value returned
947 by the case_source ->destroy function.
949 * procedure.c (struct write_case_data): Removed.
950 (struct dataset): Added some members to track procedure state.
951 (procedure): Optimize the trivial case at this level.
952 (internal_procedure): Re-implement in terms of proc_open,
953 proc_read, proc_close.
954 (proc_open) New function.
955 (proc_read) New function.
956 (proc_close) New function.
957 (write_case) Moved into proc_read.
958 (close_active_file) Moved closing of data source into proc_close.
960 * storage-source.c: Rewrote to conform with modified
961 case_source_class interface.
963 * transformations.c (trns_chain_execute): Added argument to allow
964 starting execution from an arbitrary transformation. Updated
967 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
969 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
971 * sys-file-reader.c (read_display_parameters): Don't assume that
972 MEASURE_* and ALIGN_* have the same values found in system files.
974 * sys-file-writer.c (write_variable_display_parameters): Ditto.
976 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
977 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
978 the value of n_MEASURES, which was off by 1 (at least from my
981 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
983 * dictionary.c dictionary.h vardict.h variable.c: Added optional
984 callbacks which are invoked when the dictionary or its
985 variables are changed.
987 * missing-values.c missing-values.h value-labels.c: Tidied up
988 consistency checks, and made some of them return false
989 instead of assert-failing.
991 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
993 * calendar.c (calendar_days_in_month): New function.
995 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
997 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
998 the value label's width.
1000 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
1002 * sfm-private.h: Move contents into sys-file-writer.c, which is
1003 the only remaining user. Removed Borland C++-specific directives.
1005 * sys-file-reader.c: Clean up and rewrite entire file. The
1006 rewritten version is simpler and better abstracted, and should be
1007 easier to maintain and extend. It avoids using structures to read
1008 file data, which is prone to padding variations among compilers.
1009 It should also handle non-IEEE 754 system files, although I
1010 haven't been able to find any. It has been tested against many
1011 .sav files obtained from the Web and found to produce the same
1012 results as the earlier version of the code, or in some cases
1013 improved results. It is more tolerant of format variations found
1016 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
1017 member, putting an enum integer_format in its place. New member
1018 `float_format'. Changed `compressed' member to type bool.
1020 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
1022 * dictionary.c (dict_delete_consecutive_vars): New function.
1024 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
1026 * file-name.c (fn_search_path): Remove prefix arg that was unused
1027 by any caller. Updated all callers.
1029 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
1031 * format.c (fmt_dollar_template): Use user's decimal point
1032 character. Add assertion.
1034 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
1036 * format.c (fmt_dollar_template): New function, based on
1037 dollar_format_template from var-type-dialog.c.
1039 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1041 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1044 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1046 Finish converting struct variable to an opaque type. In this
1047 phase, we add remaining setter and getter functions, convert the
1048 remaining PSPP code to use them, and do a bunch of cleanup. The
1049 resulting changes are pervasive but mostly trivial, and only the
1050 notable changes are logged.
1052 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1055 * case.c (case_data): Renamed case_data_idx.
1056 (case_num): Renamed case_num_idx.
1057 (case_str): Renamed case_str_idx.
1058 (case_data_rw): Renamed case_data_rw_idx.
1060 * case.h (case_data): New function with old name and an interface
1061 that takes a variable instead of an index, which is easier to
1062 use. Updated all callers to use the new interface, or to use the
1063 new *_idx function (see above).
1066 (case_data_rw): Ditto.
1068 * category.c (cat_stored_values_destroy): Changed interface to
1069 take a struct cat_vals * instead of a struct variable *.
1071 * dictionary.c (dict_clone): Use new vector_clone function.
1072 (dict_clear) Use new var_destroy function.
1073 (add_var) New function.
1074 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1075 (dict_create_var_assert) Rewrite in terms of add_var.
1076 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1077 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1078 (dict_lookup_var) Use new var_create, var_destroy functions.
1079 (dict_contains_var) Rewrite in terms of new vardict functionality.
1080 (set_var_dict_index) New function.
1081 (set_var_case_index) New function.
1082 (reindex_vars) New function.
1083 (dict_delete_var) Rewrite in terms of new vardict functionality.
1084 (dict_reorder_var) Ditto.
1085 (dict_reorder_vars) Ditto.
1086 (rename_var) New function.
1087 (dict_rename_var) Use rename_var.
1088 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1089 (dict_get_compacted_idx_to_fv) Rename
1090 dict_get_compacted_dict_index_to_case_index, update callers.
1091 (dict_create_vector) Use new vector_create function.
1092 (dict_clear_vectors) Use new vector_destroy function.
1093 (set_var_short_name_suffix) Move here from variable.c, renamed
1094 from var_set_short_name_suffix, make static, update caller.
1096 * sys-file-private.c: New file.
1097 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1098 width_to_bytes, update callers.
1100 * sys-file-private.h: New file. Later it will supplant
1101 sfm-private.h; for now it supplements it.
1102 (macro MIN_VERY_LONG_STRING) New macro.
1103 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1105 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1106 MAX_LONG_STRING was used before.
1108 * sys-file-writer.c: Ditto.
1110 * value-labels.c: Change the paradigm here to be that a null
1111 pointer is OK for a struct val_labs * in most cases; it just
1112 represents an empty set of value labels.
1113 (val_labs_copy) A copy of a null set is a null set.
1114 (val_labs_count) A null set has 0 labels.
1115 (val_labs_replace) Change return type to void. Rewrite for
1117 (val_labs_find) A null set does not contain the value.
1118 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1119 transposed argument order, updated all callers.
1121 * value.c: New file.
1122 (value_dup) Moved here from variable.c.
1123 (compare_values) Ditto.
1126 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1127 (macro MAX_LONG_STRING) Removed, because it was only interesting
1128 for system files, not for general code.
1129 (macro MAX_VERY_LONG_STRING) Ditto.
1130 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1131 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1133 * vardict.h: New file, for an interface between variables and
1136 * variable.c: A lot of functions were moved around, for better
1138 (struct variable) Move definition here, from variable.h.
1139 (var_type_adj) Removed--makes i18n hard.
1140 (var_type_noun) Ditto.
1141 (var_create) New function.
1142 (var_clone) New function.
1143 (var_destroy) New function.
1144 (var_set_name) Assert that variable is not in a dictionary.
1145 (compare_var_names) Rename compare_vars_by_name and fix a couple
1146 of callers who thought the args were strings.
1147 (hash_var_name) Rename hash_var_by_name.
1148 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1149 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1150 (var_is_very_long_string) Removed, because it was only interesting
1151 to system file code.
1152 (var_set_missing_values) Allow the argument to be the wrong width,
1153 as long as we can resize it. Simplify callers who were doing the
1154 resizing themselves.
1155 (var_get_value_labels) New function.
1156 (var_has_value_labels) New function.
1157 (var_set_value_labels) New function.
1158 (alloc_value_labels) New function.
1159 (var_add_value_label) New function.
1160 (var_replace_value_label) New function.
1161 (var_clear_value_labels) New function.
1162 (var_lookup_value_label) New function.
1163 (var_get_value_name) Moved here from variable.c, renamed from
1164 var_get_value_name, transposed argument order, updated all
1166 (var_to_string) Moved here, from variable-label.c.
1167 (var_set_leave) New function.
1168 (var_get_leave) New function.
1169 (var_must_leave) New function.
1170 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1171 set_var_short_name_suffix.
1172 (var_get_dict_index) New function.
1173 (var_get_case_index) New function.
1174 (var_get_obs_vals) New function.
1175 (var_set_obs_vals) New function.
1176 (var_has_obs_vals) New function.
1177 (var_get_vardict) New function.
1178 (var_set_vardict) New function.
1179 (var_has_vardict) New function.
1180 (var_clear_vardict) New function.
1181 (value_dup) Moved to value.c.
1182 (compare_values) Ditto.
1185 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1186 (enum ALPHA) Rename VAR_STRING, update all users.
1188 * vector.c: New file.
1189 (struct vector) Moved here, from variable.h.
1190 (check_widths) New function.
1191 (vector_create) New function.
1192 (vector_clone) New function.
1193 (vector_destroy) New function.
1194 (vector_get_name) New function.
1195 (vector_get_var) New function.
1196 (vector_get_var_cnt) New function.
1197 (compare_vector_ptrs_by_name) New function.
1199 * vector.h: New file.
1201 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1203 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1204 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1207 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1209 * value-labels.c (destroy_atoms): New function.
1210 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1212 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1214 Thanks to Jason Stover for pointing out this problem.
1216 * data-out.c (output_number): Use gsl_finite from GSL, which is
1217 portable, instead of isfinite, which is not.
1220 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1222 * variable.c variable.h (value_dup): New function.
1224 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1226 Start converting struct variable to an opaque type. In this
1227 phase, we add a bunch of setter and getter functions and convert
1228 most of the PSPP code to use them. The resulting changes are
1229 pervasive but mostly trivial, and only the notable changes are
1232 * format.c (fmt_equal): New function.
1234 * variable.c (var_type_is_valid): New function.
1235 (measure_is_valid) Moved here, from format.c.
1236 (alignment_is_valid) Moved here, from format.c.
1237 (var_get_name) New function.
1238 (var_set_name) New function.
1239 (width_to_type) New function.
1240 (var_get_type) New function.
1241 (var_get_width) New function.
1242 (var_set_width) New function.
1243 (var_is_numeric) New function.
1244 (var_is_alpha) New function.
1245 (var_is_short_string) New function.
1246 (var_is_long_string) New function.
1247 (var_is_very_long_string) New function.
1248 (var_get_missing_values) New function.
1249 (var_set_missing_values) New function.
1250 (var_clear_missing_values) New function.
1251 (var_has_missing_values) New function.
1252 (var_is_value_missing) New function.
1253 (var_is_num_missing) New function.
1254 (var_is_str_missing) New function.
1255 (var_is_value_user_missing) New function.
1256 (var_is_num_user_missing) New function.
1257 (var_is_str_user_missing) New function.
1258 (var_is_value_system_missing) New function.
1259 (var_get_print_format) New function.
1260 (var_set_print_format) New function.
1261 (var_get_write_format) New function.
1262 (var_set_write_format) New function.
1263 (var_set_both_formats) New function.
1264 (var_get_label) New function.
1265 (var_set_label) New function.
1266 (var_clear_label) New function.
1267 (var_has_label) New function.
1268 (var_get_measure) New function.
1269 (var_set_measure) New function.
1270 (var_get_display_width) New function.
1271 (var_set_display_width) New function.
1272 (var_get_alignment) New function.
1273 (var_set_alignment) New function.
1274 (var_get_value_cnt) New function.
1275 (var_get_leave) New function.
1276 (var_get_short_name) New function.
1278 * variable.h: (struct variable) Removed "type" and "nv" members;
1279 they are now computed from "width" where needed.
1281 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1283 * missing-values.c (mv_resize): Don't write beyond end of the
1284 allocated buffer when resizing a long string.
1286 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1288 Clean up identifier code: don't require identifier enumerations to
1289 be in a particular order; make better use of string library;
1290 expose less of the internals.
1292 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1293 change interface. Updated all callers.
1294 (lex_id_match) Change interface to use struct substring, update
1296 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1297 (global array keywords[]) Make static, change form. Update all
1298 users to use lex_id_name instead.
1299 (lex_is_keyword) New function.
1300 (lex_id_to_token) Change interface to use struct substring, update
1302 (lex_id_name) New function.
1304 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1305 lex_is_keyword instead.
1306 (T_LAST_KEYWORD) Removed.
1307 (T_N_KEYWORDS) Removed.
1309 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1311 * format.c: (fmt_date_template) Distinguish characters for which a
1312 space is output and any date delimiter is allowed on input, from
1313 those for which a space is output and only a space is allowed on
1314 input. The former is represented by X, the latter by a space.
1315 Also, drop distinction between h and H, changing the former to the
1318 * data-in.c: Completely rewrite internals to conform to SPSS input
1319 formats as closely as possible.
1320 (data_in) Changed external interface by replacing the structure
1321 that was used as a single argument by a set of arguments. Updated
1323 (data_in_finite_line) Removed. Converted all callers to use plain
1325 (data_in_get_integer_format) New function.
1326 (data_in_set_integer_format) New function.
1327 (data_in_get_float_format) New function.
1328 (data_in_set_float_format) New function.
1330 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1331 (struct data_in) Removed.
1333 * data-out.c: (output_date) Drop each component from the input as
1334 it is output, to allow us to drop the distinction between h (a
1335 count of hours) and H (the hour of day) template characters.
1336 Also, handle new X template character.
1337 (output_scientific) Follow more rational rule on when to drop
1338 fraction introduced between SPSS 13 and 15. Updated test case to
1341 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1343 Fix buffer overflow reported by John Darrington.
1345 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1346 realize that DIGITS is a count of nibbles, not of bytes.
1348 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1350 * calendar.c (calendar_offset_to_gregorian) Also return the
1351 year-of-day. Change callers to new interface.
1353 * data-out.c: Completely rewrite internals to conform to SPSS
1354 output formats as completely as possible.
1355 (data_out) Change interface to put input parameters before output
1356 parameters, for consistency with the style I now prefer. Update
1358 (data_out_get_integer_format) New public function.
1359 (data_out_set_integer_format) New public function.
1360 (data_out_get_float_format) New public function.
1361 (data_out_set_float_format) New public function.
1363 * data-out.h: New file. Move prototype for data_out here, from
1366 * format.c: (fmt_step_width) Use equality comparison instead of
1367 bitwise and, for clarity.
1368 (fmt_is_string) Ditto.
1369 (fmt_input_to_output) Fix categories that are translated to F
1372 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1374 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1375 casefile-private.h: Added casefilter to assist commands with missing
1378 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1380 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1382 * settings.c: (route_errors_to_terminal) New variable.
1383 (route_errors_to_listing) New variable.
1384 (get_error_routing_to_terminal) New function.
1385 (set_error_routing_to_terminal) New function.
1386 (get_error_routing_to_listing) New function.
1387 (set_error_routing_to_listing) New function.
1389 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1391 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1393 * format.c: Completely rewrite, to achieve better abstraction.
1394 Rewrite all references to formats in other files.
1396 * format.def: Rewrite and reorganize.
1398 * settings.c: Move everything related to custom currency formats
1399 into format.[ch], changing them in form, so as to group related
1400 code and definitions better. Changed all references to use the
1402 (static var decimal) Removed.
1403 (static var grouping) Removed.
1404 (static var cc) Removed.
1405 (get_decimal) Removed.
1406 (set_decimal) Removed.
1407 (get_grouping) Removed.
1408 (set_grouping) Removed.
1412 * settings.h: (macro CC_CNT) Removed.
1413 (macro CC_WIDTH) Removed.
1414 (struct custom_currency) Removed.
1416 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1418 * data-in.c (data_in): Use switch statement instead of table, to
1419 avoid dependence on the order of the FMT_* enums.
1421 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1423 * data-out.c: (num_to_string) Removed, because it was dead code.
1425 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1427 * data-in.c (parse_trailer): Fix error message.
1429 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1431 * format.c (fmt_is_binary): New function.
1433 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1435 * procedure.c procedure.h: Encapsulated the static data into a single
1438 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1440 * casefile.c (casereader_read_xfer): Always initialize the case,
1441 even on an error condition.
1443 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1445 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1446 entire function useless.
1448 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1450 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1451 casereader method casereader_clone.
1453 * procedure.c pransformations.h: Introduced new type casenum_t
1455 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1457 * variable.c: (width_to_bytes) Rephrase code for clarify.
1459 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1461 * format.c: (fmt_type_from_string) New function.
1462 (fmt_to_string) Include decimals in output if the format has
1463 decimals, even if the format type does not. This way, we can
1464 accurately reproduce incorrect formats in user output.
1465 (check_common_specifier) Make the check for a bad format type an
1466 assertion, so we get bug reports if they show up. Fix message.
1467 Check for decimal places with a format type that doesn't allow
1469 (check_input_specifier) Remove check for FMT_X, which has been
1471 (check_output_specifier) Ditto.
1473 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1475 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1476 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1477 (enum fmt_parse_flags) Removed.
1479 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1481 * casefile.c casefile.h: Converted to an abstract base class.
1482 * casefile-private.h fastfile.c fastfile.h: New files.
1483 * automake.mk procedure.c scratch-writer.c storage-stream.c
1485 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1487 * procedure.c (internal_procedure): Create sink_case with only as
1488 many values as the compacted dictionary.
1490 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1492 Remove "debugging" code that caused plenty of false positives and
1495 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1497 * case.c: Remove all references to `this' member.
1499 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1501 Fix link error noted by Jason Stover.
1503 * storage-stream.c: Include <assert.h>.
1505 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1507 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1508 ALL) and additional underlying system file issues.
1510 Thanks to John Darrington for review.
1512 First problem: var_hash points to variables not owned by the
1513 sys-file-reader, which the caller may free or modify. Use an
1514 array of sfm_vars instead, as done earlier (e.g. CVS version
1517 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1518 members and remove all code that references it. Add vars, var_cnt
1519 members. Remove fix_specials member, which was unused.
1520 (struct sfm_var) Remove name member, which was unused.
1521 (sfm_close_reader) Free vars member instead of var_hash.
1522 (compare_var_shortnames) Removed.
1523 (hash_var_shortname) Removed.
1524 (sfm_open_reader) Fill out vars array.
1525 (compare_var_index) Removed.
1526 (sfm_read_case) Use vars instead of var_hash.
1528 Second problem: we're confused about when we actually have very
1529 long strings, causing us to choose incorrectly between slow path
1530 and fast path in sfm_read_case.
1532 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1533 have very long strings, not when we have long variable names,
1534 which is an unrelated feature.
1536 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1538 * variable.h: Move var_set and variable parsing declarations to
1539 new header, src/language/lexer/variable-parser.h. Modified lots
1540 of files to include the new header.
1542 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1544 * value-labels.c (value_to_string): When there's no value label,
1545 format the variable according to its print format, instead of
1546 always effectively using A or F format.
1548 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1550 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1553 * format.c: Removed tortological assertion.
1555 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1557 Reform string library.
1559 * file-name.c (fn_interp_vars): Change interface to take a
1560 substring as input. Updated all users.
1562 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1564 * format.c (measure_is_valid): Really return false when m >=
1567 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1569 Implement random access to casefiles, for use in GUI.
1571 * casefile.c: (struct casereader) Add `random', `file_ofs',
1572 `buffer_ofs' members.
1573 (casefile_get_random_reader) New function.
1574 (read_open_file) Break part into new function
1575 seek_and_fill_buffer().
1576 (fill_buffer) Update buffer_ofs, file_ofs.
1577 (casereader_seek) New function.
1579 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1581 * settings.c: Added call to i18n{done, init}.
1583 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1585 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1588 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1590 * casefile.c: Convert many uses of `int' to `bool'.
1592 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1594 * transformations.c (trns_chain_destroy): Destroy chain's trns
1595 member, to fix memory leak.
1597 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1599 * storage-stream.c (storage_source_decapsulate): Destroy case
1600 source to fix memory leak.
1602 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1604 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1605 case passed as argument instead of initializing the argument as a
1606 case. Fixes memory leak that showed up in
1607 tests/command/aggregate.sh with scratch files.
1609 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1611 * procedure.c (proc_done): Destroy default_dict, to fix memory
1614 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1616 Simplify procedure_with_splits().
1618 * procedure.c (struct split_aux_data): Removed case_count member.
1619 (procedure_with_splits) Don't initialize case_count.
1620 (split_procedure_case_func) Check whether prev_case is null
1621 instead of case_count.
1622 (split_procedure_end_func) Ditto.
1624 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1626 * case.c (case_move): Do nothing if dst and src are the same
1628 (case_try_create) Merge two similar cases.
1629 (case_copy) Unshare only if data must be actually copied.
1631 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1633 * data-in.c data-out.c dictionary.c sys-file-reader.c
1634 sys-file-writer.c variable.c variable.h: Reworked very long string
1635 support for better encapsulation.
1637 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1639 * value-labels.c (val_labs_can_set_width): New function.
1640 (val_labs_set_width) Clear labels if increasing width to long
1642 (val_labs_destroy) Remove unneeded test for null.
1644 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1646 * value-labels.h: Remove unneeded dependency on variable.h.
1648 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1650 Get rid of `char *c' member in union value, for cleanliness.
1652 * value.h: (union value) Remove `c' member.
1654 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1656 Make dictionary compacting functions a little more general.
1658 * sys-file-writer.c (sfm_open_writer): Use
1659 dict_compacting_would_change().
1660 (does_dict_need_translation) Removed.
1662 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1664 Make dictionary compacting functions a little more general.
1666 * dictionary.c (dict_needs_compaction): Rename
1667 dict_compacting_would_shrink(). Update all callers.
1668 (dict_compacting_would_change) New function.
1670 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1672 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1673 inverted return value (!).
1675 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1677 Continue reforming procedure execution.
1679 * procedure.c: Search and replace "vfm" by "proc". Notably:
1680 (static var vfm_source) Rename proc_source. Update all
1682 (static var vfm_sink) Rename proc_sink. Update all references.
1684 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1686 Continue reforming procedure execution. In this phase, remove
1687 PROCESS IF, which was deprecated anyway and can be easily
1688 simulated with TEMPORARY followed by SELECT IF.
1690 * procedure.c: (open_active_file) Don't call
1691 add_process_if_trns().
1692 (discard_variables) Get rid of redundant call to
1693 proc_cancel_all_transformations().
1694 (add_process_if_trns) Removed.
1695 (process_if_trns_proc) Removed.
1696 (process_if_trns_free) Removed.
1698 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1700 Continue reforming procedure execution. In this phase, add
1701 `const' to the case passed to procedure()'s callback.
1703 Updated all users of procedure() as well.
1705 * procedure.c: (struct write_case_data) Add "const" to ccase
1706 parameter for case_func member.
1707 (procedure) Add "const" to ccase parameter for proc_func
1709 (multipass_case_func) Make ccase parameter const.
1710 (internal_procedure) Add "const" to ccase parameter for case_func
1712 (split_procedure_case_func) Make ccase parameter const.
1713 (multipass_split_case_func) Make ccase parameter const.
1715 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1717 Continue reforming procedure execution. In this phase, get rid of
1718 the output code for SPLIT FILE groups in procedure.c, which really
1719 shouldn't be doing any output. Move it into the individual
1720 procedures instead. This also adds some flexibility.
1722 Updated many users of procedure_with_splits() and
1723 multipass_procedure_with_splits() to call
1724 output_split_file_values() and to deal with increased use of
1727 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1728 parameter to begin_func member.
1729 (procedure_with_splits) Add "const struct ccase *" parameter to
1730 begin_func parameter. Make ccase parameter const in proc_func
1732 (split_procedure_case_func) Don't dump split file group. Pass
1734 (dump_splits) Moved to language/dictionary/split-file.c as
1735 output_split_file_values().
1736 (struct multipass_split_aux_data) Add "const struct ccase *"
1737 parameter to split_func member.
1738 (multipass_procedure_with_splits) Add "const struct ccase *"
1739 parameter to split_func parameter.
1740 (multipass_split_case_func) Save new SPLIT FILE case before
1742 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1744 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1746 Continue reforming procedure execution. Change
1747 internal_procedure() so that it calls open_active_file() and
1748 close_active_file(), which isolates most of the actual procedure
1751 * procedure.c: (struct write_case_data) Rename `proc_func' member
1752 to `case_func' and update all references.
1753 (procedure) Rewrite as one-line wrapper around
1754 internal_procedure().
1755 (struct multipass_aux_data) New.
1756 (multipass_callback) Renamed multipass_case_func(). Use struct
1757 multipass_aux_data as auxiliary data.
1758 (multipass_end_func) New function.
1759 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1760 that uses multipass_case_func, multipass_end_func.
1761 (internal_procedure) Add `end_func' argument. Move optimization
1762 of trivial case in here. Move call to open_active_file() and
1763 close_active_file() in here. Now assert that vfm_source is
1765 (procedure_with_splits_callback) Rename
1766 split_procedure_case_func().
1767 (split_procedure_end_func) New function.
1768 (multipass_split_callback) Rename multipass_split_case_func.
1769 (multipass_split_end_func) New function.
1770 (discard_variables) No need to test for nonnull vfm_source.
1772 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1774 Continue reforming procedure execution. Get rid of unused member.
1776 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1778 (write_case) Don't increment cases_analyzed.
1780 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1782 Continue reforming procedure execution. In this phase, move
1783 procedure.c and procedure.h from src to src/data. Update
1784 makefiles and #includes accordingly.
1786 * procedure.c: Moved here from src/.
1788 * procedure.h: Moved here from src/.
1790 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1792 Continue reforming procedure execution. In this phase, get rid of
1793 many global variables, consolidating procedure execution in
1794 procedure.c. Encapsulate transformations in new "struct
1795 trns_chain". Also, change implementation of N OF CASES, FILTER,
1796 and PROCESS IF from special cases to transformations.
1798 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1801 * dictionary.c: (global variable default_dict) Move to
1804 * variable.h: (TRNS_*) Move to transformations.h.
1805 (struct transformation) Move to transformations.c.
1807 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1809 * sys-file-reader.c: Fixed invalid read problems.
1811 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1813 * storage-stream.c: Add missing function comments.
1815 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1817 Continue reforming procedure execution. In this phase, add some
1818 new, needed functionality to storage-stream.
1820 * storage-stream.c: (storage_source_decapsulate) New function.
1822 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1824 * variable.c (width_to_bytes): Declarations must precede
1825 statements for C90 compliance.
1827 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1829 * data-out.c, data-in.c, variable.c, variable.h: New functions
1830 copy_mangle and copy_demangle for reading/writing cases; emulates the
1831 way SPSS deals with strings > 255 bytes.
1833 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1834 subtype 14 needed for strings longer than 255 bytes.
1836 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1837 instead of literal values. Also fixed some constness issues.
1839 * format.h: Constness
1841 * sfm-private.h: Renamed the case_size identifier, since I discovered
1842 that SPSS's respect for this variable is very nominal.
1844 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1846 Change case limit type from int to size_t.
1848 * dictionary.c: (struct dictionary) Change type of case_limit
1850 (dict_get_case_limit) Change return type.
1851 (dict_set_case_limit) Change parameter type.
1853 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1855 * variable.h: (struct variable) Rename `reinit' member as `leave'
1856 and invert sense. Fix up all references.
1858 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1860 Continue reforming procedure execution. In this phase, break
1861 procedure.c into multiple files.
1863 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1865 * case-sink.c: New file.
1867 * case-sink.h: New file.
1869 * case-source.c: New file.
1871 * case-source.h: New file.
1873 * storage-stream.c: New file.
1875 * storage-stream.h: New file.
1877 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1879 * variable.h: (struct variable) Remove `init' member and all
1880 references to it from other files. It was initialized in several
1881 places, but nothing really ever used it for anything worthwhile.
1882 Thanks to Jason Stover for pointing out how confusing this
1885 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1887 Continue reforming error message support. In this phase, get rid
1888 of message "titles" and put the message text in `struct error'.
1889 Now `struct error' encapsulates a message more properly.
1891 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1892 Format message ourselves.
1894 * data-in.c: (vdls_error) Ditto.
1896 * por-file-reader.c: (error) Ditto.
1898 * sys-file-reader.c: (corrupt_msg) Ditto.
1900 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1902 GNU standards require "file name" instead of "filename" in
1903 documentation. It's nice for our code to follow the convention
1906 * casefile.c: (struct casefile) Rename `filename' member to
1907 `file_name'. Updated all references.
1909 * file-name.c: [!unix] (struct file_identity) Rename
1910 normalized_filename member to normalized_file_name. Updated all
1913 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1915 We don't really support anything but Unix-like environments well,
1916 so we might as well de-obfuscate by writing directory and path
1917 separators explicitly.
1919 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1921 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1922 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1924 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1927 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1929 GNU standards require "file name" instead of "filename" in
1930 documentation. It's nice for our code to follow the convention
1933 * filename.c: Rename to file-name.c.
1935 * filename.h: Rename to file-name.h. Update all inclusions.
1936 Update header guards.
1938 * automake.mk: Update file names.
1940 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1942 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1944 (fn_basename) Removed (dead code).
1945 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1946 (fn_special_p) Renamed fn_is_special(), all references updated.
1947 (fn_exists_p) Renamed fn_exists(), all references updated.
1949 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1951 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1952 Also, now it only tilde-expands file names, not paths.
1953 (fn_search_path) Tilde-expand one directory at a time.
1955 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1957 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1958 get rid of non-Unixlike version of the code, which has probably
1960 (fn_prepend_dir) Removed (dead code).
1962 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1963 (macro PATH_SEPARATOR_STRING) New.
1964 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1966 Continue reforming error message support. In this phase, we get
1967 rid of VM() and the other msg() support for "verbosity", replacing
1968 it by a new function verbose_msg().
1970 * filename.c: (fn_search_path) Use verbose_msg() instead of
1973 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1975 * sfm-private.h: Get rid of #defines after #error, which makes no
1978 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1980 Get rid of our own int32 type in favor of the standard int32_t
1983 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1986 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1988 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1990 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1992 Remove ill-considered file routines that are no longer used.
1994 * filename.c: (fn_open_ext) Removed.
1995 (fn_close_ext) Removed.
1997 * filename.h: (struct file_ext) Removed.
1999 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
2001 * variable.c (var_is_valid_name): Move declarations before code
2004 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
2006 * filename.ch (fn_interp_vars): Fixed small buglet.
2008 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
2010 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
2011 so as to modify the string inline. Thus makeing it easier to
2012 destroy the results when no longer needed.
2014 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
2016 * category.c (cat_stored_values_destroy): Fixed memory leak.
2018 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
2020 Add some missing frees. Thanks to John Darrington for reporting
2023 * any-writer.c (any_writer_close): Free writer.
2025 * any-reader.c (any_reader_close): Free reader.
2027 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
2029 * por-file-reader.c: (error) Mark as NO_RETURN.
2031 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
2033 * settings.c: Changed default value of scompress to true.
2035 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
2037 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
2039 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2042 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2043 here from pref.h.orig.
2045 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2047 * sys-file-reader.c: Fixed bug reading compressed files.
2049 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2051 * Numerous renames. See src/ChangeLog for details.
2053 * Moved files from src directory