pspp
6 years agospv-file-format: Improve description of structure member format.
Ben Pfaff [Sun, 16 Jul 2017 18:21:02 +0000 (11:21 -0700)]
spv-file-format: Improve description of structure member format.

6 years agotests: Use path search for zip-test instead of full path.
Ben Pfaff [Sun, 16 Jul 2017 03:11:06 +0000 (20:11 -0700)]
tests: Use path search for zip-test instead of full path.

This allows "check-valgrind" to work properly since it relies on putting
wrappers early in $PATH.

6 years agoUpdate to newest Gnulib.
Ben Pfaff [Sat, 15 Jul 2017 22:10:38 +0000 (15:10 -0700)]
Update to newest Gnulib.

Harry Thijssen reported an issue with the previous version on Windows.
John Darrington suggested an update, since the Gnulib developers have been
working through related problems.

6 years agodoc/statistics.texi: Add comma after @xref.
John Darrington [Sat, 15 Jul 2017 04:11:28 +0000 (06:11 +0200)]
doc/statistics.texi: Add comma after @xref.

Apparently older versions of makeinfo insist on this.

Reported-by: Harry Thijssen
Fix-by: Ben Pfaff
6 years agotests: Avoid failure based on encoding name differences.
Ben Pfaff [Thu, 13 Jul 2017 03:48:16 +0000 (20:48 -0700)]
tests: Avoid failure based on encoding name differences.

glibc and Mac OS X call the ASCII encoding by different names, which caused
differing output and a test failure.  This fixes the problem.

Reported by Jeremy Lavergne.

6 years agospv-file-format: Add much more detail.
Ben Pfaff [Thu, 13 Jul 2017 00:48:26 +0000 (17:48 -0700)]
spv-file-format: Add much more detail.

6 years agozip-reader: Use xstrdup() instead of strdup().
Ben Pfaff [Mon, 10 Jul 2017 20:49:13 +0000 (13:49 -0700)]
zip-reader: Use xstrdup() instead of strdup().

6 years agoMove XML declarations to the start of .ui files.
John Darrington [Sat, 8 Jul 2017 20:26:29 +0000 (22:26 +0200)]
Move XML declarations to the start of .ui files.

Apparently xgettext complains if comments start the file.

6 years agoFix erroneous subsitute by previous commit.
John Darrington [Sat, 8 Jul 2017 04:29:43 +0000 (06:29 +0200)]
Fix erroneous subsitute by previous commit.

Commit 691a034d7f2139076fa012739dffd40ef5db4a9b  inadvertenntly
commented out the first line of every .at file.  This commit
fixes that.

6 years agoAdd copyright and licence notices to files which lack them.
John Darrington [Wed, 5 Jul 2017 19:02:56 +0000 (21:02 +0200)]
Add copyright and licence notices to files which lack them.

The savannah hackers have been recently complaining about lack of copyright/licence notices.

6 years agotests: Add tests against regression for two previously fixed bugs.
Ben Pfaff [Tue, 4 Jul 2017 17:13:15 +0000 (13:13 -0400)]
tests: Add tests against regression for two previously fixed bugs.

6 years agosys-file-reader: Fix integer overflows in parse_long_string_missing_values().
Ben Pfaff [Tue, 4 Jul 2017 16:58:55 +0000 (12:58 -0400)]
sys-file-reader: Fix integer overflows in parse_long_string_missing_values().

Crafted system files caused integer overflow errors that in turn caused
aborts.  This fixes the problem.

CVE-2017-10791.
See also https://bugzilla.redhat.com/show_bug.cgi?id=1467004.
See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866890.
See also https://security-tracker.debian.org/tracker/CVE-2017-10791.
Found by team OWL337, using the collAFL fuzzer.

6 years agosys-file-reader: Avoid null dereference skipping bad extension record 18.
Ben Pfaff [Tue, 4 Jul 2017 16:54:47 +0000 (12:54 -0400)]
sys-file-reader: Avoid null dereference skipping bad extension record 18.

read_record() assumed that read_extension_record() never set its output
argument to NULL when it returned true, but this is possible in an error
case.

CVE-2017-10792.
See also https://bugzilla.redhat.com/show_bug.cgi?id=1467005.
See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866890.
See also https://security-tracker.debian.org/tracker/CVE-2017-10792.
Reported by team OWL337, with fuzzer collAFL.

6 years agoUpdate version number to 0.10.5-pre2.
Ben Pfaff [Tue, 27 Jun 2017 22:10:00 +0000 (18:10 -0400)]
Update version number to 0.10.5-pre2.

This prerelease is to update the Gnulib version, to fix the GCC 7 problems.

6 years agoREADME.Git: Recommend newer Gnulib, to avoid GCC 7 segfaults.
Ben Pfaff [Tue, 27 Jun 2017 21:54:42 +0000 (17:54 -0400)]
README.Git: Recommend newer Gnulib, to avoid GCC 7 segfaults.

Reported by Matthias Klose <doko@debian.org>
at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853623.

Bug #51318.

6 years agoperl-module: Avoid VERSION redefinition warning from compiler.
Ben Pfaff [Tue, 27 Jun 2017 21:52:40 +0000 (17:52 -0400)]
perl-module: Avoid VERSION redefinition warning from compiler.

If the PSPP version includes a suffix like "-pre1", then Perl will strip
that suffix from the version it passes to the compiler using -DVERSION=...,
and <config.h> will re-define it with the full version string.  This causes
a warning.

This change avoids the warning.  I am not yet aware of a new problem that
it causes.

6 years agoEnable the show value labels feature
John Darrington [Fri, 23 Jun 2017 10:06:57 +0000 (12:06 +0200)]
Enable the show value labels feature

6 years agoFACTOR: Improve calculation of Kaiser-Meyer-Olkin and add a test
John Darrington [Mon, 19 Jun 2017 10:44:16 +0000 (12:44 +0200)]
FACTOR: Improve calculation of Kaiser-Meyer-Olkin and add a test

6 years agoFACTOR: Add Anti-image matrix output
John Darrington [Sun, 18 Jun 2017 19:34:47 +0000 (21:34 +0200)]
FACTOR: Add Anti-image matrix output

6 years agoUpdated German translation from translationproject.org
John Darrington [Sat, 17 Jun 2017 04:49:55 +0000 (06:49 +0200)]
Updated German translation from translationproject.org

6 years agoAdd documentation for MATRIX DATA /N
John Darrington [Sat, 17 Jun 2017 04:48:28 +0000 (06:48 +0200)]
Add documentation for MATRIX DATA /N

6 years agoMATRIX DATA: Add /N subcommand
John Darrington [Fri, 16 Jun 2017 09:34:27 +0000 (11:34 +0200)]
MATRIX DATA: Add /N subcommand

6 years agoAllow dialog boxes to be cancelled by hitting the Escape key.
John Darrington [Thu, 15 Jun 2017 14:48:19 +0000 (16:48 +0200)]
Allow dialog boxes to be cancelled by hitting the Escape key.

Closes bug #51225

6 years agoFixed perl regression problem due to Version name - Fixes Bug #51218
Friedrich Beckmann [Sun, 11 Jun 2017 18:56:35 +0000 (20:56 +0200)]
Fixed perl regression problem due to Version name - Fixes Bug #51218

The regression failed in some perl tests due to an incompatible
pspp version number. I changed to a version number that includes
a "-". The problem is described in acinclude.m4. See

  The PSPP autobuilder appends a build number to the PSPP version number,
  e.g. "0.7.2-build40".  But Perl won't parse version numbers that contain
  anything other than digits and periods, so "-build" causes an error.  So we
  define $(VERSION_FOR_PERL) that drops everything from the hyphen onward.
  VERSION_FOR_PERL=`echo "$VERSION" | sed 's/-.*//'`
  AC_SUBST([VERSION_FOR_PERL])

The version name was 0.10.5pre1 without a "-". Therefore the version name
for perl results in a problem.

6 years agoChange the return type of psppire_delimited_text_new.
John Darrington [Thu, 8 Jun 2017 05:14:04 +0000 (07:14 +0200)]
Change the return type of psppire_delimited_text_new.

... and deal with the consequences.

6 years agoImport assistant: Disable the search function of treeviews
John Darrington [Wed, 7 Jun 2017 18:57:13 +0000 (20:57 +0200)]
Import assistant: Disable the search function of treeviews

6 years agoWhitespace changes only
John Darrington [Wed, 7 Jun 2017 12:23:29 +0000 (14:23 +0200)]
Whitespace changes only

6 years agoPsppireDelimitedText (count_delims): Make the iteration multibyte character safe
John Darrington [Wed, 7 Jun 2017 12:15:15 +0000 (14:15 +0200)]
PsppireDelimitedText (count_delims): Make the iteration multibyte character safe

6 years agoPsppireDelimitedText (count_delims): Reverse sense of test condition
John Darrington [Wed, 7 Jun 2017 10:40:15 +0000 (12:40 +0200)]
PsppireDelimitedText (count_delims): Reverse sense of test condition

6 years agoPsppireDelimitedText: Extend the functionality such that it copes with quotes.
John Darrington [Wed, 7 Jun 2017 09:48:28 +0000 (11:48 +0200)]
PsppireDelimitedText: Extend the functionality such that it copes with quotes.

Currently the set of characters it considers quotes is hard coded.

6 years agoPsppireImportAssistant: Avoid possible null pointer dereferences
John Darrington [Wed, 7 Jun 2017 08:44:37 +0000 (10:44 +0200)]
PsppireImportAssistant: Avoid possible null pointer dereferences

6 years agoPsppireImportAssistant: Use a more reliable way of setting the number of cases.
John Darrington [Mon, 5 Jun 2017 17:16:28 +0000 (19:16 +0200)]
PsppireImportAssistant: Use a more reliable way of setting the number of cases.

6 years agoPsppireDelimitedText: Remove g_print statements
John Darrington [Mon, 5 Jun 2017 17:03:09 +0000 (19:03 +0200)]
PsppireDelimitedText: Remove g_print statements

6 years agoPsppireDelimitedText: use the maximum_lines property of the child as the number of...
John Darrington [Mon, 5 Jun 2017 16:12:19 +0000 (18:12 +0200)]
PsppireDelimitedText: use the maximum_lines property of the child as the number of items in the model

6 years agoImport Assistant: Mark lines beyond the declared maximum as insensitive
John Darrington [Mon, 5 Jun 2017 12:49:44 +0000 (14:49 +0200)]
Import Assistant: Mark lines beyond the declared maximum as insensitive

6 years agoImport Assistant: Don't try to parse non-existant files
John Darrington [Mon, 5 Jun 2017 14:32:05 +0000 (16:32 +0200)]
Import Assistant: Don't try to parse non-existant files

6 years agoImport assistant: Simplify the construction of the introductory page
John Darrington [Mon, 5 Jun 2017 13:33:07 +0000 (15:33 +0200)]
Import assistant: Simplify the construction of the introductory page

6 years agoAdd SPREAD_SHEET_WIDGET_CFLAGS to the flags used for building the GUI
John Darrington [Sun, 4 Jun 2017 17:00:25 +0000 (19:00 +0200)]
Add SPREAD_SHEET_WIDGET_CFLAGS to the flags used for building the GUI

6 years agoMention the changes to the sheet in NEWS
John Darrington [Fri, 2 Jun 2017 15:46:43 +0000 (17:46 +0200)]
Mention the changes to the sheet in NEWS

6 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Fri, 2 Jun 2017 15:39:39 +0000 (17:39 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

6 years agoUse a more reliable way of setting the initial state of PsppireDialogAction objects.
John Darrington [Fri, 2 Jun 2017 08:12:15 +0000 (10:12 +0200)]
Use a more reliable way of setting the initial state of PsppireDialogAction objects.

6 years agoFix bug where the Examine subdialogs appeared multiple times.
John Darrington [Fri, 2 Jun 2017 06:43:04 +0000 (08:43 +0200)]
Fix bug where the Examine subdialogs appeared multiple times.

6 years agoUpdate translations from translationproject.org
John Darrington [Wed, 31 May 2017 12:23:01 +0000 (14:23 +0200)]
Update translations from translationproject.org

6 years agoMention a version number for the spread sheet widget dependency
John Darrington [Tue, 30 May 2017 16:22:07 +0000 (18:22 +0200)]
Mention a version number for the spread sheet widget dependency

6 years agoINSTALL: Mention the spread-sheet-widget dependency
John Darrington [Sat, 27 May 2017 18:50:58 +0000 (20:50 +0200)]
INSTALL: Mention the spread-sheet-widget dependency

6 years agoRemoved GtkXPaned which is currently not used
John Darrington [Sat, 27 May 2017 18:48:48 +0000 (20:48 +0200)]
Removed GtkXPaned which is currently not used

6 years agoDeal with formal release of upstream library
John Darrington [Thu, 25 May 2017 09:05:29 +0000 (11:05 +0200)]
Deal with formal release of upstream library

6 years agoUpdate identifiers to reflect new identity of upstream package
John Darrington [Thu, 25 May 2017 05:35:01 +0000 (07:35 +0200)]
Update identifiers to reflect new identity of upstream package

6 years agoPsppireImportAssistant: New function psppire_import_assistant_run
John Darrington [Wed, 24 May 2017 05:12:29 +0000 (07:12 +0200)]
PsppireImportAssistant: New function psppire_import_assistant_run

6 years agoRemove duplicate accelerator from the one-way anova menuitem.
John Darrington [Tue, 23 May 2017 19:22:11 +0000 (21:22 +0200)]
Remove duplicate accelerator from the one-way anova menuitem.

Reported-by: Yuri Chornoivan
6 years agocase.c: variable_matches_case -> assert_variable_matches_case
John Darrington [Mon, 22 May 2017 08:07:32 +0000 (10:07 +0200)]
case.c: variable_matches_case -> assert_variable_matches_case

This function was only used in assertions.   Having the function itself assert, rather
than returning a boolean makes debugging easier, because one need not guess which
term of the assertion has failed.

6 years agoPsppireImportAssistant: Remove some unnecessary #include directives
John Darrington [Mon, 22 May 2017 02:05:02 +0000 (04:05 +0200)]
PsppireImportAssistant: Remove some unnecessary #include directives

6 years agoImport Assistant: Remove unused prototypes
John Darrington [Mon, 22 May 2017 01:55:14 +0000 (03:55 +0200)]
Import Assistant: Remove unused prototypes

6 years agoImport Assistant: Allow separators to be unicode characters
John Darrington [Mon, 22 May 2017 01:52:22 +0000 (03:52 +0200)]
Import Assistant: Allow separators to be unicode characters

6 years agoImport Assistant: Fix generation of variable names
John Darrington [Mon, 22 May 2017 01:32:27 +0000 (03:32 +0200)]
Import Assistant: Fix generation of variable names

6 years agoRemove psppire-empty-list-store which is now unused
John Darrington [Sun, 21 May 2017 16:08:47 +0000 (18:08 +0200)]
Remove psppire-empty-list-store which is now unused

6 years agoImport Assistant: Remove struct column which is now unused
John Darrington [Sun, 21 May 2017 16:05:22 +0000 (18:05 +0200)]
Import Assistant: Remove struct column which is now unused

6 years agoRemove some unused code
John Darrington [Sun, 21 May 2017 04:53:33 +0000 (06:53 +0200)]
Remove some unused code

6 years agoUpdate version number to 0.10.5pre1, for translations.
Ben Pfaff [Sat, 20 May 2017 22:17:05 +0000 (15:17 -0700)]
Update version number to 0.10.5pre1, for translations.

6 years agoK Independent Samples Dialog: Fix compiler warnings.
John Darrington [Sat, 20 May 2017 18:54:06 +0000 (20:54 +0200)]
K Independent Samples Dialog: Fix compiler warnings.

6 years agoImport assistant: Re-enable automatic inference of the separators
John Darrington [Sat, 20 May 2017 17:37:30 +0000 (19:37 +0200)]
Import assistant: Re-enable automatic inference of the separators

6 years agoImport Assistant: Fix generation of /DELIMITERS subcommand
John Darrington [Sat, 20 May 2017 13:24:38 +0000 (15:24 +0200)]
Import Assistant: Fix generation of /DELIMITERS subcommand

6 years agoRemove some unused code
John Darrington [Sat, 20 May 2017 11:53:31 +0000 (13:53 +0200)]
Remove some unused code

6 years agoImport Assistant: Re-add the format guesser feature
John Darrington [Sat, 20 May 2017 11:46:18 +0000 (13:46 +0200)]
Import Assistant: Re-add the format guesser feature

6 years agoImportAssistant: Set the GtkPaned slider to half way
John Darrington [Fri, 19 May 2017 15:51:23 +0000 (17:51 +0200)]
ImportAssistant: Set the GtkPaned slider to half way

6 years agoImportAssistant: make division between var and data sheets clearer
John Darrington [Fri, 19 May 2017 15:28:01 +0000 (17:28 +0200)]
ImportAssistant: make division between var and data sheets clearer

6 years agoconstness
John Darrington [Fri, 19 May 2017 15:16:25 +0000 (17:16 +0200)]
constness

6 years agoRemove some unused variables
John Darrington [Fri, 19 May 2017 15:07:56 +0000 (17:07 +0200)]
Remove some unused variables

6 years agoPsppireImportAssistant: Remove the "transient-for" property.
John Darrington [Fri, 19 May 2017 06:52:32 +0000 (08:52 +0200)]
PsppireImportAssistant: Remove the "transient-for" property.

6 years agoAdd a callback when variables change
John Darrington [Fri, 19 May 2017 05:36:00 +0000 (07:36 +0200)]
Add a callback when variables change

6 years agoPopulate the data sheet in the import assistant
John Darrington [Thu, 18 May 2017 17:14:43 +0000 (19:14 +0200)]
Populate the data sheet in the import assistant

6 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Thu, 18 May 2017 16:28:21 +0000 (18:28 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

6 years agoUpdated the Dutch translation from translationproject.org
John Darrington [Thu, 18 May 2017 16:25:32 +0000 (18:25 +0200)]
Updated the Dutch translation from translationproject.org

6 years agoRemove commented out code
John Darrington [Tue, 16 May 2017 12:00:55 +0000 (14:00 +0200)]
Remove commented out code

6 years agoFix potential crash if matrix file variables are of unexpected types
John Darrington [Tue, 16 May 2017 12:00:39 +0000 (14:00 +0200)]
Fix potential crash if matrix file variables are of unexpected types

6 years agoFix buffer overflow which could occur if the matrix reader encounters a badly formed...
John Darrington [Tue, 16 May 2017 10:53:35 +0000 (12:53 +0200)]
Fix buffer overflow which could occur if the matrix reader encounters a badly formed file.

6 years agoRemove unreachable code
John Darrington [Tue, 16 May 2017 10:54:03 +0000 (12:54 +0200)]
Remove unreachable code

6 years agomatrix-reader: Use strcpy() on char arrays, in next_matrix_from_reader().
Ben Pfaff [Tue, 16 May 2017 04:04:58 +0000 (21:04 -0700)]
matrix-reader: Use strcpy() on char arrays, in next_matrix_from_reader().

Fixes GCC warning "pointer targets in passing argument 1 of 'strcpy'
differ in signedness".

6 years agofactor: Fix return type of do_factor_by_matrix().
Ben Pfaff [Tue, 16 May 2017 04:00:56 +0000 (21:00 -0700)]
factor: Fix return type of do_factor_by_matrix().

This function had a "bool" return type but nothing used it.

Fixes GCC warning "'return' with no value, in function returning non-void".

Reported by Jeremy Lavergne.

6 years agoNew Dialog: Non Parametric | K Indepdendent Samples
John Darrington [Sat, 13 May 2017 17:26:17 +0000 (19:26 +0200)]
New Dialog: Non Parametric | K Indepdendent Samples

6 years agoPsppireValueEntry: Use a more reliable way to override parent property.
John Darrington [Mon, 15 May 2017 07:00:45 +0000 (09:00 +0200)]
PsppireValueEntry: Use a more reliable way to override parent property.

Setting the property in the _new function doesn't work if the object is constructed
via GtkBuilder for example.

6 years agoZip Reader: initialise error string earlier.
John Darrington [Sat, 13 May 2017 09:19:58 +0000 (11:19 +0200)]
Zip Reader: initialise error string earlier.

Fixed a bug which could have caused a crash if pspp were presented
with a corrupt zip file.

6 years agoFixed bug which caused a crash in GET DATA
John Darrington [Fri, 12 May 2017 15:03:06 +0000 (17:03 +0200)]
Fixed bug which caused a crash in GET DATA

6 years agoMEANS: Prevent parser from entering infinite loop.
John Darrington [Fri, 12 May 2017 10:25:55 +0000 (12:25 +0200)]
MEANS: Prevent parser from entering infinite loop.

Fixes bug #51008
.

6 years agosrc/math/linreg.c: Don't calculate the intercept for regression through the origin
John Darrington [Fri, 12 May 2017 09:35:09 +0000 (11:35 +0200)]
src/math/linreg.c: Don't calculate the intercept for regression through the origin

6 years agosrc/math/linreg.c: Encapsulate this object better.
John Darrington [Fri, 12 May 2017 06:36:56 +0000 (08:36 +0200)]
src/math/linreg.c: Encapsulate this object better.

6 years agoREGRESSION: Implement /ORIGIN subcommand.
John Darrington [Fri, 12 May 2017 05:42:55 +0000 (07:42 +0200)]
REGRESSION: Implement /ORIGIN subcommand.

6 years agoDESCRIPTIVES: Fix a bug where the parser could enter an infinite loop
John Darrington [Thu, 11 May 2017 14:38:11 +0000 (16:38 +0200)]
DESCRIPTIVES: Fix a bug where the parser could enter an infinite loop

6 years agoFACTOR: Don't try to perform analysis if there are no variables.
John Darrington [Thu, 11 May 2017 12:01:50 +0000 (14:01 +0200)]
FACTOR: Don't try to perform analysis if there are no variables.

6 years agoFACTOR: Do not try to run an analysis if no matrix is present
John Darrington [Thu, 11 May 2017 11:48:31 +0000 (13:48 +0200)]
FACTOR: Do not try to run an analysis if no matrix is present

6 years agoFACTOR: Fix a crash when bad input was presented
John Darrington [Thu, 11 May 2017 11:22:37 +0000 (13:22 +0200)]
FACTOR: Fix a crash when bad input was presented

6 years agoFACTOR: Make idata parameters const where they can be.
John Darrington [Thu, 11 May 2017 10:42:10 +0000 (12:42 +0200)]
FACTOR: Make idata parameters const where they can be.

6 years agoDATA MATRIX: Avoid crash on invalid input
John Darrington [Thu, 11 May 2017 08:40:51 +0000 (10:40 +0200)]
DATA MATRIX: Avoid crash on invalid input

6 years agoFix memory leaks in FACTOR/MATRIX
John Darrington [Wed, 10 May 2017 14:43:39 +0000 (16:43 +0200)]
Fix memory leaks in FACTOR/MATRIX

6 years agoRemove unused variable
John Darrington [Wed, 10 May 2017 10:59:11 +0000 (12:59 +0200)]
Remove unused variable

6 years agoFACTOR: Use consistent indexing when displaying matrices.
John Darrington [Wed, 10 May 2017 10:48:17 +0000 (12:48 +0200)]
FACTOR: Use consistent indexing when displaying matrices.

In any sane use case this will make no difference, since
all covariance and correlation matrices are symetrical.
However for correctness and ease of debugging this helps.

6 years agomatrix reader: Fix bug which incorrectly read in matrix material.
John Darrington [Wed, 10 May 2017 10:41:40 +0000 (12:41 +0200)]
matrix reader: Fix bug which incorrectly read in matrix material.

6 years agoMATRIX DATA: Allow non-symetric matrices if /FORMAT = FULL.
John Darrington [Wed, 10 May 2017 08:50:12 +0000 (10:50 +0200)]
MATRIX DATA: Allow non-symetric matrices if /FORMAT = FULL.

6 years agoMatrix reader, fix comment to reflect reality.
John Darrington [Wed, 10 May 2017 05:54:02 +0000 (07:54 +0200)]
Matrix reader, fix comment to reflect reality.

6 years agoMATRIX DATA: Cope with long variable names
John Darrington [Tue, 9 May 2017 14:41:08 +0000 (16:41 +0200)]
MATRIX DATA: Cope with long variable names