pspp
8 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Thu, 7 Apr 2016 11:30:01 +0000 (13:30 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

8 years agoFixed crash on FLIP vs. invalid variable names.
John Darrington [Wed, 6 Apr 2016 07:38:56 +0000 (09:38 +0200)]
Fixed crash on FLIP vs. invalid variable names.

FLIP would crash if the designated new names were not
valid names.  For example "TO", "BY", "" etc.

Found by zzuf.

8 years agoFixed a crash when data for correlations was empty.
John Darrington [Tue, 5 Apr 2016 19:08:50 +0000 (21:08 +0200)]
Fixed a crash when data for correlations was empty.

Found by zzuf.

8 years agoAdd test for PERMISSIONS with bad syntax
John Darrington [Tue, 5 Apr 2016 18:01:35 +0000 (20:01 +0200)]
Add test for PERMISSIONS with bad syntax

8 years agoFix crash in T-Test after parsing a null terminated string.
John Darrington [Mon, 4 Apr 2016 11:42:21 +0000 (13:42 +0200)]
Fix crash in T-Test after parsing a null terminated string.

Found by zzuf.

8 years agotests: Fix a deeper bug in null byte check in testsuite.
Ben Pfaff [Sun, 3 Apr 2016 18:52:55 +0000 (11:52 -0700)]
tests: Fix a deeper bug in null byte check in testsuite.

Thanks to Jeremy Lavergne for reporting the problem.

8 years agotests: Fix bug in null byte check in testsuite.
Ben Pfaff [Sun, 3 Apr 2016 18:20:27 +0000 (11:20 -0700)]
tests: Fix bug in null byte check in testsuite.

Thanks to Jeremy Lavergne for reporting the problem.

8 years agoUpdate version number to 0.10.2.
Ben Pfaff [Sun, 3 Apr 2016 03:50:51 +0000 (20:50 -0700)]
Update version number to 0.10.2.

8 years agoRelease PSPP 0.10.1.
Ben Pfaff [Sun, 3 Apr 2016 03:37:15 +0000 (20:37 -0700)]
Release PSPP 0.10.1.

8 years agolexer: Treat null characters in input as spaces.
Ben Pfaff [Sun, 3 Apr 2016 00:53:52 +0000 (17:53 -0700)]
lexer: Treat null characters in input as spaces.

In some circumstances nulls could confuse the lexer and cause crashes.

Thanks to John Darrington for reporting the problem.

Bug #47602.

8 years agolexer: Add comments and update style in lex_source_get__().
Ben Pfaff [Sat, 2 Apr 2016 23:41:13 +0000 (16:41 -0700)]
lexer: Add comments and update style in lex_source_get__().

8 years agoCROSSTABS: Fix corner case in integer mode.
Ben Pfaff [Sat, 2 Apr 2016 18:09:15 +0000 (11:09 -0700)]
CROSSTABS: Fix corner case in integer mode.

I'm not really sure what I was thinking when I wrote this code, but the
off-by-one errors could cause a crash.

Thanks to John Darrington for reporting the problem.

Bug #47600.

8 years agoDocumentation: Update copyright notice to reflect recent changes
John Darrington [Sat, 2 Apr 2016 08:21:09 +0000 (10:21 +0200)]
Documentation: Update copyright notice to reflect recent changes

8 years agoFix date format tests when running under wine
John Darrington [Sat, 2 Apr 2016 04:01:43 +0000 (06:01 +0200)]
Fix date format tests when running under wine

8 years agoReplace valgrind-wrapper with a generic wrapper.
Ben Pfaff [Sat, 2 Apr 2016 03:12:29 +0000 (05:12 +0200)]
Replace valgrind-wrapper with a generic wrapper.

One potential use is to run tests under an emulator such as wine.

8 years agolexer.h: Add WARN_UNUSED_RESULT to lex_force functions.
John Darrington [Fri, 1 Apr 2016 13:38:37 +0000 (15:38 +0200)]
lexer.h: Add WARN_UNUSED_RESULT to lex_force functions.

There does not seem to be any sensible and safe use of these
functions unless the return value is used somehow.

8 years agoCheck the return value of various calls to lex_force_match.
John Darrington [Fri, 1 Apr 2016 10:16:15 +0000 (12:16 +0200)]
Check the return value of various calls to lex_force_match.

8 years agooutput.c: cmd_output: Check return values of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:44:17 +0000 (11:44 +0200)]
output.c: cmd_output: Check return values of lex_force_match

8 years agovariable-display.c (cmd_variable_level): Check return value of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:37:02 +0000 (11:37 +0200)]
variable-display.c (cmd_variable_level): Check return value of lex_force_match

8 years agovalue-parser.c (parse_number): Simplified logic and removed redundant lines.
John Darrington [Fri, 1 Apr 2016 09:30:44 +0000 (11:30 +0200)]
value-parser.c (parse_number): Simplified logic and removed redundant lines.

8 years agoFix crash in NPAR when no variables were parsed.
John Darrington [Thu, 31 Mar 2016 20:27:52 +0000 (22:27 +0200)]
Fix crash in NPAR when no variables were parsed.

Found by zzuf.

8 years agoFix typo in NEWS
John Darrington [Thu, 31 Mar 2016 19:57:17 +0000 (21:57 +0200)]
Fix typo in NEWS

8 years agoFixed a bug where frequencies/histogram would crash when all data had missing wieghts.
John Darrington [Thu, 31 Mar 2016 19:51:25 +0000 (21:51 +0200)]
Fixed a bug where frequencies/histogram would crash when all data had missing wieghts.

Found by zzuf.

8 years agopo: Update Dutch translation.
Ben Pfaff [Thu, 31 Mar 2016 19:44:24 +0000 (12:44 -0700)]
po: Update Dutch translation.

8 years agoUpdated NEWS to mention bugs fixed in command parser
John Darrington [Thu, 31 Mar 2016 08:19:07 +0000 (10:19 +0200)]
Updated NEWS to mention bugs fixed in command parser

8 years agoFix crash when ROC was passed a non-number where a number was expected.
John Darrington [Thu, 31 Mar 2016 08:14:05 +0000 (10:14 +0200)]
Fix crash when ROC was passed a non-number where a number was expected.

Found by zzuf.

8 years agoFixed by where pspp would crash if ELSE appeared without a DO IF.
John Darrington [Thu, 31 Mar 2016 07:19:35 +0000 (09:19 +0200)]
Fixed by where pspp would crash if ELSE appeared without a DO IF.

Found by zzuf.

8 years agoFixed a bug where INSERT would crash when an unterminated string was given.
John Darrington [Thu, 31 Mar 2016 06:22:44 +0000 (08:22 +0200)]
Fixed a bug where INSERT would crash when an unterminated string was given.

Found by zzuf.

8 years agopo: Update German translation from translationproject.org.
Ben Pfaff [Thu, 31 Mar 2016 15:14:52 +0000 (08:14 -0700)]
po: Update German translation from translationproject.org.

8 years agoFix crash when ONEWAY/CONTRASTS contained an empty list.
John Darrington [Thu, 31 Mar 2016 12:44:57 +0000 (14:44 +0200)]
Fix crash when ONEWAY/CONTRASTS contained an empty list.

Found by zzuf.

8 years agoPsppireSelector: Do not add a default selector func, if an explicit one already exists
John Darrington [Wed, 30 Mar 2016 15:42:44 +0000 (17:42 +0200)]
PsppireSelector: Do not add a default selector func, if an explicit one already exists

Fixes bug #47573.

8 years agoFixed crash when processing malformed NPAR TESTS BINOMIAL command.
John Darrington [Wed, 30 Mar 2016 06:17:48 +0000 (08:17 +0200)]
Fixed crash when processing malformed NPAR TESTS BINOMIAL command.

Found by zzuf.

8 years agopo: Update Lithuanian translation.
Ben Pfaff [Wed, 30 Mar 2016 15:34:06 +0000 (08:34 -0700)]
po: Update Lithuanian translation.

8 years agoAvoid possible memory allocation error on erroneous input.
John Darrington [Wed, 30 Mar 2016 10:04:54 +0000 (12:04 +0200)]
Avoid possible memory allocation error on erroneous input.

Valgrind showed a possible problem here.

8 years agoCleanup the RENAME VARIABLES command.
John Darrington [Tue, 29 Mar 2016 11:17:25 +0000 (13:17 +0200)]
Cleanup the RENAME VARIABLES command.

Also fix some crashes which occured on invalid syntax.

8 years agouse fixed format string to avoid -Wformat-security warning
Friedrich Beckmann [Tue, 29 Mar 2016 00:11:59 +0000 (02:11 +0200)]
use fixed format string to avoid -Wformat-security warning

The debian build fails due to the -Wformat-security check. This
change replaces a variable format string with a fixed format
string.

8 years agopo: Update translations from translationproject.org.
Ben Pfaff [Mon, 28 Mar 2016 15:31:46 +0000 (08:31 -0700)]
po: Update translations from translationproject.org.

8 years agoFixed bug in EXAMINE where the parametric calculation would crash if the weight
John Darrington [Sun, 27 Mar 2016 11:51:53 +0000 (13:51 +0200)]
Fixed bug in EXAMINE where the parametric calculation would crash if the weight
variable contained a missing value.

Found by zzuf.

8 years agoFix bug in EXAMINE when an invalid dependent variable was specified.
John Darrington [Sat, 26 Mar 2016 17:34:02 +0000 (18:34 +0100)]
Fix bug in EXAMINE when an invalid dependent variable was specified.

Found by zzuf.

8 years agoUpdate NEWS to keep make dist happy
John Darrington [Sun, 27 Mar 2016 06:11:38 +0000 (08:11 +0200)]
Update NEWS to keep make dist happy

8 years agoUpdate version number to 0.10.1
John Darrington [Sun, 27 Mar 2016 05:08:20 +0000 (07:08 +0200)]
Update version number to 0.10.1

8 years agoUpdate version number to 0.10.0.
Ben Pfaff [Sat, 26 Mar 2016 17:30:51 +0000 (10:30 -0700)]
Update version number to 0.10.0.

8 years agoFix bug in GRAPH when a bad dependent variable was specified.
John Darrington [Sat, 26 Mar 2016 16:36:59 +0000 (17:36 +0100)]
Fix bug in GRAPH when a bad dependent variable was specified.

Found by zzuf.

8 years agoFix crash in FLIP with no variables.
John Darrington [Sat, 26 Mar 2016 15:57:16 +0000 (16:57 +0100)]
Fix crash in FLIP with no variables.

Found by zzuf.

8 years agoFix double heap deallocation when erroneous SET was specified.
John Darrington [Sat, 26 Mar 2016 15:34:20 +0000 (16:34 +0100)]
Fix double heap deallocation when erroneous SET was specified.

Found by zzuf.

8 years agoFixed crash in MODIFY OUTPUT when no valid FORMAT clause was specified.
John Darrington [Sat, 26 Mar 2016 15:13:50 +0000 (16:13 +0100)]
Fixed crash in MODIFY OUTPUT when no valid FORMAT clause was specified.

Found by zzuf.

8 years agoFix crash in oneway when an invalid dependent variable was specified.
John Darrington [Sat, 26 Mar 2016 14:22:47 +0000 (15:22 +0100)]
Fix crash in oneway when an invalid dependent variable was specified.

Found by zzuf

8 years agoFix crash in recode when the INTO variable was invalid.
John Darrington [Sat, 26 Mar 2016 07:48:14 +0000 (08:48 +0100)]
Fix crash in recode when the INTO variable was invalid.

Found by zzuf.

8 years agoFix assertion failure when using PRINT with an empty argument.
John Darrington [Sat, 26 Mar 2016 07:17:37 +0000 (08:17 +0100)]
Fix assertion failure when using PRINT with an empty argument.

Found by zzuf.

8 years agoFix crash in ROC command when no valid state variable is given.
John Darrington [Fri, 25 Mar 2016 20:25:49 +0000 (21:25 +0100)]
Fix crash in ROC command when no valid state variable is given.

Found by zzuf.

8 years agoFix crash when no indepdendent variable in NPAR is given.
John Darrington [Fri, 25 Mar 2016 19:13:46 +0000 (20:13 +0100)]
Fix crash when no indepdendent variable in NPAR is given.

Found by zzuf.

8 years agoFix crash in DATA LIST when RECORDS and/or SKIP is negative
John Darrington [Fri, 25 Mar 2016 13:16:03 +0000 (14:16 +0100)]
Fix crash in DATA LIST when RECORDS and/or SKIP is negative

Found by zzuf

8 years agoFix crash in LIST when no valid variables exist.
John Darrington [Fri, 25 Mar 2016 10:16:22 +0000 (11:16 +0100)]
Fix crash in LIST when no valid variables exist.

Found by zzuf.

8 years agoFix crash in histogram when all values are missing.
John Darrington [Thu, 24 Mar 2016 22:13:18 +0000 (23:13 +0100)]
Fix crash in histogram when all values are missing.

Found by zzuf.

8 years agoFix crash when running GET DATA with incomplete command.
John Darrington [Thu, 24 Mar 2016 20:07:04 +0000 (21:07 +0100)]
Fix crash when running GET DATA with incomplete command.

Found by zzuf.

8 years agoFixed crash in T-TEST when a non-number was passed where a number was expected.
John Darrington [Thu, 24 Mar 2016 19:30:36 +0000 (20:30 +0100)]
Fixed crash in T-TEST when a non-number was passed where a number was expected.

Found by zzuf.

8 years agoFix crash in correlations with empty dataset.
John Darrington [Thu, 24 Mar 2016 19:07:11 +0000 (20:07 +0100)]
Fix crash in correlations with empty dataset.

Found by zzuf.

8 years agoProvide an environment where cross-compiled tests can run in an emulator
John Darrington [Sun, 20 Mar 2016 19:41:14 +0000 (20:41 +0100)]
Provide an environment where cross-compiled tests can run in an emulator

This change allows some of the tests to run successfully under wine when
cross-compiled with mingw

8 years agoPrevent link error when cross compiling with mingw
John Darrington [Sun, 20 Mar 2016 18:34:34 +0000 (19:34 +0100)]
Prevent link error when cross compiling with mingw

8 years agospreadsheet-reader.c: Do not export local symbols
John Darrington [Sun, 13 Mar 2016 08:54:36 +0000 (09:54 +0100)]
spreadsheet-reader.c: Do not export local symbols

8 years agoSORT VARIABLES: Add test.
Ben Pfaff [Sun, 20 Mar 2016 16:49:26 +0000 (09:49 -0700)]
SORT VARIABLES: Add test.

This should have been in the initial commit; sorry.

8 years agoREADME.Git: Update required Texinfo version
John Darrington [Sun, 20 Mar 2016 06:37:08 +0000 (07:37 +0100)]
README.Git:  Update required Texinfo version

It seems that older makeinfo does not correctly generate the docbook format.  Thanks to
Harry for finding this.

8 years agoImplement new command SORT VARIABLES.
Ben Pfaff [Sun, 20 Mar 2016 00:19:45 +0000 (17:19 -0700)]
Implement new command SORT VARIABLES.

8 years agoFix error in dist-hook-git.
John Darrington [Sat, 19 Mar 2016 18:41:35 +0000 (19:41 +0100)]
Fix error in dist-hook-git.

The previous commit introduced a new "meta" file.  But it provoked our test for
missing distribution files.  This change fixes that.

8 years agoChange the align, role and measure columns on the appropriate signal
John Darrington [Sat, 19 Mar 2016 17:22:25 +0000 (18:22 +0100)]
Change the align, role and measure columns on the appropriate signal

8 years agoNew transform function for converting enums to strings
John Darrington [Sat, 19 Mar 2016 16:16:47 +0000 (17:16 +0100)]
New transform function for converting enums to strings

8 years agoAdded naive callbacks for the "value-changed" signal
John Darrington [Sat, 19 Mar 2016 07:19:17 +0000 (08:19 +0100)]
Added naive callbacks for the "value-changed" signal

8 years agoAdded transform function for string to int
John Darrington [Sat, 19 Mar 2016 06:38:26 +0000 (07:38 +0100)]
Added transform function for string to int

8 years agoPsppireDict: Added GType values for missing columns
John Darrington [Fri, 18 Mar 2016 20:08:18 +0000 (21:08 +0100)]
PsppireDict: Added GType values for missing columns

8 years agoExtend the build to include new sheet files
John Darrington [Fri, 18 Mar 2016 18:08:36 +0000 (19:08 +0100)]
Extend the build to include new sheet files

8 years agoAdded a "meta" file, explaining administrative procedures for bug handling
John Darrington [Fri, 18 Mar 2016 10:14:20 +0000 (11:14 +0100)]
Added a "meta" file, explaining administrative procedures for bug handling

8 years agoFix compiler warnings
John Darrington [Thu, 17 Mar 2016 14:21:59 +0000 (15:21 +0100)]
Fix compiler warnings

8 years agoLocalise values of comboboxes in var sheet
John Darrington [Thu, 17 Mar 2016 13:36:32 +0000 (14:36 +0100)]
Localise values of comboboxes in var sheet

8 years agoSet individual cell renderers for variable sheet columns
John Darrington [Thu, 17 Mar 2016 13:26:06 +0000 (14:26 +0100)]
Set individual cell renderers for variable sheet columns

8 years agoUpdate build to reflect new file in sheet implementation
John Darrington [Wed, 16 Mar 2016 15:51:14 +0000 (16:51 +0100)]
Update build to reflect new file in sheet implementation

8 years agoComplete definition of PsppireDict get_value and get_type methods
John Darrington [Mon, 14 Mar 2016 20:10:11 +0000 (21:10 +0100)]
Complete definition of PsppireDict get_value and get_type methods

8 years agoRegister enums and transform functions
John Darrington [Mon, 14 Mar 2016 20:08:54 +0000 (21:08 +0100)]
Register enums and transform functions

8 years agoDefine the measurement, alignment and role enums in a way compatible with Gtk
John Darrington [Mon, 14 Mar 2016 19:53:12 +0000 (20:53 +0100)]
Define the measurement, alignment and role enums in a way compatible with Gtk

8 years agoPsppireDataStore: Return GValues of G_TYPE_STRING if variable type is alphanumeric
John Darrington [Mon, 14 Mar 2016 12:22:06 +0000 (13:22 +0100)]
PsppireDataStore: Return GValues of G_TYPE_STRING if variable type is alphanumeric

This is a naive change.  The proper change must consider pspp variable types of date, custom currency etc.

8 years agoexpressions: Add support for mult and fuzzbits arguments to TRUNC function.
Ben Pfaff [Sun, 13 Mar 2016 19:10:22 +0000 (12:10 -0700)]
expressions: Add support for mult and fuzzbits arguments to TRUNC function.

8 years agoexpressions: Implement the STRUNC function.
Ben Pfaff [Sun, 13 Mar 2016 18:39:29 +0000 (11:39 -0700)]
expressions: Implement the STRUNC function.

8 years agoexpressions: Implement the MEDIAN function.
Ben Pfaff [Sun, 13 Mar 2016 18:20:22 +0000 (11:20 -0700)]
expressions: Implement the MEDIAN function.

8 years agodoc: Document that value labels are case sensitive.
Ben Pfaff [Sun, 13 Mar 2016 17:10:35 +0000 (10:10 -0700)]
doc: Document that value labels are case sensitive.

This was not documented and a user found it surprising.

Also, long string variables can now be labeled.

Reported by Robert Pittman.

8 years agoRe-enable display of cell reference label
John Darrington [Sun, 13 Mar 2016 13:43:23 +0000 (14:43 +0100)]
Re-enable display of cell reference label

8 years agoEnable case insensitivity test.
John Darrington [Sun, 13 Mar 2016 12:19:10 +0000 (13:19 +0100)]
Enable case insensitivity test.

The operative part of this test seemed to have been inadvertently omitted.

8 years agoPsppireVarSheetHeader: Add the "changed" signal.
John Darrington [Sat, 12 Mar 2016 17:44:46 +0000 (18:44 +0100)]
PsppireVarSheetHeader: Add the "changed" signal.

This signal is never emitted, but critical runtime warnings
appear if it doesn't exist.

8 years agoRemove unused symbol
John Darrington [Sat, 12 Mar 2016 17:36:23 +0000 (18:36 +0100)]
Remove unused symbol

8 years agoChange view and scroll to position on header double click
John Darrington [Sat, 12 Mar 2016 16:15:18 +0000 (17:15 +0100)]
Change view and scroll to position on header double click

8 years agoPsppireKeypad: Remove gdkkeysyms-compat.h
John Darrington [Mon, 7 Mar 2016 18:16:00 +0000 (19:16 +0100)]
PsppireKeypad: Remove gdkkeysyms-compat.h

8 years agoPipe read test: Replace "echo" with "printf"
John Darrington [Fri, 4 Mar 2016 19:09:00 +0000 (20:09 +0100)]
Pipe read test: Replace "echo" with "printf"

This test was failing on GuixSD

8 years agoDATA LIST: Do not treat the comma as a field separator if DECIMAL=COMMA
John Darrington [Tue, 1 Mar 2016 18:28:20 +0000 (19:28 +0100)]
DATA LIST: Do not treat the comma as a field separator if DECIMAL=COMMA

Closes bug #47253

8 years agoSpeed up rendering of columns in sheet.
John Darrington [Tue, 1 Mar 2016 05:24:54 +0000 (06:24 +0100)]
Speed up rendering of columns in sheet.

This change causes _pspp_sheet_view_install_mark_rows_col_dirty to be called once
per sheet, instead of once per column when adding/deleting columns.  Hence there
is a significant speed improvement when dealing with a data sheet with a large
number of variables.

Fixes bug #47090

8 years agoPsppireDataStore: Implemenet get_flags function
John Darrington [Sun, 28 Feb 2016 17:58:30 +0000 (18:58 +0100)]
PsppireDataStore: Implemenet get_flags function

8 years agoChange signal name and signature from "backend-changed" to "items-changed"
John Darrington [Sun, 28 Feb 2016 17:53:15 +0000 (18:53 +0100)]
Change signal name and signature from "backend-changed" to "items-changed"

8 years agoPsppireDict: New signal "changed"
John Darrington [Sun, 28 Feb 2016 14:59:06 +0000 (15:59 +0100)]
PsppireDict: New signal "changed"

8 years agoAdded makefile to build the efficient-sheet
John Darrington [Sun, 28 Feb 2016 14:08:54 +0000 (15:08 +0100)]
Added makefile to build the efficient-sheet

8 years agopsppire: Remove unused function.
Ben Pfaff [Sun, 28 Feb 2016 00:47:27 +0000 (16:47 -0800)]
psppire: Remove unused function.

8 years agogui: Add some generated files to .gitignore files.
Ben Pfaff [Sat, 27 Feb 2016 22:53:59 +0000 (14:53 -0800)]
gui: Add some generated files to .gitignore files.

Reported by Friedrich Beckmann.
Bug #47265.

8 years agoRemove attempts do destroy windows before quit.
John Darrington [Fri, 26 Feb 2016 16:39:48 +0000 (17:39 +0100)]
Remove attempts do destroy windows before quit.

This change deletes an attempt to remove all existing
windows from a list (and thereby unreffing and deleting them).
The attempt fails, because lists may not be altered whilst
iterating them.  This resulted only in a Critical Warning.

It is also pointless to attempt to destroy windows immediately
priot to quit.

8 years agoUpdated de.po from translationproject.org
John Darrington [Fri, 26 Feb 2016 15:29:25 +0000 (16:29 +0100)]
Updated de.po from translationproject.org