Merge master into gtk3. 20131026032545/pspp 20131027032559/pspp 20131028032549/pspp 20131030030824/pspp 20131031032414/pspp 20131101032516/pspp 20131102032602/pspp 20131103032703/pspp 20131104032617/pspp 20131105032650/pspp 20131106032624/pspp 20131107032703/pspp 20131108032720/pspp 20131110032717/pspp 20131111032724/pspp 20131112032726/pspp 20131113032746/pspp 20131114032755/pspp 20131115032755/pspp 20131116032752/pspp
authorBen Pfaff <blp@cs.stanford.edu>
Sat, 26 Oct 2013 05:05:05 +0000 (22:05 -0700)
committerBen Pfaff <blp@cs.stanford.edu>
Sat, 26 Oct 2013 05:36:15 +0000 (22:36 -0700)
17 files changed:
1  2 
INSTALL
configure.ac
src/output/cairo.c
src/output/cairo.h
src/output/render.c
src/ui/gui/automake.mk
src/ui/gui/main.c
src/ui/gui/page-assistant.c
src/ui/gui/page-separators.c
src/ui/gui/pspp-sheet-view.c
src/ui/gui/psppire-conf.c
src/ui/gui/psppire-data-editor.c
src/ui/gui/psppire-data-sheet.c
src/ui/gui/psppire-data-window.c
src/ui/gui/psppire-output-window.c
src/ui/gui/syntax-editor.ui
src/ui/gui/text-data-import-dialog.c

diff --cc INSTALL
Simple merge
diff --cc configure.ac
Simple merge
Simple merge
Simple merge
Simple merge
Simple merge
Simple merge
Simple merge
Simple merge
index 5bdeee4c56a44b02631f65d6254ea42d696df400,cd4999301f6539a13d95dc21d5c32e050108b503..ccdbd10e9919b5d61cbc059bd6d4c7284c66e277
@@@ -3844,12 -3773,18 +3841,18 @@@ pspp_sheet_view_draw_vertical_grid_line
  
        current_x += column->width;
  
 -      if (x >= event->area.x && x < event->area.x + event->area.width)
 -        gdk_draw_line (event->window,
 -                       tree_view->priv->grid_line_gc[GTK_WIDGET(tree_view)->state],
 -                       x, min_y,
 -                       x, max_y - min_y);
+       /* Generally the grid lines should fit within the column, but for the
+          last visible column we put it just past the end of the column.
+          (Otherwise horizontal grid lines sometimes stick out by one pixel.) */
+       x = current_x;
+       if (i != n_visible_columns - 1)
+         x--;
-       cairo_move_to (cr, current_x - 0.5, min_y);
-       cairo_line_to (cr, current_x - 0.5 , max_y - min_y);
-       
 +      cairo_set_line_width (cr, 1.0);
 +      cairo_set_line_cap (cr, CAIRO_LINE_CAP_SQUARE);
++      cairo_move_to (cr, x + 0.5, min_y);
++      cairo_line_to (cr, x + 0.5, max_y - min_y);
 +      cairo_stroke (cr);
      }
  }
  
@@@ -4241,40 -4161,19 +4244,40 @@@ pspp_sheet_view_bin_expose (GtkWidge
  
          if (draw_hgrid_lines)
            {
 -            if (background_area.y > 0)
 -              gdk_draw_line (event->window,
 -                             tree_view->priv->grid_line_gc[widget->state],
 -                             background_area.x, background_area.y,
 -                             background_area.x + background_area.width,
 -                             background_area.y);
 -
 -            if (y_offset + max_height <= event->area.height)
 -              gdk_draw_line (event->window,
 -                             tree_view->priv->grid_line_gc[widget->state],
 -                             background_area.x, background_area.y + max_height,
 -                             background_area.x + background_area.width,
 -                             background_area.y + max_height);
 +            cairo_set_line_width (cr, 1.0);
 +            cairo_set_line_cap (cr, CAIRO_LINE_CAP_SQUARE);
 +
 +            if (background_area.y >= 0)
 +              {
 +#if GTK3_TRANSITION
 +                gdk_draw_line (event->window,
 +                               tree_view->priv->grid_line_gc[widget->state],
 +                               background_area.x, background_area.y,
 +                               background_area.x + background_area.width,
 +                               background_area.y);
 +#else
 +                cairo_move_to (cr, background_area.x, background_area.y - 0.5);
 +                cairo_line_to (cr, background_area.x + background_area.width,
 +                               background_area.y - 0.5);
 +#endif
 +              }
 +
-             if (y_offset + max_height >= Zarea.height - 0.5)
++            if (y_offset + max_height <= Zarea.height - 0.5)
 +              {
 +#if GTK3_TRANSITION
 +                gdk_draw_line (event->window,
 +                               tree_view->priv->grid_line_gc[widget->state],
 +                               background_area.x, background_area.y + max_height,
 +                               background_area.x + background_area.width,
 +                               background_area.y + max_height);
 +#else
 +
 +                cairo_move_to (cr, background_area.x, background_area.y + max_height - 0.5);
 +                cairo_line_to (cr, background_area.x + background_area.width,
 +                               background_area.y + max_height - 0.5);
 +#endif
 +              }
 +            cairo_stroke (cr);
            }
  
            _pspp_sheet_view_column_cell_render (column,
Simple merge
Simple merge
Simple merge
Simple merge
Simple merge
Simple merge
Simple merge