Warnings: removed fallthrough in case statements
authorFriedrich Beckmann <friedrich.beckmann@gmx.de>
Mon, 24 Aug 2020 11:20:21 +0000 (13:20 +0200)
committerFriedrich Beckmann <friedrich.beckmann@gmx.de>
Mon, 24 Aug 2020 18:24:29 +0000 (20:24 +0200)
I guess the fallthroughs in the case statements were not intentional.
This avoids the warning:
warning: this statement may fall through

src/ui/gui/psppire-buttonbox.c
src/ui/gui/psppire-dictview.c
src/ui/gui/psppire-val-chooser.c

index abb90123ef95b4b51e5d47f4967dffa8aedb947f..f00a2cf491c3983ef718c98beb48ccc6b8a2aeb9 100644 (file)
@@ -108,6 +108,7 @@ psppire_buttonbox_get_property (GObject         *object,
 
     case PROP_DEFAULT:
       g_value_set_flags (value, bb->def);
+      break;
 
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
index d51a22381b26efe01970dd9368eb8d0cb4303f97..8f4a677b29d03b640855f51768bbcfe52e54fc83 100644 (file)
@@ -291,6 +291,7 @@ psppire_dict_view_get_property (GObject         *object,
 
        g_value_set_enum (value, gtk_tree_selection_get_mode (selection));
       }
+      break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
index 6a9b876a4356a4a09abc27af44db2ec84a1d6c76..2bdc3c551e984d281c9d44eb49e7860c8b234545 100644 (file)
@@ -144,6 +144,7 @@ psppire_val_chooser_get_property (GObject         *object,
       break;
     case PROP_IS_STRING:
       g_value_set_boolean (value, vr->input_var_is_string);
+      break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;