pspp-builds.git
15 years agoMake cases simpler, faster, and easier to understand.
Ben Pfaff [Wed, 7 Jan 2009 07:17:32 +0000 (23:17 -0800)]
Make cases simpler, faster, and easier to understand.

Cases (struct ccase) is reference-counted to avoid copying more
data than necessary.  But the existing implementation that uses
separate structures for references to cases (struct ccase) and
the cases themselves (struct case_data) has a number of issues:

   - The semantics of struct ccase are tricky to remember; one
     has to remember to treat struct ccase as essentially a
     pointer type.  I get confused sometimes myself.

     (One of the symptoms of this was the existence of
      the case_nullify and case_is_null functions, which are
      exactly analogous to setting a pointer to null and comparing
      one against null, respectively.)

   - Every reference to data in a case involves two levels of
     indirection, which is one more than actually necessary.

   - The implementation is somewhat complicated.

This commit simplifies things, by dropping a level of indirection.
Now, a case is just a pointer to a struct ccase, which contains
the actual data.  Reference counting is still present, but it is
simplified.  The only thing that must be remembered is that, before
modifying a case that may be shared, it must be passed through
case_unshare() to make a new unshared copy if necessary.

15 years agoRemove inappropriate include directives
John Darrington [Sun, 4 Jan 2009 07:39:49 +0000 (16:39 +0900)]
Remove inappropriate include directives

15 years agoRemove invalid property
John Darrington [Sun, 4 Jan 2009 07:04:38 +0000 (16:04 +0900)]
Remove invalid property

15 years agoFix pointer types as appropriate
John Darrington [Sun, 4 Jan 2009 07:00:04 +0000 (16:00 +0900)]
Fix pointer types as appropriate

15 years agoConvert psppire.glade to psppire.ui
John Darrington [Sun, 4 Jan 2009 06:48:59 +0000 (15:48 +0900)]
Convert psppire.glade to psppire.ui

15 years agoConverted T-Test dialogs to GtkBuilder
John Darrington [Sun, 4 Jan 2009 06:03:02 +0000 (15:03 +0900)]
Converted T-Test dialogs to GtkBuilder

15 years agoAdd *.ui to .gitignore
John Darrington [Sun, 4 Jan 2009 05:32:36 +0000 (14:32 +0900)]
Add *.ui to .gitignore

15 years agoConvert Regression dialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:31:45 +0000 (14:31 +0900)]
Convert Regression dialog to GtkBuilder

15 years agoConvert MessageDialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:26:11 +0000 (14:26 +0900)]
Convert MessageDialog to GtkBuilder

15 years agoConvert Crosstabs dialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:19:07 +0000 (14:19 +0900)]
Convert Crosstabs dialog to GtkBuilder

15 years agoConvert Examine dialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:09:30 +0000 (14:09 +0900)]
Convert Examine dialog to GtkBuilder

15 years agoConvert Frequencies dialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 04:59:50 +0000 (13:59 +0900)]
Convert Frequencies dialog to GtkBuilder

15 years agoMigrated rank and recode dialogs to GtkBuilder
John Darrington [Sat, 3 Jan 2009 12:45:47 +0000 (21:45 +0900)]
Migrated rank and recode dialogs to GtkBuilder

15 years agoAdded infrastructure for GtkBuilder and change oneway-dialog to use it.
John Darrington [Sat, 3 Jan 2009 12:20:28 +0000 (21:20 +0900)]
Added infrastructure for GtkBuilder and change oneway-dialog to use it.

15 years agoRename lib/gtksheet to lib/gtk-contrib
John Darrington [Mon, 15 Dec 2008 06:06:07 +0000 (15:06 +0900)]
Rename lib/gtksheet to lib/gtk-contrib

15 years agoCreated new directory src/ui/gui/sheet
John Darrington [Mon, 15 Dec 2008 05:30:41 +0000 (14:30 +0900)]
Created new directory src/ui/gui/sheet

Moved files from lib/gtksheet to src/ui/gui/sheet except those whose
copyright is not FSF owned.

15 years agoAdjusted packing properties as appropriatate
John Darrington [Sun, 14 Dec 2008 22:21:38 +0000 (07:21 +0900)]
Adjusted packing properties as appropriatate

15 years agoRemove expand property from inappropriate widget
John Darrington [Sun, 14 Dec 2008 22:03:05 +0000 (07:03 +0900)]
Remove expand property from inappropriate widget

15 years agoReadd lost files
John Darrington [Sun, 14 Dec 2008 06:58:03 +0000 (15:58 +0900)]
Readd lost files

15 years agoMoved marshallers to src/ui/gui
John Darrington [Sun, 14 Dec 2008 06:45:58 +0000 (15:45 +0900)]
Moved marshallers to src/ui/gui

15 years agoRename GtkSheet to PsppireSheet
John Darrington [Sun, 14 Dec 2008 04:56:01 +0000 (13:56 +0900)]
Rename GtkSheet to PsppireSheet

15 years agoRename gsheetmodel to psppiresheetmodel
John Darrington [Sun, 14 Dec 2008 03:20:25 +0000 (12:20 +0900)]
Rename gsheetmodel to psppiresheetmodel

15 years agoMerge commit 'HEAD'; branch 'rewrite-sheet'
John Darrington [Sun, 14 Dec 2008 02:08:37 +0000 (11:08 +0900)]
Merge commit 'HEAD'; branch 'rewrite-sheet'

15 years agoFix warning
John Darrington [Sat, 13 Dec 2008 07:34:34 +0000 (16:34 +0900)]
Fix warning

15 years agoRe-enabled display of global sheet button
John Darrington [Sat, 13 Dec 2008 03:46:35 +0000 (12:46 +0900)]
Re-enabled display of global sheet button

15 years agoMore runtime warnings fixed
John Darrington [Fri, 12 Dec 2008 13:13:20 +0000 (22:13 +0900)]
More runtime warnings fixed

15 years agoFix some runtime warnings
John Darrington [Fri, 12 Dec 2008 11:34:41 +0000 (20:34 +0900)]
Fix some runtime warnings

15 years agoDon't set row/column to zero when selecting
John Darrington [Fri, 12 Dec 2008 10:26:08 +0000 (19:26 +0900)]
Don't set row/column to zero when selecting

15 years agoFix compiler warning
John Darrington [Fri, 12 Dec 2008 07:34:44 +0000 (16:34 +0900)]
Fix compiler warning

15 years agoFixed bug which manifested itself in the text import dialog
John Darrington [Fri, 12 Dec 2008 07:24:57 +0000 (16:24 +0900)]
Fixed bug which manifested itself in the text import dialog

15 years agoRedraw cells when a row/column is resize
John Darrington [Thu, 11 Dec 2008 09:14:05 +0000 (18:14 +0900)]
Redraw cells when a row/column is resize

15 years agoPrevent updates to the model from feeding back to the current sheet
John Darrington [Wed, 10 Dec 2008 11:58:05 +0000 (20:58 +0900)]
Prevent updates to the model from feeding back to the current sheet

15 years agoFix problem where entry strings got mangled
John Darrington [Wed, 10 Dec 2008 10:28:44 +0000 (19:28 +0900)]
Fix problem where entry strings got mangled

15 years agoFix some warnings
John Darrington [Wed, 10 Dec 2008 08:36:06 +0000 (17:36 +0900)]
Fix some warnings

15 years agoImprove reliability of active cell border rendering
John Darrington [Wed, 10 Dec 2008 05:33:10 +0000 (14:33 +0900)]
Improve reliability of active cell border rendering

15 years agoFixed a problem redrawing the active cell.
John Darrington [Wed, 10 Dec 2008 02:05:29 +0000 (11:05 +0900)]
Fixed a problem redrawing the active cell.

Disabled double buffering on the sheet body since this
seemed to interfere with things.

15 years agoSimplify expose callback
John Darrington [Wed, 10 Dec 2008 01:12:04 +0000 (10:12 +0900)]
Simplify expose callback

15 years agoMerge commit 'HEAD'; branch 'master' into rewrite-sheet
John Darrington [Wed, 10 Dec 2008 00:32:52 +0000 (09:32 +0900)]
Merge commit 'HEAD'; branch 'master' into rewrite-sheet

15 years agoFix up include path for generated source file
John Darrington [Wed, 10 Dec 2008 00:30:15 +0000 (09:30 +0900)]
Fix up include path for generated source file

15 years agoAdded a chapter to the developers' manual about i18n.
John Darrington [Tue, 9 Dec 2008 05:30:55 +0000 (14:30 +0900)]
Added a chapter to the developers' manual about i18n.

15 years agoRemoved that rather kludgy idle callback
John Darrington [Tue, 9 Dec 2008 01:33:09 +0000 (10:33 +0900)]
Removed that rather kludgy idle callback

15 years agoFix bug resizing rows/columns
John Darrington [Tue, 9 Dec 2008 01:20:48 +0000 (10:20 +0900)]
Fix bug resizing rows/columns

15 years agoDon't crash when resizing columns with no associated variable
John Darrington [Mon, 8 Dec 2008 11:26:56 +0000 (20:26 +0900)]
Don't crash when resizing columns with no associated variable

15 years agoDraw the boundary line when resizing rows/columns
John Darrington [Mon, 8 Dec 2008 11:23:06 +0000 (20:23 +0900)]
Draw the boundary line when resizing rows/columns

15 years agoPrevent widths less than 1
John Darrington [Mon, 8 Dec 2008 09:58:05 +0000 (18:58 +0900)]
Prevent widths less than 1

15 years agoFree the elements from the pool
John Darrington [Sun, 7 Dec 2008 13:08:41 +0000 (22:08 +0900)]
Free the elements from the pool

15 years agoMake the axes members of the data editor object
John Darrington [Sun, 7 Dec 2008 11:43:55 +0000 (20:43 +0900)]
Make the axes members of the data editor object

15 years agoWritten a proper implementation of psppire_axis_impl_delete
John Darrington [Sun, 7 Dec 2008 05:50:14 +0000 (14:50 +0900)]
Written a proper implementation of psppire_axis_impl_delete

15 years agoTrap some bad usage
John Darrington [Sun, 7 Dec 2008 02:31:05 +0000 (11:31 +0900)]
Trap some bad usage

15 years agoSet variable display width when datasheet's columns are resized.
John Darrington [Sun, 7 Dec 2008 02:14:16 +0000 (11:14 +0900)]
Set variable display width when datasheet's columns are resized.

15 years agoAdd a resize method to the axis
John Darrington [Sun, 7 Dec 2008 00:12:32 +0000 (09:12 +0900)]
Add a resize method to the axis

15 years agoRemove unused match-files.c.
Ben Pfaff [Sat, 6 Dec 2008 22:28:10 +0000 (14:28 -0800)]
Remove unused match-files.c.

This has been supplanted by combine-files.c, but I forgot to delete
it when I added that file.

Thanks to John Darrington for pointing out the problem.

15 years agoImproved robustness of axis implementation
John Darrington [Sat, 6 Dec 2008 07:13:20 +0000 (16:13 +0900)]
Improved robustness of axis implementation

15 years agoMake the axis implementation more tolerant of boundary conditions
John Darrington [Sat, 6 Dec 2008 03:42:58 +0000 (12:42 +0900)]
Make the axis implementation more tolerant of boundary conditions

15 years agoCanonicalise identifier names
John Darrington [Sat, 6 Dec 2008 03:21:57 +0000 (12:21 +0900)]
Canonicalise identifier names

15 years agoMade the datasheets share axes
John Darrington [Sat, 6 Dec 2008 02:23:31 +0000 (11:23 +0900)]
Made the datasheets share axes

15 years ago(re)enabled dragging of row boundaries
John Darrington [Sat, 6 Dec 2008 02:05:38 +0000 (11:05 +0900)]
(re)enabled dragging of row boundaries

15 years agoReplaced implementation of psppire-axis.
John Darrington [Sat, 6 Dec 2008 00:07:42 +0000 (09:07 +0900)]
Replaced implementation of psppire-axis.

Deleted psppire-axis-hetero.* and psppire-axis-uniform.* and
replaced with psppire-axis-impl.[ch] which combines the benefits
of both.

15 years agoImprove rendering of active cell border
John Darrington [Thu, 4 Dec 2008 12:49:50 +0000 (21:49 +0900)]
Improve rendering of active cell border

15 years agoImprove reliability of active cell border display
John Darrington [Thu, 4 Dec 2008 12:30:02 +0000 (21:30 +0900)]
Improve reliability of active cell border display

15 years agoAllow variables to be entered beyond the end of sheet.
John Darrington [Thu, 4 Dec 2008 02:38:08 +0000 (11:38 +0900)]
Allow variables to be entered beyond the end of sheet.

Several changes to fix the problem where variables beyond
the vertical size of the var sheet couldn't be added.

1. Undo the effect of commit 8c9fae384585163197685e684e62e49a6b922f0c
since it seems to cause problems and need to be rethought.

2. On the traverse callback, don't clamp the range of the requested
   destination cell.  Clamp it only after the signal returns.

3. Add one more row than there are variables.

15 years agoRemove {rows,columns}_resizeable function
John Darrington [Thu, 4 Dec 2008 00:21:55 +0000 (09:21 +0900)]
Remove {rows,columns}_resizeable function

15 years agoMerge branch 'master' into rewrite-sheet
John Darrington [Thu, 4 Dec 2008 00:14:35 +0000 (09:14 +0900)]
Merge branch 'master' into rewrite-sheet

Conflicts:

src/ui/gui/psppire-case-file.c
src/ui/gui/psppire-case-file.h

15 years agoUse value_compare_3way instead of compare_values_short in find dialog
John Darrington [Wed, 3 Dec 2008 23:46:36 +0000 (08:46 +0900)]
Use value_compare_3way instead of compare_values_short in find dialog

15 years agoRemove unused sheetmodel function
John Darrington [Wed, 3 Dec 2008 23:31:22 +0000 (08:31 +0900)]
Remove unused sheetmodel function

15 years agoImplement ADD FILES and UPDATE.
Ben Pfaff [Tue, 18 Nov 2008 05:36:41 +0000 (21:36 -0800)]
Implement ADD FILES and UPDATE.

15 years agoReplace case_ordering with subcase.
Ben Pfaff [Sun, 30 Nov 2008 23:23:20 +0000 (15:23 -0800)]
Replace case_ordering with subcase.

The case_ordering data structure was useful for comparing cases,
but that is all that it did.  In fact, the same data structure
can be used, at least, for extracting data from cases into arrays
of values, stuffing values back into cases, and for more general
comparisons than case_ordering anticipated.

This commit adds those abilities to case_ordering.  It also renames
it to "subcase", because it is useful for more than just sorting
cases, which is all that case_ordering was designed for.

This commit also changes the allocation pattern for subcase from
having the implementation allocate all of the memory, to having
the subcase client allocate "struct subcase".  This saves a
memory allocation without making life harder for anyone.

  - Naming: the "case_ordering" name implied that it was
    only useful for ordering (comparing cases).

  - Interface: the interface

15 years agoBreak get.c up into multiple files in a logical fashion.
Ben Pfaff [Sun, 12 Oct 2008 22:04:09 +0000 (15:04 -0700)]
Break get.c up into multiple files in a logical fashion.

get.c implemented GET, IMPORT, SAVE, XSAVE, EXPORT, XEXPORT,
and MATCH FILES, which seems like too much for one file.

15 years agoAllow MATCH FILES before an active file has been defined.
Ben Pfaff [Wed, 29 Oct 2008 13:33:56 +0000 (06:33 -0700)]
Allow MATCH FILES before an active file has been defined.

Except when it has the active file as an input, MATCH FILES does
not require an active file, and produces an active file, so it
makes sense to allow it anywhere.

Thanks to John Darrington for pointing out the bug.

15 years agoRename compare_values, hash_values with "_short" suffix.
Ben Pfaff [Sun, 30 Nov 2008 23:26:43 +0000 (15:26 -0800)]
Rename compare_values, hash_values with "_short" suffix.

The compare_values and hash_values functions do not compare an
entire value.  Rather, they compare only the short string prefix
of long string values.  I have a feeling that this misnaming was
confusing people (it certainly confused me) so this commit renames
them.

It also adds a new function value_compare_3way() that does what
one what expect such a function to do.

15 years agoKeep adjustment values in their relative positions on resizing sheet
John Darrington [Wed, 3 Dec 2008 01:27:34 +0000 (10:27 +0900)]
Keep adjustment values in their relative positions on resizing sheet

15 years agoOnly grab the focus when appropriate
John Darrington [Tue, 2 Dec 2008 23:48:55 +0000 (08:48 +0900)]
Only grab the focus when appropriate

15 years agoWhitespace change
John Darrington [Tue, 2 Dec 2008 11:07:43 +0000 (20:07 +0900)]
Whitespace change

15 years agoRemove extraneous code moving sheet adjustments on updates
John Darrington [Tue, 2 Dec 2008 10:03:12 +0000 (19:03 +0900)]
Remove extraneous code moving sheet adjustments on updates

15 years agoAdd range_changed callbacks as appropriate
John Darrington [Tue, 2 Dec 2008 09:40:30 +0000 (18:40 +0900)]
Add range_changed callbacks as appropriate

15 years agoUpdate model on inserting/deleting cases
John Darrington [Tue, 2 Dec 2008 04:42:06 +0000 (13:42 +0900)]
Update model on inserting/deleting cases

15 years agoAdded static qualifier
John Darrington [Tue, 2 Dec 2008 04:10:09 +0000 (13:10 +0900)]
Added static qualifier

15 years agoAdd handlers for inserting/deleteing cases
John Darrington [Tue, 2 Dec 2008 03:24:39 +0000 (12:24 +0900)]
Add handlers for inserting/deleteing cases

15 years agoDestroy datasheet, but not if we've made a reader of it
John Darrington [Tue, 2 Dec 2008 01:58:52 +0000 (10:58 +0900)]
Destroy datasheet, but not if we've made a reader of it

15 years agoDeleted psppire-case-file.[ch]
John Darrington [Tue, 2 Dec 2008 01:42:49 +0000 (10:42 +0900)]
Deleted psppire-case-file.[ch]

This module was nothing more than a wrapper around
src/data/datasheet.c Moved its guts into
psppire-data-store.c

15 years agoMerge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
John Darrington [Mon, 1 Dec 2008 12:50:16 +0000 (21:50 +0900)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp

15 years agoFixed some boundary conditions displaying row/column data
John Darrington [Mon, 1 Dec 2008 12:47:21 +0000 (21:47 +0900)]
Fixed some boundary conditions displaying row/column data

15 years agoRemove marshaller from helper.c and use a generated one instead
John Darrington [Mon, 1 Dec 2008 10:13:16 +0000 (19:13 +0900)]
Remove marshaller from helper.c and use a generated one instead

15 years agoRemoved an unsed variable and used an unused macro
John Darrington [Mon, 1 Dec 2008 10:04:44 +0000 (19:04 +0900)]
Removed an unsed variable and used an unused macro

15 years agoDeleted some superflous nonsense
John Darrington [Mon, 1 Dec 2008 10:00:58 +0000 (19:00 +0900)]
Deleted some superflous nonsense

15 years agoReplaced extern "C" with G_BEGIN_DECLS
John Darrington [Mon, 1 Dec 2008 09:55:45 +0000 (18:55 +0900)]
Replaced extern "C" with G_BEGIN_DECLS

15 years agoRemove flicker drawing cell ranges
John Darrington [Mon, 1 Dec 2008 09:44:50 +0000 (18:44 +0900)]
Remove flicker drawing cell ranges

15 years agoMerge branch 'rewrite-sheet' of ssh://jmd@git.sv.gnu.org/srv/git/pspp into rewrite...
John Darrington [Mon, 1 Dec 2008 09:35:16 +0000 (18:35 +0900)]
Merge branch 'rewrite-sheet' of ssh://jmd@git.sv.gnu.org/srv/git/pspp into rewrite-sheet

Conflicts:

src/ui/gui/psppire-var-store.h

15 years agoAdded popup menu to row titles in variable sheet
John Darrington [Mon, 1 Dec 2008 03:46:28 +0000 (12:46 +0900)]
Added popup menu to row titles in variable sheet

15 years agoAdd cast to avoid warning
John Darrington [Mon, 1 Dec 2008 03:23:40 +0000 (12:23 +0900)]
Add cast to avoid warning

15 years agoRename properties so as to be more specific
John Darrington [Mon, 1 Dec 2008 03:21:29 +0000 (12:21 +0900)]
Rename properties so as to be more specific

15 years agoCalculate the width of M based on the current font
John Darrington [Mon, 1 Dec 2008 01:59:14 +0000 (10:59 +0900)]
Calculate the width of M based on the current font

15 years agoRemove unused variable
John Darrington [Mon, 1 Dec 2008 01:29:26 +0000 (10:29 +0900)]
Remove unused variable

15 years agoRemove font information from cell attributes and sheet model.
John Darrington [Mon, 1 Dec 2008 01:07:48 +0000 (10:07 +0900)]
Remove font information from cell attributes and sheet model.

Deleted the font_desc member from the GtkSheetCellAttr struct
and also all font related stuff from the GSheetModel interface.
Instead, fonts are now considered strictly a parameter of the
viewing widget instead of data in the model.

15 years agoFix memory leak in get_system_decimal().
Ben Pfaff [Tue, 25 Nov 2008 06:12:01 +0000 (22:12 -0800)]
Fix memory leak in get_system_decimal().

15 years agoAdd PKG_CHECK_MODULES to forbidden m4 patterns.
Ben Pfaff [Wed, 29 Oct 2008 13:32:04 +0000 (06:32 -0700)]
Add PKG_CHECK_MODULES to forbidden m4 patterns.

This should help to catch running autoconf on systems that lack
pkg-config earlier in the build process.

15 years agoRemove unused property from var-sheet
John Darrington [Sun, 30 Nov 2008 07:53:56 +0000 (16:53 +0900)]
Remove unused property from var-sheet

15 years agoAdd mutual links to VARIABLE/DATAFILE ATTRIBUTE documentation
John Darrington [Sun, 30 Nov 2008 05:46:24 +0000 (14:46 +0900)]
Add mutual links to VARIABLE/DATAFILE ATTRIBUTE documentation

15 years agoWhen adding variables in varsheet, add at the current position.
John Darrington [Sun, 30 Nov 2008 04:08:56 +0000 (13:08 +0900)]
When adding variables in varsheet, add at the current position.

Previously variables could only be inserted at the start of the dictionary.
Fixes bug #24502

15 years agoFixed problem when double clicking on column header
John Darrington [Sun, 30 Nov 2008 03:06:40 +0000 (12:06 +0900)]
Fixed problem when double clicking on column header