pintos-anon
18 years agoTest commit.
Ben Pfaff [Tue, 14 Mar 2006 22:43:44 +0000 (22:43 +0000)]
Test commit.

18 years agoFix type of sector_idx in inode_write_at().
Ben Pfaff [Thu, 9 Mar 2006 05:59:39 +0000 (05:59 +0000)]
Fix type of sector_idx in inode_write_at().
Thanks to Ryan Seth Propper <rpropper@stanford.edu> for reporting this
bug.

18 years ago-u option should be -ul.
Ben Pfaff [Mon, 6 Mar 2006 17:14:40 +0000 (17:14 +0000)]
-u option should be -ul.
Thanks to Josh Wiseman <joshwise@stanford.edu> for reporting this bug.

18 years agoPHYS_ADDR should be PHYS_BASE.
Ben Pfaff [Thu, 2 Feb 2006 14:47:50 +0000 (14:47 +0000)]
PHYS_ADDR should be PHYS_BASE.
Thanks to "Ryan Seth Propper" <rpropper@stanford.edu> for pointing it
out.

18 years agoAttempting to pass command-line arguments before they've been
Ben Pfaff [Wed, 1 Feb 2006 20:58:50 +0000 (20:58 +0000)]
Attempting to pass command-line arguments before they've been
implemented will fail.
Thanks to Josh Wiseman for pointing this out.

18 years agoClarify when enable_mlfqs gets set.
Ben Pfaff [Sun, 29 Jan 2006 21:55:08 +0000 (21:55 +0000)]
Clarify when enable_mlfqs gets set.
Thanks to "Yi Lang Mok" <yilangmok@stanford.edu> and others for
pointing this out.

18 years agoClarify when enable_mlfqs gets set.
Ben Pfaff [Sun, 29 Jan 2006 21:54:44 +0000 (21:54 +0000)]
Clarify when enable_mlfqs gets set.
Thanks to "Yi Lang Mok" <yilangmok@stanford.edu> and others for
pointing this out.

18 years agoUpdate Intel architecture guide references to latest.
Ben Pfaff [Sun, 29 Jan 2006 21:32:55 +0000 (21:32 +0000)]
Update Intel architecture guide references to latest.
Thanks to Josh Wiseman <joshwise@stanford.edu> and Godmar Back
<godmar@gmail.com> for pointing this out.

18 years agoAdd examples of how to iterate and remove elements from a list.
Ben Pfaff [Wed, 25 Jan 2006 22:10:19 +0000 (22:10 +0000)]
Add examples of how to iterate and remove elements from a list.
Pointed out by Ben Sapp.

18 years agoClean up temp files on signal.
Ben Pfaff [Thu, 12 Jan 2006 17:04:09 +0000 (17:04 +0000)]
Clean up temp files on signal.

18 years agoFix priority donation example.
Ben Pfaff [Tue, 10 Jan 2006 22:56:29 +0000 (22:56 +0000)]
Fix priority donation example.
From Godmar Back's TA.

18 years agoTypo fixes found by Godmar Back's TA.
Ben Pfaff [Tue, 10 Jan 2006 00:14:14 +0000 (00:14 +0000)]
Typo fixes found by Godmar Back's TA.

18 years agoAdd "panic: action=fatal" to bochsrc.txt to avoid a potentially
Ben Pfaff [Tue, 10 Jan 2006 00:13:01 +0000 (00:13 +0000)]
Add "panic: action=fatal" to bochsrc.txt to avoid a potentially
confusing dialogue on control+c or timeout.
Via Godmar Back.

18 years agoFix comment.
Ben Pfaff [Sun, 8 Jan 2006 20:21:31 +0000 (20:21 +0000)]
Fix comment.

18 years agoRemove -Wdeclaration-after-statement because it's not supported by GCC
Ben Pfaff [Sun, 8 Jan 2006 20:09:25 +0000 (20:09 +0000)]
Remove -Wdeclaration-after-statement because it's not supported by GCC
(GCC 3.4) on the elaines.  Ugh.

18 years agoAdd explanatory comments to vm tests.
Ben Pfaff [Sun, 8 Jan 2006 19:00:20 +0000 (19:00 +0000)]
Add explanatory comments to vm tests.

18 years agoAdd explanatory comments to filesys tests.
Ben Pfaff [Sun, 8 Jan 2006 18:59:11 +0000 (18:59 +0000)]
Add explanatory comments to filesys tests.

18 years agoAdd explanatory comments to vm tests.
Ben Pfaff [Sun, 8 Jan 2006 18:02:41 +0000 (18:02 +0000)]
Add explanatory comments to vm tests.

18 years agoFormatting.
Ben Pfaff [Sun, 8 Jan 2006 03:35:04 +0000 (03:35 +0000)]
Formatting.

18 years agoAdd explanatory comments to vm tests.
Ben Pfaff [Sun, 8 Jan 2006 03:24:27 +0000 (03:24 +0000)]
Add explanatory comments to vm tests.

18 years agoAdd explanatory comments to userprog tests.
Ben Pfaff [Sun, 8 Jan 2006 01:08:06 +0000 (01:08 +0000)]
Add explanatory comments to userprog tests.

18 years agoRemove file that was not used.
Ben Pfaff [Sun, 8 Jan 2006 01:07:21 +0000 (01:07 +0000)]
Remove file that was not used.

18 years agoAdd explanatory comments to threads tests.
Ben Pfaff [Sat, 7 Jan 2006 02:08:18 +0000 (02:08 +0000)]
Add explanatory comments to threads tests.

18 years agoElaborate on how to get the user program's stack pointer.
Ben Pfaff [Wed, 4 Jan 2006 22:45:01 +0000 (22:45 +0000)]
Elaborate on how to get the user program's stack pointer.
Suggested by Godmar Back.

18 years agoDon't check return value of write().
Ben Pfaff [Wed, 4 Jan 2006 21:51:59 +0000 (21:51 +0000)]
Don't check return value of write().

18 years agoClarify question.
Ben Pfaff [Wed, 4 Jan 2006 21:33:25 +0000 (21:33 +0000)]
Clarify question.
Via "Bruce Schechter" <bruceds@stanford.edu>.

18 years agoClarify stack limit.
Ben Pfaff [Wed, 4 Jan 2006 21:30:15 +0000 (21:30 +0000)]
Clarify stack limit.

18 years agoClarifying comments.
Ben Pfaff [Wed, 4 Jan 2006 21:27:52 +0000 (21:27 +0000)]
Clarifying comments.
Via "Amit Nagpal" <anagpal1@stanford.edu>.

18 years agoHelpful comment.
Ben Pfaff [Wed, 4 Jan 2006 21:21:50 +0000 (21:21 +0000)]
Helpful comment.
Via Megan Anneke Wachs <wachs@stanford.edu>.

18 years agoAdd additional disclaimer to "diffstat"s.
Ben Pfaff [Wed, 4 Jan 2006 21:17:34 +0000 (21:17 +0000)]
Add additional disclaimer to "diffstat"s.

18 years agoTypo in comment.
Ben Pfaff [Wed, 4 Jan 2006 21:16:36 +0000 (21:16 +0000)]
Typo in comment.

18 years agoNew test for growing the stack using a system call.
Ben Pfaff [Wed, 4 Jan 2006 21:15:37 +0000 (21:15 +0000)]
New test for growing the stack using a system call.
From Godmar Back.

18 years agoGrammar.
Ben Pfaff [Wed, 4 Jan 2006 21:07:01 +0000 (21:07 +0000)]
Grammar.
From Godmar Back.

18 years agoMention that other aliases should only arise from sharing or bugs.
Ben Pfaff [Wed, 4 Jan 2006 21:05:17 +0000 (21:05 +0000)]
Mention that other aliases should only arise from sharing or bugs.

18 years agoClarify that swap needs to be written when needed, not before.
Ben Pfaff [Wed, 4 Jan 2006 20:14:45 +0000 (20:14 +0000)]
Clarify that swap needs to be written when needed, not before.

18 years agoAdd clarifying comment.
Ben Pfaff [Wed, 4 Jan 2006 20:08:04 +0000 (20:08 +0000)]
Add clarifying comment.
Via Bruce Schechter.

18 years agoNote about testing.
Ben Pfaff [Wed, 4 Jan 2006 20:03:28 +0000 (20:03 +0000)]
Note about testing.

18 years agoClarify that an ELF loader is provided.
Ben Pfaff [Wed, 4 Jan 2006 19:52:43 +0000 (19:52 +0000)]
Clarify that an ELF loader is provided.
Via Ben Sapp.

18 years agoClarify ROX.
Ben Pfaff [Wed, 4 Jan 2006 19:49:20 +0000 (19:49 +0000)]
Clarify ROX.

18 years agoMove PF_* from exception.c to exception.h, because some students may
Ben Pfaff [Wed, 4 Jan 2006 18:56:16 +0000 (18:56 +0000)]
Move PF_* from exception.c to exception.h, because some students may
wish to pass them around.
Suggested by Godmar Back.

18 years agoMove PF_* from exception.c to exception.h, because some students may
Ben Pfaff [Wed, 4 Jan 2006 18:56:16 +0000 (18:56 +0000)]
Move PF_* from exception.c to exception.h, because some students may
wish to pass them around.
Suggested by Godmar Back.

18 years agoMove some FAQs into the specification for mmap'd files.
Ben Pfaff [Wed, 4 Jan 2006 18:53:03 +0000 (18:53 +0000)]
Move some FAQs into the specification for mmap'd files.

18 years agoAdd hash_apply() function.
Ben Pfaff [Wed, 4 Jan 2006 18:36:53 +0000 (18:36 +0000)]
Add hash_apply() function.
Revise hash_clear(), hash_delete() to take destructor function
argument.
Fully document hash table.

18 years agoAlways round up disk sizes to multiple of a cylinder,
Ben Pfaff [Tue, 3 Jan 2006 20:20:18 +0000 (20:20 +0000)]
Always round up disk sizes to multiple of a cylinder,
because Bochs 2.2.5 requires that.
Based on patch from Godmar Back.

18 years agoMove mmap consistency FAQ into assignment description.
Ben Pfaff [Tue, 3 Jan 2006 17:03:46 +0000 (17:03 +0000)]
Move mmap consistency FAQ into assignment description.

18 years agoPartial mmap'd pages need not be lazy loaded.
Ben Pfaff [Tue, 3 Jan 2006 17:00:02 +0000 (17:00 +0000)]
Partial mmap'd pages need not be lazy loaded.

18 years agoGet rid of -rndpg option for now, because none of the tests use it.
Ben Pfaff [Tue, 3 Jan 2006 16:50:59 +0000 (16:50 +0000)]
Get rid of -rndpg option for now, because none of the tests use it.
In the future it may make sense to reintroduce it (and test it).

18 years agoClarification.
Ben Pfaff [Thu, 22 Dec 2005 20:51:30 +0000 (20:51 +0000)]
Clarification.

18 years agoMention that keyboard input does not work with "pintos -v".
Ben Pfaff [Thu, 22 Dec 2005 20:49:13 +0000 (20:49 +0000)]
Mention that keyboard input does not work with "pintos -v".

18 years agoClarification.
Ben Pfaff [Thu, 22 Dec 2005 20:47:21 +0000 (20:47 +0000)]
Clarification.

18 years agoMention that process_wait() can be changed to an infinite loop
Ben Pfaff [Thu, 22 Dec 2005 20:44:27 +0000 (20:44 +0000)]
Mention that process_wait() can be changed to an infinite loop
temporarily.

18 years agoFix formula.
Ben Pfaff [Thu, 22 Dec 2005 01:18:35 +0000 (01:18 +0000)]
Fix formula.

18 years agoUse -Wdeclaration-after-statement.
Ben Pfaff [Wed, 21 Dec 2005 23:48:57 +0000 (23:48 +0000)]
Use -Wdeclaration-after-statement.

18 years agoDon't need GCC patch anymore because we don't use Intel syntax.
Ben Pfaff [Wed, 21 Dec 2005 23:48:40 +0000 (23:48 +0000)]
Don't need GCC patch anymore because we don't use Intel syntax.

18 years agoComments.
Ben Pfaff [Wed, 21 Dec 2005 23:46:05 +0000 (23:46 +0000)]
Comments.

18 years agoUse AT&T syntax instead of Intel.
Ben Pfaff [Wed, 21 Dec 2005 23:44:35 +0000 (23:44 +0000)]
Use AT&T syntax instead of Intel.

18 years agoDon't use -I- because GCC 4.0 complains.
Ben Pfaff [Wed, 21 Dec 2005 22:35:07 +0000 (22:35 +0000)]
Don't use -I- because GCC 4.0 complains.
(Can't use -iquote because GCC 3.x doesn't have it.)

18 years agoAdd cast to silence new warning in GCC 4.0.
Ben Pfaff [Wed, 21 Dec 2005 22:31:36 +0000 (22:31 +0000)]
Add cast to silence new warning in GCC 4.0.

18 years agoUse bool vars instead of bits for shift keys.
Ben Pfaff [Wed, 21 Dec 2005 04:56:23 +0000 (04:56 +0000)]
Use bool vars instead of bits for shift keys.

18 years agoRevise "Design" description.
Ben Pfaff [Wed, 21 Dec 2005 03:21:33 +0000 (03:21 +0000)]
Revise "Design" description.
Based on Ben Sapp <bensapp@stanford.edu> comments.

18 years agoClarify "invalid PID".
Ben Pfaff [Wed, 21 Dec 2005 01:00:32 +0000 (01:00 +0000)]
Clarify "invalid PID".
Thanks to "Kevin Hart" <kevin.hart@hp.com> for question.

18 years agoClarify function comment.
Ben Pfaff [Wed, 21 Dec 2005 00:58:30 +0000 (00:58 +0000)]
Clarify function comment.
Via Ben Sapp <bensapp@stanford.edu>.

18 years agoAdd "suggested order of implementation" section.
Ben Pfaff [Wed, 21 Dec 2005 00:56:06 +0000 (00:56 +0000)]
Add "suggested order of implementation" section.

18 years agoClarify that multithreaded processes not supported.
Ben Pfaff [Tue, 20 Dec 2005 23:45:09 +0000 (23:45 +0000)]
Clarify that multithreaded processes not supported.

18 years agoClarify.
Ben Pfaff [Tue, 20 Dec 2005 23:41:15 +0000 (23:41 +0000)]
Clarify.

18 years agoAdd suggested implementations for filesys syscalls.
Ben Pfaff [Tue, 20 Dec 2005 23:39:13 +0000 (23:39 +0000)]
Add suggested implementations for filesys syscalls.
Clarify write syscall description.

18 years agoClarify that struct intr_frame is on the kernel stack.
Ben Pfaff [Tue, 20 Dec 2005 23:24:52 +0000 (23:24 +0000)]
Clarify that struct intr_frame is on the kernel stack.
Thanks to "Kevin Hart" <kevin.hart@hp.com> for the question.

18 years agoClarifications.
Ben Pfaff [Tue, 20 Dec 2005 23:21:15 +0000 (23:21 +0000)]
Clarifications.
Pointer to instructions for debugging user programs.

18 years agoAllow .png as alternate for ASCII art.
Ben Pfaff [Tue, 20 Dec 2005 22:58:44 +0000 (22:58 +0000)]
Allow .png as alternate for ASCII art.

18 years agoClarify that the idle thread does not receive recent_cpu.
Ben Pfaff [Tue, 20 Dec 2005 22:54:51 +0000 (22:54 +0000)]
Clarify that the idle thread does not receive recent_cpu.

18 years agoWording.
Ben Pfaff [Tue, 20 Dec 2005 22:52:01 +0000 (22:52 +0000)]
Wording.

18 years agoIt's okay to use a single sorted queue for MLFQS.
Ben Pfaff [Tue, 20 Dec 2005 22:32:05 +0000 (22:32 +0000)]
It's okay to use a single sorted queue for MLFQS.

18 years agoSuggest order of operations for recent_cpu calculation.
Ben Pfaff [Tue, 20 Dec 2005 22:26:13 +0000 (22:26 +0000)]
Suggest order of operations for recent_cpu calculation.
Thanks to "Jeff Sun" <precisely@gmail.com> for report.

18 years agoSuggest 17.14 instead of 21.10 because the extra precision may be
Ben Pfaff [Tue, 20 Dec 2005 22:15:44 +0000 (22:15 +0000)]
Suggest 17.14 instead of 21.10 because the extra precision may be
necessary for some implementations.
Thanks to Matt Page <mpage@stanford.edu> and "Jeff Sun"
<precisely@gmail.com> for the suggestion.

18 years agoExplain why it sometimes looks like pass() fails.
Ben Pfaff [Tue, 20 Dec 2005 21:27:33 +0000 (21:27 +0000)]
Explain why it sometimes looks like pass() fails.

18 years agoMake backtrace chop long filenames to just the last few characters.
Ben Pfaff [Tue, 20 Dec 2005 21:11:42 +0000 (21:11 +0000)]
Make backtrace chop long filenames to just the last few characters.

18 years agoWording.
Ben Pfaff [Tue, 20 Dec 2005 20:47:43 +0000 (20:47 +0000)]
Wording.

18 years agoAdd CVS Locking to menu.
Ben Pfaff [Tue, 20 Dec 2005 20:47:21 +0000 (20:47 +0000)]
Add CVS Locking to menu.

18 years agoIgnore pintos.text.
Ben Pfaff [Tue, 20 Dec 2005 20:47:01 +0000 (20:47 +0000)]
Ignore pintos.text.

18 years agoBe slightly more lenient.
Ben Pfaff [Tue, 20 Dec 2005 20:46:38 +0000 (20:46 +0000)]
Be slightly more lenient.

18 years agoIgnore *.d.
Ben Pfaff [Tue, 20 Dec 2005 20:45:41 +0000 (20:45 +0000)]
Ignore *.d.

18 years agoClarifications.
Ben Pfaff [Tue, 20 Dec 2005 20:44:39 +0000 (20:44 +0000)]
Clarifications.
Add FAQ for how to run tests.

18 years agoAdd summary of scheduler.
Ben Pfaff [Tue, 20 Dec 2005 20:42:15 +0000 (20:42 +0000)]
Add summary of scheduler.

18 years agoComment idle thread more thoroughly.
Ben Pfaff [Tue, 20 Dec 2005 20:03:51 +0000 (20:03 +0000)]
Comment idle thread more thoroughly.
Thanks to "Kevin Hart" <kevin.hart@hp.com> for asking questions.

18 years agoFix description of rounding to nearest in fixed point to take into
Ben Pfaff [Tue, 20 Dec 2005 19:47:32 +0000 (19:47 +0000)]
Fix description of rounding to nearest in fixed point to take into
account negative numbers.  Thanks to Nishit Sureshchandra Shah
<nishit@stanford.edu> for the correction.

18 years agoClarify that adding code where interrupts are already disabled may be
Ben Pfaff [Tue, 20 Dec 2005 18:35:50 +0000 (18:35 +0000)]
Clarify that adding code where interrupts are already disabled may be
necessary.

18 years agoWording clarifications.
Ben Pfaff [Tue, 20 Dec 2005 18:30:03 +0000 (18:30 +0000)]
Wording clarifications.

18 years agoTalk about CVS locks.
Ben Pfaff [Tue, 20 Dec 2005 18:17:30 +0000 (18:17 +0000)]
Talk about CVS locks.

18 years agoWording clarifications.
Ben Pfaff [Tue, 20 Dec 2005 18:03:02 +0000 (18:03 +0000)]
Wording clarifications.

18 years agoClarifying comment.
Ben Pfaff [Tue, 20 Dec 2005 18:02:50 +0000 (18:02 +0000)]
Clarifying comment.

18 years agoAdd comment that gdb and pintos have to run on the same machine.
Ben Pfaff [Tue, 20 Dec 2005 07:33:37 +0000 (07:33 +0000)]
Add comment that gdb and pintos have to run on the same machine.

18 years agoMention that aklog and/or logging out and back in may be necessary to
Ben Pfaff [Tue, 20 Dec 2005 07:28:19 +0000 (07:28 +0000)]
Mention that aklog and/or logging out and back in may be necessary to
gain new group membership.

18 years agoRevising "Setting Up CVS" section.
Ben Pfaff [Tue, 20 Dec 2005 07:19:43 +0000 (07:19 +0000)]
Revising "Setting Up CVS" section.
Need to `fs setacl' $HOME also.
Add summary of commands.

18 years agoAdd plaintext target.
Ben Pfaff [Tue, 20 Dec 2005 07:17:48 +0000 (07:17 +0000)]
Add plaintext target.

18 years agoCheck for the compiler's availability early in the `make' run, in
Ben Pfaff [Tue, 20 Dec 2005 06:27:07 +0000 (06:27 +0000)]
Check for the compiler's availability early in the `make' run, in
Make.config, and give a warning that points to the documentation if we
can't find it.
Also, modify other Makefiles so that Make.config is only included
once, so that the message is only printed once.

18 years agoAdd some clarifications to address question from "Kevin Hart"
Ben Pfaff [Tue, 20 Dec 2005 04:17:18 +0000 (04:17 +0000)]
Add some clarifications to address question from "Kevin Hart"
<kevin.hart@hp.com>.

18 years agoDon't use ! in shell--Solaris sh doesn't support it.
Ben Pfaff [Tue, 20 Dec 2005 03:27:15 +0000 (03:27 +0000)]
Don't use ! in shell--Solaris sh doesn't support it.

18 years agoCall qemu with "-nics 0" to avoid calling any network initialization
Ben Pfaff [Tue, 20 Dec 2005 00:26:27 +0000 (00:26 +0000)]
Call qemu with "-nics 0" to avoid calling any network initialization
script.

18 years agoRevert Intel-style assembly back to AT&T-style.
Ben Pfaff [Tue, 20 Dec 2005 00:25:23 +0000 (00:25 +0000)]
Revert Intel-style assembly back to AT&T-style.
The Intel-style assembly found too many bugs in GAS
and the GAS folks actually changed behavior on us
for lidt, lgdt.

18 years agoFix fencepost error in strstr().
Ben Pfaff [Tue, 13 Dec 2005 06:47:18 +0000 (06:47 +0000)]
Fix fencepost error in strstr().
Thanks to Bryan Branstetter for bug and fix.