Avoid writes to variables that are never read back.
authorBen Pfaff <blp@nicira.com>
Sun, 13 May 2012 23:34:49 +0000 (16:34 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 14 May 2012 16:37:18 +0000 (09:37 -0700)
Found by clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/ofp-print.c
utilities/ovs-vsctl.c

index 7479bf222ca98840615afced3306c9b4ae2f1ee1..1757a30c3be522c69f1d1bef60123e90da51c619 100644 (file)
@@ -480,7 +480,7 @@ ofp_print_bit_names(struct ds *string, uint32_t bits,
     }
 
     if (bits) {
-        if (n++) {
+        if (n) {
             ds_put_char(string, ' ');
         }
         ds_put_format(string, "0x%"PRIx32, bits);
index 2fc87f00277fc0cc57198e6fe1f9f1b15a71b229..d8aeb53d8bcb0036a1e6c9c9c09bb7b2bddaa677 100644 (file)
@@ -3809,8 +3809,6 @@ do_vsctl(const char *args, struct vsctl_command *commands, size_t n_commands,
 
         if (ctx.try_again) {
             vsctl_context_done(&ctx, NULL);
-
-            status = TXN_TRY_AGAIN;
             goto try_again;
         }
     }