vswitchd: Drop 'need_refresh' member from struct iface.
authorBen Pfaff <blp@nicira.com>
Tue, 24 Apr 2012 22:43:11 +0000 (15:43 -0700)
committerBen Pfaff <blp@nicira.com>
Wed, 25 Apr 2012 01:08:39 +0000 (18:08 -0700)
It's no longer useful.

Signed-off-by: Ben Pfaff <blp@nicira.com>
vswitchd/bridge.c

index 058d7c024f0f13ad1ffdc3dce7c628010060e5e5..204972083d50b994fe8a7d840c35b4b582f1a95d 100644 (file)
@@ -87,7 +87,6 @@ struct iface {
     struct netdev *netdev;      /* Network device. */
     const char *type;           /* Usually same as cfg->type. */
     const struct ovsrec_interface *cfg;
-    bool need_refresh;          /* Refresh iface after create. */
 };
 
 struct mirror {
@@ -1253,7 +1252,6 @@ iface_create(struct bridge *br, struct if_cfg *if_cfg, int ofp_port)
     iface->ofp_port = -1;
     iface->netdev = NULL;
     iface->cfg = if_cfg->cfg;
-    iface->need_refresh = true;
     hmap_insert(&br->iface_by_name, &iface->name_node,
                 hash_string(iface->name, 0));
     list_push_back(&port->ifaces, &iface->port_elem);
@@ -1313,11 +1311,10 @@ iface_create(struct bridge *br, struct if_cfg *if_cfg, int ofp_port)
         }
     }
 
-    /* Populate stats columns in new Interface rows. */
-    if (iface->netdev && iface->need_refresh) {
+    /* Initially populate stats columns. */
+    if (iface->netdev) {
         iface_refresh_stats(iface);
         iface_refresh_status(iface);
-        iface->need_refresh = false;
     }
 
     /* Delete the iface if we failed. */