timeval: Fix occasional backtrace() related deadlock.
authorEthan Jackson <ethan@nicira.com>
Fri, 26 Oct 2012 19:33:01 +0000 (12:33 -0700)
committerEthan Jackson <ethan@nicira.com>
Fri, 26 Oct 2012 21:44:33 +0000 (14:44 -0700)
Occasionally, backtrace() will deadlock in the signal handler
because it does some non signal safe initialization.  Specifically,
it opens a shared object.  As a work around, this patch forces
backtrace() to run outside of a signal handler, so that future
calls will perform as expected.

Signed-off-by: Ethan Jackson <ethan@nicira.com>
lib/timeval.c

index 05f1c2d3643030dc16c20bdcacb44cc0f72311ac..d8539892afa57145f6d90d84056f1eb0dc86c010 100644 (file)
@@ -121,6 +121,16 @@ time_init(void)
     }
     inited = true;
 
+    /* The implementation of backtrace() in glibc does some one time
+     * initialization which is not signal safe.  This can cause deadlocks if
+     * run from the signal handler.  As a workaround, force the initialization
+     * to happen here. */
+    if (HAVE_EXECINFO_H) {
+        void *bt[1];
+
+        backtrace(bt, ARRAY_SIZE(bt));
+    }
+
     memset(traces, 0, sizeof traces);
 
     if (HAVE_EXECINFO_H && CACHE_TIME) {