ofproto-dpif: Drop unneeded _SAFE from iteration in handle_flow_miss().
authorBen Pfaff <blp@nicira.com>
Mon, 16 Apr 2012 21:07:56 +0000 (14:07 -0700)
committerBen Pfaff <blp@nicira.com>
Thu, 19 Apr 2012 03:28:10 +0000 (20:28 -0700)
The loop never frees the packet that it operates on, so _SAFE is not
needed.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ofproto/ofproto-dpif.c

index a42d09eb9575f2dc8f6f09667335e5bbc667a567..f9936e4c7f1c6359ae5a6a5fbc06616a123f47bf 100644 (file)
@@ -2562,8 +2562,8 @@ handle_flow_miss(struct ofproto_dpif *ofproto, struct flow_miss *miss,
                  struct flow_miss_op *ops, size_t *n_ops)
 {
     const struct flow *flow = &miss->flow;
-    struct ofpbuf *packet, *next_packet;
     struct subfacet *subfacet;
+    struct ofpbuf *packet;
     struct facet *facet;
 
     facet = facet_lookup_valid(ofproto, flow);
@@ -2599,7 +2599,7 @@ handle_flow_miss(struct ofproto_dpif *ofproto, struct flow_miss *miss,
                                miss->key_fitness, miss->key, miss->key_len,
                                miss->initial_tci);
 
-    LIST_FOR_EACH_SAFE (packet, next_packet, list_node, &miss->packets) {
+    LIST_FOR_EACH (packet, list_node, &miss->packets) {
         struct dpif_flow_stats stats;
         struct flow_miss_op *op;
         struct dpif_execute *execute;