ovs-monitor-ipsec: Use all caps for global constants.
authorJustin Pettit <jpettit@nicira.com>
Sat, 10 Mar 2012 19:04:42 +0000 (11:04 -0800)
committerJustin Pettit <jpettit@nicira.com>
Sat, 10 Mar 2012 19:04:42 +0000 (11:04 -0800)
The convention in Python is to use all caps for global constants.

Signed-off-by: Justin Pettit <jpettit@nicira.com>
debian/ovs-monitor-ipsec

index 87a149113f1bc2df61e5c301ed3d09c98a21cb99..a4a4575491b31028ae1ba7e71027245cbad8446e 100755 (executable)
@@ -42,7 +42,7 @@ import ovs.vlog
 
 vlog = ovs.vlog.Vlog("ovs-monitor-ipsec")
 root_prefix = ''                # Prefix for absolute file names, for testing.
-setkey = "/usr/sbin/setkey"
+SETKEY = "/usr/sbin/setkey"
 exiting = False
 
 
@@ -266,11 +266,11 @@ class IPsec:
 
     def call_setkey(self, cmds):
         try:
-            p = subprocess.Popen([root_prefix + setkey, "-c"],
+            p = subprocess.Popen([root_prefix + SETKEY, "-c"],
                                  stdin=subprocess.PIPE,
                                  stdout=subprocess.PIPE)
         except:
-            vlog.err("could not call %s%s" % (root_prefix, setkey))
+            vlog.err("could not call %s%s" % (root_prefix, SETKEY))
             sys.exit(1)
 
         # xxx It is safer to pass the string into the communicate()