John Darrington [Sun, 20 Sep 2020 19:10:56 +0000 (21:10 +0200)]
PsppireKeypad: Remove deprecated properties
John Darrington [Sun, 20 Sep 2020 19:09:56 +0000 (21:09 +0200)]
src/ui/gui/psppire.xml: Add definition of PsppireKeypad
John Darrington [Sat, 19 Sep 2020 20:07:46 +0000 (22:07 +0200)]
Oneway Dialog: Remove deprecated properties
John Darrington [Sat, 19 Sep 2020 20:00:12 +0000 (22:00 +0200)]
Reliability Dialog: Remove depdecated properties
John Darrington [Sat, 19 Sep 2020 20:00:00 +0000 (22:00 +0200)]
Factor Dialog: Remove depdecated properties
John Darrington [Sat, 19 Sep 2020 19:48:39 +0000 (21:48 +0200)]
Aggregate Dialog Box: Remove deprecated properties
John Darrington [Sat, 19 Sep 2020 19:37:04 +0000 (21:37 +0200)]
Recode Dialog Box: Remove deprecated properties
John Darrington [Sat, 19 Sep 2020 19:22:58 +0000 (21:22 +0200)]
psppire.xml: Add PsppireAcr and PsppireValChooser
John Darrington [Sat, 19 Sep 2020 06:54:40 +0000 (08:54 +0200)]
Select Cases Dialog: Make the 'All Cases' button easier to select.
The radiobutton area is very small and hard to click.
This change adds an Eventbox under the corresponding
label, So clicking on the label will have the same effect.
John Darrington [Sat, 19 Sep 2020 05:44:11 +0000 (07:44 +0200)]
Select Cases Dialog: Cosmetic Improvements
John Darrington [Sat, 19 Sep 2020 05:31:25 +0000 (07:31 +0200)]
Rank Dialog: Cosmetic Improvements
John Darrington [Sat, 19 Sep 2020 05:19:13 +0000 (07:19 +0200)]
Frequencies Dialog: Cosmetic Improvements
John Darrington [Sat, 19 Sep 2020 04:22:09 +0000 (06:22 +0200)]
Examine Spreadlevel: Allow power to be non-integer
John Darrington [Sat, 19 Sep 2020 04:21:14 +0000 (06:21 +0200)]
Examine Plots Dialog : Set combo box sensitivity
John Darrington [Sat, 19 Sep 2020 04:20:00 +0000 (06:20 +0200)]
src/ui/gui/psppire-dialog-action-examine.c: constness
John Darrington [Sat, 19 Sep 2020 04:18:43 +0000 (06:18 +0200)]
Examine Dialog: Cosmetic improvements
John Darrington [Sat, 19 Sep 2020 04:15:50 +0000 (06:15 +0200)]
doc/invoking.texi (Main Options): Correct minor informational error
Friedrich Beckmann [Tue, 15 Sep 2020 10:07:10 +0000 (12:07 +0200)]
metainfo - changed url from commit to tree
Friedrich Beckmann [Tue, 15 Sep 2020 10:01:55 +0000 (12:01 +0200)]
metainfo: added releases 1.4.0 and 1.4.1
Friedrich Beckmann [Tue, 15 Sep 2020 09:53:00 +0000 (11:53 +0200)]
metainfo: Fixed typos in metainfo
Jaap Verhage found several wrong wordings. I changed them according
to his proposals. See:
https://lists.gnu.org/archive/html/pspp-dev/2020-09/msg00058.html
Friedrich Beckmann [Sun, 13 Sep 2020 21:55:00 +0000 (23:55 +0200)]
psppire: add "Plots" subdialog for examine (Explore)
Closes: https://savannah.gnu.org/bugs/?49674
John Darrington [Sun, 13 Sep 2020 11:46:20 +0000 (13:46 +0200)]
Psppire: Move Mac OS specific code to its own file
John Darrington [Sat, 12 Sep 2020 20:03:15 +0000 (22:03 +0200)]
Percentiles: Remove unused static data
John Darrington [Sat, 12 Sep 2020 17:31:58 +0000 (19:31 +0200)]
Use PACKAGE_BUGREPORT instead of a literal string
John Darrington [Sat, 12 Sep 2020 17:16:03 +0000 (19:16 +0200)]
Remove obsolete acknowlegdement.
Network Theory Ltd. have been dissolved so they cannot benefit from our
acknowledgement.
Ben Pfaff [Sat, 12 Sep 2020 16:53:52 +0000 (09:53 -0700)]
i18n: Fix use of const qualifiers in create_iconv().
Only the inbuf parameter of iconv() takes a const qualifier, on some POSIX
nonconforming systems, but all of its parameters were qualified here, which
caused warnings on those nonconforming systems. This fixes the problem.
Found with win-iconv for mingw.
John Darrington [Sat, 12 Sep 2020 12:35:18 +0000 (14:35 +0200)]
Regression Dialog: Reduce the size of the Independent Variables widget.
It is uncommon to perform a linear regression on many predictor variables.
But it is quite common to have many depdendent variables. This change
reduces the size of the predictor variable view widget and increases the
size of the regressor variable view widget.
John Darrington [Sat, 12 Sep 2020 05:35:25 +0000 (07:35 +0200)]
README.Git: Remove mention of --with-gui-tools.
This information is obsolete.
John Darrington [Sat, 12 Sep 2020 05:31:58 +0000 (07:31 +0200)]
Add static qualifiers where appropriate.
A number of items were defined in global scope. This change
puts them into file scope.
Friedrich Beckmann [Fri, 11 Sep 2020 21:01:11 +0000 (23:01 +0200)]
psppire-output: added drag-n-drop
Friedrich Beckmann [Fri, 11 Sep 2020 16:50:14 +0000 (18:50 +0200)]
psppire-output: disable the select-all menu
The copy and paste only works on a single item.
Friedrich Beckmann [Fri, 11 Sep 2020 16:33:54 +0000 (18:33 +0200)]
psppire-output-view: modified the way how copy and paste works
Copy (no Paste in output window) works now the usual gui way. You
can select an item in the output window like a table or a chart and
it will be highlighted. When you now do the copy operation via menu
or key, then the item is copied to the clipboard. With the change
the clipboard now provides the additional formats svg and various image
formats. You can now paste to inkscape, libreoffice suite and gimp.
Friedrich Beckmann [Fri, 11 Sep 2020 16:32:13 +0000 (18:32 +0200)]
cairo: added xr_draw_svg_file function
This is used by the output window to render the items for copy and paste.
Friedrich Beckmann [Tue, 8 Sep 2020 21:48:08 +0000 (23:48 +0200)]
output view: make items selectable and use system colours
The items in the output window are now selectable and the
rendering uses the gtk3 style context for background
and default foreground colours.
Ben Pfaff [Mon, 7 Sep 2020 21:25:33 +0000 (14:25 -0700)]
pspp-output: Make the binary relocatable.
Ben Pfaff [Mon, 7 Sep 2020 21:18:14 +0000 (14:18 -0700)]
HOST: Implement timeouts on Hurd.
The existing implementation didn't work and I do not know why.
Hurd isn't documented to have different behavior for signals on
execl(). The timeouts were not firing, however.
This implementation does work.
Thanks to Friedrich Beckmann for reporting the issue (via Debian
buildd).
Ben Pfaff [Mon, 7 Sep 2020 21:16:15 +0000 (14:16 -0700)]
HOST: Check for setitimer() failure.
This is unlikely but it eliminates one possible problem during
debugging.
Friedrich Beckmann [Mon, 7 Sep 2020 21:06:06 +0000 (23:06 +0200)]
fixed typo in pl.po which breaks sed on MacOS
Ben Pfaff [Mon, 7 Sep 2020 17:45:50 +0000 (10:45 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Mon, 7 Sep 2020 17:45:22 +0000 (10:45 -0700)]
po: Add comment.
Ben Pfaff [Mon, 7 Sep 2020 17:45:12 +0000 (10:45 -0700)]
po: Simplify wget command.
https://translationproject.org/html/maintainers.html shows all
kinds of recursive options, but that's for retrieving all of the
po files in one go. This makefile doesn't do that, so the
recursive options don't help and provoke warnings from wget.
Ben Pfaff [Mon, 7 Sep 2020 17:33:28 +0000 (10:33 -0700)]
po: Don't regenerate po files just before replacing them.
Ben Pfaff [Sun, 6 Sep 2020 19:20:06 +0000 (12:20 -0700)]
po: Fix placement of $(AM_V_at) in automake.mk.
It has to be at the beginning of the line because it is interpreted by
make, not by the shell.
Fixes: commit b703fcd74fda ("Fix build error when building --without-gui")
John Darrington [Sun, 6 Sep 2020 14:04:54 +0000 (16:04 +0200)]
Correct the copyright holder named in some files.
For some reason, these files named myself as the copyright holder,
instead of the FSF.
Friedrich Beckmann [Sun, 6 Sep 2020 10:43:59 +0000 (12:43 +0200)]
metainfo.its: changed this from a build requirement to a warning
When the build system is not capable to extract the strings from
org.fsf.pspp.metainfo.xml.in file, then this will not be translated.
John Darrington [Sun, 6 Sep 2020 09:49:58 +0000 (11:49 +0200)]
Fix build error when building --without-gui
Closes bug #59069.
Ben Pfaff [Sat, 5 Sep 2020 23:37:19 +0000 (16:37 -0700)]
Update version number to 1.4.2.
Ben Pfaff [Sat, 5 Sep 2020 23:15:27 +0000 (16:15 -0700)]
Release version 1.4.1.
This commit moves the version number *backward*, because we decided
that it was necessary to release 1.4.1 with all of the commits that
were currently on master.
Ben Pfaff [Sat, 5 Sep 2020 23:13:56 +0000 (16:13 -0700)]
po: Delete temporary files to fix "make distcheck" error.
Ben Pfaff [Sat, 5 Sep 2020 22:08:33 +0000 (15:08 -0700)]
Makefiles: Use $(PHONY) instead of .PHONY.
Avoids a warning from Automake in Smake:
src/ui/gui/automake.mk:463: warning: .PHONY was already defined in condition TRUE, which includes condition HAVE_GUI ...
Makefile.am:91: 'src/automake.mk' included from here
src/automake.mk:55: 'src/ui/automake.mk' included from here
src/ui/automake.mk:21: 'src/ui/gui/automake.mk' included from here
po/automake.mk:128: ... '.PHONY' previously defined here
Makefile.am:87: 'po/automake.mk' included from here
Friedrich Beckmann [Sat, 5 Sep 2020 15:24:17 +0000 (17:24 +0200)]
added appstream as a build requirement
appstream provides the metainfo.its file which is required for
xgettext to extract the translation strings of the
src/ui/gui/org.fsf.pspp.metainfo.xml.in file
The metainfo.its file is located in /usr/share/gettext/its on
debian and on opensuse. It is provided by the packages
debian: appstream
opensuse: AppStream-devel
Friedrich Beckmann [Sat, 5 Sep 2020 15:19:09 +0000 (17:19 +0200)]
po/automake.mk: changed xgettext glade language to Glade
Friedrich Beckmann [Sat, 5 Sep 2020 15:17:37 +0000 (17:17 +0200)]
Revert "po/metainfo.its: New file."
This reverts commit
e94442a3b00c1f22952586cc26b7be60617b93e1.
Friedrich Beckmann [Sat, 5 Sep 2020 15:17:07 +0000 (17:17 +0200)]
Revert "Work around bug in xgettext 0.19.8.1"
This reverts commit
df9ada336f1373c1144b7133a78c97ef5e7afdc3.
John Darrington [Sat, 5 Sep 2020 10:20:51 +0000 (12:20 +0200)]
Work around bug in xgettext 0.19.8.1
This version crashes on exit when passed a .its file. So ignore the
exit status.
John Darrington [Sat, 5 Sep 2020 03:08:12 +0000 (05:08 +0200)]
Use g_ascii_strtoll instead of strtol.
The former is locale sensitive.
John Darrington [Sat, 5 Sep 2020 03:08:12 +0000 (05:08 +0200)]
po-update rule: use wget rather than rsync
Rsync is considered insecure these days
John Darrington [Sat, 5 Sep 2020 03:08:12 +0000 (05:08 +0200)]
Remove the --enable-debug configure option.
In practice, it is faster and simpler to make local modifications
to the respective files which debugging rather than reconfiguring
with --enable-debug. Furthermore this is just another configure
option which confuses users and serves little purpose.
John Darrington [Sat, 5 Sep 2020 03:08:12 +0000 (05:08 +0200)]
Check that merged po files are well formed.
John Darrington [Sat, 5 Sep 2020 02:31:28 +0000 (04:31 +0200)]
src/ui/*/automake.mk: Conditionally include the gui automake file
John Darrington [Sat, 5 Sep 2020 02:31:28 +0000 (04:31 +0200)]
po/automake.mk: Fixed typo in variable names.
This resulted in po/pspp.pot not getting updated when it should have been.
This is a very good demonstration of the reason why carefully desigined
languages should insist on a variable being declared before it is used.
Also make the file depend on Makefile, so that it gets rebuilt when the
PACKAGE VERSION changes.
John Darrington [Sat, 5 Sep 2020 02:31:28 +0000 (04:31 +0200)]
Deal properly with EOF in the REPL, when built without readline
John Darrington [Sat, 5 Sep 2020 02:31:28 +0000 (04:31 +0200)]
utitilites/pspp-output.c: Deal properly with plural forms
Friedrich Beckmann [Wed, 2 Sep 2020 22:31:50 +0000 (00:31 +0200)]
updated german translation de.po
Ben Pfaff [Wed, 2 Sep 2020 06:17:50 +0000 (23:17 -0700)]
doc: Describe running the "rc" file at pspp startup.
Bug #54376.
Thanks to Harry Thijssen for reporting this bug.
Ben Pfaff [Wed, 2 Sep 2020 06:02:44 +0000 (23:02 -0700)]
doc/manual: Remove gitignore file in otherwise empty directory.
I added this by mistake some time ago. It's not useful.
Ben Pfaff [Wed, 2 Sep 2020 05:55:45 +0000 (22:55 -0700)]
tests: Add missing host.at tests.
Thanks to Friedrich Beckmann for reporting the problem.
Ben Pfaff [Wed, 2 Sep 2020 05:49:43 +0000 (22:49 -0700)]
encoding-guesser: Explain UTF-16, UTF-16BE, UTF-16LE distinctions.
Ben Pfaff [Wed, 2 Sep 2020 05:49:16 +0000 (22:49 -0700)]
u8-istream: Add some more tests for byte-order marks.
Ben Pfaff [Wed, 2 Sep 2020 04:42:35 +0000 (21:42 -0700)]
make-file: Pass O_BINARY or O_TEXT to open() call in replace_file_start().
It's hard to imagine why this would make a difference on a real system,
because the file descriptor obtained from open() is passed to fdopen(),
which is documented to determine whether the stream is text or binary
based on the mode string. However, bug #40223 implies that it makes a
difference. I hope that this commit fixes the problem (if any!).
Thanks to the anonymous submitter of bug #40223.
Ben Pfaff [Wed, 2 Sep 2020 04:40:46 +0000 (21:40 -0700)]
csv-file-writer: Fix typo in user message.
Ben Pfaff [Wed, 2 Sep 2020 01:54:00 +0000 (18:54 -0700)]
HOST: Reimplement and add support for TIMELIMIT subcommand.
Fixes bug #25816.
Thanks to John Darrington for reporting this bug.
Ben Pfaff [Mon, 31 Aug 2020 19:29:32 +0000 (12:29 -0700)]
tests: Add 'slow' tag to more tests.
This reduces the runtime of "make check TESTSUITEFLAGS='-k \!slow -j128'"
from 4.4 to 3.5 seconds on my computer.
Ben Pfaff [Mon, 31 Aug 2020 18:00:24 +0000 (11:00 -0700)]
spv-light-decoder: Avoid GCC 10.x warning in decode_spvlb_valign().
It seems to be wrong, but GCC can't tell and it's hard to blame it.
Ben Pfaff [Mon, 31 Aug 2020 17:29:52 +0000 (10:29 -0700)]
value: Suppress uninitialized tmp.s warning in value_resize().
This warning is wrong, but it should not cause a performance problem to
avoid it. Encountered with GCC 10.x.
Ben Pfaff [Mon, 31 Aug 2020 16:03:24 +0000 (09:03 -0700)]
Makefile.am: Suppress GCC 10.x warning in gl/careadlinkat.c.
This suppresses an error in gl/careadlinkat.c that otherwise can't be
avoided in GCC 10.x:
../../gl/careadlinkat.c: In function ‘careadlinkat’:
cc1: error: function may return address of local variable
Friedrich Beckmann [Sun, 30 Aug 2020 20:24:18 +0000 (22:24 +0200)]
GFUNC_COMPAT_CAST also for dialog-common.c
I missed that one - Thanks!
John Darrington [Sun, 30 Aug 2020 13:09:13 +0000 (15:09 +0200)]
Work around bug in Automake 1.16.1
Friedrich Beckmann [Sun, 30 Aug 2020 12:56:21 +0000 (14:56 +0200)]
moved GFunc cast to macro GFUNC_COMPAT_CAST
I moved the GFunc cast for g_list_foreach to a macro with
some explaining comment. The macro is in helper.h
Friedrich Beckmann [Sun, 30 Aug 2020 11:50:14 +0000 (13:50 +0200)]
psppire-spread-sheetmodel.c: modified userdata increment using GPOINTER_TO_INT
Friedrich Beckmann [Sun, 30 Aug 2020 11:55:39 +0000 (13:55 +0200)]
po/pl.po - replaced strange character in comment
This results in sed on MacOS to report an error.
John Darrington [Sun, 30 Aug 2020 05:43:32 +0000 (07:43 +0200)]
dummy.c: Conform to exact prototypes
Apparently certain toolchains complain if the symbols in dummy.c do not
exactly match their declarations. This should not be a problem unless
the compiler has enabled a lot of warnings, and is treating those warnings
as errors, (which is inadvisable except under very special circumstances).
However, it appears that some people are doing that.
This change ensures that they are identical.
John Darrington [Sun, 30 Aug 2020 05:48:26 +0000 (07:48 +0200)]
Prefer GTK+ style casts rather than C-style casts.
John Darrington [Sun, 30 Aug 2020 05:46:03 +0000 (07:46 +0200)]
Replace '(GObjectClass*) class' with 'G_OBJECT_CLASS(class)'
John Darrington [Sun, 30 Aug 2020 05:45:01 +0000 (07:45 +0200)]
Remove _base_init functions from custom widget definitions.
These served no purpose, and are in Gtk+ only for reasons of
legacy so far as I can make out. Also use G_TYPE_DEFINE macros
instead of explicit *_get_type function definitions.
John Darrington [Sun, 30 Aug 2020 05:43:32 +0000 (07:43 +0200)]
INSTALL: Remove reference to --with-gui-tools which no longer exists
Friedrich Beckmann [Sat, 29 Aug 2020 22:26:35 +0000 (00:26 +0200)]
switched off unused-paramter warning for lib-essential gui files
I disabled the unused-parameter warning as for the other
gui files. Same as before the introduction of the essential
library.
John Darrington [Sat, 29 Aug 2020 18:06:25 +0000 (20:06 +0200)]
src/ui/gui/automake.mk: Add missing AM_CFLAGS parameter
Friedrich Beckmann [Sat, 29 Aug 2020 16:29:06 +0000 (18:29 +0200)]
Warnings: correct cast for psppire-spread-sheet model
This fixes the compiler warning:
warning: wrong type argument to increment [-Wpointer-arith]
John Darrington [Sat, 29 Aug 2020 13:41:37 +0000 (15:41 +0200)]
Remove src/ui/gui/memorandum.txt
Almost all of the information in this file is out of date.
John Darrington [Sat, 29 Aug 2020 13:40:16 +0000 (15:40 +0200)]
Add convenience library libwidgets-essential
This avoids having to compile large numbers of modules twice.
Friedrich Beckmann [Sat, 29 Aug 2020 13:19:36 +0000 (15:19 +0200)]
xml-parser-generator - iterate over sorted dict - #58975
I sort the dict before iteration because the normal
iterator over a dict is not reproducible and will generate
different code in each run. This will work but the
build is not reproducible.
Closes: https://savannah.gnu.org/bugs/index.php?58975
John Darrington [Sat, 29 Aug 2020 06:26:23 +0000 (08:26 +0200)]
src/ui/gui/psppire-conf.c: Use GError instead of strerror.
Apparently the use of strerror was causing problems on certain
platforms. In this case, since the function being checked provides
a GError argument it makes sense to use that instead.
Closes bug #59034
Friedrich Beckmann [Tue, 25 Aug 2020 12:58:17 +0000 (14:58 +0200)]
replace finite with isfinite
finite function is deprecated on MacOS.
Friedrich Beckmann [Tue, 25 Aug 2020 08:18:42 +0000 (10:18 +0200)]
Warning: added missing initializer for closure_callback in GSourceFuncs
Friedrich Beckmann [Tue, 25 Aug 2020 07:56:57 +0000 (09:56 +0200)]
Warning: "static const" instead of "const static"
Remove warning:
‘static’ is not at beginning of declaration
Friedrich Beckmann [Tue, 25 Aug 2020 07:50:12 +0000 (09:50 +0200)]
Warning: avoid warning that weekday may be used uninitialized
Friedrich Beckmann [Tue, 25 Aug 2020 07:42:55 +0000 (09:42 +0200)]
Warning: adhere to const qualifier for initializations and assignments
This commit avoids the warnings:
warning: initialization discards ‘const’ qualifier from pointer target type
warning: assignment discards ‘const’ qualifier from pointer target type
Friedrich Beckmann [Mon, 24 Aug 2020 20:46:48 +0000 (22:46 +0200)]
Warnings: fix missing function prototypes
In most cases I added the static qualifier which was
missing. Some functions are never called so I either
removed them or I put them in #if DEBUG
Friedrich Beckmann [Mon, 24 Aug 2020 11:20:21 +0000 (13:20 +0200)]
Warnings: removed fallthrough in case statements
I guess the fallthroughs in the case statements were not intentional.
This avoids the warning:
warning: this statement may fall through