Ben Pfaff [Sun, 6 Sep 2015 19:27:46 +0000 (12:27 -0700)]
po: Update translations from translationproject.org.
John Darrington [Sun, 6 Sep 2015 08:06:02 +0000 (10:06 +0200)]
Remove some unnecessary #include directives
John Darrington [Sun, 6 Sep 2015 07:43:53 +0000 (09:43 +0200)]
Have "make distcheck" run without errors
John Darrington [Sat, 5 Sep 2015 05:56:13 +0000 (07:56 +0200)]
Splash screen: Flush display after drawing.
This avoids a few milliseconds of black which some users have reported.
John Darrington [Sun, 30 Aug 2015 15:06:15 +0000 (17:06 +0200)]
Encoding selector: fix memory leak
John Darrington [Sun, 30 Aug 2015 11:14:25 +0000 (13:14 +0200)]
PsppireEncodingSelector: Add comment
John Darrington [Sat, 29 Aug 2015 12:42:29 +0000 (14:42 +0200)]
Don't bother freeing import dialog memory. Thus avoid crashes.
A number of users have complained that the import dialog assistant
crashes on exit. This seems to be because some callback is accessing
the data after it has been freed.
This change "fixes" that by simply not ever freeing the data. This
will cause a memory leak. However during my investigations, I have
found that this dialog leaks so much anyway that these few bytes are
hardly significant.
A proper fix will hopefully be forthcoming.
Affects bug #45805
John Darrington [Tue, 25 Aug 2015 05:27:37 +0000 (07:27 +0200)]
TextImportDialog: Gtk[VH]Box --> GtkBox
John Darrington [Sat, 22 Aug 2015 02:11:40 +0000 (04:11 +0200)]
TextImportDialog: Remove unused struct definition
John Darrington [Sat, 22 Aug 2015 02:07:46 +0000 (04:07 +0200)]
TextImportDialog: GtkVPaned --> GtkPaned
John Darrington [Sat, 22 Aug 2015 01:38:09 +0000 (03:38 +0200)]
TextImportDialog: GtkTable --> GtkGrid
Ben Pfaff [Fri, 21 Aug 2015 14:14:55 +0000 (07:14 -0700)]
Pulled the latest translations from translation-project.org
John Darrington [Mon, 17 Aug 2015 17:00:53 +0000 (19:00 +0200)]
Restore the splash screen.
Re-implementat the splash screen, using functinos which are not
deprecated under Gtk3. Note: This implementation does not
use the gtk functions which the Gtk devs recommend for splash screens.
What they forget, is that a primary purpose of a splash screen is
that it should appear with the minimum of delay. gtk_init can
have significant delay - hence the recommended way of doing splash
screens in Gtk is self defeating.
John Darrington [Tue, 11 Aug 2015 10:27:21 +0000 (12:27 +0200)]
Pulled the latest translations from translation-project.org
John Darrington [Sun, 9 Aug 2015 07:52:36 +0000 (09:52 +0200)]
Remove deprecation: gtk_misc_set_alignment -> gtk_widget_set_valign
John Darrington [Sun, 2 Aug 2015 20:20:30 +0000 (22:20 +0200)]
Removed superfluous #include directive
Ben Pfaff [Sun, 2 Aug 2015 19:26:39 +0000 (12:26 -0700)]
sys-file-reader: Add PSPP version to messages that ask for files.
This may make it easier to advise users.
Suggested by Harry Thijssen <pspp4windows@gmail.com>.
John Darrington [Sat, 1 Aug 2015 02:57:02 +0000 (04:57 +0200)]
REGRESSION: Relaxed the syntax parser slightly and include /METHO=ENTER in generated syntax.
This improves comparibility between PSPP and other software.
Addresses bug #45667
Ben Pfaff [Fri, 31 Jul 2015 15:44:41 +0000 (08:44 -0700)]
T-TEST: Allow comma to be omitted in GROUPS subcommand.
Reported by Douglas Bonett and Friedrich Beckmann.
Ben Pfaff [Fri, 31 Jul 2015 15:35:04 +0000 (08:35 -0700)]
T-TEST: Allow both CIN and CI on CRITERIA.
Upon reading the bug report further, I see that it says that SPSS also
allows both forms.
Bug #45664.
Ben Pfaff [Fri, 31 Jul 2015 15:30:59 +0000 (08:30 -0700)]
T-TEST: Use correct keyword CI (instead of CIN) on CRITERIA subcommand.
Reported by Douglas Bonett <dgbonett@ucsc.edu>.
John Darrington [Tue, 28 Jul 2015 03:16:56 +0000 (05:16 +0200)]
psppire_cell_renderer_button_render: Avoid deprecation warning
John Darrington [Mon, 27 Jul 2015 15:14:54 +0000 (17:14 +0200)]
PsppireDataWindow (on_switch_page): Add comment and reformat
John Darrington [Mon, 27 Jul 2015 14:57:59 +0000 (16:57 +0200)]
PsppireDataWindow: reduce scope of incidental
variables. Add comments.
John Darrington [Sun, 26 Jul 2015 17:56:12 +0000 (19:56 +0200)]
Replace deprecated GtkHBox with GtkBox
John Darrington [Sun, 26 Jul 2015 17:43:19 +0000 (19:43 +0200)]
Data Editor: Remove the GtkHandleBox
This widget is deprecated, and I never saw the point of it anyway.
John Darrington [Sun, 26 Jul 2015 08:22:32 +0000 (10:22 +0200)]
PsppireDialogAction and subclasses - use function to set class activate and thus minimise deprecation warnings
All subclasses of PsppireDialogAction needed to use GtkActionClass. This widget however
is deprecated in recent Gtk versions. Meaning that all instances of PsppireDialogAction
implementations would provoke a deprecation warning at compile time.
This change avoids that by providing a common function to set GtkActionClass->activate.
Thus, there is now only a single warning instead of many.
Ben Pfaff [Sun, 26 Jul 2015 04:57:38 +0000 (21:57 -0700)]
system-file-format; Add a little more information gleaned from examples.
John Darrington [Sun, 26 Jul 2015 02:06:54 +0000 (04:06 +0200)]
Added notes about glade versions to src/ui/gui/memorandum.txt
Ben Pfaff [Sat, 25 Jul 2015 20:44:07 +0000 (13:44 -0700)]
sys-file-reader: Change some errors to warnings.
I encountered some system files with corrupt data in the long string
missing value record. Until now, this entirely prevented the file from
being read. This commit changes that to just a warning, enabling the file
to be read.
Also revises system file format documentation to better explain that
unknown or corrupted extension records should be ignored.
Ben Pfaff [Sat, 25 Jul 2015 19:41:44 +0000 (12:41 -0700)]
sys-file-reader: Avoid hanging forever if a system file has no variables.
Ben Pfaff [Sat, 25 Jul 2015 15:58:06 +0000 (08:58 -0700)]
dictionary: Make dict_delete_var() much faster in common case.
When a system file is opened, dict_delete_consecutive_vars() deletes lots
of variables if the system file has long string variables. This was very
slow because of the O(n**2) behavior in dict_delete_var(). The biggest
cost of that O(n**2) behavior was in calling var_clone() on every variable
several times. Fortunately, the var_clone() call is not necessary in this
case, because the cloned variable is only needed for callbacks, which
aren't set when a dictionary is being read.
This reduced the time to read the dictionary in a particular sample system
file from seconds to milliseconds.
John Darrington [Thu, 9 Jul 2015 15:46:00 +0000 (17:46 +0200)]
Fix behaviour of the REGRESSION /STATISTICS subcommand.
Ben Pfaff [Tue, 21 Jul 2015 03:43:00 +0000 (20:43 -0700)]
GET DATA/TYPE=TXT: Remove ESCAPE subcommand and make its behavior default.
Frans Houweling reported that this is the default and only behavior for
GET DATA/TYPE=TXT in SPSS 14, at:
http://lists.gnu.org/archive/html/pspp-users/2015-07/msg00027.html
Therefore, this commit makes this behavior the default and only behavior
in PSPP as well. (In my opinion it's the only sensible behavior, but SPSS
didn't document it so I assumed that it didn't do it that way.)
John Darrington [Sun, 19 Jul 2015 12:12:28 +0000 (14:12 +0200)]
PsppireValueEntry: Enable can_focus in realize callback
John Darrington [Sun, 19 Jul 2015 11:13:18 +0000 (13:13 +0200)]
PsppireDialogActionIndepSamples: Replace GtkTable with GtkGrid
John Darrington [Sun, 19 Jul 2015 10:42:01 +0000 (12:42 +0200)]
Independent Samples T-Test dialog: Replace deprected GtkVBox and GtkHBox
John Darrington [Sat, 18 Jul 2015 07:59:32 +0000 (09:59 +0200)]
GET DATA TXT: change syntax generation from /IMPORTCASES to IMPORTCASE
Apparently, spss only accepts IMPORTCASE (contrary to its documentation).
Reported by: Frans Houweling
John Darrington [Fri, 10 Jul 2015 08:38:54 +0000 (10:38 +0200)]
Linreg: Reduce scope of variables
John Darrington [Sat, 4 Jul 2015 17:28:33 +0000 (19:28 +0200)]
Avoid gtk_widget_reparent which is deprecated
John Darrington [Sat, 4 Jul 2015 17:12:02 +0000 (19:12 +0200)]
Avoid GtkArrow which is deprecated
John Darrington [Thu, 2 Jul 2015 16:45:27 +0000 (18:45 +0200)]
PsppireWindowRegister: Remove unused function
John Darrington [Mon, 29 Jun 2015 15:11:13 +0000 (17:11 +0200)]
Fix bug when searching through an empty dataset.
Closes bug #45430
John Darrington [Mon, 29 Jun 2015 15:07:48 +0000 (17:07 +0200)]
Correct bad button label
Friedrich Beckmann [Sun, 28 Jun 2015 16:42:46 +0000 (18:42 +0200)]
missing-val-dialog.c: fixed bug #45419 - added value type checks
This patch fixes bug #45419:
psppire crashes when entering missing data in new string variable.
The missing value width is now derived from the variable type. I noticed that
there are currently no type checks and no detailed warnings. I added the type
checks which were already provided by data_in and forward them to the existing
error dialog box. If an error is detected, the focus of the dialog box is
set to the field which produces the error.
John Darrington [Sun, 28 Jun 2015 14:09:36 +0000 (16:09 +0200)]
Fix non-working accelerator key
John Darrington [Sat, 27 Jun 2015 20:44:09 +0000 (22:44 +0200)]
PsppireMeansLayer: Remove useless widget
Not only did this GtkAlignment not do anything, but it is also deprecated in Gtk3
John Darrington [Sat, 27 Jun 2015 20:19:08 +0000 (22:19 +0200)]
PsppireValChooser: remove deprecated functions
John Darrington [Sat, 27 Jun 2015 19:31:49 +0000 (21:31 +0200)]
GtkTable -> GtkGrid
John Darrington [Sat, 27 Jun 2015 15:57:02 +0000 (17:57 +0200)]
Remove deprecations from help-menu.c
John Darrington [Sat, 27 Jun 2015 14:22:25 +0000 (16:22 +0200)]
OutputWindow: Convert deprecated widgets to non-deprecated ones
John Darrington [Sat, 27 Jun 2015 13:05:55 +0000 (15:05 +0200)]
Removed unreachable code section
John Darrington [Sat, 27 Jun 2015 12:38:02 +0000 (14:38 +0200)]
gtk_widget_size_request --> gtk_widget_get_preferred_size
John Darrington [Sat, 27 Jun 2015 12:10:20 +0000 (14:10 +0200)]
Replace two instances of gdk_pointer_grab with gdk_device_grab
John Darrington [Sat, 27 Jun 2015 11:28:40 +0000 (13:28 +0200)]
Revert "Replaced a few instances of gdk_window_get_pointer by gdk_device_get_position"
This reverts commit
70702237d6765a3cc276e952919211387eeee87c.
It seems to cause problems selecting areas on the sheet.
John Darrington [Sat, 27 Jun 2015 10:21:29 +0000 (12:21 +0200)]
Replaced a few instances of gdk_window_get_pointer by gdk_device_get_position
Friedrich Beckmann [Sat, 27 Jun 2015 10:05:50 +0000 (12:05 +0200)]
psppire-output-view.c: added check for view->xr - fixes bug #45421
The output windows crashed when an empty syntax window is executed. The
rerender function got called without a valid view->xr (=NULL). I added a
check for this condition and create a new view->xr as it is done in the
psppire_output_view_put function.
This fixes bug #45421: Crash when trying to run empty syntax
John Darrington [Sat, 27 Jun 2015 06:27:33 +0000 (08:27 +0200)]
Replace deprecated GTK_STOCK_ symbols with translatable strings
John Darrington [Sat, 27 Jun 2015 05:42:08 +0000 (07:42 +0200)]
Paired samples T-TEST: fix bug calculating correlation coefficient.
The value did not properly consider the weights of the data.
Thanks to Douglas Bonett <dgbonett@ucsc.edu> for reporting this.
John Darrington [Fri, 26 Jun 2015 09:59:07 +0000 (11:59 +0200)]
CROSSTABS: Fixed the reporting of the standard error of Cohen's Kappa
The Standard error assuming the null hypothesis was being reported
when the standard error NOT assuming the null hypothesis ought to
have been.
Thanks to Joanne Ingram <joanne.ingram@ed.ac.uk> for reporting this
problem, and to Douglas Bonett <dgbonett@ucsc.edu> for explaining
how to fix it.
John Darrington [Thu, 25 Jun 2015 07:08:22 +0000 (09:08 +0200)]
gdk_cursor_unref -> g_object_unref
Friedrich Beckmann [Wed, 24 Jun 2015 21:50:52 +0000 (23:50 +0200)]
fix s390x build failure on debian due to wrong type casting
The problem showed up on s390x for the 0.8.5 debian version
where four graph tests using pdf export failed with the same assertion. The
problem is due to wrong casting. intptr_t is long int (64 Bit) on s390x
but nl_langinfo returns 0xd200000000 on s390x where 0 is the integer result.
This results in wrong but positive height and width values for the paper size.
Friedrich Beckmann [Wed, 24 Jun 2015 21:47:58 +0000 (23:47 +0200)]
fix crash when exporting pdf via gui - fixes bug #45272
The problem https://savannah.gnu.org/bugs/?45272 occurs when the pdf
export is done via the gui. The problem is that tables containing only
carriage returns are considered to have no vertical space consumption.
John Darrington [Wed, 24 Jun 2015 20:06:26 +0000 (22:06 +0200)]
Select cases dialog: Change GtkTable to GtkGrid
John Darrington [Wed, 24 Jun 2015 19:03:07 +0000 (21:03 +0200)]
Replace some obsolete Gtk2 functions
John Darrington [Wed, 24 Jun 2015 17:13:28 +0000 (19:13 +0200)]
Fix typo in value chooser
John Darrington [Wed, 24 Jun 2015 16:41:12 +0000 (18:41 +0200)]
gdk_cursor_unref -> g_object_unref
Ben Pfaff [Wed, 24 Jun 2015 03:12:44 +0000 (20:12 -0700)]
FREQUENCIES: Reimplement FORMAT=LIMIT feature.
When the FREQUENCIES input parser was rewritten, this feature was
mistakenly omitted. This commit fixes the problem.
Reported by Douglas Ferguson.
John Darrington [Tue, 23 Jun 2015 06:29:29 +0000 (08:29 +0200)]
NEWS: add note to mention the transition to Gtk+3
John Darrington [Mon, 22 Jun 2015 19:33:19 +0000 (21:33 +0200)]
Data import dialog: GtkTable -> GtkGrid
John Darrington [Mon, 22 Jun 2015 18:34:49 +0000 (20:34 +0200)]
PsppireKeypad: replace GtkTable with GtkGrid
John Darrington [Mon, 22 Jun 2015 16:45:17 +0000 (18:45 +0200)]
Remove deprecated functions gtk_threads_enter and gdk_threads_leave
John Darrington [Mon, 22 Jun 2015 16:29:28 +0000 (18:29 +0200)]
Replace GtkFontSelectionDialog with GtkFontChooserDialog
John Darrington [Sun, 21 Jun 2015 19:45:24 +0000 (21:45 +0200)]
Replace GtkStock, GtkVBox and GtkHBox with their non-deprecated equivalents
Ben Pfaff [Sun, 21 Jun 2015 19:48:39 +0000 (12:48 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sun, 21 Jun 2015 19:25:49 +0000 (12:25 -0700)]
po: Update translations from translationproject.org.
John Darrington [Sun, 21 Jun 2015 18:12:57 +0000 (20:12 +0200)]
PsppireScanf and PsppireAcr: Avoid deprected API features
Ben Pfaff [Sun, 21 Jun 2015 17:07:06 +0000 (10:07 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sun, 21 Jun 2015 17:05:29 +0000 (10:05 -0700)]
configure: With -Werror, add -Wno-error=deprecated-declarations.
The PSPP code for GTK+3 still uses several deprecated interfaces, so
using -Werror without -Wno-error=deprecated-declarations prevents the tree
from compiling.
I hope that this is a temporary measure.
Ben Pfaff [Sun, 21 Jun 2015 17:01:29 +0000 (10:01 -0700)]
pspp-sheet-view: Removed unused variable.
Commit
9682fa965a7d (fixed scrolling of edited cell - fixes bug #45113)
removed all uses of local variable 'requisition' from
pspp_sheet_view_real_start_editing(), but did not remove the declaration.
This commit removes the declaration.
Fixes a warning reported by GCC 4.9.1.
Ben Pfaff [Sun, 21 Jun 2015 16:59:17 +0000 (09:59 -0700)]
pspp-sheet-view: Remove write-only variable from pspp_sheet_view_draw_bin().
Commit
9682fa965 (fixed scrolling of edited cell - fixes bug #45113)
removed the only code that uses the variable of 'has_special_cell' from
pspp_sheet_view_draw_bin(), but retained the code that set its value.
This commit removes the variable entirely.
This fixes a warning reported by GCC 4.9.1.
Ben Pfaff [Sun, 21 Jun 2015 16:33:22 +0000 (09:33 -0700)]
Merge "gtk3" branch into "master".
John Darrington [Sun, 21 Jun 2015 10:21:54 +0000 (12:21 +0200)]
Missing value dialog: Simplify error dialog.
This also avoids the use of deprecated API features.
John Darrington [Sun, 21 Jun 2015 08:43:21 +0000 (10:43 +0200)]
GRAPH: Correct spacing and punctuation of error message
John Darrington [Sun, 21 Jun 2015 06:10:46 +0000 (08:10 +0200)]
PsppireOutputView redefined parameter y to be of type long.
The variable y was defined as int, but being cast to long when set in the tree store. This seems like it
could give rise to integer overflow. This change redefines y to be of type long.
Possibly related to bug #45272
Ben Pfaff [Sat, 20 Jun 2015 23:11:41 +0000 (16:11 -0700)]
po: Update translations from translationproject.org.
John Darrington [Sat, 20 Jun 2015 19:39:59 +0000 (21:39 +0200)]
Replace deprecated functions
John Darrington [Sat, 20 Jun 2015 18:29:42 +0000 (20:29 +0200)]
Merge remote-tracking branch 'origin/master' into gtk3
Conflicts:
src/math/chart-geometry.c
src/output/cairo-chart.c
src/output/charts/plot-hist-cairo.c
tests/math/chart-geometry.at
Ben Pfaff [Sat, 20 Jun 2015 16:29:55 +0000 (09:29 -0700)]
Update version number to 0.8.5.
John Darrington [Fri, 19 Jun 2015 09:00:51 +0000 (11:00 +0200)]
Gtk3: Fix font selection of variable and dataview.
Closes bug #45337
John Darrington [Thu, 18 Jun 2015 19:18:59 +0000 (21:18 +0200)]
gtk_widget_modify_font -> gtk_widget_override_font
John Darrington [Thu, 18 Jun 2015 15:06:18 +0000 (17:06 +0200)]
Move version dependent constructs to gtk.in.h
John Darrington [Thu, 18 Jun 2015 07:06:25 +0000 (09:06 +0200)]
Chart Geometry: Fix Chart Ticks Format test
A previous commit changed the expected output, but neglected to change a
test accordingly. This change fixes that.
John Darrington [Wed, 17 Jun 2015 20:11:25 +0000 (22:11 +0200)]
Charts: internationalise representation of scientific format.
It seems that when representing real numbers in scientific
notation, there are several cultural conventions. This change
allows the translators to choose the convention best suited
to their locale.
Friedrich Beckmann [Wed, 17 Jun 2015 08:12:35 +0000 (10:12 +0200)]
charts: switched from bullet operator to multiplication sign for numbers
The previous switch to pango used the bullet operator for the display
of scientific numbers in charts. Now the numbers are displayed in the
form: 1.5x10^5 instead as 1.5.10^5.
Friedrich Beckmann [Wed, 17 Jun 2015 08:12:35 +0000 (10:12 +0200)]
charts: switched from bullet operator to multiplication sign for numbers
The previous switch to pango used the bullet operator for the display
of scientific numbers in charts. Now the numbers are displayed in the
form: 1.5x10^5 instead as 1.5.10^5.
John Darrington [Tue, 16 Jun 2015 15:51:25 +0000 (17:51 +0200)]
Correct and expand comment to barchart_create
John Darrington [Tue, 16 Jun 2015 15:32:27 +0000 (17:32 +0200)]
Remove redundant prototype from src/data/variable.h: var_get_value_name.
There was no definition corresponding to this declaration.
Ben Pfaff [Mon, 15 Jun 2015 15:22:17 +0000 (08:22 -0700)]
tests: Unset $TERM to avoid error if $TERM is set to an unknown terminal.
Reported by Friedrich Beckmann <friedrich.beckmann@gmx.de>.
See failed tests here:
https://launchpadlibrarian.net/
209052134/buildlog_ubuntu-wily-i386.pspp_0.8.4-1_BUILDING.txt.gz
Ben Pfaff [Sun, 14 Jun 2015 21:24:20 +0000 (14:24 -0700)]
plot-hist-cairo: Clip normal curve.
Otherwise a tall normal curve can go way above the intended data
rectangle to spill out even beyond the page boundary, as shown in
the PDF examples in bug #45192.