John Darrington [Fri, 30 Jul 2010 17:40:36 +0000 (19:40 +0200)]
Removed the gnulib modules which are being flagged as obsolete
Ben Pfaff [Fri, 30 Jul 2010 05:34:24 +0000 (22:34 -0700)]
AGGREGATE: Add .h file to Makefile (fixing "make distcheck").
Ben Pfaff [Fri, 30 Jul 2010 05:15:15 +0000 (22:15 -0700)]
FLIP: Convert tests to use Autotest.
Ben Pfaff [Fri, 30 Jul 2010 05:09:08 +0000 (22:09 -0700)]
make-file: Remove superfluous fflush().
Probably introduced during debugging and accidentally left in.
Ben Pfaff [Fri, 30 Jul 2010 05:08:33 +0000 (22:08 -0700)]
temp-file: New functions for creating temporary files honoring $TMPDIR.
The tmpfile() function is useful, but it doesn't necessarily honor
the $TMPDIR environment variable. Some of our users find that a problem,
so this commit replaces tmpfile() usage by a new pair of functions
create_temp_file() and close_temp_file() that do honor $TMPDIR.
Bug #30530.
Ben Pfaff [Fri, 30 Jul 2010 04:16:06 +0000 (21:16 -0700)]
temp-file: Rename "ext-array" (for "external array").
I want to introduce a new source module for general creation of temporary
files and this module's name conflicts.
John Darrington [Thu, 29 Jul 2010 16:15:59 +0000 (18:15 +0200)]
AGGREGATE: Fixed a bug with MEDIAN vs. MODE=ADDVARIABLES
John Darrington [Thu, 29 Jul 2010 14:35:56 +0000 (16:35 +0200)]
Added dialog box for the aggregate command
John Darrington [Wed, 28 Jul 2010 14:32:00 +0000 (16:32 +0200)]
AGGREGATE: New file aggregate.h containing the summary function specifications
Added a header file containing the declaration and type of the agr_func_tab
table, and expanded that type to contain a description of the function and
an explicit declaration of whether a source variable is permitted/needed.
This change is primarily for the benefit of the forthcoming dialog box for
the aggregate command. However it also (in my opinion) makes the existing
implementation a little easier to understand.
John Darrington [Mon, 26 Jul 2010 13:16:03 +0000 (15:16 +0200)]
Remove URL from translatable string
John Darrington [Mon, 26 Jul 2010 12:34:58 +0000 (14:34 +0200)]
AGGREGATE: Add MODE=ADDVARIABLES subcommand.
Instead of replacing the current dataset with the aggregated
data, this subcommand appends newvariables to the data with the
aggregated values.
Jason H Stover [Sun, 25 Jul 2010 16:34:46 +0000 (12:34 -0400)]
Fix upper bound for subscript in ordered_cols.
John Darrington [Sat, 24 Jul 2010 16:21:15 +0000 (18:21 +0200)]
Fix memory leak in crosstabs
John Darrington [Sat, 24 Jul 2010 15:54:55 +0000 (17:54 +0200)]
Fix memory leak in MRSETS
John Darrington [Sat, 24 Jul 2010 14:37:00 +0000 (16:37 +0200)]
Avoid unused function warning
John Darrington [Tue, 20 Jul 2010 07:26:47 +0000 (09:26 +0200)]
Replaced relibility.q with relibility.c
Replaced the reliability autogenerated parser
with a handcrafted one.
Jason H Stover [Tue, 20 Jul 2010 22:32:35 +0000 (18:32 -0400)]
Add argument specifying column containing dependent variable.
John Darrington [Mon, 19 Jul 2010 18:47:05 +0000 (20:47 +0200)]
Delete file "means.q"
This file contained only the skeleton of the parser.
John Darrington [Mon, 19 Jul 2010 16:47:38 +0000 (18:47 +0200)]
Remove unnecessary include directives of hash.h
John Darrington [Sun, 18 Jul 2010 17:19:53 +0000 (19:19 +0200)]
Fix memory leak in data_in
John Darrington [Fri, 16 Jul 2010 20:53:18 +0000 (22:53 +0200)]
Reliability dialog: Add checkbox for summary subcommand
John Darrington [Fri, 16 Jul 2010 20:44:10 +0000 (22:44 +0200)]
add missing source file to glade support library
John Darrington [Fri, 16 Jul 2010 14:18:07 +0000 (16:18 +0200)]
Fix memory leak
John Darrington [Fri, 16 Jul 2010 13:42:40 +0000 (15:42 +0200)]
Remove const qualifiers from encoding converter components.
These elements have to be freed. Therefore const is not
appropriate.
Jason H Stover [Thu, 15 Jul 2010 17:11:33 +0000 (13:11 -0400)]
Do not rely on user to specify all variables in VARIABLE subcommand. Fixes bug 30389.
John Darrington [Thu, 8 Jul 2010 13:24:11 +0000 (15:24 +0200)]
Replace unknown XML entities with their numerical counterpart.
Texinfo seems to produce XML entities (such as ©) which
are not valid (although they are valid for HTML). We work
around such problems by post-processing with sed. Here, we
replace these unknown entities with their numeric counterparts.
Such is the advice given at
http://www.dwheeler.com/essays/quotes-in-html.html
John Darrington [Sun, 4 Jul 2010 15:17:32 +0000 (17:17 +0200)]
Fix various memory leaks
John Darrington [Sun, 4 Jul 2010 12:50:16 +0000 (14:50 +0200)]
Fix memory leak in tab_destroy
John Darrington [Sun, 4 Jul 2010 12:49:54 +0000 (14:49 +0200)]
Fix memory leak in examine
John Darrington [Sun, 4 Jul 2010 12:17:32 +0000 (14:17 +0200)]
Fix uninitialized variable
John Darrington [Sun, 4 Jul 2010 11:16:54 +0000 (13:16 +0200)]
Fix invalid reference
Ben Pfaff [Tue, 29 Jun 2010 23:59:42 +0000 (16:59 -0700)]
cairo: Fix handling of font sizes.
Until now this code used pango_font_description_set_absolute_size() to set
the font size. This sets the font size in device units, e.g. pixels on a
display. But font sizes are actual specified by the user in points, so
we should instead use pango_font_description_get_size(). This commit
makes that change.
That change is simple, but it necessitates a larger change.
Until now the cairo driver has just assumed that the size of a font is
the size that we assigned it. But this is no longer the case, since
points and pixels are now different. So now we measure the actual width
and height of characters and use those as the font size. At the same
time, the code no longer ignores font sizes included as part of font
description strings, and allows different fonts to have different sizes.
With plenty of help from John Darrington.
Ben Pfaff [Wed, 23 Jun 2010 05:36:57 +0000 (22:36 -0700)]
cairo: Remove support for printed headers.
The printed headers on each page do not very attractive, and the
information that they contain by default is not very useful. Because an
upcoming commit makes them harder to properly implement, simply remove
them for now.
With this commit, the cairo driver no longer prints titles and subtitles
at all. This needs to be fixed.
Ben Pfaff [Sat, 26 Jun 2010 19:38:39 +0000 (12:38 -0700)]
gui: Fix spelling error in user-visible string.
Ben Pfaff [Sat, 26 Jun 2010 19:28:28 +0000 (12:28 -0700)]
output: Fix logic error in table_select_slice().
z1 is a row or column number, not a count of header rows or columns, so it
only makes sense to compare it against another row or column number, not
against a count of rows or columns.
John Darrington [Sat, 26 Jun 2010 18:04:40 +0000 (20:04 +0200)]
perl-module: Further corrections to dependencies
Ben Pfaff [Sat, 26 Jun 2010 17:19:39 +0000 (10:19 -0700)]
Revert unintended change to tests_libpspp_str_test_LDADD.
When I was preparing the previous commit I tested a change to
tests_libpspp_str_test_LDADD and then (I thought) reverted it. But my
revert actually changed the order. Oops.
John Darrington reports that the new order causes link problems for him, so
I'm putting the order back to the original, with this commit.
Ben Pfaff [Sat, 26 Jun 2010 04:33:18 +0000 (21:33 -0700)]
Avoid redundant linking against libtool convenience libraries.
Both libpspp.la and libpspp-core.la linked directly against libgl.la, and
the UI linked against both libpspp.la and libpspp-core.la. This works fine
on ELF systems, but with Mach-O on Mac OS X it silently causes duplicate
symbols at runtime. In particular there are two different copies of
rpl_optarg from libgl.la. Different code sees different copies of these,
which causes a segfault at runtime whenever anyone invokes pspp with an
option that takes an argument.
Reported by Jeremy Lavergne <jeremy@lavergne.gotdns.org>, with debugging
assistance by Jeremy and by John Darrington.
John Darrington [Wed, 23 Jun 2010 15:49:15 +0000 (17:49 +0200)]
Move compute dialog definition to its own file
John Darrington [Wed, 23 Jun 2010 15:24:57 +0000 (17:24 +0200)]
Move select cases into its own definition file
John Darrington [Wed, 23 Jun 2010 15:10:02 +0000 (17:10 +0200)]
(Re)enable select cases dialog.
The handler for this action seemed to have gone missing.
Fixing it.
John Darrington [Wed, 23 Jun 2010 14:21:06 +0000 (16:21 +0200)]
Seperate the goto-case dialog into its own definition file
John Darrington [Tue, 22 Jun 2010 12:39:56 +0000 (14:39 +0200)]
Correct makefile dependencies for perl module
Ben Pfaff [Thu, 17 Jun 2010 03:28:29 +0000 (20:28 -0700)]
README.Git: Upgrade to latest Gnulib.
In particular this incorporates commit
39bdc0a99 "strtod: Stop using
AC_FUNC_STRTOD", which should fix problems with the strtod() replacement
when cross-compiling to Mingw. For more information, see the thread at
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/22091 and PSPP bug
#29965.
John Darrington [Wed, 16 Jun 2010 14:59:16 +0000 (16:59 +0200)]
Ensure that psppire's --help and --version options work even without an X server.
Ben Pfaff [Wed, 16 Jun 2010 05:27:13 +0000 (22:27 -0700)]
lexer: Fix funny indentation.
Ben Pfaff [Wed, 16 Jun 2010 05:19:17 +0000 (22:19 -0700)]
psppire: Fix insecure temporary file creation in clipboard_get_cb().
Ben Pfaff [Wed, 16 Jun 2010 04:30:12 +0000 (21:30 -0700)]
pspp: Mark the pspp --help text as translatable.
Ben Pfaff [Wed, 16 Jun 2010 04:29:50 +0000 (21:29 -0700)]
psppire: Re-implement --help and --version options.
Commit
f51ecb4802 "Greatly simplify PSPP configuration." accidentally
removed PSPPIRE support for the --help and --version options. This commit
restores it (and improves upon the text previously displayed).
Ben Pfaff [Wed, 16 Jun 2010 03:41:12 +0000 (20:41 -0700)]
Do not treat isolated CR in input data as new-line.
User "tvw" on IRC reported that PSPP failed to parse data that SPSS 18
accepted. We found that the problem was carriage return (CR) characters
in the middle of a line. PSPP treated these as new-lines, but SPSS did
not. This commit adopts the SPSS behavior in PSPP and adjusts one test
that checks this behavior.
This will break reading some old Mac OS files, since Mac OS before version
10 used CR without LF as new-line. Time will tell whether this is a real
problem for our users.
John Darrington [Tue, 15 Jun 2010 18:31:02 +0000 (20:31 +0200)]
Remove unused functions make_temp_file and make_unique_file_stream
Ben Pfaff [Sat, 12 Jun 2010 03:40:35 +0000 (20:40 -0700)]
tests: Fix test failures in calendar and expressions tests.
Ben Pfaff [Fri, 11 Jun 2010 04:31:59 +0000 (21:31 -0700)]
tmpfile: Rename "struct tmpfile" to "struct temp_file".
Mingw builds were failing because Gnulib was replacing "tmpfile" by
"rpl_tmpfile", and this was visible only to some users of "struct tmpfile".
The safest fix seems to be just renaming struct tmpfile, so that's what
this commit does.
Thanks to Harry Thijssen <pspp@sjpaes.nl> for reporting the problem.
Bug #29965.
John Darrington [Wed, 9 Jun 2010 19:50:10 +0000 (21:50 +0200)]
Remove unnecessary translatiosn of stock items.
Stock items have their own translations, so it's counter
productive to ask pspp's translators to re-translate them
without good reason.
John Darrington [Wed, 9 Jun 2010 18:22:43 +0000 (20:22 +0200)]
perl-module/Makefile.PL: Change DLEXT to SO
Apparently the former is for dynamically loaded modules,
whereas the latter is for shared libraries. So SO is
appropriate here. Thanks to Jeremy Lavergne for reporting
this.
Ben Pfaff [Wed, 9 Jun 2010 17:26:55 +0000 (10:26 -0700)]
README.Git: Update to latest Gnulib.
The newest Gnulib fixes problems building the relocation wrapper used on
some OSes (e.g. OpenBSD) when PSPP is configured with --enable-relocatable.
Ben Pfaff [Wed, 9 Jun 2010 17:10:03 +0000 (10:10 -0700)]
configure.ac: Do not define DEPENDS_ON_LIBINTL.
If <config.h> defines DEPENDS_ON_LIBINTL, then the relocation wrapper fails
to link at install time when --enable-relocatable is used on a system that
requires the relocation wrapper (e.g. OpenBSD), because the relocation
wrapper does not link against libintl.
Ben Pfaff [Wed, 9 Jun 2010 04:36:51 +0000 (21:36 -0700)]
inexactify: #include <config.h>
This fixes a problem with redefined "struct option" under OpenBSD 4.7.
Ben Pfaff [Tue, 8 Jun 2010 05:57:26 +0000 (22:57 -0700)]
Smake: Don't create .cvsignore files.
Clearly these files aren't useful anymore, since we no longer use CVS.
Ben Pfaff [Tue, 8 Jun 2010 16:36:08 +0000 (09:36 -0700)]
gui: Fix permissions when creating configuration directory.
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html says
that the configuration directory should have mode 0700, so use that.
Reported by John Darrington.
Ben Pfaff [Tue, 8 Jun 2010 04:45:33 +0000 (21:45 -0700)]
gui: Create user settings directory if it doesn't already exist.
The user settings directory doesn't necessarily exist. Some program has to
create it, and PSPPIRE might be the first program that wants it, so it
should try to create it.
Discovered on OpenBSD.
Ben Pfaff [Tue, 8 Jun 2010 04:42:25 +0000 (21:42 -0700)]
po: Avoid passing nonportable -D option to "install" program.
OpenBSD "install" and "install-sh" distributed with Autoconf do not
support -D, so we should not try to use it.
Ben Pfaff [Sun, 6 Jun 2010 19:45:01 +0000 (12:45 -0700)]
DEBUG EVALUATE: Eliminate lexical corner case, rewrite tests in Autotest.
The DEBUG EVALUATE command, used only for testing, used the
lex_rest_of_line() function. I'd like to eventually get rid of all of the
uses of this function and other unusual lexical corner cases, so this
commit starts off by removing this one.
Ben Pfaff [Sun, 6 Jun 2010 19:23:33 +0000 (12:23 -0700)]
expressions: Improve error message for bad quarter argument to DATE.QYR.
The error message issued by DATE.QYR for an invalid "quarter" argument
referred instead to a "month" value. This makes the error message more
understandable.
Ben Pfaff [Sun, 6 Jun 2010 19:19:19 +0000 (12:19 -0700)]
expressions: Improve error messages evaluating invalid Boolean values.
The error message used for an invalid Boolean value was terribly generic.
This commit adds the name of the operator to the error message.
Ben Pfaff [Sun, 6 Jun 2010 19:14:19 +0000 (12:14 -0700)]
expressions: Don't abbreviate "number" as "num" in error messages.
Ben Pfaff [Sun, 6 Jun 2010 19:41:08 +0000 (12:41 -0700)]
expressions: Improve "type mismatch" error messages from expression parser.
Before this commit, type mismatches invoking functions in expressions would
yield confusing error messages due to missing type names, e.g.:
Type mismatch invoking MISSING(number) as missing(string).
This commit fills in the missing type names:
Type mismatch invoking MISSING(number) as missing().
An upcoming commit will start checking error messages as part of the tests
for expressions, which should ensure that the problem does not recur.
Ben Pfaff [Sun, 6 Jun 2010 19:43:10 +0000 (12:43 -0700)]
MOMENTS: Avoid lexical corner case in test case.
The DEBUG MOMENTS command, used only for testing, used the
lex_rest_of_line() function. I'd like to eventually get rid of all of the
uses of this function and other unusual lexical corner cases, so this
commit starts off by removing this one.
Ben Pfaff [Thu, 3 Jun 2010 05:02:42 +0000 (22:02 -0700)]
pspp: Add --no-output option to allow entirely disabling output.
John Darrington [Fri, 4 Jun 2010 07:15:12 +0000 (09:15 +0200)]
en_GB.po: Attended to fuzzy entries
John Darrington [Wed, 2 Jun 2010 08:32:38 +0000 (10:32 +0200)]
Fix memory leak in casewriter_make_reader.
The proto member was not being unrefed when it should have been.
Reviewed by Ben Pfaff.
Ben Pfaff [Sat, 29 May 2010 21:16:14 +0000 (14:16 -0700)]
gui: Speed up rendering of large tables that are only partly visible.
Ben Pfaff [Sat, 29 May 2010 03:35:28 +0000 (20:35 -0700)]
Remove 255-byte limit on the length of literal strings.
I don't see a reason for this restriction. I think it must date to before
support for 32767-byte string variables.
Problem reported by Dr Eberhard W Lisse <el@lisse.NA>.
John Darrington [Fri, 28 May 2010 11:49:43 +0000 (13:49 +0200)]
Fix inconsistent label positions on piecharts.
The labels of piechart slices did not match the positions
of the slices (possibly due to libplot legacy). This
change fixes this problem.
John Darrington [Thu, 27 May 2010 14:33:44 +0000 (16:33 +0200)]
Documentation: Added concept indices for various charts
John Darrington [Thu, 27 May 2010 14:29:10 +0000 (16:29 +0200)]
Added some very rudimentary tests for charts.
Currently, all these tests do is ensure that the syntax which
should generate charts, can run without crashing. More
rigourous tests should be added in the future, when the infrastructure
allows.
John Darrington [Thu, 27 May 2010 14:11:58 +0000 (16:11 +0200)]
Be more forgiving about ROC syntax
John Darrington [Thu, 27 May 2010 14:10:08 +0000 (16:10 +0200)]
Fix crash on erroneous ROC input
John Darrington [Wed, 26 May 2010 20:14:10 +0000 (22:14 +0200)]
Create the detrended np plot instead of a second normal one
John Darrington [Wed, 26 May 2010 20:02:39 +0000 (22:02 +0200)]
Removed uninitialised variable.
Removed an uninitialised variable which was being
dereferenced and hence crashing.
Ben Pfaff [Sun, 18 Oct 2009 00:12:58 +0000 (17:12 -0700)]
Fix tests/command/sample.sh test on Mingw.
On Mingw pspp.list contains CR-LF line ends, so the "grep" command to
skip blank lines needs to allow for that.
Ben Pfaff [Sun, 18 Oct 2009 00:12:19 +0000 (17:12 -0700)]
Fix tests/formats/num-out.sh test on Mingw.
inexactify needs an .exe extension on Mingw.
Ben Pfaff [Sat, 17 Oct 2009 23:57:42 +0000 (16:57 -0700)]
Fix Mingw test failures due to differences in line endings.
This commit changes "diff" invocations to ignore changes in white space to
avoid spurious test failures due to differences in line endings.
Ben Pfaff [Sat, 17 Oct 2009 23:46:21 +0000 (16:46 -0700)]
Fix get-data-txt-importcases.sh test on Mingw.
On Mingw, ftell() and ftello() are unreliable when used on text files with
plain LF line endings:
http://article.gmane.org/gmane.comp.gnu.m4.bugs/2224
This made the get-data-txt-importcases.sh test fail, because
dfm_get_percent_read() that it depends upon to determine the percentage of
the file that has been read uses ftello(). The solution is to always open
the text file as a binary file. According to my audit of the ways that
the text file is read, this should not cause other problems. In
particular, ds_read_line() handles both LF and CR-LF line endings. But it
cannot handle negative effects on Unix platforms anyway, since they do not
distinguish text and binary modes.
Ben Pfaff [Wed, 26 May 2010 05:06:57 +0000 (22:06 -0700)]
Add $EXEEXT to names of binaries executed in tests.
This makes "make check" work much better when building for Windows with
the mingw cross-compiler suite.
Ben Pfaff [Tue, 13 Oct 2009 05:10:55 +0000 (22:10 -0700)]
Move auxiliary files used for build into "build-aux" directory.
This reduces clutter in the root directory of the PSPP distribution. It
is common practice for GNU software these days.
Ben Pfaff [Wed, 26 May 2010 04:46:23 +0000 (21:46 -0700)]
perl-module: Copy perl-module files if missing as well as if changed.
I don't know why the behavior here changed, because I don't see any changes
that would cause the problem, but at least the new version makes equal
sense.
Ben Pfaff [Wed, 26 May 2010 03:42:19 +0000 (20:42 -0700)]
po: Update Dutch translation.
Thanks to the Dutch translation team and the translationproject.org
coordinators.
John Darrington [Tue, 25 May 2010 08:53:53 +0000 (10:53 +0200)]
Output viewer: Guess file type from filename suffix.
When choosing File|Export in the output viewer,
the dialog box now guesses the desired file format
based upon the given filename suffix.
Closes bug #29867
John Darrington [Mon, 24 May 2010 13:28:18 +0000 (15:28 +0200)]
Use gtk stock item instead of a custom one
John Darrington [Mon, 24 May 2010 13:19:29 +0000 (15:19 +0200)]
Fix compiler warnings
John Darrington [Mon, 24 May 2010 10:09:11 +0000 (12:09 +0200)]
Added remaining relevant unicode box characters
John Darrington [Mon, 24 May 2010 09:41:01 +0000 (11:41 +0200)]
Entered some extra unicode box chars in the table
John Darrington [Mon, 24 May 2010 08:22:20 +0000 (10:22 +0200)]
Call expand all on Edit->SelectAll
Expand the treeview widget before calling
select_all, since this is probably what the
user wants.
John Darrington [Mon, 24 May 2010 08:19:51 +0000 (10:19 +0200)]
Added an ODT target to the output viewer clipboard
John Darrington [Mon, 24 May 2010 07:50:50 +0000 (09:50 +0200)]
Added a SelectAll menuitem to the output viewer
John Darrington [Mon, 24 May 2010 07:34:00 +0000 (09:34 +0200)]
Add html target to output viewer clipboard
John Darrington [Mon, 24 May 2010 07:21:22 +0000 (09:21 +0200)]
Added basic clipboard functionality to the output viewer.
This version only allows pasting to text and utf8 targets.
John Darrington [Mon, 24 May 2010 06:19:59 +0000 (08:19 +0200)]
Replace LDFLAGS setting inadvertently removed by commit
3fac2920b97a068e156c376afd05583b481801ac
John Darrington [Sun, 23 May 2010 15:37:36 +0000 (17:37 +0200)]
Added a GTK_STOCK_INFO icon to the file information menu