John Darrington [Sat, 27 Jun 2015 05:42:08 +0000 (07:42 +0200)]
Paired samples T-TEST: fix bug calculating correlation coefficient.
The value did not properly consider the weights of the data.
Thanks to Douglas Bonett <dgbonett@ucsc.edu> for reporting this.
John Darrington [Fri, 26 Jun 2015 09:59:07 +0000 (11:59 +0200)]
CROSSTABS: Fixed the reporting of the standard error of Cohen's Kappa
The Standard error assuming the null hypothesis was being reported
when the standard error NOT assuming the null hypothesis ought to
have been.
Thanks to Joanne Ingram <joanne.ingram@ed.ac.uk> for reporting this
problem, and to Douglas Bonett <dgbonett@ucsc.edu> for explaining
how to fix it.
John Darrington [Thu, 25 Jun 2015 07:08:22 +0000 (09:08 +0200)]
gdk_cursor_unref -> g_object_unref
Friedrich Beckmann [Wed, 24 Jun 2015 21:50:52 +0000 (23:50 +0200)]
fix s390x build failure on debian due to wrong type casting
The problem showed up on s390x for the 0.8.5 debian version
where four graph tests using pdf export failed with the same assertion. The
problem is due to wrong casting. intptr_t is long int (64 Bit) on s390x
but nl_langinfo returns 0xd200000000 on s390x where 0 is the integer result.
This results in wrong but positive height and width values for the paper size.
Friedrich Beckmann [Wed, 24 Jun 2015 21:47:58 +0000 (23:47 +0200)]
fix crash when exporting pdf via gui - fixes bug #45272
The problem https://savannah.gnu.org/bugs/?45272 occurs when the pdf
export is done via the gui. The problem is that tables containing only
carriage returns are considered to have no vertical space consumption.
John Darrington [Wed, 24 Jun 2015 20:06:26 +0000 (22:06 +0200)]
Select cases dialog: Change GtkTable to GtkGrid
John Darrington [Wed, 24 Jun 2015 19:03:07 +0000 (21:03 +0200)]
Replace some obsolete Gtk2 functions
John Darrington [Wed, 24 Jun 2015 17:13:28 +0000 (19:13 +0200)]
Fix typo in value chooser
John Darrington [Wed, 24 Jun 2015 16:41:12 +0000 (18:41 +0200)]
gdk_cursor_unref -> g_object_unref
Ben Pfaff [Wed, 24 Jun 2015 03:12:44 +0000 (20:12 -0700)]
FREQUENCIES: Reimplement FORMAT=LIMIT feature.
When the FREQUENCIES input parser was rewritten, this feature was
mistakenly omitted. This commit fixes the problem.
Reported by Douglas Ferguson.
John Darrington [Tue, 23 Jun 2015 06:29:29 +0000 (08:29 +0200)]
NEWS: add note to mention the transition to Gtk+3
John Darrington [Mon, 22 Jun 2015 19:33:19 +0000 (21:33 +0200)]
Data import dialog: GtkTable -> GtkGrid
John Darrington [Mon, 22 Jun 2015 18:34:49 +0000 (20:34 +0200)]
PsppireKeypad: replace GtkTable with GtkGrid
John Darrington [Mon, 22 Jun 2015 16:45:17 +0000 (18:45 +0200)]
Remove deprecated functions gtk_threads_enter and gdk_threads_leave
John Darrington [Mon, 22 Jun 2015 16:29:28 +0000 (18:29 +0200)]
Replace GtkFontSelectionDialog with GtkFontChooserDialog
John Darrington [Sun, 21 Jun 2015 19:45:24 +0000 (21:45 +0200)]
Replace GtkStock, GtkVBox and GtkHBox with their non-deprecated equivalents
Ben Pfaff [Sun, 21 Jun 2015 19:48:39 +0000 (12:48 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sun, 21 Jun 2015 19:25:49 +0000 (12:25 -0700)]
po: Update translations from translationproject.org.
John Darrington [Sun, 21 Jun 2015 18:12:57 +0000 (20:12 +0200)]
PsppireScanf and PsppireAcr: Avoid deprected API features
Ben Pfaff [Sun, 21 Jun 2015 17:07:06 +0000 (10:07 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sun, 21 Jun 2015 17:05:29 +0000 (10:05 -0700)]
configure: With -Werror, add -Wno-error=deprecated-declarations.
The PSPP code for GTK+3 still uses several deprecated interfaces, so
using -Werror without -Wno-error=deprecated-declarations prevents the tree
from compiling.
I hope that this is a temporary measure.
Ben Pfaff [Sun, 21 Jun 2015 17:01:29 +0000 (10:01 -0700)]
pspp-sheet-view: Removed unused variable.
Commit
9682fa965a7d (fixed scrolling of edited cell - fixes bug #45113)
removed all uses of local variable 'requisition' from
pspp_sheet_view_real_start_editing(), but did not remove the declaration.
This commit removes the declaration.
Fixes a warning reported by GCC 4.9.1.
Ben Pfaff [Sun, 21 Jun 2015 16:59:17 +0000 (09:59 -0700)]
pspp-sheet-view: Remove write-only variable from pspp_sheet_view_draw_bin().
Commit
9682fa965 (fixed scrolling of edited cell - fixes bug #45113)
removed the only code that uses the variable of 'has_special_cell' from
pspp_sheet_view_draw_bin(), but retained the code that set its value.
This commit removes the variable entirely.
This fixes a warning reported by GCC 4.9.1.
Ben Pfaff [Sun, 21 Jun 2015 16:33:22 +0000 (09:33 -0700)]
Merge "gtk3" branch into "master".
John Darrington [Sun, 21 Jun 2015 10:21:54 +0000 (12:21 +0200)]
Missing value dialog: Simplify error dialog.
This also avoids the use of deprecated API features.
John Darrington [Sun, 21 Jun 2015 08:43:21 +0000 (10:43 +0200)]
GRAPH: Correct spacing and punctuation of error message
John Darrington [Sun, 21 Jun 2015 06:10:46 +0000 (08:10 +0200)]
PsppireOutputView redefined parameter y to be of type long.
The variable y was defined as int, but being cast to long when set in the tree store. This seems like it
could give rise to integer overflow. This change redefines y to be of type long.
Possibly related to bug #45272
Ben Pfaff [Sat, 20 Jun 2015 23:11:41 +0000 (16:11 -0700)]
po: Update translations from translationproject.org.
John Darrington [Sat, 20 Jun 2015 19:39:59 +0000 (21:39 +0200)]
Replace deprecated functions
John Darrington [Sat, 20 Jun 2015 18:29:42 +0000 (20:29 +0200)]
Merge remote-tracking branch 'origin/master' into gtk3
Conflicts:
src/math/chart-geometry.c
src/output/cairo-chart.c
src/output/charts/plot-hist-cairo.c
tests/math/chart-geometry.at
Ben Pfaff [Sat, 20 Jun 2015 16:29:55 +0000 (09:29 -0700)]
Update version number to 0.8.5.
John Darrington [Fri, 19 Jun 2015 09:00:51 +0000 (11:00 +0200)]
Gtk3: Fix font selection of variable and dataview.
Closes bug #45337
John Darrington [Thu, 18 Jun 2015 19:18:59 +0000 (21:18 +0200)]
gtk_widget_modify_font -> gtk_widget_override_font
John Darrington [Thu, 18 Jun 2015 15:06:18 +0000 (17:06 +0200)]
Move version dependent constructs to gtk.in.h
John Darrington [Thu, 18 Jun 2015 07:06:25 +0000 (09:06 +0200)]
Chart Geometry: Fix Chart Ticks Format test
A previous commit changed the expected output, but neglected to change a
test accordingly. This change fixes that.
John Darrington [Wed, 17 Jun 2015 20:11:25 +0000 (22:11 +0200)]
Charts: internationalise representation of scientific format.
It seems that when representing real numbers in scientific
notation, there are several cultural conventions. This change
allows the translators to choose the convention best suited
to their locale.
Friedrich Beckmann [Wed, 17 Jun 2015 08:12:35 +0000 (10:12 +0200)]
charts: switched from bullet operator to multiplication sign for numbers
The previous switch to pango used the bullet operator for the display
of scientific numbers in charts. Now the numbers are displayed in the
form: 1.5x10^5 instead as 1.5.10^5.
Friedrich Beckmann [Wed, 17 Jun 2015 08:12:35 +0000 (10:12 +0200)]
charts: switched from bullet operator to multiplication sign for numbers
The previous switch to pango used the bullet operator for the display
of scientific numbers in charts. Now the numbers are displayed in the
form: 1.5x10^5 instead as 1.5.10^5.
John Darrington [Tue, 16 Jun 2015 15:51:25 +0000 (17:51 +0200)]
Correct and expand comment to barchart_create
John Darrington [Tue, 16 Jun 2015 15:32:27 +0000 (17:32 +0200)]
Remove redundant prototype from src/data/variable.h: var_get_value_name.
There was no definition corresponding to this declaration.
Ben Pfaff [Mon, 15 Jun 2015 15:22:17 +0000 (08:22 -0700)]
tests: Unset $TERM to avoid error if $TERM is set to an unknown terminal.
Reported by Friedrich Beckmann <friedrich.beckmann@gmx.de>.
See failed tests here:
https://launchpadlibrarian.net/
209052134/buildlog_ubuntu-wily-i386.pspp_0.8.4-1_BUILDING.txt.gz
Ben Pfaff [Sun, 14 Jun 2015 21:24:20 +0000 (14:24 -0700)]
plot-hist-cairo: Clip normal curve.
Otherwise a tall normal curve can go way above the intended data
rectangle to spill out even beyond the page boundary, as shown in
the PDF examples in bug #45192.
Ben Pfaff [Sun, 14 Jun 2015 20:44:38 +0000 (13:44 -0700)]
po: Update translations from translationproject.org.
Friedrich Beckmann [Sat, 13 Jun 2015 04:55:13 +0000 (06:55 +0200)]
gtk3 - output window: migrated to style context, less rerendering
I replaced the deprecated gtk_style_get with the style_context
constructs. The rerendering is now only called after size-allocation or
style updates. The xr fonts are only updated after a style-updated
signal. The style is now derived from the view class for the GtkLayout
widget.
Friedrich Beckmann [Wed, 10 Jun 2015 19:44:17 +0000 (21:44 +0200)]
output window: click on overview item adjusts output view (jump)
On MacOS clicking on the overview item did not result in a correct
adjustment of the output window. The reason is that view->y is of type
integer but type long is stored in the treestore. This requires correct
type casting.
Friedrich Beckmann [Sun, 7 Jun 2015 21:10:07 +0000 (23:10 +0200)]
replaced decimal module, xrchart_scale with autoformat, histogram x-axis ticks changed.
During gtk3 osx debugging the decimal unit crashed. I replaced the decimal computations
with traditional tick interval computation plus a printf format string generation which is
adapted to the chosen tick style.
The xrchart scales writing are adapted to use this mechanism. If the tick text is too long
to fit in the interval, then the tick label uses the existing rotation by 45 degrees. I added
some space below the x-axis to make the tick labels visible. Maybe the tick label placement
could also be done in two rows for the even and odd ticks.
The histogram x-axis tick generation is changed from a tick per bin to the usual
normal x-axis tick generation. This allows easier visual bin border identification.
The bin width is adapted to the chosen x-axis tick scale. Any number of bins can now
be visualized. This is according to the spss examples I found for the histograms.
Conflicts:
src/output/cairo-chart.c
Friedrich Beckmann [Thu, 4 Jun 2015 05:35:00 +0000 (07:35 +0200)]
charts: changed scientifc number display from e+6 type to pango markup
Friedrich Beckmann [Wed, 10 Jun 2015 19:44:17 +0000 (21:44 +0200)]
output window: click on overview item adjusts output view (jump)
On MacOS clicking on the overview item did not result in a correct
adjustment of the output window. The reason is that view->y is of type
integer but type long is stored in the treestore. This requires correct
type casting.
Friedrich Beckmann [Wed, 10 Jun 2015 18:27:55 +0000 (20:27 +0200)]
output window: added allocation setting for drawing areas. fixes bug #45229.
I added allocation setting to the drawing areas in the output window. The
problem occured in osx gtk3 branch and is described in bug #45229. The
content of the output window was not rendered correctly in the initial
window but only after a resize. Setting the size request for the drawing
areas is not enough because the current allocation is not immediatly changed.
The clipping is based on the current allocation, while the drawing is based
on the results from the rerender function. This problem is related to
the problem described in bug #43362.
Friedrich Beckmann [Sun, 7 Jun 2015 21:10:07 +0000 (23:10 +0200)]
replaced decimal module, xrchart_scale with autoformat, histogram x-axis ticks changed.
During gtk3 osx debugging the decimal unit crashed. I replaced the decimal computations
with traditional tick interval computation plus a printf format string generation which is
adapted to the chosen tick style.
The xrchart scales writing are adapted to use this mechanism. If the tick text is too long
to fit in the interval, then the tick label uses the existing rotation by 45 degrees. I added
some space below the x-axis to make the tick labels visible. Maybe the tick label placement
could also be done in two rows for the even and odd ticks.
The histogram x-axis tick generation is changed from a tick per bin to the usual
normal x-axis tick generation. This allows easier visual bin border identification.
The bin width is adapted to the chosen x-axis tick scale. Any number of bins can now
be visualized. This is according to the spss examples I found for the histograms.
Ben Pfaff [Fri, 5 Jun 2015 03:09:24 +0000 (20:09 -0700)]
cairo-chart: Use "Sans" instead of "sans serif" as font.
This fixes a bug on Windows, where Pango doesn't have a font
named "sans serif" but does have one named "Sans".
Reported and tested by Harry Thijssen.
Friedrich Beckmann [Thu, 4 Jun 2015 05:35:00 +0000 (07:35 +0200)]
charts: changed scientifc number display from e+6 type to pango markup
John Darrington [Tue, 2 Jun 2015 08:26:06 +0000 (10:26 +0200)]
Fixed bug GRAPH /HISTOGRAM vs. null data.
Fixed a crash which occured when GRAPH /HISTOGRAM was called
on a dataset with less than 2 data.'
John Darrington [Tue, 2 Jun 2015 05:14:18 +0000 (07:14 +0200)]
Exercise the GRAPH command in the split-file test
John Darrington [Mon, 1 Jun 2015 05:03:02 +0000 (07:03 +0200)]
Added src/ui/gui/memorandum.txt to EXTRA_DIST
Friedrich Beckmann [Sun, 31 May 2015 22:20:01 +0000 (00:20 +0200)]
histogram tick drawing - added format generation for optimum tick drawing
Fixes bug #45192 which showed up in the gtk3 branch on MacOS.
It replaces the decimal_xxx computations with a routine that computes a
formatting string and a scale factor for a given axis range and number of
bins. The formatting will switch between normal and scientific depending on
the length of the displayed label text. The formatting is such that no
rounded numbers like 3.
9999999 when in fact 4 is expected is shown.
Differences between bins remain visible in the tick labels.
In addition the width of the rendered labels is compared with the width
of the bins in the display such that the labels will automatically
switch between horizontal and 45 degree display.
Friedrich Beckmann [Sun, 31 May 2015 22:20:01 +0000 (00:20 +0200)]
histogram tick drawing - added format generation for optimum tick drawing
Fixes bug #45192 which showed up in the gtk3 branch on MacOS.
It replaces the decimal_xxx computations with a routine that computes a
formatting string and a scale factor for a given axis range and number of
bins. The formatting will switch between normal and scientific depending on
the length of the displayed label text. The formatting is such that no
rounded numbers like 3.
9999999 when in fact 4 is expected is shown.
Differences between bins remain visible in the tick labels.
In addition the width of the rendered labels is compared with the width
of the bins in the display such that the labels will automatically
switch between horizontal and 45 degree display.
John Darrington [Sun, 31 May 2015 20:34:42 +0000 (22:34 +0200)]
Value Label Dialog: Do not attempt to read selection if there is none.
Fixes bug #45215.
John Darrington [Sun, 31 May 2015 20:34:42 +0000 (22:34 +0200)]
Value Label Dialog: Do not attempt to read selection if there is none.
Fixes bug #45215.
John Darrington [Sun, 31 May 2015 13:34:47 +0000 (15:34 +0200)]
New file for developers: memorandum.txt
This short text very briefly describes the steps to add a new GUI dialog to Psppire.
Ben Pfaff [Sat, 30 May 2015 23:13:30 +0000 (16:13 -0700)]
QUICK CLUSTER: Fix infinite loop on bad command name.
Reported by Alan Mead.
Friedrich Beckmann [Fri, 29 May 2015 12:32:59 +0000 (14:32 +0200)]
Smake: build from git on Mac OSX
Friedrich Beckmann [Thu, 28 May 2015 21:47:28 +0000 (23:47 +0200)]
removed references to psppire-dialog orientation property
Friedrich Beckmann [Thu, 28 May 2015 20:26:03 +0000 (22:26 +0200)]
fixed scrolling of edited cell - fixes bug #45113
Friedrich Beckmann [Fri, 22 May 2015 09:37:35 +0000 (11:37 +0200)]
scatterplot: fixed compiler warnings
Friedrich Beckmann [Sun, 24 May 2015 19:27:24 +0000 (21:27 +0200)]
fixed the scroll-to-bottom; removed the size-request signal warning
Friedrich Beckmann [Fri, 22 May 2015 07:44:19 +0000 (09:44 +0200)]
repair glade; switched to gladeui-2.0; removed the internal-child in psppire-dialog.
Friedrich Beckmann [Fri, 22 May 2015 09:37:35 +0000 (11:37 +0200)]
scatterplot: fixed compiler warnings
Friedrich Beckmann [Thu, 21 May 2015 21:46:22 +0000 (23:46 +0200)]
gtk3: replaced gtk_widget_register_window with older code depending on gtk version (pre 3.8)
Friedrich Beckmann [Thu, 21 May 2015 06:18:58 +0000 (08:18 +0200)]
gtk3 - fix to show selected cells with adwaita theme
Friedrich Beckmann [Sun, 17 May 2015 13:01:16 +0000 (15:01 +0200)]
gtk3 - adapted draw routine to gtk_cairo_should_draw_window. gtk-criticals with undefined drag window disappeared. The gtk-criticals showed up in debian 8.
John Darrington [Wed, 20 May 2015 14:29:57 +0000 (16:29 +0200)]
gtk3: Replace gdk_window_get_pointer with gdk_window_get_device_position
John Darrington [Tue, 19 May 2015 16:12:37 +0000 (18:12 +0200)]
Gtk+3: Replace deprecated gtk_layout_get_vadjustment with gtk_scrollable_get_vadjustment
John Darrington [Tue, 19 May 2015 15:09:54 +0000 (17:09 +0200)]
Gtk+3: Replace deprecated gtk_widget_size_request with gtk_widget_get_preferred_size
John Darrington [Tue, 19 May 2015 14:51:23 +0000 (16:51 +0200)]
Gtk+3: Replace deprecated gtk_cell_renderer_get_size with gtk_cell_renderer_get_preferred_width
Friedrich Beckmann [Sun, 17 May 2015 14:20:57 +0000 (16:20 +0200)]
gtk3 - added NULL check to tt_test_options_dialog_destroy - psppire crashed during exit on debian 8
Friedrich Beckmann [Sun, 17 May 2015 14:20:57 +0000 (16:20 +0200)]
gtk3 - added NULL check to tt_test_options_dialog_destroy - psppire crashed during exit on debian 8
John Darrington [Sun, 17 May 2015 06:20:04 +0000 (08:20 +0200)]
Fix GtkCritical whilst displaying last line of variable view.
Closes bug #45112
John Darrington [Sun, 17 May 2015 06:20:04 +0000 (08:20 +0200)]
Fix GtkCritical whilst displaying last line of variable view.
Closes bug #45112
John Darrington [Sat, 16 May 2015 12:25:25 +0000 (14:25 +0200)]
Fix crash when cancelling variable type dialog.
Fixes bug #45114
John Darrington [Sat, 16 May 2015 12:25:25 +0000 (14:25 +0200)]
Fix crash when cancelling variable type dialog.
Fixes bug #45114
John Darrington [Thu, 14 May 2015 17:01:24 +0000 (19:01 +0200)]
Sheet View optimisation: Do not attempt to draw sheet cells which lie outside of the exposed area.
Friedrich Beckmann [Sun, 3 May 2015 20:22:02 +0000 (22:22 +0200)]
fixed initial show of names in header window. Variable names only showed up after switching between variable and data window. The reason is that the buttons of the columns are not created. This is due to interdependency between the size allocation and the button creation. I removed the need_button mechanism.
Friedrich Beckmann [Sun, 3 May 2015 18:50:31 +0000 (20:50 +0200)]
Fixed horizontal scrolling for header window (variable names)
Friedrich Beckmann [Fri, 1 May 2015 09:04:20 +0000 (11:04 +0200)]
merge master->gtk3, fixed psppire-output-view.c refactoring; this compiles and runs but the window update is only working partly
Friedrich Beckmann [Fri, 24 Apr 2015 16:53:13 +0000 (18:53 +0200)]
Switch the order in which scatterplot axes appear in the graphic's caption.
Hulliger Beat <beat.hulliger@fhnw.ch> Reported that scatterplots were titled 'x vs. y'
where x and y were opposite to what is conventional. This change fixes that.
Friedrich Beckmann [Fri, 24 Apr 2015 16:42:57 +0000 (18:42 +0200)]
Allow data used by GRAPH /SCATTERPLOT to persist after the procedure has ended.
Fixes bug #44877
Friedrich Beckmann [Fri, 24 Apr 2015 16:21:11 +0000 (18:21 +0200)]
Whitespace changes only.
Ben Pfaff [Thu, 23 Apr 2015 01:56:16 +0000 (18:56 -0700)]
po: Update translations from translationproject.org.
John Darrington [Wed, 8 Apr 2015 08:54:35 +0000 (10:54 +0200)]
Update glib requirements to version 2.32 or later
Ben Pfaff [Thu, 26 Mar 2015 04:47:17 +0000 (21:47 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sat, 14 Mar 2015 19:38:43 +0000 (12:38 -0700)]
po: Add Chinese (simplified) translation.
Ben Pfaff [Tue, 10 Mar 2015 02:45:32 +0000 (19:45 -0700)]
help-pages-list: Distribute.
Otherwise "make distcheck" will have to regenerate it, which means
that it will have to regenerate doc/pspp.xml (because it depends on
help-pages-list) but that's not possible under "make distcheck"
because it makes the source directory read-only.
Found by PSPP autobuilder.
Ben Pfaff [Sun, 8 Mar 2015 20:41:01 +0000 (13:41 -0700)]
RELIABILITY: Ignore STATISTICS subcommand.
Statistics aren't yet implemented but it's more friendly to produce
everything we can than to fail the whole command.
Thanks to Tom Smekens for reporting the problem.
Ben Pfaff [Sun, 8 Mar 2015 20:34:10 +0000 (13:34 -0700)]
configure: Create "doc" directory in build directory.
Otherwise we get build failures from the autobuilder when the rule
in gui/automake.mk tries to create doc/help-pages-list. Problem
introduced in commit
531de52e961c (PsppireDialog: New property:
help-page).
Developers probably didn't notice this problem because they probably
already had doc/ directories in their build directories due to
building PDF versions of the documentation at one time or another, or
because they do builds in the source directory.
Found by examining autobuilder failures.
Ben Pfaff [Sun, 8 Mar 2015 20:20:26 +0000 (13:20 -0700)]
FACTOR: Support ANALYSIS subcommand.
This appears in syntax generated by SPSS.
Thanks to Tom Smekens for reporting the omission.
Ben Pfaff [Sat, 7 Mar 2015 08:36:42 +0000 (00:36 -0800)]
expressions: Add support for 2- and 3-operand RND function.
Requested by Tom Smekens.
Ben Pfaff [Sat, 7 Mar 2015 07:47:36 +0000 (23:47 -0800)]
FREQUENCIES: Accept (but ignore) ORDER subcommand.
Allows syntax generated by SPSS to work.
Reported by Tom Smekens.
Ben Pfaff [Fri, 6 Mar 2015 05:27:56 +0000 (21:27 -0800)]
RENAME VARIABLES: Make parentheses optional for single variables.
This matches SPSS documented behavior.
Reported by Tom Smekens.
Ben Pfaff [Fri, 6 Mar 2015 04:43:50 +0000 (20:43 -0800)]
psppire-dialog: Fix incompatible pointer type.