Ben Pfaff [Sat, 23 Apr 2011 19:01:35 +0000 (12:01 -0700)]
dictionary: Set encoding early when cloning a dictionary.
Many operations that involve the names of variables and other entities
in a dictionary depend on the dictionary's encoding, so it is
potentially important to have the encoding set properly when adding
other entities to the dictionary.
I did not check that this fixes an actual bug.
Ben Pfaff [Sat, 23 Apr 2011 18:59:49 +0000 (11:59 -0700)]
short-names: Consider character encoding when making short names.
Variable names and short names are always in UTF-8, but the length of
short names needs to be limited to 8 bytes in the dictionary encoding,
not in UTF-8. This commit fixes that problem.
Ben Pfaff [Sat, 23 Apr 2011 18:40:42 +0000 (11:40 -0700)]
short-names: Drop redundant call to var_set_short_name().
This function always calls var_set_short_name() twice, so we can drop
the first call.
Ben Pfaff [Sun, 24 Apr 2011 04:59:38 +0000 (21:59 -0700)]
dissect-sysfile: Don't omit the last in a series of text tokens.
Otherwise dissect-sysfile would not print the last long string
variable name written by sys-file-writer, because it did not include
a separator byte after the last record. (This was obvious running
dissect-sysfile on a system file with only one variable.)
Ben Pfaff [Sat, 23 Apr 2011 19:02:04 +0000 (12:02 -0700)]
str: Always null-terminate string in str_format_26adic().
It seems like a good idea to always supply a null terminator, even on
error.
Ben Pfaff [Tue, 26 Apr 2011 01:28:20 +0000 (18:28 -0700)]
Reformat src/language/stats/automake.mk.
It seems more consistent with most of our Makefiles to just write one
file per line.
Ben Pfaff [Sat, 23 Apr 2011 18:00:49 +0000 (11:00 -0700)]
Updated the Lithuanian translation from translationproject.org.
Ben Pfaff [Sat, 23 Apr 2011 14:54:56 +0000 (07:54 -0700)]
Smake: Add unilbrk/u8-possible-linebreaks Gnulib module.
The ASCII output driver now requires this module, as of commit
14b3603043 "ascii: Add support for multibyte characters."
Reported by John Darrington.
Ben Pfaff [Sat, 23 Apr 2011 14:53:00 +0000 (07:53 -0700)]
Add new output/ascii.h header to the distribution, fixing "make dist".
Ben Pfaff [Sat, 23 Apr 2011 05:29:19 +0000 (22:29 -0700)]
ascii: Print syntax in output single-spaced.
When SET PRINTBACK=ON was in effect, the ASCII output driver would
put a blank line between successive lines of syntax, because each line
was output separately. This commit fixes that, by causing the output
core to combine successive syntax output items into a single item that
contains multiple lines of text. This was essentially what the HTML
output driver was doing anyhow, so putting this into the core also
allows removing the corresponding logic from the HTML driver.
Ben Pfaff [Sat, 23 Apr 2011 05:10:04 +0000 (22:10 -0700)]
ascii: Don't print command names in output.
This seems to be closer to what users expect.
I think that having the command names in output was being confused
by users with SET PRINTBACK=ON (see e.g. bug #31561) even though I
really just added that so that there are clear titles for the output
that goes with each procedure. This change should help, I think.
It might make sense to make drivers only print the titles of
procedures that have other output, but this commit doesn't do that.
Ben Pfaff [Sat, 23 Apr 2011 05:07:52 +0000 (22:07 -0700)]
odt: Write command name in output both only before command, not after.
Ben Pfaff [Sat, 23 Apr 2011 03:21:57 +0000 (20:21 -0700)]
ascii: Add support for multibyte characters.
This commit modifies render.at, changing hyphens to non-breaking
hyphens. This change is only to ensure that the output for the tests
in render.at are the same afterward. Without these changes, these
tests wrap these tables differently, because they break after the
hyphens; before, only spaces were considered valid breakpoints.
Bug #31478.
Ben Pfaff [Sun, 17 Apr 2011 01:43:56 +0000 (18:43 -0700)]
ascii: Drop useless 'wrap_mode' parameter from ascii_layout_cell().
This parameter is always supplied as WRAP_WORD, so there's no point
in having it at all.
Ben Pfaff [Sun, 17 Apr 2011 23:55:09 +0000 (16:55 -0700)]
Updated the Lithuanian translation from translationproject.org.
Mindaugas [Sun, 17 Apr 2011 23:52:41 +0000 (16:52 -0700)]
gui: Add Lithuanian translation and MIME type to pspp.desktop
Ben Pfaff [Sat, 16 Apr 2011 20:40:43 +0000 (13:40 -0700)]
Updated the Lithuanian translation from translationproject.org.
Ben Pfaff [Sat, 16 Apr 2011 18:20:59 +0000 (11:20 -0700)]
gui: Fix crash in executor when inline data is missing.
Without this commit, typing "DATA LIST /x 1." into an otherwise empty
syntax window and executing it caused a crash because the lexer was
being accessed after it was destroyed. This commit averts the crash.
Ben Pfaff [Sat, 16 Apr 2011 16:52:34 +0000 (09:52 -0700)]
CROSSTABS: Fix output of multiway statistics tables.
Bug #27452.
Ben Pfaff [Sat, 16 Apr 2011 16:30:10 +0000 (09:30 -0700)]
Updated the Lithuanian translation from translationproject.org.
Ben Pfaff [Sat, 16 Apr 2011 05:49:00 +0000 (22:49 -0700)]
table-casereader: Put space between columns.
When table_casereaders are pasted together next to each other, there
should normally be a little bit of space between neighboring columns,
instead of having them directly abutting. This makes the output of
LIST, for example, much more readable.
Without this commit, LIST output for three variables named x, y, and
z, all with F1.0 format, looks something like this:
xyz
---
111
222
311
412
521
612
711
811
912
With this commit, it looks like this:
x y z
-----
1 1 1
2 2 2
3 1 1
4 1 2
5 2 1
6 1 2
7 1 1
8 1 1
9 1 2
Ben Pfaff [Sat, 16 Apr 2011 05:26:43 +0000 (22:26 -0700)]
render: Fix rendering of TAL_GAP rules.
A rule that is set to TAL_GAP is supposed to have the same width or
height as a rule of type TAL_1, but without drawing the line. That
is, it is supposed to be a small blank space between rows or columns.
Unfortunately, TAL_GAP was not implemented properly in the rendering
code. It was treated just like TAL_0, which meant that it was ignored
and no gap appeared.
This commit implements TAL_GAP, fixing the problem.
Ben Pfaff [Sat, 16 Apr 2011 03:16:02 +0000 (20:16 -0700)]
configure: Invoke AM_GNU_GETTEXT by hand.
The Gnulib "gettext" module does not invoke AM_GNU_GETTEXT, because
gnulib-tool uses "sed" to filter it out. So we must invoke it
ourselves.
John Darrington narrowed the problem down to the commit
b54a5702b6
"Fix up build following dropping ulc-width-linebreaks module" that
started using the gettext Gnulib module.
Bug #33083.
Reported by Mindaugus.
Ben Pfaff [Fri, 15 Apr 2011 04:09:00 +0000 (21:09 -0700)]
gui: Add missing scroll bar in K related samples variables list.
Reported by and fix from Mindaugas Baranauskas <embar@super.lt>.
Reviewed by John Darrington.
Ben Pfaff [Thu, 14 Apr 2011 04:24:30 +0000 (21:24 -0700)]
value-labels: Interpret \n as new-line in value labels.
Bug #18497.
Ben Pfaff [Wed, 13 Apr 2011 05:19:45 +0000 (22:19 -0700)]
intern: New function intern_strlen().
Ben Pfaff [Wed, 13 Apr 2011 03:42:47 +0000 (20:42 -0700)]
intern: Use UP_CAST macro instad of open-coding it.
Ben Pfaff [Wed, 13 Apr 2011 03:33:13 +0000 (20:33 -0700)]
po: Update Dutch translation.
Thanks to the Dutch translation team and the translationproject.org
coordinators.
Ben Pfaff [Tue, 12 Apr 2011 13:48:08 +0000 (06:48 -0700)]
value-parser: Make parse_value() accept variable's print format also.
Previously commands such as VALUE LABELS required numeric values to
be given as plain numbers, but this makes it difficult to add
meaningful value labels for variables with date and time formats.
This commit allows values for this command and a few others to be
given in a variable's print format instead.
Bug #18497.
Ben Pfaff [Tue, 12 Apr 2011 13:45:53 +0000 (06:45 -0700)]
value-labels: Fix comment.
Ben Pfaff [Tue, 12 Apr 2011 13:45:33 +0000 (06:45 -0700)]
DISPLAY: Display values for value labels using the variable's format.
Until now, the values in value labels have been displayed as plain
numbers, but this makes the values for variables with date and time
formats unreadable. Changing them to use the variable's own format
makes them easier to read.
Ben Pfaff [Tue, 12 Apr 2011 13:43:04 +0000 (06:43 -0700)]
tab: Make tab_value() take a variable instead of a dictionary.
It seems far more likely that callers will have the variable handy
than the dictionary. Also, when the variable is used the format can
be optional since tab_value() can get it from the variable's print
format.
Ben Pfaff [Tue, 12 Apr 2011 05:49:01 +0000 (22:49 -0700)]
FORMATS: Allow an optional slash before each set of variable names.
This increases compatibility.
Ben Pfaff [Tue, 12 Apr 2011 05:48:08 +0000 (22:48 -0700)]
FORMATS: Allow setting formats of string variables.
Thanks to John Darrington for reporting this bug.
Bug #22012.
Ben Pfaff [Sun, 10 Apr 2011 16:52:31 +0000 (09:52 -0700)]
gui: psppire-var-view: Change "<unset>" to null string.
Commit
0cb2b9c42 caused NULL variables to be displayed as "<unset>".
This commit changes that to the empty string, which doesn't require
translation and is equally clear.
Suggested by John Darrington <john@darrington.wattle.id.au>.
Ben Pfaff [Sun, 10 Apr 2011 02:11:44 +0000 (19:11 -0700)]
LIST: Fix crash when SPLIT FILE was used.
Thanks to John Darrington for reporting the problem and to Michel
Boaventura for reducing the problem to a simple test case.
Ben Pfaff [Sat, 9 Apr 2011 23:53:26 +0000 (16:53 -0700)]
gui: Fix crash in Paired T-Test dialog on selecting first variable.
When a variable is moved into the list of selected variables in the
Paired T-Test dialog, that row of the treeview has one nonnull
variable and one null variable. Calling var_get_name(NULL) causes a
segfault.
I'm not certain that this is the correct fix, but it fixes the
segfault. The missing variable is now shown as <unset> until a second
variable is moved into the treeview.
Bug #32958.
Ben Pfaff [Sat, 9 Apr 2011 23:50:44 +0000 (16:50 -0700)]
gui: Fix Glib warnings for dialogs in realize and configure callbacks.
The GtkBuilder documentation says:
Prior to 2.20, GtkBuilder was setting the "name" property of
constructed widgets to the "id" attribute. In GTK+ 2.20 or newer,
you have to use gtk_buildable_get_name() instead of
gtk_widget_get_name() to obtain the "id", or set the "name"
property in your UI definition.
This commit fixes the problem by switching from using the "name"
property to calling gtk_buildable_get_name().
Ben Pfaff [Sat, 9 Apr 2011 17:57:55 +0000 (10:57 -0700)]
gui: Link against $(LIBICONV) too.
The GUI now uses iconv, so we need to link libiconv too.
Problem reported by Harry Thijssen <harry.thijssen@gmail.com>.
Fix suggested by John Darrington <john@darrington.wattle.id.au>.
Ben Pfaff [Sat, 9 Apr 2011 17:55:53 +0000 (10:55 -0700)]
u8-istream: Add cast to iconv() to suppress warnings on some systems.
Problem reported by Harry Thijssen <harry.thijssen@gmail.com>.
Fix suggested by John Darrington <john@darrington.wattle.id.au>.
Ben Pfaff [Sat, 9 Apr 2011 16:25:59 +0000 (09:25 -0700)]
u8-istream: Include <limits.h> for definition of MB_LEN_MAX.
Problem reported by Harry Thijssen <pspp@sjpaes.nl>.
Fix suggested by John Darrington <john@darrington.wattle.id.au>.
Ben Pfaff [Sat, 9 Apr 2011 04:14:13 +0000 (21:14 -0700)]
segment: Fix uninitialized variable in segmenter_parse_comment_2__().
This caused a couple of test failures on Mac OS X.
Thanks to Jeremy Lavergne <jeremy@lavergne.gotdns.org> for reporting
the problem.
Ben Pfaff [Fri, 8 Apr 2011 04:49:13 +0000 (21:49 -0700)]
tests: Only check MODE=360 when EBCDIC is supported.
Jeremy Lavergne <jeremy@lavergne.gotdns.org> reported that these tests
fail on Mac OS X. testsuite.log showed that Mac OS X did not support
the EBCDIC-US encoding, so this OS cannot support these tests.
Ben Pfaff [Fri, 8 Apr 2011 04:37:37 +0000 (21:37 -0700)]
tests: Fix quoting in data-in tests.
Without [[ ]] around the test commands, m4 swallows the inner [] in
the sed argument, causing the substitution to be ineffective.
Reported by Jeremy Lavergne <jeremy@lavergne.gotdns.org>.
Ben Pfaff [Fri, 8 Apr 2011 04:05:31 +0000 (21:05 -0700)]
gui: widget-io: Fix cleanup code in widget_printf(), widget_scanf().
The 'arg' member of arguments and the 'dir' member of char_directives
are only allocated from malloc() if there are more than fit in the
arrays that are included inside their respective structures, so they
must only be freed when that internal structure is not used.
Also, these arrays are allocated with malloc() and so must be freed
with free(), not g_free().
Thanks to Benoit Flippen <anagogue@gmail.com> for reporting the
problem.
Ben Pfaff [Fri, 8 Apr 2011 03:53:18 +0000 (20:53 -0700)]
FREQUENCIES: Fix crash when median and histogram both requested.
Thanks to Benoit Flippen <anagogue@gmail.com> for reporting this bug.
Ben Pfaff [Fri, 25 Mar 2011 03:50:27 +0000 (20:50 -0700)]
Update version number to 0.7.7 to
Ben Pfaff [Wed, 23 Mar 2011 05:10:49 +0000 (22:10 -0700)]
cairo: Correctly render table during scrolling.
Commit
845d4b4f3f (cairo: Draw table titles in xr_rendering_draw()
too) started rendering table titles in the GUI but forgot to
compensate for this in the call to render_page_draw_region(), so
scrolling caused visible damage.
Bug #31569.
Reported-by: John Darrington <john@darrington.wattle.id.au>
Ben Pfaff [Wed, 23 Mar 2011 04:20:04 +0000 (21:20 -0700)]
i18n: Only close valid iconv converters in i18n_done().
iconv_open() returns (iconv_t) -1 to indicate an error. We shouldn't
pass this to iconv_Close().
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>.
John Darrington suggested that this was probably the problem, and
Jeremy confirmed it with valgrind.
Ben Pfaff [Wed, 23 Mar 2011 04:14:15 +0000 (21:14 -0700)]
i18n: Test converting between unknown encodings too.
This would have found the bug fixed by the previous commit.
Ben Pfaff [Wed, 23 Mar 2011 03:55:55 +0000 (20:55 -0700)]
str: Make ss_alloc_substring_pool() null-terminate its output.
It's inconsistent that ss_alloc_substring() null-terminates its output
but ss_alloc_substring_pool() does not. This caught us out in
recode_substring_pool(), which used ss_alloc_substring_pool() in a
fallback case where create_iconv() failed and expected the result to
be null-terminated.
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>
Ben Pfaff [Wed, 23 Mar 2011 04:12:11 +0000 (21:12 -0700)]
tests: Wrap more binaries for "check-valgrind" target.
Ben Pfaff [Tue, 22 Mar 2011 14:58:37 +0000 (07:58 -0700)]
Smake: Add 'memrchr' Gnulib module.
Thanks to John Darrington for reporting that this was needed.
Ben Pfaff [Tue, 22 Mar 2011 04:22:54 +0000 (21:22 -0700)]
Add valgrind support to testsuite.
Ben Pfaff [Mon, 21 Mar 2011 04:03:15 +0000 (21:03 -0700)]
Fix up build following dropping ulc-width-linebreaks module.
Commit
b5cebf00d5e "Smake: Remove module"
unexpectedly broke the build, because ulc-width-linebreaks had several
indirect dependencies that PSPP actually used but were not in the
list of Gnulib modules in Smake. This fixes the problem.
The oddest consequence fixed by this commit has to do with
build-aux/config.rpath. AM_GNU_GETTEXT requires this file, which is
supplied by only a few Gnulib modules: havelib, gettext, and
threadlib. ulc-width-linebreaks depended indirectly on havelib, but
PSPP did not otherwise depend on any of these modules. It seemed that
the best fix was simply to use the Gnulib gettext module, which is
what this commit does.
Ben Pfaff [Sun, 20 Mar 2011 18:39:55 +0000 (11:39 -0700)]
Change terminology from "active file" to "active dataset".
I plan to introduce the concept of multiple datasets. One of these is
active at any given time, and the others are inactive. Each one is
similar to what has been called the "active file" until now. Thus, it
is natural to rename the "active file" to the "active dataset". I
guess that this greater uniformity of terminology will cause less
user confusion.
Ben Pfaff [Sun, 20 Mar 2011 18:35:11 +0000 (11:35 -0700)]
dataset: Use similar form to dictionary code for callbacks, and document.
Ben Pfaff [Sun, 20 Mar 2011 18:25:53 +0000 (11:25 -0700)]
dataset: Rename functions with "dataset_" prefix.
Ben Pfaff [Sun, 20 Mar 2011 18:19:39 +0000 (11:19 -0700)]
Rename procedure.[ch] to dataset.[ch].
These functions deal with datasets, so it is good to name the file after
the data structure.
Ben Pfaff [Tue, 31 Aug 2010 04:45:24 +0000 (21:45 -0700)]
dataset: Remove unused types and useless struct forward declaration.
These typedefs were not used anywhere in the tree. The struct forward
declaration duplicates an identical one at the top of the header.
Ben Pfaff [Sun, 20 Mar 2011 18:09:16 +0000 (11:09 -0700)]
message: Remove reference to deleted type "struct source_stream".
Ben Pfaff [Sun, 20 Mar 2011 18:07:30 +0000 (11:07 -0700)]
NEWS: Remove Time-stamp line.
This isn't useful in conjunction with a version control system. It
just causes artificial merge conflicts.
Ben Pfaff [Sun, 20 Mar 2011 00:05:47 +0000 (17:05 -0700)]
lexer: Reimplement for better testability and internationalization.
This commit reimplements PSPP lexical analysis from the ground up.
From a PSPP user's perspective, this should make PSPP more reliable
and make it easier to work with syntax files in non-ASCII encodings.
See the changes to NEWS for more details.
From a developer's perspective, the most visible change may be that
strings within tokens are now always encoded in UTF-8, regardless of
the syntax file's encoding. Many of the changes in this commit are
due to this, especially those to functions that check for valid
identifiers: an identifier in UTF-8 is not necessarily the same length
when encoded in the dictionary's encoding, but limits on identifier
length must be enforced in the dictionary's encoding (otherwise it
might not be possible to write out a valid system file, since the
identifier might not fit in the fixed length fields in such files).
Another important change is that, whereas before some special syntax
had to be handled by the parser providing feedback to the lexer, now
increasing the sophistication of the lexer has enabled all PSPP syntax
to be analyzed into tokens. This permitted some other improvements:
- An arbitrary number of tokens of lookahead, up to the end of the
current command, is now supported using lex_next_token() and
related functions.
- Before, some command implementations had a special attribute that
meant that the top-level PSPP command parser would not consume the
final token of the command name (because that token was not
followed by tokenizable syntax). This is no longer necessary and
has been removed.
- Before, each command implementation was responsible for ensuring
that valid command syntax was not followed by trailing garbage,
often by calling lex_end_of_command() as the last step of parsing.
This is no longer necessary; the main command parser will ensure
this for itself.
Ben Pfaff [Sat, 19 Mar 2011 23:32:16 +0000 (16:32 -0700)]
scan: New library for high-level PSPP syntax lexical analysis.
This library converts a stream of segments output by the "segment"
library into PSPP tokens.
Ben Pfaff [Sat, 19 Mar 2011 23:30:55 +0000 (16:30 -0700)]
segment: New library for low-level phase of lexical syntax analysis.
This library provides for a low-level part of lexical analysis for
PSPP syntax, which I call "segmentation". Segmentation accepts a
stream of UTF-8 bytes as input. It outputs a label (a segment type)
for each byte or contiguous sequence of bytes in the input.
The following commit will implement the high-level phase of lexical
analysis, called "scanning", that converts a sequence of segments into
PSPP tokens.
Ben Pfaff [Sat, 19 Mar 2011 23:34:53 +0000 (16:34 -0700)]
u8-istream: New library for reading a text file and recoding to UTF-8.
This new library will be used in an upcoming commit.
Ben Pfaff [Sun, 20 Mar 2011 16:43:42 +0000 (09:43 -0700)]
encoding-guesser: New library to guess the encoding of a text file.
This will be used by other new libraries in upcoming commits.
Ben Pfaff [Sat, 19 Mar 2011 23:20:44 +0000 (16:20 -0700)]
i18n: New functions and data structure for obtaining encoding info.
For now these functions don't do any caching, but it might sense to
add caching later if they are called frequently.
Ben Pfaff [Sat, 19 Mar 2011 21:40:11 +0000 (14:40 -0700)]
identifier: Rename token_type_to_string() and make a new version.
Ben Pfaff [Sun, 13 Feb 2011 18:43:57 +0000 (10:43 -0800)]
i18n: New functions for truncating strings in an arbitrary encoding.
Ben Pfaff [Sun, 13 Feb 2011 00:37:10 +0000 (16:37 -0800)]
i18n: New function recode_string_len().
Ben Pfaff [Sun, 12 Dec 2010 04:58:32 +0000 (20:58 -0800)]
i18n: New function uc_name().
Ben Pfaff [Tue, 7 Dec 2010 04:50:04 +0000 (20:50 -0800)]
hash-functions: New function hash_case_bytes().
This is useful for hashing an arbitrary byte sequence case-insensitively.
Obviously most uses would be better off working with Unicode but we aren't
there yet.
Ben Pfaff [Thu, 10 Mar 2011 06:21:11 +0000 (22:21 -0800)]
str: New functions for checking for and removing string suffixes.
Ben Pfaff [Thu, 10 Mar 2011 06:10:48 +0000 (22:10 -0800)]
str: Rename ss_chomp() to ss_chomp_byte(), ds_chomp() to ds_chomp_byte().
This paves the way for new functions that chomp an entire substring.
Ben Pfaff [Tue, 7 Dec 2010 04:46:56 +0000 (20:46 -0800)]
str: New function ss_realloc().
Ben Pfaff [Tue, 7 Dec 2010 04:54:40 +0000 (20:54 -0800)]
output: New function text_item_create_nocopy().
Ben Pfaff [Sun, 6 Feb 2011 05:10:10 +0000 (21:10 -0800)]
sys-file-reader: Refactor to clean up character encoding support.
The system file format is unusual in that it does not record the encoding
used by character strings at the beginning or at any fixed place in the
file. Instead, it can be recorded practically anywhere in the file. It
never precedes all of the actual character strings in the file, which makes
it impossible to interpret those strings completely and correctly until it
is encountered.
Until now, the system file reader has dealt with this situation by
stuffing uninterpreted character strings into data structures until the
encoding is known, then at that point fetching out the character strings,
reencoding them, and stuffing them back into the data structures. This
does work, but it has the disadvantage that all of the PSPP data
structures have to tolerate character strings with unknown encoding. In
some cases this seems like an ugly situation. For example, arbitrary
variable names have to be supported, even though the syntax for variable
names is circumscribed by the language, because the syntax rules for
variable names cannot be completely and correctly applied to a string that
is in an unknown encoding.
This commit fixes that problem by adopting a new way to read system files.
Each record in the system file dictionary is essentially slurped into
memory as a chunk, then the character encoding is extracted from it, then
the rest of the dictionary is interpreted based on that encoding. The
actual implementation is a little more intricate because the format of
system file records is somewhat non-uniform.
Ben Pfaff [Thu, 17 Mar 2011 04:33:54 +0000 (21:33 -0700)]
file-name: Do not make output files line-buffered in fn_open().
I don't see any reason to do this. I can't see anything in the commit
log for this file or in OChangeLog that explains why it was done.
Ben Pfaff [Tue, 15 Mar 2011 01:19:23 +0000 (18:19 -0700)]
data-reader: Remove unreachable "return" statements.
Ben Pfaff [Sun, 5 Sep 2010 03:56:41 +0000 (20:56 -0700)]
file-handle-def: Use hmap instead of list for name table.
It makes much more sense to keep an index of names using a hash table
than using a linked list.
Ben Pfaff [Sat, 19 Mar 2011 20:48:24 +0000 (13:48 -0700)]
Update all #include directives to the currently preferred style.
I left src/ui/gui alone for now.
Ben Pfaff [Sat, 19 Mar 2011 20:57:45 +0000 (13:57 -0700)]
Smake: Remove ulc-width-linebreaks module.
This function has not been used in PSPP for a long time now.
Ben Pfaff [Sat, 12 Mar 2011 06:10:54 +0000 (22:10 -0800)]
FREQUENCIES: Fix percentiles calculation.
The condition for using a variate directly instead of interpolating was
just wrong. It would interpolate in cases where it clearly should not,
which produced incorrect results in many cases.
Thanks to Fabio Bordignon <bordignon@demos.it> for reporting the problem
and supplying a simple test case.
Ben Pfaff [Fri, 11 Mar 2011 06:53:17 +0000 (22:53 -0800)]
T-TEST: Fix use-after-free with TEMPORARY and independent samples.
When TEMPORARY is in effect, proc_commit() destroys the temporary
dictionary. This means that any procedure that does not somehow disable
temporary transformations and refers to a variable following proc_commit()
has a use-after-free error.
T-TEST has two different bugs of this type. First, the loop that destroys
group statistics refers to destroyed variables. This commit fixes this
problem by instead using variable aux data destructors to destroy group
statistics.
Second, when there is an independent variable, destroying its values
requires knowing the variable's width. This commit fixes this problem by
destroying the values before calling proc_commit().
The AUTORECODE, DESCRIPTIVES, RANK, and REGRESSION procedures appear to
have similar issues (not fixed by this commit).
Reported by Jeremy Lavergne <jeremy@lavergne.gotdns.org>.
Ben Pfaff [Fri, 11 Mar 2011 06:46:04 +0000 (22:46 -0800)]
group: Delete unused functions.
Ben Pfaff [Fri, 11 Mar 2011 06:44:50 +0000 (22:44 -0800)]
DELETE VARIABLES: Style fix.
Ben Pfaff [Fri, 25 Feb 2011 05:31:44 +0000 (21:31 -0800)]
README.Git: Update to newer commit.
This is the Gnulib commit I'm testing against locally. It should fix the
problem that showed up in the nightly build, in which the dtoastr module
was missing.
Ben Pfaff [Sun, 20 Feb 2011 01:30:39 +0000 (17:30 -0800)]
data-out: Add test for non-ASCII custom currency formats.
These now work as I would expect, so add a test to avoid future regression.
Ben Pfaff [Sat, 19 Feb 2011 20:55:54 +0000 (12:55 -0800)]
data-out: Optimize and fix some bad assumptions.
Until now, data_out_pool() and its wrapper function data_out() have always
done at least two memory allocations: one to fill in the initial version
of the result and another to recode it to UTF-8. However, recoding to
UTF-8 is usually unnecessary, because most output formats always produce
output in UTF-8 anyway. Only binary formats and the string A format ever
produce data in other encodings, so this commit drops recoding entirely
except for those cases. Binary formats are a particularly special case:
usually it doesn't make any sense to use these formats for text output,
but this commit does its best to translate the binary output bytes into
valid UTF-8, at least up to the first null byte.
This commit also finishes fixing up display widths.
The closely related data_out_legacy() function, which only has one user
in three also needed some work. It was badly named, so I renamed it to
data_out_recode(). It made the bad assumption that the data passed in
was encoded in ASCII (written C_ENCODING). It also made the bad
assumption that the number of bytes output would be exactly the format's
width. This rewrite fixes these problems.
Ben Pfaff [Sat, 19 Feb 2011 05:58:08 +0000 (21:58 -0800)]
pool: Support NULL pool argument to pool_alloc_unaligned().
I don't see a reason that this should be unsupported.
Ben Pfaff [Thu, 17 Feb 2011 05:42:13 +0000 (21:42 -0800)]
data-out: Reorganize output_Z() to be more easily understood.
It took me a minute to figure out what was going on here, so this commit
slightly reorganizes it.
Ben Pfaff [Sat, 19 Feb 2011 05:55:18 +0000 (21:55 -0800)]
format: Count prefix and suffix width in terms of display columns.
Until now, the prefixes and suffixes for custom currency formats
(CCA, etc.) have been considered to occupy one display column per
byte. This is fine for prefixes and suffixes like "$" or "%", but
falls down badly with U+00A5 (¥) or U+20AC (€), which occupy two
or three bytes, respectively, in UTF-8, while occupying only a
single display column.
This commit fixes the problem. It doesn't add a test yet because
there are still some higher-level issues, but that will come in
a later commit when those remaining issues are resolved.
Ben Pfaff [Wed, 16 Feb 2011 06:00:33 +0000 (22:00 -0800)]
format: Create a new "struct fmt_affix" for prefix and suffix strings.
This combines two changes: changing the string type for numeric
prefix and suffix strings from "struct substring" to plain "char *",
and putting the string inside a new structure. Both of these will
make more sense after the following commit, which adds another member
to the new structure and stops using the length of the string in so
many places (which is the reason that "struct substring" was a good
choice).
Ben Pfaff [Sat, 19 Feb 2011 06:30:00 +0000 (22:30 -0800)]
data-out: Make each converter responsible for storing null terminator.
Until now, every converter has produced output that is exactly as many
bytes long as the format's width. In upcoming patches this will change,
because in UTF-8 a character that occupies a single display column can
require multiple bytes. In preparation, this commit requires the
individual converters to write out their own null byte, giving a bit
more flexibility regarding length.
Ben Pfaff [Tue, 15 Feb 2011 07:17:11 +0000 (23:17 -0800)]
format: Increase abstraction of fmt_number_style.
Upcoming commits will make some changes to fmt_number_style, so it
seems best to avoid having clients actually construct and modify
instances of this structure. This commit makes that change.
We could take it one step further and add accessor functions even
for reading out the structure, but in my opinion that would be
overkill for this structure.
Ben Pfaff [Sun, 13 Feb 2011 19:23:06 +0000 (11:23 -0800)]
legacy-encoding: Remove.
The functions in this module are no longer used.
Ben Pfaff [Sun, 13 Feb 2011 19:49:30 +0000 (11:49 -0800)]
i18n: Introduce C_ENCODING as replacement for LEGACY_NATIVE.
The LEGACY_NATIVE name seems a bit awkward for something that is just the
name of the encoding for strings in C source code, that is, the C locale,
so this commit renames it to C_ENCODING and moves it to i18n.h with the
rest of the encoding-related functions.
In addition, PSPP assumes in various places that the local system has
ASCII-based locales. I don't think there's much point in pretending to
support EBCDIC, so this commit removes that little bit of support.
Ben Pfaff [Sun, 13 Feb 2011 19:36:27 +0000 (11:36 -0800)]
i18n: New function recode_byte().
Ben Pfaff [Sun, 20 Feb 2011 00:55:58 +0000 (16:55 -0800)]
PRINT: Use UTF-8 encoding for output to the output subsystem.
All string data coming into the output subsystem must be encoded in UTF-8,
but PRINT was recoding it into ASCII instead.