Ben Pfaff [Wed, 23 Mar 2011 04:12:11 +0000 (21:12 -0700)]
tests: Wrap more binaries for "check-valgrind" target.
Ben Pfaff [Tue, 22 Mar 2011 14:58:37 +0000 (07:58 -0700)]
Smake: Add 'memrchr' Gnulib module.
Thanks to John Darrington for reporting that this was needed.
Ben Pfaff [Tue, 22 Mar 2011 04:22:54 +0000 (21:22 -0700)]
Add valgrind support to testsuite.
Ben Pfaff [Mon, 21 Mar 2011 04:03:15 +0000 (21:03 -0700)]
Fix up build following dropping ulc-width-linebreaks module.
Commit
b5cebf00d5e "Smake: Remove module"
unexpectedly broke the build, because ulc-width-linebreaks had several
indirect dependencies that PSPP actually used but were not in the
list of Gnulib modules in Smake. This fixes the problem.
The oddest consequence fixed by this commit has to do with
build-aux/config.rpath. AM_GNU_GETTEXT requires this file, which is
supplied by only a few Gnulib modules: havelib, gettext, and
threadlib. ulc-width-linebreaks depended indirectly on havelib, but
PSPP did not otherwise depend on any of these modules. It seemed that
the best fix was simply to use the Gnulib gettext module, which is
what this commit does.
Ben Pfaff [Sun, 20 Mar 2011 18:39:55 +0000 (11:39 -0700)]
Change terminology from "active file" to "active dataset".
I plan to introduce the concept of multiple datasets. One of these is
active at any given time, and the others are inactive. Each one is
similar to what has been called the "active file" until now. Thus, it
is natural to rename the "active file" to the "active dataset". I
guess that this greater uniformity of terminology will cause less
user confusion.
Ben Pfaff [Sun, 20 Mar 2011 18:35:11 +0000 (11:35 -0700)]
dataset: Use similar form to dictionary code for callbacks, and document.
Ben Pfaff [Sun, 20 Mar 2011 18:25:53 +0000 (11:25 -0700)]
dataset: Rename functions with "dataset_" prefix.
Ben Pfaff [Sun, 20 Mar 2011 18:19:39 +0000 (11:19 -0700)]
Rename procedure.[ch] to dataset.[ch].
These functions deal with datasets, so it is good to name the file after
the data structure.
Ben Pfaff [Tue, 31 Aug 2010 04:45:24 +0000 (21:45 -0700)]
dataset: Remove unused types and useless struct forward declaration.
These typedefs were not used anywhere in the tree. The struct forward
declaration duplicates an identical one at the top of the header.
Ben Pfaff [Sun, 20 Mar 2011 18:09:16 +0000 (11:09 -0700)]
message: Remove reference to deleted type "struct source_stream".
Ben Pfaff [Sun, 20 Mar 2011 18:07:30 +0000 (11:07 -0700)]
NEWS: Remove Time-stamp line.
This isn't useful in conjunction with a version control system. It
just causes artificial merge conflicts.
Ben Pfaff [Sun, 20 Mar 2011 00:05:47 +0000 (17:05 -0700)]
lexer: Reimplement for better testability and internationalization.
This commit reimplements PSPP lexical analysis from the ground up.
From a PSPP user's perspective, this should make PSPP more reliable
and make it easier to work with syntax files in non-ASCII encodings.
See the changes to NEWS for more details.
From a developer's perspective, the most visible change may be that
strings within tokens are now always encoded in UTF-8, regardless of
the syntax file's encoding. Many of the changes in this commit are
due to this, especially those to functions that check for valid
identifiers: an identifier in UTF-8 is not necessarily the same length
when encoded in the dictionary's encoding, but limits on identifier
length must be enforced in the dictionary's encoding (otherwise it
might not be possible to write out a valid system file, since the
identifier might not fit in the fixed length fields in such files).
Another important change is that, whereas before some special syntax
had to be handled by the parser providing feedback to the lexer, now
increasing the sophistication of the lexer has enabled all PSPP syntax
to be analyzed into tokens. This permitted some other improvements:
- An arbitrary number of tokens of lookahead, up to the end of the
current command, is now supported using lex_next_token() and
related functions.
- Before, some command implementations had a special attribute that
meant that the top-level PSPP command parser would not consume the
final token of the command name (because that token was not
followed by tokenizable syntax). This is no longer necessary and
has been removed.
- Before, each command implementation was responsible for ensuring
that valid command syntax was not followed by trailing garbage,
often by calling lex_end_of_command() as the last step of parsing.
This is no longer necessary; the main command parser will ensure
this for itself.
Ben Pfaff [Sat, 19 Mar 2011 23:32:16 +0000 (16:32 -0700)]
scan: New library for high-level PSPP syntax lexical analysis.
This library converts a stream of segments output by the "segment"
library into PSPP tokens.
Ben Pfaff [Sat, 19 Mar 2011 23:30:55 +0000 (16:30 -0700)]
segment: New library for low-level phase of lexical syntax analysis.
This library provides for a low-level part of lexical analysis for
PSPP syntax, which I call "segmentation". Segmentation accepts a
stream of UTF-8 bytes as input. It outputs a label (a segment type)
for each byte or contiguous sequence of bytes in the input.
The following commit will implement the high-level phase of lexical
analysis, called "scanning", that converts a sequence of segments into
PSPP tokens.
Ben Pfaff [Sat, 19 Mar 2011 23:34:53 +0000 (16:34 -0700)]
u8-istream: New library for reading a text file and recoding to UTF-8.
This new library will be used in an upcoming commit.
Ben Pfaff [Sun, 20 Mar 2011 16:43:42 +0000 (09:43 -0700)]
encoding-guesser: New library to guess the encoding of a text file.
This will be used by other new libraries in upcoming commits.
Ben Pfaff [Sat, 19 Mar 2011 23:20:44 +0000 (16:20 -0700)]
i18n: New functions and data structure for obtaining encoding info.
For now these functions don't do any caching, but it might sense to
add caching later if they are called frequently.
Ben Pfaff [Sat, 19 Mar 2011 21:40:11 +0000 (14:40 -0700)]
identifier: Rename token_type_to_string() and make a new version.
Ben Pfaff [Sun, 13 Feb 2011 18:43:57 +0000 (10:43 -0800)]
i18n: New functions for truncating strings in an arbitrary encoding.
Ben Pfaff [Sun, 13 Feb 2011 00:37:10 +0000 (16:37 -0800)]
i18n: New function recode_string_len().
Ben Pfaff [Sun, 12 Dec 2010 04:58:32 +0000 (20:58 -0800)]
i18n: New function uc_name().
Ben Pfaff [Tue, 7 Dec 2010 04:50:04 +0000 (20:50 -0800)]
hash-functions: New function hash_case_bytes().
This is useful for hashing an arbitrary byte sequence case-insensitively.
Obviously most uses would be better off working with Unicode but we aren't
there yet.
Ben Pfaff [Thu, 10 Mar 2011 06:21:11 +0000 (22:21 -0800)]
str: New functions for checking for and removing string suffixes.
Ben Pfaff [Thu, 10 Mar 2011 06:10:48 +0000 (22:10 -0800)]
str: Rename ss_chomp() to ss_chomp_byte(), ds_chomp() to ds_chomp_byte().
This paves the way for new functions that chomp an entire substring.
Ben Pfaff [Tue, 7 Dec 2010 04:46:56 +0000 (20:46 -0800)]
str: New function ss_realloc().
Ben Pfaff [Tue, 7 Dec 2010 04:54:40 +0000 (20:54 -0800)]
output: New function text_item_create_nocopy().
Ben Pfaff [Sun, 6 Feb 2011 05:10:10 +0000 (21:10 -0800)]
sys-file-reader: Refactor to clean up character encoding support.
The system file format is unusual in that it does not record the encoding
used by character strings at the beginning or at any fixed place in the
file. Instead, it can be recorded practically anywhere in the file. It
never precedes all of the actual character strings in the file, which makes
it impossible to interpret those strings completely and correctly until it
is encountered.
Until now, the system file reader has dealt with this situation by
stuffing uninterpreted character strings into data structures until the
encoding is known, then at that point fetching out the character strings,
reencoding them, and stuffing them back into the data structures. This
does work, but it has the disadvantage that all of the PSPP data
structures have to tolerate character strings with unknown encoding. In
some cases this seems like an ugly situation. For example, arbitrary
variable names have to be supported, even though the syntax for variable
names is circumscribed by the language, because the syntax rules for
variable names cannot be completely and correctly applied to a string that
is in an unknown encoding.
This commit fixes that problem by adopting a new way to read system files.
Each record in the system file dictionary is essentially slurped into
memory as a chunk, then the character encoding is extracted from it, then
the rest of the dictionary is interpreted based on that encoding. The
actual implementation is a little more intricate because the format of
system file records is somewhat non-uniform.
Ben Pfaff [Thu, 17 Mar 2011 04:33:54 +0000 (21:33 -0700)]
file-name: Do not make output files line-buffered in fn_open().
I don't see any reason to do this. I can't see anything in the commit
log for this file or in OChangeLog that explains why it was done.
Ben Pfaff [Tue, 15 Mar 2011 01:19:23 +0000 (18:19 -0700)]
data-reader: Remove unreachable "return" statements.
Ben Pfaff [Sun, 5 Sep 2010 03:56:41 +0000 (20:56 -0700)]
file-handle-def: Use hmap instead of list for name table.
It makes much more sense to keep an index of names using a hash table
than using a linked list.
Ben Pfaff [Sat, 19 Mar 2011 20:48:24 +0000 (13:48 -0700)]
Update all #include directives to the currently preferred style.
I left src/ui/gui alone for now.
Ben Pfaff [Sat, 19 Mar 2011 20:57:45 +0000 (13:57 -0700)]
Smake: Remove ulc-width-linebreaks module.
This function has not been used in PSPP for a long time now.
Ben Pfaff [Sat, 12 Mar 2011 06:10:54 +0000 (22:10 -0800)]
FREQUENCIES: Fix percentiles calculation.
The condition for using a variate directly instead of interpolating was
just wrong. It would interpolate in cases where it clearly should not,
which produced incorrect results in many cases.
Thanks to Fabio Bordignon <bordignon@demos.it> for reporting the problem
and supplying a simple test case.
Ben Pfaff [Fri, 11 Mar 2011 06:53:17 +0000 (22:53 -0800)]
T-TEST: Fix use-after-free with TEMPORARY and independent samples.
When TEMPORARY is in effect, proc_commit() destroys the temporary
dictionary. This means that any procedure that does not somehow disable
temporary transformations and refers to a variable following proc_commit()
has a use-after-free error.
T-TEST has two different bugs of this type. First, the loop that destroys
group statistics refers to destroyed variables. This commit fixes this
problem by instead using variable aux data destructors to destroy group
statistics.
Second, when there is an independent variable, destroying its values
requires knowing the variable's width. This commit fixes this problem by
destroying the values before calling proc_commit().
The AUTORECODE, DESCRIPTIVES, RANK, and REGRESSION procedures appear to
have similar issues (not fixed by this commit).
Reported by Jeremy Lavergne <jeremy@lavergne.gotdns.org>.
Ben Pfaff [Fri, 11 Mar 2011 06:46:04 +0000 (22:46 -0800)]
group: Delete unused functions.
Ben Pfaff [Fri, 11 Mar 2011 06:44:50 +0000 (22:44 -0800)]
DELETE VARIABLES: Style fix.
Ben Pfaff [Fri, 25 Feb 2011 05:31:44 +0000 (21:31 -0800)]
README.Git: Update to newer commit.
This is the Gnulib commit I'm testing against locally. It should fix the
problem that showed up in the nightly build, in which the dtoastr module
was missing.
Ben Pfaff [Sun, 20 Feb 2011 01:30:39 +0000 (17:30 -0800)]
data-out: Add test for non-ASCII custom currency formats.
These now work as I would expect, so add a test to avoid future regression.
Ben Pfaff [Sat, 19 Feb 2011 20:55:54 +0000 (12:55 -0800)]
data-out: Optimize and fix some bad assumptions.
Until now, data_out_pool() and its wrapper function data_out() have always
done at least two memory allocations: one to fill in the initial version
of the result and another to recode it to UTF-8. However, recoding to
UTF-8 is usually unnecessary, because most output formats always produce
output in UTF-8 anyway. Only binary formats and the string A format ever
produce data in other encodings, so this commit drops recoding entirely
except for those cases. Binary formats are a particularly special case:
usually it doesn't make any sense to use these formats for text output,
but this commit does its best to translate the binary output bytes into
valid UTF-8, at least up to the first null byte.
This commit also finishes fixing up display widths.
The closely related data_out_legacy() function, which only has one user
in three also needed some work. It was badly named, so I renamed it to
data_out_recode(). It made the bad assumption that the data passed in
was encoded in ASCII (written C_ENCODING). It also made the bad
assumption that the number of bytes output would be exactly the format's
width. This rewrite fixes these problems.
Ben Pfaff [Sat, 19 Feb 2011 05:58:08 +0000 (21:58 -0800)]
pool: Support NULL pool argument to pool_alloc_unaligned().
I don't see a reason that this should be unsupported.
Ben Pfaff [Thu, 17 Feb 2011 05:42:13 +0000 (21:42 -0800)]
data-out: Reorganize output_Z() to be more easily understood.
It took me a minute to figure out what was going on here, so this commit
slightly reorganizes it.
Ben Pfaff [Sat, 19 Feb 2011 05:55:18 +0000 (21:55 -0800)]
format: Count prefix and suffix width in terms of display columns.
Until now, the prefixes and suffixes for custom currency formats
(CCA, etc.) have been considered to occupy one display column per
byte. This is fine for prefixes and suffixes like "$" or "%", but
falls down badly with U+00A5 (¥) or U+20AC (€), which occupy two
or three bytes, respectively, in UTF-8, while occupying only a
single display column.
This commit fixes the problem. It doesn't add a test yet because
there are still some higher-level issues, but that will come in
a later commit when those remaining issues are resolved.
Ben Pfaff [Wed, 16 Feb 2011 06:00:33 +0000 (22:00 -0800)]
format: Create a new "struct fmt_affix" for prefix and suffix strings.
This combines two changes: changing the string type for numeric
prefix and suffix strings from "struct substring" to plain "char *",
and putting the string inside a new structure. Both of these will
make more sense after the following commit, which adds another member
to the new structure and stops using the length of the string in so
many places (which is the reason that "struct substring" was a good
choice).
Ben Pfaff [Sat, 19 Feb 2011 06:30:00 +0000 (22:30 -0800)]
data-out: Make each converter responsible for storing null terminator.
Until now, every converter has produced output that is exactly as many
bytes long as the format's width. In upcoming patches this will change,
because in UTF-8 a character that occupies a single display column can
require multiple bytes. In preparation, this commit requires the
individual converters to write out their own null byte, giving a bit
more flexibility regarding length.
Ben Pfaff [Tue, 15 Feb 2011 07:17:11 +0000 (23:17 -0800)]
format: Increase abstraction of fmt_number_style.
Upcoming commits will make some changes to fmt_number_style, so it
seems best to avoid having clients actually construct and modify
instances of this structure. This commit makes that change.
We could take it one step further and add accessor functions even
for reading out the structure, but in my opinion that would be
overkill for this structure.
Ben Pfaff [Sun, 13 Feb 2011 19:23:06 +0000 (11:23 -0800)]
legacy-encoding: Remove.
The functions in this module are no longer used.
Ben Pfaff [Sun, 13 Feb 2011 19:49:30 +0000 (11:49 -0800)]
i18n: Introduce C_ENCODING as replacement for LEGACY_NATIVE.
The LEGACY_NATIVE name seems a bit awkward for something that is just the
name of the encoding for strings in C source code, that is, the C locale,
so this commit renames it to C_ENCODING and moves it to i18n.h with the
rest of the encoding-related functions.
In addition, PSPP assumes in various places that the local system has
ASCII-based locales. I don't think there's much point in pretending to
support EBCDIC, so this commit removes that little bit of support.
Ben Pfaff [Sun, 13 Feb 2011 19:36:27 +0000 (11:36 -0800)]
i18n: New function recode_byte().
Ben Pfaff [Sun, 20 Feb 2011 00:55:58 +0000 (16:55 -0800)]
PRINT: Use UTF-8 encoding for output to the output subsystem.
All string data coming into the output subsystem must be encoded in UTF-8,
but PRINT was recoding it into ASCII instead.
Ben Pfaff [Tue, 15 Feb 2011 06:04:51 +0000 (22:04 -0800)]
CROSSTABS: Eliminate redundant data copying.
There's no point in copying the output string twice.
Ben Pfaff [Mon, 14 Feb 2011 06:20:45 +0000 (22:20 -0800)]
Use new Gnulib function dtoastr() to format short, accurate real numbers.
%.*g with DBL_DIG + 1 as argument is simple but in rare cases it fails to
accurately format a real number. The recently added Gnulib routine
dtoastr() always formats a real number accurately, so switch to using it
for these cases.
Ben Pfaff [Sun, 13 Feb 2011 19:20:35 +0000 (11:20 -0800)]
operations.def: Fix indentation.
Ben Pfaff [Sat, 12 Feb 2011 16:02:48 +0000 (08:02 -0800)]
PRINT SPACE: When an output file is specified, don't ignore expression.
When both OUTFILE= and an expression were specified on PRINT SPACE, the
expression was ignored (if it was only a single token) or an error would
occur (if it was was more than one token).
Ben Pfaff [Sun, 6 Feb 2011 21:39:38 +0000 (13:39 -0800)]
GET DATA: Get rid of lex_put_back().
An upcoming commit will get rid of lex_put_back(), so don't use it here.
Ben Pfaff [Sun, 12 Dec 2010 22:00:28 +0000 (14:00 -0800)]
float-format: Eliminate tests' dependence on exact string encoding.
Until now, the float-format tests have depended on the PSPP syntax
accepting arbitrary byte values in strings, without treating them as part
of any particular encoding. The lexer is being rewritten so that this
assumption is no longer true, so this commit eliminates this assumption in
the float-format tests. After this commit, the tests only use ASCII
characters in strings.
Ben Pfaff [Sun, 2 Jan 2011 00:42:06 +0000 (16:42 -0800)]
por-file-reader: Remove dependency on VAR_NAME_LEN.
VAR_NAME_LEN wasn't really needed here because we knew that the name we
started from was no more than 8 bytes long. Also, we know that we can
come up with a unique name within ULONG_MAX tries since we'd run out of
memory before running out of values to try.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sun, 2 Jan 2011 00:30:42 +0000 (16:30 -0800)]
text-data-import-dialog: Eliminate VAR_NAME_LEN restriction.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sun, 2 Jan 2011 00:26:25 +0000 (16:26 -0800)]
REGRESSION: Eliminate restriction to VAR_NAME_LEN in reg_get_name().
There's still an obvious problem here that the prefix isn't being trimmed
down so that the suffix will fit. Since an upcoming series of changes
would have to completely redo how this would be done, I'm not fixing that
now, only marking it with XXX.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sun, 2 Jan 2011 00:16:30 +0000 (16:16 -0800)]
FLIP: Eliminate false dependency on VAR_NAME_LEN.
The size of this buffer really shouldn't have anything to do with
VAR_NAME_LEN but with the string about to be put into it.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sun, 2 Jan 2011 00:08:03 +0000 (16:08 -0800)]
DESCRIPTIVES: Eliminate main restriction on Z-score variable name length.
Ben Pfaff [Sat, 1 Jan 2011 23:54:54 +0000 (15:54 -0800)]
variable-parser: Drop VAR_NAME_LEN restriction from var_set_lookup_var_idx().
This restriction is purely artificial, as part of an assertion. Since
longer variable names are going to have to be supported, remove it.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 21:00:49 +0000 (13:00 -0800)]
variable-parser: Rewrite parse_DATA_LIST_vars().
This rewrite was prompted by getting rid of the VAR_NAME_LEN limit inside
parse_DATA_LIST_vars(), but then I noticed that the variable naming and
coding style was dated, and that duplicate variable names were only
detected for variables named using TO, not for individual names, so I
rewrote much of the code instead.
Ben Pfaff [Sat, 1 Jan 2011 19:15:33 +0000 (11:15 -0800)]
DEBUG EVALUATE: Eliminate VAR_NAME_LEN limit.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 19:11:07 +0000 (11:11 -0800)]
VECTOR: Eliminate VAR_NAME_LEN limit for variable names.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 19:09:01 +0000 (11:09 -0800)]
MODIFY VARIABLES: Eliminate VAR_NAME_LEN limit on variable names.
This is actually a general code improvement, since it eliminates memory
allocation and copying that was not actually necessary.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 19:05:14 +0000 (11:05 -0800)]
DATAFILE ATTRIBUTE, VARIABLE ATTRIBUTE: Eliminate VAR_NAME_LEN limit.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 18:59:03 +0000 (10:59 -0800)]
GET DATA /TYPE=TXT: Get rid of VAR_NAME_LEN limit on variable names.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 18:56:55 +0000 (10:56 -0800)]
FILE HANDLE: Get rid of VAR_NAME_LEN limit on handle name.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 18:52:14 +0000 (10:52 -0800)]
combine-files: Eliminate VAR_NAME_LEN restriction from combine_files().
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 18:47:56 +0000 (10:47 -0800)]
vector: Remove VAR_NAME_LEN limit for internal representation of name.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 18:45:11 +0000 (10:45 -0800)]
variable: Remove VAR_NAME_LEN limit for internal representation of name.
Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8. The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
Ben Pfaff [Sat, 1 Jan 2011 18:39:07 +0000 (10:39 -0800)]
dict: Make dict_make_unique_var_name() return an allocated string.
Ben Pfaff [Sun, 12 Dec 2010 22:29:00 +0000 (14:29 -0800)]
tests: Add `check-programs' target.
Occasionally I want to build all the programs required to run "make check"
without actually running the tests. This target allows me to do that.
Ben Pfaff [Mon, 27 Dec 2010 05:12:06 +0000 (21:12 -0800)]
Smake: Avoid duplicating $(GNULIB_TOOL) invocation.
The "all" and "gnulib" rules both contained the same gnulib-tool
invocation. This commit changes the "all" rule to use the "gnulib" rule
as a subrule.
Ben Pfaff [Sat, 5 Feb 2011 05:33:47 +0000 (21:33 -0800)]
i18n: Always allocate from pool in recode_substring_pool().
Ben Pfaff [Wed, 5 Jan 2011 05:55:07 +0000 (21:55 -0800)]
sys-file-writer: Fix subtype used for v14+ multiple response set records.
Ben Pfaff [Mon, 3 Jan 2011 21:10:07 +0000 (13:10 -0800)]
doc: Document that type-7 records must appear in ascending numerical order.
Every system file that I have seen puts them in this order, so I cannot
imagine that any other order receives any testing.
Ben Pfaff [Sat, 5 Feb 2011 21:18:07 +0000 (13:18 -0800)]
doc: Update description of character encoding information in system files.
Based on information provided by John Darrington and on system files
obtained freely from the Internet.
Ben Pfaff [Fri, 4 Feb 2011 04:41:40 +0000 (20:41 -0800)]
sys-file-reader: Add tests.
Ben Pfaff [Sun, 30 Jan 2011 23:41:12 +0000 (15:41 -0800)]
sys-file-reader: Elevate invalid number of labels from warning to error.
There's no way to figure out when the labels end when the count is wrong,
so this has to be an error.
Ben Pfaff [Sun, 30 Jan 2011 23:27:06 +0000 (15:27 -0800)]
sys-file-reader: Avoid redundant "within system file" in messages.
All system file message already state the system file's name, which should
be enough identification.
Ben Pfaff [Sun, 30 Jan 2011 23:42:51 +0000 (15:42 -0800)]
sys-file-reader: Improve debugging usefulness of error messages.
I found that these changes made it easier to debug problems with system
files while I was developing tests.
Ben Pfaff [Sun, 30 Jan 2011 23:40:17 +0000 (15:40 -0800)]
sys-file-reader: Really enable warnings for invalid variable formats.
With these operator in the wrong order, I never saw any warnings, although
other people might have seen different behavior.
Ben Pfaff [Sun, 30 Jan 2011 23:29:38 +0000 (15:29 -0800)]
sys-file-reader: Add missing periods at end of error messages.
Most of the error messages already ended in periods, so this adds them to
the others for consistency.
Ben Pfaff [Sun, 30 Jan 2011 23:35:48 +0000 (15:35 -0800)]
sys-file-reader: Check that multiple response set names begin with `$'.
This invariant was being checked by an assertion in dict_add_mrset(), so
this change avoids an assertion failure for invalid system files.
Ben Pfaff [Sun, 30 Jan 2011 23:33:30 +0000 (15:33 -0800)]
sys-file-reader: Fix double-free on read of partial record.
partial_record() does a longjmp() to code near the top of
sys_file_casereader_read() that unrefs the case, but this code at the
end of sys_file_casereader_read() would have already unref'ed it once in
that case, resulting in a double-free.
Ben Pfaff [Mon, 31 Jan 2011 04:34:32 +0000 (20:34 -0800)]
hash-functions: Use C instead of preprocessor to test size of double.
I don't see a reason that this has to be done as an #if directive. The
compiler should be easily able to optimize out the branch that will never
be taken. This allows us to get rid of a configure check, so it seems
worthwhile to me.
Ben Pfaff [Sat, 29 Jan 2011 18:02:32 +0000 (10:02 -0800)]
q2c: T_RPAREN should be T_LPAREN for matching a left parenthesis.
Also add a test for this case on the T-TEST command, where the bug was
first reported.
Bug #32061.
Reported by Mindaugas <embar@super.lt>.
Reported by Chuck Kralowec <chuck.kralowec@gmail.com>.
Ben Pfaff [Wed, 5 Jan 2011 17:18:27 +0000 (09:18 -0800)]
Updated the Lithuanian translation from translationproject.org.
Ben Pfaff [Sun, 2 Jan 2011 16:37:31 +0000 (08:37 -0800)]
README: Describe meaning of copyright year ranges.
This is required by the GNU maintainers guide as a prerequisite for using
copyright year ranges. So far, PSPP itself doesn't use ranges, but Gnulib
(which PSPP uses) does.
Ben Pfaff [Sat, 1 Jan 2011 21:42:04 +0000 (13:42 -0800)]
expressions: Fix test failures due to new year.
Some of the date-related test cases assumed that year 41 would be
interpreted as 1941, but due to the 30-year century window, as soon as it
became 2011 this assumption failed. Write these years explicitly as 1941
instead to fix the problem.
Ben Pfaff [Tue, 21 Dec 2010 08:12:09 +0000 (00:12 -0800)]
NPAR TESTS: Fix two test failures.
Tests "NPAR TESTS CHISQUARE with DESCRIPTIVES" and "NPAR TESTS CHISQUARE,
listwise missing" were failing because of some unexpected behavior of
lex_put_back(). This fixes the problem by avoiding lex_put_back()
entirely.
Ben Pfaff [Tue, 21 Dec 2010 08:00:25 +0000 (00:00 -0800)]
NPAR TESTS: Fix "NPAR TESTS BINOMIAL, P = 0.5; N1/N2 < 1" test failure.
Ben Pfaff [Tue, 21 Dec 2010 07:59:28 +0000 (23:59 -0800)]
lexer: Fix GCC warning for unhandled TOKEN_N_TYPES in lex_token_name().
Ben Pfaff [Tue, 21 Dec 2010 07:58:59 +0000 (23:58 -0800)]
lexer: Remove unused function lex_put_back_id().
Ben Pfaff [Fri, 10 Dec 2010 05:41:49 +0000 (21:41 -0800)]
value-parser: Remove redundant call to lex_force_string() in parse_value().
Ben Pfaff [Sun, 12 Dec 2010 04:56:15 +0000 (20:56 -0800)]
GET DATA: Fix punctuation in error message.
Ben Pfaff [Fri, 10 Dec 2010 05:55:58 +0000 (21:55 -0800)]
AGGREGATE: Align arg_func_tab[] in columns.
This makes the code more readable. It should not change PSPP behavior.
Ben Pfaff [Tue, 7 Dec 2010 04:54:15 +0000 (20:54 -0800)]
i18n: Remove unnecessary #ifs.
The test for LC_MESSAGES should not be necessary because Gnulib ensures
that LC_MESSAGES is always defined.
The test for ENABLE_NLS should not be necessary because PSPP has not
supported that configuration for some time.
Ben Pfaff [Tue, 7 Dec 2010 04:48:32 +0000 (20:48 -0800)]
ECHO: Use text_item, as intended.
TEXT_ITEM_ECHO is meant for use by ECHO but it had been overlooked
accidentally until now.