John Darrington [Mon, 23 Feb 2009 22:07:32 +0000 (07:07 +0900)]
fix warnings
John Darrington [Mon, 23 Feb 2009 21:57:42 +0000 (06:57 +0900)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
John Darrington [Mon, 23 Feb 2009 21:55:53 +0000 (06:55 +0900)]
Remove remaining GladeXML references from psppire-data-window.c
Jason H Stover [Mon, 23 Feb 2009 16:48:34 +0000 (11:48 -0500)]
Oops
Jason H Stover [Mon, 23 Feb 2009 16:23:30 +0000 (11:23 -0500)]
linreg.c: (pspp_linreg_mse) New accessor function
regression.q: (reg_stats_r) Report root MSE instead of std. error of
R-squared. Fixes bug 25677.
John Darrington [Mon, 23 Feb 2009 12:08:29 +0000 (21:08 +0900)]
Removed most uses of GladeXML from data window
John Darrington [Mon, 23 Feb 2009 04:29:17 +0000 (13:29 +0900)]
Set the filename on loading a new file
John Darrington [Mon, 23 Feb 2009 03:09:13 +0000 (12:09 +0900)]
Refactor code from psppire.c
Instead of using custom code for loading files given
on the command line, instead use code from psppire-data-window.c
John Darrington [Mon, 23 Feb 2009 02:35:32 +0000 (11:35 +0900)]
Unsaved indicator for data files.
Add callback to dictionary and dataset. Use these callbacks
to set a flag for the gui to indicate when a data file is
saved or not saved.
John Darrington [Sun, 22 Feb 2009 23:43:23 +0000 (08:43 +0900)]
Add a set_unsaved method.
Added a psppire_window_set_unsaved method, which can be
used to indicate that the contents of a window has been
modified since it was last saved.
Use this method for the syntax window.
John Darrington [Sun, 22 Feb 2009 22:27:48 +0000 (07:27 +0900)]
Reorder sources list
Try to keep them alphabetical.
John Darrington [Sun, 22 Feb 2009 05:32:33 +0000 (14:32 +0900)]
Merge commit 'window-manager/master'
John Darrington [Sun, 22 Feb 2009 05:30:11 +0000 (14:30 +0900)]
Fix problems with make distcheck
John Darrington [Sun, 22 Feb 2009 02:38:12 +0000 (11:38 +0900)]
Fix signature of connect_help
John Darrington [Sun, 22 Feb 2009 02:28:16 +0000 (11:28 +0900)]
Replace "usage" property with a "description" property
John Darrington [Sat, 21 Feb 2009 04:04:05 +0000 (13:04 +0900)]
Re enable the connect_help function
John Darrington [Sat, 21 Feb 2009 02:24:58 +0000 (11:24 +0900)]
convert labels and missing values dialogs to GtkBuilder
John Darrington [Sat, 21 Feb 2009 01:54:51 +0000 (10:54 +0900)]
Set more appropriate default names for Syntax and Output windows.
Syntax windows now default to "Syntax" and output windows to "Output".
John Darrington [Sat, 21 Feb 2009 00:32:24 +0000 (09:32 +0900)]
Converted output-viewer.glade to GtkBuilder
Jason H Stover [Fri, 20 Feb 2009 21:20:24 +0000 (16:20 -0500)]
covariance-matrix.c (covariance_matrix_init): pass pointer to
result->n_variables instead of stack variable n_variables.
covariance-matrix.c (covariance_hsh_create): Accept pointer to number
of variables instead of size_t.
John Darrington [Fri, 20 Feb 2009 05:28:16 +0000 (14:28 +0900)]
Converted syntax-editor definition from libglade to gtkbuilder
John Darrington [Fri, 20 Feb 2009 01:26:17 +0000 (10:26 +0900)]
Merge branch 'master' of /home/john/Development/pspp-window-manager
Conflicts:
src/ui/gui/crosstabs-dialog.c
src/ui/gui/helper.c
John Darrington [Fri, 20 Feb 2009 01:22:49 +0000 (10:22 +0900)]
Merge commit 'HEAD'; commit 'savannah/master'
Conflicts:
src/ui/gui/crosstabs-dialog.c
src/ui/gui/goto-case-dialog.c
src/ui/gui/helper.c
src/ui/gui/output-viewer.c
src/ui/gui/output-viewer.h
src/ui/gui/psppire.c
src/ui/gui/regression-dialog.c
John Darrington [Tue, 10 Feb 2009 00:55:58 +0000 (09:55 +0900)]
Use the sum of weights of only those cases which are valid to
calculate percentiles.
Fixes bug #25522
Jason H Stover [Mon, 9 Feb 2009 16:27:00 +0000 (11:27 -0500)]
Skip the SAVE subcommand if no valid data are present, instead of crashing.
Fix for bug 25523
John Darrington [Sun, 8 Feb 2009 10:22:05 +0000 (19:22 +0900)]
Use c-ctype functions in lexer.
Lexical analysis should not depend upon the locale,
so change is* functions from ctype.h to the c_is*
counterparts from gnulib. This should avoid potential
i18n issues.
John Darrington [Sun, 8 Feb 2009 08:50:25 +0000 (17:50 +0900)]
Prevent test failure when non-English language selected
John Darrington [Sun, 8 Feb 2009 06:33:48 +0000 (15:33 +0900)]
Added a brief description of the --enable-relocatable flag to INSTALL
John Darrington [Sat, 7 Feb 2009 07:41:08 +0000 (16:41 +0900)]
Added LIB_CLOSE to link flags for test programs.
This allows all binaries needed by "make check" to be built.
John Darrington [Sat, 7 Feb 2009 07:32:03 +0000 (16:32 +0900)]
Add LIB_CLOSE to link command for dissect-sysfile program.
Ben Pfaff [Sat, 7 Feb 2009 05:49:44 +0000 (21:49 -0800)]
Link against -lws2_32 on Windows.
Gnulib commit
df1da811, "Fix link errors on Windows when close
module is used", adds a Makefile variable $(LIB_CLOSE) that expands
to -lws2_32. This commit adds that variable to the linker command
line.
It might not be necessary to add this to both pspp and psppire,
but it shouldn't hurt.
John Darrington [Fri, 6 Feb 2009 09:55:54 +0000 (18:55 +0900)]
Fix minor build issues.
Remove dependence on lib/misc which no longer exists.
Add new file src/math/wilcoxon-sig.[ch] to makefile.
Ben Pfaff [Fri, 6 Feb 2009 06:28:15 +0000 (22:28 -0800)]
wilcoxon: Drop now-unnecessary timer support.
Calculating the Wilcoxon significance level now takes only a
fraction of a second, so there is no need to support a timer.
Also, report the problem if the significance level cannot be
calculated.
Ben Pfaff [Fri, 6 Feb 2009 05:25:55 +0000 (21:25 -0800)]
Speed up Wilcoxon matched-pairs signed-ranks significance routine.
The performance of this routine was O(2**N). This improves it to
O(N*W). For N=30, W=120 this reduces calculation time from 6m9s
to .002s, which is a 123000x speedup.
Refer to bug #25466 for more information.
Ben Pfaff [Fri, 6 Feb 2009 04:34:27 +0000 (20:34 -0800)]
perl-module: fix version mismatch between module and PSPP
The version number update in the previous Perl module commit
broke the Perl module's version number checking. Oops. This fixes
it (and updates NEWS).
Ben Pfaff [Mon, 2 Feb 2009 03:06:52 +0000 (19:06 -0800)]
perl-module: Document and test PSPP::Dict::get_var_cnt().
This function was present but not documented or tested.
Ben Pfaff [Fri, 6 Feb 2009 03:36:18 +0000 (19:36 -0800)]
perl-module: Make PSPP::Reader::get_next_case() return a list.
PSPP::Reader::get_next_case() was documented to return a list,
but actually it returned a reference to a list. This commit
changes the behavior to match the documentation.
This also fixes the behavior on reading past the end of the file.
Previously this was documented to return undef but caused a
segfault in practice. Now it returns an empty list.
Also increase PSPP version number from 0.7.1 to 0.7.2 at John
Darrington's request, to alert users of the previous version of
the Perl interface.
John Darrington [Wed, 4 Feb 2009 05:33:54 +0000 (14:33 +0900)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
John Darrington [Wed, 4 Feb 2009 05:29:53 +0000 (14:29 +0900)]
Don't build the perl module if cross compiling.
Whilst, in general, it should be possible to cross compile a perl
module, the current organisation of the module doesn't support it.
So this has been disabled until somebody has the time and resources
to fix and test it.
Ben Pfaff [Mon, 2 Feb 2009 04:21:52 +0000 (20:21 -0800)]
INSTALL: Add hints about how to obtain root permission.
Suggested by Nick Thompson <nickadamthompson@gmail.com>.
Ben Pfaff [Mon, 2 Feb 2009 00:30:01 +0000 (16:30 -0800)]
perl-module: Document PSPP::Dict::get_var() for too-large index.
Approved by John Darrington.
Ben Pfaff [Sat, 31 Jan 2009 05:03:34 +0000 (21:03 -0800)]
Accept LF, CR LF, and LF as new-line sequences in data files.
Until now, PSPP has used the host operating system's idea of the
new-line sequence when reading data files and other text files.
This means that, when a file with CR LF line ends is read on an OS
that uses LF as new-line (e.g. an MS-DOS file on Unix), each line
appears to have a CR at the the end. This commit fixes the
problem, by normalizing the new-line sequence at time of reading.
This commit eliminates a performance optimization from
ds_read_line(), because the getdelim() function that it used cannot
be made to stop reading at one of two different delimiters. If
this causes a real performance regression, then the getndelim2
function from gnulib could be used to restore the optimization.
Also adds a test to make sure that it works.
Thanks to RĂ©mi Dewitte <remi@gide.net> for pointing out the problem
and providing an initial patch (which solved the problem in a
completely different way from this commit).
John Darrington [Thu, 29 Jan 2009 23:25:28 +0000 (08:25 +0900)]
Updated NEWS
John Darrington [Thu, 29 Jan 2009 23:23:29 +0000 (08:23 +0900)]
Correct the directory of the perl module tarball target
John Darrington [Thu, 29 Jan 2009 23:01:28 +0000 (08:01 +0900)]
Bump minor version number
John Darrington [Thu, 29 Jan 2009 22:37:37 +0000 (07:37 +0900)]
Merge branch 'savannah/perl-module'
Conflicts:
po/en_GB.po
src/libpspp/automake.mk
Jason H Stover [Wed, 28 Jan 2009 21:29:38 +0000 (16:29 -0500)]
interaction.c: Introduced interaction_variable and interaction_value
structs and associated functions.
covariance-matrix.c: Altered covariance_accumulate_listwise,
covariance_accumulate_pairwise, and update_* functions to handle
interactions.
glm.q: Added temporary NULL and 0 as final args to call to
covariance_matrix_accumulate.
John Darrington [Tue, 27 Jan 2009 06:51:23 +0000 (15:51 +0900)]
Remove pspp-vers.pl which did more harm than good.
Removed the auto-generated file pspp-vers.pl and all references
to it. Instead, use a manually set string for the version.
John Darrington [Fri, 23 Jan 2009 09:36:52 +0000 (18:36 +0900)]
Change COPYING from GPLv2 to GPLv3
John Darrington [Tue, 20 Jan 2009 22:57:58 +0000 (07:57 +0900)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
John Darrington [Tue, 20 Jan 2009 22:54:56 +0000 (07:54 +0900)]
Fix further bug in NPAR BINOMIAL
Change "break" to "continue", so that if a binomial
variable was missing, only this single variable is skipped
rather than all subsequent ones. Thanks to Ben Pfaff for
reporting this.
Jason H Stover [Mon, 19 Jan 2009 20:20:17 +0000 (15:20 -0500)]
Fixed bug in compare_values_short. Reported by Ben Pfaff.
John Darrington [Mon, 19 Jan 2009 07:50:54 +0000 (16:50 +0900)]
Fixed bug allocating the memory in NPAR BINOMIAL
Thanks to Ben Pfaff for reporting this problem.
John Darrington [Sat, 17 Jan 2009 02:47:25 +0000 (11:47 +0900)]
Merge commit 'origin/stable'
Conflicts:
src/language/utilities/include.c
src/ui/terminal/automake.mk
tests/command/insert.sh
Ben Pfaff [Wed, 14 Jan 2009 04:41:54 +0000 (20:41 -0800)]
Put unique dictionary indexes into internal variables
Code that Jason is working on creates some internal variables, using
var_create_internal(), and wants to hash those variables based
on their dictionary indexes, along with some other variables that
are actually in a dictionary. Thus, the internal variables need to
have unique dictionary indexes.
Jason H Stover [Mon, 12 Jan 2009 21:21:13 +0000 (16:21 -0500)]
fixed update of moments
Jason H Stover [Mon, 12 Jan 2009 16:18:44 +0000 (11:18 -0500)]
Rewrote interaction.[ch]
John Darrington [Mon, 12 Jan 2009 06:38:32 +0000 (15:38 +0900)]
Added module file to PM entry
John Darrington [Mon, 12 Jan 2009 05:38:44 +0000 (14:38 +0900)]
Fix syntax errors in pod
John Darrington [Sun, 11 Jan 2009 01:38:09 +0000 (10:38 +0900)]
Updated copyright notices with the year 2009
John Darrington [Sun, 11 Jan 2009 00:45:47 +0000 (09:45 +0900)]
Add the perl module tarball to the build target
John Darrington [Sat, 10 Jan 2009 23:15:49 +0000 (08:15 +0900)]
Merge branch 'master' of /home/john/Development/pspp-bare
John Darrington [Sat, 10 Jan 2009 03:42:01 +0000 (12:42 +0900)]
Add short entry to Examples.pod describing Reader
John Darrington [Sat, 10 Jan 2009 00:11:53 +0000 (09:11 +0900)]
Merge commit 'origin/master'; commit 'savannah/master'
John Darrington [Fri, 9 Jan 2009 23:49:32 +0000 (08:49 +0900)]
Move .ui files to build directory
The .ui files had been inadvertently put in the src directory.
This change moves them to the build directory, since they're
(currently) generated from the .glade files.
John Darrington [Fri, 9 Jan 2009 21:43:34 +0000 (06:43 +0900)]
Replaced call to g_strcmp0 with strcmp, since the former
is available only in glib 2.16+.
Thanks to unknown-1 for reporting this.
John Darrington [Fri, 9 Jan 2009 08:37:10 +0000 (17:37 +0900)]
Link the perl module against the shared library instead of the static one
Ben Pfaff [Fri, 9 Jan 2009 05:36:23 +0000 (21:36 -0800)]
Fix assertion in case_copy().
This is an apparent cut-and-paste error.
John Darrington [Thu, 8 Jan 2009 08:23:53 +0000 (17:23 +0900)]
Ensure that perl module tests work before pspp has been installed
John Darrington [Thu, 8 Jan 2009 03:08:44 +0000 (12:08 +0900)]
Added method to get the custom variable attributes
John Darrington [Wed, 7 Jan 2009 22:57:12 +0000 (07:57 +0900)]
Update module to reflect new case API
John Darrington [Wed, 7 Jan 2009 22:20:47 +0000 (07:20 +0900)]
Merge commit 'savannah/master'
John Darrington [Wed, 7 Jan 2009 22:16:58 +0000 (07:16 +0900)]
Merge branch 'master' of /home/john/Development/pspp-bare
Ben Pfaff [Wed, 7 Jan 2009 07:17:32 +0000 (23:17 -0800)]
Make cases simpler, faster, and easier to understand.
Cases (struct ccase) is reference-counted to avoid copying more
data than necessary. But the existing implementation that uses
separate structures for references to cases (struct ccase) and
the cases themselves (struct case_data) has a number of issues:
- The semantics of struct ccase are tricky to remember; one
has to remember to treat struct ccase as essentially a
pointer type. I get confused sometimes myself.
(One of the symptoms of this was the existence of
the case_nullify and case_is_null functions, which are
exactly analogous to setting a pointer to null and comparing
one against null, respectively.)
- Every reference to data in a case involves two levels of
indirection, which is one more than actually necessary.
- The implementation is somewhat complicated.
This commit simplifies things, by dropping a level of indirection.
Now, a case is just a pointer to a struct ccase, which contains
the actual data. Reference counting is still present, but it is
simplified. The only thing that must be remembered is that, before
modifying a case that may be shared, it must be passed through
case_unshare() to make a new unshared copy if necessary.
John Darrington [Wed, 7 Jan 2009 01:16:03 +0000 (10:16 +0900)]
Ensure that dict survives sysfile
Make sure that the dict of a sysfile survives for the
lifetime of that sysfile. Thanks to Rob Messer for
reporting this bug.
John Darrington [Sun, 4 Jan 2009 12:34:16 +0000 (21:34 +0900)]
Write message to status bar on saving syntax files
John Darrington [Sun, 4 Jan 2009 08:30:30 +0000 (17:30 +0900)]
Merge commit 'HEAD'; commit 'master/master'
Conflicts:
src/ui/gui/crosstabs-dialog.c
src/ui/gui/goto-case-dialog.c
src/ui/gui/helper.c
src/ui/gui/regression-dialog.c
John Darrington [Sun, 4 Jan 2009 07:39:49 +0000 (16:39 +0900)]
Remove inappropriate include directives
John Darrington [Sun, 4 Jan 2009 07:04:38 +0000 (16:04 +0900)]
Remove invalid property
John Darrington [Sun, 4 Jan 2009 07:00:04 +0000 (16:00 +0900)]
Fix pointer types as appropriate
John Darrington [Sun, 4 Jan 2009 06:48:59 +0000 (15:48 +0900)]
Convert psppire.glade to psppire.ui
John Darrington [Sun, 4 Jan 2009 06:03:02 +0000 (15:03 +0900)]
Converted T-Test dialogs to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:32:36 +0000 (14:32 +0900)]
Add *.ui to .gitignore
John Darrington [Sun, 4 Jan 2009 05:31:45 +0000 (14:31 +0900)]
Convert Regression dialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:26:11 +0000 (14:26 +0900)]
Convert MessageDialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:19:07 +0000 (14:19 +0900)]
Convert Crosstabs dialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 05:09:30 +0000 (14:09 +0900)]
Convert Examine dialog to GtkBuilder
John Darrington [Sun, 4 Jan 2009 04:59:50 +0000 (13:59 +0900)]
Convert Frequencies dialog to GtkBuilder
John Darrington [Sat, 3 Jan 2009 12:45:47 +0000 (21:45 +0900)]
Migrated rank and recode dialogs to GtkBuilder
John Darrington [Sat, 3 Jan 2009 12:20:28 +0000 (21:20 +0900)]
Added infrastructure for GtkBuilder and change oneway-dialog to use it.
John Darrington [Fri, 2 Jan 2009 08:01:23 +0000 (17:01 +0900)]
Fix warnings
John Darrington [Fri, 2 Jan 2009 07:47:34 +0000 (16:47 +0900)]
Make sure finalizers are called properly
John Darrington [Fri, 2 Jan 2009 06:48:32 +0000 (15:48 +0900)]
Add menushell initialiser to output viewer
John Darrington [Thu, 1 Jan 2009 12:26:45 +0000 (21:26 +0900)]
Set default name on File->New
John Darrington [Thu, 1 Jan 2009 11:05:26 +0000 (20:05 +0900)]
Set the window title when opening a file on the command line
John Darrington [Thu, 1 Jan 2009 10:12:51 +0000 (19:12 +0900)]
Remove obsoleted files from build rules
John Darrington [Thu, 1 Jan 2009 08:12:06 +0000 (17:12 +0900)]
Re-enable reporting of filename in syntax errors
John Darrington [Thu, 1 Jan 2009 07:35:50 +0000 (16:35 +0900)]
Refactor common code in dialog implementations
John Darrington [Thu, 1 Jan 2009 01:19:37 +0000 (10:19 +0900)]
Add actions to the menuitem signals
John Darrington [Thu, 1 Jan 2009 00:09:36 +0000 (09:09 +0900)]
New (singleton) object psppire-window-register