pintos-anon
18 years agoMove assignment to _end_kernel_text inside .rodata.
Ben Pfaff [Mon, 25 Sep 2006 21:43:09 +0000 (21:43 +0000)]
Move assignment to _end_kernel_text inside .rodata.

Without this change, any orphan, read-only sections (such as .eh_frame
from libgcc) will be placed by GNU ld between .rodata and
_end_kernel_text.  The result is that _end_kernel_text gets pushed
into the middle of a page that now contains some read-only and some
read/write data.  After paging_init() marks that page read-only, the
first write to it (in intr_init() in my case) causes Pintos to go
ka-boom!

With this change, orphan read-only sections just don't get marked
read-only in the page tables.  Big deal.

18 years agoFix two bugs in the base Pintos code:
Ben Pfaff [Mon, 25 Sep 2006 20:26:35 +0000 (20:26 +0000)]
Fix two bugs in the base Pintos code:

1. Idle thread doesn't get initialized well: it hangs around on the
   ready list until we have idle time.  Fix by using a semaphore to
   make sure the idle thread gets initialized.

2. After idle thread does get initialized, it can get put back on the
   ready list if you yield from the timer interrupt.  Fix by not ever
   putting the idle thread on the ready list.

Plus fix a bug in the sample solution that tends to mask #2:

3. Doesn't yield from timer interrupt when unblocking a thread.  Fix
   by yielding from timer interrupt when unblocking a thread (of
   higher priority).

Also, fix something that confused students:

4. Rename enable_mlfqs to thread_mlfqs and move it to thread.c (to
   reduce confusion about where it is declared), and heavily comment
   to ensure that students know when it gets initialized.

These problems were drawn to my attention by Godmar Back.  Thanks!

18 years agofixed left-over, now-wrong comment about how decrease in numeric priority means incre...
Godmar Back [Wed, 13 Sep 2006 11:40:40 +0000 (11:40 +0000)]
fixed left-over, now-wrong comment about how decrease in numeric priority means increase in effective priority

18 years agofixed typo in wrong iterator example
Godmar Back [Tue, 12 Sep 2006 02:32:27 +0000 (02:32 +0000)]
fixed typo in wrong iterator example

18 years agoFix issue reported by Godmar Back:
Ben Pfaff [Sat, 9 Sep 2006 16:53:56 +0000 (16:53 +0000)]
Fix issue reported by Godmar Back:

    I may have found a problem with the triple fault patch, though I don't
    know how to solve it.
    If you add a *(int *)0=42 right after paging_init(), but before
    intr_init(), gdb will just hang:

...

    where it hangs while Pintos prints:

    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    Triple fault: stopping for gdb
    etc.

    It stops properly if I don't next-step (that is, if I just let it run.)

18 years agoConvert tabs to spaces to make cut-and-paste to interactive shell
Ben Pfaff [Sat, 9 Sep 2006 16:52:39 +0000 (16:52 +0000)]
Convert tabs to spaces to make cut-and-paste to interactive shell
work.

18 years agoMake kernel code pages read-only.
Ben Pfaff [Fri, 8 Sep 2006 00:51:17 +0000 (00:51 +0000)]
Make kernel code pages read-only.
From Godmar Back, with changes.

18 years agoClarify summary section.
Ben Pfaff [Fri, 8 Sep 2006 00:50:31 +0000 (00:50 +0000)]
Clarify summary section.

18 years agoChange several "die"s to "fail"s in read_tar.
Ben Pfaff [Sun, 20 Aug 2006 21:38:16 +0000 (21:38 +0000)]
Change several "die"s to "fail"s in read_tar.
Reported by Haobo Xu <haoboxu@stanford.edu>.

18 years agoB5: Include "open by a process" as a reason to disallow removing a
Ben Pfaff [Fri, 18 Aug 2006 16:48:47 +0000 (16:48 +0000)]
B5: Include "open by a process" as a reason to disallow removing a
directory.

18 years agoMinor wording improvement.
Ben Pfaff [Thu, 17 Aug 2006 18:27:07 +0000 (18:27 +0000)]
Minor wording improvement.

18 years agoA2: We want to see the work in the calculation, not just the final
Ben Pfaff [Thu, 17 Aug 2006 17:23:38 +0000 (17:23 +0000)]
A2: We want to see the work in the calculation, not just the final
result.

18 years agoMay also consult course staff.
Ben Pfaff [Thu, 17 Aug 2006 17:09:14 +0000 (17:09 +0000)]
May also consult course staff.

18 years agomake_tar_archive() needs to initialize `success'.
Ben Pfaff [Thu, 17 Aug 2006 16:47:41 +0000 (16:47 +0000)]
make_tar_archive() needs to initialize `success'.
Thanks to "Morgan" <theatomicbob@excite.com> for reporting this bug.

18 years agoClarify length.
Ben Pfaff [Fri, 4 Aug 2006 20:46:26 +0000 (20:46 +0000)]
Clarify length.

18 years agoFix comment.
Ben Pfaff [Sun, 23 Jul 2006 21:56:44 +0000 (21:56 +0000)]
Fix comment.

18 years agoFix comment.
Ben Pfaff [Sun, 23 Jul 2006 21:53:47 +0000 (21:53 +0000)]
Fix comment.

18 years agoImprove comment on sema_down.
Ben Pfaff [Fri, 21 Jul 2006 02:05:37 +0000 (02:05 +0000)]
Improve comment on sema_down.
Thanks to Haobo Xu for pointing this out.

18 years agoAdd an identifier to each question in the design document templates, sum0506
Ben Pfaff [Fri, 21 Jul 2006 00:56:03 +0000 (00:56 +0000)]
Add an identifier to each question in the design document templates,
so that they are easier to refer to individually.

18 years agoAdd a label for each question.
Ben Pfaff [Sun, 9 Jul 2006 17:55:06 +0000 (17:55 +0000)]
Add a label for each question.

18 years agoFix typo.
Ben Pfaff [Sun, 9 Jul 2006 15:10:00 +0000 (15:10 +0000)]
Fix typo.

18 years ago"woken up" => "awakened"
Ben Pfaff [Sat, 8 Jul 2006 18:56:36 +0000 (18:56 +0000)]
"woken up" => "awakened"

18 years agoAdd additional explanation to the spontaneous reboot output.
Ben Pfaff [Sat, 8 Jul 2006 18:15:14 +0000 (18:15 +0000)]
Add additional explanation to the spontaneous reboot output.

18 years agoMake requirements consistent with doc template wording.
Ben Pfaff [Fri, 7 Jul 2006 20:54:50 +0000 (20:54 +0000)]
Make requirements consistent with doc template wording.

18 years agoPoint out that all_list and all_elem don't exist in the tree we provide.
Ben Pfaff [Fri, 7 Jul 2006 18:53:30 +0000 (18:53 +0000)]
Point out that all_list and all_elem don't exist in the tree we provide.

18 years agoNew FAQ.
Ben Pfaff [Fri, 7 Jul 2006 01:52:28 +0000 (01:52 +0000)]
New FAQ.

18 years agoFix summary.
Ben Pfaff [Fri, 7 Jul 2006 01:14:13 +0000 (01:14 +0000)]
Fix summary.
Thanks to Samanth Lingampalli <samanthl@stanford.edu> and Haobo Xu
<haoboxu@stanford.edu> for input.

18 years agoDon't say that the design doc itself is 50% of the grade.
Ben Pfaff [Sun, 2 Jul 2006 16:52:58 +0000 (16:52 +0000)]
Don't say that the design doc itself is 50% of the grade.

18 years agoUse test -f because Solaris sh does not support -e.
Ben Pfaff [Fri, 30 Jun 2006 00:51:42 +0000 (00:51 +0000)]
Use test -f because Solaris sh does not support -e.
(Idiots can't read POSIX spec I guess.)

18 years agoRecommend zcat piping into tar x, instead of tar xzf, because some of
Ben Pfaff [Mon, 19 Jun 2006 21:52:52 +0000 (21:52 +0000)]
Recommend zcat piping into tar x, instead of tar xzf, because some of
the Leland machines don't have GNU tar and thus don't support "z".

18 years agoAllow user fault messages in output in bad-* tests.
Ben Pfaff [Mon, 19 Jun 2006 21:50:53 +0000 (21:50 +0000)]
Allow user fault messages in output in bad-* tests.
Add "pass;" at end of each bad-* test checker script.

18 years ago@ need to be escaped.
Ben Pfaff [Thu, 15 Jun 2006 00:59:18 +0000 (00:59 +0000)]
@ need to be escaped.

18 years agoAdd some comments.
Ben Pfaff [Wed, 14 Jun 2006 16:00:20 +0000 (16:00 +0000)]
Add some comments.
From chris@seberino.org.

18 years agoPoint out that the tarball does not include the doc directory.
Ben Pfaff [Sun, 11 Jun 2006 16:53:09 +0000 (16:53 +0000)]
Point out that the tarball does not include the doc directory.
From chris@seberino.org.

18 years agoCapitalize QEMU properly.
Ben Pfaff [Sat, 10 Jun 2006 20:09:25 +0000 (20:09 +0000)]
Capitalize QEMU properly.
From chris@seberino.org.

18 years agoadded bad-jump/read/write bad-jump2/read2/write2 to check that process
Godmar Back [Wed, 7 Jun 2006 22:09:19 +0000 (22:09 +0000)]
added bad-jump/read/write bad-jump2/read2/write2 to check that process
that attempt to execute/read/write NULL or a kernel address, resp., are
properly terminated.

18 years agodefined 'test_name' for msg()/vmsg() to work properly
Godmar Back [Tue, 6 Jun 2006 12:48:38 +0000 (12:48 +0000)]
defined 'test_name' for msg()/vmsg() to work properly

18 years agoMake quoting consistent.
Ben Pfaff [Fri, 2 Jun 2006 22:13:31 +0000 (22:13 +0000)]
Make quoting consistent.

18 years agoPoint to installation instructions.
Ben Pfaff [Fri, 2 Jun 2006 22:10:36 +0000 (22:10 +0000)]
Point to installation instructions.

18 years agoReplace GSX Server support with VMware Player support.
Ben Pfaff [Fri, 2 Jun 2006 22:06:51 +0000 (22:06 +0000)]
Replace GSX Server support with VMware Player support.
Fully support serial terminal with Player.

18 years agoAdd installation chapter to manual. Remove now-redundant files from
Ben Pfaff [Thu, 1 Jun 2006 22:17:39 +0000 (22:17 +0000)]
Add installation chapter to manual.  Remove now-redundant files from
src/utils, src/misc.

Update copyright years in license.  Add license to manual.

18 years agoFix typos.
Ben Pfaff [Thu, 1 Jun 2006 21:54:30 +0000 (21:54 +0000)]
Fix typos.

18 years agoAdd support for "keyboard" input over the serial port.
Ben Pfaff [Thu, 1 Jun 2006 20:11:00 +0000 (20:11 +0000)]
Add support for "keyboard" input over the serial port.
Revise documentation accordingly.
Revise reference solution accordingly.
Change real Return key to produce \r, to match what is received on
serial port.
Update shell example program to expect \r at end of file.
Modify testing makefiles to supply /dev/null as input.
Add squish-pty help program to deal with Bochs,
and modify "pintos" to use it.

18 years agoDon't put white space before call to $(eval) because that makes GNU
Ben Pfaff [Thu, 1 Jun 2006 20:07:45 +0000 (20:07 +0000)]
Don't put white space before call to $(eval) because that makes GNU
make 3.80 on vine barf.

18 years agoIncrease timeout for MLFQS tests to 480 seconds, which is necessary
Ben Pfaff [Thu, 1 Jun 2006 15:03:40 +0000 (15:03 +0000)]
Increase timeout for MLFQS tests to 480 seconds, which is necessary
sometimes.

18 years agoAdd utils to CLEAN_SUBDIRS.
Ben Pfaff [Wed, 31 May 2006 18:26:36 +0000 (18:26 +0000)]
Add utils to CLEAN_SUBDIRS.

18 years agoFix two bugs:
Ben Pfaff [Tue, 30 May 2006 21:35:27 +0000 (21:35 +0000)]
Fix two bugs:
- If -s used with GSX, really don't provide serial port.
- Call File::Temp::cleanup() inside eval to cope with old versions
  of File::Temp that didn't have cleanup.

18 years agoFix stupidity in last check-in.
Ben Pfaff [Tue, 30 May 2006 21:33:10 +0000 (21:33 +0000)]
Fix stupidity in last check-in.

18 years agoAdd patch to support serial terminals under Solaris.
Ben Pfaff [Tue, 30 May 2006 20:27:07 +0000 (20:27 +0000)]
Add patch to support serial terminals under Solaris.

18 years agoAdd priority-donate-lower to rubric.
Ben Pfaff [Tue, 30 May 2006 20:26:03 +0000 (20:26 +0000)]
Add priority-donate-lower to rubric.

18 years agoReduce number of simultaneously waking threads to 3,
Ben Pfaff [Tue, 30 May 2006 20:25:40 +0000 (20:25 +0000)]
Reduce number of simultaneously waking threads to 3,
in lieu of increasing instructions-per-second (ips) for Bochs.

18 years agoWhen using -k, make sure to flush all of the subprocess's output to
Ben Pfaff [Tue, 30 May 2006 20:18:24 +0000 (20:18 +0000)]
When using -k, make sure to flush all of the subprocess's output to
stdout, even after the subprocess has died.

18 years agoMake stdout unbuffered while filtering output.
Ben Pfaff [Tue, 30 May 2006 19:25:32 +0000 (19:25 +0000)]
Make stdout unbuffered while filtering output.

18 years agoComment.
Ben Pfaff [Sat, 27 May 2006 20:57:13 +0000 (20:57 +0000)]
Comment.

18 years agoAdd "-k" option to pintos script. When used, pintos will scan the
Ben Pfaff [Sat, 27 May 2006 20:21:09 +0000 (20:21 +0000)]
Add "-k" option to pintos script.  When used, pintos will scan the
serial output for key words like "Kernel PANIC" and, if found,
terminate the run.  This is useful for making sure that things like
triple faults or recursive panics don't waste a lot of time by finally
terminating only upon a timeout that might be as much as 10 minutes.
Add "-k" to the command line used in the test scripts.

Also, pintos now saves and restores the terminal settings across the
call to the simulator.  This is because qemu turns off local echo and
doesn't restore it if killed by a signal.

18 years agoPut "abort" in "User process abort" in all caps, analogous to "Kernel
Ben Pfaff [Sat, 27 May 2006 20:10:32 +0000 (20:10 +0000)]
Put "abort" in "User process abort" in all caps, analogous to "Kernel
PANIC".

18 years agoDisable networking when running qemu,
Ben Pfaff [Sat, 27 May 2006 16:27:04 +0000 (16:27 +0000)]
Disable networking when running qemu,
to suppress prompt for sudo password (if enabled).

18 years agoAdd file system persistence tests:
Ben Pfaff [Sat, 27 May 2006 00:06:54 +0000 (00:06 +0000)]
Add file system persistence tests:

Change Make.tests to invoke pintos a second time for the extended
filesys tests, and in that run to tar up the file system contents and
copy it out.
Update grading scripts to check the generated tarballs.

Update documentation.

Update documented requirements for remove() of a directory to give
basically the options offered by POSIX, and update the tests to check
for these behaviors.

Remove dir-lsdir test, which no longer made sense given that readdir
is used so heavily in other tests.

Merge dir-mk-vine and dir-rm-vine tests into a single dir-vine test,
which is now much more stringent.

Merge dir-rm-cwd-cd and dir-rm-cwd into a single dir-rm-cwd test,
which is now much more stringent.

Check that a non-empty directory cannot be removed.

Update scoring rubrics.

18 years agoMake the default simulator qemu for project 2...4,
Ben Pfaff [Fri, 26 May 2006 20:59:59 +0000 (20:59 +0000)]
Make the default simulator qemu for project 2...4,
instead of just doing so in tests/Makefile.
Update documentation to match.

18 years agoqemu is much faster than Bochs.
Ben Pfaff [Fri, 26 May 2006 19:50:57 +0000 (19:50 +0000)]
qemu is much faster than Bochs.

18 years agoEnclose kernel command line arguments that contain spaces in quotes
Ben Pfaff [Wed, 24 May 2006 20:18:05 +0000 (20:18 +0000)]
Enclose kernel command line arguments that contain spaces in quotes
when printing.

18 years agoAdd EXIT_FAILURE, EXIT_SUCCESS to syscall.h,
Ben Pfaff [Tue, 23 May 2006 16:33:22 +0000 (16:33 +0000)]
Add EXIT_FAILURE, EXIT_SUCCESS to syscall.h,
and use them in the example programs.
Add comments to syscall.h.

18 years agoFile system project updates:
Ben Pfaff [Mon, 22 May 2006 18:47:19 +0000 (18:47 +0000)]
File system project updates:
Require support for . and ...
Add inumber system call, so getcwd can be implemented,
and inode_get_inumber() function.
Implement these features in the reference solution.
Add "pwd" example program and require explanation of it in design
document.
Implement "cd" in shell.
Add -l option to "ls" example program.
Describe interpretation of unusual file names.
Remove filesys_self_test().
Update TODO.

18 years agoAdd test that compiles the examples.
Ben Pfaff [Mon, 22 May 2006 17:52:28 +0000 (17:52 +0000)]
Add test that compiles the examples.

18 years agoWording.
Ben Pfaff [Mon, 22 May 2006 17:51:46 +0000 (17:51 +0000)]
Wording.

18 years agoFix comment style.
Ben Pfaff [Mon, 22 May 2006 01:45:13 +0000 (01:45 +0000)]
Fix comment style.

18 years agoRemove obsolete files.
Ben Pfaff [Sun, 21 May 2006 02:11:51 +0000 (02:11 +0000)]
Remove obsolete files.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 22:43:50 +0000 (22:43 +0000)]
Wordsmithing.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 22:29:26 +0000 (22:29 +0000)]
Wordsmithing.

18 years agoUpdate bibliography.
Ben Pfaff [Sat, 20 May 2006 22:29:16 +0000 (22:29 +0000)]
Update bibliography.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 22:18:36 +0000 (22:18 +0000)]
Wordsmithing.
Document block allocator functions.

18 years agoComment.
Ben Pfaff [Sat, 20 May 2006 22:00:32 +0000 (22:00 +0000)]
Comment.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 21:29:04 +0000 (21:29 +0000)]
Wordsmithing.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 20:45:40 +0000 (20:45 +0000)]
Wordsmithing.

18 years agoComment.
Ben Pfaff [Sat, 20 May 2006 20:01:15 +0000 (20:01 +0000)]
Comment.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 19:56:27 +0000 (19:56 +0000)]
Wordsmithing.
Cite papers on semaphores, monitors.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 17:33:48 +0000 (17:33 +0000)]
Wordsmithing.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 17:27:02 +0000 (17:27 +0000)]
Wordsmithing.

18 years agoWordsmithing.
Ben Pfaff [Sat, 20 May 2006 17:17:25 +0000 (17:17 +0000)]
Wordsmithing.
Update description of main()'s calling order.

18 years agoConsistently spell "file name" and "file system" as two words.
Ben Pfaff [Fri, 19 May 2006 23:41:59 +0000 (23:41 +0000)]
Consistently spell "file name" and "file system" as two words.

18 years agoAdd file_get_inode() for symmetry with dir_get_inode().
Ben Pfaff [Fri, 19 May 2006 20:43:25 +0000 (20:43 +0000)]
Add file_get_inode() for symmetry with dir_get_inode().

18 years agoComments.
Ben Pfaff [Fri, 19 May 2006 20:39:54 +0000 (20:39 +0000)]
Comments.

18 years agoReplace lsdir system call by readdir, isdir system calls,
Ben Pfaff [Fri, 19 May 2006 20:38:50 +0000 (20:38 +0000)]
Replace lsdir system call by readdir, isdir system calls,
which are far less offensive to good taste.
Add dir_get_inode() and dir_readdir() functions.
Remove dir_list(), filesys_list().  The latter was unused.
Update project documentation, solutions, and tests.
Rewrite "ls" example program to use the new interface, and add the
ability to specify a directory name and a "long format" feature.
Add "cd" command to shell.

18 years agoImprove readability.
Ben Pfaff [Fri, 19 May 2006 20:03:10 +0000 (20:03 +0000)]
Improve readability.

18 years agoImprove automatic test failure interpretation by extending backtrace
Ben Pfaff [Fri, 19 May 2006 17:44:13 +0000 (17:44 +0000)]
Improve automatic test failure interpretation by extending backtrace
to the binary that failed.

18 years agoRemove unused variable.
Ben Pfaff [Fri, 19 May 2006 16:50:19 +0000 (16:50 +0000)]
Remove unused variable.

18 years agoIgnore mcat.
Ben Pfaff [Fri, 19 May 2006 14:39:47 +0000 (14:39 +0000)]
Ignore mcat.

18 years agoMake directory interface more like file interface.
Ben Pfaff [Fri, 19 May 2006 04:47:28 +0000 (04:47 +0000)]
Make directory interface more like file interface.
In reference solution, push locking up to inode layer, simplifying
changes to directory code.

18 years agoWording.
Ben Pfaff [Fri, 19 May 2006 03:18:59 +0000 (03:18 +0000)]
Wording.

18 years agoFix menu.
Ben Pfaff [Fri, 19 May 2006 03:17:28 +0000 (03:17 +0000)]
Fix menu.

18 years agoWording.
Ben Pfaff [Fri, 19 May 2006 03:17:09 +0000 (03:17 +0000)]
Wording.

18 years agoWording.
Ben Pfaff [Thu, 18 May 2006 19:47:22 +0000 (19:47 +0000)]
Wording.

18 years agoWording.
Ben Pfaff [Thu, 18 May 2006 19:47:04 +0000 (19:47 +0000)]
Wording.

18 years agoTest interaction between priority donation and thread_set_priority().
Ben Pfaff [Thu, 18 May 2006 19:37:03 +0000 (19:37 +0000)]
Test interaction between priority donation and thread_set_priority().
Suggestion from Godmar Back.

18 years agoFormatting.
Ben Pfaff [Thu, 18 May 2006 19:08:17 +0000 (19:08 +0000)]
Formatting.

18 years agoRandomize the bits that bitmap_scan() returns, to make student errors
Ben Pfaff [Thu, 18 May 2006 19:02:35 +0000 (19:02 +0000)]
Randomize the bits that bitmap_scan() returns, to make student errors
that assume contiguous memory allocation show up.

18 years agoFix comment typo.
Ben Pfaff [Thu, 18 May 2006 17:08:52 +0000 (17:08 +0000)]
Fix comment typo.

18 years agoAdd test that checks that recent_cpu decays properly for blocked
Ben Pfaff [Thu, 18 May 2006 17:08:41 +0000 (17:08 +0000)]
Add test that checks that recent_cpu decays properly for blocked
threads.
Suggested by Godmar Back.

18 years agoUpdate docs to say that a pointer to an inode should not limit you to
Ben Pfaff [Thu, 18 May 2006 15:54:25 +0000 (15:54 +0000)]
Update docs to say that a pointer to an inode should not limit you to
64 open files.

18 years agoAdd a test for P1 that checks that multiple threads can properly wake
Ben Pfaff [Thu, 18 May 2006 02:55:09 +0000 (02:55 +0000)]
Add a test for P1 that checks that multiple threads can properly wake
up at the same clock tick.