John Darrington [Wed, 1 Aug 2007 23:30:37 +0000 (23:30 +0000)]
Use non-deprecated functions.
Ben Pfaff [Wed, 1 Aug 2007 03:33:15 +0000 (03:33 +0000)]
Remove integer mode from FREQUENCIES and incidentally fix bug
#17421. Reviewed by John Darrington.
* frequencies.q (int_pool): Rename data_pool.
(gen_pool): Rename syntax_pool.
(enum FRQM_*): Removed.
(struct freq_tab): Removed `mode', `vector', `min', `max',
`out_of_range', `sysmis' members.
(calc): Delete support for integer mode.
(precalc): Ditto.
(postprocess_freq_tab): Ditto.
(cleanup_freq_tab): Ditto.
(frq_custom_variables): Ditto.
John Darrington [Mon, 30 Jul 2007 23:57:07 +0000 (23:57 +0000)]
Used the correct variable in error message. Thanks to Ben for reporting
this problem.
Ben Pfaff [Mon, 30 Jul 2007 17:07:50 +0000 (17:07 +0000)]
Provisional fix for bug #18692 and bug #20161. Reviewed by John
Darrington.
John Darrington [Mon, 30 Jul 2007 09:43:27 +0000 (09:43 +0000)]
Implemented the CD command.
John Darrington [Mon, 30 Jul 2007 09:28:35 +0000 (09:28 +0000)]
Enabled output generation in the GUI.
John Darrington [Sun, 29 Jul 2007 07:56:52 +0000 (07:56 +0000)]
Implemented the Select Cases Dialog
Ben Pfaff [Sun, 29 Jul 2007 05:40:51 +0000 (05:40 +0000)]
Make PSPP able to read all the portable files I could find on the
web.
* por-file-reader.c (struct pfm_reader): New member `line_length'.
(error): Print file offset in hexadecimal.
(warning): New function.
(advance): Treat lines less than 80 bytes long as padded to 80
bytes with spaces.
(pfm_open_reader): Call read_documents if we find an "E" record.
(convert_format): Convert invalid formats to the default format
instead of aborting reading the file.
(read_variables): Rename duplicate variable names instead of
aborting reading the file.
(read_value_label): Allow string variables of different widths to
be assigned value labels in the same record. Replace duplicate
value labels instead of aborting.
(read_documents): New function.
* por-file-writer.c (pfm_open_writer): Call write_documents if the
dictionary has documents.
(write_documents): New function.
John Darrington [Sat, 28 Jul 2007 05:24:49 +0000 (05:24 +0000)]
Per latest comments in bug #19069
John Darrington [Sat, 28 Jul 2007 00:40:52 +0000 (00:40 +0000)]
Fix bug #19604. T-Test documentation now matches code; code matches spss behaviour
Ben Pfaff [Fri, 27 Jul 2007 22:59:32 +0000 (22:59 +0000)]
Add tty and listing devices that use VT100 (and xterm) line-drawing
characters, and corresponding support for an initialization string in
the ASCII output device.
Ben Pfaff [Fri, 27 Jul 2007 22:58:02 +0000 (22:58 +0000)]
Make interactive output go to the terminal (bug #17213), by
causing the UI to flush output to the user when it prompts for a
command.
Thanks to John Darrington for review.
Ben Pfaff [Fri, 27 Jul 2007 21:44:18 +0000 (21:44 +0000)]
(run_regression): Move casereader_destroy call so that it always gets
called, not just if there was some valid data. Fixes bug #19581.
Reviewed by Jason Stover.
Ben Pfaff [Fri, 27 Jul 2007 21:38:12 +0000 (21:38 +0000)]
Bug #19069.
* INSTALL: Improve installation instructions.
* README: Move prerequisites to INSTALL.
Reviewed by Jason Stover.
Ben Pfaff [Fri, 27 Jul 2007 21:33:35 +0000 (21:33 +0000)]
Make PKG_CHECK_MODULES tests more user-friendly,
by having them give their errors at the end of the configuration
process instead of stopping it in the middle. Patch #6116.
Reviewed by Jason Stover.
John Darrington [Thu, 26 Jul 2007 12:03:21 +0000 (12:03 +0000)]
Removed the OMS status bar area for which we're unlikely to have any use
in the near future.
John Darrington [Thu, 26 Jul 2007 02:02:22 +0000 (02:02 +0000)]
Patch #6086. Adds "transformation pending" state.
Thanks to Ben for the review.
Ben Pfaff [Thu, 26 Jul 2007 01:52:04 +0000 (01:52 +0000)]
Fix bug #17100.
* command/data-list.sh: Add tests for multi-record DATA LIST with
and without empty trailing record.
* data-list.c (read_from_data_list_fixed): Handle multi-record
DATA LIST correctly.
Ben Pfaff [Wed, 25 Jul 2007 04:32:14 +0000 (04:32 +0000)]
*** empty log message ***
Ben Pfaff [Wed, 25 Jul 2007 04:31:34 +0000 (04:31 +0000)]
Fix bug #6113.
* sys-file-writer.c (write_variable_display_parameters): Use new
var_default_display_width function to choose display width of
segments after the first one in a given variable.
* variable.c (var_create): Use var_default_display_width to pick
new variable's display width.
(var_default_display_width): New function.
Ben Pfaff [Wed, 25 Jul 2007 04:09:44 +0000 (04:09 +0000)]
Fix bug #20427.
* por-file-writer.c (write_variables): Write weight variable.
Reviewed by John Darrington.
Ben Pfaff [Wed, 25 Jul 2007 04:03:58 +0000 (04:03 +0000)]
Fix bugs #20493, #20494.
* flip.c (struct flip_pgm): Remove `case_size' member (now
unused).
(cmd_flip): Pass var_cnt as number of cases instead of case_cnt,
to fix bug #20494. Don't assign to `case_size' member, which was
unused after assignment.
(build_dictionary): When NEWNAMES not used, get the number of
variables right, to fix bug #20493.
* tests/command/flip.sh: Add tests to avoid regression on bugs
#20493, #20494.
John Darrington [Wed, 25 Jul 2007 01:33:02 +0000 (01:33 +0000)]
Made Missing Values and Value Label cells non-editable, if the variable
is a long string variable.
Closes bug #20564
John Darrington [Tue, 24 Jul 2007 13:05:05 +0000 (13:05 +0000)]
Added the ability to paste data from the primary selection.
Removed the "clip" feature.
John Darrington [Tue, 24 Jul 2007 12:45:06 +0000 (12:45 +0000)]
Added an extra call to data_var_select and a comment to explain why.
John Darrington [Tue, 24 Jul 2007 11:50:18 +0000 (11:50 +0000)]
Removed a function which was simply a wrapper around another.
John Darrington [Tue, 24 Jul 2007 06:24:01 +0000 (06:24 +0000)]
Tidied up the way that value-labels button and menu item interact.
Ben Pfaff [Tue, 24 Jul 2007 05:33:43 +0000 (05:33 +0000)]
Numerous improvements to system file reader and writer.
Ben Pfaff [Mon, 23 Jul 2007 05:11:58 +0000 (05:11 +0000)]
Don't try to write very long strings to portable files. The format
does not support it.
(MAX_POR_WIDTH): New macro.
(pfm_open_writer): Limit output width to MAX_POR_WIDTH.
(write_format): Add arg to take width to resize format to.
(write_value): Limit width of value written to MAX_POR_WIDTH.
(write_variables): Limit width of variable and its output formats
to MAX_POR_WIDTH.
Ben Pfaff [Mon, 23 Jul 2007 05:07:23 +0000 (05:07 +0000)]
(read_variable_to_value_map): Use max_warnings
local variable instead of literal 5.
Ben Pfaff [Mon, 23 Jul 2007 05:05:45 +0000 (05:05 +0000)]
Fix problems with uniqueness of short names in system files with very
long string variables. Now a variable may have multiple short names.
* automake.mk (src_data_libdata_a_SOURCES): Add new files
short-names.c, short-names.h.
* dictionary.c (dict_clone): Clone all the short names.
(compare_strings): Move into short-names.c.
(hash_strings): Ditto.
(set_var_short_name_suffix): Ditto.
(dict_assign_short_names): Ditto, rename short_names_assign,
change to assign all short names.
* por-file-writer.c (write_variables): Use short_names_assign
instead of dict_assign_short_names.
* short-names.c: New file.
* short-names.h: New file.
* sys-file-private.c (sfm_width_to_segments): New function.
* sys-file-reader.c (read_long_var_name_map): Save and restore all
the short names, not just the first one.
* sys-file-writer.c (cont_var_name): Removed.
(sfm_open_writer): Use short_names_assign instead of
dict_assign_short_names. Use unique short names assigned by
short_names_assign instead of those generated by cont_var_name.
* variable.c (struct variable): Remove `short_name' member,
replace by `short_names' and `short_name_cnt'.
(var_create) Initialize new members.
(var_get_short_name_cnt): New function.
(var_get_short_name): Now takes an index argument. Changed most
callers to pass 0.
(var_set_short_name): Ditto.
(var_clear_short_name): Renamed var_clear_short_names, changed to
clear all short names.
Ben Pfaff [Mon, 23 Jul 2007 04:48:10 +0000 (04:48 +0000)]
Include xstrndup.h also.
Ben Pfaff [Mon, 23 Jul 2007 04:46:30 +0000 (04:46 +0000)]
(float_get_double): New function.
Ben Pfaff [Mon, 23 Jul 2007 04:44:11 +0000 (04:44 +0000)]
* variable.c (var_set_width): Use new var_set_width function.
* missing-values.c (mv_n_values): Drop assertion, which was not
needed.
* format.c (fmt_default_for_width): New function.
(fmt_resize): New function.
Ben Pfaff [Mon, 23 Jul 2007 04:40:21 +0000 (04:40 +0000)]
Test both compressed and uncompressed system files with very long
strings.
John Darrington [Thu, 19 Jul 2007 00:36:00 +0000 (00:36 +0000)]
Delete unused dialogs
John Darrington [Wed, 18 Jul 2007 05:32:21 +0000 (05:32 +0000)]
Added popup menus to column and row title areas in datasheet.
Ben Pfaff [Wed, 18 Jul 2007 04:28:11 +0000 (04:28 +0000)]
Ignore directories that have been removed from CVS. These used to not
show up in Emacs' pcl-cvs mode, but for some reason they now pollute
the display.
John Darrington [Wed, 18 Jul 2007 04:27:29 +0000 (04:27 +0000)]
Enabled deleting of variables from the datasheet
Ben Pfaff [Wed, 18 Jul 2007 03:20:25 +0000 (03:20 +0000)]
Use strict and all warnings.
Ben Pfaff [Wed, 18 Jul 2007 03:18:31 +0000 (03:18 +0000)]
Use strict and all warnings. Fix warnings that this triggers.
Ben Pfaff [Wed, 18 Jul 2007 03:17:03 +0000 (03:17 +0000)]
Use strict and all warnings. Simplify parsing. Add "@c End:" line to
output to suppress Emacs warning. From bug #19335. Reviewed by John
Darrington.
Ben Pfaff [Wed, 18 Jul 2007 02:45:57 +0000 (02:45 +0000)]
Make file names in change log consistently relative to tests
directory.
Ben Pfaff [Wed, 18 Jul 2007 02:44:29 +0000 (02:44 +0000)]
Drop the tests that depend on parsing "-0" from a syntax file. Also
make float-format.sh error messages easier to read, by changing the
sed command so that error line numbers are easier to match to the test
input.
Ben Pfaff [Wed, 18 Jul 2007 02:20:45 +0000 (02:20 +0000)]
Improve the description of the SPSS system file format. Patch #6103.
Thanks to John Darrington for review.
John Darrington [Wed, 18 Jul 2007 00:50:58 +0000 (00:50 +0000)]
Added the ability to resize string variables from the GUI. Thanks to
Ben for his comments.
John Darrington [Mon, 16 Jul 2007 11:18:09 +0000 (11:18 +0000)]
Removed legacy code.
John Darrington [Mon, 16 Jul 2007 05:07:02 +0000 (05:07 +0000)]
File Open dialog now remembers directory of last opened file.
John Darrington [Sun, 15 Jul 2007 09:59:52 +0000 (09:59 +0000)]
Only generate NUMERIC or STRING command if the type-and-label dialog was
used.
John Darrington [Sun, 15 Jul 2007 09:22:46 +0000 (09:22 +0000)]
Remove "show-expanders" field (prevents warnings under gtk+-2.8)
John Darrington [Sat, 14 Jul 2007 06:25:23 +0000 (06:25 +0000)]
Only taint casereader if case size is unknown.
John Darrington [Sat, 14 Jul 2007 05:47:46 +0000 (05:47 +0000)]
Respect the case_cnt field from sys file header. Closes patch #6092
John Darrington [Fri, 13 Jul 2007 06:39:05 +0000 (06:39 +0000)]
Finally got the datasheet responding fast enough.
John Darrington [Fri, 13 Jul 2007 02:50:00 +0000 (02:50 +0000)]
Removed some deprecated gtk_ calls.
John Darrington [Fri, 13 Jul 2007 01:18:48 +0000 (01:18 +0000)]
Deleted lib/gtksheet/gtkiconlist.[ch] which isn't used (was it ever?)
John Darrington [Fri, 13 Jul 2007 00:57:02 +0000 (00:57 +0000)]
Updated INSTALL to be more specific to pspp.
John Darrington [Fri, 13 Jul 2007 00:46:41 +0000 (00:46 +0000)]
Added prototype to avoid compile time warning.
John Darrington [Thu, 12 Jul 2007 12:22:35 +0000 (12:22 +0000)]
Made the datasheet redraw itself when new data is loaded.
John Darrington [Thu, 12 Jul 2007 06:33:51 +0000 (06:33 +0000)]
Use non-deprecated function g_idle_add
Ben Pfaff [Thu, 12 Jul 2007 05:06:22 +0000 (05:06 +0000)]
Remove unused file. Fixes bug #18140.
Ben Pfaff [Thu, 12 Jul 2007 04:30:11 +0000 (04:30 +0000)]
(map_case): Create destination case instead of leaving it
undefined. Fixes bug #20285.
Reviewed by John Darrington.
John Darrington [Wed, 11 Jul 2007 03:59:57 +0000 (03:59 +0000)]
Made type-and-label subdialog behave rationally when the target variable
already exists.
Ben Pfaff [Tue, 10 Jul 2007 13:17:59 +0000 (13:17 +0000)]
Improve N OF CASES documentation.
John Darrington [Tue, 10 Jul 2007 07:40:02 +0000 (07:40 +0000)]
Enabled deletion of cases from the datasheet.
John Darrington [Tue, 10 Jul 2007 06:38:09 +0000 (06:38 +0000)]
Removed restructure menuitem, since it's unlikely to be implemented in
the near future.
Jason Stover [Tue, 10 Jul 2007 04:01:00 +0000 (04:01 +0000)]
initial version of glm
Jason Stover [Tue, 10 Jul 2007 03:17:49 +0000 (03:17 +0000)]
fixed export bug
John Darrington [Mon, 9 Jul 2007 11:31:17 +0000 (11:31 +0000)]
Prevent crash when attempting to insert cases when dictionary is empty.
John Darrington [Mon, 9 Jul 2007 05:21:12 +0000 (05:21 +0000)]
Implemented the "Insert Case" button and menuitem.
John Darrington [Sun, 8 Jul 2007 11:13:54 +0000 (11:13 +0000)]
Removed visibility from recent file menuitems, if recent managers aren't
available.
John Darrington [Sun, 8 Jul 2007 10:49:29 +0000 (10:49 +0000)]
Used type casenumber in GUI code where appropriate. Also, generally
stricter type allocations.
John Darrington [Sun, 8 Jul 2007 06:13:06 +0000 (06:13 +0000)]
Set type hints for older gtk versions
John Darrington [Sun, 8 Jul 2007 02:39:10 +0000 (02:39 +0000)]
Implemented the goto-case dialog
John Darrington [Sat, 7 Jul 2007 12:42:02 +0000 (12:42 +0000)]
Added appropriate window_type_hint to the splash window.
John Darrington [Sat, 7 Jul 2007 09:23:52 +0000 (09:23 +0000)]
Implemented "type & label" subdialog on compute.
John Darrington [Sat, 7 Jul 2007 07:34:19 +0000 (07:34 +0000)]
Made cell reference label take proper offset.
Ben Pfaff [Sat, 7 Jul 2007 06:30:03 +0000 (06:30 +0000)]
(legal): Update startup notice to use format recommended by latest GNU
coding standards.
Ben Pfaff [Sat, 7 Jul 2007 06:14:04 +0000 (06:14 +0000)]
Change license from GPLv2+ to GPLv3+.
John Darrington [Sat, 7 Jul 2007 02:12:41 +0000 (02:12 +0000)]
Made the datasheet number cases from 1 instead of zero.
John Darrington [Sat, 7 Jul 2007 01:52:44 +0000 (01:52 +0000)]
Added a tooltip like feature to display variables' labels when the mouse hovers
over a column title in the datasheet.
John Darrington [Thu, 5 Jul 2007 04:00:12 +0000 (04:00 +0000)]
Get rid of unused function.
John Darrington [Wed, 4 Jul 2007 10:37:49 +0000 (10:37 +0000)]
Make sure that width entry widget shows.
John Darrington [Wed, 4 Jul 2007 05:22:51 +0000 (05:22 +0000)]
Fixed bug updating cell ref and datum entry widgets
John Darrington [Wed, 4 Jul 2007 03:21:29 +0000 (03:21 +0000)]
Enabled the insert-variable button
John Darrington [Tue, 3 Jul 2007 05:49:53 +0000 (05:49 +0000)]
Removed some gtksheet features that were causing problems for us when
autoscrolling the datasheet.
Ben Pfaff [Sun, 1 Jul 2007 15:26:46 +0000 (15:26 +0000)]
Fix speling error.
John Darrington [Sun, 1 Jul 2007 03:17:05 +0000 (03:17 +0000)]
Changed trns_chain_execute signature (Patch #6057)
John Darrington [Sun, 1 Jul 2007 00:16:53 +0000 (00:16 +0000)]
Removed visibility from those toolbar buttons whose actions are
unimplemented and aren't likely to be in the near future.
Ben Pfaff [Sat, 30 Jun 2007 15:45:39 +0000 (15:45 +0000)]
Ignore quilt-related files and another libtool file.
John Darrington [Fri, 29 Jun 2007 05:14:32 +0000 (05:14 +0000)]
(Re)enabled cell reference entry and datum entry widgets.
John Darrington [Fri, 29 Jun 2007 00:52:03 +0000 (00:52 +0000)]
Re-enabled updates in the cell reference entry box.
John Darrington [Thu, 28 Jun 2007 05:02:38 +0000 (05:02 +0000)]
Removed some gtksheet features that psppire is never likely to use.
Results in much faster rendering!
John Darrington [Thu, 28 Jun 2007 04:42:25 +0000 (04:42 +0000)]
More whitespace changes. Thanks to Ben for pointing out prior errors.
John Darrington [Thu, 28 Jun 2007 02:38:32 +0000 (02:38 +0000)]
Changes to whitespace, formatting and removed some commented out code.
Ben Pfaff [Thu, 21 Jun 2007 15:47:43 +0000 (15:47 +0000)]
Improve comment.
John Darrington [Fri, 15 Jun 2007 01:24:28 +0000 (01:24 +0000)]
Fixed procedure execution in GUI.
Ben Pfaff [Thu, 14 Jun 2007 14:21:23 +0000 (14:21 +0000)]
Use xmalloca instead of xallocsa due to module renaming.
Update all uses.
John Darrington [Tue, 12 Jun 2007 01:59:00 +0000 (01:59 +0000)]
Improved the encapsulation of PsppireCaseFile
Ben Pfaff [Mon, 11 Jun 2007 04:15:48 +0000 (04:15 +0000)]
Oops, forgot a file.
Ben Pfaff [Mon, 11 Jun 2007 04:03:19 +0000 (04:03 +0000)]
Add lots of comments. Some minor substantive changes too:
* casereader-filter.c (casereader_filter_destroy): Make sure to
write all the remaining excluded cases to the casewriter, if any.
* caseinit.c (init_list_destroy): Rewrite.
(init_list_clear): Ditto.
* casegrouper.c (casegrouper_get_next_group): Always set *reader
to null when returning false.