John Darrington [Thu, 4 Dec 2008 02:38:08 +0000 (11:38 +0900)]
Allow variables to be entered beyond the end of sheet.
Several changes to fix the problem where variables beyond
the vertical size of the var sheet couldn't be added.
1. Undo the effect of commit
8c9fae384585163197685e684e62e49a6b922f0c
since it seems to cause problems and need to be rethought.
2. On the traverse callback, don't clamp the range of the requested
destination cell. Clamp it only after the signal returns.
3. Add one more row than there are variables.
John Darrington [Thu, 4 Dec 2008 00:21:55 +0000 (09:21 +0900)]
Remove {rows,columns}_resizeable function
John Darrington [Thu, 4 Dec 2008 00:14:35 +0000 (09:14 +0900)]
Merge branch 'master' into rewrite-sheet
Conflicts:
src/ui/gui/psppire-case-file.c
src/ui/gui/psppire-case-file.h
John Darrington [Wed, 3 Dec 2008 23:46:36 +0000 (08:46 +0900)]
Use value_compare_3way instead of compare_values_short in find dialog
John Darrington [Wed, 3 Dec 2008 23:31:22 +0000 (08:31 +0900)]
Remove unused sheetmodel function
Ben Pfaff [Tue, 18 Nov 2008 05:36:41 +0000 (21:36 -0800)]
Implement ADD FILES and UPDATE.
Ben Pfaff [Sun, 30 Nov 2008 23:23:20 +0000 (15:23 -0800)]
Replace case_ordering with subcase.
The case_ordering data structure was useful for comparing cases,
but that is all that it did. In fact, the same data structure
can be used, at least, for extracting data from cases into arrays
of values, stuffing values back into cases, and for more general
comparisons than case_ordering anticipated.
This commit adds those abilities to case_ordering. It also renames
it to "subcase", because it is useful for more than just sorting
cases, which is all that case_ordering was designed for.
This commit also changes the allocation pattern for subcase from
having the implementation allocate all of the memory, to having
the subcase client allocate "struct subcase". This saves a
memory allocation without making life harder for anyone.
- Naming: the "case_ordering" name implied that it was
only useful for ordering (comparing cases).
- Interface: the interface
Ben Pfaff [Sun, 12 Oct 2008 22:04:09 +0000 (15:04 -0700)]
Break get.c up into multiple files in a logical fashion.
get.c implemented GET, IMPORT, SAVE, XSAVE, EXPORT, XEXPORT,
and MATCH FILES, which seems like too much for one file.
Ben Pfaff [Wed, 29 Oct 2008 13:33:56 +0000 (06:33 -0700)]
Allow MATCH FILES before an active file has been defined.
Except when it has the active file as an input, MATCH FILES does
not require an active file, and produces an active file, so it
makes sense to allow it anywhere.
Thanks to John Darrington for pointing out the bug.
Ben Pfaff [Sun, 30 Nov 2008 23:26:43 +0000 (15:26 -0800)]
Rename compare_values, hash_values with "_short" suffix.
The compare_values and hash_values functions do not compare an
entire value. Rather, they compare only the short string prefix
of long string values. I have a feeling that this misnaming was
confusing people (it certainly confused me) so this commit renames
them.
It also adds a new function value_compare_3way() that does what
one what expect such a function to do.
John Darrington [Wed, 3 Dec 2008 01:27:34 +0000 (10:27 +0900)]
Keep adjustment values in their relative positions on resizing sheet
John Darrington [Tue, 2 Dec 2008 23:48:55 +0000 (08:48 +0900)]
Only grab the focus when appropriate
John Darrington [Tue, 2 Dec 2008 11:07:43 +0000 (20:07 +0900)]
Whitespace change
John Darrington [Tue, 2 Dec 2008 10:03:12 +0000 (19:03 +0900)]
Remove extraneous code moving sheet adjustments on updates
John Darrington [Tue, 2 Dec 2008 09:40:30 +0000 (18:40 +0900)]
Add range_changed callbacks as appropriate
John Darrington [Tue, 2 Dec 2008 04:42:06 +0000 (13:42 +0900)]
Update model on inserting/deleting cases
John Darrington [Tue, 2 Dec 2008 04:10:09 +0000 (13:10 +0900)]
Added static qualifier
John Darrington [Tue, 2 Dec 2008 03:24:39 +0000 (12:24 +0900)]
Add handlers for inserting/deleteing cases
John Darrington [Tue, 2 Dec 2008 01:58:52 +0000 (10:58 +0900)]
Destroy datasheet, but not if we've made a reader of it
John Darrington [Tue, 2 Dec 2008 01:42:49 +0000 (10:42 +0900)]
Deleted psppire-case-file.[ch]
This module was nothing more than a wrapper around
src/data/datasheet.c Moved its guts into
psppire-data-store.c
John Darrington [Mon, 1 Dec 2008 12:50:16 +0000 (21:50 +0900)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
John Darrington [Mon, 1 Dec 2008 12:47:21 +0000 (21:47 +0900)]
Fixed some boundary conditions displaying row/column data
John Darrington [Mon, 1 Dec 2008 10:13:16 +0000 (19:13 +0900)]
Remove marshaller from helper.c and use a generated one instead
John Darrington [Mon, 1 Dec 2008 10:04:44 +0000 (19:04 +0900)]
Removed an unsed variable and used an unused macro
John Darrington [Mon, 1 Dec 2008 10:00:58 +0000 (19:00 +0900)]
Deleted some superflous nonsense
John Darrington [Mon, 1 Dec 2008 09:55:45 +0000 (18:55 +0900)]
Replaced extern "C" with G_BEGIN_DECLS
John Darrington [Mon, 1 Dec 2008 09:44:50 +0000 (18:44 +0900)]
Remove flicker drawing cell ranges
John Darrington [Mon, 1 Dec 2008 09:35:16 +0000 (18:35 +0900)]
Merge branch 'rewrite-sheet' of ssh://jmd@git.sv.gnu.org/srv/git/pspp into rewrite-sheet
Conflicts:
src/ui/gui/psppire-var-store.h
John Darrington [Mon, 1 Dec 2008 03:46:28 +0000 (12:46 +0900)]
Added popup menu to row titles in variable sheet
John Darrington [Mon, 1 Dec 2008 03:23:40 +0000 (12:23 +0900)]
Add cast to avoid warning
John Darrington [Mon, 1 Dec 2008 03:21:29 +0000 (12:21 +0900)]
Rename properties so as to be more specific
John Darrington [Mon, 1 Dec 2008 01:59:14 +0000 (10:59 +0900)]
Calculate the width of M based on the current font
John Darrington [Mon, 1 Dec 2008 01:29:26 +0000 (10:29 +0900)]
Remove unused variable
John Darrington [Mon, 1 Dec 2008 01:07:48 +0000 (10:07 +0900)]
Remove font information from cell attributes and sheet model.
Deleted the font_desc member from the GtkSheetCellAttr struct
and also all font related stuff from the GSheetModel interface.
Instead, fonts are now considered strictly a parameter of the
viewing widget instead of data in the model.
Ben Pfaff [Tue, 25 Nov 2008 06:12:01 +0000 (22:12 -0800)]
Fix memory leak in get_system_decimal().
Ben Pfaff [Wed, 29 Oct 2008 13:32:04 +0000 (06:32 -0700)]
Add PKG_CHECK_MODULES to forbidden m4 patterns.
This should help to catch running autoconf on systems that lack
pkg-config earlier in the build process.
John Darrington [Sun, 30 Nov 2008 07:53:56 +0000 (16:53 +0900)]
Remove unused property from var-sheet
John Darrington [Sun, 30 Nov 2008 05:46:24 +0000 (14:46 +0900)]
Add mutual links to VARIABLE/DATAFILE ATTRIBUTE documentation
John Darrington [Sun, 30 Nov 2008 04:08:56 +0000 (13:08 +0900)]
When adding variables in varsheet, add at the current position.
Previously variables could only be inserted at the start of the dictionary.
Fixes bug #24502
John Darrington [Sun, 30 Nov 2008 03:06:40 +0000 (12:06 +0900)]
Fixed problem when double clicking on column header
John Darrington [Sun, 30 Nov 2008 02:27:30 +0000 (11:27 +0900)]
Improve drawing of active cell border
John Darrington [Sat, 29 Nov 2008 03:03:13 +0000 (12:03 +0900)]
Make close button grab the focus on popup
John Darrington [Sat, 29 Nov 2008 01:37:20 +0000 (10:37 +0900)]
Improve useability of value label dialog.
Make the value entry widget grab the keyboard focus whenever
the dialog is updated, and on showing the dialog. Fixes
bug #24929
John Darrington [Sat, 29 Nov 2008 00:21:54 +0000 (09:21 +0900)]
Fixed crash when scrolling
John Darrington [Fri, 28 Nov 2008 23:46:10 +0000 (08:46 +0900)]
Fixed bug redrawing row/column title windows
John Darrington [Fri, 28 Nov 2008 22:35:54 +0000 (07:35 +0900)]
Dont try to draw cells outside the valid range
John Darrington [Fri, 28 Nov 2008 07:32:13 +0000 (16:32 +0900)]
Fix problem redrawing old active cell
John Darrington [Fri, 28 Nov 2008 06:55:21 +0000 (15:55 +0900)]
Draw active cell on adjustment changes
John Darrington [Fri, 28 Nov 2008 06:43:58 +0000 (15:43 +0900)]
Fixed problem displaying the active cell.
John Darrington [Fri, 28 Nov 2008 05:48:13 +0000 (14:48 +0900)]
Removed unsed is_visible from sheetmodel
John Darrington [Fri, 28 Nov 2008 05:41:22 +0000 (14:41 +0900)]
Remove unused auxvalues variable
John Darrington [Fri, 28 Nov 2008 00:47:10 +0000 (09:47 +0900)]
Removed internal_allocation member which was assigned but never used
John Darrington [Fri, 28 Nov 2008 00:40:59 +0000 (09:40 +0900)]
Made the active cell border a lot more noticeable
John Darrington [Thu, 27 Nov 2008 10:51:03 +0000 (19:51 +0900)]
Use BUILT_SOURCES to ensure that marshallers get built
John Darrington [Thu, 27 Nov 2008 09:16:20 +0000 (18:16 +0900)]
Merge branch 'rewrite-sheet' of ssh://jmd@git.sv.gnu.org/srv/git/pspp into rewrite-sheet
John Darrington [Thu, 27 Nov 2008 06:13:54 +0000 (15:13 +0900)]
Removed condition which was always true
John Darrington [Thu, 27 Nov 2008 03:43:26 +0000 (12:43 +0900)]
Disabled sheet entry for non-editable cells
John Darrington [Thu, 27 Nov 2008 03:30:48 +0000 (12:30 +0900)]
Change return type of gtk_sheet_get_entry and removed an unused function.
John Darrington [Thu, 27 Nov 2008 02:37:59 +0000 (11:37 +0900)]
Remove sheet_container member which served no useful purpose
John Darrington [Thu, 27 Nov 2008 00:59:27 +0000 (09:59 +0900)]
Remove [hv]geo arguments to gtksheet which no longer do anything
John Darrington [Thu, 27 Nov 2008 00:53:34 +0000 (09:53 +0900)]
Removed reference to row-geometry property which no longer exists
John Darrington [Thu, 27 Nov 2008 00:47:34 +0000 (09:47 +0900)]
Added g_return_if_fail to new methods
John Darrington [Wed, 26 Nov 2008 13:10:33 +0000 (22:10 +0900)]
Added extra include path necessary when building outside the source dir
John Darrington [Wed, 26 Nov 2008 12:31:52 +0000 (21:31 +0900)]
Generate marshaller functions instead of using prebuilt ones.
Use the glib-genmarshal program (distributed with glib) to
build the marshaller functions that came with gtkxpaned and
gtksheet.
John Darrington [Wed, 26 Nov 2008 10:16:20 +0000 (19:16 +0900)]
Remove obscure pango_font_description munging which caused criticals
John Darrington [Wed, 26 Nov 2008 04:43:40 +0000 (13:43 +0900)]
Oops
John Darrington [Wed, 26 Nov 2008 04:28:36 +0000 (13:28 +0900)]
Merge branch 'rewrite-sheet' of ssh://jmd@git.sv.gnu.org/srv/git/pspp into rewrite-sheet
Conflicts:
lib/gtksheet/automake.mk
John Darrington [Wed, 26 Nov 2008 04:21:38 +0000 (13:21 +0900)]
Remove the gsheet-row-* modules and replaced with psppire-axis-*
John Darrington [Tue, 25 Nov 2008 22:40:40 +0000 (07:40 +0900)]
Remove gtkextrafeatures.h from file manifest
John Darrington [Tue, 25 Nov 2008 01:51:38 +0000 (10:51 +0900)]
Set the minimum-extent property from the size_allocate handler of the sheet
John Darrington [Tue, 25 Nov 2008 01:14:27 +0000 (10:14 +0900)]
Fixed minor bug getting the extent of the last unit
John Darrington [Tue, 25 Nov 2008 01:01:48 +0000 (10:01 +0900)]
Added "min-extent" and "default-size" properties.
Before rows/columns have been added, which are sufficient to
cover "min-extent", there will be implicit rows/columns of "default-size".
John Darrington [Mon, 24 Nov 2008 13:45:20 +0000 (22:45 +0900)]
Fix problem inserting variables at end of var sheet
John Darrington [Mon, 24 Nov 2008 13:16:02 +0000 (22:16 +0900)]
Merge branch 'rewrite-sheet' of ssh://jmd@git.sv.gnu.org/srv/git/pspp into rewrite-sheet
Conflicts:
lib/gtksheet/gtksheet.c
John Darrington [Mon, 24 Nov 2008 06:50:34 +0000 (15:50 +0900)]
Don't redraw buttons in size_allocate callback
I've no idea why this was here but it is clearly wrong, and
caused lots of annoying flicker.
John Darrington [Mon, 24 Nov 2008 04:52:54 +0000 (13:52 +0900)]
Removed the STRING_WIDTH function
John Darrington [Mon, 24 Nov 2008 04:43:08 +0000 (13:43 +0900)]
Removed feature relating to multiline column button labels which we never use
John Darrington [Mon, 24 Nov 2008 04:33:32 +0000 (13:33 +0900)]
Removed the autoresize-column feature which was unused
John Darrington [Mon, 24 Nov 2008 04:10:41 +0000 (13:10 +0900)]
Remove flicker when redrawing row/column titles
John Darrington [Sun, 23 Nov 2008 08:07:33 +0000 (17:07 +0900)]
Replace gsheet-column interface by psppire-axis
Created a new object psppire-axis, which is a thinish
wrapper around src/libpspp/tower.c, and can be used
to maintain the positions and widths of rows/columns
in the data/variable sheets.
This change also deletes the lib/gtksheet/*-column-*
modules, and uses a psppire-axis in their place.
Some functions previously performed by gsheet-column-iface
have been moved to gsheetmodel.
This change doesn't touch lib/gtksheet/*-row-* but it
will be straightforward to replace that too.
John Darrington [Sun, 23 Nov 2008 01:46:37 +0000 (10:46 +0900)]
Ben's patches to tower.[ch]
John Darrington [Sat, 22 Nov 2008 07:16:28 +0000 (16:16 +0900)]
Fix crash
John Darrington [Sat, 22 Nov 2008 07:09:20 +0000 (16:09 +0900)]
Remove unused signal
John Darrington [Sat, 22 Nov 2008 07:07:16 +0000 (16:07 +0900)]
Change traverse signal to take GtkSheetCell instead of gint,gint
John Darrington [Sat, 22 Nov 2008 05:21:13 +0000 (14:21 +0900)]
Remove inline qualifiers
John Darrington [Sat, 22 Nov 2008 02:26:32 +0000 (11:26 +0900)]
Removed function default_row_height
Jason H Stover [Fri, 21 Nov 2008 15:48:57 +0000 (10:48 -0500)]
pspp_linreg_with_cov: Accept struct covariance_matrix as first argument.
rearrange_covariance_matrix: Accept struct covariance_matrix as
first argument.
John Darrington [Fri, 21 Nov 2008 10:31:34 +0000 (19:31 +0900)]
Avoid annoying double line at beginning of rows/columns
John Darrington [Fri, 21 Nov 2008 10:15:35 +0000 (19:15 +0900)]
Avoid critical when renewing dataset
John Darrington [Fri, 21 Nov 2008 10:01:33 +0000 (19:01 +0900)]
Remove gtk_sheet_move_query function
John Darrington [Fri, 21 Nov 2008 09:08:39 +0000 (18:08 +0900)]
Avoid runtime warning
John Darrington [Fri, 21 Nov 2008 06:10:40 +0000 (15:10 +0900)]
Block entry change handler whilst traversing cells
Prevent the "changed" signal from invoking a handler
whilst the cells are changing. This sometimes resulted
in data erroneously getting entered into the new cell.
John Darrington [Fri, 21 Nov 2008 05:29:30 +0000 (14:29 +0900)]
Prevent double-click signal from being emitted when the row/column is insensitive
John Darrington [Fri, 21 Nov 2008 05:20:49 +0000 (14:20 +0900)]
Prevent traversing to cells for which there is no variable
John Darrington [Thu, 20 Nov 2008 23:23:08 +0000 (08:23 +0900)]
Prevent sheet from stepping outside its valid cell range.
John Darrington [Thu, 20 Nov 2008 11:42:07 +0000 (20:42 +0900)]
Fixed the scrolling of the sheet when the active cell changes.
John Darrington [Thu, 20 Nov 2008 04:34:15 +0000 (13:34 +0900)]
Improved behaviour of arrow keys
John Darrington [Thu, 20 Nov 2008 03:01:40 +0000 (12:01 +0900)]
Rename functions
John Darrington [Thu, 20 Nov 2008 02:57:54 +0000 (11:57 +0900)]
Removed unused return value from cell activation features
John Darrington [Thu, 20 Nov 2008 01:49:23 +0000 (10:49 +0900)]
Improve the behaviour of the moveto function