pspp-builds.git
17 years ago * file-name.c (fn_search_path): Remove prefix arg that was unused
Ben Pfaff [Sun, 10 Dec 2006 04:08:47 +0000 (04:08 +0000)]
* file-name.c (fn_search_path): Remove prefix arg that was unused
by any caller.  Updated all callers.

17 years ago * format.c (fmt_dollar_template): Use user's decimal point
Ben Pfaff [Sun, 10 Dec 2006 04:04:38 +0000 (04:04 +0000)]
* format.c (fmt_dollar_template): Use user's decimal point
character.  Add assertion.

17 years agoNew function fmt_dollar_template based on pspp-dev discussion.
Ben Pfaff [Sun, 10 Dec 2006 04:03:34 +0000 (04:03 +0000)]
New function fmt_dollar_template based on pspp-dev discussion.

17 years agoFinish converting struct variable to an opaque type. In this
Ben Pfaff [Sun, 10 Dec 2006 03:42:50 +0000 (03:42 +0000)]
Finish converting struct variable to an opaque type. In this
phase, we add remaining setter and getter functions, convert the
remaining PSPP code to use them, and do a bunch of cleanup. The
resulting changes are pervasive but mostly trivial, and only the
notable changes are logged.

This is patch #5629 on Savannah.

17 years agoAvoided comparison of string variables to SYSMIS
John Darrington [Sun, 10 Dec 2006 02:33:43 +0000 (02:33 +0000)]
Avoided comparison of string variables to SYSMIS

17 years agoIgnore cscope files.
Ben Pfaff [Sun, 10 Dec 2006 01:20:55 +0000 (01:20 +0000)]
Ignore cscope files.

17 years agoMemory leak patrol and minor cleanups.
John Darrington [Fri, 8 Dec 2006 22:24:08 +0000 (22:24 +0000)]
Memory leak patrol and minor cleanups.

17 years agoUse gsl_finite from GSL, which is portable, instead of isfinite, which
Ben Pfaff [Fri, 8 Dec 2006 01:41:21 +0000 (01:41 +0000)]
Use gsl_finite from GSL, which is portable, instead of isfinite, which
is not.

17 years agoRemoved mutual dependency between libpspp and data
John Darrington [Thu, 7 Dec 2006 11:34:17 +0000 (11:34 +0000)]
Removed mutual dependency between libpspp and data

17 years agoAdded a syntax editor to the GUI.
John Darrington [Thu, 7 Dec 2006 11:10:23 +0000 (11:10 +0000)]
Added a syntax editor to the GUI.
It doesn't do anything yet --- it's just an editor.

17 years agoFixed memory leak.
John Darrington [Thu, 7 Dec 2006 07:09:06 +0000 (07:09 +0000)]
Fixed memory leak.

17 years agoChanged factors' independent variables to be copies on the heap.
John Darrington [Thu, 7 Dec 2006 06:31:04 +0000 (06:31 +0000)]
Changed factors' independent variables to be copies on the heap.
Fixes part of bug #15911.

17 years agoRemove blank page.
Ben Pfaff [Thu, 7 Dec 2006 05:41:11 +0000 (05:41 +0000)]
Remove blank page.

17 years agoCompare variable pointers instead of variable indexes.
Ben Pfaff [Thu, 7 Dec 2006 05:16:33 +0000 (05:16 +0000)]
Compare variable pointers instead of variable indexes.

17 years agoFirst step in making struct variable opaque: the boring mechanical
Ben Pfaff [Tue, 5 Dec 2006 15:10:21 +0000 (15:10 +0000)]
First step in making struct variable opaque: the boring mechanical
work of replacing most struct variable member accesses by use of
setter and getter functions.

17 years agoApplied patch #5611
John Darrington [Tue, 5 Dec 2006 11:27:42 +0000 (11:27 +0000)]
Applied patch  #5611

17 years ago * missing-values.c (mv_resize): Don't write beyond end of the
Ben Pfaff [Tue, 5 Dec 2006 05:39:29 +0000 (05:39 +0000)]
* missing-values.c (mv_resize): Don't write beyond end of the
allocated buffer when resizing a long string.

17 years agoFix lack of ->name and ->location in DO REPEAT's getl_interface.
Ben Pfaff [Sun, 3 Dec 2006 22:16:45 +0000 (22:16 +0000)]
Fix lack of ->name and ->location in DO REPEAT's getl_interface.
See bug #15702.

Significant cleanup to DO REPEAT.

17 years agoRemove redundant parentheses.
Ben Pfaff [Sat, 2 Dec 2006 06:45:25 +0000 (06:45 +0000)]
Remove redundant parentheses.

17 years ago * compute.c: Fix bug #17422, which reports that a variable created
Ben Pfaff [Fri, 1 Dec 2006 06:51:08 +0000 (06:51 +0000)]
* compute.c: Fix bug #17422, which reports that a variable created
by assignment in a COMPUTE command could not be used in the
computation expression.

17 years agoProperly handle empty DO REPEAT...END REPEAT block. Fixes bug #18407.
Ben Pfaff [Fri, 1 Dec 2006 06:45:52 +0000 (06:45 +0000)]
Properly handle empty DO REPEAT...END REPEAT block.  Fixes bug #18407.
Thanks to John Darrington for reporting this bug.

17 years ago * statistics.texi: Document charts supported by FREQUENCIES.
Ben Pfaff [Fri, 1 Dec 2006 06:21:05 +0000 (06:21 +0000)]
* statistics.texi: Document charts supported by FREQUENCIES.
Fixes bug #18297.  Thanks to Mohammed Babekir Elmalik Abdalmajid
for reporting this bug.

17 years ago * value-labels.c (get_label): Allow commas between values and
Ben Pfaff [Fri, 1 Dec 2006 06:06:52 +0000 (06:06 +0000)]
* value-labels.c (get_label): Allow commas between values and
labels and between value labels.  Fixes bug #18303.  Thanks to
John Darrington for reporting this bug.

17 years agoFix indentation.
Ben Pfaff [Fri, 1 Dec 2006 06:03:58 +0000 (06:03 +0000)]
Fix indentation.

17 years agoProperly handle empty DO REPEAT...END REPEAT block. Fixes bug #18407.
Ben Pfaff [Fri, 1 Dec 2006 06:02:35 +0000 (06:02 +0000)]
Properly handle empty DO REPEAT...END REPEAT block.  Fixes bug #18407.
Thanks to John Darrington for reporting this bug.

17 years ago * inpt-pgm.c (cmd_reread): Always return error code upon detecting
Ben Pfaff [Fri, 1 Dec 2006 05:52:59 +0000 (05:52 +0000)]
* inpt-pgm.c (cmd_reread): Always return error code upon detecting
syntax error.  Fixes bug #18419.  Thanks to John Darrington for
reporting this bug.

17 years agodeleted some commented out code.
John Darrington [Thu, 30 Nov 2006 10:39:00 +0000 (10:39 +0000)]
deleted some commented out code.

17 years agoOops. committing new files
John Darrington [Wed, 29 Nov 2006 12:19:07 +0000 (12:19 +0000)]
Oops.  committing new files

17 years agoApplying patch #5562
John Darrington [Wed, 29 Nov 2006 11:50:31 +0000 (11:50 +0000)]
Applying patch #5562

17 years agoFixed make distcheck
John Darrington [Wed, 29 Nov 2006 02:15:00 +0000 (02:15 +0000)]
Fixed make distcheck

18 years agoFixed documentation problems
John Darrington [Tue, 28 Nov 2006 09:39:37 +0000 (09:39 +0000)]
Fixed documentation problems

18 years agoAdd note about Texinfo.
Ben Pfaff [Mon, 27 Nov 2006 01:09:45 +0000 (01:09 +0000)]
Add note about Texinfo.

18 years agoFix some table formatting.
Ben Pfaff [Sun, 26 Nov 2006 17:00:54 +0000 (17:00 +0000)]
Fix some table formatting.
Thanks to John Darrington for pointing out the problem.

18 years agoList Texinfo 4.7 or later as optional.
Ben Pfaff [Sun, 26 Nov 2006 02:59:11 +0000 (02:59 +0000)]
List Texinfo 4.7 or later as optional.

18 years agoWe've had a mix of min, max from libpspp/misc.h and MIN, MAX from
Ben Pfaff [Sat, 25 Nov 2006 02:15:00 +0000 (02:15 +0000)]
We've had a mix of min, max from libpspp/misc.h and MIN, MAX from
gnulib's minmax.h thus far. This change replaces all instances of the
former by the latter.

18 years agoAdded whitespace and plugged memory leak.
John Darrington [Sat, 25 Nov 2006 00:42:44 +0000 (00:42 +0000)]
Added whitespace and plugged memory leak.

18 years agoFix race condition in tests/bugs/signals.sh.
Ben Pfaff [Wed, 22 Nov 2006 14:28:24 +0000 (14:28 +0000)]
Fix race condition in tests/bugs/signals.sh.

18 years agoHOST command needs F_KEEP_FINAL_TOKEN.
Ben Pfaff [Wed, 22 Nov 2006 14:27:16 +0000 (14:27 +0000)]
HOST command needs F_KEEP_FINAL_TOKEN.

18 years agoRewrite formatted data input routines to conform to SPSS data formats
Ben Pfaff [Wed, 22 Nov 2006 04:24:02 +0000 (04:24 +0000)]
Rewrite formatted data input routines to conform to SPSS data formats
as closely as possible

18 years agoFix grammar in comment.
Ben Pfaff [Sun, 19 Nov 2006 03:44:10 +0000 (03:44 +0000)]
Fix grammar in comment.

18 years agoReplace several similar lines by one line inside DO REPEAT.
Ben Pfaff [Sat, 18 Nov 2006 03:32:54 +0000 (03:32 +0000)]
Replace several similar lines by one line inside DO REPEAT.

18 years agoApply patch #5561. Connect debugger on error.
John Darrington [Thu, 16 Nov 2006 12:47:22 +0000 (12:47 +0000)]
Apply patch #5561. Connect debugger on error.

18 years agoFixed bug which crept in with the recent lexer changes.
John Darrington [Tue, 14 Nov 2006 12:29:25 +0000 (12:29 +0000)]
Fixed bug which crept in with the recent lexer changes.
Added regression test to check for this bug.

18 years agoPlugged some small memory leaks
John Darrington [Tue, 14 Nov 2006 11:47:17 +0000 (11:47 +0000)]
Plugged some small memory leaks

18 years agoEncapsulated lexer and updated calling functions accordingly.
John Darrington [Sat, 11 Nov 2006 23:10:00 +0000 (23:10 +0000)]
Encapsulated lexer and updated calling functions accordingly.

18 years agoFix buffer overflow reported by John Darrington.
Ben Pfaff [Sat, 11 Nov 2006 19:43:33 +0000 (19:43 +0000)]
Fix buffer overflow reported by John Darrington.

18 years agoImplement SKIP keyword on DATA LIST. Fixes bug #17099.
Ben Pfaff [Sat, 11 Nov 2006 19:30:59 +0000 (19:30 +0000)]
Implement SKIP keyword on DATA LIST.  Fixes bug #17099.

18 years agoCommitted patch #5524, which allows the message destination to be
John Darrington [Tue, 7 Nov 2006 12:59:59 +0000 (12:59 +0000)]
Committed patch #5524, which allows the message destination to be
set on the command line.

18 years agoRewrite and improve formatted output routines.
Ben Pfaff [Sun, 5 Nov 2006 05:20:52 +0000 (05:20 +0000)]
Rewrite and improve formatted output routines.
Add lots of regression tests.
Revise documentation.
Thanks to John Darrington for review--see patch #5522.

18 years agoAdded casefilter structure to assist with missing values. Changed T-TEST
John Darrington [Sun, 5 Nov 2006 00:35:43 +0000 (00:35 +0000)]
Added casefilter structure to assist with missing values.  Changed T-TEST
and ONEWAY commands to use it.

18 years ago * msg-ui.c (handle_msg): Only write message to terminal if
Ben Pfaff [Sat, 4 Nov 2006 23:49:35 +0000 (23:49 +0000)]
* msg-ui.c (handle_msg): Only write message to terminal if
get_error_routing_to_terminal() returns true.

18 years agoImplement SET ERRORS, SHOW ERRORS.
Ben Pfaff [Sat, 4 Nov 2006 19:49:45 +0000 (19:49 +0000)]
Implement SET ERRORS, SHOW ERRORS.

18 years agoUpdated the docs and the parser for EXAMINE to make it clearer which options
John Darrington [Fri, 3 Nov 2006 09:54:15 +0000 (09:54 +0000)]
Updated the docs and the parser for EXAMINE to make it clearer which options
are currently supported and which are not.

18 years agoCompletely rewrite src/data/format.[ch], to achieve better
Ben Pfaff [Fri, 3 Nov 2006 04:53:51 +0000 (04:53 +0000)]
Completely rewrite src/data/format.[ch], to achieve better
abstraction.  Rewrite all references to formats in other files.
See patch #5511.

18 years ago * sys-file-info.c: (cmd_display) Use compare_var_ptr_names to
Ben Pfaff [Thu, 2 Nov 2006 04:51:41 +0000 (04:51 +0000)]
* sys-file-info.c: (cmd_display) Use compare_var_ptr_names to
compare "struct variable **"s, not compare_var_names.  Fixes bug
#17423.

18 years agoRemove num_to_string() function, because it is not used anywhere.
Ben Pfaff [Wed, 1 Nov 2006 03:36:09 +0000 (03:36 +0000)]
Remove num_to_string() function, because it is not used anywhere.

18 years agoTue Oct 31 19:29:05 2006 Ben Pfaff <blp@gnu.org>
Ben Pfaff [Wed, 1 Nov 2006 03:33:01 +0000 (03:33 +0000)]
Tue Oct 31 19:29:05 2006  Ben Pfaff  <blp@gnu.org>

* configure.ac: Drop tests for strchr, strrchr because now we
assume a C89 compliant library.  (Gnulib makes this assumption so
we might as well too.)

18 years agoAdd missing "#include <config.h>".
Ben Pfaff [Wed, 1 Nov 2006 03:25:36 +0000 (03:25 +0000)]
Add missing "#include <config.h>".

18 years agoTue Oct 31 18:21:48 2006 Ben Pfaff <blp@gnu.org>
Ben Pfaff [Wed, 1 Nov 2006 02:22:35 +0000 (02:22 +0000)]
Tue Oct 31 18:21:48 2006  Ben Pfaff  <blp@gnu.org>

* print-space.c (print_space_trns_proc): Let dfm_put_record add
the new-line character, to match dfm_put_record change below.

18 years agoFix error messages and comment.
Ben Pfaff [Wed, 1 Nov 2006 02:12:25 +0000 (02:12 +0000)]
Fix error messages and comment.

18 years agoSun Oct 29 14:08:53 2006 Ben Pfaff <blp@gnu.org>
Ben Pfaff [Sun, 29 Oct 2006 22:09:41 +0000 (22:09 +0000)]
Sun Oct 29 14:08:53 2006  Ben Pfaff  <blp@gnu.org>

* Smake (GNULIB_MODULES): Remove `restrict' from modules, because
recent gnulib doesn't have such a module.

18 years agoReduce verbosity of ll-test, llx-test output.
Ben Pfaff [Sun, 29 Oct 2006 22:04:09 +0000 (22:04 +0000)]
Reduce verbosity of ll-test, llx-test output.

18 years agoMore constness
John Darrington [Sun, 29 Oct 2006 11:16:07 +0000 (11:16 +0000)]
More constness

18 years agoMade array.h const correct, and dealt with the consequences.
John Darrington [Sun, 29 Oct 2006 09:51:35 +0000 (09:51 +0000)]
Made array.h const correct, and dealt with the consequences.

18 years agoChange some aspects of the PRINT, PRINT EJECT, and WRITE
Ben Pfaff [Sun, 29 Oct 2006 00:01:52 +0000 (00:01 +0000)]
Change some aspects of the PRINT, PRINT EJECT, and WRITE
transformations to more closely match SPSS behavior:

- PRINT puts spaces between variables, unless a format is specified
explicitly.

- WRITE doesn't put space between variables.

- PRINT to an external file prefixes each line with a space.

- PRINT EJECT to an external file indicates a formfeed by a "1" in the
first column.

- WRITE writes out spaces for system-missing values, not a period.

- When no output is specified, an empty record is output.

Also, update documentation and tests to match this behavior.

18 years agoEliminated global variable getl_buf
John Darrington [Sat, 28 Oct 2006 08:31:22 +0000 (08:31 +0000)]
Eliminated global variable getl_buf

18 years agoAdd routines for integer byte order conversions, floating point format
Ben Pfaff [Sat, 28 Oct 2006 04:01:54 +0000 (04:01 +0000)]
Add routines for integer byte order conversions, floating point format
and byte order conversions, and ASCII<->EBCDIC conversion.  Also add
an extensive floating point format conversion test.

The ASCII<->EBCDIC conversion used by SPSS does not correspond exactly
to any found in GNU libiconv, hence the need for a separate library.

These routines are a small part of a larger change set that I'm
breaking up for gradual submission.  Thus, they aren't used by much
yet.

18 years agoDamn! Forgot to change casenum_t in *.q
John Darrington [Thu, 26 Oct 2006 06:29:10 +0000 (06:29 +0000)]
Damn!  Forgot to change casenum_t in *.q

18 years agoEliminated global variable current_dataset.
John Darrington [Thu, 26 Oct 2006 06:16:36 +0000 (06:16 +0000)]
Eliminated global variable current_dataset.
The dataset is now owned by main, and passed around by pointer.

18 years agoYet more constness
John Darrington [Wed, 25 Oct 2006 22:28:13 +0000 (22:28 +0000)]
Yet more constness

18 years agoMore constness/namespace policing
John Darrington [Sun, 22 Oct 2006 11:07:52 +0000 (11:07 +0000)]
More constness/namespace policing

18 years agoremoved useless code
Jason Stover [Fri, 20 Oct 2006 19:33:52 +0000 (19:33 +0000)]
removed useless code

18 years agoConstness and global namespace patrol.
John Darrington [Fri, 20 Oct 2006 11:32:56 +0000 (11:32 +0000)]
Constness and global namespace patrol.

18 years agoAdded some more UNIMPL entries.
John Darrington [Fri, 20 Oct 2006 03:00:25 +0000 (03:00 +0000)]
Added some more UNIMPL entries.

18 years agoEncapsulated the static data of procedure.[ch] into a single object, to be
John Darrington [Thu, 19 Oct 2006 15:04:52 +0000 (15:04 +0000)]
Encapsulated the static data of procedure.[ch] into a single object, to be
passed into its functions.  Dealt with the consequences.

18 years ago * command.c: (do_parse_command) Issue an error for unimplemented
Ben Pfaff [Mon, 16 Oct 2006 02:39:32 +0000 (02:39 +0000)]
* command.c: (do_parse_command) Issue an error for unimplemented
commands, instead of silently ignoring them.  Reported by John
Darrington.

18 years agoAdded a pooled version of hsh_create
John Darrington [Sun, 15 Oct 2006 01:51:02 +0000 (01:51 +0000)]
Added a pooled version of hsh_create

18 years ago * casefile.c (casereader_read_xfer): Always initialize the case,
Ben Pfaff [Sat, 14 Oct 2006 23:57:54 +0000 (23:57 +0000)]
* casefile.c (casereader_read_xfer): Always initialize the case,
even on an error condition.

18 years agoFix memory leak in rank_sorted_casefile().
Ben Pfaff [Sat, 14 Oct 2006 23:55:18 +0000 (23:55 +0000)]
Fix memory leak in rank_sorted_casefile().

18 years agoFix memory leak in test_casereader_clone().
Ben Pfaff [Sat, 14 Oct 2006 23:23:17 +0000 (23:23 +0000)]
Fix memory leak in test_casereader_clone().

18 years agoChanged a lot of ints to bools.
John Darrington [Sat, 14 Oct 2006 00:25:20 +0000 (00:25 +0000)]
Changed a lot of ints to bools.

18 years agoDISPLAY FILE LABEL is no longer undocumented.
Ben Pfaff [Sun, 8 Oct 2006 16:54:46 +0000 (16:54 +0000)]
DISPLAY FILE LABEL is no longer undocumented.

18 years agoMemory leak patrol.
John Darrington [Sun, 8 Oct 2006 01:49:15 +0000 (01:49 +0000)]
Memory leak patrol.

18 years agoImplemented the RANK command.
John Darrington [Sat, 7 Oct 2006 03:10:14 +0000 (03:10 +0000)]
Implemented the RANK command.

18 years agoFixed warnings generated by gcc 4.1.2
John Darrington [Wed, 27 Sep 2006 10:21:35 +0000 (10:21 +0000)]
Fixed warnings generated by gcc 4.1.2
Fixed bug in N OF CASES command which these warnings exposed.
Added a test for this bug (how many years had it gone unreported?)

18 years agoAdded casereader_clone function.
John Darrington [Mon, 25 Sep 2006 09:35:15 +0000 (09:35 +0000)]
Added casereader_clone function.
Introduced casenum_t type to enumerate and count cases.

18 years agoChanged int to bool in dict_get_weight and sort_active_file_in_place
John Darrington [Sat, 23 Sep 2006 00:15:58 +0000 (00:15 +0000)]
Changed int to bool in dict_get_weight and sort_active_file_in_place

18 years ago * variable.c: (width_to_bytes) Rephrase code for clarify.
Ben Pfaff [Thu, 21 Sep 2006 14:01:09 +0000 (14:01 +0000)]
* variable.c: (width_to_bytes) Rephrase code for clarify.

18 years agoFix "size" in flt64 info record description: it's always 8, not 4.
Ben Pfaff [Thu, 14 Sep 2006 04:52:27 +0000 (04:52 +0000)]
Fix "size" in flt64 info record description: it's always 8, not 4.

18 years agoActually, the startup syntax file *is* implemented.
Ben Pfaff [Tue, 22 Aug 2006 04:19:04 +0000 (04:19 +0000)]
Actually, the startup syntax file *is* implemented.

18 years agoError message needs a period at end of sentence.
Ben Pfaff [Mon, 14 Aug 2006 01:06:59 +0000 (01:06 +0000)]
Error message needs a period at end of sentence.

18 years agoFix bug #17329 in REREAD parsing, reported by John Darrington.
Ben Pfaff [Sat, 5 Aug 2006 15:28:12 +0000 (15:28 +0000)]
Fix bug #17329 in REREAD parsing, reported by John Darrington.

18 years agoNew PURE_FUNCTION, CONST_FUNCTION macros.
Ben Pfaff [Mon, 31 Jul 2006 22:50:01 +0000 (22:50 +0000)]
New PURE_FUNCTION, CONST_FUNCTION macros.

18 years agoAllow a comma between specifications on PRINT.
Ben Pfaff [Mon, 31 Jul 2006 17:32:55 +0000 (17:32 +0000)]
Allow a comma between specifications on PRINT.

18 years agoRe-enabled automatic insertion of cases in data sheet.
John Darrington [Sun, 30 Jul 2006 12:27:59 +0000 (12:27 +0000)]
Re-enabled automatic insertion of cases in data sheet.

18 years agoMade the variable sheet automatically add variables when clickes in a blank
John Darrington [Sat, 29 Jul 2006 09:37:18 +0000 (09:37 +0000)]
Made the variable sheet automatically add variables when clickes in a blank
row.

18 years agoFixed bug where psppire tried to save a file even after Cancel had been clicked.
John Darrington [Sat, 29 Jul 2006 08:49:59 +0000 (08:49 +0000)]
Fixed bug where psppire tried to save a file even after Cancel had been clicked.

18 years agoRe-enabled saving of the current file.
John Darrington [Sat, 29 Jul 2006 05:57:26 +0000 (05:57 +0000)]
Re-enabled saving of the current file.

18 years agoFixed bug where gui would crash when columns were resized.
John Darrington [Sun, 23 Jul 2006 10:32:50 +0000 (10:32 +0000)]
Fixed bug where gui would crash when columns were resized.

18 years agoPatch #5244.
Ben Pfaff [Tue, 18 Jul 2006 04:57:01 +0000 (04:57 +0000)]
Patch #5244.

This patch cleans up DATA LIST and PRINT in preparation for
re-implementing REPEATING DATA (bug #12859).  It reduces the code
duplication between DATA LIST and PRINT a great deal, actually
reducing the total code in PSPP by a couple hundred lines.  The result
should be more maintainable as well as easier to read.