Jason Stover [Fri, 17 Jul 2009 20:02:02 +0000 (16:02 -0400)]
pspp_linreg(): Use cache->n_coeffs to set the dimensions of sw, instead of
cache->n_indeps, which may give incorrect dimension in the case
of categorical variables. Fixes bug referenced in bug report
26861.
Ben Pfaff [Fri, 17 Jul 2009 03:36:20 +0000 (20:36 -0700)]
Release PSPP 0.6.2-pre5.
Ben Pfaff [Fri, 17 Jul 2009 03:58:51 +0000 (20:58 -0700)]
Fix reversed logic in when to append "/" to path in previous commit.
Ben Pfaff [Fri, 17 Jul 2009 03:48:18 +0000 (20:48 -0700)]
Fix failure to write output file in GUI on Windows when HOMEPATH is "\".
Thanks to Michel Boaventura for reporting this problem:
http://lists.gnu.org/archive/html/pspp-dev/2009-07/msg00064.html
Ben Pfaff [Fri, 17 Jul 2009 03:27:45 +0000 (20:27 -0700)]
REGRESSION: Fix access beyond end of allocated region.
From Jason Stover, with modification for stable since the
design_matrix_get_n_cols function does not exist on this branch.
Bug #26861.
Jason Stover [Sat, 11 Jul 2009 19:45:49 +0000 (15:45 -0400)]
Return 0.0 for mean of a categorical variable. Fixes bug mentioned in bug report 26861.
John Darrington [Wed, 15 Jul 2009 18:25:42 +0000 (02:25 +0800)]
Fixed bug reporting the significance of paired value t-test.
Due to a cut and paste error, the significance of paired
t-tests was wrong when the value of T was positive.
Thanks to Mike Griffiths for reporting this problem.
Ben Pfaff [Fri, 10 Jul 2009 03:13:16 +0000 (20:13 -0700)]
Use Harry Thijssen's real name instead of his nick "unknown-1", at his request.
Ben Pfaff [Thu, 9 Jul 2009 03:21:01 +0000 (20:21 -0700)]
Release PSPP 0.6.2-pre4.
Ben Pfaff [Thu, 9 Jul 2009 03:17:28 +0000 (20:17 -0700)]
Update to latest nl.po.
Thanks to unknown-1 and the coordinators at translationproject.org.
Ben Pfaff [Thu, 9 Jul 2009 03:12:11 +0000 (20:12 -0700)]
gui: Fix brown-paper-bag bug in output file name selection.
Thanks to michel@cecaps.ufmg.br for reporting the bug and the fix.
Ben Pfaff [Wed, 8 Jul 2009 02:44:20 +0000 (19:44 -0700)]
CROSSTABS: Handle long string variables without crashing (bug #26131).
Ben Pfaff [Fri, 3 Jul 2009 18:43:09 +0000 (11:43 -0700)]
Release PSPP 0.6.2-pre3.
Ben Pfaff [Fri, 3 Jul 2009 18:40:27 +0000 (11:40 -0700)]
Add Dutch translation.
Thanks to unknown-1 and the coordinators at translationproject.org.
Ben Pfaff [Fri, 3 Jul 2009 18:34:26 +0000 (11:34 -0700)]
Fix segfault drawing pie charts with old versions of libplot.
If chart_create returned null, we dereferenced a null pointer just below.
Avoid doing this.
Also add similar fixes to other code that calls chart_create. It may not
be necessary in every case.
Reported by Jason Stover.
Ben Pfaff [Fri, 3 Jul 2009 18:03:27 +0000 (11:03 -0700)]
Release PSPP 0.6.2-pre2.
John Darrington [Wed, 13 May 2009 22:48:17 +0000 (06:48 +0800)]
Correct default_output_path function on Windows.
John Darrington [Wed, 13 May 2009 22:54:56 +0000 (06:54 +0800)]
Ensure that windows opens the right file for output.
Thanks to Michel Boaventura for reporting this problem.
Fixes bug #26542
Ben Pfaff [Fri, 3 Jul 2009 17:48:26 +0000 (10:48 -0700)]
Relocate the locale directory.
Based on commit
31e674bbb in master, but stable refers to locale_dir from
different files.
Thanks to Michel Boaventura for reporting the problem.
Ben Pfaff [Thu, 2 Jul 2009 17:17:13 +0000 (10:17 -0700)]
Release PSPP 0.6.2 prerelease 1.
Ben Pfaff [Thu, 2 Jul 2009 03:56:17 +0000 (20:56 -0700)]
chart: Fix format string issues in draw_tick callers.
The 'label' argument to draw_tick is used as a printf-type format string,
so callers must pass "%s" to safely use an arbitrary string as a label.
Also, hist_draw_bar was doing its own snprintf, but this commit changes it
to take advantage of that provided by draw_tick.
Ben Pfaff [Thu, 2 Jul 2009 03:50:33 +0000 (20:50 -0700)]
chart: Fix format string issues in chart_write_title callers.
The 'title' argument to chart_write_title is used as a printf-type format
string, so callers must pass "%s" to safely use an arbitrary string as a
title.
Ben Pfaff [Thu, 18 Jun 2009 04:24:38 +0000 (21:24 -0700)]
sys-file-reader: Don't warn if compression bias field is 0.
Some software writes a value of 0 to the compression bias field. We
expect that this field has a value of 100 and warn if we see any other
value, but there is no real need to do so (because it is very likely
that we can read the file correctly in any case). So suppress the
warning if we see a value of 0 here, because it bothers users.
Thanks to Tony Reardon <tony@sir.com.au> for reporting this
unnecessary warning.
Ben Pfaff [Thu, 18 Jun 2009 04:11:10 +0000 (21:11 -0700)]
por-file-reader: Tolerate short lines when detecting portable files.
When the portable file reader reads a file, it assumes that a line
shorter than 80 bytes should actually be padded out on the right with
spaces, because this is a fairly common problem in practice, perhaps
due to text editors or other software that drops spaces at the end of
a line.
However, pfm_detect, the function that is supposed to detect whether
a given file is an SPSS portable file, did not apply this heuristic to
the data that it read at the beginning of the file, and thus files in
which the first few lines were truncated this way were not detected
properly as portable files.
This commit fixes the problem by making pfm_detect a little bit
smarter. It would probably be better to actually unify the
file-reading logic, instead of implementing it in two separate places,
but this appears to work adequately too.
Thanks to Tony Reardon <tony@sir.com.au> for reporting the problem
and supplying a file that demonstrated it.
Ben Pfaff [Tue, 12 May 2009 03:56:39 +0000 (20:56 -0700)]
data-parser: Treat " ," the same as ",".
The data parser (used e.g. by DATA LIST) was unintentionally treating
soft separators (e.g. white space) followed by a hard separator (e.g.
a comma) as an empty field, but in fact it should be treated as just a
single separator. This fixes it and adds a test.
Thanks to pascal barbedor <pbarbedor@gmail.com> for reporting the problem.
John Darrington [Sat, 9 May 2009 00:43:35 +0000 (08:43 +0800)]
Ensure that NUMERIC's format (if any) is a valid output format.
Thanks to Pascal Barbedor for reporting this problem.
John Darrington [Sat, 11 Apr 2009 07:18:39 +0000 (15:18 +0800)]
Change g_print to g_warning
John Darrington [Wed, 8 Apr 2009 08:20:22 +0000 (16:20 +0800)]
Use the replacement rename function from gnulib.
Use the gnulib replacement rename function, to
overcome problems on certain systems saving a
file when that filename already exists. Closes bug #25795
John Darrington [Tue, 7 Apr 2009 02:30:13 +0000 (10:30 +0800)]
Allow users to set the precision of output statistics.
Instead of hard coding the width and decimals of output
numbers, respect the default format in most instances.
Counts are normally displayed with the format of the weight
variable, if any. Closes patch #6785
John Darrington [Thu, 2 Apr 2009 00:19:09 +0000 (08:19 +0800)]
Fixed bug where piecharts with many segments crashed.
Make sure that we don't index beyond the bounds of the
data_colour array.
John Darrington [Tue, 31 Mar 2009 05:07:03 +0000 (13:07 +0800)]
Fixed bug writing portable files.
Don't append slash to sysmis values when writing portable
files. Fixes bug #26034
John Darrington [Tue, 24 Mar 2009 10:12:44 +0000 (19:12 +0900)]
Added #include <config.h> to files as appropriate.
Thanks to Michel Boaventura for reporting this problem.
John Darrington [Fri, 20 Mar 2009 01:27:46 +0000 (10:27 +0900)]
Fix corrupted .sav files on w32 builds
Added the O_BINARY flag to the mode of files
created with open, so that lines aren't appended
with extraneous characters, thus corrupting .sav
files.
John Darrington [Tue, 17 Mar 2009 21:56:53 +0000 (06:56 +0900)]
Correct typo in BINOMIAL section of user manual.
Thanks to Erik Frebold for pointing out this problem.
Closes bug #25892
John Darrington [Sun, 8 Mar 2009 01:47:48 +0000 (10:47 +0900)]
Fixed a bug reading empty strings from Postgres databases.
Fixed a bug in the Postgresql import feature, where a segfault
would occur when a reading a database which contained string
fields with only null, or zero length values.
Thanks to Joerg Schmengle for reporting this.
Jason Stover [Mon, 23 Feb 2009 16:14:45 +0000 (11:14 -0500)]
Fix bug 25677
John Darrington [Sun, 22 Feb 2009 07:36:40 +0000 (16:36 +0900)]
Prevent data sheet from traversing into an invalid column.
Thanks to James R. Van Zandt for reporting this problem.
John Darrington [Sat, 7 Feb 2009 22:51:13 +0000 (07:51 +0900)]
Relocate path names when searching for files.
When searching for configuration files etc. in a
search path, relocate the filenames before testing
for their existence. Closes bug #25508
John Darrington [Thu, 5 Feb 2009 23:01:22 +0000 (08:01 +0900)]
Silently ignore some inrecognised subtypes.
When reading system files, record subtypes of which the developers are
aware but which pspp doesn't yet support are silently ignored. Subtypes
which the developers are unaware provoke a message requesting the user
to send us a sample.
John Darrington [Wed, 12 Nov 2008 01:15:16 +0000 (10:15 +0900)]
Added a set of per binary LDFLAGS parameters.
Added two optional variables PSPP_LDFLAGS and PSPPIRE_LDFLAGS for the convenience of package creators who need to be able to pass flags to one program but not the other.
Ben Pfaff [Tue, 4 Nov 2008 03:49:08 +0000 (19:49 -0800)]
Use gnulib 'close' module, for compatibility with newest Gnulib.
Otherwise at link we get an undefined reference to symbol
_close_used_without_requesting_gnulib_module_close.
Thanks to Michel Boaventura for reporting the problem.
John Darrington [Sat, 1 Nov 2008 06:10:50 +0000 (15:10 +0900)]
Move definition of OUTPUT_FILE_NAME to before first use.
Problem manifested itself when building with cygwin.
Reported by unknown-1
John Darrington [Sat, 18 Oct 2008 02:50:52 +0000 (10:50 +0800)]
Marked CORRELATIONS and PEARSON CORRELATIONS as unimplemented.
These commands were defined in command.def, but only the parser
was actually implemented; they didn't actually do anything.
Marking them as unimplemented until they're finished.
John Darrington [Sat, 18 Oct 2008 01:09:47 +0000 (09:09 +0800)]
Added (source) configurable default output directory.
Some systems expect files to be dumped in the home directory
instead of the current directory. This change makes that
easier.
Ben Pfaff [Thu, 16 Oct 2008 03:48:15 +0000 (20:48 -0700)]
Fix crash in tabulating long-string variables in CROSSTABS.
Fixes bug #24557.
Ben Pfaff [Thu, 16 Oct 2008 03:39:57 +0000 (20:39 -0700)]
Do not assume that canonicalize_file_name() always returns non-null.
Fixes bug #24569.
Ben Pfaff [Tue, 14 Oct 2008 01:40:54 +0000 (18:40 -0700)]
Make src/libpspp/version.c depend on Makefile.
This ensures that re-running "configure" with different settings causes
version.c to be rebuilt.
Thanks to Ivy Foster <ivy.foster@gmail.com> for reporting the problem.
Ben Pfaff [Fri, 10 Oct 2008 04:32:35 +0000 (21:32 -0700)]
Update NEWS for 0.6.1.
John Darrington [Tue, 7 Oct 2008 11:40:56 +0000 (19:40 +0800)]
Fixed problems when building with --enable-relocatable
Added the INSTALLDIR macro to tests/dissect-sysfile.
Relocated the pathname of the splash screen graphic.
Ben Pfaff [Sun, 5 Oct 2008 18:17:10 +0000 (11:17 -0700)]
Use Gnulib module "regex", to fix linking on Mingw.
The GUI code uses POSIX regular expressions, which Mingw has in a separate
library (-lregex). We could just search for that library, but by including
our own implementation (via Gnulib) we also work around known bugs in
system regular expression implementations.
Ben Pfaff [Sat, 4 Oct 2008 04:21:28 +0000 (21:21 -0700)]
Update NEWS for 0.6.1-rc2.
Ben Pfaff [Sat, 4 Oct 2008 04:11:20 +0000 (21:11 -0700)]
Add ".sav" or ".por" suffix to filename when saving with Save_As
Closes bug #23137
(This is a cross-port of commit
169887f6d6d7bf5c10d5b05786aa3fd252040c93
from the master branch, originally authored and committed by John
Darrington.)
Ben Pfaff [Sat, 4 Oct 2008 03:59:44 +0000 (20:59 -0700)]
Only use -fgnu89-inline if the compiler actually supports it.
Jason Stover pointed out that we were using -fgnu89-inline even when the
compiler didn't support it. Obviously that's not good.
Ben Pfaff [Sat, 4 Oct 2008 04:01:50 +0000 (21:01 -0700)]
Also warn about missing prerequisites as we encounter them (bug #24445).
It can happen that configure bails out in the middle due to some issue
that PSPP cannot directly control; for example, AC_CHECK_SIZEOF exits
unconditionally if it fails. If this happens then, before, we would fail
to warn about missing required prerequisites that could well have been
the actual cause of the failure, because we only warn about these at
the end of the run.
Now, we warn about missing prerequisites both at time of detection and
in a summary at the end, to head off this problem.
Thanks to Jim Orr for allowing me to notice the problem.
Ben Pfaff [Sat, 4 Oct 2008 04:00:55 +0000 (21:00 -0700)]
Add note to INSTALL explaining how to use libraries from /usr/local.
Several users have had trouble building PSPP with self-built GSL, etc.
that were installed to /usr/local. Explain how to do it here to be
more friendly to Unix novices.
Thanks to Jim Orr for making me realize that this was important.
Ben Pfaff [Sat, 4 Oct 2008 03:54:28 +0000 (20:54 -0700)]
Add pspp-dev.dvi to CLEANFILES.
Automake does not seem to clean this file automatically. (Is this an
Automake bug?)
Ben Pfaff [Sat, 4 Oct 2008 03:53:51 +0000 (20:53 -0700)]
Append $(EXEEXT_FOR_BUILD) to output file name when building q2c.
Thanks to "Michel Boaventura" <michel.boaventura@gmail.com> for reporting
this problem and to John Darrington for assisting with the solution.
Ben Pfaff [Fri, 3 Oct 2008 03:42:23 +0000 (20:42 -0700)]
Update NEWS for 0.6.1 release.
John Darrington [Sun, 14 Sep 2008 13:29:53 +0000 (21:29 +0800)]
Don't append % to count totals.
There was an erroneous '%' appended to the totals for count
values. This change removes it. Fixes bug #24003
John Darrington [Sun, 14 Sep 2008 12:51:38 +0000 (20:51 +0800)]
Don't destroy dictionary on error if we didn't create it.
Avoid assertion failure on bad input. Closes bug #24031
John Darrington [Sun, 14 Sep 2008 08:57:10 +0000 (16:57 +0800)]
Fixed bug which caused a crash if "end data." was not left aligned.
John Darrington [Sat, 23 Aug 2008 00:59:00 +0000 (08:59 +0800)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
John Darrington [Sat, 23 Aug 2008 00:44:32 +0000 (08:44 +0800)]
Work around bug #24033 (appending to output in cygwin).
Cygwin (and perhaps other w32 platforms) cannot write to a file
whilst it is open for reading. This kludge therefore closes the
output after pasting into the output viewer and re-opens when new
data is appended. It'll be slow if the output file becomes large.
Ben Pfaff [Fri, 1 Aug 2008 03:47:49 +0000 (20:47 -0700)]
Start generating ChangeLog automatically from Git commit messages.
Thus, at the same time we rename the existing ChangeLog files to
OChangeLog and add them to EXTRA_DIST to make sure that they get
distributed.
Jason H Stover [Sun, 17 Aug 2008 21:40:15 +0000 (17:40 -0400)]
Estimate parameters. Moved some code to re-usable functions.
Jason H Stover [Sat, 16 Aug 2008 21:29:31 +0000 (17:29 -0400)]
Pointer DEPVAR is now required to be set correctly in linreg.c
Jason H Stover [Sat, 16 Aug 2008 21:26:37 +0000 (17:26 -0400)]
Initial versions of functions to estimate parameters
via the covariance matrix
John Darrington [Fri, 8 Aug 2008 01:13:07 +0000 (09:13 +0800)]
Initialise label for piechart slices.
(Closes bug #24014
John Darrington [Fri, 8 Aug 2008 01:08:18 +0000 (09:08 +0800)]
Bump minor version number so that git builds are distinct from released version
Ben Pfaff [Sun, 27 Jul 2008 18:12:45 +0000 (11:12 -0700)]
Use standard C99 isfinite, isnan, isinf in place of GSL substitutes.
In change
a9afcdd22, "Use gsl_isnan instead of isnan, ...," isfinite,
isnan, and isinf were changed to use the GSL substitutes because of
lack of portability of the C99 versions. Now, gnulib has portable
versions of all of these, so change them back.
This commit changes calls to gsl_finite() to call isfinite() instead
of the equivalent finite(). isfinite() is correct here: both gsl_finite()
and finite() return true for NaNs, which is a surprising result given
that a NaN is definitely not finite, but isfinite() returns false and,
more importantly, behaves as actually wanted in each place it is used
in PSPP code.
This commit requires upgrading gnulib to at least change
5183a0e3c,
"Add missing dependencies on new m4/exponent[fdl].m4 files," or later,
and re-running "make -f Smake".
John Darrington [Sun, 27 Jul 2008 01:02:42 +0000 (09:02 +0800)]
Constness
John Darrington [Sun, 27 Jul 2008 00:47:06 +0000 (08:47 +0800)]
Changed the default WORKSPACE value to 64MB.
Corrected documentation of WORKSPACE.
When --testing-mode is set, workspace can now be arbitrarily low.
Ben Pfaff [Sat, 26 Jul 2008 06:25:53 +0000 (23:25 -0700)]
New function for adding a numbering column to a casereader.
John Darrington [Sat, 26 Jul 2008 06:12:01 +0000 (14:12 +0800)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
Conflicts:
src/math/ChangeLog
John Darrington [Sat, 26 Jul 2008 05:47:40 +0000 (13:47 +0800)]
Merge with recent change by Jason.
John Darrington [Sat, 26 Jul 2008 05:36:03 +0000 (13:36 +0800)]
Removed the value_cnt associated with the caseordering
Made sure that sort_execute returns a casereader the same
dimensions as its subject.
Jason H Stover [Thu, 24 Jul 2008 21:53:50 +0000 (17:53 -0400)]
Dropped weight argument. Corrected update of entries of the covariance matrix
Jason H Stover [Tue, 22 Jul 2008 21:27:55 +0000 (17:27 -0400)]
No longer store entire data set in memory.
Accumulate covariance matrix using covariance_pass_two
John Darrington [Sun, 20 Jul 2008 12:25:15 +0000 (20:25 +0800)]
Why does git only commit some of the changes if you don't pass the -a flag?
John Darrington [Sun, 20 Jul 2008 12:16:05 +0000 (20:16 +0800)]
Deleted lib/gsl-extras and updated gsl dependence to 1.8
Jason H Stover [Thu, 17 Jul 2008 22:11:21 +0000 (18:11 -0400)]
Recurse to simplify flow of covariance_pass_two(). Move tests for V2 into for loop.
Jason Stover [Wed, 16 Jul 2008 22:28:31 +0000 (18:28 -0400)]
Merge branch 'master' of ssh://jstover@git.sv.gnu.org/srv/git/pspp
Jason Stover [Wed, 16 Jul 2008 22:27:27 +0000 (18:27 -0400)]
Fixed update of covariance matrix when both variables are categorical.
Added function to access counted categories.
Ben Pfaff [Wed, 16 Jul 2008 17:18:35 +0000 (10:18 -0700)]
Make PSPP_LINK2_IFELSE macro work with Autoconf earlier than 2.62.
Jason Stover [Wed, 16 Jul 2008 22:22:33 +0000 (18:22 -0400)]
Fixed updating of covariance matrix when both variables
are categorical. Reported by John Darrington
Jason Stover [Wed, 16 Jul 2008 02:54:36 +0000 (22:54 -0400)]
Added functions to compute covariance matrix.
Ben Pfaff [Sun, 13 Jul 2008 18:17:22 +0000 (11:17 -0700)]
Autodetect and fix GSL use of GCC-style "extern inline".
Ben Pfaff [Sun, 6 Jul 2008 00:07:16 +0000 (17:07 -0700)]
Enable users of dist tarballs to use --enable-gui-tools.
Formerly, we didn't distribute the necessary files.
Ben Pfaff [Sun, 6 Jul 2008 00:06:28 +0000 (17:06 -0700)]
Remove 'de' from LINGUAS and delete po/de.po.
Suggested by Andreas Streichardt <mop@globalpark.de>, who points out
that the poor German translations annoy German users.
Ben Pfaff [Sun, 6 Jul 2008 01:17:56 +0000 (18:17 -0700)]
Remove obsolete .gitignore entries.
Ben Pfaff [Sun, 6 Jul 2008 01:11:22 +0000 (18:11 -0700)]
Remove files from .gitignore that are specific to blp's workflow.
These files to ignore are supposed to be listed in the user's
core.gitexcludes file (see gitignore(5)), not in the repository's
.gitignore files.
Ben Pfaff [Sun, 6 Jul 2008 00:55:38 +0000 (17:55 -0700)]
Rename .cvsignore files to .gitignore.
Thus, Git will now ignore the same files that CVS did.
Jason Stover [Sun, 22 Jun 2008 02:44:27 +0000 (22:44 -0400)]
Fixed bug 23567. Added accessor functions to get/set means and standard deviations for variables associated with struct coeffs. Fixed corresponding values in tests.
Jason Stover [Sat, 14 Jun 2008 19:38:24 +0000 (15:38 -0400)]
removed src/math/linreg/
Jason Stover [Sat, 14 Jun 2008 19:35:03 +0000 (15:35 -0400)]
moved src/math/linreg.[ch] to src/math
Ben Pfaff [Sat, 14 Jun 2008 05:29:23 +0000 (22:29 -0700)]
Fix typo in AC_PREREQ command name.
Ben Pfaff [Mon, 9 Jun 2008 03:55:41 +0000 (03:55 +0000)]
Final changes for 0.6.0 release.
John Darrington [Sat, 7 Jun 2008 04:55:22 +0000 (04:55 +0000)]
Updated about dialog text.
John Darrington [Sat, 7 Jun 2008 04:42:57 +0000 (04:42 +0000)]
Updated authors' contributions.
John Darrington [Thu, 29 May 2008 11:07:28 +0000 (11:07 +0000)]
Fixed bugs which manifested themselves as bus errors on solaris.