John Darrington [Sun, 31 Jul 2016 13:47:06 +0000 (15:47 +0200)]
Fix memory leak in test program
John Darrington [Sat, 30 Jul 2016 14:09:18 +0000 (16:09 +0200)]
Fix possible crash if no buttons are active (should never be the case)
Found by cppcheck
John Darrington [Sat, 30 Jul 2016 14:08:00 +0000 (16:08 +0200)]
Remove unused variable.
Found by cppcheck.
John Darrington [Sat, 30 Jul 2016 05:19:40 +0000 (07:19 +0200)]
Remove PsppireVButtonBox and PsppireHButtonBox
Instead, use the orientable property of the ancester GtkButtonBox
Ben Pfaff [Wed, 27 Jul 2016 03:39:24 +0000 (20:39 -0700)]
range-set-test: Remove special case for llvm-gcc on Mac OS.
According to Jeremy Lavergne, recent llvm-gcc doesn't have the same bug.
Ben Pfaff [Mon, 25 Jul 2016 18:13:58 +0000 (11:13 -0700)]
Increment version number to 0.10.3.
John Darrington [Sat, 23 Jul 2016 07:03:58 +0000 (09:03 +0200)]
Allow the variable info dialog to paste more than one variables.
Fixes bug #48596
John Darrington [Thu, 14 Jul 2016 18:35:51 +0000 (20:35 +0200)]
Fix compiler warning on gcc 5.4
John Darrington [Mon, 11 Jul 2016 19:51:42 +0000 (21:51 +0200)]
Replace gtk_widget_get_style in favour of gtk_widget_get_style_context
John Darrington [Mon, 11 Jul 2016 18:51:18 +0000 (20:51 +0200)]
Logistic Regression syntax generator: replace ds_data with ds_cstr
ds_data does not produce a terminating null. So garbage could be appended at the end of the command.
Fixes bug #48467
John Darrington [Thu, 7 Jul 2016 05:07:05 +0000 (07:07 +0200)]
Update NEWS
John Darrington [Thu, 23 Jun 2016 08:07:23 +0000 (10:07 +0200)]
Fixed GLM vs. missing values in the dependent variable
John Darrington [Thu, 23 Jun 2016 07:13:53 +0000 (09:13 +0200)]
Fixed typo in comment
John Darrington [Wed, 22 Jun 2016 05:09:58 +0000 (07:09 +0200)]
Avoid link error when compiling without libxml2 installed
John Darrington [Sun, 19 Jun 2016 11:36:48 +0000 (13:36 +0200)]
Update the Gnulib version
The primary motive for doing this is to update gl/version_etc which changes
the copyright year to 2016. This is the value which gets displayed by --version
I do not think it is ideal that we must update gnulib to get the current year
in our version string, but I did not design this aspect of the code.
John Darrington [Sun, 12 Jun 2016 07:03:33 +0000 (09:03 +0200)]
Fixed a small bug in te variable info dialog.
Friedrich Beckmann [Wed, 8 Jun 2016 18:22:00 +0000 (20:22 +0200)]
added FREQUENCIES regression test for bug#48128
FREQUENCIES command crashed in a combination of /histogram /percentiles
and /statistics option. This was fixed in commit 86642e. Here a crash
test is added exactly for this situation.
John Darrington [Tue, 7 Jun 2016 18:44:13 +0000 (20:44 +0200)]
src/output.tab.c: Format according to Gnu Coding Standards
Friedrich Beckmann [Sat, 4 Jun 2016 22:44:26 +0000 (00:44 +0200)]
tab.c: Compile error in debug mode
tab.c could not be compile with --enable-debug configuration because
the return value did not fit with the function. In addition a typo in
a "bad cell" check was fixed.
Friedrich Beckmann [Sat, 4 Jun 2016 22:41:05 +0000 (00:41 +0200)]
frequencies: fixed bug #48128 in percentiles
The frequencies command crashed with a certain combination of
percentiles and histogram options. The bug was reported by
Cubyrk Zyrvay in
http://lists.gnu.org/archive/html/bug-gnu-pspp/2016-06/msg00000.html
Closes bug #48128
John Darrington [Sun, 29 May 2016 08:48:24 +0000 (10:48 +0200)]
Recode Dialog Action: Split into RecodeDialogAction, RecodeDialogActionSame and RecodeDialogActionDifferent
Friedrich Beckmann [Sun, 29 May 2016 20:18:04 +0000 (22:18 +0200)]
NEWS: added online help feature and T-Test gui bug for 0.10.2 version
Friedrich Beckmann [Sat, 28 May 2016 09:42:30 +0000 (11:42 +0200)]
help-menu.c: start the default html browser via wscript instead of cmd
Harry mentioned that starting help via cmd shows the command window for
a short time on windows. With this patch the default html browser is
started via wscript instead of cmd /C <uri>.
Unfortunatly the nice function g_app_info_launch_default_for_uri does
not work, at least on osx and windows.
John Darrington [Sat, 28 May 2016 06:01:54 +0000 (08:01 +0200)]
Whitespace changes only
John Darrington [Sat, 28 May 2016 05:59:57 +0000 (07:59 +0200)]
Independent Samples Gui: Make the on_grp_var function and associated code less naive.
Addresses bug #48015
Friedrich Beckmann [Thu, 26 May 2016 11:05:33 +0000 (13:05 +0200)]
help-menu.c: fix default html browser start on windows - correct uri
commit #6c9aaa introduced calling the default html browser in case the
yelp system is not available on the system. This patch fixes a
problem on WINDOWS, where the browser did not open. The problem is
that on windows the "start" command is not a regular executable but
a part of the cmd shell. So the executable that has to be called is
"cmd" with start as a parameter to execute. There is an additional
problem on windows that the "Program Files" directory contains a
space in the path name. For a proper uri, this has to be
translated to Program%20Files. This is done via the
g_filename_to_uri function.
Friedrich Beckmann [Mon, 23 May 2016 20:00:38 +0000 (22:00 +0200)]
scatterplot: changed colorscheme - first color is black - fixes bug#47806
The default data colour palette choses light colors (yellow). This patch
selects black if no BY variable is selected for the scatterplot. Having
a special colour palette for scatterplot will interfere with the legend
coloring scheme. That would need more changes to have data points and
legend having the same color palette.
Friedrich Beckmann [Mon, 23 May 2016 15:51:54 +0000 (17:51 +0200)]
added help function via html if yelp is not installed
The current help system requires yelp to be installed. This patch
will fallback to local html help and then internet html help via
http://www.gnu.org/software/pspp if no html is installed. The browser
is invoked via open (MAC), start (windows) and xdg-open (linux)
Friedrich Beckmann [Sun, 22 May 2016 22:11:53 +0000 (00:11 +0200)]
Revert "adding osx application bundler scripts"
This reverts commit
c2c8832630ad1619cd8e1769da3a294a1d35d1ed.
This interferes with distribution check...
Friedrich Beckmann [Sun, 22 May 2016 21:01:37 +0000 (23:01 +0200)]
adding osx application bundler scripts
This adds a utility script which produces a mac application bundle
based on the macports installation of pspp. The application bundle
can then be distributed as a single file and can be installed exactly
like a usual mac application. This is easier for mac users as they
do not need to install XCode, macports, XQuartz but just this package.
John Darrington [Thu, 21 Apr 2016 10:39:36 +0000 (12:39 +0200)]
Fix bug in syntax parser of GET DATA /TYPE=TXT
Fixed a bug which manifested itself when GET DATA /TYPE=TXT was
passed a variable name which happened also to be a token identifier.
The actual bug might also have caused other ill effects, but seems
to have been masked.
Reported-by: Rob L
John Darrington [Mon, 11 Apr 2016 17:12:59 +0000 (19:12 +0200)]
Fix compiler warning
Ben Pfaff [Mon, 11 Apr 2016 01:50:12 +0000 (18:50 -0700)]
CROSSTABS: Implement COUNT subcommand to round case or cell weights.
Bug #47547.
Requested by Harry Thijssen.
Ben Pfaff [Mon, 11 Apr 2016 00:45:13 +0000 (17:45 -0700)]
tests: Fix error message when using a wrapper for the first time.
Ben Pfaff [Mon, 11 Apr 2016 00:44:53 +0000 (17:44 -0700)]
FILE HANDLE: Get rid of use of q2c preprocessor.
John Darrington [Sat, 9 Apr 2016 08:20:23 +0000 (10:20 +0200)]
Change warning about test versions.
The consensus was that this warning was too strong. These change makes
it somewhat weaker.
John Darrington [Wed, 6 Apr 2016 07:38:56 +0000 (09:38 +0200)]
Fixed crash on FLIP vs. invalid variable names.
FLIP would crash if the designated new names were not
valid names. For example "TO", "BY", "" etc.
Found by zzuf.
John Darrington [Tue, 5 Apr 2016 19:08:50 +0000 (21:08 +0200)]
Fixed a crash when data for correlations was empty.
Found by zzuf.
John Darrington [Tue, 5 Apr 2016 18:01:35 +0000 (20:01 +0200)]
Add test for PERMISSIONS with bad syntax
John Darrington [Mon, 4 Apr 2016 11:42:21 +0000 (13:42 +0200)]
Fix crash in T-Test after parsing a null terminated string.
Found by zzuf.
Ben Pfaff [Sun, 3 Apr 2016 18:52:55 +0000 (11:52 -0700)]
tests: Fix a deeper bug in null byte check in testsuite.
Thanks to Jeremy Lavergne for reporting the problem.
Ben Pfaff [Sun, 3 Apr 2016 18:20:27 +0000 (11:20 -0700)]
tests: Fix bug in null byte check in testsuite.
Thanks to Jeremy Lavergne for reporting the problem.
Ben Pfaff [Sun, 3 Apr 2016 03:50:51 +0000 (20:50 -0700)]
Update version number to 0.10.2.
Ben Pfaff [Sun, 3 Apr 2016 03:37:15 +0000 (20:37 -0700)]
Release PSPP 0.10.1.
Ben Pfaff [Sun, 3 Apr 2016 00:53:52 +0000 (17:53 -0700)]
lexer: Treat null characters in input as spaces.
In some circumstances nulls could confuse the lexer and cause crashes.
Thanks to John Darrington for reporting the problem.
Bug #47602.
Ben Pfaff [Sat, 2 Apr 2016 23:41:13 +0000 (16:41 -0700)]
lexer: Add comments and update style in lex_source_get__().
Ben Pfaff [Sat, 2 Apr 2016 18:09:15 +0000 (11:09 -0700)]
CROSSTABS: Fix corner case in integer mode.
I'm not really sure what I was thinking when I wrote this code, but the
off-by-one errors could cause a crash.
Thanks to John Darrington for reporting the problem.
Bug #47600.
John Darrington [Sat, 2 Apr 2016 08:21:09 +0000 (10:21 +0200)]
Documentation: Update copyright notice to reflect recent changes
John Darrington [Sat, 2 Apr 2016 04:01:43 +0000 (06:01 +0200)]
Fix date format tests when running under wine
Ben Pfaff [Sat, 2 Apr 2016 03:12:29 +0000 (05:12 +0200)]
Replace valgrind-wrapper with a generic wrapper.
One potential use is to run tests under an emulator such as wine.
John Darrington [Fri, 1 Apr 2016 13:38:37 +0000 (15:38 +0200)]
lexer.h: Add WARN_UNUSED_RESULT to lex_force functions.
There does not seem to be any sensible and safe use of these
functions unless the return value is used somehow.
John Darrington [Fri, 1 Apr 2016 10:16:15 +0000 (12:16 +0200)]
Check the return value of various calls to lex_force_match.
John Darrington [Fri, 1 Apr 2016 09:44:17 +0000 (11:44 +0200)]
output.c: cmd_output: Check return values of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:37:02 +0000 (11:37 +0200)]
variable-display.c (cmd_variable_level): Check return value of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:30:44 +0000 (11:30 +0200)]
value-parser.c (parse_number): Simplified logic and removed redundant lines.
John Darrington [Thu, 31 Mar 2016 20:27:52 +0000 (22:27 +0200)]
Fix crash in NPAR when no variables were parsed.
Found by zzuf.
John Darrington [Thu, 31 Mar 2016 19:57:17 +0000 (21:57 +0200)]
Fix typo in NEWS
John Darrington [Thu, 31 Mar 2016 19:51:25 +0000 (21:51 +0200)]
Fixed a bug where frequencies/histogram would crash when all data had missing wieghts.
Found by zzuf.
Ben Pfaff [Thu, 31 Mar 2016 19:44:24 +0000 (12:44 -0700)]
po: Update Dutch translation.
John Darrington [Thu, 31 Mar 2016 08:19:07 +0000 (10:19 +0200)]
Updated NEWS to mention bugs fixed in command parser
John Darrington [Thu, 31 Mar 2016 08:14:05 +0000 (10:14 +0200)]
Fix crash when ROC was passed a non-number where a number was expected.
Found by zzuf.
John Darrington [Thu, 31 Mar 2016 07:19:35 +0000 (09:19 +0200)]
Fixed by where pspp would crash if ELSE appeared without a DO IF.
Found by zzuf.
John Darrington [Thu, 31 Mar 2016 06:22:44 +0000 (08:22 +0200)]
Fixed a bug where INSERT would crash when an unterminated string was given.
Found by zzuf.
Ben Pfaff [Thu, 31 Mar 2016 15:14:52 +0000 (08:14 -0700)]
po: Update German translation from translationproject.org.
John Darrington [Thu, 31 Mar 2016 12:44:57 +0000 (14:44 +0200)]
Fix crash when ONEWAY/CONTRASTS contained an empty list.
Found by zzuf.
John Darrington [Wed, 30 Mar 2016 15:42:44 +0000 (17:42 +0200)]
PsppireSelector: Do not add a default selector func, if an explicit one already exists
Fixes bug #47573.
John Darrington [Wed, 30 Mar 2016 06:17:48 +0000 (08:17 +0200)]
Fixed crash when processing malformed NPAR TESTS BINOMIAL command.
Found by zzuf.
Ben Pfaff [Wed, 30 Mar 2016 15:34:06 +0000 (08:34 -0700)]
po: Update Lithuanian translation.
John Darrington [Wed, 30 Mar 2016 10:04:54 +0000 (12:04 +0200)]
Avoid possible memory allocation error on erroneous input.
Valgrind showed a possible problem here.
John Darrington [Tue, 29 Mar 2016 11:17:25 +0000 (13:17 +0200)]
Cleanup the RENAME VARIABLES command.
Also fix some crashes which occured on invalid syntax.
Friedrich Beckmann [Tue, 29 Mar 2016 00:11:59 +0000 (02:11 +0200)]
use fixed format string to avoid -Wformat-security warning
The debian build fails due to the -Wformat-security check. This
change replaces a variable format string with a fixed format
string.
Ben Pfaff [Mon, 28 Mar 2016 15:31:46 +0000 (08:31 -0700)]
po: Update translations from translationproject.org.
John Darrington [Sun, 27 Mar 2016 11:51:53 +0000 (13:51 +0200)]
Fixed bug in EXAMINE where the parametric calculation would crash if the weight
variable contained a missing value.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 17:34:02 +0000 (18:34 +0100)]
Fix bug in EXAMINE when an invalid dependent variable was specified.
Found by zzuf.
John Darrington [Sun, 27 Mar 2016 06:11:38 +0000 (08:11 +0200)]
Update NEWS to keep make dist happy
John Darrington [Sun, 27 Mar 2016 05:08:20 +0000 (07:08 +0200)]
Update version number to 0.10.1
Ben Pfaff [Sat, 26 Mar 2016 17:30:51 +0000 (10:30 -0700)]
Update version number to 0.10.0.
John Darrington [Sat, 26 Mar 2016 16:36:59 +0000 (17:36 +0100)]
Fix bug in GRAPH when a bad dependent variable was specified.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 15:57:16 +0000 (16:57 +0100)]
Fix crash in FLIP with no variables.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 15:34:20 +0000 (16:34 +0100)]
Fix double heap deallocation when erroneous SET was specified.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 15:13:50 +0000 (16:13 +0100)]
Fixed crash in MODIFY OUTPUT when no valid FORMAT clause was specified.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 14:22:47 +0000 (15:22 +0100)]
Fix crash in oneway when an invalid dependent variable was specified.
Found by zzuf
John Darrington [Sat, 26 Mar 2016 07:48:14 +0000 (08:48 +0100)]
Fix crash in recode when the INTO variable was invalid.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 07:17:37 +0000 (08:17 +0100)]
Fix assertion failure when using PRINT with an empty argument.
Found by zzuf.
John Darrington [Fri, 25 Mar 2016 20:25:49 +0000 (21:25 +0100)]
Fix crash in ROC command when no valid state variable is given.
Found by zzuf.
John Darrington [Fri, 25 Mar 2016 19:13:46 +0000 (20:13 +0100)]
Fix crash when no indepdendent variable in NPAR is given.
Found by zzuf.
John Darrington [Fri, 25 Mar 2016 13:16:03 +0000 (14:16 +0100)]
Fix crash in DATA LIST when RECORDS and/or SKIP is negative
Found by zzuf
John Darrington [Fri, 25 Mar 2016 10:16:22 +0000 (11:16 +0100)]
Fix crash in LIST when no valid variables exist.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 22:13:18 +0000 (23:13 +0100)]
Fix crash in histogram when all values are missing.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 20:07:04 +0000 (21:07 +0100)]
Fix crash when running GET DATA with incomplete command.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 19:30:36 +0000 (20:30 +0100)]
Fixed crash in T-TEST when a non-number was passed where a number was expected.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 19:07:11 +0000 (20:07 +0100)]
Fix crash in correlations with empty dataset.
Found by zzuf.
John Darrington [Sun, 20 Mar 2016 19:41:14 +0000 (20:41 +0100)]
Provide an environment where cross-compiled tests can run in an emulator
This change allows some of the tests to run successfully under wine when
cross-compiled with mingw
John Darrington [Sun, 20 Mar 2016 18:34:34 +0000 (19:34 +0100)]
Prevent link error when cross compiling with mingw
John Darrington [Sun, 13 Mar 2016 08:54:36 +0000 (09:54 +0100)]
spreadsheet-reader.c: Do not export local symbols
Ben Pfaff [Sun, 20 Mar 2016 16:49:26 +0000 (09:49 -0700)]
SORT VARIABLES: Add test.
This should have been in the initial commit; sorry.
John Darrington [Sun, 20 Mar 2016 06:37:08 +0000 (07:37 +0100)]
README.Git: Update required Texinfo version
It seems that older makeinfo does not correctly generate the docbook format. Thanks to
Harry for finding this.
Ben Pfaff [Sun, 20 Mar 2016 00:19:45 +0000 (17:19 -0700)]
Implement new command SORT VARIABLES.
John Darrington [Sat, 19 Mar 2016 18:41:35 +0000 (19:41 +0100)]
Fix error in dist-hook-git.
The previous commit introduced a new "meta" file. But it provoked our test for
missing distribution files. This change fixes that.
John Darrington [Fri, 18 Mar 2016 10:14:20 +0000 (11:14 +0100)]
Added a "meta" file, explaining administrative procedures for bug handling